Re: Overuse of AssumedStale Issue Tag
I think Thomas's comments on http://code.google.com/p/google-web-toolkit/issues/detail?id=6962 and the spring cleaning thing say it all on the attitude of GWT devs toward bug reports: they are just an annoyance and the fact that the issue tracker has a lot of very old reports (not even considered for years) is just the reporters' fault. After all, GWT is quite perfect as is and many supposed bugs should have fixed themselves during the years, or are just invalid. Feel free to provide patches, although they probably won't be reviewed at all, since your reports usually just matter to you and few others. I'm really sad :-( Mauro. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: GWT dev team members blogs and way-of-work (WOW) advice ?
IMHO having lots of blog posts for a given library somehow indicates that the library API is either too complex or documentation isn't good enough...well...or both. Not IMHO, for 2 reaons: 1) As a marketing tool. Blog posts and HowTo's are used a lot by TrendSetters and other interesting Software development websites. Blog posts shows activity, movement and exposure... 2) There many different kind of developers and there are developers that find easy things very difficult (I am often surprised by the forum questions). If you want these developers to use your product, and to motivate them you have to have all kind of HowTo's, blog posts (have a look at commercial products where they are more commercial driven and have this by default). (you can make the most amazing product, but if nobody know about it, nor how to use it, it will never be a success) -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Overuse of AssumedStale Issue Tag
Mauro, I have the same feeling. It seems like nothing has changed since GWT being detached from Google. After years of neglecting the loyal developers, who devoted time to report issues that were bugging us, we just got slapped in the face. We are now officially allowed to fix the bugs ourselves - and maybe after spending our free time on this, just maybe they will take our fixes. This attitude does not give me a lot of confidence that GWT is going the right direction, so I will probably be holding off in advocating GWT as a dependable tool for enterprise developments. Bug fixes are way more important than new functionality. We have to support our software for 10 years, we need to be able to depend on a professional attitude towards bug fixing. Look at the code base now: - 4 different ways of handling events (Listeners, Handlers and 2 event bus implementations - which should I choose ?). - CssResources are not really usable with style dependent naming as used in most of the widgets so I need to mark as NonStrict or use @external all over the place. - GWT RPC is not fast enough and causes stackoverflow and slow script warnings (well after years of waiting that bug will be resolved by moving to IE9). - DeRPC was supposed to fix the deficiencies of RPC but it got scrapped - RequestFactory is the new kid in town, but let's face it, it is no that easy to start with because we are not all pushing JPA Objects straight to the browser. We have our own JDBC layer that works much faster than most JPA compliant implementations. - LayoutPanels vs regular panels, watch out when mixing. - No full featured table implementation. - No CellTree (basically a big lack of decent components that are completely inline with all optimisations that GWT allows) - ... I'm sure others can add to this list, this is just the first things that comes to mind. and those are just the first things that comes to mind. David On Tue, Jun 4, 2013 at 9:06 AM, Mauro Molinari mauro...@tiscali.it wrote: I think Thomas's comments on http://code.google.com/p/google-web-toolkit/issues/detail?id=6962 and the spring cleaning thing say it all on the attitude of GWT devs toward bug reports: they are just an annoyance and the fact that the issue tracker has a lot of very old reports (not even considered for years) is just the reporters' fault. After all, GWT is quite perfect as is and many supposed bugs should have fixed themselves during the years, or are just invalid. Feel free to provide patches, although they probably won't be reviewed at all, since your reports usually just matter to you and few others. I'm really sad :-( Mauro. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Dynamically generated HTML and GWT
Jens, They way I use the widgets, maybe not supported, work perfectly. It is made part of the widget hierarchy. And when I remove the widget, everything is again cleaned up. I did a lot of memory leak investigating and it is just working the way it should. Even if the window close event is triggered, they get properly cleaned up just like the rest of the widget hierarchy. The wrap methods on Widget assume and do too much and that makes them not usable beyond the scope of wrapping non nested widgets. David On Mon, Jun 3, 2013 at 5:26 PM, Jens jens.nehlme...@gmail.com wrote: From my experimentation with wrap() I can see very few circumstances in which case it is actually useful. It appears to be useful where there is only one page. The way nesting of widgets is handled would make it tricky in anything more complicated. Yes, imagine a login application. Its UI is pretty easy and you could design it right in your host html page, so no RootPanel, no LayoutPanels, etc. If you want to do any useful with it you would get a handle to these DOM elements and now you can decide if you want to work with the low level element API or if you want the higher level Widget API by using any existing *.wrap() method to attach GWT widgets to these elements. These widgets created by *.wrap() do not have any parent widgets and will cleanup themselves once you leave the login page. So IMHO its indeed for simple use cases. There are probably a good reasons why you can not wrap elements that are already managed by a widget. E.g. if you remove the widget, what would happen to the wrapped widget then? -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Overuse of AssumedStale Issue Tag
Il 04/06/2013 09:24, David ha scritto: This attitude does not give me a lot of confidence that GWT is going the right direction, so I will probably be holding off in advocating GWT as a dependable tool for enterprise developments. Bug fixes are way more important than new functionality. We have to support our software for 10 years, we need to be able to depend on a professional attitude towards bug fixing. I totally agree with this. - ... I'm sure others can add to this list, this is just the first things that comes to mind. I also struggled with many of the points you are listing. I would add this: they are going to remove the dev mode and the browser plugins. Hence, no more way to debug in Java, but rely on the dramatically fast (!? takes dozen minutes to compile a bunch of modules on my machine...) GWT draft compilation and the JavaScript debugger of your browser (i.e.: Chrome, since it's the only one that supports many features needed for this purpose), alias super dev mode. This also scares me and IMHO cancels one of the main GWT strengths (the ability to debug code using the excellent Java tooling out there). Mauro. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Overuse of AssumedStale Issue Tag
@David, @Mauro, I am surprised and disappointed by your reactions. My reaction on this all: Please be positive and not so negative. Clearly your glass is half empty and mine is half full (and I am using GWT for about 7 years now)... Please follow the GWT news, G+ GWT posts, Ray Google 2013 GWT session, the issues being solved blazing fasts currently..., the contributor forum, etc... I am sure that if you follow these sources, your glass will be half full as well. If not, please see a doctor ;)... @David: your list of negative points is incorrect as I am building huge gwt projects and don't have this experience of 80% of your issues. So you might want to consider refactoring/reviewing your code/GWT usage. GWT had a tough year putting all pieces in place, but I think things look very promising which they are showing if you follow the above sources... -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Overuse of AssumedStale Issue Tag
Il 04/06/2013 09:50, Ed ha scritto: I am surprised and disappointed by your reactions. My reaction on this all: Please be positive and not so negative. Clearly your glass is half empty and mine is half full (and I am using GWT for about 7 years now)... Please follow the GWT news, G+ GWT posts, Ray Google 2013 GWT session, the issues being solved blazing fasts currently..., the contributor forum, etc... It's hard to be positive when: - you have starred about 10 issues which received no updates for months/years, some of which are so critical that it's surprising they never got fixed - you now see your starred issues closed as AssumedStale one by one, without any evaluation or feedback either - you ask for clarifications and you are said that you're the only one interested on those non-bugs - you are said that it's a waste of time to review your bug reports Mauro. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Overuse of AssumedStale Issue Tag
Ed, You are right that my glass is half empty, but that is just my character ;-) I've been using GWT since it was first introduced, I loved it straight away - coming from a Motif/JBuilder/Swing background. I am still hoping that they manage to get this back on-track, but I just hope that they put a little more focus on bug-fixing. It is really frustrating that about all the issues I ever reported where put on assumed stale. I spend a lot of time to detect and report these. In the mean time I have worked around many of them (JSNI to the rescue!) and I guess a lot of other people have done the same. But for new people starting out with GWT, this is not easy. You might now have experienced the same issues, but all applications stress the browsers differently. We need to send a lot of data over RPC and that was just plain bad on older IE. Our software runs over fast networks, so the bandwidth is not the issue. But the browser limitations in IE7/8 were. I moved on to JSON for my RPC needs and it moved from minutes to less than a second in some cases. David On Tue, Jun 4, 2013 at 9:50 AM, Ed post2edb...@gmail.com wrote: @David, @Mauro, I am surprised and disappointed by your reactions. My reaction on this all: Please be positive and not so negative. Clearly your glass is half empty and mine is half full (and I am using GWT for about 7 years now)... Please follow the GWT news, G+ GWT posts, Ray Google 2013 GWT session, the issues being solved blazing fasts currently..., the contributor forum, etc... I am sure that if you follow these sources, your glass will be half full as well. If not, please see a doctor ;)... @David: your list of negative points is incorrect as I am building huge gwt projects and don't have this experience of 80% of your issues. So you might want to consider refactoring/reviewing your code/GWT usage. GWT had a tough year putting all pieces in place, but I think things look very promising which they are showing if you follow the above sources... -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Dynamically generated HTML and GWT
They way I use the widgets, maybe not supported, work perfectly. It is made part of the widget hierarchy. And when I remove the widget, everything is again cleaned up. I did a lot of memory leak investigating and it is just working the way it should. Even if the window close event is triggered, they get properly cleaned up just like the rest of the widget hierarchy. The wrap methods on Widget assume and do too much and that makes them not usable beyond the scope of wrapping non nested widgets. Interesting, then they maybe decide to implement it the safe way so they don't have to think about that case when they want to change Widget internals. -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Overuse of AssumedStale Issue Tag
@Ed I really hope you are right... but so far I've had the same feelings of Mauro and David I guess some discouragement/vexation could be avoided adding an explanatory comment before or contextually tagging an issue as *AssumedStale*, and especially avoid stating I spent more than half an hour reading the code and the specs and doing tests. We can't realistically spend as many time on each and every opened issue. That really makes me wonder... On Tuesday, June 4, 2013 9:50:15 AM UTC+2, Ed wrote: @David, @Mauro, I am surprised and disappointed by your reactions. My reaction on this all: Please be positive and not so negative. Clearly your glass is half empty and mine is half full (and I am using GWT for about 7 years now)... Please follow the GWT news, G+ GWT posts, Ray Google 2013 GWT session, the issues being solved blazing fasts currently..., the contributor forum, etc... I am sure that if you follow these sources, your glass will be half full as well. If not, please see a doctor ;)... @David: your list of negative points is incorrect as I am building huge gwt projects and don't have this experience of 80% of your issues. So you might want to consider refactoring/reviewing your code/GWT usage. GWT had a tough year putting all pieces in place, but I think things look very promising which they are showing if you follow the above sources... -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Overuse of AssumedStale Issue Tag
Of course I recognize the pain and a few weeks ago I have to admit I was less positive then now.. But in the mean time many things have happened, issues are being fixxed as we speak... Yes, I also have a lo of issues that are put on AssumedStale... But that means they get a lower priority, not that they are forgotten!.. Please put yourself in their position (GWT dev member)... Imagine you just entered the GWT dev team and have to clean up 5000 open issues ?... What would you do ?... Of course it's a bad thing that it got this far, but taken as it is, Google had their own private gwt issue tracker and hardly used the public issue tracker (follow the sources please)... All these things have changed, contributors are joining the gwt development and things are being picked up quicker then before... Patient please, see it as GWT just started as it's completely different thing now.. I understand your complaints, but please turn them around in help... The way things are setup now, it's very easy to contribute code to to the Trunc, others will review it, and accepted (if your lucky ;)... This setup certainly invites me (and others) to do this... Like mentioned, every body stresses/usages the browser differently, that results in different kind of issues. As such, it might be hard that your issues get attention. The more reason to pick them up yourself and contribute (in the past contributing was hard, as google had strict rules, that all changed now)... BTW: this is nothing... Hibernate is/was much worse ;)... The Hibernate dev team would hammer you down ;) On Tue, Jun 4, 2013 at 10:15 AM, David david.no...@gmail.com wrote: Ed, You are right that my glass is half empty, but that is just my character ;-) I've been using GWT since it was first introduced, I loved it straight away - coming from a Motif/JBuilder/Swing background. I am still hoping that they manage to get this back on-track, but I just hope that they put a little more focus on bug-fixing. It is really frustrating that about all the issues I ever reported where put on assumed stale. I spend a lot of time to detect and report these. In the mean time I have worked around many of them (JSNI to the rescue!) and I guess a lot of other people have done the same. But for new people starting out with GWT, this is not easy. You might now have experienced the same issues, but all applications stress the browsers differently. We need to send a lot of data over RPC and that was just plain bad on older IE. Our software runs over fast networks, so the bandwidth is not the issue. But the browser limitations in IE7/8 were. I moved on to JSON for my RPC needs and it moved from minutes to less than a second in some cases. David On Tue, Jun 4, 2013 at 9:50 AM, Ed post2edb...@gmail.com wrote: @David, @Mauro, I am surprised and disappointed by your reactions. My reaction on this all: Please be positive and not so negative. Clearly your glass is half empty and mine is half full (and I am using GWT for about 7 years now)... Please follow the GWT news, G+ GWT posts, Ray Google 2013 GWT session, the issues being solved blazing fasts currently..., the contributor forum, etc... I am sure that if you follow these sources, your glass will be half full as well. If not, please see a doctor ;)... @David: your list of negative points is incorrect as I am building huge gwt projects and don't have this experience of 80% of your issues. So you might want to consider refactoring/reviewing your code/GWT usage. GWT had a tough year putting all pieces in place, but I think things look very promising which they are showing if you follow the above sources... -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/5aNsIcPKDm4/unsubscribe?hl=en . To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To
Re: Overuse of AssumedStale Issue Tag
Wouldn't be cool that many gwt developers (like us) would get permission of their boss/manager to contribute about 2 hours to GWT ? Imagine that around 100 developers around the world would do that? - 200 hours/week of GWT extra development time ;)... I am certain many issues get fixxed ;) To my experience, may bosses don't mind and put it under research development -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Overuse of AssumedStale Issue Tag
Il 04/06/2013 10:36, Ed Bras ha scritto: Please put yourself in their position (GWT dev member)... Imagine you just entered the GWT dev team and have to clean up 5000 open issues ?... What would you do ?... I would start to evaluate them to see if they need a fix or not, and put a priority on them. Unless you think the reporters are all happy to waste their time to open tickets, I think that those bugs were opened for a reason. So, for me they're actually a resource, rather than a burden. Mauro. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
GWT reusable components in JSP web pages - example
*This is a small demonstration of how GWT client side widgets can be used in JSP web pages:* *http://gwtjsp.lehelsipos.cloudbees.net/ Regards, Lehel * -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Overuse of AssumedStale Issue Tag
On Tuesday, June 4, 2013 10:19:27 AM UTC+2, Davide Cavestro wrote: @Ed I really hope you are right... but so far I've had the same feelings of Mauro and David I guess some discouragement/vexation could be avoided adding an explanatory comment before or contextually tagging an issue as * AssumedStale*, and especially avoid stating I spent more than half an hour reading the code and the specs and doing tests. We can't realistically spend as many time on each and every opened issue. That really makes me wonder... The quote above is out of context: it was a reply to Mauro's This is the kind of feedback I would have appreciated before setting the AssumedStale keyword. So let's try again: 1. the issue tracker has been neglected for years, leading to many issues open and never triaged; we need to clean that up 2. we can't realistically spend half an hour for each and every of these issues: 1500 issues or so would take 750 man×hour, and nobody works full-time just on this (that'd be 100 workdays, i.e. 5 months, if one person were dedicated full-time verifying issues *before* closing them; surely we can spend everyone's time better) 3. so as Ray Cromwell sayshttps://plus.google.com/111204862432674062264/posts/A2SDJXAAZJ2, the only viable option is to crowd source: when in doubt, close the issue and see if someone complains, and *then only* spend time on that issue. Then we have to set priorities, because we're not paid to work on GWT (some Google employees are, but their priorities are the ones of Google; this is the reason why the issue tracker had been neglected for so long and why Google chose to make GWT more open by forming the Steering Committee). On the issue Mauro points out and many others where Daniel replies with feel free to provide patch, we can reopen it but if nobody spends the time to fix it, in a year from now we'll have the same mess in the issue tracker. On that specific issue, I could change the status to NotPlanned (so it's still closed, but removes the word stale) but would it change anything to the way the issue is handled after that? No. (though if you think NotPlanned would be better than AssumedStale, I can make that change). I've had issues open for years, patches pending review for months. I've been there. Daniel also closes some of the issues I reported some time ago [1], and my response is to post patches: e.g. https://code.google.com/p/google-web-toolkit/issues/detail?id=6227 I understand that everyone does not have the GWT sources setup to hack on them, so I don't expect patches coming that fast after an issue has been closed, but at one point this is something you'll want to do. I report issues on other projects too, and when possible I try to provide patches (particularly if that's blocking me for my job). I don't expect every patch to come without prior discussion either: if you're not sure how to fix something, ask on the gwt-contrib group and we'll try to help as best as we can. (and this is in addition to also providing patches for other issues –e.g. https://code.google.com/p/google-web-toolkit/issues/detail?id=8171–, following comments on the issue tracker to help Daniel in triaging issues –the reason I answered on Mauro's issue–, follow the group and stackoverflow, etc. and everything being done mostly during my free time –most issues I reported were for projects at work–) Put differently: we're all in the same boat! BTW, I'm with Ed here: there haven't been as many external patches since we moved to Gerrit and started closing issues and asking for patches; and the move to Gerrit really speed up the review process. [1] https://code.google.com/p/google-web-toolkit/issues/list?can=1q=status:AssumedStale%20reporter:t.bro...@gmail.comsort=-closedcolspec=ID%20Type%20Status%20Owner%20Milestone%20Summary%20Stars%20Closed -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: How to change the application locale dynamically
Another nicer (imho) solution is to use cookie. In your gwt.xml (locale.cookie could be whatever you want): set-configuration-property name=locale.cookie value=gwtLocale/ By default GWT uses following search order: set-configuration-property name=locale.searchorder value=queryparam,cookie,meta,useragent/ You can modify it according to your needs. To actually change the locale you have to: Cookies.setCookie(gwtLocale, ja_JP); Window.Location.reload(); Greg On Monday, June 3, 2013 4:32:48 PM UTC+2, David Levesque wrote: Here's how I do it from a ClickHandler: UrlBuilder builder = Window.Location.createUrlBuilder(); builder.setParameter(locale, localeName); String url = URL.decodeQueryString(builder.buildString()); Window.Location.replace(url); where *localeName* is the locale code, e.g. en_US. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Overuse of AssumedStale Issue Tag
Il 04/06/2013 11:11, Thomas Broyer ha scritto: 1. the issue tracker has been neglected for years, leading to many issues open and never triaged; we need to clean that up 2. we can't realistically spend half an hour for each and every of these issues: 1500 issues or so would take 750 man×hour, and nobody works full-time just on this (that'd be 100 workdays, i.e. 5 months, if one person were dedicated full-time verifying issues *before* closing them; surely we can spend everyone's time better) 3. so as Ray Cromwell says https://plus.google.com/111204862432674062264/posts/A2SDJXAAZJ2, the only viable option is to crowd source: when in doubt, close the issue and see if someone complains, and *then only* spend time on that issue. I'm still convinced that, even if we accept that 3. is the only viable solution, this way of conducing it (that is, closing bugs without any explanation) is not so nice towards the people who opened the bugs. Unless you consider it an explanation to force people to look at n sources of information (two GWT groups, Google+ posts, conference sessions, web pages, ...) to realize why their reports were assumed stale, a simple explanation in the bug reports would have been enough. This is what I saw in other similar cases (I think of Eclipse TPTP project, for example, when they decided to put it in maintenance mode, but it's just an example). However I still think that bug reports review and fixing is also a way to improve a product, so I don't think that 5 months of such an activity would be wasted time. Unless, again, we think that most bug reports are invalid... and this sounds to me as a quite debatable assumption. tracker. On that specific issue, I could change the status to NotPlanned (so it's still closed, but removes the word stale) but would it change anything to the way the issue is handled after that? No. (though if you think NotPlanned would be better than AssumedStale, I can make that change). There's a difference, indeed: the attitude. If you don't care, that's another story. Mauro -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Overuse of AssumedStale Issue Tag
Hi, I asked that many times to my direct managers and even a few levels above. It is indeed in their best interest to also invest in GWT by not producing workarounds but patches. On that front I am a bit optimistic in my position as well, but it takes time to change that mentality in the corporate world. They like to use (which took them a long time to adapt too as well) but contributing is another big step for smaller companies that are not 100% into software. David On Tue, Jun 4, 2013 at 10:45 AM, Ed post2edb...@gmail.com wrote: Wouldn't be cool that many gwt developers (like us) would get permission of their boss/manager to contribute about 2 hours to GWT ? Imagine that around 100 developers around the world would do that? - 200 hours/week of GWT extra development time ;)... I am certain many issues get fixxed ;) To my experience, may bosses don't mind and put it under research development -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Pb with activity and events (using gin)
Hi all,
i'm facing a litlle problem using places activities and events... Have
tried multiple tricks but not luck .
My problem:
i try to fire an event from the activity but my widget does not catch it
since its not loaded (I mean that if i fire this event once the widget's
loaded everything works fine).
Here is my Gin configuration:
@Override
protected void configure()
{
bind(EventBus.class).to(SimpleEventBus.class).asEagerSingleton();
bind(PlaceHistoryMapper.class).to(MyPlaceHistoryMapper.class).in(Singleton.class);
bind(ActivityMapper.class).to(MyActivityMapper.class).in(Singleton.class);
bind(MyActivity.class);
install(new
GinFactoryModuleBuilder().build(MyActivityMapper.Factory.class));
}
@Provides
@Singleton
public PlaceController getPlaceController(EventBus eventBus)
{
return new PlaceController(eventBus);
}
@Singleton
@Provides
public ActivityManager provideActivityManager(ActivityMapper
activityMapper, EventBus eventBus)
{
return new ActivityManager(activityMapper, eventBus);
}
in MyActivity:
@Inject
private MyWidget myWidget;
@Inject
private EventBus globalEventBus;
@Override
public void start(AcceptsOneWidget panel, EventBus eventBus)
{
panel.setWidget(myWidget);
MyEvent event = new MyEvent();
event.setAction(MyEvent.Action.INIT);
globalEventBus.fireEvent(event);
}
I also try two different ways of binding events in my widget, during onLoad
and in constructor:
During onLoad:
@Inject EventBus eventBus;
@Override
protected void onLoad()
{
handlersRegistration.add(eventBus.addHandler(MyEvent.TYPE, this));
}
In constructor:
private EventBus eventBus;
@Inject
public MyWidget(EventBus eventBus)
{
this.eventBus = eventBus;
// registration of handlers
handlersRegistration = new ArrayListHandlerRegistration();
// register myself has a listener of different event TYPE
handlersRegistration.add(eventBus.addHandler(MyEvent.TYPE, this));
...
}
Am I doing something w rong or missing something?
Thks in advance
Tugdual
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Pb with activity and events (using gin)
check if the instance of EventBus is the same. I know you have declared it
as eagerSingleton in your GIN configuration. But do a quick log to see if
the instances are the same.
I remember encountering a similar issue wherein I used to have a new
instance of the EventBus getting injected even though I had a similar
configuration as yours. In order to fix the problem I had to do the
following
1. define a provider
public static class EventBusProvider implements ProviderEventBus {
private static EventBus bus = null;
/* (non-Javadoc)
* @see com.google.inject.Provider#get()
*/
@Override
public EventBus get() {
if(null == bus)
bus = new SimpleEventBus();
return bus;
}
}
2. bind
bind(EventBus.class).toProvider(EventBusProvider.class).in(Singleton.class);
On Tue, Jun 4, 2013 at 4:16 PM, Tugdual Huertas
tugdual.huer...@gmail.comwrote:
Hi all,
i'm facing a litlle problem using places activities and events... Have
tried multiple tricks but not luck .
My problem:
i try to fire an event from the activity but my widget does not catch it
since its not loaded (I mean that if i fire this event once the widget's
loaded everything works fine).
Here is my Gin configuration:
@Override
protected void configure()
{
bind(EventBus.class).to(SimpleEventBus.class).asEagerSingleton();
bind(PlaceHistoryMapper.class).to(MyPlaceHistoryMapper.class).in(Singleton.class);
bind(ActivityMapper.class).to(MyActivityMapper.class).in(Singleton.class);
bind(MyActivity.class);
install(new
GinFactoryModuleBuilder().build(MyActivityMapper.Factory.class));
}
@Provides
@Singleton
public PlaceController getPlaceController(EventBus eventBus)
{
return new PlaceController(eventBus);
}
@Singleton
@Provides
public ActivityManager provideActivityManager(ActivityMapper
activityMapper, EventBus eventBus)
{
return new ActivityManager(activityMapper, eventBus);
}
in MyActivity:
@Inject
private MyWidget myWidget;
@Inject
private EventBus globalEventBus;
@Override
public void start(AcceptsOneWidget panel, EventBus eventBus)
{
panel.setWidget(myWidget);
MyEvent event = new MyEvent();
event.setAction(MyEvent.Action.INIT);
globalEventBus.fireEvent(event);
}
I also try two different ways of binding events in my widget, during
onLoad and in constructor:
During onLoad:
@Inject EventBus eventBus;
@Override
protected void onLoad()
{
handlersRegistration.add(eventBus.addHandler(MyEvent.TYPE, this));
}
In constructor:
private EventBus eventBus;
@Inject
public MyWidget(EventBus eventBus)
{
this.eventBus = eventBus;
// registration of handlers
handlersRegistration = new ArrayListHandlerRegistration();
// register myself has a listener of different event TYPE
handlersRegistration.add(eventBus.addHandler(MyEvent.TYPE, this));
...
}
Am I doing something w rong or missing something?
Thks in advance
Tugdual
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an
email to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Dynamically generated HTML and GWT
Hi, I'm using protected members, nothing private. So any change to those methods in the Widget API will break compatibility for a lot of projects. But regardless, if the widget API is ever changed or something better is created that would allow us to use Renderers and do it in a supported way then I would be glad to migrate my code. I am not the only one who has moved to this direction. I am currently working on a second project that uses about the same approach, developed before I ever talked to the developers in that team/company. In our case the root cause is that the GWT is always focusing on build time optimisations. I had big hopes for UiBinder - and I use it in some cases - but it turns out that this only targets build time. We are uploading schema's so we need to generate big UI's on the fly. Otherwise I would have created a generator that would spit out UiBinder compatible classes/files. But with pure usage of the widgets it just does not scale. Sure if we wait a few more years then everyone will be using IE10 or newer with GPU acceleration and god knows what else, and maybe we won't care that much anymore, but do not forget that mobile phones consume a lot of battery if you do not optimize. GWT started doing similar bulk rendering with the Cell widgets, but there it is a much more narrow context. In tables you can get away with the rubber stamp approach and collect all events centrally. But with forms that becomes a bit more complicated, since I really need exactly the same behaviour as widgets already support, so why not share the code ? David On Tue, Jun 4, 2013 at 10:23 AM, Jens jens.nehlme...@gmail.com wrote: They way I use the widgets, maybe not supported, work perfectly. It is made part of the widget hierarchy. And when I remove the widget, everything is again cleaned up. I did a lot of memory leak investigating and it is just working the way it should. Even if the window close event is triggered, they get properly cleaned up just like the rest of the widget hierarchy. The wrap methods on Widget assume and do too much and that makes them not usable beyond the scope of wrapping non nested widgets. Interesting, then they maybe decide to implement it the safe way so they don't have to think about that case when they want to change Widget internals. -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Pb with activity and events (using gin)
On Tuesday, June 4, 2013 12:46:16 PM UTC+2, Tugdual Huertas wrote:
Hi all,
i'm facing a litlle problem using places activities and events... Have
tried multiple tricks but not luck .
My problem:
i try to fire an event from the activity but my widget does not catch it
since its not loaded (I mean that if i fire this event once the widget's
loaded everything works fine).
Here is my Gin configuration:
@Override
protected void configure()
{
bind(EventBus.class).to(SimpleEventBus.class).asEagerSingleton();
bind(PlaceHistoryMapper.class).to(MyPlaceHistoryMapper.class).in(Singleton.class);
bind(ActivityMapper.class).to(MyActivityMapper.class).in(Singleton.class);
bind(MyActivity.class);
install(new
GinFactoryModuleBuilder().build(MyActivityMapper.Factory.class));
}
@Provides
@Singleton
public PlaceController getPlaceController(EventBus eventBus)
{
return new PlaceController(eventBus);
}
@Singleton
@Provides
public ActivityManager provideActivityManager(ActivityMapper
activityMapper, EventBus eventBus)
{
return new ActivityManager(activityMapper, eventBus);
}
in MyActivity:
@Inject
private MyWidget myWidget;
@Inject
private EventBus globalEventBus;
@Override
public void start(AcceptsOneWidget panel, EventBus eventBus)
{
panel.setWidget(myWidget);
MyEvent event = new MyEvent();
event.setAction(MyEvent.Action.INIT);
globalEventBus.fireEvent(event);
}
I also try two different ways of binding events in my widget, during
onLoad and in constructor:
During onLoad:
@Inject EventBus eventBus;
@Override
protected void onLoad()
{
handlersRegistration.add(eventBus.addHandler(MyEvent.TYPE, this));
}
In constructor:
private EventBus eventBus;
@Inject
public MyWidget(EventBus eventBus)
{
this.eventBus = eventBus;
// registration of handlers
handlersRegistration = new ArrayListHandlerRegistration();
// register myself has a listener of different event TYPE
handlersRegistration.add(eventBus.addHandler(MyEvent.TYPE, this));
...
}
Am I doing something w rong or missing something?
All adds and removes of event handlers during the dispatching of an event
(which is the case when the activity starts: it's in response to a
PlaceChangeEvent) is deferred to after the event has been dispatched all
handlers.
Events however are dispatched synchronously (so that handlers can possibly
modify them and the sender take action depending on the event after the
dispatching; see setWarning for PlaceChangeRequestEvent).
So you have to defer your fireEvent() call using the Scheduler:
// Assuming a Scheduler has been @Inject-ed
scheduler.scheduleFinally(new ScheduledCommand() {
@Override
public void execute() {
MyEvent event = new MyEvent();
event.setAction(MyEvent.Action.INIT);
globalEventBus.fireEvent(event);
}
});
It's a good rule to always assume you might be called as part of event
dispatching unless you're handling UI events (click on a button, etc.) and
thus always defer your event dispatching in this case.
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: RPC call with android
In the event anyone else still needs it, I just put out a 0.4 release for the SyncProxy system, which includes a separate Android library. It can always use more work, but I've got enough testing on it that for now, I believe it's stable for integration into the majority of projects needing it. The front page will hopefully get updated by the project owner soon, but in the meantime the jar's are available for download and details on usage are in the Wiki. https://code.google.com/p/gwt-syncproxy/ On Sunday, March 3, 2013 10:32:12 AM UTC-5, Preethum Prithviraj wrote: I'd been needing something like this for a GAE based project I'm working on. Using the code from the gwt-syncproxy project, I created an Android library and I've got got a dev mode working mock up of an android client using GWT-RPC to the server and using the native android account system to login to GAE. I've still got quite a bit of testing to do, but I've contacted the owner of the gwt-syncproxy project to look at getting this integrated into their project once I finish testing it in a couple of weeks. On Sunday, February 17, 2013 11:47:55 PM UTC-5, Chii wrote: I m expecting that both RequestFactory and gwt-rpc has less overhead than vanilla json (at least, in terms of bandwidth - not sure about cpu requirement differences between them), but if it turns out that neither works on android, then it would suck to have to switch to json. On Friday, February 25, 2011 12:50:03 AM UTC+11, Thomas Lefort wrote: Thanks! I will try the RequestFactory hack, although it seems like there might be a third (and easier?) way with JSON-RPC from the discussions. On Feb 24, 11:28 am, Thomas Broyer t.bro...@gmail.com wrote: GWT SyncProxy http://code.google.com/p/gwt-syncproxy/ allows you to call GWT-RPC services from a Java app, but it apparently does not work on Androidhttp://code.google.com/p/gwt-syncproxy/issues/detail?id=3 . As for RequestFactory, it has built-in support for running in the JVM, and it should work on Android: https://groups.google.com/d/msg/google-web-toolkit-contributors/-AJR5... -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Pb with activity and events (using gin)
Thanks for your responses, i try the scheduleFinally solution, that works, just have to inject the eventBus in the constructor of my activity (has to become final)! Tks a lot -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Pb with activity and events (using gin)
You can add final to the method parameter: Activity.start(final AcceptsOneWidget panel, final EventBus eventBus). Actually you should not inject an additional event bus into your activity (unless you really know what you are doing and you absolutely need it). You should always use the one that is provided by Activity.start() because this EventBus instance will be cleaned up automatically once your activity stops. -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Pb with activity and events (using gin)
thanks Jens, you're right, Thomas told me the same. I haven't seen that the eventBus given as parameter (which is a resettableeventBus) is created from the eventBus declared and binded in gin! Tks Le mardi 4 juin 2013 14:28:50 UTC+2, Jens a écrit : You can add final to the method parameter: Activity.start(final AcceptsOneWidget panel, final EventBus eventBus). Actually you should not inject an additional event bus into your activity (unless you really know what you are doing and you absolutely need it). You should always use the one that is provided by Activity.start() because this EventBus instance will be cleaned up automatically once your activity stops. -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Overuse of AssumedStale Issue Tag
Mauro, I am not sure how many open source projects you have been involved with. I did not bother to google your name to find out. But I have have seen many projects take the same tactic as the GWT-Dev team did to clean up the issue tracker. I have also seen commercial projects take the exact same approach (Oracle and Microsoft for example). In most cases, they are not even polite enough to use a new term Assumed Stale Instead they are marked close and sometimes they may attach a single comment such as Closed due to lack of activity. At this point, the project is largely just moving to the concept of open source and will have growing pains. (See Eclipse for some examples.) I am sorry you feel insulted that your issues have not been addressed. However I believe this issue has been beat to death. I know I am tired of seeing emails on it. If you want your issues addressed, check that they do not go against the vision the steering committee created. Then contribute either by providing a fix or paying someone to fix it. Not buy whining about it. (Personally, due to legal conflicts and other issues I have always paid someone else to provide a fix -- I am normally a consultant and most IP I create belongs to the customer). Tim On Jun 4, 2013, at 5:32 AM, Mauro Molinari mauro...@tiscali.it wrote: Il 04/06/2013 11:11, Thomas Broyer ha scritto: 1. the issue tracker has been neglected for years, leading to many issues open and never triaged; we need to clean that up 2. we can't realistically spend half an hour for each and every of these issues: 1500 issues or so would take 750 man×hour, and nobody works full-time just on this (that'd be 100 workdays, i.e. 5 months, if one person were dedicated full-time verifying issues *before* closing them; surely we can spend everyone's time better) 3. so as Ray Cromwell says https://plus.google.com/111204862432674062264/posts/A2SDJXAAZJ2, the only viable option is to crowd source: when in doubt, close the issue and see if someone complains, and *then only* spend time on that issue. I'm still convinced that, even if we accept that 3. is the only viable solution, this way of conducing it (that is, closing bugs without any explanation) is not so nice towards the people who opened the bugs. Unless you consider it an explanation to force people to look at n sources of information (two GWT groups, Google+ posts, conference sessions, web pages, ...) to realize why their reports were assumed stale, a simple explanation in the bug reports would have been enough. This is what I saw in other similar cases (I think of Eclipse TPTP project, for example, when they decided to put it in maintenance mode, but it's just an example). However I still think that bug reports review and fixing is also a way to improve a product, so I don't think that 5 months of such an activity would be wasted time. Unless, again, we think that most bug reports are invalid... and this sounds to me as a quite debatable assumption. tracker. On that specific issue, I could change the status to NotPlanned (so it's still closed, but removes the word stale) but would it change anything to the way the issue is handled after that? No. (though if you think NotPlanned would be better than AssumedStale, I can make that change). There's a difference, indeed: the attitude. If you don't care, that's another story. Mauro -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Search for a substring in a string ignoring accented characters
I cannot find a way, using GWT's *JRE emulation,* to : - *search* *for a* sub *string* in a String *ignoring accented characters * (diacritics) - *remove accented characters* from a String Any suggestion or pointer to an external library offering any of these features would be greatly appreciated ? Thanks. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Search for a substring in a string ignoring accented characters
Eric, I had to do something close to what you have requested. I do not think it is an exact fit. I used String.split method which takes a regex param. I then concat the resulting array. I only had a few strings to deal with, so I did not worry about performance or other potential issues. Good luck, Tim On Jun 4, 2013, at 9:27 AM, Eric Bouchut alfo...@gmail.com wrote: I cannot find a way, using GWT's *JRE emulation,* to : - *search* *for a* sub *string* in a String *ignoring accented characters * (diacritics) - *remove accented characters* from a String Any suggestion or pointer to an external library offering any of these features would be greatly appreciated ? Thanks. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Drag and Drop to a RichTextArea / IFrame?
paranoiabla@... paranoiabla@... writes:
I have the same problem. I can't drop into an iframe :( On Monday, August
6, 2012 10:36:58 PM UTC+3, GWT Kid wrote:
is there a solution for this ? How do we do drag and drop in
richTextAreaOn Wed, Oct 26, 2011 at 9:55 AM, Derek derek...-
re5jqeeqqe8avxtiumw...@public.gmane.org wrote:I'm trying out some of the
fun drag-and-drop stuff in GWT. My current
attempt is to drag a file into a richtextarea, but nothing seems to be
working correctly. It works fine if I use a FlowPanel or some other
GWT widget, but not a RichTextArea despite it have an addDropHandler
method.
Anyone have any experience with this?
My code in onModuleLoad:
DropHandler drop = new DropHandler() {
at Override
public void onDrop(DropEvent event) {
event.preventDefault();
String data = event.getData(text);
GWT.log(text is +data+ and there are
+numFiles(event.getDataTransfer())+ files);
}
};
RichTextArea rt = new RichTextArea();
rt.addDropHandler(drop); // never called even after drag-and-dropping
a file on the rt
RootPanel.get().add(rt);
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To post to this group, send email to google-we... at googlegroups.com.
To unsubscribe from this group, send email to google-web-
toolkit+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/google-web-toolkit?hl=en.
Did you find a solution? I'm having the same problem. I've tried it using
JSNI too, it seems to get a few events then stops. How did you solve this?
-Dave
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: DataGrid vertical scrollbar overlaps the last column
I am using percentages to define the size of the columns, so the padding solution did not work for me. However an additional dummy column (with no title and no value) solved the problem. Jarka -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: [ANN] net.ltgt.gwt.maven:gwt-maven-plugin:1.0-alpha-1 released
They are very useful. Thanks. How do I generate a gwtar file if I use this plugin? David On Monday, June 3, 2013 2:55:13 PM UTC-4, Thomas Broyer wrote: On Mon, Jun 3, 2013 at 8:29 PM, Jens jens.ne...@gmail.com javascript: wrote: Would you provide me with some examples about gwt-lib or gwt-app? I do need some tutorials about how to use this new library. You can look at the integration test examples at https://github.com/tbroyer/gwt-maven-plugin/tree/master/src/it Most likely gwt-app, gwt-lib and, for a bit more complex scenario, e2e. You can also find real uses of gwt-lib in the wild (so you can omit the inherits/ in your gwt-app!): https://github.com/google/gwtmockito/ and https://github.com/google/gwteventbinder -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
tedious JSNI primitive casts - JavaScriptPrimitive?
I wonder if anyone has an approach to avoids (or lessen) the tedious
instanceof if loops in the following kind of code:
public static void javaMethod(Object value) {
if (value instanceof String) {
jsniMethod((String) value);
} else if (value instanceof Number) {
jsniMethod(((Number) value).doubleValue());
} else if (value instanceof Boolean) {
jsniMethod((Boolean) value);
} else {
if (value!=null)
throw new RuntimeException(not a primitive : +
value.getClass().getName());
}
}
...
public static native void jsniMethod(String arg) /*-{
jsMethod(arg);
}-*/;
public static native void jsniMethod(double arg) /*-{
jsMethod(arg);
}-*/;
public static native void jsniMethod(boolean arg) /*-{
jsMethod(arg);
}-*/;
and in JavaScript - a single method
jsMethod = function(data) {
alert('hello ' + data);
};
Part of the annoyance is tedium, but I often wonder if I might miss a case.
What I'd love is for a class JavaScriptPrimitive or something like that.
JSONValue is pretty close in semantics, but I don't think it works for
this use case.
so, then I could write a single
public static native void jsniMethod(JavaScriptPrimitive arg) /*-{
jsMethod(arg);
}-*/;
and perhaps have a single utility cast method toJavaScriptPrimitive
public static void javaMethod(Object value) {
jsniMethod(toJavaScriptPrimitive(value));
}
I've written code like this so often now, I'm resigned to continuing along
those lines - but I am posting here because I wonder if there is a better
way?
Thanks,
Tom
--
You received this message because you are subscribed to the Google Groups
Google Web Toolkit group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit+unsubscr...@googlegroups.com.
To post to this group, send email to google-web-toolkit@googlegroups.com.
Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.
Re: [ANN] net.ltgt.gwt.maven:gwt-maven-plugin:1.0-alpha-1 released
On Tue, Jun 4, 2013 at 4:31 PM, Lexis Nexis lexisnexis5...@gmail.com wrote: They are very useful. Thanks. How do I generate a gwtar file if I use this plugin? You don't ;-) AFAICT gwtar files are highly dependent on the version of GWT used to produce them, so you won't want to create them for a library you intend for wide reuse. David On Monday, June 3, 2013 2:55:13 PM UTC-4, Thomas Broyer wrote: On Mon, Jun 3, 2013 at 8:29 PM, Jens jens.ne...@gmail.com wrote: Would you provide me with some examples about gwt-lib or gwt-app? I do need some tutorials about how to use this new library. You can look at the integration test examples at https://github.com/tbroyer/gwt-maven-plugin/tree/master/src/it Most likely gwt-app, gwt-lib and, for a bit more complex scenario, e2e. You can also find real uses of gwt-lib in the wild (so you can omit the inherits/ in your gwt-app!): https://github.com/google/gwtmockito/ and https://github.com/google/gwteventbinder -- You received this message because you are subscribed to a topic in the Google Groups Google Web Toolkit group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/google-web-toolkit/O8HaPzExxhc/unsubscribe?hl=en. To unsubscribe from this group and all its topics, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- Thomas Broyer /tɔ.ma.bʁwa.je/ -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Place and states of widgets
Hi all, is there a way to get a widget in the exactly state it was when navigate with back/forward history mechanism? For example, i have a menu item that displays a view containing a set of radios, a tree and a cellTable (clicking the menuItem call a place with no args just to initialize the view). In this view, i can do multiple things like switch radio buttons, selected a row in the tree... When changing to another place and navigate back to this one, how can i get back all the selected objects? Is there a way to rewrite the url so that we can modify the token each time the user's selection change? Must I pass through session args? Tks, Tugdual -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Am I able to write a panel that likes DockLayoutPanel with scroll bar
Sorry for the question, what is 'flowPanel' in your example? Is it the widget in the center of the docklayoutpanel? Or what else? On Friday, February 10, 2012 3:23:50 PM UTC+1, Patrick Tucker wrote: I'm not sure it makes sense to make an entire DockLayoutPanel scroll, its a LayoutPanel... If you apply the appropriate overflow value (auto or scroll) to the container element that you would like to scroll, the container will scroll when the child is to big for its current size. Example: dockLayoutPanel.getWidgetContainerElement(flowPanel).getStyle().setOverflowY(Overflow.AUTO); Where dockLayoutPanel is the DockLayoutPanel that you intend to manipulate. On Feb 9, 2:32 am, linhua linhu...@citiz.net wrote: What I want to do is: Currently, I can only add scroll panel inside the center part of DockLayoutPanel. I want all the parts of DockLayoutPanel share a scroll bar. If can do, how to implement a such class? Which class should I extend and what interfaces should be implemented? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Place and states of widgets
May be I can use the History.newItem(String historyToken, boolean issueEvent) function with issueEvent set to false... but it seems to be a little tricky to do that for all views Le mardi 4 juin 2013 17:05:54 UTC+2, Tugdual Huertas a écrit : Hi all, is there a way to get a widget in the exactly state it was when navigate with back/forward history mechanism? For example, i have a menu item that displays a view containing a set of radios, a tree and a cellTable (clicking the menuItem call a place with no args just to initialize the view). In this view, i can do multiple things like switch radio buttons, selected a row in the tree... When changing to another place and navigate back to this one, how can i get back all the selected objects? Is there a way to rewrite the url so that we can modify the token each time the user's selection change? Must I pass through session args? Tks, Tugdual -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Am I able to write a panel that likes DockLayoutPanel with scroll bar
Yes flowPanel is the object that should be scrolled when it overflows. On Tuesday, June 4, 2013 11:29:32 AM UTC-4, Magallo wrote: Sorry for the question, what is 'flowPanel' in your example? Is it the widget in the center of the docklayoutpanel? Or what else? On Friday, February 10, 2012 3:23:50 PM UTC+1, Patrick Tucker wrote: I'm not sure it makes sense to make an entire DockLayoutPanel scroll, its a LayoutPanel... If you apply the appropriate overflow value (auto or scroll) to the container element that you would like to scroll, the container will scroll when the child is to big for its current size. Example: dockLayoutPanel.getWidgetContainerElement(flowPanel).getStyle().setOverflowY(Overflow.AUTO); Where dockLayoutPanel is the DockLayoutPanel that you intend to manipulate. On Feb 9, 2:32 am, linhua linhu...@citiz.net wrote: What I want to do is: Currently, I can only add scroll panel inside the center part of DockLayoutPanel. I want all the parts of DockLayoutPanel share a scroll bar. If can do, how to implement a such class? Which class should I extend and what interfaces should be implemented? -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Place and states of widgets
You don't want to save the UI state in the URL. The reason is that if you do so, the browser would have two history entries if you check and then uncheck a checkbox. Now when you hit the browsers back button you don't go to the previous place (the previous selected menu item) but you just undo the last checkbox action. Thats probably not what you want. So you should store UI state in the browsers local storage (http://www.gwtproject.org/doc/latest/DevGuideHtml5Storage.html) or save it in memory using a Map or something. -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Place and states of widgets
ok tks Jens, i'll try it Le mardi 4 juin 2013 17:05:54 UTC+2, Tugdual Huertas a écrit : Hi all, is there a way to get a widget in the exactly state it was when navigate with back/forward history mechanism? For example, i have a menu item that displays a view containing a set of radios, a tree and a cellTable (clicking the menuItem call a place with no args just to initialize the view). In this view, i can do multiple things like switch radio buttons, selected a row in the tree... When changing to another place and navigate back to this one, how can i get back all the selected objects? Is there a way to rewrite the url so that we can modify the token each time the user's selection change? Must I pass through session args? Tks, Tugdual -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Place and states of widgets
May be I can use the History.newItem(String historyToken, boolean issueEvent) function with issueEvent set to false... but it seems to be a little tricky to do that for all views History.newItem() is used for navigation inside the app, e.g. you want to go from the person menu item to the companies menu item. Its not about storing UI state, its about storing navigation state. Also instead of using the History class directly you could take a look at GWT's Activities and Places article: http://www.gwtproject.org/doc/latest/DevGuideMvpActivitiesAndPlaces.html (you can use Place without Activities) -- J. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Export CellTable data to PDF and Excel Format using UIBinder
hey can u send me a complete code for celltable export to excel On Friday, May 25, 2012 9:21:38 AM UTC-5, Joseph Lust wrote: The gist is to: 1. Get a list of all records you need to export from the celltable on the client browser (and the sorting information). 2. Return this to the server. 3. Fetch all the information from (1). 4. Build into an Excel or CSV output using POI or similar. In reality it can be quite a pain. I implemented it in ExtJs grids using POI and had to have columns in any order user had rearranged them to, columns shown/hidden if user had changed them, numeric values as numeric type in exported Excel file... etc. You probably want to try to use a library to achieve this rather than write it yourself. I've not used this library, but it looks like a good start: GWT-Table-To-Excel http://code.google.com/p/gwt-table-to-excel/ Note that the library uses HTML output, which is a hack (that even ASP.Net recommends... LOL). You'll get a warning if you open a HTML table in Excel that it is not the proper format, but then Excel will load it anyway. If you need rich, native Excel exports, you'll probably need to write your own POI framework. This topic was covered earlier here: https://groups.google.com/forum/#!msg/google-web-toolkit/I9VEaFlkA1I/pDXGBBD2g_AJ Sincerely, Joseph -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Export CellTable data to PDF and Excel Format using UIBinder
If you want to do it clientside I could recomment using ClientIO http://emitrom.com/announcements/flash4j-3.1-ga See it in action here http://eemi2010.github.io/ext4j/#!ClientIO 2013/6/4 Shashank Beerla shashankgris...@gmail.com hey can u send me a complete code for celltable export to excel On Friday, May 25, 2012 9:21:38 AM UTC-5, Joseph Lust wrote: The gist is to: 1. Get a list of all records you need to export from the celltable on the client browser (and the sorting information). 2. Return this to the server. 3. Fetch all the information from (1). 4. Build into an Excel or CSV output using POI or similar. In reality it can be quite a pain. I implemented it in ExtJs grids using POI and had to have columns in any order user had rearranged them to, columns shown/hidden if user had changed them, numeric values as numeric type in exported Excel file... etc. You probably want to try to use a library to achieve this rather than write it yourself. I've not used this library, but it looks like a good start: GWT-Table-To-Excel http://**code.google.com/p/gwt-table-**to-excel/http://code.google.com/p/gwt-table-to-excel/ Note that the library uses HTML output, which is a hack (that even ASP.Net recommends... LOL). You'll get a warning if you open a HTML table in Excel that it is not the proper format, but then Excel will load it anyway. If you need rich, native Excel exports, you'll probably need to write your own POI framework. This topic was covered earlier here: https://groups.google.** com/forum/#!msg/google-web-**toolkit/I9VEaFlkA1I/pDXGBBD2g_**AJhttps://groups.google.com/forum/#!msg/google-web-toolkit/I9VEaFlkA1I/pDXGBBD2g_AJ Sincerely, Joseph -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: change in children not saved in GWT 2.5.1 after implement OSIV
The only work around that i have found is to persist the entity child in a diferent request. In my case i have a ParentEntity with a SetChildEntity. When persisting a new set, it work just fine, but when i try to update the values, the modifications never reach the server. I tried to create a new Set to overwrite the old one, but no sucess in this attempt; -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: [ANN] net.ltgt.gwt.maven:gwt-maven-plugin:1.0-alpha-1 released
I have the following two questions: 1. Can we have more sub source folders under src/main such as src/main/java, src/main/gwt for GWT, src/main/birt,for BIRT, src/main/config for Spring Java configuration. 2. I have a huge project ( 1000 database tables). I like to generate many gwtar files for my internal team in order to reduce gwt compilation time. How do I do it? Should I use CompileModule from prompt? I like to get one script how to generate a gwtar file? Thanks, On Monday, March 25, 2013 5:22:37 AM UTC-4, Thomas Broyer wrote: Hi everyone, Last night (UTC+1), I released 1.0-alpha-1 of my * net.ltgt.gwt.maven:gwt-maven-plugin*. Preliminary documentation is available at https://github.com/tbroyer/gwt-maven-plugin Note that this is an early alpha: • As an experiment, the GWT compiler runs inline rather than in a forked process (which also means it only uses threads for now and won't fork worker processes); forking will likely become an option behind a flag (similar to the maven-compiler-plugin). • There's no way to launch the DevMode or SuperDevMode. I want something that works in multi-module builds, contrary to the * org.codehaus.mojo:gwt-maven-plugin.* Unless someone opposes to it, this plugin will likely become * com.google.gwt.maven:gwt-maven-plugin* in the near future (with the stated goal of replacing the Codehaus Mojo plugin in the long run). Note: this forum is about GWT proper, so please keep feedback on this specific thread, the G+ announcement (see link below), the other announcements in the GWT and gwt-maven-plugin forums, or possibly on Twitter (@tbroyer). “Illustrated announcement” at: https://plus.google.com/113945685385052458154/posts/RDrK7ukVFqJ -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
Re: Dynamically generated HTML and GWT
This looks more difficult than I first thought. I think I'd have to somehow also attach to the form element. I would need to set the action to go to a servlet. I don't see a way to take some HTML and get the FORM element. I may try a completely different way to do this. I'll create a servlet to get the form, display it, and handle the form submission. The entire thing will be put in an iframe (GWT frame). I think this may also be the only way to get some of our forms working that have Javascript in them. It looks like the Frame class treats the document as completely independent from the app (and the RootPanel). You need to subclass HTMLPanel and SubmitButton to get what you want. The HTMLPanel only supports adding widgets to existing HTML elements, not just make an Element into a widget without detaching. First you need to subclass the SubmitButton so that you gain access to the SubmitButton(Element) protected constructor. Use that constructor to create the SubmitButton instance. -- You received this message because you are subscribed to the Google Groups Google Web Toolkit group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit+unsubscr...@googlegroups.com. To post to this group, send email to google-web-toolkit@googlegroups.com. Visit this group at http://groups.google.com/group/google-web-toolkit?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes api-checker reference JARs from the source tree.
Thomas Broyer has posted comments on this change. Change subject: Removes api-checker reference JARs from the source tree. .. Patch Set 5: Matthew: can I go ahead and merge? Any blocker on Google's side? -- To view, visit https://gwt-review.googlesource.com/2500 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3d5a585fb57cfd959504109df35279b3c9c56879 Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Matthew Dempsky mdemp...@gwtproject.org Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Add NavigableSet, NavigableMap to GWT and retrofit TreeMap and TreeSet to implement it. (issue1839803)
Can someone move that patch over to Gerrit? Would you prefer that I do it? (BTW, any reason this hadn't been reviewed yet?) http://gwt-code-reviews.appspot.com/1839803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Add HasPaths interface.
Jens Nehlmeier has posted comments on this change. Change subject: Add HasPaths interface. .. Patch Set 2: LGTM, although I don't get why all these feature interfaces like HasRequestContext, HasEditorErrors and now HasPaths need to extend Editor. It gets more awkward the more you have of them. Whats the point of PersonEditor extends Widget implements HasRequestContextPersonProxy, HasEditorErrorsPersonProxy, HasPathsPersonProxy Thats not very DRY (sure the example is the worst case), given the fact that the feature interfaces do not depend on PersonProxy. I would always prefer: PersonEditor implements EditorPersonProxy, HasRequestContext, HasEditorErrors, HasPaths. So maybe we should not follow this concept and make HasPath do not extend Editor. -- To view, visit https://gwt-review.googlesource.com/3185 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f259552d945bf22592c4395e3c7b2ad45bfe93c Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Jens Nehlmeier jens.nehlme...@gmail.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...
Daniel Kurka has posted comments on this change.
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare -Long.compare -Float.compare (Double
already exists) fixes issue 7998
..
Patch Set 9:
(4 comments)
File user/super/com/google/gwt/emul/java/lang/Float.java
Line 37: if (isNaN(x)) {
I don't think its a good idea, since with this we would have to do
something like:
if(!isNaN(x) !isNaN(y)) {
// do normal stuff
}else{
//test again
}
If we want to change this, we should also change this in Double.compare
(its implemented the same way)
File user/super/com/google/gwt/emul/java/lang/Short.java
Line 37: return Integer.compare(x, y);
I dont really understand what the difference would be between prod vs. dev
if we do not use x-y. Correct me if I am wrong but one should never rely on
the exact value returned from compare.
File user/test/com/google/gwt/emultest/java/lang/FloatTest.java
Line 81: }
In JavaScript something like this passes:
assertEquals(0, Float.compare(0.0f, -0.0f));
While it does not pass in Java. Do we want to make sure we cover this
corner case (as well as others) and take the performance hit?
Not sure here. Could we just cover this in the docs of the JRE Emulation?
File user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
Line 120: assertEquals(0, Integer.compare(1, 1));
We actually look terrible at the Borders:
This will just fail:
Integer.compare(Integer.MAX_VALUE, Integer.MIN_VALUE) 0
since we do not got overflow for ints in javascript.
I am not sure how to handle such corner cases, do we want to handle them,
any input?
--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
James Horsley has uploaded a new change for review. https://gwt-review.googlesource.com/3210 Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. This patch adds Map support to RequestFactory (see https://code.google.com/p/google-web-toolkit/issues/detail?id=5524) There's a lot of existing discussion on the patch at https://codereview.appspot.com/6132056/. From looking back over that discussion the main user facing design decision to call out which isn't just what someone might expect from Map support is that referencing child complex types in keys and values is done using .with(someMap.keys.property, someMap.values.property ) Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b --- M user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java M user/src/com/google/web/bindery/requestfactory/apt/TransportableTypeVisitor.java M user/src/com/google/web/bindery/requestfactory/server/Resolver.java A user/src/com/google/web/bindery/requestfactory/server/Resolver.java.orig M user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java A user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java.orig M user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java A user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java.orig M user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java A user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java.orig A user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java.rej M user/src/com/google/web/bindery/requestfactory/shared/impl/EntityCodex.java M user/src/com/google/web/bindery/requestfactory/shared/impl/ProxySerializerImpl.java M user/test/com/google/web/bindery/requestfactory/gwt/client/FindServiceTest.java M user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java A user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java.orig A user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java.rej A user/test/com/google/web/bindery/requestfactory/server/MapKey.java A user/test/com/google/web/bindery/requestfactory/server/MapValue.java M user/test/com/google/web/bindery/requestfactory/server/SimpleFoo.java A user/test/com/google/web/bindery/requestfactory/server/SimpleFoo.java.orig M user/test/com/google/web/bindery/requestfactory/shared/BaseFooProxy.java A user/test/com/google/web/bindery/requestfactory/shared/MapKeyProxy.java A user/test/com/google/web/bindery/requestfactory/shared/MapKeyRequest.java A user/test/com/google/web/bindery/requestfactory/shared/MapValueProxy.java A user/test/com/google/web/bindery/requestfactory/shared/MapValueRequest.java M user/test/com/google/web/bindery/requestfactory/shared/SimpleBarProxy.java M user/test/com/google/web/bindery/requestfactory/shared/SimpleRequestFactory.java 28 files changed, 7,973 insertions(+), 46 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
Manuel Carrasco Moñino has posted comments on this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Patch Set 1: James could you submit a new patch set without files *.rej and *.orig -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
James Horsley has posted comments on this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Patch Set 1: Ick sorry. Will submit a new patch. Should just discard this one or update it? -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Adds Map support to RequestFactory (see https://code.google....
James Horsley has uploaded a new change for review.
https://gwt-review.googlesource.com/3186
Change subject: Adds Map support to RequestFactory (see
https://code.google.com/p/google-web-toolkit/issues/detail?id=5524)
..
Adds Map support to RequestFactory (see
https://code.google.com/p/google-web-toolkit/issues/detail?id=5524)
This is a port of an existing svn patch
https://codereview.appspot.com/6132056/
onto the new git repo to work with gerrit.
There's a lot of existing discussion on the patch at
https://codereview.appspot.com/6132056/. From looking back over that
discussion
the main user facing design decision to call out which isn't just what
someone
might expect from Map support is that referencing child complex types in
keys
and values is done using .with(someMap.keys.property,
someMap.values.property )
Change-Id: I6dd3c8a9862473954a72ccee96212c20d9198b22
---
M
user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java
M
user/src/com/google/web/bindery/requestfactory/apt/TransportableTypeVisitor.java
M user/src/com/google/web/bindery/requestfactory/server/Resolver.java
M
user/src/com/google/web/bindery/requestfactory/server/ResolverServiceLayer.java
M
user/src/com/google/web/bindery/requestfactory/server/SimpleRequestProcessor.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/AbstractRequestContext.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/EntityCodex.java
M
user/src/com/google/web/bindery/requestfactory/shared/impl/ProxySerializerImpl.java
M
user/test/com/google/web/bindery/requestfactory/gwt/client/FindServiceTest.java
M
user/test/com/google/web/bindery/requestfactory/gwt/client/RequestFactoryTest.java
A user/test/com/google/web/bindery/requestfactory/server/MapKey.java
A user/test/com/google/web/bindery/requestfactory/server/MapValue.java
M user/test/com/google/web/bindery/requestfactory/server/SimpleFoo.java
M user/test/com/google/web/bindery/requestfactory/shared/BaseFooProxy.java
A user/test/com/google/web/bindery/requestfactory/shared/MapKeyProxy.java
A user/test/com/google/web/bindery/requestfactory/shared/MapKeyRequest.java
A user/test/com/google/web/bindery/requestfactory/shared/MapValueProxy.java
A
user/test/com/google/web/bindery/requestfactory/shared/MapValueRequest.java
M user/test/com/google/web/bindery/requestfactory/shared/SimpleBarProxy.java
M
user/test/com/google/web/bindery/requestfactory/shared/SimpleRequestFactory.java
20 files changed, 897 insertions(+), 46 deletions(-)
diff --git
a/user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java
b/user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java
index dd1f28c..2eac320 100644
---
a/user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java
+++
b/user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java
@@ -17,6 +17,7 @@
import java.util.Collection;
import java.util.List;
+import java.util.Map;
import java.util.Set;
import javax.lang.model.element.ElementKind;
@@ -99,6 +100,12 @@
TypeMirror param = convertSingleParamType(x,
state.findType(Collection.class), 0, state);
return state.types.getDeclaredType((TypeElement)
state.types.asElement(x), param);
}
+if (state.types.isAssignable(x, state.findType(Map.class))) {
+ // Convert MapString,FooProxy to MapString,FooDomain
+ TypeMirror keyParam = convertSingleParamType(x,
state.findType(Map.class), 0, state);
+ TypeMirror valueParam = convertSingleParamType(x,
state.findType(Map.class), 1, state);
+ return state.types.getDeclaredType((TypeElement)
state.types.asElement(x), keyParam, valueParam);
+}
return defaultAction(x, state);
}
diff --git
a/user/src/com/google/web/bindery/requestfactory/apt/TransportableTypeVisitor.java
b/user/src/com/google/web/bindery/requestfactory/apt/TransportableTypeVisitor.java
index 9d47dd1..8663ad5 100644
---
a/user/src/com/google/web/bindery/requestfactory/apt/TransportableTypeVisitor.java
+++
b/user/src/com/google/web/bindery/requestfactory/apt/TransportableTypeVisitor.java
@@ -17,6 +17,7 @@
import java.util.Collection;
import java.util.List;
+import java.util.Map;
import java.util.Set;
import javax.lang.model.element.ElementKind;
@@ -77,6 +78,19 @@
}
return t.getTypeArguments().get(0).accept(this, state);
}
+if (state.types.isAssignable(t, state.findType(Map.class))) {
+ if (!allowNestedParameterization) {
+return false;
+ }
+ allowNestedParameterization = false;
+ DeclaredType asMap =
+ (DeclaredType) State.viewAs(state.findType(Map.class), t, state);
+ if (asMap.getTypeArguments().isEmpty()) {
+return false;
+ }
+ return t.getTypeArguments().get(0).accept(this, state)
+ t.getTypeArguments().get(1).accept(this,
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
James Horsley has abandoned this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Abandoned Contains unintended .orig and .rej files. Resubmitted with https://gwt-review.googlesource.com/#/c/3186/ -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
Manuel Carrasco Moñino has posted comments on this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Patch Set 1: Actually you could have submitted a new patch set to this issue instead of abandoning it and opening a new one. git commit --amend -a git push origin HEAD:refs/for/master But it's ok a new one as well. -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Redoing existing svn patch https://codereview.appspot.com/61...
James Horsley has posted comments on this change. Change subject: Redoing existing svn patch https://codereview.appspot.com/6132056/ on new git repo to work with gerrit. .. Patch Set 1: Will remember for next time. Thanks! -- To view, visit https://gwt-review.googlesource.com/3210 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89d87d39e38b8f1df045494cbe655a44849a650b Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: James Horsley james.hors...@gmail.com Gerrit-Reviewer: James Horsley james.hors...@gmail.com Gerrit-Reviewer: Manuel Carrasco Moñino manuel.carrasc...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] GWT style: Trailing spaces
Hi All, This thread is to continue a conversation in gerrit [1] about trailing spaces at the end of lines. GWT convention is not to leave spaces at the end of lines, but some IDEs add them by default like Eclipse in empty javadoc lines. Maybe we want to relax this rule, or perhaps we could remove this warning from gerrit, I think it's a bit upsetting seeing those spaces in red. - Manolo [1] https://gwt-review.googlesource.com/#/c/1031/1/dev/core/src/com/google/gwt/util/tools/shared/StringUtils.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: adding compare for several number types -Byte.compare -...
Goktug Gokdogan has posted comments on this change.
Change subject: adding compare for several number types -Byte.compare
-Short.compare -Integer.compare -Long.compare -Float.compare (Double
already exists) fixes issue 7998
..
Patch Set 9:
(4 comments)
File user/super/com/google/gwt/emul/java/lang/Float.java
Line 37: if (isNaN(x)) {
Why do you need to do something like that?
Following should work fine:
// All these checks should be false if x or y isNaN
if(x y) return -1;
if(x y) return 1;
if(x == y) return 0;
// below same isNaN check as before
if( isNaN(x) )
File user/super/com/google/gwt/emul/java/lang/Short.java
Line 37: return Integer.compare(x, y);
One should never rely on it for sure, but if somehow they rely on it, it
will work or fail consistently in both production and dev mode (i.e. less
surprises).
In general, it is best to not diverge prod vs dev if there is no good
reason to do so (like a big performance hit).
File user/test/com/google/gwt/emultest/java/lang/FloatTest.java
Line 81: }
I guess there is no -0 in js and in that case there is not much to do,
On the other hand, I'm not very familiar how we handle numerical difference
in js vs java. Thomas? John?
File user/test/com/google/gwt/emultest/java/lang/IntegerTest.java
Line 120: assertEquals(0, Integer.compare(1, 1));
I think we need to but we can create a bug and defer it to another time.
John Thomas, any input here?
--
To view, visit https://gwt-review.googlesource.com/3180
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib33c93ff0fb3f7e4b93994a29d6e2a65898be246
Gerrit-PatchSet: 9
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Add NavigableSet, NavigableMap to GWT and retrofit TreeMap and TreeSet to implement it. (issue1839803)
On 2013/06/04 09:01:51, tbroyer wrote: Can someone move that patch over to Gerrit? Would you prefer that I do it? (BTW, any reason this hadn't been reviewed yet?) No particular reason other than it dropping off the radar with other stuff going on. Of course we will want unit tests for this. http://gwt-code-reviews.appspot.com/1839803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Re: Add NavigableSet, NavigableMap to GWT and retrofit TreeMap and TreeSet to implement it. (issue1839803)
Please go ahead and move it, but with a couple of team members away we probably won't get to it this week. http://gwt-code-reviews.appspot.com/1839803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [gwt-contrib] GWT style: Trailing spaces
In Eclipse, I use auto-format on save for edited lines. If it is a javadoc, it forces you to use correct javadoc tags however for regular multiine comments if you do some ascii art, then auto-format can mess it up. In those cases, I simply press Ctrl+Z which just reverts the last auto-format. It is not ideal but it is reasonable to work with for me. On Tue, Jun 4, 2013 at 11:23 AM, Manuel Carrasco Moñino man...@apache.orgwrote: Hi All, This thread is to continue a conversation in gerrit [1] about trailing spaces at the end of lines. GWT convention is not to leave spaces at the end of lines, but some IDEs add them by default like Eclipse in empty javadoc lines. Maybe we want to relax this rule, or perhaps we could remove this warning from gerrit, I think it's a bit upsetting seeing those spaces in red. - Manolo [1] https://gwt-review.googlesource.com/#/c/1031/1/dev/core/src/com/google/gwt/util/tools/shared/StringUtils.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects
Hello John A. Tamplin, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3184 to look at the new patch set (#7). Change subject: Emulate java.util.Objects .. Emulate java.util.Objects Fixes issue 8173 Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 --- M user/super/com/google/gwt/emul/java/util/Arrays.java A user/super/com/google/gwt/emul/java/util/Objects.java M user/test/com/google/gwt/emultest/EmulSuite.java A user/test/com/google/gwt/emultest/java/util/ObjectsTest.java 4 files changed, 213 insertions(+), 58 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3184 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects
Andrey Korzhevskiy has posted comments on this change.
Change subject: Emulate java.util.Objects
..
Patch Set 3:
(2 comments)
File user/super/com/google/gwt/emul/java/util/Arrays.java
Line 414: static boolean deepEquals0(Object obj1, Object obj2) {
Done
Line 414: static boolean deepEquals0(Object obj1, Object obj2) {
Done
--
To view, visit https://gwt-review.googlesource.com/3184
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599
Gerrit-PatchSet: 3
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Andrey Korzhevskiy a.korzhevs...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: John A. Tamplin j...@jaet.org
Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com
Gerrit-Reviewer: Ray Cromwell cromwell...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Emulate java.util.Objects
John A. Tamplin has posted comments on this change. Change subject: Emulate java.util.Objects .. Patch Set 7: (2 comments) LGTM with a couple of nits. File user/super/com/google/gwt/emul/java/util/Objects.java Line 2: * Copyright 2008 Google Inc. Copyright date is wrong again. File user/test/com/google/gwt/emultest/java/util/ObjectsTest.java Line 2: * Copyright 2008 Google Inc. Copyright date. -- To view, visit https://gwt-review.googlesource.com/3184 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15a10e7c52eb39baac2c22b9f6596ad0a5c1c599 Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Andrey Korzhevskiy a.korzhevs...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Ray Cromwell cromwell...@gmail.com Gerrit-Reviewer: Ray Cromwell cromwell...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes delegation of event from TextBox event handler insid...
Goktug Gokdogan has posted comments on this change.
Change subject: Removes delegation of event from TextBox event handler
inside SuggestBox.
..
Patch Set 2:
(1 comment)
File user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
Line 375: public void testKeyDownEvent() {
Done. (added a reference to the issue)
--
To view, visit https://gwt-review.googlesource.com/3141
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I70752f24667a83bee208f31f37ec63d79ec8b1b8
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Patrick Tucker tucker...@gmail.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes delegation of event from TextBox event handler insid...
Hello Leeroy Jenkins, Thomas Broyer, Patrick Tucker, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/3141 to look at the new patch set (#3). Change subject: Removes delegation of event from TextBox event handler inside SuggestBox. .. Removes delegation of event from TextBox event handler inside SuggestBox. The events are already fired in SuggestBox as it is a composite, additional delegation was causing events to be fired twice. Bug: Issue 3533 Original author: Patrick Tucker Change-Id: I70752f24667a83bee208f31f37ec63d79ec8b1b8 Review-Link: https://gwt-review.googlesource.com/#/c/3141/ --- M user/src/com/google/gwt/user/client/ui/SuggestBox.java M user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java 2 files changed, 44 insertions(+), 10 deletions(-) -- To view, visit https://gwt-review.googlesource.com/3141 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I70752f24667a83bee208f31f37ec63d79ec8b1b8 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Patrick Tucker tucker...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Revert Adds onEnsureDebugId delegation to Composite.
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Revert Adds onEnsureDebugId delegation to Composite.
..
Revert Adds onEnsureDebugId delegation to Composite.
This reverts commit ff027f069482154b94c5b17434824992017d0f23
Change-Id: Id162c4e9b553a5981f09d26a3d1112dbf085825e
---
M user/src/com/google/gwt/user/client/ui/Composite.java
1 file changed, 0 insertions(+), 5 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Goktug Gokdogan: Looks good to me, approved
diff --git a/user/src/com/google/gwt/user/client/ui/Composite.java
b/user/src/com/google/gwt/user/client/ui/Composite.java
index 8faab75..257832d 100644
--- a/user/src/com/google/gwt/user/client/ui/Composite.java
+++ b/user/src/com/google/gwt/user/client/ui/Composite.java
@@ -184,11 +184,6 @@
widget.onDetach();
}
}
-
- @Override
- protected void onEnsureDebugId(String baseID) {
-widget.onEnsureDebugId(baseID);
- }
@Override
protected Element resolvePotentialElement() {
--
To view, visit https://gwt-review.googlesource.com/3151
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id162c4e9b553a5981f09d26a3d1112dbf085825e
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka danku...@google.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups GWT Contributors group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Removes delegation of event from TextBox event handler insid...
Goktug Gokdogan has submitted this change and it was merged.
Change subject: Removes delegation of event from TextBox event handler
inside SuggestBox.
..
Removes delegation of event from TextBox event handler inside SuggestBox.
The events are already fired in SuggestBox as it is a composite, additional
delegation was causing events to be fired twice.
Bug: Issue 3533
Original author: Patrick Tucker
Change-Id: I70752f24667a83bee208f31f37ec63d79ec8b1b8
Review-Link: https://gwt-review.googlesource.com/#/c/3141/
---
M user/src/com/google/gwt/user/client/ui/SuggestBox.java
M user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
2 files changed, 44 insertions(+), 10 deletions(-)
Approvals:
Leeroy Jenkins: Verified
Goktug Gokdogan: Looks good to me, approved
diff --git a/user/src/com/google/gwt/user/client/ui/SuggestBox.java
b/user/src/com/google/gwt/user/client/ui/SuggestBox.java
index 818e9b2..7d87fb2 100644
--- a/user/src/com/google/gwt/user/client/ui/SuggestBox.java
+++ b/user/src/com/google/gwt/user/client/ui/SuggestBox.java
@@ -21,7 +21,6 @@
import com.google.gwt.editor.client.IsEditor;
import com.google.gwt.editor.client.LeafValueEditor;
import com.google.gwt.editor.client.adapters.TakesValueEditor;
-import com.google.gwt.event.dom.client.HandlesAllKeyEvents;
import com.google.gwt.event.dom.client.HasAllKeyHandlers;
import com.google.gwt.event.dom.client.KeyCodes;
import com.google.gwt.event.dom.client.KeyDownEvent;
@@ -1119,8 +1118,7 @@
}
private void addEventsToTextBox() {
-class TextBoxEvents extends HandlesAllKeyEvents implements
-ValueChangeHandlerString {
+class TextBoxEvents implements KeyDownHandler, KeyUpHandler,
ValueChangeHandlerString {
public void onKeyDown(KeyDownEvent event) {
switch (event.getNativeKeyCode()) {
@@ -1140,17 +1138,11 @@
}
break;
}
-delegateEvent(SuggestBox.this, event);
- }
-
- public void onKeyPress(KeyPressEvent event) {
-delegateEvent(SuggestBox.this, event);
}
public void onKeyUp(KeyUpEvent event) {
// After every user key input, refresh the popup's suggestions.
refreshSuggestions();
-delegateEvent(SuggestBox.this, event);
}
public void onValueChange(ValueChangeEventString event) {
@@ -1159,7 +1151,8 @@
}
TextBoxEvents events = new TextBoxEvents();
-events.addKeyHandlersTo(box);
+box.addKeyDownHandler(events);
+box.addKeyUpHandler(events);
box.addValueChangeHandler(events);
}
diff --git a/user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
b/user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
index 503c96e..cbb0e1b 100644
--- a/user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
+++ b/user/test/com/google/gwt/user/client/ui/SuggestBoxTest.java
@@ -17,6 +17,11 @@
import com.google.gwt.dom.client.Document;
import com.google.gwt.dom.client.Element;
+import com.google.gwt.dom.client.NativeEvent;
+import com.google.gwt.event.dom.client.KeyDownEvent;
+import com.google.gwt.event.dom.client.KeyDownHandler;
+import com.google.gwt.event.dom.client.KeyUpEvent;
+import com.google.gwt.event.dom.client.KeyUpHandler;
import
com.google.gwt.user.client.ui.MultiWordSuggestOracle.MultiWordSuggestion;
import com.google.gwt.user.client.ui.SuggestBox.DefaultSuggestionDisplay;
import com.google.gwt.user.client.ui.SuggestBox.SuggestionCallback;
@@ -367,6 +372,42 @@
assertTrue(b.getParent() == box);
}
+ /**
+ * See https://code.google.com/p/google-web-toolkit/issues/detail?id=3533
+ */
+ public void testKeyDownEvent() {
+final int[] eventFireCount = {0};
+SuggestBox box = new SuggestBox();
+RootPanel.get().add(box);
+box.addKeyDownHandler(new KeyDownHandler() {
+ @Override
+ public void onKeyDown(KeyDownEvent event) {
+eventFireCount[0]++;
+ }
+});
+NativeEvent e = Document.get().createKeyDownEvent(false, false, false,
false, 'g');
+box.getElement().dispatchEvent(e);
+assertEquals(1, eventFireCount[0]);
+ }
+
+ /**
+ * See https://code.google.com/p/google-web-toolkit/issues/detail?id=3533
+ */
+ public void testKeyUpEvent() {
+final int[] eventFireCount = {0};
+SuggestBox box = new SuggestBox();
+RootPanel.get().add(box);
+box.addKeyUpHandler(new KeyUpHandler() {
+ @Override
+ public void onKeyUp(KeyUpEvent event) {
+eventFireCount[0]++;
+ }
+});
+NativeEvent e = Document.get().createKeyUpEvent(false, false, false,
false, 'g');
+box.getElement().dispatchEvent(e);
+assertEquals(1, eventFireCount[0]);
+ }
+
protected SuggestBox createSuggestBox() {
MultiWordSuggestOracle oracle = createOracle();
return new SuggestBox(oracle, new TextBox(), new
TestSuggestionDisplay());
--
To view, visit
[gwt-contrib] Change in gwt[master]: Removes delegation of event from TextBox event handler insid...
Goktug Gokdogan has posted comments on this change. Change subject: Removes delegation of event from TextBox event handler inside SuggestBox. .. Patch Set 3: Code-Review+2 (Just added a reference to issue after last patch) -- To view, visit https://gwt-review.googlesource.com/3141 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I70752f24667a83bee208f31f37ec63d79ec8b1b8 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Leeroy Jenkins jenk...@gwtproject.org Gerrit-Reviewer: Patrick Tucker tucker...@gmail.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups GWT Contributors group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolkit-contributors+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[gwt-contrib] Change in gwt[master]: Fixes JRawType#getImplementedMethods to return correct signa...
Goktug Gokdogan has uploaded a new change for review.
https://gwt-review.googlesource.com/3230
Change subject: Fixes JRawType#getImplementedMethods to return correct
signature for inherited methods
..
Fixes JRawType#getImplementedMethods to return correct signature for
inherited methods
Original author forgot to override some methods which was causing
getImplementedMethods
to not erase the types for the methods inherited from superclasses.
Bugs: Issue 8177
Change-Id: I7e2c4cf3d2d0bc1e50ecab1e257a6ac1d0e496d0
---
M dev/core/src/com/google/gwt/core/ext/typeinfo/JGenericType.java
M dev/core/src/com/google/gwt/dev/javac/typemodel/JRawType.java
M dev/core/test/com/google/gwt/dev/javac/typemodel/JRawTypeTest.java
A dev/core/test/com/google/gwt/dev/javac/typemodel/test/MyArrayList.java
4 files changed, 53 insertions(+), 3 deletions(-)
diff --git
a/dev/core/src/com/google/gwt/core/ext/typeinfo/JGenericType.java
b/dev/core/src/com/google/gwt/core/ext/typeinfo/JGenericType.java
index 83700ef..bdbe1a0 100644
--- a/dev/core/src/com/google/gwt/core/ext/typeinfo/JGenericType.java
+++ b/dev/core/src/com/google/gwt/core/ext/typeinfo/JGenericType.java
@@ -22,5 +22,10 @@
JParameterizedType asParameterizedByWildcards();
+ /**
+ * Returns the raw type for this generic type. The raw type removes
all 'generics' information
+ * from the class. i.e. {@code void a1(ListT)} {@code void
a2(ListString)} becomes
+ * {@code void a1(List)} {@code void a2(List))} respectively.
+ */
JRawType getRawType();
}
diff --git a/dev/core/src/com/google/gwt/dev/javac/typemodel/JRawType.java
b/dev/core/src/com/google/gwt/dev/javac/typemodel/JRawType.java
index 477..585cb7f 100644
--- a/dev/core/src/com/google/gwt/dev/javac/typemodel/JRawType.java
+++ b/dev/core/src/com/google/gwt/dev/javac/typemodel/JRawType.java
@@ -20,6 +20,7 @@
import java.util.ArrayList;
import java.util.List;
+import java.util.Map;
/**
* Represents a raw type; that is a generic type with no type arguments.
@@ -104,6 +105,18 @@
}
@Override
+ protected void getInheritableMethodsOnSuperclassesAndThisClass(
+ MapString, JMethod methodsBySignature) {
+
members.getInheritableMethodsOnSuperclassesAndThisClass(methodsBySignature);
+ }
+
+ @Override
+ protected void
getInheritableMethodsOnSuperinterfacesAndMaybeThisInterface(
+ MapString, JMethod methodsBySignature) {
+
members.getInheritableMethodsOnSuperinterfacesAndMaybeThisInterface(methodsBySignature);
+ }
+
+ @Override
public JMethod[] getInheritableMethods() {
return members.getInheritableMethods();
}
diff --git
a/dev/core/test/com/google/gwt/dev/javac/typemodel/JRawTypeTest.java
b/dev/core/test/com/google/gwt/dev/javac/typemodel/JRawTypeTest.java
index 919ee08..072e64e 100644
--- a/dev/core/test/com/google/gwt/dev/javac/typemodel/JRawTypeTest.java
+++ b/dev/core/test/com/google/gwt/dev/javac/typemodel/JRawTypeTest.java
@@ -18,6 +18,7 @@
import com.google.gwt.core.ext.TreeLogger;
import com.google.gwt.core.ext.UnableToCompleteException;
import com.google.gwt.core.ext.typeinfo.NotFoundException;
+import com.google.gwt.dev.javac.typemodel.test.MyArrayList;
import com.google.gwt.dev.javac.typemodel.test.MyCustomList;
import com.google.gwt.dev.javac.typemodel.test.MyIntegerList;
import com.google.gwt.dev.javac.typemodel.test.MyList;
@@ -49,8 +50,25 @@
}
@Override
- public void testGetInheritableMethods() {
-// TODO Auto-generated method stub
+ public void testGetInheritableMethods() throws NotFoundException {
+JMethod addMethod = null;
+JMethod indexedAddMethod = null;
+for (JMethod jMethod : getTestType().getInheritableMethods()) {
+ if (jMethod.getName().equals(add)) {
+if (jMethod.getParameters().length == 1) {
+ assertNull(addMethod);
+ addMethod = jMethod;
+} else {
+ assertEquals(2, jMethod.getParameters().length);
+ assertNull(indexedAddMethod);
+ indexedAddMethod = jMethod;
+}
+ }
+}
+
+JClassType javaLangObject =
moduleContext.getOracle().getJavaLangObject();
+assertEquals(javaLangObject, addMethod.getParameters()[0].getType());
+assertEquals(javaLangObject,
indexedAddMethod.getParameters()[1].getType());
}
@Override
@@ -111,7 +129,7 @@
@Override
protected JRawType getTestType() throws NotFoundException {
TypeOracle oracle = moduleContext.getOracle();
-JClassType testType = oracle.getType(ArrayList.class.getName());
+JClassType testType = oracle.getType(MyArrayList.class.getName());
return testType.isGenericType().getRawType();
}
}
diff --git
a/dev/core/test/com/google/gwt/dev/javac/typemodel/test/MyArrayList.java
b/dev/core/test/com/google/gwt/dev/javac/typemodel/test/MyArrayList.java
new file mode 100644
index 000..26a5756
--- /dev/null
+++
