[gwt-contrib] Removing processElementClicked from gen2.FastTree
Reviewers: jlabanca,
Description:
http://code.google.com/p/google-web-toolkit-incubator/issues/detail?id=232
Please review this at http://gwt-code-reviews.appspot.com/14802
Affected files:
client/FastTree.java
Index: client/FastTree.java
===
--- client/FastTree.java(revision 1543)
+++ client/FastTree.java(working copy)
@@ -599,25 +599,6 @@
}
/**
- * This is called when a valid selectable element is clicked in the tree.
- * Subclasses can override this method to decide whether or not FastTree
- * should keep processing the element clicked. For example, a subclass
may
- * decide to return false for this method if selecting a new item in the
tree
- * is subject to asynchronous approval from other components of the
- * application.
- *
- * @returns true if element should be processed normally, false
otherwise.
- * Default returns true.
- *
- * @deprecated Add a beforeSelectionHandler by calling
- * addBeforeSelectionHandler instead.
- */
- @Deprecated
- protected boolean processElementClicked(FastTreeItem item) {
-return true;
- }
-
- /**
* Supply a decorator for the fast tree.
*
* @return a decorator
@@ -789,9 +770,7 @@
disableSelection(target);
return;
}
- if (processElementClicked(item)) {
-onSelection(item, true, !shouldTreeDelegateFocusToElement(target));
- }
+ onSelection(item, true, !shouldTreeDelegateFocusToElement(target));
}
return;
}
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: JavaScriptException with 1.6.2
On 26 mar, 19:18, John Tamplin j...@google.com wrote: On Thu, Mar 26, 2009 at 1:40 PM, Scott Blum sco...@google.com wrote: That's not good it looks like Nicolas found an object for which trying to evaluate (!!o.nodeType) throws an exception. If my atrophied high-school French is correct, I believe the error is that o is null at that point. It actually says that 'nodeType' (not 'o'!) is Null or is not an object. The thing is: I cannot understand why IE (this looks like an IE exception message, don't you think?) would throw such an exception while evaluating !! on such a null/undefined (it would effectively throw if 'o' were null, but it would say that 'o' is null or is not an object, or if we were trying to get or set a property or call a method on o.nodeType). Am I wrong? --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: RR: testing -noserver hosted mode
Thanks, John! It's in at r5094 and r5095. Comments inline: On Thu, Mar 26, 2009 at 4:31 PM, John Tamplin j...@google.com wrote: Passing the parameter all the way down this way is ugly, but I don't know of any better ways to do it. Agreed. I would prefer the new ArgHandler to be a top-level class, but I see the others are inlined as well so I am ok with keeping it. Also agreed, so I left it. I don't see the build.xml changes for test.noserver. Shoot, that part of the patch got lost. I recreated these per our discussion. Lex --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5094 - Adds a test for -noserver hosted mode.
Author: sp...@google.com
Date: Fri Mar 27 07:58:53 2009
New Revision: 5094
Added:
trunk/user/src/com/google/gwt/junit/RunStyleNoServerHosted.java
(contents, props changed)
Modified:
trunk/user/build.xml
trunk/user/src/com/google/gwt/junit/JUnitShell.java
trunk/user/src/com/google/gwt/junit/RunStyle.java
Log:
Adds a test for -noserver hosted mode.
Review by: jat
Modified: trunk/user/build.xml
==
--- trunk/user/build.xml(original)
+++ trunk/user/build.xmlFri Mar 27 07:58:53 2009
@@ -13,11 +13,14 @@
fileset id=default.emma.tests dir=${javac.junit.out}
includes=**/EmmaClassLoadingTest.class /
-
+
fileset id=default.hosted.emma.tests dir=${javac.junit.out}
excludes=**/CoverageTest.class,**/CompilerSuite.class
includes=${gwt.junit.emmatestcase.includes} /
!-- everything succeeds except CoverageTest.java. It fails due to a
javac bug in sun/OpenJDK's Java. See the file contents for details --
-
+
+ fileset id=default.noserver.tests dir=${javac.junit.out}
includes=**/IFrameLinkerTest.class /
+ !-- Only IFrameLinker actually supports -noserver mode; run the other
linker tests if and when they are supported --
+
!--
Default web mode test cases
--
@@ -49,11 +52,11 @@
!--
Compile test code for dev/core to pick up TypeOracleTestUtils and
others.
- --
+ --
target name=compile.dev.core.tests description=Compiles test
dependencies in dev/core
gwt.ant dir=../dev/core target=compile.tests /
/target
-
+
target name=compile.tests depends=compile.dev.core.tests
description=Compiles the test code for this project
mkdir dir=${javac.junit.out} /
gwt.javac srcdir=test excludes=com/google/gwt/langtest/**
destdir=${javac.junit.out}
@@ -126,11 +129,19 @@
pathelement location=${gwt.build}/out/dev/core/bin-test /
pathelement location=${gwt.tools.redist}/emma/emma.jar /
/extraclasspaths
-/gwt.junit
+/gwt.junit
+ /target
+
+ target name=test.noserver depends=compile, compile.tests
description=Run noserver hosted-mode tests for this project.
+gwt.junit test.args=${test.args}
test.out=${junit.out}/${build.host.platform}-noserver-mode
test.cases=default.noserver.tests
+ extraclasspaths
+pathelement location=${gwt.build}/out/dev/core/bin-test /
+ /extraclasspaths
+/gwt.junit
/target
target name=test.web depends=compile, compile.tests
description=Run only web-mode tests for this project.
-gwt.junit test.args=${test.args} -out www -web
test.out=${junit.out}/${build.host.platform}-web-mode
test.cases=default.web.tests
+gwt.junit test.args=${test.args} -out www -web
test.out=${junit.out}/${build.host.platform}-web-mode
test.cases=default.web.tests
extraclasspaths
pathelement location=${gwt.build}/out/dev/core/bin-test /
/extraclasspaths
@@ -167,6 +178,7 @@
!-- remoteweb-test is a no-op unless gwt.remote.browsers is defined
--
antcall target=remoteweb-test/
antcall target=test.hosted/
+ antcall target=test.noserver/
antcall target=test.web/
antcall target=test.web.disableClassMetadata/
antcall target=test.web.draft/
@@ -179,6 +191,6 @@
delete file=${project.lib} /
/target
target name=presubmit depends=test, checkstyle description=runs
the gwt api checker, user checkstyle, and user tests
- gwt.ant dir=.. target=apicheck-nobuild/
+gwt.ant dir=.. target=apicheck-nobuild/
/target
/project
Modified: trunk/user/src/com/google/gwt/junit/JUnitShell.java
==
--- trunk/user/src/com/google/gwt/junit/JUnitShell.java (original)
+++ trunk/user/src/com/google/gwt/junit/JUnitShell.java Fri Mar 27 07:58:53
2009
@@ -116,6 +116,25 @@
registerHandler(new ArgHandlerFlag() {
@Override
public String getPurpose() {
+ return Causes your test to run in -noserver hosted mode
(defaults to hosted mode);
+}
+
+@Override
+public String getTag() {
+ return -noserver;
+}
+
+@Override
+public boolean setFlag() {
+ runStyle = new RunStyleNoServerHosted(JUnitShell.this);
+ numClients = 1;
+ return true;
+}
+ });
+
+ registerHandler(new ArgHandlerFlag() {
+@Override
+public String getPurpose() {
return Causes your test to run in web (compiled) mode (defaults
to hosted mode);
}
@@ -587,6 +606,11 @@
}
return !messageQueue.hasResult();
+ }
+
+ @Override
+ protected boolean shouldAutoGenerateResources() {
+return runStyle.shouldAutoGenerateResources();
}
@Override
Modified: trunk/user/src/com/google/gwt/junit/RunStyle.java
[gwt-contrib] RR : Fix ImageResource de-duplication
The attached patch re-adds image de-duplication to ClientBundle's ImageBundleBuilder. (It was there at some point, but disappeared along the way). The patch also ensures that the ImageResource test is run in a no-inlining permutation, which would have allowed me to see this error on my mac. Diffstat: src/com/google/gwt/resources/rg/ImageBundleBuilder.java | 29 25 +4 - 0 ! test/com/google/gwt/resources/ResourcesNoInlining.gwt.xml | 17 17 +0 - 0 ! test/com/google/gwt/resources/ResourcesSuite.java |5 3 + 2 - 0 ! test/com/google/gwt/resources/client/ImageResourceNoInliningTest.java | 26 26 +0 - 0 ! test/com/google/gwt/resources/client/ImageResourceTest.java |4 2 + 2 - 0 ! 5 files changed, 73 insertions(+), 8 deletions(-) -- Bob Vawter Google Web Toolkit Team --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~--- imageBundleBuilder_r5087.patch Description: Binary data
[gwt-contrib] [google-web-toolkit commit] r5095 - The rest of the implementation of -noserver hosted
Author: sp...@google.com
Date: Fri Mar 27 08:09:11 2009
New Revision: 5095
Modified:
trunk/dev/core/src/com/google/gwt/dev/GWTShell.java
trunk/dev/core/src/com/google/gwt/dev/shell/GWTShellServlet.java
trunk/dev/core/src/com/google/gwt/dev/shell/tomcat/EmbeddedTomcatServer.java
Log:
The rest of the implementation of -noserver hosted
mode test. r5094 was incomplete.
Review by: jat
Modified: trunk/dev/core/src/com/google/gwt/dev/GWTShell.java
==
--- trunk/dev/core/src/com/google/gwt/dev/GWTShell.java (original)
+++ trunk/dev/core/src/com/google/gwt/dev/GWTShell.java Fri Mar 27 08:09:11
2009
@@ -234,7 +234,7 @@
protected int doStartUpServer() {
// TODO(bruce): make tomcat work in terms of the modular launcher
String whyFailed = EmbeddedTomcatServer.start(getTopLogger(),
getPort(),
-options);
+options, shouldAutoGenerateResources());
// TODO(bruce): test that we can remove this old approach in favor of
// a better, logger-based error reporting
@@ -259,5 +259,15 @@
* magic?
*/
return false;
+ }
+
+ /**
+ * Whether this shell should auto-generate GWT resources when it
recognizes
+ * requests for them. By default this is true. Subclasses can disable
such
+ * auto-generation and make this servlet appear to be like any arbitrary
web
+ * server that knows nothing about GWT.
+ */
+ protected boolean shouldAutoGenerateResources() {
+return true;
}
}
Modified: trunk/dev/core/src/com/google/gwt/dev/shell/GWTShellServlet.java
==
--- trunk/dev/core/src/com/google/gwt/dev/shell/GWTShellServlet.java
(original)
+++ trunk/dev/core/src/com/google/gwt/dev/shell/GWTShellServlet.javaFri
Mar 27 08:09:11 2009
@@ -116,12 +116,12 @@
private int nextRequestId;
- private WorkDirs workDirs;
-
private final Object requestIdLock = new Object();
private TreeLogger topLogger;
+ private WorkDirs workDirs;
+
public GWTShellServlet() {
initMimeTypes();
}
@@ -409,9 +409,11 @@
logger = logger.branch(TreeLogger.TRACE, msg, null);
// Handle auto-generation of resources.
-if (autoGenerateResources(request, response, logger, partialPath,
-moduleName)) {
- return;
+if (shouldAutoGenerateResources()) {
+ if (autoGenerateResources(request, response, logger, partialPath,
+ moduleName)) {
+return;
+ }
}
URL foundResource = null;
@@ -419,20 +421,22 @@
// Look for the requested file on the public path.
//
ModuleDef moduleDef = getModuleDef(logger, moduleName);
- Resource publicResource = moduleDef.findPublicFile(partialPath);
- if (publicResource != null) {
-foundResource = publicResource.getURL();
- }
+ if (shouldAutoGenerateResources()) {
+Resource publicResource = moduleDef.findPublicFile(partialPath);
+if (publicResource != null) {
+ foundResource = publicResource.getURL();
+}
- if (foundResource == null) {
-// Look for public generated files
-File shellDir = getShellWorkDirs().getShellPublicGenDir(moduleDef);
-File requestedFile = new File(shellDir, partialPath);
-if (requestedFile.exists()) {
- try {
-foundResource = requestedFile.toURI().toURL();
- } catch (MalformedURLException e) {
-// ignore since it was speculative anyway
+if (foundResource == null) {
+ // Look for public generated files
+ File shellDir =
getShellWorkDirs().getShellPublicGenDir(moduleDef);
+ File requestedFile = new File(shellDir, partialPath);
+ if (requestedFile.exists()) {
+try {
+ foundResource = requestedFile.toURI().toURL();
+} catch (MalformedURLException e) {
+ // ignore since it was speculative anyway
+}
}
}
}
@@ -884,6 +888,16 @@
HttpHeaders.CACHE_CONTROL_MAXAGE + cacheTime);
String expiresString = HttpHeaders.toInternetDateFormat(expires);
response.setHeader(HttpHeaders.EXPIRES, expiresString);
+ }
+
+ private boolean shouldAutoGenerateResources() {
+ServletContext servletContext = getServletContext();
+final String attr
= com.google.gwt.dev.shell.shouldAutoGenerateResources;
+Boolean attrValue = (Boolean) servletContext.getAttribute(attr);
+if (attrValue == null) {
+ return true;
+}
+return attrValue;
}
private void streamOut(InputStream in, OutputStream out, int bufferSize)
Modified:
trunk/dev/core/src/com/google/gwt/dev/shell/tomcat/EmbeddedTomcatServer.java
==
---
trunk/dev/core/src/com/google/gwt/dev/shell/tomcat/EmbeddedTomcatServer.java
[gwt-contrib] Re: RR : Fix ImageResource de-duplication
Kindly enable my tooling dependency: http://gwt-code-reviews.appspot.com/new rjrjr On Fri, Mar 27, 2009 at 8:21 AM, BobV b...@google.com wrote: The attached patch re-adds image de-duplication to ClientBundle's ImageBundleBuilder. (It was there at some point, but disappeared along the way). The patch also ensures that the ImageResource test is run in a no-inlining permutation, which would have allowed me to see this error on my mac. Diffstat: src/com/google/gwt/resources/rg/ImageBundleBuilder.java | 29 25 +4 - 0 ! test/com/google/gwt/resources/ResourcesNoInlining.gwt.xml | 17 17 +0 - 0 ! test/com/google/gwt/resources/ResourcesSuite.java |5 3 + 2 - 0 ! test/com/google/gwt/resources/client/ImageResourceNoInliningTest.java | 26 26 +0 - 0 ! test/com/google/gwt/resources/client/ImageResourceTest.java |4 2 + 2 - 0 ! 5 files changed, 73 insertions(+), 8 deletions(-) -- Bob Vawter Google Web Toolkit Team --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: JavaScriptException with 1.6.2
Do you know what event this was? What do you do with the popup to get it to trigger? Or does it just happen with no user interaction? On Fri, Mar 27, 2009 at 11:46 AM, nicolas de loof nicolas.del...@gmail.comwrote: Some more infos : We got this exception running in hosted mode browser (with -noserver) on windows No error when using an empty PopupPanel, also fine when containing a label, but fails when including a Table. Hope this helps ... On Fri, Mar 27, 2009 at 3:57 PM, Thomas Broyer t.bro...@gmail.com wrote: On 26 mar, 19:18, John Tamplin j...@google.com wrote: On Thu, Mar 26, 2009 at 1:40 PM, Scott Blum sco...@google.com wrote: That's not good it looks like Nicolas found an object for which trying to evaluate (!!o.nodeType) throws an exception. If my atrophied high-school French is correct, I believe the error is that o is null at that point. It actually says that 'nodeType' (not 'o'!) is Null or is not an object. The thing is: I cannot understand why IE (this looks like an IE exception message, don't you think?) would throw such an exception while evaluating !! on such a null/undefined (it would effectively throw if 'o' were null, but it would say that 'o' is null or is not an object, or if we were trying to get or set a property or call a method on o.nodeType). Am I wrong? --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] JVM crashes when using GWT compiler under Java 6 update 7 JVM
[java] Compiling module com.google.gwt.benchmarks.viewer.ReportViewer [java] # [java] # An unexpected error has been detected by Java Runtime Environment: [java] # [java] # SIGSEGV (0xb) at pc=0x0625665c, pid=17105, tid=3762477968 [java] # [java] # Java VM: Java HotSpot(TM) Server VM (10.0-b23 mixed mode linux-x86) [java] # Problematic frame: [java] # V [libjvm.so+0x25665c] [java] # [java] # An error report file with more information is saved as: [java] # /home/vlovich/workspace/gwt/tools/benchmark-viewer/hs_err_pid17105.log [java] # [java] # If you would like to submit a bug report, please visit: [java] # http://java.sun.com/webapps/bugreport/crash.jsp [java] # The crash happened outside the Java Virtual Machine in native code. [java] # See problematic frame for where to report the bug. [java] # This is kind of annoying because GWT fails to build with the newer JDKs due to the issue mentioned before with the change to generics. So it's a two step workaround: Use the older sun JDK to compile the classes after it crashes, use run ant again with the newer JDK so that the GWT compiler doesn't crash the VM. This also happens if I try to use the older JDK with my projects, but that's not really an issue since I just use the latest OpenJDK in the Ubuntu repos. Might be relevant that I'm using 64-bit jdks. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Fix ImageBundleBuilder de-duplication
Misused rietveld and dropped my comments: http://gwt-code-reviews.appspot.com/15802/diff/1/6 File user/src/com/google/gwt/resources/rg/ImageBundleBuilder.java (right): http://gwt-code-reviews.appspot.com/15802/diff/1/6#newcode434 Line 434: gwt.imageResource.maxBundleSize, 256); Please mention this new property in your commit description. Is there any place to document it? http://gwt-code-reviews.appspot.com/15802/diff/1/3 File user/test/com/google/gwt/resources/client/ImageResourceNoInliningTest.java (right): http://gwt-code-reviews.appspot.com/15802/diff/1/3#newcode19 Line 19: * Runs the ImageResource tests with inling disabled. How? By having an overridden module name? --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Fix ImageBundleBuilder de-duplication
http://gwt-code-reviews.appspot.com/15802 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Review: JsArrays patch
Scott, we already talked about this, but here's the patch for public review.
The basic goal is to surface the native length, sort, push, and shift
operators for JsArrays... I know you mentioned that IE6's push may be slower
than indexed extension, and thus a candidate for deferred binding, but I
wanted to get a basic implementation in first.
There should be only checkstyle changes from what we discussed (though that
obviously doesn't help the rest GWTC). I also added some checkstyle fixes
to JavaScriptObject, introduced by my c5082.
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Index: user/src/com/google/gwt/core/client/JsArrayString.java
===
--- user/src/com/google/gwt/core/client/JsArrayString.java (revision 5095)
+++ user/src/com/google/gwt/core/client/JsArrayString.java (working copy)
@@ -1,12 +1,12 @@
/*
* Copyright 2008 Google Inc.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the License); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
@@ -17,24 +17,24 @@
/**
* A simple wrapper around a homogeneous native array of string values.
- *
+ *
* This class may not be directly instantiated, and can only be returned from a
* native method. For example,
- *
+ *
* code
* native JsArrayString getNativeArray() /*-{
* return ['foo', 'bar', 'baz'];
* }-* /;
* /code
*/
-public class JsArrayString extends JavaScriptObject {
+public class JsArrayString extends JsArrayBase {
protected JsArrayString() {
}
/**
* Gets the value at a given index.
- *
+ *
* @param index the index to be retrieved
* @return the value at the given index, or codenull/code if none exists
*/
@@ -43,24 +43,31 @@
}-*/;
/**
- * Gets the length of the array.
- *
- * @return the array length
+ * call underlying push method.
*/
- public final native int length() /*-{
-return this.length;
+ public final native void push(String value) /*-{
+this.push(value);
}-*/;
/**
* Sets the value value at a given index.
- *
+ *
* If the index is out of bounds, the value will still be set. The array's
* length will be updated to encompass the bounds implied by the added value.
- *
+ *
* @param index the index to be set
* @param value the value to be stored
*/
public final native void set(int index, String value) /*-{
this[index] = value;
}-*/;
+
+ /**
+ * Shifts the first value off the array.
+ * @return the shifted value
+ */
+ public final native String shift() /*-{
+return this.shift();
+ }-*/;
+
}
Index: user/src/com/google/gwt/core/client/JsArrayBase.java
===
--- user/src/com/google/gwt/core/client/JsArrayBase.java (revision 0)
+++ user/src/com/google/gwt/core/client/JsArrayBase.java (revision 0)
@@ -0,0 +1,41 @@
+/*
+ * Copyright 2008 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may not
+ * use this file except in compliance with the License. You may obtain a copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package com.google.gwt.core.client;
+
+/**
+ * Common methods for JsArray... classes.
+ */
+public class JsArrayBase extends JavaScriptObject {
+
+ protected JsArrayBase() {
+ }
+
+ /**
+ * Gets the length of the array.
+ *
+ * @return the array length
+ */
+ public final native int length() /*-{
+return this.length;
+ }-*/;
+
+ /**
+ * direct mapping to underlying sort method.
+ */
+ public final native void sort(JavaScriptObject sortFunc) /*-{
+this.sort(sortFunc);
+ }-*/;
+}
Index: user/src/com/google/gwt/core/client/JsArray.java
===
--- user/src/com/google/gwt/core/client/JsArray.java (revision 5095)
+++ user/src/com/google/gwt/core/client/JsArray.java (working copy)
@@ -1,12 +1,12 @@
/*
* Copyright 2008 Google Inc.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the License); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the
[gwt-contrib] Re: Review: JsArrays patch
Let's not add this extra type JsArrayBase into the hierarchy. Why can't we just push the various methods down? We can always factor upward in the future. If we need shared implementation, we can factor that out into a package-private JsArrayImpl class. On Fri, Mar 27, 2009 at 1:28 PM, Freeland Abbott gwt.team.fabb...@gmail.com wrote: Scott, we already talked about this, but here's the patch for public review. The basic goal is to surface the native length, sort, push, and shift operators for JsArrays... I know you mentioned that IE6's push may be slower than indexed extension, and thus a candidate for deferred binding, but I wanted to get a basic implementation in first. There should be only checkstyle changes from what we discussed (though that obviously doesn't help the rest GWTC). I also added some checkstyle fixes to JavaScriptObject, introduced by my c5082. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] GWTC compiler disallows using a derivative of AsyncCallback on async interface declaration
I tried to use my own custom class that extends AsyncCallback in the async interface, the compiler told me that the async version didn't match the sync version. For instance: public interface NoResultCallback extends AsyncCallbackVoid. It's not really an issue, but I prefer to use the more precise type to get the compiler to statically check the code. Is this by design for a reason? --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: JVM crashes when using GWT compiler under Java 6 update 7 JVM
I can has hs_err_pid17105.log? On Fri, Mar 27, 2009 at 12:36 PM, Vitali Lovich vlov...@gmail.com wrote: [java] Compiling module com.google.gwt.benchmarks.viewer.ReportViewer [java] # [java] # An unexpected error has been detected by Java Runtime Environment: [java] # [java] # SIGSEGV (0xb) at pc=0x0625665c, pid=17105, tid=3762477968 [java] # [java] # Java VM: Java HotSpot(TM) Server VM (10.0-b23 mixed mode linux-x86) [java] # Problematic frame: [java] # V [libjvm.so+0x25665c] [java] # [java] # An error report file with more information is saved as: [java] # /home/vlovich/workspace/gwt/tools/benchmark-viewer/hs_err_pid17105.log [java] # [java] # If you would like to submit a bug report, please visit: [java] # http://java.sun.com/webapps/bugreport/crash.jsp [java] # The crash happened outside the Java Virtual Machine in native code. [java] # See problematic frame for where to report the bug. [java] # This is kind of annoying because GWT fails to build with the newer JDKs due to the issue mentioned before with the change to generics. So it's a two step workaround: Use the older sun JDK to compile the classes after it crashes, use run ant again with the newer JDK so that the GWT compiler doesn't crash the VM. This also happens if I try to use the older JDK with my projects, but that's not really an issue since I just use the latest OpenJDK in the Ubuntu repos. Might be relevant that I'm using 64-bit jdks. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Review: JsArrays patch
FWIW, in another little project I used a pattern for this that avoids
implementation inheritance that I call self-delegation.
Here's an example:
/** Not put API, but it includes the impl for al getters and setters for all
types. **/
final class JsArray extends JavaScriptObject {
...
public int getInt(int index) {
assert indexIsInBounds(index);
return getIntImpl(index);
}
public void setNumber(int index, double value) {
assert isNumber(value);
setNumberImpl(index, value);
}
private native int getIntImpl(int index) /*-{
return this[index];
}-*/;
private native void setNumberImpl(int index, double value) /*-{
this[index] = value;
}-*/;
...
}
/** Public API */
public final class IntArray extends DataStructure {
public static IntArray create() {
return JavaScriptObject.createArray().cast();
}
protected IntArray() {
}
public int get(int index) {
return this.JsArraycast().getInt(index);
}
public int getSize() {
return this.JsArraycast().getSize();
}
public void set(int index, int value) {
this.JsArraycast().setNumber(index, value);
}
}
/kel
On Fri, Mar 27, 2009 at 1:41 PM, Bruce Johnson br...@google.com wrote:
Let's not add this extra type JsArrayBase into the hierarchy. Why can't we
just push the various methods down? We can always factor upward in the
future. If we need shared implementation, we can factor that out into a
package-private JsArrayImpl class.
On Fri, Mar 27, 2009 at 1:28 PM, Freeland Abbott
gwt.team.fabb...@gmail.com wrote:
Scott, we already talked about this, but here's the patch for public
review.
The basic goal is to surface the native length, sort, push, and shift
operators for JsArrays... I know you mentioned that IE6's push may be slower
than indexed extension, and thus a candidate for deferred binding, but I
wanted to get a basic implementation in first.
There should be only checkstyle changes from what we discussed (though
that obviously doesn't help the rest GWTC). I also added some checkstyle
fixes to JavaScriptObject, introduced by my c5082.
--
If you received this communication by mistake, you are entitled to one free
ice cream cone on me. Simply print out this email including all relevant
SMTP headers and present them at my desk to claim your creamy treat. We'll
have a laugh at my emailing incompetence, and play a game of ping pong.
(offer may not be valid in all States).
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: Review: JsArrays patch
I'm going to punt this review to Bruce Kelly, 'cause I have no idea why having JsArrayBase would be bad. :) On Fri, Mar 27, 2009 at 1:28 PM, Freeland Abbott gwt.team.fabb...@gmail.com wrote: Scott, we already talked about this, but here's the patch for public review. The basic goal is to surface the native length, sort, push, and shift operators for JsArrays... I know you mentioned that IE6's push may be slower than indexed extension, and thus a candidate for deferred binding, but I wanted to get a basic implementation in first. There should be only checkstyle changes from what we discussed (though that obviously doesn't help the rest GWTC). I also added some checkstyle fixes to JavaScriptObject, introduced by my c5082. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Review: JsArrays patch
I think the argument is more for unnecessary rather than bad...
although without JsArrayBase (we can make it package-protected, and call it
JsArrayImpl if anyone cares), we duplicate the JSNI implementation for a
couple trivial methods. I thought refactoring them into one place was nice,
but trivial enough that I'm not fighting over it. Revised patch attached; I
can go either way on this.
On Fri, Mar 27, 2009 at 2:06 PM, Scott Blum sco...@google.com wrote:
I'm going to punt this review to Bruce Kelly, 'cause I have no idea why
having JsArrayBase would be bad. :)
On Fri, Mar 27, 2009 at 1:28 PM, Freeland Abbott
gwt.team.fabb...@gmail.com wrote:
Scott, we already talked about this, but here's the patch for public
review.
The basic goal is to surface the native length, sort, push, and shift
operators for JsArrays... I know you mentioned that IE6's push may be slower
than indexed extension, and thus a candidate for deferred binding, but I
wanted to get a basic implementation in first.
There should be only checkstyle changes from what we discussed (though
that obviously doesn't help the rest GWTC). I also added some checkstyle
fixes to JavaScriptObject, introduced by my c5082.
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
Index: user/src/com/google/gwt/core/client/JsArrayString.java
===
--- user/src/com/google/gwt/core/client/JsArrayString.java (revision 5095)
+++ user/src/com/google/gwt/core/client/JsArrayString.java (working copy)
@@ -1,12 +1,12 @@
/*
* Copyright 2008 Google Inc.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the License); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
@@ -17,10 +17,10 @@
/**
* A simple wrapper around a homogeneous native array of string values.
- *
+ *
* This class may not be directly instantiated, and can only be returned from a
* native method. For example,
- *
+ *
* code
* native JsArrayString getNativeArray() /*-{
* return ['foo', 'bar', 'baz'];
@@ -34,7 +34,7 @@
/**
* Gets the value at a given index.
- *
+ *
* @param index the index to be retrieved
* @return the value at the given index, or codenull/code if none exists
*/
@@ -44,7 +44,7 @@
/**
* Gets the length of the array.
- *
+ *
* @return the array length
*/
public final native int length() /*-{
@@ -52,15 +52,38 @@
}-*/;
/**
+ * call underlying push method.
+ */
+ public final native void push(String value) /*-{
+this.push(value);
+ }-*/;
+
+ /**
* Sets the value value at a given index.
- *
+ *
* If the index is out of bounds, the value will still be set. The array's
* length will be updated to encompass the bounds implied by the added value.
- *
+ *
* @param index the index to be set
* @param value the value to be stored
*/
public final native void set(int index, String value) /*-{
this[index] = value;
}-*/;
+
+ /**
+ * Shifts the first value off the array.
+ * @return the shifted value
+ */
+ public final native String shift() /*-{
+return this.shift();
+ }-*/;
+
+ /**
+ * direct mapping to underlying sort method.
+ */
+ public final native void sort(JavaScriptObject sortFunc) /*-{
+this.sort(sortFunc);
+ }-*/;
+
}
Index: user/src/com/google/gwt/core/client/JsArrayBoolean.java
===
--- user/src/com/google/gwt/core/client/JsArrayBoolean.java (revision 5095)
+++ user/src/com/google/gwt/core/client/JsArrayBoolean.java (working copy)
@@ -1,12 +1,12 @@
/*
* Copyright 2008 Google Inc.
- *
+ *
* Licensed under the Apache License, Version 2.0 (the License); you may not
* use this file except in compliance with the License. You may obtain a copy of
* the License at
- *
+ *
* http://www.apache.org/licenses/LICENSE-2.0
- *
+ *
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an AS IS BASIS, WITHOUT
* WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
@@ -17,10 +17,10 @@
/**
* A simple wrapper around a homogeneous native array of boolean values.
- *
+ *
* This class may not be directly instantiated, and can only be returned from a
* native method. For example,
- *
+ *
* code
* native JsArrayBoolean getNativeArray() /*-{
* return [true, false, true];
@@ -34,11 +34,11 @@
/**
*
[gwt-contrib] Re: JVM crashes when using GWT compiler under Java 6 update 7 JVM
Ugggh... you want me to do all the work don't you :D On a separate note 5094 compilation is broken (JUnitShell fails to compile). In 5096 the problem is resolved. On Fri, Mar 27, 2009 at 2:03 PM, Scott Blum sco...@google.com wrote: I can has hs_err_pid17105.log? On Fri, Mar 27, 2009 at 12:36 PM, Vitali Lovich vlov...@gmail.com wrote: [java] Compiling module com.google.gwt.benchmarks.viewer.ReportViewer [java] # [java] # An unexpected error has been detected by Java Runtime Environment: [java] # [java] # SIGSEGV (0xb) at pc=0x0625665c, pid=17105, tid=3762477968 [java] # [java] # Java VM: Java HotSpot(TM) Server VM (10.0-b23 mixed mode linux-x86) [java] # Problematic frame: [java] # V [libjvm.so+0x25665c] [java] # [java] # An error report file with more information is saved as: [java] # /home/vlovich/workspace/gwt/tools/benchmark-viewer/hs_err_pid17105.log [java] # [java] # If you would like to submit a bug report, please visit: [java] # http://java.sun.com/webapps/bugreport/crash.jsp [java] # The crash happened outside the Java Virtual Machine in native code. [java] # See problematic frame for where to report the bug. [java] # This is kind of annoying because GWT fails to build with the newer JDKs due to the issue mentioned before with the change to generics. So it's a two step workaround: Use the older sun JDK to compile the classes after it crashes, use run ant again with the newer JDK so that the GWT compiler doesn't crash the VM. This also happens if I try to use the older JDK with my projects, but that's not really an issue since I just use the latest OpenJDK in the Ubuntu repos. Might be relevant that I'm using 64-bit jdks. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~--- hs_err_pid2473.log Description: Binary data
[gwt-contrib] [google-web-toolkit commit] r5096 - Adds an entry to the API checker's config files to reflect
Author: sp...@google.com Date: Fri Mar 27 11:15:17 2009 New Revision: 5096 Modified: trunk/tools/api-checker/config/gwt15_16userApi.conf Log: Adds an entry to the API checker's config files to reflect the newly added class RunStyleNoServerHosted. Patch by: spoon,amitmanjhi Review by: spoon,amitmanjhi Modified: trunk/tools/api-checker/config/gwt15_16userApi.conf == --- trunk/tools/api-checker/config/gwt15_16userApi.conf (original) +++ trunk/tools/api-checker/config/gwt15_16userApi.conf Fri Mar 27 11:15:17 2009 @@ -62,6 +62,7 @@ :user/src/com/google/gwt/junit/RunStyleLocalHosted.java\ :user/src/com/google/gwt/junit/RunStyleLocalWeb.java\ :user/src/com/google/gwt/junit/RunStyleManual.java\ +:user/src/com/google/gwt/junit/RunStyleNoServerHosted.java\ :user/src/com/google/gwt/junit/RunStyleRemote.java\ :user/src/com/google/gwt/junit/RunStyleRemoteWeb.java\ :user/src/com/google/gwt/junit/RunStyleSelenium.java\ --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: GWTC compiler disallows using a derivative of AsyncCallback on async interface declaration
hmm... i looked and there appears to be a simple fix.
private static String computeInternalSignature(JMethod method) {
StringBuffer sb = new StringBuffer();
sb.setLength(0);
sb.append(method.getName());
JParameter[] params = method.getParameters();
int i = 0;
for (JParameter param : params) {
sb.append(/);
JType paramType = param.getType();
if (i++ == params.length - 1) {
paramType = getAsyncCallbackSignature(paramType);
}
sb.append(paramType.getErasedType().getQualifiedSourceName());
}
return sb.toString();
}
getAsyncCallbackSignature simply checks to see if there's a way to
cast the paramType to AsyncCallback. If there is, then it returns the
equivalent AsyncCallback JType. If there isn't, it returns the
original JType.
Haven't looked at the JType API to see how getAsyncCallbackSignature
would be written. I'll try to look at it Tuesday evening when I have
some time.
On Fri, Mar 27, 2009 at 2:10 PM, Scott Blum sco...@google.com wrote:
I'm sure it's unintentional. Here's where you would go to fix it:
http://code.google.com/p/google-web-toolkit/source/browse/trunk/user/src/com/google/gwt/user/rebind/rpc/RemoteServiceAsyncValidator.java#185
On Fri, Mar 27, 2009 at 2:00 PM, Vitali Lovich vlov...@gmail.com wrote:
I tried to use my own custom class that extends AsyncCallback in the async
interface, the compiler told me that the async version didn't match the
sync version.
For instance: public interface NoResultCallback extends
AsyncCallbackVoid. It's not really an issue, but I prefer to use the more
precise type to get the compiler to statically check the code.
Is this by design for a reason?
--~--~-~--~~~---~--~~
http://groups.google.com/group/Google-Web-Toolkit-Contributors
-~--~~~~--~~--~--~---
[gwt-contrib] Re: JVM crashes when using GWT compiler under Java 6 update 7 JVM
You can also has the hs_err for the 32-bit vm On Fri, Mar 27, 2009 at 2:26 PM, Vitali Lovich vlov...@gmail.com wrote: Ugggh... you want me to do all the work don't you :D On a separate note 5094 compilation is broken (JUnitShell fails to compile). In 5096 the problem is resolved. On Fri, Mar 27, 2009 at 2:03 PM, Scott Blum sco...@google.com wrote: I can has hs_err_pid17105.log? On Fri, Mar 27, 2009 at 12:36 PM, Vitali Lovich vlov...@gmail.com wrote: [java] Compiling module com.google.gwt.benchmarks.viewer.ReportViewer [java] # [java] # An unexpected error has been detected by Java Runtime Environment: [java] # [java] # SIGSEGV (0xb) at pc=0x0625665c, pid=17105, tid=3762477968 [java] # [java] # Java VM: Java HotSpot(TM) Server VM (10.0-b23 mixed mode linux-x86) [java] # Problematic frame: [java] # V [libjvm.so+0x25665c] [java] # [java] # An error report file with more information is saved as: [java] # /home/vlovich/workspace/gwt/tools/benchmark-viewer/hs_err_pid17105.log [java] # [java] # If you would like to submit a bug report, please visit: [java] # http://java.sun.com/webapps/bugreport/crash.jsp [java] # The crash happened outside the Java Virtual Machine in native code. [java] # See problematic frame for where to report the bug. [java] # This is kind of annoying because GWT fails to build with the newer JDKs due to the issue mentioned before with the change to generics. So it's a two step workaround: Use the older sun JDK to compile the classes after it crashes, use run ant again with the newer JDK so that the GWT compiler doesn't crash the VM. This also happens if I try to use the older JDK with my projects, but that's not really an issue since I just use the latest OpenJDK in the Ubuntu repos. Might be relevant that I'm using 64-bit jdks. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~--- hs_err_pid13507.log Description: Binary data
[gwt-contrib] Re: JVM crashes when using GWT compiler under Java 6 update 7 JVM
Sorry - forgot to mention that this happened when I tried to load the hosted mode browser. On Fri, Mar 27, 2009 at 3:57 PM, Vitali Lovich vlov...@gmail.com wrote: Might be related. Just set up my project to run under the regular hosted mode w/ 32-bit JVM: LoadPlugin: failed to initialize shared library /home/vlovich/.mozilla/plugins/libflashplayer.so [/home/vlovich/.mozilla/plugins/libflashplayer.so: wrong ELF class: ELFCLASS64] LoadPlugin: failed to initialize shared library /usr/lib/jvm/java-6-sunjre/lib/amd64/libnpjp2.so [/usr/lib/jvm/java-6-sunjre/lib/amd64/libnpjp2.so: wrong ELF class: ELFCLASS64] # # An unexpected error has been detected by Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x0625665c, pid=20124, tid=3607796624 # # Java VM: Java HotSpot(TM) Server VM (10.0-b23 mixed mode linux-x86) # Problematic frame: # V [libjvm.so+0x25665c] # # An error report file with more information is saved as: # /home/vlovich/workspace/sacred_heart/hs_err_pid20124.log # # If you would like to submit a bug report, please visit: # http://java.sun.com/webapps/bugreport/crash.jsp # The crash happened outside the Java Virtual Machine in native code. # See problematic frame for where to report the bug. # On Fri, Mar 27, 2009 at 3:07 PM, Vitali Lovich vlov...@gmail.com wrote: You can also has the hs_err for the 32-bit vm On Fri, Mar 27, 2009 at 2:26 PM, Vitali Lovich vlov...@gmail.com wrote: Ugggh... you want me to do all the work don't you :D On a separate note 5094 compilation is broken (JUnitShell fails to compile). In 5096 the problem is resolved. On Fri, Mar 27, 2009 at 2:03 PM, Scott Blum sco...@google.com wrote: I can has hs_err_pid17105.log? On Fri, Mar 27, 2009 at 12:36 PM, Vitali Lovich vlov...@gmail.com wrote: [java] Compiling module com.google.gwt.benchmarks.viewer.ReportViewer [java] # [java] # An unexpected error has been detected by Java Runtime Environment: [java] # [java] # SIGSEGV (0xb) at pc=0x0625665c, pid=17105, tid=3762477968 [java] # [java] # Java VM: Java HotSpot(TM) Server VM (10.0-b23 mixed mode linux-x86) [java] # Problematic frame: [java] # V [libjvm.so+0x25665c] [java] # [java] # An error report file with more information is saved as: [java] # /home/vlovich/workspace/gwt/tools/benchmark-viewer/hs_err_pid17105.log [java] # [java] # If you would like to submit a bug report, please visit: [java] # http://java.sun.com/webapps/bugreport/crash.jsp [java] # The crash happened outside the Java Virtual Machine in native code. [java] # See problematic frame for where to report the bug. [java] # This is kind of annoying because GWT fails to build with the newer JDKs due to the issue mentioned before with the change to generics. So it's a two step workaround: Use the older sun JDK to compile the classes after it crashes, use run ant again with the newer JDK so that the GWT compiler doesn't crash the VM. This also happens if I try to use the older JDK with my projects, but that's not really an issue since I just use the latest OpenJDK in the Ubuntu repos. Might be relevant that I'm using 64-bit jdks. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: JVM crashes when using GWT compiler under Java 6 update 7 JVM
Ok - i'm almost positive it is the same problem. I think the loadplugin thing is a misdirection. The project appears to crash compiling the code. On Fri, Mar 27, 2009 at 3:59 PM, Vitali Lovich vlov...@gmail.com wrote: Sorry - forgot to mention that this happened when I tried to load the hosted mode browser. On Fri, Mar 27, 2009 at 3:57 PM, Vitali Lovich vlov...@gmail.com wrote: Might be related. Just set up my project to run under the regular hosted mode w/ 32-bit JVM: LoadPlugin: failed to initialize shared library /home/vlovich/.mozilla/plugins/libflashplayer.so [/home/vlovich/.mozilla/plugins/libflashplayer.so: wrong ELF class: ELFCLASS64] LoadPlugin: failed to initialize shared library /usr/lib/jvm/java-6-sunjre/lib/amd64/libnpjp2.so [/usr/lib/jvm/java-6-sunjre/lib/amd64/libnpjp2.so: wrong ELF class: ELFCLASS64] # # An unexpected error has been detected by Java Runtime Environment: # # SIGSEGV (0xb) at pc=0x0625665c, pid=20124, tid=3607796624 # # Java VM: Java HotSpot(TM) Server VM (10.0-b23 mixed mode linux-x86) # Problematic frame: # V [libjvm.so+0x25665c] # # An error report file with more information is saved as: # /home/vlovich/workspace/sacred_heart/hs_err_pid20124.log # # If you would like to submit a bug report, please visit: # http://java.sun.com/webapps/bugreport/crash.jsp # The crash happened outside the Java Virtual Machine in native code. # See problematic frame for where to report the bug. # On Fri, Mar 27, 2009 at 3:07 PM, Vitali Lovich vlov...@gmail.com wrote: You can also has the hs_err for the 32-bit vm On Fri, Mar 27, 2009 at 2:26 PM, Vitali Lovich vlov...@gmail.com wrote: Ugggh... you want me to do all the work don't you :D On a separate note 5094 compilation is broken (JUnitShell fails to compile). In 5096 the problem is resolved. On Fri, Mar 27, 2009 at 2:03 PM, Scott Blum sco...@google.com wrote: I can has hs_err_pid17105.log? On Fri, Mar 27, 2009 at 12:36 PM, Vitali Lovich vlov...@gmail.com wrote: [java] Compiling module com.google.gwt.benchmarks.viewer.ReportViewer [java] # [java] # An unexpected error has been detected by Java Runtime Environment: [java] # [java] # SIGSEGV (0xb) at pc=0x0625665c, pid=17105, tid=3762477968 [java] # [java] # Java VM: Java HotSpot(TM) Server VM (10.0-b23 mixed mode linux-x86) [java] # Problematic frame: [java] # V [libjvm.so+0x25665c] [java] # [java] # An error report file with more information is saved as: [java] # /home/vlovich/workspace/gwt/tools/benchmark-viewer/hs_err_pid17105.log [java] # [java] # If you would like to submit a bug report, please visit: [java] # http://java.sun.com/webapps/bugreport/crash.jsp [java] # The crash happened outside the Java Virtual Machine in native code. [java] # See problematic frame for where to report the bug. [java] # This is kind of annoying because GWT fails to build with the newer JDKs due to the issue mentioned before with the change to generics. So it's a two step workaround: Use the older sun JDK to compile the classes after it crashes, use run ant again with the newer JDK so that the GWT compiler doesn't crash the VM. This also happens if I try to use the older JDK with my projects, but that's not really an issue since I just use the latest OpenJDK in the Ubuntu repos. Might be relevant that I'm using 64-bit jdks. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Fix ImageBundleBuilder de-duplication
With my stupid question about the test answered offline, LGTM http://gwt-code-reviews.appspot.com/15802 --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Review: JsArrays patch
Kelly, since you have experience with this, I'd like you to be the decider (i.e. Freeland is now waiting on your LGTM). On Fri, Mar 27, 2009 at 2:16 PM, Freeland Abbott gwt.team.fabb...@gmail.com wrote: I think the argument is more for unnecessary rather than bad... although without JsArrayBase (we can make it package-protected, and call it JsArrayImpl if anyone cares), we duplicate the JSNI implementation for a couple trivial methods. I thought refactoring them into one place was nice, but trivial enough that I'm not fighting over it. Revised patch attached; I can go either way on this. On Fri, Mar 27, 2009 at 2:06 PM, Scott Blum sco...@google.com wrote: I'm going to punt this review to Bruce Kelly, 'cause I have no idea why having JsArrayBase would be bad. :) On Fri, Mar 27, 2009 at 1:28 PM, Freeland Abbott gwt.team.fabb...@gmail.com wrote: Scott, we already talked about this, but here's the patch for public review. The basic goal is to surface the native length, sort, push, and shift operators for JsArrays... I know you mentioned that IE6's push may be slower than indexed extension, and thus a candidate for deferred binding, but I wanted to get a basic implementation in first. There should be only checkstyle changes from what we discussed (though that obviously doesn't help the rest GWTC). I also added some checkstyle fixes to JavaScriptObject, introduced by my c5082. --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Public git repository
Is there by any chance a public git repository (preferably one that tracks trunk fairly closely)? git svn clone takes forever. Thanks --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] [google-web-toolkit commit] r5098 - Updating license and attributions.
Author: sco...@google.com Date: Fri Mar 27 15:01:35 2009 New Revision: 5098 Modified: releases/1.6/distro-source/core/src/COPYING releases/1.6/distro-source/core/src/COPYING.html releases/1.6/distro-source/core/src/about.html releases/1.6/distro-source/core/src/about.txt Log: Updating license and attributions. Modified: releases/1.6/distro-source/core/src/COPYING == --- releases/1.6/distro-source/core/src/COPYING (original) +++ releases/1.6/distro-source/core/src/COPYING Fri Mar 27 15:01:35 2009 @@ -191,8 +191,17 @@ * Apache Tomcat License: Apache License v. 2.0 (above) Source code availability: http://tomcat.apache.org -modifications are at org/apache/tomcat within gwt-dev.jar +modifications are at org/apache/tomcat/ within gwt-dev.jar +* Apache Tapestry + License: Apache License v. 2.0 (above) + Source code availability: http://tapestry.apache.org + +* ASM 3.1 + License: (custom) +http://asm.objectweb.org/license.html + Source code availability: com/google/gwt/dev/asm/ within gwt-dev.jar + * Browser Detect v2.1.6 License: Creative Commons Attribution 1.0 http://creativecommons.org/licenses/by/1.0/ @@ -213,7 +222,12 @@ Linux: http://download.eclipse.org/eclipse/downloads/drops/R-3.2.1-200609210945/download.php?dropFile=swt-3.2.1-gtk-linux-x86.zip Windows: http://download.eclipse.org/eclipse/downloads/drops/R-3.2.1-200609210945/download.php?dropFile=swt-3.2.1-win32-win32-x86.zip Mac: http://download.eclipse.org/eclipse/downloads/drops/R-3.2.1-200609210945/download.php?dropFile=swt-3.2.1-carbon-macosx.zip -modifications are at org/eclipse/swt within gwt-dev.jar +modifications are at org/eclipse/swt/ within gwt-dev.jar + +* Jetty + License: Apache License v. 2.0 (above) + Source code availability: +http://mortbay.org/jetty/ * JFreeChart License: GNU Lesser General Public License v. 2.1 @@ -231,10 +245,4 @@ http://www.mozilla.org/MPL/MPL-1.1.txt Source code availability: http://developer.mozilla.org/en/docs/Download_Mozilla_Source_Code - -* WebKit 418.9 (Mac only) - License: GNU Lesser General Public License v. 2.1 -http://www.gnu.org/licenses/lgpl.html - Source code availability: -http://webkit.org/building/checkout.html Modified: releases/1.6/distro-source/core/src/COPYING.html == --- releases/1.6/distro-source/core/src/COPYING.html(original) +++ releases/1.6/distro-source/core/src/COPYING.htmlFri Mar 27 15:01:35 2009 @@ -281,28 +281,43 @@ tr td class=packageApache Tomcat/td td class=licenseApache License v. 2.0 (above)/td -td class=locationa href=http://tomcat.apache.org/;tomcat.apache.org/a; modifications are at org/apache/tomcat within gwt-dev.jar/td +td class=locationa href=http://tomcat.apache.org/;tomcat.apache.org/a; modifications are at org/apache/tomcat/ within gwt-dev.jar/td + /tr + tr class=even +td class=packageApache Tapestry/td +td class=licenseApache License v. 2.0 (above)/td +td class=locationa href=http://tapestry.apache.org/;tapestry.apache.org/a/td /tr tr +td class=packageASM 3.1/td +td class=license(a href=http://asm.objectweb.org/license.html;custom/a)/td +td class=locationcom/google/gwt/dev/asm/ within gwt-dev.jar/td + /tr + tr class=even td class=packageBrowser Detect v2.1.6/td td class=licensea href=http://creativecommons.org/licenses/by/1.0/;Creative Commons Attribution 1.0/a/td td class=locationa href=http://google-web-toolkit.googlecode.com/svn/trunk/tools/benchmark-viewer/src/com/google/gwt/benchmarks/viewer/client/BrowserInfo.java;google-web-toolkit.googlecode.com/a; transliterated into Java source/td /tr - tr class=even + tr td class=packageEclipse Java Development Tools (JDT)/td td class=licensea href=http://www.eclipse.org/legal/epl-v10.html;Eclipse Public License v. 1.0/a/td td class=locationa href=http://archive.eclipse.org/eclipse/downloads/drops/R-3.3.1-200709211145/download.php?dropFile=eclipse-JDT-SDK-3.3.1.zip;eclipse.org/a/td /tr - tr + tr class=even td class=packageEclipse Standard Widget Toolkit (SWT)/td td class=licensea href=http://www.eclipse.org/legal/epl-v10.html;Eclipse Public License v. 1.0/a/td td class=location a href=http://download.eclipse.org/eclipse/downloads/drops/R-3.2.1-200609210945/download.php?dropFile=swt-3.2.1-gtk-linux-x86.zip;Linux/a, a href=http://download.eclipse.org/eclipse/downloads/drops/R-3.2.1-200609210945/download.php?dropFile=swt-3.2.1-win32-win32-x86.zip;Windows/a, and a href=http://download.eclipse.org/eclipse/downloads/drops/R-3.2.1-200609210945/download.php?dropFile=swt-3.2.1-carbon-macosx.zip;Mac/a; -modifications are at org/eclipse/swt within gwt-dev.jar +
[gwt-contrib] Re: Public git repository
We don't have a public one... but I do have a repo with the whole svn history in it that would git you started. You can grab a copy from a personal webpage of mine... http://www.shaftnet.org/~sinth/gwt-repo.tgz Just download, unpack, checkout, and you should be g2g. git svn fetch isn't so painful if you're nearly up to date already. On Fri, Mar 27, 2009 at 6:09 PM, Vitali Lovich vlov...@gmail.com wrote: Is there by any chance a public git repository (preferably one that tracks trunk fairly closely)? git svn clone takes forever. Thanks --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
[gwt-contrib] Re: Public git repository
Thx. The initial checkout's a pain because Google code also limits you to like 50 kbs/s On Fri, Mar 27, 2009 at 6:34 PM, Scott Blum sco...@google.com wrote: We don't have a public one... but I do have a repo with the whole svn history in it that would git you started. You can grab a copy from a personal webpage of mine... http://www.shaftnet.org/~sinth/gwt-repo.tgz Just download, unpack, checkout, and you should be g2g. git svn fetch isn't so painful if you're nearly up to date already. On Fri, Mar 27, 2009 at 6:09 PM, Vitali Lovich vlov...@gmail.com wrote: Is there by any chance a public git repository (preferably one that tracks trunk fairly closely)? git svn clone takes forever. Thanks --~--~-~--~~~---~--~~ http://groups.google.com/group/Google-Web-Toolkit-Contributors -~--~~~~--~~--~--~---
