[gwt-contrib] Ensure that primitive values can be used as RequestFactory proxy properties. (issue1216801)
Reviewers: rjrjr, rchandia, Description: Ensure that primitive values can be used as RequestFactory proxy properties. Make RequestFactoryInterfaceValidator stricter in handling mismatches. Issue 5357. Patch by: bobv Review by: rjrjr, rchandia Please review this at http://gwt-code-reviews.appspot.com/1216801/show Affected files: M user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java M user/src/com/google/gwt/requestfactory/server/SimpleRequestProcessor.java M user/test/com/google/gwt/requestfactory/RequestFactoryJreSuite.java M user/test/com/google/gwt/requestfactory/RequestFactorySuite.java A user/test/com/google/gwt/requestfactory/server/BoxesAndPrimitivesJreTest.java M user/test/com/google/gwt/requestfactory/server/SimpleFoo.java M user/test/com/google/gwt/requestfactory/shared/BaseFooProxy.java A user/test/com/google/gwt/requestfactory/shared/BoxesAndPrimitivesTest.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Reduces class and JSNI loading for RPC in devmode. (issue1215801)
http://gwt-code-reviews.appspot.com/1215801/diff/1/4
File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/1/4#newcode231
dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:231:
eventsByGeneratorType.put(com.google.gwt.resources.rebind.context.InlineClientBundleGenerator,
CompilerEventType.GENERATOR_CLIENT_BUNDLE);
line length 100
http://gwt-code-reviews.appspot.com/1215801/diff/1/4#newcode231
dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:231:
eventsByGeneratorType.put(com.google.gwt.resources.rebind.context.InlineClientBundleGenerator,
CompilerEventType.GENERATOR_CLIENT_BUNDLE);
Wouldn't it be more robust to refer to these types by class constants? I
know it would introduce dependencies through import statements, but in
effect, the code does depend on these classes by using their package
names like this, and will silently break if there is some refactoring.
Or maybe it would be better to include an extendable method for
Generator to return a SpeedTracer event type.
http://gwt-code-reviews.appspot.com/1215801/diff/1/6
File dev/core/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/1/6#newcode49
dev/core/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java:49: if
(jsniMethod.isScriptOnly()) {
I would appreciate a comment here that this is for a performance
optimization.
http://gwt-code-reviews.appspot.com/1215801/diff/1/13
File user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/1/13#newcode27
user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java:27:
// as the syntax is correct, e.g. [[Ljava.lang.String;
I'm not sure its so surprising the names match, since the
SerializationUtils.getRpcTypeName() is explicitly documented as such.
Maybe reference that method?
http://gwt-code-reviews.appspot.com/1215801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Ensure that primitive values can be used as RequestFactory proxy properties. (issue1216801)
LGTM http://gwt-code-reviews.appspot.com/1216801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Have separate devmode.js files for each permutation if we are outputting (issue1208802)
http://gwt-code-reviews.appspot.com/1208802/diff/1/2
File
dev/core/src/com/google/gwt/core/ext/linker/impl/PropertiesUtil.java
(right):
http://gwt-code-reviews.appspot.com/1208802/diff/1/2#newcode33
dev/core/src/com/google/gwt/core/ext/linker/impl/PropertiesUtil.java:33:
for (SelectionProperty property :
result.getPropertyMap().first().keySet()) {
iterate over the Map.Entry instead.
also, why only the first propertyMap in the set? Shouldn't it be on a
permutation basis or all of them?
http://gwt-code-reviews.appspot.com/1208802/diff/1/4
File dev/core/src/com/google/gwt/core/ext/linker/impl/propertiesNull.js
(right):
http://gwt-code-reviews.appspot.com/1208802/diff/1/4#newcode17
dev/core/src/com/google/gwt/core/ext/linker/impl/propertiesNull.js:17:
return propValue == computePropValue(propName);
won't this function then throw an exception whenever the property is
unknown?
http://gwt-code-reviews.appspot.com/1208802/diff/1/4#newcode19
dev/core/src/com/google/gwt/core/ext/linker/impl/propertiesNull.js:19:
__MODULE_FUNC__.__computePropValue = computePropValue;
I'm confused by the naming here. I'd expect propertiesNull to not
include any properties, but now it does. Perhaps you should move this
minimal properties logic into a different file?
http://gwt-code-reviews.appspot.com/1208802/diff/1/5
File dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java
(right):
http://gwt-code-reviews.appspot.com/1208802/diff/1/5#newcode78
dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java:78:
This linker does not support script tags in the gwt.xml files);
add the linker getDescription() in place of this linker
http://gwt-code-reviews.appspot.com/1208802/diff/1/5#newcode229
dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java:229:
shouldIncludeBootstrapInPrimaryFragment(context)) {
your comment above seems to indicate that you want
isFinalLinkStage != shouldIncludeBootstrapInPrimaryFragment
http://gwt-code-reviews.appspot.com/1208802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fixes rebased guava library without using JarJar (issue1213801)
Submitted as of r9412 On 2010/12/13 21:22:20, rice wrote: LGTM http://gwt-code-reviews.appspot.com/1213801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Ensure that primitive values can be used as RequestFactory proxy properties. (issue1216801)
LGTM http://gwt-code-reviews.appspot.com/1216801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9414 committed - Ensure that primitive values can be used as RequestFactory proxy prope...
Revision: 9414
Author: gwt.mirror...@gmail.com
Date: Tue Dec 14 10:22:35 2010
Log: Ensure that primitive values can be used as RequestFactory proxy
properties.
Make RequestFactoryInterfaceValidator stricter in handling mismatches.
Issue 5357.
Patch by: bobv
Review by: rjrjr, rchandia
Review at http://gwt-code-reviews.appspot.com/1216801
http://code.google.com/p/google-web-toolkit/source/detail?r=9414
Added:
/trunk/user/test/com/google/gwt/requestfactory/server/BoxesAndPrimitivesJreTest.java
/trunk/user/test/com/google/gwt/requestfactory/shared/BoxesAndPrimitivesTest.java
Modified:
/trunk/user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java
/trunk/user/src/com/google/gwt/requestfactory/server/SimpleRequestProcessor.java
/trunk/user/test/com/google/gwt/requestfactory/RequestFactoryJreSuite.java
/trunk/user/test/com/google/gwt/requestfactory/RequestFactorySuite.java
/trunk/user/test/com/google/gwt/requestfactory/server/SimpleFoo.java
/trunk/user/test/com/google/gwt/requestfactory/shared/BaseFooProxy.java
===
--- /dev/null
+++
/trunk/user/test/com/google/gwt/requestfactory/server/BoxesAndPrimitivesJreTest.java
Tue Dec 14 10:22:35 2010
@@ -0,0 +1,123 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.requestfactory.server;
+
+import com.google.gwt.dev.asm.Type;
+import com.google.gwt.dev.asm.commons.Method;
+import
com.google.gwt.requestfactory.server.RequestFactoryInterfaceValidatorTest.VisibleErrorContext;
+import com.google.gwt.requestfactory.shared.BoxesAndPrimitivesTest;
+import com.google.gwt.requestfactory.shared.EntityProxy;
+import com.google.gwt.requestfactory.shared.ProxyFor;
+import com.google.gwt.requestfactory.shared.Request;
+import com.google.gwt.requestfactory.shared.RequestContext;
+import com.google.gwt.requestfactory.shared.Service;
+
+import java.util.Arrays;
+import java.util.logging.Logger;
+
+/**
+ * A JRE version of {...@link BoxesAndPrimitivesTest} with additional
validation
+ * tests.
+ */
+public class BoxesAndPrimitivesJreTest extends BoxesAndPrimitivesTest {
+
+ @Service(ServiceImpl.class)
+ interface ContextMismatchedParameterA extends RequestContext {
+RequestVoid checkBoxed(int value);
+ }
+
+ @Service(ServiceImpl.class)
+ interface ContextMismatchedParameterB extends RequestContext {
+RequestVoid checkPrimitive(Integer value);
+ }
+
+ @ProxyFor(Entity.class)
+ interface ProxyMismatchedGetterA extends EntityProxy {
+int getBoxed();
+ }
+
+ @ProxyFor(Entity.class)
+ interface ProxyMismatchedGetterB extends EntityProxy {
+Integer getPrimitive();
+ }
+
+ private VisibleErrorContext errors;
+ private RequestFactoryInterfaceValidator v;
+
+ @Override
+ public String getModuleName() {
+return null;
+ }
+
+ public void test() {
+RequestFactoryInterfaceValidator v = new
RequestFactoryInterfaceValidator(
+Logger.getAnonymousLogger(),
+new RequestFactoryInterfaceValidator.ClassLoaderLoader(
+getClass().getClassLoader()));
+v.validateRequestFactory(Factory.class.getName());
+assertFalse(v.isPoisoned());
+ }
+
+ /**
+ * Tests that mismatched primitive verses boxed getters are correctly
+ * reported.
+ */
+ public void testMismatchedGetters() {
+v.validateEntityProxy(ProxyMismatchedGetterA.class.getName());
+v.validateEntityProxy(ProxyMismatchedGetterB.class.getName());
+assertTrue(v.isPoisoned());
+
+String getBoxedMessage =
RequestFactoryInterfaceValidator.messageCouldNotFindMethod(
+Type.getType(Entity.class),
+Arrays.asList(new Method(getBoxed, ()Ljava/lang/Integer;)));
+String getPrimitiveMessage =
RequestFactoryInterfaceValidator.messageCouldNotFindMethod(
+Type.getType(Entity.class),
+Arrays.asList(new Method(getPrimitive, ()I)));
+assertEquals(Arrays.asList(getBoxedMessage, getPrimitiveMessage),
+errors.logs);
+ }
+
+ /**
+ * Tests that mismatched parameter types are correctly reported.
+ */
+ public void testMismatchedParameters() {
+v.validateRequestContext(ContextMismatchedParameterA.class.getName());
+v.validateRequestContext(ContextMismatchedParameterB.class.getName());
+
+String checkBoxedMessage =
RequestFactoryInterfaceValidator.messageCouldNotFindMethod(
+Type.getType(ServiceImpl.class),
+
[gwt-contrib] [google-web-toolkit] r9415 committed - 1.5 compat fix
Revision: 9415
Author: sco...@google.com
Date: Tue Dec 14 07:18:04 2010
Log: 1.5 compat fix
http://code.google.com/p/google-web-toolkit/source/detail?r=9415
Modified:
/trunk/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java
===
--- /trunk/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java
Thu Dec 9 10:54:59 2010
+++ /trunk/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java
Tue Dec 14 07:18:04 2010
@@ -688,7 +688,7 @@
private ListJClassType classChain(JClassType cls) {
LinkedListJClassType chain = new LinkedListJClassType();
while (cls != null) {
- chain.push(cls);
+ chain.addFirst(cls);
cls = cls.getSuperclass();
}
return chain;
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9416 committed - Edited wiki page RequestFactory_2_1_1 through web user interface.
Revision: 9416 Author: b...@google.com Date: Tue Dec 14 10:43:37 2010 Log: Edited wiki page RequestFactory_2_1_1 through web user interface. http://code.google.com/p/google-web-toolkit/source/detail?r=9416 Modified: /wiki/RequestFactory_2_1_1.wiki === --- /wiki/RequestFactory_2_1_1.wiki Wed Dec 8 16:02:54 2010 +++ /wiki/RequestFactory_2_1_1.wiki Tue Dec 14 10:43:37 2010 @@ -50,6 +50,8 @@ * *API Break* `ServerFailure` now has a boolean `isFatal()` method (usually true), which `Request#onFailure` checks before throwing a RuntimeException * The Expenses sample has been extended to show how to handle user authentication in the wake of these changes. It's easier now, and more flexible. * (Issue 5674) The server code will explicitly disallow persisted entities with null versions. + * (Issue 5357) Proxy types may use primitive types for proxy property accessor methods. +* *API Break* The RequestFactory interface validator has been tightened to require that the a proxy property type matches the domain type exactly. If the domain type defines an `int getFoo()` property accessor, the matching property accessor in the proxy type must also be an `int` instead of an `Integer`. = What's in review = = What's coming = -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9417 committed - Integrate r9414 into GWT 2.1 branch....
Revision: 9417
Author: b...@google.com
Date: Tue Dec 14 07:37:53 2010
Log: Integrate r9414 into GWT 2.1 branch.
Ensure that primitive values can be used as RequestFactory proxy properties.
http://code.google.com/p/google-web-toolkit/source/detail?r=9417
Added:
/releases/2.1/user/test/com/google/gwt/requestfactory/server/BoxesAndPrimitivesJreTest.java
/releases/2.1/user/test/com/google/gwt/requestfactory/shared/BoxesAndPrimitivesTest.java
Modified:
/releases/2.1/user/src/com/google/gwt/requestfactory/server/RequestFactoryInterfaceValidator.java
/releases/2.1/user/src/com/google/gwt/requestfactory/server/SimpleRequestProcessor.java
/releases/2.1/user/test/com/google/gwt/requestfactory/RequestFactoryJreSuite.java
/releases/2.1/user/test/com/google/gwt/requestfactory/RequestFactorySuite.java
/releases/2.1/user/test/com/google/gwt/requestfactory/server/SimpleFoo.java
/releases/2.1/user/test/com/google/gwt/requestfactory/shared/BaseFooProxy.java
===
--- /dev/null
+++
/releases/2.1/user/test/com/google/gwt/requestfactory/server/BoxesAndPrimitivesJreTest.java
Tue Dec 14 07:37:53 2010
@@ -0,0 +1,123 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.requestfactory.server;
+
+import com.google.gwt.dev.asm.Type;
+import com.google.gwt.dev.asm.commons.Method;
+import
com.google.gwt.requestfactory.server.RequestFactoryInterfaceValidatorTest.VisibleErrorContext;
+import com.google.gwt.requestfactory.shared.BoxesAndPrimitivesTest;
+import com.google.gwt.requestfactory.shared.EntityProxy;
+import com.google.gwt.requestfactory.shared.ProxyFor;
+import com.google.gwt.requestfactory.shared.Request;
+import com.google.gwt.requestfactory.shared.RequestContext;
+import com.google.gwt.requestfactory.shared.Service;
+
+import java.util.Arrays;
+import java.util.logging.Logger;
+
+/**
+ * A JRE version of {...@link BoxesAndPrimitivesTest} with additional
validation
+ * tests.
+ */
+public class BoxesAndPrimitivesJreTest extends BoxesAndPrimitivesTest {
+
+ @Service(ServiceImpl.class)
+ interface ContextMismatchedParameterA extends RequestContext {
+RequestVoid checkBoxed(int value);
+ }
+
+ @Service(ServiceImpl.class)
+ interface ContextMismatchedParameterB extends RequestContext {
+RequestVoid checkPrimitive(Integer value);
+ }
+
+ @ProxyFor(Entity.class)
+ interface ProxyMismatchedGetterA extends EntityProxy {
+int getBoxed();
+ }
+
+ @ProxyFor(Entity.class)
+ interface ProxyMismatchedGetterB extends EntityProxy {
+Integer getPrimitive();
+ }
+
+ private VisibleErrorContext errors;
+ private RequestFactoryInterfaceValidator v;
+
+ @Override
+ public String getModuleName() {
+return null;
+ }
+
+ public void test() {
+RequestFactoryInterfaceValidator v = new
RequestFactoryInterfaceValidator(
+Logger.getAnonymousLogger(),
+new RequestFactoryInterfaceValidator.ClassLoaderLoader(
+getClass().getClassLoader()));
+v.validateRequestFactory(Factory.class.getName());
+assertFalse(v.isPoisoned());
+ }
+
+ /**
+ * Tests that mismatched primitive verses boxed getters are correctly
+ * reported.
+ */
+ public void testMismatchedGetters() {
+v.validateEntityProxy(ProxyMismatchedGetterA.class.getName());
+v.validateEntityProxy(ProxyMismatchedGetterB.class.getName());
+assertTrue(v.isPoisoned());
+
+String getBoxedMessage =
RequestFactoryInterfaceValidator.messageCouldNotFindMethod(
+Type.getType(Entity.class),
+Arrays.asList(new Method(getBoxed, ()Ljava/lang/Integer;)));
+String getPrimitiveMessage =
RequestFactoryInterfaceValidator.messageCouldNotFindMethod(
+Type.getType(Entity.class),
+Arrays.asList(new Method(getPrimitive, ()I)));
+assertEquals(Arrays.asList(getBoxedMessage, getPrimitiveMessage),
+errors.logs);
+ }
+
+ /**
+ * Tests that mismatched parameter types are correctly reported.
+ */
+ public void testMismatchedParameters() {
+v.validateRequestContext(ContextMismatchedParameterA.class.getName());
+v.validateRequestContext(ContextMismatchedParameterB.class.getName());
+
+String checkBoxedMessage =
RequestFactoryInterfaceValidator.messageCouldNotFindMethod(
+Type.getType(ServiceImpl.class),
+Arrays.asList(new Method(checkBoxed, (Ljava/lang/Integer;)V)));
+String
[gwt-contrib] [google-web-toolkit] r9418 committed - Fix second part of issue 5243, full name for the AD era. I didn't get...
Revision: 9418
Author: j...@google.com
Date: Tue Dec 14 07:49:52 2010
Log: Fix second part of issue 5243, full name for the AD era. I didn't get
any conclusive answer about what it should be in Portugal, so I am leaving
the old value there, at least for now.
Issue: 5243
Patch by: jat
Review by: pdr, shanjian
http://code.google.com/p/google-web-toolkit/source/detail?r=9418
Modified:
/trunk/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt.properties
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt.java
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
===
---
/trunk/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt.properties
Mon Dec 13 09:02:12 2010
+++
/trunk/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt.properties
Tue Dec 14 07:49:52 2010
@@ -8,7 +8,7 @@
# CLDR version 1.7.1 is used in this generation.
eras = a.C., d.C.
-eraNames = Antes de Cristo, Ano do Senhor
+eraNames = Antes de Cristo, Depois de Cristo
narrowMonths = J, F, M, A, M, J, J, A, S, O, N, D
months = janeiro, fevereiro, março, abril, maio, junho, julho, agosto,
setembro, outubro, novembro, dezembro
shortMonths = jan, fev, mar, abr, mai, jun, jul, ago, set, out, nov, dez
===
---
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt.java
Mon Dec 13 09:02:12 2010
+++
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt.java
Tue Dec 14 07:49:52 2010
@@ -46,7 +46,7 @@
public String[] erasFull() {
return new String[] {
Antes de Cristo,
-Ano do Senhor
+Depois de Cristo
};
}
===
---
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
Mon Dec 13 09:02:12 2010
+++
/trunk/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
Tue Dec 14 07:49:52 2010
@@ -34,6 +34,14 @@
public String dateFormatMedium() {
return d 'de' MMM 'de' ;
}
+
+ @Override
+ public String[] erasFull() {
+return new String[] {
+Antes de Cristo,
+Ano do Senhor
+};
+ }
@Override
public int firstDayOfTheWeek() {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Public: Generate BeanDescriptors for GWT Validation. (issue1212801)
LGTM On 2010/12/11 00:38:11, Nick Chalko wrote: [JSR 303 TCK Result] 31 of 258 (12.02%) Pass with 10 Failures and 13 Errors. http://gwt-code-reviews.appspot.com/1212801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9419 committed - Merge trunk r9418 (Brazilian era name for AD) into the 2.1 branch.
Revision: 9419
Author: j...@google.com
Date: Tue Dec 14 08:25:33 2010
Log: Merge trunk r9418 (Brazilian era name for AD) into the 2.1 branch.
http://code.google.com/p/google-web-toolkit/source/detail?r=9419
Modified:
/releases/2.1/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt.properties
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt.java
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
===
---
/releases/2.1/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt.properties
Mon Dec 13 09:23:00 2010
+++
/releases/2.1/user/src/com/google/gwt/i18n/client/constants/DateTimeConstantsImpl_pt.properties
Tue Dec 14 08:25:33 2010
@@ -8,7 +8,7 @@
# CLDR version 1.7.1 is used in this generation.
eras = a.C., d.C.
-eraNames = Antes de Cristo, Ano do Senhor
+eraNames = Antes de Cristo, Depois de Cristo
narrowMonths = J, F, M, A, M, J, J, A, S, O, N, D
months = janeiro, fevereiro, março, abril, maio, junho, julho, agosto,
setembro, outubro, novembro, dezembro
shortMonths = jan, fev, mar, abr, mai, jun, jul, ago, set, out, nov, dez
===
---
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt.java
Mon Dec 13 09:23:00 2010
+++
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt.java
Tue Dec 14 08:25:33 2010
@@ -46,7 +46,7 @@
public String[] erasFull() {
return new String[] {
Antes de Cristo,
-Ano do Senhor
+Depois de Cristo
};
}
===
---
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
Mon Dec 13 09:23:00 2010
+++
/releases/2.1/user/src/com/google/gwt/i18n/client/impl/cldr/DateTimeFormatInfoImpl_pt_PT.java
Tue Dec 14 08:25:33 2010
@@ -34,6 +34,14 @@
public String dateFormatMedium() {
return d 'de' MMM 'de' ;
}
+
+ @Override
+ public String[] erasFull() {
+return new String[] {
+Antes de Cristo,
+Ano do Senhor
+};
+ }
@Override
public int firstDayOfTheWeek() {
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9420 committed - updated .msi to the svn checkin revision 9345. copied .msi files to Lo...
Revision: 9420
Author: fabio...@google.com
Date: Tue Dec 14 08:30:34 2010
Log: updated .msi to the svn checkin revision 9345. copied .msi files to
Lorry
Omaha does not support platform attribute to allow a single config file. we
need to create another product for x64.
http://code.google.com/p/google-web-toolkit/source/detail?r=9420
Modified:
/trunk/plugins/ie/installer/installer.wxs.xml
/trunk/plugins/ie/installer/oophm.wxs
/trunk/plugins/ie/prebuilt/gwt-dev-plugin-x64.msi
/trunk/plugins/ie/prebuilt/gwt-dev-plugin-x86.msi
===
--- /trunk/plugins/ie/installer/installer.wxs.xml Thu Dec 2 07:41:14 2010
+++ /trunk/plugins/ie/installer/installer.wxs.xml Tue Dec 14 08:30:34 2010
@@ -8,7 +8,7 @@
?define upgradeCode = 9a5e649a-ec63-4c7d-99bf-75adb345e7e5 ?
?define win64Flag = yes ?
?else ?
- ?define upgradeCode = 8B3F15BC-42FB-4e0e-BAC4-1DE8C4AA10FD ?
+ ?define upgradeCode = 53DAE7D2-8C28-440F-920B-B2D665CE73B2 ?
?define win64Flag = no ?
?endif ?
?define updateRegKey
= SOFTWARE\Google\Update\Clients\{$(var.upgradeCode)} ?
===
--- /trunk/plugins/ie/installer/oophm.wxs Thu Dec 2 07:41:14 2010
+++ /trunk/plugins/ie/installer/oophm.wxs Tue Dec 14 08:30:34 2010
@@ -12,7 +12,7 @@
/Fragment
Fragment
ComponentGroup Id=oophmDll
-Component Win64=$(var.win64Flag)
Id=cmpC5076456A3EE2DC3FC2683246BE38AD6
Directory=dir315E0C50682DFB472927FE1254A22F6A
Guid=48789066-DDF6-46C5-BF60-408BC872BF05
+Component Win64=$(var.win64Flag)
Id=cmpC5076456A3EE2DC3FC2683246BE38AD6
Directory=dir315E0C50682DFB472927FE1254A22F6A
Guid=76483594-CBB8-438C-B777-5ABF473A90F0
File Id=filEF78EFE99C26E3436EC9C8852A85BE88
KeyPath=yes Source=$(var.binDir)\oophm.dll
TypeLib Id={9259F105-BE55-4BF6-B7CE-D0AA878C1BA6}
Description=oophm 1.0 Type Library
HelpDirectory=dir315E0C50682DFB472927FE1254A22F6A Language=0
MajorVersion=1 MinorVersion=0
AppId Description=oophm
Id={F9365E53-5A14-47F3-BF1D-10CAAB815309}
===
--- /trunk/plugins/ie/prebuilt/gwt-dev-plugin-x64.msi Thu Dec 2 07:41:14
2010
+++ /trunk/plugins/ie/prebuilt/gwt-dev-plugin-x64.msi Tue Dec 14 08:30:34
2010
Binary file, no diff available.
===
--- /trunk/plugins/ie/prebuilt/gwt-dev-plugin-x86.msi Thu Dec 2 07:41:14
2010
+++ /trunk/plugins/ie/prebuilt/gwt-dev-plugin-x86.msi Tue Dec 14 08:30:34
2010
Binary file, no diff available.
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Reduces class and JSNI loading for RPC in devmode. (issue1215801)
http://gwt-code-reviews.appspot.com/1215801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Reduces class and JSNI loading for RPC in devmode. (issue1215801)
http://gwt-code-reviews.appspot.com/1215801/diff/1/4
File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/1/4#newcode231
dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:231:
eventsByGeneratorType.put(com.google.gwt.resources.rebind.context.InlineClientBundleGenerator,
CompilerEventType.GENERATOR_CLIENT_BUNDLE);
On 2010/12/14 14:33:58, zundel wrote:
line length 100
Done.
http://gwt-code-reviews.appspot.com/1215801/diff/1/4#newcode231
dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:231:
eventsByGeneratorType.put(com.google.gwt.resources.rebind.context.InlineClientBundleGenerator,
CompilerEventType.GENERATOR_CLIENT_BUNDLE);
On 2010/12/14 14:33:58, zundel wrote:
Wouldn't it be more robust to refer to these types by class constants?
I know it
would introduce dependencies through import statements, but in effect,
the code
does depend on these classes by using their package names like this,
and will
silently break if there is some refactoring.
It would be a reverse dependency (bad), and also wouldn't even compile.
If something changes causing it to fail, the result would be that the
time would get lumped in as GENERATOR_OTHER and the data would include
the generator class. I think that's fine.
Or maybe it would be better to include an extendable method for
Generator to
return a SpeedTracer event type.
I don't think we should head in that direction. I'd rather see us
improve on tools to slice and dice events by data, so that I could
decide after the fact that I want to see a breakdown of GENERATOR events
by typename.
http://gwt-code-reviews.appspot.com/1215801/diff/1/6
File dev/core/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/1/6#newcode49
dev/core/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java:49: if
(jsniMethod.isScriptOnly()) {
On 2010/12/14 14:33:58, zundel wrote:
I would appreciate a comment here that this is for a performance
optimization.
I added a reference from JsniMethod.isScriptOnly to GwtScriptOnly which
documents this as a performance optimization.
http://gwt-code-reviews.appspot.com/1215801/diff/1/13
File user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/1/13#newcode27
user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java:27:
// as the syntax is correct, e.g. [[Ljava.lang.String;
On 2010/12/14 14:33:58, zundel wrote:
I'm not sure its so surprising the names match, since the
SerializationUtils.getRpcTypeName() is explicitly documented as such.
Maybe
reference that method?
There's intentionally no direct relationship to
SerializationUtils.getRpcTypeName and ReflectionHelper. I expect that
we'll eventually move this class out of rpc.
I added method javadoc and dropped the comment since it's clear from
Class.forName javadoc that it accepts Class.getName syntax.
http://gwt-code-reviews.appspot.com/1215801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9421 committed - Public: Generate BeanDescriptors for GWT Validation....
Revision: 9421
Author: ncha...@google.com
Date: Tue Dec 14 08:48:08 2010
Log: Public: Generate BeanDescriptors for GWT Validation.
[JSR 303 TCK Result] 31 of 258 (12.02%) Pass with 10 Failures and 13 Errors.
Review at http://gwt-code-reviews.appspot.com/1212801
Review by: rchan...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9421
Added:
/trunk/samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/inheritance
/trunk/samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/inheritance/ConstraintInheritanceTest.java
/trunk/samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/inheritance/ConstraintsInheritanceGwtSuite.java
/trunk/samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/inheritance/TckTest.gwt.xml
/trunk/samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/inheritance/TckTestValidator.java
/trunk/samples/validationtck/test/com/google/gwt/sample/validationtck/metadata
/trunk/samples/validationtck/test/com/google/gwt/sample/validationtck/metadata/BeanDescriptorTest.java
/trunk/samples/validationtck/test/com/google/gwt/sample/validationtck/metadata/MetadataGwtSuite.java
/trunk/samples/validationtck/test/com/google/gwt/sample/validationtck/metadata/TckTest.gwt.xml
/trunk/samples/validationtck/test/com/google/gwt/sample/validationtck/metadata/TckTestValidator.java
/trunk/user/src/com/google/gwt/validation/client/impl/GwtBeanDescriptorImpl.java
Deleted:
/trunk/user/src/com/google/gwt/validation/client/impl/AbstractBeanDescriptor.java
Modified:
/trunk/user/src/com/google/gwt/validation/rebind/BeanHelper.java
/trunk/user/src/com/google/gwt/validation/rebind/GwtSpecificValidatorCreator.java
/trunk/user/src/com/google/gwt/validation/rebind/ValidatorCreator.java
===
--- /dev/null
+++
/trunk/samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/inheritance/ConstraintInheritanceTest.java
Tue Dec 14 08:48:08 2010
@@ -0,0 +1,41 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.sample.validationtck.constraints.inheritance;
+
+import com.google.gwt.junit.client.GWTTestCase;
+
+/**
+ * Test wrapper for
+ * {...@link
org.hibernate.jsr303.tck.tests.constraints.inheritance.ConstraintInheritanceTest}
+ * .
+ */
+public class ConstraintInheritanceTest extends GWTTestCase {
+ private final
org.hibernate.jsr303.tck.tests.constraints.inheritance.ConstraintInheritanceTest
delegate =
+ new
org.hibernate.jsr303.tck.tests.constraints.inheritance.ConstraintInheritanceTest();
+
+ @Override
+ public String getModuleName() {
+
return com.google.gwt.sample.validationtck.constraints.inheritance.TckTest;
+ }
+
+ public void testConstraintsOnInterfaceAreInherited() {
+delegate.testConstraintsOnInterfaceAreInherited();
+ }
+
+ public void testConstraintsOnSuperClassAreInherited() {
+delegate.testConstraintsOnSuperClassAreInherited();
+ }
+}
===
--- /dev/null
+++
/trunk/samples/validationtck/test/com/google/gwt/sample/validationtck/constraints/inheritance/ConstraintsInheritanceGwtSuite.java
Tue Dec 14 08:48:08 2010
@@ -0,0 +1,32 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.sample.validationtck.constraints.inheritance;
+
+import com.google.gwt.junit.tools.GWTTestSuite;
+
+import junit.framework.Test;
+
+/**
+ * Tck Tests for the {...@code constraints inheritance} package.
+ */
+public class ConstraintsInheritanceGwtSuite {
+ public static Test suite() {
+GWTTestSuite suite = new GWTTestSuite(
+TCK for GWT Validation, constraints inheritance package);
+suite.addTestSuite(ConstraintInheritanceTest.class);
+return suite;
+ }
+}
[gwt-contrib] Re: Issue 5671: CellWidget breaks HasValue contract: fires ValueChangeEvent even if value doesn't change (issue1155801)
committed as r9413 http://gwt-code-reviews.appspot.com/1155801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Have separate devmode.js files for each permutation if we are outputting (issue1208802)
http://gwt-code-reviews.appspot.com/1208802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Public: GWT emulation for the normal Validation Bootstrap. (issue1208801)
LGTM. With JavaDoc nits. http://gwt-code-reviews.appspot.com/1208801/diff/3001/4002 File samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4002#newcode34 samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java:34: * Validator marker for the Valiation Sample project. Only the classes listed Validation http://gwt-code-reviews.appspot.com/1208801/diff/3001/4005 File samples/validationtck/src/org/hibernate/jsr303/tck/super/org/hibernate/jsr303/tck/common/TCKValidationProvider.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4005#newcode35 samples/validationtck/src/org/hibernate/jsr303/tck/super/org/hibernate/jsr303/tck/common/TCKValidationProvider.java:35: * liMeved cast call./li Moved http://gwt-code-reviews.appspot.com/1208801/diff/3001/4019 File user/src/com/google/gwt/validation/client/GwtValidationProviderResolver.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4019#newcode34 user/src/com/google/gwt/validation/client/GwtValidationProviderResolver.java:34: private final ListValidationProvider? defaultList; Would it be better to make this static? http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022 File user/src/com/google/gwt/validation/client/Validation.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022#newcode197 user/src/com/google/gwt/validation/client/Validation.java:197: * defined, use the default ValidationProviderResolver Is the Javadoc in this class still accurate? http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022#newcode212 user/src/com/google/gwt/validation/client/Validation.java:212: * default Bean Validation provider and following the XML configuration. GWT does not use XML config, right? http://gwt-code-reviews.appspot.com/1208801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Reduces class and JSNI loading for RPC in devmode. (issue1215801)
LG, just nits.
http://gwt-code-reviews.appspot.com/1215801/diff/1/4
File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/1/4#newcode231
dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:231:
eventsByGeneratorType.put(com.google.gwt.resources.rebind.context.InlineClientBundleGenerator,
CompilerEventType.GENERATOR_CLIENT_BUNDLE);
I thought it was possible to create new event types on the fly. Maybe
we should just do that for every generator? I get that this is very
practical, feels slightly hacky tho. :)
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8004
File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8004#newcode1255
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:1255:
event.end();
Try/finally? I think the call can fail, if say the comm channel drops.
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8006
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/CompilerEventType.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8006#newcode38
dev/core/src/com/google/gwt/dev/util/log/speedtracer/CompilerEventType.java:38:
GENERATOR_OTHER(Generator (Other), Red), //
Feels kind of ugh to include these here. I'm starting to think just
creating event types on the fly for generator types is the way to go.
Could all be done inside StandardGeneratorContext.
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8009
File tools/api-checker/config/gwt21_22userApi.conf (right):
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8009#newcode123
tools/api-checker/config/gwt21_22userApi.conf:123:
com.google.gwt.user.client.rpc.core.java.util.Collections.SingletonList_CustomFieldSerializer::concreteType()
RETURN_TYPE_ERROR
Should we just exclude that whole package? This is a non-user-facing
implementation detail.
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8017
File user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8017#newcode327
user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java:327:
* Writes a method to produce a map of type string - {...@link TypeHandler}
map of type string - type handler class name?
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8017#newcode444
user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java:444:
* Writes a method to produce a map of class to type string for Java.
also needs update
http://gwt-code-reviews.appspot.com/1215801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Have separate devmode.js files for each permutation if we are outputting (issue1208802)
LGTM http://gwt-code-reviews.appspot.com/1208802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to th... (issue1217801)
Reviewers: tobyr, jbrosenberg, scottb, Description: Refactors TypeOracleMediator to avoid CompiledClass references. This way, we will be able to throw in byte code from other sources besides JDT. This design is a little different from the Instant Hosted Mode change which created a BinaryCompileClass type to represent pre-compiled code. An additional unit test that runs purely from byte code from the classloader will follow this change. The TypeOracleMediatorTest is slightly refactored in this change to make the unit test changes easier to review in the next patch. Please review this at http://gwt-code-reviews.appspot.com/1217801/show Affected files: M dev/core/src/com/google/gwt/dev/javac/CompilationState.java M dev/core/src/com/google/gwt/dev/javac/TypeOracleMediator.java A dev/core/src/com/google/gwt/dev/javac/TypeOracleMediatorFromSource.java M dev/core/test/com/google/gwt/dev/javac/JavaCompilationSuite.java D dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTest.java A dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java A dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestFromSource.java M tools/api-checker/src/com/google/gwt/tools/apichecker/ApiContainer.java -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] New Google Groups apparent with GWT ?
Are there any code samples/documentation of integrating Closure Library widgets (like rich text editor etc) with GWT. if this integration can be done seamlessly with no performance hit this would help GWT developers get the best of both worlds(GWT and Closure Library) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Have separate devmode.js files for each permutation if we are outputting (issue1208802)
http://gwt-code-reviews.appspot.com/1208802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Have separate devmode.js files for each permutation if we are outputting (issue1208802)
Still LGTM. http://gwt-code-reviews.appspot.com/1208802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Update samples/expenses/pom.xml for 2.1.1. Also fix bad gwt-maven-plugin config. (issue1218801)
Reviewers: drfibonacci,
Description:
Update samples/expenses/pom.xml for 2.1.1. Also fix bad gwt-maven-plugin
config.
Please review this at http://gwt-code-reviews.appspot.com/1218801/show
Affected files:
M samples/expenses/pom.xml
A samples/expenses/src/main/resources/log4j.properties
M tools/scripts/maven_script.sh
Index: samples/expenses/pom.xml
===
--- samples/expenses/pom.xml(revision 9421)
+++ samples/expenses/pom.xml(working copy)
@@ -7,7 +7,7 @@
version0.1.0.BUILD-SNAPSHOT/version
nameexpenses/name
properties
-gwt.version2.1.1-rc1/gwt.version
+gwt.version2.1.1/gwt.version
roo.version1.1.0.RELEASE/roo.version
spring.version3.0.3.RELEASE/spring.version
slf4j.version1.6.1/slf4j.version
@@ -620,7 +620,7 @@
/dependency
dependency
groupIdcom.google.gwt/groupId
-artifactIdgwt-user/artifactId
+artifactIdgwt-dev/artifactId
version${gwt.version}/version
/dependency
/dependencies
Index: samples/expenses/src/main/resources/log4j.properties
===
--- samples/expenses/src/main/resources/log4j.properties(revision 0)
+++ samples/expenses/src/main/resources/log4j.properties(revision 0)
Index: tools/scripts/maven_script.sh
===
--- tools/scripts/maven_script.sh (revision 9421)
+++ tools/scripts/maven_script.sh (working copy)
@@ -14,16 +14,15 @@
# License for the specific language governing permissions and limitations
under
# the License.
-
# This script should be run from the trunk dir.
-ant clean dist-dev
+echo Did you remember to run ant clean dist-dev
MAVEN_REPO=~/.m2/repository
for i in dev user servlet
do
- mvn install:install-file -DgroupId=com.google.gwt -DartifactId=gwt-${i}
-Dversion=2.1.1-rc1 -Dpackaging=jar -Dfile=build/lib/gwt-${i}.jar
-DgeneratePom=true
+ mvn install:install-file -DgroupId=com.google.gwt -DartifactId=gwt-${i}
-Dversion=2.1.1 -Dpackaging=jar -Dfile=build/lib/gwt-${i}.jar
-DgeneratePom=true
done
touch /tmp/empty-fake-soyc-vis.jar
-mvn install:install-file -DgroupId=com.google.gwt
-DartifactId=gwt-soyc-vis -Dversion=2.1.1-rc1 -Dpackaging=jar
-DgeneratePom=true -Dfile=/tmp/empty-fake-soyc-vis.jar
+mvn install:install-file -DgroupId=com.google.gwt
-DartifactId=gwt-soyc-vis -Dversion=2.1.1 -Dpackaging=jar
-DgeneratePom=true -Dfile=/tmp/empty-fake-soyc-vis.jar
echo installed the gwt libs in the maven repo
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Reduces class and JSNI loading for RPC in devmode. (issue1215801)
http://gwt-code-reviews.appspot.com/1215801/diff/1/4
File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/1/4#newcode231
dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:231:
eventsByGeneratorType.put(com.google.gwt.resources.rebind.context.InlineClientBundleGenerator,
CompilerEventType.GENERATOR_CLIENT_BUNDLE);
On 2010/12/14 22:11:56, scottb wrote:
I thought it was possible to create new event types on the fly. Maybe
we should
just do that for every generator? I get that this is very practical,
feels
slightly hacky tho. :)
I don't think that's practical. For example, I'm doing things like
manually categorizing groups of generators together. (For example, deRPC
+ RPC, and all i18n generators). You'd also have to synthesize
reasonable colors for these things.
Again, I think we can improve our tooling instead and make this go away.
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8004
File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8004#newcode1255
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:1255:
event.end();
On 2010/12/14 22:11:56, scottb wrote:
Try/finally? I think the call can fail, if say the comm channel
drops.
Done.
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8006
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/CompilerEventType.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8006#newcode38
dev/core/src/com/google/gwt/dev/util/log/speedtracer/CompilerEventType.java:38:
GENERATOR_OTHER(Generator (Other), Red), //
On 2010/12/14 22:11:56, scottb wrote:
Feels kind of ugh to include these here. I'm starting to think just
creating
event types on the fly for generator types is the way to go. Could
all be done
inside StandardGeneratorContext.
FWIW, I did actually try this and it turned out to be actively worse.
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8009
File tools/api-checker/config/gwt21_22userApi.conf (right):
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8009#newcode123
tools/api-checker/config/gwt21_22userApi.conf:123:
com.google.gwt.user.client.rpc.core.java.util.Collections.SingletonList_CustomFieldSerializer::concreteType()
RETURN_TYPE_ERROR
On 2010/12/14 22:11:56, scottb wrote:
Should we just exclude that whole package? This is a non-user-facing
implementation detail.
Done.
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8017
File user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
(right):
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8017#newcode327
user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java:327:
* Writes a method to produce a map of type string - {...@link TypeHandler}
On 2010/12/14 22:11:56, scottb wrote:
map of type string - type handler class name?
Done.
http://gwt-code-reviews.appspot.com/1215801/diff/7001/8017#newcode444
user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java:444:
* Writes a method to produce a map of class to type string for Java.
On 2010/12/14 22:11:56, scottb wrote:
also needs update
Done.
http://gwt-code-reviews.appspot.com/1215801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Public: GWT emulation for the normal Validation Bootstrap. (issue1208801)
http://gwt-code-reviews.appspot.com/1208801/diff/3001/4002 File samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4002#newcode34 samples/validation/src/com/google/gwt/sample/validation/client/SampleValidator.java:34: * Validator marker for the Valiation Sample project. Only the classes listed On 2010/12/14 20:52:46, rchandia wrote: Validation Done. http://gwt-code-reviews.appspot.com/1208801/diff/3001/4005 File samples/validationtck/src/org/hibernate/jsr303/tck/super/org/hibernate/jsr303/tck/common/TCKValidationProvider.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4005#newcode35 samples/validationtck/src/org/hibernate/jsr303/tck/super/org/hibernate/jsr303/tck/common/TCKValidationProvider.java:35: * liMeved cast call./li On 2010/12/14 20:52:46, rchandia wrote: Moved Done. http://gwt-code-reviews.appspot.com/1208801/diff/3001/4019 File user/src/com/google/gwt/validation/client/GwtValidationProviderResolver.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4019#newcode34 user/src/com/google/gwt/validation/client/GwtValidationProviderResolver.java:34: private final ListValidationProvider? defaultList; On 2010/12/14 20:52:46, rchandia wrote: Would it be better to make this static? Done. http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022 File user/src/com/google/gwt/validation/client/Validation.java (right): http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022#newcode197 user/src/com/google/gwt/validation/client/Validation.java:197: * defined, use the default ValidationProviderResolver On 2010/12/14 20:52:46, rchandia wrote: Is the Javadoc in this class still accurate? Yes in that I will allow this. Unsure if it is fully implemented. http://gwt-code-reviews.appspot.com/1208801/diff/3001/4022#newcode212 user/src/com/google/gwt/validation/client/Validation.java:212: * default Bean Validation provider and following the XML configuration. On 2010/12/14 20:52:46, rchandia wrote: GWT does not use XML config, right? Done. http://gwt-code-reviews.appspot.com/1208801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9422 committed - Have separate devmode.js files for each permutation if we are outputti...
Revision: 9422
Author: unn...@google.com
Date: Tue Dec 14 13:21:45 2010
Log: Have separate devmode.js files for each permutation if we are
outputting
bootstrap in the primary fragment so we can put the properties info in
them and avoid putting it in the primary fragment. Also, fail explicitly
when we encounter a script tag in the gwt.xml
rather than failing silently (xsiframe linker does not support this feature)
Review at http://gwt-code-reviews.appspot.com/1208802
http://code.google.com/p/google-web-toolkit/source/detail?r=9422
Added:
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/propertiesServerSide.js
Deleted:
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/propertiesNull.js
Modified:
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/PropertiesUtil.java
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
/trunk/dev/core/src/com/google/gwt/core/linker/CrossSiteIframeLinker.java
/trunk/user/test/com/google/gwt/dev/jjs/CrossSiteIframeRunAsyncMetrics.gwt.xml
===
--- /dev/null
+++
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/propertiesServerSide.js
Tue Dec 14 13:21:45 2010
@@ -0,0 +1,27 @@
+// Computes the value of a given property that was determined during the
+// compilation process. This assumes that the bootstrap is embedded in an
MD5
+// specific file, and during the compilation phase, the PermutationsUtil
class
+// will take care of filling the __KNOWN_PROPERTIES__ section with the
values
+// of the properties for this specific permutation. Note that if a
permutation
+// is valid for more than one property value (for example user.agent =
chrome
+// or safari) then one of those values will be chosen at random. Since the
+// different values resulted in the same MD5 file, we can assume that the
+// behavior of this module is the same for either value.
+
+ var properties = [];
+
+ function computePropValue(propName) {
+if (propName in properties) {
+ return properties[propName];
+}
+throw null;
+ }
+
+ __KNOWN_PROPERTIES__
+
+ // It's unclear how/if this function is applicable in the context of the
+ // properties being selected on the server. Just return false for now.
+ __gwt_isKnownPropertyValue = function(propName, propValue) {
+return false;
+ }
+ __MODULE_FUNC__.__computePropValue = computePropValue;
===
---
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/propertiesNull.js
Tue Oct 12 16:00:43 2010
+++ /dev/null
@@ -1,4 +0,0 @@
- __gwt_isKnownPropertyValue = function(propName, propValue) {
-return false;
- }
- __MODULE_FUNC__.__computePropValue = null;
===
---
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/PropertiesUtil.java
Tue Nov 23 06:49:43 2010
+++
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/PropertiesUtil.java
Tue Dec 14 13:21:45 2010
@@ -18,12 +18,37 @@
import com.google.gwt.core.ext.LinkerContext;
import com.google.gwt.core.ext.TreeLogger;
+import com.google.gwt.core.ext.linker.CompilationResult;
import com.google.gwt.core.ext.linker.SelectionProperty;
+import java.util.Map.Entry;
+
/**
* A utility class to fill in the properties javascript in linker
templates.
*/
public class PropertiesUtil {
+ public static String addKnownPropertiesJs(TreeLogger logger,
+ CompilationResult result) {
+StringBuffer propertiesJs = new StringBuffer();
+
+// Multiple values for a property can result in one permutation. For
+// example, this permutation may be valid for safari and chrome.
However,
+// we need to pick one, since the computePropValue() needs to return a
+// single value. It actually doesn't matter which one we pick. The
fact
+// that safari and chrome compiled into one permutation indicates that
+// for this module, the behavior is the same. Therefore, we just pick
+// the first one.
+for (EntrySelectionProperty, String entry :
+ result.getPropertyMap().first().entrySet()) {
+ propertiesJs.append(properties[');
+ propertiesJs.append(entry.getKey().getName());
+ propertiesJs.append('] = ');
+ propertiesJs.append(entry.getValue());
+ propertiesJs.append(';);
+}
+return propertiesJs.toString();
+ }
+
public static StringBuffer addPropertiesJs(StringBuffer selectionScript,
TreeLogger logger, LinkerContext context) {
int startPos;
@@ -38,7 +63,7 @@
}
}
return selectionScript;
- }
+ }
private static String generatePropertyProvider(SelectionProperty prop) {
StringBuffer toReturn = new StringBuffer();
===
---
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
Wed Nov 10 07:09:21 2010
+++
/trunk/dev/core/src/com/google/gwt/core/ext/linker/impl/SelectionScriptLinker.java
Tue Dec 14 13:21:45
[gwt-contrib] [google-web-toolkit] r9423 committed - Update samples/expenses/pom.xml for 2.1.1. Also fix bad gwt-maven-plug...
Revision: 9423
Author: gwt.mirror...@gmail.com
Date: Tue Dec 14 16:40:09 2010
Log: Update samples/expenses/pom.xml for 2.1.1. Also fix bad
gwt-maven-plugin config.
Review at http://gwt-code-reviews.appspot.com/1218801
Review by: drfibona...@google.com
http://code.google.com/p/google-web-toolkit/source/detail?r=9423
Added:
/trunk/samples/expenses/src/main/resources
/trunk/samples/expenses/src/main/resources/log4j.properties
Modified:
/trunk/samples/expenses/pom.xml
/trunk/tools/scripts/maven_script.sh
===
--- /trunk/samples/expenses/pom.xml Thu Dec 9 08:29:18 2010
+++ /trunk/samples/expenses/pom.xml Tue Dec 14 16:40:09 2010
@@ -7,7 +7,7 @@
version0.1.0.BUILD-SNAPSHOT/version
nameexpenses/name
properties
-gwt.version2.1.1-rc1/gwt.version
+gwt.version2.1.1/gwt.version
roo.version1.1.0.RELEASE/roo.version
spring.version3.0.3.RELEASE/spring.version
slf4j.version1.6.1/slf4j.version
@@ -620,7 +620,7 @@
/dependency
dependency
groupIdcom.google.gwt/groupId
-artifactIdgwt-user/artifactId
+artifactIdgwt-dev/artifactId
version${gwt.version}/version
/dependency
/dependencies
===
--- /trunk/tools/scripts/maven_script.shThu Dec 9 08:29:18 2010
+++ /trunk/tools/scripts/maven_script.shTue Dec 14 16:40:09 2010
@@ -14,16 +14,15 @@
# License for the specific language governing permissions and limitations
under
# the License.
-
# This script should be run from the trunk dir.
-ant clean dist-dev
+echo Did you remember to run ant clean dist-dev
MAVEN_REPO=~/.m2/repository
for i in dev user servlet
do
- mvn install:install-file -DgroupId=com.google.gwt -DartifactId=gwt-${i}
-Dversion=2.1.1-rc1 -Dpackaging=jar -Dfile=build/lib/gwt-${i}.jar
-DgeneratePom=true
+ mvn install:install-file -DgroupId=com.google.gwt -DartifactId=gwt-${i}
-Dversion=2.1.1 -Dpackaging=jar -Dfile=build/lib/gwt-${i}.jar
-DgeneratePom=true
done
touch /tmp/empty-fake-soyc-vis.jar
-mvn install:install-file -DgroupId=com.google.gwt
-DartifactId=gwt-soyc-vis -Dversion=2.1.1-rc1 -Dpackaging=jar
-DgeneratePom=true -Dfile=/tmp/empty-fake-soyc-vis.jar
+mvn install:install-file -DgroupId=com.google.gwt
-DartifactId=gwt-soyc-vis -Dversion=2.1.1 -Dpackaging=jar
-DgeneratePom=true -Dfile=/tmp/empty-fake-soyc-vis.jar
echo installed the gwt libs in the maven repo
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update samples/expenses/pom.xml for 2.1.1. Also fix bad gwt-maven-plugin config. (issue1218801)
r9423 http://gwt-code-reviews.appspot.com/1218801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make ExternalTextResource use Jsonp (issue1214801)
http://gwt-code-reviews.appspot.com/1214801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make ExternalTextResource use Jsonp (issue1214801)
http://gwt-code-reviews.appspot.com/1214801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make ExternalTextResource use Jsonp (issue1214801)
LGTM http://gwt-code-reviews.appspot.com/1214801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9424 committed - Reduces class and JSNI loading for RPC in devmode....
Revision: 9424
Author: gwt.mirror...@gmail.com
Date: Tue Dec 14 17:09:19 2010
Log: Reduces class and JSNI loading for RPC in devmode.
- Makes GwtScriptOnly work with JSNI methods.
- Modifies the RPC generator to tag native methods with GwtScriptOnly.
- Modifies the RPC generator to defer class loads of FieldSerializers until
needed.
Review at http://gwt-code-reviews.appspot.com/1215801
http://code.google.com/p/google-web-toolkit/source/detail?r=9424
Added:
/trunk/user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java
/trunk/user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl
/trunk/user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java
Modified:
/trunk/dev/core/src/com/google/gwt/dev/javac/JsniCollector.java
/trunk/dev/core/src/com/google/gwt/dev/javac/JsniMethod.java
/trunk/dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
/trunk/dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
/trunk/dev/core/src/com/google/gwt/dev/shell/ModuleSpaceOOPHM.java
/trunk/dev/core/src/com/google/gwt/dev/util/log/speedtracer/CompilerEventType.java
/trunk/dev/core/src/com/google/gwt/dev/util/log/speedtracer/DevModeEventType.java
/trunk/dev/core/super/com/google/gwt/core/client/GwtScriptOnly.java
/trunk/tools/api-checker/config/gwt21_22userApi.conf
/trunk/user/src/com/google/gwt/user/client/rpc/core/java/util/Arrays.java
/trunk/user/src/com/google/gwt/user/client/rpc/core/java/util/Collections.java
/trunk/user/src/com/google/gwt/user/client/rpc/impl/SerializerBase.java
/trunk/user/src/com/google/gwt/user/rebind/rpc/CustomFieldSerializerValidator.java
/trunk/user/src/com/google/gwt/user/rebind/rpc/FieldSerializerCreator.java
/trunk/user/src/com/google/gwt/user/rebind/rpc/ProxyCreator.java
/trunk/user/src/com/google/gwt/user/rebind/rpc/TypeSerializerCreator.java
===
--- /dev/null
+++
/trunk/user/src/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java
Tue Dec 14 17:09:19 2010
@@ -0,0 +1,44 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.user.client.rpc.impl;
+
+import java.lang.reflect.Constructor;
+
+/**
+ * Provides access to reflection capability, but only when running from
+ * bytecode.
+ */
+public class ReflectionHelper {
+
+ /**
+ * Loads {...@code klass} using Class.forName.
+ */
+ public static Class? loadClass(String klass) throws Exception {
+return Class.forName(klass);
+ }
+
+ /**
+ * Creates a new instance of {...@code klass}. The class must have a no-arg
+ * constructor. The constructor may have any access modifier (for
example,
+ * private).
+ */
+ public static T T newInstance(ClassT klass)
+ throws Exception {
+ConstructorT c = klass.getDeclaredConstructor();
+c.setAccessible(true);
+return c.newInstance();
+ }
+}
===
--- /dev/null
+++
/trunk/user/super/com/google/gwt/user/translatable/com/google/gwt/user/client/rpc/impl/ReflectionHelper.java
Tue Dec 14 17:09:19 2010
@@ -0,0 +1,34 @@
+/*
+ * Copyright 2010 Google Inc.
+ *
+ * Licensed under the Apache License, Version 2.0 (the License); you may
not
+ * use this file except in compliance with the License. You may obtain a
copy of
+ * the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an AS IS BASIS,
WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package com.google.gwt.user.client.rpc.impl;
+
+import com.google.gwt.core.client.GwtScriptOnly;
+
+/**
+ * The script-mode equivalent for ReflectionHelper. This version throws
+ * exceptions if used, because ReflectionHelper can only be used from
bytecode.
+ */
+...@gwtscriptonly
+public class ReflectionHelper {
+ public static Class? loadClass(String name) throws Exception {
+throw new RuntimeException(ReflectionHelper can't be used from web
mode.);
+ }
+
+ public static T T newInstance(ClassT klass)
+ throws Exception {
+throw new RuntimeException(ReflectionHelper can't be used from web
mode.);
+ }
+}
[gwt-contrib] Re: Make ExternalTextResource use Jsonp (issue1214801)
http://gwt-code-reviews.appspot.com/1214801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make ExternalTextResource use Jsonp (issue1214801)
http://gwt-code-reviews.appspot.com/1214801/diff/1/2
File user/src/com/google/gwt/jsonp/client/JsonpRequest.java (right):
http://gwt-code-reviews.appspot.com/1214801/diff/1/2#newcode33
user/src/com/google/gwt/jsonp/client/JsonpRequest.java:33:
On 2010/12/13 21:42:50, jat wrote:
Added whitespace.
Done.
http://gwt-code-reviews.appspot.com/1214801/diff/1/2#newcode78
user/src/com/google/gwt/jsonp/client/JsonpRequest.java:78:
On 2010/12/13 21:42:50, jat wrote:
Whitespace.
Done.
http://gwt-code-reviews.appspot.com/1214801/diff/1/2#newcode129
user/src/com/google/gwt/jsonp/client/JsonpRequest.java:129: * Create a
new JSONP request.
On 2010/12/13 21:42:50, jat wrote:
Shouldn't this distinguish from the above constructor, explaining why
this would
be used?
Done.
http://gwt-code-reviews.appspot.com/1214801/diff/1/2#newcode142
user/src/com/google/gwt/jsonp/client/JsonpRequest.java:142: String
callbackParam, String failureCallbackParam, String id) {
On 2010/12/13 21:42:50, jat wrote:
Need javadoc for id.
Done.
http://gwt-code-reviews.appspot.com/1214801/diff/1/6
File
user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java
(right):
http://gwt-code-reviews.appspot.com/1214801/diff/1/6#newcode67
user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java:67:
On 2010/12/13 21:42:50, jat wrote:
Whitespace.
Done.
http://gwt-code-reviews.appspot.com/1214801/diff/1/6#newcode91
user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java:91:
On 2010/12/13 21:42:50, jat wrote:
Whitespace.
Done.
http://gwt-code-reviews.appspot.com/1214801/diff/1/6#newcode154
user/src/com/google/gwt/resources/rg/ExternalTextResourceGenerator.java:154:
On 2010/12/13 21:42:50, jat wrote:
Whitespace.
Something must be set wrong in your IDE to generate all these where
they didn't
exist previously.
It seems like it doesn't it? I have the gwt formatting stuff imported
though, and as far as I can tell, indent is not checked for blank
lines...
http://gwt-code-reviews.appspot.com/1214801/diff/1/8
File
user/test/com/google/gwt/resources/ExternalTextResourceJsonp.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/1214801/diff/1/8#newcode16
user/test/com/google/gwt/resources/ExternalTextResourceJsonp.gwt.xml:16:
set-configuration-property name=ExternalTextResource.useJsonp
value=true /
On 2010/12/13 21:42:50, jat wrote:
80 columns
Done.
http://gwt-code-reviews.appspot.com/1214801/diff/1/11
File
user/test/com/google/gwt/resources/client/ExternalTextResourceTest.java
(right):
http://gwt-code-reviews.appspot.com/1214801/diff/1/11#newcode26
user/test/com/google/gwt/resources/client/ExternalTextResourceTest.java:26:
static interface Resources extends ClientBundleWithLookup {
On 2010/12/13 21:42:50, jat wrote:
Why package protected?
Done.
http://gwt-code-reviews.appspot.com/1214801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Make ExternalTextResource use Jsonp (issue1214801)
LGTM http://gwt-code-reviews.appspot.com/1214801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] [google-web-toolkit] r9426 committed - Cherry pick r9423 to releases/2.1, Update samples/expenses/pom.xml for...
Revision: 9426
Author: rj...@google.com
Date: Tue Dec 14 13:47:03 2010
Log: Cherry pick r9423 to releases/2.1, Update samples/expenses/pom.xml for
2.1.1
http://code.google.com/p/google-web-toolkit/source/detail?r=9426
Added:
/releases/2.1/samples/expenses/src/main/resources
/releases/2.1/samples/expenses/src/main/resources/log4j.properties
Modified:
/releases/2.1/samples/expenses/pom.xml
/releases/2.1/tools/scripts/maven_script.sh
===
--- /releases/2.1/samples/expenses/pom.xml Thu Dec 9 09:19:49 2010
+++ /releases/2.1/samples/expenses/pom.xml Tue Dec 14 13:47:03 2010
@@ -7,7 +7,7 @@
version0.1.0.BUILD-SNAPSHOT/version
nameexpenses/name
properties
-gwt.version2.1.1-rc1/gwt.version
+gwt.version2.1.1/gwt.version
roo.version1.1.0.RELEASE/roo.version
spring.version3.0.3.RELEASE/spring.version
slf4j.version1.6.1/slf4j.version
@@ -620,7 +620,7 @@
/dependency
dependency
groupIdcom.google.gwt/groupId
-artifactIdgwt-user/artifactId
+artifactIdgwt-dev/artifactId
version${gwt.version}/version
/dependency
/dependencies
===
--- /releases/2.1/tools/scripts/maven_script.sh Thu Dec 9 09:19:49 2010
+++ /releases/2.1/tools/scripts/maven_script.sh Tue Dec 14 13:47:03 2010
@@ -14,16 +14,15 @@
# License for the specific language governing permissions and limitations
under
# the License.
-
# This script should be run from the trunk dir.
-ant clean dist-dev
+echo Did you remember to run ant clean dist-dev
MAVEN_REPO=~/.m2/repository
for i in dev user servlet
do
- mvn install:install-file -DgroupId=com.google.gwt -DartifactId=gwt-${i}
-Dversion=2.1.1-rc1 -Dpackaging=jar -Dfile=build/lib/gwt-${i}.jar
-DgeneratePom=true
+ mvn install:install-file -DgroupId=com.google.gwt -DartifactId=gwt-${i}
-Dversion=2.1.1 -Dpackaging=jar -Dfile=build/lib/gwt-${i}.jar
-DgeneratePom=true
done
touch /tmp/empty-fake-soyc-vis.jar
-mvn install:install-file -DgroupId=com.google.gwt
-DartifactId=gwt-soyc-vis -Dversion=2.1.1-rc1 -Dpackaging=jar
-DgeneratePom=true -Dfile=/tmp/empty-fake-soyc-vis.jar
+mvn install:install-file -DgroupId=com.google.gwt
-DartifactId=gwt-soyc-vis -Dversion=2.1.1 -Dpackaging=jar
-DgeneratePom=true -Dfile=/tmp/empty-fake-soyc-vis.jar
echo installed the gwt libs in the maven repo
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Update samples/expenses/pom.xml for 2.1.1. Also fix bad gwt-maven-plugin config. (issue1218801)
LGTM http://gwt-code-reviews.appspot.com/1218801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
