[gwt-contrib] Re: Fix issue 6959. (issue1587803)
http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/EditorSource.java File user/src/com/google/gwt/editor/client/adapters/EditorSource.java (right): http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/EditorSource.java#newcode60 user/src/com/google/gwt/editor/client/adapters/EditorSource.java:60: * For backwards compatibility with GWT 2.5.0 and earlier, the default implemtation calls On 2013/01/15 02:55:22, skybrian wrote: sp: implementation Done. http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java File user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java (right): http://gwt-code-reviews.appspot.com/1587803/diff/5002/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode44 user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:44: return new IndexedEditorT(-1, null); On 2013/01/15 02:55:22, skybrian wrote: If IndexedEditor's index is -1 then getValue() always returns null and setValue() probably throws an exception eventually in data.setRowData (I didn't trace it). It seems like it would be clearer to return an anonymous subclass of LeafValueEditor that implements getValue() and setValue() to do this directly? I'm assuming setValue() shouldn't be called at all, not sure about getValue. I was assuming getValue/setValue wouldn't be called, but user code can actually call them (from the EditorVisitor passed to EditorContext#traverseSyntheticCompositeEditor). I can't see any use case for that, but still. So I fixed IndexedEditor to no longer throw if data is null. Then dispose() can do an instanceof check and ignore this instance. Or perhaps keep it in a constant and use ==. Actually, dispose() won't be called; that was a leftover from a previous iteration where I only moved the create(0) to createEditorForTraversal; I then moved both create(0) and dispose() so, in the case of HasDataEditor, dispose is no longer called for the synthetic editor. http://gwt-code-reviews.appspot.com/1587803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Developing a new remote RunStyle for PhantomJS
I see, it's probably perfectly applicable to Travis CI (I would just
start the phantomjs webdriver server before executing tests) but what about:
http://code.google.com/p/google-web-toolkit/issues/detail?id=7768
Am 15.01.2013 02:29, schrieb Thomas Broyer:
Note that, while probably not applicable to Travis CI, there's
GhostDriver (WebDriver for PhantomJS) which should allow you to use
the Selenium RunStyle to drive PhantomJS.
On Monday, January 14, 2013 8:59:14 PM UTC+1, Maik Riechert wrote:
Hi all,
As htmlunit isn't suited for all testing scenarios (in particular
layout specific ones), I'd like to use PhantomJS as an alternative
(production mode only). It is a headless webkit engine and can be
easily controlled with JS files, meaning that the new RunStyle
would fork a shell process phantomjs pageload.js where
pageload.js would be written to disk beforehand containing:
var page = require('webpage').create();
var url = 'http://host/gwt...';
page.open(url, function (status) {
//Page is loaded!
phantom.exit();
});
This is particularly great for CI, in my case Travis CI, as it
already has phantomjs installed. Is there a way that I can write a
new RunStyle class and make it available as a kind of plugin? Or
do I really have to submit it as a patch and hope that it gets
included in the official GWT distribution?
Thanks for your support!
Maik
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: simple typo
Daniel Kurka has abandoned this change. Change subject: simple typo .. Abandoned commited -- To view, visit https://gwt-review.googlesource.com/1730 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If17d1c835a05df4409e242bd27c52fbc673ccd90 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: updated javadoc n DeckPanel.getVisibleWidget() fixes issue 7...
Daniel Kurka has abandoned this change. Change subject: updated javadoc n DeckPanel.getVisibleWidget() fixes issue 7680 .. Abandoned commited -- To view, visit https://gwt-review.googlesource.com/1720 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I457b2238ee2f36b0958fed47ed012329a860e0d1 Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: AbstractMap.remove() is incorrect, accessing entry after del...
Daniel Kurka has abandoned this change. Change subject: AbstractMap.remove() is incorrect, accessing entry after deletion fixes issue 7856 .. Abandoned commited -- To view, visit https://gwt-review.googlesource.com/1740 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I4d3d92d7aaf13e499c8e12b680ecae66864f8a3a Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Developing a new remote RunStyle for PhantomJS
On Tuesday, January 15, 2013 10:27:57 AM UTC+1, Maik Riechert wrote: I see, it's probably perfectly applicable to Travis CI (I would just start the phantomjs webdriver server before executing tests) but what about: http://code.google.com/p/google-web-toolkit/issues/detail?id=7768 Ah, good catch! Patches welcome! ;-) -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] GWT 2.5.1 release - Call for help
Anything I can do with https://codereview.appspot.com/6132056/ to help get it ready to go out with whatever release is deemed appropriate? On 13 January 2013 18:24, Patrick Tucker tucker...@gmail.com wrote: Any chance these can get committed? http://gwt-code-reviews.appspot.com/1876803/ http://gwt-code-reviews.appspot.com/1762803/ http://gwt-code-reviews.appspot.com/1833803/ http://gwt-code-reviews.appspot.com/1785803/ http://gwt-code-reviews.appspot.com/1736804/ On Saturday, January 12, 2013 11:02:41 AM UTC-5, Daniel Kurka wrote: Repost from gwt-steering: Hi Everyone, a quick status update. In the last week a lot of patches have been contributed and some have already been submitted. At the beginning of next week I want to close of for any new patches, so that we can finish the work we are started. We are aiming for a code freeze at the 24th of Januar and a release a short time after that. So once again, if you feel strongly that you need to have something included in GWT 2.5.1 now is the time to act. We also have a couple of open issues that we would like to see in GWT 2.5.1, but might not make it (see: https://docs.google.com/** spreadsheet/ccc?key=**0AuK8EZ6jAAQrdDk1ME1lcmtWOWt3M**ngxOUlTMGJSVEEhttps://docs.google.com/spreadsheet/ccc?key=0AuK8EZ6jAAQrdDk1ME1lcmtWOWt3MngxOUlTMGJSVEE ). Feel free to to contribute patches and do code reviews on the issues listed in the document. -Daniel On Saturday, January 12, 2013 4:17:29 PM UTC+1, Thomas Broyer wrote: On Saturday, January 12, 2013 3:40:42 PM UTC+1, Julien Dramaix wrote: It would be nice to adapt the following paragraph [1] to explain the procedure for submitting code in gerrit. This paragraph is still mentioning svn [1] : https://developers.google.com/**web-toolkit/makinggwtbetter?#** submittingpatcheshttps://developers.google.com/web-toolkit/makinggwtbetter?#submittingpatches I think the idea was to wait until the move to Git is complete. For now the Git repo is still a mirror of the SVN repo (git-svn) which is a mirror of Google's internal Perforce. To complete the move, we'll rewrite the history to remove all big files (prebuilt plugins and api-checker reference jars) so all contributors will have to re-sync their Git repo. So in the mean time, SVN and Rietveld is still OK, though deprecated. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] GWT 2.5.1 release - Call for help
On Tuesday, January 15, 2013 12:02:54 PM UTC+1, James Horsley wrote: Anything I can do with https://codereview.appspot.com/6132056/ to help get it ready to go out with whatever release is deemed appropriate? Won't make it to 2.5.1 sorry. For the next release after 2.5.1, my first task is to finish modularizing and mavenizing GWT, and only then I'll get back to fully work on fixing issues. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Hello Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/1750 to look at the new patch set (#5). Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. avoid busy waiting in SchedulerImpl.runRepeatingTasks If all task are finished in the queue, the code was doing busy waiting. Added detection for finished task, thus returning as soon as possible. fixes issue 7307 Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb --- M user/src/com/google/gwt/core/client/impl/SchedulerImpl.java M user/test/com/google/gwt/core/client/impl/SchedulerImplTest.java 2 files changed, 118 insertions(+), 48 deletions(-) -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Daniel Kurka has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 5: nit picking -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Thomas Broyer has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 5: IIUC, the test as written now would timeout without the fix, right? It might be worth documenting… -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Daniel Kurka has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 5: Where would we document that? -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Thomas Broyer has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 5: For me, it would be enough to add to the never expire comment; somethin like: never expire, would loop indefinitely if the loop always waited TIME_SLICE, and the test would timeout, and add a link to the issue in the javadoc for the test. (I would have done it entirely differently: call runRepeatingTasks directly, and in the mock Duration assert that it hasn't been called more times than the task +/-1, and when it returns, check that the returned list is empty and the task has been called enough times; your test is fine though, I'm possibly/probably too low-level here) -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 5 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: Issue 7713 - Float/Double parsing of NaN/Infinity
Matthew Dempsky has abandoned this change. Change subject: Issue 7713 - Float/Double parsing of NaN/Infinity .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/1670 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ibc14d48df05e2029d4bcc780c77883f07b7f07f4 Gerrit-PatchSet: 3 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: increased zIndex of compile dialog to avoid it being hidden
Matthew Dempsky has abandoned this change. Change subject: increased zIndex of compile dialog to avoid it being hidden .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/1530 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Id1a541fc108e0a9087276a3fe104f5ec129e56cf Gerrit-PatchSet: 1 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Tom Carchrae carch...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: use java.net.HttpCookie instead of Crockfords json.org
Matthew Dempsky has abandoned this change. Change subject: use java.net.HttpCookie instead of Crockfords json.org .. Abandoned Submitted, thanks! -- To view, visit https://gwt-review.googlesource.com/1600 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: abandon Gerrit-Change-Id: If3568a459f7a196140fa7af5b38850716a71fdd6 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Koch tho...@koch.ro Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Thomas Koch tho...@koch.ro -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Hello Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/1750 to look at the new patch set (#6). Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. avoid busy waiting in SchedulerImpl.runRepeatingTasks If all task are finished in the queue, the code was doing busy waiting. Added detection for finished task, thus returning as soon as possible. fixes issue 7307 Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb --- M user/src/com/google/gwt/core/client/impl/SchedulerImpl.java M user/test/com/google/gwt/core/client/impl/SchedulerImplTest.java 2 files changed, 122 insertions(+), 48 deletions(-) -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: Update to use ICU4J 50.1.1
Andrew Bachmann has posted comments on this change. Change subject: Update to use ICU4J 50.1.1 .. Patch Set 2: Code-Review+1 To clarify, my pending patch is to update the gwt tools for the current CLDR (22.1). Public review forthcoming. -- To view, visit https://gwt-review.googlesource.com/1700 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75c9e0e07c4d29a75573701a676a19d6e83b91d9 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Andrew Bachmann andrewbachm...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: Update to use ICU4J 50.1.1
Andrew Bachmann has posted comments on this change. Change subject: Update to use ICU4J 50.1.1 .. Patch Set 2: (1 comment) File eclipse/tools/cldr-import/.classpath Line 13: classpathentry kind=var path=GWT_TOOLS/lib/icu4j/50.1.1/utilities.jar / John do you think that it is still required to have icu4j.jar and utilities.jar in the cldr/22.1 subdirectory or is it sufficient to keep it in icu4j only? -- To view, visit https://gwt-review.googlesource.com/1700 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I75c9e0e07c4d29a75573701a676a19d6e83b91d9 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: John A. Tamplin j...@jaet.org Gerrit-Reviewer: Andrew Bachmann andrewbachm...@google.com Gerrit-Reviewer: Brian Slesinsky skybr...@google.com Gerrit-Reviewer: John A. Tamplin j...@jaet.org Gerrit-HasComments: Yes -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Goktug Gokdogan has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 6: Hi Daniel. Did you see my previous comment? -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Daniel Kurka has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 6: I actually replied on it: The repeating command needs to be run a second time to be in the task queue. Without it we would not be able to test the behavior of runRepeatingTasks -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Daniel Kurka has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 6: my bad: I did not publish it, I am new to gerrit, sorry! -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 6 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Goktug Gokdogan has posted comments on this change.
Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks
..
Patch Set 6:
Now I see what you are doing. Just a nit but perhaps you can add a comment
to document that?
// Command needs to run for the second time to be executed in
runScheduledTasks
if (command.commandRanSecondTime) {
Alternatively, you can call runScheduledTasks directly with a one task and
if returns that means your test is passing.
--
To view, visit https://gwt-review.googlesource.com/1750
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com
Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com
Gerrit-Reviewer: Goktug Gokdogan gok...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Hello Thomas Broyer, I'd like you to reexamine a change. Please visit https://gwt-review.googlesource.com/1750 to look at the new patch set (#7). Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. avoid busy waiting in SchedulerImpl.runRepeatingTasks If all task are finished in the queue, the code was doing busy waiting. Added detection for finished task, thus returning as soon as possible. fixes issue 7307 Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb --- M user/src/com/google/gwt/core/client/impl/SchedulerImpl.java M user/test/com/google/gwt/core/client/impl/SchedulerImplTest.java 2 files changed, 123 insertions(+), 48 deletions(-) -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Daniel Kurka has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 7: Added the comment. I prefer not to call a private function here and test this via a public API, even though this yields a test that is less readable. -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: avoid busy waiting in SchedulerImpl.runRepeatingTasks
Goktug Gokdogan has posted comments on this change. Change subject: avoid busy waiting in SchedulerImpl.runRepeatingTasks .. Patch Set 7: Code-Review+1 That is fair. Thanks for fixing it. -- To view, visit https://gwt-review.googlesource.com/1750 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: I288975242600fe5fc13b9bcb356f9807894bb2cb Gerrit-PatchSet: 7 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Goktug Gokdogan gok...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] Re: Developing a new remote RunStyle for PhantomJS
Am 15.01.2013 11:22, schrieb Thomas Broyer: On Tuesday, January 15, 2013 10:27:57 AM UTC+1, Maik Riechert wrote: I see, it's probably perfectly applicable to Travis CI (I would just start the phantomjs webdriver server before executing tests) but what about: http://code.google.com/p/google-web-toolkit/issues/detail?id=7768 http://code.google.com/p/google-web-toolkit/issues/detail?id=7768 Ah, good catch! Patches welcome! ;-) Alright, I did a quick prototype based on the selenium run style and guess what, it works! https://github.com/neothemachine/gwt-webdriver-junit-runstyle It's a shame though that the gwt-maven-plugin doesn't support arbitrary run styles. I guess I'll open an issue on GitHub for that. -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: use java.net.HttpCookie instead of Crockfords json.org
Daniel Kurka has posted comments on this change. Change subject: use java.net.HttpCookie instead of Crockfords json.org .. Patch Set 2: no worries this is committed and will be included in GWT 2.5.1 (see Matthews comment) -- To view, visit https://gwt-review.googlesource.com/1600 To unsubscribe, visit https://gwt-review.googlesource.com/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3568a459f7a196140fa7af5b38850716a71fdd6 Gerrit-PatchSet: 2 Gerrit-Project: gwt Gerrit-Branch: master Gerrit-Owner: Thomas Koch tho...@koch.ro Gerrit-Reviewer: Daniel Kurka kurka.dan...@gmail.com Gerrit-Reviewer: Matthew Dempsky mdemp...@google.com Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com Gerrit-Reviewer: Thomas Koch tho...@koch.ro Gerrit-HasComments: No -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Re: Fix issue 6959. (issue1587803)
Seems fine. (I'll take care of these nits.)
http://gwt-code-reviews.appspot.com/1587803/diff/10006/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java
File user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java
(right):
http://gwt-code-reviews.appspot.com/1587803/diff/10006/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode71
user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:71:
public Q getValue() {
@Override?
http://gwt-code-reviews.appspot.com/1587803/diff/10006/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode75
user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:75:
public void setIndex(int index) {
Doesn't need to be public since we only call it from
HasDataEditorSource.setIndex.
http://gwt-code-reviews.appspot.com/1587803/diff/10006/user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java#newcode81
user/src/com/google/gwt/editor/client/adapters/HasDataEditor.java:81:
public void setValue(Q value) {
@Override?
http://gwt-code-reviews.appspot.com/1587803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Re: [gwt-contrib] GWT 2.5.1 release - Call for help
Hi Patrick, thanks for putting in the work, it's really appreciated! I have added the reviews to the list for GWT 2.5.1, there is no guarantee that everything will land in GWT 2.5.1, but at least someone will take a look. Do you have an open issue for http://gwt-code-reviews.appspot.com/1736804/ ? Thanks again, Daniel Am 13.01.2013 um 19:24 schrieb Patrick Tucker tucker...@gmail.com: http://gwt-code-reviews.appspot.com/1736804/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
[gwt-contrib] Change in gwt[master]: Emit a warning if (some) incompatible options are used.
Brian Slesinsky has posted comments on this change.
Change subject: Emit a warning if (some) incompatible options are used.
..
Patch Set 1:
(1 comment)
File dev/core/src/com/google/gwt/dev/jjs/JavaToJavaScriptCompiler.java
Line 490: if (options.isClosureCompilerEnabled()
options.isCompilerMetricsEnabled() {
This is okay, but it seems like it would be clearer like this?
if (options.isClosureCompilerEnabled()) {
... log warnings based on options ...
} else {
... run reports based on options ...
}
--
To view, visit https://gwt-review.googlesource.com/1760
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e73b0107c23e54b69b9e648bff05d2135ff0b77
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman rlu...@google.com
Gerrit-Reviewer: Brian Slesinsky skybr...@google.com
Gerrit-Reviewer: Thomas Broyer t.bro...@gmail.com
Gerrit-HasComments: Yes
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
