[jira] [Comment Edited] (HBASE-23968) Periodically check whether a system stop is requested in compaction by time.
[ https://issues.apache.org/jira/browse/HBASE-23968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103121#comment-17103121 ] Minwoo Kang edited comment on HBASE-23968 at 5/9/20, 6:10 AM: -- I recognized what the problem mentioned is. I have a question. If so, should I reopen the issue and patch it? [~stack] was (Author: minwoo.kang): I know the problem. I have a question. If so, should I reopen the issue and patch it? [~stack] > Periodically check whether a system stop is requested in compaction by time. > > > Key: HBASE-23968 > URL: https://issues.apache.org/jira/browse/HBASE-23968 > Project: HBase > Issue Type: Improvement > Components: Compaction >Reporter: Minwoo Kang >Assignee: Minwoo Kang >Priority: Minor > Fix For: 3.0.0-alpha-1 > > > The compaction check that the system is stopped when it reaches > hbase.hstore.close.check.interval size. > If the size is not reached, the compaction does not stop even though the > system is stopped. > If compaction is not terminated, the region is not closed. > As a result, region remains pending-close. > > Thread A (regionserver/longCompactions): > State: RUNNABLE > Stack: > org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:319) > org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:111) > org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:119) > org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1232) > org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:1896) > org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.doCompaction(CompactSplitThread.java:525) > org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:562) > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > java.lang.Thread.run(Thread.java:748) > Thread B (RS_CLOSE_REGION): > State: WAITING > Waiting on org.apache.hadoop.hbase.regionserver.HRegion$WriteState > Stack: > java.lang.Object.wait(Native Method) > java.lang.Object.wait(Object.java:502) > org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1567) > org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1417) > org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1380) > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:138) > org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:129) > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > java.lang.Thread.run(Thread.java:748) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-23968) Periodically check whether a system stop is requested in compaction by time.
[ https://issues.apache.org/jira/browse/HBASE-23968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103121#comment-17103121 ] Minwoo Kang commented on HBASE-23968: - I know the problem. I have a question. If so, should I reopen the issue and patch it? [~stack] > Periodically check whether a system stop is requested in compaction by time. > > > Key: HBASE-23968 > URL: https://issues.apache.org/jira/browse/HBASE-23968 > Project: HBase > Issue Type: Improvement > Components: Compaction >Reporter: Minwoo Kang >Assignee: Minwoo Kang >Priority: Minor > Fix For: 3.0.0-alpha-1 > > > The compaction check that the system is stopped when it reaches > hbase.hstore.close.check.interval size. > If the size is not reached, the compaction does not stop even though the > system is stopped. > If compaction is not terminated, the region is not closed. > As a result, region remains pending-close. > > Thread A (regionserver/longCompactions): > State: RUNNABLE > Stack: > org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:319) > org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:111) > org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:119) > org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1232) > org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:1896) > org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.doCompaction(CompactSplitThread.java:525) > org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:562) > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > java.lang.Thread.run(Thread.java:748) > Thread B (RS_CLOSE_REGION): > State: WAITING > Waiting on org.apache.hadoop.hbase.regionserver.HRegion$WriteState > Stack: > java.lang.Object.wait(Native Method) > java.lang.Object.wait(Object.java:502) > org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1567) > org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1417) > org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1380) > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:138) > org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:129) > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > java.lang.Thread.run(Thread.java:748) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24284) [h3/jdk11] REST server won't start
[
https://issues.apache.org/jira/browse/HBASE-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103113#comment-17103113
]
Hudson commented on HBASE-24284:
Results for branch branch-2
[build #2651 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2651/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2651/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2651/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2651/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- Something went wrong running this stage, please [check relevant console
output|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2651//console].
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [h3/jdk11] REST server won't start
> --
>
> Key: HBASE-24284
> URL: https://issues.apache.org/jira/browse/HBASE-24284
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> {code}
> 2020-04-29 07:06:31,610 INFO [main] server.AbstractConnector: Started
> ServerConnector@1bdf8190{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}
> Exception in thread "main" java.lang.NoSuchMethodError: 'java.util.Map
> javax.ws.rs.core.Application.getProperties()'
> at
> org.glassfish.jersey.server.ApplicationHandler.(ApplicationHandler.java:331)
> at
> org.glassfish.jersey.servlet.WebComponent.(WebComponent.java:392)
> at
> org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:177)
> {code}
> Seems fine for hadoop2/jdk8.
> I get the above when I do: mvn install -Dhadoop.profile=3.0 building w/ jdk11.
> Fix coming...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24152) Add ServerSsdLocalityCostFunction to StochasticLoadBalancer
[
https://issues.apache.org/jira/browse/HBASE-24152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103071#comment-17103071
]
Zheng Wang commented on HBASE-24152:
{quote}Was reviewing the PR but figured don't have enough understanding of what
is going on so let me ask here.
I don't follow why the PR is special casing SSD weight. Why it it not just
factored into the host general weight? Balancer works at the RS level, not at
type of storage? A local replica should be favored whether on ssd or not?
Help me out [~filtertip] Thank you.
{quote}
[~stack]
Consider this case when setting ONE_SSD as STORAGE_POLICY.
The region-1 opened by host-1, it includes one hdfs block which has three
replicas stored as below:
replica-1 on host-1(hdd)
replica-2 on host-2(hdd)
replica-3 on host-3(ssd)
Then the reader of hfile will read from hdd, because host-1 is local and has
high priority.
If we move the region-1 to host-3, the reader will read from ssd, and this cost
function could increase the possibility of the movement when making plans.
> Add ServerSsdLocalityCostFunction to StochasticLoadBalancer
> ---
>
> Key: HBASE-24152
> URL: https://issues.apache.org/jira/browse/HBASE-24152
> Project: HBase
> Issue Type: New Feature
> Components: Balancer
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Major
>
> When use ONE_SSD storagy policy, or ALL_SSD but has not enough SSD, there
> will be some hdfs blocks on DISK and others on SSD,so it is reasonable to
> consider the locality of ssd for StochasticLoadBalancer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24284) [h3/jdk11] REST server won't start
[
https://issues.apache.org/jira/browse/HBASE-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103063#comment-17103063
]
Hudson commented on HBASE-24284:
Results for branch branch-2.3
[build #73 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/73/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/73/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/73/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/73/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/73/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [h3/jdk11] REST server won't start
> --
>
> Key: HBASE-24284
> URL: https://issues.apache.org/jira/browse/HBASE-24284
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> {code}
> 2020-04-29 07:06:31,610 INFO [main] server.AbstractConnector: Started
> ServerConnector@1bdf8190{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}
> Exception in thread "main" java.lang.NoSuchMethodError: 'java.util.Map
> javax.ws.rs.core.Application.getProperties()'
> at
> org.glassfish.jersey.server.ApplicationHandler.(ApplicationHandler.java:331)
> at
> org.glassfish.jersey.servlet.WebComponent.(WebComponent.java:392)
> at
> org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:177)
> {code}
> Seems fine for hadoop2/jdk8.
> I get the above when I do: mvn install -Dhadoop.profile=3.0 building w/ jdk11.
> Fix coming...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24310) Use Slf4jRequestLog for hbase-http
[
https://issues.apache.org/jira/browse/HBASE-24310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103062#comment-17103062
]
Hudson commented on HBASE-24310:
Results for branch branch-2.3
[build #73 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/73/]:
(/) *{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/73/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/73/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/73/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/73/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Use Slf4jRequestLog for hbase-http
> --
>
> Key: HBASE-24310
> URL: https://issues.apache.org/jira/browse/HBASE-24310
> Project: HBase
> Issue Type: Sub-task
> Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> To remove the direct dependency on log4j in hbase-http server.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache9 commented on a change in pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly
Apache9 commented on a change in pull request #1640:
URL: https://github.com/apache/hbase/pull/1640#discussion_r422441237
##
File path: hbase-shaded/pom.xml
##
@@ -51,15 +51,14 @@
org.apache.hbase
hbase-resource-bundle
- ${project.version}
true
-
+
Review comment:
After trying HBASE-19577, some hadoop classes do have dependencies on
log4j directly, for example the FSNamesystem class. But usually we do not need
to touch this class unless in UT. Anyway, since we are still on log4j after
this patch so I think it is fine for now. When switching to log4j2, we need to
more testing to find out the direct dependencies on log4j from hadoop and try
to fix them.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] Apache9 commented on a change in pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly
Apache9 commented on a change in pull request #1640: URL: https://github.com/apache/hbase/pull/1640#discussion_r422440815 ## File path: hbase-assembly/pom.xml ## @@ -318,5 +318,18 @@ jaxws-ri pom + Review comment: We could do this? I'v never tried this before. How does the start-hbase.sh script find all the dependencies? We do not have a lib directory in the checkout directory... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24117) If move target RS crashes, move fails if concurrent master crash
[ https://issues.apache.org/jira/browse/HBASE-24117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103053#comment-17103053 ] Duo Zhang commented on HBASE-24117: --- Thanks sir. Let me take a look. > If move target RS crashes, move fails if concurrent master crash > > > Key: HBASE-24117 > URL: https://issues.apache.org/jira/browse/HBASE-24117 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Attachments: > org.apache.hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash-output.txt > > > I saw this on TestCloseRegionWithRSCrash. The Region > 788a516d1f86af98e0a16bcc1afe4fa1 was being moved to RS > example.com,62652,1586032098445 just after it was killed. The Move Close > fails because the RS has no node in the Master. The Move then tries to > 'confirm' the close but it fails because no remote RS. We are then to wait in > this state until operator or some other procedure intervenes to 'fix' the > state. Normally a ServerCrashProcedure would do the job but in this test the > Master is restarted after the RS is killed, a condition we do not accommodate. > Let me attach the test log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24117) If move target RS crashes, move fails if concurrent master crash
[
https://issues.apache.org/jira/browse/HBASE-24117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103026#comment-17103026
]
Michael Stack commented on HBASE-24117:
---
Uploaded log with described failure. I got it by making below change and then
running test in a loop. Took a long time to reproduce so long that I'm
unscheduling this JIRA.
{code}
diff --git
a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java
b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java
index 4761991e75..da4f36ea20 100644
---
a/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java
+++
b/hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestCloseRegionWhileRSCrash.java
@@ -163,7 +163,8 @@ public class TestCloseRegionWhileRSCrash {
UTIL.shutdownMiniCluster();
}
- @org.junit.Ignore @Test // Until root-cause of flakeyness, HBASE-24117, is
addressed.
+ @Test
+ // @org.junit.Ignore @Test // Until root-cause of flakeyness, HBASE-24117,
is addressed.
public void testRetryBackoff() throws IOException, InterruptedException {
HRegionServer srcRs = UTIL.getRSForFirstRegionInTable(TABLE_NAME);
RegionInfo region = srcRs.getRegions(TABLE_NAME).get(0).getRegionInfo();
{code}
> If move target RS crashes, move fails if concurrent master crash
>
>
> Key: HBASE-24117
> URL: https://issues.apache.org/jira/browse/HBASE-24117
> Project: HBase
> Issue Type: Bug
> Components: proc-v2
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
> Attachments:
> org.apache.hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash-output.txt
>
>
> I saw this on TestCloseRegionWithRSCrash. The Region
> 788a516d1f86af98e0a16bcc1afe4fa1 was being moved to RS
> example.com,62652,1586032098445 just after it was killed. The Move Close
> fails because the RS has no node in the Master. The Move then tries to
> 'confirm' the close but it fails because no remote RS. We are then to wait in
> this state until operator or some other procedure intervenes to 'fix' the
> state. Normally a ServerCrashProcedure would do the job but in this test the
> Master is restarted after the RS is killed, a condition we do not accommodate.
> Let me attach the test log.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24117) If move target RS crashes, move fails if concurrent master crash
[ https://issues.apache.org/jira/browse/HBASE-24117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-24117: -- Fix Version/s: (was: 2.3.0) (was: 3.0.0-alpha-1) > If move target RS crashes, move fails if concurrent master crash > > > Key: HBASE-24117 > URL: https://issues.apache.org/jira/browse/HBASE-24117 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Attachments: > org.apache.hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash-output.txt > > > I saw this on TestCloseRegionWithRSCrash. The Region > 788a516d1f86af98e0a16bcc1afe4fa1 was being moved to RS > example.com,62652,1586032098445 just after it was killed. The Move Close > fails because the RS has no node in the Master. The Move then tries to > 'confirm' the close but it fails because no remote RS. We are then to wait in > this state until operator or some other procedure intervenes to 'fix' the > state. Normally a ServerCrashProcedure would do the job but in this test the > Master is restarted after the RS is killed, a condition we do not accommodate. > Let me attach the test log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24117) If move target RS crashes, move fails if concurrent master crash
[ https://issues.apache.org/jira/browse/HBASE-24117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-24117: -- Attachment: org.apache.hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash-output.txt > If move target RS crashes, move fails if concurrent master crash > > > Key: HBASE-24117 > URL: https://issues.apache.org/jira/browse/HBASE-24117 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > Attachments: > org.apache.hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash-output.txt > > > I saw this on TestCloseRegionWithRSCrash. The Region > 788a516d1f86af98e0a16bcc1afe4fa1 was being moved to RS > example.com,62652,1586032098445 just after it was killed. The Move Close > fails because the RS has no node in the Master. The Move then tries to > 'confirm' the close but it fails because no remote RS. We are then to wait in > this state until operator or some other procedure intervenes to 'fix' the > state. Normally a ServerCrashProcedure would do the job but in this test the > Master is restarted after the RS is killed, a condition we do not accommodate. > Let me attach the test log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24117) If move target RS crashes, move fails if concurrent master crash
[ https://issues.apache.org/jira/browse/HBASE-24117?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack updated HBASE-24117: -- Attachment: (was: org.apache.hadoop.hbase.master.TestMasterShutdown-output.txt) > If move target RS crashes, move fails if concurrent master crash > > > Key: HBASE-24117 > URL: https://issues.apache.org/jira/browse/HBASE-24117 > Project: HBase > Issue Type: Bug > Components: proc-v2 >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > Attachments: > org.apache.hadoop.hbase.master.assignment.TestCloseRegionWhileRSCrash-output.txt > > > I saw this on TestCloseRegionWithRSCrash. The Region > 788a516d1f86af98e0a16bcc1afe4fa1 was being moved to RS > example.com,62652,1586032098445 just after it was killed. The Move Close > fails because the RS has no node in the Master. The Move then tries to > 'confirm' the close but it fails because no remote RS. We are then to wait in > this state until operator or some other procedure intervenes to 'fix' the > state. Normally a ServerCrashProcedure would do the job but in this test the > Master is restarted after the RS is killed, a condition we do not accommodate. > Let me attach the test log. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] bharathv commented on a change in pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted
bharathv commented on a change in pull request #1684:
URL: https://github.com/apache/hbase/pull/1684#discussion_r422412820
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java
##
@@ -163,7 +164,16 @@ public void
testMasterShutdownBeforeStartingAnyRegionServer() throws Exception {
assertNotEquals("Timeout waiting for server manager to become
available.",
-1, Waiter.waitFor(htu.getConfiguration(), timeout,
() -> masterThread.getMaster().getServerManager() != null));
- htu.getConnection().getAdmin().shutdown();
+ try {
+htu.getConnection().getAdmin().shutdown();
Review comment:
Ya, doesn't look like it. This is a known problem I think (Root cause is
a flaky Zk connection. I can repro it locally once every ~100 runs). The
problem here seems to me that shutdown is running inline with the rpc call [1].
Nick actually made the shutdown call async in HBASE-23808 but Stack undid that
in HBASE-24052 [2]. Perhaps the fix is to actually make it async in test until
we fix HBASE-24070? Thoughts? (@saintstack curious what the rationale was in
HBASE-24052).
[1] https://issues.apache.org/jira/browse/HBASE-24070
[2]
https://issues.apache.org/jira/browse/HBASE-24052?focusedCommentId=17068822&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17068822
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (HBASE-24331) [Flakey Test] TestJMXListener rmi port clash
[ https://issues.apache.org/jira/browse/HBASE-24331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Stack resolved HBASE-24331. --- Fix Version/s: 2.3.0 3.0.0-alpha-1 Assignee: Michael Stack Resolution: Fixed Merged to branch-2.3+ > [Flakey Test] TestJMXListener rmi port clash > > > Key: HBASE-24331 > URL: https://issues.apache.org/jira/browse/HBASE-24331 > Project: HBase > Issue Type: Sub-task > Components: flakies, test >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > > The TestJMXListener can fail because the random port it wants to put the jmx > listener on is occupied when it goes to run. Handle this case in test startup. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] saintstack commented on a change in pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly
saintstack commented on a change in pull request #1640: URL: https://github.com/apache/hbase/pull/1640#discussion_r422369449 ## File path: hbase-assembly/pom.xml ## @@ -318,5 +318,18 @@ jaxws-ri pom + Review comment: I'm asking about running an hbase instance from built checkout, not from an assembly. Currently it works. It looks like it will no longer work if this patch goes in? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24284) [h3/jdk11] REST server won't start
[
https://issues.apache.org/jira/browse/HBASE-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102909#comment-17102909
]
Michael Stack commented on HBASE-24284:
---
Confirmed the REST server still starts.
> [h3/jdk11] REST server won't start
> --
>
> Key: HBASE-24284
> URL: https://issues.apache.org/jira/browse/HBASE-24284
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> {code}
> 2020-04-29 07:06:31,610 INFO [main] server.AbstractConnector: Started
> ServerConnector@1bdf8190{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}
> Exception in thread "main" java.lang.NoSuchMethodError: 'java.util.Map
> javax.ws.rs.core.Application.getProperties()'
> at
> org.glassfish.jersey.server.ApplicationHandler.(ApplicationHandler.java:331)
> at
> org.glassfish.jersey.servlet.WebComponent.(WebComponent.java:392)
> at
> org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:177)
> {code}
> Seems fine for hadoop2/jdk8.
> I get the above when I do: mvn install -Dhadoop.profile=3.0 building w/ jdk11.
> Fix coming...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted
virajjasani commented on a change in pull request #1684:
URL: https://github.com/apache/hbase/pull/1684#discussion_r422339899
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java
##
@@ -163,7 +164,16 @@ public void
testMasterShutdownBeforeStartingAnyRegionServer() throws Exception {
assertNotEquals("Timeout waiting for server manager to become
available.",
-1, Waiter.waitFor(htu.getConfiguration(), timeout,
() -> masterThread.getMaster().getServerManager() != null));
- htu.getConnection().getAdmin().shutdown();
+ try {
+htu.getConnection().getAdmin().shutdown();
Review comment:
Btw the root cause that I have seen for the above Exception:
```
2020-05-09 00:58:39,957 ERROR
[RpcServer.priority.RWQ.Fifo.read.handler=1,queue=1,port=53033]
master.HMaster(2878): ZooKeeper exception trying to set cluster as down in ZK
org.apache.zookeeper.KeeperException$SystemErrorException: KeeperErrorCode =
SystemError
at
org.apache.hadoop.hbase.zookeeper.ZKWatcher.interruptedException(ZKWatcher.java:626)
at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:1285)
at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:1269)
at
org.apache.hadoop.hbase.zookeeper.ClusterStatusTracker.setClusterDown(ClusterStatusTracker.java:84)
at org.apache.hadoop.hbase.master.HMaster.shutdown(HMaster.java:2876)
at
org.apache.hadoop.hbase.master.MasterRpcServices.shutdown(MasterRpcServices.java:1630)
at
org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:395)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)
Caused by: java.lang.InterruptedException
at java.lang.Object.wait(Native Method)
at java.lang.Object.wait(Object.java:502)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1529)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1512)
at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:1791)
at
org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:171)
at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:1280)
... 9 more
2020-05-09 00:58:39,957 DEBUG [Time-limited test-EventThread]
zookeeper.ZKWatcher(490): master:53033-0x1000d0785dd,
quorum=127.0.0.1:60460, baseZNode=/hbase Received ZooKeeper Event,
type=NodeDeleted, state=SyncConnected, path=/hbase/master
2020-05-09 00:58:39,957 INFO [M:0;172.20.10.2:53033]
regionserver.HRegionServer(1119): stopping server
172.20.10.2,53033,1588966118448; all regions closed.
2020-05-09 00:58:39,958 INFO [M:0;172.20.10.2:53033]
hbase.ChoreService(329): Chore service for: master/172.20.10.2:0 had [] on
shutdown
2020-05-09 00:58:39,958 DEBUG [M:0;172.20.10.2:53033] master.HMaster(1516):
Stopping service threads
```
Does not look like issue with moving code to registry.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-24284) [h3/jdk11] REST server won't start
[
https://issues.apache.org/jira/browse/HBASE-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102902#comment-17102902
]
Michael Stack commented on HBASE-24284:
---
Pushed this:
{code}
commit f7deadc9af9a7a402f6e362fb8ce88bcfba2e459 (HEAD -> 2, origin/branch-2,
2.clean)
Author: stack
Date: Fri May 8 13:00:07 2020 -0700
HBASE-24284 [h3/jdk11] REST server won't start Exclude transitive includes
of jax-rs 1.x and then explicitly include jax-rs 2.x glassfish impl for REST
context when hadoop3. (#1625)
Addendum to fix failing MR tests; e.g. TestExportSnapshot.
diff --git a/hbase-mapreduce/pom.xml b/hbase-mapreduce/pom.xml
index 781748d7de..ff52764db8 100644
--- a/hbase-mapreduce/pom.xml
+++ b/hbase-mapreduce/pom.xml
@@ -418,10 +418,6 @@
hadoop-minicluster
test
-
- javax.xml.bind
- jaxb-api
-
javax.ws.rs
jsr311-api
{code}
> [h3/jdk11] REST server won't start
> --
>
> Key: HBASE-24284
> URL: https://issues.apache.org/jira/browse/HBASE-24284
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> {code}
> 2020-04-29 07:06:31,610 INFO [main] server.AbstractConnector: Started
> ServerConnector@1bdf8190{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}
> Exception in thread "main" java.lang.NoSuchMethodError: 'java.util.Map
> javax.ws.rs.core.Application.getProperties()'
> at
> org.glassfish.jersey.server.ApplicationHandler.(ApplicationHandler.java:331)
> at
> org.glassfish.jersey.servlet.WebComponent.(WebComponent.java:392)
> at
> org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:177)
> {code}
> Seems fine for hadoop2/jdk8.
> I get the above when I do: mvn install -Dhadoop.profile=3.0 building w/ jdk11.
> Fix coming...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (HBASE-24284) [h3/jdk11] REST server won't start
[
https://issues.apache.org/jira/browse/HBASE-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack resolved HBASE-24284.
---
Resolution: Fixed
Re-resolved after pushing above addendum.
> [h3/jdk11] REST server won't start
> --
>
> Key: HBASE-24284
> URL: https://issues.apache.org/jira/browse/HBASE-24284
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> {code}
> 2020-04-29 07:06:31,610 INFO [main] server.AbstractConnector: Started
> ServerConnector@1bdf8190{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}
> Exception in thread "main" java.lang.NoSuchMethodError: 'java.util.Map
> javax.ws.rs.core.Application.getProperties()'
> at
> org.glassfish.jersey.server.ApplicationHandler.(ApplicationHandler.java:331)
> at
> org.glassfish.jersey.servlet.WebComponent.(WebComponent.java:392)
> at
> org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:177)
> {code}
> Seems fine for hadoop2/jdk8.
> I get the above when I do: mvn install -Dhadoop.profile=3.0 building w/ jdk11.
> Fix coming...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (HBASE-24284) [h3/jdk11] REST server won't start
[
https://issues.apache.org/jira/browse/HBASE-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Stack reopened HBASE-24284:
---
Reopen to push addendum which readds jaxb to hadoop3 profile only:
{code}
diff --git a/hbase-mapreduce/pom.xml b/hbase-mapreduce/pom.xml
index 781748d7de..ff52764db8 100644
--- a/hbase-mapreduce/pom.xml
+++ b/hbase-mapreduce/pom.xml
@@ -418,10 +418,6 @@
hadoop-minicluster
test
-
- javax.xml.bind
- jaxb-api
-
javax.ws.rs
jsr311-api
kalashnikov:target stack$
{code}
> [h3/jdk11] REST server won't start
> --
>
> Key: HBASE-24284
> URL: https://issues.apache.org/jira/browse/HBASE-24284
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> {code}
> 2020-04-29 07:06:31,610 INFO [main] server.AbstractConnector: Started
> ServerConnector@1bdf8190{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}
> Exception in thread "main" java.lang.NoSuchMethodError: 'java.util.Map
> javax.ws.rs.core.Application.getProperties()'
> at
> org.glassfish.jersey.server.ApplicationHandler.(ApplicationHandler.java:331)
> at
> org.glassfish.jersey.servlet.WebComponent.(WebComponent.java:392)
> at
> org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:177)
> {code}
> Seems fine for hadoop2/jdk8.
> I get the above when I do: mvn install -Dhadoop.profile=3.0 building w/ jdk11.
> Fix coming...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24284) [h3/jdk11] REST server won't start
[
https://issues.apache.org/jira/browse/HBASE-24284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102885#comment-17102885
]
Michael Stack commented on HBASE-24284:
---
This broke some of the MR tests. Stuff won't start. Saw it in nightly. Took
while to finger this issue because we seemed to have passing nightlies that
included this change but passed anyway. Researching locally, looks like this
reliably breaks TestExportSnapshot at least (and all of its children). Failure
is us not clearing out of test startup dumping threads. If you dig, you'll find
lots of:
{code}
org.apache.hadoop.yarn.webapp.WebAppException: java.lang.NullPointerException:
guiceFilter
at org.apache.hadoop.yarn.webapp.WebApp.stop(WebApp.java:102)
at
org.apache.hadoop.mapreduce.v2.hs.HistoryClientService.serviceStop(HistoryClientService.java:179)
at org.apache.hadoop.service.AbstractService.stop(AbstractService.java:220)
at
org.apache.hadoop.service.ServiceOperations.stop(ServiceOperations.java:54)
at
org.apache.hadoop.service.ServiceOperations.stopQuietly(ServiceOperations.java:102)
at org.apache.hadoop.service.CompositeService.stop(CompositeService.java:158)
at
org.apache.hadoop.service.CompositeService.serviceStop(CompositeService.java:132)
{code}
but root is ...
{code}
2020-05-08 12:55:32,622 ERROR [Thread-231] server.NIOServerCnxnFactory$1(92):
Thread Thread[Thread-231,5,FailOnTimeoutGroup] died
java.lang.NoClassDefFoundError: javax/xml/bind/JAXBContext
at java.base/java.lang.Class.getDeclaredConstructors0(Native Method)
at java.base/java.lang.Class.privateGetDeclaredConstructors(Class.java:3137)
at java.base/java.lang.Class.getDeclaredConstructors(Class.java:2357)
{code}
> [h3/jdk11] REST server won't start
> --
>
> Key: HBASE-24284
> URL: https://issues.apache.org/jira/browse/HBASE-24284
> Project: HBase
> Issue Type: Bug
> Components: REST
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> {code}
> 2020-04-29 07:06:31,610 INFO [main] server.AbstractConnector: Started
> ServerConnector@1bdf8190{HTTP/1.1,[http/1.1]}{0.0.0.0:8080}
> Exception in thread "main" java.lang.NoSuchMethodError: 'java.util.Map
> javax.ws.rs.core.Application.getProperties()'
> at
> org.glassfish.jersey.server.ApplicationHandler.(ApplicationHandler.java:331)
> at
> org.glassfish.jersey.servlet.WebComponent.(WebComponent.java:392)
> at
> org.glassfish.jersey.servlet.ServletContainer.init(ServletContainer.java:177)
> {code}
> Seems fine for hadoop2/jdk8.
> I get the above when I do: mvn install -Dhadoop.profile=3.0 building w/ jdk11.
> Fix coming...
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted
virajjasani commented on a change in pull request #1684:
URL: https://github.com/apache/hbase/pull/1684#discussion_r422339899
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java
##
@@ -163,7 +164,16 @@ public void
testMasterShutdownBeforeStartingAnyRegionServer() throws Exception {
assertNotEquals("Timeout waiting for server manager to become
available.",
-1, Waiter.waitFor(htu.getConfiguration(), timeout,
() -> masterThread.getMaster().getServerManager() != null));
- htu.getConnection().getAdmin().shutdown();
+ try {
+htu.getConnection().getAdmin().shutdown();
Review comment:
Btw the root cause that I have seen for the above Exception:
```
2020-05-09 00:58:39,957 ERROR
[RpcServer.priority.RWQ.Fifo.read.handler=1,queue=1,port=53033]
master.HMaster(2878): ZooKeeper exception trying to set cluster as down in ZK
org.apache.zookeeper.KeeperException$SystemErrorException: KeeperErrorCode =
SystemError
at
org.apache.hadoop.hbase.zookeeper.ZKWatcher.interruptedException(ZKWatcher.java:626)
at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:1285)
at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:1269)
at
org.apache.hadoop.hbase.zookeeper.ClusterStatusTracker.setClusterDown(ClusterStatusTracker.java:84)
at org.apache.hadoop.hbase.master.HMaster.shutdown(HMaster.java:2876)
at
org.apache.hadoop.hbase.master.MasterRpcServices.shutdown(MasterRpcServices.java:1630)
at
org.apache.hadoop.hbase.shaded.protobuf.generated.MasterProtos$MasterService$2.callBlockingMethod(MasterProtos.java)
at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:395)
at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:133)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:338)
at
org.apache.hadoop.hbase.ipc.RpcExecutor$Handler.run(RpcExecutor.java:318)
Caused by: java.lang.InterruptedException
at java.lang.Object.wait(Native Method)
at java.lang.Object.wait(Object.java:502)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1529)
at org.apache.zookeeper.ClientCnxn.submitRequest(ClientCnxn.java:1512)
at org.apache.zookeeper.ZooKeeper.delete(ZooKeeper.java:1791)
at
org.apache.hadoop.hbase.zookeeper.RecoverableZooKeeper.delete(RecoverableZooKeeper.java:171)
at org.apache.hadoop.hbase.zookeeper.ZKUtil.deleteNode(ZKUtil.java:1280)
... 9 more
2020-05-09 00:58:39,957 DEBUG [Time-limited test-EventThread]
zookeeper.ZKWatcher(490): master:53033-0x1000d0785dd,
quorum=127.0.0.1:60460, baseZNode=/hbase Received ZooKeeper Event,
type=NodeDeleted, state=SyncConnected, path=/hbase/master
2020-05-09 00:58:39,957 INFO [M:0;172.20.10.2:53033]
regionserver.HRegionServer(1119): stopping server
172.20.10.2,53033,1588966118448; all regions closed.
2020-05-09 00:58:39,958 INFO [M:0;172.20.10.2:53033]
hbase.ChoreService(329): Chore service for: master/172.20.10.2:0 had [] on
shutdown
2020-05-09 00:58:39,958 DEBUG [M:0;172.20.10.2:53033] master.HMaster(1516):
Stopping service threads
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-23968) Periodically check whether a system stop is requested in compaction by time.
[ https://issues.apache.org/jira/browse/HBASE-23968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102863#comment-17102863 ] Michael Stack commented on HBASE-23968: --- So, the time-based check here can get frustrated by pressure-aware throughtput controller? Are these threads not daemon? If not, that is a problem. Lets reopen or file follow-on. Thanks [~anoop.hbase] > Periodically check whether a system stop is requested in compaction by time. > > > Key: HBASE-23968 > URL: https://issues.apache.org/jira/browse/HBASE-23968 > Project: HBase > Issue Type: Improvement > Components: Compaction >Reporter: Minwoo Kang >Assignee: Minwoo Kang >Priority: Minor > Fix For: 3.0.0-alpha-1 > > > The compaction check that the system is stopped when it reaches > hbase.hstore.close.check.interval size. > If the size is not reached, the compaction does not stop even though the > system is stopped. > If compaction is not terminated, the region is not closed. > As a result, region remains pending-close. > > Thread A (regionserver/longCompactions): > State: RUNNABLE > Stack: > org.apache.hadoop.hbase.regionserver.compactions.Compactor.performCompaction(Compactor.java:319) > org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor.compact(DefaultCompactor.java:111) > org.apache.hadoop.hbase.regionserver.DefaultStoreEngine$DefaultCompactionContext.compact(DefaultStoreEngine.java:119) > org.apache.hadoop.hbase.regionserver.HStore.compact(HStore.java:1232) > org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:1896) > org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.doCompaction(CompactSplitThread.java:525) > org.apache.hadoop.hbase.regionserver.CompactSplitThread$CompactionRunner.run(CompactSplitThread.java:562) > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > java.lang.Thread.run(Thread.java:748) > Thread B (RS_CLOSE_REGION): > State: WAITING > Waiting on org.apache.hadoop.hbase.regionserver.HRegion$WriteState > Stack: > java.lang.Object.wait(Native Method) > java.lang.Object.wait(Object.java:502) > org.apache.hadoop.hbase.regionserver.HRegion.waitForFlushesAndCompactions(HRegion.java:1567) > org.apache.hadoop.hbase.regionserver.HRegion.doClose(HRegion.java:1417) > org.apache.hadoop.hbase.regionserver.HRegion.close(HRegion.java:1380) > org.apache.hadoop.hbase.regionserver.handler.CloseRegionHandler.process(CloseRegionHandler.java:138) > org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:129) > java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) > java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) > java.lang.Thread.run(Thread.java:748) > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] anoopsjohn commented on a change in pull request #1675: HBASE-24341 The region should be removed from ConfigurationManager as…
anoopsjohn commented on a change in pull request #1675:
URL: https://github.com/apache/hbase/pull/1675#discussion_r422327852
##
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/conf/ConfigurationManager.java
##
@@ -137,4 +138,14 @@ public int getNumObservers() {
return configurationObservers.size();
}
}
+
+ /**
+ * @return the observers
+ */
+ @VisibleForTesting
+ public Set getConfigurationObservers() {
Review comment:
This is used by tests only. But still how this synchronized block helps
here? We are directly returning that object which is not thread safe. IMO we
should add a method like containObserver (or a better name?) and just return a
boolean.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-24189) Regionserver recreates region folders in HDFS after replaying WAL with removed table entries
[ https://issues.apache.org/jira/browse/HBASE-24189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102856#comment-17102856 ] Anoop Sam John commented on HBASE-24189: What do you think about above approach [~timoha]? > Regionserver recreates region folders in HDFS after replaying WAL with > removed table entries > > > Key: HBASE-24189 > URL: https://issues.apache.org/jira/browse/HBASE-24189 > Project: HBase > Issue Type: Bug > Components: regionserver, wal >Affects Versions: 2.2.4 > Environment: * HDFS 3.1.3 > * HBase 2.1.4 > * OpenJDK 8 >Reporter: Andrey Elenskiy >Assignee: Anoop Sam John >Priority: Major > > Under the following scenario region directories in HDFS can be recreated with > only recovered.edits in them: > # Create table "test" > # Put into "test" > # Delete table "test" > # Create table "test" again > # Crash the regionserver to which the put has went to force the WAL replay > # Region directory in old table is recreated in new table > # hbase hbck returns inconsistency > This appears to happen due to the fact that WALs are not cleaned up once a > table is deleted and they still contain the edits from old table. I've tried > wal_roll command on the regionserver before crashing it, but it doesn't seem > to help as under some circumstances there are still WAL files around. The > only solution that works consistently is to restart regionserver before > creating the table at step 4 because that triggers log cleanup on startup: > [https://github.com/apache/hbase/blob/f3ee9b8aa37dd30d34ff54cd39fb9b4b6d22e683/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java#L508|https://github.com/apache/hbase/blob/f3ee9b8aa37dd30d34ff54cd39fb9b4b6d22e683/hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/store/wal/WALProcedureStore.java#L508)] > > Truncating a table also would be a workaround by in our case it's a no-go as > we create and delete tables in our tests which run back to back (create table > in the beginning of the test and delete in the end of the test). > A nice option in our case would be to provide hbase shell utility to force > clean up of log files manually as I realize that it's not really viable to > clean all of those up every time some table is removed. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24328) skip duplicate GCMultipleMergedRegionsProcedure while previous finished
[
https://issues.apache.org/jira/browse/HBASE-24328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102852#comment-17102852
]
Hudson commented on HBASE-24328:
Results for branch branch-2.2
[build #856 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/856/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(x) {color:red}-1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/856//General_Nightly_Build_Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/856//JDK8_Nightly_Build_Report_(Hadoop2)/]
(x) {color:red}-1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/856//JDK8_Nightly_Build_Report_(Hadoop3)/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> skip duplicate GCMultipleMergedRegionsProcedure while previous finished
> ---
>
> Key: HBASE-24328
> URL: https://issues.apache.org/jira/browse/HBASE-24328
> Project: HBase
> Issue Type: Improvement
>Reporter: niuyulin
>Assignee: niuyulin
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.2.5
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted
virajjasani commented on a change in pull request #1684:
URL: https://github.com/apache/hbase/pull/1684#discussion_r422318551
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java
##
@@ -163,7 +164,16 @@ public void
testMasterShutdownBeforeStartingAnyRegionServer() throws Exception {
assertNotEquals("Timeout waiting for server manager to become
available.",
-1, Waiter.waitFor(htu.getConfiguration(), timeout,
() -> masterThread.getMaster().getServerManager() != null));
- htu.getConnection().getAdmin().shutdown();
+ try {
+htu.getConnection().getAdmin().shutdown();
Review comment:
Test results before 5th May doesn't seem available and the flakes seem
present on the day of commit (need to check timezone diff):
https://builds.apache.org/job/HBase-Flaky-Tests/job/master/6184/
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-24152) Add ServerSsdLocalityCostFunction to StochasticLoadBalancer
[ https://issues.apache.org/jira/browse/HBASE-24152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102849#comment-17102849 ] Michael Stack commented on HBASE-24152: --- Was reviewing the PR but figured don't have enough understanding of what is going on so let me ask here. I don't follow why the PR is special casing SSD weight. Why it it not just factored into the host general weight? Balancer works at the RS level, not at type of storage? A local replica should be favored whether on ssd or not? Help me out [~filtertip] Thank you. > Add ServerSsdLocalityCostFunction to StochasticLoadBalancer > --- > > Key: HBASE-24152 > URL: https://issues.apache.org/jira/browse/HBASE-24152 > Project: HBase > Issue Type: New Feature > Components: Balancer >Reporter: Zheng Wang >Assignee: Zheng Wang >Priority: Major > > When use ONE_SSD storagy policy, or ALL_SSD but has not enough SSD, there > will be some hdfs blocks on DISK and others on SSD,so it is reasonable to > consider the locality of ssd for StochasticLoadBalancer. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] virajjasani commented on a change in pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted
virajjasani commented on a change in pull request #1684:
URL: https://github.com/apache/hbase/pull/1684#discussion_r422315817
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java
##
@@ -163,7 +164,16 @@ public void
testMasterShutdownBeforeStartingAnyRegionServer() throws Exception {
assertNotEquals("Timeout waiting for server manager to become
available.",
-1, Waiter.waitFor(htu.getConfiguration(), timeout,
() -> masterThread.getMaster().getServerManager() != null));
- htu.getConnection().getAdmin().shutdown();
+ try {
+htu.getConnection().getAdmin().shutdown();
Review comment:
This is what I thought that after waitFor(), bootstrap should be over
but in 2/50 cases, this stacktrace comes. This test is also present in flaky
report and I just realized that flaky results data accessible is 2 days after
Duo's commit. Let me check 5-10 older builds before the commit and see if this
was not flaky before.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #1482: HBASE-24152 Add ServerSsdLocalityCostFunction to StochasticLoadBalancer
saintstack commented on pull request #1482: URL: https://github.com/apache/hbase/pull/1482#issuecomment-625958604 @bsglz Any comment on the @anoopsjohn remark above? File a follow-on @anoopsjohn ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] bharathv commented on a change in pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted
bharathv commented on a change in pull request #1684:
URL: https://github.com/apache/hbase/pull/1684#discussion_r422305113
##
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterShutdown.java
##
@@ -163,7 +164,16 @@ public void
testMasterShutdownBeforeStartingAnyRegionServer() throws Exception {
assertNotEquals("Timeout waiting for server manager to become
available.",
-1, Waiter.waitFor(htu.getConfiguration(), timeout,
() -> masterThread.getMaster().getServerManager() != null));
- htu.getConnection().getAdmin().shutdown();
+ try {
+htu.getConnection().getAdmin().shutdown();
Review comment:
I have some on context on this test. Did you happen to dig into the root
cause of the ConnectionRefused stack trace that you posted (you have the full
stack trace with failed RPC name?)?
Ideally that shouldn't happen right? The waitFor() above means the bootstrap
of the master is complete and it should be able to process the shutdown()
command, in a normal case. Just want to be sure we are not masking a real bug,
especially after Duo moved all the code from RPC to registry.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (HBASE-24345) [ACL] renameRSGroup should require Admin level permission
[ https://issues.apache.org/jira/browse/HBASE-24345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102824#comment-17102824 ] Anoop Sam John commented on HBASE-24345: So in Master branch we are again doing the RS group related ACL check using the AccessController CP hooks. (Not directly on AccessChecker) cc [~pankajkumar] > [ACL] renameRSGroup should require Admin level permission > - > > Key: HBASE-24345 > URL: https://issues.apache.org/jira/browse/HBASE-24345 > Project: HBase > Issue Type: Improvement > Components: acl, rsgroup >Reporter: Reid Chan >Assignee: Reid Chan >Priority: Major > > Currently renameRSgroup can be called by anyone without permission -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1685: Backport "HBASE-24305 Prepare deprecations in ServerName (#1666)" to branch-2
Apache-HBase commented on pull request #1685: URL: https://github.com/apache/hbase/pull/1685#issuecomment-625954145 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 8s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 8s | branch-2 passed | | +1 :green_heart: | compile | 2m 28s | branch-2 passed | | +1 :green_heart: | shadedjars | 5m 2s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 43s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 51s | the patch passed | | +1 :green_heart: | compile | 2m 22s | the patch passed | | +1 :green_heart: | javac | 2m 22s | the patch passed | | +1 :green_heart: | shadedjars | 5m 0s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 1m 44s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 39s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 2m 34s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 224m 49s | hbase-server in the patch passed. | | +1 :green_heart: | unit | 4m 16s | hbase-rest in the patch passed. | | | | 264m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1685 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux d8806585490a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ec333922ce | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/testReport/ | | Max. process+thread count | 2437 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1685: Backport "HBASE-24305 Prepare deprecations in ServerName (#1666)" to branch-2
Apache-HBase commented on pull request #1685: URL: https://github.com/apache/hbase/pull/1685#issuecomment-625950856 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 38s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 55s | branch-2 passed | | +1 :green_heart: | compile | 2m 59s | branch-2 passed | | +1 :green_heart: | shadedjars | 6m 3s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 33s | hbase-client in branch-2 failed. | | -0 :warning: | javadoc | 0m 18s | hbase-common in branch-2 failed. | | -0 :warning: | javadoc | 0m 26s | hbase-rest in branch-2 failed. | | -0 :warning: | javadoc | 0m 43s | hbase-server in branch-2 failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 18s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 42s | the patch passed | | +1 :green_heart: | compile | 2m 44s | the patch passed | | +1 :green_heart: | javac | 2m 44s | the patch passed | | +1 :green_heart: | shadedjars | 6m 14s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 17s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 28s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 44s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 24s | hbase-rest in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 2m 24s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 3m 10s | hbase-client in the patch passed. | | +1 :green_heart: | unit | 211m 21s | hbase-server in the patch passed. | | -1 :x: | unit | 3m 22s | hbase-rest in the patch failed. | | | | 256m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1685 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux c46fa968bf80 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ec333922ce | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rest.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-client.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rest.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-rest.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/testReport/ | | Max. process+thread count | 2527 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automa
[jira] [Commented] (HBASE-23832) Old config hbase.hstore.compactionThreshold is ignored
[
https://issues.apache.org/jira/browse/HBASE-23832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102784#comment-17102784
]
Anoop Sam John commented on HBASE-23832:
[~busbey]
Ya there are 4 configs in the renamed list. 3 of them are completely removed
from referring in the code.
One is still used partially
{code}
public static final String HREGION_COLUMNFAMILY_FLUSH_SIZE_LOWER_BOUND =
"hbase.hregion.percolumnfamilyflush.size.lower.bound";
public static final String HREGION_COLUMNFAMILY_FLUSH_SIZE_LOWER_BOUND_MIN =
"hbase.hregion.percolumnfamilyflush.size.lower.bound.min";
...
long minimumLowerBound =
getConf().getLong(HREGION_COLUMNFAMILY_FLUSH_SIZE_LOWER_BOUND_MIN,
DEFAULT_HREGION_COLUMNFAMILY_FLUSH_SIZE_LOWER_BOUND_MIN);
if (minimumLowerBound > flushSizeLowerBound) {
flushSizeLowerBound = minimumLowerBound;
}
// use the setting in table description if any
String flushedSizeLowerBoundString =
region.getTableDescriptor().getValue(HREGION_COLUMNFAMILY_FLUSH_SIZE_LOWER_BOUND);
if (flushedSizeLowerBoundString == null) {
LOG.debug("No {} set in table {} descriptor;"
+ "using region.getMemStoreFlushHeapSize/# of families ({}) "
+ "instead."
, HREGION_COLUMNFAMILY_FLUSH_SIZE_LOWER_BOUND
, region.getTableDescriptor().getTableName()
, StringUtils.humanSize(flushSizeLowerBound)
+ ")");
} else {
try {
flushSizeLowerBound = Long.parseLong(flushedSizeLowerBoundString);
{code}
It is wrt the old config name used at the table definition level.
The compaction configs also can be tuned at table level. So whether we can
completely remove it I doubt ! Moreover we will just silently ignore it if we
remove the config from code.
> Old config hbase.hstore.compactionThreshold is ignored
> --
>
> Key: HBASE-23832
> URL: https://issues.apache.org/jira/browse/HBASE-23832
> Project: HBase
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Anoop Sam John
>Assignee: Sambit Mohapatra
>Priority: Critical
>
> In 2.x we added new name 'hbase.hstore.compaction.min' for this. Still for
> compatibility we allow the old config name and honor that in code
> {code}
> minFilesToCompact = Math.max(2, conf.getInt(HBASE_HSTORE_COMPACTION_MIN_KEY,
> /*old name*/ conf.getInt("hbase.hstore.compactionThreshold", 3)));
> {code}
> But if hbase.hstore.compactionThreshold alone is configured by user, there is
> no impact of that.
> This is because in hbase-default.xml we have the new config with a value of
> 3. So the call conf.getInt(HBASE_HSTORE_COMPACTION_MIN_KEY) always return a
> value 3 even if it is not explicitly configured by customer and instead used
> the old key.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] saintstack edited a comment on pull request #1664: HBASE-24333 Backport HBASE-24304 "Separate a hbase-asyncfs module" to…
saintstack edited a comment on pull request #1664: URL: https://github.com/apache/hbase/pull/1664#issuecomment-625883657 These PRs run with -Phadoop-3.0, not -Dhadoop.profile=3.0 (see console log). They run w/ config that is not the same as nightly (an issue Nick has been talking up). The REST issue is because of doubled up profile -- hadoop3 and hadoop2 are both active. I tried the patch locally. All REST tests pass for me w/ jdk11 using hadoop.profile=3.0. I think you should just go ahead and commit. But, just had a thought, if you commit, will we fail all PRs from here on out until we change the PR builds to do -Dhadoop.version when branch-2? PR builds should be failing now because if I build locally w/ -Phadoop-3.0 on branch-2, that fails. Maybe we don't run the REST tests usually. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-23927) hbck2 assigns command should accept a file containing a list of region names
[ https://issues.apache.org/jira/browse/HBASE-23927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Huaxiang Sun reassigned HBASE-23927: Assignee: Huaxiang Sun (was: Hua Xiang) > hbck2 assigns command should accept a file containing a list of region names > > > Key: HBASE-23927 > URL: https://issues.apache.org/jira/browse/HBASE-23927 > Project: HBase > Issue Type: Improvement > Components: hbck2, Operability, Usability >Affects Versions: hbase-operator-tools-1.0.0 >Reporter: Nick Dimiduk >Assignee: Huaxiang Sun >Priority: Major > > The interface is not very ergonomic. Currently the command accepts a list of > region names on the command line. If you have 100's of regions to assign, > this sucks. We should accept a path to a file that contains these encoded > regions, one per line. That way, this command tails nicely into an operator's > incantation using grep/sed over log files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted
Apache-HBase commented on pull request #1684: URL: https://github.com/apache/hbase/pull/1684#issuecomment-625924985 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 6s | master passed | | +1 :green_heart: | compile | 0m 57s | master passed | | +1 :green_heart: | shadedjars | 5m 40s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 44s | the patch passed | | +1 :green_heart: | compile | 0m 58s | the patch passed | | +1 :green_heart: | javac | 0m 58s | the patch passed | | +1 :green_heart: | shadedjars | 5m 42s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 190m 52s | hbase-server in the patch passed. | | | | 216m 6s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1684/1/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1684 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 6a419a89fb0b 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0cd70ed89c | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1684/1/testReport/ | | Max. process+thread count | 3242 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1684/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1682: Backport: HBASE-24273 HBCK's "Orphan Regions on FileSystem" reports regions wit…
Apache-HBase commented on pull request #1682: URL: https://github.com/apache/hbase/pull/1682#issuecomment-625923919 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 0s | Docker mode activated. | | -1 :x: | docker | 2m 47s | Docker failed to build yetus/hbase:d9b4982ad4. | | Subsystem | Report/Notes | |--:|:-| | GITHUB PR | https://github.com/apache/hbase/pull/1682 | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1682/2/console | | versions | git=2.17.1 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on pull request #1485: HBASE-23969 Meta browser should show all `info` columns
ndimiduk commented on pull request #1485: URL: https://github.com/apache/hbase/pull/1485#issuecomment-625923399 This looks good to merge. @saintstack any other concerns with the changes to `MetaTableAccessor` ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] huaxiangsun commented on pull request #1584: HBASE-24256 When fixOverlap hits the max region limit, it is possible…
huaxiangsun commented on pull request #1584: URL: https://github.com/apache/hbase/pull/1584#issuecomment-625922815 Merged the change, thanks for review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] ndimiduk commented on a change in pull request #1485: HBASE-23969 Meta browser should show all `info` columns
ndimiduk commented on a change in pull request #1485: URL: https://github.com/apache/hbase/pull/1485#discussion_r422252959 ## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/RegionReplicaInfo.java ## @@ -17,14 +17,22 @@ */ package org.apache.hadoop.hbase.master.webapp; +import static org.apache.hbase.thirdparty.org.apache.commons.collections4.ListUtils.emptyIfNull; Review comment: Due to complications around multi-jdk support, we have Yetus run in 3 different invocations. Looks like the checkstyle check gave you a +1. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1681: HBASE-23938 : System table hbase:slowlog to store complete slow/large…
Apache-HBase commented on pull request #1681: URL: https://github.com/apache/hbase/pull/1681#issuecomment-625910649 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 45s | master passed | | +1 :green_heart: | compile | 1m 17s | master passed | | +1 :green_heart: | shadedjars | 5m 36s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 55s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 45s | the patch passed | | +1 :green_heart: | compile | 1m 18s | the patch passed | | +1 :green_heart: | javac | 1m 18s | the patch passed | | +1 :green_heart: | shadedjars | 5m 41s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 54s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 28s | hbase-common in the patch passed. | | -1 :x: | unit | 196m 28s | hbase-server in the patch failed. | | | | 224m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1681 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux ec5f70fbc64a 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0cd70ed89c | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/3/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/3/testReport/ | | Max. process+thread count | 3820 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1681: HBASE-23938 : System table hbase:slowlog to store complete slow/large…
Apache-HBase commented on pull request #1681: URL: https://github.com/apache/hbase/pull/1681#issuecomment-625905169 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 22s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 23s | master passed | | +1 :green_heart: | compile | 1m 33s | master passed | | +1 :green_heart: | shadedjars | 5m 56s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-common in master failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 15s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 30s | the patch passed | | +1 :green_heart: | compile | 1m 33s | the patch passed | | +1 :green_heart: | javac | 1m 33s | the patch passed | | +1 :green_heart: | shadedjars | 5m 57s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 15s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 41s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 187m 56s | hbase-server in the patch passed. | | | | 219m 16s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1681 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 72eb268b952e 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0cd70ed89c | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/3/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/3/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/3/testReport/ | | Max. process+thread count | 3393 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted
Apache-HBase commented on pull request #1684: URL: https://github.com/apache/hbase/pull/1684#issuecomment-625891717 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 33s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 12s | master passed | | +1 :green_heart: | compile | 1m 3s | master passed | | +1 :green_heart: | shadedjars | 5m 24s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 42s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 0s | the patch passed | | +1 :green_heart: | compile | 1m 3s | the patch passed | | +1 :green_heart: | javac | 1m 3s | the patch passed | | +1 :green_heart: | shadedjars | 5m 20s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 40s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 122m 41s | hbase-server in the patch passed. | | | | 147m 45s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1684/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1684 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux cf2b58b7e138 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0cd70ed89c | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1684/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1684/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1684/1/testReport/ | | Max. process+thread count | 3837 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1684/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] saintstack commented on pull request #1664: HBASE-24333 Backport HBASE-24304 "Separate a hbase-asyncfs module" to…
saintstack commented on pull request #1664: URL: https://github.com/apache/hbase/pull/1664#issuecomment-625883657 These PRs run with -Phadoop-3.0, not -Dhadoop.profile=3.0 (see console log). They run w/ config that is not the same as nightly (an issue Nick has been talking up). The REST issue is because of doubled up profile -- hadoop3 and hadoop2 are both active. I tried the patch locally. All REST tests pass for me w/ jdk11 using hadoop.profile=3.0. I think you should just go ahead and commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1686: Backport HBASE-24345 to branch-2
Apache-HBase commented on pull request #1686: URL: https://github.com/apache/hbase/pull/1686#issuecomment-625881153 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 12s | Docker mode activated. | | -0 :warning: | yetus | 0m 9s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 34s | branch-2 passed | | +1 :green_heart: | compile | 0m 33s | branch-2 passed | | +1 :green_heart: | shadedjars | 7m 3s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 34s | hbase-rsgroup in branch-2 failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 27s | the patch passed | | +1 :green_heart: | compile | 0m 40s | the patch passed | | +1 :green_heart: | javac | 0m 40s | the patch passed | | +1 :green_heart: | shadedjars | 7m 14s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 27s | hbase-rsgroup in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 37s | hbase-rsgroup in the patch passed. | | | | 34m 44s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1686/1/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1686 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux eee522f228cc 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ec333922ce | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1686/1/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-rsgroup.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1686/1/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-rsgroup.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1686/1/testReport/ | | Max. process+thread count | 2500 (vs. ulimit of 12500) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1686/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1686: Backport HBASE-24345 to branch-2
Apache-HBase commented on pull request #1686: URL: https://github.com/apache/hbase/pull/1686#issuecomment-625878024 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 33s | branch-2 passed | | +1 :green_heart: | checkstyle | 0m 15s | branch-2 passed | | +1 :green_heart: | spotbugs | 0m 42s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 9s | the patch passed | | +1 :green_heart: | checkstyle | 0m 12s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 40s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 0m 49s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 14s | The patch does not generate ASF License warnings. | | | | 28m 21s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1686/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1686 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux e2dd3cb3524c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ec333922ce | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1686/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1686: Backport HBASE-24345 to branch-2
Apache-HBase commented on pull request #1686: URL: https://github.com/apache/hbase/pull/1686#issuecomment-625876141 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 15s | Docker mode activated. | | -0 :warning: | yetus | 0m 7s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ branch-2 Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 56s | branch-2 passed | | +1 :green_heart: | compile | 0m 23s | branch-2 passed | | +1 :green_heart: | shadedjars | 4m 55s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 21s | branch-2 passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 32s | the patch passed | | +1 :green_heart: | compile | 0m 22s | the patch passed | | +1 :green_heart: | javac | 0m 22s | the patch passed | | +1 :green_heart: | shadedjars | 4m 48s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 19s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 3m 8s | hbase-rsgroup in the patch passed. | | | | 24m 14s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1686/1/artifact/yetus-jdk8-hadoop2-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1686 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b0ce60b2363a 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ec333922ce | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1686/1/testReport/ | | Max. process+thread count | 2374 (vs. ulimit of 12500) | | modules | C: hbase-rsgroup U: hbase-rsgroup | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1686/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly
Apache-HBase commented on pull request #1640: URL: https://github.com/apache/hbase/pull/1640#issuecomment-625865261 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 44s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 38s | master passed | | +1 :green_heart: | compile | 2m 21s | master passed | | +1 :green_heart: | shadedjars | 5m 27s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 9m 24s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 31s | the patch passed | | +1 :green_heart: | compile | 2m 21s | the patch passed | | +1 :green_heart: | javac | 2m 21s | the patch passed | | +1 :green_heart: | shadedjars | 5m 41s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 8m 54s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 291m 52s | root in the patch failed. | | | | 340m 41s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1640/4/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1640 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4aa7b2f561e4 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 03e5a1402d | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1640/4/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-root.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1640/4/testReport/ | | Max. process+thread count | 5327 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-hbtop hbase-assembly hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1640/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Reidddddd opened a new pull request #1686: Backport HBASE-24345 to branch-2
Reidd opened a new pull request #1686: URL: https://github.com/apache/hbase/pull/1686 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1685: Backport "HBASE-24305 Prepare deprecations in ServerName (#1666)" to branch-2
Apache-HBase commented on pull request #1685: URL: https://github.com/apache/hbase/pull/1685#issuecomment-625857286 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 50s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ branch-2 Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 41s | branch-2 passed | | +1 :green_heart: | checkstyle | 3m 20s | branch-2 passed | | +1 :green_heart: | spotbugs | 5m 26s | branch-2 passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 7s | the patch passed | | +1 :green_heart: | checkstyle | 0m 30s | hbase-common: The patch generated 0 new + 0 unchanged - 25 fixed = 0 total (was 25) | | +1 :green_heart: | checkstyle | 0m 40s | The patch passed checkstyle in hbase-client | | +1 :green_heart: | checkstyle | 1m 31s | hbase-server: The patch generated 0 new + 275 unchanged - 3 fixed = 275 total (was 278) | | +1 :green_heart: | checkstyle | 0m 19s | The patch passed checkstyle in hbase-rest | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 15m 18s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 6m 5s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 44s | The patch does not generate ASF License warnings. | | | | 54m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1685 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux d589d7d3611e 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | branch-2 / ec333922ce | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-client hbase-server hbase-rest U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1685/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-23887) BlockCache performance improve by reduce eviction rate
[
https://issues.apache.org/jira/browse/HBASE-23887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102636#comment-17102636
]
Josh Elser commented on HBASE-23887:
Thanks Danil! Your edits here are greatly appreciated. This makes a lot more
sense.
Let me think about this one some more.
> BlockCache performance improve by reduce eviction rate
> --
>
> Key: HBASE-23887
> URL: https://issues.apache.org/jira/browse/HBASE-23887
> Project: HBase
> Issue Type: Improvement
> Components: BlockCache, Performance
>Reporter: Danil Lipovoy
>Priority: Minor
> Attachments: 1582787018434_rs_metrics.jpg,
> 1582801838065_rs_metrics_new.png, BC_LongRun.png, cmp.png,
> evict_BC100_vs_BC23.png, read_requests_100pBC_vs_23pBC.png
>
>
> Hi!
> I first time here, correct me please if something wrong.
> I want propose how to improve performance when data in HFiles much more than
> BlockChache (usual story in BigData). The idea - caching only part of DATA
> blocks. It is good becouse LruBlockCache starts to work and save huge amount
> of GC.
> Sometimes we have more data than can fit into BlockCache and it is cause a
> high rate of evictions. In this case we can skip cache a block N and insted
> cache the N+1th block. Anyway we would evict N block quite soon and that why
> that skipping good for performance.
> Example:
> Imagine we have little cache, just can fit only 1 block and we are trying to
> read 3 blocks with offsets:
> 124
> 198
> 223
> Current way - we put the block 124, then put 198, evict 124, put 223, evict
> 198. A lot of work (5 actions).
> With the feature - last few digits evenly distributed from 0 to 99. When we
> divide by modulus we got:
> 124 -> 24
> 198 -> 98
> 223 -> 23
> It helps to sort them. Some part, for example below 50 (if we set
> *hbase.lru.cache.data.block.percent* = 50) go into the cache. And skip
> others. It means we will not try to handle the block 198 and save CPU for
> other job. In the result - we put block 124, then put 223, evict 124 (3
> actions).
> See the picture in attachment with test below. Requests per second is higher,
> GC is lower.
>
> The key point of the code:
> Added the parameter: *hbase.lru.cache.data.block.percent* which by default =
> 100
>
> But if we set it 1-99, then will work the next logic:
>
>
> {code:java}
> public void cacheBlock(BlockCacheKey cacheKey, Cacheable buf, boolean
> inMemory) {
> if (cacheDataBlockPercent != 100 && buf.getBlockType().isData())
> if (cacheKey.getOffset() % 100 >= cacheDataBlockPercent)
> return;
> ...
> // the same code as usual
> }
> {code}
>
> Other parameters help to control when this logic will be enabled. It means it
> will work only while heavy reading going on.
> hbase.lru.cache.heavy.eviction.count.limit - set how many times have to run
> eviction process that start to avoid of putting data to BlockCache
> hbase.lru.cache.heavy.eviction.bytes.size.limit - set how many bytes have to
> evicted each time that start to avoid of putting data to BlockCache
> By default: if 10 times (100 secunds) evicted more than 10 MB (each time)
> then we start to skip 50% of data blocks.
> When heavy evitions process end then new logic off and will put into
> BlockCache all blocks again.
>
> Descriptions of the test:
> 4 nodes E5-2698 v4 @ 2.20GHz, 700 Gb Mem.
> 4 RegionServers
> 4 tables by 64 regions by 1.88 Gb data in each = 600 Gb total (only FAST_DIFF)
> Total BlockCache Size = 48 Gb (8 % of data in HFiles)
> Random read in 20 threads
>
> I am going to make Pull Request, hope it is right way to make some
> contribution in this cool product.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted
Apache-HBase commented on pull request #1684: URL: https://github.com/apache/hbase/pull/1684#issuecomment-625837709 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 42s | master passed | | +1 :green_heart: | checkstyle | 1m 8s | master passed | | +1 :green_heart: | spotbugs | 2m 0s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | +1 :green_heart: | checkstyle | 1m 2s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 11s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 6s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 15s | The patch does not generate ASF License warnings. | | | | 32m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1684/1/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1684 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 0104adf7bcdd 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0cd70ed89c | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1684/1/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] HorizonNet commented on pull request #1685: Backport "HBASE-24305 Prepare deprecations in ServerName (#1666)" to branch-2
HorizonNet commented on pull request #1685: URL: https://github.com/apache/hbase/pull/1685#issuecomment-625828747 Variation of #1666 to backport the improvements made there to branch-2 without doing the actual deprecations. That includes moving all the usages of deprecated methods to their successors. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] HorizonNet opened a new pull request #1685: Backport "HBASE-24305 Prepare deprecations in ServerName (#1666)" to branch-2
HorizonNet opened a new pull request #1685: URL: https://github.com/apache/hbase/pull/1685 Signed-off-by: Duo Zhang Signed-off-by: stack This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24310) Use Slf4jRequestLog for hbase-http
[
https://issues.apache.org/jira/browse/HBASE-24310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102603#comment-17102603
]
Hudson commented on HBASE-24310:
Results for branch master
[build #1720 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1475//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Use Slf4jRequestLog for hbase-http
> --
>
> Key: HBASE-24310
> URL: https://issues.apache.org/jira/browse/HBASE-24310
> Project: HBase
> Issue Type: Sub-task
> Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> To remove the direct dependency on log4j in hbase-http server.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24295) [Chaos Monkey] abstract logging through the class hierarchy
[
https://issues.apache.org/jira/browse/HBASE-24295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102600#comment-17102600
]
Hudson commented on HBASE-24295:
Results for branch master
[build #1720 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1475//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Chaos Monkey] abstract logging through the class hierarchy
> ---
>
> Key: HBASE-24295
> URL: https://issues.apache.org/jira/browse/HBASE-24295
> Project: HBase
> Issue Type: Task
> Components: integration tests
>Affects Versions: 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Running chaos monkey and watching the logs, it's very difficult to tell what
> actions are actually running. There's lots of shared methods through the
> class hierarchy that extends from {{abstract class Action}}, and each class
> comes with its own {{Logger}}. As a result, the logs have useless stuff like
> {noformat}
> INFO actions.Action: Started regionserver...
> {noformat}
> Add {{protected abstract Logger getLogger()}} to the class's internal
> interface, and have the concrete implementations provide their logger.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24342) [Flakey Tests] Disable TestClusterPortAssignment.testClusterPortAssignment as it can't pass 100% of the time
[
https://issues.apache.org/jira/browse/HBASE-24342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102601#comment-17102601
]
Hudson commented on HBASE-24342:
Results for branch master
[build #1720 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1475//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] Disable TestClusterPortAssignment.testClusterPortAssignment as
> it can't pass 100% of the time
>
>
> Key: HBASE-24342
> URL: https://issues.apache.org/jira/browse/HBASE-24342
> Project: HBase
> Issue Type: Bug
> Components: flakies, test
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> This is a BindException special. We get randomFreePort and then put up the
> procesess.
> {code}
> 2020-05-07 00:30:15,844 INFO [Time-limited test] http.HttpServer(1080):
> HttpServer.start() threw a non Bind IOException
> java.net.BindException: Port in use: 0.0.0.0:59568
> at
> org.apache.hadoop.hbase.http.HttpServer.openListeners(HttpServer.java:1146)
> at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1077)
> at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:148)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.putUpWebUI(HRegionServer.java:2133)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:670)
> at org.apache.hadoop.hbase.master.HMaster.(HMaster.java:511)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:132)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.addMaster(LocalHBaseCluster.java:239)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.(LocalHBaseCluster.java:181)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.init(MiniHBaseCluster.java:245)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.(MiniHBaseCluster.java:115)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniHBaseCluster(HBaseTestingUtility.java:1178)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1142)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1106)
> at
> org.apache.hadoop.hbase.TestClusterPortAssignment.testClusterPortAssignment(TestClusterPortAssignment.java:57)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> a
[jira] [Commented] (HBASE-24305) Handle deprecations in ServerName
[
https://issues.apache.org/jira/browse/HBASE-24305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102604#comment-17102604
]
Hudson commented on HBASE-24305:
Results for branch master
[build #1720 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1475//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Handle deprecations in ServerName
> -
>
> Key: HBASE-24305
> URL: https://issues.apache.org/jira/browse/HBASE-24305
> Project: HBase
> Issue Type: Task
>Affects Versions: 3.0.0-alpha-1
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> Some functions in {{ServerName}} were deprecated in 2.0.0 and should be
> removed for version 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24338) [Flakey Tests] NPE in TestRaceBetweenSCPAndDTP
[
https://issues.apache.org/jira/browse/HBASE-24338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102602#comment-17102602
]
Hudson commented on HBASE-24338:
Results for branch master
[build #1720 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1475//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] NPE in TestRaceBetweenSCPAndDTP
> --
>
> Key: HBASE-24338
> URL: https://issues.apache.org/jira/browse/HBASE-24338
> Project: HBase
> Issue Type: Bug
> Components: flakies, test
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Seen in local runs
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24335) Support deleteall with ts but without column in shell mode
[
https://issues.apache.org/jira/browse/HBASE-24335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102599#comment-17102599
]
Hudson commented on HBASE-24335:
Results for branch master
[build #1720 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/]: (/)
*{color:green}+1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/General_20Nightly_20Build_20Report/]
(x) {color:red}-1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1475//JDK8_Nightly_Build_Report_(Hadoop2)/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/master/1720/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Support deleteall with ts but without column in shell mode
> --
>
> Key: HBASE-24335
> URL: https://issues.apache.org/jira/browse/HBASE-24335
> Project: HBase
> Issue Type: Improvement
> Components: shell
>Affects Versions: 3.0.0-alpha-1
>Reporter: Zheng Wang
>Assignee: Zheng Wang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0, 2.4.0
>
>
> The position after rowkey is column, so we can't only specify ts now.
> My proposal is use a empty string to represent no column specified.
> useage:
> deleteall 'test','r1','',158876590
> deleteall 'test', \{ROWPREFIXFILTER => 'prefix'}, '', 158876590
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Work started] (HBASE-24327) TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail with retries exhausted on an admin call.
[ https://issues.apache.org/jira/browse/HBASE-24327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on HBASE-24327 started by Viraj Jasani. > TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail > with retries exhausted on an admin call. > > > Key: HBASE-24327 > URL: https://issues.apache.org/jira/browse/HBASE-24327 > Project: HBase > Issue Type: Test > Components: test >Reporter: Mark Robert Miller >Assignee: Viraj Jasani >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24327) TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail with retries exhausted on an admin call.
[ https://issues.apache.org/jira/browse/HBASE-24327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani updated HBASE-24327: - Fix Version/s: 2.3.0 3.0.0-alpha-1 Status: Patch Available (was: In Progress) > TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail > with retries exhausted on an admin call. > > > Key: HBASE-24327 > URL: https://issues.apache.org/jira/browse/HBASE-24327 > Project: HBase > Issue Type: Test > Components: test >Reporter: Mark Robert Miller >Assignee: Viraj Jasani >Priority: Minor > Fix For: 3.0.0-alpha-1, 2.3.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] virajjasani opened a new pull request #1684: HBASE-24327 : Handle shutdown() if master cannot be contacted
virajjasani opened a new pull request #1684: URL: https://github.com/apache/hbase/pull/1684 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1681: HBASE-23938 : System table hbase:slowlog to store complete slow/large…
Apache-HBase commented on pull request #1681: URL: https://github.com/apache/hbase/pull/1681#issuecomment-625821616 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 34s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 43s | master passed | | +1 :green_heart: | checkstyle | 1m 33s | master passed | | +1 :green_heart: | spotbugs | 2m 43s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 14s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 25s | the patch passed | | -0 :warning: | checkstyle | 1m 9s | hbase-server: The patch generated 4 new + 148 unchanged - 0 fixed = 152 total (was 148) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 11m 16s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 3m 1s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 26s | The patch does not generate ASF License warnings. | | | | 36m 40s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/3/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1681 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 8fc438e0c194 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 0cd70ed89c | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 94 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/3/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1683: HBASE-24345 [ACL] renameRSGroup should require Admin level permission
Apache-HBase commented on pull request #1683: URL: https://github.com/apache/hbase/pull/1683#issuecomment-625812167 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 10s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 43s | master passed | | +1 :green_heart: | compile | 1m 8s | master passed | | +1 :green_heart: | shadedjars | 5m 59s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 4m 26s | the patch passed | | +1 :green_heart: | compile | 1m 8s | the patch passed | | +1 :green_heart: | javac | 1m 8s | the patch passed | | +1 :green_heart: | shadedjars | 5m 54s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 39s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 181m 43s | hbase-server in the patch passed. | | | | 209m 30s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1683/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1683 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 937a8432a190 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 03e5a1402d | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1683/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1683/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1683/2/testReport/ | | Max. process+thread count | 3720 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1683/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (HBASE-24327) TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail with retries exhausted on an admin call.
[ https://issues.apache.org/jira/browse/HBASE-24327?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viraj Jasani reassigned HBASE-24327: Assignee: Viraj Jasani > TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail > with retries exhausted on an admin call. > > > Key: HBASE-24327 > URL: https://issues.apache.org/jira/browse/HBASE-24327 > Project: HBase > Issue Type: Test > Components: test >Reporter: Mark Robert Miller >Assignee: Viraj Jasani >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly
Apache-HBase commented on pull request #1640: URL: https://github.com/apache/hbase/pull/1640#issuecomment-625807113 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 43s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 6s | master passed | | +1 :green_heart: | compile | 2m 43s | master passed | | +1 :green_heart: | shadedjars | 5m 23s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 18s | hbase-common in master failed. | | -0 :warning: | javadoc | 0m 16s | hbase-metrics-api in master failed. | | -0 :warning: | javadoc | 0m 14s | hbase-metrics in master failed. | | -0 :warning: | javadoc | 0m 19s | hbase-hadoop-compat in master failed. | | -0 :warning: | javadoc | 0m 25s | hbase-client in master failed. | | -0 :warning: | javadoc | 0m 16s | hbase-zookeeper in master failed. | | -0 :warning: | javadoc | 0m 15s | hbase-balancer in master failed. | | -0 :warning: | javadoc | 0m 16s | hbase-http in master failed. | | -0 :warning: | javadoc | 0m 17s | hbase-procedure in master failed. | | -0 :warning: | javadoc | 0m 16s | hbase-hbtop in master failed. | | -0 :warning: | javadoc | 0m 18s | root in master failed. | | -0 :warning: | javadoc | 0m 15s | hbase-client-project in master failed. | | -0 :warning: | javadoc | 0m 15s | hbase-shaded-client-project in master failed. | | -0 :warning: | javadoc | 0m 15s | hbase-asyncfs in master failed. | | -0 :warning: | javadoc | 0m 18s | hbase-backup in master failed. | | -0 :warning: | javadoc | 0m 17s | hbase-examples in master failed. | | -0 :warning: | javadoc | 0m 20s | hbase-mapreduce in master failed. | | -0 :warning: | javadoc | 0m 14s | hbase-replication in master failed. | | -0 :warning: | javadoc | 0m 19s | hbase-rest in master failed. | | -0 :warning: | javadoc | 0m 39s | hbase-server in master failed. | | -0 :warning: | javadoc | 0m 50s | hbase-thrift in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 56s | the patch passed | | +1 :green_heart: | compile | 2m 45s | the patch passed | | +1 :green_heart: | javac | 2m 45s | the patch passed | | +1 :green_heart: | shadedjars | 5m 19s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 17s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 14s | hbase-metrics-api in the patch failed. | | -0 :warning: | javadoc | 0m 16s | hbase-metrics in the patch failed. | | -0 :warning: | javadoc | 0m 18s | hbase-hadoop-compat in the patch failed. | | -0 :warning: | javadoc | 0m 25s | hbase-client in the patch failed. | | -0 :warning: | javadoc | 0m 16s | hbase-zookeeper in the patch failed. | | -0 :warning: | javadoc | 0m 15s | hbase-replication in the patch failed. | | -0 :warning: | javadoc | 0m 15s | hbase-balancer in the patch failed. | | -0 :warning: | javadoc | 0m 17s | hbase-http in the patch failed. | | -0 :warning: | javadoc | 0m 16s | hbase-asyncfs in the patch failed. | | -0 :warning: | javadoc | 0m 18s | hbase-procedure in the patch failed. | | -0 :warning: | javadoc | 0m 37s | hbase-server in the patch failed. | | -0 :warning: | javadoc | 0m 19s | hbase-mapreduce in the patch failed. | | -0 :warning: | javadoc | 0m 47s | hbase-thrift in the patch failed. | | -0 :warning: | javadoc | 0m 19s | hbase-backup in the patch failed. | | -0 :warning: | javadoc | 0m 18s | hbase-rest in the patch failed. | | -0 :warning: | javadoc | 0m 17s | hbase-examples in the patch failed. | | -0 :warning: | javadoc | 0m 17s | hbase-hbtop in the patch failed. | | -0 :warning: | javadoc | 0m 16s | hbase-client-project in the patch failed. | | -0 :warning: | javadoc | 0m 15s | hbase-shaded-client-project in the patch failed. | | -0 :warning: | javadoc | 0m 16s | root in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 163m 44s | root in the patch passed. | | | | 212m 44s | | | Subsystem | Report/Notes | |--:|:-| | Dock
[GitHub] [hbase] Apache-HBase commented on pull request #1681: HBASE-23938 : System table hbase:slowlog to store complete slow/large…
Apache-HBase commented on pull request #1681: URL: https://github.com/apache/hbase/pull/1681#issuecomment-625804727 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 13s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 29s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 4m 45s | master passed | | +1 :green_heart: | compile | 1m 36s | master passed | | +1 :green_heart: | shadedjars | 6m 2s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 17s | hbase-common in master failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 13s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 4m 32s | the patch passed | | +1 :green_heart: | compile | 1m 34s | the patch passed | | +1 :green_heart: | javac | 1m 34s | the patch passed | | +1 :green_heart: | shadedjars | 5m 57s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 16s | hbase-common in the patch failed. | | -0 :warning: | javadoc | 0m 41s | hbase-server in the patch failed. | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 43s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 185m 15s | hbase-server in the patch passed. | | | | 217m 23s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1681 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 09ed9caf75be 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 03e5a1402d | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-common.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/2/testReport/ | | Max. process+thread count | 3653 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24327) TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail with retries exhausted on an admin call.
[ https://issues.apache.org/jira/browse/HBASE-24327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102559#comment-17102559 ] Mark Robert Miller commented on HBASE-24327: Yeah, fire away. > TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail > with retries exhausted on an admin call. > > > Key: HBASE-24327 > URL: https://issues.apache.org/jira/browse/HBASE-24327 > Project: HBase > Issue Type: Test > Components: test >Reporter: Mark Robert Miller >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] HuiHang-Yu commented on pull request #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile
HuiHang-Yu commented on pull request #1380: URL: https://github.com/apache/hbase/pull/1380#issuecomment-625803217 How can i reslove the UT failure "Failed to read test report file ..." ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1683: HBASE-24345 [ACL] renameRSGroup should require Admin level permission
Apache-HBase commented on pull request #1683: URL: https://github.com/apache/hbase/pull/1683#issuecomment-625791036 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 44s | master passed | | +1 :green_heart: | compile | 0m 54s | master passed | | +1 :green_heart: | shadedjars | 5m 19s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 38s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 21s | the patch passed | | +1 :green_heart: | compile | 0m 55s | the patch passed | | +1 :green_heart: | javac | 0m 55s | the patch passed | | +1 :green_heart: | shadedjars | 5m 9s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 132m 13s | hbase-server in the patch passed. | | | | 155m 31s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1683/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1683 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 238ba23e0fb6 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 03e5a1402d | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1683/2/testReport/ | | Max. process+thread count | 3987 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1683/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile
Apache-HBase commented on pull request #1380: URL: https://github.com/apache/hbase/pull/1380#issuecomment-625789170 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 29s | Docker mode activated. | | -0 :warning: | yetus | 0m 2s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 18s | master passed | | +1 :green_heart: | compile | 1m 15s | master passed | | +1 :green_heart: | shadedjars | 6m 23s | branch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 48s | hbase-server in master failed. | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 5m 10s | the patch passed | | +1 :green_heart: | compile | 1m 20s | the patch passed | | +1 :green_heart: | javac | 1m 20s | the patch passed | | +1 :green_heart: | shadedjars | 6m 21s | patch has no errors when building our shaded downstream artifacts. | | -0 :warning: | javadoc | 0m 45s | hbase-server in the patch failed. | ||| _ Other Tests _ | | -1 :x: | unit | 195m 24s | hbase-server in the patch failed. | | | | 225m 3s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1380/2/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1380 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux b5edd05086fc 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 03e5a1402d | | Default Java | 2020-01-14 | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1380/2/artifact/yetus-jdk11-hadoop3-check/output/branch-javadoc-hbase-server.txt | | javadoc | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1380/2/artifact/yetus-jdk11-hadoop3-check/output/patch-javadoc-hbase-server.txt | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1380/2/artifact/yetus-jdk11-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1380/2/testReport/ | | Max. process+thread count | 2526 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1380/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (HBASE-24327) TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail with retries exhausted on an admin call.
[ https://issues.apache.org/jira/browse/HBASE-24327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102520#comment-17102520 ] Viraj Jasani edited comment on HBASE-24327 at 5/8/20, 12:10 PM: [~markrmiller] Can I take this up since this is not assigned? I have a small patch. was (Author: vjasani): [~markrmiller] Can I take this up? I have a small patch. > TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail > with retries exhausted on an admin call. > > > Key: HBASE-24327 > URL: https://issues.apache.org/jira/browse/HBASE-24327 > Project: HBase > Issue Type: Test > Components: test >Reporter: Mark Robert Miller >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (HBASE-24327) TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail with retries exhausted on an admin call.
[ https://issues.apache.org/jira/browse/HBASE-24327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102520#comment-17102520 ] Viraj Jasani commented on HBASE-24327: -- [~markrmiller] Can I take this up? I have a small patch. > TestMasterShutdown#testMasterShutdownBeforeStartingAnyRegionServer can fail > with retries exhausted on an admin call. > > > Key: HBASE-24327 > URL: https://issues.apache.org/jira/browse/HBASE-24327 > Project: HBase > Issue Type: Test > Components: test >Reporter: Mark Robert Miller >Priority: Minor > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1681: HBASE-23938 : System table hbase:slowlog to store complete slow/large…
Apache-HBase commented on pull request #1681: URL: https://github.com/apache/hbase/pull/1681#issuecomment-625783196 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 19s | Docker mode activated. | | -0 :warning: | yetus | 0m 3s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 27s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 43s | master passed | | +1 :green_heart: | compile | 1m 25s | master passed | | +1 :green_heart: | shadedjars | 5m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 57s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 16s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 23s | the patch passed | | +1 :green_heart: | compile | 1m 16s | the patch passed | | +1 :green_heart: | javac | 1m 16s | the patch passed | | +1 :green_heart: | shadedjars | 5m 10s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 57s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | unit | 1m 22s | hbase-common in the patch passed. | | +1 :green_heart: | unit | 131m 1s | hbase-server in the patch passed. | | | | 159m 10s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1681 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4fa290dfdfb8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 03e5a1402d | | Default Java | 1.8.0_232 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/2/testReport/ | | Max. process+thread count | 4003 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly
Apache-HBase commented on pull request #1640: URL: https://github.com/apache/hbase/pull/1640#issuecomment-625767309 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 37s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 43s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 45s | master passed | | +1 :green_heart: | checkstyle | 1m 59s | master passed | | +1 :green_heart: | spotbugs | 23m 58s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 20s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 35s | the patch passed | | +1 :green_heart: | checkstyle | 2m 5s | root: The patch generated 0 new + 3 unchanged - 1 fixed = 3 total (was 4) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | xml | 0m 34s | The patch has no ill-formed XML file. | | +1 :green_heart: | hadoopcheck | 13m 16s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 29m 44s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 5m 5s | The patch does not generate ASF License warnings. | | | | 100m 42s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1640/4/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1640 | | Optional Tests | dupname asflicense hadoopcheck xml spotbugs hbaseanti checkstyle | | uname | Linux 2e80264c229f 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 03e5a1402d | | Max. process+thread count | 137 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-metrics-api hbase-metrics hbase-hadoop-compat hbase-client hbase-zookeeper hbase-replication hbase-balancer hbase-http hbase-asyncfs hbase-procedure hbase-server hbase-mapreduce hbase-testing-util hbase-thrift hbase-shell hbase-endpoint hbase-backup hbase-it hbase-rest hbase-examples hbase-shaded hbase-hbtop hbase-assembly hbase-archetypes/hbase-client-project hbase-archetypes/hbase-shaded-client-project . U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1640/4/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [hbase] Apache-HBase commented on pull request #1380: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile
Apache-HBase commented on pull request #1380: URL: https://github.com/apache/hbase/pull/1380#issuecomment-625766729 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Docker mode activated. | | -0 :warning: | yetus | 0m 4s | Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck | ||| _ Prechecks _ | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 48s | master passed | | +1 :green_heart: | compile | 0m 56s | master passed | | +1 :green_heart: | shadedjars | 5m 20s | branch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 37s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 30s | the patch passed | | +1 :green_heart: | compile | 0m 56s | the patch passed | | +1 :green_heart: | javac | 0m 56s | the patch passed | | +1 :green_heart: | shadedjars | 5m 18s | patch has no errors when building our shaded downstream artifacts. | | +1 :green_heart: | javadoc | 0m 36s | the patch passed | ||| _ Other Tests _ | | -1 :x: | unit | 134m 42s | hbase-server in the patch failed. | | | | 158m 34s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1380/2/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1380 | | Optional Tests | javac javadoc unit shadedjars compile | | uname | Linux 4762f1b16184 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 03e5a1402d | | Default Java | 1.8.0_232 | | unit | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1380/2/artifact/yetus-jdk8-hadoop3-check/output/patch-unit-hbase-server.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1380/2/testReport/ | | Max. process+thread count | 4039 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1380/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24310) Use Slf4jRequestLog for hbase-http
[
https://issues.apache.org/jira/browse/HBASE-24310?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102456#comment-17102456
]
Hudson commented on HBASE-24310:
Results for branch branch-2.3
[build #72 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/72/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/72/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/72/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/72/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.3/72/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> Use Slf4jRequestLog for hbase-http
> --
>
> Key: HBASE-24310
> URL: https://issues.apache.org/jira/browse/HBASE-24310
> Project: HBase
> Issue Type: Sub-task
> Components: logging
>Reporter: Duo Zhang
>Assignee: Duo Zhang
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> To remove the direct dependency on log4j in hbase-http server.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1683: HBASE-24345 [ACL] renameRSGroup should require Admin level permission
Apache-HBase commented on pull request #1683: URL: https://github.com/apache/hbase/pull/1683#issuecomment-625750100 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 9s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 44s | master passed | | +1 :green_heart: | checkstyle | 1m 11s | master passed | | +1 :green_heart: | spotbugs | 2m 9s | master passed | ||| _ Patch Compile Tests _ | | +1 :green_heart: | mvninstall | 3m 52s | the patch passed | | +1 :green_heart: | checkstyle | 1m 15s | the patch passed | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 49s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 2m 23s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 13s | The patch does not generate ASF License warnings. | | | | 36m 32s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1683/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1683 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux e16d511ab782 4.15.0-74-generic #84-Ubuntu SMP Thu Dec 19 08:06:28 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 03e5a1402d | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-server U: hbase-server | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1683/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (HBASE-23268) Remove disable/enable operations from doc when altering schema
[
https://issues.apache.org/jira/browse/HBASE-23268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated HBASE-23268:
--
Fix Version/s: 3.0.0-alpha-1
> Remove disable/enable operations from doc when altering schema
> --
>
> Key: HBASE-23268
> URL: https://issues.apache.org/jira/browse/HBASE-23268
> Project: HBase
> Issue Type: Bug
> Components: documentation
>Affects Versions: 3.0.0-alpha-1
>Reporter: Daisuke Kobayashi
>Assignee: Daisuke Kobayashi
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
> Attachments: HBASE-23268.master.001.patch
>
>
> Per HBASE-15989, we always allow users to alter a schema without disabling
> the table. We should remove the steps before and after {{alter}} command from
> the doc appropriately.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-20516) Offheap read-path needs more detail
[ https://issues.apache.org/jira/browse/HBASE-20516?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-20516: -- Fix Version/s: 3.0.0-alpha-1 > Offheap read-path needs more detail > --- > > Key: HBASE-20516 > URL: https://issues.apache.org/jira/browse/HBASE-20516 > Project: HBase > Issue Type: Task > Components: Offheaping >Reporter: Michael Stack >Assignee: Michael Stack >Priority: Major > Fix For: 3.0.0-alpha-1 > > Attachments: 20516.initial.patch.txt, 20516.initial.patch.txt > > > Needs notes on what an operator should look for to see that all is on and > what to monitor in a running cluster. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-23738) Remove deprecated createLocalHRegion from HBaseTestingUtility
[
https://issues.apache.org/jira/browse/HBASE-23738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated HBASE-23738:
--
Fix Version/s: 3.0.0-alpha-1
> Remove deprecated createLocalHRegion from HBaseTestingUtility
> -
>
> Key: HBASE-23738
> URL: https://issues.apache.org/jira/browse/HBASE-23738
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 3.0.0-alpha-1
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> {{createLocalHRegion}} in {{HBaseTestingUtility}} was deprecated back in
> 2.0.0 and should be removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23736) Remove deprecated getTimeStampOfLastAppliedOp from MetricsSink
[
https://issues.apache.org/jira/browse/HBASE-23736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated HBASE-23736:
--
Fix Version/s: 3.0.0-alpha-1
> Remove deprecated getTimeStampOfLastAppliedOp from MetricsSink
> --
>
> Key: HBASE-23736
> URL: https://issues.apache.org/jira/browse/HBASE-23736
> Project: HBase
> Issue Type: Task
>Affects Versions: 3.0.0-alpha-1
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> {{MetricsSink}} defines the deprecated method
> {{getTimeStampOfLastAppliedOp}}, which should be removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23844) Remove deprecated Scan(byte[], Filter) from Scan
[
https://issues.apache.org/jira/browse/HBASE-23844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated HBASE-23844:
--
Fix Version/s: 3.0.0-alpha-1
> Remove deprecated Scan(byte[], Filter) from Scan
>
>
> Key: HBASE-23844
> URL: https://issues.apache.org/jira/browse/HBASE-23844
> Project: HBase
> Issue Type: Sub-task
>Affects Versions: 3.0.0-alpha-1
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> {{Scan(byte[], Filter)}} in {{Scan}} was deprecated back in 2.0.0 and should
> be removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-23309) Add support in ChainWalEntryFilter to filter Entry if all cells get filtered through WalCellFilter
[
https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated HBASE-23309:
--
Fix Version/s: 3.0.0-alpha-1
> Add support in ChainWalEntryFilter to filter Entry if all cells get filtered
> through WalCellFilter
> --
>
> Key: HBASE-23309
> URL: https://issues.apache.org/jira/browse/HBASE-23309
> Project: HBase
> Issue Type: Improvement
>Affects Versions: 3.0.0-alpha-1, 1.3.6, 2.3.3
>Reporter: Sandeep Pal
>Assignee: Sandeep Pal
>Priority: Major
> Fix For: 3.0.0-alpha-1
>
> Attachments: HBASE-23309.branch-1.patch, HBASE-23309.branch-2.patch,
> HBASE-23309.patch
>
>
> ChainWalEntryFilter applies the filter on entry followed by filter on cells.
> If filter on cells remove all the cells from the entry, we should add an
> option in chainwalentryfilter to filter the entry as well.
> Here is the snippet for ChainWalEntryFilter filter. After filterCells we
> should check if there is any cells remaining in the entry.
> {code:java}
> @Override
> public Entry filter(Entry entry) {
> for (WALEntryFilter filter : filters) {
> if (entry == null) {
> return null;
> }
> entry = filter.filter(entry);
> }
> filterCells(entry);
> return entry;
> }{code}
> Customer replication endpoints may use this flag.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24185) Junit tests do not behave well with System.exit or Runtime.halt or JVM exits in general.
[ https://issues.apache.org/jira/browse/HBASE-24185?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Somogyi updated HBASE-24185: -- Fix Version/s: 2.3.0 3.0.0-alpha-1 > Junit tests do not behave well with System.exit or Runtime.halt or JVM exits > in general. > > > Key: HBASE-24185 > URL: https://issues.apache.org/jira/browse/HBASE-24185 > Project: HBase > Issue Type: Test > Components: test >Reporter: Mark Robert Miller >Assignee: Mark Robert Miller >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > > This ends up exiting the JVM and confusing / erroring out the test runner > that manages that JVM as well as cutting off test output files. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (HBASE-23938) Replicate slow/large RPC calls to HDFS
[ https://issues.apache.org/jira/browse/HBASE-23938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102427#comment-17102427 ] Viraj Jasani edited comment on HBASE-23938 at 5/8/20, 10:12 AM: (Memstore + Flush + Compaction) should be enough for this effort overall. I can use Skip WAL option. was (Author: vjasani): Memstore + Flush + Compaction are enough. I can use Skip WAL option. > Replicate slow/large RPC calls to HDFS > -- > > Key: HBASE-23938 > URL: https://issues.apache.org/jira/browse/HBASE-23938 > Project: HBase > Issue Type: Sub-task >Affects Versions: 3.0.0-alpha-1, 2.3.0, 1.7.0 >Reporter: Viraj Jasani >Assignee: Viraj Jasani >Priority: Major > Fix For: 3.0.0-alpha-1, 2.3.0 > > Attachments: Screen Shot 2020-05-07 at 12.01.26 AM.png > > > We should provide capability to replicate complete slow and large RPC logs to > HDFS or create new system table in addition to Ring Buffer. This way we don't > lose any of slow logs and operator can retrieve all the slow/large logs. > Replicating logs to HDFS / creating new system table should be configurable. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (HBASE-24307) [Flakey Tests] krb server for secure thrift tests throws BindException
[
https://issues.apache.org/jira/browse/HBASE-24307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Somogyi updated HBASE-24307:
--
Fix Version/s: 2.3.0
3.0.0-alpha-1
> [Flakey Tests] krb server for secure thrift tests throws BindException
> --
>
> Key: HBASE-24307
> URL: https://issues.apache.org/jira/browse/HBASE-24307
> Project: HBase
> Issue Type: Bug
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Thought I'd put all the BindExceptions in thrift to sleep but just came
> across this one putting up the *krb* server used by the secure thrift http
> tests. There are two tests that use krb:
> {code}
>
> ---
> Test set: org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer
>
> ---
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.042 s <<<
> FAILURE! - in
> org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer
> org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer Time
> elapsed: 0.017 s <<< ERROR!
> org.apache.kerby.kerberos.kerb.KrbException: Failed to start KDC-Server
>at
> org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer.setUpBeforeClass(TestThriftSpnegoHttpFallbackServer.java:137)
> Caused by: java.net.BindException: Address already in use (Bind failed)
>at
> org.apache.hadoop.hbase.thrift.TestThriftSpnegoHttpFallbackServer.setUpBeforeClass(TestThriftSpnegoHttpFallbackServer.java:137)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24305) Handle deprecations in ServerName
[
https://issues.apache.org/jira/browse/HBASE-24305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102434#comment-17102434
]
Jan Hentschel commented on HBASE-24305:
---
Pushed to master. Thanks [~stack] & [~zhangduo] for the reviews. Leaving open
for the backports of the parts not affected by the removal of the deprecations.
> Handle deprecations in ServerName
> -
>
> Key: HBASE-24305
> URL: https://issues.apache.org/jira/browse/HBASE-24305
> Project: HBase
> Issue Type: Task
>Affects Versions: 3.0.0-alpha-1
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> Some functions in {{ServerName}} were deprecated in 2.0.0 and should be
> removed for version 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24305) Handle deprecations in ServerName
[
https://issues.apache.org/jira/browse/HBASE-24305?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated HBASE-24305:
--
Fix Version/s: 3.0.0-alpha-1
> Handle deprecations in ServerName
> -
>
> Key: HBASE-24305
> URL: https://issues.apache.org/jira/browse/HBASE-24305
> Project: HBase
> Issue Type: Task
>Affects Versions: 3.0.0-alpha-1
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
> Fix For: 3.0.0-alpha-1
>
>
> Some functions in {{ServerName}} were deprecated in 2.0.0 and should be
> removed for version 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24329) Remove deprecated CoprocessorService
[
https://issues.apache.org/jira/browse/HBASE-24329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102433#comment-17102433
]
Jan Hentschel commented on HBASE-24329:
---
This comment should originally go onto HBASE-24305. Just ignore it.
> Remove deprecated CoprocessorService
>
>
> Key: HBASE-24329
> URL: https://issues.apache.org/jira/browse/HBASE-24329
> Project: HBase
> Issue Type: Improvement
> Components: Coprocessors
>Affects Versions: 3.0.0-alpha-1
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> The interface {{CoprocessorService}} was deprecated in 2.0.0 and should be
> removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24329) Remove deprecated CoprocessorService
[
https://issues.apache.org/jira/browse/HBASE-24329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated HBASE-24329:
--
Fix Version/s: (was: 3.0.0-alpha-1)
> Remove deprecated CoprocessorService
>
>
> Key: HBASE-24329
> URL: https://issues.apache.org/jira/browse/HBASE-24329
> Project: HBase
> Issue Type: Improvement
> Components: Coprocessors
>Affects Versions: 3.0.0-alpha-1
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> The interface {{CoprocessorService}} was deprecated in 2.0.0 and should be
> removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (HBASE-24329) Remove deprecated CoprocessorService
[
https://issues.apache.org/jira/browse/HBASE-24329?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Hentschel updated HBASE-24329:
--
Status: In Progress (was: Patch Available)
> Remove deprecated CoprocessorService
>
>
> Key: HBASE-24329
> URL: https://issues.apache.org/jira/browse/HBASE-24329
> Project: HBase
> Issue Type: Improvement
> Components: Coprocessors
>Affects Versions: 3.0.0-alpha-1
>Reporter: Jan Hentschel
>Assignee: Jan Hentschel
>Priority: Minor
>
> The interface {{CoprocessorService}} was deprecated in 2.0.0 and should be
> removed for 3.0.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [hbase] Apache-HBase commented on pull request #1681: HBASE-23938 : System table hbase:slowlog to store complete slow/large…
Apache-HBase commented on pull request #1681: URL: https://github.com/apache/hbase/pull/1681#issuecomment-625742344 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 6s | Docker mode activated. | ||| _ Prechecks _ | | +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. | | +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | ||| _ master Compile Tests _ | | +0 :ok: | mvndep | 0m 32s | Maven dependency ordering for branch | | +1 :green_heart: | mvninstall | 3m 59s | master passed | | +1 :green_heart: | checkstyle | 1m 37s | master passed | | +1 :green_heart: | spotbugs | 2m 49s | master passed | ||| _ Patch Compile Tests _ | | +0 :ok: | mvndep | 0m 12s | Maven dependency ordering for patch | | +1 :green_heart: | mvninstall | 3m 47s | the patch passed | | -0 :warning: | checkstyle | 1m 15s | hbase-server: The patch generated 4 new + 148 unchanged - 0 fixed = 152 total (was 148) | | +1 :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | +1 :green_heart: | hadoopcheck | 12m 30s | Patch does not cause any errors with Hadoop 3.1.2 3.2.1. | | +1 :green_heart: | spotbugs | 3m 9s | the patch passed | ||| _ Other Tests _ | | +1 :green_heart: | asflicense | 0m 22s | The patch does not generate ASF License warnings. | | | | 39m 48s | | | Subsystem | Report/Notes | |--:|:-| | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/2/artifact/yetus-general-check/output/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/1681 | | Optional Tests | dupname asflicense spotbugs hadoopcheck hbaseanti checkstyle | | uname | Linux 28e300e9ee83 4.15.0-91-generic #92-Ubuntu SMP Fri Feb 28 11:09:48 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | dev-support/hbase-personality.sh | | git revision | master / 03e5a1402d | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt | | Max. process+thread count | 84 (vs. ulimit of 12500) | | modules | C: hbase-common hbase-server U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1681/2/console | | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) spotbugs=3.1.12 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (HBASE-24342) [Flakey Tests] Disable TestClusterPortAssignment.testClusterPortAssignment as it can't pass 100% of the time
[
https://issues.apache.org/jira/browse/HBASE-24342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102428#comment-17102428
]
Hudson commented on HBASE-24342:
Results for branch branch-2
[build #2649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] Disable TestClusterPortAssignment.testClusterPortAssignment as
> it can't pass 100% of the time
>
>
> Key: HBASE-24342
> URL: https://issues.apache.org/jira/browse/HBASE-24342
> Project: HBase
> Issue Type: Bug
> Components: flakies, test
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> This is a BindException special. We get randomFreePort and then put up the
> procesess.
> {code}
> 2020-05-07 00:30:15,844 INFO [Time-limited test] http.HttpServer(1080):
> HttpServer.start() threw a non Bind IOException
> java.net.BindException: Port in use: 0.0.0.0:59568
> at
> org.apache.hadoop.hbase.http.HttpServer.openListeners(HttpServer.java:1146)
> at org.apache.hadoop.hbase.http.HttpServer.start(HttpServer.java:1077)
> at org.apache.hadoop.hbase.http.InfoServer.start(InfoServer.java:148)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.putUpWebUI(HRegionServer.java:2133)
> at
> org.apache.hadoop.hbase.regionserver.HRegionServer.(HRegionServer.java:670)
> at org.apache.hadoop.hbase.master.HMaster.(HMaster.java:511)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at java.lang.reflect.Constructor.newInstance(Constructor.java:423)
> at
> org.apache.hadoop.hbase.util.JVMClusterUtil.createMasterThread(JVMClusterUtil.java:132)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.addMaster(LocalHBaseCluster.java:239)
> at
> org.apache.hadoop.hbase.LocalHBaseCluster.(LocalHBaseCluster.java:181)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.init(MiniHBaseCluster.java:245)
> at
> org.apache.hadoop.hbase.MiniHBaseCluster.(MiniHBaseCluster.java:115)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniHBaseCluster(HBaseTestingUtility.java:1178)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1142)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.startMiniCluster(HBaseTestingUtility.java:1106)
> at
> org.apache.hadoop.hbase.TestClusterPortAssignment.testClusterPortAssignment(TestClusterPortAssignment.java:57)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunne
[jira] [Commented] (HBASE-24338) [Flakey Tests] NPE in TestRaceBetweenSCPAndDTP
[
https://issues.apache.org/jira/browse/HBASE-24338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102430#comment-17102430
]
Hudson commented on HBASE-24338:
Results for branch branch-2
[build #2649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Flakey Tests] NPE in TestRaceBetweenSCPAndDTP
> --
>
> Key: HBASE-24338
> URL: https://issues.apache.org/jira/browse/HBASE-24338
> Project: HBase
> Issue Type: Bug
> Components: flakies, test
>Reporter: Michael Stack
>Assignee: Michael Stack
>Priority: Major
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Seen in local runs
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (HBASE-24295) [Chaos Monkey] abstract logging through the class hierarchy
[
https://issues.apache.org/jira/browse/HBASE-24295?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17102429#comment-17102429
]
Hudson commented on HBASE-24295:
Results for branch branch-2
[build #2649 on
builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/]:
(x) *{color:red}-1 overall{color}*
details (if available):
(/) {color:green}+1 general checks{color}
-- For more information [see general
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/General_20Nightly_20Build_20Report/]
(/) {color:green}+1 jdk8 hadoop2 checks{color}
-- For more information [see jdk8 (hadoop2)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/JDK8_20Nightly_20Build_20Report_20_28Hadoop2_29/]
(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3)
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(x) {color:red}-1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11
report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2/2649/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]
(/) {color:green}+1 source release artifact{color}
-- See build output for details.
(/) {color:green}+1 client integration test{color}
> [Chaos Monkey] abstract logging through the class hierarchy
> ---
>
> Key: HBASE-24295
> URL: https://issues.apache.org/jira/browse/HBASE-24295
> Project: HBase
> Issue Type: Task
> Components: integration tests
>Affects Versions: 2.3.0
>Reporter: Nick Dimiduk
>Assignee: Nick Dimiduk
>Priority: Minor
> Fix For: 3.0.0-alpha-1, 2.3.0
>
>
> Running chaos monkey and watching the logs, it's very difficult to tell what
> actions are actually running. There's lots of shared methods through the
> class hierarchy that extends from {{abstract class Action}}, and each class
> comes with its own {{Logger}}. As a result, the logs have useless stuff like
> {noformat}
> INFO actions.Action: Started regionserver...
> {noformat}
> Add {{protected abstract Logger getLogger()}} to the class's internal
> interface, and have the concrete implementations provide their logger.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
