D24939: Meson: more built-in functions and add built-in member functions

[Dominik Haumann]

dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Looks good to me, thanks!

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  meson (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24939

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

[Laurent Montel]

mlaurent added a comment.


  So what is the correct fix for my case ?

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D24884

To: mlaurent, dfaure, ilic
Cc: aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 WindowsMSVCQt5.13 - Build # 10 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20WindowsMSVCQt5.13/10/
 Project:
kf5-qt5 WindowsMSVCQt5.13
 Date of build:
Thu, 24 Oct 2019 22:28:45 +
 Build duration:
2 hr 46 min and counting
   JUnit Tests
  Name: projectroot Failed: 13 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_picFailed: projectroot.autotests.kimageformats_read_hdrFailed: projectroot.autotests.kimageformats_read_kraFailed: projectroot.autotests.kimageformats_read_oraFailed: projectroot.autotests.kimageformats_read_pcxFailed: projectroot.autotests.kimageformats_read_psdFailed: projectroot.autotests.kimageformats_read_rasFailed: projectroot.autotests.kimageformats_read_rgbFailed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_read_xcfFailed: projectroot.autotests.kimageformats_write_pcxFailed: projectroot.autotests.kimageformats_write_rgbFailed: projectroot.autotests.kimageformats_write_tga

KDE CI: Frameworks » kwayland » kf5-qt5 SUSEQt5.13 - Build # 31 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20SUSEQt5.13/31/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 24 Oct 2019 22:31:55 +
 Build duration:
2 hr 15 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5Wayland-5.64.0.xmlcompat_reports/KF5Wayland_compat_report.htmllogs/KF5Wayland/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.autotests Failed: 1 test(s), Passed: 45 test(s), Skipped: 0 test(s), Total: 46 test(s)Failed: projectroot.autotests.client.kwayland_testPlasmaWindowModel
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report63%
(5/8)90%
(240/268)90%
(240/268)85%
(27194/32075)53%
(10952/20609)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests.client100%
(43/43)100%
(43/43)99%
(12503/12574)50%
(6591/13095)autotests.server100%
(5/5)100%
(5/5)99%
(373/376)49%
(177/360)src.client96%
(73/76)96%
(73/76)85%
(6344/7481)64%
(1828/2836)src.compat100%
(2/2)100%
(2/2)100%
(81/81)100%
(0/0)src.server95%
(117/123)95%
(117/123)84%
(7893/9364)64%
(2356/3687)src.tools0%
(0/2)0%
(0/2)0%
(0/785)0%
(0/302)src.tools.testserver0%
(0/3)0%
(0/3)0%
(0/119)0%
(0/14)tests0%
(0/14)0%
(0/14)0%
(0/1295)0%
(0/315)

D24939: Meson: more built-in functions and add built-in member functions

[jonathan poelen]

jpoelen created this revision.
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann.
jpoelen added projects: Kate, Frameworks.
jpoelen requested review of this revision.

REPOSITORY
  R216 Syntax Highlighting

BRANCH
  meson (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24939

AFFECTED FILES
  autotests/folding/meson.build.fold
  autotests/html/meson.build.html
  autotests/input/meson.build
  autotests/reference/meson.build.ref
  data/syntax/meson.xml

To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D24938: Fix memory leak in KXzFilter::init

[Aleix Pol Gonzalez]

apol added a comment.


  +1 makes sense

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D24938

To: aacid
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kimageformats » kf5-qt5 SUSEQt5.13 - Build # 18 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20SUSEQt5.13/18/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 24 Oct 2019 22:28:48 +
 Build duration:
1 hr 33 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 13 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_picFailed: projectroot.autotests.kimageformats_read_hdrFailed: projectroot.autotests.kimageformats_read_kraFailed: projectroot.autotests.kimageformats_read_oraFailed: projectroot.autotests.kimageformats_read_pcxFailed: projectroot.autotests.kimageformats_read_psdFailed: projectroot.autotests.kimageformats_read_rasFailed: projectroot.autotests.kimageformats_read_rgbFailed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_read_xcfFailed: projectroot.autotests.kimageformats_write_pcxFailed: projectroot.autotests.kimageformats_write_rgbFailed: projectroot.autotests.kimageformats_write_tga
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report33%
(1/3)5%
(1/20)5%
(1/20)1%
(37/3921)0%
(3/2238)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests33%
(1/3)33%
(1/3)10%
(37/385)2%
(3/134)src.imageformats0%
(0/14)0%
(0/14)0%
(0/3401)0%
(0/2064)tests0%
(0/3)0%
(0/3)0%
(0/135)0%
(0/40)

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.13 - Build # 54 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.13/54/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Thu, 24 Oct 2019 22:27:02 +
 Build duration:
1 hr 23 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.64.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6884/9076)43%
(10766/24805)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2871/2964)48%
(6168/12727)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/788)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(993/1215)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » solid » kf5-qt5 FreeBSDQt5.13 - Build # 31 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/31/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 24 Oct 2019 22:32:31 +
 Build duration:
1 hr 7 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 3 test(s), Skipped: 0 test(s), Total: 4 test(s)Failed: projectroot.autotests.halbasictest

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 29 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/29/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 24 Oct 2019 22:31:52 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 130 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/130/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 24 Oct 2019 22:30:43 +
 Build duration:
54 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 61 test(s), Skipped: 0 test(s), Total: 62 test(s)Failed: projectroot.autotests.inlinenote_testName: projectroot.autotests.src Failed: 0 test(s), Passed: 5 test(s), Skipped: 0 test(s), Total: 5 test(s)

KDE CI: Frameworks » kservice » kf5-qt5 FreeBSDQt5.13 - Build # 44 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kservice/job/kf5-qt5%20FreeBSDQt5.13/44/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 24 Oct 2019 22:30:36 +
 Build duration:
45 min and counting
   JUnit Tests
  Name: projectroot Failed: 2 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 9 test(s)Failed: projectroot.autotests.kmimeassociationstestFailed: projectroot.autotests.ksycoca_xdgdirstestName: projectroot.tests Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpty » kf5-qt5 FreeBSDQt5.13 - Build # 16 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpty/job/kf5-qt5%20FreeBSDQt5.13/16/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 24 Oct 2019 22:30:24 +
 Build duration:
40 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kptyprocesstest

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/24/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 24 Oct 2019 22:30:18 +
 Build duration:
37 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 157 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/157/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 24 Oct 2019 22:28:55 +
 Build duration:
35 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kimageformats » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kimageformats/job/kf5-qt5%20FreeBSDQt5.13/15/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 24 Oct 2019 22:28:44 +
 Build duration:
27 min and counting
   JUnit Tests
  Name: projectroot Failed: 13 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 14 test(s)Failed: projectroot.autotests.kimageformats_picFailed: projectroot.autotests.kimageformats_read_hdrFailed: projectroot.autotests.kimageformats_read_kraFailed: projectroot.autotests.kimageformats_read_oraFailed: projectroot.autotests.kimageformats_read_pcxFailed: projectroot.autotests.kimageformats_read_psdFailed: projectroot.autotests.kimageformats_read_rasFailed: projectroot.autotests.kimageformats_read_rgbFailed: projectroot.autotests.kimageformats_read_tgaFailed: projectroot.autotests.kimageformats_read_xcfFailed: projectroot.autotests.kimageformats_write_pcxFailed: projectroot.autotests.kimageformats_write_rgbFailed: projectroot.autotests.kimageformats_write_tga

D24938: Fix memory leak in KXzFilter::init

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  I wasn't 99% sure we need to free the filters so early since we're passing 
them to the functions that manipulate the streams,
  but having a look at various other code using lzma they also free them very 
early and the fact that everything still works is also a good indicator

TEST PLAN
  Before valgrind --leak-check=full karchivetest gave memory leaks, now it does 
not

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24938

AFFECTED FILES
  src/kxzfilter.cpp

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcoreaddons » kf5-qt5 SUSEQt5.12 - Build # 101 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20SUSEQt5.12/101/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 24 Oct 2019 22:27:01 +
 Build duration:
26 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/KF5CoreAddons-5.64.0.xmlcompat_reports/KF5CoreAddons_compat_report.htmllogs/KF5CoreAddons/5.64.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 27 test(s), Skipped: 0 test(s), Total: 27 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report91%
(10/11)86%
(80/93)86%
(80/93)76%
(6884/9077)43%
(10766/24805)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests94%
(31/33)94%
(31/33)97%
(2871/2964)48%
(6168/12727)src.desktoptojson100%
(2/2)100%
(2/2)78%
(90/115)37%
(109/298)src.lib67%
(2/3)67%
(2/3)62%
(382/621)26%
(244/924)src.lib.caching100%
(2/2)100%
(2/2)45%
(354/784)18%
(187/1054)src.lib.io75%
(9/12)75%
(9/12)67%
(868/1293)36%
(998/2787)src.lib.jobs71%
(5/7)71%
(5/7)57%
(160/281)40%
(54/134)src.lib.plugin100%
(7/7)100%
(7/7)85%
(672/789)42%
(944/2251)src.lib.randomness100%
(2/2)100%
(2/2)70%
(67/96)58%
(45/78)src.lib.text63%
(5/8)63%
(5/8)51%
(427/834)47%
(1001/2143)src.lib.util100%
(15/15)100%
(15/15)82%
(993/1215)50%
(1016/2019)tests0%
(0/2)0%
(0/2)0%
(0/85)0%
(0/390)

KDE CI: Frameworks » kdesu » kf5-qt5 FreeBSDQt5.13 - Build # 17 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kdesu/job/kf5-qt5%20FreeBSDQt5.13/17/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 24 Oct 2019 22:27:33 +
 Build duration:
18 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.autotests.kdesutest

KDE CI: Frameworks » kcoreaddons » kf5-qt5 FreeBSDQt5.13 - Build # 50 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcoreaddons/job/kf5-qt5%20FreeBSDQt5.13/50/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 24 Oct 2019 22:27:01 +
 Build duration:
16 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 26 test(s), Skipped: 0 test(s), Total: 27 test(s)Failed: projectroot.autotests.kdirwatch_inotify_unittest

D24908: fix default shortcut detection

[Albert Astals Cid]

aacid accepted this revision.
aacid added a comment.
This revision is now accepted and ready to land.


  ok, fair enough about the tests

INLINE COMMENTS

> sitter wrote in kshortcuteditwidget.cpp:72
> it's initialized to None via the ctor at line 68 already. now that I notice 
> it, defaultText could also be const now.

ah right.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24908

To: sitter, dfaure, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24827: auto-enable KIO_ASSERT_SLAVE_STATES also for from-git builds

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  assert-for-git

REVISION DETAIL
  https://phabricator.kde.org/D24827

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kcalendarcore » kf5-qt5 FreeBSDQt5.13 - Build # 20 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kcalendarcore/job/kf5-qt5%20FreeBSDQt5.13/20/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 24 Oct 2019 22:26:18 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 457 test(s), Passed: 35 test(s), Skipped: 0 test(s), Total: 492 test(s)Failed: projectroot.autotests.Compat_libical3_AppleICal_1.5.icsFailed: projectroot.autotests.Compat_libical3_Evolution_2.8.2_timezone_test.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.1a.icsFailed: projectroot.autotests.Compat_libical3_KOrganizer_3.2.icsFailed: projectroot.autotests.Compat_libical3_MSExchange.icsFailed: projectroot.autotests.Compat_libical3_Mozilla_1.0.icsFailed: projectroot.autotests.Compat_libical3_Todos.icsFailed: projectroot.autotests.Compat_libical3_eGroupware.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1.icsFailed: projectroot.autotests.RecurNext_ConnectDaily10.icsFailed: projectroot.autotests.RecurNext_ConnectDaily11.icsFailed: projectroot.autotests.RecurNext_ConnectDaily1a.icsFailed: projectroot.autotests.RecurNext_ConnectDaily2.icsFailed: projectroot.autotests.RecurNext_ConnectDaily3.icsFailed: projectroot.autotests.RecurNext_ConnectDaily4.icsFailed: projectroot.autotests.RecurNext_ConnectDaily5.icsFailed: projectroot.autotests.RecurNext_ConnectDaily6.icsFailed: projectroot.autotests.RecurNext_ConnectDaily7.icsFailed: projectroot.autotests.RecurNext_ConnectDaily8.icsFailed: projectroot.autotests.RecurNext_ConnectDaily9.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase01.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase02.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase03.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase04.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase05.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase06.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase07.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase08.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase09.icsFailed: projectroot.autotests.RecurNext_KAlarm_TestCase10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test01.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test02.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test03.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test04.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test05.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test06.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test07.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test08.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test09.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test10.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test11.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test12.icsFailed: projectroot.autotests.RecurNext_KOrganizer_Test13.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase01.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase02.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase03.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase04.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase05.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase06.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase07.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase08.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase09.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase10.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase11.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase12.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase15.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase16.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase17.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase18.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase19.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase20.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase21.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase23.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase24.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase25.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase26.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase27.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase28.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase29.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase30.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase31.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase32.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase33.icsFailed: projectroot.autotests.RecurNext_LibICal_TestCase34.icsFailed: 

Re: [sysadmin/release-tools/frameworks/5.0] /: KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version

[David Faure]

On jeudi 24 octobre 2019 22:24:55 CEST Friedrich W. H. Kossebau wrote:
> BTW, we want to also set
> -DQT_DEPRECATED_WARNINGS_SINCE=0x06
> otherwise the deprecations done with QT_DEPRECATED_VERSION in Qt's API will
> not emit warnings, because QT_DEPRECATED_WARNINGS_SINCE defaults to
> QT_DISABLE_DEPRECATED_BEFORE if set.

Oh, good to know. Done now for all of KF5.

> Otherwise there will be bad surprises when bumping
> QT_DISABLE_DEPRECATED_BEFORE.

There will be anyway, given that people ignore warnings :-)

-- 
David Faure, fa...@kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5

D24908: fix default shortcut detection

[Harald Sitter]

sitter added inline comments.

INLINE COMMENTS

> aacid wrote in kshortcuteditwidget.cpp:72
> this is wrong, isn't it?
> 
> Or at least behaviour changing, before m_defaultLabel was set to None, when 
> defaultText was empty. Now it's not?

it's initialized to None via the ctor at line 68 already. now that I notice it, 
defaultText could also be const now.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24908

To: sitter, dfaure
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

[Ahmad Samir]

ahmadsamir added a comment.


  Is cipherDigestMethod() (method @ line 96) needed? the cipher name is 
inserted in sslMetaData a couple of lines after that.
  
  Using some test code:
  QList list = QSslConfiguration::supportedCiphers();
  for (QSslCipher c  : list) {
  
qInfo() << c.name();
  
  }
  
  I get:
  "TLS_AES_256_GCM_SHA384"
  "TLS_CHACHA20_POLY1305_SHA256"
  "TLS_AES_128_GCM_SHA256"
  "ECDHE-ECDSA-AES256-GCM-SHA384"
  "ECDHE-RSA-AES256-GCM-SHA384"
  "DHE-RSA-AES256-GCM-SHA384"
  "ECDHE-ECDSA-CHACHA20-POLY1305"
  "ECDHE-RSA-CHACHA20-POLY1305"
  "DHE-RSA-CHACHA20-POLY1305"
  "ECDHE-ECDSA-AES128-GCM-SHA256"
  "ECDHE-RSA-AES128-GCM-SHA256"
  "DHE-RSA-AES128-GCM-SHA256"
  "ECDHE-ECDSA-AES256-SHA384"
  "ECDHE-RSA-AES256-SHA384"
  "DHE-RSA-AES256-SHA256"
  "ECDHE-ECDSA-AES128-SHA256"
  "ECDHE-RSA-AES128-SHA256"
  "DHE-RSA-AES128-SHA256"
  "ECDHE-ECDSA-AES256-SHA"
  "ECDHE-RSA-AES256-SHA"
  "DHE-RSA-AES256-SHA"
  "ECDHE-ECDSA-AES128-SHA"
  "ECDHE-RSA-AES128-SHA"
  "DHE-RSA-AES128-SHA"
  "RSA-PSK-AES256-GCM-SHA384"
  "DHE-PSK-AES256-GCM-SHA384"
  "RSA-PSK-CHACHA20-POLY1305"
  "DHE-PSK-CHACHA20-POLY1305"
  "ECDHE-PSK-CHACHA20-POLY1305"
  "AES256-GCM-SHA384"
  "PSK-AES256-GCM-SHA384"
  "PSK-CHACHA20-POLY1305"
  "RSA-PSK-AES128-GCM-SHA256"
  "DHE-PSK-AES128-GCM-SHA256"
  "AES128-GCM-SHA256"
  "PSK-AES128-GCM-SHA256"
  "AES256-SHA256"
  "AES128-SHA256"
  "ECDHE-PSK-AES256-CBC-SHA384"
  "ECDHE-PSK-AES256-CBC-SHA"
  "SRP-RSA-AES-256-CBC-SHA"
  "SRP-AES-256-CBC-SHA"
  "RSA-PSK-AES256-CBC-SHA384"
  "DHE-PSK-AES256-CBC-SHA384"
  "RSA-PSK-AES256-CBC-SHA"
  "DHE-PSK-AES256-CBC-SHA"
  "AES256-SHA"
  "PSK-AES256-CBC-SHA384"
  "PSK-AES256-CBC-SHA"
  "ECDHE-PSK-AES128-CBC-SHA256"
  "ECDHE-PSK-AES128-CBC-SHA"
  "SRP-RSA-AES-128-CBC-SHA"
  "SRP-AES-128-CBC-SHA"
  "RSA-PSK-AES128-CBC-SHA256"
  "DHE-PSK-AES128-CBC-SHA256"
  "RSA-PSK-AES128-CBC-SHA"
  "DHE-PSK-AES128-CBC-SHA"
  "AES128-SHA"
  "PSK-AES128-CBC-SHA256"
  "PSK-AES128-CBC-SHA"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24928

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24936: readAndDecodePackedStreams: call reserve on inflated bytearray

[Albert Astals Cid]

aacid abandoned this revision.
aacid added a comment.


  I don't know either. Let's not micro optimize without need and knowledge

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D24936

To: aacid
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24908: fix default shortcut detection

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> kshortcuteditwidget.cpp:72
> +m_defaultLabel->setText(defaultText);
>  }
>  

this is wrong, isn't it?

Or at least behaviour changing, before m_defaultLabel was set to None, when 
defaultText was empty. Now it's not?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24908

To: sitter, dfaure
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24936: readAndDecodePackedStreams: call reserve on inflated bytearray

[David Faure]

dfaure added a comment.


  Should this be in   if (folder->unpackCRCDefined) like the check for 
unpackSize? Disclaimer: I don't know this code.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D24936

To: aacid
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

[David Faure]

dfaure added a comment.


  I forgot to link the fix here: D24880 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24316

To: vkrause, dfaure
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24898: Add KLocalizedString::untranslatedText

[Albert Astals Cid]

aacid added a comment.


  No one has shown the need for those things your asking.
  
  We have clear need for untranlatedText.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D24898

To: aacid
Cc: apol, ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24936: readAndDecodePackedStreams: call reserve on inflated bytearray

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24936

AFFECTED FILES
  src/k7zip.cpp

To: aacid
Cc: dfaure, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24908: fix default shortcut detection

[Harald Sitter]

sitter added a comment.


  Supposedly, I was being lazy though since there is no pre existing test and I 
don't exactly know if there's anything to watch out for when testing widgets 
(as in: I've never written a widget test before).

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24908

To: sitter, dfaure
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: [sysadmin/release-tools/frameworks/5.0] /: KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version

[Friedrich W. H. Kossebau]

Am Donnerstag, 24. Oktober 2019, 22:16:47 CEST schrieb David Faure:
> Git commit fb4639b0b5f2a51d124949d59b9a327bf66c8f04 by David Faure.
> Committed on 24/10/2019 at 20:15.
> Pushed by dfaure into branch 'frameworks/5.0'.
> 
> KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt
> version

BTW, we want to also set
-DQT_DEPRECATED_WARNINGS_SINCE=0x06
otherwise the deprecations done with QT_DEPRECATED_VERSION in Qt's API will 
not emit warnings, because QT_DEPRECATED_WARNINGS_SINCE defaults to 
QT_DISABLE_DEPRECATED_BEFORE if set.
Cmp. https://code.woboq.org/qt5/qtbase/src/corelib/global/qglobal.h.html#310 
ff.

Otherwise there will be bad surprises when bumping 
QT_DISABLE_DEPRECATED_BEFORE.

Cheers
Friedrich

[sysadmin/release-tools/frameworks/5.0] /: KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt version

[David Faure]

Git commit fb4639b0b5f2a51d124949d59b9a327bf66c8f04 by David Faure.
Committed on 24/10/2019 at 20:15.
Pushed by dfaure into branch 'frameworks/5.0'.

KF5: auto-increase QT_DISABLE_DEPRECATED_BEFORE when upgrading the min Qt 
version

This is just safety; some time ago I made them all disable API
deprecated before 5.13 and the current min Qt version is 5.11.

Thanks Volker for the idea.

CCMAIL: vkra...@kde.org, kde-frameworks-devel@kde.org

M  +9-1increase_qt_version.sh

https://commits.kde.org/sysadmin/release-tools/fb4639b0b5f2a51d124949d59b9a327bf66c8f04

diff --git a/increase_qt_version.sh b/increase_qt_version.sh
index ef17c11..8059910 100755
--- a/increase_qt_version.sh
+++ b/increase_qt_version.sh
@@ -2,7 +2,12 @@
 
 . utils.sh
 
-qt_version="5.11.0"
+qt_version_major=5
+qt_version_minor=11
+qt_version_patch=0
+
+qt_version="${qt_version_major}.${qt_version_minor}.${qt_version_patch}"
+qt_version_hex="0x`printf '%02x%02x%02x\n' ${qt_version_major} 
${qt_version_minor} ${qt_version_patch}`"
 
 if [ ! -d $srcdir ]; then
 echo "$srcdir does not exist, please fix srcdir variable"
@@ -20,6 +25,9 @@ cat $releasetools/modules.git | while read repo branch; do
 $cmd git pull --rebase || exit 3
 if [ "$repo" != extra-cmake-modules ]; then
 $cmd perl -pi -e 's/REQUIRED_QT_VERSION 
\"?[0-9]+\.[0-9]+\.[0-9]+\"?/REQUIRED_QT_VERSION '$qt_version'/g' CMakeLists.txt
+if ! grep -q 'deprecated: true' metainfo.yaml; then
+$cmd perl -pi -e 'if (my ($old) = 
/QT_DISABLE_DEPRECATED_BEFORE=(0x[0-9a-fA-F]+)/) { s/$old/'$qt_version_hex'/ if 
(hex($old) < hex("'$qt_version_hex'")); }' CMakeLists.txt
+fi
 $cmd git commit -a -m "GIT_SILENT Upgrade Qt5 version requirement to 
$qt_version."
 fi
 $cmd git pull --rebase

D24932: [WIP]: Add Button to open the folder in filelight for more details

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kpropertiesdialog.cpp:444
>  {
> -for (KPropertiesDialogPlugin *it : qAsConst(d->m_pageList)) {
> +foreach (KPropertiesDialogPlugin *it, d->m_pageList) {
>  if (auto *filePropsPlugin = qobject_cast(it)) {

We're trying to port our software //away// from using `foreach` and 
`Q_FOREACH`; not back to them! :) Don't change these.

> kpropertiesdialog.cpp:745
>  
> +static bool isFilelightInstalled()
> +{

All of this logic is unnecessary; instead use 
https://doc.qt.io/qt-5/qstandardpaths.html#findExecutable

> kpropertiesdialog.cpp:1118
> +if (isFilelightInstalled()) {
> +d->m_sizeDetailsButton = new QPushButton(i18n("Open in 
> Filelight"), d->m_frame);
> +
> d->m_sizeDetailsButton->setIcon(QIcon::fromTheme(QStringLiteral("filelight")));

Maybe "Explore in Filelight?" or "See usage with Filelight" If the user isn't 
familiar with what Filelight is, it might be unclear what you would want to 
open a folder in it.

> kpropertiesdialog.cpp:1409
> +QProcess *m_filelight = nullptr;
> +m_filelight->start(QStringLiteral("filelight"), QStringList() << 
> directory);
> +m_filelight->waitForFinished(); 

Use `KRun` to launch it, not `QProcess`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24932

To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D24931: Port KSSD internals from KSslError to QSslError

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24931

To: vkrause, aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24908: fix default shortcut detection

[Albert Astals Cid]

aacid added a comment.


  Can this be autotested?

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24908

To: sitter, dfaure
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24932: [WIP]: Add Button to open the folder in filelight for more details

[Shubham]

shubham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24932

To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

[Albert Astals Cid]

aacid added a comment.


  numid is something we want to fix, we have a test for it, so if someone feels 
like working, ki18n is waiting for you :)

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik, aacid
Cc: flherne, dfaure, aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, 
kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns

D24932: [WIP]: Add Button to open the folder in filelight for more details

[Shubham]

shubham created this revision.
shubham added reviewers: ngraham, Frameworks.
shubham added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
shubham requested review of this revision.

REVISION SUMMARY
  BUG:  408962
  
  Note: Does not compile on my machine due to system-specific issues (Should 
work ; )

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24932

AFFECTED FILES
  src/widgets/kpropertiesdialog.cpp
  src/widgets/kpropertiesdialog_p.h

To: shubham, ngraham, #frameworks
Cc: kde-frameworks-devel, #frameworks, LeGast00n, GB_2, michaelh, ngraham, bruns

D24902: K7Zip: Fix memory use in readAndDecodePackedStreams

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R243 KArchive

REVISION DETAIL
  https://phabricator.kde.org/D24902

To: aacid, vkrause
Cc: kde-frameworks-devel, apol, dfaure, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D22069: Localize long number strings

[Karl Ove Hufthammer]

huftis added a comment.


  In D22069#553556 , @huftis wrote:
  
  > In D22069#553527 , @huftis wrote:
  >
  > > For non-localised formatting of numbers, use QString::number() instead of 
QLocale::toString(), as detailed in 
https://api.kde.org/frameworks/ki18n/html/prg_guide.html#subs_notes.
  >
  >
  > I think I used the wrong link there. This one is more up to date and 
useful: 
https://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics
  
  
  According to https://bugs.kde.org/show_bug.cgi?id=413390, the **first** link 
is the most up to date one. So use `QString::number()` instead of 
`%1` (which doesn’t work anymore). Not as elegant, perhaps, but 
it has the added advantage that it doesn’t break string freeze.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik, aacid
Cc: flherne, dfaure, aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, 
kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns

D24892: Fix usage of the new deprecation macros for assignIconsToContextMenu

[Volker Krause]

vkrause added a comment.


  In D24892#552838 , @kossebau wrote:
  
  > Looks good. Perfect would be if you tested KIconThemes  with 
EXCLUDE_DEPRECATED_BEFORE_AND_AT set to hexnumber(5.64.0), to see if there is 
no internal usage still happening, like with autotests which might need to 
support such a build with KICONTHEMES_ENABLE_DEPRECATED_SINCE (ENABLE variant, 
as external to lib).
  
  
  Assuming I used this correctly (setting EXCLUDE_DEPRECATED_BEFORE_AND_AT to 
054000) this doesn't build independent of assignIconsToContextMenu, due to the 
Q_ENUM code generated for KIconLoader still referencing the deprecated 
FileSystem enum element?
  
  > In general, given even you missed this (both the build disabling of the 
implementation as well as testing the build with 
EXCLUDE_DEPRECATED_BEFORE_AND_AT, I asume), I wonder if the support for 
build-without-deprecated should not be removed again from KDE Frameworks 
(though not the ECM macro, it works and others might find it useful). KF 
contributors/builders might not really need it or gain from it before actually 
KF6 gets created, and things are fragile enough with the new deprecation macros 
even without that feature (think virtual methods & enums being accidentally 
wrapped by *_ENABLE_DEPRECATED_SINCE...
  
  It has just been added and I assume people still need to get used to it and 
we are still ironing out the last issues, so maybe give it a bit more time 
before pulling it out again right away :) It does have BC and maintenance 
challenges for sure, but IMHO that is ok as I don't really see it as something 
to use in production rather than as a tool to help with migrations to new major 
version.

INLINE COMMENTS

> kossebau wrote in kicontheme.h:292
> Is "// TODO KF6 remove" really needed BTW?
> 
> Personally I would be strict and for KF6 just dump any API deprecated in KF5 
> times.
> Do you think there will be deprecated API we should keep around even in KF6?
> Or should this be considered on case-by-case once KF6 is created?

I am unsure about that, therefore I'm opting for the safe approach :) It is 
IMHO possible some deprecate API will stay, e.g. if it got deprecated before 
having strict rules on porting away from such API or the porting impact turning 
out more complex than anticipated. I'm therefore only adding the KF6 todos in 
places where they could be executed immediately when disregarding BC.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D24892

To: vkrause, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24931: Port KSSD internals from KSslError to QSslError

[Volker Krause]

vkrause created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  The strings don't match all enum values exactly, as this tries to keep
  the same strings for the corresponding enums from KSslError as mapped
  in ktcpsocket.cpp.
  
  Mistakes to do this correctly (or the eventual move to QMetaEnum from
  QSslError) however are not dangerous, it will merely result in the user
  being asked to confirm ignoring the (now more precise) error again, we
  will not silently ignore errors we shouldn't be ignoring.

REPOSITORY
  R241 KIO

BRANCH
  next

REVISION DETAIL
  https://phabricator.kde.org/D24931

AFFECTED FILES
  src/core/ksslcertificatemanager.h
  src/kssld/kssld.cpp

To: vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 156 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/156/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Thu, 24 Oct 2019 17:12:47 +
 Build duration:
8 min 9 sec and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ba182f153729: Port (most of) KSslInfoDialog from 
KSslError to QSslError (authored by vkrause).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24703?vs=68619=68708

REVISION DETAIL
  https://phabricator.kde.org/D24703

AFFECTED FILES
  src/core/ksslerror_p.h
  src/widgets/ksslinfodialog.cpp
  src/widgets/ksslinfodialog.h

To: vkrause, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24316: Consider the usage of WebDAV methods sufficient for assuming WebDAV

[Méven Car]

meven added a comment.


  The new bug https://bugs.kde.org/show_bug.cgi?id=413117 mentions this as well 
:
  
  > kio-5.63 makes kdav-19.08.2 fail with HTTP error (400)
  > 
  > STEPS TO REPRODUCE
  >  Install the mentioned packages. Try to connect to a davical server via 
https.
  > 
  > RESULT
  >  HTTP error (400).
  > 
  > Works with kio-5.62.
  > 
  > Reverting commit 9713ea02e49eda11d72e1ac605417dac0dab8c37 

  >  "Consider the usage of WebDAV methods sufficient for assuming WebDAV" in 
kio-5.63 makes kdav work again.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24316

To: vkrause, dfaure
Cc: meven, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24909: [PC3/button] Elide text always

[Nathaniel Graham]

ngraham accepted this revision.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24909

To: davidedmundson, #plasma, apol, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

[Karl Ove Hufthammer]

huftis added a comment.


  In D22069#553527 , @huftis wrote:
  
  > For non-localised formatting of numbers, use QString::number() instead of 
QLocale::toString(), as detailed in 
https://api.kde.org/frameworks/ki18n/html/prg_guide.html#subs_notes.
  
  
  I think I used the wrong link there. This one is more up to date and useful: 
https://techbase.kde.org/Development/Tutorials/Localization/i18n_Semantics
  
  The relevant quote is:
  

By default, numbers supplied as arguments to i18n calls are formatted into 
localized form. If the number is supposed to be a numeric identifier instead, 
like a port number, use this tag to signal numeric-id environment.
i18nc("@info:progress",
  "Connecting to %1...", portNo);

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik, aacid
Cc: flherne, dfaure, aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, 
kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

[Ahmad Samir]

ahmadsamir added a dependent revision: D24929: [pop3 kioslave] Port KTcpSocket 
(deprecated) to QSslSocket.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24928

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

[Karl Ove Hufthammer]

huftis added a comment.


  In D22069#553374 , @flherne wrote:
  
  >  on IRC pointed out that this could affect telephone numbers.
  
  
  Telephone numbers are not numbers, and should never be represented internally 
as numbers. If they are, then that’s a bug, that will leads to all sorts of 
problems. For proper representation and presentation of telephone numbers, see 
RFC 3966 (https://tools.ietf.org/html/rfc3966) and ITU E.123 
(https://www.itu.int/rec/T-REC-E.123-200102-I/en).

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik, aacid
Cc: flherne, dfaure, aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, 
kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

[Ahmad Samir]

ahmadsamir updated this revision to Diff 68702.
ahmadsamir edited the summary of this revision.
ahmadsamir added a dependency: D24928: [TcpSlaveBase] port from KTcpSocket 
(deprecated) to QSslSocket.
ahmadsamir added a comment.


  Depends on D24928 

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24873?vs=68570=68702

BRANCH
  ahmad/kio_http-ktcpsocket (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24873

AFFECTED FILES
  src/ioslaves/http/http.cpp

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

[Ahmad Samir]

ahmadsamir added a dependent revision: D24873: [http kio slave] use QSslSocket 
instead of KTcpSocket (deprecated).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24928

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24928: [TcpSlaveBase] port from KTcpSocket (deprecated) to QSslSocket

[Ahmad Samir]

ahmadsamir created this revision.
ahmadsamir added reviewers: dfaure, vkrause.
Herald added a project: Frameworks.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Also add a method similar to KSslCipher::digestMethod() to TcpSlaveBase.

REPOSITORY
  R241 KIO

BRANCH
  ahmad/tcpslavebase (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24928

AFFECTED FILES
  src/core/tcpslavebase.cpp

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

[Karl Ove Hufthammer]

huftis added a comment.


  In D22069#553328 , @flherne wrote:
  
  > I'm afraid this was a breaking API change -- it changes the behaviour, and 
not all numbers are intended to have separators added in this way.
  >
  > See https://bugs.kde.org/show_bug.cgi?id=413390
  
  
  The breaking API change happened earlier. This commit *fixed* it. Localised 
number formatting *used* to work on earlier versions of KDE (which is what 
KF5/Plasma/… was called then), but broke with the switch from KLocale to 
Qlocale.
  
  > A similar pattern occurs three different times just in KDevelop, and I 
can't even see how to work around this without breaking translations.
  
  For non-localised formatting of numbers, use QString::number() instead of 
QLocale::toString(), as detailed in 
https://api.kde.org/frameworks/ki18n/html/prg_guide.html#subs_notes. Note that 
this is not KDE-specific; it’s true for all Qt applications (KF5 just had a bug 
which made the user’s locale not being used).

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik, aacid
Cc: flherne, dfaure, aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, 
kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

[Francis Herne]

flherne added a comment.


   on IRC pointed out that this could affect telephone numbers.
  
  Also: numeric IDs [I bet at least something prints PIDs this way].
  
  I don't think it makes sense to try and enumerate specific cases -- this 
needs a flag to determine whether localization is done, and at least for KF5 
the default must be "no" to avoid breaking compatibility.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik, aacid
Cc: flherne, dfaure, aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, 
kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

[Nathaniel Graham]

ngraham added a comment.


  Darn. :/
  
  Is the problem only with years, or with other kinds of numbers too? Maybe we 
need a "don't localize this number" flag.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik, aacid
Cc: flherne, dfaure, aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, 
kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns

D22069: Localize long number strings

[Francis Herne]

flherne added a comment.


  I'm afraid this was a breaking API change -- it changes the behaviour, and 
not all numbers are intended to have separators added in this way.
  
  See https://bugs.kde.org/show_bug.cgi?id=413390
  
  A similar pattern occurs three different times just in KDevelop, and I can't 
even see how to work around this without breaking translations.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D22069

To: ngraham, #localization, #frameworks, broulik, aacid
Cc: flherne, dfaure, aacid, huftis, safaalfulaij, mikeroyal, aspotashev, ilic, 
kde-frameworks-devel, broulik, LeGast00n, GB_2, michaelh, ngraham, bruns

D24898: Add KLocalizedString::untranslatedText

[Chusslove Illich]

ilic added a comment.


  An apparent need for this functionality was popping up from time to time, but 
somehow never got too serious. Probably because each time it would have been 
just a convenience, since the original text could have been transported to 
where it is needed next to the KLocalizedString objects themselves. Is it then 
worthy of adding more API? I don't know.
  
  However, if it is added, then there should exist also methods for retrieving 
the context and original plural strings.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D24898

To: aacid
Cc: apol, ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

[Chusslove Illich]

ilic added a comment.


  The idea was indeed to deprecate stripping of context, and not only the macro 
name, for the reason Alber provided.
  
  The apparent counterexample in kuitmarkup.cpp is seen only due to 
macro-within-macro call and the macro expansion order, which is a situation 
that does not (or did not at the time of writing) occur anywhere else through 
KDE projects. But it too can be reformulated easily to the cleaner variant.
  
  However, as I recall, even though KLocalizedString objects do deferred 
translation, I18N* macros were not deprecated alltogether in order to still 
allow for well-defined static initializers.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D24884

To: mlaurent, dfaure, ilic
Cc: aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24909: [PC3/button] Elide text always

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24909

To: davidedmundson, #plasma, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24898: Add KLocalizedString::untranslatedText

[Aleix Pol Gonzalez]

apol added a comment.


  LGTM

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D24898

To: aacid
Cc: apol, ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24641: Collect more information from version control systems

[Harald Sitter]

sitter added a comment.


  Hm, how about separate functions though? With a single stat any given build 
still needs N process forks even when they only want 1 value.
  
  In D24641#548394 , @thomasfischer 
wrote:
  
  > To clarify `ECM_SOURCE_VERSION_CONTROL_COMMIT_COUNT`: it counts the number 
of commits in direct line of succession from the repository's initialization to 
the current commit. It does not include commits in other branches. Basically 
the number of commits listed in a plain `git log`. The commit count gives a 
quick indication of the progress of a repository (or branch) without requiring 
to look up the repo's commit messages or hashes.
  
  
  I understand. This is super heavy though. I have just run it on all clones I 
have on this PC and for some repos that takes upwards of half a second to 
complete... on an SSD, so I also ran a quick check on our CI servers, which use 
HDDs and there it takes at least half a second with some repos (e.g. kdevelop) 
going up to 26 seconds (uncached)! I wouldn't mind terribly if the various 
things got split into their own functions (ecm_source_version_control_revison, 
ecm_source_version_control_branch, ecm_source_version_control_commit_count... 
or some names like that) but even then I have to question the use case behind 
the commit count information. So, what is the use case? What do you do with 
this information? It occurs to me that if you know the hash you could look up 
the commit count of that hash should you need it, but I struggle to imagine a 
scenario where that number is relevant.

INLINE COMMENTS

> ECMSourceVersionControl.cmake:70
> +message(STATUS "Source directory '${CMAKE_SOURCE_DIR}' is under 
> version control by Git.")
> +find_program(GIT_EXECUTABLE
> +NAMES git.bat git # for Windows, 'git.bat' must be found before 
> 'git'

I think you are leaking this variable into the parent scope. I am not super 
sure how to deal with this but I think I've seen `_`prefixes, or you use a 
function and explicitly forward into the PARENT_SCOPE 
(https://cmake.org/cmake/help/v3.0/command/set.html).

Alternatively with a multi-function approach I'd probably just make it 
ECM_SOURCE_VERSION_CONTROL_EXECUTABLE so it only needs finding on the first 
call.

REPOSITORY
  R240 Extra CMake Modules

REVISION DETAIL
  https://phabricator.kde.org/D24641

To: thomasfischer, sitter, kossebau
Cc: kde-frameworks-devel, kde-buildsystem, LeGast00n, GB_2, bencreasy, 
michaelh, ngraham, bruns

D24895: [RFC] Drop implicit size from PC buttons

[David Edmundson]

davidedmundson added a comment.


  Having had a play, setting implicitWidth to unit.gridUnit * 1.6 
  and keeping height as-is, makes the most things pass.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24895

To: nicolasfella, #plasma, mart, #vdg
Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, mart, LeGast00n, 
GB_2, michaelh, bruns

D24909: [PC3/button] Elide text always

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  We always want the label to have the width managed by the layout to fill
  all available space.

TEST PLAN
  In tests/components/button3.qml the test
  
  "long text but constrained, should be 150px and elided" now is correctly
  elided rather than the text spewing past the end of the button. The text
  does not overlap the icon.

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24909

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml

To: davidedmundson, #plasma
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24895: [RFC] Drop implicit size from PC buttons

[David Edmundson]

davidedmundson added a comment.


  Please run plasma tests/components/button.qml  and 
tests/components/button3.qml  it explains all goals visually (and shows some 
other PC3 issues)
  
  This patch fails "button with or without icon and textfield" should all have 
the same height.
  
  I understand why you want to change the width, we used to have a special 
property on the PC2 version that allowed for what you want.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24895

To: nicolasfella, #plasma, mart, #vdg
Cc: davidedmundson, broulik, ngraham, kde-frameworks-devel, mart, LeGast00n, 
GB_2, michaelh, bruns

D24908: fix default shortcut detection

[Harald Sitter]

sitter added a reviewer: dfaure.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24908

To: sitter, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24908: fix default shortcut detection

[Harald Sitter]

sitter edited the test plan for this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D24908

To: sitter
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24908: fix default shortcut detection

[Harald Sitter]

sitter created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.

REVISION SUMMARY
  When the default shortcut is empty the UI string "None" is used to
  indicate that. Alas, when mapping QKeySequences to the UI label we have to
  rely on QKS::toString being equal/notequal to the text in the label and
  that is not the case since an empty QKS will be an empty string, but
  our display string is "None".
  
  This resulted in the "custom" sequence detection incorrectly thinking all
  shortcuts without a default are customized when in fact they aren't, the
  strings are just different because we express it as "None" and QKS as "".
  To mitigate this we'll simply ensure empty sequences are serialized to our
  None reference string instead of an empty string.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24908

AFFECTED FILES
  src/kshortcuteditwidget.cpp
  src/kshortcutsdialog_p.h

To: sitter
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24895: [RFC] Drop implicit size from PC buttons

[Kai Uwe Broulik]

broulik added a comment.


  Perhaps only when it has no text so icon-only can become rightfully square?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24895

To: nicolasfella, #plasma, mart, #vdg
Cc: broulik, ngraham, kde-frameworks-devel, mart, LeGast00n, GB_2, michaelh, 
bruns

D24902: K7Zip: Fix memory use in readAndDecodePackedStreams

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> k7zip.cpp:1678
>  
>  QByteArray inflated;
>  for (const QByteArray& data : qAsConst(inflatedDatas)) {

This makes me realize that there could be an inflated.reserve(unpackSize) here, 
then, to avoid reallocations.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24902

To: aacid, vkrause
Cc: kde-frameworks-devel, apol, dfaure, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24902: K7Zip: Fix memory use in readAndDecodePackedStreams

[Volker Krause]

vkrause accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24902

To: aacid, vkrause
Cc: kde-frameworks-devel, apol, dfaure, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24873: [http kio slave] use QSslSocket instead of KTcpSocket (deprecated)

[Ahmad Samir]

ahmadsamir added a comment.


  In D24873#552795 , @vkrause wrote:
  
  > In D24873#552697 , @ahmadsamir 
wrote:
  >
  > > In D24873#552410 , @vkrause 
wrote:
  > >
  > > > This will compile, but it will only work correctly once TCPSlaveBase 
has been ported to QSslSocket too.
  > >
  > >
  > > If you say so.
  >
  >
  > Well, socket() returns the KTcpSocket that TCPSlaveBase created, so this 
cast will always return a nullptr.
  
  
  I wasn't doubting the validity of what you said, just I didn't see it, until 
now :)
  
  >> Anyway, I've started porting TcpSlaveBase. :)
  > 
  > Awesome! There seems to be only one other place that also assumes socket() 
returns a KTcpSocket 
(https://lxr.kde.org/source/kde/pim/kdepim-runtime/kioslave/pop3/pop3.cpp#0625).
  
  Yep.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D24873

To: ahmadsamir, dfaure, vkrause
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24703: Port (most of) KSslInfoDialog from KSslError to QSslError

[Albert Astals Cid]

aacid accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  D24703

REVISION DETAIL
  https://phabricator.kde.org/D24703

To: vkrause, aacid
Cc: aacid, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

[Albert Astals Cid]

aacid added a comment.


  https://phabricator.kde.org/D24898

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D24884

To: mlaurent, dfaure, ilic
Cc: aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24895: [RFC] Drop implicit size from PC buttons

[Nicolas Fella]

nicolasfella updated this revision to Diff 68629.
nicolasfella added a comment.


  - Actually remove

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24895?vs=68628=68629

BRANCH
  mo

REVISION DETAIL
  https://phabricator.kde.org/D24895

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml

To: nicolasfella, #plasma, mart
Cc: kde-frameworks-devel, mart, LeGast00n, GB_2, michaelh, ngraham, bruns

D24884: I18N_NOOP2 was deprecated but we can't replace by I18NC_NOOP as it expends it as 2 elements (context + text)

[Albert Astals Cid]

aacid added a comment.


  Discarding the context is bad practice, if you discard it, it's very easy you 
will make a mistake when you try to i18n the text again and not pass the 
correct context.
  
  I'm against bringing any I18NC_NOOP variant that strips the context.
  
  This would also break since I18NC_NOOP_STRIP is unknown to the extraction 
scripts so nothing would be extracted for translation.
  
  Ideally we would even deprecated I18NC_NOOP too, we now have KLocalizedString 
that is a string-to-be-localizaed but that hasn't been yet, so that fixes the 
same problem that _NOOP does, that you're translating too early.
  
  Unfortunately for this case it seems that you also need the untranslated text 
and KLocalizedString doesn't have a getter for that. I'll propose that API.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D24884

To: mlaurent, dfaure, ilic
Cc: aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24898: Add KLocalizedString::untranslatedText

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  returns the untraslated string of the KLocalizedString

REPOSITORY
  R249 KI18n

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24898

AFFECTED FILES
  autotests/klocalizedstringtest.cpp
  autotests/klocalizedstringtest.h
  src/klocalizedstring.cpp
  src/klocalizedstring.h

To: aacid
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24895: [RFC] Drop implicit size from PC buttons

[Nathaniel Graham]

ngraham added a reviewer: VDG.
ngraham added a comment.


  Compatibility with the wide style in PC1 I think? I've always thought this 
was kind of weird as well.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24895

To: nicolasfella, #plasma, mart, #vdg
Cc: ngraham, kde-frameworks-devel, mart, LeGast00n, GB_2, michaelh, bruns

D24895: [RFC] Drop implicit size from PC buttons

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  It makes buttons in apps using plasma as a QQC2 style weirdly wide.
  
  A comment suggests that this is intentional for compatibility reasons. @mart 
can you please expand on why this was necessary and whether it still is?
  
  A workaround for applications for this issue would be to set an explicit 
implicit size (heh), but doing that /everywhere/ souds wrong to me

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  mo

REVISION DETAIL
  https://phabricator.kde.org/D24895

AFFECTED FILES
  src/declarativeimports/plasmacomponents3/Button.qml

To: nicolasfella, #plasma, mart
Cc: kde-frameworks-devel, mart, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

[Nathaniel Graham]

ngraham added a comment.


  Needs a rebase on master. It doesn't apply for me.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24902: K7Zip: Fix memory use in readAndDecodePackedStreams

[Albert Astals Cid]

aacid created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
aacid requested review of this revision.

REVISION SUMMARY
  oss-fuzz has created a file in which inflated size was smaller than 
unpackSize and thus crc32 was using wrong memory
  oss-fuzz warns about uninitialized because QByteArray probably allocates a 
bit more than asked, but this could very well be a out of bounds memory read

REPOSITORY
  R243 KArchive

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24902

AFFECTED FILES
  src/k7zip.cpp

To: aacid
Cc: kde-frameworks-devel, apol, dfaure, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove added a comment.


  In D24593#551591 , @ngraham wrote:
  
  > Is this ready for formal review now or are you still tweaking and/or 
soliciting comments?
  
  
  Ready for review :-)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24593

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24898: Add KLocalizedString::untranslatedText

[Albert Astals Cid]

aacid added a subscriber: ilic.

REPOSITORY
  R249 KI18n

REVISION DETAIL
  https://phabricator.kde.org/D24898

To: aacid
Cc: ilic, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24593: Modified breeze shadows

[Niccolò Venerandi]

niccolove updated this revision to Diff 68626.
niccolove added a comment.


  Made missing shadow on corners less noticeable on widgets shadows

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24593?vs=67853=68626

BRANCH
  breeze-shadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24593

AFFECTED FILES
  src/desktoptheme/breeze/dialogs/background.svg
  src/desktoptheme/breeze/widgets/panel-background.svg

To: niccolove, #vdg
Cc: Luwx, filipf, ngraham, davidedmundson, kde-frameworks-devel, LeGast00n, 
GB_2, michaelh, bruns

D24895: [RFC] Drop implicit size from PC buttons

[Nicolas Fella]

nicolasfella edited the test plan for this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D24895

To: nicolasfella, #plasma, mart
Cc: kde-frameworks-devel, mart, LeGast00n, GB_2, michaelh, ngraham, bruns