D25517: Add an option to extract binary data and add front cover property

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in extractionresult.h:61
> Binary is **how**, not **what**.

Do you have a suggestion for a better name? I tried to be as generic as 
possible. It could be named more specifically ExtractImages, since this is what 
it will be primarily used for

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25517

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25516: Remove unrequired private declarations for taglibextractor

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in taglibextractor.cpp:105
> This puts `readGenericProperties(...)` with external linkage in the global 
> namespace.
> 
> Put the private helpers in an anonymous namespace (and also include 
> `extractAudioProperties(...)` in it).

Urgh, that was the plan actually. I could swear I've done that.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25516

To: astippich, #baloo, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25516: Remove unrequired private declarations for taglibextractor

[Alexander Stippich]

astippich updated this revision to Diff 70398.
astippich added a comment.


  - put all helper functions into anonymous namespace

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25516?vs=70283&id=70398

BRANCH
  cleanupTagLib

REVISION DETAIL
  https://phabricator.kde.org/D25516

AFFECTED FILES
  src/extractors/taglibextractor.cpp
  src/extractors/taglibextractor.h

To: astippich, #baloo, bruns, ngraham, mgallien
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25515: Only extract lyrics when the plain text flag is set

[Alexander Stippich]

astippich added a comment.


  For baloo-widgets, the display of the lyrics tag is disabled anyways. 
Displaying a large chunk of text does not really look good in the information 
panel...

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D25515

To: astippich, #baloo, bruns, mgallien, ngraham
Cc: kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, fbampaloukas, GB_2, 
domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D25530: Sonnet: Add locales that are missing in QLocale

[Waqar Ahmed]

waqar updated this revision to Diff 70399.
waqar added a comment.


  Add test for iso code to language names

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25530?vs=70310&id=70399

BRANCH
  add-missing-locales (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25530

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/test_languageNames.cpp
  src/core/loader.cpp

To: waqar
Cc: aspotashev, aacid, yurchor, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.


  I think that is nicer, not yet-an-other global hash ;=)
  
  Thanks!

REPOSITORY
  R39 KTextEditor

BRANCH
  verify-katefiletypes

REVISION DETAIL
  https://phabricator.kde.org/D25390

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

KDE CI: Frameworks » ktexteditor » kf5-qt5 FreeBSDQt5.13 - Build # 151 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20FreeBSDQt5.13/151/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 27 Nov 2019 08:58:59 +
 Build duration:
7 min 33 sec and counting
   JUnit Tests
  Name: projectroot Failed: 0 test(s), Passed: 62 test(s), Skipped: 0 test(s), Total: 62 test(s)Name: projectroot.autotests.src Failed: 1 test(s), Passed: 4 test(s), Skipped: 0 test(s), Total: 5 test(s)Failed: projectroot.autotests.src.vimode.vimode_keys

D25390: KateModeManager::updateFileType(): validate modes and reload menu of the status bar

[Christoph Cullmann]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:cee9d9642735: KateModeManager::updateFileType(): validate 
modes and reload menu of the status… (authored by nibags, committed by 
cullmann).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25390?vs=70392&id=70400

REVISION DETAIL
  https://phabricator.kde.org/D25390

AFFECTED FILES
  src/mode/katemodemanager.cpp
  src/mode/katemodemenu.cpp
  src/mode/katemodemenulist.cpp
  src/mode/katemodemenulist.h
  src/syntax/katehighlightmenu.cpp
  src/view/katestatusbar.cpp
  src/view/katestatusbar.h

To: nibags, #ktexteditor, cullmann, dhaumann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, 
ngraham, bruns, demsking, cullmann, sars, dhaumann

D25117: file ioslave: stop copying as soon as the ioslave is killed

[Méven Car]

meven updated this revision to Diff 70401.
meven added a comment.


  Let windows code path not being changed, add a todo for windows support

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25117?vs=70102&id=70401

BRANCH
  arcpatch-D25117

REVISION DETAIL
  https://phabricator.kde.org/D25117

AFFECTED FILES
  autotests/jobtest.cpp
  src/core/filecopyjob.cpp
  src/ioslaves/file/file_unix.cpp

To: meven, #frameworks, dfaure, ngraham, apol
Cc: apol, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24657: Add support for _GTK_FRAME_EXTENTS

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R278 KWindowSystem

BRANCH
  gtk-frame-extents

REVISION DETAIL
  https://phabricator.kde.org/D24657

To: zzag, #kwin, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

kde-frameworks-devel@kde.org

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kurllabel.h:281
>   * Emitted when the mouse has passed over the label.
> + * @deprecated Since 5.65, use leftUrl(const QString &url);
>   */

Wrong comment?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D25561

To: mlaurent, dfaure, kossebau
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

kde-frameworks-devel@kde.org

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Looks correct from deprecation-markup POV. Did you do a test build with 
EXCLUDE_DEPRECATED_BEFORE_AND_AT=5.65.0, to check if any tests or examples 
still use the deprecated signals and need some additions of #if 
KWIDGETSADDONS_ENABLE_DEPRECATED_SINCE(5, 65) in places?
  
  When it comes to deprecated signals, seems those overloads have been present 
since introduction of KUrlLabel. Not sure about the usefulness of passing the 
url as argument with any signals, given that the url is a static property of 
the label, only set via the setter setUrl().
  Have you checked how the respective signals are used? Are there similar 
classes, what signals do they have?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D25561

To: mlaurent, dfaure, kossebau
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25545: Rename signal for avoiding overload signal

[Friedrich W. H. Kossebau]

kossebau added inline comments.

INLINE COMMENTS

> Doxyfile.local:4
> +# define so that deprecated API is not skipped
> +PREDEFINED += \
> +"KCOREADDONS_ENABLE_DEPRECATED_SINCE(x, y)=1" \

The predefined macros we want to tell doxygen about in the case of kapidox 
(being run in a non-build checkout, so without the generated headers/sources) 
are both the variants of the 3 macros for SONNETCORE and SONNETUI, not 
KCOREADDONS :)

In case you wonder about the differences for instructions to ecm_add_qch, 
kapidox processes the whole sources with both libs into one documentation 
module, while the ecm macro is used to create two separate QCH files, one per 
library.
(and ecm_add_qch also is run in a build, so with the generated headers/sources 
available, cmp. also the INCLUDE_DIRS arg. Sadly doxygen does not digest the 
`__deprecated(text)__` attribute properly, so we need to help it with the very 
warning deprecation macro (*_DEPRECATED_VERSION) and have it resolve it itself 
to a void string instead of the real content. At least the *_DEPRECATED_SINCE 
are properly done, so no assistance needed there)

> CMakeLists.txt:36
> +DEPRECATED_BASE_VERSION 0
> +DEPRECATION_VERSIONS 5.65
> +EXCLUDE_DEPRECATED_BEFORE_AND_AT ${EXCLUDE_DEPRECATED_BEFORE_AND_AT}

Given there is nothing yet deprecated in the core lib, you want for now to not 
pass any DEPRECATION_VERSIONS args (to avoid the respective generated 
preprocessor code).
You can still prepare the argument by just making the line a comment, like

  # DEPRECATION_VERSIONS 5.x

> dialog.h:110
> + * The dialog won't be closed if you setBuffer() in slot connected to 
> this signal
> + * @Since 5.65
> + * Also emitted after stop() signal

The @since would ideally also be move to the end of the docs.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25545

To: mlaurent, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25562: Add some friendly "report bugs here" links

[Dan Leinir Turthra Jensen]

leinir created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
leinir requested review of this revision.

REVISION SUMMARY
  Add a link to the FeedbackOverlay's "report-a-bug-please" bit
  
  Also add the link to EntryDetails (and remove some debug items)
  
  This is in response to a comment i made on D25189 
 in which i said there
  were a few places i would like to do this.

REPOSITORY
  R304 KNewStuff

BRANCH
  helpful-linking-for-bugs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25562

AFFECTED FILES
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/private/entrygriddelegates/FeedbackOverlay.qml

To: leinir
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25562: Add some friendly "report bugs here" links

[Dan Leinir Turthra Jensen]

leinir added reviewers: Frameworks, KNewStuff, ngraham.

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25562

To: leinir, #frameworks, #knewstuff, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25552: Deprecate top-level UserIcon method, no longer used

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R302 KIconThemes

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25552

To: vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25311: Add KColumnHeadersProxyModel

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 70405.
ahiemstra added a comment.


  - Do not use nested Private class

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25311?vs=70359&id=70405

BRANCH
  columnheadersmodel

REVISION DETAIL
  https://phabricator.kde.org/D25311

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kcolumnheadersmodeltest.cpp
  src/core/CMakeLists.txt
  src/core/kcolumnheadersmodel.cpp
  src/core/kcolumnheadersmodel.h
  src/qml/plugin.cpp
  tests/qml/columnheaders.qml

To: ahiemstra
Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

kde-frameworks-devel@kde.org

[Laurent Montel]

mlaurent marked an inline comment as done.
mlaurent added a comment.


  There is not autotests/test which use kurllabel.
  we have some apps as connect(urlLabel, qOverload(&KUrlLabel::leftClickedUrl), this, &SummaryWidget::selectFolder); in kmail.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D25561

To: mlaurent, dfaure, kossebau
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

kde-frameworks-devel@kde.org

[Laurent Montel]

mlaurent updated this revision to Diff 70406.
mlaurent added a comment.


  Fix comment

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25561?vs=70395&id=70406

BRANCH
  remove_overload_signal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25561

AFFECTED FILES
  src/CMakeLists.txt
  src/kurllabel.cpp
  src/kurllabel.h

To: mlaurent, dfaure, kossebau
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

[Ahmad Samir]

ahmadsamir updated this revision to Diff 70407.
ahmadsamir added a comment.


  Per dfaure's recommendation, change createSystemBookmark 2nd and 3rd params 
to take a const char * (since this is the translation context which will be 
dropped) and a QByteArray, respectively.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24349?vs=70379&id=70407

BRANCH
  arcpatch-D24349 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24349

AFFECTED FILES
  src/core/forwardingslavebase.cpp
  src/core/kremoteencoding.cpp
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/filewidgets/kencodingfiledialog.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/ioslaves/ftp/CMakeLists.txt
  src/ioslaves/ftp/ftp.cpp
  src/kcms/kio/kcookiespolicies.cpp
  src/kcms/kio/smbrodlg.cpp
  src/kioexec/main.cpp
  src/kpasswdserver/autotests/CMakeLists.txt
  src/kpasswdserver/autotests/kpasswdservertest.cpp

To: ahmadsamir, dfaure, #frameworks
Cc: yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25311: Add KColumnHeadersProxyModel

[Friedrich W. H. Kossebau]

kossebau added a comment.


  Two more nitpicks while this has my attention (sadly no time/idea to comment 
on the general usefulness) :)

INLINE COMMENTS

> kcolumnheadersmodel.h:57
> +void setSourceModel(QAbstractItemModel *newSourceModel);
> +Q_SIGNAL void sourceModelChanged();
> +

For consistency I would prefer having a full Q_SIGNALS section:

  Q_SIGNALS:
  void sourceModelChanged();

That matches the usual pattern and helps when reading raw headers to learn 
about API of classes.

> kcolumnheadersmodel.h:60
> +private:
> +const std::unique_ptr d;
> +};

Why not QScopedPointer (for consistency in KF code)? Is that one going to be 
deprecated in favour of std::unique_ptr?

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25311

To: ahiemstra
Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25563: Remove -std=c++0x flag and duplicated -Wall flag

[Friedrich W. H. Kossebau]

kossebau created this revision.
kossebau added reviewers: Frameworks, apol, mart.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
kossebau requested review of this revision.

REVISION SUMMARY
  -Wall is set by KDECompilerSettings (via KDEFrameworkCompilerSettings)

REPOSITORY
  R290 KPackage

BRANCH
  removeoldstd

REVISION DETAIL
  https://phabricator.kde.org/D25563

AFFECTED FILES
  CMakeLists.txt

To: kossebau, #frameworks, apol, mart
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25563: Remove -std=c++0x flag and duplicated -Wall flag

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R290 KPackage

BRANCH
  removeoldstd

REVISION DETAIL
  https://phabricator.kde.org/D25563

To: kossebau, #frameworks, apol, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25564: Fix conflicts of shortcuts

[Yunhe Guo]

guoyunhe added a reviewer: Frameworks.

REPOSITORY
  R480 Kipi Plugins

REVISION DETAIL
  https://phabricator.kde.org/D25564

To: guoyunhe, #frameworks

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  arcpatch-D24349 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24349

To: ahmadsamir, dfaure, #frameworks
Cc: yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25545: Rename signal for avoiding overload signal

[Laurent Montel]

mlaurent updated this revision to Diff 70410.
mlaurent added a comment.


  Fix some errors

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25545?vs=70394&id=70410

BRANCH
  deprecated_overload_signal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25545

AFFECTED FILES
  CMakeLists.txt
  docs/Doxyfile.local
  src/core/CMakeLists.txt
  src/ui/CMakeLists.txt
  src/ui/dialog.cpp
  src/ui/dialog.h

To: mlaurent, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25563: Remove -std=c++0x flag and duplicated -Wall flag

[Friedrich W. H. Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R290:d6a6c210b0d1: Remove -std=c++0x flag and duplicated -Wall 
flag (authored by kossebau).

REPOSITORY
  R290 KPackage

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25563?vs=70408&id=70412

REVISION DETAIL
  https://phabricator.kde.org/D25563

AFFECTED FILES
  CMakeLists.txt

To: kossebau, #frameworks, apol, mart, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwindowsystem » kf5-qt5 FreeBSDQt5.13 - Build # 39 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20FreeBSDQt5.13/39/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 27 Nov 2019 12:10:50 +
 Build duration:
3 min 27 sec and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_netrootinfotestwm

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.12 - Build # 72 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.12/72/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 27 Nov 2019 12:10:49 +
 Build duration:
4 min 52 sec and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.65.0.xmllogs/KF5WindowSystem/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7198/9615)55%
(3471/6363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3034/3164)51%
(1263/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)60%
(820/1374)47%
(301/644)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3337/4719)59%
(1904/3209)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

KDE CI: Frameworks » kwindowsystem » kf5-qt5 SUSEQt5.13 - Build # 44 - Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwindowsystem/job/kf5-qt5%20SUSEQt5.13/44/
 Project:
kf5-qt5 SUSEQt5.13
 Date of build:
Wed, 27 Nov 2019 12:10:49 +
 Build duration:
5 min 13 sec and counting
   BUILD ARTIFACTS
  acc/KF5WindowSystem-5.65.0.xmllogs/KF5WindowSystem/5.65.0/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 1 test(s), Passed: 12 test(s), Skipped: 0 test(s), Total: 13 test(s)Failed: projectroot.autotests.kwindowsystem_netrootinfotestwm
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report67%
(4/6)80%
(43/54)80%
(43/54)75%
(7193/9615)55%
(3469/6363)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests88%
(15/17)88%
(15/17)96%
(3030/3164)51%
(1260/2458)autotests.helper100%
(1/1)100%
(1/1)70%
(7/10)50%
(3/6)src92%
(12/13)92%
(12/13)60%
(819/1374)47%
(302/644)src.platforms.wayland0%
(0/2)0%
(0/2)0%
(0/70)100%
(0/0)src.platforms.xcb94%
(15/16)94%
(15/16)71%
(3337/4719)59%
(1904/3209)tests0%
(0/5)0%
(0/5)0%
(0/278)0%
(0/46)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/36/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 27 Nov 2019 12:12:29 +
 Build duration:
8 min 50 sec and counting
   CONSOLE OUTPUT
  [...truncated 167 lines...][2019-11-27T12:21:08.754Z] -- Detecting CXX compile features[2019-11-27T12:21:08.754Z] -- Detecting CXX compile features - done[2019-11-27T12:21:08.754Z] -- [2019-11-27T12:21:08.754Z] [2019-11-27T12:21:08.754Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Frameworks/kpackage/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for KPackage.[2019-11-27T12:21:08.754Z] -- Could not set up the appstream test. appstreamcli is missing.[2019-11-27T12:21:08.754Z] -- Looking for __GLIBC__[2019-11-27T12:21:08.754Z] -- Looking for __GLIBC__ - not found[2019-11-27T12:21:08.754Z] -- Performing Test _OFFT_IS_64BIT[2019-11-27T12:21:09.011Z] -- Performing Test _OFFT_IS_64BIT - Success[2019-11-27T12:21:09.011Z] -- Performing Test HAVE_DATE_TIME[2019-11-27T12:21:09.011Z] -- Performing Test HAVE_DATE_TIME - Success[2019-11-27T12:21:09.011Z] -- Found Gettext: /usr/local/bin/msgmerge (found version "0.20.1") [2019-11-27T12:21:09.011Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Frameworks/kpackage/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for KPackage.[2019-11-27T12:21:09.011Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-11-27T12:21:09.270Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-11-27T12:21:09.270Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-11-27T12:21:09.270Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-11-27T12:21:09.270Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-11-27T12:21:09.270Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-11-27T12:21:09.529Z] -- Found Doxygen: /usr/local/bin/doxygen (found suitable version "1.8.15", minimum required is "1.8.13") found components:  doxygen dot [2019-11-27T12:21:09.791Z] -- Found QHelpGenerator executable: /usr/local/lib/qt5/bin/qhelpgenerator[2019-11-27T12:21:10.050Z] -- The following features have been enabled:[2019-11-27T12:21:10.050Z] [2019-11-27T12:21:10.050Z]  * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)[2019-11-27T12:21:10.050Z] [2019-11-27T12:21:10.050Z] -- The following OPTIONAL packages have been found:[2019-11-27T12:21:10.050Z] [2019-11-27T12:21:10.050Z]  * KF5DocTools (required version >= 5.64.0), Tools to generate documentation[2019-11-27T12:21:10.050Z] [2019-11-27T12:21:10.050Z] -- The following REQUIRED packages have been found:[2019-11-27T12:21:10.050Z] [2019-11-27T12:21:10.050Z]  * Qt5DBus[2019-11-27T12:21:10.050Z]  * Qt5 (required version >= 5.11.0)[2019-11-27T12:21:10.050Z]  * KF5Archive (required version >= 5.64.0)[2019-11-27T12:21:10.050Z]  * Gettext[2019-11-27T12:21:10.050Z]  * KF5I18n (required version >= 5.64.0)[2019-11-27T12:21:10.050Z]  * KF5CoreAddons (required version >= 5.64.0)[2019-11-27T12:21:10.050Z]  * ECM (required version >= 1.6.0), Extra CMake Modules., [2019-11-27T12:21:10.050Z]  * Doxygen (required version >= 1.8.13)[2019-11-27T12:21:10.050Z]Needed for API dox QCH file generation[2019-11-27T12:21:10.050Z]  * QHelpGenerator, Part of Qt5 tools[2019-11-27T12:21:10.050Z]Needed for API dox QCH file generation[2019-11-27T12:21:10.050Z]  * Qt5Core[2019-11-27T12:21:10.050Z]  * Qt5Test (required version >= 5.11.0)[2019-11-27T12:21:10.050Z]Required for tests[2019-11-27T12:21:10.050Z] [2019-11-27T12:21:10.050Z] -- Configuring done[2019-11-27T12:21:10.050Z] CMake Warning (dev) in src/kpackage/CMakeLists.txt:[2019-11-27T12:21:10.050Z]   AUTOMOC: CMAKE_AUTOMOC_RELAXED_MODE is deprecated an will be removed in the[2019-11-27T12:21:10.050Z]   future.  Consider disabling it and converting the target KF5Package to[2019-11-27T12:21:10.050Z]   regular mode.[2019-11-27T12:21:10.050Z] This warning is for project developers.  Use -Wno-dev to suppress it.[2019-11-27T12:21:10.050Z] [2019-11-27T12:21:10.050Z] -- Generating done[2019-11-27T12:21:10.050Z] -- Build files have been written to: /usr/home/jenkins/workspace/Frameworks/kpackage/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-11-27T12:21:15.369Z] + python3 -u ci-tooling/helpers/compile-build.py --product Frameworks --project kpackage --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2019-11-27T12:21:15.628Z] Scanning dependencies of target KF5CoreAddons_QCH[2019-11-27T12:21:15.628Z] Scanning dependencies of target KF5Package_autogen[2019-11-27T12:21:15.628Z] Scanning dependencies of target testpackage-rcc[2019-11-27T12:21:15.628Z] Scanning dependencies of target docs-kpackagetool-kpackagetool5-1[2019-11-27T12:21:15.628Z] Scanning dependencies of

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 35 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/35/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 27 Nov 2019 12:11:25 +
 Build duration:
9 min 29 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 14 test(s), Passed: 28 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testRemoteAccessFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellStableFailed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D24349: More fixes to compile without implicit conversion from ASCII/ByteArray

[Ahmad Samir]

This revision was automatically updated to reflect the committed changes.
ahmadsamir marked an inline comment as done.
Closed by commit R241:54ccb1ac4883: More fixes to compile without implicit 
conversion from ASCII/ByteArray (authored by ahmadsamir).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24349?vs=70407&id=70424

REVISION DETAIL
  https://phabricator.kde.org/D24349

AFFECTED FILES
  src/core/forwardingslavebase.cpp
  src/core/kremoteencoding.cpp
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/filewidgets/kencodingfiledialog.cpp
  src/filewidgets/kfileplacesitem.cpp
  src/filewidgets/kfileplacesitem_p.h
  src/filewidgets/kfileplacesmodel.cpp
  src/ioslaves/ftp/CMakeLists.txt
  src/ioslaves/ftp/ftp.cpp
  src/kcms/kio/kcookiespolicies.cpp
  src/kcms/kio/smbrodlg.cpp
  src/kioexec/main.cpp
  src/kpasswdserver/autotests/CMakeLists.txt
  src/kpasswdserver/autotests/kpasswdservertest.cpp

To: ahmadsamir, dfaure, #frameworks
Cc: yurchor, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23745: [server] Make double-buffered properties in xdg-shell double-buffered

[Vlad Zahorodnii]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R127:d0b3eab864a2: [server] Make double-buffered properties in 
xdg-shell double-buffered (authored by zzag).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23745?vs=65603&id=70425#toc

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23745?vs=65603&id=70425

REVISION DETAIL
  https://phabricator.kde.org/D23745

AFFECTED FILES
  autotests/client/test_xdg_shell_stable.cpp
  autotests/client/test_xdg_shell_v6.cpp
  src/server/CMakeLists.txt
  src/server/generic_shell_surface_p.h
  src/server/shell_interface.cpp
  src/server/surface_interface.cpp
  src/server/surface_interface.h
  src/server/surface_interface_p.h
  src/server/surfacerole.cpp
  src/server/surfacerole_p.h
  src/server/xdgshell_interface.cpp
  src/server/xdgshell_interface.h
  src/server/xdgshell_interface_p.h
  src/server/xdgshell_stable_interface.cpp
  src/server/xdgshell_v5_interface.cpp
  src/server/xdgshell_v6_interface.cpp

To: zzag, #kwin
Cc: davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, 
bruns

D25546: Deprecate KRecursiveFilterProxyModel

[David Redondo]

davidre updated this revision to Diff 70426.
davidre marked 4 inline comments as done.
davidre added a comment.


  address comments

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25546?vs=70348&id=70426

BRANCH
  deprecate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25546

AFFECTED FILES
  src/core/CMakeLists.txt
  src/core/krecursivefilterproxymodel.cpp
  src/core/krecursivefilterproxymodel.h

To: davidre, kossebau, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, davidre, GB_2, michaelh, ahmadsamir, 
ngraham, bruns, kpiwowarski, asturmlechner, cfeck, cullmann, vkrause, 
cordlandwehr, knauss, dfaure

KDE CI: Frameworks » kio » kf5-qt5 FreeBSDQt5.13 - Build # 207 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kio/job/kf5-qt5%20FreeBSDQt5.13/207/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 27 Nov 2019 12:32:15 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: projectroot Failed: 3 test(s), Passed: 49 test(s), Skipped: 0 test(s), Total: 52 test(s)Failed: projectroot.autotests.kiocore_kmountpointtestFailed: projectroot.autotests.kiowidgets_kdirlistertestFailed: projectroot.autotests.kiowidgets_kdirmodeltestName: projectroot.autotests Failed: 0 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 6 test(s)Name: projectroot.src.ioslaves.trash Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.src.kpasswdserver Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)

KDE CI: Frameworks » kpackage » kf5-qt5 FreeBSDQt5.13 - Build # 37 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kpackage/job/kf5-qt5%20FreeBSDQt5.13/37/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 27 Nov 2019 12:55:38 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 10 test(s), Skipped: 0 test(s), Total: 11 test(s)Failed: projectroot.autotests.plasma_packagestructuretest

D25441: Send along the config name with requests

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 70427.
leinir added a comment.


  (just a little merge, for my own sanity... but also ping?)
  
  - Merge branch 'master' into send-config-name-with-requests

REPOSITORY
  R304 KNewStuff

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25441?vs=70111&id=70427

BRANCH
  send-config-name-with-requests (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25441

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/attica/atticaprovider_p.h
  src/core/engine.cpp

To: leinir, #knewstuff, #frameworks, #plasma, starbuck, ronaldv
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24657: Add support for _GTK_FRAME_EXTENTS

[Vlad Zahorodnii]

zzag closed this revision.

REPOSITORY
  R278 KWindowSystem

REVISION DETAIL
  https://phabricator.kde.org/D24657

To: zzag, #kwin, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25015: Update breeze theme shadows

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Actually it looks like that was due to some kind of caching issue. It's gone 
now. LGTM!
  
  Everyone else good with this?

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25562: Add some friendly "report bugs here" links

[Nathaniel Graham]

ngraham added a comment.


  Instead of using `.arg()`, just put the variable inline, inside the i18n 
call. This is less fragile and less likely to produce visible i18n errors in 
the UI.
  
  Also, screenshots in the Test Plan section are always appreciated for 
user-visible changes. :)

REPOSITORY
  R304 KNewStuff

REVISION DETAIL
  https://phabricator.kde.org/D25562

To: leinir, #frameworks, #knewstuff, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

Re: KInit - Current state and benchmarks

[Aleix Pol]

On Tue, Nov 26, 2019 at 8:57 AM Milian Wolff  wrote:
>
> On Montag, 25. November 2019 22:57:11 CET Albert Astals Cid wrote:
> > El dissabte, 23 de novembre de 2019, a les 11:47:40 CET, Milian Wolff va
> escriure:
> > > On Mittwoch, 19. Juni 2019 19:57:56 CET Albert Astals Cid wrote:
> > > > El dimarts, 18 de juny de 2019, a les 12:04:38 CEST, David Edmundson va
> > >
> > > escriure:
> > > > > > Are we sure it's fair to assume people have SSD? our of the 4
> > > > > > laptops i
> > > > > > own, only 2 have SSD.>
> > > > >
> > > > > It's at least safe to assume it's the trend moving forward.
> > > > >
> > > > > > Do you think it's worth me trying in one of the two that don't have
> > > > > > SSD?
> > > > >
> > > > > More data is normally a good thing. If you or anyone else wants to
> > > > > collect stats:
> > > > > From my git link above, it's as simple as running the normal ; cmake;
> > > > > make ; ./kinittest -median 5
> > > >
> > > > On my very old/very slow computer seems to make a lot of difference
> > > >
> > > > RESULT : DaveTest::testQProcess():
> > > >  2,625 msecs per iteration (total: 2,625, iterations: 1)
> > > >
> > > > RESULT : DaveTest::testKInit():
> > > >  1,852 msecs per iteration (total: 1,852, iterations: 1)
> > > >
> > > > RESULT : DaveTest::testQProcess():
> > > >  2,390 msecs per iteration (total: 2,390, iterations: 1)
> > > >
> > > > RESULT : DaveTest::testKInit():
> > > >  1,846 msecs per iteration (total: 1,846, iterations: 1)
> > >
> > > Hey Albert,
> > >
> > > these numbers are quite impressive but I can't quite explain those. Are
> > > you
> > > measuring maybe a full debug build without any compiler optimizations?
> >
> > I obviously can't remember, this was *months* ago, but i just ran the test
> > again (making sure -O3 was there and not any -g) and got a bit different
> > results, so maybe it was.
>
> Does this apply to your whole stack (instead of just the inittest from Dave)?
>
> > New results:
> >  * testQProcess: 2200 msec per iteration
> >  * testKInit:1700 msec per iteration
> >
> > Still a 20% speed improvement.
> >
> > > Then
> > > the library sizes will be _much_ larger and thus trigger more page faults.
> > > If every one of those is extremely slow on that machine compared to more
> > > modern machines?
> > >
> > > May I ask how old this machine is and what the speed of the HDD is?
> >
> > It's a Lenovo ideapad S10-3t, around 10 years old, the HDD is slow. But it's
> > of similar power to the Librecomputer La Frite i just got for free at
> > LinuxAppSummit, so even this is on the slow end of things we support i
> > think there's value on supporting it.
> >
> > If you're interested i can arrange you to get ssh access to the machine (the
> > ideapad, i don't have all the KF5/Qt stack built for the LaFrite).
>
> Yes, that would be interesting for me!

I have some leftover units. If that's helpful, I can arrange for you
to get a unit.

Aleix

D25564: Fix conflicts of shortcuts

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R480 Kipi Plugins

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25564

To: guoyunhe, #frameworks, apol

D25564: Fix conflicts of shortcuts

[Phabricator]

This revision was automatically updated to reflect the committed changes.
Closed by commit R480:4db2d47acddb: Fix conflicts of shortcuts (authored by Guo 
Yunhe ).

REPOSITORY
  R480 Kipi Plugins

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25564?vs=70409&id=70435

REVISION DETAIL
  https://phabricator.kde.org/D25564

AFFECTED FILES
  printimages/ui/croppage.ui

To: guoyunhe, #frameworks, apol

D25311: Add KColumnHeadersProxyModel

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 70437.
ahiemstra added a comment.


  - Use separate Q_SIGNALS for consistency

REPOSITORY
  R275 KItemModels

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25311?vs=70405&id=70437

BRANCH
  columnheadersmodel

REVISION DETAIL
  https://phabricator.kde.org/D25311

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/kcolumnheadersmodeltest.cpp
  src/core/CMakeLists.txt
  src/core/kcolumnheadersmodel.cpp
  src/core/kcolumnheadersmodel.h
  src/qml/plugin.cpp
  tests/qml/columnheaders.qml

To: ahiemstra
Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25311: Add KColumnHeadersProxyModel

[Arjen Hiemstra]

ahiemstra marked an inline comment as done.
ahiemstra added inline comments.

INLINE COMMENTS

> kossebau wrote in kcolumnheadersmodel.h:57
> For consistency I would prefer having a full Q_SIGNALS section:
> 
>   Q_SIGNALS:
>   void sourceModelChanged();
> 
> That matches the usual pattern and helps when reading raw headers to learn 
> about API of classes.

I actually prefer the combined style since it groups together all related bits 
regarding a single property. But I've changed it to a separate section now.

> kossebau wrote in kcolumnheadersmodel.h:60
> Why not QScopedPointer (for consistency in KF code)? Is that one going to be 
> deprecated in favour of std::unique_ptr?

Mostly force of habit. I also see little point in using QScopedPointer 
nowadays, as it does not offer anything over std::unique_ptr.

REPOSITORY
  R275 KItemModels

REVISION DETAIL
  https://phabricator.kde.org/D25311

To: ahiemstra
Cc: kossebau, vkrause, davidedmundson, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25545: Rename signal for avoiding overload signal

[David Faure]

dfaure accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R246 Sonnet

BRANCH
  deprecated_overload_signal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25545

To: mlaurent, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25572: [KFileWidget] Allow double quotes in filenames

[Méven Car]

meven created this revision.
meven added reviewers: Frameworks, ngraham.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
meven requested review of this revision.

REVISION SUMMARY
  Use " " to detect if there is multiple files and split filenames allowing 
them to contain ".
  
  BUG: 185433
  FIXED-IN: 5.65

TEST PLAN
  1. touch ~/\"test.txt
  2. Use KFileWidget to select this file (you can use 
kfilewidgettest_saving_gui.cpp)
  
  ctest

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25572

AFFECTED FILES
  autotests/kfilewidgettest.cpp
  src/filewidgets/kfilewidget.cpp

To: meven, #frameworks, ngraham
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25533: Deprecate KFileWidget::toolBar

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  5.65 isn't released yet, you can use 5.65 as deprecation version here.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D25533

To: nicolasfella, #frameworks, dfaure
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

kde-frameworks-devel@kde.org

[David Faure]

dfaure added a comment.


  Yeah, but these days with lambdas, we can find out who emitted the signal, 
without the need for an identifier as signal argument...
  
connect(urlLabel, qOverload<>(&KUrlLabel::leftClickedUrl), this, [this, 
urlLabel]() { selectFolder(urlLabel->url()); } );
  
  should work too.
  This way the application can choose whether it wants the URL or the KUrlLabel 
pointer in the slot, or whatever else.
  
  I'm not 100% sure what's best -- e.g. QPushButton has clicked() without 
arguments, while KJob as result(KJob*) because it's convenient for the slot. 
With lambdas we don't really need the KJob* anymore. Capturing the local job 
variable instead would even remove some static_cast to subclasses in a number 
of cases. But the porting effort would be huge, so I'm reluctant :-)
  
  I guess this is most closely related to QPushButton though. In the simple 
case (different slot for each button or URLLabel) the signal with 0 arguments 
was always enough, and for the dynamic case (N buttons or N URLLabels) we have 
lambdas nowadays. Seems true for both, so I vote for deprecating the signals 
with an argument, and for porting KMail to my lambda above right away.
  
  Opinions?

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D25561

To: mlaurent, dfaure, kossebau
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25546: Deprecate KRecursiveFilterProxyModel

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R275 KItemModels

BRANCH
  deprecate (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25546

To: davidre, kossebau, dfaure, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, davidre, GB_2, michaelh, ahmadsamir, 
ngraham, bruns, kpiwowarski, asturmlechner, cfeck, cullmann, vkrause, 
cordlandwehr, knauss, dfaure

D25530: Sonnet: Add locales that are missing in QLocale

[Albert Astals Cid]

aacid added a comment.


  > the end user doesn't give a crap whether it was a problem in QLocale, or 
whether it needed to be done in many places in KDE code and that nobody did it. 
The end user opens the menu, sees 'American English (United States)' and below 
that 'cv_RU' and he is just going to think the developers didn't fix it.
  
  With no respect for your lack of being subtle, we need to maintain this for 
20 years in the future, you making a quick hack here doesn't make this any 
better, the user will still see cv_RU in random places and will be all annoyed 
anyway.
  
  Now go and make the fix in Qt, if it gets rejected, we can speak about doing 
dirty fixes.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25530

To: waqar
Cc: aspotashev, aacid, yurchor, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns

D25552: Deprecate top-level UserIcon method, no longer used

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R302:312f27f31199: Deprecate top-level UserIcon method, no 
longer used (authored by vkrause).

REPOSITORY
  R302 KIconThemes

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25552?vs=70364&id=70450

REVISION DETAIL
  https://phabricator.kde.org/D25552

AFFECTED FILES
  src/CMakeLists.txt
  src/kiconloader.cpp
  src/kiconloader.h

To: vkrause, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25575: remove unused kgesturemap from kaction

[David Edmundson]

davidedmundson created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Compiles
  Checked kaction_p.h wasn't installed

REPOSITORY
  R239 KDELibs4Support

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25575

AFFECTED FILES
  src/kdeui/kaction.cpp
  src/kdeui/kaction_p.h
  src/kdeui/kapplication.cpp

To: davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25576: [server] Do not own dmabuf implementation

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: KWin.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
romangg requested review of this revision.

REVISION SUMMARY
  The dmabuf implementation should be managed by the compositor and not by the
  interface which might go away through signals while the implementation goes
  away in the compositor simultaneously.

TEST PLAN
  Compiles.

REPOSITORY
  R127 KWayland

BRANCH
  dmabuf-impl-ownership

REVISION DETAIL
  https://phabricator.kde.org/D25576

AFFECTED FILES
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: romangg, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25576: [server] Do not own dmabuf implementation

[Roman Gilg]

romangg added a dependent revision: D25577: Destroy dmabuf implementation on 
EGL backend going down.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D25576

To: romangg, #kwin
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25576: [server] Do not own dmabuf implementation

[David Edmundson]

davidedmundson accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R127 KWayland

BRANCH
  dmabuf-impl-ownership

REVISION DETAIL
  https://phabricator.kde.org/D25576

To: romangg, #kwin, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25576: [server] Do not own dmabuf implementation

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R127:005a8ede4bb7: [server] Do not own dmabuf implementation 
(authored by romangg).

REPOSITORY
  R127 KWayland

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25576?vs=70457&id=70463

REVISION DETAIL
  https://phabricator.kde.org/D25576

AFFECTED FILES
  src/server/linuxdmabuf_v1_interface.cpp
  src/server/linuxdmabuf_v1_interface.h

To: romangg, #kwin, davidedmundson
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

KDE CI: Frameworks » kwayland » kf5-qt5 FreeBSDQt5.13 - Build # 36 - Still Unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Frameworks/job/kwayland/job/kf5-qt5%20FreeBSDQt5.13/36/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Wed, 27 Nov 2019 20:51:45 +
 Build duration:
5 min 52 sec and counting
   JUnit Tests
  Name: projectroot.autotests Failed: 13 test(s), Passed: 29 test(s), Skipped: 0 test(s), Total: 42 test(s)Failed: projectroot.autotests.client.kwayland_testCompositorFailed: projectroot.autotests.client.kwayland_testDataDeviceFailed: projectroot.autotests.client.kwayland_testDataSourceFailed: projectroot.autotests.client.kwayland_testRegionFailed: projectroot.autotests.client.kwayland_testShmPoolFailed: projectroot.autotests.client.kwayland_testSubCompositorFailed: projectroot.autotests.client.kwayland_testSubSurfaceFailed: projectroot.autotests.client.kwayland_testWaylandConnectionThreadFailed: projectroot.autotests.client.kwayland_testWaylandRegistryFailed: projectroot.autotests.client.kwayland_testWaylandShellFailed: projectroot.autotests.client.kwayland_testWaylandSurfaceFailed: projectroot.autotests.client.kwayland_testXdgShellV5Failed: projectroot.autotests.server.kwayland_testWaylandServerDisplay

D25015: Update breeze theme shadows

[Niccolò Venerandi]

niccolove added a comment.


  In D25015#568331 , @ngraham wrote:
  
  > Actually it looks like that was due to some kind of caching issue. It's 
gone now. LGTM!
  >
  > Everyone else good with this?
  
  
  Actually, it seems to me that borders are not correctly rounded except when 
on bright background, and sometimes. I'm not sure why would that be. Do you 
also see this, or is it just me?
  F7787476: image.png 
  F7787479: image.png 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25583: Quit baloo_file_extractor if DB transaction fails

[David Edmundson]

davidedmundson created this revision.
Herald added projects: Frameworks, Baloo.
Herald added subscribers: Baloo, kde-frameworks-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Currently I have a broken DB, the worst part is that I'm in a 100% CPU
  loop.
  
  baloo-file runs, sees some files need phase 2 extraction, and launches
  the extractor. The extractor fails to update the DB which means they're
  never marked as complete or failed.
  
  baloo-file then keeps sending the same files
  
  By having the extractor bail, it at least stops.

TEST PLAN
  Ran baloo-file
  It fails for 20 files or so (one batch) then stops

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25583

AFFECTED FILES
  src/engine/transaction.cpp
  src/engine/transaction.h
  src/file/extractor/app.cpp

To: davidedmundson
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25583: Quit baloo_file_extractor if DB transaction fails

[David Edmundson]

davidedmundson added a reviewer: bruns.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D25583

To: davidedmundson, bruns
Cc: kde-frameworks-devel, #baloo, hurikhan77, lots0logs, LeGast00n, 
fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D25015: Update breeze theme shadows

[Filip Fila]

filipf added a comment.


  My impression is that the rounding is currently just faked by the shadow. So 
when the shadow gets lighter, it becomes more obvious that the object itself 
isn't really rounded.
  
  F7787609: image.png 

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  bettershadows (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25015

To: niccolove, #vdg, ngraham
Cc: cblack, ndavis, manueljlin, ngraham, filipf, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh, bruns

D25575: remove unused kgesturemap from kaction

[Aleix Pol Gonzalez]

apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R239 KDELibs4Support

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25575

To: davidedmundson, apol
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25585: Fix i18n syntax to avoid runtime errors

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: leinir, Plasma, Frameworks.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Using `.arg()` in `i18n()` calls can lead to runtime errors such as the ones 
shown in
  https://bugs.kde.org/show_bug.cgi?id=414498. Let's port away from that.
  
  BUG: 414498

TEST PLAN
  QML GHNS dialog no longer has any i18n errors in strings

REPOSITORY
  R304 KNewStuff

BRANCH
  fix-i18n-usage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25585

AFFECTED FILES
  src/attica/atticaprovider.cpp
  src/qtquick/qml/Dialog.qml
  src/qtquick/qml/EntryDetails.qml
  src/qtquick/qml/private/EntryCommentDelegate.qml
  src/qtquick/qml/private/EntryCommentsPage.qml
  src/qtquick/qml/private/entrygriddelegates/BigPreviewDelegate.qml
  src/qtquick/qml/private/entrygriddelegates/TileDelegate.qml
  src/qtquick/quickitemsmodel.cpp

To: ngraham, leinir, #plasma, #frameworks
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24884: Undeprecate I18N_NOOP2

[Laurent Montel]

mlaurent accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R249 KI18n

BRANCH
  arcpatch-D24884

REVISION DETAIL
  https://phabricator.kde.org/D24884

To: dfaure, ilic, aacid, mlaurent
Cc: kossebau, aacid, vkrause, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
ngraham, bruns

D25545: Rename signal for avoiding overload signal

[Laurent Montel]

This revision was automatically updated to reflect the committed changes.
Closed by commit R246:f6f6aa244b55: Rename signal for avoiding overload signal 
(authored by mlaurent).

REPOSITORY
  R246 Sonnet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25545?vs=70410&id=70476

REVISION DETAIL
  https://phabricator.kde.org/D25545

AFFECTED FILES
  CMakeLists.txt
  docs/Doxyfile.local
  src/core/CMakeLists.txt
  src/ui/CMakeLists.txt
  src/ui/dialog.cpp
  src/ui/dialog.h

To: mlaurent, dfaure, kossebau
Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

kde-frameworks-devel@kde.org

[Laurent Montel]

mlaurent added a comment.


  I don't prefer a signal with argument or not.
  Indeed I can adapt kmail for it.
  
  So I will change deprecated signal.

REPOSITORY
  R236 KWidgetsAddons

REVISION DETAIL
  https://phabricator.kde.org/D25561

To: mlaurent, dfaure, kossebau
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

kde-frameworks-devel@kde.org

[Laurent Montel]

mlaurent updated this revision to Diff 70477.
mlaurent added a comment.


  Deprecated signal with argument

REPOSITORY
  R236 KWidgetsAddons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25561?vs=70406&id=70477

BRANCH
  remove_overload_signal (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25561

AFFECTED FILES
  src/CMakeLists.txt
  src/kurllabel.cpp
  src/kurllabel.h

To: mlaurent, dfaure, kossebau
Cc: cfeck, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D25530: Sonnet: Add locales that are missing in QLocale

[Waqar Ahmed]

waqar added a comment.


  > With no respect for your lack of being subtle
  
  I meant no disrespect to anyone. If you felt offended I apologize
  
  > we need to maintain this for 20 years in the future, you making a quick 
hack here doesn't make this any better, the user will still see cv_RU in random 
places and will be all annoyed anyway.
  
  Can you give examples of places where an iso_code (cv_RU) could pop up?
  
  Spellchecker is a frequently accessed tool. It can have more languages than 
any other tool. The user can just place a dictionary in the directory and it is 
the job of spellchecker to load those dictionaries and their filenames 
correctly.
  
  > Now go and make the fix in Qt
  
  Please don't give orders.
  
  Anyways, I looked deep into this to figure out what's the issue. The relevant 
data is stored in qlocale_data_p.h, it does have most of the iso_codes (even 
the ones that are being displayed incorrectly). What it doesn't have is native 
language names.
  
  So, if I do,
  
QLocale locale("cv");
QLocale::Language l = locale.language();
QString localizedLangName = locale.languageToString(l);
  
  It shows `Chuvash` as the language name.
  
  Now, qlocale_data_p.h is a generated file. You can't edit it manually. Qt 
takes the data from CLDR . And CLDR doesn't have the 
native names for these languages. CLDR is a huge database of locale stuff, and 
it is not very easy to contribute data if you aren't a native speaker.
  
  > if it gets rejected, we can speak about doing dirty fixes.
  
  It's a fallback mechanism for when QLocale fails.

REPOSITORY
  R246 Sonnet

REVISION DETAIL
  https://phabricator.kde.org/D25530

To: waqar
Cc: aspotashev, aacid, yurchor, kde-frameworks-devel, LeGast00n, GB_2, 
michaelh, ngraham, bruns