D21861: Add default variables for variables interface
gregormi added a comment. In D21861#484556 <https://phabricator.kde.org/D21861#484556>, @dhaumann wrote: > I'd like to drop the " Current" prefix in all the variables. It just makes the names longer and I don't see any value for users. Comments? There is no other Document than the current one. I also don't come up with an idea where "Current" prefix makes things clearer. => Removal seems ok to me. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D21861 To: dhaumann, cullmann, gregormi Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D21931: [kmoretools] Add icons to download and install actions
gregormi accepted this revision. gregormi added a comment. Looks good to me. REPOSITORY R304 KNewStuff BRANCH actions REVISION DETAIL https://phabricator.kde.org/D21931 To: nicolasfella, gregormi, ngraham, #vdg, #knewstuff Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns
D21293: Markdown: Use color with higher contrast for lists
gregormi added a comment. In D21293#467150 <https://phabricator.kde.org/D21293#467150>, @dhaumann wrote: > New color is red: F6835074: Screenshot_20190519_175848.png <https://phabricator.kde.org/F6835074> > > @gregormi If you want other colors, please propose them yourself :-) Thanks. Let's see how it works out. Regarding the screenshot, I see that "code 1, code2" is also the same orange as list items previously were. I think it would be better to change that as well, e.g. to blue as in "block quote" but a bit darker. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21293 To: dhaumann, cullmann, gregormi Cc: kwrite-devel, kde-frameworks-devel, domson, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17137: KTextEditor: File menu: Put Save, Print and Export in submenus
gregormi added a comment. What I wonder: during the work with the .rc files I noticed that even the Kate which is installed in root got affected by the changes I made in the development version and I had to regularly change the version number to make changes take effect. Is this normal? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: anthonyfieroni, ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, sars
D17137: KTextEditor: File menu: Put Save, Print and Export in submenus
gregormi marked an inline comment as done. gregormi added a comment. This is what is looks like now (together with latest changes from https://phabricator.kde.org/D17138): F6547077: grafik.png <https://phabricator.kde.org/F6547077> REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: anthonyfieroni, ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, sars
D17137: KTextEditor: File menu: Put Save, Print and Export in submenus
gregormi updated this revision to Diff 49369. gregormi added a comment. - Move "Save As..." out of the submenu REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17137?vs=46132=49369 BRANCH arcpatch-D17137 REVISION DETAIL https://phabricator.kde.org/D17137 AFFECTED FILES src/data/katepart5ui.rc To: gregormi, #kate, #kdevelop Cc: anthonyfieroni, ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, sars
D17730: Review KateStatusBar
gregormi added a comment. @loh.tar: I like the new status bar. > Move the modified label from far right to far left This way have it a more prominent position Now, the "modified label" behaves like a button but with no visible action when it is clicked. Two general observations: - In "unedited" state the purpose is (still) hard to guess from the icon (and there is the convention of not having tooltips for the status bar which requires a creative solution). - In "modified" state it would be cool to be able to click to save the document REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17730 To: loh.tar, #ktexteditor, cullmann Cc: gregormi, dhaumann, zetazeta, cullmann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase, michaelh, ngraham, bruns, demsking, sars
D17442: KTextEditor: Tweak keyboard shortcuts to free F keys
gregormi retitled this revision from "KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate" to "KTextEditor: Tweak keyboard shortcuts to free F keys". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17442 To: gregormi, #kate Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, sars
D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate
gregormi added a comment.
With respect to bringing this https://phabricator.kde.org/T10279 forward, how
should I proceed here? Can this go in as first step (after I removed F10 and
F11)? (see also https://phabricator.kde.org/D17443)
INLINE COMMENTS
> kateview.cpp:700
> ac->addAction(QStringLiteral("view_dynamic_word_wrap"), a);
> -ac->setDefaultShortcut(a, QKeySequence(Qt::Key_F10));
> +ac->setDefaultShortcuts(a, { QKeySequence(Qt::Key_F10),
> QKeySequence(Qt::CTRL + Qt::Key_E, Qt::CTRL + Qt::Key_W) });
> a->setWhatsThis(i18n("If this option is checked, the text lines will be
> wrapped at the view border on the screen."));
todo: Remove F10
> kateview.cpp:727
> ac->addAction(QStringLiteral("view_line_numbers"), a);
> -ac->setDefaultShortcut(a, QKeySequence(Qt::Key_F11));
> +ac->setDefaultShortcuts(a, { QKeySequence(Qt::Key_F11),
> QKeySequence(Qt::CTRL + Qt::Key_E, Qt::CTRL + Qt::Key_L) });
> a->setWhatsThis(i18n("Show/hide the line numbers on the left hand side
> of the view."));
todo: remove F11
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17442
To: gregormi, #kate
Cc: cullmann, dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, hase,
michaelh, bruns, demsking, sars
D17137: KTextEditor: File menu: Put Save, Print and Export in submenus
gregormi added a comment. If there are no further comments, would proceed with: - Introduce "Save Variants" by leaving Save and Save as... top-level. I will use the name 'file_save_variants' - Introduce "Print and Export" submenu - Introduce "Close Variants" while leaving the 'Ctrl+W' Close on top-level REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: ngraham, cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, sars
D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate
gregormi added a comment. Yes, those shortcuts exist long time. I would like to change them for these specific reasons which I think are worth to be considered: 1. Introduce a default shortcut pair for "Next / Prev Match" which is useful and currently missing. 2. "Free" some F keys to have them available for user-defined shortcuts; for me that would be those needed for developing (run, debug, stepping, stop and what else comes in handy; probably KDevelop would also profit to have F10 and F11 freed). I think it is easier for the user to choose one of the F keys for those actions than to find a free Ctrl+... combination. At least I have those problems regularly when trying to add useful custom shortcuts. Extended shortcuts are often used in advanced editors and IDEs. I would be happy if there are other ideas that would address those issues. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17442 To: gregormi, #kate Cc: dhaumann, ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, cullmann, sars
D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate
gregormi added a comment. In D17442#374054 <https://phabricator.kde.org/D17442#374054>, @ngraham wrote: > In D17442#373755 <https://phabricator.kde.org/D17442#373755>, @gregormi wrote: > > > In D17442#373708 <https://phabricator.kde.org/D17442#373708>, @ngraham wrote: > > > > > I always re-bind Find Next and and Find Previous to use [Ctrl] + [G] and [Ctrl] + [⇧] + [G]. These are the shortcuts that are used by most 3rd-party apps, as well as all GNOME and macOS apps. It might make more sense to standardize on those. > > > > > > Just to clarify: F3/Shift+F3 would stay the same, right? > > > Yeah, as backup/additional shortcuts so we don't break workflows for people who currently use them. This sounds that we speak of different actions here. This proposal does **not** touch the F3/Shift+F3 action which is "Next/Prev result" **from a search that was started with Ctrl+F**. It is not my intention to make changes there. It is about introducing a default shortcut where we currently have none: "Goto Next/Prev result item" coming **from a search across multiple files**. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17442 To: gregormi, #kate Cc: ngraham, kwrite-devel, kde-frameworks-devel, hase, michaelh, bruns, demsking, cullmann, sars, dhaumann
D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate
gregormi edited the summary of this revision. gregormi added a reviewer: Kate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17442 To: gregormi, #kate Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17442: KTextEditor: Tweak keyboard shortcuts to prepare for F6/Shift+F6 in Kate
gregormi created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. gregormi requested review of this revision. REVISION SUMMARY The idea is to use F6 and Shift+F6 in Kate for Next and Previous Search Match. These shortcuts are also used by QtCreator for that. Since F6 is currently used for "Show Icon Border", here is a proposal to adapt. 1. Change shortcut for "Show Icon Border" to "Ctrl+E, Ctrl+B" because it is used not that often to deserve an F key. Why "Ctrl+E, ..."? Because Qt Creator uses it as start key combination for various functions. The alternative would be "Ctrl+D, ..." which is used by Visual Studio. Ctrl+E is currently used for "Go to previous edit" (Ctrl+Shift+E: go to next edit). Ctrl+D is currently used to comment a line. I choose to change "Go to previous edit". 2. Set new shortcut Alt+F6 and Alt+Shift+F6 for "Go to previous/next edit". While at it, I made some additions with the newly freed Ctrl+E shortcut: 3. Add Ctrl+E, Ctrl+W for "Dynamic Word Wrap" (like in Qt Creator) (the current F10 could be freed later) 4. Use Ctrl+E, Ctrl+I for "Clean Indentation" which is a useful feature (which could later be extended by a more powerful code formatter) 5. Use Ctrl+E, Ctrl+S for "Show non-printable spaces" (for comparison: in Qt Creator it is Ctrl+E, Ctrl+V for "Visualize Whitespace") 6. Use Ctrl+E, Ctrl+L for "Show Line Numbers" (as alternative to F11 which could later be used for something else) REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D17442 AFFECTED FILES src/view/kateview.cpp To: gregormi Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17137: KTextEditor: File menu: Put Save, Print and Export in submenus
gregormi added a comment. +1 for leaving Save As on top level. Just for reference the File menu of the current master on my screen :) F6464245: grafik.png <https://phabricator.kde.org/F6464245> As for me, at least all the Close actions could be moved into a submenu. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: cullmann, flherne, dhaumann, kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, sars
D6877: Add Conan files
Herald edited subscribers, added: kde-frameworks-devel; removed: Frameworks. REPOSITORY R243 KArchive REVISION DETAIL https://phabricator.kde.org/D6877 To: gladhorn, dfaure Cc: kde-frameworks-devel, gregormi, dfaure, apol, cfeck, michaelh, ngraham, bruns, #frameworks
D17137: KTextEditor: File menu: Put Save, Print and Export in submenus
gregormi retitled this revision from "File menu: Put Save, Print and Export in submenus" to "KTextEditor: File menu: Put Save, Print and Export in submenus". REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: kwrite-devel, kde-frameworks-devel, hase, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17270: [KUrlNavigator] List subdirs of a parent folder of an archive
gregormi added inline comments.
INLINE COMMENTS
> kurlnavigatorbutton.cpp:414
> +url = KIO::upUrl(m_url);
> +} else if ((m_url.scheme() == QLatin1String("tar")) || (m_url.scheme()
> == QLatin1String("zip"))) {
> +// We are in an archive, check whether the subdir we have to list is
> part of the archive
When I click a zip file I get this in the URL bar:
krarc:/home/gregor/Downloads/kfk_10p.zip/
This could mean that "krarc" should be added to this if statement.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D17270
To: thsurrel, #frameworks
Cc: gregormi, kde-frameworks-devel, michaelh, ngraham, bruns
D17137: File menu: Put Save, Print and Export in submenus
gregormi edited the summary of this revision. gregormi added a reviewer: KDevelop. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate, #kdevelop Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17137: File menu: Put Save, Print and Export in submenus
gregormi edited the summary of this revision. gregormi added a reviewer: Kate. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi, #kate Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17137: File menu: Put Save, Print and Export in submenus
gregormi updated this revision to Diff 46132. gregormi added a comment. rebase on master REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17137?vs=46128=46132 BRANCH arcpatch-D17137 REVISION DETAIL https://phabricator.kde.org/D17137 AFFECTED FILES src/data/katepart5ui.rc To: gregormi Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17137: File menu: Put Save, Print and Export in submenus
gregormi retitled this revision from "File menu: Put Save, Print and Export in submenus With https://phabricator.kde.org/D16830 the file menu gets more entries. This is a suggestion to do some cleanup before. This is the corresponding patch for Kate: TODO (screenshots are there)..." to "File menu: Put Save, Print and Export in submenus". gregormi edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17137 To: gregormi Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D17137: File menu: Put Save, Print and Export in submenusWith https://phabricator.kde.org/D16830 the file menu gets more entries. This is a suggestion to do some cleanup before.This is the correspondi
gregormi created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. gregormi requested review of this revision. REVISION SUMMARY ...NOTE: I assume that dependent applications like KWrite and KDevelop must be adapted, too. So, a broader discussion is expected. REPOSITORY R39 KTextEditor BRANCH master REVISION DETAIL https://phabricator.kde.org/D17137 AFFECTED FILES src/data/katepart5ui.rc To: gregormi Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann
D16145: Adapt autotest to new menu structure
gregormi accepted this revision. This revision is now accepted and ready to land. REPOSITORY R304 KNewStuff BRANCH fix REVISION DETAIL https://phabricator.kde.org/D16145 To: nicolasfella, gregormi, dhaumann Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13970: Handle empty preview lists
gregormi added a comment. I am rather familiar with KMoreTools but not with the rest of KNewStuff. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13970 To: cordlandwehr, gregormi, nicolasfella, dhaumann, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13880: [KMoreTools] Reduce menu hierarchy
gregormi added a comment. The spirit goes in the right direction; please proceed :-). Note, that Kate's project plugin also uses KMoreTools. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13880 To: nicolasfella, gregormi, dhaumann, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13880: [KMoreTools] Reduce menu hierarchy
gregormi added a comment. > You are the most awesome person in the world today. +1 :-) > Pro: Very flat hierarchy, code could be simplified a lot > Con: Unwanted and uninstalled tools would be present all the time. Exactly my thoughts. The idea behind the More menu was to hide (a potentially large number) of alternative programs which are not installed and not needed for the user. And even if there is only one alternative not installed program which the user does not want to use, always showing a "Install XYZ" seems a bit obtrusive to me. > https://phabricator.kde.org/D13880#286937 +1 for your suggestions. Downside: higher implementation effort. A bit of history: When I was creating the More submenu and the Configure... item I was pondering a thing: I was (and still am) not so glad about those two items because they are seldom used but always present in the menu. Back then, I thought about adding a keyboard modifier (like the Shift key) which must be pressed to let the Configure... item appear (similar to the context menu in Windows Explorer where the Shift key let more advanced items appear like Run as admin... etc.). I discarded the idea because of its hard discoverability. Another alternative would be to somehow hook the Configuration of KMoreTools menus in the host applications main Configure... dialog. Downside: configuration is far away from the actual menu. It would be cool if instead of the text "Configure..." or "More" there would be a small gear icon that does not take the space of a whole menu item. I suspect this is not possible with QMenus. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13880 To: nicolasfella, gregormi, dhaumann, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13706: [KMoreTools] Enable installing tools via appstream url
gregormi added a comment.
In D13706#282765 <https://phabricator.kde.org/D13706#282765>, @ngraham wrote:
> I'd like to see the missing AppStream URLs filled in for all the software
in this list. There are currently some claring omissions, especially for KDE
software (e.g. ksysguard) for which there is definitely an appstream ID
available). For any software that doesn't have any AppStream information (and
is therefore not visible or installable via Discover), I would actually
advocate removing it from the list, and making the presence of AppStream data a
pre-condition of inclusion--the reason being that otherwise an Install button
can't be presented to the user. Entries without an Install button are just
frustrating, tantamount to taunting them ("here's some cool software you could
use; oh, sorry, can't actually install it lol")
Hi Nate, thanks for reviewing.
- I tried `appstreamcli ksysguard` and `appstreamcli ding`. Both do not yield
a result. => I vote not to remove a program from this list just because it has
no obvious appstream id (yet).
- Programs which serve the same purpose should have a comment why they are in
the list, like it was done with giggle ("// good for searching in history"). In
such cases, for me it would be ok if there is no appstream id yet.
- For me, it would be ok, if Nicolas does not have to search for all the
missing appstream ids - except if you have fun to do it, Nicolas :-). The patch
is a definite improvement to the current state and missing ids could also be
added later incrementally.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D13706
To: nicolasfella, #frameworks, gregormi, ngraham
Cc: ngraham, dhaumann, kde-frameworks-devel, michaelh, bruns
D13706: [KMoreTools] Enable installing tools via appstream url
gregormi accepted this revision. gregormi added a comment. Ok from my side. Probably Dominik also wants to approve. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13706 To: nicolasfella, #frameworks, gregormi, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D13706: [KMoreTools] Enable installing tools via appstream url
gregormi added inline comments.
INLINE COMMENTS
> kmoretools_p.h:394
> +
> +QUrl appstreamUrl = QUrl(QStringLiteral("appstream://") %
> appstreamId);
> +
What does the % sign do here? Can this be used to concatenate strings? Did not
try it myself.
Otherwise ready to land.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D13706
To: nicolasfella, #frameworks, gregormi, dhaumann
Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D13706: [KMoreTools] Enable installing tools via appstream url
gregormi added inline comments.
INLINE COMMENTS
> kmoretoolspresets.cpp:59
> //
> -ADD_ENTRY("angrysearch",0,
> "https://github.com/DoTheEvo/ANGRYsearch;);
> -ADD_ENTRY("com.uploadedlobster.peek", 0,
> "https://github.com/phw/peek;); // easy to use screen recorder, creates gif
> -ADD_ENTRY("catfish",1,
> "http://www.twotoasts.de/index.php/catfish/;);
> -ADD_ENTRY("ding", 0,
> "https://www-user.tu-chemnitz.de/~fri/ding/;); // Offline dict, Online:
> http://dict.tu-chemnitz.de/dings.cgi
> -ADD_ENTRY("disk", 0,
> "https://en.opensuse.org/YaST_Disk_Controller;);
> -ADD_ENTRY("fontinst", 0,
> "https://docs.kde.org/trunk5/en/kde-workspace/kcontrol/fontinst/;); // good
> for previewing many fonts at once
> -ADD_ENTRY("fontmatrix", 0,
> "https://github.com/fontmatrix/fontmatrix;);
> -ADD_ENTRY("fsearch",0,
> "http://www.fsearch.org/;);
> -ADD_ENTRY("giggle", 1,
> "https://wiki.gnome.org/Apps/giggle/;); // good for searching in history
> -ADD_ENTRY("git-cola-folder-handler",1,
> "https://git-cola.github.io;);
> -ADD_ENTRY("git-cola-view-history.kmt-edition", 1,
> "https://git-cola.github.io;);
> -ADD_ENTRY("gitk.kmt-edition", 1,
> "http://git-scm.com/docs/gitk;);
> -ADD_ENTRY("qgit.kmt-edition", 1,
> "http://libre.tibirna.org/projects/qgit;);
> -ADD_ENTRY("gitg", 1,
> "https://wiki.gnome.org/action/show/Apps/Gitg?action=show=Gitg;);
> -ADD_ENTRY("gnome-search-tool", 0,
> "https://help.gnome.org/users/gnome-search-tool/;); // has good filtering
> options
> -ADD_ENTRY("gucharmap", 0,
> "https://wiki.gnome.org/action/show/Apps/Gucharmap;);
> -ADD_ENTRY("gparted",0, "http://gparted.org;);
> -ADD_ENTRY("htop", 0,
> "http://hisham.hm/htop/;);
> -ADD_ENTRY("hotshots", 1,
> "http://sourceforge.net/projects/hotshots/;);
> -ADD_ENTRY("kaption",0,
> "http://kde-apps.org/content/show.php/?content=139302;);
> -ADD_ENTRY("kding", 0, ""); // Offline dict;
> unmaintained?
> -ADD_ENTRY("org.kde.kmousetool", 0,
> "https://www.kde.org/applications/utilities/kmousetool/;);
> -ADD_ENTRY("org.gnome.clocks", 0,
> "https://wiki.gnome.org/Apps/Clocks;);
> -ADD_ENTRY("org.kde.filelight", 1,
> "https://utils.kde.org/projects/filelight;);
> -ADD_ENTRY("org.kde.kcharselect",0,
> "https://utils.kde.org/projects/kcharselect/;);
> -ADD_ENTRY("org.kde.kdf",0,
> "https://www.kde.org/applications/system/kdiskfree;);
> -ADD_ENTRY("org.kde.kfind", 1,
> "https://www.kde.org/applications/utilities/kfind/;); // has good filtering
> options
> -ADD_ENTRY("org.kde.partitionmanager", 0,
> "https://www.kde.org/applications/system/kdepartitionmanager/;);
> -ADD_ENTRY("org.kde.plasma.cuttlefish.kmt-edition", 0,
> "http://vizzzion.org/blog/2015/02/say-hi-to-cuttlefish/;);
> -ADD_ENTRY("org.kde.ksysguard", 0,
> "https://userbase.kde.org/KSysGuard;);
> -ADD_ENTRY("org.kde.ksystemlog", 0,
> "https://www.kde.org/applications/system/ksystemlog/;);
> -ADD_ENTRY("org.kde.ktimer", 0,
> "https://www.kde.org/applications/utilities/ktimer/;);
> -ADD_ENTRY("org.kde.spectacle", 0,
> "https://www.kde.org/applications/graphics/spectacle;);
> -ADD_ENTRY("simplescreenrecorder", 0,
> "http://www.maartenbaert.be/simplescreenrecorder/;);
> -ADD_ENTRY("shutter",0,
> "http://shutter-project.org;); // good for edit screenshot after capture
> -ADD_ENTRY("vokoscreen", 0,
> "https://github.com/vkohaupt/
D13706: [KMoreTools] Enable installing tools via appstream url
gregormi added inline comments. INLINE COMMENTS > kmoretools.h:500 > + */ > +void setAppstreamUrl(const QUrl& url); > + I am not so familiar with appstream. Why not only setting the COMPONENT-ID instead of the whole URL? Then the method would be named setAppstreamComponentId. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13706 To: nicolasfella, #frameworks, gregormi, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns
D13706: [KMoreTools] Enable installing tools via appstream url
gregormi added a comment. First of all, thanks for adding this feature. This was missing a long time :-). I will do some comments in the code. INLINE COMMENTS > kmoretools.h:488-491 > +QUrl appstreamUrl() const; > + > +void setAppstreamUrl(const QUrl& url); > + Please add a comment and add something like "@since 5.xx" (see elsewhere in the this file) to indicate since which frameworks version this will be available. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13706 To: nicolasfella, #frameworks, gregormi Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D11733: Allow opening items from the open/save dialogs
gregormi added a comment. In D11733#235208 <https://phabricator.kde.org/D11733#235208>, @rkflx wrote: > and the bug reporter's use case of selecting a file in a web browser for upload essentially wants the existing [F11] preview feature and perhaps a better preview feature in the web application itself. The inline preview only gives thumbnails which are not usable when one wants to read text on the image (zoom to 100%). For me, the preview should take place before it is uploaded to the web application because I want to make sure the right thing is uploaded. > Also note that you could just drag-and-drop the file onto Dolphin, which should then open the default app, or onto Gwenview's launcher etc. Interesting. Thanks for the hint. > My concern is that the naming as well as the concept itself clashes with the regular Open button while doing something different. +1. If the function is added, it should be named Open with... to not be confused with the Open button. > Maybe I'll change my mind if you can come up with a very compelling use case which is so great it's worth living with the disadvantages. For now my (i.e. take this with a grain of salt) recommendation would be to not add this. I come from Windows where the Open item is also available. Not having it feels like a lack of flexibility. I think having it in the context menu will not affect the "normal" user. Your proposed workaround with "Open containing Folder" -> Press Enter is certainly ok. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11733 To: ngraham, #dolphin, #frameworks Cc: gregormi, rkflx, broulik, michaelh, ngraham
D10390: Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping
This revision was automatically updated to reflect the committed changes. Closed by commit R304:bf82fe7c222f: Add vokoscreen to KMoreTools and add it to the screenrecorder grouping (authored by gregormi). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D10390?vs=26772=26774#toc REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10390?vs=26772=26774 REVISION DETAIL https://phabricator.kde.org/D10390 AFFECTED FILES data/kmoretools-desktopfiles/_INFO data/kmoretools-desktopfiles/_README.md data/kmoretools-desktopfiles/_update_all_files.sh data/kmoretools-desktopfiles/vokoscreen.desktop data/kmoretools-desktopfiles/vokoscreen.png src/kmoretools/kmoretoolspresets.cpp To: gregormi, ngraham, apol Cc: #frameworks, michaelh, ngraham
D10390: Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping
gregormi added a comment. Screenshot of test program: F5698743: grafik.png <https://phabricator.kde.org/F5698743>. One can see the new item. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D10390 To: gregormi, ngraham Cc: #frameworks, michaelh, ngraham
D10390: Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping
gregormi retitled this revision from "Minor fix: rename info file to _README.md" to "Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping". gregormi edited the test plan for this revision. gregormi added a reviewer: ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D10390 To: gregormi, ngraham Cc: #frameworks, michaelh, ngraham
D10390: Minor fix: rename info file to _README.md
gregormi created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. gregormi requested review of this revision. REVISION SUMMARY Add vokoscreen to KMoreTools and add it to the "screenrecorder" grouping TEST PLAN Run $ cd kde/src/build/frameworks/knewstuff/bin/ ; ./kmoretoolstest_interactive testDialogForGroupingNames and try the grouping "screenrecorder" REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D10390 AFFECTED FILES data/kmoretools-desktopfiles/_INFO data/kmoretools-desktopfiles/_README.md data/kmoretools-desktopfiles/_update_all_files.sh data/kmoretools-desktopfiles/vokoscreen.desktop data/kmoretools-desktopfiles/vokoscreen.png src/kmoretools/kmoretoolspresets.cpp To: gregormi Cc: #frameworks, michaelh, ngraham
D8848: do not install development tool to aggregate desktop files
gregormi accepted this revision. gregormi added a comment. This revision is now accepted and ready to land. Approval from my side. Thanks. REPOSITORY R304 KNewStuff BRANCH master REVISION DETAIL https://phabricator.kde.org/D8848 To: sitter, #frameworks, whiting, gregormi
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a comment. Thanks for committing, Nate. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: mak, ngraham, ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi updated this revision to Diff 20781. gregormi added a comment. Rebase, run _update_all_files.sh and fix outdated desktop files REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7130?vs=17723=20781 BRANCH mydev REVISION DETAIL https://phabricator.kde.org/D7130 AFFECTED FILES autotests/kmoretools/kmoretoolstest.cpp autotests/kmoretools/kmoretoolstest2.cpp data/kmoretools-desktopfiles/_INFO data/kmoretools-desktopfiles/_update_all_files.sh data/kmoretools-desktopfiles/angrysearch.desktop data/kmoretools-desktopfiles/catfish.desktop data/kmoretools-desktopfiles/com.uploadedlobster.peek.desktop data/kmoretools-desktopfiles/ding.desktop data/kmoretools-desktopfiles/disk.desktop data/kmoretools-desktopfiles/filelight.png data/kmoretools-desktopfiles/filelight.svg data/kmoretools-desktopfiles/fontinst.desktop data/kmoretools-desktopfiles/fontmatrix.desktop data/kmoretools-desktopfiles/fsearch.desktop data/kmoretools-desktopfiles/giggle.desktop data/kmoretools-desktopfiles/git-cola-folder-handler.desktop data/kmoretools-desktopfiles/git-cola.desktop data/kmoretools-desktopfiles/gitg.desktop data/kmoretools-desktopfiles/gnome-search-tool.desktop data/kmoretools-desktopfiles/gparted.desktop data/kmoretools-desktopfiles/gucharmap.desktop data/kmoretools-desktopfiles/htop.desktop data/kmoretools-desktopfiles/kdf.desktop data/kmoretools-desktopfiles/kding.desktop data/kmoretools-desktopfiles/ksystemlog.desktop data/kmoretools-desktopfiles/org.gnome.clocks.desktop data/kmoretools-desktopfiles/org.kde.PartitionManager.desktop data/kmoretools-desktopfiles/org.kde.filelight.desktop data/kmoretools-desktopfiles/org.kde.kcharselect.desktop data/kmoretools-desktopfiles/org.kde.kdf.desktop data/kmoretools-desktopfiles/org.kde.kfind.desktop data/kmoretools-desktopfiles/org.kde.kmousetool.desktop data/kmoretools-desktopfiles/org.kde.kscreengenie.desktop data/kmoretools-desktopfiles/org.kde.ksnapshot.desktop data/kmoretools-desktopfiles/org.kde.ksysguard.desktop data/kmoretools-desktopfiles/org.kde.ksystemlog.desktop data/kmoretools-desktopfiles/org.kde.ktimer.desktop data/kmoretools-desktopfiles/org.kde.partitionmanager.desktop data/kmoretools-desktopfiles/org.kde.spectacle.desktop data/kmoretools-desktopfiles/shutter.desktop data/kmoretools-desktopfiles/shutter.svg data/kmoretools-desktopfiles/simplescreenrecorder.desktop data/kmoretools-desktopfiles/xfce4-taskmanager.desktop src/kmoretools/kmoretoolspresets.cpp src/kmoretools/kmoretoolspresets.h tests/kmoretools/kmoretoolstest_interactive.cpp To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson, ngraham Cc: ngraham, ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a comment.
> @ltoscano, can we commit this?
Hi Nate, thanks for pushing this forward.
> I still disagree in the way this is done, as it means manually periodically
updating the information and it's definitely not the right thing to do.
Hi Luigi,
I agree with you that the manual updating process is not good. As the library
was written, there was no better way. The desktop file method was chosen
because it was said that they avoid duplicate translation work. See last point
of the Introduction
https://api.kde.org/frameworks/knewstuff/html/classKMoreTools.html ("Reduce
translation effort by re-using .desktop files of the services added to the
menu."). Since the goal of KMoreTools is to present applications that are not
installed, I currently see no other way to ship all the desktop files.
> That said, if @elvisangelaccio approves this, it can go in as temporary fix
but the next update should work on using the appstream library to get those
information from appstream files. Or any other solutions which does not involve
duplicating the information.
I looked at the appstream documentation but I was not able to extract
information that would help me to understand how to use it in the KMoreTools
case. To be of use in KMoreTools there should be an offline database with all
needed applications and descriptions. How will this database be filled with new
applications? Maybe you can point me to some suitable documentation?
> I had tested the patch and it was fixing the bug.
> I'm fine with this as long as @gregormi volunteers to maintain this code
updated (and eventually to switch to a better design, if possible).
Hi Elvis, thanks for testing. Yes, I am currently volunteering to maintain.
The library was created to keep application code (like Dolphin) clean of such
details. I am regularly looking for a better design. Input welcome.
> I'm afraid this doesn't merge cleanly onto master. @gregormi, can you
rebase it against current master so that I can merge it?
OK, I will rebase onto master and report back when done.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D7130
To: gregormi, ltoscano, elvisangelaccio, #kde_applications, davidedmundson,
ngraham
Cc: ngraham, ltoscano, #frameworks
D7446: Add a Recent Documents places item to Dolphin and file pickers by default
gregormi added a comment. In https://phabricator.kde.org/D7446#148135, @ngraham wrote: > That said, the advantage to adding this as a Places item is that it shows up in file open/save dialogs for free, which is where it's most useful. This would support the use case presented here: https://store.kde.org/p/1156273 and here: https://bugs.kde.org/show_bug.cgi?id=384411 Regarding those use cases, are you planning to add a list of recent folders to the Select Folder dialog, too? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7446 To: ngraham, #dolphin, #kde_applications, broulik, elvisangelaccio, dfaure, emmanuelp Cc: gregormi, markg, alexeymin, #frameworks, broulik, elvisangelaccio, dfaure, davidedmundson, ltoscano, #konqueror, akrutzler, navarromorales, firef, andrebarros, emmanuelp
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a comment. In https://phabricator.kde.org/D7130#133389, @elvisangelaccio wrote: > In https://phabricator.kde.org/D7130#132809, @gregormi wrote: > > > Hmm, this looks fine. Actually, KMoreTools uses KService to find out if an application is installed by passing the desktop filename (without extension), i.e. "org.kde.filelight" or "org.kde.partitionmanager" (KService::serviceByDesktopName(desktopEntryName)). I did not fully understand how it works internally. It uses some caching mechanism. Could you run kbuildsycoca5 or relogin and try again? I have no idea how I should reproduce it here on my machine because it works here. When dealing with KService I got the impression that it is hard to find out why a particular service (desktop file) is _not_ found. > > > Right, worked after a kbuildsycoca5 run. > I guess +1 from my side, but this will break again as soon as one of the desktop files changes upstream. Great :). Yes, it will break again... but... the desktop file name reflects the application or component ID (see https://www.freedesktop.org/software/appstream/docs/chap-Quickstart.html#sect-Quickstart-DesktopApps) and this is presumably the most stable part of an application (after consolidating all the old names to the reverse-DNS scheme). Who will give the final Ship it? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a comment. In https://phabricator.kde.org/D7130#132857, @ltoscano wrote: > In https://phabricator.kde.org/D7130#132425, @gregormi wrote: > > > In https://phabricator.kde.org/D7130#132409, @ltoscano wrote: > > > > > Just update the English messages. > > > More generally, why do we need copies of the system desktop files (even the ones developed by KDE, org.kde.filelight.desktop?) Isn't there a way to use the existing desktop files if installed? We don't want to duplicate what exists. > > > > > > KMoreTools provides information about applications (gives hints about their existence) that are maybe not installed yet. Back then, the idea was to reuse the translations in the desktop files. Do the duplicate desktop files cause duplicate translation work? > > Personally, I also find the desktop file handling a bit clumsy, but currently I have no better idea. > > > It may be duplicated work for translations from KDE (translation memory helps, but the message can be non aligned anyway). > This role (show information of non-installed tool) is better suited for appdata. AppData: yes, I also think that these files provide more detailed information and support should be added in the future. The duplicate translation problem would remain, though, wouldn't it? Is it possible to exclude a whole directory from translation? (There one could put pretranslated files taken from the current distribution of the developer) REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a comment. In https://phabricator.kde.org/D7130#132762, @elvisangelaccio wrote: > In https://phabricator.kde.org/D7130#132742, @gregormi wrote: > > > In https://phabricator.kde.org/D7130#132640, @elvisangelaccio wrote: > > > > > It doesn't seem to fix the bug here, it's still saying that filelight and partitionmanager are not installed (but they are). > > > > > > Can you tell me what distro you are using and maybe the full path to the installed desktop files of filelight and partitionmanager > > > > > /usr/share/applications/org.kde.filelight.desktop > /usr/share/applications/org.kde.partitionmanager.desktop > > > (on archlinux) Hmm, this looks fine. Actually, KMoreTools uses KService to find out if an application is installed by passing the desktop filename (without extension), i.e. "org.kde.filelight" or "org.kde.partitionmanager" (KService::serviceByDesktopName(desktopEntryName)). I did not fully understand how it works internally. It uses some caching mechanism. Could you run kbuildsycoca5 or relogin and try again? I have no idea how I should reproduce it here on my machine because it works here. When dealing with KService I got the impression that it is hard to find out why a particular service (desktop file) is _not_ found. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a comment. In https://phabricator.kde.org/D7130#132640, @elvisangelaccio wrote: > It doesn't seem to fix the bug here, it's still saying that filelight and partitionmanager are not installed (but they are). Can you tell me what distro you are using and maybe the full path to the installed desktop files of filelight and partitionmanager REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a comment. BUG: 369646 REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a reviewer: elvisangelaccio. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano, elvisangelaccio Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi updated this revision to Diff 17723. gregormi edited the summary of this revision. gregormi added a comment. - add FSearch and AngrySearch to search tools - Add new grouping "screenrecorder" with Peek and Simples Screen Recorder - Add new grouping "mouse-tools" - Add new grouping "font-tools" - Add new grouping "language-dictionary" REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7130?vs=17710=17723 BRANCH mydev REVISION DETAIL https://phabricator.kde.org/D7130 AFFECTED FILES autotests/kmoretools/kmoretoolstest.cpp data/kmoretools-desktopfiles/_INFO data/kmoretools-desktopfiles/_update_all_files.sh data/kmoretools-desktopfiles/angrysearch.desktop data/kmoretools-desktopfiles/catfish.desktop data/kmoretools-desktopfiles/com.uploadedlobster.peek.desktop data/kmoretools-desktopfiles/ding.desktop data/kmoretools-desktopfiles/disk.desktop data/kmoretools-desktopfiles/filelight.png data/kmoretools-desktopfiles/filelight.svg data/kmoretools-desktopfiles/fontinst.desktop data/kmoretools-desktopfiles/fontmatrix.desktop data/kmoretools-desktopfiles/fsearch.desktop data/kmoretools-desktopfiles/giggle.desktop data/kmoretools-desktopfiles/git-cola-folder-handler.desktop data/kmoretools-desktopfiles/git-cola.desktop data/kmoretools-desktopfiles/gitg.desktop data/kmoretools-desktopfiles/gnome-search-tool.desktop data/kmoretools-desktopfiles/gparted.desktop data/kmoretools-desktopfiles/gucharmap.desktop data/kmoretools-desktopfiles/htop.desktop data/kmoretools-desktopfiles/kdf.desktop data/kmoretools-desktopfiles/kding.desktop data/kmoretools-desktopfiles/kmousetool.desktop data/kmoretools-desktopfiles/ksystemlog.desktop data/kmoretools-desktopfiles/org.gnome.clocks.desktop data/kmoretools-desktopfiles/org.kde.KCharSelect.desktop data/kmoretools-desktopfiles/org.kde.PartitionManager.desktop data/kmoretools-desktopfiles/org.kde.filelight.desktop data/kmoretools-desktopfiles/org.kde.kdf.desktop data/kmoretools-desktopfiles/org.kde.kfind.desktop data/kmoretools-desktopfiles/org.kde.kscreengenie.desktop data/kmoretools-desktopfiles/org.kde.ksnapshot.desktop data/kmoretools-desktopfiles/org.kde.ksysguard.desktop data/kmoretools-desktopfiles/org.kde.ksystemlog.desktop data/kmoretools-desktopfiles/org.kde.ktimer.desktop data/kmoretools-desktopfiles/org.kde.partitionmanager.desktop data/kmoretools-desktopfiles/org.kde.spectacle.desktop data/kmoretools-desktopfiles/shutter.desktop data/kmoretools-desktopfiles/shutter.svg data/kmoretools-desktopfiles/simplescreenrecorder.desktop data/kmoretools-desktopfiles/xfce4-taskmanager.desktop src/kmoretools/kmoretoolspresets.cpp src/kmoretools/kmoretoolspresets.h tests/kmoretools/kmoretoolstest2.cpp tests/kmoretools/kmoretoolstest_interactive.cpp To: gregormi, ltoscano Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a comment. In https://phabricator.kde.org/D7130#132409, @ltoscano wrote: > Just update the English messages. > More generally, why do we need copies of the system desktop files (even the ones developed by KDE, org.kde.filelight.desktop?) Isn't there a way to use the existing desktop files if installed? We don't want to duplicate what exists. KMoreTools provides information about applications (gives hints about their existence) that are maybe not installed yet. Back then, the idea was to reuse the translations in the desktop files. Do the duplicate desktop files cause duplicate translation work? Personally, I also find the desktop file handling a bit clumsy, but currently I have no better idea. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi added a comment. In https://phabricator.kde.org/D7130#132397, @ltoscano wrote: > I think there is more than what you want: the translations of desktop are handled automatically by scripty. Thanks for the hint. I copied the desktop files from the system installation. I know that translations are updated automatically. But what should be done (i.e. remove the translations manually before checkin)? REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano Cc: ltoscano, #frameworks
D7130: KMoreTools: Update and fix desktopfiles
gregormi retitled this revision from "Update and fix desktopfiles" to "KMoreTools: Update and fix desktopfiles". gregormi edited the summary of this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D7130 To: gregormi, ltoscano Cc: ltoscano, #frameworks
D7130: Update and fix desktopfiles
gregormi created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R304 KNewStuff BRANCH mydev REVISION DETAIL https://phabricator.kde.org/D7130 AFFECTED FILES autotests/kmoretools/kmoretoolstest.cpp data/kmoretools-desktopfiles/_INFO data/kmoretools-desktopfiles/_update_all_files.sh data/kmoretools-desktopfiles/catfish.desktop data/kmoretools-desktopfiles/disk.desktop data/kmoretools-desktopfiles/filelight.png data/kmoretools-desktopfiles/filelight.svg data/kmoretools-desktopfiles/giggle.desktop data/kmoretools-desktopfiles/git-cola-folder-handler.desktop data/kmoretools-desktopfiles/git-cola.desktop data/kmoretools-desktopfiles/gitg.desktop data/kmoretools-desktopfiles/gnome-search-tool.desktop data/kmoretools-desktopfiles/gparted.desktop data/kmoretools-desktopfiles/htop.desktop data/kmoretools-desktopfiles/kdf.desktop data/kmoretools-desktopfiles/ksystemlog.desktop data/kmoretools-desktopfiles/org.gnome.clocks.desktop data/kmoretools-desktopfiles/org.kde.PartitionManager.desktop data/kmoretools-desktopfiles/org.kde.filelight.desktop data/kmoretools-desktopfiles/org.kde.kdf.desktop data/kmoretools-desktopfiles/org.kde.kfind.desktop data/kmoretools-desktopfiles/org.kde.kscreengenie.desktop data/kmoretools-desktopfiles/org.kde.ksnapshot.desktop data/kmoretools-desktopfiles/org.kde.ksysguard.desktop data/kmoretools-desktopfiles/org.kde.ksystemlog.desktop data/kmoretools-desktopfiles/org.kde.ktimer.desktop data/kmoretools-desktopfiles/org.kde.partitionmanager.desktop data/kmoretools-desktopfiles/org.kde.spectacle.desktop data/kmoretools-desktopfiles/shutter.desktop data/kmoretools-desktopfiles/shutter.svg data/kmoretools-desktopfiles/xfce4-taskmanager.desktop src/kmoretools/kmoretoolspresets.cpp tests/kmoretools/kmoretoolstest2.cpp tests/kmoretools/kmoretoolstest_interactive.cpp To: gregormi Cc: #frameworks
