D18915: Fix batchrename changing extension to lower case

[David Faure]

dfaure added a comment.


  The fix will be in 5.15.1.
  Can you add Qt version checks if you intend to keep the KIO workaround?
  Or we just say it's fixed in Qt and we discard this. Your choice. But the 
unittest would make sense to keep (with Qt version checks, if there's no 
workaround).

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji, dfaure
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
LeGast00n, cblack, michaelh

D18915: Fix batchrename changing extension to lower case

[David Faure]

dfaure added a comment.


  The fix landed in dev.
  
  I now uploaded a backport to 5.15 for review.
  https://codereview.qt-project.org/c/qt/qtbase/+/302532

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji, dfaure
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
LeGast00n, cblack, michaelh

D18915: Fix batchrename changing extension to lower case

[David Faure]

dfaure added a comment.


  Let's see which branch this ends up in, don't use 5, 14, 0 just yet, it might 
end up in 5.13.2.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji, dfaure
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh

D18915: Fix batchrename changing extension to lower case

[David Faure]

dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.


  Good catch, but then this is a bug in QMimeDatabase::suffixForFileName.
  
  I just submitted a fix at 
https://codereview.qt-project.org/c/qt/qtbase/+/274548 -- aiming at the 5.14 
branch.
  
  So this commit is still valid of course, but it would be good to use #if 
QT_VERSION < QT_VERSION_CHECK(5, 14, 0) around the workaround, so that it goes 
away once we use a Qt version with the fix.
  AFAICS the workaround is only the use of "extensionLen", though (that's what 
should be ifdef'ed). This commit doesn't only fix casing, it also fixes the 
case of unknown extensions. That's valid and can be kept, no matter which Qt 
version we're using.
  
  I don't understand the comment about right-to-left languages in the commit 
log; this isn't using any locale-dependent APIs, is it?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji, dfaure
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh

D18915: Fix batchrename changing extension to lower case

[Ahmad Samir]

ahmadsamir added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji, dfaure
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
LeGast00n, GB_2, michaelh

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster added a comment.


  What needs to happen now for this to be accepted?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
michaelh

D18915: Fix batchrename changing extension to lower case

[Stefan Brüns]

bruns added a comment.


  LGTM

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
michaelh

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster updated this revision to Diff 54269.
cfoster added a comment.


  - Add unit tests.

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18915?vs=53914=54269

BRANCH
  arcpatch-D18915

REVISION DETAIL
  https://phabricator.kde.org/D18915

AFFECTED FILES
  autotests/batchrenamejobtest.cpp
  src/core/batchrenamejob.cpp

To: cfoster, #dolphin, #frameworks, abalaji
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
michaelh

D18915: Fix batchrename changing extension to lower case

[Stefan Brüns]

bruns added a comment.


  Now, a unit test would be nice ...

INLINE COMMENTS

> batchrenamejob.cpp:177
> +}
> +return QStringLiteral();
> +}

This should be `return QString();`, wont get any cheaper than that.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
michaelh

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster updated this revision to Diff 53914.
cfoster added a comment.


  - Pass QString by reference

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18915?vs=53068=53914

BRANCH
  arcpatch-D18915

REVISION DETAIL
  https://phabricator.kde.org/D18915

AFFECTED FILES
  src/core/batchrenamejob.cpp

To: cfoster, #dolphin, #frameworks, abalaji
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
michaelh

D18915: Fix batchrename changing extension to lower case

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> batchrenamejob.cpp:170
> +if (extensionLen) {
> +extension = filename.right(extensionLen);
> +} else {

You can just return here.

> batchrenamejob.cpp:175
> +if (dotIndex != -1) {
> +extension = filename.mid(dotIndex+1);
> +}

just return

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
michaelh

D18915: Fix batchrename changing extension to lower case

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> cfeck wrote in batchrenamejob.cpp:165
> Function/method names are usually lowercase. Also, we don't add `get` for 
> getters, only `set` for setters.
> 
> ⇒ `fileExtension()` ?
> 
> Additionally, we pass QString via reference
> 
> ⇒ `QString ` ?

Actually, const reference:

`const QString `

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
michaelh

D18915: Fix batchrename changing extension to lower case

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> bruns wrote in batchrenamejob.cpp:165
> `QString extension = GetFileExtension(url.fileName());`
> ...
> `static QString BatchRenameJobPrivate::GetFileExtension(QString filename)`

Function/method names are usually lowercase. Also, we don't add `get` for 
getters, only `set` for setters.

⇒ `fileExtension()` ?

Additionally, we pass QString via reference

⇒ `QString ` ?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: cfeck, bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, 
michaelh

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster updated this revision to Diff 53068.
cfoster added a comment.


  - Change GetFileExtension to take QString

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18915?vs=52691=53068

BRANCH
  arcpatch-D18915

REVISION DETAIL
  https://phabricator.kde.org/D18915

AFFECTED FILES
  src/core/batchrenamejob.cpp

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster marked 6 inline comments as done.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> cfoster wrote in batchrenamejob.cpp:165
> Just making sure I understand you correctly.
> Are you saying I should change the function to take the filename as a QString 
> and extract the filename from the QUrl outside of the function or change 
> url.toDisplayString() to url.fileName() within the function?

`QString extension = GetFileExtension(url.fileName());`
...
`static QString BatchRenameJobPrivate::GetFileExtension(QString filename)`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster added inline comments.

INLINE COMMENTS

> bruns wrote in batchrenamejob.cpp:165
> I think you can use `QUrl::filename()`, and you should do it from the calling 
> code.

Just making sure I understand you correctly.
Are you saying I should change the function to take the filename as a QString 
and extract the filename from the QUrl outside of the function or change 
url.toDisplayString() to url.fileName() within the function?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> batchrenamejob.cpp:160
>  
> +//The function QMimeDatabase.suffixForFileName always converts the extension 
> to lower case
> +//This function is a wrapper which avoids the coversion to lower case

Space after `//`

> batchrenamejob.cpp:161
> +//The function QMimeDatabase.suffixForFileName always converts the extension 
> to lower case
> +//This function is a wrapper which avoids the coversion to lower case
> +QString BatchRenameJobPrivate::GetFileExtension(QUrl url)

helper, not wrapper

> batchrenamejob.cpp:161
> +//The function QMimeDatabase.suffixForFileName always converts the extension 
> to lower case
> +//This function is a wrapper which avoids the coversion to lower case
> +QString BatchRenameJobPrivate::GetFileExtension(QUrl url)

`co_n_version`

> batchrenamejob.cpp:165
> +QMimeDatabase db;
> +const size_t extensionLen = 
> db.suffixForFileName(url.toDisplayString()).length();
> + 

I think you can use `QUrl::filename()`, and you should do it from the calling 
code.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster updated this revision to Diff 52691.
cfoster added a comment.


  
  
  - Add function for getting extension All unit tests pass Manually tested 
invalid extensions. Files with no extensions and files with upper and lower 
case extensions

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18915?vs=52180=52691

BRANCH
  arcpatch-D18915

REVISION DETAIL
  https://phabricator.kde.org/D18915

AFFECTED FILES
  src/core/batchrenamejob.cpp

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

[Stefan Brüns]

bruns added a comment.


  And factor out the function, it is used in 2 places, and you can unit test it 
then.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

[Stefan Brüns]

bruns added a comment.


  In D18915#416402 , @cfoster wrote:
  
  > In D18915#416400 , @bruns wrote:
  >
  > > https://doc.qt.io/qt-5/qmimedatabase.html#suffixForFileName
  > >
  > > > Returns the suffix for the file fileName, as known by the MIME database.
  > > >  This allows to pre-select "tar.bz2" for foo.tar.bz2, but still only 
"txt" for my.file.with.dots.txt.
  >
  >
  > This was the original method of getting the file extension however it was 
converting the file extensions to lower case.
  >
  > This can be demonstrated with the following code:
  >  QMimeDatabase db;
  >  QUrl url = (QString) "foo.TXT";
  >  const QString extension = db.suffixForFileName(url.toDisplayString());
  >  qDebug(qUtf8Printable(extension)); //outputs "txt"
  
  
  Just compare the extension after `.toLower()`, and if both match, keep the 
original one.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster added a comment.


  In D18915#416400 , @bruns wrote:
  
  > https://doc.qt.io/qt-5/qmimedatabase.html#suffixForFileName
  >
  > > Returns the suffix for the file fileName, as known by the MIME database.
  > >  This allows to pre-select "tar.bz2" for foo.tar.bz2, but still only 
"txt" for my.file.with.dots.txt.
  
  
  This was the original method of getting the file extension however it was 
converting the file extensions to lower case.
  
  This can be demonstrated with the following code:
  QMimeDatabase db;
  QUrl url = (QString) "foo.TXT";
  const QString extension = db.suffixForFileName(url.toDisplayString());
  qDebug(qUtf8Printable(extension)); //outputs "txt"

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

[Stefan Brüns]

bruns added a comment.


  https://doc.qt.io/qt-5/qmimedatabase.html#suffixForFileName
  
  > Returns the suffix for the file fileName, as known by the MIME database.
  >  This allows to pre-select "tar.bz2" for foo.tar.bz2, but still only "txt" 
for my.file.with.dots.txt.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: bruns, ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster added inline comments.

INLINE COMMENTS

> ngraham wrote in batchrenamejob.cpp:181
> Is it?
> 
> `file.tar.gz`

Ah yes... very good point...
I think have to rethink how to solve this.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh, bruns

D18915: Fix batchrename changing extension to lower case

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> batchrenamejob.cpp:181
> +
> + //If the oldFileName contains a '.' then its extension is all to the 
> right of the last dot
> +int dotIndex = oldFileName.lastIndexOf(QStringLiteral("."));

Is it?

`file.tar.gz`

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: ngraham, elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh, bruns

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster updated this revision to Diff 52180.
cfoster added a comment.


  - Changes after review feedback

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18915?vs=51372=52180

BRANCH
  arcpatch-D18915_2

REVISION DETAIL
  https://phabricator.kde.org/D18915

AFFECTED FILES
  src/core/batchrenamejob.cpp

To: cfoster, #dolphin, #frameworks, abalaji
Cc: elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D18915: Fix batchrename changing extension to lower case

[Elvis Angelaccio]

elvisangelaccio added inline comments.

INLINE COMMENTS

> cfoster wrote in batchrenamejob.cpp:62
> Without the fromStdString() I get the following compilation error.
> 
> src/core/batchrenamejob.cpp:64:15: error: 'QString::QString(const char*)' is 
> private within this context
> 
>   QString dot= ".";
> 
> I must admit I don't fully understand the compilation error however adding 
> fromStdString seemed the most reasonable way to fix it.

Please use `QStringLiteral()` instead.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: elvisangelaccio, chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster added inline comments.

INLINE COMMENTS

> abalaji wrote in batchrenamejob.cpp:62
> You can just `QString dot = "."`, but you should use a single character 
> instead of a string, since it's just a single character

Without the fromStdString() I get the following compilation error.

src/core/batchrenamejob.cpp:64:15: error: 'QString::QString(const char*)' is 
private within this context

  QString dot= ".";

I must admit I don't fully understand the compilation error however adding 
fromStdString seemed the most reasonable way to fix it.

> abalaji wrote in batchrenamejob.cpp:64
> I wonder if just getting rid of `.toLower()` fixes this bug

I tested just removing the .toLower() however this didn't fix it. It seems that 
QMimeDatabase::suffixForFileName() converts it to lower case unless I 
overlooked something. See the code snippet below.

I tested this with the following lines in a standalone program:
QMimeDatabase db;
QUrl url = (QString) "foo.TXT";
const QString extension = db.suffixForFileName(url.toDisplayString());
qDebug(qUtf8Printable(extension)); //Outputs "txt"

> abalaji wrote in batchrenamejob.cpp:68
> Rather than using `contains` here, you can just use `lastIndexOf`, check if 
> it's not `-1`, and go from there. Just simply `urlStr.lastIndexOf('.')`.

Fair point will do.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D18915: Fix batchrename changing extension to lower case

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> abalaji wrote in batchrenamejob.cpp:64
> I wonder if just getting rid of `.toLower()` fixes this bug

I agree with @abalaji here. Modifying the code around this line should fix the 
bug and also address my previous comment.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D18915: Fix batchrename changing extension to lower case

[Ambareesh Balaji]

abalaji added a comment.


  Added a couple inline comments for you to address. Also, please use four 
spaces instead of tabs, and keep the spacing consistent (spaces around `+`, 
space between `if ()` and the `{). I have yet to run and test this, but if you 
check the comment on the left side of the diff, I wonder if just removing that 
`.toLower()` is enough.

INLINE COMMENTS

> batchrenamejob.cpp:62
>  QSet extensions;
> -QMimeDatabase db;
> + const QString dot = QString::fromStdString(".");
>  foreach (const QUrl , m_srcList) {

You can just `QString dot = "."`, but you should use a single character instead 
of a string, since it's just a single character

> batchrenamejob.cpp:64
>  foreach (const QUrl , m_srcList) {
> -const QString extension = 
> db.suffixForFileName(url.toDisplayString().toLower());
>  if (extensions.contains(extension)) {

I wonder if just getting rid of `.toLower()` fixes this bug

> batchrenamejob.cpp:68
> + //If the oldFileName contains a '.' then its extension is all to 
> the right of the last dot
> + if (urlStr.contains(dot)){
> + extension = urlStr.mid(urlStr.lastIndexOf(dot)+1);

Rather than using `contains` here, you can just use `lastIndexOf`, check if 
it's not `-1`, and go from there. Just simply `urlStr.lastIndexOf('.')`.

> batchrenamejob.cpp:179
> +
> + const QString dot = QString::fromStdString(".");
> + const QString oldFileName = oldUrl.fileName();

Same as above

> batchrenamejob.cpp:184
> + //If the oldFileName contains a '.' then its extension is all to the 
> right of the last dot
> + if (oldFileName.contains(dot)){
> + extension = oldFileName.mid(oldFileName.lastIndexOf(dot)+1);

Same as above

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D18915: Fix batchrename changing extension to lower case

[Chinmoy Ranjan Pradhan]

chinmoyr added a comment.


  @cfoster Thanks for the patch :)
  
  There's one more mass-rename related bug here:
  
  1. Create two files; one with a known extension (.cpp) and the other with a 
random extension (.xyz, anything not in mime db)
  2. Rename both.
  3. The extension (.xyz) is removed from second file.
  
  It is possible to add code for preserving the unknown extension in this patch 
itself. If not you can always create a new diff :)

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: chinmoyr, kde-frameworks-devel, michaelh, ngraham, bruns

D18915: Fix batchrename changing extension to lower case

[Nathaniel Graham]

ngraham edited the summary of this revision.
ngraham added reviewers: Dolphin, Frameworks, abalaji.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D18915

To: cfoster, #dolphin, #frameworks, abalaji
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D18915: Fix batchrename changing extension to lower case

[cfoster]

cfoster created this revision.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
cfoster requested review of this revision.

REVISION SUMMARY
  Files renamed with Dolphins batch rename would have their file
  extensions always converted to lower case.
  
  New method of getting the file extension may not work with a right
  to left language such as Arabic
  
  Resolves: #402388

TEST PLAN
  1. Open Dolphin
  2. Create files "foo.TXT" and "bar.TXT"
  3. Batch rename (F2) to name "x"
  4. Check files are now named "x1.TXT" and "x2.TXT"

REPOSITORY
  R241 KIO

BRANCH
  FileExtensionCase (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18915

AFFECTED FILES
  src/core/batchrenamejob.cpp

To: cfoster
Cc: kde-frameworks-devel, michaelh, ngraham, bruns