[Libreoffice-commits] .: autodoc/source
autodoc/source/parser_i/idl/tk_keyw.cxx | 10 +-
autodoc/source/parser_i/idl/tk_punct.cxx |2 +-
autodoc/source/parser_i/idoc/tk_atag2.cxx |2 +-
autodoc/source/parser_i/idoc/tk_xml.cxx |6 +++---
4 files changed, 10 insertions(+), 10 deletions(-)
New commits:
commit 302bb2c4003745f40b075baaf2c66941b0c7f897
Author: Kristian Rietveld k...@lanedo.com
Date: Sat Oct 22 09:38:42 2011 +0200
Match the correct function template specialization
Fully specify the E_TokenId type instead of relying on the EV_TokenId
typedef.
diff --git a/autodoc/source/parser_i/idl/tk_keyw.cxx
b/autodoc/source/parser_i/idl/tk_keyw.cxx
index 408f83d..dd84301 100644
--- a/autodoc/source/parser_i/idl/tk_keyw.cxx
+++ b/autodoc/source/parser_i/idl/tk_keyw.cxx
@@ -107,15 +107,15 @@ namespace lux
{
template EnumValueMap
-TokBuiltInType::EV_TokenId::Values_() { return
G_aTokBuiltInType_EV_TokenId_Values; }
+EnumTokBuiltInType::E_TokenId::Values_() { return
G_aTokBuiltInType_EV_TokenId_Values; }
template EnumValueMap
-TokTypeModifier::EV_TokenId::Values_() { return
G_aTokTypeModifier_EV_TokenId_Values; }
+EnumTokTypeModifier::E_TokenId::Values_() { return
G_aTokTypeModifier_EV_TokenId_Values; }
template EnumValueMap
-TokMetaType::EV_TokenId::Values_() { return
G_aTokMetaType_EV_TokenId_Values; }
+EnumTokMetaType::E_TokenId::Values_() { return
G_aTokMetaType_EV_TokenId_Values; }
template EnumValueMap
-TokStereotype::EV_TokenId::Values_(){ return
G_aTokStereotype_EV_TokenId_Values; }
+EnumTokStereotype::E_TokenId::Values_(){ return
G_aTokStereotype_EV_TokenId_Values; }
template EnumValueMap
-TokParameterHandling::EV_TokenId::Values_() { return
G_aTokParameterHandling_EV_TokenId_Values; }
+EnumTokParameterHandling::E_TokenId::Values_() { return
G_aTokParameterHandling_EV_TokenId_Values; }
} // namespace lux
diff --git a/autodoc/source/parser_i/idl/tk_punct.cxx
b/autodoc/source/parser_i/idl/tk_punct.cxx
index e617473..f1a8680 100644
--- a/autodoc/source/parser_i/idl/tk_punct.cxx
+++ b/autodoc/source/parser_i/idl/tk_punct.cxx
@@ -61,7 +61,7 @@ TokPunctuation::EV_TokenId
Greater(TokPunctuation::Greater,);
namespace lux
{
template EnumValueMap
-TokPunctuation::EV_TokenId::Values_() { return
G_aTokPunctuation_EV_TokenId_Values; }
+EnumTokPunctuation::E_TokenId::Values_() { return
G_aTokPunctuation_EV_TokenId_Values; }
}
diff --git a/autodoc/source/parser_i/idoc/tk_atag2.cxx
b/autodoc/source/parser_i/idoc/tk_atag2.cxx
index 30264f6..4e0022b 100644
--- a/autodoc/source/parser_i/idoc/tk_atag2.cxx
+++ b/autodoc/source/parser_i/idoc/tk_atag2.cxx
@@ -58,7 +58,7 @@ Tok_AtTag::EV_TokenId ev_since(Tok_AtTag::since,@since);
namespace lux
{
template EnumValueMap
-Tok_AtTag::EV_TokenId::Values_(){ return G_aTokAtTag_EV_TokenId_Values; }
+EnumTok_AtTag::E_TokenId::Values_(){ return
G_aTokAtTag_EV_TokenId_Values; }
}
diff --git a/autodoc/source/parser_i/idoc/tk_xml.cxx
b/autodoc/source/parser_i/idoc/tk_xml.cxx
index a1f60d0..c4cc9ce 100644
--- a/autodoc/source/parser_i/idoc/tk_xml.cxx
+++ b/autodoc/source/parser_i/idoc/tk_xml.cxx
@@ -62,11 +62,11 @@ namespace lux
{
template EnumValueMap
-Tok_XmlConst::EV_TokenId::Values_() { return
G_aTok_XmlConst_EV_TokenId_Values; }
+EnumTok_XmlConst::E_TokenId::Values_() { return
G_aTok_XmlConst_EV_TokenId_Values; }
template EnumValueMap
-Tok_XmlLink_Tag::EV_TokenId::Values_() { return
G_aTok_XmlLink_Tag_EV_TokenId_Values; }
+EnumTok_XmlLink_Tag::E_TokenId::Values_() { return
G_aTok_XmlLink_Tag_EV_TokenId_Values; }
template EnumValueMap
-Tok_XmlFormat_Tag::EV_TokenId::Values_(){ return
G_aTok_XmlFormat_Tag_EV_TokenId_Values; }
+EnumTok_XmlFormat_Tag::E_TokenId::Values_(){ return
G_aTok_XmlFormat_Tag_EV_TokenId_Values; }
} // namespace lux
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: chart2/source
chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx | 17
++
1 file changed, 11 insertions(+), 6 deletions(-)
New commits:
commit 8cff18bee2a560c682b5c54d8f68c8bf9d8a69a8
Author: Kristian Rietveld k...@lanedo.com
Date: Sat Oct 22 09:39:12 2011 +0200
Put neq-operator for awt::Size in correct namespace
diff --git
a/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx
b/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx
index f9062ba..aa156b2 100644
--- a/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx
+++ b/chart2/source/controller/chartapiwrapper/WrappedSymbolProperties.cxx
@@ -61,6 +61,17 @@ using ::com::sun::star::uno::Sequence;
using ::com::sun::star::beans::Property;
using ::rtl::OUString;
+
+namespace com { namespace sun { namespace star { namespace awt {
+
+// this operator is not defined by default
+bool operator!=( const awt::Size rSize1, const awt::Size rSize2 )
+{
+return (rSize1.Width != rSize2.Width) || (rSize1.Height != rSize2.Height);
+}
+
+} } } }
+
//.
namespace chart
{
@@ -97,12 +108,6 @@ public:
virtual ~WrappedSymbolBitmapURLProperty();
};
-// this operator is not defined by default
-bool operator!=( const awt::Size rSize1, const awt::Size rSize2 )
-{
-return (rSize1.Width != rSize2.Width) || (rSize1.Height != rSize2.Height);
-}
-
class WrappedSymbolSizeProperty : public WrappedSeriesOrDiagramProperty
awt::Size
{
public:
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: rsc/Executable_rsc.mk
rsc/Executable_rsc.mk |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 5f950b5d79d4567ae385fdf25de26b4d0e43e471 Author: Tor Lillqvist tlillqv...@suse.com Date: Mon Oct 24 10:02:50 2011 +0300 Make the use of gb_LinkTarget_EXCEPTIONFLAGS for the yacc source more reliable diff --git a/rsc/Executable_rsc.mk b/rsc/Executable_rsc.mk index e1ed345..1fcb2b4 100644 --- a/rsc/Executable_rsc.mk +++ b/rsc/Executable_rsc.mk @@ -58,7 +58,7 @@ $(eval $(call gb_Executable_add_grammars,rsc,\ rsc/source/parser/rscyacc \ )) -$(call gb_YaccTarget_get_target,rsc/source/parser/rscyacc): T_CXXFLAGS := $(gb_LinkTarget_EXCEPTIONFLAGS) $(gb_LinkTarget_CXXFLAGS) $(CXXFLAGS) +$(WORKDIR)/GenCxxObject/YaccTarget/rsc/source/parser/rscyacc.o: T_CXXFLAGS := $(gb_LinkTarget_EXCEPTIONFLAGS) $(gb_LinkTarget_CXXFLAGS) $(CXXFLAGS) $(eval $(call gb_Executable_add_exception_objects,rsc,\ rsc/source/parser/erscerr \ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: editeng/inc editeng/source
editeng/inc/editeng/svxacorr.hxx |2 +-
editeng/source/misc/svxacorr.cxx |6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
New commits:
commit d330483ad0106a750dec560b987c21aaa5394ab6
Author: Andras Timar ati...@suse.com
Date: Mon Oct 24 11:01:36 2011 +0200
autocorrect: non-breaking space before % in French fdo#41015
diff --git a/editeng/inc/editeng/svxacorr.hxx b/editeng/inc/editeng/svxacorr.hxx
index 0659b73..dd83531 100644
--- a/editeng/inc/editeng/svxacorr.hxx
+++ b/editeng/inc/editeng/svxacorr.hxx
@@ -53,7 +53,7 @@ class Window;
// Auto correct flags
const long CptlSttSntnc = 0x0001; // Capital letters at the
beginning of a sentence
const long CptlSttWrd = 0x0002; // not two Capital letters at the
beginning of a word
-const long AddNonBrkSpace = 0x0004; // Add non breaking space before
:;?!
+const long AddNonBrkSpace = 0x0004; // Add non breaking space before
:;?!%
const long ChgOrdinalNumber = 0x0008; // Ordinal-Number 1st, 2nd,..
const long ChgToEnEmDash= 0x0010; // - - Endash/Emdash
const long ChgWeightUnderl = 0x0020; // * - Bold, _ - Underscore
diff --git a/editeng/source/misc/svxacorr.cxx b/editeng/source/misc/svxacorr.cxx
index 7e53771..9c74713 100644
--- a/editeng/source/misc/svxacorr.cxx
+++ b/editeng/source/misc/svxacorr.cxx
@@ -297,14 +297,14 @@ sal_Bool SvxAutoCorrect::IsAutoCorrectChar( sal_Unicode
cChar )
{
return cChar == '\0' || cChar == '\t' || cChar == 0x0a ||
cChar == ' ' || cChar == '\'' || cChar == '\' ||
-cChar == '*' || cChar == '_' ||
+cChar == '*' || cChar == '_' || cChar == '%' ||
cChar == '.' || cChar == ',' || cChar == ';' ||
cChar == ':' || cChar == '?' || cChar == '!' || cChar == '/';
}
sal_Bool SvxAutoCorrect::NeedsHardspaceAutocorr( sal_Unicode cChar )
{
-return cChar == ';' || cChar == ':' || cChar == '?' || cChar == '!' ||
+return cChar == '%' || cChar == ';' || cChar == ':' || cChar == '?' ||
cChar == '!' ||
cChar == '/' /*case for the urls exception*/;
}
@@ -661,7 +661,7 @@ sal_Bool SvxAutoCorrect::FnAddNonBrkSpace(
if ( rLocale.Language == OUString(RTL_CONSTASCII_USTRINGPARAM( fr )) )
{
bool bFrCA = rLocale.Country == OUString(RTL_CONSTASCII_USTRINGPARAM(
CA ));
-OUString allChars = OUString(RTL_CONSTASCII_USTRINGPARAM( :;!? ));
+OUString allChars = OUString(RTL_CONSTASCII_USTRINGPARAM( :;?!% ));
OUString chars( allChars );
if ( bFrCA )
chars = OUString(RTL_CONSTASCII_USTRINGPARAM( : ));
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: svtools/source
svtools/source/misc/sampletext.cxx |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
New commits:
commit 21696eadc88f67b4900a580bcd90284b8f449e75
Author: Caolán McNamara caol...@redhat.com
Date: Mon Oct 24 11:06:01 2011 +0100
seperate words in hebrew text preview
diff --git a/svtools/source/misc/sampletext.cxx
b/svtools/source/misc/sampletext.cxx
index e1b52c9..33a49c6 100644
--- a/svtools/source/misc/sampletext.cxx
+++ b/svtools/source/misc/sampletext.cxx
@@ -145,9 +145,9 @@ rtl::OUString
makeShortRepresentativeTextForScript(UScriptCode eScript)
case USCRIPT_HEBREW:
{
const sal_Unicode aHebr[] = {
-0x05D0, 0x05B8, 0x05DC, 0x05B6, 0x05E3, 0x05D1, 0x05B5, 0x05BC,
-0x05D9, 0x05EA, 0x0020, 0x05E2, 0x05B4, 0x05D1, 0x05B0, 0x05E8,
-0x05B4, 0x05D9
+0x05D0, 0x05B8, 0x05DC, 0x05B6, 0x05E3, 0x05BE, 0x05D1, 0x05B5,
+0x05BC, 0x05D9, 0x05EA, 0x0020, 0x05E2, 0x05B4, 0x05D1, 0x05B0,
+0x05E8, 0x05B4, 0x05D9
};
sSampleText = rtl::OUString(aHebr, SAL_N_ELEMENTS(aHebr));
break;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/gtk3' - 0 commits -
Rebased ref, commits from common ancestor: ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] Changes to 'feature/gtk3'
New branch 'feature/gtk3' available with the following commits: commit ce7751fc108a6f8c91369f99be756204b7313a34 Author: Michael Meeks michael.me...@suse.com Date: Mon Oct 24 09:20:29 2011 +0100 gtk3: post merge fixups commit 9bceb3abb0548c3386a7970220cf0e4d644ebd67 Author: Michael Meeks michael.me...@suse.com Date: Fri Oct 21 15:47:23 2011 +0100 gtk3: caveats on using g_main_prepare for older glibs; needs re-work commit 28d66cfcf5b3e2c3488a07024dcbac1c40c5a937 Author: Michael Meeks michael.me...@suse.com Date: Fri Oct 21 15:27:17 2011 +0100 gtk3: add some missing SolarMutexGuards (thanks to mst for noticing) commit 65ab7497b1836b79017586891123572d121ef6ec Author: Michael Meeks michael.me...@suse.com Date: Thu Oct 20 21:49:40 2011 +0100 gtk3: fix cairo canvas crash for non X (or svp) backend commit bb9cc750cb3aa3a010e062c2ddd5f9c935fc81cd Author: Michael Meeks michael.me...@suse.com Date: Thu Oct 20 21:12:39 2011 +0100 gtk3: cleanup fullscreen unpleasantness commit a6c9db9d191e91625ebe0c07d01fc1a0c8135493 Author: Michael Meeks michael.me...@suse.com Date: Thu Oct 20 19:37:01 2011 +0100 generic: fix error trap push/pop/reset semantics commit b46e975514a522cb08ef5dc0683407d8521ca62a Author: Michael Meeks michael.me...@suse.com Date: Thu Oct 20 17:22:19 2011 +0100 generic: fix misc. initialization problems simplify a little commit 3aec0236dbb92b0ea0e984c77249ff2c53e0eb4f Author: Michael Meeks michael.me...@suse.com Date: Wed Oct 19 15:21:29 2011 +0100 generic: undo attempt at cross-platform headless for now commit 73340626acce095c3ce52b4e8e6a19cbb5b4cb4d Author: Michael Meeks michael.me...@suse.com Date: Fri Oct 7 21:35:14 2011 +0100 cleanup some missing conditionals causing problems for mac commit f11d3faddacf5a37675cdf0e6b203ef87b507c48 Author: Michael Meeks michael.me...@suse.com Date: Mon Oct 17 17:21:41 2011 +0100 gtk3: fix display changed signal emissions commit ecbf69a110f308e27339ac4630bd357a3359a276 Author: Michael Meeks michael.me...@suse.com Date: Tue Oct 11 17:46:05 2011 +0100 gtk3: substantial performance win for editing document headers commit 0e0bdb27c37d52e6f2612ad62cc9385d8188b3ed Author: Michael Meeks michael.me...@suse.com Date: Mon Oct 10 11:55:14 2011 +0100 generic: overcome Mac specific build errors commit d4b300814d7a93abe012ebd5ce0fbee8ce6c2c97 Author: Michael Meeks michael.me...@suse.com Date: Mon Oct 10 11:25:42 2011 +0100 headless: add required clip map reset for simpler clipping cases commit 1eb02c98a3cbb0bf6e0804ed063cf1b9d6c30f57 Author: Michael Meeks michael.me...@suse.com Date: Sat Oct 8 15:37:32 2011 +0100 basebmp: B2IRange::isEmpty is surprisingly, unhelpfully lame - workaround commit f94e6da896cab5301233cfa3bd13e3f828aed7ba Author: Michael Meeks michael.me...@suse.com Date: Fri Oct 7 17:29:49 2011 +0100 generic: more unix conditional compilation pieces and win32 porting commit 6fdd8449a6da74de19de31ed5ad28e3a122c8228 Author: Michael Meeks michael.me...@suse.com Date: Fri Oct 7 12:41:35 2011 +0100 generic: share the PspGraphics code between gtk/unx and svp commit fa05744126bdcfa15c34eab5b12c7ae5987c9769 Author: Michael Meeks michael.me...@suse.com Date: Fri Oct 7 11:29:18 2011 +0100 WaE: cleanup misc. redundant warnings, and silence the gtk2 case commit 46fda3687b094ae68a4224742a5aa7c7f229886e Author: Michael Meeks michael.me...@suse.com Date: Fri Oct 7 10:43:17 2011 +0100 generic: remove mistaken m_aFrames hiding parent's frame list commit 470eb55a6dbdd576ef668ead8b166021ac522b5f Author: Michael Meeks michael.me...@suse.com Date: Thu Oct 6 22:22:39 2011 +0100 gtk3: make AnyInput to behave itself properly commit cfbdb8490d7e110cd8fc8d8a8e28a13b2abec66d Author: Michael Meeks michael.me...@suse.com Date: Mon Oct 3 20:06:35 2011 +0100 gtk3: fix gtk2 crash-on-exit regression commit bbffa4780a4f91ec75756311d0448faa31747955 Author: Michael Meeks michael.me...@suse.com Date: Mon Oct 3 20:00:17 2011 +0100 gtk3: try to improve AnyInput (absent toolkit support for it) commit 47bd9a6d7b26e3835df1458ba791d415e24ec310 Author: Michael Meeks michael.me...@suse.com Date: Mon Oct 3 16:36:26 2011 +0100 generic: re-work X error push/pop and error message handling commit 94593629fa1074e460cf485aa4dd5bb3ed45b986 Author: Michael Meeks michael.me...@suse.com Date: Mon Oct 3 15:16:32 2011 +0100 generic: try to cleanup SalXLib cruft some more commit a31e1394d7e4ed1e13d89019b07fe8b0f5e05383 Author: Michael Meeks michael.me...@suse.com Date: Mon Oct 3 12:21:34 2011 +0100 generic: create shared display class and re-factor to use it commit ae629bc363f17303dc28a7a96e2f4ded0f10282a Author: Michael Meeks michael.me...@suse.com Date: Fri Sep 30 18:00:13 2011 +0100 move SalYieldMutexReleaser into a more sensible place commit a2cbe860d4256cc6086113307df93e6ee1d5eea6 Author: Michael Meeks michael.me...@suse.com
[Libreoffice-commits] .: binfilter/bf_svtools binfilter/bf_svx
binfilter/bf_svtools/source/items1/svt_poolio.cxx |7 ---
binfilter/bf_svx/source/xoutdev/svx_xattr.cxx |1 -
2 files changed, 8 deletions(-)
New commits:
commit e8c71c5ae20d33f8aa3bf67296b71c955fd11b34
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Oct 24 13:02:29 2011 +0200
Removed erroneously pushed debug printfs.
diff --git a/binfilter/bf_svtools/source/items1/svt_poolio.cxx
b/binfilter/bf_svtools/source/items1/svt_poolio.cxx
index 98c5cce..0d453dc 100644
--- a/binfilter/bf_svtools/source/items1/svt_poolio.cxx
+++ b/binfilter/bf_svtools/source/items1/svt_poolio.cxx
@@ -114,7 +114,6 @@ void SfxItemPool::readTheItems (
SvStream rStream, USHORT nItemCount, USHORT nVersion,
SfxPoolItem * pDefItem, SfxPoolItemArray_Impl ** ppArr)
{
-/*SB*/fprintf(stderr,SfxItemPool::readTheItems %d
%d\n,(int)nItemCount,(int)nVersion);
SfxMultiRecordReader aItemsRec( rStream, SFX_ITEMPOOL_REC_ITEMS );
SfxPoolItemArray_Impl *pNewArr = new SfxPoolItemArray_Impl( nItemCount );
@@ -137,7 +136,6 @@ void SfxItemPool::readTheItems (
USHORT nRef(0);
rStream nRef;
-/*SB*/fprintf(stderr,... X\n);
pItem = pDefItem-Create(rStream, nVersion);
pNewArr-C40_INSERT(SfxPoolItem, pItem, nSurrogate);
@@ -371,10 +369,8 @@ SvStream SfxItemPool::Load(SvStream rStream)
nWhich = GetNewWhich( nWhich );
// unbekanntes Item aus neuerer Version
-/*SB*/fprintf(stderr,nWhich = %d\n,(int)nWhich);
if ( !IsInRange(nWhich) )
continue;
-/*SB*/fprintf(stderr, ,,,\n);
rStream nVersion;
rStream nCount;
@@ -1163,7 +1159,6 @@ const SfxPoolItem* SfxItemPool::LoadItem( SvStream
rStream, bool bDirect,
{
USHORT nWhich=0, nSlot=0; // nSurrogate;
rStream nWhich nSlot;
-/*SB*/fprintf(stderr,A nWhich = %d\n,(int)nWhich);
BOOL bDontPut = (SfxItemPool*)-1 == pRefPool;
if ( bDontPut || !pRefPool )
@@ -1193,7 +1188,6 @@ const SfxPoolItem* SfxItemPool::LoadItem( SvStream
rStream, bool bDirect,
if ( !bCurVersion )
// Which-Id auf neue Version mappen
nWhich = pRefPool-GetNewWhich( nWhich );
-/*SB*/fprintf(stderr,B nWhich = %d\n,(int)nWhich);
DBG_ASSERT( !nWhich || !pImp-bInSetItem ||
!pRefPool-ppStaticDefaults[pRefPool-GetIndex_Impl(nWhich)]-ISA(SfxSetItem),
@@ -1227,7 +1221,6 @@ const SfxPoolItem* SfxItemPool::LoadItem( SvStream
rStream, bool bDirect,
// Item direkt laden
SfxPoolItem *pNewItem =
pRefPool-GetDefaultItem(nWhich).Create(rStream, nVersion);
-/*SB*/fprintf(stderr,C nWhich = %d, pNewItem = %p\n,(int)nWhich,pNewItem);
if ( bDontPut )
pItem = pNewItem;
else
diff --git a/binfilter/bf_svx/source/xoutdev/svx_xattr.cxx
b/binfilter/bf_svx/source/xoutdev/svx_xattr.cxx
index 5c2f357..3f11fd3 100644
--- a/binfilter/bf_svx/source/xoutdev/svx_xattr.cxx
+++ b/binfilter/bf_svx/source/xoutdev/svx_xattr.cxx
@@ -3880,7 +3880,6 @@ const XHatch XFillHatchItem::GetValue() const
/*N*/ SfxPoolItem* XFillAttrSetItem::Create( SvStream rStream, USHORT
/*nVersion*/ ) const
/*N*/ {
-/*SB*/fprintf(stderr,XFillAttrSetItem::Create\n);
/*N*/ SfxItemSet* _pSet = new SfxItemSet( *GetItemSet().GetPool(),
/*N*/ XATTR_FILL_FIRST, XATTR_FILL_LAST);
/*N*/ _pSet-Load( rStream );
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - comphelper/inc comphelper/source toolkit/source unotools/inc unotools/source vcl/inc vcl/source vcl/unx xmloff/inc xmloff/source
comphelper/inc/comphelper/accessiblecontexthelper.hxx |3 +
comphelper/source/misc/accessiblecontexthelper.cxx|2 +
toolkit/source/awt/forward.hxx|6 +--
unotools/inc/unotools/options.hxx |2 +
unotools/source/config/options.cxx|2 +
vcl/inc/fontcache.hxx |4 +-
vcl/inc/printergfx.hxx|4 +-
vcl/inc/unx/salgdi.h | 28 +-
vcl/source/app/settings.cxx | 18 ++-
vcl/source/gdi/pdfwriter_impl.cxx |2 -
vcl/source/window/splitwin.cxx| 12 ---
vcl/source/window/toolbox.cxx | 19
vcl/unx/generic/printer/ppdparser.cxx |7
vcl/unx/gtk/gdi/salnativewidgets-gtk.cxx |8 ++---
xmloff/inc/xmloff/maptype.hxx |2 -
xmloff/source/transform/TransformerActionInit.hxx |2 -
16 files changed, 40 insertions(+), 81 deletions(-)
New commits:
commit 81448039ea3f757fcdfc2212a02b0ecf56b7c821
Author: Kristian Rietveld k...@lanedo.com
Date: Sat Oct 22 10:10:28 2011 +0200
Also use .NET2003 build fix for Clang
diff --git a/toolkit/source/awt/forward.hxx b/toolkit/source/awt/forward.hxx
index ab39b40..efb22e7 100644
--- a/toolkit/source/awt/forward.hxx
+++ b/toolkit/source/awt/forward.hxx
@@ -64,12 +64,12 @@
return aReturn; \
}
-#if defined (_MSC_VER) (_MSC_VER = 1310)
+#if (defined (_MSC_VER) (_MSC_VER = 1310)) || defined (__clang__)
// Windows .Net2003 build fix
#define W3K_EXPLICIT_CAST(x) static_cast XWindow2* (x)
-#else // !(defined (_MSC_VER) (_MSC_VER = 1310))
+#else // !((defined (_MSC_VER) (_MSC_VER = 1310)) || defined (__clang__))
#define W3K_EXPLICIT_CAST(x) x
-#endif // !(defined (_MSC_VER) (_MSC_VER = 1310))
+#endif // !((defined (_MSC_VER) (_MSC_VER = 1310)) || defined (__clang__))
#endif /* AWT_FORWARD_HXX */
commit c31d7b012f953f4a677fd5a576c0aa8379897879
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Oct 24 12:27:16 2011 +0200
Some warning cleanup (found with trunk Clang).
diff --git a/comphelper/inc/comphelper/accessiblecontexthelper.hxx
b/comphelper/inc/comphelper/accessiblecontexthelper.hxx
index b80805d..3f02666 100644
--- a/comphelper/inc/comphelper/accessiblecontexthelper.hxx
+++ b/comphelper/inc/comphelper/accessiblecontexthelper.hxx
@@ -52,9 +52,10 @@ namespace comphelper
/** abstract interface for implementing a mutex
*/
-class IMutex
+class COMPHELPER_DLLPUBLIC IMutex
{
public:
+virtual ~IMutex();
virtual void acquire() = 0;
virtual void release() = 0;
};
diff --git a/comphelper/source/misc/accessiblecontexthelper.cxx
b/comphelper/source/misc/accessiblecontexthelper.cxx
index 4d2a7d9..980fa36 100644
--- a/comphelper/source/misc/accessiblecontexthelper.cxx
+++ b/comphelper/source/misc/accessiblecontexthelper.cxx
@@ -44,6 +44,8 @@ namespace comphelper
using namespace ::com::sun::star::lang;
using namespace ::com::sun::star::accessibility;
+IMutex::~IMutex() {}
+
//=
//= OContextHelper_Impl
//=
diff --git a/unotools/inc/unotools/options.hxx
b/unotools/inc/unotools/options.hxx
index d743e95..3c032c2 100644
--- a/unotools/inc/unotools/options.hxx
+++ b/unotools/inc/unotools/options.hxx
@@ -50,6 +50,8 @@ namespace utl {
class UNOTOOLS_DLLPUBLIC ConfigurationListener
{
public:
+virtual ~ConfigurationListener();
+
virtual void ConfigurationChanged( ConfigurationBroadcaster* p,
sal_uInt32 nHint=0 ) = 0;
};
typedef ::std::vector ConfigurationListener*
IMPL_ConfigurationListenerList;
diff --git a/unotools/source/config/options.cxx
b/unotools/source/config/options.cxx
index 5eee90d..6fc5d98 100644
--- a/unotools/source/config/options.cxx
+++ b/unotools/source/config/options.cxx
@@ -35,6 +35,8 @@
using utl::detail::Options;
using utl::ConfigurationBroadcaster;
+utl::ConfigurationListener::~ConfigurationListener() {}
+
ConfigurationBroadcaster::ConfigurationBroadcaster()
: mpList(0)
, m_nBroadcastBlocked( 0 )
diff --git a/vcl/inc/fontcache.hxx b/vcl/inc/fontcache.hxx
index ad261e8..fd1b8cd 100644
--- a/vcl/inc/fontcache.hxx
+++ b/vcl/inc/fontcache.hxx
@@ -42,9 +42,9 @@ namespace psp
class VCL_PLUGIN_PUBLIC FontCache
{
struct FontDir;
-friend class FontDir;
+friend struct FontDir;
struct FontFile;
-friend class FontFile;
+friend struct FontFile;
typedef std::list PrintFontManager::PrintFont* FontCacheEntry;
struct FontFile
diff --git a/vcl/inc/printergfx.hxx b/vcl/inc/printergfx.hxx
index 7fea405..840054a 100644
--- a/vcl/inc/printergfx.hxx
[Libreoffice-commits] .: solenv/bin
solenv/bin/linkoo | 27 +--
1 file changed, 25 insertions(+), 2 deletions(-)
New commits:
commit f17c10545fabefd027b278798840706f2dbf4a04
Author: David Tardon dtar...@redhat.com
Date: Mon Oct 24 13:52:57 2011 +0200
create links to gdb autoloaders in the right dir
diff --git a/solenv/bin/linkoo b/solenv/bin/linkoo
index 1c22cb0..c39237f 100755
--- a/solenv/bin/linkoo
+++ b/solenv/bin/linkoo
@@ -341,11 +341,34 @@ sub evilness($)
}
}
+sub do_link_gdb_py($$$)
+{
+my $srcdir = shift;
+my $libdir = shift;
+my $loader = shift;
+
+my $lib = $loader =~ s/-gdb.py$//r;
+my $destdir = $libdir;
+# Autoloader for a library is looked for in the same directory the library
+# is (the library, not a symlink to it). Therefore it does not help to link
+# it from solver into install, because there is only a symlink in install
+# anyway. Instead, we must follow the link.
+if (-l $libdir/$lib) {
+$destdir = readlink ($libdir/$lib);
+$destdir =~ s@/[^/]*$@@;
+}
+
+if ($destdir ne $srcdir) {
+do_link ($srcdir, $destdir, $loader, $loader, 1);
+}
+}
+
sub link_gdb_py()
{
return if ($TARGET eq 'wntgcci.pro');
print Special gdb.py helpers case: ;
+
my $dirh;
my @basis;
my @ure;
@@ -365,10 +388,10 @@ sub link_gdb_py()
print STDERR Warning: missing helpful python debug helpers\n;
} else {
for my $c (@basis) {
- do_link ($src, $OOO_INSTALL/program, $c, $c, 1);
+ do_link_gdb_py ($src, $OOO_INSTALL/program, $c);
}
for my $c (@ure) {
- do_link ($src, $OOO_INSTALL/ure/lib, $c, $c, 1);
+ do_link_gdb_py ($src, $OOO_INSTALL/ure/lib, $c);
}
}
print \n;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'feature/gtk3' - 4 commits - vcl/inc vcl/unx
vcl/inc/unx/gtk/gtkgdi.hxx| 12 ++-
vcl/inc/vcl/sysdata.hxx |1
vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx | 90 ++
3 files changed, 85 insertions(+), 18 deletions(-)
New commits:
commit 38069129838811512e4dfc5ec459d46779bb96bf
Author: Lucas Baudin xapa...@gmail.com
Date: Mon Oct 24 14:23:18 2011 +0200
gtk3: add cstddef to vcl/inc/vcl/sysdata.hxx, it seems that g++ 4.6.1
doesn't like to have 'NULL' in plan C++ without this include
diff --git a/vcl/inc/vcl/sysdata.hxx b/vcl/inc/vcl/sysdata.hxx
index 59a174d..4e4e71f 100644
--- a/vcl/inc/vcl/sysdata.hxx
+++ b/vcl/inc/vcl/sysdata.hxx
@@ -30,6 +30,7 @@
#define _SV_SYSDATA_HXX
#include vector
+#include cstddef
#ifdef QUARTZ
// predeclare the native classes to avoid header/include problems
commit a94ac9b347f004d0dd7b793c1da8e14c6eef9e34
Author: Lucas Baudin xapa...@gmail.com
Date: Sat Oct 22 18:07:07 2011 +0200
gtk3: Use some static variable in GtkSalGraphics in order to avoid
re-loading all GtkStylaContexts
diff --git a/vcl/inc/unx/gtk/gtkgdi.hxx b/vcl/inc/unx/gtk/gtkgdi.hxx
index 6ca6c47..4604751 100644
--- a/vcl/inc/unx/gtk/gtkgdi.hxx
+++ b/vcl/inc/unx/gtk/gtkgdi.hxx
@@ -66,16 +66,17 @@ public:
void updateSettings( AllSettings rSettings );
private:
GtkWidget *mpWindow;
-GtkStyleContext *mpButtonStyle;
-GtkStyleContext *mpEntryStyle;
-GtkStyleContext *mpScrollbarStyle;
-GtkStyleContext *mpToolbarStyle;
-GtkStyleContext *mpToolButtonStyle;
-GtkStyleContext *mpCheckButtonStyle;
+static GtkStyleContext *mpButtonStyle;
+static GtkStyleContext *mpEntryStyle;
+static GtkStyleContext *mpScrollbarStyle;
+static GtkStyleContext *mpToolbarStyle;
+static GtkStyleContext *mpToolButtonStyle;
+static GtkStyleContext *mpCheckButtonStyle;
void renderAreaToPix( cairo_t* cr, cairo_rectangle_t* rect );
void drawStyleContext( GtkStyleContext* style, GtkStateFlags flags,
const Rectangle rControlRegion, bool render_background = true );
void getStyleContext( GtkStyleContext** style, GtkWidget* widget );
+static bool style_loaded;
};
#else
diff --git a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
index a5877dd..fb88bc4 100644
--- a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
+++ b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
@@ -34,6 +34,13 @@
#include unx/gtk/gtkinst.hxx
#include unx/gtk/gtkgdi.hxx
+GtkStyleContext* GtkSalGraphics::mpButtonStyle = NULL;
+GtkStyleContext* GtkSalGraphics::mpEntryStyle = NULL;
+GtkStyleContext* GtkSalGraphics::mpScrollbarStyle = NULL;
+GtkStyleContext* GtkSalGraphics::mpToolbarStyle = NULL;
+GtkStyleContext* GtkSalGraphics::mpToolButtonStyle = NULL;
+GtkStyleContext* GtkSalGraphics::mpCheckButtonStyle = NULL;
+bool GtkSalGraphics::style_loaded = false;
/
* State conversion
/
@@ -107,11 +114,11 @@ void GtkSalGraphics::drawStyleContext( GtkStyleContext*
style, GtkStateFlags fla
*/
gtk_render_background(gtk_widget_get_style_context(mpWindow),
cr,
--2, -2,
-rControlRegion.GetWidth() + 6, rControlRegion.GetHeight() + 6);
+1, -2,
+rControlRegion.GetWidth(), rControlRegion.GetHeight() + 6);
gtk_render_background(mpToolbarStyle, cr,
--4, -4,
-rControlRegion.GetWidth() + 8, rControlRegion.GetHeight() + 8);
+1, -4,
+rControlRegion.GetWidth(), rControlRegion.GetHeight() + 8);
}
gtk_style_context_set_state(style, flags);
@@ -556,7 +563,7 @@ void GtkSalGraphics::getStyleContext(GtkStyleContext**
style, GtkWidget* widget)
{
*style = gtk_widget_get_style_context(widget);
g_object_ref(*style);
-//gtk_widget_destroy(widget);
+gtk_widget_destroy(widget);
}
GtkSalGraphics::GtkSalGraphics( GtkSalFrame *pFrame, GtkWidget *pWindow )
@@ -565,6 +572,9 @@ GtkSalGraphics::GtkSalGraphics( GtkSalFrame *pFrame,
GtkWidget *pWindow )
mpWindow( pWindow )
{
+if(style_loaded)
+return;
+style_loaded = true;
gtk_init(NULL, NULL);
/* Load the GtkStyleContexts, it might be a bit slow, but usually,
* gtk apps create a lot of widgets at startup, so, it shouldn't be
commit d8be64b02a5ec468a76fbbcab6afdb1f87329ecf
Author: Lucas Baudin xapa...@gmail.com
Date: Sat Oct 22 17:45:27 2011 +0200
gtk3: add toolbar rendering, there is some graphical bugs if you have more
than one row in the toolbar (is it detectable in GtkSalGraphices?)
diff --git a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
b/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
index b021036..a5877dd 100644
--- a/vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx
+++
[Libreoffice-commits] .: vcl/unx
vcl/unx/generic/printer/ppdparser.cxx | 90 +-
1 file changed, 45 insertions(+), 45 deletions(-)
New commits:
commit cbf692559c91dae8db4cada6c7eeeb613313df24
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Oct 24 15:05:35 2011 +0200
These DBG_ASSERTs should really be OSL_TRACEs.
Otherwise, --enable-dbgutil smoketestoo_native fails due to assertions.
diff --git a/vcl/unx/generic/printer/ppdparser.cxx
b/vcl/unx/generic/printer/ppdparser.cxx
index 208fc07..7eec1f7 100644
--- a/vcl/unx/generic/printer/ppdparser.cxx
+++ b/vcl/unx/generic/printer/ppdparser.cxx
@@ -804,69 +804,69 @@ PPDParser::PPDParser( const String rFile ) :
m_pImageableAreas = getKey( String( RTL_CONSTASCII_USTRINGPARAM(
ImageableArea ) ) );
if( m_pImageableAreas )
m_pDefaultImageableArea = m_pImageableAreas-getDefaultValue();
-DBG_ASSERT(
-m_pImageableAreas,
-OSL_FORMAT(
-Warning: no ImageableArea in %s\n,
-rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr()));
-DBG_ASSERT(
-m_pDefaultImageableArea,
-OSL_FORMAT(
-Warning: no DefaultImageableArea in %s\n,
-rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr()));
+if (m_pImageableAreas == 0) {
+OSL_TRACE(
+OSL_LOG_PREFIX Warning: no ImageableArea in %s\n,
+rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr());
+}
+if (m_pDefaultImageableArea == 0) {
+OSL_TRACE(
+OSL_LOG_PREFIX Warning: no DefaultImageableArea in %s\n,
+rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr());
+}
m_pPaperDimensions = getKey( String( RTL_CONSTASCII_USTRINGPARAM(
PaperDimension ) ) );
if( m_pPaperDimensions )
m_pDefaultPaperDimension = m_pPaperDimensions-getDefaultValue();
-DBG_ASSERT(
-m_pPaperDimensions,
-OSL_FORMAT(
-Warning: no PaperDimensions in %s\n,
-rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr()));
-DBG_ASSERT(
-m_pDefaultPaperDimension,
-OSL_FORMAT(
-Warning: no DefaultPaperDimensions in %s\n,
-rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr()));
+if (m_pPaperDimensions == 0) {
+OSL_TRACE(
+OSL_LOG_PREFIX Warning: no PaperDimensions in %s\n,
+rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr());
+}
+if (m_pDefaultPaperDimension == 0) {
+OSL_TRACE(
+OSL_LOG_PREFIX Warning: no DefaultPaperDimensions in %s\n,
+rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr());
+}
m_pResolutions = getKey( String( RTL_CONSTASCII_USTRINGPARAM( Resolution
) ) );
if( m_pResolutions )
m_pDefaultResolution = m_pResolutions-getDefaultValue();
-DBG_ASSERT(
-m_pResolutions,
-OSL_FORMAT(
-Warning: no Resolution in %s\n,
-rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr()));
-DBG_ASSERT(
-m_pDefaultResolution,
-OSL_FORMAT(
-Warning: no DefaultResolution in %s\n,
-rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr()));
+if (m_pResolutions == 0) {
+OSL_TRACE(
+OSL_LOG_PREFIX Warning: no Resolution in %s\n,
+rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr());
+}
+if (m_pDefaultResolution == 0) {
+OSL_TRACE(
+OSL_LOG_PREFIX Warning: no DefaultResolution in %s\n,
+rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr());
+}
m_pInputSlots = getKey( String( RTL_CONSTASCII_USTRINGPARAM( InputSlot )
) );
if( m_pInputSlots )
m_pDefaultInputSlot = m_pInputSlots-getDefaultValue();
-DBG_ASSERT(
-m_pInputSlots,
-OSL_FORMAT(
-Warning: no InputSlot in %s\n,
-rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr()));
-DBG_ASSERT(
-m_pDefaultInputSlot,
-OSL_FORMAT(
-Warning: no DefaultInputSlot in %s\n,
-rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr()));
+if (m_pInputSlots == 0) {
+OSL_TRACE(
+OSL_LOG_PREFIX Warning: no InputSlot in %s\n,
+rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr());
+}
+if (m_pDefaultInputSlot == 0) {
+OSL_TRACE(
+OSL_LOG_PREFIX Warning: no DefaultInputSlot in %s\n,
+rtl::OUStringToOString(m_aFile, RTL_TEXTENCODING_UTF8).getStr());
+}
m_pDuplexTypes = getKey( String( RTL_CONSTASCII_USTRINGPARAM( Duplex ) )
);
if( m_pDuplexTypes )
m_pDefaultDuplexType = m_pDuplexTypes-getDefaultValue();
m_pFontList = getKey( String( RTL_CONSTASCII_USTRINGPARAM( Font ) ) );
-DBG_ASSERT(
-m_pFontList,
-OSL_FORMAT(
-
[Libreoffice-commits] .: 2 commits - forms/source solenv/gbuild
forms/source/helper/windowstateguard.cxx | 11 +++
solenv/gbuild/extensions/pre_Counters.mk |2 --
solenv/gbuild/gbuild.mk |8
3 files changed, 7 insertions(+), 14 deletions(-)
New commits:
commit 3895c2e7c8b32bfde74e2dc391c6c195aae22fc7
Author: Michael Stahl mst...@redhat.com
Date: Mon Oct 24 12:58:23 2011 +0200
fdo#42157: fix deadlock
WindowStateGuard_Impl::impl_ensureEnabledState_nothrow_nolck:
drop own mutex while calling XWindow method that locks SolarMutex.
diff --git a/forms/source/helper/windowstateguard.cxx
b/forms/source/helper/windowstateguard.cxx
index 7a947ec..2cfae61 100644
--- a/forms/source/helper/windowstateguard.cxx
+++ b/forms/source/helper/windowstateguard.cxx
@@ -135,18 +135,21 @@ namespace frm
try
{
Reference XWindow2 xWindow;
-sal_Bool bEnabled = sal_False;
+Reference XPropertySet xModelProps;
sal_Bool bShouldBeEnabled = sal_False;
{
::osl::MutexGuard aGuard( m_aMutex );
if ( !m_xWindow.is() || !m_xModelProps.is() )
return;
xWindow = m_xWindow;
-bEnabled = xWindow-isEnabled();
-OSL_VERIFY( m_xModelProps-getPropertyValue( PROPERTY_ENABLED
) = bShouldBeEnabled );
+xModelProps = m_xModelProps;
}
+// fdo#42157: do not lock m_aMutex to prevent deadlock
+bool const bEnabled = xWindow-isEnabled();
+OSL_VERIFY( xModelProps-getPropertyValue( PROPERTY_ENABLED )
+= bShouldBeEnabled );
-if ( !bShouldBeEnabled bEnabled xWindow.is() )
+if ( !bShouldBeEnabled bEnabled )
xWindow-setEnable( sal_False );
}
catch( const Exception )
commit dc8249af103741415a074d9bbf8b1211f24a7c3f
Author: Michael Stahl mst...@redhat.com
Date: Mon Oct 24 12:55:31 2011 +0200
gbuild: remove remnants of gb_CHECKOBJECTOWNER
diff --git a/solenv/gbuild/extensions/pre_Counters.mk
b/solenv/gbuild/extensions/pre_Counters.mk
index feebe8c..8f6eb4a 100644
--- a/solenv/gbuild/extensions/pre_Counters.mk
+++ b/solenv/gbuild/extensions/pre_Counters.mk
@@ -37,8 +37,6 @@ countoutdated:
ifneq ($(filter countoutdated,$(MAKECMDGOALS)),)
-gb_CHECKOBJECTOWNER := $(false)
-
$(WORKDIR)/%:
$(eval gb_CountersOutdated_COUNTER_ALL+= x)
$(eval gb_CountersOutdated__TYPE=$(firstword $(subst /, ,$*)))
diff --git a/solenv/gbuild/gbuild.mk b/solenv/gbuild/gbuild.mk
index 03110a5..4ff643a 100644
--- a/solenv/gbuild/gbuild.mk
+++ b/solenv/gbuild/gbuild.mk
@@ -126,14 +126,6 @@ else
gb_FULLDEPS := $(true)
endif
-# Life in the fast lane: only check for duplicate objects when explicitly
building check targets
-# triples speed of noop builds
-ifeq ($(origin gb_CHECKOBJECTOWNER),undefined)
-ifneq ($(filter check unitcheck subsequentcheck,$(MAKECMDGOALS)),)
-gb_CHECKOBJECTOWNER := $(true)
-endif
-endif
-
# save user-supplied flags for latter use
ifneq ($(strip $(CFLAGS)),)
gb__ENV_CFLAGS := $(CFLAGS)
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: toolkit/source
toolkit/source/controls/stdtabcontroller.cxx | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
New commits:
commit 09179e24c4e4eec135012a3cce5e1cffc42fae60
Author: julien2412 serval2...@yahoo.fr
Date: Mon Oct 24 14:46:13 2011 +0200
activation order crashes address database (fdo#41022)
diff --git a/toolkit/source/controls/stdtabcontroller.cxx
b/toolkit/source/controls/stdtabcontroller.cxx
index 3065515..082733f 100644
--- a/toolkit/source/controls/stdtabcontroller.cxx
+++ b/toolkit/source/controls/stdtabcontroller.cxx
@@ -262,6 +262,7 @@ void StdTabController::autoTabOrder( )
throw(RuntimeException)
sal_uInt32 nCtrls = aCompSeq.getLength();
Reference XWindow * pComponents = aCompSeq.getArray();
+// insert sort algorithm
ComponentEntryList aCtrls;
size_t n;
for ( n = 0; n nCtrls; n++ )
@@ -277,15 +278,9 @@ void StdTabController::autoTabOrder( )
throw(RuntimeException)
for ( nPos = 0; nPos aCtrls.size(); nPos++ )
{
ComponentEntry* pEntry = aCtrls[ nPos ];
-if ( pEntry-aPos.Y() = pE-aPos.Y() )
-{
-while ( pEntry ( pEntry-aPos.Y() == pE-aPos.Y() )
- ( pEntry-aPos.X() pE-aPos.X() ) )
-{
-pEntry = aCtrls[ ++nPos ];
-}
-break;
-}
+if ( ( pEntry-aPos.Y() pE-aPos.Y() ) ||
+ ( ( pEntry-aPos.Y() == pE-aPos.Y() ) ( pEntry-aPos.X()
pE-aPos.X() ) ) )
+break;
}
if ( nPos aCtrls.size() ) {
ComponentEntryList::iterator it = aCtrls.begin();
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: writerperfect/source
writerperfect/source/filter/DocumentElement.hxx |2
writerperfect/source/filter/FontStyle.cxx |3 -
writerperfect/source/filter/OdgGenerator.cxx| 57
writerperfect/source/filter/OdtGenerator.cxx| 21
writerperfect/source/filter/Style.hxx | 21 ++--
writerperfect/source/filter/TextRunStyle.hxx|4 -
6 files changed, 52 insertions(+), 56 deletions(-)
New commits:
commit f9832c3edb8c69eb9791e55ebfdce8c21f460291
Author: Caolán McNamara caol...@redhat.com
Date: Mon Oct 24 14:51:29 2011 +0100
fix warning and indent and use boost::noncopyable
diff --git a/writerperfect/source/filter/DocumentElement.hxx
b/writerperfect/source/filter/DocumentElement.hxx
index f56cfb2..4032a39 100644
--- a/writerperfect/source/filter/DocumentElement.hxx
+++ b/writerperfect/source/filter/DocumentElement.hxx
@@ -57,7 +57,7 @@ private:
class TagOpenElement : public TagElement
{
public:
- TagOpenElement(const WPXString szTagName) : TagElement(szTagName),
maAttrList() {}
+TagOpenElement(const WPXString szTagName) : TagElement(szTagName),
maAttrList() {}
virtual ~TagOpenElement() {}
void addAttribute(const WPXString szAttributeName, const WPXString
sAttributeValue);
virtual void write(OdfDocumentHandler *pHandler) const;
diff --git a/writerperfect/source/filter/FontStyle.cxx
b/writerperfect/source/filter/FontStyle.cxx
index a3f0ef7..8b24e18 100644
--- a/writerperfect/source/filter/FontStyle.cxx
+++ b/writerperfect/source/filter/FontStyle.cxx
@@ -54,7 +54,8 @@ void FontStyle::write(OdfDocumentHandler *pHandler) const
void FontStyleManager::clean()
{
for (std::mapWPXString, FontStyle *, ltstr::iterator iter =
mHash.begin();
- iter != mHash.end(); iter++) {
+ iter != mHash.end(); iter++)
+{
delete(iter-second);
}
mHash.clear();
diff --git a/writerperfect/source/filter/OdgGenerator.cxx
b/writerperfect/source/filter/OdgGenerator.cxx
index 79653fa..2de6f4a 100644
--- a/writerperfect/source/filter/OdgGenerator.cxx
+++ b/writerperfect/source/filter/OdgGenerator.cxx
@@ -255,14 +255,14 @@ public:
std::vectorDocumentElement * mPageAutomaticStyles;
std::vectorDocumentElement * mPageMasterStyles;
- // paragraph styles
- ParagraphStyleManager mParagraphManager;
+// paragraph styles
+ParagraphStyleManager mParagraphManager;
- // span styles
- SpanStyleManager mSpanManager;
+// span styles
+SpanStyleManager mSpanManager;
// font styles
- FontStyleManager mFontManager;
+FontStyleManager mFontManager;
OdfDocumentHandler *mpHandler;
@@ -283,17 +283,18 @@ public:
};
OdgGeneratorPrivate::OdgGeneratorPrivate(OdfDocumentHandler *pHandler, const
OdfStreamType streamType):
- mBodyElements(),
- mGraphicsStrokeDashStyles(),
- mGraphicsGradientStyles(),
- mGraphicsAutomaticStyles(),
- mPageAutomaticStyles(),
- mPageMasterStyles(),
- mParagraphManager(),
- mSpanManager(),
- mFontManager(),
+mBodyElements(),
+mGraphicsStrokeDashStyles(),
+mGraphicsGradientStyles(),
+mGraphicsAutomaticStyles(),
+mPageAutomaticStyles(),
+mPageMasterStyles(),
+mParagraphManager(),
+mSpanManager(),
+mFontManager(),
mpHandler(pHandler),
- mxStyle(), mxGradient(),
+mxStyle(),
+mxGradient(),
miGradientIndex(1),
miDashIndex(1),
miGraphicsStyleIndex(1),
@@ -1335,15 +1336,15 @@ void OdgGenerator::endTextObject()
void OdgGenerator::startTextLine(WPXPropertyList const propList)
{
- WPXPropertyList finalPropList(propList);
- finalPropList.insert(style:parent-style-name, Standard);
- WPXString paragName = mpImpl-mParagraphManager.findOrAdd(finalPropList,
WPXPropertyListVector());
+WPXPropertyList finalPropList(propList);
+finalPropList.insert(style:parent-style-name, Standard);
+WPXString paragName = mpImpl-mParagraphManager.findOrAdd(finalPropList,
WPXPropertyListVector());
- // create a document element corresponding to the paragraph, and append it
to our list of document elements
- TagOpenElement *pParagraphOpenElement = new TagOpenElement(text:p);
- pParagraphOpenElement-addAttribute(text:style-name, paragName);
- mpImpl-mBodyElements.push_back(pParagraphOpenElement);
+// create a document element corresponding to the paragraph, and append it
to our list of document elements
+TagOpenElement *pParagraphOpenElement = new TagOpenElement(text:p);
+pParagraphOpenElement-addAttribute(text:style-name, paragName);
+mpImpl-mBodyElements.push_back(pParagraphOpenElement);
}
void OdgGenerator::endTextLine()
@@ -1354,18 +1355,18 @@ void OdgGenerator::endTextLine()
void OdgGenerator::startTextSpan(WPXPropertyList constpropList)
{
if (propList[style:font-name])
-
mpImpl-mFontManager.findOrAdd(propList[style:font-name]-getStr().cstr());
+
[Libreoffice-commits] .: writerperfect/source
writerperfect/source/filter/DocumentElement.hxx |2
writerperfect/source/filter/FontStyle.cxx |3 -
writerperfect/source/filter/OdgGenerator.cxx| 57
writerperfect/source/filter/OdtGenerator.cxx| 21
writerperfect/source/filter/Style.hxx | 21 ++--
writerperfect/source/filter/TextRunStyle.hxx|4 -
6 files changed, 52 insertions(+), 56 deletions(-)
New commits:
commit f8c2d298be72440da658b580630d1f4452a807a4
Author: Caolán McNamara caol...@redhat.com
Date: Mon Oct 24 14:51:29 2011 +0100
fix warning and indent and use boost::noncopyable
diff --git a/writerperfect/source/filter/DocumentElement.hxx
b/writerperfect/source/filter/DocumentElement.hxx
index f56cfb2..4032a39 100644
--- a/writerperfect/source/filter/DocumentElement.hxx
+++ b/writerperfect/source/filter/DocumentElement.hxx
@@ -57,7 +57,7 @@ private:
class TagOpenElement : public TagElement
{
public:
- TagOpenElement(const WPXString szTagName) : TagElement(szTagName),
maAttrList() {}
+TagOpenElement(const WPXString szTagName) : TagElement(szTagName),
maAttrList() {}
virtual ~TagOpenElement() {}
void addAttribute(const WPXString szAttributeName, const WPXString
sAttributeValue);
virtual void write(OdfDocumentHandler *pHandler) const;
diff --git a/writerperfect/source/filter/FontStyle.cxx
b/writerperfect/source/filter/FontStyle.cxx
index a3f0ef7..8b24e18 100644
--- a/writerperfect/source/filter/FontStyle.cxx
+++ b/writerperfect/source/filter/FontStyle.cxx
@@ -54,7 +54,8 @@ void FontStyle::write(OdfDocumentHandler *pHandler) const
void FontStyleManager::clean()
{
for (std::mapWPXString, FontStyle *, ltstr::iterator iter =
mHash.begin();
- iter != mHash.end(); iter++) {
+ iter != mHash.end(); iter++)
+{
delete(iter-second);
}
mHash.clear();
diff --git a/writerperfect/source/filter/OdgGenerator.cxx
b/writerperfect/source/filter/OdgGenerator.cxx
index 79653fa..2de6f4a 100644
--- a/writerperfect/source/filter/OdgGenerator.cxx
+++ b/writerperfect/source/filter/OdgGenerator.cxx
@@ -255,14 +255,14 @@ public:
std::vectorDocumentElement * mPageAutomaticStyles;
std::vectorDocumentElement * mPageMasterStyles;
- // paragraph styles
- ParagraphStyleManager mParagraphManager;
+// paragraph styles
+ParagraphStyleManager mParagraphManager;
- // span styles
- SpanStyleManager mSpanManager;
+// span styles
+SpanStyleManager mSpanManager;
// font styles
- FontStyleManager mFontManager;
+FontStyleManager mFontManager;
OdfDocumentHandler *mpHandler;
@@ -283,17 +283,18 @@ public:
};
OdgGeneratorPrivate::OdgGeneratorPrivate(OdfDocumentHandler *pHandler, const
OdfStreamType streamType):
- mBodyElements(),
- mGraphicsStrokeDashStyles(),
- mGraphicsGradientStyles(),
- mGraphicsAutomaticStyles(),
- mPageAutomaticStyles(),
- mPageMasterStyles(),
- mParagraphManager(),
- mSpanManager(),
- mFontManager(),
+mBodyElements(),
+mGraphicsStrokeDashStyles(),
+mGraphicsGradientStyles(),
+mGraphicsAutomaticStyles(),
+mPageAutomaticStyles(),
+mPageMasterStyles(),
+mParagraphManager(),
+mSpanManager(),
+mFontManager(),
mpHandler(pHandler),
- mxStyle(), mxGradient(),
+mxStyle(),
+mxGradient(),
miGradientIndex(1),
miDashIndex(1),
miGraphicsStyleIndex(1),
@@ -1335,15 +1336,15 @@ void OdgGenerator::endTextObject()
void OdgGenerator::startTextLine(WPXPropertyList const propList)
{
- WPXPropertyList finalPropList(propList);
- finalPropList.insert(style:parent-style-name, Standard);
- WPXString paragName = mpImpl-mParagraphManager.findOrAdd(finalPropList,
WPXPropertyListVector());
+WPXPropertyList finalPropList(propList);
+finalPropList.insert(style:parent-style-name, Standard);
+WPXString paragName = mpImpl-mParagraphManager.findOrAdd(finalPropList,
WPXPropertyListVector());
- // create a document element corresponding to the paragraph, and append it
to our list of document elements
- TagOpenElement *pParagraphOpenElement = new TagOpenElement(text:p);
- pParagraphOpenElement-addAttribute(text:style-name, paragName);
- mpImpl-mBodyElements.push_back(pParagraphOpenElement);
+// create a document element corresponding to the paragraph, and append it
to our list of document elements
+TagOpenElement *pParagraphOpenElement = new TagOpenElement(text:p);
+pParagraphOpenElement-addAttribute(text:style-name, paragName);
+mpImpl-mBodyElements.push_back(pParagraphOpenElement);
}
void OdgGenerator::endTextLine()
@@ -1354,18 +1355,18 @@ void OdgGenerator::endTextLine()
void OdgGenerator::startTextSpan(WPXPropertyList constpropList)
{
if (propList[style:font-name])
-
mpImpl-mFontManager.findOrAdd(propList[style:font-name]-getStr().cstr());
+
[Libreoffice-commits] .: Branch 'libreoffice-3-4' - toolkit/source
toolkit/source/controls/stdtabcontroller.cxx | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
New commits:
commit ee26becc4a5690840fd3181b71d293340853b58e
Author: julien2412 serval2...@yahoo.fr
Date: Mon Oct 24 14:46:13 2011 +0200
activation order crashes address database (fdo#41022)
Signed-off-by: Petr Mladek pmla...@suse.cz
diff --git a/toolkit/source/controls/stdtabcontroller.cxx
b/toolkit/source/controls/stdtabcontroller.cxx
index d5c2f06..2fecd4d 100644
--- a/toolkit/source/controls/stdtabcontroller.cxx
+++ b/toolkit/source/controls/stdtabcontroller.cxx
@@ -262,6 +262,7 @@ void StdTabController::autoTabOrder( )
throw(RuntimeException)
sal_uInt32 nCtrls = aCompSeq.getLength();
Reference XWindow * pComponents = aCompSeq.getArray();
+// insert sort algorithm
ComponentEntryList aCtrls;
size_t n;
for ( n = 0; n nCtrls; n++ )
@@ -277,15 +278,9 @@ void StdTabController::autoTabOrder( )
throw(RuntimeException)
for ( nPos = 0; nPos aCtrls.size(); nPos++ )
{
ComponentEntry* pEntry = aCtrls[ nPos ];
-if ( pEntry-aPos.Y() = pE-aPos.Y() )
-{
-while ( pEntry ( pEntry-aPos.Y() == pE-aPos.Y() )
- ( pEntry-aPos.X() pE-aPos.X() ) )
-{
-pEntry = aCtrls[ ++nPos ];
-}
-break;
-}
+if ( ( pEntry-aPos.Y() pE-aPos.Y() ) ||
+ ( ( pEntry-aPos.Y() == pE-aPos.Y() ) ( pEntry-aPos.X()
pE-aPos.X() ) ) )
+break;
}
if ( nPos aCtrls.size() ) {
ComponentEntryList::iterator it = aCtrls.begin();
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - sc/qa toolkit/source
sc/qa/unit/data/xls/TestAddress.xls |binary
sc/qa/unit/data/xls/vba.xls |binary
sc/qa/unit/macros-test.cxx| 73 +++---
toolkit/source/controls/dialogcontrol.cxx |3 -
4 files changed, 49 insertions(+), 27 deletions(-)
New commits:
commit 1b2b2283000850dedb00659ce49a0c5eee4aeebb
Author: Noel Power noel.po...@novell.com
Date: Mon Oct 24 15:05:39 2011 +0100
fix wae aRect uninitialized when used within its own initialization
diff --git a/toolkit/source/controls/dialogcontrol.cxx
b/toolkit/source/controls/dialogcontrol.cxx
index f463bfa..35eff0e 100644
--- a/toolkit/source/controls/dialogcontrol.cxx
+++ b/toolkit/source/controls/dialogcontrol.cxx
@@ -1033,7 +1033,8 @@ void UnoFrameControl::ImplSetPosSize( Reference XControl
rxCtrl )
if ( !bOwnCtrl sTitle.getLength() )
{
// Adjust Y based on height of Title
-::Rectangle aRect = pOutDev-GetTextRect( aRect, sTitle );
+::Rectangle aRect;
+aRect = pOutDev-GetTextRect( aRect, sTitle );
nY = nY + ( aRect.GetHeight() / 2 );
}
}
commit 82fb60bc563b444679617396cb4d22a740427e6d
Author: Noel Power noel.po...@novell.com
Date: Mon Oct 24 14:26:33 2011 +0100
make vba.xls return 'OK' on success, adjust macros-test.cxx to test for 'OK'
diff --git a/sc/qa/unit/data/xls/vba.xls b/sc/qa/unit/data/xls/vba.xls
index 2ee53a5..399b1ec 100644
Binary files a/sc/qa/unit/data/xls/vba.xls and b/sc/qa/unit/data/xls/vba.xls
differ
diff --git a/sc/qa/unit/macros-test.cxx b/sc/qa/unit/macros-test.cxx
index e3c9974..3737869 100644
--- a/sc/qa/unit/macros-test.cxx
+++ b/sc/qa/unit/macros-test.cxx
@@ -165,7 +165,7 @@ public:
CPPUNIT_TEST(testStarBasic);
//enable if you want to hack vba support for unit tests
//does not work, still problems during loading
-//CPPUNIT_TEST(testVba);
+CPPUNIT_TEST(testVba);
CPPUNIT_TEST_SUITE_END();
@@ -262,37 +262,58 @@ void ScMacrosTest::testStarBasic()
xDocSh-DoClose();
}
+struct TestMacroInfo
+{
+rtl::OUString sFileBaseName;
+rtl::OUString sMacroUrl;
+};
void ScMacrosTest::testVba()
{
-const rtl::OUString aFileNameBase(RTL_CONSTASCII_USTRINGPARAM(vba.));
+TestMacroInfo testInfo[] {
+{
+rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(TestAddress.)),
+
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(vnd.sun.Star.script:VBAProject.Sheet1.test?language=Basiclocation=document))
+},
+/*
+vba.xls is still throwing up a basic error :-/
+{
+rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(vba.)),
+
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(vnd.sun.Star.script:VBAProject.Modul1.Modul1?language=Basiclocation=document)),
+}
+*/
+};
+
rtl::OUString aFileExtension(aFileFormats[1].pName,
strlen(aFileFormats[1].pName), RTL_TEXTENCODING_UTF8 );
rtl::OUString aFilterName(aFileFormats[1].pFilterName,
strlen(aFileFormats[1].pFilterName), RTL_TEXTENCODING_UTF8) ;
-rtl::OUString aFileName;
-createFileURL(aFileNameBase, aFileExtension, aFileName);
rtl::OUString aFilterType(aFileFormats[1].pTypeName,
strlen(aFileFormats[1].pTypeName), RTL_TEXTENCODING_UTF8);
std::cout aFileFormats[1].pName Test std::endl;
-ScDocShellRef xDocSh = load (aFilterName, aFileName, rtl::OUString(),
aFilterType, aFileFormats[1].nFormatType);
-
-CPPUNIT_ASSERT_MESSAGE(Failed to load vba.xls, xDocSh.Is());
-
-//is it really the right way to call a vba macro through CallXScript?
-//it seems that the basic ide does it differently, but then we would need
to init all parts ourself
-//the problem is that CallXScript inits the basic part
-BasicIDE::RunMethod takes an SbMethod as parametre
-rtl::OUString
aURL(RTL_CONSTASCII_USTRINGPARAM(vnd.sun.Star.script:VBAProject.Modul1.Modul1?language=Basiclocation=document));
-String sUrl = aURL;
-Any aRet;
-Sequence sal_Int16 aOutParamIndex;
-Sequence Any aOutParam;
-Sequence uno::Any aParams;
-ScDocument* pDoc = xDocSh-GetDocument();
-
-xDocSh-CallXScript(sUrl, aParams, aRet, aOutParamIndex,aOutParam);
-double aValue;
-pDoc-GetValue(0,0,0,aValue);
-std::cout aValue std::endl;
-CPPUNIT_ASSERT_MESSAGE(script did not change the value of
Sheet1.A1,aValue==2);
-xDocSh-DoClose();
+for ( sal_uInt32 i=0; iSAL_N_ELEMENTS( testInfo ); ++i )
+{
+rtl::OUString aFileName;
+createFileURL(testInfo[i].sFileBaseName, aFileExtension, aFileName);
+ScDocShellRef xDocSh = load (aFilterName, aFileName, rtl::OUString(),
aFilterType, aFileFormats[1].nFormatType);
+rtl::OUString sMsg( RTL_CONSTASCII_USTRINGPARAM(Failed to load ) );
+sMsg.concat( aFileName );
+CPPUNIT_ASSERT_MESSAGE( rtl::OUStringToOString( sMsg,
RTL_TEXTENCODING_UTF8 ).getStr(), xDocSh.Is() );
+
+
[Libreoffice-commits] .: Branch 'libreoffice-3-4' - dbaccess/source
dbaccess/source/ui/querydesign/QueryDesignView.cxx | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
New commits:
commit 718e2912d031280a52991157ffc024c5516eec32
Author: Julien Nabet serval2...@yahoo.fr
Date: Sat Oct 22 11:26:20 2011 +0200
Fix fdo#38286. Perhaps it could be simplified
Signed-off-by: Petr Mladek pmla...@suse.cz
diff --git a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
index be56580..a94ead0 100644
--- a/dbaccess/source/ui/querydesign/QueryDesignView.cxx
+++ b/dbaccess/source/ui/querydesign/QueryDesignView.cxx
@@ -3193,7 +3193,18 @@ void OQueryDesignView::fillFunctionInfo( const
::connectivity::OSQLParseNode* p
OQueryController rController =
static_castOQueryController(getController());
sal_Int32 nDataType = DataType::DOUBLE;
::rtl::OUString sFieldName = sFunctionTerm;
-OSQLParseNode* pFunctionName = pNode-getChild(0);
+const OSQLParseNode* pFunctionName;
+// Fix fdo#38286 : crash when constant in the query
+// TODO : is it possible to have a child or children in the pNode ?
+// if not this part could be simplified
+if (pNode-count())
+{
+pFunctionName = pNode-getChild(0);
+}
+else
+{
+pFunctionName = pNode;
+}
if ( !SQL_ISPUNCTUATION(pFunctionName,{) )
{
if ( SQL_ISRULEOR2(pNode,length_exp,char_value_fct) )
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: solenv/bin
solenv/bin/linkoo |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) New commits: commit 8cfa1d73c165f9e0f09b8cbc41a93c7a66406903 Author: Caolán McNamara caol...@redhat.com Date: Mon Oct 24 15:29:56 2011 +0100 assuming this is a typo diff --git a/solenv/bin/linkoo b/solenv/bin/linkoo index fc7b38c..ac59d88 100755 --- a/solenv/bin/linkoo +++ b/solenv/bin/linkoo @@ -347,7 +347,7 @@ sub do_link_gdb_py($$$) my $libdir = shift; my $loader = shift; -my $lib = $loader =~ s/-gdb.py$//r; +my $lib = $loader =~ s/-gdb.py$//; my $destdir = $libdir; # Autoloader for a library is looked for in the same directory the library # is (the library, not a symlink to it). Therefore it does not help to link ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - hyphen/hyphen-2.7.1-2.8.2.patch hyphen/hyphen-2.7.1-2.8.3.patch hyphen/makefile.mk
hyphen/hyphen-2.7.1-2.8.2.patch | 325
hyphen/hyphen-2.7.1-2.8.3.patch | 399
hyphen/makefile.mk |2
3 files changed, 400 insertions(+), 326 deletions(-)
New commits:
commit e894342d6bdbe7cf6b3f93c6e66d6988e3fda907
Author: Caolán McNamara caol...@redhat.com
Date: Mon Oct 24 15:38:01 2011 +0100
fix up hyphen 2.8.2/2.8.3 conflicts
diff --git a/hyphen/hyphen-2.7.1-2.8.2.patch b/hyphen/hyphen-2.7.1-2.8.2.patch
deleted file mode 100644
index 912fba7..000
--- a/hyphen/hyphen-2.7.1-2.8.2.patch
+++ /dev/null
@@ -1,325 +0,0 @@
misc/build/hyphen-2.7.1/hyphen.c.old 2011-10-07 15:51:25.883686906
+0200
-+++ misc/build/hyphen-2.7.1/hyphen.c 2011-10-07 15:51:59.363686900 +0200
-@@ -242,99 +242,45 @@
- }
- #endif
-
--HyphenDict *
--hnj_hyphen_load (const char *fn)
--{
-- HyphenDict *dict[2];
-- HashTab *hashtab;
-- FILE *f;
-- char buf[MAX_CHARS];
-+void hnj_hyphen_load_line(char * buf, HyphenDict * dict, HashTab * hashtab) {
-+ int i, j;
- char word[MAX_CHARS];
- char pattern[MAX_CHARS];
- char * repl;
- signed char replindex;
- signed char replcut;
-- int state_num = 0, last_state;
-- int i, j, k;
-+ int state_num = 0;
-+ int last_state;
- char ch;
- int found;
-- HashEntry *e;
-- int nextlevel = 0;
--
-- f = fopen (fn, r);
-- if (f == NULL)
--return NULL;
-
--// loading one or two dictionaries (separated by NEXTLEVEL keyword)
--for (k = 0; k == 0 || (k == 1 nextlevel); k++) {
-- hashtab = hnj_hash_new ();
--#ifdef VERBOSE
-- global = hashtab;
--#endif
-- hnj_hash_insert (hashtab, , 0);
-- dict[k] = hnj_malloc (sizeof(HyphenDict));
-- dict[k]-num_states = 1;
-- dict[k]-states = hnj_malloc (sizeof(HyphenState));
-- dict[k]-states[0].match = NULL;
-- dict[k]-states[0].repl = NULL;
-- dict[k]-states[0].fallback_state = -1;
-- dict[k]-states[0].num_trans = 0;
-- dict[k]-states[0].trans = NULL;
-- dict[k]-nextlevel = NULL;
-- dict[k]-lhmin = 0;
-- dict[k]-rhmin = 0;
-- dict[k]-clhmin = 0;
-- dict[k]-crhmin = 0;
-- dict[k]-nohyphen = NULL;
-- dict[k]-nohyphenl = 0;
--
-- /* read in character set info */
-- if (k == 0) {
--for (i=0;iMAX_NAME;i++) dict[k]-cset[i]= 0;
--fgets(dict[k]-cset, sizeof(dict[k]-cset),f);
--for (i=0;iMAX_NAME;i++)
-- if ((dict[k]-cset[i] == '\r') || (dict[k]-cset[i] == '\n'))
--dict[k]-cset[i] = 0;
--dict[k]-utf8 = (strcmp(dict[k]-cset, UTF-8) == 0);
-- } else {
--strcpy(dict[k]-cset, dict[0]-cset);
--dict[k]-utf8 = dict[0]-utf8;
-- }
--
-- while (fgets (buf, sizeof(buf), f) != NULL)
--{
-- if (buf[0] != '%')
-- {
--if (strncmp(buf, NEXTLEVEL, 9) == 0) {
-- nextlevel = 1;
-- break;
--} else if (strncmp(buf, LEFTHYPHENMIN, 13) == 0) {
-- dict[k]-lhmin = atoi(buf + 13);
-- continue;
-+if (strncmp(buf, LEFTHYPHENMIN, 13) == 0) {
-+ dict-lhmin = atoi(buf + 13);
-+ return;
- } else if (strncmp(buf, RIGHTHYPHENMIN, 14) == 0) {
-- dict[k]-rhmin = atoi(buf + 14);
-- continue;
-+ dict-rhmin = atoi(buf + 14);
-+ return;
- } else if (strncmp(buf, COMPOUNDLEFTHYPHENMIN, 21) == 0) {
-- dict[k]-clhmin = atoi(buf + 21);
-- continue;
-+ dict-clhmin = atoi(buf + 21);
-+ return;
- } else if (strncmp(buf, COMPOUNDRIGHTHYPHENMIN, 22) == 0) {
-- dict[k]-crhmin = atoi(buf + 22);
-- continue;
-+ dict-crhmin = atoi(buf + 22);
-+ return;
- } else if (strncmp(buf, NOHYPHEN, 8) == 0) {
- char * space = buf + 8;
- while (*space != '\0' (*space == ' ' || *space == '\t')) space++;
-- if (*buf != '\0') dict[k]-nohyphen = hnj_strdup(space);
-- if (dict[k]-nohyphen) {
-- char * nhe = dict[k]-nohyphen + strlen(dict[k]-nohyphen) - 1;
-+ if (*buf != '\0') dict-nohyphen = hnj_strdup(space);
-+ if (dict-nohyphen) {
-+ char * nhe = dict-nohyphen + strlen(dict-nohyphen) - 1;
- *nhe = 0;
-- for (nhe = nhe - 1; nhe dict[k]-nohyphen; nhe--) {
-+ for (nhe = nhe - 1; nhe dict-nohyphen; nhe--) {
- if (*nhe == ',') {
-- dict[k]-nohyphenl++;
-+ dict-nohyphenl++;
- *nhe = 0;
- }
- }
- }
-- continue;
-+ return;
- }
- j = 0;
- pattern[j] = '0';
-@@ -379,7 +325,7 @@
- } else {
- if (*word == '.') i++;
- /* convert UTF-8 char. positions of discretionary hyph.
replacements to 8-bit */
--if (dict[k]-utf8) {
-+if (dict-utf8) {
- int pu = -1;/* unicode character position */
- int ps = -1;/* unicode start
[Libreoffice-commits] .: writerperfect/source
writerperfect/source/filter/FontStyle.cxx|4 ++--
writerperfect/source/filter/OdtGenerator.cxx | 16
writerperfect/source/filter/TextRunStyle.cxx |8
3 files changed, 14 insertions(+), 14 deletions(-)
New commits:
commit 510199339092ab83ddaaa3bdfccb2f757024ca74
Author: Julien Nabet serval2...@yahoo.fr
Date: Mon Oct 24 16:46:18 2011 +0200
Some cppcheck cleaning (I let the extra qualified as advised on IRC)
diff --git a/writerperfect/source/filter/FontStyle.cxx
b/writerperfect/source/filter/FontStyle.cxx
index 8b24e18..5743e1e 100644
--- a/writerperfect/source/filter/FontStyle.cxx
+++ b/writerperfect/source/filter/FontStyle.cxx
@@ -54,7 +54,7 @@ void FontStyle::write(OdfDocumentHandler *pHandler) const
void FontStyleManager::clean()
{
for (std::mapWPXString, FontStyle *, ltstr::iterator iter =
mHash.begin();
- iter != mHash.end(); iter++)
+ iter != mHash.end(); ++iter)
{
delete(iter-second);
}
@@ -65,7 +65,7 @@ void
FontStyleManager::writeFontsDeclaration(OdfDocumentHandler *pHandler) const
{
TagOpenElement(office:font-face-decls).write(pHandler);
for (std::mapWPXString, FontStyle *, ltstr::const_iterator iter =
mHash.begin();
- iter != mHash.end(); iter++)
+ iter != mHash.end(); ++iter)
{
(iter-second)-write(pHandler);
}
diff --git a/writerperfect/source/filter/OdtGenerator.cxx
b/writerperfect/source/filter/OdtGenerator.cxx
index aba82d8..69e8f24 100644
--- a/writerperfect/source/filter/OdtGenerator.cxx
+++ b/writerperfect/source/filter/OdtGenerator.cxx
@@ -215,7 +215,7 @@ OdtGeneratorPrivate::~OdtGeneratorPrivate()
WRITER_DEBUG_MSG((WriterWordPerfect: Cleaning up our mess..\n));
WRITER_DEBUG_MSG((Destroying the body elements\n));
-for (std::vectorDocumentElement *::iterator iterBody =
mBodyElements.begin(); iterBody != mBodyElements.end(); iterBody++) {
+for (std::vectorDocumentElement *::iterator iterBody =
mBodyElements.begin(); iterBody != mBodyElements.end(); ++iterBody) {
delete (*iterBody);
(*iterBody) = 0;
}
@@ -225,32 +225,32 @@ OdtGeneratorPrivate::~OdtGeneratorPrivate()
mFontManager.clean();
for (std::vectorListStyle *::iterator iterListStyles =
mListStyles.begin();
-iterListStyles != mListStyles.end(); iterListStyles++) {
+iterListStyles != mListStyles.end(); ++iterListStyles) {
delete(*iterListStyles);
}
for (std::vectorSectionStyle *::iterator iterSectionStyles =
mSectionStyles.begin();
-iterSectionStyles != mSectionStyles.end(); iterSectionStyles++) {
+iterSectionStyles != mSectionStyles.end(); ++iterSectionStyles) {
delete(*iterSectionStyles);
}
for (std::vectorTableStyle *::iterator iterTableStyles =
mTableStyles.begin();
-iterTableStyles != mTableStyles.end(); iterTableStyles++) {
+iterTableStyles != mTableStyles.end(); ++iterTableStyles) {
delete((*iterTableStyles));
}
for (std::vectorPageSpan *::iterator iterPageSpans = mPageSpans.begin();
-iterPageSpans != mPageSpans.end(); iterPageSpans++) {
+iterPageSpans != mPageSpans.end(); ++iterPageSpans) {
delete(*iterPageSpans);
}
for (std::vectorDocumentElement *::iterator iterFrameStyles =
mFrameStyles.begin();
-iterFrameStyles != mFrameStyles.end(); iterFrameStyles++) {
+iterFrameStyles != mFrameStyles.end(); ++iterFrameStyles) {
delete(*iterFrameStyles);
}
for (std::vectorDocumentElement *::iterator iterFrameAutomaticStyles =
mFrameAutomaticStyles.begin();
-iterFrameAutomaticStyles != mFrameAutomaticStyles.end();
iterFrameAutomaticStyles++) {
+iterFrameAutomaticStyles != mFrameAutomaticStyles.end();
++iterFrameAutomaticStyles) {
delete(*iterFrameAutomaticStyles);
}
for (std::vectorDocumentElement *::iterator iterMetaData =
mMetaData.begin();
-iterMetaData != mMetaData.end(); iterMetaData++) {
+iterMetaData != mMetaData.end(); ++iterMetaData) {
delete(*iterMetaData);
}
}
diff --git a/writerperfect/source/filter/TextRunStyle.cxx
b/writerperfect/source/filter/TextRunStyle.cxx
index 6a1eec6..caa70af 100644
--- a/writerperfect/source/filter/TextRunStyle.cxx
+++ b/writerperfect/source/filter/TextRunStyle.cxx
@@ -184,7 +184,7 @@ void SpanStyle::write(OdfDocumentHandler *pHandler) const
void ParagraphStyleManager::clean()
{
for (std::mapWPXString, ParagraphStyle *, ltstr::iterator iter =
mHash.begin();
- iter != mHash.end(); iter++) {
+ iter != mHash.end(); ++iter) {
delete(iter-second);
}
mHash.clear();
@@ -193,7 +193,7 @@ void ParagraphStyleManager::clean()
void ParagraphStyleManager::write(OdfDocumentHandler *pHandler) const
{
for (std::mapWPXString, ParagraphStyle *, ltstr::const_iterator iter =
mHash.begin();
- iter != mHash.end(); iter++)
+ iter
[Libreoffice-commits] .: Branch 'feature/gtk3' - basic/source desktop/source sc/source sd/source sw/source vcl/aqua vcl/headless vcl/inc vcl/ios vcl/unx vcl/win
basic/source/app/textedit.cxx|2 +-
desktop/source/app/app.cxx |4 ++--
sc/source/core/data/documen8.cxx |2 +-
sc/source/ui/app/scmod.cxx |2 +-
sd/source/ui/tools/IdleDetection.cxx |2 +-
sw/source/core/layout/layact.cxx | 10 +-
sw/source/core/txtnode/txtedt.cxx|2 +-
vcl/aqua/source/app/salinst.cxx | 10 +-
vcl/headless/svpinst.cxx |2 +-
vcl/inc/vcl/apptypes.hxx | 12 ++--
vcl/inc/vcl/svapp.hxx|2 +-
vcl/ios/source/app/salinst.cxx |6 +++---
vcl/unx/generic/app/salinst.cxx |9 -
vcl/unx/gtk/app/gtkinst.cxx | 10 +-
vcl/win/source/app/salinst.cxx | 10 +-
15 files changed, 42 insertions(+), 43 deletions(-)
New commits:
commit e065338d305044204d350c1e8cfb553b2e432ff2
Author: Olivier Hallot olivier.hal...@alta.org.br
Date: Mon Oct 24 16:04:07 2011 +0100
Fix for fdo41997 continuation of VCL cleanup
diff --git a/basic/source/app/textedit.cxx b/basic/source/app/textedit.cxx
index 8c8ea68..a2226bd 100644
--- a/basic/source/app/textedit.cxx
+++ b/basic/source/app/textedit.cxx
@@ -370,7 +370,7 @@ IMPL_LINK( TextEditImp, SyntaxTimerHdl, Timer *, EMPTYARG )
bHighlightning = sal_True;
sal_uInt16 nLine;
-while ( aSyntaxLineTable.First() !Application::AnyInput(
INPUT_MOUSEANDKEYBOARD ) )
+while ( aSyntaxLineTable.First() !Application::AnyInput(
VCL_INPUT_MOUSEANDKEYBOARD ) )
{
nLine = (sal_uInt16)aSyntaxLineTable.GetCurKey();
DoSyntaxHighlight( nLine );
diff --git a/desktop/source/app/app.cxx b/desktop/source/app/app.cxx
index fb1da91..b63ee06 100644
--- a/desktop/source/app/app.cxx
+++ b/desktop/source/app/app.cxx
@@ -1784,7 +1784,7 @@ int Desktop::Main()
(SvtModuleOptions().IsModuleInstalled(SvtModuleOptions::E_SSTARTMODULE))
(!bExistsRecoveryData
)
(!bExistsSessionData
)
-(!Application::AnyInput( INPUT_APPEVENT )
))
+(!Application::AnyInput( VCL_INPUT_APPEVENT )
))
{
RTL_LOGFILE_CONTEXT_TRACE( aLog, { create BackingComponent
);
Reference XFrame xDesktopFrame( xDesktop, UNO_QUERY );
@@ -2875,7 +2875,7 @@ void Desktop::OpenClients()
if ( xList-hasElements() || rArgs.IsServer() )
return;
-if ( rArgs.IsQuickstart() || rArgs.IsInvisible() || rArgs.IsBean() ||
Application::AnyInput( INPUT_APPEVENT ) )
+if ( rArgs.IsQuickstart() || rArgs.IsInvisible() || rArgs.IsBean() ||
Application::AnyInput( VCL_INPUT_APPEVENT ) )
// soffice was started as tray icon ...
return;
{
diff --git a/sc/source/core/data/documen8.cxx b/sc/source/core/data/documen8.cxx
index 5f0ca06..61dc837 100644
--- a/sc/source/core/data/documen8.cxx
+++ b/sc/source/core/data/documen8.cxx
@@ -450,7 +450,7 @@ void ScDocument::InvalidateTextWidth( const ScAddress*
pAdrFrom, const ScAddress
//
#define CALCMAX 1000// Berechnungen
-#define ABORT_EVENTS(INPUT_ANY ~INPUT_TIMER ~INPUT_OTHER)
+#define ABORT_EVENTS(VCL_INPUT_ANY ~VCL_INPUT_TIMER
~VCL_INPUT_OTHER)
sal_Bool ScDocument::IdleCalcTextWidth()// sal_True = demnaechst
wieder versuchen
{
diff --git a/sc/source/ui/app/scmod.cxx b/sc/source/ui/app/scmod.cxx
index b4284e7..fe71636 100644
--- a/sc/source/ui/app/scmod.cxx
+++ b/sc/source/ui/app/scmod.cxx
@@ -1822,7 +1822,7 @@ void lcl_CheckNeedsRepaint( ScDocShell* pDocShell )
IMPL_LINK( ScModule, IdleHandler, Timer*, EMPTYARG )
{
-if ( Application::AnyInput( INPUT_MOUSEANDKEYBOARD ) )
+if ( Application::AnyInput( VCL_INPUT_MOUSEANDKEYBOARD ) )
{
aIdleTimer.Start(); // Timeout unveraendert
return 0;
diff --git a/sd/source/ui/tools/IdleDetection.cxx
b/sd/source/ui/tools/IdleDetection.cxx
index e0fba1a..f7d3857 100644
--- a/sd/source/ui/tools/IdleDetection.cxx
+++ b/sd/source/ui/tools/IdleDetection.cxx
@@ -59,7 +59,7 @@ sal_Int32 IdleDetection::GetIdleState (const ::Window*
pWindow)
sal_Int32 IdleDetection::CheckInputPending (void)
{
-if (GetpApp()-AnyInput(VCL_INPUT_MOUSE | VCL_INPUT_KEYBOARD |
INPUT_PAINT))
+if (GetpApp()-AnyInput(VCL_INPUT_MOUSE | VCL_INPUT_KEYBOARD |
VCL_INPUT_PAINT))
return IDET_SYSTEM_EVENT_PENDING;
else
return IDET_IDLE;
diff --git a/sw/source/core/layout/layact.cxx b/sw/source/core/layout/layact.cxx
index 70bfd1a..f48061b 100644
--- a/sw/source/core/layout/layact.cxx
+++ b/sw/source/core/layout/layact.cxx
@@ -2127,13 +2127,13 @@ sal_Bool SwLayIdle::_DoIdleJob( const SwCntntFrm *pCnt,
IdleJobType eJob )
[Libreoffice-commits] .: 5 commits - fpicker/source lingucomponent/source reportdesign/source svx/source vcl/aqua
fpicker/source/aqua/ControlHelper.cxx|4 -
fpicker/source/aqua/ControlHelper.hxx|4 -
lingucomponent/source/spellcheck/macosxspell/macspellimp.cxx |2
reportdesign/source/core/sdr/ReportDrawPage.cxx |2
svx/source/form/fmdmod.cxx |2
vcl/aqua/source/dtrans/DataFlavorMapping.cxx | 24 +--
6 files changed, 19 insertions(+), 19 deletions(-)
New commits:
commit 6aaebef83fe1091baef5a6ace3cfec5f046bc68d
Author: Kristian Rietveld k...@lanedo.com
Date: Sat Oct 22 10:17:59 2011 +0200
Eliminate ambiguous conversion to cppu::OWeakObject
diff --git a/svx/source/form/fmdmod.cxx b/svx/source/form/fmdmod.cxx
index 807919e..e4ecc37 100644
--- a/svx/source/form/fmdmod.cxx
+++ b/svx/source/form/fmdmod.cxx
@@ -49,7 +49,7 @@ using namespace ::svxform;
else if ( ServiceSpecifier == ::rtl::OUString(
::rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(com.sun.star.drawing.ControlShape))
) )
{
SdrObject* pObj = new FmFormObj(OBJ_FM_CONTROL);
-xRet = *new SvxShapeControl(pObj);
+xRet =
static_castcppu::OWeakObject*(static_castSvxShape_UnoImplHelper*(new
SvxShapeControl(pObj)));
}
if (!xRet.is())
xRet = SvxUnoDrawMSFactory::createInstance(ServiceSpecifier);
commit 93ef7cab14049576cdd24d2f749ef32c72c85ca9
Author: Kristian Rietveld k...@lanedo.com
Date: Sat Oct 22 10:16:19 2011 +0200
Eliminate ambiguous conversion to cppu::OWeakObject
diff --git a/reportdesign/source/core/sdr/ReportDrawPage.cxx
b/reportdesign/source/core/sdr/ReportDrawPage.cxx
index d34b72d..aa2f6ff 100644
--- a/reportdesign/source/core/sdr/ReportDrawPage.cxx
+++ b/reportdesign/source/core/sdr/ReportDrawPage.cxx
@@ -93,7 +93,7 @@ uno::Reference drawing::XShape
OReportDrawPage::_CreateShape( SdrObject *pOb
else
bChangeOrientation = pUnoObj-GetObjIdentifier() ==
OBJ_DLG_HFIXEDLINE;
SvxShapeControl* pShape = new SvxShapeControl( pObj );
-xShape.set(*pShape,uno::UNO_QUERY);
+
xShape.set(static_castcppu::OWeakObject*(static_castSvxShape_UnoImplHelper
*(pShape)),uno::UNO_QUERY);
pShape-setShapeKind(pObj-GetObjIdentifier());
}
else if ( pObj-ISA(OCustomShape) )
commit 7d6097410cc18771112aa3aa4c7355e484f36628
Author: Kristian Rietveld k...@lanedo.com
Date: Sat Oct 22 09:49:38 2011 +0200
Use NSString in template specification instead of objc_object
diff --git a/lingucomponent/source/spellcheck/macosxspell/macspellimp.cxx
b/lingucomponent/source/spellcheck/macosxspell/macspellimp.cxx
index 97407f2..e7bf20f 100644
--- a/lingucomponent/source/spellcheck/macosxspell/macspellimp.cxx
+++ b/lingucomponent/source/spellcheck/macosxspell/macspellimp.cxx
@@ -156,7 +156,7 @@ Sequence Locale SAL_CALL MacSpellChecker::getLocales()
SvtPathOptions aPathOpt;
rtl_TextEncoding aEnc = RTL_TEXTENCODING_UTF8;
-std::vectorobjc_object * postspdict;
+std::vectorNSString * postspdict;
std::vectordictentry * postupdict;
commit 45fca623fa3d050e72f5f759a9c97308a1c7d87e
Author: Kristian Rietveld k...@lanedo.com
Date: Sat Oct 22 09:40:55 2011 +0200
SystemFlavor NSStrings should not be const
diff --git a/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
b/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
index 2e2e0c2..d0146f8 100644
--- a/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
+++ b/vcl/aqua/source/dtrans/DataFlavorMapping.cxx
@@ -89,18 +89,18 @@ namespace // private
}
- const NSString* PBTYPE_SODX =
@application/x-openoffice-objectdescriptor-xml;windows_formatname=\Star
Object Descriptor (XML)\;
- const NSString* PBTYPE_SESX =
@application/x-openoffice-embed-source-xml;windows_formatname=\Star Embed
Source (XML)\;
- const NSString* PBTYPE_SLSDX =
@application/x-openoffice-linksrcdescriptor-xml;windows_formatname=\Star Link
Source Descriptor (XML)\;
- const NSString* PBTYPE_ESX =
@application/x-openoffice-embed-source-xml;windows_formatname=\Star Embed
Source (XML)\;
- const NSString* PBTYPE_LSX =
@application/x-openoffice-link-source-xml;windows_formatname=\Star Link
Source (XML)\;
- const NSString* PBTYPE_EOX =
@application/x-openoffice-embedded-obj-xml;windows_formatname=\Star Embedded
Object (XML)\;
- const NSString* PBTYPE_SVXB =
@application/x-openoffice-svbx;windows_formatname=\SVXB (StarView
Bitmap/Animation)\;
- const NSString* PBTYPE_GDIMF =
@application/x-openoffice-gdimetafile;windows_formatname=\GDIMetaFile\;
- const NSString* PBTYPE_WMF =
@application/x-openoffice-wmf;windows_formatname=\Image WMF\;
- const NSString* PBTYPE_EMF =
@application/x-openoffice-emf;windows_formatname=\Image EMF\;
-
- const NSString* PBTYPE_DUMMY_INTERNAL = @application/x-openoffice-internal;
+ NSString* PBTYPE_SODX =
@application/x-openoffice-objectdescriptor-xml;windows_formatname=\Star
Object
[Libreoffice-commits] .: distro-configs/LibreOfficeDragonFly.conf
distro-configs/LibreOfficeDragonFly.conf |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) New commits: commit 721d38067a513634d54567f8100770866f18881f Author: François Tigeot ftig...@wolfpond.org Date: Mon Oct 24 17:41:50 2011 +0200 Disable the Presenter Console extension diff --git a/distro-configs/LibreOfficeDragonFly.conf b/distro-configs/LibreOfficeDragonFly.conf index e4bfacb..2a5d87c 100644 --- a/distro-configs/LibreOfficeDragonFly.conf +++ b/distro-configs/LibreOfficeDragonFly.conf @@ -1,5 +1,7 @@ --enable-symbols +--enable-python=system --disable-epm +--disable-ext-presenter-console --disable-mozilla --disable-neon --disable-nss-module @@ -11,7 +13,6 @@ --with-system-headers --with-system-libs --with-system-libexttextcat ---with-system-python --with-vendor=DragonFly BSD --without-java --without-system-altlinuxhyph ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: Branch 'libreoffice-3-4' - binfilter/bf_sw binfilter/inc
binfilter/bf_sw/source/filter/basflt/sw_fltini.cxx | 13 ++
binfilter/bf_sw/source/filter/basflt/sw_shellio.cxx | 24
binfilter/inc/bf_sw/iodetect.hxx|5 +---
3 files changed, 16 insertions(+), 26 deletions(-)
New commits:
commit 46c7ac486e44899cce3057727eccc502ee995a4d
Author: Caolán McNamara caol...@redhat.com
Date: Wed Apr 13 13:48:19 2011 +0100
add these back in to silence the MAXFILTER assert
Signed-off-by: Petr Mladek pmla...@suse.cz
diff --git a/binfilter/bf_sw/source/filter/basflt/sw_fltini.cxx
b/binfilter/bf_sw/source/filter/basflt/sw_fltini.cxx
index 8aaedf4..ed36043 100644
--- a/binfilter/bf_sw/source/filter/basflt/sw_fltini.cxx
+++ b/binfilter/bf_sw/source/filter/basflt/sw_fltini.cxx
@@ -89,10 +89,23 @@ inline void _SetFltPtr( USHORT rPos, SwRead pReader, const
sal_Char* pNm )
void _InitFilter()
{
+SwRead pRd;
+
USHORT nCnt = 0;
_SetFltPtr( nCnt, (ReadSw3 = new Sw3Reader), FILTER_SW5 );
_SetFltPtr( nCnt, ReadSw3, FILTER_SW4 );
_SetFltPtr( nCnt, ReadSw3, FILTER_SW3 );
+_SetFltPtr( nCnt, (ReadSwg = new SwgReader), FILTER_SWG );
+_SetFltPtr( nCnt, ReadSwg, FILTER_SWGV );
+_SetFltPtr( nCnt, new Sw6Reader, sSwDos );
+_SetFltPtr( nCnt, (ReadAscii = new AsciiReader), FILTER_BAS );
+_SetFltPtr( nCnt, new W4WReader, FILTER_W4W );
+_SetFltPtr( nCnt, ( pRd = new ExcelReader ), sCExcel );
+_SetFltPtr( nCnt, pRd, sExcel );
+_SetFltPtr( nCnt, new LotusReader, sLotusD );
+_SetFltPtr( nCnt, ReadSwg, sSwg1 );
+
+_SetFltPtr( nCnt, ReadAscii, FILTER_TEXT );
OSL_ENSURE( MAXFILTER == nCnt, Anzahl Filter ungleich der Definierten );
}
diff --git a/binfilter/bf_sw/source/filter/basflt/sw_shellio.cxx
b/binfilter/bf_sw/source/filter/basflt/sw_shellio.cxx
index 606aaa9..50180b3 100644
--- a/binfilter/bf_sw/source/filter/basflt/sw_shellio.cxx
+++ b/binfilter/bf_sw/source/filter/basflt/sw_shellio.cxx
@@ -351,29 +351,7 @@ using namespace ::com::sun::star;
/*?*/ // we cannot create a SwDocShell. We could
create a
/*?*/ // SwWebDocShell however, because this exists
always
/*?*/ // for the help.
-OSL_ASSERT(ReadXML removed);
-
-// SvtModuleOptions aModuleOptions;
-// if( aModuleOptions.IsWriter() )
-// {
-// SwDocShell *pDocSh =
-// new SwDocShell ( SFX_CREATE_MODE_INTERNAL );
-// SvEmbeddedObjectRef xDocSh = pDocSh;
-// if( pDocSh-DoInitNew( 0 ) )
-// {
-// pTemplate = pDocSh-GetDoc();
-// pTemplate-SetOle2Link( Link() );
-// pTemplate-SetBrowseMode( bTmplBrowseMode );
-// pTemplate-RemoveAllFmtLanguageDependencies();
-//
-// ReadXML-SetOrganizerMode( TRUE );
-// SwReader aRdr( *xStor, aEmptyStr, pTemplate );
-// aRdr.Read( *ReadXML );
-// ReadXML-SetOrganizerMode( FALSE );
-//
-// pTemplate-AddLink();
-// }
-//}
+OSL_ASSERT(ReadXML removed);
/*?*/ }
/*?*/ else
/*?*/ {
diff --git a/binfilter/inc/bf_sw/iodetect.hxx b/binfilter/inc/bf_sw/iodetect.hxx
index 02e2416..ed4697a 100644
--- a/binfilter/inc/bf_sw/iodetect.hxx
+++ b/binfilter/inc/bf_sw/iodetect.hxx
@@ -105,7 +105,7 @@ struct SwIoDetect
#endif
-const USHORT MAXFILTER = 14;
+const USHORT MAXFILTER = 13;
#define FORAMTNAME_SW4 StarWriter 4.0
#define FORAMTNAME_SW3 StarWriter 3.0
@@ -161,8 +161,7 @@ SwIoDetect aReaderWriter[ MAXFILTER ] = {
\
{/* 9*/ SwIoEntry(sExcel, 4,FALSE)}, \
{/*10*/ SwIoEntry(sLotusD,5,TRUE)},\
{/*11*/ SwIoEntry(sSwg1, 4,FALSE)}, \
-{/*12*/ SwIoEntry(FILTER_XML, 4,TRUE)},\
-{/*13*/ SwIoEntry(FILTER_TEXT,4,TRUE)} \
+{/*12*/ SwIoEntry(FILTER_TEXT,4,TRUE)} \
};
// Filter erkennung
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 3 commits - sc/qa solenv/gbuild
sc/qa/unit/macros-test.cxx|1 - solenv/gbuild/JavaClassSet.mk |2 +- solenv/gbuild/WinResTarget.mk |6 +++--- 3 files changed, 4 insertions(+), 5 deletions(-) New commits: commit d781ae9ae1aef10927de6ace368b0cc7d48280ad Author: Michael Stahl mst...@redhat.com Date: Mon Oct 24 18:16:09 2011 +0200 WinResTarget: remove realpath calls diff --git a/solenv/gbuild/WinResTarget.mk b/solenv/gbuild/WinResTarget.mk index 234ab2d..7a4fee9 100644 --- a/solenv/gbuild/WinResTarget.mk +++ b/solenv/gbuild/WinResTarget.mk @@ -60,13 +60,13 @@ endef define gb_WinResTarget_add_file $(call gb_WinResTarget_get_clean_target,$(1)) : RCFILE=$(gb_Helper_SRCDIR_NATIVE)/$(2).rc -$(call gb_WinResTarget_get_target,$(1)) : RCFILE=$(realpath $(SRCDIR)/$(strip $(2)).rc) -$(call gb_WinResTarget_get_target,$(1)) : $(realpath $(SRCDIR)/$(strip $(2)).rc) +$(call gb_WinResTarget_get_target,$(1)) : RCFILE=$(SRCDIR)/$(strip $(2)).rc +$(call gb_WinResTarget_get_target,$(1)) : $(SRCDIR)/$(strip $(2)).rc endef define gb_WinResTarget_add_dependency -$(call gb_WinResTarget_get_target,$(1)) : $(foreach file,$(2),$(realpath $(SRCDIR)/$(strip $(file +$(call gb_WinResTarget_get_target,$(1)) : $(foreach file,$(2),$(SRCDIR)/$(file)) endef commit aa146f46d2688b9f0c7b03f540ca11fc2c6ee80b Author: Michael Stahl mst...@redhat.com Date: Mon Oct 24 17:48:06 2011 +0200 macros-test.cxx: unused variable pDoc diff --git a/sc/qa/unit/macros-test.cxx b/sc/qa/unit/macros-test.cxx index 3737869..e97156f 100644 --- a/sc/qa/unit/macros-test.cxx +++ b/sc/qa/unit/macros-test.cxx @@ -305,7 +305,6 @@ void ScMacrosTest::testVba() Sequence sal_Int16 aOutParamIndex; Sequence Any aOutParam; Sequence uno::Any aParams; -ScDocument* pDoc = xDocSh-GetDocument(); xDocSh-CallXScript(sUrl, aParams, aRet, aOutParamIndex,aOutParam); rtl::OUString aStringRes; commit 81042d7a366ad8d5f52fcd78e4b44183f62ce0e1 Author: Michael Stahl mst...@redhat.com Date: Mon Oct 24 17:10:06 2011 +0200 JavaClassSet: fix partial rebuilds Partial rebuilds can fail because the reubilt classes may import other classes that are not rebuilt; putting the target directory on the classpath seems to fix it (it would also be possible to use -sourcepath but that seems more complicated). diff --git a/solenv/gbuild/JavaClassSet.mk b/solenv/gbuild/JavaClassSet.mk index 292d7ae..cea27c0 100644 --- a/solenv/gbuild/JavaClassSet.mk +++ b/solenv/gbuild/JavaClassSet.mk @@ -43,7 +43,7 @@ $(call gb_Helper_abbreviate_dirs_native,\ $(filter-out $(JARDEPS),$(4) \ $(if $(3),$(gb_JavaClassSet_JAVACCOMMAND) \ $(gb_JavaClassSet_JAVACDEBUG) \ - -cp $(CLASSPATH) \ + -cp $(CLASSPATH)$(gb_CLASSPATHSEP)$(call gb_JavaClassSet_get_classdir,$(2)) \ -d $(call gb_JavaClassSet_get_classdir,$(2)) \ @$$RESPONSEFILE ) \ rm -f $$RESPONSEFILE \ ___ Libreoffice-commits mailing list Libreoffice-commits@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - sc/qa vcl/unx
sc/qa/unit/macros-test.cxx |6 +++---
vcl/unx/generic/fontmanager/fontmanager.cxx |4
2 files changed, 7 insertions(+), 3 deletions(-)
New commits:
commit 1a76bb7161d0a892b6998f404d3922421a89db9b
Author: Michael Stahl mst...@redhat.com
Date: Mon Oct 24 21:23:23 2011 +0200
macros-test.cxx: fix syntax error
diff --git a/sc/qa/unit/macros-test.cxx b/sc/qa/unit/macros-test.cxx
index e97156f..28f5d49 100644
--- a/sc/qa/unit/macros-test.cxx
+++ b/sc/qa/unit/macros-test.cxx
@@ -269,8 +269,8 @@ struct TestMacroInfo
};
void ScMacrosTest::testVba()
{
-TestMacroInfo testInfo[] {
-{
+TestMacroInfo testInfo[] = {
+{
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(TestAddress.)),
rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(vnd.sun.Star.script:VBAProject.Sheet1.test?language=Basiclocation=document))
},
@@ -282,7 +282,7 @@ void ScMacrosTest::testVba()
}
*/
};
-
+
rtl::OUString aFileExtension(aFileFormats[1].pName,
strlen(aFileFormats[1].pName), RTL_TEXTENCODING_UTF8 );
rtl::OUString aFilterName(aFileFormats[1].pFilterName,
strlen(aFileFormats[1].pFilterName), RTL_TEXTENCODING_UTF8) ;
rtl::OUString aFilterType(aFileFormats[1].pTypeName,
strlen(aFileFormats[1].pTypeName), RTL_TEXTENCODING_UTF8);
commit 95550e469b5b0fa90401235be8398ecd73dec11d
Author: Michael Stahl mst...@redhat.com
Date: Mon Oct 24 21:22:17 2011 +0200
PrintFontManager: don't look at empty path entires
diff --git a/vcl/unx/generic/fontmanager/fontmanager.cxx
b/vcl/unx/generic/fontmanager/fontmanager.cxx
index 0028f04..80cddee 100644
--- a/vcl/unx/generic/fontmanager/fontmanager.cxx
+++ b/vcl/unx/generic/fontmanager/fontmanager.cxx
@@ -2190,6 +2190,10 @@ void PrintFontManager::initialize()
{
OString aToken = aPath.getToken( 0, ';', nIndex );
normPath( aToken );
+if (!aToken.getLength())
+{
+continue;
+}
// if registering an app-specific fontdir with fontconfig fails
// and fontconfig-based substitutions are enabled
// then trying to use these app-specific fonts doesn't make sense
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: 2 commits - sc/CppunitTest_sc_macros_test.mk sc/qa
sc/CppunitTest_sc_macros_test.mk |1
sc/qa/unit/macros-test.cxx | 82 +--
2 files changed, 5 insertions(+), 78 deletions(-)
New commits:
commit fb95e1d94538ff7847f0597be756ff289a5608f5
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Mon Oct 24 23:21:24 2011 +0200
execute macros_test in headless mode too
otherwise a error dialog might pop up
diff --git a/sc/CppunitTest_sc_macros_test.mk b/sc/CppunitTest_sc_macros_test.mk
index 9049f85..8a9bd3d 100644
--- a/sc/CppunitTest_sc_macros_test.mk
+++ b/sc/CppunitTest_sc_macros_test.mk
@@ -97,6 +97,7 @@ $(eval $(call gb_CppunitTest_add_service_rdbs,sc_macros_test,\
))
$(eval $(call gb_CppunitTest_set_args,sc_macros_test,\
+--headless \
--protector unoexceptionprotector$(gb_Library_DLLEXT)
unoexceptionprotector \
-env:OOO_CONFIG_REGISTRY_DIR=$(call
gb_CppunitTarget__make_url,$(OUTDIR)/xml/registry) \
))
commit c631b30c6b9b9ffaf9a402c406282225c21560ff
Author: Markus Mohrhard markus.mohrh...@googlemail.com
Date: Mon Oct 24 23:07:51 2011 +0200
clean up macros-test
diff --git a/sc/qa/unit/macros-test.cxx b/sc/qa/unit/macros-test.cxx
index 28f5d49..fcc59ba 100644
--- a/sc/qa/unit/macros-test.cxx
+++ b/sc/qa/unit/macros-test.cxx
@@ -40,15 +40,12 @@
#include sfx2/sfxmodelfactory.hxx
#include svl/intitem.hxx
-#include editeng/brshitem.hxx
-#include editeng/justifyitem.hxx
#include basic/sbxdef.hxx
-#include helper/csv_handler.hxx
-#include orcus/csv_parser.hpp
-#include fstream
-#include string
-#include sstream
+#include docsh.hxx
+#include patattr.hxx
+#include scitems.hxx
+#include document.hxx
#define ODS_FORMAT_TYPE 50331943
#define XLS_FORMAT_TYPE 318767171
@@ -73,68 +70,6 @@ FileFormat aFileFormats[] = {
{ xlsx, Calc MS Excel 2007 XML , MS Excel 2007 XML, XLSX_FORMAT_TYPE
}
};
-void loadFile(const rtl::OUString aFileName, std::string aContent)
-{
-rtl::OString aOFileName = rtl::OUStringToOString(aFileName,
RTL_TEXTENCODING_UTF8);
-std::ifstream aFile(aOFileName.getStr());
-
-rtl::OStringBuffer aErrorMsg(Could not open csv file: );
-aErrorMsg.append(aOFileName);
-CPPUNIT_ASSERT_MESSAGE(aErrorMsg.getStr(), aFile);
-std::ostringstream aOStream;
-aOStream aFile.rdbuf();
-aFile.close();
-aContent = aOStream.str();
-}
-
-void testFile(rtl::OUString aFileName, ScDocument* pDoc, SCTAB nTab,
StringType aStringFormat = StringValue)
-{
-csv_handler aHandler(pDoc, nTab, aStringFormat);
-orcus::csv_parser_config aConfig;
-aConfig.delimiters.push_back(',');
-aConfig.delimiters.push_back(';');
-aConfig.text_qualifier = '';
-std::string aContent;
-loadFile(aFileName, aContent);
-orcus::csv_parsercsv_handler parser ( aContent[0], aContent.size() ,
aHandler, aConfig);
-try
-{
-parser.parse();
-}
-catch (const orcus::csv_parse_error e)
-{
-std::cout reading csv content file failed: e.what()
std::endl;
-rtl::OStringBuffer aErrorMsg(csv parser error: );
-aErrorMsg.append(e.what());
-CPPUNIT_ASSERT_MESSAGE(aErrorMsg.getStr(), false);
-}
-}
-
-//need own handler because conditional formatting strings must be generated
-void testCondFile(rtl::OUString aFileName, ScDocument* pDoc, SCTAB nTab)
-{
-conditional_format_handler aHandler(pDoc, nTab);
-orcus::csv_parser_config aConfig;
-aConfig.delimiters.push_back(',');
-aConfig.delimiters.push_back(';');
-aConfig.text_qualifier = '';
-std::string aContent;
-loadFile(aFileName, aContent);
-orcus::csv_parserconditional_format_handler parser ( aContent[0],
aContent.size() , aHandler, aConfig);
-try
-{
-parser.parse();
-}
-catch (const orcus::csv_parse_error e)
-{
-std::cout reading csv content file failed: e.what()
std::endl;
-rtl::OStringBuffer aErrorMsg(csv parser error: );
-aErrorMsg.append(e.what());
-CPPUNIT_ASSERT_MESSAGE(aErrorMsg.getStr(), false);
-}
-
-}
-
}
/* Implementation of Filters test */
@@ -151,7 +86,6 @@ public:
const rtl::OUString rUserData, const rtl::OUString rTypeName,
sal_uLong nFormatType=0);
void createFileURL(const rtl::OUString aFileBase, const rtl::OUString
aFileExtension, rtl::OUString rFilePath);
-void createCSVPath(const rtl::OUString aFileBase, rtl::OUString
rFilePath);
virtual void setUp();
virtual void tearDown();
@@ -225,14 +159,6 @@ void ScMacrosTest::createFileURL(const rtl::OUString
aFileBase, const rtl::OUSt
rFilePath = aBuffer.makeStringAndClear();
}
-void ScMacrosTest::createCSVPath(const rtl::OUString aFileBase,
rtl::OUString rCSVPath)
-{
-rtl::OUStringBuffer aBuffer(getSrcRootPath());
-
aBuffer.append(m_aBaseString).append(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(/contentCSV/)));
-
aBuffer.append(aFileBase).append(rtl::OUString(RTL_CONSTASCII_USTRINGPARAM(csv)));
-rCSVPath =
[Libreoffice-commits] .: sal/rtl
sal/rtl/source/alloc_arena.c |2 +-
sal/rtl/source/alloc_cache.c |8
2 files changed, 5 insertions(+), 5 deletions(-)
New commits:
commit 041b54fef20668abaab5bcc7b52dfc31695c25d2
Author: Stephan Bergmann sberg...@redhat.com
Date: Mon Oct 24 23:41:21 2011 +0200
Avoid Clang -Wunused-value with trunk rev. 12226 Valgrind.
diff --git a/sal/rtl/source/alloc_arena.c b/sal/rtl/source/alloc_arena.c
index 5984f75..3936481 100644
--- a/sal/rtl/source/alloc_arena.c
+++ b/sal/rtl/source/alloc_arena.c
@@ -1100,7 +1100,7 @@ SAL_CALL rtl_arena_free (
/* DEBUG ONLY: mark unallocated, undefined */
VALGRIND_MEMPOOL_FREE(arena, segment-m_addr);
-/* OSL_DEBUG_ONLY() */
VALGRIND_MAKE_MEM_UNDEFINED(segment-m_addr, segment-m_size);
+/* OSL_DEBUG_ONLY() */ (void)
VALGRIND_MAKE_MEM_UNDEFINED(segment-m_addr, segment-m_size);
OSL_DEBUG_ONLY(memset((void*)(segment-m_addr), 0x,
segment-m_size));
/* coalesce w/ adjacent free segment(s) */
diff --git a/sal/rtl/source/alloc_cache.c b/sal/rtl/source/alloc_cache.c
index 4fa16f4..e4cbc74 100644
--- a/sal/rtl/source/alloc_cache.c
+++ b/sal/rtl/source/alloc_cache.c
@@ -500,7 +500,7 @@ rtl_cache_slab_alloc (
addr = bufctl;
/* DEBUG ONLY: mark allocated, undefined */
-/* OSL_DEBUG_ONLY() */ VALGRIND_MAKE_MEM_UNDEFINED(addr,
cache-m_type_size);
+/* OSL_DEBUG_ONLY() */ (void) VALGRIND_MAKE_MEM_UNDEFINED(addr,
cache-m_type_size);
OSL_DEBUG_ONLY(memset(addr, 0x, cache-m_type_size));
VALGRIND_MEMPOOL_ALLOC(cache, addr, cache-m_type_size);
}
@@ -527,7 +527,7 @@ rtl_cache_slab_free (
/* DEBUG ONLY: mark unallocated, undefined */
VALGRIND_MEMPOOL_FREE(cache, addr);
-/* OSL_DEBUG_ONLY() */ VALGRIND_MAKE_MEM_UNDEFINED(addr,
cache-m_type_size);
+/* OSL_DEBUG_ONLY() */ (void) VALGRIND_MAKE_MEM_UNDEFINED(addr,
cache-m_type_size);
OSL_DEBUG_ONLY(memset(addr, 0x, cache-m_type_size));
/* determine slab from addr */
@@ -641,7 +641,7 @@ rtl_cache_magazine_clear (
if (cache-m_destructor != 0)
{
/* DEBUG ONLY: keep constructed object defined */
-VALGRIND_MAKE_MEM_DEFINED(obj, cache-m_type_size);
+(void) VALGRIND_MAKE_MEM_DEFINED(obj, cache-m_type_size);
/* destruct object */
(cache-m_destructor)(obj, cache-m_userarg);
@@ -1237,7 +1237,7 @@ SAL_CALL rtl_cache_alloc (
if (cache-m_constructor != 0)
{
/* keep constructed object defined */
-VALGRIND_MAKE_MEM_DEFINED(obj, cache-m_type_size);
+(void) VALGRIND_MAKE_MEM_DEFINED(obj, cache-m_type_size);
}
#endif /* HAVE_VALGRIND_MEMCHECK_H */
cache-m_cpu_stats.m_alloc += 1;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: sal/rtl
sal/rtl/source/alloc_arena.c |2 +-
sal/rtl/source/alloc_cache.c |8
sal/rtl/source/alloc_impl.h |2 ++
3 files changed, 7 insertions(+), 5 deletions(-)
New commits:
commit 0a6132d7de81e33f6d632f621cf30eb232c3b5df
Author: Stephan Bergmann sberg...@redhat.com
Date: Tue Oct 25 00:01:01 2011 +0200
Fix previous commit for non-Valgrind builds.
diff --git a/sal/rtl/source/alloc_arena.c b/sal/rtl/source/alloc_arena.c
index 3936481..1585273 100644
--- a/sal/rtl/source/alloc_arena.c
+++ b/sal/rtl/source/alloc_arena.c
@@ -1100,7 +1100,7 @@ SAL_CALL rtl_arena_free (
/* DEBUG ONLY: mark unallocated, undefined */
VALGRIND_MEMPOOL_FREE(arena, segment-m_addr);
-/* OSL_DEBUG_ONLY() */ (void)
VALGRIND_MAKE_MEM_UNDEFINED(segment-m_addr, segment-m_size);
+/* OSL_DEBUG_ONLY() */ RTL_VALGRIND_IGNORE_VAL
VALGRIND_MAKE_MEM_UNDEFINED(segment-m_addr, segment-m_size);
OSL_DEBUG_ONLY(memset((void*)(segment-m_addr), 0x,
segment-m_size));
/* coalesce w/ adjacent free segment(s) */
diff --git a/sal/rtl/source/alloc_cache.c b/sal/rtl/source/alloc_cache.c
index e4cbc74..1a4c87e 100644
--- a/sal/rtl/source/alloc_cache.c
+++ b/sal/rtl/source/alloc_cache.c
@@ -500,7 +500,7 @@ rtl_cache_slab_alloc (
addr = bufctl;
/* DEBUG ONLY: mark allocated, undefined */
-/* OSL_DEBUG_ONLY() */ (void) VALGRIND_MAKE_MEM_UNDEFINED(addr,
cache-m_type_size);
+/* OSL_DEBUG_ONLY() */ RTL_VALGRIND_IGNORE_VAL
VALGRIND_MAKE_MEM_UNDEFINED(addr, cache-m_type_size);
OSL_DEBUG_ONLY(memset(addr, 0x, cache-m_type_size));
VALGRIND_MEMPOOL_ALLOC(cache, addr, cache-m_type_size);
}
@@ -527,7 +527,7 @@ rtl_cache_slab_free (
/* DEBUG ONLY: mark unallocated, undefined */
VALGRIND_MEMPOOL_FREE(cache, addr);
-/* OSL_DEBUG_ONLY() */ (void) VALGRIND_MAKE_MEM_UNDEFINED(addr,
cache-m_type_size);
+/* OSL_DEBUG_ONLY() */ RTL_VALGRIND_IGNORE_VAL
VALGRIND_MAKE_MEM_UNDEFINED(addr, cache-m_type_size);
OSL_DEBUG_ONLY(memset(addr, 0x, cache-m_type_size));
/* determine slab from addr */
@@ -641,7 +641,7 @@ rtl_cache_magazine_clear (
if (cache-m_destructor != 0)
{
/* DEBUG ONLY: keep constructed object defined */
-(void) VALGRIND_MAKE_MEM_DEFINED(obj, cache-m_type_size);
+RTL_VALGRIND_IGNORE_VAL VALGRIND_MAKE_MEM_DEFINED(obj,
cache-m_type_size);
/* destruct object */
(cache-m_destructor)(obj, cache-m_userarg);
@@ -1237,7 +1237,7 @@ SAL_CALL rtl_cache_alloc (
if (cache-m_constructor != 0)
{
/* keep constructed object defined */
-(void) VALGRIND_MAKE_MEM_DEFINED(obj, cache-m_type_size);
+RTL_VALGRIND_IGNORE_VAL VALGRIND_MAKE_MEM_DEFINED(obj,
cache-m_type_size);
}
#endif /* HAVE_VALGRIND_MEMCHECK_H */
cache-m_cpu_stats.m_alloc += 1;
diff --git a/sal/rtl/source/alloc_impl.h b/sal/rtl/source/alloc_impl.h
index 55f6ed3..8ea0384 100644
--- a/sal/rtl/source/alloc_impl.h
+++ b/sal/rtl/source/alloc_impl.h
@@ -258,6 +258,7 @@ typedef CRITICAL_SECTION rtl_memory_lock_type;
#define VALGRIND_DESTROY_MEMPOOL(pool)
#define VALGRIND_MEMPOOL_ALLOC(pool, addr, size)
#define VALGRIND_MEMPOOL_FREE(pool, addr)
+#define RTL_VALGRIND_IGNORE_VAL
#elif defined(HAVE_MEMCHECK_H)
#include memcheck.h
/* valgrind macros contain unused variables... */
@@ -267,6 +268,7 @@ typedef CRITICAL_SECTION rtl_memory_lock_type;
#if GCC_VERSION = 40201 !defined __clang__
#pragma GCC diagnostic warning -Wunused-but-set-variable
#endif
+#define RTL_VALGRIND_IGNORE_VAL (void)
#endif /* NVALGRIND || HAVE_MEMCHECK_H */
typedef enum { AMode_CUSTOM, AMode_SYSTEM, AMode_UNSET } AllocMode;
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
[Libreoffice-commits] .: writerperfect/source
writerperfect/source/filter/OdtGenerator.cxx |3 +++
1 file changed, 3 insertions(+)
New commits:
commit 2ba5d12f3a49a23767f17b9db3c019cd6351cfc9
Author: Fridrich Å trba fridrich.st...@bluewin.ch
Date: Tue Oct 25 01:54:00 2011 +0200
Put the modeline back
diff --git a/writerperfect/source/filter/OdtGenerator.cxx
b/writerperfect/source/filter/OdtGenerator.cxx
index 94fd1fd..979b383 100644
--- a/writerperfect/source/filter/OdtGenerator.cxx
+++ b/writerperfect/source/filter/OdtGenerator.cxx
@@ -1,3 +1,4 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */
/* OdtGenerator: Collects sections and runs of text from a
* wordperfect file (and styles to go along with them) and writes them
* to a Writer target document
@@ -1345,3 +1346,5 @@ void OdtGenerator::registerEmbeddedObjectHandler(const
WPXString mimeType, OdfE
{
mpImpl-mObjectHandlers[mimeType] = objectHandler;
}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab: */
___
Libreoffice-commits mailing list
Libreoffice-commits@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice-commits
Re: [Libreoffice] [PATCH] [PUSHED] Match the correct function template specialization (in autodoc)
On 10/22/2011 11:37 AM, Kristian Rietveld wrote: My understanding of the issue is that when the EV_TokenId typedef is expanded, the resulting E_TokenId part is ambiguous. Therefore, fully specifying the E_TokenId fixes the problem. Yes. Thanks, Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Put neq-operator for awt::Size in correct namespace (in chartapiwrapper)
On 10/22/2011 11:39 AM, Kristian Rietveld wrote: If not done, Clang will not find the operator overload. Yeah, thanks. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] NEEDINFO Status and Keyword
Hi Rainer, I've used this status recently and I'm sorry for this. I'm going to reread the links you had given me about bugtracking : http://wiki.documentfoundation.org/BugReport and http://wiki.documentfoundation.org/BugReport_Details and correct this. But if NEEDINFO Status shouldn't be used, would it be possible to remove it to avoid this pb ? Julien. -- View this message in context: http://nabble.documentfoundation.org/NEEDINFO-Status-and-Keyword-tp3447207p3447391.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] NEEDINFO Status and Keyword
Hi Julien, IMHO there is no need to correct those 7 reports with a bulk change. Currently it's enough if we try to use the Bugzilla dashboard fairly unique and modify deviations when we see them and also do comments or similar in the bugs. But if NEEDINFO Status shouldn't be used, would it be possible to remove it to avoid this pb ? Unfortunately not, Status selector is for all Projects, and may be in an other way? For LibO I simply defined from my experience from the history, we have much more Keywords NEEDINFO than Status. Kind regards Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] NEEDINFO Status and Keyword
Jan Holesovsky schrieb: - you do not have to know about the keyword to set the status, because the UI for that is more convenient than typing the keyword - and resetting it back to NEW / RESOLVED is easier too; I am afraid in many cases the reporters forget to reset the keyword after having provided the information Hello, good points, may be we should change proceeding indeed that seems more easy. But that has to be coordinated with freedesktop.org, I have no information whether they have plans to change the workflow scheme. I will check that soon when we have a clear decision here - currently I believe we should follow your suggestion for the future. Kind regards Rainer ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] patch for fdo#41022 Activation Order Crashes Address Database
Hi Julien,
you rock that you tracked it down to the problematic code.
julien2412 píše v So 22. 10. 2011 v 07:34 -0700:
Hello,
I propose the patch attached to correct the bug.
I had put the backtrace of the error in the tracker.
It compiles ok and it doesn't crash. It seems to respect the order of the
fields we can see (cf the attached file of the tracker)
I fixed the comparison operator too cause when you clicked several times,
the order is changed for 2 fields each time and for always the same 2
fields.
http://nabble.documentfoundation.org/file/n3443648/patch_fdo41022.txt
patch_fdo41022.txt
I am a bit unsure about the change:
-if ( pEntry-aPos.Y() = pE-aPos.Y() )
+if ( pEntry-aPos.Y() pE-aPos.Y() )
It means that the following while cycle newer happens because it checks
for:
pEntry-aPos.Y() == pE-aPos.Y()
The following change would make more sense:
-if ( pEntry-aPos.Y() = pE-aPos.Y() )
+if ( pEntry-aPos.Y() == pE-aPos.Y() )
or we need to somehow update the check in that while cycle.
Otherwise, the most important change should be the added check:
nPos aCtrls.size()
It makes sure that pEntry-aPos.Y() is not called with invalid pEntry
pointer, so it avoids the crash.
Could you please test the attached patch? You might apply it using:
git am 0001-activation-order-crashes-address-database-fdo-41022.patch
Takes a lot for looking at the bug. You are great because you did the
hard work to find the problematic piece of code!
Best Regards,
Petr
From 1e54be7a9377a7c30d2acc7c23e1ae2f6d8e3505 Mon Sep 17 00:00:00 2001
From: julien2412 serval2...@yahoo.fr
Date: Mon, 24 Oct 2011 11:15:20 +0200
Subject: [PATCH] activation order crashes address database (fdo#41022)
---
toolkit/source/controls/stdtabcontroller.cxx |8 +---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/toolkit/source/controls/stdtabcontroller.cxx b/toolkit/source/controls/stdtabcontroller.cxx
index d5c2f06..92030f0 100644
--- a/toolkit/source/controls/stdtabcontroller.cxx
+++ b/toolkit/source/controls/stdtabcontroller.cxx
@@ -277,10 +277,12 @@ void StdTabController::autoTabOrder( ) throw(RuntimeException)
for ( nPos = 0; nPos aCtrls.size(); nPos++ )
{
ComponentEntry* pEntry = aCtrls[ nPos ];
-if ( pEntry-aPos.Y() = pE-aPos.Y() )
+if ( pEntry-aPos.Y() == pE-aPos.Y() )
{
-while ( pEntry ( pEntry-aPos.Y() == pE-aPos.Y() )
- ( pEntry-aPos.X() pE-aPos.X() ) )
+while ( nPos aCtrls.size()
+pEntry
+( pEntry-aPos.Y() == pE-aPos.Y() )
+( pEntry-aPos.X() pE-aPos.X() ) )
{
pEntry = aCtrls[ ++nPos ];
}
--
1.7.3.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] String::CompareIngoreCaseToAscii
On 21/10/11 16:04, Michael Meeks wrote: Hi August, Well - of course, it'd be nice to have some more complex tests of StarBasic (and VBA) macros, potentially loaded from .bas files inside a unit test. Noel - do you have any really nasty syntax / built-in basic functionality corner cases embedded into xls files that could be extracted and turned into compile-time unit tests in basic/ ? hmm off hand can't think precise hard examples, we surely have known problems buried in bug reports that we have previously identified ( specifically to do with VBA compatability mode ) . But.. I guess that's not the focus here, I suppose the idea here is to regression and/or unit test existing behaviour ? Probably we want to split testing of 'normal' basic v's 'vba compatability mode' basic. Unit testing the the core basic is of course a good idea but I would imagine very very time consuming, another problem is related to the question below I'm also curious about VBA support and whether there exists a grammar or similar documentation for the StarBASIC language. sorry to say I don't know of any such descriptions :-( and this is one of the problems at least for 'normal' basic operation where the historical behaviour of libreoffice/openoffice basic is more or less taken as the specification, it can be unclear as to whether some behaviour is intended or just a bug. Behaviour around visibility specifier ( public. private etc. ) come to mine here which are more or less ignored for 'historic' reasons My gut feeling for testing basic is it is probably easier to write stand alone macros that self test themselves either deployed as mentioned in some sort of flat file or in a document ( not sure how easy/hard it is to get basic to use a standalone file ). Certainly I see the use for more finegrained unit tests like the one shown in this thread when modifying the core code maybe to check runtime behaviour pre/post changes. Personally I don't think I would write such tests 'cold' ( of course no reason why you shouldn't if you really want to, this is just my personal opinion ) We have some bit-rotting vba tests in sc/source/ui/vba/test, most of these aren't really self testing but relied on writing output to a log file and comparing the results with 'known' output. This didn't work that well ( ambiguous output, differently output of different platforms etc. ) it would be great to get at least some of those converted to run within the qa test framework that moggi is working on. ( hopefully I can update with details of some updated test there later today ) Regarding the core basic I am of the opinion that even simple testing that captures the existing behaviour of things like precedence, results of logical/bitwise/arithmetic operators on different data types etc. that could serve as regression tests are useful. Part of the problem here is the scope for testing is quite huge Noel ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] unowinreg.dll usage
On 23/10/11 14:10, Tomáš Chvátal wrote: Tor I am not whining because it is dll, I am asking because it is another weird file libreoffice requests me to download, and for this one I was unable to think of any usage. interesting that it is now downloaded; back in OOo it used to be cross-compiled via MinGW; apparently that is still an option today if you configure --enable-build-unowinreg. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] compilation error in binfilter/bf_svx/
Hi, I have a problem with binfilter (./g pull -r this morning, make clean, make), compilation fails with the following message: Compiling: binfilter/bf_svx/source/xoutdev/svx_xattr.cxx /home/jbf/LibO/master/clone/binfilter/binfilter/bf_svx/source/xoutdev/svx_xattr.cxx: In member function 'virtual binfilter::SfxPoolItem* binfilter::XFillAttrSetItem::Create(SvStream, USHORT) const': /home/jbf/LibO/master/clone/binfilter/binfilter/bf_svx/source/xoutdev/svx_xattr.cxx:3883: error: 'stderr' was not declared in this scope /home/jbf/LibO/master/clone/binfilter/binfilter/bf_svx/source/xoutdev/svx_xattr.cxx:3883: error: 'fprintf' was not declared in this scope dmake: Error code 1, while making '../../../unxlngx6.pro/slo/svx_xattr.obj' I have commented the offending line (line 3883 in .../binfilter/bf_svx/source/xoutdev/svx_xattr.cxx) and binfilter has been build without problem. Is it a problem in my own configuration or somebody forgot to remove this line before to commit it's patch ? Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Novell/SUSE - license statement ...
Someone pointed out that we don't have one of these for SUSE employee's contributions which is a fair point :-) so here it is: In line with our general corporate policy, code contributed to open source projects will be made available under the terms of that project's license. Thus, all contributions past, present, and future (while this choice of project license is in place) made to LibreOffice from SUSE / Novell are available under the terms the MPL / LGPLv3+ All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] compilation error in binfilter/bf_svx/
On 10/24/2011 12:25 PM, Jean-Baptiste Faure wrote: Compiling: binfilter/bf_svx/source/xoutdev/svx_xattr.cxx /home/jbf/LibO/master/clone/binfilter/binfilter/bf_svx/source/xoutdev/svx_xattr.cxx: In member function 'virtual binfilter::SfxPoolItem* binfilter::XFillAttrSetItem::Create(SvStream, USHORT) const': /home/jbf/LibO/master/clone/binfilter/binfilter/bf_svx/source/xoutdev/svx_xattr.cxx:3883: error: 'stderr' was not declared in this scope /home/jbf/LibO/master/clone/binfilter/binfilter/bf_svx/source/xoutdev/svx_xattr.cxx:3883: error: 'fprintf' was not declared in this scope dmake: Error code 1, while making '../../../unxlngx6.pro/slo/svx_xattr.obj' Oops, had erroneously been pushed. Fixed now http://cgit.freedesktop.org/libreoffice/binfilter/commit/?id=e8c71c5ae20d33f8aa3bf67296b71c955fd11b34. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Also use .NET2003 build fix for Clang (in toolkit)
On 10/22/2011 11:47 AM, Kristian Rietveld wrote: By far the quickest is to use the already existing fix for .NET2003 for clang as well. In the future, this is something that possibly should be avoided in the class hierarchy, there are more classes in the code base that expose a similar problem. Pushed, thanks. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Build: Turning off Debug after enabling it for a module
Hi, I have done a build debug=t on a module. Now every time I build this module, debug symbols are build - no matter, if I have the debug parameter or not. Is there a trick to turn a debug build off? Greetings eymux ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build: Turning off Debug after enabling it for a module
Hi there, On Mon, 2011-10-24 at 14:00 +0200, Andor E wrote: I have done a build debug=t on a module. Now every time I build this module, debug symbols are build - no matter, if I have the debug parameter or not. Is there a trick to turn a debug build off? That is odd :-) quite possibly you configured with some debug option enabled ? what does autogen.lastrun say ? if so your environment will have the moral equivalent of debug=true. Otherwise, perhaps the debug messages are coming from a module that is not re-built; so rm -Rf unxlngi6.pro (or equiv.) first and then a re-build might fix it. Hope that helps, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build: Turning off Debug after enabling it for a module
Hi, I did remove unxlngi6.pro. The configure.log shows that debug is turned off. I might have to add, that I'm building OOo. Thanks eymux On Mon, Oct 24, 2011 at 2:25 PM, Michael Meeks michael.me...@suse.com wrote: Hi there, On Mon, 2011-10-24 at 14:00 +0200, Andor E wrote: I have done a build debug=t on a module. Now every time I build this module, debug symbols are build - no matter, if I have the debug parameter or not. Is there a trick to turn a debug build off? That is odd :-) quite possibly you configured with some debug option enabled ? what does autogen.lastrun say ? if so your environment will have the moral equivalent of debug=true. Otherwise, perhaps the debug messages are coming from a module that is not re-built; so rm -Rf unxlngi6.pro (or equiv.) first and then a re-build might fix it. Hope that helps, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Trouble of showing LibreOffice/OpenOffice toolbar back
Hi Noel co.
I'll CC the public dev list on this since it may be of wider interest.
On Mon, 2011-10-24 at 11:24 +0100, Noel Power wrote:
something like this should work ( although doesn't on master or 3.4
but... does appear to work on 3.3 :-/ ) seems like this really is a
regression
Carlos - reading the code, it looks like 'setVisible' is what you want
to be calling - it -looks- (on a first glance) as if it doesn't save the
state in this case - so it should be something we can call and will not
alter the other documents (but perhaps I'm mistaken).
sub togglefind
layoutManager = thisComponent.currentController.frame.layoutManager
findbarUrl = private:resource/toolbar/findbar
bVis = layoutmanager.iselementvisible( private:resource/toolbar/findbar )
msgbox Findbar currently IsVisible? bVis
if bVis then
layoutmanager.hideElement( findbarUrl )
else
layoutmanager.showelement( findbarUrl )
endif
end sub
I'm personally suspicious of:
commit 560e5132f606b1fcd790e3cf97d665cec8c442fc
Author: Carsten Driesner c...@openoffice.org
Date: Mon Nov 1 13:29:26 2010 +0100
dockingwindows: #i112595# Fixed problem related to changes for
better layouting. Further code rework
Which does the:
-if ( pWindow pIter-m_bFloating )
-pWindow-Show(bVisible bToolbarVisible, SHOW_NOFOCUSCHANGE |
SHOW_NOACTIVATE );
+if ( pWindow )
+{
+bool bSetVisible( pIter-m_bVisible bVisible );
+if ( !bSetVisible )
+pWindow-Hide();
+else
+{
+if ( pIter-m_bFloating )
+pWindow-Show(true, SHOW_NOFOCUSCHANGE | SHOW_NOACTIVATE );
+else
+implts_setLayoutDirty();
+}
Which (at first glance) doesn't seem to hide non-floating windows ( or
perhaps I'm missing how the dirty notification propagates somehow ).
HTH,
Michael.
--
michael.me...@suse.com , Pseudo Engineer, itinerant idiot
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] vcl: Printing UI page range autofocus
Hi, At 06:50 22-10-2011, Maxim Iorsh wrote: When the user selects Pages radio button in the Range section, it is very reasonable to expect that she would now want to specify the range. Thus moving the focus automatically to the page range edit box would save the user a mouse click. Unrequested focus changes that are not announced in advance are not good practice for accessibility reasons. 1. When a screen reader user (typically a blind user) encounters a set of radio buttons, the only way to find out what the buttons are, is going through them with the up/down arrow. If the focus changes to the page range input field when she puts the focus on the Pages radio button, the label for the radio button will either not be read by the screen reader or the labels for the radio button and the edit field will be run together, which might lead to confusion. 2. Keyboard users (not only blind users) move through dialogs like the Print dialog with the Tab key and the Shift+Tab key. The latter is for navigating backwards. With this patch, what happens when the user presses Shift+Tab from the Page Range field in order to move back to the radio buttons? Does the focus immediately get pushed back to the edit field, making backwards navigation impossible? Best regards, Christophe Code is contributed under the LGPLv3+ / MPL. Signed-off-by: Maxim Iorsh io...@users.sourceforge.net --- vcl/source/window/printdlg.cxx | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) -- Christophe Strobbe K.U.Leuven - Dept. of Electrical Engineering - SCD Research Group on Document Architectures Kasteelpark Arenberg 10 bus 2442 B-3001 Leuven-Heverlee BELGIUM tel: +32 16 32 85 51 http://www.docarch.be/ Twitter: @RabelaisA11y --- Open source for accessibility: results from the AEGIS project www.aegis-project.eu --- Please don't invite me to Facebook, Quechup or other social networks. You may have agreed to their privacy policy, but I haven't. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] patch for fdo#41022 Activation Order Crashes Address Database
Petr Mladek píše v Po 24. 10. 2011 v 11:23 +0200:
Could you please test the attached patch? You might apply it using:
git am 0001-activation-order-crashes-address-database-fdo-41022.patch
It did not sort the very last element FaxNumber from the sample
document.
Well, it was a simple insert sort algorithm but it was written somehow
complicated way. I have simplified it, see the attached patch.
It works here. Could you please try it?
Best Regards,
Petr
From e7698add6ba6bda362e50b343cac0682167fbcca Mon Sep 17 00:00:00 2001
From: julien2412 serval2...@yahoo.fr
Date: Mon, 24 Oct 2011 14:46:13 +0200
Subject: [PATCH] activation order crashes address database (fdo#41022)
---
toolkit/source/controls/stdtabcontroller.cxx | 13 -
1 files changed, 4 insertions(+), 9 deletions(-)
diff --git a/toolkit/source/controls/stdtabcontroller.cxx b/toolkit/source/controls/stdtabcontroller.cxx
index d5c2f06..86604f9 100644
--- a/toolkit/source/controls/stdtabcontroller.cxx
+++ b/toolkit/source/controls/stdtabcontroller.cxx
@@ -262,6 +262,7 @@ void StdTabController::autoTabOrder( ) throw(RuntimeException)
sal_uInt32 nCtrls = aCompSeq.getLength();
Reference XWindow * pComponents = aCompSeq.getArray();
+// insert sort algorithm
ComponentEntryList aCtrls;
size_t n;
for ( n = 0; n nCtrls; n++ )
@@ -277,15 +278,9 @@ void StdTabController::autoTabOrder( ) throw(RuntimeException)
for ( nPos = 0; nPos aCtrls.size(); nPos++ )
{
ComponentEntry* pEntry = aCtrls[ nPos ];
-if ( pEntry-aPos.Y() = pE-aPos.Y() )
-{
-while ( pEntry ( pEntry-aPos.Y() == pE-aPos.Y() )
- ( pEntry-aPos.X() pE-aPos.X() ) )
-{
-pEntry = aCtrls[ ++nPos ];
-}
-break;
-}
+if ( ( pEntry-aPos.Y() pE-aPos.Y() ) ||
+ ( pEntry-aPos.Y() == pE-aPos.Y() ) ( pEntry-aPos.X() pE-aPos.X() ) )
+break;
}
if ( nPos aCtrls.size() ) {
ComponentEntryList::iterator it = aCtrls.begin();
--
1.7.3.4
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] vcl: Printing UI page range autofocus
Hi Maxime, On Mon, 2011-10-24 at 14:52 +0200, Christophe Strobbe wrote: At 06:50 22-10-2011, Maxim Iorsh wrote: When the user selects Pages radio button in the Range section, it is very reasonable to expect that she would now want to specify the range. Thus moving the focus automatically to the page range edit box would save the user a mouse click. Which looks nice ! :-) Unrequested focus changes that are not announced in advance are not good practice for accessibility reasons. Unfortunately, I suspect Christophe is right, so - presumably we need to do this in a slightly more cunning fashion (ditto for the PDF case). I wonder what ways those could be - personally I love the easier to use, more ergonomic UI change you suggest - and surely it'd help improve life for impaired people too if they could find out about it. The tab navigation ordering is already somewhat strange in the print dialog with the Print in reverse page order appearing in the chain before the radio buttons above it - which might be worth fixing too. On Mon, 2011-10-24 at 14:52 +0200, Christophe Strobbe wrote: 1. When a screen reader user (typically a blind user) encounters a set of radio buttons, the only way to find out what the buttons are, is going through them with the up/down arrow. Surely the screen reader knows these are part of a radio button group and has relations it can use to read out the options ? 2. Keyboard users (not only blind users) move through dialogs like the Print dialog with the Tab key and the Shift+Tab key. The latter is for navigating backwards. With this patch, what happens when the user presses Shift+Tab from the Page Range field in order to move back to the radio buttons ? It works fine; you go from the entry back to the Pages button (which is already selected so we don't get a new selection event) and then you can use up and down arrows. Does the focus immediately get pushed back to the edit field, making backwards navigation impossible? So no, this is fine, but good to check. For what it is worth the current situation for a blind user tabbing through that dialog is pretty horrible too - the 'tab' goes from 'All Pages' to the 'Pages' entry field (which is not insensitive when the Page range thing is unselected), and so on. So - IMHO, if the Pages entry (which we auto-focus) has a suitable label (saying 'Page range') that a screen reader can read, and we handle insensitivity better there - we already made the UI rather better for the impaired. More ideally, if we can clobber the up/down arrow on the keyboard to move to previous / next radio button in the group we improve things all around - right ? [ and fixing the tab chain looks like it would be nice too - but I'm not clear on the APIs for doing that - is it really just the order of instantiation of the widgets in vcl/source/window/printdlg.cxx eg. ? ]. How does that sound ? and thanks Maxim for caring enough to improve these rough edges ! :-) All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Build: Turning off Debug after enabling it for a module
On Mon, 2011-10-24 at 14:27 +0200, Andor E wrote: I did remove unxlngi6.pro. The configure.log shows that debug is turned off. I might have to add, that I'm building OOo. Well - I'd grab someone on IRC (#libreoffice-dev on irc.freenode.net) to ask, we need a lot more information about your build environment, git checkout etc. to be more helpful. ATB, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Also use .NET2003 build fix for Clang (in toolkit)
On 10/24/2011 01:26 PM, Stephan Bergmann wrote: Pushed, thanks. [had forgotten to add the PUSHED marker] ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] vcl: Printing UI page range autofocus
Hi Michael, Christophe, The accessibility issue is important indeed. I think a solution could be to automatically move the focus only in response to mouse click, and not keys (either tab or up/down arrow). This could solve the problem of keyboard / screen reader users. From the technical point of view, maybe a global solution would be most appropriate here. I mean, the function GrabFocus() could be modified to work only for mouse clicks. I think it is mostly responsible for such focus movements. Thank you, -- Maxim. On Mon, Oct 24, 2011 at 3:24 PM, Michael Meeks michael.me...@suse.comwrote: Hi Maxime, On Mon, 2011-10-24 at 14:52 +0200, Christophe Strobbe wrote: At 06:50 22-10-2011, Maxim Iorsh wrote: When the user selects Pages radio button in the Range section, it is very reasonable to expect that she would now want to specify the range. Thus moving the focus automatically to the page range edit box would save the user a mouse click. Which looks nice ! :-) Unrequested focus changes that are not announced in advance are not good practice for accessibility reasons. Unfortunately, I suspect Christophe is right, so - presumably we need to do this in a slightly more cunning fashion (ditto for the PDF case). I wonder what ways those could be - personally I love the easier to use, more ergonomic UI change you suggest - and surely it'd help improve life for impaired people too if they could find out about it. The tab navigation ordering is already somewhat strange in the print dialog with the Print in reverse page order appearing in the chain before the radio buttons above it - which might be worth fixing too. On Mon, 2011-10-24 at 14:52 +0200, Christophe Strobbe wrote: 1. When a screen reader user (typically a blind user) encounters a set of radio buttons, the only way to find out what the buttons are, is going through them with the up/down arrow. Surely the screen reader knows these are part of a radio button group and has relations it can use to read out the options ? 2. Keyboard users (not only blind users) move through dialogs like the Print dialog with the Tab key and the Shift+Tab key. The latter is for navigating backwards. With this patch, what happens when the user presses Shift+Tab from the Page Range field in order to move back to the radio buttons ? It works fine; you go from the entry back to the Pages button (which is already selected so we don't get a new selection event) and then you can use up and down arrows. Does the focus immediately get pushed back to the edit field, making backwards navigation impossible? So no, this is fine, but good to check. For what it is worth the current situation for a blind user tabbing through that dialog is pretty horrible too - the 'tab' goes from 'All Pages' to the 'Pages' entry field (which is not insensitive when the Page range thing is unselected), and so on. So - IMHO, if the Pages entry (which we auto-focus) has a suitable label (saying 'Page range') that a screen reader can read, and we handle insensitivity better there - we already made the UI rather better for the impaired. More ideally, if we can clobber the up/down arrow on the keyboard to move to previous / next radio button in the group we improve things all around - right ? [ and fixing the tab chain looks like it would be nice too - but I'm not clear on the APIs for doing that - is it really just the order of instantiation of the widgets in vcl/source/window/printdlg.cxx eg. ? ]. How does that sound ? and thanks Maxim for caring enough to improve these rough edges ! :-) All the best, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 41022, which changed state. Bug 41022 Summary: Activation Order Crashes Address Database https://bugs.freedesktop.org/show_bug.cgi?id=41022 What|Old Value |New Value Status|NEEDINFO|NEW Status|NEW |ASSIGNED Resolution||FIXED Status|ASSIGNED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] make check fails in ScFiltersTest
Hi Markus, On Thu, 2011-10-20 at 23:53 +0200, Markus Mohrhard wrote: Kohei, Eike: Any ideas why our xls import of these cells goes wrong in a windows build. It seems that none of our Linux or mac builds has a problem with this cell import. I'm looking if perhaps my mingw build shows the same but otherwise I have no idea. The content looks a bit like the fact that we added a non initialized double variable. Short of doing a build on Windows and debugging it, I have no clue. Is this still a problem BTW? I won't be able to do a build on Windows at least in the next few days, but I'll keep this in the back of my head in case this is still outstanding when I do my next windows build. Kohei -- Kohei Yoshida, LibreOffice hacker, Calc ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PUSHED] [REVIEW] patch for fdo38286 EDITING: Crash when inserting a constant in a query
julien2412 píše v So 22. 10. 2011 v 02:33 -0700: I commited (48cdc0318b348c51742339b243dc05546148b335) and pushed on Master the patch by adding a comment too. I put the fdo bug to resolved. I let you see about 3.4 since it needs review. The check for pNode-count() makes perfect sense. I am not 100% sure that the fallback pFunctionName = pNode; is correct. Well, it should not be worse than the crash. The patch really fixes the crash and works reasonable, so I have pushed it for libreoffice-3-4, see http://cgit.freedesktop.org/libreoffice/base/commit/?h=libreoffice-3-4id=718e2912d031280a52991157ffc024c5516eec32 Thanks a log for working on these nasty bugs. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] Question about resource-IDs
Hi all, I want to add some line ends, which are used in UML diagrams, to standard.soe. Problem is the localization of the names of that new line ends. Please correct me where I'm wrong in the following: In svx/source/dialog/sdstring.src the resource-IDs of kind RID_SVXSTR_LEND0 are connected to the English display name of the line end. /translations/source/lang/svx/source/dialog.po contains the translation for this display name. What is the task of those RID_SVXSTR_LEND0_DEF kind, with the ending '_DEF'? The actual number of the resource-ID is defined in /svx/inc/svx/dialogs.hrc I first thought I could add such resource-IDs, but the numbers are consecutive, so after RID_SVXSTR_LEND12_DEF follows immediately RID_SVXSTR_LEND0. And at the end of the range there are only free numbers from 'RID_SVX_START + 796' to 'RID_SVX_START + 799', perhaps to 'RID_SVX_START + 801', if those in cuires.hrc does not conflict with these in dialogs.hrc. But that are not enough for 7 new line ends. So, what to do? What is allowed, what is recommend? Kind regards Regina ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] Continuation of Fix for Bug fdo#41997 clean VCL enumeration
Hi Olivier, On Sat, 2011-10-22 at 08:08 -0200, Olivier Hallot wrote: Here is the patch to clean further, as requested. Wonderful ... thanks for that :-) I'll push it to the feature/gtk3 branch which I hope to merge tomorrow. Thanks, Michael. -- michael.me...@suse.com , Pseudo Engineer, itinerant idiot ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [PUSHED] hyphenation fixes
On Mon, 2011-10-17 at 15:18 +0200, Németh László wrote: I'm sorry, here are the missing patches. Many thanks for the integration. ok, pushed all these now. C. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW 3-4][PUSHED-3-4] Revised patches: fdo#40701 Base crashes when Find Record button is clicked
Lionel Elie Mamane píše v Pá 16. 09. 2011 v 23:50 +0200: Here are revised patches as per Eike's comments. They fix fdo#40701, which is a crasher, a regression and a most annoying 3.4 bug. There are two versions of it: * The one suggested by Eike * The one preferred by me You convinced me, so I have pushed your variant ;-) See http://cgit.freedesktop.org/libreoffice/libs-core/commit/?h=libreoffice-3-4id=45e6ceee47e4f1c5fdf800ae35b062f8387cf61c 0002-FmXGridPeer-getByIndex-Error-checking-of-pGrid-GetMo.patch fixes the reason the bug was a crasher instead of just broken feature, nothing happens when Find Record button is clicked. I have pushed this one as well, see http://cgit.freedesktop.org/libreoffice/libs-core/commit/?h=libreoffice-3-4id=8590273b3ee8f34386bcb9e620fab10794b38a6f We are sorry that it took so long to accept these patches. It has somehow fallen out of radar. Anyway, it did not miss any release and it will be in 3.4.4. Thanks patience and digging into these bugs. Best Regards, Pert ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 35673] LibreOffice 3.4 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=35673 Bug 35673 depends on bug 40701, which changed state. Bug 40701 Summary: Base crashes with runtime error when Find Record button is clicked with certain documents https://bugs.freedesktop.org/show_bug.cgi?id=40701 What|Old Value |New Value Resolution||FIXED Status|ASSIGNED|RESOLVED -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Argument to setTitle cannot be const (in fpicker/aqua)
On 10/22/2011 11:41 AM, Kristian Rietveld wrote: This fixes the following warning: /source/libo/libo/fpicker/source/aqua/ControlHelper.cxx:244:39: error: cannot initialize a parameter of type 'NSString *' with an lvalue of type 'const NSString *' I did not see another solution so quickly than removing const. Also, if you want to modify the actual string contents, you need to use NSMutableString anyway. pushed Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] SystemFlavor NSStrings should not be const (in vcl/aqua/.../dtrans/)
On 10/22/2011 11:43 AM, Kristian Rietveld wrote: This fixes an issue where const NSString* is assigned to a non-const NSString* field in FlavorMap. The NSString cannot be const when passed to an objective-C method expecting a non-const value (the NSStrings from flavor map are passed to such methods elsewhere in the code). Also, if you want to modify the actual string contents, you need to use NSMutableString anyway. pushed Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Use NSString in template specification instead of objc_object (in macosxspell)
On 10/22/2011 11:45 AM, Kristian Rietveld wrote: This fixes the following warnings: /source/libo/libo/lingucomponent/source/spellcheck/macosxspell/macspellimp.cxx:176:39: error: reference to type 'const value_type' (aka 'objc_object *const') could not bind to an rvalue of type 'id' postspdict.push_back( [ aLocales objectAtIndex:i ] ); ^~~~ /Developer/SDKs/MacOSX10.6.sdk/usr/include/c++/4.2.1/bits/stl_vector.h:600:35: note: passing argument to parameter '__x' here push_back(const value_type __x) pushed Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Eliminate ambiguous conversion to cppu::OWeakObject (in reportdesign)
On 10/22/2011 11:48 AM, Kristian Rietveld wrote: This fixes the following error: /source/libo/libo/reportdesign/source/core/sdr/ReportDrawPage.cxx:96:24: error: ambiguous conversion from derived class 'SvxShapeControl' to base class 'cppu::OWeakObject': class SvxShapeControl - class SvxShapeText - class SvxShape - SvxShape_UnoImplHelper - class cppu::OWeakAggObject - ::cppu::OWeakObject class SvxShapeControl - class SvxShapeText - class SvxUnoTextBase - class SvxUnoTextBase_Base - SvxUnoTextBase_Base0 - class SvxUnoTextRangeBase - SvxUnoTextRangeBase_Base - class cppu::OWeakAggObject - ::cppu::OWeakObject xShape.set(*pShape,uno::UNO_QUERY); ^~~ pushed Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] [PUSHED] Eliminate ambiguous conversion to cppu::OWeakObject (in svx/form)
On 10/22/2011 11:52 AM, Kristian Rietveld wrote: Similar to the previous patch. pushed, too Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEWED][PUSHED-3-4] cherry-pick to fix .sdw import in 3-4
Caolán McNamara píše v Pá 21. 10. 2011 v 14:07 +0100: I want to cherry-pick the attached commit back to 3-4, the .sdw import of the binfilter is broken otherwise as timar noted. Looked fine = pushed into 3-4 branch, see http://cgit.freedesktop.org/libreoffice/filters/commit/?h=libreoffice-3-4id=46c7ac486e44899cce3057727eccc502ee995a4d Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] error checking in Base ODBC
On Mon, 2011-10-24 at 10:32 +0100, Caolán McNamara wrote: On Sat, 2011-10-22 at 11:11 -0400, Terrence Enger wrote: Hmm. Is my question really of no interest? Or did I just time it badly with respect to the big conference? It's the wrong list really, libreoffice-dev is a better choice than libreoffice-qa for what is fundamentally a code level question. Yes, silly me. And it'd be easier for someone to see what you're talking about exactly, e.g. line numbers and source files if you attached e.g. the sample patch you were talking about at the time. Sounds like we should call SQLDisconnect anyway. I shall proceed with that. And, unless somebody tells me otherwise, I shall indulge myself with OSL_ENSURE() on the return values. Terry. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Cherry-pick to 3-4? commit f33232a3ff67d7a4def830fa6fda78ef5f255ae7
Hi Tor, Tor Lillqvist píše v St 19. 10. 2011 v 10:42 +0300: OK, so technically not possible as cherry-pick because of the git repo combination, I guess, but anyway, should this fix be cherry-picked to the 3.4 branch? It is supposed to fix the Windows build so that a 64-bit Explorer extension is also built, to get the Explorer extension also on a 64-bit OS. Requested by fdo#36950 . Note that I have never actually tested whether this fix helps... So I will do that before actually cherry-picking, if signed off in principle. The patch looks safe and could go into libreoffice-3-4 branch. Have you tested the build? Did it succeed? ;-) Could you please back port it for libreoffice-3-4? There are conflicts. Best Regards, Petr ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] Question about resource-IDs
Hi Regina, 2011/10/24 Regina Henschel rb.hensc...@t-online.de: Hi all, I want to add some line ends, which are used in UML diagrams, to standard.soe. Problem is the localization of the names of that new line ends. Please correct me where I'm wrong in the following: In svx/source/dialog/sdstring.src the resource-IDs of kind RID_SVXSTR_LEND0 are connected to the English display name of the line end. /translations/source/lang/svx/source/dialog.po contains the translation for this display name. What is the task of those RID_SVXSTR_LEND0_DEF kind, with the ending '_DEF'? _DEF ending contains the English string (should be exactly the same as it is in the .soe file). The other entry withourt _DEF is translatable. So in the localized resource we will have both the English original and the localized string. When LibreOffice reads a soe file, it looks for English definition in the resource and displays its corresponding localized string on the UI. The actual number of the resource-ID is defined in /svx/inc/svx/dialogs.hrc I first thought I could add such resource-IDs, but the numbers are consecutive, so after RID_SVXSTR_LEND12_DEF follows immediately RID_SVXSTR_LEND0. And at the end of the range there are only free numbers from 'RID_SVX_START + 796' to 'RID_SVX_START + 799', perhaps to 'RID_SVX_START + 801', if those in cuires.hrc does not conflict with these in dialogs.hrc. But that are not enough for 7 new line ends. So, what to do? What is allowed, what is recommend? Renumber the whole section of line endings, for example start from 2770. Best regards, Andras ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] build error in tail_build
On 20/10/11 09:00, Noel Grandin wrote: Hi Building on Windows using Visual Studio, running into a build error in ScriptProviderForJava. Trimmed build log attached. Any ideas? Thanks, Noel Grandin have had this problem myself today, the command for compiling java files does not do the right thing in case of a partial rebuild. fixed on master: http://cgit.freedesktop.org/libreoffice/core/commit/?id=81042d7a366ad8d5f52fcd78e4b44183f62ce0e1 ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] make check fails in ScFiltersTest
Hi, On Thursday, 2011-10-20 23:53:39 +0200, Markus Mohrhard wrote: Kohei, Eike: Any ideas why our xls import of these cells goes wrong in a windows build. It seems that none of our Linux or mac builds has a problem with this cell import. I'm looking if perhaps my mingw build shows the same but otherwise I have no idea. The content looks a bit like the fact that we added a non initialized double variable. There may be two reasons that only shows up on a certain platform: a) as already lined out on IRC, for uninitialized variables allocated memory may have different content on different platforms. b) if that's only with one compiler and code inspection does not reveal an uninitialized variable, sometimes compiler optimization may overdo a bit. In such cases it may help to declare an affected variable as volatile. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpkJyigHSP5s.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [PATCH] Frac function in calc/BASIC
Hi Regina, On Friday, 2011-10-21 13:20:42 +0200, Regina Henschel wrote: For CALC there are some problems. A function FRAC is not defined in ODF1.2 [1]. Markus already gave a hint why we wouldn't even need a FRAC function in Calc as MOD(x,1) does it. However, the naming question remains for future functions not (yet) defined by ODF. So it has to be written different. For OOo that has been org.openoffice.style (for example). But I'm not sure, whether the same should be done for LO, or whether it should be org.libreoffice, or more general org.documentfoundation. Certainly it should not be ORG.OPENOFFICE.FOO, IMHO it should be ORG.LIBREOFFICE.FOO instead of ORG.DOCUMENTFOUNDATION.FOO, i.e. specify the implementation. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpUTQ8KOBbta.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] IDL hyper / Java long
Hi, On Friday, 2011-10-21 18:37:34 +0200, Stephan Bergmann wrote: As I wrote at https://bugs.freedesktop.org/show_bug.cgi?id=42005#c1, Calc add-ins do not support functions that take or return UNO type hyper. So I think that explains why an add-in using hyper in the .idl file does not work. Seconded. Why, however, it should work if the .idl file instead uses unsigned hyper I do not know. Wild guess: may it be that the .idl parser takes 'unsigned' of 'unsigned hyper' and ignores the 'hyper', effectively mapping that to an unsigned 32-bit value and generating sal_Int32 (not uInt32 as API doesn't know that)? Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpVTlwYreLtG.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] IDL hyper / Java long
Hi MarcinGutman, On Saturday, 2011-10-22 00:42:32 +0200, MarcinGutman wrote: Calc add-ins do not support functions that take or return UNO type hyper. .. however, it should work if the .idl file instead uses unsigned hyper ... You omitted some words that slightly change the meaning of the quoted sentence ;-) | Why, however, it should work if the .idl file instead uses unsigned | hyper I do not know. So actually that means that there is no reason that it should work with 'unsigned hyper', because in this context hyper should not work at all. You have to choose double or Object. On the other hand unsigned hyper works fine. So, why there is int in Wizard... use double instead. If you write a code and you want long you use long not double with Math.round(). Am I the first one who wants clean long in Calc add-in? Problem is that a hyper reflects a 64-bit value. Calc internally uses IEEE754 double and you can't map 64 bit into a double without sacrificing precision. Btw, please let your mail program not break threads, use Reply-All when replying. Thanks. Eike -- LibreOffice Calc developer. Number formatter stricken i18n transpositionizer. GnuPG key 0x293C05FD : 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD pgpeQwCrZfdIo.pgp Description: PGP signature ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] IDL hyper / Java long
On 10/24/2011 08:46 PM, Eike Rathke wrote: Why, however, it should work if the .idl file instead uses unsigned hyper I do not know. Wild guess: may it be that the .idl parser takes 'unsigned' of 'unsigned hyper' and ignores the 'hyper', effectively mapping that to an unsigned 32-bit value and generating sal_Int32 (not uInt32 as API doesn't know that)? Nah, such basic brokenness would already be caught by testtools/source/bridgetest. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] IDL hyper / Java long
... .idl parser takes 'unsigned' of 'unsigned hyper' and ignores the 'hyper' I tried with unsigned asdf and obtained an error: Illegal syntax or missing type in parameter declaration: syntax error, unexpected IDL_IDENTIFIER, expecting IDL_HYPER or IDL_LONG or IDL_SHORT in ... libreoffice3.4/basis3.4/sdk/bin/idlc Version 1.1 - Marcin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] make check fails in ScFiltersTest
Hey, 2011/10/24 Eike Rathke er...@redhat.com: Hi, On Thursday, 2011-10-20 23:53:39 +0200, Markus Mohrhard wrote: Kohei, Eike: Any ideas why our xls import of these cells goes wrong in a windows build. It seems that none of our Linux or mac builds has a problem with this cell import. I'm looking if perhaps my mingw build shows the same but otherwise I have no idea. The content looks a bit like the fact that we added a non initialized double variable. There may be two reasons that only shows up on a certain platform: a) as already lined out on IRC, for uninitialized variables allocated memory may have different content on different platforms. b) if that's only with one compiler and code inspection does not reveal an uninitialized variable, sometimes compiler optimization may overdo a bit. In such cases it may help to declare an affected variable as volatile. I tried with our mingw build and it happens there too. I can't debug it because any recent debug mingw builds from me won't start. An older non debug build showed that problem. I'm trying again to get a windows build but my hopes are very low. I have never been able to get a working windows build. To test it you can use the formats.xls or even better the matrix.xls which shows that it seems to be only related to some numbers. I haven't seen a system behind them yet. It would be good if I won't be able to get a windows build soon that someone with one (or a mingw debug build) could have a look at it. Thanks a lot, Markus ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] compilation error in binfilter/bf_svx/
Hi Stephan, Le 24/10/2011 13:04, Stephan Bergmann a écrit : On 10/24/2011 12:25 PM, Jean-Baptiste Faure wrote: [...] error: 'fprintf' was not declared in this scope dmake: Error code 1, while making '../../../unxlngx6.pro/slo/svx_xattr.obj' Oops, had erroneously been pushed. Fixed now http://cgit.freedesktop.org/libreoffice/binfilter/commit/?id=e8c71c5ae20d33f8aa3bf67296b71c955fd11b34. Thank you :-) Best regards. JBF -- Seuls des formats ouverts peuvent assurer la pérennité de vos documents. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [REVIEW] Cherry-pick to 3-4? commit f33232a3ff67d7a4def830fa6fda78ef5f255ae7
See fdo#36950 for discussion. It doesn't seem to make sense to push a backport of the commit to the 3-4 branch, as we don't know if it actually helps the problem. --tml ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-qa] error checking in Base ODBC
On 10/24/2011 05:59 PM, Terrence Enger wrote: I shall proceed with that. And, unless somebody tells me otherwise, I shall indulge myself with OSL_ENSURE() on the return values. Note that OSL_ENSURE, OSL_ASSERT, and OSL_FAIL should only be used for logic errors (i.e., the program detects that it contains an error and ends up in a state that cannot happen), not for uncommon situations that nevertheless should be handled, like IO errors or malformed user input. OSL_TRACE, on the other hand, is the tool of choice to document interesting events during program execution (which is only evaluated when built with DEBUG=TRUE, however). -- Even if lots of places in the code base misuse the former for the latter. Ideally, OSL_ENSURE et al. should directly abort program execution, but we're not there, yet. Stephan ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-commits] .: writerperfect/source
At 7:24pm -0400 Mon, 24 Oct 2011, Fridrich Štrba wrote:
New commits:
commit 38cf494f90d19d1673773437cd52e8f0cfbf4eb5
Author: Fridrich Štrba fridrich.st...@bluewin.ch
Date: Tue Oct 25 01:11:49 2011 +0200
White-space change to fix messy mix of different coding styles
[...]
diff --git a/writerperfect/source/filter/FontStyle.cxx
b/writerperfect/source/filter/FontStyle.cxx
index 5743e1e..ac501c6 100644
void FontStyleManager::clean()
{
for (std::mapWPXString, FontStyle *, ltstr::iterator iter =
mHash.begin();
- iter != mHash.end(); ++iter)
+iter != mHash.end(); iter++)
{
@@ -65,7 +63,7 @@ void
FontStyleManager::writeFontsDeclaration(OdfDocumentHandler *pHandler) const
for (std::mapWPXString, FontStyle *, ltstr::const_iterator iter =
mHash.begin();
- iter != mHash.end(); ++iter)
+iter != mHash.end(); iter++)
Err, in terms of coding style, is a pre to post increment operator
merely a whitespace change? I seem to recall a message or two on the
subject but I'm having a difficult time tracking them down just now.
About 8 months ago, perhaps?
Kevin
___
LibreOffice mailing list
LibreOffice@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] [Libreoffice-commits] .: writerperfect/source
At 9:48pm -0400 Mon, 24 Oct 2011, Kevin Hunter wrote: At 7:24pm -0400 Mon, 24 Oct 2011, Fridrich Štrba wrote: for (std::mapWPXString, FontStyle *, ltstr::const_iterator iter = mHash.begin(); - iter != mHash.end(); ++iter) + iter != mHash.end(); iter++) Err, in terms of coding style, is a pre to post increment operator merely a whitespace change? I seem to recall a message or two on the subject but I'm having a difficult time tracking them down just now. About 8 months ago, perhaps? Kevin: open mouth, insert foot. I apologize. Just perusing commits, should've kept going. I take it the pre to post is needed to fix the build. Kevin ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice] build error in tail_build
Here is my build_error.log http://nabble.documentfoundation.org/file/n3450416/build_error.log build_error.log As I already stated, when I remove all mentions of adabasui, I no longer get the adabasuilo.so error, but I still get the sdbtlo.so error. I am not sure if adabasui is the problem, or if the problem is somewhere else, and only showing up here, but since everything from this point on fails the same way, I am thinking the problem is somewhere else, but I have no idea where. Then again, I could be totally wrong. Thanks for the help so far. Any other ideas? -- View this message in context: http://nabble.documentfoundation.org/build-error-in-tail-build-tp3419875p3450416.html Sent from the Dev mailing list archive at Nabble.com. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
[Libreoffice] [Bug 37361] LibreOffice 3.5 most annoying bugs
https://bugs.freedesktop.org/show_bug.cgi?id=37361 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Depends on||42178 Version|unspecified |LibO Master --- Comment #16 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-10-24 21:43:21 PDT --- Nominate Bug 42178 - CRASH when PRINTING from Page Preview -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are on the CC list for the bug. ___ LibreOffice mailing list LibreOffice@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice
Re: [Libreoffice-qa] error checking in Base ODBC
On Sat, 2011-10-22 at 11:11 -0400, Terrence Enger wrote: Hmm. Is my question really of no interest? Or did I just time it badly with respect to the big conference? It's the wrong list really, libreoffice-dev is a better choice than libreoffice-qa for what is fundamentally a code level question. And it'd be easier for someone to see what you're talking about exactly, e.g. line numbers and source files if you attached e.g. the sample patch you were talking about at the time. Sounds like we should call SQLDisconnect anyway. C. ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
Re: [Libreoffice-qa] db test VM
On Wed, 2011-10-19 at 20:39 +0200, Petr Mladek wrote: Bernhard M. Wiedemann píše v St 19. 10. 2011 v 16:04 +0200: during package install I got /opt/lo-dev/program/unopkg.bin: error while loading shared libraries: libpng12.so.0: cannot open shared object file: No such file or directory It is related to https://bugs.freedesktop.org/show_bug.cgi?id=36497#c2 We need to disable the splash also in the daily build. I am going to investigate it. which I worked around with a sudo zypper -n in libpng12-0 This is a good workaround. Then some configs or dirs were needed which I got by pulling the losmoketest-0.2.tar.bz2 that I found by googling. I am sorry. I should have told you about it. This was described in http://cgit.freedesktop.org/libreoffice/core/tree/smoketestoo_native/losmoketest.readme It is still work in progress. We are going to package this stuff and make it more convenient to use. and then, everything runs. Though 22 seconds total time for test is surprisingly quick. It is just a basic test. For example, it checks that all applications, calc, writer, impress, can be started. if you want to test: curl http://openqa.opensuse.org/opensuse/qatests/qa_office.sh|sh Great work! Please, find attached slightly updated version. There are two changes: + use mktemp instead of the hardcoded temp dir name + use --headless option to do the test even without working X11; heh, you might want to remove it, if you have running X11 session in the openQA framework I hope that it helps. I am very interested how the DB testing will work in the end. Howdy all, Well, thought I'd let folks know what I've been up to with the SuseSTUDIO service...errr stuff. Creating a VM with the daily build files turned out to be really straightforward. - OK, so it's not automated for daily updates, but doing so by hand now is really quite simple and fairly quick (3 clicks and ~10 minutes), and not that big a deal for what I personally had in mind. Here is the latest configuration setup: http://susegallery.com/a/EvUJ20/lo-client-daily-libreoffice_master That VM image includes yesterdays (10-23-2011) build from Master, located at /opt/lo-dev Currently there is no menu integration (should be there tomorrow :) Anyway - I'll update the wiki page with more details this afternoon. //drew ___ List Name: Libreoffice-qa mailing list Mail address: Libreoffice-qa@lists.freedesktop.org Change settings: http://lists.freedesktop.org/mailman/listinfo/libreoffice-qa Problems? http://www.libreoffice.org/get-help/mailing-lists/how-to-unsubscribe/ Posting guidelines + more: http://wiki.documentfoundation.org/Netiquette List archive: http://lists.freedesktop.org/archives/libreoffice-qa/
[Libreoffice-bugs] [Bug 41915] named cells not highlighted when editing formulae
https://bugs.freedesktop.org/show_bug.cgi?id=41915 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Status|UNCONFIRMED |NEW CC||LibreOffice@bielefeldundbus ||s.de Ever Confirmed|0 |1 --- Comment #8 from Michael Dewitt mjdwitt...@gmail.com 2011-10-21 08:33:30 PDT --- Also, this is still a problem in the current git master branch for x86_64. It could be a problem in git builds on x86 systems as well, however, I am not running any x86 systems and cannot test that. --- Comment #9 from Michael Dewitt mjdwitt...@gmail.com 2011-10-21 08:33:50 PDT --- Also, this is still a problem in the current git master branch for x86_64. It could be a problem in git builds on x86 systems as well, however, I am not running any x86 systems and cannot test that. --- Comment #10 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-10-23 23:01:44 PDT --- [Reproducible] with LibreOffice Portable 3.3.3 - WIN7 Home Premium (64bit) German UI [OOO330m19 (Build:301 Tag 3.3.3.1)]. Steps to reproduce: 1. penn attached sample.ods 2. Double click 'D3' As expected referenced Cells B2, B3 get colored borders and references in formula B2 and B3 are shown with colors of cell borders. 3. Double click 'D4' Unexpectedly referenced Cells B2 (name = NamedCell1), B3 (name = NamedCell2) will NOT get colored borders and references in formula NamedCell1 and NamedCell2 are NOT shown with colors of cell borders. Might be an other aspect of Bug 41304 - EDITING: Cell formula shown without colors, colored frames missing around referenced cells -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41915] named cells not highlighted when editing formulae
https://bugs.freedesktop.org/show_bug.cgi?id=41915 --- Comment #11 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-10-23 23:03:01 UTC --- Created attachment 52671 -- https://bugs.freedesktop.org/attachment.cgi?id=52671 Sample document, see Comment 10 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41915] named cells not highlighted when editing formulae
https://bugs.freedesktop.org/show_bug.cgi?id=41915 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added Version|LibO 3.4.3 release |LibO 3.3.3 release --- Comment #12 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-10-23 23:05:37 PDT --- Old problem, see Comment 10! Still problem with Server installation of Master LibO-dev 3.5.0 – WIN7 Home Premium (64bit) English UI [(Build ID: d3d1481-3f8994a-2ba0a9f)] (110909) @Kohei: Please feel free to reassign (or reset Assignee to default) if it’s not your area or if provided information is not sufficient. Please set Status to ASSIGNED if you accept this Bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42147] New: Opening valid ODF text document crashes Writer
https://bugs.freedesktop.org/show_bug.cgi?id=42147 Bug #: 42147 Summary: Opening valid ODF text document crashes Writer Classification: Unclassified Product: LibreOffice Version: LibO 3.4.3 release Platform: All OS/Version: All Status: UNCONFIRMED Severity: critical Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: ibur...@gmail.com Created attachment 52672 -- https://bugs.freedesktop.org/attachment.cgi?id=52672 The test case file causing a crash Valid ODF text documents (created in LibreOffice 3.4.1 without an issue) that contain at least one page with a frame, size of which is in certain proportion to the page size and the header height on that page, cannot be opened in LibreOffice 3.4.3 without causing a crash. Regardless of whether such a document is opened from a running instance of Writer or whether it is passed to 'libreoffice' executable as a command line argument (one can reproduce the issue either way), LibreOffice starts to open the file showing a progress bar and sometimes even rendering the first few pages of the document, and then suddenly halts. I experience the bug both on x86 and x86-64 systems running both Windows and Linux. The minimal document I can create to reproduce this crash behavior, consists of a single page with a frame of particular size. The file containing that document is attached to this bug report. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 41835] EDITING: AUTOFILTER shows cells not containing filter criteria
https://bugs.freedesktop.org/show_bug.cgi?id=41835 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added CC||LibreOffice@bielefeldundbus ||s.de Summary|EDITING: AUTOFILTER |EDITING: AUTOFILTER shows ||cells not containing filter ||criteria Keywords||NEEDINFO --- Comment #2 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-10-23 23:49:24 PDT --- NOT reproducible with LibreOffice 3.4.3 - WIN7 Home Premium (64bit) German UI [OOO340m1 (Build:302)] @baldinirob...@yahoo.it Please attach a sample document! -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 38327] Pivot table converts text values to numbers in column headers
https://bugs.freedesktop.org/show_bug.cgi?id=38327 --- Comment #10 from Nikos gdna7...@hotmail.com 2011-10-24 00:15:13 PDT --- Unfortunately, I must revise my comment that changing the Pivot table category style solves the problem in my case, since this is the case only in a very limited number of cases. In other cases the pivot table just returns the numeric value corresponding to the date it interprets in my data. I am very disappointed by this behavior of the software. One of the reasons I moved to Openoffice (back in 2.2) was that the distinction between different data types (strings vs. numbers) was clearer than in the software we used till that time. Even though I understand the urge to keep up with a market leader as well as the necessity to maintain (or achieve) a high level of compatibility, this is a point where the openoffice/Libreoffice approach up to version 3.3 was clearly superior. There are at least 4 bugs describing this behavior, which is creating serious problems to advanced users, and I have not found a single reaction from a developer thus far. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42148] New: EDITING: Inserting a manual page break causes a frame on the next page to disappear
https://bugs.freedesktop.org/show_bug.cgi?id=42148 Bug #: 42148 Summary: EDITING: Inserting a manual page break causes a frame on the next page to disappear Classification: Unclassified Product: LibreOffice Version: LibO 3.4.3 release Platform: All OS/Version: All Status: UNCONFIRMED Severity: normal Priority: medium Component: Writer AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: ibur...@gmail.com Created attachment 52673 -- https://bugs.freedesktop.org/attachment.cgi?id=52673 The test case file for reproducing the bug On certain configurations of a frame anchored to page, inserting a manual page break (pressing Ctrl+Enter) in the text on the previous page make the frame disappear. It is unclear whether that frame is deleted or just is not drawn since then. Furthermore, the action of inserting the page break cannot be fully undone: the disappeared frame does not reveal itself even after undo! The issue occurs on both Windows and Linux versions of LibreOffice 3.4.3 running on both x86 and x86-64 systems. The test case document attached to the bug report consists of two pages: one containing a text snippet and the other dedicated to a page-anchored frame. To reproduce the issue put the cursor just after the text Put cursor here and press Ctrl-Enter → on the first page and insert a manual page break with Ctrl+Enter. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42140] LOCALHELP [ES] shows workflow comment
https://bugs.freedesktop.org/show_bug.cgi?id=42140 Rainer Bielefeld libreoff...@bielefeldundbuss.de changed: What|Removed |Added OS/Version|Linux (All) |All Status|UNCONFIRMED |NEW Status Whiteboard||CONFIRMED AssignedTo|libreoffice-b...@lists.free |andre.schna...@gmx.net |desktop.org | CC||LibreOffice@bielefeldundbus ||s.de Ever Confirmed|0 |1 Summary|Error in Spanish LO |LOCALHELP [ES] shows |documentation |workflow comment --- Comment #1 from Rainer Bielefeld libreoff...@bielefeldundbuss.de 2011-10-24 00:27:27 PDT --- [Reproducible] with LibreOffice 3.4.3 - WIN7 Home Premium (64bit) Spanish UI [OOO340m1 (Build:302)]: Heading shows a strange comment commentUFI: replace with guide for new MailMerge Wizard when that is visible/comment German and French Help are not affected. http://help.libreoffice.org/Writer/Creating_a_Form_Letter/es is not affected. @André: Can you eliminate comment in Pootle? Please feel free to reassign (or reset Assignee to default) if it’s not your area or if provided information is not sufficient. Please set Status to ASSIGNED if you accept this Bug. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42149] New: : LibreOffice crashed when install or update extension
https://bugs.freedesktop.org/show_bug.cgi?id=42149 Bug #: 42149 Summary: : LibreOffice crashed when install or update extension Classification: Unclassified Product: LibreOffice Version: LibO 3.4.3 release Platform: Other OS/Version: All Status: UNCONFIRMED Status Whiteboard: BSA Severity: normal Priority: medium Component: Libreoffice AssignedTo: libreoffice-bugs@lists.freedesktop.org ReportedBy: tonal.proms...@gmail.com Created attachment 52674 -- https://bugs.freedesktop.org/attachment.cgi?id=52674 log for gdb Problem description: Steps to reproduce: 1. Run LibreOffice: $ libreoffice 2. Start Extension manager from menu (Меню «Сервис/Управление расширениями...») 3. Click to button Check updates (Щелчёк по кнопке «Проверка обновлений») Current behavior: Libreoffice crashed with output: QPixmap: It is not safe to use pixmaps outside the GUI thread QPixmap: It is not safe to use pixmaps outside the GUI thread QPixmap: It is not safe to use pixmaps outside the GUI thread Expected behavior: Check for updates Platform (if different from the browser): Kubuntu 11.10 i686 with all updates Browser: Mozilla/5.0 (X11; Linux i686; rv:7.0.1) Gecko/20100101 Firefox/7.0.1 Bug in launchpad: http://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/880678 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42149] : LibreOffice crashed when install or update extension
https://bugs.freedesktop.org/show_bug.cgi?id=42149 --- Comment #1 from Tonal tonal.proms...@gmail.com 2011-10-24 00:45:58 PDT --- Created attachment 52675 -- https://bugs.freedesktop.org/attachment.cgi?id=52675 log for strace LibreOffice 3.4.3 OOO340m1 (Build:302) -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42033] Segmentation fault when holding the left mouse button pressed for a second and then dragging the object
https://bugs.freedesktop.org/show_bug.cgi?id=42033 --- Comment #3 from Maximilien Renard iixama...@gmail.com 2011-10-24 00:52:59 PDT --- The bug shows up again exactly as I described. What should I provide to help identifying it? -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
[Libreoffice-bugs] [Bug 42149] : LibreOffice crashed when install or update extension
https://bugs.freedesktop.org/show_bug.cgi?id=42149 Tonal tonal.proms...@gmail.com changed: What|Removed |Added Platform|Other |All OS/Version|All |Linux (All) --- Comment #2 from Tonal tonal.proms...@gmail.com 2011-10-24 00:54:08 PDT --- Desktop Environment: KDE 4.7.1 -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. ___ Libreoffice-bugs mailing list Libreoffice-bugs@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/libreoffice-bugs
