Re: Windows: release with Qt 5.5.1 or 5.6?

[Scott Kostyshak]

On Mon, Jan 18, 2016 at 01:32:15AM +0100, Uwe Stöhr wrote:
> Am 16.01.2016 um 16:58 schrieb Scott Kostyshak:
> 
> >Uwe, I know you do not have much time but are you willing to make both
> >installers? It seems there is help available for both the MSVC and mingw
> >if you get stuck.
> 
> To repeat, the installer is completely independent of the compiler! So if
> you fear bugs in the installer, it is there, no matter how LyX was built.

Indeed, you are right.

> Please push beta1 right now.

We have two other issues we are trying to fix before beta.

Scott


signature.asc
Description: PGP signature

Re: Beta hopefully soon, only waiting on Windows installer(s)

[Scott Kostyshak]

On Mon, Jan 18, 2016 at 01:17:09AM +0100, Uwe Stöhr wrote:
> Am 16.01.2016 um 23:43 schrieb Scott Kostyshak:
> 
> >Hopefully we will release beta1 very soon. As far as I'm concerned, the
> >only thing we are waiting for is the Windows installer(s).
> 
> Why? I reported that I am ready on Friday.

A couple of other issues have come up. Hopefully these will be addressed
in the next couple of days.

Scott


signature.asc
Description: PGP signature

Re: Questions for Uwe once you are back

[Peter Kümmel]

Am 18. Januar 2016 00:56:50 MEZ, schrieb "Uwe Stöhr" :
>Am 15.01.2016 um 22:33 schrieb Georg Baum:
>
>> Indirectly (via the MSVC project files .sln and .vcxproj) yes. In
>order
>> to do so, cmake does run lots of tests. These tests are partly
>> implemented in the cmake installation, and partly in the LyX sources
>> (development/cmake). The results of these tests are cached. If you
>now
>> re-use an existing cmake cache to build LyX from different sources,
>then
>> the contents of the MSVC project files (and therefore the resulting
>> build) depends on the history of your previous cmake calls, and
>whether
>> something was changed in development/cmake in the meantime. If you
>> ensure that no cached information is re-used then the build is
>> reprodcible (but you would need to specify the 40 paths again withj
>your
>> current way of calling cmake).
>
>OK, now with Qt 5 there are only 6 Qt paths to be specified. But I
>think 
>that this can still be reduced to one, since all Qt installations on 
>Windows have the same structure. So it should be sufficient to specify 
>only the path to the qmake.exe and then CMake has enough info to find 
>the rest.
>Peter, could you perhaps do this like you did for the mingw build?
>
>To please Georg, I will build in future LyX by compiling the source 
>files in a separate folder.

This is not only to please Georg. This is essential for serious software 
development.

>
>regards Uwe

Re: Beta hopefully soon, only waiting on Windows installer(s)

[Scott Kostyshak]

On Sun, Jan 17, 2016 at 07:12:22PM +0100, Peter Kümmel wrote:
> Am 17.01.2016 um 08:06 schrieb Scott Kostyshak:
> >
> >>I would release the beta with the available Windows installer, but would 
> >>also mention, that because of men power this time on Windows there will be 
> >>nothing better that beta quality.
> >>In the announcement you could mention that we are busy improving this, but 
> >>that at the moment no Windows developer has the time to create a reliable 
> >>installer and that we are very interested in someone who wanna help out.
> >>It would be a starter project which could be done without C++ knowledge.
> >
> >Good idea. We can indeed put a note in the announcement of the beta
> >release.
> 
> Initially I didn't like the idea to do a 5.5.1 msvc2010 release but it seems
> we have to go this way ATM.
> 
> I fixed the build script for msvc2010 and when Uwe could build the installer
> after the final release commits, I think we could drop the
> warning about the installer. It would be as stable as before.

Thanks for doing that.

Scott


signature.asc
Description: PGP signature

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Peter Kümmel]

Hello Uwe,

as you told, you have big problems in settings up clean build.
Therefore I've changed the build5-2010.bat file you added for building 
with MSVC2010.


This script now works with a double click, and builds LyX with MSVC2010 
in a clean build directory.


Three pathes are hardcoded:
- Qt installation qt C:\Qt
- MSVC2010 installation in C:\Program Files (x86)\Microsoft Visual 
Studio 10.0\VC
- and the deps at the same level as the LyX sources 
lyx20-deps-msvc2010-x86\deps20 (I disabled the automatic download)


I assume the pathes are the same on most systems.
You only have to unpack the deps-msvc2010-x86 folder once at the right 
place.


A simple double click creates the folder "build5-msvc2010" with
the LYX_INSTALLED files. Please use these files for you installer.

We should change this script until it also works for you.
The goal is that you don't have to touch it before you execute it.

I really hope this improves the current installer chaos.

Peter

Re: Beta hopefully soon, only waiting on Windows installer(s)

[Peter Kümmel]

Am 17.01.2016 um 08:06 schrieb Scott Kostyshak:



I would release the beta with the available Windows installer, but would also 
mention, that because of men power this time on Windows there will be nothing 
better that beta quality.
In the announcement you could mention that we are busy improving this, but that 
at the moment no Windows developer has the time to create a reliable installer 
and that we are very interested in someone who wanna help out.
It would be a starter project which could be done without C++ knowledge.


Good idea. We can indeed put a note in the announcement of the beta
release.


Initially I didn't like the idea to do a 5.5.1 msvc2010 release but it 
seems we have to go this way ATM.


I fixed the build script for msvc2010 and when Uwe could build the 
installer after the final release commits, I think we could drop the

warning about the installer. It would be as stable as before.



Scott

Re: Questions for Uwe once you are back

[Uwe Stöhr]

Am 15.01.2016 um 22:33 schrieb Georg Baum:


Indirectly (via the MSVC project files .sln and .vcxproj) yes. In order
to do so, cmake does run lots of tests. These tests are partly
implemented in the cmake installation, and partly in the LyX sources
(development/cmake). The results of these tests are cached. If you now
re-use an existing cmake cache to build LyX from different sources, then
the contents of the MSVC project files (and therefore the resulting
build) depends on the history of your previous cmake calls, and whether
something was changed in development/cmake in the meantime. If you
ensure that no cached information is re-used then the build is
reprodcible (but you would need to specify the 40 paths again withj your
current way of calling cmake).


OK, now with Qt 5 there are only 6 Qt paths to be specified. But I think 
that this can still be reduced to one, since all Qt installations on 
Windows have the same structure. So it should be sufficient to specify 
only the path to the qmake.exe and then CMake has enough info to find 
the rest.

Peter, could you perhaps do this like you did for the mingw build?

To please Georg, I will build in future LyX by compiling the source 
files in a separate folder.


regards Uwe

Re: Windows: release with Qt 5.5.1 or 5.6?

[Uwe Stöhr]

Am 16.01.2016 um 16:58 schrieb Scott Kostyshak:


Uwe, I know you do not have much time but are you willing to make both
installers? It seems there is help available for both the MSVC and mingw
if you get stuck.


To repeat, the installer is completely independent of the compiler! So 
if you fear bugs in the installer, it is there, no matter how LyX was built.


As I wrote, I have a very well tested installer ready and won't invest 
another week to dive into the compiler business. it is also not 
necessary to release a beta. LyX 2.2 is very stable in my experience and 
it is sufficient that users use it and give us feedback.


Please push beta1 right now.

regards Uwe

Re: Beta hopefully soon, only waiting on Windows installer(s)

[Uwe Stöhr]

Am 16.01.2016 um 23:43 schrieb Scott Kostyshak:


Hopefully we will release beta1 very soon. As far as I'm concerned, the
only thing we are waiting for is the Windows installer(s).


Why? I reported that I am ready on Friday.

regards Uwe

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Uwe Stöhr]

Am 17.01.2016 um 18:59 schrieb Peter Kümmel:

> as you told, you have big problems in settings up clean build.

Therefore I've changed the build5-2010.bat file you added for building
with MSVC2010.


As I reported proudly I was able to get a clean build. I still have some 
troubles with CMake and reported them as

http://www.lyx.org/trac/ticket/9927

The script you modified is the one I uploaded after I could use it to 
compile LyX with it with just a click.


Now I cannot use the script to build LyX: double-clicking on it gives 
starts a console that is clased after a few seconds.  The error message is:


---
CMake Error at CMakeLists.txt:561 (find_package):
  By not providing "FindQt5Core.cmake" in CMAKE_MODULE_PATH this 
project has
  asked CMake to find a package configuration file provided by 
"Qt5Core", but

  CMake did not find one.

  Could not find a package configuration file provided by "Qt5Core" 
with any

  of the following names:

Qt5CoreConfig.cmake
qt5core-config.cmake

  Add the installation prefix of "Qt5Core" to CMAKE_PREFIX_PATH or set
  "Qt5Core_DIR" to a directory containing one of the above files.  If
  "Qt5Core" provides a separate development package or SDK, be sure it has
  been installed.

-- Configuring incomplete, errors occurred!
See also "D:/LyXGit/compile-msvc2010/CMakeFiles/CMakeOutput.log".
---

I miss in your script a method to select to build a devel or an install 
build.

Moreover
-DLYX_MERGE_REBUILD=1 -DLYX_MERGE_FILES=1
never worked for me. i get then compilation errors. Thus I am forced to use
-DLYX_MERGE_REBUILD=0 -DLYX_MERGE_FILES=0


I really hope this improves the current installer chaos.


I am very thankful that you help me here but I don't understand what you 
mean with "installer chaos". I provided a buggy installer for alpha2 
because I could not test it. That was it. My main problems are to build 
LyX because of the CMake bugs and because I first need to find out that 
LyX cannot be built with MSVC 2012 or newer.


regards Uwe

Re: Windows: release with Qt 5.5.1 or 5.6?

[Uwe Stöhr]

Am 16.01.2016 um 16:21 schrieb Scott Kostyshak:


We need to figure out the MSVC vs. mingw issue before releasing beta.


What for an issue? I am using the MSVC2010 build now for many hours 
writing a scientific paper and to work on the docs. I cannot see a 
special problem.



don't think it would be a good idea to release one and then switch to
the other for final release. We have seen many installer-related issues
in the past


What has the compiler to do with the installer? What installer-related 
issues do you remember except of my mistake with alpha2?


regards Uwe

Re: Beta hopefully soon, only waiting on Windows installer(s)

[Uwe Stöhr]

Am 17.01.2016 um 03:22 schrieb Peter Kümmel:


I would release the beta with the available Windows installer, but would also 
mention, that because of men power this time on Windows there will be nothing 
better that beta quality.
In the announcement you could mention that we are busy improving this, but that 
at the moment no Windows developer has the time to create a reliable installer 
and that we are very interested in someone who wanna help out.


But what is going on here? I reported that i am ready for beta1. I even 
presented you an installer.
And to repeat myself, building the installer was never a problem, 
building LyX with Qt 5 was the problem.


Sorry, but it is an effrontery to say that no dev has the time nor the 
ability to build a reliable installer!


Of course the installer for beta works fine - tested for 2 days on 5 
PCs. And no, LyX on Windows is as stable as LyX on Mac and Unix.

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Peter Kümmel]

Am 18. Januar 2016 01:10:41 MEZ, schrieb "Uwe Stöhr" :
>Am 17.01.2016 um 18:59 schrieb Peter Kümmel:
>
> > as you told, you have big problems in settings up clean build.
>> Therefore I've changed the build5-2010.bat file you added for
>building
>> with MSVC2010.
>
>As I reported proudly I was able to get a clean build. I still have
>some 
>troubles with CMake and reported them as
>http://www.lyx.org/trac/ticket/9927
>
>The script you modified is the one I uploaded after I could use it to 
>compile LyX with it with just a click.
>
>Now I cannot use the script to build LyX: double-clicking on it gives 
>starts a console that is clased after a few seconds.  The error message
>is:
>
>---
>CMake Error at CMakeLists.txt:561 (find_package):
>   By not providing "FindQt5Core.cmake" in CMAKE_MODULE_PATH this 
>project has
>   asked CMake to find a package configuration file provided by 
>"Qt5Core", but
>   CMake did not find one.
>
>   Could not find a package configuration file provided by "Qt5Core" 
>with any
>   of the following names:
>
> Qt5CoreConfig.cmake
> qt5core-config.cmake
>
>   Add the installation prefix of "Qt5Core" to CMAKE_PREFIX_PATH or set
>   "Qt5Core_DIR" to a directory containing one of the above files.  If
>"Qt5Core" provides a separate development package or SDK, be sure it
>has
>   been installed.
>
>-- Configuring incomplete, errors occurred!
>See also "D:/LyXGit/compile-msvc2010/CMakeFiles/CMakeOutput.log".
>---
>
>I miss in your script a method to select to build a devel or an install
>
>build.
>Moreover
>-DLYX_MERGE_REBUILD=1 -DLYX_MERGE_FILES=1
>never worked for me. i get then compilation errors. Thus I am forced to
>use
>-DLYX_MERGE_REBUILD=0 -DLYX_MERGE_FILES=0
>
>> I really hope this improves the current installer chaos.
>
>I am very thankful that you help me here but I don't understand what
>you 
>mean with "installer chaos". I provided a buggy installer for alpha2 
>because I could not test it. That was it. My main problems are to build
>
>LyX because of the CMake bugs and because I first need to find out that
>
>LyX cannot be built with MSVC 2012 or newer.
>
>regards Uwe

Something is different on your system, there should be no problem with finding 
Qt 5. How actual is your cmake installation? Or do you use a years old Windows 
for the build?

Latest build folder name should be build5-msvc2010, didn't land this commit 
upstream? 

Script maybe misses the correcr man dir pass this could be fixed.

Re: Questions for Uwe once you are back

[Peter Kümmel]

Am 18. Januar 2016 00:56:50 MEZ, schrieb "Uwe Stöhr" :
>Am 15.01.2016 um 22:33 schrieb Georg Baum:
>
>> Indirectly (via the MSVC project files .sln and .vcxproj) yes. In
>order
>> to do so, cmake does run lots of tests. These tests are partly
>> implemented in the cmake installation, and partly in the LyX sources
>> (development/cmake). The results of these tests are cached. If you
>now
>> re-use an existing cmake cache to build LyX from different sources,
>then
>> the contents of the MSVC project files (and therefore the resulting
>> build) depends on the history of your previous cmake calls, and
>whether
>> something was changed in development/cmake in the meantime. If you
>> ensure that no cached information is re-used then the build is
>> reprodcible (but you would need to specify the 40 paths again withj
>your
>> current way of calling cmake).
>
>OK, now with Qt 5 there are only 6 Qt paths to be specified. But I
>think 
>that this can still be reduced to one, since all Qt installations on 
>Windows have the same structure. So it should be sufficient to specify 
>only the path to the qmake.exe and then CMake has enough info to find 
>the rest.
>Peter, could you perhaps do this like you did for the mingw build?
>
>To please Georg, I will build in future LyX by compiling the source 
>files in a separate folder.
>
>regards Uwe

Do you mean you have to specify the Qt pathes in the installer script? Where 
you list the Dll which needs to be copied from c:\Qt into the installer? Then 
your are right, this must be done manually for a msvc build. Only when building 
with mingw all needed dlls are copied automatically into the bin dir.

But again, to build only absolute no Qt pathes should be adjusted anywhere. 

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Peter Kümmel]

>
>I miss in your script a method to select to build a devel or an install

We need a reliable script for the installer input, which only builds lyx 
nothing else, this is the intention. No parameters no choice. 

>Moreover
>-DLYX_MERGE_REBUILD=1 

This flag is only needed when you rebuild again, which is the case here, each 
time the build dir is clean.

-DLYX_MERGE_FILES=1
>never worked for me. i get then compilation errors. Thus I am forced to
>use
>-DLYX_MERGE_REBUILD=0 -DLYX_MERGE_FILES=0
>
>> I really hope this improves the current installer chaos.
>
>I am very thankful that you help me here but I don't understand what
>you 
>mean with "installer chaos". I provided a buggy installer for alpha2 
>because I could not test it. That was it. My main problems are to build
>
>LyX because of the CMake bugs and because I first need to find out that
>
>LyX cannot be built with MSVC 2012 or newer.
>
>regards Uwe

Re: Beta hopefully soon, only waiting on Windows installer(s)

[Peter Kümmel]

Am 18. Januar 2016 01:24:38 MEZ, schrieb "Uwe Stöhr" :
>Am 17.01.2016 um 03:22 schrieb Peter Kümmel:
>
>> I would release the beta with the available Windows installer, but
>would also mention, that because of men power this time on Windows
>there will be nothing better that beta quality.
>> In the announcement you could mention that we are busy improving
>this, but that at the moment no Windows developer has the time to
>create a reliable installer and that we are very interested in someone
>who wanna help out.
>
>But what is going on here? I reported that i am ready for beta1. I even
>
>presented you an installer.
>And to repeat myself, building the installer was never a problem, 
>building LyX with Qt 5 was the problem.
>

But there must be no problem in building with Qt5. And if you report problems 
about cmake could not find Qt5 something is fishy on your system. And nobody 
had an idea what you are doing when creating the installer.


>Sorry, but it is an effrontery to say that no dev has the time nor the 
>ability to build a reliable installer!

But it looked like you are not able to get a straightforward build, you told 
you have to touch 40 pathes to get a build up. Hearing this, the only reaction 
is "wtf is he doing". 

>
>Of course the installer for beta works fine - tested for 2 days on 5 
>PCs. And no, LyX on Windows is as stable as LyX on Mac and Unix.

This was to early, because until now we have no beta release. You have to build 
the installer after the beta is out.

Re: compilation problems with Qt 5.5.1 and MSVC 2010

[Peter Kümmel]

Am 18. Januar 2016 01:10:41 MEZ, schrieb "Uwe Stöhr" :
>Am 17.01.2016 um 18:59 schrieb Peter Kümmel:
>
> > as you told, you have big problems in settings up clean build.
>> Therefore I've changed the build5-2010.bat file you added for
>building
>> with MSVC2010.
>
>As I reported proudly I was able to get a clean build. I still have
>some 
>troubles with CMake and reported them as
>http://www.lyx.org/trac/ticket/9927
>
>The script you modified is the one I uploaded after I could use it to 
>compile LyX with it with just a click.
>
>Now I cannot use the script to build LyX: double-clicking on it gives 
>starts a console that is clased after a few seconds.  The error message
>is:
>
>---
>CMake Error at CMakeLists.txt:561 (find_package):
>   By not providing "FindQt5Core.cmake" in CMAKE_MODULE_PATH this 
>project has
>   asked CMake to find a package configuration file provided by 
>"Qt5Core", but
>   CMake did not find one.
>
>   Could not find a package configuration file provided by "Qt5Core" 
>with any
>   of the following names:
>
> Qt5CoreConfig.cmake
> qt5core-config.cmake
>
>   Add the installation prefix of "Qt5Core" to CMAKE_PREFIX_PATH or set
>   "Qt5Core_DIR" to a directory containing one of the above files.  If
>"Qt5Core" provides a separate development package or SDK, be sure it
>has
>   been installed.
>
>-- Configuring incomplete, errors occurred!
>See also "D:/LyXGit/compile-msvc2010/CMakeFiles/CMakeOutput.log".
>---
>
>I miss in your script a method to select to build a devel or an install
>
>build.
>Moreover
>-DLYX_MERGE_REBUILD=1 -DLYX_MERGE_FILES=1
>never worked for me. i get then compilation errors. Thus I am forced to
>use
>-DLYX_MERGE_REBUILD=0 -DLYX_MERGE_FILES=0
>
>> I really hope this improves the current installer chaos.
>
>I am very thankful that you help me here but I don't understand what
>you 
>mean with "installer chaos". I provided a buggy installer for alpha2 
>because I could not test it. That was it. My main problems are to build
>
>LyX because of the CMake bugs and because I first need to find out that
>
>LyX cannot be built with MSVC 2012 or newer.
>
>regards Uwe

Is Qt installed on D: in your system? This could be the reason that Qt is not 
found. Please check the Qt path bin the script.

Is it a problem on your system to use Qt's default paths? Maybe you should also 
use a virtual machine only used for building lyx.

Re: Windows: release with Qt 5.5.1 or 5.6?

[Peter Kümmel]

Am 18. Januar 2016 01:32:15 MEZ, schrieb "Uwe Stöhr" :
>Am 16.01.2016 um 16:58 schrieb Scott Kostyshak:
>
>> Uwe, I know you do not have much time but are you willing to make
>both
>> installers? It seems there is help available for both the MSVC and
>mingw
>> if you get stuck.
>
>To repeat, the installer is completely independent of the compiler! So 
>if you fear bugs in the installer, it is there, no matter how LyX was
>built.
>
>As I wrote, I have a very well tested installer ready and won't invest 
>another week to dive into the compiler business. it is also not 
>necessary to release a beta. LyX 2.2 is very stable in my experience
>and 
>it is sufficient that users use it and give us feedback.
>
>Please push beta1 right now.

Do you plan to rebuild the installer after the official beta commit? Nobody 
knows which changed are not in the already uploaded installer because since 
then there were commits.

>
>regards Uwe

Re: Beta hopefully soon, only waiting on Windows installer(s)

[Peter Kümmel]

>And to repeat myself, building the installer was never a problem, 

Great! And it looks like necessary stuff is committet by you to the repository.
Ideally all files needed for the installer would be part of the repository, but 
this would mean to add multiple MB of Windows binaries which is not an option.

Maybe we could think about a git submodle which could be checked out optionally.


>building LyX with Qt 5 was the problem.
>
>Sorry, but it is an effrontery to say that no dev has the time nor the 
>ability to build a reliable installer!
>
>Of course the installer for beta works fine - tested for 2 days on 5 
>PCs. And no, LyX on Windows is as stable as LyX on Mac and Unix.

fontforge files in source package?

[Georg Baum]

Enrico added the fontforge files for all fonts (see 
http://www.lyx.org/trac/ticket/6115 for the reason). Now we have the one 
which did exist previously in the tar ball, and the others not (see 
dist_noinst_DATA in lib/Makefile.am).

We should handle all .sfd files alike, so either add the others or remove 
the existing one. I suggest to remove the existing one, since the .sfd files 
are not used in our build and only needed in very rare cases, and they are 
not small files.


Georg

Re: Beta hopefully soon, only waiting on Windows installer(s)

[Jean-Marc Lasgouttes]

Le 16/01/16 23:43, Scott Kostyshak a écrit :

Dear all,

Hopefully we will release beta1 very soon. As far as I'm concerned, the
only thing we are waiting for is the Windows installer(s).


Note also that we have a memory corruption in undo:
http://www.lyx.org/trac/ticket/9916

I'd appreciate some c++ experts comment about why scoped_ptr does not do 
what I think it does.


JMarc

Re: Beta hopefully soon, only waiting on Windows installer(s)

[Jean-Marc Lasgouttes]

Le 17/01/16 13:32, Jean-Marc Lasgouttes a écrit :

Le 16/01/16 23:43, Scott Kostyshak a écrit :

Dear all,

Hopefully we will release beta1 very soon. As far as I'm concerned, the
only thing we are waiting for is the Windows installer(s).


Note also that we have a memory corruption in undo:
http://www.lyx.org/trac/ticket/9916

I'd appreciate some c++ experts comment about why scoped_ptr does not do
what I think it does.


Err, shared_ptr, actually.

JMarc

Re: [LyX/master] Update LFUNs.lyx to current format

[Jean-Marc Lasgouttes]

Le 16/01/16 12:48, Guenter Milde a écrit :

Or we remove this generated file from git (my preference).


This creates problems of its own, since now there are files in 
/lib.


JMarc