Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Sun, Oct 07, 2018 at 05:18:23PM +0200, Jean-Marc Lasgouttes wrote:

> I have removed this feature in 2.4.0. The feature is already hidden in 2.3.

Sounds good. Thanks for doing that.

Scott


signature.asc
Description: PGP signature

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Jean-Marc Lasgouttes]

Le 09/02/2018 à 19:19, Scott Kostyshak a écrit :

On Tue, Feb 06, 2018 at 10:15:30PM +, Scott Kostyshak wrote:

On Tue, Feb 06, 2018 at 08:35:56PM +, Jean-Marc Lasgouttes wrote:

Le 06/02/2018 à 18:17, Scott Kostyshak a écrit :

Absolutely. I think JMarc made a similar suggestion to hide it. I
proposed to silently ignore it because by nature of being a release
manager I tend to by default suggest the fewest changes possible now
that we are after rc2.


Note that we already do that on Linux, so it would not be an extraordinary
change.


Good point.


We can decide to disable it for now


That's fine with me.


Since no other opinions yet, let's move forward with disabling it for
2.3.0. JMarc do you have time to do this? Normally I think this is
something I could make a patch for, but I'm hesitant to provide a patch
for something I don't understand (pixmap cache) this close to a release.


I have removed this feature in 2.4.0. The feature is already hidden in 2.3.

JMarc

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Tue, Feb 06, 2018 at 10:15:30PM +, Scott Kostyshak wrote:
> On Tue, Feb 06, 2018 at 08:35:56PM +, Jean-Marc Lasgouttes wrote:
> > Le 06/02/2018 à 18:17, Scott Kostyshak a écrit :
> > > Absolutely. I think JMarc made a similar suggestion to hide it. I
> > > proposed to silently ignore it because by nature of being a release
> > > manager I tend to by default suggest the fewest changes possible now
> > > that we are after rc2.
> > 
> > Note that we already do that on Linux, so it would not be an extraordinary
> > change.
> 
> Good point.
> 
> > We can decide to disable it for now
> 
> That's fine with me.

Since no other opinions yet, let's move forward with disabling it for
2.3.0. JMarc do you have time to do this? Normally I think this is
something I could make a patch for, but I'm hesitant to provide a patch
for something I don't understand (pixmap cache) this close to a release.

Scott


signature.asc
Description: PGP signature

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Tue, Feb 06, 2018 at 08:35:56PM +, Jean-Marc Lasgouttes wrote:
> Le 06/02/2018 à 18:17, Scott Kostyshak a écrit :
> > Absolutely. I think JMarc made a similar suggestion to hide it. I
> > proposed to silently ignore it because by nature of being a release
> > manager I tend to by default suggest the fewest changes possible now
> > that we are after rc2.
> 
> Note that we already do that on Linux, so it would not be an extraordinary
> change.

Good point.

> We can decide to disable it for now

That's fine with me.

Scott


signature.asc
Description: PGP signature

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Jean-Marc Lasgouttes]

Le 06/02/2018 à 18:17, Scott Kostyshak a écrit :

Absolutely. I think JMarc made a similar suggestion to hide it. I
proposed to silently ignore it because by nature of being a release
manager I tend to by default suggest the fewest changes possible now
that we are after rc2.


Note that we already do that on Linux, so it would not be an 
extraordinary change. We can decide to disable it for now and reinstate 
it if we find what is wrong (and if people on lyx-users ask for it).


JMarc

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Tue, Feb 06, 2018 at 05:49:39PM +, Jürgen Spitzmüller wrote:
> Am Dienstag, den 06.02.2018, 12:17 -0500 schrieb Scott Kostyshak:
> > I'm most worried about a change to the .ui files. We've seen weird
> > platform-specific Qt-version specific behavior with even minor
> > changes
> > to .ui files that no one would guess would cause a problem. But it
> > might
> > be possible to hide the option without touching the .ui file. I don't
> > know.
> 
> You don't need to touch the .ui file. You can use setEnabled(false) or
> setVisible (false) in the class file.

Good to know. I'm fine with either of those then.

Thanks,

Scott


signature.asc
Description: PGP signature

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Jürgen Spitzmüller]

Am Dienstag, den 06.02.2018, 12:17 -0500 schrieb Scott Kostyshak:
> I'm most worried about a change to the .ui files. We've seen weird
> platform-specific Qt-version specific behavior with even minor
> changes
> to .ui files that no one would guess would cause a problem. But it
> might
> be possible to hide the option without touching the .ui file. I don't
> know.

You don't need to touch the .ui file. You can use setEnabled(false) or
setVisible (false) in the class file.

Jürgen 

> 
> Scott

signature.asc
Description: This is a digitally signed message part

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Tue, Feb 06, 2018 at 05:07:02PM +, Joel Kulesza wrote:
> On Tue, Feb 6, 2018 at 10:00 AM, Scott Kostyshak  wrote:
> 
> > If the repair is non-trivial, let's not fix it and
> >
> instead just not act on the pixmap pref. Does that seem like a good plan
> > for 2.3.0?
> 
> 
>  If this is the route taken, would it be acceptable to gray-out/disable the
> unchecked checkbox in the preferences rather than silently ignoring it?

Absolutely. I think JMarc made a similar suggestion to hide it. I
proposed to silently ignore it because by nature of being a release
manager I tend to by default suggest the fewest changes possible now
that we are after rc2.

I actually like your idea of disabling the option better than hiding it,
because I imagine it is a more minor change.

I'm most worried about a change to the .ui files. We've seen weird
platform-specific Qt-version specific behavior with even minor changes
to .ui files that no one would guess would cause a problem. But it might
be possible to hide the option without touching the .ui file. I don't
know.

Scott


signature.asc
Description: PGP signature

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Joel Kulesza]

On Tue, Feb 6, 2018 at 10:00 AM, Scott Kostyshak  wrote:

> If the repair is non-trivial, let's not fix it and
>
instead just not act on the pixmap pref. Does that seem like a good plan
> for 2.3.0?


 If this is the route taken, would it be acceptable to gray-out/disable the
unchecked checkbox in the preferences rather than silently ignoring it?

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Tue, Feb 06, 2018 at 09:29:08AM +, Jean-Marc Lasgouttes wrote:
> Le 06/02/2018 à 01:57, Scott Kostyshak a écrit :
> > > This is the main question IMO. These days, we cache QTextLayout objects,
> > > which already contain the typeset glyphs.
> > 
> > I know nothing about this. If we decide to not use the pixmap cache,
> > would we do a prefs to prefs change at this point in the release
> > process? Or would we just ignore the pref in our internal code?
> 
> We can try to repair it if it is easy. Full removal of the code is for
> master only, in 2.3 we could decide to hide the option and not act of
> existing value. So IMO there is no rush to remove the option and modify
> lyxrc version.

Makes sense. Should we then ask Joel/Stephan for a bisect to see if the
repair is easy? If the repair is easy, let's just fix it and not mess
with anything else. If the repair is non-trivial, let's not fix it and
instead just not act on the pixmap pref. Does that seem like a good plan
for 2.3.0?

Scott


signature.asc
Description: PGP signature

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Jean-Marc Lasgouttes]

Le 06/02/2018 à 01:57, Scott Kostyshak a écrit :

This is the main question IMO. These days, we cache QTextLayout objects,
which already contain the typeset glyphs.


I know nothing about this. If we decide to not use the pixmap cache,
would we do a prefs to prefs change at this point in the release
process? Or would we just ignore the pref in our internal code?


We can try to repair it if it is easy. Full removal of the code is for 
master only, in 2.3 we could decide to hide the option and not act of 
existing value. So IMO there is no rush to remove the option and modify 
lyxrc version.


JMarc

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Mon, Feb 05, 2018 at 08:40:09AM +, Jean-Marc Lasgouttes wrote:
> Le 05/02/2018 à 09:22, Stephan Witt a écrit :
> > Am 05.02.2018 um 03:07 schrieb Scott Kostyshak :
> > > 
> > > On Sat, Feb 03, 2018 at 10:22:42PM +, Stephan Witt wrote:
> > > 
> > > > I cannot reproduce it either. Let’s see how it goes with the pixmap 
> > > > cache disabled.
> > > 
> > > Joel and Stephan, can you reproduce with pixmap enabled?
> > 
> > Yes, I can reproduce with pixmap enabled.
> > 
> > Before starting a bisect I’d like to know if the pixmap cache is needed at 
> > all.
> 
> This is the main question IMO. These days, we cache QTextLayout objects,
> which already contain the typeset glyphs.

I know nothing about this. If we decide to not use the pixmap cache,
would we do a prefs to prefs change at this point in the release
process? Or would we just ignore the pref in our internal code?

Scott


signature.asc
Description: PGP signature

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Jean-Marc Lasgouttes]

Le 05/02/2018 à 09:22, Stephan Witt a écrit :

Am 05.02.2018 um 03:07 schrieb Scott Kostyshak :


On Sat, Feb 03, 2018 at 10:22:42PM +, Stephan Witt wrote:


I cannot reproduce it either. Let’s see how it goes with the pixmap cache 
disabled.


Joel and Stephan, can you reproduce with pixmap enabled?


Yes, I can reproduce with pixmap enabled.

Before starting a bisect I’d like to know if the pixmap cache is needed at all.


This is the main question IMO. These days, we cache QTextLayout objects, 
which already contain the typeset glyphs.


JMarc

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Stephan Witt]

Am 05.02.2018 um 03:07 schrieb Scott Kostyshak :
> 
> On Sat, Feb 03, 2018 at 10:22:42PM +, Stephan Witt wrote:
> 
>> I cannot reproduce it either. Let’s see how it goes with the pixmap cache 
>> disabled.
> 
> Joel and Stephan, can you reproduce with pixmap enabled?

Yes, I can reproduce with pixmap enabled.

Before starting a bisect I’d like to know if the pixmap cache is needed at all.

Stephan

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Joel Kulesza]

On Sun, Feb 4, 2018 at 10:32 PM, Scott Kostyshak  wrote:

> Would it make sense for Joel or
> Stephan (if he could reproduce) to do a bisect to figure out what caused
> the problem so we can figure out a fix for 2.3.x branch?


Let me know how I can help.  If asked to do a bisect, it would be helpful
if a starting (i.e., "good") commit were suggested so I needn't bisect the
whole history.

On another note, while Stephan is attempting to reproduce the pixmap issue,
it would be good if he could confirm a crash using this MWE. Steps to
reproduce:

   1. Clear out any settings (e.g., ~/Library/Application Support/LyX) that
   would apply to the next step to achieve default behavior.
   2. Make and make install master (I built against e80e7d8478).
   3. Launch LyX, open MWE (MathFont.lyx).  The math should be "previewed".
   4. LyX -> Preferences -> Screen Fonts -> Enable "Use pixmap...", Apply.
   5. Display -> Instant Preview -> No Math, Save -> Crash.

The resulting crash output to the terminal is attached.  Note that
selecting "Apply" in step 5 behaves normally and doesn't produce a crash.

- Joel
CoordCache.cpp (30): break on pointer: 0x7fcb0fbaac50 hint: dim size: 0
(  1) 1   lyx 0x0001011589b4 
_ZN3lyx8doBufErrEPKcS1_l : 1   lyx 
0x0001011589b4 _ZN3lyx8doBufErrEPKcS1_l + 116
(  2) 2   lyx 0x000100dae1da 
_ZNK3lyx8MathData9dimensionERKNS_10BufferViewE : 2   lyx
 0x000100dae1da _ZNK3lyx8MathData9dimensionERKNS_10BufferViewE + 106
(  3) 3   lyx 0x000100d4ffcb 
_ZNK3lyx13InsetMathGrid11cellXOffsetERKNS_10BufferViewEm : 3   lyx  
   0x000100d4ffcb 
_ZNK3lyx13InsetMathGrid11cellXOffsetERKNS_10BufferViewEm + 123
(  4) 4   lyx 0x000100d4faff 
_ZNK3lyx13InsetMathGrid4drawERNS_11PainterInfoEii : 4   lyx 
0x000100d4faff 
_ZNK3lyx13InsetMathGrid4drawERNS_11PainterInfoEii + 175
(  5) 5   lyx 0x000100d5d93d 
_ZNK3lyx13InsetMathHull4drawERNS_11PainterInfoEii : 5   lyx 
0x000100d5d93d 
_ZNK3lyx13InsetMathHull4drawERNS_11PainterInfoEii + 1005
(  6) 6   lyx 0x000100cac6c4 
_ZNK3lyx10RowPainter10paintInsetERKNS_3Row7ElementE : 6   lyx   
  0x000100cac6c4 
_ZNK3lyx10RowPainter10paintInsetERKNS_3Row7ElementE + 580
(  7) 7   lyx 0x000100cae2bb 
_ZN3lyx10RowPainter9paintTextEv : 7   lyx 
0x000100cae2bb _ZN3lyx10RowPainter9paintTextEv + 283
(  8) 8   lyx 0x000100cf5c0f 
_ZNK3lyx11TextMetrics13drawParagraphERNS_11PainterInfoElii : 8   lyx
 0x000100cf5c0f 
_ZNK3lyx11TextMetrics13drawParagraphERNS_11PainterInfoElii + 2015
(  9) 9   lyx 0x000100cfac4e 
_ZNK3lyx11TextMetrics4drawERNS_11PainterInfoEii : 9   lyx   
  0x000100cfac4e _ZNK3lyx11TextMetrics4drawERNS_11PainterInfoEii + 
142
( 10) 10  lyx 0x000100b888be 
_ZN3lyx10BufferView4drawERNS_8frontend7PainterEb : 10  lyx  
   0x000100b888be _ZN3lyx10BufferView4drawERNS_8frontend7PainterEb 
+ 798
( 11) 11  lyx 0x0001010c9539 
_ZN3lyx8frontend11GuiWorkArea10paintEventEP11QPaintEvent : 11  lyx  
   0x0001010c9539 
_ZN3lyx8frontend11GuiWorkArea10paintEventEP11QPaintEvent + 265
( 12) 12  QtWidgets   0x000101e78d03 
_ZN7QWidget5eventEP6QEvent : 12  QtWidgets   
0x000101e78d03 _ZN7QWidget5eventEP6QEvent + 1123
( 13) 13  QtWidgets   0x000101f2cc8d 
_ZN6QFrame5eventEP6QEvent : 13  QtWidgets   
0x000101f2cc8d _ZN6QFrame5eventEP6QEvent + 45
( 14) 14  QtWidgets   0x000101f370a7 
_ZN19QAbstractScrollArea13viewportEventEP6QEvent : 14  QtWidgets
   0x000101f370a7 _ZN19QAbstractScrollArea13viewportEventEP6QEvent 
+ 135
( 15) 15  QtWidgets   0x000101f37c44 
_ZN19QAbstractScrollArea11qt_metacallEN11QMetaObject4CallEiPPv : 15  QtWidgets  
 0x000101f37c44 
_ZN19QAbstractScrollArea11qt_metacallEN11QMetaObject4CallEiPPv + 388
( 16) 16  QtCore  0x000102b04e6b 
_ZN23QCoreApplicationPrivate29sendThroughObjectEventFiltersEP7QObjectP6QEvent : 
16  QtCore  0x000102b04e6b 
_ZN23QCoreApplicationPrivate29sendThroughObjectEventFiltersEP7QObjectP6QEvent + 
203
( 17) 17  QtWidgets   0x000101e408b8 

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Joel Kulesza]

On Sun, Feb 4, 2018 at 7:07 PM, Scott Kostyshak  wrote:

> On Sat, Feb 03, 2018 at 10:22:42PM +, Stephan Witt wrote:
>
> > I cannot reproduce it either. Let’s see how it goes with the pixmap
> cache disabled.
>
> Joel and Stephan, can you reproduce with pixmap enabled?
>

Yes, I can reproduce.  Toggling pixmap in turn toggles the aberrant
behavior.  Note that in the meantime I've upgraded to macOS 10.13.3.

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Sat, Feb 03, 2018 at 10:22:42PM +, Stephan Witt wrote:

> I cannot reproduce it either. Let’s see how it goes with the pixmap cache 
> disabled.

Joel and Stephan, can you reproduce with pixmap enabled?

Scott


signature.asc
Description: PGP signature

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Zhexuan Gong]

Hi Stephan,

The math font problem is not an urgent problem now since one can just turn
off the pixel map caching.

Regarding the blurry image, the problem you mentioned with low resolution
image generated by the Mac built-in image converter engine can be easily
fixed. I added a rule "sips -Z 600 -s format png $$i --out $$o" in the
PDF->PNG converter setting where 600 is dpi that can be further increased.
So I can get a very high resolution image showing on the Lyx workspace.
However, the image is displayed in 2X zoom always and not in a HiDPI mode.
Maybe you can just pass to DPI setting to the Lyx workspace for showing
images?

Best,

Zhexuan

On Sat, Feb 3, 2018 at 3:22 PM, Stephan Witt  wrote:

> Am 03.02.2018 um 20:39 schrieb Scott Kostyshak :
> >
> > On Sat, Feb 03, 2018 at 07:31:15PM +, Joel Kulesza wrote:
> >> On Sat, Feb 3, 2018 at 11:51 AM, Zhexuan Gong 
> wrote:
> >>
> >>> Hi Scott,
> >>>
> >>> Yes please see attached for a minimum lyx file that produces the math
> font
> >>> issue, and two screenshots using Lyx 2.2.3 stable and 2.3.0rc2. The
> 2.2.3
> >>> has no problem with the math font.
> >>>
> >>> Best,
> >>>
> >>> Zhexuan
> >>>
> >>
> >> Thank you for providing a MWE.  Unfortunately, I cannot reproduce the
> issue
> >> with the distributed 2.3.0rc2 on my OS X 10.11.6 iMac with 5k Retina
> >> display.  Please see the attached for what I see in LyX and my system
> >> properties.
> >>
> >> - Joel
> >
> > The .lyx example file and screenshots are perfect. Thank you, Zhexuan.
> >
> > Stephan, are you able to reproduce? I forget whether you have a retina
> > display. In either case, do you have any intuition on whether the
> > difference between 2.2.3 and 2.3.0rc2 is due to our change of Qt library
> > or a change in our code?
>
> I cannot reproduce it either. Let’s see how it goes with the pixmap cache
> disabled.
>
> > Does anyone have suggestions for especific environment variables that
> > Zhexuan could test to see if it fixes things? e.g., could the
> > environment variables QT_AUTO_SCREEN_SCALE_FACTOR, QT_SCALE_FACTOR, and
> > QT_SCREEN_SCALE_FACTORS be of potential use here? They are documented
> > here:
> >
> >  http://doc.qt.io/qt-5/highdpi.html
> >
> > Joel, did you by chance set one of those environment variables in the
> > past?
>
> I don’t believe it’s useful to set these variables on a Mac. It’s simply
> not needed and should work automatically. Fiddling with the environment
> is not so easy on a Mac - LyX isn’t a terminal application and the
> environment of a desktop app is very basic and not easy to change.
>
> Regarding the blurry image thing - the problem here is the images being
> generated for preview with the wrong (too low) resolution by the preview
> images converter engine, IMHO. Last time I had a look I couldn’t find a
> way to pass the actual screen resolution down to the graphics converters
> in a clean manner. Furthermore the screen resolution on a Mac isn’t static.
> It may change at runtime if you’re working with multiple displays. I think
> this may happen on other platforms too - but I don’t know how this works
> e.g. on Linux.
>
> Stephan

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Sat, Feb 03, 2018 at 10:22:42PM +, Stephan Witt wrote:

> I cannot reproduce it either. Let’s see how it goes with the pixmap cache 
> disabled.

+1.

> > Does anyone have suggestions for especific environment variables that
> > Zhexuan could test to see if it fixes things? e.g., could the
> > environment variables QT_AUTO_SCREEN_SCALE_FACTOR, QT_SCALE_FACTOR, and
> > QT_SCREEN_SCALE_FACTORS be of potential use here? They are documented
> > here:
> > 
> >  http://doc.qt.io/qt-5/highdpi.html
> > 
> > Joel, did you by chance set one of those environment variables in the
> > past?
> 
> I don’t believe it’s useful to set these variables on a Mac. It’s simply
> not needed and should work automatically. Fiddling with the environment
> is not so easy on a Mac - LyX isn’t a terminal application and the
> environment of a desktop app is very basic and not easy to change.

Good to know. It seems that using launchctl setenv can be useful [1].

> Regarding the blurry image thing - the problem here is the images being
> generated for preview with the wrong (too low) resolution by the preview
> images converter engine, IMHO. Last time I had a look I couldn’t find a
> way to pass the actual screen resolution down to the graphics converters
> in a clean manner. Furthermore the screen resolution on a Mac isn’t static.
> It may change at runtime if you’re working with multiple displays. I think
> this may happen on other platforms too - but I don’t know how this works
> e.g. on Linux.

OK so nothing we should try for 2.3.0. As for the screen resolution
changing, I guess we would need to hook such changes into regeneration,
like we do when zooming.

Thanks,

Scott


[1] https://stackoverflow.com/a/3756674/1376404


signature.asc
Description: PGP signature

Re: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Stephan Witt]

Am 03.02.2018 um 20:39 schrieb Scott Kostyshak :
> 
> On Sat, Feb 03, 2018 at 07:31:15PM +, Joel Kulesza wrote:
>> On Sat, Feb 3, 2018 at 11:51 AM, Zhexuan Gong  wrote:
>> 
>>> Hi Scott,
>>> 
>>> Yes please see attached for a minimum lyx file that produces the math font
>>> issue, and two screenshots using Lyx 2.2.3 stable and 2.3.0rc2. The 2.2.3
>>> has no problem with the math font.
>>> 
>>> Best,
>>> 
>>> Zhexuan
>>> 
>> 
>> Thank you for providing a MWE.  Unfortunately, I cannot reproduce the issue
>> with the distributed 2.3.0rc2 on my OS X 10.11.6 iMac with 5k Retina
>> display.  Please see the attached for what I see in LyX and my system
>> properties.
>> 
>> - Joel
> 
> The .lyx example file and screenshots are perfect. Thank you, Zhexuan.
> 
> Stephan, are you able to reproduce? I forget whether you have a retina
> display. In either case, do you have any intuition on whether the
> difference between 2.2.3 and 2.3.0rc2 is due to our change of Qt library
> or a change in our code?

I cannot reproduce it either. Let’s see how it goes with the pixmap cache 
disabled.

> Does anyone have suggestions for especific environment variables that
> Zhexuan could test to see if it fixes things? e.g., could the
> environment variables QT_AUTO_SCREEN_SCALE_FACTOR, QT_SCALE_FACTOR, and
> QT_SCREEN_SCALE_FACTORS be of potential use here? They are documented
> here:
> 
>  http://doc.qt.io/qt-5/highdpi.html
> 
> Joel, did you by chance set one of those environment variables in the
> past?

I don’t believe it’s useful to set these variables on a Mac. It’s simply
not needed and should work automatically. Fiddling with the environment
is not so easy on a Mac - LyX isn’t a terminal application and the
environment of a desktop app is very basic and not easy to change.

Regarding the blurry image thing - the problem here is the images being
generated for preview with the wrong (too low) resolution by the preview
images converter engine, IMHO. Last time I had a look I couldn’t find a
way to pass the actual screen resolution down to the graphics converters
in a clean manner. Furthermore the screen resolution on a Mac isn’t static.
It may change at runtime if you’re working with multiple displays. I think
this may happen on other platforms too - but I don’t know how this works
e.g. on Linux.

Stephan

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Jean-Marc Lasgouttes]

Le 03/02/2018 à 21:45, Zhexuan Gong a écrit :
Just found that turning off the pixel map caching fixed the math font 
problem on 2.3.0rc2. However, 2.2.3 works fine even with pixel map 
caching on.


I might have broken the Pixmap cache, since I have no way to test it on 
linux. I will take a look next week.


BTW, is there a reason why you enabled the pixmap cache? I was thinking 
about removing it, actually.


Concerning your 2.3 screenshot, it is not only the blur that is wrong, 
many letters are not where they are supposed to be. Can you show the 
screenshot of 2.3.0rc2 without pixmap cache?


JMarc

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Zhexuan Gong]

Just found that turning off the pixel map caching fixed the math font
problem on 2.3.0rc2. However, 2.2.3 works fine even with pixel map caching
on.

On Sat, Feb 3, 2018 at 1:42 PM, Zhexuan Gong  wrote:

> It could be the macOS version then. I'm using the latest macOS 10.13.3.
> There must be something different with the 2.3.0rc2, because 2.2.3 works
> perfectly.
>
> On Sat, Feb 3, 2018 at 12:31 PM, Joel Kulesza  wrote:
>
>> On Sat, Feb 3, 2018 at 11:51 AM, Zhexuan Gong 
>> wrote:
>>
>>> Hi Scott,
>>>
>>> Yes please see attached for a minimum lyx file that produces the math
>>> font issue, and two screenshots using Lyx 2.2.3 stable and 2.3.0rc2. The
>>> 2.2.3 has no problem with the math font.
>>>
>>> Best,
>>>
>>> Zhexuan
>>>
>>
>> Thank you for providing a MWE.  Unfortunately, I cannot reproduce the
>> issue with the distributed 2.3.0rc2 on my OS X 10.11.6 iMac with 5k Retina
>> display.  Please see the attached for what I see in LyX and my system
>> properties.
>>
>> - Joel
>>
>
>

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Joel Kulesza]

On Sat, Feb 3, 2018 at 1:42 PM, Zhexuan Gong  wrote:

> It could be the macOS version then. I'm using the latest macOS 10.13.3.
> There must be something different with the 2.3.0rc2, because 2.2.3 works
> perfectly.
>

I recall there being some other issues with 10.12 (which I'll test tonight;
heading out now).  However, I don't have access to 10.13 currently.

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Zhexuan Gong]

It could be the macOS version then. I'm using the latest macOS 10.13.3.
There must be something different with the 2.3.0rc2, because 2.2.3 works
perfectly.

On Sat, Feb 3, 2018 at 12:31 PM, Joel Kulesza  wrote:

> On Sat, Feb 3, 2018 at 11:51 AM, Zhexuan Gong 
> wrote:
>
>> Hi Scott,
>>
>> Yes please see attached for a minimum lyx file that produces the math
>> font issue, and two screenshots using Lyx 2.2.3 stable and 2.3.0rc2. The
>> 2.2.3 has no problem with the math font.
>>
>> Best,
>>
>> Zhexuan
>>
>
> Thank you for providing a MWE.  Unfortunately, I cannot reproduce the
> issue with the distributed 2.3.0rc2 on my OS X 10.11.6 iMac with 5k Retina
> display.  Please see the attached for what I see in LyX and my system
> properties.
>
> - Joel
>

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Sat, Feb 03, 2018 at 08:08:03PM +, Joel Kulesza wrote:

> I don't recall having done so and don't see any QT variables set:
> 
> 9997 jkulesza@tempest[~]> env | grep QT
> 9998 jkulesza@tempest[~]>

OK thanks for checking.

Scott


signature.asc
Description: PGP signature

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Joel Kulesza]

On Sat, Feb 3, 2018 at 12:39 PM, Scott Kostyshak  wrote:

>
> Does anyone have suggestions for especific environment variables that
> Zhexuan could test to see if it fixes things? e.g., could the
> environment variables QT_AUTO_SCREEN_SCALE_FACTOR, QT_SCALE_FACTOR, and
> QT_SCREEN_SCALE_FACTORS be of potential use here? They are documented
> here:
>
>   http://doc.qt.io/qt-5/highdpi.html
>
> Joel, did you by chance set one of those environment variables in the
> past?


I don't recall having done so and don't see any QT variables set:

9997 jkulesza@tempest[~]> env | grep QT
9998 jkulesza@tempest[~]>

- Joel

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Sat, Feb 03, 2018 at 07:31:15PM +, Joel Kulesza wrote:
> On Sat, Feb 3, 2018 at 11:51 AM, Zhexuan Gong  wrote:
> 
> > Hi Scott,
> >
> > Yes please see attached for a minimum lyx file that produces the math font
> > issue, and two screenshots using Lyx 2.2.3 stable and 2.3.0rc2. The 2.2.3
> > has no problem with the math font.
> >
> > Best,
> >
> > Zhexuan
> >
> 
> Thank you for providing a MWE.  Unfortunately, I cannot reproduce the issue
> with the distributed 2.3.0rc2 on my OS X 10.11.6 iMac with 5k Retina
> display.  Please see the attached for what I see in LyX and my system
> properties.
> 
> - Joel

The .lyx example file and screenshots are perfect. Thank you, Zhexuan.

Stephan, are you able to reproduce? I forget whether you have a retina
display. In either case, do you have any intuition on whether the
difference between 2.2.3 and 2.3.0rc2 is due to our change of Qt library
or a change in our code?

Does anyone have suggestions for especific environment variables that
Zhexuan could test to see if it fixes things? e.g., could the
environment variables QT_AUTO_SCREEN_SCALE_FACTOR, QT_SCALE_FACTOR, and
QT_SCREEN_SCALE_FACTORS be of potential use here? They are documented
here:

  http://doc.qt.io/qt-5/highdpi.html

Joel, did you by chance set one of those environment variables in the
past?

Scott


signature.asc
Description: PGP signature

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Wed, Sep 27, 2017 at 05:03:11PM +, Zhexuan Gong wrote:
> Dear Scott,
> 
> Thanks for the reply! Yes I'd be happy to test the 2.3.0rc1 to see if the
> problem persists.
> 
> Best,
> 
> Zhexuan


Dear Zhexuan,

Great, thanks for being willing to test! You can subscribe to
lyx-announce [1] if you want, but I made a note to myself to also send
you an email directly.

Thanks,

Scott


[1] https://www.lyx.org/MailingLists#toc4

> On Wed, Sep 27, 2017 at 12:44 PM, Scott Kostyshak  wrote:
> 
> > On Mon, Sep 25, 2017 at 06:21:20PM +, Zhexuan Gong wrote:
> > > Dear Lyx developers,
> > >
> > > It looks like this problem is still not fixed in the latest Lyx 2.2.3 Mac
> > > version. Has anyone been working on this?
> > >
> > > Thanks a lot!
> > >
> > > Zhexuan
> >
> > Dear Zhexuan,
> >
> > Thank you for your persistence! I think that part of the problem is that
> > LyX developers do not all have access to retina screens.
> >
> > Would you be willing to test 2.3.0rc1 when it is available in a couple
> > of weeks? It would be good to know if you still see the problem with
> > 2.3.0rc1.
> >
> > Thanks,
> >
> > Scott
> >


signature.asc
Description: PGP signature

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Zhexuan Gong]

Dear Scott,

Thanks for the reply! Yes I'd be happy to test the 2.3.0rc1 to see if the
problem persists.

Best,

Zhexuan



On Wed, Sep 27, 2017 at 12:44 PM, Scott Kostyshak  wrote:

> On Mon, Sep 25, 2017 at 06:21:20PM +, Zhexuan Gong wrote:
> > Dear Lyx developers,
> >
> > It looks like this problem is still not fixed in the latest Lyx 2.2.3 Mac
> > version. Has anyone been working on this?
> >
> > Thanks a lot!
> >
> > Zhexuan
>
> Dear Zhexuan,
>
> Thank you for your persistence! I think that part of the problem is that
> LyX developers do not all have access to retina screens.
>
> Would you be willing to test 2.3.0rc1 when it is available in a couple
> of weeks? It would be good to know if you still see the problem with
> 2.3.0rc1.
>
> Thanks,
>
> Scott
>

Re: Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Scott Kostyshak]

On Mon, Sep 25, 2017 at 06:21:20PM +, Zhexuan Gong wrote:
> Dear Lyx developers,
> 
> It looks like this problem is still not fixed in the latest Lyx 2.2.3 Mac
> version. Has anyone been working on this?
> 
> Thanks a lot!
> 
> Zhexuan

Dear Zhexuan,

Thank you for your persistence! I think that part of the problem is that
LyX developers do not all have access to retina screens.

Would you be willing to test 2.3.0rc1 when it is available in a couple
of weeks? It would be good to know if you still see the problem with
2.3.0rc1.

Thanks,

Scott


signature.asc
Description: PGP signature

Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Zhexuan Gong]

Dear Lyx developers,

It looks like this problem is still not fixed in the latest Lyx 2.2.3 Mac
version. Has anyone been working on this?

Thanks a lot!

Zhexuan

-- Forwarded message --
From: Zhexuan Gong <gongzhex...@gmail.com>
Date: Sun, Jun 5, 2016 at 9:05 PM
Subject: Blurry inserted figures for retina display in Lyx 2.2 Mac
To: lyx-us...@lists.lyx.org


Dear Lyx developers,

I've just installed the official release of Lyx 2.2 Mac version. Thanks a
lot for your team's hard work! It's really awesome and the text in the
workspace is super sharp right now. However, the display of inserted
figures in the Lyx workspace is still blurry and non-retina (see my
screenshot at http://i.imgur.com/mI849a8.jpg) on my retina display Macbook.
Are you aware of this problem and is there a plan to fix it in a future
version?

Thanks a lot!

Zhexuan

Fwd: Blurry inserted figures for retina display in Lyx 2.2 Mac

[Richard Heck]

Questions like this one are better sent to the developers' list, so I'm
forwarding it there.

 Forwarded Message 
Subject:Blurry inserted figures for retina display in Lyx 2.2 Mac
Date:   Sun, 5 Jun 2016 21:05:03 -0400
From:   Zhexuan Gong <gongzhex...@gmail.com>
To: lyx-us...@lists.lyx.org



Dear Lyx developers,

I've just installed the official release of Lyx 2.2 Mac version. Thanks
a lot for your team's hard work! It's really awesome and the text in the
workspace is super sharp right now. However, the display of inserted
figures in the Lyx workspace is still blurry and non-retina (see my
screenshot at http://i.imgur.com/mI849a8.jpg) on my retina display
Macbook. Are you aware of this problem and is there a plan to fix it in
a future version?

Thanks a lot!

Zhexuan