Re: Quick view

[Andrew Borodin]

On Sun, 02 Oct 2022 10:14:23 +0200 "Riccardo Paolo Bestetti"  
wrote:
> One feature I like about MC is "quick view" (C-x q), or the ability to
> use one of the panes to quickly preview files. However, I have noticed
> that it doesn't work as well as the file viewer (F3). Some examples:
> 
> - When quick view is open, hovering on some types of files (especially
>   zip files and derivatives such as epub, docx, jar) results in a big
>   red popup that needs a keypress to be dismissed, and then their
>   content is not displayed

There is a bug in zip-files detection. I hope, it's fixed[1]. It'll be
in the master branch at next weekend.

> - Some of the files that ca be successfully rendered in the viewer (e.g.
>   HTML, images*, PDF) show up as plain text/binary dumped as ASCII
>   instead in quick view

It's a feature[2]. Quick view shows file in the raw mode to avoid any delays
required to get some info of the file.

> - Directories show the string "Cannot view: not a regular file" but it
>   might be a good feature to show the contents, or maybe a short
>   description of it ("X images, Y documents")

Again, to calculate directory statistics, or get some info of file, we need
some time. Any delay can annoy users.

[1] https://midnight-commander.org/ticket/4404
[2] https://midnight-commander.org/ticket/4117

-- 
Andrew

___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Help testing release candidate / mc-4.8.28-rc1

[Andrew Borodin]

On Sun, 20 Mar 2022 19:12:13 +0100 Oswald Buddenhagen via mc-devel 
 wrote:
> On Sun, Mar 20, 2022 at 06:59:32PM +0300, Andrew Borodin wrote:
> >On Sun, 20 Mar 2022 15:22:14 +0100 Oswald Buddenhagen via mc-devel 
> >
> > wrote:
> >> `mc -P $file` doesn't work any more when the file already exists 
> >> (which is of course the case after file=`mktemp`).
> >
> >Indeed.
> >
> >A following patch is proposed:
> >
> >diff --git a/src/main.c b/src/main.c
> >index 3a33dfb59..a4910349a 100644
> >--- a/src/main.c
> >+++ b/src/main.c
> >@@ -492,6 +492,10 @@ main (int argc, char *argv[])
> > 
> > last_wd_fd = open (mc_args__last_wd_file, O_WRONLY | O_CREAT | 
> > O_TRUNC | O_EXCL,
> >S_IRUSR | S_IWUSR);
> >+
> >+if (last_wd_fd == -1 && errno == EEXIST)
> >+last_wd_fd = open (mc_args__last_wd_file, O_WRONLY | O_TRUNC, 
> >S_IRUSR | S_IWUSR);
> >+
> > if (last_wd_fd != -1)
> > {
> > ssize_t ret1;
> >
> that seems overly complicated - why not just drop the O_EXCL? at least i 
> can't see an obvious
> reason for having it in the first place.

Ok.

> anyway, i wonder why i ran into this only recently, given that this behavior 
> is actually
> rather ancient. probably has something to do with me porting the wrapper 
> function from
> tempfile to mktemp (as debian started to complain about deprecation), though 
> the replacement
> itself couldn't have caused it.

mc-wrapper.sh doesn't create a file. It creates a file name only. then mc 
creates a file with
given file name, and everything works fine.

Wrapper patched to use mktemp creates a file, and mc tries to open an existing 
file and fails.
A workaround is to apply `mktemp -u` or even `mktemp -u -t`, but is it portable?

-- 
A.


___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Help testing release candidate / mc-4.8.28-rc1

[Andrew Borodin]

On Sun, 20 Mar 2022 15:22:14 +0100 Oswald Buddenhagen via mc-devel 

 wrote:
> On Sun, Mar 20, 2022 at 01:15:41PM +0100, Yury V. Zaytsev wrote:
> >TLDR; I would appreciate if you could please test the following tarball on 
> >your systems
> and report any blocker regressions as compared to the previous 4.8.27 release:
> >
> i tested master instead:
> 
> find.c: In function ‘find_cmd’:
> find.c:1837:28: warning: ‘start_dir_len’ may be used uninitialized in this 
> function [-Wmaybe-uninitialized]
>   1837 | p = name + (size_t) start_dir_len;
>|^~
> find.c:1897:13: note: ‘start_dir_len’ was declared here
>   1897 | ssize_t start_dir_len;
>| ^

This isn't critical. start_dir_len is an output of find_parameters().

> coord_cache.c: In function ‘mcview_ccache_add_entry’:
> coord_cache.c:97:5: warning: ‘g_memdup’ is deprecated: Use 'g_memdup2' 
> instead [-Wdeprecated-declarations]
> 97 | cache->cache[pos] = g_memdup (entry, sizeof (*entry));
>| ^
> In file included from /usr/include/glib-2.0/glib.h:82,
>   from ../../lib/global.h:66,
>   from coord_cache.c:57:
> /usr/include/glib-2.0/glib/gstrfuncs.h:257:23: note: declared here
>257 | gpointer  g_memdup (gconstpointer mem,
>|   ^~~~

This is not critical too.
https://midnight-commander.org/ticket/4270#comment:12

> `mc -P $file` doesn't work any more when the file already exists (which is of 
> course the case after file=`mktemp`).

Indeed.
file is opened with O_CREAT | O_EXCL flags. In this case, as written in open(2),

O_EXCL Ensure  that  this call creates the file: if this flag is specified in 
conjunction
   with O_CREAT, and pathname already exists, then open() fails with the 
error EEXIST.

A following patch is proposed:

diff --git a/src/main.c b/src/main.c
index 3a33dfb59..a4910349a 100644
--- a/src/main.c
+++ b/src/main.c
@@ -492,6 +492,10 @@ main (int argc, char *argv[])
 
 last_wd_fd = open (mc_args__last_wd_file, O_WRONLY | O_CREAT | O_TRUNC 
| O_EXCL,
S_IRUSR | S_IWUSR);
+
+if (last_wd_fd == -1 && errno == EEXIST)
+last_wd_fd = open (mc_args__last_wd_file, O_WRONLY | O_TRUNC, 
S_IRUSR | S_IWUSR);
+
 if (last_wd_fd != -1)
 {
 ssize_t ret1;

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Help testing release candidate / mc-4.8.26-rc1

[Andrew Borodin]

On Mon, 18 Jan 2021 08:35:24 +0300 Andrew Borodin wrote:
> On Mon, 18 Jan 2021 04:38:10 +0100 David Haller wrote:
> > 1. mcedit causes a SIGSEGV when jumping out via Ctrl-o, even if just
> >too _look_ at stuff, not doing anything on the (sub-)shell:
> 
> Confirmed.
> I'll fix this today.

Fixed: 
https://midnight-commander.org/changeset/a88a626e76139259e5b6fc0db39045f051e243dd

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Help testing release candidate / mc-4.8.26-rc1

[Andrew Borodin]

On Mon, 18 Jan 2021 04:38:10 +0100 David Haller wrote:
> Hello,

Hi!

Thanks for testing.

> On Sun, 10 Jan 2021, Yury V. Zaytsev wrote:
> >TLDR; I would appreciate if you could please test the following tarball on
> >your systems and report any blocker regressions as compared to the previous
> >4.8.25 release:
> 
> Two things:
> 
> 1. mcedit causes a SIGSEGV when jumping out via Ctrl-o, even if just
>too _look_ at stuff, not doing anything on the (sub-)shell:

Confirmed.
I'll fix this today.

> 2. I don't know if that's a current regression or if that already was
>the case in 4.8.25 and earlier: if compiled without slang, no mouse
>actions work anymore (has the curses code gone?)
> 
> I can do more debugging if you can't pinpoint the change...

This is known: https://midnight-commander.org/ticket/4144

> 3.: you should add the version to AC_INIT, so that PACKAGE_VERSION
> gets set correctly during configure. If not, generated docs have
> 'mc-' instead of 'mc-$VERSION' (e.g. mc-4.8.25) as version in e.g. 
> the pdf ;)

This is known too: https://midnight-commander.org/ticket/3603

> A possible patch might be:
> 
>  mc-4.8.26-fix_ac_version.patch 
> diff '-bpurNx*~' g/configure.ac h/configure.ac
> --- g/configure.ac  2021-01-10 12:50:16.0 +0100
> +++ h/configure.ac  2021-01-11 13:56:25.382961865 +0100
> @@ -3,7 +3,8 @@ dnl Configure.in file for the Midnight C
>  dnl
>  
>  AC_PREREQ(2.60)
> -AC_INIT([GNU Midnight Commander], [], [mc-devel@gnome.org])
> +m4_define(pkg_VERSION,[m4_esyscmd([sh ./ver.sh])])
> +AC_INIT([GNU Midnight Commander], [pkg_VERSION], [mc-devel@gnome.org])
>  m4_pattern_forbid(MC_)
>  AC_CONFIG_MACRO_DIR([m4])
>  AC_CONFIG_AUX_DIR(config)
> diff '-bpurNx*~' g/ver.sh h/ver.sh
> --- g/ver.sh1970-01-01 01:00:00.0 +0100
> +++ h/ver.sh2021-01-11 13:54:30.0 +0100
> @@ -0,0 +1,2 @@
> +#!/bin/sh
> +awk -F'"' '/MC_CURRENT_VERSION/{printf("%s",$2);}' version.h
> 
> 
> (not using the external script get's you into quoting hell ;)
> 
> I've seen that it's somewhat redundant, but possible the later setting
> of the version from version.h can be removed then, I've not looked
> into that yet.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: extfs changes with mc 4.8.25 regarding '.' '..' in filenames list

[Andrew Borodin]

On Wed, 21 Oct 2020 15:05:10 +0200 dieter via mc-devel  
wrote:
> This "untar" module adds "./" at the beginning of the extracted
> filenames in order to handle filenames beginning with a blank.
> 
> Removing this "./" it works again, except for filenames which start
> with a blank - they are listed in the panel but can not be opened or
> extracted because tar can not find them in the archive without the
> missing blank.

Seems this bug and https://midnight-commander.org/ticket/4077 have the same 
root.

> I found that in some other extfs modules (for deb and urar) in mc 4.2.25
> also the "./" was removed

I'll try to get extfs working again with leading ./ in the file names.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: how to report security bugs?

[Andrew Borodin]

On Wed, 21 Oct 2020 15:48:44 +0200 Petr Špaček via mc-devel 
 wrote:
> what is the recommended way to report security bugs?

https://midnight-commander.org/wiki/NewTicket

Registration is required.

-- 
Andrew

___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: displays bad regular file timestamps on entry to .bz2 file & preserves the errors on copy out

[Andrew Borodin]

On Tue, 17 Mar 2020 20:50:49 -0400 Felix Miata wrote:
> It's only happened on this one so far that I can remember:
> 
> Others I've checked from mozilla.org are handled normally.
> 
> Tar has no such problem.
> 
> Is this a known issue?

Yes, it is. MC's tar implementation doesn't support extended headers:

https://mail.gnome.org/archives/mc-devel/2020-March/msg1.html

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: displays bad regular file timestamps on entry to .bz2 file & preserves the errors on copy out

[Andrew Borodin]

On Tue, 17 Mar 2020 20:50:49 -0400 Felix Miata via mc-devel 
 wrote:
> It's only happened on this one so far that I can remember:
> 
> Others I've checked from mozilla.org are handled normally.
> 
> Tar has no such problem.

The most part of tar source code in MC is very old (end of 1990s or beginning 
of 2000s)
and doesn't support some modern tar features.

In the case of firefox-68.6.0esr.tar.bz2, MC's tar vfs ignores extended headers
which contain the mtime of file in tar archive. The mtime field in POSIX header
is 0, therefore you can see the the 1 Jan 1970 in MC file panel.

> Is this a known issue? I've not been able to find anything on point among 
> tickets
> on https://midnight-commander.org/

Probably, the main tar ticket is https://midnight-commander.org/ticket/1952.

-- 
Amdrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Help testing release candidate / mc-4.8.24-rc1

[Andrew Borodin]

On Tue, 07 Jan 2020 17:45:28 +0300 Andrew Borodin wrote:
> On Tue, 7 Jan 2020 14:15:21 +0100 wwp wrote:
> > I think I have one more tiny issue to report.. I went back to 4.8.23,
> > and at least two settings from the layout prefs were lost: command
> > prompt and panel split. Maybe you changed the storage format for some
> > config items?
> 
> Yes. This is a result of [1].
> 
> Previously some options that are actually boolean were stored
> as intreger 0/1. Now its are stored as yes/no.

Sorry. Not yes/no, but true/false.

> 
> [1] https://midnight-commander.org/ticket/4039

-- 
А.
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Help testing release candidate / mc-4.8.24-rc1

[Andrew Borodin]

On Tue, 7 Jan 2020 14:15:21 +0100 wwp wrote:
> I think I have one more tiny issue to report.. I went back to 4.8.23,
> and at least two settings from the layout prefs were lost: command
> prompt and panel split. Maybe you changed the storage format for some
> config items?

Yes. This is a result of [1].

Previously some options that are actually boolean were stored
as intreger 0/1. Now its are stored as yes/no.

[1] https://midnight-commander.org/ticket/4039

-- 
А.
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Help testing release candidate / mc-4.8.24-rc1

[Andrew Borodin]

On Mon, 6 Jan 2020 12:45:57 +0100 wwp  wrote:
> 
> I noticed one regression: if I start mc, then start mcedit from
> subshell, I'll get:
> ===
> GNU Midnight Commander is already running on this terminal.
> Subshell support will be disabled.
> ===
> 
> Back to 4.8.23 and the issue is gone, as expected.

Notice if you run standalone mceditor, you haven't a subshell in it [1].

A new behavior (I can't say this is a bug) is a some kind of payment 
for having a full-functional subshell in standalone 
mceditor/mcviewer/mcdiffviewer.
Now if you run mcedit from mc it is the same as you run mc from mc
with all features.

[1] https://midnight-commander.org/ticket/3380

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Last version - Enter key bug

[Andrew Borodin]

On Mon, 23 Dec 2019 02:18:53 +0100 Piotr Biesiada via mc-devel wrote:
> Just tested:
> 4.8.22-1 does not have this bug
> 4.8.23-1 does have this bug
>
> Reproduce:
> 1. open Cygwin
> 2. type "mc"
> 3. open "Right" menu
> 4. go down with arrow keys to "Shell connection"
> 5. press Enter
>
> Bug is that Enter does here go to next option below "Shell connection", does 
> not start the option.

This is fixed already:
https://midnight-commander.org/ticket/4006

-- 
A.

___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Help testing release candidate / mc-4.8.23-rc1

[Andrew Borodin]

On Mon, 17 Jun 2019 22:56:45 +0200 Egmont Koblinger via mc-devel wrote:
> There's a severe usability regression: After pressing F9 the hotkeys
> (e.g. O for Options, then L for Layout) don't work.

Thanks for the bugreport.
Fixed in 7eaa51c79bb74e6e650935e23895c62073ff46c5.

-- 
A.
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Help testing release candidate / mc-4.8.23-rc1

[Andrew Borodin]

On Mon, 17 Jun 2019 08:56:55 +0200 David Martin via mc-devel wrote:
> "Ubuntu 16.04.6 LTS": many unsigned int cast warnings for smbfs.

Thanks for the report.

Fixed in
c47f0c4bba7af48c2147950f23fbc2e14f1de162
92146f10333f6068d6b0a54921bd2cae284705a7

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Help testing release candidate / mc-4.8.23-rc1

[Andrew Borodin]

On Sun, 16 Jun 2019 22:06:56 -0600 Jack Woehr via mc-devel wrote:
> make[4]: Entering directory '/usr/local/src/MC/build-4.8.22-166/src/vfs/sfs'
>   CC   sfs.lo
> ../../../../mc-4.8.22-166-gcd16697a3/src/vfs/sfs/sfs.c: In function 
> ‘sfs_open’:
> ../../../../mc-4.8.22-166-gcd16697a3/src/vfs/sfs/sfs.c:281:10: warning:
> declaration of ‘sfs_info’ shadows a global declaration [-Wshadow]
>  int *sfs_info;
>   ^~~~
> ../../../../mc-4.8.22-166-gcd16697a3/src/vfs/sfs/sfs.c:118:3: note: shadowed 
> declaration is here
>  } sfs_info[MAXFS];
>^~~~

Thanks for the report.
Fixed in 58d601c54b62ff061c2088d03d5d5aeaceec3dcf.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: [PATCH] fix GPM bug in MC

[Andrew Borodin]

On Wed, 27 Feb 2019 13:54:35 -0500 (EST) Mikulas Patocka wrote:
> I am sending this patch that fixes GPM bug.

Thanks! Please add your patch and comment to
https://midnight-commander.org/ticket/3208

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Help testing release candidate / mc-4.8.22-rc1

[Andrew Borodin]

On Sat, 29 Dec 2018 19:46:16 -0700 Jack Woehr via mc 
 wrote:
> In IBM i PASE environment, we're back to having struct timespect trouble
> with this snapshot:

This is weird.

> /home/JWOEHR/work/mc-4.8.21-108-g4b46e6194/src/filemanager/file.c: In
> function 'get_times':
> /home/JWOEHR/work/mc-4.8.21-108-g4b46e6194/src/filemanager/file.c:899:17:
> error: incompatible types when assigning to type 'struct timespec' from
> type 'st_timespec_t {aka const struct st_timespec}'
>  (*times)[0] = sb->st_atim;
>  ^
> /home/JWOEHR/work/mc-4.8.21-108-g4b46e6194/src/filemanager/file.c:900:17:
> error: incompatible types when assigning to type 'struct timespec' from
> type 'st_timespec_t {aka const struct st_timespec}'
>  (*times)[1] = sb->st_mtim;

Looks like HAVE_UTIMENSAT is defined. But there no any changes around
checking of utimensat() since 09/09 (commit a453376).

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: change default configuration

[Andrew Borodin]

On Fri, 27 Jul 2018 17:01:17 +0300 Sergey Naumov via mc-devel wrote:
> I'm curious whether there is a way to change default configuration that is
> generated when user invokes mc for the first time?
> 
> For example, I want "use_internal_edit" to be true by default instead of
> false for any new user.

In vanilla mc the initial value of use_internal_edit is true. Some distros
(Debian and some others) change this to false.

> If there is a way to do it, then is it possible to just use lines that I
> want to change, not the whole configuration, say
> 
> [Midnight-Commander]
> use_internal_edit=true

Before first run, ~/.config/mc/ini doesn't exist.
If ~/.config/mc/ini doesn't exist, /etc/mc/mc.ini is used.
If /etc/mc/mc.ini doesn't exist, /usr/share/mc/mc.ini is used.
You can create one of these files with required default settings set.

Unfortunately, there is no info about /etc/mc/mc.ini in the man page.
I'll fix that at this weekend.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: develop vfs plugin

[Andrew Borodin]

On Mon, 28 May 2018 13:42:33 +0200 Raikol Duergar wrote:
> the problem is that extfs helpers need full ls -lR from start,

Yes. This mean that you read an archive one time only. Otherwise, if you
want walk through archive directories, you have to read archive again
and again. If archive doesn't provide its list explicitly, the directory
change will take a lot of time.

> it is possible to get directory by directory?

Unfortunately, no.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: develop vfs plugin

[Andrew Borodin]

On Wed, 23 May 2018 13:07:28 +0200 Raikol Duergar wrote:
> i dont like to do a full scan of archive from the start 

The base vfs library code is in the lib/vfs directory.
Also you can find there some notes in README and HACKING files.
Unfortunately, historically, a detail documentation is absent at all.

Various VFS implementations (plugins) are in the src/vfs directory.
Some VFSes (ftp, fish, etc) are written in C. Most archive VFSes
are shell, perl, python scripts run via extfs (see src/vfs/extfs/helpers).

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Contributing to the wiki

[Andrew Borodin]

On Tue, 3 Oct 2017 00:13:15 +0200 Cristian Rigamonti wrote:
> Hi, I'd like to suggest/make some changes to the documentation
> at https://midnight-commander.org/wiki/doc
> 
> Is it possible to have edit permission on the wiki? (my trac account is "cri")

Thanks for the request!

I added permission to you to modify wiki pages.

--
Andrew

___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: mc macro recording/editing issues

[Andrew Borodin]

On Wed, 20 Sep 2017 12:28:02 +0300 Sergey Naumov  wrote:
> But I will try to use macro too.
> In the code (usermenu.c: expand_format()) I see that despite mcedit manual
> mentions %c, it is not actually supported.
> Could I fix %c and also add %C as file offset (WEdit.buffer.curs1)? Should
> I file a bug for it?

No. usermenu.c isn't related to editor and editor macros. It is related to user 
menu
(called via F2 in file namager or F11 in the editor).

I can't confirm that recorded macro isn't stored in ~/.local/share/mc/mc.macros.
It works for me. But ctrl-space. It is some special case.

-- 
Andrew.
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: [PATCH] fix directory search order to be depth-first again

[Andrew Borodin]

On Sun, 22 May 2016 12:45:58 +0200 Oswald Buddenhagen wrote:
> this matches the pre-glib implementation, and is way more natural.

Thanks!

Committed to the 3641_cleanup branch.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

About 4.8.16 (was: Re: mc^2 news (january 2016))

[Andrew Borodin]

On Thu, 25 Feb 2016 22:17:33 +0100 "Yury V. Zaytsev" wrote:
> On a related note, I think we (or, rather, I) should start thinking
> about releasing 4.8.16 sometime soon. There is quite a bit of good stuff
> accumulated in master already.

I agree.

> The biggest problem now is that the cleanup branch again has became quite 
> huge.

The cleanup branch contains about 50 commits. Most of them are small and clean.

> But I can always tell to myself that I trust Andrew's good judgment :-)

Thanks!

> Andrew, what do you think of this? Do you have any personal plans as to
> what do you want to get done before 4.8.16?

No, I don't. We can release 4.8.16 after review and merge of #3566 and #3547.

IIRC, we don't have tickets that are so critical to be included in release.
But I can mistake because we have 540 open tickets and I can forget something.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Midnight Commander 4.8.15 released

[Andrew Borodin]

On Sun, 08 Nov 2015 21:33:19 +0100 Laurent Wandrebeck wrote:
>   --enable-vfs-mcfs

This is useless. mcfs was removed  a long time ago.

-- 
A.
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: mc and me

[Andrew Borodin]

On Fri, 6 Nov 2015 11:12:55 +0300 Slava Zanko wrote:
> > I'm all for granting Egmont commit access.
> 
> +1 from me.

Me too.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Midnight Commander not compiles on Debian Squeeze

[Andrew Borodin]

On Tue, 20 Oct 2015 19:54:45 +0200 "Yury V. Zaytsev" wrote:
> On Tue, 2015-10-20 at 14:48 +0300, Mooffie wrote:
> > 
> > You also need to update README, INSTALL, HACKING. 
> 
> Thanks! I would have forgotten about it.

What about forgotten

11 PKG_CHECK_MODULES(GMODULE, [gmodule-no-export-2.0 >= 2.14], 
[found_gmodule=yes], [:])
12 if test x"$found_gmodule" = xyes; then
13 g_module_supported="gmodule-no-export-2.0"
14 else
15 dnl try fallback to the generic gmodule
16 PKG_CHECK_MODULES(GMODULE, [gmodule-2.0 >= 2.14], 
[found_gmodule=yes], [:])

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: COPYOUT time

[Andrew Borodin]

On Wed, 10 Jun 2015 19:10:52 +0300 Nicolas Rybkin wrote:
 Can anyone tell me where is implementation of mc_fstat() ? I can't find it.

lib/vfs/interface.c:589

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Translations and Transifex

[Andrew Borodin]

On Tue, 9 Jun 2015 21:17:35 +0200 Morten Bo Johansen wrote:
 On 2015-06-09 Oswald Buddenhagen wrote:
  do you see what is right below that button on the pricing page?
 
 No, nothing that contradicts what I said. Please open my eyes.

https://www.transifex.com/pricing/

Open source projects

Crowdsource translations for your Open Source project for free on Transifex 
with no word count limits.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Hello

[Andrew Borodin]

On Mon, 18 May 2015 17:18:22 -0400 David  Both wrote:
 That information is actually very helpful. I will proceed on the basis that
 the primary documentation is the MAN page and that information will move into
 the help file.

Current man page is very big. We have an old idea to split it in to independent
files:
1) the man page itself which contains description of command line options
and probably some other info, and
2) the content of built-in help.

I would be great if you try to implement that. Thanks!

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: [ANN] mc^2

[Andrew Borodin]

On Sun, 10 May 2015 14:25:50 +0300 Paul Sokolovsky wrote:
 the patch exists http://www.midnight-commander.org/ticket/1652 , and only
 held by exactly perfectionist attitudes and lack of more general response.

I don't have words other than I wrote in ticket comments.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: [ANN] mc^2

[Andrew Borodin]

On Fri, 8 May 2015 15:05:33 +0300 Mooffie wrote:
 On 5/8/15, Egmont Koblinger wrote:
  How much work would it be to port your branch to 4.8.14 or git head
  (they're pretty much the same now)?
 
 Probably very little work.
 
 I'll do that sometime soon, I hope.

It would be great if you split first huge commit of branch in several small
commits. It will make the review easier.

Thanks!

-- 
A.
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Bug reports / suggestions welcome here ?

[Andrew Borodin]

On Sat, 18 Apr 2015 12:52:07 +0200 Rikishi 42 wrote:
 I've been using mc for a very, very long time now. And a while (years ?) back
 there was a change in the interface of the copy progress display. I liked
 that very much, but found a bug and also a need for a an additional option.
 
 I'm only using release 4.8.1, but didn't find anything in the release notes
 that would suggest that it would have been addressed.

 Is this the right place to report/suggest those modifications, or is this
 list for developpers only?
 
 The other mc mailing list seems very quiet, so I figured I'd ask here.

The only place for bug reporting is https://www.midnight-commander.org.
We don't use other sites (github, etc) for bug tracking.

Start page for bug reporting is 
https://www.midnight-commander.org/wiki/NewTicket.
Registration is required.
Please don't ignore any requests written on this page.

-- 
Andrew
 
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Ticket comment rejected and lost

[Andrew Borodin]

On Mon, 23 Feb 2015 17:16:19 +0100 Egmont Koblinger wrote:
 Actually, I got the same message again.  I can't submit my newest bug report.

Sorry. I still hope to make spam filter more corresponding to spam and ham.
For last day, there 3 real spam messages was banned.

 
 (Which, for reference is: F2 followed by F1 brings up an error about
 missing help.)
 

I've created the ticket.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Ticket comment rejected and lost

[Andrew Borodin]

On Mon, 9 Feb 2015 14:59:53 +0100 Egmont Koblinger wrote:
 So... I wanted to submit a comment to ticket 2027... I logged in,
 wrote about 10-15 lines, and after clicking Submit I was given an
 error, something like Submission rejected because of suspected spam
 (can't remember the exact words).

I'm sorry! That's my fault. I played with anti-spam settings some days
ago. Some spam was blocked but some ham was blocked too. I returned
previous settings.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Bug tracker doesn't work

[Andrew Borodin]

On Sat, 13 Dec 2014 15:23:03 +0100 Egmont Koblinger egm...@gmail.com  wrote:
 I'd like you to understand that at this point that fixing the
 development architecture and process of mc is the most critical issue,
 pretty much blocking everything else.

Slava is working on fixing bugtracker. Unfortunately, I can't help him
because I don't have any experience of administration and support of real web
services.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: MC Tabs

[Andrew Borodin]

On Mon, 14 Oct 2013 20:20:19 +0200 Cosmin Popescu wrote:
 Please find attached my contribution to mc: tabs like Total Commander has.

This is a known issue: https://www.midnight-commander.org/ticket/1581

 I am a regular midnight commander user. I use it for all my file exploring
 needs on several systems. I use it under Arch Linux and Ubuntu at home,
 under Red Hat on various servers that I administer and under Cygwin on
 Windows 7 at work.
 
 One of the things that was missing were the tabs and I hated all the time,
 when I needed to copy some files from a location to several locations to
 have to change the folder so many times.
 
 You will find an archive containing several patches that will add tabs to
 MC and a keymap file to map some shortcuts for the tabs. Another message
 will follow with some screen shots.

Bugtracker is rather than e-mail to collect requests. This is some guarantee
that your request will not be forgotten.

 Inside the archive there is an executable file called apply-patch that will
 apply all the pathes on the required files. To install the patch, just
 un-archive the patch.tar.gz inside the root folder of mc-4.8.10 archive, cd
 to patch and run ./apply-patch.

Please, no. Use diff -ruNp to create patch if you're working with snapshot.
Or git format-patch, or git diff if you're working with repo.

[...]

 Also, please note that in the src/filemanager/filegui.c you have a small
 bug at the line 288. The closing bracket of the function is inside the
 #ifdef directive, while the opening one is outside. The program will of
 course fail to compile under cygwin, so I've corrected it.

This is already fixed: https://www.midnight-commander.org/ticket/3053
That is why you should use recent repo snapshot instead of release tarball.

 In the src/filemanager/mountlist.c, on the line 245 you are using the
 _GL_UNUSED macro. This will also fail to compile on my version of cygwin.
 Although I know that probably I have to add a dev package to have the macro
 defined, I don't think that it should be the case to do that just to avoid
 a warning (to add a dependency). I would do that with something like #ifdef
 _CYGWIN_ directive, but since this might be because of my installation of
 cygwin, I didn't modify it in the patch that I've sent you.

Thanks! This code was borrowed from gnulib. Seems I missed somesing. I'll check
that.

[...]

 Please let me know if you would like to include the tabs in your main
 source repository. If not, do you have something against me posting the
 patch on sourceforce and github?

The best way is following:
1. Clone git repo, or if you are not familiar with git, get recent snapshot:
https://github.com/MidnightCommander/mc/archive/master.zip
2. Create patch.
3. Attach this patch (and some description as you wish) to the ticket #1581.
You must be registered at m-c.o for that.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Vim's modeline support

[Andrew Borodin]

On Sat, 31 Aug 2013 17:32:28 +0200 Tomasz Wasilczyk wrote:
 Hi,
 
 I recently needed indentation styles set per-file (not globally). Such
 feature is supported by vim with modeline mod enabled, but my favorite
 editor is mcedit. So, I've just wrote modeline support for mcedit.
 
 Here is the patch against current git: http://pastebin.com/99anc269
 
 This is rather a proof-of-concept, than final pull request. If you
 find it useful to add its support to official mcedit, I could polish
 this commit (I guess, mc_findinfile should be moved somewhere and
 named differently).

Yes, it is useful. Please create a ticket on www.midnight-commander.org.

 By the way: how to enable BlockShiftLeft/BlockShiftRight? I tried
 editing mc.keymap, but none of locations where i put it didn't worked.

System-wide in /etc/mc/keymap, section [editor]. For reference:
BlockShiftLeft = alt-shift-left
BlockShiftRight = alt-shift-right

For user only, the same is in ~/.config/mc/mc.keymap.

Both cases are work for me.

Be sure that shortcuts you choose are supported in your terminal.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: [PATCH] Fix info for ogg files in sound.sh

[Andrew Borodin]

On Sat, 18 May 2013 18:09:06 +0300 wrote:
 MC 4.8.8 views OGG files incorrectly if they names contain spaces:
 
 Error opening input file My\ recording\ #1.ogg: No such file or directory
 
 There is a small bug in misc/ext.d/sound.sh.
 ogginfo should be shown for MC_EXT_FILENAME like other cases.
 Using MC_EXT_SELECTED handles filenames with spaces incorrectly.
 
 An appropriate patch is attached.

Thanks for the patch! Applied to the 2900_cleanup branch and will be merged
to master soon.

-- 
Andrew

___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: MC-win-4.8.7 does not show files

[Andrew Borodin]

On Sat, 18 May 2013 03:36:04 +0300 Alpo Värri wrote:
 Midnight Commander Windows version 4.8.7

MC for Windows isn't developed and isn't supported at all. Sorry.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: stable vs. latest

[Andrew Borodin]

On Tue, 19 Feb 2013 15:19:11 -0500 Felix Miata wrote:
 Last Debian, Fedora  *buntu releases had 4.8.x. Current Gentoo is 4.8.7.
 Mageia 3 is about to be released with 4.8.7. So, why does the stable/4.8.1.x
 branch even exist?

There is no stable branch anymore. 4.8.1.7 was the last release in 4.8.1.x
branch. 4.8.1-stable and master branches have more and more differences, and
patch backporting from master to stable and vice versa becomes more and more
hardly. We try make stability in master as much as possible.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Easy renaming of files

[Andrew Borodin]

On Mon, 28 Jan 2013 10:34:29 +0100 Marco wrote:
 Is there an easier way to rename files, for instance a shortcut to
 pre-populate the field with the current file name?

Shifr-F6.

-- 
Andrew


___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: ctrl mappings don't work

[Andrew Borodin]

On Thu, 10 Jan 2013 20:30:50 +0100 Oswald Buddenhagen wrote:
 huh? slang/ncurses runs the tty in raw mode, so it gets all the keys
 just fine. what is most likely happening is that mc's command prompt is
 eating those keys before they reach the keybinding dispatcher.

Ok. In xterm

when I press ctrl-h, SLang_getkey() returns 8
when I press ctrl-m, SLang_getkey() returns 13

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Bugreports

[Andrew Borodin]

On Fri, 26 Oct 2012 16:14:41 +0200 Kov?cs Zolt?n wrote:
 Dear mc-devel,

First of all, print relevant subject.

 Is this enough for a normal bug report? I use 4.8.1 (3:4.8.1-4 in an Ubuntu
 box).

No. Current release is 4.8.6. For bug report for recent mc version welcome to
https://www.midnight-commander.org/wiki/NewTicket. Don't forget to use search
to avoid ticket duplication.
For bug report for old releases welcome to bugzilla of your distro.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Spanish Help + man

[Andrew Borodin]

On Sat, 15 Sep 2012 17:37:06 +0200 David Mart?n wrote:
 I have updated the Spanish docs for mc. Here is the main source file.

Thanks!

Applied: 
https://www.midnight-commander.org/changeset/672c572e9b18363bfb4cad854082da739e11d569

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Segfault when viewing HTML files with mc -v

[Andrew Borodin]

On Mon, 30 Jul 2012 01:38:53 +0300 Nikos Chantziaras wrote:
 (I'm on Linux 64-bit.  This happens with current Git master as well as the
 4.8.4 release.  4.8.3 does not have the issue.

Thanks for the bugreport. But best way to report bugs is to create ticket at
midnight-commander.org.

Since segfault is serious bug, I created ticket myself:
https://www.midnight-commander.org/ticket/2858.
Please test that fix.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Transifex and mc.pot

[Andrew Borodin]

On Mon, 30 Jul 2012 01:34:46 +0200 David Mart?n wrote:
 I feel that I'm doing something wrong about translations... I keep my es.po
 file updated to latest git sources. Not every day nor every week, but on
 a regular basis. But if I upload the file to Transifex it REFUSES quite a few
 messages. I suppose it's because an older mc.pot file. The mc.pot seems to be
 uploaded just before every release, but this way the release is published
 with old translations.

Transifex detects changes in mc.pot in repo and automatically downloads mc.pot
and merges it into all .po files. And yes, actually mc.pot is gerenerated before
release. I think, we should make it more often, not for after every change in 
i18n stuff, but after more or less accumulated number of changes.

-- 
Andrew
___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Segfault when viewing HTML files with mc -v

[Andrew Borodin]

On Mon, 30 Jul 2012 14:32:49 +0200 Yury V. Zaytsev wrote:
 Worse even it's substantially harder for most of them to communicate in
 English, so tickets that require a lot of communication naturally get put off
 till later.

Some communication problems in non-native language exist, yes. But actually
requirement for ticket is a guarantee that request/bugreport as ticket will be
kept in Trac forever. Request via e-mail/forum/jabber/etc has a good chance to 
be
forgotten and lost.

-- 
Andrew

___
mc-devel mailing list
https://mail.gnome.org/mailman/listinfo/mc-devel

Re: Problem with renaming a file

[Andrew Borodin]

On Thu, 06 Oct 2011 20:06:43 +0200 Hartmut Figge wrote:
 Too complicated. I do not see an explanation how to file a bug there and
 searching the wiki leads to
 
 | Creating a custom report requires a comfortable knowledge of SQL.
 
 Well, i do know nothing about SQL. *g* It would be nice if you could
 open a ticket by yourself.

What? Where did you read that?

 P.S.
 Accessing https://www.midnight-commander.org/ gives
 http://www.triffids.de/pub/screenshot/mc111006.png

It's ok. m-c.o uses self-signed certificate 
(https://www.midnight-commander.org/ticket/2578).

I filed a bugreport myself: https://www.midnight-commander.org/ticket/2626

Thanks!

-- 
Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Problem with renaming a file

[Andrew Borodin]

On Fri, 07 Oct 2011 11:12:28 +0200 Hartmut Figge wrote:
 Wanting to file a bug and not finding a way to do so on
 https://www.midnight-commander.org/ i used the Tab Help/Guide and found
 https://www.midnight-commander.org/wiki/TracReports.
 
 The paragraph 'Creating Custom Reports' was terrifying. *g*

That is internal stuff of Trac itself, not MC.

To file a bug, you must be registered and logged in at m-c.o. Then you can use
the 'New Ticket' item of top-screen menu line.

-- 
Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Problem with renaming a file

[Andrew Borodin]

On Thu, 06 Oct 2011 16:39:15 +0200 Hartmut Figge wrote:
 hafi@i5 ~ $ mc --version
 GNU Midnight Commander 4.7.5.3
 
 Downloading a patch from bugzilla/mozilla gives a file with the name
 attachment.cgi?id=564208. My build script requires, that a patch begins
 with 'patch'. Trying a rename to patch_attachment.cgi?id=564208 with mc
 results in patch_attachment.cgiattachment.cgi?id=564208id=564208
 
 Steps to reproduce:
 mkdir mc-test
 cd mc-test
 touch attachment.cgi?id=564208
 mc
 Point to this file, press F6, type the letter a then ESC then TAB, press
 Home, then patch_ and then the button OK.

Yes, I confirm this bug. Special chars like ? should be escaped while
autocompletion file names. Would you create a ticket in midnight-commander.org?
Shift-F6 works as expected.

-- 
Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Bug: compare files with ZERO SIZE

[Andrew Borodin]

On Thu, 16 Jun 2011 13:48:30 +0400 Alexander vea...@mail.ru

Please, don't use html for this list.

 When compare files in directories on panels, MC selects the files with ZERO
 SIZE, the same dates and the names, showing them as different.
 
 GNU Midnight Commander, version 2006-09-25-14

Hm, 2011 year is now. You should update your mc to the recent stable version 
4.7.5.2. But, in general, directory comparing is broken. This is known bug:
https://www.midnight-commander.org/ticket/399. If you want, you can append
some info to this bugreport.

Thanks!

-- 
Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: multiple codepages support under OpenSUSE

[Andrew Borodin]

On Wed, 2 Mar 2011 16:48:18 +0300 Andrew Bogorodsky wrote:
 # mc --version
 GNU Midnight Commander 4.6.2

You should update your mc up to 4.7.5.1 version.

-- 
Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [SPAM] (5.50/5.00) Re: updated: [master] [4de95fe] Ticket #1963: use grep instead of awk in iso9660 extfs plugin.

[Andrew Borodin]

On Wed, 15 Dec 2010 09:37:09 +0100 Oswald Buddenhagen wrote:
   that's cleaner and should be more portable than the gnu extensions
   to basic regular expressions.
  
  Is \| a GNU extension in grep?
  
 it's kind of implied. the man page merely says In other
 implementations, basic regular expressions are less powerful. the sed
 man page is more explicit about it, and i think it's reasonabe to assume
 that it applies equally to grep.

Ok, if you're insisting, please reopen 
http://www.midnight-commander.org/ticket/1963.

-- 
Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [Fwd: [Pkg-mc-devel] midnight commander bug]

[Andrew Borodin]

On Mon, 13 Dec 2010 21:21:38 +0100 Yury V. Zaytsev wrote:
 Did anyone actually tried to copy  45000 files???

No.

 midnight 
 commander (under slackware 13.1, 64bit) simply stopped after copying 
 about 45000 files from the 65000 files of the windows-directory of a 
 windows 7 install. I did not get any error message from mc

Which version of mc is used?
What is total size of those 65000 files?

-- 
Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: updated: [master] [4de95fe] Ticket #1963: use grep instead of awk in iso9660 extfs plugin.

[Andrew Borodin]

On Tue, 14 Dec 2010 17:28:11 +0100 Oswald Buddenhagen wrote:
 or more precisely, you mean
   @EGREP@ Iconv not yet supported|Unknown charset
 (without the backslash).

No. I mean @GREP@ with backslash'ed OR \|.

There is an alternative:
@GREP@ with \|
or
@EGREP@ with |

 that's cleaner and should be more portable than the gnu extensions to
 basic regular expressions.

Is \| a GNU extension in grep?

-- 
Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Midnight Commander 4.7.5-pre1 (stable candidate) released

[Andrew Borodin]

On Wed, 08 Dec 2010 13:10:03 +0200 Slava Zanko wrote:
 Please note: this is prerelease for new stable branch with 4.7.5 code
 base.
 Feel free to testing and bug-reporting to us if some critical issues
 is present.

The main goal of 4.7.5-pre1 release is freeze of i18n stuff before 4.7.5
release. We're planning to release 4.7.5 at December 27. We think that
approx 3.5-weeks time interval between 4.7.5-pre1 and 4.7.5 releases
is enough for translators. :)

-- 

Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: leftover branches ?

[Andrew Borodin]

On Mon, 13 Sep 2010 00:09:08 +0200 Enrico Weigelt wrote:
 there seem to be some old leftover branches:
 
 1823_prev_line_def
Ticket is not closed yet.

 1897_libc_return_values
Removed.

 should they get removed ?

And now my questions to you:

1775_mvfs_9P
1775_mvfs_9P_2
1775_mvfs_9P_3
DEV_mvfs_fish
DEV_mvfs_local
METUX.mvfs

WTF? Why you created a lot of branches about your mvfs stuff???
MC dev team doesn't have any plans to use this unknown library. Please
remove that branches yourself and please don't push any mvfs-related
code to the mc repo. Else your write access to the mc repo will be
disabled.

If you develop the mc fork, please don't that in official mc server. That's 
nonsense.

Thanks.

-- 
Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: leftover branches ?

[Andrew Borodin]

On Mon, 13 Sep 2010 08:47:30 +0200 Enrico Weigelt wrote:
  1775_mvfs_9P
  1775_mvfs_9P_2
  1775_mvfs_9P_3
  DEV_mvfs_fish
  DEV_mvfs_local
  METUX.mvfs
 
 Work in progress. I'll assign it to proper ticket when it passed 
 test cycles.

Do you really need these tons of branches for one task?

  MC dev team doesn't have any plans to use this unknown library. 
 
 Did you do any one vote on that or do you now rule alone here ?

We discussed about that in Jabber room and in this list.

  Please remove that branches yourself and please don't push any
  mvfs-related code to the mc repo. Else your write access to the
  mc repo will be disabled.
 
 Are you sure you're officially authorized to impose those threats ?

I'm one of current MC developers.

 Did you check back with the guy who sponsors the infrastructure ?

Are you one of that sponsors?

 And do you think this is an appropriate reward for one of the 
 people who practically revived mc from death ?

And who are that people?

  If you develop the mc fork, please don't that in official mc server.
 
 In case you still didn't notice: the mvfs stuff was meant for
 upstream on day one.

Really?

-- 
Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: technical question about branches

[Andrew Borodin]

On Fri, 21 May 2010 23:45:59 +0200 Janek Kozicki wrote:
 Now I want to make it available for you. How?
 
   git push origin 1517_collapse_a_treeview_dir_with_enter
 
 fatal: The remote end hung up unexpectedly

Right. You don't have write permissions to the mc repo.

 Do I need to make my own repo (github? gitorious?) so that you can
 fetch from it?

I think, yes.

 Do I have an access to origin, because I made a trac account, and I'm
 simply unaware of that?

If you will have your repo on github, we can review your branches,
fetch them into main mc repo and merge to master.

 Or should I `git format-patch master 1517_collapse_a_treeview_dir_with_enter` 
 and attach it to tickets?

This way is also possible. In this case the branch will be created
by one of MC developers in main mc repo.

-- 
Andrew


___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: getting real

[Andrew Borodin]

On Fri, 21 May 2010 21:11:12 +0200 Janek Kozicki wrote:
 Ideally each of them should be a separate (smaller) patch, but they
 will have to be applied in order (they depend on each other).

In such case I prefer create one branch with several commits.

-- 
Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: how does skin recognize that UTF-8 is available?

[Andrew Borodin]

On Thu, 20 May 2010 13:15:00 +0200 Janek Kozicki wrote:
 A skin selection dialog is missing from the Menu, or I am blind?
 Like Options-Skin.

http://www.midnight-commander.org/ticket/2165

-- 
Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: how does skin recognize that UTF-8 is available?

[Andrew Borodin]

On Wed, 19 May 2010 21:45:05 +0200 Janek Kozicki wrote:
 I wanted to check how to use  ▶ / ▼ for (un)folding a directory in
 tree view. If UTF-8 is available then I'd like to use ▶ / ▼. Andrew
 recommended using skin engine for that.

Skin engine is a single correct way for that.

 So I suppose that I would just call for an up-arrow and get either a
 UTF8 on or a ASCII one. But now I'm troubled. I switched to UTF8
 recently and mc is still using ' and , to show the sorting direction.
 Instead of ↓ and ↑.

MC uses a default skin or a skin set in command line (-S option) or
a skin set in the ~/.mc/ini file (skin key). You can try use another
skin to view non-default sotring symbols.
 
 Maybe 'mc' should detect if UTF8 is available and either use
 default-ASCII.ini skin or default-UTF8.ini skin. But there is
 currently just one: the ASCII one default.ini.

I don't think so.

-- 
Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: xtree-mode / dynamic static - tree view patch

[Andrew Borodin]

On Wed, 28 Apr 2010 21:47:39 +0200 Janek Kozicki wrote:
 In fact, at first I wanted to use the empty F7 label for that, but I
 just couldn't get it to work. Despite my best efforts the function to
 toggle the boolean, linked to F7 was never called. If you are curious
 what I have done here, see the second, “WTF” patch.

You didn't define the action in keymap file.

The

{ KEY_F (7), CK_TreeToggleXTree, F7 }

definition in default_tree_keymap variable doesn't work because the
[tree] section of keymap file completely overwrites the default_tree_keymap
binds.

Add the

TreeToggleXTree = f7

bind to the your keymap file (usually, /etc/mc/mc.keymap).

-- 
Andrew
___
mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Panelize BUG

[Andrew Borodin]

On Wed, 3 Mar 2010 15:31:28 +0300 Denis wrote:
 mc4.7.1 crashes by SIGSEGV when attempt to panelize search results. In 
 function 'static int find_file (const char *start_dir, const char *pattern, 
 const char *content, char **dirname, char **filename)' at find.c line 1266
 not check value 'le-data'. It zero, = SIGSEGV.

Already fixed.
http://www.midnight-commander.org/ticket/2068
http://www.midnight-commander.org/ticket/2080

-- 
Andrew
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Some keys are not properly recognized in Konsole/xterm

[Andrew Borodin]

On Tue, 02 Feb 2010 10:25:46 +0100 Yury V. Zaytsev wrote:
 This does not really explain why the default key bindings were switched
 from Ctrl+PgUp and Ctrl+PgDown that I've been using unconsciously for
 quite a long time at all.

Oh, sorry... I didn't quite understand that e-mail.

The discussed change of keybindings was inpired by
http://www.midnight-commander.org/ticket/1724#comment:4
and
http://www.midnight-commander.org/ticket/1724#comment:22

-- 
Andrew
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [SPAM] (5.50/5.00) Re: builtin editor, color background bug.

[Andrew Borodin]

On Tue, 12 Jan 2010 11:17:15 +0100 Yury V. Zaytsev wrote:
 Could you please attach a sample XML file?

There is no need for that. The bug is stable reproducable.

-- 
Andrew
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: quick-view line-wrap bug.

[Andrew Borodin]

On Sat, 9 Jan 2010 13:10:05 +0100 Janek Kozicki wrote:
 Andrew Borodin said: (by the date of Thu, 07 Jan 2010 09:53:59 +0300)
 
  Thanks for the bugreport. I've created a ticket:
  http://www.midnight-commander.org/ticket/1944
 
 how can I download this? Forgive me my git ignorance.

You already have the git repo, don't you? Do following commands:

# 1. Remove modified file from current working directory
git reset --hard
# 2. Switch to the master branch:
git checkout master
# 3. Update repo:
git pull
# 4. Get new branch:
git checkout -b 1944_empty_line_in_wrapped_line 
origin/1944_empty_line_in_wrapped_line

 You will probably tell me to switch branch. But I already switched,
 because I need to use this patch:
 
 git checkout -b 1918_quick_view_corruption origin/1918_quick_view_corruption
 
 How can I use both patches at the same time?

The 1918_quick_view_corruption branch already merged to the master one.
so you don't need it. 1944_empty_line_in_wrapped_line branch includes
patches of 1918_quick_view_corruption one.

-- 
Andrew
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: quick view

[Andrew Borodin]

On Sun, 3 Jan 2010 14:40:57 +0100 Janek Kozicki wrote:
 unfortunately not.
 
 Here's what I have done right now, so you can confirm that I indeed
 have used this patch:
 
 mkdir ZZ ; cd ZZ
 svn co svn://svn.debian.org/svn/pkg-mc/trunk  
 git clone git://midnight-commander.org/git/mc.git
 mv trunk/debian mc
 cd mc
 
 # go to website 
 http://www.midnight-commander.org/changeset/121875c21965f6654307c8979287a89e8fddb22f

Actually, only this commit cannot help you. This is a first commit
in a 1918_quick_view_corruption branch and it contains code refactoring
only. No bug fixing at all.

You must compile the entire 1918_quick_view_corruption branch. After
git clone, get the branch:

git checkout -b 1918_quick_view_corruption origin/1918_quick_view_corruption

Compile it and test.

I use 8-it locale (KOI8-R), so I fix this bug also for myself. :)
-- 
Andrew
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: redefining keys

[Andrew Borodin]

On Wed, 04 Nov 2009 10:05:53 + y199mp1...@gmail.com wrote:
 Further there is no indication in the help file that F1-F10 cannot
 be redefined, but I failed consistently when trying. Is this intended,
 is it a feature and not a bug?

It's known bug. I'm currently fixing it.

-- 
Andrew

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: duplicate definition of fast_reload

[Andrew Borodin]

On Wed, 28 Oct 2009 20:14:17 +0100 Enrico Weigelt wrote:
 just seen that the variable fast_reload is defined twice
 (once in main.c, once in screen.c),

I cannot find that in main.c.

fast_reload variable is declared as extern in panel.h and defined in screen.c 
only.

-- 
Andrew.

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Segmentation fault on launch - info or tree panel

[Andrew Borodin]

On Tue, 18 Aug 2009 17:23:01 -0400 David Martin wrote:
 Ctrl-x i (or open the info panel from F9 menu)
 F10 (to close)
 mc (launch again)
 Segmentation fault

Thank you for the bugreport. This is reproducable bug.

http://www.midnight-commander.org/ticket/1544

-- 
Andrew.
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: How to update es.po?

[Andrew Borodin]

On Fri, 24 Jul 2009 05:55:11 -0400 David Martin wrote:
 
 I will try to update Spanish translations as soon as possible,

Great! Thanks!

  but I'm not familiar with these new protocols and the use of git.
   Give me some time, please.David

Please attach you es.po file to  http://www.midnight-commander.org/ticket/1370.

-- 
Regards,
Andrew.
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: [BUG] memory leak in src/file.c::copy_dir_dir()

[Andrew Borodin]

On Thu, 2 Jul 2009 19:03:30 +0200 Denys Vlasenko wrote:
 Please, can someone with write access do this? Thanks.

Thanks for bugreport.

Ticket have been created.
http://www.midnight-commander.org/ticket/1393

-- 
Andrew
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[PATCH] type accuracy in listbox routines

[Andrew Borodin]

Greetings!

Since trac is still locked, I'm sending patch here.

Changelog:

src/dialog.h: set definitely values of cb_ret_t emum type.
src/widget.c: cb_ret_t type accuracy in listbox routines.

-- 
Regards,
Andrew
diff --git a/src/dialog.h b/src/dialog.h
index d0f797b..16ffc4f 100644
--- a/src/dialog.h
+++ b/src/dialog.h
@@ -49,8 +49,8 @@ typedef enum {
 } widget_msg_t;
 
 typedef enum {
-MSG_NOT_HANDLED,
-MSG_HANDLED
+MSG_NOT_HANDLED = 0,
+MSG_HANDLED = 1
 } cb_ret_t;
 
 /* Widgets are expected to answer to the following messages:
diff --git a/src/widget.c b/src/widget.c
index f85cc2a..24d196d 100644
--- a/src/widget.c
+++ b/src/widget.c
@@ -1025,7 +1025,7 @@ show_hist (GList *history, int widget_x, int widget_y)
 	listbox_add_item (query_list, 0, 0, (char *) hi-data, NULL);
 	hi = g_list_next (hi);
 	}
-	while (listbox_fwd (query_list));
+	while (listbox_fwd (query_list) != MSG_NOT_HANDLED);
 } else {
 	/* traverse backwards */
 	hi = g_list_last (history);
@@ -1965,11 +1965,11 @@ static cb_ret_t
 listbox_key (WListbox *l, int key)
 {
 int i;
-int j = 0;
+cb_ret_t j = MSG_NOT_HANDLED;
 
 if (!l-list)
 	return MSG_NOT_HANDLED;
-
+
 switch (key){
 case KEY_HOME:
 case KEY_A1:
@@ -1999,15 +1999,15 @@ listbox_key (WListbox *l, int key)
 
 case KEY_NPAGE:
 case XCTRL('v'):
-	for (i = 0; i  l-height-1; i++)
+	for (i = 0; i  l-height - 1; i++)
 	j |= listbox_fwd (l);
-	return (j  0) ? MSG_HANDLED : MSG_NOT_HANDLED;
+	return (j != MSG_NOT_HANDLED) ? MSG_HANDLED : MSG_NOT_HANDLED;
 	
 case KEY_PPAGE:
 case ALT('v'):
-	for (i = 0; i  l-height-1; i++)
+	for (i = 0; i  l-height - 1; i++)
 	j |= listbox_back (l);
-	return (j  0) ? MSG_HANDLED : MSG_NOT_HANDLED;
+	return (j != MSG_NOT_HANDLED) ? MSG_HANDLED : MSG_NOT_HANDLED;
 }
 return MSG_NOT_HANDLED;
 }
@@ -2058,7 +2058,7 @@ listbox_callback (Widget *w, widget_msg_t msg, int parm)
 	return MSG_NOT_HANDLED;
 
 case WIDGET_KEY:
-	if ((ret_code = listbox_key (l, parm)))
+	if ((ret_code = listbox_key (l, parm)) != MSG_NOT_HANDLED)
 	listbox_draw (l, 1);
 	return ret_code;
 
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Building 4.6.2

[Andrew Borodin]

On Mon, 2 Feb 2009 22:54:59 +0100 Enrico Weigelt wrote:
 * Paul Marwick wrote:
  Just tried to build 4.6.2. However, I get this error as soon as I start 
  configure:
  
  t-61vl:/~/hold/mc-4.6.2
  tooth:$ ./configure --prefix=/usr --with-screen-slang
  configure: error: cannot find install-sh or install.sh in config ./config
 
 please run ./autogen.sh first

I think this is error. Run of ./configure is enougth in release tarball.
Correct tarball must provides all required files to be ndependent
of autotools installed or not on current host.

I think this must be fixed and therefor 4.6.2.1 release is needed.

-- 
Regards,
Andrew

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: updated: [54d6ec8] replaced buggy concat_dir_and_file() by mhl_str_dir_plus_file()

[Andrew Borodin]

On Sat, 31 Jan 2009 18:17:03 +0100 (CET) Enrico Weigelt, metux IT service 
wrote:
 +static inline char* mhl_str_dir_plus_file(const char* dirname, const char* 
 filename)
 +{
 +/* make sure we have valid strings */
 +if (!dirname)
 + dirname=;
 +
 +if (!filename)
 + filename=;
 +
 +/* skip leading slashes on filename */
 +while (*filename == '/')
 + filename++;
 +
 +/* skip trailing slashes on dirname */
 +int dnlen = strlen(dirname);
 +while (dnlen  (dirname[dnlen-1]=='/'))
 + dnlen--;
 +
 +int fnlen = strlen(filename);
 +char* buffer = mhl_mem_alloc_z(dnlen+fnlen+2);   /* enough space for 
 dirname, /, filename, zero */
 +char* ptr = buffer;
 +
 +memcpy(ptr, dirname, dnlen);
 +ptr+=dnlen;
 +*ptr = '/';
 +ptr++;
 +memcpy(ptr, filename, fnlen);
 +ptr+=fnlen;
 +*ptr = 0;
 +
 +return buffer;
 +}
 +
  #endif /* __MHL_STRING_H */

strlen() returns a value of type size_t, not int!

-- 
Regards,
Andrew.
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

glib or not glib? (was: Re: [Midnight Commander] #150: [PATCH] More FHS-compliant install directories)

[Andrew Borodin]

On Wed, 7 Jan 2009 09:35:25 +0100 Enrico Weigelt wrote:
 * MC Ticket System tick...@midnight-commander.org schrieb:
 
   Why the _strcatdup() function is used instead of g_strconcat() one?
 
 First tiny step to get rid if glib.

It's very strange. Do you think than mc must be free of glib?

glib or not glib?

-- 
Regards.
Andrew.
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: glib or not glib?

[Andrew Borodin]

On Wed, 7 Jan 2009 13:11:56 +0100 Enrico Weigelt wrote:
 * Andrew Borodin  schrieb:
   First tiny step to get rid if glib.
  
  It's very strange. Do you think than mc must be free of glib?
 
 Yes, because glib is a fat blob we don't really need (the few
 things we currently use can be easily done w/ a bunch of 
 macros or inline's).

Other developers are disagree with you. glib provides many useful
functions and data structures and allows us do not reinvent the wheel.
And glib is portable library.

 Isn't it rather absurd to maintain an stripped-down branch of
 slang for embedded systems, but at the same time import glib ? ;-O

mc for embedded systems can be linked statically.

-- 
Regards,
Andrew.
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: bundled intl stuff necessary

[Andrew Borodin]

On Sat, 3 Jan 2009 17:34:19 +0100 Enrico Weigelt wrote:
 Why do extfs scripts belong into contrib ?
 
 BTW: they should be installed into ${libexecdir}/mc, not 
 ${datarootdir}/mc. Same w/ the stuff in ${datarootdir}/mc/bin.

Why? ${datarootdir}/mc contains arch-independent files and
mc-specific files. It's correct place in terms of FHS.

 The global menu configs belong into ${sysconfdir}/mc.

I agree.

 Hintfiles are locale stuff, so belong somewhere below 
 ${datarootdir}/locale/.

Hintfiles are private data of mc. ${datarootdir}/mc is correct place
for it.

-- 
Regards,
Andrew.
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: Tree-Maintenance: current/devel

[Andrew Borodin]

On Wed, 31 Dec 2008 10:19:33 +0200 Slava Zanko wrote:
 Or may be anonymous r/o access:
 git clone git://midnight-commander.org/git/mc.git

Is it possible to make an anonymous r/o http access to git for those people who 
lives behind the corporative proxy?

git clone http://midnight-commander.org/git/mc.git

Regards,
Andrew.
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #18129] sort users and groups in chown dialog

[Andrew Borodin]

Follow-up Comment #2, bug #18129 (project mc):

In some cases, this patch produces incorrect sorting.

For example, the list

Unknown user
root
bin
daemon
adm
lp

is being sorted as following:

Unknown user
adm
daemon
lp
root
bin

You can see bin at the end of the sorted list.

Example code is attached.


(file #15710)
___

Additional Item Attachment:

File name: sort.c Size:3 KB


___

Reply to this item at:

  http://savannah.gnu.org/bugs/?18129

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #6457] Check returned values of vfs_get_class() and vfs_op()

[Andrew Borodin]

URL:
  http://savannah.gnu.org/patch/?6457

 Summary: Check returned values of vfs_get_class() and
vfs_op()
 Project: GNU Midnight Commander
Submitted by: a_borodin
Submitted on: Вторник 11.03.2008 at 07:10
Category: VFS
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

Patch from ALT Linux: http://www.sisyphus.ru/srpm/Sisyphus/mc/patches/29




___

Reply to this item at:

  http://savannah.gnu.org/patch/?6457

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #6457] Check returned values of vfs_get_class() and vfs_op()

[Andrew Borodin]

Follow-up Comment #2, patch #6457 (project mc):

Unfortunately, yes. (Btw, this patch is not written by me).

___

Reply to this item at:

  http://savannah.gnu.org/patch/?6457

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #6457] Check returned values of vfs_get_class() and vfs_op()

[Andrew Borodin]

Follow-up Comment #4, patch #6457 (project mc):

I reported about this bug to ALT Linux bugzilla.
https://bugzilla.altlinux.org/show_bug.cgi?id=14849

Thank you.


___

Reply to this item at:

  http://savannah.gnu.org/patch/?6457

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

do_refresh() is called twice

[Andrew Borodin]

Hi!

In many places, the do_refresh() function is called twice.

Let's the mc_internal_viewer() function as an example. The last action
in mc_internal_viewer() is the of destroy_dlg() call. The last action
in destroy_dlg() is the do_refresh() call.

In view_file_at_line() function, repaint_screen() is called
after mc_internal_viewer(). The same is in exec_extension() function. The first 
action in repaint_screen() is the do_refresh() call. So, you
can see that the do_refresh() is called twice.

Sometimes do_refresh() can be called twice in user_menu_cmd() (src/user.c, 
lines 659, 834).


Another such places:

end of display_bits_box() function:
destroy_dlg (dbits_dlg);
repaint_screen ();

hotlist_done(), learn_done(), listmode_done(), panelize_done() functions:
destroy_dlg (...);
repaint_screen ();

May be somewhere else. I don't have the full list at this moment .

Regards,
Andrew.
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #6272] main.h: code clean up

[Andrew Borodin]

URL:
  http://savannah.gnu.org/patch/?6272

 Summary: main.h: code clean up
 Project: GNU Midnight Commander
Submitted by: a_borodin
Submitted on: Понедельник 19.11.2007 at 08:17
Category: Core
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

Some fixes in src/main.h.

Changelog:

* Removed touch_bar() prototype declaration. This function is defined
nowhere.
* Conditional inclusion of do_update_prompt() and do_possible_cd() function
prototipes using #ifdef HAVE_SUBSHELL_SUPPORT.




___

File Attachments:


---
Date: Понедельник 19.11.2007 at 08:17  Name:
mc-20071103-main.h.patch  Size: 769B   By: a_borodin

http://savannah.gnu.org/patch/download.php?file_id=14426

___

Reply to this item at:

  http://savannah.gnu.org/patch/?6272

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #6267] Remove of WANT_WIDGETS.

[Andrew Borodin]

URL:
  http://savannah.gnu.org/patch/?6267

 Summary: Remove of WANT_WIDGETS.
 Project: GNU Midnight Commander
Submitted by: a_borodin
Submitted on: Среда 14.11.2007 at 07:00
Category: Core
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

What the WANT_WIDGETS define is need for? I propose to remove WANT_WIDGETS at
all. Patch is attached.

Changelog:

src/main.h: Remove #ifdef WANT_WIDGETS preprocessor directive.
src/filegui.c: Remove #define WANT_WIDGETS preprocessor directive.
src/layout.c: Likewise.
src/screen.c: Likewise.



___

File Attachments:


---
Date: Среда 14.11.2007 at 07:00  Name: mc-20071103-want_widgets.patch 
Size: 2kB   By: a_borodin

http://savannah.gnu.org/patch/download.php?file_id=14385

___

Reply to this item at:

  http://savannah.gnu.org/patch/?6267

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Updates of po/*.po files are needed

[Andrew Borodin]

Hi!

Since src/find.c file was modified (rev. 1.102 : Fix hotkey duplication),
all po/*.po files should be updated.

for i in po/*.po
do
sed -i -e 's|find Re\cursively|\Find recursively|' $i
done

Regards, 
Andrew.
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #6247] Goto Line #0

[Andrew Borodin]

URL:
  http://savannah.gnu.org/patch/?6247

 Summary: Goto Line #0
 Project: GNU Midnight Commander
Submitted by: a_borodin
Submitted on: Понедельник 29.10.2007 at 07:10
Category: Editor
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

Input line in Goto line dialog is initialized by any value but 0. In the
meantime, the Goto line #0 command is processed just as Goto line #1 one.
So, I think that the line number 0 should be enabled. Patch, which provides
that, is attached.

Changelog:

* editcmd.c (edit_goto_cmd): Allow init the input line
of Goto line dialog by 0 value.
(edit_goto_cmd): Small optimization of allocated buffer freeing.





___

File Attachments:


---
Date: Понедельник 29.10.2007 at 07:10  Name:
mc-20071027-edit-goto_line.patch  Size: 720B   By: a_borodin

http://savannah.gnu.org/patch/download.php?file_id=14239

___

Reply to this item at:

  http://savannah.gnu.org/patch/?6247

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #6248] edit/editcmd.c: removed unnecessary preprocessor directives

[Andrew Borodin]

URL:
  http://savannah.gnu.org/patch/?6248

 Summary: edit/editcmd.c: removed unnecessary preprocessor
directives
 Project: GNU Midnight Commander
Submitted by: a_borodin
Submitted on: Понедельник 29.10.2007 at 07:15
Category: Editor
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

Changelog:

* editoptions.c: Removed unnecessary #include directives.
Removed unnecessary USE_INTERNAL_EDIT define.
(edit_options_dialog): Changed type of i18n_flag variable from
int to gboolean.





___

File Attachments:


---
Date: Понедельник 29.10.2007 at 07:15  Name:
mc-20071027-editoptions.patch  Size: 2kB   By: a_borodin

http://savannah.gnu.org/patch/download.php?file_id=14240

___

Reply to this item at:

  http://savannah.gnu.org/patch/?6248

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #6249] Improvement usability of Goto line/Goto address dialogs

[Andrew Borodin]

URL:
  http://savannah.gnu.org/patch/?6249

 Summary: Improvement usability of Goto line/Goto address
dialogs
 Project: GNU Midnight Commander
Submitted by: a_borodin
Submitted on: Понедельник 29.10.2007 at 07:30
Category: Viewer
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

In editor, the Goto line dialog is called by M-l key command. In viewer,
Goto line/Goto address dialog is called by F5 key command. I propose to
add M-l key combination as alias of F5 one in viewer. Patch is attached.

In editor, the input line of Goto line dialog is initialized by prevous
typed value. In viewer, doesn't. Attached patch provides the initialization of
input line.

Changelog:

* src/view.c: Removed unnecessary #include directives.
(view_offset_to_coord): Check pointers of returned values.
(view_moveto_bol): Eliminate unused variable.
(view_moveto_eol): Likewise.
(view_moveto_line_cmd): Input line of Goto line dialog is
initilized by previous typed value. Small optimization.
(view_moveto_addr_cmd): Input line of Goto Address dialog is
initilized by previous typed value. Small optimization.
(view_handle_key): Added M-l as alias of F5 to call the
Goto Line/Goto address command (like in mcedit).
doc/mc.1.in: Added Alt-l to mcview key descriptions.
doc/es/mc.1.in: Likewise.
doc/hu/mc.1.in: Likewise.
doc/it/mc.1.in: Likewise.
doc/pl/mc.1.in: Likewise.
doc/ru/mc.1.in: Likewise.
doc/sr/mc.1.in: Likewise.




___

File Attachments:


---
Date: Понедельник 29.10.2007 at 07:30  Name:
mc-20071027-view-moveto.patch  Size: 7kB   By: a_borodin

http://savannah.gnu.org/patch/download.php?file_id=14241

___

Reply to this item at:

  http://savannah.gnu.org/patch/?6249

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

Re: GNU Midnight Commander 4.6.2-pre1

[Andrew Borodin]

On Sat, 29 Sep 2007 20:58:13 +0100 Denys Vlasenko [EMAIL PROTECTED] wrote:
 
 I found the following issues:
 
 
 Alt-O behavior changes for the worse:
 
 4.6.1: make inactive panel show the same dir as active one
 
 4.6.2: make inactive panel show the .. if we stand on non directory
or directory we stand on.
 
 I find 4.6.1 behavior more consistent and useful.

Alt-I in 4.6.2 works as Alt-O in 4.6.1.

 
 I sent a patch which fixes this by adding [skip] and [abort] buttons.
 In case it was missed, I attach it again now. Applies with some offsets,
 run-tested.

The following code

char *msg = g_strconcat(fmt, a, b, (char *)NULL);

is short and clearly than the following one:

char *msg;
int n = strlen(fmt) + strlen(a) + strlen(b) + 1;
msg = malloc(n);
snprintf(msg, n, fmt, a, b);


Regards,
Andrew
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #6216] Don't set the field of structure to NULL before g_free() call

[Andrew Borodin]

URL:
  http://savannah.gnu.org/patch/?6216

 Summary: Don't set the field of structure to NULL before
g_free() call
 Project: GNU Midnight Commander
Submitted by: a_borodin
Submitted on: Суббота 22.09.2007 at 06:35
Category: VFS
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

Small code clean up.



___

File Attachments:


---
Date: Суббота 22.09.2007 at 06:35  Name: mc-unneeded-null.patch  Size:
238B   By: a_borodin

http://savannah.gnu.org/patch/download.php?file_id=14006

___

Reply to this item at:

  http://savannah.gnu.org/patch/?6216

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #6186] Small unifications

[Andrew Borodin]

Follow-up Comment #2, patch #6186 (project mc):

OK


___

Reply to this item at:

  http://savannah.gnu.org/patch/?6186

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #20977] Small unifications

[Andrew Borodin]

URL:
  http://savannah.gnu.org/bugs/?20977

 Summary: Small unifications
 Project: GNU Midnight Commander
Submitted by: a_borodin
Submitted on: Среда 05.09.2007 at 11:29
Category: None
Severity: 3 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
 Open/Closed: Open
 Discussion Lock: Any
 Release: current (CVS or snapshot)
Operating System: GNU/Linux

___

Details:

The following modifications are included into attached patch:

1. In 'Save macro' dialog (edit/editcmd.c, edit_raw_key_query()), button
'Cancel' is renamed to 'Cancel'. So we can remove 'Cancel' from .po files.

2. Renamed defines in src/ext.h: MC_USER_EXT to MC_HOME_EXT, MC_LIB_EXT to
MC_GLOBAL_EXT. Now they look like defines in src/user.h.file.

3. We have two query dialogs:
   with 'Local', 'Home' and 'System Wide' buttons for menu file;
   with 'User' and 'System Wide' buttons for file extensions and syntax
files.
'User' button is renamed to 'Home' in second dialog.




___

File Attachments:


---
Date: Среда 05.09.2007 at 11:29  Name: mc-cvs20070828-unific.patch 
Size: 3kB   By: a_borodin

http://savannah.gnu.org/bugs/download.php?file_id=13882

___

Reply to this item at:

  http://savannah.gnu.org/bugs/?20977

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[patch #6186] Small unifications

[Andrew Borodin]

URL:
  http://savannah.gnu.org/patch/?6186

 Summary: Small unifications
 Project: GNU Midnight Commander
Submitted by: a_borodin
Submitted on: Среда 05.09.2007 at 11:34
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any

___

Details:

The following modifications are included into attached patch:

1. In 'Save macro' dialog (edit/editcmd.c, edit_raw_key_query()), button
'Cancel' is renamed to 'Cancel'. So we can remove 'Cancel' from .po files.

2. Renamed defines in src/ext.h: MC_USER_EXT to MC_HOME_EXT, MC_LIB_EXT to
MC_GLOBAL_EXT. Now they look like defines in src/user.h.file.

3. We have two query dialogs:
with 'Local', 'Home' and 'System Wide' buttons for menu file;
with 'User' and 'System Wide' buttons for file extensions and syntax files.
'User' button is renamed to 'Home' in second dialog. 



___

File Attachments:


---
Date: Среда 05.09.2007 at 11:34  Name: mc-cvs20070828-unific.patch 
Size: 3kB   By: a_borodin

http://savannah.gnu.org/patch/download.php?file_id=13883

___

Reply to this item at:

  http://savannah.gnu.org/patch/?6186

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #13146] make tabs and trailing spaces visible

[Andrew Borodin]

Follow-up Comment #18, bug #13146 (project mc):

Pavel, I applied your patch to vte-0.16.8. It works.


___

Reply to this item at:

  http://savannah.gnu.org/bugs/?13146

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel

[bug #13146] make tabs and trailing spaces visible

[Andrew Borodin]

Follow-up Comment #14, bug #13146 (project mc):

Oswald, you are right. This effect is depending on terminal emulation program
and color scheme.

In linux console, cursor is visible every time. The color of cursor is
changed to light blue in tab and trailing space positions, but cursor is
visible.

The same is in xterm under X. xterm doesn't have any non-default cursor
settings.

In gnome-terminal and multi-gnome-terminal, which I use, cursor changes its
color and becomes invisible. (Green on black color scheme and Linux
console palette are used in both those programs.)

Is it possible to make the same cursor color in positions of  visualized tab
an training space as in positions of other symbols?


___

Reply to this item at:

  http://savannah.gnu.org/bugs/?13146

___
  Message sent via/by Savannah
  http://savannah.gnu.org/

___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel