[MediaWiki-commits] [Gerrit] Simplified and cleaned up code - change (mediawiki...SemanticMediaWiki)
Markus Kroetzsch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/50736
Change subject: Simplified and cleaned up code
..
Simplified and cleaned up code
This also prepares the removal of the deprecated method
SMWWikiPageValue::getSortKey().
This change does not affect functionality or behaviour.
No new methods have been introduced, but some were renamed (hence the @since
1.9 tags).
Change-Id: If48871c8e1035d53f3cbf814a5f174b1c8057e72
---
M includes/queryprinters/ListResultPrinter.php
1 file changed, 225 insertions(+), 146 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki
refs/changes/36/50736/1
diff --git a/includes/queryprinters/ListResultPrinter.php
b/includes/queryprinters/ListResultPrinter.php
index 6e129c2..1768996 100644
--- a/includes/queryprinters/ListResultPrinter.php
+++ b/includes/queryprinters/ListResultPrinter.php
@@ -29,11 +29,14 @@
/**
* New implementation of SMW's printer for results in lists.
+ * The implementation covers comma-separated lists, ordered and unordered
lists.
+ * List items may be formatted using templates, and list output can be in
+ * multiple columns (at least for ordered and unordered lists).
*
- * Somewhat confusing code, since one has to iterate through lists, inserting
texts
- * in between their elements depending on whether the element is the first
that is
- * printed, the first that is printed in parentheses, or the last that will be
printed.
- * Maybe one could further simplify this.
+ * In the code below, one list item (with all extra information displayed for
+ * it) is called a row, while one entry in this row is called a field to
+ * avoid confusion with the columns that we have in multi-column display.
+ * Every field may in turn contain many values.
*
* @ingroup SMWQuery
*/
@@ -45,6 +48,70 @@
protected $mColumns;
protected $mIntroTemplate;
protected $mOutroTemplate;
+
+ /**
+* The text used to start the list.
+* @var string
+* @since 1.9
+*/
+ protected $header;
+ /**
+* The text used to end the list.
+* @var string
+* @since 1.9
+*/
+ protected $footer;
+ /**
+* The text used to start a row in the list.
+* @var string
+* @since 1.9
+*/
+ protected $rowstart;
+ /**
+* The text used to end a row in the list.
+* @var string
+* @since 1.9
+*/
+ protected $rowend;
+ /**
+* The text used to separate items in the list, other than the final
+* one.
+* @var string
+* @since 1.9
+*/
+ protected $listsep;
+ /**
+* The text used to separate the last item in the list from the rest.
+* @var string
+* @since 1.9
+*/
+ protected $finallistsep;
+ /**
+* Width (in percent) of columns in multi-column display.
+* @var integer
+* @since 1.9
+*/
+ protected $columnWidth;
+ /**
+* Number of results per column in multi-column display.
+* @var integer
+* @since 1.9
+*/
+ protected $rowsPerColumn;
+ /**
+* Number of results in current column in multi-column display.
+* @var integer
+* @since 1.9
+*/
+ protected $numRowsInColumn;
+ /**
+* Number of results printed so far (equals index of result
+* to print next).
+* @var integer
+* @since 1.9
+*/
+ protected $numRows;
+
/**
* @see SMWResultPrinter::handleParameters
@@ -82,73 +149,30 @@
* @return string
*/
protected function getResultText( SMWQueryResult $queryResult,
$outputmode ) {
- if ( ( $this-mFormat == 'template' ) ( $this-mTemplate ==
false ) ) {
- $queryResult-addErrors( array(
$this-getContext()-msg( 'smw_notemplategiven' )-inContentLanguage()-text()
) );
+ if ( $this-mFormat == 'template' !$this-mTemplate ) {
+ $queryResult-addErrors( array(
+ $this-getContext()-msg( 'smw_notemplategiven'
)-inContentLanguage()-text()
+ ) );
return '';
}
- // Determine mark-up strings used around list items:
- if ( ( $this-mFormat == 'ul' ) || ( $this-mFormat == 'ol' ) )
{
- $header = . $this-mFormat . \n;
- $footer = / . $this-mFormat . \n;
- $rowstart = \tli;
- $rowend = /li\n;
- $plainlist = false;
- } else { // list and template format
- $header = '';
- $footer = '';
-
[MediaWiki-commits] [Gerrit] Add missing use statement and use one line for each - change (mediawiki...SemanticMediaWiki)
Markus Kroetzsch has submitted this change and it was merged. Change subject: Add missing use statement and use one line for each .. Add missing use statement and use one line for each Change-Id: I5ed83bfced9be1da8e1ba00cedc92da68f2082c9 --- M includes/queryprinters/ListResultPrinter.php 1 file changed, 7 insertions(+), 2 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved diff --git a/includes/queryprinters/ListResultPrinter.php b/includes/queryprinters/ListResultPrinter.php index 1768996..4cacf03 100644 --- a/includes/queryprinters/ListResultPrinter.php +++ b/includes/queryprinters/ListResultPrinter.php @@ -1,8 +1,13 @@ ?php namespace SMW; -use SMWQueryResult, SMWDataItem; -use Sanitizer, Html; + +use SMWQueryResult; +use SMWDataItem; +use SMWResultArray; + +use Sanitizer; +use Html; /** * Print query results in lists. -- To view, visit https://gerrit.wikimedia.org/r/50754 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5ed83bfced9be1da8e1ba00cedc92da68f2082c9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: jenkins-bot ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix construction of SMWExpLiteral which requires first arg t... - change (mediawiki...SemanticMediaWiki)
Markus Kroetzsch has submitted this change and it was merged.
Change subject: Fix construction of SMWExpLiteral which requires first arg to
be string
..
Fix construction of SMWExpLiteral which requires first arg to be string
Change-Id: Iab48fe77e862b077e0d65580268e37fe416e
---
M includes/export/SMW_Exporter.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Markus Kroetzsch: Verified; Looks good to me, approved
diff --git a/includes/export/SMW_Exporter.php b/includes/export/SMW_Exporter.php
index 6db650f..1765aa0 100644
--- a/includes/export/SMW_Exporter.php
+++ b/includes/export/SMW_Exporter.php
@@ -639,7 +639,7 @@
*/
static public function getDataItemHelperExpElement( SMWDataItem
$dataItem ) {
if ( $dataItem-getDIType() == SMWDataItem::TYPE_TIME ) {
- $lit = new SMWExpLiteral( $dataItem-getSortKey(),
'http://www.w3.org/2001/XMLSchema#double', $dataItem );
+ $lit = new SMWExpLiteral(
(string)$dataItem-getSortKey(), 'http://www.w3.org/2001/XMLSchema#double',
$dataItem );
return $lit;
} else {
return null;
--
To view, visit https://gerrit.wikimedia.org/r/50487
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iab48fe77e862b077e0d65580268e37fe416e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com
Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org
Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com
Gerrit-Reviewer: jenkins-bot
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Remove line that disables DISTINCT with blobs - change (mediawiki...SemanticMediaWiki)
Markus Kroetzsch has uploaded a new change for review. https://gerrit.wikimedia.org/r/50381 Change subject: Remove line that disables DISTINCT with blobs .. Remove line that disables DISTINCT with blobs This fixes bug 45129. Change-Id: I5f8028c4a7b360b144304055d2938c6b8694ff37 --- M includes/storage/SQLStore/SMW_SQLStore3_Readers.php 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/81/50381/1 diff --git a/includes/storage/SQLStore/SMW_SQLStore3_Readers.php b/includes/storage/SQLStore/SMW_SQLStore3_Readers.php index f6d8e60..c9cb0fb 100644 --- a/includes/storage/SQLStore/SMW_SQLStore3_Readers.php +++ b/includes/storage/SQLStore/SMW_SQLStore3_Readers.php @@ -311,8 +311,6 @@ $fieldname AS v$valuecount; } - // Don't use DISTINCT with text blobs: - if ( $typeid == 'l' ) $usedistinct = false; $valuecount += 1; } -- To view, visit https://gerrit.wikimedia.org/r/50381 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5f8028c4a7b360b144304055d2938c6b8694ff37 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Cleanup of SMW_setup.php, attempt to fix bug 42349 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Cleanup of SMW_setup.php, attempt to fix bug 42349 .. Cleanup of SMW_setup.php, attempt to fix bug 42349 Change-Id: Ia70b25d870e74515c49d5f35e5b9efca09dac373 --- M maintenance/SMW_setup.php 1 file changed, 117 insertions(+), 39 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/35417 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia70b25d870e74515c49d5f35e5b9efca09dac373 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Foxtrott s7ep...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Kghbln mediaw...@kghoffmeyer.de Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com Gerrit-Reviewer: Yaron Koren yaro...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed some interface issues in SMW_setup.php - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed some interface issues in SMW_setup.php .. Fixed some interface issues in SMW_setup.php Changes: * Register --backend as an option *with parameters*; this makes --backend Name work (otherwise only --backend=Name works) and it improves error handling * Check if provided backend is a valid class name; prevents PHP errors on typos * Respect --quiet by using the output() method instead of print, and by passing on the information given by isQuiet() to store operations * Fix spelling and format of some documentation Change-Id: I3e2ada69a0bb23ee42e993cee3ad4a6ef7ffd65e --- M maintenance/SMW_setup.php 1 file changed, 24 insertions(+), 19 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/62/36162/1 -- To view, visit https://gerrit.wikimedia.org/r/36162 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3e2ada69a0bb23ee42e993cee3ad4a6ef7ffd65e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Minor fix in URI decoding for SPARQL stores - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Minor fix in URI decoding for SPARQL stores .. Minor fix in URI decoding for SPARQL stores Use rawurldecode instead of urldecode, as reported by Luka Frelih [1]. [1] http://permalink.gmane.org/gmane.comp.web.wiki.semediawiki.devel/3974 Change-Id: I8551ba52c21757af5034bcfe619c70d6120ac423 --- M includes/export/SMW_Exporter.php 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/63/36163/1 -- To view, visit https://gerrit.wikimedia.org/r/36163 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8551ba52c21757af5034bcfe619c70d6120ac423 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed some interface issues in SMW_setup.php - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed some interface issues in SMW_setup.php .. Fixed some interface issues in SMW_setup.php Changes: * Register --backend as an option *with parameters*; this makes --backend Name work (otherwise only --backend=Name works) and it improves error handling * Check if provided backend is a valid class name; prevents PHP errors on typos * Respect --quiet by using the output() method instead of print, and by passing on the information given by isQuiet() to store operations * Fix spelling and format of some documentation Patchset 2: Fixing remaining uses of echo that ignored --quiet. Patchset 3: Fixed more typos (promt) and modified behaviour when given invalid storage class (report error die) Change-Id: I3e2ada69a0bb23ee42e993cee3ad4a6ef7ffd65e --- M maintenance/SMW_setup.php 1 file changed, 34 insertions(+), 27 deletions(-) Approvals: Markus Kroetzsch: Verified Foxtrott: Looks good to me, but someone else must approve Jeroen De Dauw: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/36162 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3e2ada69a0bb23ee42e993cee3ad4a6ef7ffd65e Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Foxtrott s7ep...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Kghbln mediaw...@kghoffmeyer.de Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com Gerrit-Reviewer: Yaron Koren yaro...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 42361 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 42361 .. Fix Bug 42361 Reworked code for string datavalue to avoid double escaping of active markup that we introduce for display. The code should also be more readable overall now. This fixes Bug 42361. Change-Id: Iac5a6a25068df133246979f0db19f19b9ddad2ef --- M includes/datavalues/SMW_DV_String.php 1 file changed, 88 insertions(+), 31 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/64/34864/1 -- To view, visit https://gerrit.wikimedia.org/r/34864 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iac5a6a25068df133246979f0db19f19b9ddad2ef Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 42361 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix Bug 42361 .. Fix Bug 42361 Reworked code for string datavalue to avoid double escaping of active markup that we introduce for display. The code should also be more readable overall now. This fixes Bug 42361. Change-Id: Iac5a6a25068df133246979f0db19f19b9ddad2ef --- M includes/datavalues/SMW_DV_String.php 1 file changed, 88 insertions(+), 31 deletions(-) Approvals: Markus Kroetzsch: Verified Jeroen De Dauw: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/34864 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac5a6a25068df133246979f0db19f19b9ddad2ef Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Nischayn22 nischay...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Store3 as default; updated documentation files - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Store3 as default; updated documentation files .. Store3 as default; updated documentation files Getting ready for the release. * Reorganised RELEASE-NOTES to separate user enahncements from code enhancements; added some things forgotten so far; clarified some formulations * Updated INSTALL (might need update again when migration script is working; I suggest to keep the slow method documented as a backup in any case) * Switched to Store3 as the default (but INSTALL has instructions for upgrade to avoid surprises) Change-Id: Ia6766b03bdb72e1d89a6cdb88a7688c0391acf5f --- M INSTALL M RELEASE-NOTES-1.8 M SMW_Settings.php 3 files changed, 64 insertions(+), 42 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/92/34492/1 -- To view, visit https://gerrit.wikimedia.org/r/34492 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia6766b03bdb72e1d89a6cdb88a7688c0391acf5f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed Bug 42032 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed Bug 42032 .. Fixed Bug 42032 The bug is caused by more than one entry referring to special properties in the SMW IDs table. There are multiple reasons why this has happened: * Predefined properties are stored by their keys (e.g., _TYPE) but if they also have a property page, this page will be called like their current label (e.g., has type); this was not matched * The refresh script carelessly created refresh jobs even for predefined properties, thus refreshing pages with titles like TYPE that never existed. Both problems surfaced due to the new way of producing Special:Properties. The new code requires Store3 to be reset and recreated to fix any existing problems caused by the earlier misbehaviour. A simple refresh is not going to delete the obsolete ID entries. Note for review: SMW_Sql3SmwIds.php applies some inconsistent naming for new symbols. The old ones should be fixed in another commit, but this is not release critical and would require more far-reaching changes since some of the methods that should be renamed are public. Can be done in SMW 1.9. Change set 2: Using property IDs (with property keys instead of titles) in all places where a property is used requires us to also reconstruct wikipage DIs from such IDs now. If a predefined property is used as a property value, then this is necessary. The DIHandler for wikipage has been augmented to do this, and all code that created SMWDIWikipage from SMW ID table contents is now calling the handler instead. Also fixed a lot of documentation. Change-Id: Ifd6267cbd3fca1c3bee1b1927c70b91bd8128356 --- M includes/dataitems/SMW_DI_Property.php M includes/storage/SQLStore/SMW_DIHandler_WikiPage.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php 7 files changed, 398 insertions(+), 156 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved Jeroen De Dauw: Verified; Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/34211 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd6267cbd3fca1c3bee1b1927c70b91bd8128356 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Foxtrott s7ep...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Kghbln mediaw...@kghoffmeyer.de Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com Gerrit-Reviewer: Yaron Koren yaro...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed Bug 42032 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed Bug 42032 .. Fixed Bug 42032 The bug is caused by more than one entry referring to special properties in the SMW IDs table. There are multiple reasons why this has happened: * Predefined properties are stored by their keys (e.g., _TYPE) but if they also have a property page, this page will be called like their current label (e.g., has type); this was not matched * The refresh script carelessly created refresh jobs even for predefined properties, thus refreshing pages with titles like TYPE that never existed. Both problems surfaced due to the new way of producing Special:Properties. The new code requires Store3 to be reset and recreated to fix any existing problems caused by the earlier misbehaviour. A simple refresh is not going to delete the obsolete ID entries. Note for review: SMW_Sql3SmwIds.php applies some inconsistent naming for new symbols. The old ones should be fixed in another commit, but this is not release critical and would require more far-reaching changes since some of the methods that should be renamed are public. Can be done in SMW 1.9. Change-Id: Ifd6267cbd3fca1c3bee1b1927c70b91bd8128356 --- M includes/dataitems/SMW_DI_Property.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php 3 files changed, 234 insertions(+), 102 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/11/34211/1 -- To view, visit https://gerrit.wikimedia.org/r/34211 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd6267cbd3fca1c3bee1b1927c70b91bd8128356 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix sortkey retrieval in Store3 (Bug 42033, ...) - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix sortkey retrieval in Store3 (Bug 42033, ...) .. Fix sortkey retrieval in Store3 (Bug 42033, ...) Since sortkeys are not stored in a property table, but in the SMW IDs table, methods need special code to handle them. This was missing everywhere, but has a practical impact only for getPropertyValues(). Where unexpected, this caused warnings and errors (Bug 42033, Bug 42034) but also spurious problems with ordering of results (only in certain cases). The change fixes this for getPropertyValues and adds remarks/todos in all cases where sortkeys are not currently supported (but not practically needed either). Change-Id: I69b7900152efb72b3fc5e31f3b68a07b22a2e67d --- M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php 2 files changed, 27 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/81/33081/1 -- To view, visit https://gerrit.wikimedia.org/r/33081 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I69b7900152efb72b3fc5e31f3b68a07b22a2e67d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix sortkey retrieval in Store3 (Bug 42033, ...) - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix sortkey retrieval in Store3 (Bug 42033, ...) .. Fix sortkey retrieval in Store3 (Bug 42033, ...) Since sortkeys are not stored in a property table, but in the SMW IDs table, methods need special code to handle them. This was missing everywhere, but has a practical impact only for getPropertyValues(). Where unexpected, this caused warnings and errors (Bug 42033, Bug 42034) but also spurious problems with ordering of results (only in certain cases). The change fixes this for getPropertyValues and adds remarks/todos in all cases where sortkeys are not currently supported (but not practically needed either). Change-Id: I69b7900152efb72b3fc5e31f3b68a07b22a2e67d --- M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php 2 files changed, 27 insertions(+), 4 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved Jeroen De Dauw: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/33081 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69b7900152efb72b3fc5e31f3b68a07b22a2e67d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Foxtrott s7ep...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Kghbln mediaw...@kghoffmeyer.de Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com Gerrit-Reviewer: Yaron Koren yaro...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Support variable SQL backends in SPARQL Store - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Support variable SQL backends in SPARQL Store .. Support variable SQL backends in SPARQL Store SMWSparlStore used to be a subclass of SMWSQLStore2, which made it impossible to switch to SQLStore3 in a clean way. The change turns SMWSparqlStore into an adaptor for a base store object that can be any SMWStore. The class to use there can be chosen by setting SMWSparqlStore::$baseStoreClass; the default is SMWSQLStore3 now. Change-Id: I7e60704e4faadb32aac1899d2047e8c66dbb83c3 --- M includes/storage/SMW_SparqlStore.php 1 file changed, 149 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/30/32930/1 -- To view, visit https://gerrit.wikimedia.org/r/32930 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7e60704e4faadb32aac1899d2047e8c66dbb83c3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Support variable SQL backends in SPARQL Store - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Support variable SQL backends in SPARQL Store .. Support variable SQL backends in SPARQL Store SMWSparlStore used to be a subclass of SMWSQLStore2, which made it impossible to switch to SQLStore3 in a clean way. The change turns SMWSparqlStore into an adaptor for a base store object that can be any SMWStore. The class to use there can be chosen by setting SMWSparqlStore::$baseStoreClass; the default is SMWSQLStore3 now. Patchset 2: add missing @since. Patchset 3: fixed documentation Change-Id: I7e60704e4faadb32aac1899d2047e8c66dbb83c3 --- M includes/storage/SMW_SparqlStore.php 1 file changed, 160 insertions(+), 12 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved Jeroen De Dauw: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32930 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e60704e4faadb32aac1899d2047e8c66dbb83c3 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Foxtrott s7ep...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Kghbln mediaw...@kghoffmeyer.de Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com Gerrit-Reviewer: Yaron Koren yaro...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing Change I1b2b6617 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixing Change I1b2b6617 .. Fixing Change I1b2b6617 This fixes some further ways in which change I1b2b6617 breaks SMW. Anything else? Not sure ... Change-Id: Ie966103f0e5832c2af0b0763359448a1243add22 --- M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php 2 files changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/44/32844/1 -- To view, visit https://gerrit.wikimedia.org/r/32844 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie966103f0e5832c2af0b0763359448a1243add22 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixing Change I1b2b6617 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixing Change I1b2b6617 .. Fixing Change I1b2b6617 This fixes some further ways in which change I1b2b6617 breaks SMW. Anything else? Not sure ... Change-Id: Ie966103f0e5832c2af0b0763359448a1243add22 --- M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32844 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie966103f0e5832c2af0b0763359448a1243add22 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed Bug 33610 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed Bug 33610 .. Fixed Bug 33610 The special page code did not handle errors that can occur on property dataitem creation (e.g., if a special property ID from the database is no longer known). To fix this, it was not enough to catch this problem, because the number of results must be the same as requested (otherwise the special page will not offer navigation to the next page of results). The code was changed to return an error dataitem in this case. Several other changes were needed to appropriately process such errors in special pages using this code. Note for review: some code in the two special page files has been moved to a new function. May show as a bigger change in the diff than it actually is. Change-Id: Ibdebbc6b4149afc2a0548e67584580f1637d0f5d --- M includes/storage/SMW_Store.php M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php M specials/QueryPages/SMW_SpecialProperties.php M specials/QueryPages/SMW_SpecialUnusedProperties.php 4 files changed, 151 insertions(+), 52 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved Jeroen De Dauw: Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/32201 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdebbc6b4149afc2a0548e67584580f1637d0f5d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Daniel Werner daniel.wer...@wikimedia.de Gerrit-Reviewer: Denny Vrandecic denny.vrande...@wikimedia.de Gerrit-Reviewer: Foxtrott s7ep...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Kghbln mediaw...@kghoffmeyer.de Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com Gerrit-Reviewer: Yaron Koren yaro...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Better fix for Bug 39392 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Better fix for Bug 39392 .. Better fix for Bug 39392 Changed the behaviour to be as follows: * if linking is enabled (link=all, default), URLs will be made into an explicit link using [ ] in wiki and a in HTML * if linking is disabled or outputformat empty is used (#- or simply #), then URLs will be returned as plain strings in wiki and HTML; in wiki this will mean that the URL will still be linked if MW is configured to link such strings automatically (default) * if the new outputformat nowiki is used (#nowiki), then the URL string will be escaped to prevent MW from making a link of it, so it appears as a plain string in HTML and wiki alike; this changes the string so that it is no longer a valid URL All of this only applies to URL values that can be linked at all (MW knows protocol). URLs that are not linkable in MW are always returned as plain strings in all contexts. Change-Id: If3a91ea6f9fc988e156b64850e428ecbae096228 --- M includes/datavalues/SMW_DV_URI.php 1 file changed, 14 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/55/32555/1 -- To view, visit https://gerrit.wikimedia.org/r/32555 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If3a91ea6f9fc988e156b64850e428ecbae096228 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Store3: tablenames, usage count init, style - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Store3: tablenames, usage count init, style .. Store3: tablenames, usage count init, style This complex change prepares SQLStore3 for release. After updating, you *must* delete and recreate all Store3 tables, e.g., as follows: * first run php SMW_refreshData.php -b SMWSQLStore3 -fp to recreate tables and initialise property pages, * then run php SMW_refreshData.php -b SMWSQLStore3 again to refresh all normal pages. This will not affect the functionality of Store2, if still used. The change does three things: * Change the names of the tables formerly known as smw_ids, smw_conccache, smw_stats (the first two are used by Store2 already; the last was just not very well named and easy to update with the rest); the new names are smw_object_ids, smw_concept_cache, smw_prop_stats. The rename of smw_ids is the reason why a normal setup+refresh will not do. * Update the batch computation of usage counts (in SMW_SQLStore3_SetupHandlers.php); the old computation counted only values of a property that are stored in the table that the property uses *now* to store its data, missing uses in other tables (e.g., due to new special tables being created or due to plain type changes) * The maintenance script SMW_resetStats.php is removed since its job is now done by SMW_setup.php (its old code was outdated anyway) * The broken maintenance script SMW_migration.php is disabled, printing a message on what to do instead. * Many smaller style improvements, especially in documentation. The change depends on the recent writer change, since it is not possible to separate this. Change-Id: I1a163ac23121c373fb9ef5c93eb1a50ed33d85a6 --- M includes/storage/SQLStore/SMW_DataItemHandler.php M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php M maintenance/SMW_migration.php D maintenance/SMW_resetStats.php 10 files changed, 338 insertions(+), 292 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/83/32583/1 -- To view, visit https://gerrit.wikimedia.org/r/32583 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1a163ac23121c373fb9ef5c93eb1a50ed33d85a6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Rewritten SQLStore3 writing methods - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Rewritten SQLStore3 writing methods .. Rewritten SQLStore3 writing methods This is a rewrite of large parts of SMW_SQLStore3_Writers.php. The only methods that are almost unaffected are the ones related to cahning titles and processing redirects (may appear changed in diff since they have been moved to the end). This change should fix the property statistics computation. It also prepares an acurate semantic diff implementation later on. Main changes/key points: * Cleaned up code, splitting everything into smaller methods with a clear task. * Changed writing workflow to compute a full diff of table rows before writing anything * The new writing code deletes only the table rows that are really obsolete, and inserts only those that are added. If a change only deletes or adds one value, then this is all that will be done. * The property statistics are updeated by comparing the real DB contents to the new contents that is to be written. No higher-level data structures or SMW objects are invloved. * There is no longer a separate delete method. To delete all data, we update it to be empty. This ensures that all necessary updates really happen whenever the store is changed (since there are fewer methods that change the store at all). * The new code has no issues with input errors or redirects any more. * The code is now properly documented. Change-Id: I78596341b4427604c31b6d3b15acd894e47ccec0 --- M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php 5 files changed, 476 insertions(+), 397 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/97/32397/1 -- To view, visit https://gerrit.wikimedia.org/r/32397 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I78596341b4427604c31b6d3b15acd894e47ccec0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed Bug 33610 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed Bug 33610 .. Fixed Bug 33610 The special page code did not handle errors that can occur on property dataitem creation (e.g., if a special property ID from the database is no longer known). To fix this, it was not enough to catch this problem, because the number of results must be the same as requested (otherwise the special page will not offer navigation to the next page of results). The code was changed to return an error dataitem in this case. Several other changes were needed to appropriately process such errors in special pages using this code. Note for review: some code in the two special page files has been moved to a new function. May show as a bigger change in the diff than it actually is. Change-Id: Ibdebbc6b4149afc2a0548e67584580f1637d0f5d --- M includes/storage/SMW_Store.php M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php M specials/QueryPages/SMW_SpecialProperties.php M specials/QueryPages/SMW_SpecialUnusedProperties.php 4 files changed, 151 insertions(+), 52 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/01/32201/1 -- To view, visit https://gerrit.wikimedia.org/r/32201 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibdebbc6b4149afc2a0548e67584580f1637d0f5d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 38811 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 38811 .. Fix Bug 38811 Special:UnusedProperties was not checking if a property is special (pre-defined in SMW). This is fixed now, and thus the datatype information for unused special properties shows correctly and the standard tooltip is given. The formatting code for special properties is copied from Special:Properties, so the formatting will be the same as it is there. The change depends on the recent updates done to fix Bug 33610. Change-Id: I0a49c1dae5e27ca12dd52e00fff6c3df1d0b006f --- M specials/QueryPages/SMW_SpecialUnusedProperties.php 1 file changed, 22 insertions(+), 13 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/06/32206/1 -- To view, visit https://gerrit.wikimedia.org/r/32206 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0a49c1dae5e27ca12dd52e00fff6c3df1d0b006f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Trivial documentation change - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Trivial documentation change .. Trivial documentation change The docs were misleading here. Change-Id: I9650e1d77fb3ccc877c08be2ac5e2b18d6bc1a8b --- M includes/storage/SMW_Query.php 1 file changed, 13 insertions(+), 13 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/21/32021/1 -- To view, visit https://gerrit.wikimedia.org/r/32021 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9650e1d77fb3ccc877c08be2ac5e2b18d6bc1a8b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Corrected getWikiValue() for Property DVs - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Corrected getWikiValue() for Property DVs .. Corrected getWikiValue() for Property DVs Inverse properties now have a label with - on the DI level (this was done a few changes back to fix the query string serialisation). Now we do no longer have to add the - on the DV level (this would lead to wrong outputs). Change-Id: I3c92134bafcc805062693f8c23d15963860d7482 --- M includes/datavalues/SMW_DV_Property.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/22/32022/1 -- To view, visit https://gerrit.wikimedia.org/r/32022 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3c92134bafcc805062693f8c23d15963860d7482 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] SMW DataValue check SMWDIBlob - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: SMW DataValue check SMWDIBlob .. SMW DataValue check SMWDIBlob Change-Id: I93d2269e5cc22ee1579e3eb57ad63dc5772812ed --- M includes/datavalues/SMW_DataValue.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved Nischayn22: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/32013 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93d2269e5cc22ee1579e3eb57ad63dc5772812ed Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Nischayn22 nischay...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Protect against unitialised/unrecognised dataitem - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Protect against unitialised/unrecognised dataitem .. Protect against unitialised/unrecognised dataitem There are rare cases (I encountered one during import) when getShortWikiText can be called on an invalid DV. In the given case, this caused an exception. The change protects against that situation. Change-Id: Ifcea2ef4e0e36abfcd5e477a2b34d497a002b066 --- M includes/datavalues/SMW_DV_Time.php 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/26/31826/1 -- To view, visit https://gerrit.wikimedia.org/r/31826 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifcea2ef4e0e36abfcd5e477a2b34d497a002b066 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Protect StubSemanticData agains DI exceptions - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Protect StubSemanticData agains DI exceptions .. Protect StubSemanticData agains DI exceptions If the database contained data about a property whose name is no longer legal, an uncaught exception would be thrown when unstubbing all properties. The usual cause of this situation is that a special property got removed and is no longer known to SMW (because it vanished in a later release, or because it came from an extension now disabled). Change-Id: Ic3d6d169045e800dbdd706f8963b99e62828a0d2 --- M includes/storage/SQLStore/SMW_Sql3StubSemanticData.php M includes/storage/compatSQLStore/SMW_SqlStubSemanticData.php 2 files changed, 25 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/29/31829/1 -- To view, visit https://gerrit.wikimedia.org/r/31829 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic3d6d169045e800dbdd706f8963b99e62828a0d2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed concept cache creation for SQLStore3 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed concept cache creation for SQLStore3 .. Fixed concept cache creation for SQLStore3 Concept caching did not work with Store3 since it was disabled explicitly (easy to fix) and since concept DIs were not read correctly frmo the database. To address the latter, it is necessary to distinguish fields in the DI table from fields that should be retrieved when fetching the DI from the DB (because the concept table has two extra fields that are not relevant to DI creation). Now all DI handlers specify which information should be fetched from the DB to build their DIs, and since this is often just one row, the DI creation allows the use of a string instead of an array that contains a single string only. This safes memory, which is the main goal in this mechanism. Concrete changes: * All DIHandlers have a method getFetchFields() that works like getTableFields() but only for fields whose contents is needed to create the DI. * The SQLStore3Reader uses these fields instead of the table fields to fetch semantic data * The SQLStoreReader uses plain strings instead of arrays whenever only one value is fetched * The DIHandlers slightly change their dataItemFromDBKeys() implementations to use plain strings instead of arrays if only one key is needed. Checks are added to make sure that we never mistake an array for a string or vice versa (no PHP warnings even on unusual circumstances). * Minor documentation and style updates in the affected methods/files. Change-Id: I3f8589b5bc8210d3866e07a9bfe8bdd513ec2688 --- M includes/storage/SQLStore/SMW_DIHandler_Bool.php M includes/storage/SQLStore/SMW_DIHandler_Concept.php M includes/storage/SQLStore/SMW_DIHandler_GeoCoord.php M includes/storage/SQLStore/SMW_DIHandler_Number.php M includes/storage/SQLStore/SMW_DIHandler_String.php M includes/storage/SQLStore/SMW_DIHandler_Time.php M includes/storage/SQLStore/SMW_DIHandler_URI.php M includes/storage/SQLStore/SMW_DIHandler_WikiPage.php M includes/storage/SQLStore/SMW_DataItemHandler.php M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_Sql3StubSemanticData.php M maintenance/SMW_conceptCache.php 13 files changed, 199 insertions(+), 83 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/55/31855/1 -- To view, visit https://gerrit.wikimedia.org/r/31855 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3f8589b5bc8210d3866e07a9bfe8bdd513ec2688 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed broken Special:PageProperty - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed broken Special:PageProperty .. Fixed broken Special:PageProperty This not-so-often used special page was severely broken, due to two problems: * Parameter parsing assume WebRequest::getVal to return '' for empty parameters, but null is returned. * The navigation bar generation used = instead of .= for adding the Next link, thus destroying most of the navigation bar. Have not tried to clean up the rest of the code. It is ugly but short. Change-Id: I7df5be8b729a2ea0b05eb74762611b22b4c45575 --- M RELEASE-NOTES-1.8 M specials/SearchTriple/SMW_SpecialPageProperty.php 2 files changed, 8 insertions(+), 11 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/61/31861/1 -- To view, visit https://gerrit.wikimedia.org/r/31861 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7df5be8b729a2ea0b05eb74762611b22b4c45575 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed version in ask api, removed alpha notice and did some ... - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed version in ask api, removed alpha notice and did some style fixes .. Fixed version in ask api, removed alpha notice and did some style fixes Change-Id: Idf18e6660a914ad0d67871f590e021bcb001f78d --- M includes/api/ApiAsk.php M includes/api/ApiAskArgs.php M includes/api/ApiSMWQuery.php M includes/storage/SMW_PrintRequest.php 4 files changed, 62 insertions(+), 20 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/31743 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idf18e6660a914ad0d67871f590e021bcb001f78d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Always returing Blob - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Always returing Blob .. Always returing Blob Change-Id: I251f86a527f4945cba118338b4b314e5f762bcba --- M includes/storage/SQLStore/SMW_DIHandler_String.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved Nikerabbit: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/31606 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I251f86a527f4945cba118338b4b314e5f762bcba Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Nischayn22 nischay...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Yaron Koren yaro...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Updated SMWQueryProcessor API - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Updated SMWQueryProcessor API .. Updated SMWQueryProcessor API * Disentagled some code in print request parsing * Use array results instead of making part of the parameters call-by-ref to return outputs * Update #ask and #show to make query object first and then create result (the query object will be needed to certain data later on) * Deprecated a number of functions Change-Id: I8ab01a69759f18fc57b2f06fe5c1261b1fccd8bb --- M includes/SMW_QueryProcessor.php M includes/api/ApiAsk.php M includes/parserhooks/SMW_Ask.php M includes/parserhooks/SMW_Concept.php M includes/parserhooks/SMW_Show.php M specials/AskSpecial/SMW_QueryUIHelper.php M specials/AskSpecial/SMW_SpecialAsk.php M tests/phpunit/includes/QueryProcessorTest.php M tests/phpunit/includes/storage/StoreTest.php 9 files changed, 307 insertions(+), 194 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/57/31557/1 -- To view, visit https://gerrit.wikimedia.org/r/31557 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8ab01a69759f18fc57b2f06fe5c1261b1fccd8bb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Store data about inline queries - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Store data about inline queries .. Store data about inline queries This change makes #ask and #show create new information that is stored for the page they are on. Each query creates a subobject that is used to store data about it. Currently, query string, size, depth, and format are stored. This data can be queried as usual, e.g., to find out how many queries on the wiki use a particular format, or what are the largest queries. Changes in details: * New special properties are declared to store the data * All language files are updated to include translations for these properties (most are English placeholders with TODOs) * The new properties get fixed IDs in the store * The serialisation of query strings fixed: it escaped and in subquery syntax. If the string is used in a context that requires escaping, it should be escaped there. * #ask and #show functions updated to store the data Change-Id: Iccd5fa173d59f1e311a03d20171710148a6b3d94 --- M RELEASE-NOTES-1.8 M includes/dataitems/SMW_DI_Property.php M includes/parserhooks/SMW_Ask.php M includes/parserhooks/SMW_Show.php M includes/storage/SMW_Description.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php M languages/SMW_Language.php M languages/SMW_LanguageAr.php M languages/SMW_LanguageArz.php M languages/SMW_LanguageDe.php M languages/SMW_LanguageEn.php M languages/SMW_LanguageEs.php M languages/SMW_LanguageFi.php M languages/SMW_LanguageFr.php M languages/SMW_LanguageHe.php M languages/SMW_LanguageId.php M languages/SMW_LanguageIt.php M languages/SMW_LanguageNl.php M languages/SMW_LanguageNo.php M languages/SMW_LanguagePl.php M languages/SMW_LanguagePt.php M languages/SMW_LanguageRu.php M languages/SMW_LanguageSk.php M languages/SMW_LanguageZh_cn.php M languages/SMW_LanguageZh_tw.php 25 files changed, 268 insertions(+), 54 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/93/31593/1 -- To view, visit https://gerrit.wikimedia.org/r/31593 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iccd5fa173d59f1e311a03d20171710148a6b3d94 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Escape [ and { in code displays - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review.
Change subject: Escape [ and { in code displays
..
Escape [ and { in code displays
This avoids MediaWiki interpretation of text that should be displayed verbatim.
Change-Id: Idd17cdab7c21beec9709a308653aff714b5e03bd
---
M includes/datavalues/SMW_DV_String.php
1 file changed, 4 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki
refs/changes/95/31595/1
--
To view, visit https://gerrit.wikimedia.org/r/31595
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idd17cdab7c21beec9709a308653aff714b5e03bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org
___
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed bug in inverse property handling - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed bug in inverse property handling .. Fixed bug in inverse property handling Inverse properties would not reliably work (in queries etc.) when property names are written in lower case, e.g., -located in. The reason was that the property name was not normalized after stripping the -, so the DB lookup would be based on located_in rather than on Located_in. Change-Id: I8b1b9a13ca2b3e193df94970545c413fff467d71 --- M includes/SMW_QueryParser.php M includes/dataitems/SMW_DI_Property.php M includes/datavalues/SMW_DV_Property.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php 5 files changed, 28 insertions(+), 22 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/79/31279/1 -- To view, visit https://gerrit.wikimedia.org/r/31279 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8b1b9a13ca2b3e193df94970545c413fff467d71 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed Bug 35962 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed Bug 35962 .. Fixed Bug 35962 Avoid a MediaWiki problem with latest revisions during refreshing, causing errors when the property _LEDT (last editor is) is enabled. Fixed according to the suggestions of Van de Bugger in Bug35962. Change-Id: Id5cdc264c7ae448d10c3e5066e732d84c2562154 --- M RELEASE-NOTES-1.8 M includes/SMW_ParseData.php 2 files changed, 33 insertions(+), 28 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/85/31285/1 -- To view, visit https://gerrit.wikimedia.org/r/31285 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id5cdc264c7ae448d10c3e5066e732d84c2562154 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix to bug 41269 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix to bug 41269 .. Fix to bug 41269 Now computing stats during setup, so the insert is anyway not needed. Patchset2: catching some exceptions, cannot see another way to do this best. Patchset4: using verbose stuff Patchset5: Less scary messages Patchset6: Messages Markus prefers:P Change-Id: Ic928d14a89419ad0e6693a87eca65191827108e7 --- M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php 1 file changed, 48 insertions(+), 11 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/29753 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic928d14a89419ad0e6693a87eca65191827108e7 Gerrit-PatchSet: 6 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Nischayn22 nischay...@gmail.com Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Better indexes for Store3 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Better indexes for Store3 .. Better indexes for Store3 * Create different indexes than before; more useful for our queries * Most indexes now created automatically from DIHandler information, only additional indexes need to be set * Cleaned up/refactored index update code in SQLHelpers; better reporting Tested for MySQL. It would be good to test for SQLite and PostreSQL, although (in theory) the old code was merely moved and restructured. Change-Id: I4907a8bea6d4db60daf64c63b994a7a44784fe1d --- M includes/dataitems/SMW_DI_Concept.php M includes/storage/SMW_SQLHelpers.php M includes/storage/SQLStore/SMW_DIHandler_Bool.php M includes/storage/SQLStore/SMW_DIHandler_Concept.php M includes/storage/SQLStore/SMW_DIHandler_GeoCoord.php M includes/storage/SQLStore/SMW_DIHandler_Number.php M includes/storage/SQLStore/SMW_DIHandler_String.php M includes/storage/SQLStore/SMW_DIHandler_Time.php M includes/storage/SQLStore/SMW_DIHandler_URI.php M includes/storage/SQLStore/SMW_DIHandler_WikiPage.php M includes/storage/SQLStore/SMW_DataItemHandler.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php 13 files changed, 212 insertions(+), 186 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/57/30357/1 -- To view, visit https://gerrit.wikimedia.org/r/30357 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4907a8bea6d4db60daf64c63b994a7a44784fe1d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Improved debug output - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Improved debug output .. Improved debug output Use wfDebug. The cache utilisation statistics are somewhat interesting and could remain in the code permanently (they need to be called from a hook, e.g. in LocalSettings, otherwise nothing will happen). Change-Id: Id917183cda8ce48a5b63d1406ae5bc3ef6c14dc3 --- M includes/storage/SQLStore/SMW_Sql3SmwIds.php 1 file changed, 12 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/67/30367/1 -- To view, visit https://gerrit.wikimedia.org/r/30367 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id917183cda8ce48a5b63d1406ae5bc3ef6c14dc3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Documentation/style improvements - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Documentation/style improvements .. Documentation/style improvements Note that all files should have an @file comment to show up in the file index of generated documentation. But a comment with @file can not document a class as well. Change-Id: Id7f54d0a89eb3384bc07dcfcbbedba3a2a1c5194 --- M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3Table.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php M includes/storage/SQLStore/SMW_Sql3StubSemanticData.php 9 files changed, 112 insertions(+), 92 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/20/30420/1 -- To view, visit https://gerrit.wikimedia.org/r/30420 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Id7f54d0a89eb3384bc07dcfcbbedba3a2a1c5194 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Improved debug output - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Improved debug output .. Improved debug output Use wfDebug. The cache utilisation statistics are somewhat interesting and could remain in the code permanently (they need to be called from a hook, e.g. in LocalSettings, otherwise nothing will happen). Change-Id: Id917183cda8ce48a5b63d1406ae5bc3ef6c14dc3 --- M includes/storage/SQLStore/SMW_Sql3SmwIds.php 1 file changed, 12 insertions(+), 9 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/30367 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id917183cda8ce48a5b63d1406ae5bc3ef6c14dc3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed I0c98593a that broke parsing with older MWs - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed I0c98593a that broke parsing with older MWs .. Fixed I0c98593a that broke parsing with older MWs Change-Id: Icaa74c2b3be35b1a1fca9f620ae46c9ca8f692cd --- M includes/SMW_ParseData.php 1 file changed, 6 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/27/30427/1 -- To view, visit https://gerrit.wikimedia.org/r/30427 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icaa74c2b3be35b1a1fca9f620ae46c9ca8f692cd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed I0c98593a that broke parsing with older MWs - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed I0c98593a that broke parsing with older MWs .. Fixed I0c98593a that broke parsing with older MWs Change-Id: Icaa74c2b3be35b1a1fca9f620ae46c9ca8f692cd --- M includes/SMW_ParseData.php 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/30427 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icaa74c2b3be35b1a1fca9f620ae46c9ca8f692cd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Support Blob in all places where String works - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Support Blob in all places where String works .. Support Blob in all places where String works This is essential for using SQLStore3 which always returns Blobs, since it does not have any length restrictions on string data. Before this change, some correctly stored property values were ignored (e.g., in unit conversion). Change-Id: Ie52e499d45be612f9ebc3da0961c9d90c61870f8 --- M includes/dataitems/SMW_DI_Blob.php M includes/datavalues/SMW_DV_Import.php M includes/datavalues/SMW_DV_PropertyList.php M includes/datavalues/SMW_DV_Quantity.php M includes/datavalues/SMW_DV_String.php M includes/datavalues/SMW_DataValue.php 6 files changed, 7 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/28/30428/1 -- To view, visit https://gerrit.wikimedia.org/r/30428 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie52e499d45be612f9ebc3da0961c9d90c61870f8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Do not use DISTINCT in vain - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Do not use DISTINCT in vain .. Do not use DISTINCT in vain Propery-value pairs of subjects are DISTINCT by default. Do not ask the DB to ensure this again when reading data. Change-Id: Ib8e3d50e8d4a960f68f8f2124a3528d0f3b4ab20 --- M includes/storage/SQLStore/SMW_SQLStore3_Readers.php 1 file changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/29/30429/1 -- To view, visit https://gerrit.wikimedia.org/r/30429 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib8e3d50e8d4a960f68f8f2124a3528d0f3b4ab20 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Control hash size for blob values - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Control hash size for blob values .. Control hash size for blob values Instead of the max value of 255, only 72 chars are used now before resorting to blobs. This should cover most values while keeping a smaller index. Change-Id: I9e48f396d2c825ccc009c1134bd3c694bdfed499 --- M includes/storage/SQLStore/SMW_DIHandler_String.php 1 file changed, 25 insertions(+), 5 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/30/30430/1 -- To view, visit https://gerrit.wikimedia.org/r/30430 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9e48f396d2c825ccc009c1134bd3c694bdfed499 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] refactor store dependent stuff to be in the relevant store c... - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: refactor store dependent stuff to be in the relevant store class .. refactor store dependent stuff to be in the relevant store class Change-Id: Ife26c19cec26228e7686a6c7ad3797ce2462b767 --- M SemanticMediaWiki.hooks.php M includes/storage/SMW_Store.php M includes/storage/compatSQLStore/SMW_SQLStore2.php 3 files changed, 41 insertions(+), 12 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/29971 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife26c19cec26228e7686a6c7ad3797ce2462b767 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Nischayn22 nischay...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Corrected table name after name change - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Corrected table name after name change .. Corrected table name after name change This fixes a bug observed in the discussion of https://gerrit.wikimedia.org/r/29753 Change-Id: Ia69a0ce7c3b538fcc82f095377b7f2f129f442bc --- M includes/storage/SQLStore/SMW_SQLStore3_Queries.php 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved Mwjames: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/29932 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia69a0ce7c3b538fcc82f095377b7f2f129f442bc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Mwjames jamesin.hongkon...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed reference to outdated table name - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed reference to outdated table name .. Fixed reference to outdated table name Name no longer hardcoded now. Change-Id: I4fbc4eec5009a30a26e2e7338cafaaadbf75a513 --- M includes/storage/SQLStore/SMW_SQLStore3_Queries.php 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved Jeroen De Dauw: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/29340 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4fbc4eec5009a30a26e2e7338cafaaadbf75a513 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed Bug 41344 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed Bug 41344 .. Fixed Bug 41344 Trivial fix to a typo in code introduced earlier. Not worth mentioning in release notes. Change-Id: I53aed88eaedeef9ce9acfb22e8bb99433ec4c188 --- M includes/storage/SQLStore/SMW_Sql3SmwIds.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/56/29756/1 -- To view, visit https://gerrit.wikimedia.org/r/29756 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I53aed88eaedeef9ce9acfb22e8bb99433ec4c188 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed Bug 41344 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed Bug 41344 .. Fixed Bug 41344 Trivial fix to a typo in code introduced earlier. Not worth mentioning in release notes. Update: Fixed fix to actually work. Change-Id: I53aed88eaedeef9ce9acfb22e8bb99433ec4c188 --- M includes/storage/SQLStore/SMW_Sql3SmwIds.php 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/29756 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53aed88eaedeef9ce9acfb22e8bb99433ec4c188 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed some queries that where not using mw db abstraction la... - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed some queries that where not using mw db abstraction layer and failing on any setup with table prefix .. Fixed some queries that where not using mw db abstraction layer and failing on any setup with table prefix Change-Id: Iefb9b8a9d0ce60d706269757861465dbcf8f2d8c --- M includes/storage/SQLStore/SMW_SQLStore3_Writers.php 1 file changed, 38 insertions(+), 7 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved Nikerabbit: Looks good to me, approved Nischayn22: Looks good to me, but someone else must approve -- To view, visit https://gerrit.wikimedia.org/r/29302 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iefb9b8a9d0ce60d706269757861465dbcf8f2d8c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Jeroen De Dauw jeroended...@gmail.com Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Nikerabbit niklas.laxst...@gmail.com Gerrit-Reviewer: Nischayn22 nischay...@gmail.com ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed reference to outdated table name - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed reference to outdated table name .. Fixed reference to outdated table name Name no longer hardcoded now. Change-Id: I4fbc4eec5009a30a26e2e7338cafaaadbf75a513 --- M includes/storage/SQLStore/SMW_SQLStore3_Queries.php 1 file changed, 5 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/40/29340/1 -- To view, visit https://gerrit.wikimedia.org/r/29340 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4fbc4eec5009a30a26e2e7338cafaaadbf75a513 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Simplify code in SQLStore3, unify table names - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Simplify code in SQLStore3, unify table names .. Simplify code in SQLStore3, unify table names * Eliminated many methods related to finding table names * Corrected property table registration * Fixed properties need to be registered with their DB key, not their label now * The names of all tables that are for a fixed property only have changed to be more uniform This change requires the database to be setup and refreshed to work, since tables have changed their names (if using SQLStore3 already, SQLStore2 is not affected). Change-Id: Ifbcec1823ece38fc1e2afbc1a8f4f1273f071a7c --- M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3Table.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_SpecialPageHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php 8 files changed, 115 insertions(+), 165 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/15/28915/1 -- To view, visit https://gerrit.wikimedia.org/r/28915 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifbcec1823ece38fc1e2afbc1a8f4f1273f071a7c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fewer database SELECTs for getting property values - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fewer database SELECTs for getting property values .. Fewer database SELECTs for getting property values Retrieve data more selectively when looking for a concrete property. So far, this was done by restricting to tables based on the property type, but this is no longer ery effective since there are many tables now. The new code will read at most one table for getting the values of one property, as it should be. Change-Id: Ia386578e9acd402cc7f702d758c15e3ed3af9bc3 --- M includes/storage/SQLStore/SMW_SQLStore3_Readers.php 1 file changed, 59 insertions(+), 43 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/21/28921/1 -- To view, visit https://gerrit.wikimedia.org/r/28921 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia386578e9acd402cc7f702d758c15e3ed3af9bc3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fewer database SELECTs for getting property values - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fewer database SELECTs for getting property values .. Fewer database SELECTs for getting property values Retrieve data more selectively when looking for a concrete property. So far, this was done by restricting to tables based on the property type, but this is no longer ery effective since there are many tables now. The new code will read at most one table for getting the values of one property, as it should be. Change-Id: Ia386578e9acd402cc7f702d758c15e3ed3af9bc3 --- M includes/storage/SQLStore/SMW_SQLStore3_Readers.php 1 file changed, 59 insertions(+), 43 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28921 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia386578e9acd402cc7f702d758c15e3ed3af9bc3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Init self::$fixed_prop_tableid before using it - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Init self::$fixed_prop_tableid before using it .. Init self::$fixed_prop_tableid before using it This caused an error in some tests. Change-Id: Iee78e74ffdbe9caabb0ba2d34b8bd399c2ce76a7 --- M includes/storage/SQLStore/SMW_SQLStore3.php 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/29/28929/1 -- To view, visit https://gerrit.wikimedia.org/r/28929 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iee78e74ffdbe9caabb0ba2d34b8bd399c2ce76a7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Init self::$fixed_prop_tableid before using it - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Init self::$fixed_prop_tableid before using it .. Init self::$fixed_prop_tableid before using it This caused an error in some tests. Change-Id: Iee78e74ffdbe9caabb0ba2d34b8bd399c2ce76a7 --- M includes/storage/SQLStore/SMW_SQLStore3.php 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28929 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iee78e74ffdbe9caabb0ba2d34b8bd399c2ce76a7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use stored hashes to avoid additional SELECTs - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Use stored hashes to avoid additional SELECTs .. Use stored hashes to avoid additional SELECTs This change significantly reduces the number of SELECT queries issued for executing getSemanticData(). Change-Id: Ieaff4dd3e16fba774d6152b7d8dac3ffa5fea99c --- M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php 3 files changed, 72 insertions(+), 58 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/33/28933/1 -- To view, visit https://gerrit.wikimedia.org/r/28933 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieaff4dd3e16fba774d6152b7d8dac3ffa5fea99c Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Added some @since and @param tags - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Added some @since and @param tags .. Added some @since and @param tags Change-Id: I3b93a842b4969d0280d3dcb151087b780c6c6d1a --- M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php 2 files changed, 46 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/47/28947/1 -- To view, visit https://gerrit.wikimedia.org/r/28947 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3b93a842b4969d0280d3dcb151087b780c6c6d1a Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Caching mechanism for property table hashes - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Caching mechanism for property table hashes .. Caching mechanism for property table hashes Property hashes are optionally read and cached when reading the smw_ids table anyway, but only if requested by the caller. The cache is kept very small (1) and is supposed to be used in another call of getPropertyTableHashes() that most likely follows very soon after. This reduces the number of SELECT for getting property hashes significantly, since they can usually be combined with another SELECT immediately before them. In local tests, the number of reads to smw_ids went down by about 40% when refreshing the data. Change-Id: I92c6ecf00811db52f920c73904402da7cc1cdaad --- M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php M includes/storage/SQLStore/SMW_Sql3SmwIds.php 3 files changed, 118 insertions(+), 25 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/48/28948/1 -- To view, visit https://gerrit.wikimedia.org/r/28948 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I92c6ecf00811db52f920c73904402da7cc1cdaad Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Improvements for SQLStore3 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Improvements for SQLStore3 .. Improvements for SQLStore3 Partial refactoring (more to come): * Code cleanup and simplification, esp in SMW_SQLStore3_Queries.php * Removed unused tables * Removed unused DI type handler * Unified database column labels for property tables * Fixed hashing of Strings (store whole hash, not just one char of it) * Changed handling of DIWikiPage in database: do not point to smw_ids table, do not use substr to find out if join with smw_ids is needed All data must be refreshed after this change when using Store3 (or it will no tbe shown). Change-Id: I4ef66006ff08108ceb71a08ff36293a6ba5b4624 --- M includes/storage/SQLStore/SMW_DIHandler_Bool.php M includes/storage/SQLStore/SMW_DIHandler_GeoCoord.php M includes/storage/SQLStore/SMW_DIHandler_Number.php D includes/storage/SQLStore/SMW_DIHandler_Property.php M includes/storage/SQLStore/SMW_DIHandler_String.php M includes/storage/SQLStore/SMW_DIHandler_Time.php M includes/storage/SQLStore/SMW_DIHandler_URI.php M includes/storage/SQLStore/SMW_DIHandler_WikiPage.php M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php 11 files changed, 325 insertions(+), 392 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/31/28831/1 -- To view, visit https://gerrit.wikimedia.org/r/28831 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ef66006ff08108ceb71a08ff36293a6ba5b4624 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Improvements for SQLStore3 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Improvements for SQLStore3 .. Improvements for SQLStore3 Partial refactoring (more to come): * Code cleanup and simplification, esp in SMW_SQLStore3_Queries.php * Removed unused tables * Removed unused DI type handler * Unified database column labels for property tables * Fixed hashing of Strings (store whole hash, not just one char of it) * Changed handling of DIWikiPage in database: do not point to smw_ids table, do not use substr to find out if join with smw_ids is needed All data must be refreshed after this change when using Store3 (or it will no tbe shown). Change-Id: I4ef66006ff08108ceb71a08ff36293a6ba5b4624 --- M includes/storage/SQLStore/SMW_DIHandler_Bool.php M includes/storage/SQLStore/SMW_DIHandler_GeoCoord.php M includes/storage/SQLStore/SMW_DIHandler_Number.php D includes/storage/SQLStore/SMW_DIHandler_Property.php M includes/storage/SQLStore/SMW_DIHandler_String.php M includes/storage/SQLStore/SMW_DIHandler_Time.php M includes/storage/SQLStore/SMW_DIHandler_URI.php M includes/storage/SQLStore/SMW_DIHandler_WikiPage.php M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php 11 files changed, 325 insertions(+), 392 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28831 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ef66006ff08108ceb71a08ff36293a6ba5b4624 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Do not index serialisation strings for numbers - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Do not index serialisation strings for numbers .. Do not index serialisation strings for numbers No string matching on numerals, one index less. Change-Id: I24a2038f94878d1dfa66d1298f0e9c7b8a9d2a60 --- M includes/storage/SQLStore/SMW_DIHandler_Number.php M includes/storage/SQLStore/SMW_SQLStore3.php 2 files changed, 5 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/60/28860/1 -- To view, visit https://gerrit.wikimedia.org/r/28860 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I24a2038f94878d1dfa66d1298f0e9c7b8a9d2a60 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Do not index serialisation strings for numbers - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Do not index serialisation strings for numbers .. Do not index serialisation strings for numbers No string matching on numerals, one index less. Change-Id: I24a2038f94878d1dfa66d1298f0e9c7b8a9d2a60 --- M includes/storage/SQLStore/SMW_DIHandler_Number.php M includes/storage/SQLStore/SMW_SQLStore3.php 2 files changed, 5 insertions(+), 6 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28860 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24a2038f94878d1dfa66d1298f0e9c7b8a9d2a60 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Improved Time handling - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Improved Time handling .. Improved Time handling * Fixed Bug 41126 by storing dates in full serialised format, including calendar model * New serialised format is also easier to parse and does not rely on deprecated code. * Added new output formats Jl and Gr for time data, so that the desired display calendar model can be set for query results * Simplified SQLStore3 table structure for SMWDITime: one index less, no more string matching (was not meaningful anyway, especially not with the new serialisation format) Change-Id: Ic017f0a3f0f48554b12b585a299c07861c19c511 --- M RELEASE-NOTES-1.8 M includes/dataitems/SMW_DI_Time.php M includes/datavalues/SMW_DV_Time.php M includes/storage/SQLStore/SMW_DIHandler_String.php M includes/storage/SQLStore/SMW_DIHandler_Time.php M includes/storage/SQLStore/SMW_DataItemHandler.php 6 files changed, 92 insertions(+), 86 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/66/28666/1 -- To view, visit https://gerrit.wikimedia.org/r/28666 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic017f0a3f0f48554b12b585a299c07861c19c511 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Improved Time handling - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Improved Time handling .. Improved Time handling * Fixed Bug 41126 by storing dates in full serialised format, including calendar model * New serialised format is also easier to parse and does not rely on deprecated code. * Added new output formats Jl and Gr for time data, so that the desired display calendar model can be set for query results * Simplified SQLStore3 table structure for SMWDITime: one index less, no more string matching (was not meaningful anyway, especially not with the new serialisation format) Change-Id: Ic017f0a3f0f48554b12b585a299c07861c19c511 --- M RELEASE-NOTES-1.8 M includes/dataitems/SMW_DI_Time.php M includes/datavalues/SMW_DV_Time.php M includes/storage/SQLStore/SMW_DIHandler_String.php M includes/storage/SQLStore/SMW_DIHandler_Time.php M includes/storage/SQLStore/SMW_DataItemHandler.php 6 files changed, 92 insertions(+), 86 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28666 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic017f0a3f0f48554b12b585a299c07861c19c511 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Implement consequences of new Container handling - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Implement consequences of new Container handling .. Implement consequences of new Container handling Container DIs have recently become virtual -- they are never stored as such but only used to encapsulate user input that leads to complex data. Various conseqeunces of this design have now been implemented: * Record properties are declared as having di type wikipage * SQLStore3 has no more special code for storing containers, no extra table either * SMWRecordValue can be created from SMWDIWikiPage objects (but also continues ot work with SMWDIContainer objects) The change should not lead to new problems in SQLStore2 either, although it still has more code for Containers (which is simply not used now). Containers remain relevant for querying the stores and they will continue to be supported there. Change-Id: Ifd159d353a0fcd928567d5c2d09df4da5168d978 --- M includes/SMW_DataValueFactory.php M includes/SMW_Setup.php M includes/datavalues/SMW_DV_Record.php D includes/storage/SQLStore/SMW_DIHandler_Container.php M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php 6 files changed, 41 insertions(+), 118 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/71/28671/1 -- To view, visit https://gerrit.wikimedia.org/r/28671 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifd159d353a0fcd928567d5c2d09df4da5168d978 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Implement consequences of new Container handling - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Implement consequences of new Container handling .. Implement consequences of new Container handling Container DIs have recently become virtual -- they are never stored as such but only used to encapsulate user input that leads to complex data. Various conseqeunces of this design have now been implemented: * Record properties are declared as having di type wikipage * SQLStore3 has no more special code for storing containers, no extra table either * SMWRecordValue can be created from SMWDIWikiPage objects (but also continues ot work with SMWDIContainer objects) The change should not lead to new problems in SQLStore2 either, although it still has more code for Containers (which is simply not used now). Containers remain relevant for querying the stores and they will continue to be supported there. Change-Id: Ifd159d353a0fcd928567d5c2d09df4da5168d978 --- M includes/SMW_DataValueFactory.php M includes/SMW_Setup.php M includes/datavalues/SMW_DV_Record.php D includes/storage/SQLStore/SMW_DIHandler_Container.php M includes/storage/SQLStore/SMW_SQLStore3.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php 6 files changed, 41 insertions(+), 118 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28671 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd159d353a0fcd928567d5c2d09df4da5168d978 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Check validity before accessing member object - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Check validity before accessing member object .. Check validity before accessing member object This fixes a rare error caused by accessing a null object. Callers should check this, but if they don't there should still not be a PHP error. Change-Id: I38956c52e3b7f68d9b2979d48980c3cfac3bfa35 --- M includes/datavalues/SMW_DV_String.php 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/75/28675/1 -- To view, visit https://gerrit.wikimedia.org/r/28675 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I38956c52e3b7f68d9b2979d48980c3cfac3bfa35 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Check validity before accessing member object - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Check validity before accessing member object .. Check validity before accessing member object This fixes a rare error caused by accessing a null object. Callers should check this, but if they don't there should still not be a PHP error. Change-Id: I38956c52e3b7f68d9b2979d48980c3cfac3bfa35 --- M includes/datavalues/SMW_DV_String.php 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28675 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38956c52e3b7f68d9b2979d48980c3cfac3bfa35 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Update Store3 layout for geo coordinates - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Update Store3 layout for geo coordinates .. Update Store3 layout for geo coordinates No longer store altitude in float column (not used); store serialisation as text (float not suitable for storing data); drop label field (no text search on coordinate serialisations) Change-Id: Idafed5a04e3590fad7e9246182c6bbb14b778095 --- M includes/storage/SQLStore/SMW_DIHandler_GeoCoord.php 1 file changed, 26 insertions(+), 32 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/88/28688/1 -- To view, visit https://gerrit.wikimedia.org/r/28688 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idafed5a04e3590fad7e9246182c6bbb14b778095 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 37575 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 37575 .. Fix Bug 37575 Applied patch submitted by Francesco Panico and Andre Klapper: * Correct insert syntax for empty default graph. * Set mime type and content encoding for update and query requests. Change-Id: I06aaf9dc5a20eb86e124878f7a149d2f5c9be0c3 --- M includes/sparql/SMW_SparqlDatabase.php 1 file changed, 6 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/69/28369/1 -- To view, visit https://gerrit.wikimedia.org/r/28369 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I06aaf9dc5a20eb86e124878f7a149d2f5c9be0c3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 37575 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix Bug 37575 .. Fix Bug 37575 Applied patch submitted by Francesco Panico and Andre Klapper: * Correct insert syntax for empty default graph. * Set mime type and content encoding for update and query requests. Change-Id: I06aaf9dc5a20eb86e124878f7a149d2f5c9be0c3 --- M includes/sparql/SMW_SparqlDatabase.php 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28369 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06aaf9dc5a20eb86e124878f7a149d2f5c9be0c3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 38136 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 38136 .. Fix Bug 38136 If a delay is given, it is now applied after every page, not only after batches of 100. Change-Id: I267361e67a6790f694b5be95f2067a58f612f073 --- M maintenance/SMW_refreshData.php 1 file changed, 10 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/70/28370/1 -- To view, visit https://gerrit.wikimedia.org/r/28370 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I267361e67a6790f694b5be95f2067a58f612f073 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 38136 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix Bug 38136 .. Fix Bug 38136 If a delay is given, it is now applied after every page, not only after batches of 100. Change-Id: I267361e67a6790f694b5be95f2067a58f612f073 --- M maintenance/SMW_refreshData.php 1 file changed, 10 insertions(+), 8 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28370 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I267361e67a6790f694b5be95f2067a58f612f073 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 38489 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 38489 .. Fix Bug 38489 Detect the specific problem reported for Bug 38489 and also check for similar exceptions that might happen due to problems we do not foresee. Change-Id: I1640938e21054e37d9ceb647ac08f5b32eb3cd39 --- M includes/SMW_QueryProcessor.php 1 file changed, 9 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/76/28376/1 -- To view, visit https://gerrit.wikimedia.org/r/28376 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1640938e21054e37d9ceb647ac08f5b32eb3cd39 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 38489 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix Bug 38489 .. Fix Bug 38489 Detect the specific problem reported for Bug 38489 and also check for similar exceptions that might happen due to problems we do not foresee. Change-Id: I1640938e21054e37d9ceb647ac08f5b32eb3cd39 --- M includes/SMW_QueryProcessor.php 1 file changed, 9 insertions(+), 2 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28376 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1640938e21054e37d9ceb647ac08f5b32eb3cd39 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 39392 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 39392 .. Fix Bug 39392 When returning unlinked URLs in wikitext, additional escaping is needed to prevent MediaWiki from turning them into hyperlinks anyway. Change-Id: I948635ffb6df1577c4dabf7b10b668975432fb4f --- M includes/datavalues/SMW_DV_URI.php 1 file changed, 15 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/93/28393/1 -- To view, visit https://gerrit.wikimedia.org/r/28393 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I948635ffb6df1577c4dabf7b10b668975432fb4f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 39392 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix Bug 39392 .. Fix Bug 39392 When returning unlinked URLs in wikitext, additional escaping is needed to prevent MediaWiki from turning them into hyperlinks anyway. Change-Id: I948635ffb6df1577c4dabf7b10b668975432fb4f --- M includes/datavalues/SMW_DV_URI.php 1 file changed, 15 insertions(+), 2 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28393 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I948635ffb6df1577c4dabf7b10b668975432fb4f Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Use md5() instead of hash_init() et al. - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Use md5() instead of hash_init() et al. .. Use md5() instead of hash_init() et al. This fixes Bug 38185. The hash function has also been changed to work with the new subobject handling. Change-Id: I7a01046ad927166ca84f0f23c88941448f76cfb9 --- M includes/SMW_SemanticData.php 1 file changed, 21 insertions(+), 8 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28399 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a01046ad927166ca84f0f23c88941448f76cfb9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 37065 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fix Bug 37065 .. Fix Bug 37065 Prepend : when serialising namespace queries for NS_CATEGORY. Without this, the serialised query cannot be parsed properly, since it is confused with a Category query. Change-Id: Iaaef1851e78ba880d70eec3179148603ebd8a678 --- M includes/storage/SMW_Description.php 1 file changed, 3 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/27/28427/1 -- To view, visit https://gerrit.wikimedia.org/r/28427 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iaaef1851e78ba880d70eec3179148603ebd8a678 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fix Bug 37065 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fix Bug 37065 .. Fix Bug 37065 Prepend : when serialising namespace queries for NS_CATEGORY. Without this, the serialised query cannot be parsed properly, since it is confused with a Category query. Change-Id: Iaaef1851e78ba880d70eec3179148603ebd8a678 --- M includes/storage/SMW_Description.php 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28427 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaaef1851e78ba880d70eec3179148603ebd8a678 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed use of SQL2 constants in SQLStore3 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed use of SQL2 constants in SQLStore3 .. Fixed use of SQL2 constants in SQLStore3 Most of the constants were just defined under the old name, which could potentially lead to re-defined constants if both files get loaded. In one case, the constant had been renamed in the definition but not in the code, leading to a PHP warning in certain cases. Change-Id: I032b965a3d301ca886a2507aec7aee4089afbffb --- M includes/storage/SQLStore/SMW_SQLStore3_Queries.php 1 file changed, 30 insertions(+), 30 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/35/28435/1 -- To view, visit https://gerrit.wikimedia.org/r/28435 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I032b965a3d301ca886a2507aec7aee4089afbffb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed use of SQL2 constants in SQLStore3 - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed use of SQL2 constants in SQLStore3 .. Fixed use of SQL2 constants in SQLStore3 Most of the constants were just defined under the old name, which could potentially lead to re-defined constants if both files get loaded. In one case, the constant had been renamed in the definition but not in the code, leading to a PHP warning in certain cases. Change-Id: I032b965a3d301ca886a2507aec7aee4089afbffb --- M includes/storage/SQLStore/SMW_SQLStore3_Queries.php 1 file changed, 30 insertions(+), 30 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28435 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I032b965a3d301ca886a2507aec7aee4089afbffb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed capitalisation in function call (minor) - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Fixed capitalisation in function call (minor) .. Fixed capitalisation in function call (minor) Change-Id: If61d9272f522250d592f50022843fd6d36497fcc --- M includes/datavalues/SMW_DV_Time.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/41/28441/1 -- To view, visit https://gerrit.wikimedia.org/r/28441 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If61d9272f522250d592f50022843fd6d36497fcc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Fixed capitalisation in function call (minor) - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Fixed capitalisation in function call (minor) .. Fixed capitalisation in function call (minor) Change-Id: If61d9272f522250d592f50022843fd6d36497fcc --- M includes/datavalues/SMW_DV_Time.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28441 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: If61d9272f522250d592f50022843fd6d36497fcc Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Small fix in debugging method. - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Small fix in debugging method. .. Small fix in debugging method. Change-Id: I6c5904347ee6f81c6e425abd6272965fb16a94d9 --- M includes/storage/SQLStore/SMW_Sql3SmwIds.php 1 file changed, 10 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/22/28222/1 -- To view, visit https://gerrit.wikimedia.org/r/28222 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6c5904347ee6f81c6e425abd6272965fb16a94d9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Correctly handle nested subdata - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Correctly handle nested subdata .. Correctly handle nested subdata The new implementation flattens all nested subdata as it gets added and ensures that no new subdata is added to SMWSemanticData objects that have subdata already. This fixes some problems with nested subdata (mainly created by using Record properties within #subobject). Change-Id: Icd4d4132078930a7c2024e1e6d6a6596bc4424fa --- M includes/SMW_SemanticData.php 1 file changed, 24 insertions(+), 8 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/23/28223/1 -- To view, visit https://gerrit.wikimedia.org/r/28223 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icd4d4132078930a7c2024e1e6d6a6596bc4424fa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Small fix in debugging method. - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Small fix in debugging method. .. Small fix in debugging method. Change-Id: I6c5904347ee6f81c6e425abd6272965fb16a94d9 --- M includes/storage/SQLStore/SMW_Sql3SmwIds.php 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28222 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c5904347ee6f81c6e425abd6272965fb16a94d9 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Correctly handle nested subdata - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Correctly handle nested subdata .. Correctly handle nested subdata The new implementation flattens all nested subdata as it gets added and ensures that no new subdata is added to SMWSemanticData objects that have subdata already. This fixes some problems with nested subdata (mainly created by using Record properties within #subobject). Change-Id: Icd4d4132078930a7c2024e1e6d6a6596bc4424fa --- M includes/SMW_SemanticData.php 1 file changed, 24 insertions(+), 8 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28223 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd4d4132078930a7c2024e1e6d6a6596bc4424fa Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Tiny fix in debugging method - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Tiny fix in debugging method .. Tiny fix in debugging method Change-Id: Ia6a9034bf97cca8c23769a14ed8bbc8075c761bd --- M includes/storage/SQLStore/SMW_Sql3SmwIds.php 1 file changed, 2 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/87/28287/1 -- To view, visit https://gerrit.wikimedia.org/r/28287 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia6a9034bf97cca8c23769a14ed8bbc8075c761bd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Tiny fix in debugging method - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Tiny fix in debugging method .. Tiny fix in debugging method Change-Id: Ia6a9034bf97cca8c23769a14ed8bbc8075c761bd --- M includes/storage/SQLStore/SMW_Sql3SmwIds.php 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28287 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6a9034bf97cca8c23769a14ed8bbc8075c761bd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Limit support for outdated Type: namespace prefix - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Limit support for outdated Type: namespace prefix .. Limit support for outdated Type: namespace prefix Types with prefix Type: (or equivalent in other languages) are now only supported when $smwgHistoricTypeNamespace == true. They would not work without this anyway, but the error was confusing. Change-Id: I7a4cd910eaf710739edfb2ba24d5fcfc473951f4 --- M includes/datavalues/SMW_DV_Types.php 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/54/28054/1 -- To view, visit https://gerrit.wikimedia.org/r/28054 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7a4cd910eaf710739edfb2ba24d5fcfc473951f4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Rewritten access/caching layer for smw_ids - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has uploaded a new change for review. Change subject: Rewritten access/caching layer for smw_ids .. Rewritten access/caching layer for smw_ids The new implementation significantly reduces the amount of SQL queries that need to be issues to retrieve IDs and their sortkeys. Some smaller issues have been fixed while restructuring the related code. Change-Id: I8216857311dccf9f8a123596fa1fabd9bc14b6d3 --- M includes/SMW_Setup.php M includes/storage/SQLStore/SMW_DIHandler_Container.php M includes/storage/SQLStore/SMW_DIHandler_WikiPage.php M includes/storage/SQLStore/SMW_SQLStore3.php D includes/storage/SQLStore/SMW_SQLStore3IdCache.php M includes/storage/SQLStore/SMW_SQLStore3_Queries.php M includes/storage/SQLStore/SMW_SQLStore3_Readers.php M includes/storage/SQLStore/SMW_SQLStore3_SetupHandlers.php M includes/storage/SQLStore/SMW_SQLStore3_Writers.php A includes/storage/SQLStore/SMW_Sql3SmwIds.php 10 files changed, 575 insertions(+), 435 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/SemanticMediaWiki refs/changes/57/28057/1 -- To view, visit https://gerrit.wikimedia.org/r/28057 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8216857311dccf9f8a123596fa1fabd9bc14b6d3 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Limit support for outdated Type: namespace prefix - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Limit support for outdated Type: namespace prefix .. Limit support for outdated Type: namespace prefix Types with prefix Type: (or equivalent in other languages) are now only supported when $smwgHistoricTypeNamespace == true. They would not work without this anyway, but the error was confusing. Change-Id: I7a4cd910eaf710739edfb2ba24d5fcfc473951f4 --- M includes/datavalues/SMW_DV_Types.php 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28054 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a4cd910eaf710739edfb2ba24d5fcfc473951f4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
[MediaWiki-commits] [Gerrit] Corrected handling of error DIs and DVs - change (mediawiki...SemanticMediaWiki[master])
Markus Kroetzsch has submitted this change and it was merged. Change subject: Corrected handling of error DIs and DVs .. Corrected handling of error DIs and DVs Error were wrongly assigned the String DI type in some contexts, although they only generate DIs of type error. Reporting error as a type should lead to earlier failures in case any code tries to use an error like a value somewhere. Change-Id: Ic78a9f86a9dc9a4fb27e10e537d9890cf00133f8 --- M includes/SMW_DataValueFactory.php M includes/datavalues/SMW_DV_Error.php 2 files changed, 5 insertions(+), 1 deletion(-) Approvals: Markus Kroetzsch: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/28056 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic78a9f86a9dc9a4fb27e10e537d9890cf00133f8 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/SemanticMediaWiki Gerrit-Branch: master Gerrit-Owner: Markus Kroetzsch mar...@semantic-mediawiki.org Gerrit-Reviewer: Markus Kroetzsch mar...@semantic-mediawiki.org ___ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
