D27458: Set a better position for Krunner in wayland

[Tranter Madi]

trmdi updated this revision to Diff 75883.
trmdi added a comment.


  Improve code style

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27458?vs=75879=75883

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27458

AFFECTED FILES
  krunner/view.cpp
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27457: Move kcminit_startup and kded to plasma-session

[Luca Beltrame]

lbeltrame added a comment.


  This completely breaks startup in my system and in openQA:
  
  https://openqa.opensuse.org/tests/1177118#step/finish_desktop/6
  
  (Notice that there is *no* desktop loaded).
  
  Basically many programs that start early complain that the Qt plugin can't be 
found because they can't connect to the display (started too early?):
  
feb 17 23:38:40 leon kwalletd5[1661]: qt.qpa.xcb: could not connect to 
display
[...]
feb 17 23:38:40 leon kwalletd5[1661]: qt.qpa.plugin: Could not load the Qt 
platform plugin "xcb" in "" even though it was found.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27457

To: apol, #plasma, davidedmundson
Cc: lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

Re: 2 kirigami fixes for a point release

[Luca Beltrame]

In data martedì 18 febbraio 2020 04:03:05 CET, Nate Graham ha scritto:

> think KDE software should be presented to users. Basically, we
> acknowledge that Neon is already an actual OS--the "KDE OS"--and we

Please don't suggest such downstream-hostile solutions, in particular because 
this failing is entirely upstream. We have already plenty in FOSS, I don't 
want KDE to be yet another community that "adopts" them.

"We messed up so let's make things our way" is not an acceptable approach.

-- 
Luca Beltrame - KDE Forums team
GPG key ID: A29D259B

signature.asc
Description: This is a digitally signed message part.

D27199: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  Thanks. Done: https://bugs.kde.org/show_bug.cgi?id=417816

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  LGTM. #plasma  folks?

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27422: [KCM]Update Device item layout based on applet

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM. #plasma  folks?
  
  In D27422#612797 , @gvgeo wrote:
  
  > Remove PlasmaComponents.
  >
  > So.. why all these different distinctions exist?
  
  
  History.
  
  The original PlasmaComponents was created first, after QML was invented, but 
before QtQuick. Then QtQuick was invented, and PlasmaComponents was re-done to 
be based on it and called "PlasmaComponents2". Then QtQuick2 was invented, and 
"PlasmaComponents3" was created with the expectation to porting to that.
  
  In the meantime, people started to want to use QML for non-Plasma user 
interfaces. So a QQC2 desktop style bridge was created, hence the 
qqc2-desktop-style framework. However people were not satisfied with the 
primitive state of QQC2 components so we started to make higher-level versions 
(e.g. drawers, pages with toolbars and navigation) and called it Kirigami.
  
  I expect in the future that PlasmaComponents (all versions) will go away, and 
if we want to retain some plasma-specific styling, that will be done in a 
different way that does not require a separate component library. See T11558 
.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  kcmports2

REVISION DETAIL
  https://phabricator.kde.org/D27422

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27282: [Applet]Correct raise max volume functions for mic

[Nathaniel Graham]

ngraham added a comment.


  Looks like it.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  mic (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27282

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27282: [Applet]Correct raise max volume functions for mic

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:06e9e3eebf18: [Applet]Correct raise max volume functions 
for mic (authored by gvgeo, committed by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27282?vs=75355=75882

REVISION DETAIL
  https://phabricator.kde.org/D27282

AFFECTED FILES
  applet/contents/ui/main.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Jan Grulich]

jgrulich added a comment.


  In D27199#613246 , @ngraham wrote:
  
  > In D27199#612689 , @jgrulich 
wrote:
  >
  > > This is probably not related to the UI, it might be issue in the 
internals. Can you open a bug for it? Ideally if you can restart plasmashell 
and enable plasma-nm debug
  >
  >
  > Will do. How do I do enable plasma-nm debug?
  
  
  Use export QT_LOGGING_RULES=plasma-nm*.debug=true
  
  More details: https://techbase.kde.org/Projects/Solid/Plasma-nm

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27205: [Applet]Always get valid device and stream name

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:830bded4d30b: [Applet]Always get valid device and stream 
name (authored by gvgeo, committed by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27205?vs=75176=75881

REVISION DETAIL
  https://phabricator.kde.org/D27205

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27469: Made a new variable called 'baseSize' for use by both itemSize value possibilities

[Nathaniel Graham]

ngraham added a comment.


  Seems like this was created by accident. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27469

To: The-Feren-OS-Dev
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26660: [Applets/Task Manager] Fix and improve behavior tab layouts

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c32b5a85cae6: [Applets/Task Manager] Fix and improve 
behavior tab layouts (authored by gvgeo, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26660?vs=73569=75880

REVISION DETAIL
  https://phabricator.kde.org/D26660

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ConfigBehavior.qml

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27458: Set a better position for Krunner in wayland

[Tranter Madi]

trmdi updated this revision to Diff 75879.
trmdi added a comment.


  Use asyncCall

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27458?vs=75828=75879

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27458

AFFECTED FILES
  krunner/view.cpp
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27453: [Applet]Update toolbar's checkbox spacing

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:88b8ce5e50b7: [Applet]Update toolbars checkbox 
spacing (authored by gvgeo, committed by ngraham).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27453?vs=75815=75878

REVISION DETAIL
  https://phabricator.kde.org/D27453

AFFECTED FILES
  applet/contents/ui/SwitchButton.qml

To: gvgeo, #plasma, #vdg, jgrulich, ngraham
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27391: [Applet]Fix dimensions of traffic Monitor

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:4ca1e7e34fd6: [Applet]Fix dimensions of traffic Monitor 
(authored by gvgeo, committed by ngraham).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27391?vs=75832=75877

REVISION DETAIL
  https://phabricator.kde.org/D27391

AFFECTED FILES
  applet/contents/ui/TrafficMonitor.qml

To: gvgeo, #plasma, #vdg, jgrulich, ngraham
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27391: [Applet]Fix dimensions of traffic Monitor

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  LGTM!

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  monitor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27391

To: gvgeo, #plasma, #vdg, jgrulich, ngraham
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  In D27199#612689 , @jgrulich wrote:
  
  > This is probably not related to the UI, it might be issue in the internals. 
Can you open a bug for it? Ideally if you can restart plasmashell and enable 
plasma-nm debug
  
  
  Will do. How do I do enable plasma-nm debug?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27199

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27393: [Applet]Fix details layout.

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:2efaecee8874: [Applet]Fix details layout. (authored by 
gvgeo, committed by ngraham).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27393?vs=75769=75876

REVISION DETAIL
  https://phabricator.kde.org/D27393

AFFECTED FILES
  applet/contents/ui/DetailsText.qml

To: gvgeo, #plasma, #vdg, jgrulich, ngraham
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27392: [Applet]Add info messages.

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:387609d10ac7: [Applet]Add info messages. (authored by 
gvgeo, committed by ngraham).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27392?vs=75721=75875

REVISION DETAIL
  https://phabricator.kde.org/D27392

AFFECTED FILES
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml

To: gvgeo, #plasma, #vdg, jgrulich, ngraham
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27424: Add missing cursors for Chromium-based apps

[Nathaniel Graham]

ngraham added a comment.


  Landed for Plasma 5.18.1! Very nice patch. May it be the first of many! :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27424

To: guilhermesilva, #breeze, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27424: Add missing cursors for Chromium-based apps

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:3944c5f74d04: Add missing cursors for Chromium-based apps 
(authored by guilhermesilva, committed by ngraham).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27424?vs=75748=75874

REVISION DETAIL
  https://phabricator.kde.org/D27424

AFFECTED FILES
  cursors/Breeze/Breeze/cursors/grab
  cursors/Breeze/Breeze/cursors/grabbing
  cursors/Breeze/src/cursorList
  cursors/Breeze_Snow/Breeze_Snow/cursors/grab
  cursors/Breeze_Snow/Breeze_Snow/cursors/grabbing
  cursors/Breeze_Snow/src/cursorList

To: guilhermesilva, #breeze, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: 2 kirigami fixes for a point release

[Nate Graham]

On 2020-02-16 14:43, Albert Astals Cid wrote:

Maybe i explain myself wrongly, i'm not blaming distros at all.

They made a decision, we/I may agree with them or not, that's *my/our* problem, 
what I was disagreeing is to us having to do extra work because someone elses 
(the distros) decision.


We already do this: it's called the Plasma LTS product. :-) It's been 
specifically created to cater to various distros' desires for an 
extended-support product they can ship to users of their own LTS releases.


But yes, I can also agree with more tests, better stability, moving to 
GitLab so tests are run before merging, etc. I think we can all agree 
with that.


However all the autotests in the world will not resolve the fundamental 
incompatibility between the Plasma LTS product, which is built around 
the release model of extended, ongoing bugfix releases, and Frameworks, 
which is built around a rolling release model with no bugfix releases at 
all.


If we don't want to change the incompatible way that Frameworks plugs 
into an LTS Plasma release, and we think our opinions regarding how a 
distro ought to ship software are valid, then I think it's time for us 
to take the lead and produce a real reference distro that shows how *we* 
think KDE software should be presented to users. Basically, we 
acknowledge that Neon is already an actual OS--the "KDE OS"--and we 
treat is as such, explicitly advertising it as a fully supported OS 
suitable for users to install and vendors to ship hardware with (as in 
fact Slimbook already does!). See also https://phabricator.kde.org/T12707.


If we don't want to be so opinionated regarding how software should be 
released--perhaps out of fear of alienating sponsors that produce LTS 
distros, for example--then maybe it's time to swallow our opinions, 
respect the way that those distro partners currently ship software even 
if we disagree with it, and adjust Frameworks to better support the 
needs of their LTS releases.



Nate

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> main.qml:44
>  property bool vertical: plasmoid.formFactor === PlasmaCore.Types.Vertical
> -readonly property int itemSize: 
> units.roundToIconSize(Math.min(Math.min(width, height), 
> units.iconSizes[iconSizes[Math.min(iconSizes.length-1, iconSize)]]))
> +readonly property int baseSize: 
> units.roundToIconSize(Math.min(Math.min(width, height), 
> units.iconSizes[iconSizes[Math.min(iconSizes.length-1, iconSize)]]))
> +readonly property int itemSize: {

this doesn't need to be a property; just make it a variable (`var baseSize = 
...`) inside the new inline function itself.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27465

To: The-Feren-OS-Dev, ngraham, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75873.
The-Feren-OS-Dev added a comment.


  You gotta love arc/git sometimes...

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75872=75873

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75872.
The-Feren-OS-Dev added a comment.


  Arcanist please

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75871=75872

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75871.
The-Feren-OS-Dev added a comment.


  Hopefully fixed the diff again

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75870=75871

BRANCH
  D27466 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27466: Increase the size of system tray icon hitboxes on the System Tray Plasmoid

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75870.
The-Feren-OS-Dev added a comment.


  Updated diff to be in line with parent patch

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27466?vs=75864=75870

BRANCH
  arcpatch-D27465_1

REVISION DETAIL
  https://phabricator.kde.org/D27466

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75869.
The-Feren-OS-Dev added a comment.


  Tidied up code a bit and introduced new baseSize variable  - Slightly 
increase system tray icon hitboxes in Non Tablet Mode Plasma

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27465?vs=75863=75869

BRANCH
  D27465 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, ngraham, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27469: Made a new variable called 'baseSize' for use by both itemSize value possibilities

[Dominic Hayes]

The-Feren-OS-Dev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
The-Feren-OS-Dev requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  D27465 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27469

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> main.qml:47
> +// Set the tray items' clickable areas on the panel to be bigger 
> than normal to allow for easier touchability
> +return units.roundToIconSize(Math.min(Math.min(width, height), 
> units.iconSizes[iconSizes[Math.min(iconSizes.length-1, iconSize)]])) + 
> units.smallSpacing;
> +} else {

Rather than repeating this long calculation twice, assign it to a variable 
called `baseSize` or something and then vary it in the return statements:

  if (Kirigami.Settings.tabletMode) {
  return baseSize + units.smallSpacing;
  } else {
  return baseSize;
  }

Also keep in mind that adding `units.smallSpacing` once will result in half 
that value amount being added to all sides. If you want to add 
`units.smallSpacing` to all sides, you'll need to add `units.smallSpacing * 2`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27465

To: The-Feren-OS-Dev, ngraham, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  ...and now the split is complete.
  https://phabricator.kde.org/D27466

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27467: make sure ifa_addr isn't null

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the manpage:
  
The ifa_addr field points to a structure containing the interface
address.  (The sa_family subfield should be consulted to determine
the format of the address structure.)  This field may contain a null
pointer.
  
  why that exactly happens I do not know in absence of more debug info.
  I expect it's something to do with an interface being up but not quite
  somehow. I utterly failed to simulate this though :|
  because of that I do not know if such a device has any use being listed,
  and I am adding some possibly relevant debug output in the hopes of
  maybe getting some data reported.
  if these devices still turn out useful, the MyNIC construction needs
  partially moving before the ifa_addr check.
  
  BUG: 417798
  FIXED-IN: 5.18.1

TEST PLAN
  hoping for the best!

REPOSITORY
  R102 KInfoCenter

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27467

AFFECTED FILES
  Modules/nics/nic.cpp

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Make the icon hitboxes for the System Tray Plasmoid larger when Kirigami Tablet Mode is enabled

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75863.
The-Feren-OS-Dev added a comment.


  Got rid of unnecessary rounding of smallSpacing at the end of the Tablet Mode 
padding addition

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27465?vs=75862=75863

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, ngraham, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27465: Add foundations for two future patches to complete the splitting of patch D27438

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75862.
The-Feren-OS-Dev added a comment.


  Make the click areas of system tray icons larger in Kirigami Tablet Mode

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27465?vs=75860=75862

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, ngraham, #plasma
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26813: Have user-manager write to SDDM's new config file

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R128:b2d0e463a490: Have user-manager write to SDDMs new 
config file (authored by filipf).

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26813?vs=75007=75861

REVISION DETAIL
  https://phabricator.kde.org/D26813

AFFECTED FILES
  src/lib/accountmodel.cpp

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27465: Add foundations for two future patches to complete the splitting of patch D27438

[David Redondo]

davidre added a comment.


  Do your second step here imo

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27465

To: The-Feren-OS-Dev, ngraham
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27465: Added foundations for two future patches to complete the splitting of patch D27438

[Dominic Hayes]

The-Feren-OS-Dev created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
The-Feren-OS-Dev requested review of this revision.

REVISION SUMMARY
  ngraham recommended that I split up https://phabricator.kde.org/D27438 into 
three patches:
  
  1. This patch - the foundation code to get landed first so that the other two 
patches can be done as patches that change two separate lines instead of just 
one
  
  2. Tablet Mode increases tray icon spacing
  
  3. Increase tray icon spacing slightly on Non-Tablet Mode (half of the amount 
it increases by in Tablet Mode)
  
  This patch is the start of that process, made to be landed first so that 
patches 2 and 3 can then follow while only having a diff that affects one 
different line each of this patch's changed lines.

TEST PLAN
  Test that System Tray still works after these changes have been made

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27465

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  The initial patch of the three, now I've thought up a suitable way of doing 
this, has been made:
  https://phabricator.kde.org/D27465

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  There's no need for this property stuff
  
  We have:
  
  view->setScreen()
  
  (or ideally passed in the constructor, it's a lot faster)
  
  and
  
  view->screen()
  
  and that has everything we need.

INLINE COMMENTS

> greeterapp.cpp:407
> +{
> +for(auto view : m_views) {
> +QScreen *screen = screenFromName(screens(), 
> view->property(screenNameProperty).toString());

Why are we looping through things again. It's all overly complex.

We just need

  void screenAddedImpl(QScreen *)
  {
//everything here
  }

then one place in the ctor,

  for (screen, qApp->screens()) {
 screenAddedImpl(screen);
  }

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D26986

To: tcanabrava, graesslin, davidedmundson
Cc: zzag, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  Actually, on second thought, @ngraham I'm not even sure if step 2 would even 
be worth it on its own, if possible.
  
  On your suggestion you have it adjusted to have step 3's tablet mode checker 
in step 2. If I don't have that check in place, for step 2, then it'd just be 
how it currently is anyway on master, effectively resulting in nothing to edit 
for a patch. I'll definitely do Step 3 as a patch, though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27438#613097 , @ngraham wrote:
  
  > ...one to increase the spacing when in tablet mode, and another one to 
increase the spacing when in desktop mode. At this point each patch will be 
changing a different line in the function
  
  
  Due to how the current patch handles it, I'll probably have to all of step 3 
one patch since they change the same line as each other, but for sure I can 
split steps 2 and 3(1)+3(2) of your post into individual patches.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev abandoned this revision.
The-Feren-OS-Dev added a comment.


  Alright, I'll start splitting the patches up now. Marking this one as 
Abandoned.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27438#613104 , @IlyaBizyaev 
wrote:
  
  > I agree with @broulik in that the spacing already feels quite excessive, or 
at least doesn't need to be increased (:
  >
  > Does this depend on DPI/panel size maybe?
  
  
  Units.smallSpacing should change depending on the DPI, from what I've heard.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Write Font without style name

[Mikhail Zolotukhin]

gikari updated this revision to Diff 75858.
gikari edited the summary of this revision.
gikari added a comment.


  Use big helper function for constructing font style. Please test, many fonts 
may break and not work.

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27380?vs=75634=75858

BRANCH
  font-style

REVISION DETAIL
  https://phabricator.kde.org/D27380

AFFECTED FILES
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h

To: gikari, #plasma, ervin, bport, meven
Cc: davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Mikhail Zolotukhin]

gikari added a comment.


  Since we plan to move more GTK related code to kde-gtk-config repo 
(specifically coloration of GTK apps from krdb), isn't it more reasonable to 
put this module in kde-gtk-config repo?

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  arcpatch-D24275_1

REVISION DETAIL
  https://phabricator.kde.org/D24275

To: cblack, #plasma, apol, The-Feren-OS-Dev
Cc: gikari, The-Feren-OS-Dev, davidedmundson, nicolasfella, GB_2, ngraham, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  I agree with @broulik in that the spacing already feels quite excessive, or 
at least doesn't need to be increased (:
  
  Does this depend on DPI/panel size maybe?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: IlyaBizyaev, broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Carson Black]

cblack updated this revision to Diff 75856.
cblack added a comment.


  Lower min version of CMake

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24275?vs=75205=75856

BRANCH
  arcpatch-D24275_1

REVISION DETAIL
  https://phabricator.kde.org/D24275

AFFECTED FILES
  CMakeLists.txt
  color-reload-module/CMakeLists.txt
  color-reload-module/reloader.c

To: cblack, #plasma, apol, The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, davidedmundson, nicolasfella, GB_2, ngraham, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> CMakeLists.txt:1
> +cmake_minimum_required ( VERSION 3.14 )
> +project ( libcolorreload C )

As noticed by @The-Feren-OS-Dev, this is too high.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  arcpatch-D24275_1

REVISION DETAIL
  https://phabricator.kde.org/D24275

To: cblack, #plasma, apol, The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, davidedmundson, nicolasfella, GB_2, ngraham, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Nathaniel Graham]

ngraham added a comment.


  
https://community.kde.org/Infrastructure/Phabricator#Marking_patches_as_dependent_on_other_patches
  
  It would probably be simplest do just do this though:
  
  1. Abandon this patch
  2. Submit a patch to refactor that logic to use a nested multi-line function 
for readability, as proposed in my comment
  3. After that patch lands, submit two more patches, one to increase the 
spacing when in tablet mode, and another one to increase the spacing when in 
desktop mode. At this point each patch will be changing a different line in the 
function
  
  Clear as mud? :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  How would I split it into two patches? Both patches would edit the exact same 
line.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Dominic Hayes]

The-Feren-OS-Dev accepted this revision.
The-Feren-OS-Dev added a comment.
This revision is now accepted and ready to land.


  Had to lower the cmake version requirement to be able to compile this, but 
this works just fine, and it's definitely something that'd be nice to have. I 
can't see any regressions nor leaks, either on this current patch version.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  arcpatch-D24275_1

REVISION DETAIL
  https://phabricator.kde.org/D24275

To: cblack, #plasma, apol, The-Feren-OS-Dev
Cc: The-Feren-OS-Dev, davidedmundson, nicolasfella, GB_2, ngraham, 
plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Nathaniel Graham]

ngraham added a comment.


  This should probably be two patches at this point: one to increase the 
spacing when using tablet mode (which IMO is an uncontroversial no-brainer) and 
another to increase the spacing when in desktop mode.

INLINE COMMENTS

> main.qml:45
> +// If Kirigami.Settings.tabletMode is true, double the amount of space 
> added around the tray icons to make them easier to tap on
> +readonly property int itemSize: 
> units.roundToIconSize(Math.min(Math.min(width, height), 
> units.iconSizes[iconSizes[Math.min(iconSizes.length-1, iconSize)]])) + 
> (Kirigami.Settings.tabletMode ? Math.round(units.smallSpacing) : 
> Math.round(units.smallSpacing/2))
>  property int hiddenItemSize: units.iconSizes.smallMedium

This should probably be rewritten as an inline function as it's now very 
difficult to read. e.g.:

  readonly property int itemSize {
  if (Kirigami.Settings.tabletMode) {
  return foo;
  } else {
  [put other logic here etc]
  return bar;
  }
  }

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75851.
The-Feren-OS-Dev added a comment.


  Tweaked an added comment

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27438?vs=75850=75851

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27438

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27438#613051 , @davidre wrote:
  
  > In D27438#613050 , 
@The-Feren-OS-Dev wrote:
  >
  > > In D27438#612719 , @davidre 
wrote:
  > >
  > > > There is now not clickable space between items:
  > > >  F8108239: grafik.png  F8108241: 
grafik.png 
  > > >  At least it should be clickable
  > >
  > >
  > > For future reference, how do you get that size examining mode in Plasma 
Desktop Workspace?
  >
  >
  > That's inside gammaray
  
  
  For some reason I couldn't get gammaray to do that over here, but I did come 
up with a new method for the patch that should increase hitboxes as well as 
icon spacing. Could you check if it does so, just to be sure?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev updated this revision to Diff 75850.
The-Feren-OS-Dev added a comment.


  Changed method used for increasing spacing between tray icons to something 
that increases hitbox sizes as well

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27438?vs=75804=75850

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27438

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

[Benjamin Port]

bport added inline comments.

INLINE COMMENTS

> DeviceAutomounterKCM.cpp:84
>  saveLayout();
> +delete m_settings;
>  }

We can also change kcfgc to add parent in constructor

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27127

To: meven, ervin, ngraham, #plasma, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[David Redondo]

davidre added a comment.


  In D27438#613050 , 
@The-Feren-OS-Dev wrote:
  
  > In D27438#612719 , @davidre 
wrote:
  >
  > > There is now not clickable space between items:
  > >  F8108239: grafik.png  F8108241: 
grafik.png 
  > >  At least it should be clickable
  >
  >
  > For future reference, how do you get that size examining mode in Plasma 
Desktop Workspace?
  
  
  That's inside gammaray

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27438: Increase System Tray Plasmoid spacing value slightly

[Dominic Hayes]

The-Feren-OS-Dev added a comment.


  In D27438#612719 , @davidre wrote:
  
  > There is now not clickable space between items:
  >  F8108239: grafik.png  F8108241: 
grafik.png 
  >  At least it should be clickable
  
  
  For future reference, how do you get that size examining mode in Plasma 
Desktop Workspace?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham, davidre
Cc: broulik, kmaterka, filipf, ndavis, anthonyfieroni, davidre, ngraham, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27052: Solid-device-automounter/kcm: Convert some foreach

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> meven wrote in DeviceAutomounter.cpp:73
> Unfortunately this is not possible line 78 requires a non-const ref to volume.

const auto for volumes was possible though.

I wonder if it wouldn't have made sense to have a non const ref in the loop 
then. Would have avoided the (potential) copy and made clear this loop was 
modifying. Oh well.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27052

To: meven, broulik, ervin, #plasma
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

[Méven Car]

meven updated this revision to Diff 75847.
meven marked 2 inline comments as done.
meven added a comment.


  Add a missing space, improve comment as suggested

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27024?vs=74667=75847

BRANCH
  arcpatch-D27024

REVISION DETAIL
  https://phabricator.kde.org/D27024

AFFECTED FILES
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, broulik, #plasma, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27116: KCM/Component email: simplify code

[Méven Car]

meven updated this revision to Diff 75846.
meven marked an inline comment as done.
meven added a comment.


  Fix a couple missing spaces

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27116?vs=74897=75846

BRANCH
  arcpatch-D27116

REVISION DETAIL
  https://phabricator.kde.org/D27116

AFFECTED FILES
  kcms/componentchooser/componentchooseremail.cpp

To: meven, #plasma, ervin, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Cyril Rossi]

crossi added a comment.


  Will do in a separate commit. I guess it's more or less related to the KCM 
Style.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27127: Solid-device-automounter/kcm: Use KConfigXT in ui

[Méven Car]

meven updated this revision to Diff 75845.
meven marked 2 inline comments as done.
meven added a comment.


  Add a delete for m_settings, move m_devices to ctor intialization

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27127?vs=74925=75845

BRANCH
  arcpatch-D27127

REVISION DETAIL
  https://phabricator.kde.org/D27127

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
  solid-device-automounter/kcm/DeviceAutomounterKCM.h
  solid-device-automounter/kcm/DeviceAutomounterKCM.ui

To: meven, ervin, ngraham, #plasma, bport, crossi
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27442: fix(kcm): use explicit Kirigami.Units over singleton from a theme

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:357df7c5c48a: fix(kcm): use explicit Kirigami.Units over 
singleton from a theme (authored by davidedmundson).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27442?vs=75791=75843

REVISION DETAIL
  https://phabricator.kde.org/D27442

AFFECTED FILES
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml

To: davidedmundson, #plasma, apol, romangg
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Benjamin Port]

bport updated this revision to Diff 75844.
bport added a comment.


  Add missing space

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27156?vs=75813=75844

REVISION DETAIL
  https://phabricator.kde.org/D27156

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fontremovenantialiasingkeys.upd
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h
  kcms/fonts/fontsaasettings.cpp
  kcms/fonts/fontsaasettings.h
  kcms/fonts/fontsaasettingsbase.kcfg
  kcms/fonts/fontsaasettingsbase.kcfgc
  kcms/fonts/kxftconfig.h
  kcms/fonts/package/contents/ui/main.qml
  kcms/krdb/krdb.cpp

To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27398: [desktoppackage] Fix layout when an applet has no custom config modules

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1123cc4d0b59: [desktoppackage] Fix layout when an applet 
has no custom config modules (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27398?vs=75680=75842

REVISION DETAIL
  https://phabricator.kde.org/D27398

AFFECTED FILES
  desktoppackage/contents/configuration/AppletConfiguration.qml

To: davidedmundson, ngraham
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27052: Solid-device-automounter/kcm: Convert some foreach

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:efdf88ec48b4: Solid-device-automounter/kcm: Convert some 
foreach (authored by meven).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27052?vs=75840=75841#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27052?vs=75840=75841

REVISION DETAIL
  https://phabricator.kde.org/D27052

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
  solid-device-automounter/kcm/DeviceModel.cpp
  solid-device-automounter/kded/DeviceAutomounter.cpp

To: meven, broulik, ervin, #plasma
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27052: Solid-device-automounter/kcm: Convert some foreach

[Méven Car]

meven added inline comments.

INLINE COMMENTS

> ervin wrote in DeviceAutomounter.cpp:73
> nitpick, feel free to ignore: would make sense to switch to a const ref here 
> since we're touching the line anyway. in the same vein, "const auto" on the 
> line before wouldn't be a bad idea either (if we ever switch to QVector for 
> instance it'd be one less place where compilation would break).

Unfortunately this is not possible line 78 requires a non-const ref to volume.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D27052_1

REVISION DETAIL
  https://phabricator.kde.org/D27052

To: meven, broulik, ervin, #plasma
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27052: Solid-device-automounter/kcm: Convert some foreach

[Méven Car]

meven updated this revision to Diff 75840.
meven marked an inline comment as done.
meven added a comment.


  Add a space

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27052?vs=74803=75840

BRANCH
  arcpatch-D27052_1

REVISION DETAIL
  https://phabricator.kde.org/D27052

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
  solid-device-automounter/kcm/DeviceModel.cpp
  solid-device-automounter/kded/DeviceAutomounter.cpp

To: meven, broulik, ervin, #plasma
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Nathaniel Graham]

ngraham added a comment.


  Separate commit is probably fine, but if this lands on the stable branch, it 
should come soon.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27353: Allow Activity Switcher to move/add windows to activities by drag and drop from the taskbar

[Will Stephenson]

wstephenson added a comment.


  There is a change to the QML missing from this diff as it stands, will amend 
it tomorrow

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27353

To: wstephenson, #plasma, ivan, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27424: Add missing cursors for Chromium-based apps

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  Cool, thanks! I was totally oblivious of the fact the page had three columns 
:)
  
  This can go into 5.18 I'd say

REPOSITORY
  R31 Breeze

BRANCH
  breeze-symlinks (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27424

To: guilhermesilva, #breeze, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27461: Sync Plasma theme settings instead of copying the plasmarc file

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> sddmauthhelper.cpp:138
> +QSharedPointer themeConfig = 
> openConfig(themeConfigLocation);
> +
> themeConfig->group(QStringLiteral("Theme")).writeEntry(QStringLiteral("name"),
>  args[QStringLiteral("plasmaTheme")].toString());
> +const char* themeConfigLocationConverted = 
> themeConfigLocation.toLocal8Bit().data();

do I need to do `themeConfig->sync`? It seems to work as intended without it, 
even when just updating the entry.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D27461

To: filipf, #plasma, davidedmundson, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27462: Include comment for translators for Power Down

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: broulik, aacid.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Should hopefully make it less confusing

REPOSITORY
  R122 Powerdevil

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27462

AFFECTED FILES
  daemon/actions/bundled/handlebuttonevents.cpp

To: apol, broulik, aacid
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27461: Sync Plasma theme settings instead of copying the plasmarc file

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  The first and the easiest part of finishing T12710 
.
  
  Instead of copying the user's plasmarc file in order to have SDDM use their 
Plasma theme, we read the user value and create the SDDM user's config 
ourselves.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  safer-plasmarc (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27461

AFFECTED FILES
  sddmauthhelper.cpp
  src/advancedconfig.cpp

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27457: Move kcminit_startup and kded to plasma-session

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:930e991b0e7e: Move kcminit_startup and kded to 
plasma-session (authored by apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27457?vs=75827=75834

REVISION DETAIL
  https://phabricator.kde.org/D27457

AFFECTED FILES
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h
  startkde/startplasma-waylandsession.cpp
  startkde/startplasma-x11.cpp
  startkde/startplasma.cpp

To: apol, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27458: Set a better position for Krunner in wayland

[Aleix Pol Gonzalez]

apol added a comment.


  +1 on fixing this

INLINE COMMENTS

> view.cpp:240
> +QDBusInterface strutManager("org.kde.plasmashell", "/StrutManager", 
> "org.kde.PlasmaShell.StrutManager");
> +QDBusReply pr = strutManager.call("availableScreenRect", 
> shownOnScreen->name());
> +if (pr.isValid()) {

This is a blocking call, it would be ideal to find a way around this...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27458

To: trmdi, #plasma, davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27391: [Applet]Fix dimensions of traffic Monitor

[George Vogiatzis]

gvgeo updated this revision to Diff 75832.
gvgeo added a comment.


  Added comment.
  
  Hope it is not semi-random-looking anymore.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27391?vs=75770=75832

BRANCH
  monitor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27391

AFFECTED FILES
  applet/contents/ui/TrafficMonitor.qml

To: gvgeo, #plasma, #vdg, jgrulich
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27199: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 75831.
gvgeo edited the summary of this revision.
gvgeo added a dependency: D27392: [Applet]Add info messages..
gvgeo added a comment.


  Changes:
  Removed some parts that were split into separate patches.
  Reintroduce background.
  Moved highlight in ListItem.
  Removed heading and moved separator in ListItem.
  
  TODO:
  Add `opacity: 0.6` for details after D27393 
 commit.
  Remove 1 extra smallSpacing in switchbutton after D27453 
 commit.

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27199?vs=75498=75831

BRANCH
  layoutsplit2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27199

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/Header.qml
  applet/contents/ui/ListItem.qml
  applet/contents/ui/PasswordField.qml
  applet/contents/ui/PopupDialog.qml
  applet/contents/ui/Toolbar.qml
  applet/contents/ui/main.qml
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp

To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27391: [Applet]Fix dimensions of traffic Monitor

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Accepting from my side. I'll wait for Nate to do the final review as I don't 
consider myself expert to QML and UI.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  monitor (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27391

To: gvgeo, #plasma, #vdg, jgrulich
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27458: Set a better position for Krunner in wayland

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  In wayland, QScreen::availableGeometry() returns QScreen::geometry(), we 
could get a better value from plasmashell
  
  CCBUG: 386114

TEST PLAN
  Krunner isn't overlapped by a top panel in all cases

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27458

AFFECTED FILES
  krunner/view.cpp
  shell/strutmanager.cpp
  shell/strutmanager.h

To: trmdi, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27457: Move kcminit_startup and kded to plasma-session

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

TEST PLAN
  Used it to start plasma

REPOSITORY
  R120 Plasma Workspace

BRANCH
  apol/kdedkcmtosession

REVISION DETAIL
  https://phabricator.kde.org/D27457

AFFECTED FILES
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h
  startkde/startplasma-waylandsession.cpp
  startkde/startplasma-x11.cpp
  startkde/startplasma.cpp

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> fontsaasettings.cpp:305
> +{
> +if(dpi() == newDPI) {
> +return;

add space between `if` and `(` please

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27156

To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27457: Move kcminit_startup and kded to plasma-session

[Aleix Pol Gonzalez]

apol updated this revision to Diff 75827.
apol added a comment.


  Removed unused code

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27457?vs=75826=75827

BRANCH
  apol/kdedkcmtosession

REVISION DETAIL
  https://phabricator.kde.org/D27457

AFFECTED FILES
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h
  startkde/startplasma-waylandsession.cpp
  startkde/startplasma-x11.cpp
  startkde/startplasma.cpp

To: apol, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Write Font without style name

[Benjamin Port]

bport added a comment.


  I just read bug report again and the from seems to came from , not from 
localization.
  
  By the way I neved end with localized style, how do you achieve that ? (I 
mean even in UI)

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven
Cc: davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Write Font without style name

[Benjamin Port]

bport added a comment.


  I think a good fix can be to use @davidedmundson solution combined with a 
check to know if font styleName is not set (if it set it will be not translated.
  
  I think
  QFont yourFont = QFont(...);
  auto f = QFontInfo(youFont)
  f.styleName(); <<=  is in theory empty if it's not enforced. In other case 
stuff based on enum will be ok. Goal of style name is to express "irregular" 
style name according to Qt documentation

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven
Cc: davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

Monday meeting notes from 17/2/2020

[Marco Martin]

Kai Uwe:
Notifications:
* File transfer labels in details section only grow, never shrink
* Keeps the dialog from constantly resizing when copying many small files
* Fixed Telegram to check action ID when invoked, in preparation for
new quick reply API using the action signal instead
* Investigated notification issues in autostart applications
* Telegram's stupid notification implementation uses
`QDBusInterface` and the `Introspect` call isn't allowed by Snap
sandbox
* Contacted owner of notification spec files to see if they're still around
* Forwarded me to someone else, no reply from them yet
Other:
* Fixed new styles KCM showing wrong window title in style config dialog
* Fixed crash in DataEngineManager when NullEngine is loaded (e.g.
geolocation missing in night color)
* Investigated a crash on plasmashell teardown
* Was looking into System Tray icons breaking with `AttentionIcon`
* Very odd. The role is in the data source, it's in the data
model,, it is in gammaray, yet it ends up missing when actually in the
delegate?!
Plasma Sprint:
Got in touch with TUXEDO and they will host this year's Plasma sprint!
>From 18 till 26 April in Augsburg, Germany.
Make sure to add yourselves to the wiki:
https://community.kde.org/Sprints/Plasma/2020

Jonathan:
* released 5.18
* it was fabulous
* although had some bugs
* all to be fixed for tomorrow's 5.18.1
* meeting on thursday for 5.19 kickoff
* Thursday 20th Feb 2020 15:00UTC/16:00CET

Bhushan:
- Working on new PlaMo images for pinephone
- Did look into halium 9 briefly for newer devices (sony xperia xa2)
- Struggled with Qt bug which makes it assume wrong prefix on arm64
- Workarounded in neon for now

Nico:
* Not super much this week, mostly recovering from fosdem/plamo sprint
* For more details on those check my recent blog post
* Diff 26918 "Improve KNotification API docs" [Needs Review]
https://phabricator.kde.org/D26918
* Still more to do
* Diff 26769 "Always strip html if server does not support it" [Needs
Review] https://phabricator.kde.org/D26769
* Diff 26604 "Check if there is an activatable service when
notification service owner changes" [Needs Review]
https://phabricator.kde.org/D26604
* Diff 26605 "Remove fallback to KPassivePopup" [Needs Review]
https://phabricator.kde.org/D26605
* Diff 22544 "[RFC] Deprecate KPassivePopup" [Needs Review]
https://phabricator.kde.org/D22544
* Diff 27434 "Improve readme" [Needs Review] https://phabricator.kde.org/D27434

David E:
* I fixed a bunch of things
* the most fun was the combo shortcut keys for plasma getting lost
* turns out the toolbox, despite being invisible, had an auto attached
accelerator on alt+d which ate everything
* One thing I'd like to mention in the meeting. In kirigami imports,
it's important we always use Kirigami.Units and not "units."
Task 12708 "Drop units singleton being exported from the Kirigami
desktop theme plugin" [Open,Needs Triage] {KF6}
https://phabricator.kde.org/T12708

Arjen:
* I did a bunch of fixes relating to scrollbars
* Diff 27379 "Baloo KCM: Do not anchor fill ScrollView" [Closed]
https://phabricator.kde.org/D27379
* Diff 27382 "KCM: Fix connection list background and padding"
[Closed] https://phabricator.kde.org/D27382
* there's one issue that I've found however that I'm not sure yet how
to resolve, but basically the applet configuration dialog will also
overlap scrollbars when sized too small
* Diff 27362 "Linux/cpuinfo.c: grow buffer size as needed for 12+ core
CPUs" [Accepted] https://phabricator.kde.org/D27362 turns out 640k
isn't enough for everyone :p

D27322: Allow move or add window to Activities during Dnd using Ctrl modifier

[Will Stephenson]

wstephenson added a comment.


  In D27322#612156 , @ivan wrote:
  
  > Cool idea, I'll have to think of something similar for the regular activity 
switcher
  
  
  @ivan it's here: https://phabricator.kde.org/D27353

REVISION DETAIL
  https://phabricator.kde.org/D27322

To: wstephenson, davidedmundson, #plasma, hein
Cc: ivan, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27156: KCM Fonts port anti aliasing part to KPropertySkeletonItem

[Kevin Ottens]

ervin accepted this revision.
ervin added a comment.
This revision is now accepted and ready to land.


  Looks good to me now, maybe try to get more reviewers before pushing though.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27156

To: bport, #plasma, ervin, crossi, meven
Cc: usta, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27407: Breeze widgetStyle value is Breeze

[Kevin Ottens]

ervin added a comment.


  Shall we expect the migration script in that patch or another one?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27407

To: crossi, ervin, bport, meven, mart, davidedmundson, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27380: [GTK Config] Write Font without style name

[Kevin Ottens]

ervin added a comment.


  Can we give a shot to @davidedmundson proposal? Maybe slightly extended to 
cover some extra enum cases if necessary?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven
Cc: davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, ahiemstra, mart

D27422: [KCM]Update Device item layout based on applet

[George Vogiatzis]

gvgeo updated this revision to Diff 75820.
gvgeo added a comment.


  Style

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27422?vs=75819=75820

BRANCH
  kcmports2

REVISION DETAIL
  https://phabricator.kde.org/D27422

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27422: [KCM]Update Device item layout based on applet

[George Vogiatzis]

gvgeo updated this revision to Diff 75819.
gvgeo added a comment.


  Restore imports.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27422?vs=75818=75819

BRANCH
  kcmports2

REVISION DETAIL
  https://phabricator.kde.org/D27422

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27422: [KCM]Update Device item layout based on applet

[George Vogiatzis]

gvgeo updated this revision to Diff 75818.
gvgeo added a comment.


  Remove PlasmaComponents.
  
  So.. why all these different distinctions exist?

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27422?vs=75760=75818

BRANCH
  kcmports2

REVISION DETAIL
  https://phabricator.kde.org/D27422

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27395: KCM/ComponentChooser Treat cases when there is no app for a usage

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> componentchooseremail.cpp:155
>  KSharedConfig::Ptr profile = 
> KSharedConfig::openConfig(QStringLiteral("mimeapps.list"), 
> KConfig::NoGlobals, QStandardPaths::GenericConfigLocation);
> -if (profile->isConfigWritable(true) && emailClientService) {
>  

This actually feels less safe now. What if KService returned a nullptr for some 
reason?

I understand from the logic of early returns you introduced everywhere that you 
*expect* something. Still I wonder if that's really guaranteed by KService, we 
could expect bad config somewhere maybe?

> componentchooserterminal.cpp:121
>  if (dlg.exec() != QDialog::Accepted) {
> -setCurrentIndex(m_currentIndex);
> +setCurrentIndex(m_currentIndex == -1 ? 0 : m_currentIndex);
>  return;

This comes back often in this patch and feels a bit cryptic, probably worth 
having a properly named method for it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27395

To: meven, bport, ervin, crossi, davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27420: [Applet]Improvements for unavailable port.

[George Vogiatzis]

gvgeo updated this revision to Diff 75817.
gvgeo added a comment.


  avoid i18n puzzles

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27420?vs=75739=75817

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27362: Linux/cpuinfo.c: grow buffer size as needed for 12+ core CPUs

[Jakob Kummerow]

jakobkummerow added a comment.


  Thanks for landing this! My name is Jakob Kummerow, email: 
jakob.kumme...@gmail.com
  
  I created the diff via Phabricator's web interface (uploading a .diff file), 
would have expected it to take the author information from my account...

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D27362

To: jakobkummerow, davidedmundson, ahiemstra
Cc: ahiemstra, cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D27453: [Applet]Update toolbar's checkbox spacing

[George Vogiatzis]

gvgeo added inline comments.

INLINE COMMENTS

> SwitchButton.qml:54
>  left: switchButtonCheckbox.right
> -leftMargin: units.gridUnit / 2
> -top: switchButtonCheckbox.top
> -bottom: switchButtonCheckbox.bottom
> +// Checkbox bug adds internally a smallSpacing on the right. 
> Doubling the effective spacing here.
> +leftMargin: units.smallSpacing

I made some tests. I even comment out in checkbox style, label and background 
but always added spacing.
Only workaround that found to work, was to set `spacing: control.text ? 
smallSpacing : 0`, but didn't felt right way to do it.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27453

To: gvgeo, #plasma, #vdg, jgrulich, ngraham
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27453: [Applet]Update toolbar's checkbox spacing

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> SwitchButton.qml:54
>  left: switchButtonCheckbox.right
> -leftMargin: units.gridUnit / 2
> -top: switchButtonCheckbox.top
> -bottom: switchButtonCheckbox.bottom
> +// Checkbox bug adds internally a smallSpacing on the right. 
> Doubling the effective spacing here.
> +leftMargin: units.smallSpacing

Can this bug be fixed? Or is that because we use a `CheckBox` without a label 
and so it is icon width + spacing + no label?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27453

To: gvgeo, #plasma, #vdg, jgrulich, ngraham
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27382: KCM: Fix connection list background and padding

[Arjen Hiemstra]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R116:f8a60c63876f: KCM: Fix connection list background and 
padding (authored by ahiemstra).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27382?vs=75636=75816

REVISION DETAIL
  https://phabricator.kde.org/D27382

AFFECTED FILES
  kcm/qml/main.qml

To: ahiemstra, jgrulich, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart