[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user asfgit closed the pull request at: https://github.com/apache/spark/pull/6876 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-114607544 Thanks, merging to master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-114288625 [Test build #35483 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35483/console) for PR 6876 at commit [`429c2c0`](https://github.com/apache/spark/commit/429c2c08768fc5a28be3ed0899c079e7b587ac1d). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `case class UnresolvedAlias(child: Expression) extends NamedExpression` * `abstract class ExtractValueWithStruct extends ExtractValue ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-114288715 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-114246587 [Test build #35483 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35483/consoleFull) for PR 6876 at commit [`429c2c0`](https://github.com/apache/spark/commit/429c2c08768fc5a28be3ed0899c079e7b587ac1d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-114245895 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-114245985 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32891689
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateProjection.scala
---
@@ -127,6 +127,7 @@ object GenerateProjection extends
CodeGenerator[Seq[Expression], Projection] {
case FloatType => s"Float.floatToIntBits($col)"
case DoubleType =>
s"(int)(Double.doubleToLongBits($col) ^
(Double.doubleToLongBits($col) >>> 32))"
+case BinaryType => s"java.util.Arrays.hashCode($col)"
--- End diff --
Ah I see, `genEqual` has already handled `BinaryType`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113844501 [Test build #946 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/946/console) for PR 6876 at commit [`32d9811`](https://github.com/apache/spark/commit/32d981137fd24d1e55c3a4c2c23bb19e494b4f65). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113838214 [Test build #946 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/946/consoleFull) for PR 6876 at commit [`32d9811`](https://github.com/apache/spark/commit/32d981137fd24d1e55c3a4c2c23bb19e494b4f65). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32887551
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateProjection.scala
---
@@ -127,6 +127,7 @@ object GenerateProjection extends
CodeGenerator[Seq[Expression], Projection] {
case FloatType => s"Float.floatToIntBits($col)"
case DoubleType =>
s"(int)(Double.doubleToLongBits($col) ^
(Double.doubleToLongBits($col) >>> 32))"
+case BinaryType => s"java.util.Arrays.hashCode($col)"
--- End diff --
That's already done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32884828
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -26,7 +26,67 @@ import
org.apache.spark.sql.catalyst.expressions.GenericRow
*/
abstract class InternalRow extends Row {
// A default implementation to change the return type
- override def copy(): InternalRow = {this}
+ override def copy(): InternalRow = this
+
+ override def equals(o: Any): Boolean = {
+if (!o.isInstanceOf[Row]) {
+ return false
+}
+
+val other = o.asInstanceOf[Row]
+if (length != other.length) {
+ return false
+}
+
+for (i <- 0 until length) {
+ if (isNullAt(i) != other.isNullAt(i)) {
+return false
+ }
+ if (!isNullAt(i)) {
+val o1 = apply(i)
+val o2 = other.apply(i)
+if (o1.isInstanceOf[Array[Byte]]) {
+ // handle equality of Array[Byte]
+ val b1 = o1.asInstanceOf[Array[Byte]]
+ if (!o2.isInstanceOf[Array[Byte]] ||
+!java.util.Arrays.equals(b1, o2.asInstanceOf[Array[Byte]])) {
+return false
+ }
+} else if (o1 != o2) {
+ return false
+}
--- End diff --
Should we abstract this column compare logic into a method? So that we
don't need to write it again for code generation...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32884758
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateProjection.scala
---
@@ -127,6 +127,7 @@ object GenerateProjection extends
CodeGenerator[Seq[Expression], Projection] {
case FloatType => s"Float.floatToIntBits($col)"
case DoubleType =>
s"(int)(Double.doubleToLongBits($col) ^
(Double.doubleToLongBits($col) >>> 32))"
+case BinaryType => s"java.util.Arrays.hashCode($col)"
--- End diff --
Should we also update `equals` for generated code?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113670505 [Test build #35322 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35322/console) for PR 6876 at commit [`32d9811`](https://github.com/apache/spark/commit/32d981137fd24d1e55c3a4c2c23bb19e494b4f65). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113670534 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113643925 [Test build #35322 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35322/consoleFull) for PR 6876 at commit [`32d9811`](https://github.com/apache/spark/commit/32d981137fd24d1e55c3a4c2c23bb19e494b4f65). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113643422 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113643472 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113637840 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113637801 [Test build #35307 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35307/console) for PR 6876 at commit [`a0626ed`](https://github.com/apache/spark/commit/a0626edbf758c89a45a8c85285057e79ec6a2bce). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113632533 [Test build #939 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/939/console) for PR 6876 at commit [`a0626ed`](https://github.com/apache/spark/commit/a0626edbf758c89a45a8c85285057e79ec6a2bce). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds the following public classes _(experimental)_: * `class SerializableConfiguration(@transient var value: Configuration) extends Serializable ` * `class SerializableJobConf(@transient var value: JobConf) extends Serializable ` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113606317 [Test build #35307 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35307/consoleFull) for PR 6876 at commit [`a0626ed`](https://github.com/apache/spark/commit/a0626edbf758c89a45a8c85285057e79ec6a2bce). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113606152 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113606196 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113606100 test this please --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113604560 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113604521 [Test build #35284 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35284/console) for PR 6876 at commit [`a0626ed`](https://github.com/apache/spark/commit/a0626edbf758c89a45a8c85285057e79ec6a2bce). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113602656 [Test build #939 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/939/consoleFull) for PR 6876 at commit [`a0626ed`](https://github.com/apache/spark/commit/a0626edbf758c89a45a8c85285057e79ec6a2bce). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113596212 [Test build #937 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/937/console) for PR 6876 at commit [`a0626ed`](https://github.com/apache/spark/commit/a0626edbf758c89a45a8c85285057e79ec6a2bce). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113595742 [Test build #937 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/937/consoleFull) for PR 6876 at commit [`a0626ed`](https://github.com/apache/spark/commit/a0626edbf758c89a45a8c85285057e79ec6a2bce). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113593028 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113592984 [Test build #35283 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35283/console) for PR 6876 at commit [`bd20780`](https://github.com/apache/spark/commit/bd20780beeb134aa54f41326fa22f7176beee29c). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113577977 [Test build #35284 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35284/consoleFull) for PR 6876 at commit [`a0626ed`](https://github.com/apache/spark/commit/a0626edbf758c89a45a8c85285057e79ec6a2bce). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113577516 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113577456 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113576770 [Test build #35283 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35283/consoleFull) for PR 6876 at commit [`bd20780`](https://github.com/apache/spark/commit/bd20780beeb134aa54f41326fa22f7176beee29c). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113576558 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113576533 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113397757 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113397673 [Test build #35225 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35225/console) for PR 6876 at commit [`41caec6`](https://github.com/apache/spark/commit/41caec6c9c7bf8d82c714d7ba081e002fa919a9d). * This patch **fails Spark unit tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32804448
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/LiteralExpressionSuite.scala
---
@@ -31,8 +45,16 @@ class LiteralExpressionSuite extends SparkFunSuite with
ExpressionEvalHelper {
}
test("int literals") {
-checkEvaluation(Literal(1), 1)
-checkEvaluation(Literal(0L), 0L)
+List(0, 1, Int.MinValue, Int.MaxValue).foreach {
--- End diff --
this is a pretty weird way of indenting. you can do
```scala
List(0, 1, Int.MinValue, Int.MaxValue).foreach { d =>
...
}
```
or
```scala
for (d <- List(0, 1, Int.MinValue, Int.MaxValue)) {
...
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113371654 [Test build #35225 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35225/consoleFull) for PR 6876 at commit [`41caec6`](https://github.com/apache/spark/commit/41caec6c9c7bf8d82c714d7ba081e002fa919a9d). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113371558 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113371570 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32799934
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -26,7 +26,67 @@ import
org.apache.spark.sql.catalyst.expressions.GenericRow
*/
abstract class InternalRow extends Row {
// A default implementation to change the return type
- override def copy(): InternalRow = {this}
+ override def copy(): InternalRow = this
+
+ override def equals(o: Any): Boolean = {
+if (!o.isInstanceOf[Row]) {
+ return false
+}
+
+val other = o.asInstanceOf[Row]
+if (length != other.length) {
+ return false
+}
+
+for (i <- 0 until length) {
+ if (isNullAt(i) != other.isNullAt(i)) {
+return false
+ }
+ if (!isNullAt(i)) {
+val o1 = apply(i)
+val o2 = other.apply(i)
+if (o1.isInstanceOf[Array[Byte]]) {
+ // handle equality of Array[Byte]
+ val b1 = o1.asInstanceOf[Array[Byte]]
+ if (!o2.isInstanceOf[Array[Byte]] ||
+!java.util.Arrays.equals(b1, o2.asInstanceOf[Array[Byte]])) {
+return false
+ }
+} else if (o1 != o2) {
+ return false
+}
--- End diff --
`match` is also slow in Scala
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32799457
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -26,7 +26,67 @@ import
org.apache.spark.sql.catalyst.expressions.GenericRow
*/
abstract class InternalRow extends Row {
// A default implementation to change the return type
- override def copy(): InternalRow = {this}
+ override def copy(): InternalRow = this
+
+ override def equals(o: Any): Boolean = {
+if (!o.isInstanceOf[Row]) {
+ return false
+}
+
+val other = o.asInstanceOf[Row]
+if (length != other.length) {
+ return false
+}
+
+for (i <- 0 until length) {
+ if (isNullAt(i) != other.isNullAt(i)) {
+return false
+ }
+ if (!isNullAt(i)) {
+val o1 = apply(i)
+val o2 = other.apply(i)
+if (o1.isInstanceOf[Array[Byte]]) {
+ // handle equality of Array[Byte]
+ val b1 = o1.asInstanceOf[Array[Byte]]
+ if (!o2.isInstanceOf[Array[Byte]] ||
+!java.util.Arrays.equals(b1, o2.asInstanceOf[Array[Byte]])) {
+return false
+ }
+} else if (o1 != o2) {
+ return false
+}
--- End diff --
what about
```scala
(o1, o2) match {
case (b1: Array[Byte], b2: Array[Byte]) => java.util.Arrays.equals(b1, b2)
case _ => o1 == o2
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32799430
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -26,7 +26,67 @@ import
org.apache.spark.sql.catalyst.expressions.GenericRow
*/
abstract class InternalRow extends Row {
// A default implementation to change the return type
- override def copy(): InternalRow = {this}
+ override def copy(): InternalRow = this
+
+ override def equals(o: Any): Boolean = {
+if (!o.isInstanceOf[Row]) {
--- End diff --
yes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32799402
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -26,7 +26,67 @@ import
org.apache.spark.sql.catalyst.expressions.GenericRow
*/
abstract class InternalRow extends Row {
// A default implementation to change the return type
- override def copy(): InternalRow = {this}
+ override def copy(): InternalRow = this
+
+ override def equals(o: Any): Boolean = {
+if (!o.isInstanceOf[Row]) {
+ return false
+}
+
+val other = o.asInstanceOf[Row]
+if (length != other.length) {
+ return false
+}
+
+for (i <- 0 until length) {
--- End diff --
I think we should use `while` here, as `for` is inefficient in scala.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32799341
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -26,7 +26,67 @@ import
org.apache.spark.sql.catalyst.expressions.GenericRow
*/
abstract class InternalRow extends Row {
// A default implementation to change the return type
- override def copy(): InternalRow = {this}
+ override def copy(): InternalRow = this
+
+ override def equals(o: Any): Boolean = {
+if (!o.isInstanceOf[Row]) {
--- End diff --
Will we change it to `isInstanceOf[InternalRow]` after
https://github.com/apache/spark/pull/6869?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113348592 **[Test build #35189 timed out](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35189/console)** for PR 6876 at commit [`d96929b`](https://github.com/apache/spark/commit/d96929bd4f9f740be82164430c3cbb9f1d8b4035) after a configured wait of `175m`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113348606 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113321944 I think using a wrapper might be necessary for efficiency. For example, we will want to reuse the same byte array when reading from something like parquet, instead of needing to allocate one of the exact size each time (think `java.nio.ByteBuffer`). However, I'm fine merging this first. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113320501 [Test build #35189 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35189/consoleFull) for PR 6876 at commit [`d96929b`](https://github.com/apache/spark/commit/d96929bd4f9f740be82164430c3cbb9f1d8b4035). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113320406 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113320382 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113319601 @marmbrus We're working to have more efficient representation in catalyst, putting Array[Byte] inside a wrapper sounds not in the same direction. I'd like to go this approach. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32790173
--- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java ---
@@ -155,27 +155,6 @@ public int fieldIndex(String name) {
throw new UnsupportedOperationException();
}
- /**
- * A generic version of Row.equals(Row), which is used for tests.
- */
- @Override
--- End diff --
Because `Row` is a trait, UnsafeRow and SpecificRow are both in Java, they
can not inherit some default implementations from `Row`, so created BaseRow in
Java for them. Right now, we have `InternalRow`, will be clean these in another
PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32790069
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -55,7 +55,7 @@ trait ExpressionEvalHelper {
val actual = try evaluate(expression, inputRow) catch {
case e: Exception => fail(s"Exception evaluating $expression", e)
}
-if (actual != expected) {
+if (actual !== expected) {
--- End diff --
Just learned from someone else, thought it could help to compare Array,
will revert it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32789934
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -27,6 +27,63 @@ import
org.apache.spark.sql.catalyst.expressions.GenericRow
abstract class InternalRow extends Row {
// A default implementation to change the return type
override def copy(): InternalRow = {this}
+
+ // A default version (slow), used for tests
--- End diff --
Yes, you are right. The comment is only true for codegen, which has a
special version of `equals`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user marmbrus commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113307995 @davies, thanks for working on this! I'm okay with this approach, but did you consider the alternative, where we instead change the internal type of `BytesType` to be a wrapper class instead of `Array[Byte]`, and define a good equality function for that wrapper? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32786925
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala
---
@@ -55,7 +55,7 @@ trait ExpressionEvalHelper {
val actual = try evaluate(expression, inputRow) catch {
case e: Exception => fail(s"Exception evaluating $expression", e)
}
-if (actual != expected) {
+if (actual !== expected) {
--- End diff --
What are the semantics of `!==`? This is new to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32786856
--- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java ---
@@ -155,27 +155,6 @@ public int fieldIndex(String name) {
throw new UnsupportedOperationException();
}
- /**
- * A generic version of Row.equals(Row), which is used for tests.
- */
- @Override
--- End diff --
Existing: can you add some javadoc to this class to explain what its used
for and why its in Java?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32786889
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/InternalRow.scala ---
@@ -27,6 +27,63 @@ import
org.apache.spark.sql.catalyst.expressions.GenericRow
abstract class InternalRow extends Row {
// A default implementation to change the return type
override def copy(): InternalRow = {this}
+
+ // A default version (slow), used for tests
--- End diff --
Is this really only used for tests? Won't it be used when we use an
internal row as a HashKey?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user davies commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113285297 @marmbrus Could you help to review this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113269194 [Test build #35146 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35146/console) for PR 6876 at commit [`6ad2a90`](https://github.com/apache/spark/commit/6ad2a908956040c4343db82634caa3f347668ad1). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113269243 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113237099 [Test build #35146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35146/consoleFull) for PR 6876 at commit [`6ad2a90`](https://github.com/apache/spark/commit/6ad2a908956040c4343db82634caa3f347668ad1). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113235712 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113235672 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113232167 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113232161 [Test build #35144 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35144/console) for PR 6876 at commit [`5819d33`](https://github.com/apache/spark/commit/5819d33fd38359c3d10dc6b22edab410b72acab7). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113231856 [Test build #35144 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35144/consoleFull) for PR 6876 at commit [`5819d33`](https://github.com/apache/spark/commit/5819d33fd38359c3d10dc6b22edab410b72acab7). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113231076 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113231014 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32752513
--- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java ---
@@ -167,9 +167,21 @@ public boolean equals(Object other) {
return false;
}
for (int i = 0; i < n; i ++) {
-if (isNullAt(i) != row.isNullAt(i) || (!isNullAt(i) &&
!get(i).equals(row.get(i {
+if (isNullAt(i) != row.isNullAt(i)) {
return false;
}
+if (!isNullAt(i)) {
+ Object o1 = get(i);
+ Object o2 = row.get(i);
+ if (o1 instanceof byte[]) {
+// handle equals() of byte[]
+if (!(o2 instanceof byte[]) ||
!java.util.Arrays.equals((byte[])o1, (byte[])o2)) {
+ return false;
+}
+ } else if (!o1.equals(o2)) {
+return false;
+ }
+}
}
return true;
--- End diff --
Because `Row` is a trait, so we can't use it in Java (for UnsafeRow and
SpecificRow in codegen), so we at least need two version of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32751957
--- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java ---
@@ -215,4 +227,15 @@ public String mkString(String sep) {
public String mkString(String start, String sep, String end) {
return toSeq().mkString(start, sep, end);
}
+
+ /*
+ * Returns hash code based on bytes in `arr`
+ * */
+ protected int bytesHashCode(byte[] arr) {
+int hash = 0;
+for (int i = 0; i < arr.length; i++) {
+ hash = hash * 37 + (int)arr[i];
+}
+return hash;
--- End diff --
Good idea, we should use that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113098285 Merged build finished. Test PASSed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113098257 [Test build #35114 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35114/console) for PR 6876 at commit [`0fff25d`](https://github.com/apache/spark/commit/0fff25de628b76f5cf2ce0bfbb4fc9c2f3fdbf1f). * This patch **passes all tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32714889
--- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java ---
@@ -167,9 +167,21 @@ public boolean equals(Object other) {
return false;
}
for (int i = 0; i < n; i ++) {
-if (isNullAt(i) != row.isNullAt(i) || (!isNullAt(i) &&
!get(i).equals(row.get(i {
+if (isNullAt(i) != row.isNullAt(i)) {
return false;
}
+if (!isNullAt(i)) {
+ Object o1 = get(i);
+ Object o2 = row.get(i);
+ if (o1 instanceof byte[]) {
+// handle equals() of byte[]
+if (!(o2 instanceof byte[]) ||
!java.util.Arrays.equals((byte[])o1, (byte[])o2)) {
+ return false;
+}
+ } else if (!o1.equals(o2)) {
+return false;
+ }
+}
}
return true;
--- End diff --
We defined `equals` at `Row`, and override it at `BaseRow` and
`GenericRow`. But these 3 `equals` are very similar, can we combine them into
one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/6876#discussion_r32714548
--- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/BaseRow.java ---
@@ -215,4 +227,15 @@ public String mkString(String sep) {
public String mkString(String start, String sep, String end) {
return toSeq().mkString(start, sep, end);
}
+
+ /*
+ * Returns hash code based on bytes in `arr`
+ * */
+ protected int bytesHashCode(byte[] arr) {
+int hash = 0;
+for (int i = 0; i < arr.length; i++) {
+ hash = hash * 37 + (int)arr[i];
+}
+return hash;
--- End diff --
Is it same with `java.util.Arrays.hashCode`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
-
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113070851 [Test build #35114 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35114/consoleFull) for PR 6876 at commit [`0fff25d`](https://github.com/apache/spark/commit/0fff25de628b76f5cf2ce0bfbb4fc9c2f3fdbf1f). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113070594 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113070606 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113069333 Merged build finished. Test FAILed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113069330 [Test build #35112 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35112/console) for PR 6876 at commit [`53c38b1`](https://github.com/apache/spark/commit/53c38b12a5a14a581c4d58060ccdb96db25b5956). * This patch **fails Scala style tests**. * This patch merges cleanly. * This patch adds no public classes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user SparkQA commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113069063 [Test build #35112 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/35112/consoleFull) for PR 6876 at commit [`53c38b1`](https://github.com/apache/spark/commit/53c38b12a5a14a581c4d58060ccdb96db25b5956). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113068917 Merged build triggered. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
Github user AmplabJenkins commented on the pull request: https://github.com/apache/spark/pull/6876#issuecomment-113068930 Merged build started. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
[GitHub] spark pull request: [SPARK-8432] [SQL] fix hashCode() and equals()...
GitHub user davies opened a pull request: https://github.com/apache/spark/pull/6876 [SPARK-8432] [SQL] fix hashCode() and equals() of BinaryType in Row Also added more tests in LiteralExpressionSuite You can merge this pull request into a Git repository by running: $ git pull https://github.com/davies/spark fix_hashcode Alternatively you can review and apply these changes as the patch at: https://github.com/apache/spark/pull/6876.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #6876 commit 53c38b12a5a14a581c4d58060ccdb96db25b5956 Author: Davies Liu Date: 2015-06-18T07:59:57Z fix hashCode() and equals() of BinaryType in Row --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- - To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
