Re: [TC4] How to know when tomcat is properly shut down?

2001-11-28 Thread Endre Stølsvik

On Thu, 29 Nov 2001, Mika Goeckel wrote:

| Hi,
|
| on a unix system, you could do something like
|
| if ps -efwww | grep "org.apache.catalina.startup.Bootstrap" | grep -vc
| "grep" >/dev/null;
| then echo "yes";
| else echo "no";
| fi
|
| the second grep is because grep might find it's own command line otherwise.
|
| hope that helps.

Hmm.. no, not really, but thanks for replying! :)

This is the obvious hack, but the underlying problem isn't solved. I
would like the Bootstrap class itself not to return until Tomcat has said
that it's properly down, basically that is is going to do System.exit() as
it's next instruction!

The same is true when going up. I'd like to know (maybe with a switch with
a timeout) when the system "is up", and that means when all the webapps
have started and so on.

Endre.

-- 
Mvh,
Endre


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-4.0/tester/web/golden SSIConditional01.txt SSIConditional02.txt SSIConditional03.txt SSIConditional04.txt SSIConditional05.txt SSIConditional06.txt SSIConditional07.txt SSIConditional08.txt SSIVarSub01.txt SSIVarSub02.txt SSIVarSub03.txt SSIVarSub04.txt SSIVarSub05.txt

2001-11-28 Thread amyroh

amyroh  01/11/28 19:53:00

  Added:   tester/web/golden SSIConditional01.txt SSIConditional02.txt
SSIConditional03.txt SSIConditional04.txt
SSIConditional05.txt SSIConditional06.txt
SSIConditional07.txt SSIConditional08.txt
SSIVarSub01.txt SSIVarSub02.txt SSIVarSub03.txt
SSIVarSub04.txt SSIVarSub05.txt
  Log:
  Server Side Include improvement tests.
  Submitted by Paul Speed <[EMAIL PROTECTED]>.
  
  Revision  ChangesPath
  1.1  jakarta-tomcat-4.0/tester/web/golden/SSIConditional01.txt
  
  Index: SSIConditional01.txt
  ===
  Before if block.
  
  
  test = value1
  
  After if block.
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/golden/SSIConditional02.txt
  
  Index: SSIConditional02.txt
  ===
  Before if block.
  
  
  test = value2
  
  After if block.
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/golden/SSIConditional03.txt
  
  Index: SSIConditional03.txt
  ===
  Before if block.
  
  
  test = "unquoted multi-word value"
  
  After if block.
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/golden/SSIConditional04.txt
  
  Index: SSIConditional04.txt
  ===
  
  
  
  
  true
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/golden/SSIConditional05.txt
  
  Index: SSIConditional05.txt
  ===
  
  
  
  
  false
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/golden/SSIConditional06.txt
  
  Index: SSIConditional06.txt
  ===
  
  
  
  
  
  not one
  
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/golden/SSIConditional07.txt
  
  Index: SSIConditional07.txt
  ===
  
  
  
  
  
  not two
  
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/golden/SSIConditional08.txt
  
  Index: SSIConditional08.txt
  ===
  
  
  
  
  two
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/golden/SSIVarSub01.txt
  
  Index: SSIVarSub01.txt
  ===
  
  /SSIVarSub01.shtml
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/golden/SSIVarSub02.txt
  
  Index: SSIVarSub02.txt
  ===
  
  
  value of test
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/golden/SSIVarSub03.txt
  
  Index: SSIVarSub03.txt
  ===
  
  
  
  value of test value of test2
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/golden/SSIVarSub04.txt
  
  Index: SSIVarSub04.txt
  ===
  
  
  
  value of test|value of test2
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/golden/SSIVarSub05.txt
  
  Index: SSIVarSub05.txt
  ===
  
  
  value of test\${test2}
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-4.0/tester/web includeme.shtml SSIConditional01.shtml SSIConditional02.shtml SSIConditional03.shtml SSIConditional04.shtml SSIConditional05.shtml SSIConditional06.shtml SSIConditional07.shtml SSIConditional08.shtml SSIVarSub01.shtml SSIVarSub02.shtml SSIVarSub03.shtml SSIVarSub04.shtml SSIVarSub05.shtml SSIVarSub06.shtml

2001-11-28 Thread amyroh

amyroh  01/11/28 19:52:28

  Added:   tester/web includeme.shtml SSIConditional01.shtml
SSIConditional02.shtml SSIConditional03.shtml
SSIConditional04.shtml SSIConditional05.shtml
SSIConditional06.shtml SSIConditional07.shtml
SSIConditional08.shtml SSIVarSub01.shtml
SSIVarSub02.shtml SSIVarSub03.shtml
SSIVarSub04.shtml SSIVarSub05.shtml
SSIVarSub06.shtml
  Log:
  Server Side Include improvement tests.
  Submitted by Paul Speed <[EMAIL PROTECTED]>.
  
  Revision  ChangesPath
  1.1  jakarta-tomcat-4.0/tester/web/includeme.shtml
  
  Index: includeme.shtml
  ===
  This is Content of "includeme.shtml"
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/SSIConditional01.shtml
  
  Index: SSIConditional01.shtml
  ===
  Before if block.
  
  
  test = value1
  
  test = value2
  
  test = neither value1 or value2
  
  After if block.
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/SSIConditional02.shtml
  
  Index: SSIConditional02.shtml
  ===
  Before if block.
  
  
  test = value1
  
  test = value2
  
  test = neither value1 or value2
  
  After if block.
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/SSIConditional03.shtml
  
  Index: SSIConditional03.shtml
  ===
  Before if block.
  
  
  test = "unquoted multi-word value"
  
  test = not "unquoted multi-word value"
  
  After if block.
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/SSIConditional04.shtml
  
  Index: SSIConditional04.shtml
  ===
  
  
  
  
  true
  
  false
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/SSIConditional05.shtml
  
  Index: SSIConditional05.shtml
  ===
  
  
  
  
  true
  
  false
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/SSIConditional06.shtml
  
  Index: SSIConditional06.shtml
  ===
  
  
  
  
  
  one
  
  not one
  
  
  
  two
  
  not two
  
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/SSIConditional07.shtml
  
  Index: SSIConditional07.shtml
  ===
  
  
  
  
  
  one
  
  not one
  
  
  
  two
  
  not two
  
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/SSIConditional08.shtml
  
  Index: SSIConditional08.shtml
  ===
  
  
  
  
  
  
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/SSIVarSub01.shtml
  
  Index: SSIVarSub01.shtml
  ===
  
  
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/SSIVarSub02.shtml
  
  Index: SSIVarSub02.shtml
  ===
  
  
  
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/SSIVarSub03.shtml
  
  Index: SSIVarSub03.shtml
  ===
  
  
  
  
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/SSIVarSub04.shtml
  
  Index: SSIVarSub04.shtml
  ===
  
  
  
  
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/SSIVarSub05.shtml
  
  Index: SSIVarSub05.shtml
  ===
  
  
  
  
  
  
  
  
  1.1  jakarta-tomcat-4.0/tester/web/SSIVarSub06.shtml
  
  Index: SSIVarSub06.shtml
  ===
  
  
  
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets SsiInvokerServlet.java

2001-11-28 Thread amyroh

amyroh  01/11/28 19:50:48

  Modified:catalina/src/share/org/apache/catalina/servlets
SsiInvokerServlet.java
  Log:
  Server Side Include improvement.
  Submitted by Paul Speed <[EMAIL PROTECTED]>.
  
  Revision  ChangesPath
  1.14  +72 -34
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/SsiInvokerServlet.java
  
  Index: SsiInvokerServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/SsiInvokerServlet.java,v
  retrieving revision 1.13
  retrieving revision 1.14
  diff -u -r1.13 -r1.14
  --- SsiInvokerServlet.java2001/11/13 00:09:41 1.13
  +++ SsiInvokerServlet.java2001/11/29 03:50:48 1.14
  @@ -1,8 +1,8 @@
   /*
* SsiInvokerServlet.java
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/SsiInvokerServlet.java,v
 1.13 2001/11/13 00:09:41 amyroh Exp $
  - * $Revision: 1.13 $
  - * $Date: 2001/11/13 00:09:41 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/SsiInvokerServlet.java,v
 1.14 2001/11/29 03:50:48 amyroh Exp $
  + * $Revision: 1.14 $
  + * $Date: 2001/11/29 03:50:48 $
*
* 
*
  @@ -99,7 +99,7 @@
*
* @author Bip Thelin
* @author Amy Roh
  - * @version $Revision: 1.13 $, $Date: 2001/11/13 00:09:41 $
  + * @version $Revision: 1.14 $, $Date: 2001/11/29 03:50:48 $
*/
   public final class SsiInvokerServlet extends HttpServlet {
   /** Debug level for this servlet. */
  @@ -321,12 +321,19 @@
   try {
   strCmd = parseCmd(command);
   } catch (IndexOutOfBoundsException ex) {
  +log( "Error parsing directive name." );
   out.print(ssiEnv.getConfiguration("errmsg"));
   continue;
   }
   
   strParamType = parseParamType(command, strCmd.length());
  -strParam = parseParam(command, strCmd.length());
  +strParam = parseParam(command, strCmd.length(),
  +  strParamType.length);
  +if (strParam == null) {
  +log( "Error parsing directive parameters." );
  +out.print(ssiEnv.getConfiguration("errmsg"));
  +continue;
  +}
   
   if(debug > 0)
   log("Serving SSI resource: " + strCmd);
  @@ -334,9 +341,10 @@
   // Run the command for the SSI directive
   ssiDispatcher.runCommand( strCmd, strParamType,
 strParam, ssiEnv, out );
  -
  +
   // Check to see if the output has been disabled
   disableOutput = ssiEnv.isOutputDisabled();
  +
   continue;
   }
   command.append((char)unparsed[bIdx]);
  @@ -359,7 +367,10 @@
   throws IndexOutOfBoundsException {
   
   String modString = ((cmd.toString()).trim()).toLowerCase();
  -return modString.substring(0, modString.indexOf(' '));
  +int end = modString.indexOf(' ');
  +if( end < 0 )
  +return modString;
  +return modString.substring(0, end);
   }
   
   /**
  @@ -390,20 +401,29 @@
   bIdx++;
   }
   
  -retBuf.append('"');
  +retBuf.append('=');
   inside=!inside;
   quotes=0;
   
  -while(bIdx < cmd.length()&"es!=2) {
  -if(cmd.charAt(bIdx)=='"')
  -quotes++;
  +boolean escaped=false;
  +for ( ; bIdx < cmd.length() && quotes != 2; bIdx++ ) {
  +char c = cmd.charAt(bIdx);
  +
  +// Need to skip escaped characters
  +if (c=='\\' && !escaped) {
  +escaped = true;
  +bIdx++;
  +continue;
  +}
  +escaped = false;
   
  -bIdx++;
  +if (c=='"')
  +quotes++;
   }
   }
   }
   
  -StringTokenizer str = new StringTokenizer(retBuf.toString(), "\"");
  +StringTokenizer str = new StringTokenizer(retBuf.toString(), "=");
   String[] retString = new String[str.countTokens()];
   
   while(str.hasMoreTokens()) {
  @@ -417,17 +437,18 @@
* Parse a StringBuffer and take out the param token.
* Called from requestHandler
* @para

cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/ssi AbstractSsiCommand.java ExpressionParseTree.java ExpressionTokenizer.java SsiConditional.java FileReference.java ResponseIncludeWrapper.java ServletOutputStreamWrapper.java SsiCommand.java SsiCommandException.java SsiConfig.java SsiDispatcher.java SsiEcho.java SsiEnvironment.java SsiExec.java SsiFlastmod.java SsiFsize.java SsiInclude.java SsiSet.java

2001-11-28 Thread amyroh

amyroh  01/11/28 19:41:27

  Modified:catalina/src/share/org/apache/catalina/util/ssi
FileReference.java ResponseIncludeWrapper.java
ServletOutputStreamWrapper.java SsiCommand.java
SsiCommandException.java SsiConfig.java
SsiDispatcher.java SsiEcho.java SsiEnvironment.java
SsiExec.java SsiFlastmod.java SsiFsize.java
SsiInclude.java SsiSet.java
  Added:   catalina/src/share/org/apache/catalina/util/ssi
AbstractSsiCommand.java ExpressionParseTree.java
ExpressionTokenizer.java SsiConditional.java
  Log:
  Server Side Include improvement.
  Submitted by Paul Speed <[EMAIL PROTECTED]>.
  
  Revision  ChangesPath
  1.2   +4 -4  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/ssi/FileReference.java
  
  Index: FileReference.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/ssi/FileReference.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -r1.1 -r1.2
  --- FileReference.java2001/10/26 19:35:23 1.1
  +++ FileReference.java2001/11/29 03:41:26 1.2
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/ssi/FileReference.java,v
 1.1 2001/10/26 19:35:23 bip Exp $
  - * $Revision: 1.1 $
  - * $Date: 2001/10/26 19:35:23 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/ssi/FileReference.java,v
 1.2 2001/11/29 03:41:26 amyroh Exp $
  + * $Revision: 1.2 $
  + * $Date: 2001/11/29 03:41:26 $
*
* 
*
  @@ -75,7 +75,7 @@
*  information can be used to retrieve the file as a resource
*  or to retrieve a request dispatcher, etc..
*
  - *  @version   $Revision: 1.1 $, $Date: 2001/10/26 19:35:23 $
  + *  @version   $Revision: 1.2 $, $Date: 2001/11/29 03:41:26 $
*  @authorPaul Speed
*/
   public class FileReference {
  
  
  
  1.5   +4 -4  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/ssi/ResponseIncludeWrapper.java
  
  Index: ResponseIncludeWrapper.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/ssi/ResponseIncludeWrapper.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- ResponseIncludeWrapper.java   2001/10/26 19:35:23 1.4
  +++ ResponseIncludeWrapper.java   2001/11/29 03:41:26 1.5
  @@ -1,8 +1,8 @@
   /*
* ResponseIncludeWrapper.java
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/ssi/ResponseIncludeWrapper.java,v
 1.4 2001/10/26 19:35:23 bip Exp $
  - * $Revision: 1.4 $
  - * $Date: 2001/10/26 19:35:23 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/ssi/ResponseIncludeWrapper.java,v
 1.5 2001/11/29 03:41:26 amyroh Exp $
  + * $Revision: 1.5 $
  + * $Date: 2001/11/29 03:41:26 $
*
* 
*
  @@ -74,7 +74,7 @@
* A HttpServletResponseWrapper, used from SsiInclude
*
* @author Bip Thelin
  - * @version $Revision: 1.4 $, $Date: 2001/10/26 19:35:23 $
  + * @version $Revision: 1.5 $, $Date: 2001/11/29 03:41:26 $
*/
   public final class ResponseIncludeWrapper
   extends HttpServletResponseWrapper {
  
  
  
  1.4   +4 -4  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/ssi/ServletOutputStreamWrapper.java
  
  Index: ServletOutputStreamWrapper.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/ssi/ServletOutputStreamWrapper.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- ServletOutputStreamWrapper.java   2001/10/26 19:35:23 1.3
  +++ ServletOutputStreamWrapper.java   2001/11/29 03:41:26 1.4
  @@ -1,8 +1,8 @@
   /*
* ServletOutputStreamWrapper.java
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/ssi/ServletOutputStreamWrapper.java,v
 1.3 2001/10/26 19:35:23 bip Exp $
  - * $Revision: 1.3 $
  - * $Date: 2001/10/26 19:35:23 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/util/ssi/ServletOutputStreamWrapper.java,v
 1.4 2001/11/29 03:41:26 amyroh Exp $
  + * $Revision: 1.4 $
  + * $Date: 2001/11/29 03:41:26 $
*
* 
*
  @@ -74,7 +74,7 @@
* from within SsiInclude
*
* @author Bip Thelin
  - * @version $Revision: 1.3 $, $Date: 2001/10/26 19:35:23 $
  

DO NOT REPLY [Bug 5173] - IllegalStateException not thrown if response out has been closed

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5173

IllegalStateException not thrown if response out has been closed

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||INVALID



--- Additional Comments From [EMAIL PROTECTED]  2001-11-28 19:57 ---
No error report will be displayed because the response has been closed, but the 
exception will be thrown and logged.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat RELEASE-NOTES-3.3.1.txt

2001-11-28 Thread billbarker

billbarker01/11/28 19:35:17

  Modified:.RELEASE-NOTES-3.3.1.txt
  Log:
  Update to document fixes to handling of invalid web.xml files and disabling JSP 
support.
  
  Revision  ChangesPath
  1.7   +7 -1  jakarta-tomcat/RELEASE-NOTES-3.3.1.txt
  
  Index: RELEASE-NOTES-3.3.1.txt
  ===
  RCS file: /home/cvs/jakarta-tomcat/RELEASE-NOTES-3.3.1.txt,v
  retrieving revision 1.6
  retrieving revision 1.7
  diff -u -r1.6 -r1.7
  --- RELEASE-NOTES-3.3.1.txt   2001/11/27 04:09:00 1.6
  +++ RELEASE-NOTES-3.3.1.txt   2001/11/29 03:35:17 1.7
  @@ -3,7 +3,7 @@
Release Notes
=
   
  -$Id: RELEASE-NOTES-3.3.1.txt,v 1.6 2001/11/27 04:09:00 larryi Exp $
  +$Id: RELEASE-NOTES-3.3.1.txt,v 1.7 2001/11/29 03:35:17 billbarker Exp $
   
   
   This document describes the changes that have been made since the
  @@ -34,6 +34,12 @@
   
 Fixed logic for response.encodeURL() so that it will work correctly 
 if the input URL includes an anchor tag.
  +
  +  Improved the handling of invalid web.xml files.  Now you get the same
  +  error messages everytime you parse the file.
  +
  +  Moved the setting of the default "*.jsp" mapping so that it is now 
  +  possible to entirely disable support for jsp files.
   
   Server:
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 5176] - getPathInfo() return wrong path info

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5176

getPathInfo() return wrong path info





--- Additional Comments From [EMAIL PROTECTED]  2001-11-28 19:48 ---
The code which calculates the pathInfo hasn't changed for more than one year.
I would suggest posting on tomcat-user with more information to make sure this 
is not a user error.
If you still think there's a problem, I would need a test case or a lot more 
details to investigate this further.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: [PATCH] TC 3.3 WebXmlReader.java

2001-11-28 Thread Bill Barker

Since I had the file open anyway, I've gone ahead and put this one in as
well.
- Original Message -
From: "Schreibman, David" <[EMAIL PROTECTED]>
To: "'Tomcat Developers List'" <[EMAIL PROTECTED]>
Sent: Friday, November 09, 2001 9:27 AM
Subject: RE: [PATCH] TC 3.3 WebXmlReader.java


> Ouch!  Here it is again without the lame null pointer exception :))
>
> -David
>
>
>
> > -Original Message-
> > From: Schreibman, David
> > Sent: Friday, November 02, 2001 1:04 PM
> > To: 'Tomcat Developers List'
> > Subject: RE: [PATCH] TC 3.3 WebXmlReader.java
> >
> >
> > Cool.
> >
> > If and when you decide to check it in, you might want to
> > consider this minor update applying the same logic to the
> > error handler's warning method.  The previously posted patch
> > only covered calls the to error handler's error and
> > fatalError methods.  I couldn't make up my mind as to whether
> > parser warnings should impose the same startup penalty but
> > now think it might be a good idea.
> >
> > -David
> >
> >
> >
> > > -Original Message-
> > > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
> > > Sent: Friday, November 02, 2001 8:33 AM
> > > To: Tomcat Developers List
> > > Subject: Re: [PATCH] TC 3.3 WebXmlReader.java
> > >
> > >
> > > On Fri, 2 Nov 2001, Bojan Smojver wrote:
> > >
> > > > Notice that here, only the second time around things go bad
> > > (at context
> > > > reload) and that's only sometimes. Normally, there is
> > nothing in the
> > > > logs. Weird...
> > > >
> > > > I'll have to dig into it to find out what it really is. I
> > > might apply
> > > > this patch to my local build, just to see if it makes any
> > > difference.
> > >
> > > The patch seems ok to me ( thanks David !) - I was planning
> > > to check it
> > > in. If you find any problem let me know.
> > >
> > > I added this 'validation mark' to avoid the expensive
> > > validation if the
> > > file was already validated before. Since tomcat can ( or
> > > should be able to
> > > ) tolerate some errors in web.xml everything should still
> > > work - but you
> > > get the warning that the file have errors like bad ordering
> > > of elements.
> > >
> > > Without the patch you get the warning only once ( or after each
> > > modification of web.xml ). With the patch you'll be warned on
> > > each server
> > > startup and the startup time will be longer until you fix web.xml -
> > > which should give time to read the warnings and be the punishment.
> > >
> > >
> > > Costin
> > >
> > >
> > >
> > > > > Some people I work with noticed that Tomcat was spitting
> > > out a web.xml
> > > > > validation error for their app, but only the first time
> > > they started up.
> > > > > This gave them the impression that everything was ok the
> > > second time.
> > > > >
> > > > > Well, I looked around a bit and found that WebXmlReader
> > > writes out a
> > > > > "validation mark" (webxmlval.txt) in the work directory.
> > > The timestamp of
> > > > > the validation mark is used as part of deciding whether
> > > to validate.  The
> > > > > thing is, this mark is written out even if web.xml was
> > > not valid so next
> > > > > time through validation is skipped.
> > > > >
> > > > > I'm not sure if this was done on purpose and I can even
> > > imagine an argument
> > > > > about not nagging more than once.  Still, in our case the
> > > disappearance of
> > > > > the validation errors brought about false confidence.
> > > > >
> > > > > In case this seems like a problem to anyone else, here's
> > > a patch that only
> > > > > writes out the validation mark if the XML parsed without
> > > errors.  That way
> > > > > you keep seeing the validation errors until you a)
> > > disable validation or b)
> > > > > fix the offending xml.
> > > > >
> > > > > Interestingly, this patch takes advantage of an unused
> > > boolean field in the
> > > > > error handler.  Makes me wonder if somebody already
> > > thought of this but
> > > > > decided not to deal with it.  Perhaps there was a good reason.
> > > > >
> > > > > Regards,
> > > > >
> > > > > -David
> > > > >
> > > > >
> > > > >
> > > > >
> > > --
> > > --
> > > > >
> > > > > --- WebXmlReader.java.orig Wed Oct 31 13:00:07 2001
> > > > > +++ WebXmlReader.java Wed Oct 31 12:12:55 2001
> > > > > @@ -99,7 +99,7 @@
> > > > >  static class WebXmlErrorHandler implements ErrorHandler{
> > > > >  Context ctx;
> > > > >  XmlMapper xm;
> > > > > - boolean ok;
> > > > > + boolean ok = true;
> > > > >  WebXmlErrorHandler( XmlMapper xm,Context ctx ) {
> > > > >  this.ctx=ctx;
> > > > >  this.xm=xm;
> > > > > @@ -113,16 +113,21 @@
> > > > >  public void error (SAXParseException exception)
> > > > >  throws SAXException
> > > > >  {
> > > > > + ok = false;
> > > > >  ctx.log("web.xml: Error " + exception );
> > > > >  ctx.log(xm.positionToString());
> > > > >  }
> > > > >  public void fatalError (SAXParseException excepti

cvs commit: jakarta-tomcat/src/facade22/org/apache/tomcat/facade WebXmlReader.java

2001-11-28 Thread billbarker

billbarker01/11/28 19:23:26

  Modified:src/facade22/org/apache/tomcat/facade WebXmlReader.java
  Log:
  Improve the handling of invalid web.xml files.
  
  With this fix, the web.xml parsing of an invalid file always generates the same 
error every time Tomcat is started.
  
  Submitted by: David Schreibman [EMAIL PROTECTED]
  
  Revision  ChangesPath
  1.16  +12 -3 
jakarta-tomcat/src/facade22/org/apache/tomcat/facade/WebXmlReader.java
  
  Index: WebXmlReader.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/facade22/org/apache/tomcat/facade/WebXmlReader.java,v
  retrieving revision 1.15
  retrieving revision 1.16
  diff -u -r1.15 -r1.16
  --- WebXmlReader.java 2001/11/29 03:06:05 1.15
  +++ WebXmlReader.java 2001/11/29 03:23:26 1.16
  @@ -98,7 +98,7 @@
   static class WebXmlErrorHandler implements ErrorHandler{
Context ctx;
XmlMapper xm;
  - boolean ok;
  + boolean ok=true;
WebXmlErrorHandler( XmlMapper xm,Context ctx ) {
this.ctx=ctx;
this.xm=xm;
  @@ -106,22 +106,28 @@
   
public void warning (SAXParseException exception)
throws SAXException {
  + ok=false;
ctx.log("web.xml: Warning " + exception );
ctx.log(xm.positionToString());
}
public void error (SAXParseException exception)
throws SAXException
{
  + ok=false;
ctx.log("web.xml: Error " + exception );
ctx.log(xm.positionToString());
}
public void fatalError (SAXParseException exception)
throws SAXException
{
  + ok=false;
ctx.log("web.xml: Fatal error " + exception );
ctx.log(xm.positionToString());
throw new SAXException( "Fatal error " + exception );
}
  + public boolean isOk() {
  + return ok;
  + }
   }
   
   void processWebXmlFile( Context ctx, String file) {
  @@ -133,13 +139,15 @@
}
if( ctx.getDebug() > 0 ) ctx.log("Reading " + file );
XmlMapper xh=new XmlMapper();
  + WebXmlErrorHandler xeh=null;
File v=new File( ctx.getWorkDir(), "webxmlval.txt" );
if( validate ) {
if( ! v.exists() || 
v.lastModified() < f.lastModified() ) {
ctx.log("Validating web.xml");
xh.setValidating(true);
  - xh.setErrorHandler( new WebXmlErrorHandler( xh, ctx ) );
  + xeh=new WebXmlErrorHandler( xh, ctx ); 
  + xh.setErrorHandler( xeh );
}
}
   
  @@ -229,7 +237,8 @@
   
Object ctx1=xh.readXml(f, ctx);
   
  - if( validate ) {
  + if( validate && xeh != null && xeh.isOk() ) {
  + // don't create the validation mark if an error was detected
try {
FileOutputStream fos=new FileOutputStream( v );
fos.write( 1 );
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core NamingContextListener.java

2001-11-28 Thread remm

remm01/11/28 19:12:52

  Modified:catalina/src/share/org/apache/catalina/core
NamingContextListener.java
  Log:
  - Fix message string name.
  
  Revision  ChangesPath
  1.5   +5 -5  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/NamingContextListener.java
  
  Index: NamingContextListener.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/NamingContextListener.java,v
  retrieving revision 1.4
  retrieving revision 1.5
  diff -u -r1.4 -r1.5
  --- NamingContextListener.java2001/11/29 02:36:05 1.4
  +++ NamingContextListener.java2001/11/29 03:12:52 1.5
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/NamingContextListener.java,v
 1.4 2001/11/29 02:36:05 remm Exp $
  - * $Revision: 1.4 $
  - * $Date: 2001/11/29 02:36:05 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/NamingContextListener.java,v
 1.5 2001/11/29 03:12:52 remm Exp $
  + * $Revision: 1.5 $
  + * $Date: 2001/11/29 03:12:52 $
*
* 
*
  @@ -116,7 +116,7 @@
* with each context and server.
*
* @author Remy Maucherat
  - * @version $Revision: 1.4 $ $Date: 2001/11/29 02:36:05 $
  + * @version $Revision: 1.5 $ $Date: 2001/11/29 03:12:52 $
*/
   
   public class NamingContextListener
  @@ -306,7 +306,7 @@
   (container, container, 
((Container) container).getLoader().getClassLoader());
   } catch (NamingException e) {
  -log(sm.getString("naming.namingContextBindingFailed", e));
  +log(sm.getString("naming.bindFailed", e));
   }
   
   if (container instanceof Server) {
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core LocalStrings.properties

2001-11-28 Thread remm

remm01/11/28 19:11:04

  Modified:catalina/src/share/org/apache/catalina/core
LocalStrings.properties
  Log:
  - Update naming-related strings.
  
  Revision  ChangesPath
  1.42  +5 -4  
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/LocalStrings.properties
  
  Index: LocalStrings.properties
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/LocalStrings.properties,v
  retrieving revision 1.41
  retrieving revision 1.42
  diff -u -r1.41 -r1.42
  --- LocalStrings.properties   2001/11/10 01:24:20 1.41
  +++ LocalStrings.properties   2001/11/29 03:11:04 1.42
  @@ -25,6 +25,11 @@
   httpHostMapper.container=This container is not a StandardHost
   interceptorValve.alreadyStarted=InterceptorValve has already been started
   interceptorValve.notStarted=InterceptorValve has not yet been started
  +naming.bindFailed=Failed to bind object: {0}
  +naming.unbindFailed=Failed to unbind object: {0}
  +naming.invalidEnvEntryType=Environment entry {0} has an invalid type
  +naming.invalidEnvEntryValue=Environment entry (0) has an invalid value
  +naming.namingContextCreationFailed=Creation of the naming context failed: {0}
   standardContext.alreadyStarted=Context has already been started
   standardContext.applicationListener=Error configuring application listener of class 
{0}
   standardContext.applicationSkipped=Skipped installing application listeners due to 
previous error(s)
  @@ -72,10 +77,6 @@
   standardContext.urlValidate=Cannot validate URL decoded request path {0}
   standardContext.wrapper.error=JSP file {0} must start with a '/'
   standardContext.wrapper.warning=WARNING: JSP file {0} must start with a '/' in 
Servlet 2.3
  -standardContext.invalidEnvEntryValue={0} environment entry has an invalid value for 
specified type
  -standardContext.invalidEnvEntryType={0} environment entry has an invalid type
  -standardContext.bindFailed=Bind naming operation failed : {0}
  -standardContext.namingInitFailed=Error initializing naming context for context {0}
   standardEngine.alreadyStarted=Engine has already been started
   standardEngine.mappingError=MAPPING configuration error for server name {0}
   standardEngine.noHost=No Host matches server name {0}
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 5176] New: - getPathInfo() return wrong path info

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5176

getPathInfo() return wrong path info

   Summary: getPathInfo() return wrong path info
   Product: Tomcat 4
   Version: 4.0.1 Final
  Platform: HP
OS/Version: Other
Status: NEW
  Severity: Blocker
  Priority: Other
 Component: HTTP/1.1 Connector
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I have a html page has:

and

Where ProcessRequest maps to a servlet.

request.getPathInfo() return /ActionLogin/style/pawsstyle.css  //wrong
request.getContextPath() return /PAWS/ProcessRequest/ActionLogin/ViewWelcome

getPathInfo is not working. It worked days ago.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: TC 3.3: For Servlets only

2001-11-28 Thread Bill Barker

I've checked in a change to move setting the default mapping to
JspInterceptor.  Now, all Bojan needs to do is to comment out JspInterceptor
in server.xml and all of his *.jsp files will be served as regular text
files.
- Original Message -
From: "Ignacio J. Ortega" <[EMAIL PROTECTED]>
To: "'Tomcat Developers List'" <[EMAIL PROTECTED]>; "'Bill
Barker'" <[EMAIL PROTECTED]>
Sent: Wednesday, November 28, 2001 1:06 PM
Subject: RE: TC 3.3: For Servlets only


> This calls for adding some kind of attribute noJsp="false" in
> WebXmlReader interceptor to not add "*.jsp" to every context..
>
> Saludos ,
> Ignacio J. Ortega
>
>
> > -Mensaje original-
> > De: Bill Barker [mailto:[EMAIL PROTECTED]]
> > Enviado el: jueves 22 de noviembre de 2001 21:42
> > Para: Tomcat Developers List
> > Asunto: Re: TC 3.3: For Servlets only
> >
> >
> > Commenting out JspInterceptor effectively removes JSP
> > support.  Now you
> > either need to define a "*.jsp" mapping in your web.xml, or hack
> > WebXmlReader (line 67 of "Final") so that it doesn't add a
> > default "*.jsp"
> > mapping.
> > - Original Message -
> > From: "Bojan Smojver" <[EMAIL PROTECTED]>
> > To: "Tomcat Dev List" <[EMAIL PROTECTED]>
> > Sent: Thursday, November 22, 2001 3:28 AM
> > Subject: TC 3.3: For Servlets only
> >
> >
> > > Two questions:
> > >
> > > - does anyone have experience with removing the JSP part
> > from TC (i.e.
> > > make TC 3.3 a servlet container only)?
> > > - would something like that actually break any licensing
> > agreements with
> > > Sun?
> > >
> > > Bojan
> > >
> > > --
> > > To unsubscribe, e-mail:
> > 
> > > For additional commands, e-mail:
> > 
> > >
> >
> >
> > **
> >
> > This message is intended only for the use of the person(s)
> > listed above
> > as the intended recipient(s), and may contain information that is
> > PRIVILEGED and CONFIDENTIAL.  If you are not an intended recipient,
> > you may not read, copy, or distribute this message or any
> > attachment.
> > If you received this communication in error, please notify us
> > immediately
> > by e-mail and then delete all copies of this message and any
> > attachments.
> >
> >
> > In addition you should be aware that ordinary (unencrypted)
> > e-mail sent
> > through the Internet is not secure. Do not send confidential
> > or sensitive
> > information, such as social security numbers, account
> > numbers, personal
> > identification numbers and passwords, to us via ordinary
> > (unencrypted)
> > e-mail.
> >
> > --
> > To unsubscribe, e-mail:
> 
> For additional commands, e-mail:
> 
>


**

This message is intended only for the use of the person(s) listed above 
as the intended recipient(s), and may contain information that is 
PRIVILEGED and CONFIDENTIAL.  If you are not an intended recipient, 
you may not read, copy, or distribute this message or any attachment.  
If you received this communication in error, please notify us immediately 
by e-mail and then delete all copies of this message and any attachments.


In addition you should be aware that ordinary (unencrypted) e-mail sent 
through the Internet is not secure. Do not send confidential or sensitive 
information, such as social security numbers, account numbers, personal 
identification numbers and passwords, to us via ordinary (unencrypted) 
e-mail. 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat/src/facade22/org/apache/tomcat/facade JspInterceptor.java WebXmlReader.java

2001-11-28 Thread billbarker

billbarker01/11/28 19:06:05

  Modified:src/facade22/org/apache/tomcat/facade JspInterceptor.java
WebXmlReader.java
  Log:
  Rationalize the setting of the default mapping for JSP pages.
  
  With this code move, only JspInterceptor knows anything about JSP pages.  In 
particular, removing JspInterceptor from server.xml disables all support for *.jsp 
files.
  
  Revision  ChangesPath
  1.32  +3 -0  
jakarta-tomcat/src/facade22/org/apache/tomcat/facade/JspInterceptor.java
  
  Index: JspInterceptor.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/facade22/org/apache/tomcat/facade/JspInterceptor.java,v
  retrieving revision 1.31
  retrieving revision 1.32
  diff -u -r1.31 -r1.32
  --- JspInterceptor.java   2001/11/27 03:54:35 1.31
  +++ JspInterceptor.java   2001/11/29 03:06:05 1.32
  @@ -298,6 +298,9 @@
   public void contextInit(Context ctx)
throws TomcatException
   {
  + if(ctx.getContainer("*.jsp") == null)
  + ctx.addServletMapping( "*.jsp", "jsp");
  +
if( useJspServlet ) {
// prepare jsp servlet. 
Handler jasper=ctx.getServletByName( "jsp" );
  
  
  
  1.15  +0 -1  
jakarta-tomcat/src/facade22/org/apache/tomcat/facade/WebXmlReader.java
  
  Index: WebXmlReader.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat/src/facade22/org/apache/tomcat/facade/WebXmlReader.java,v
  retrieving revision 1.14
  retrieving revision 1.15
  diff -u -r1.14 -r1.15
  --- WebXmlReader.java 2001/09/29 04:28:22 1.14
  +++ WebXmlReader.java 2001/11/29 03:06:05 1.15
  @@ -64,7 +64,6 @@

try {
// Defaults 
  - ctx.addServletMapping( "*.jsp", "jsp");
ctx.setSessionTimeOut( 30 );
   
// We may read a "default" web.xml from INSTALL/conf/web.xml -
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core NamingContextListener.java

2001-11-28 Thread remm

remm01/11/28 18:36:05

  Modified:catalina/src/share/org/apache/catalina/core
NamingContextListener.java
  Log:
  - Implement the container listener, so that the naming context can be modified
dynamically.
  
  Revision  ChangesPath
  1.4   +155 -24   
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/NamingContextListener.java
  
  Index: NamingContextListener.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/NamingContextListener.java,v
  retrieving revision 1.3
  retrieving revision 1.4
  diff -u -r1.3 -r1.4
  --- NamingContextListener.java2001/11/10 00:31:04 1.3
  +++ NamingContextListener.java2001/11/29 02:36:05 1.4
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/NamingContextListener.java,v
 1.3 2001/11/10 00:31:04 remm Exp $
  - * $Revision: 1.3 $
  - * $Date: 2001/11/10 00:31:04 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/core/NamingContextListener.java,v
 1.4 2001/11/29 02:36:05 remm Exp $
  + * $Revision: 1.4 $
  + * $Date: 2001/11/29 02:36:05 $
*
* 
*
  @@ -116,7 +116,7 @@
* with each context and server.
*
* @author Remy Maucherat
  - * @version $Revision: 1.3 $ $Date: 2001/11/10 00:31:04 $
  + * @version $Revision: 1.4 $ $Date: 2001/11/29 02:36:05 $
*/
   
   public class NamingContextListener
  @@ -355,33 +355,130 @@
   String type = event.getType();
   
   if (type.equals("addEjb")) {
  -
  +
  +String ejbName = (String) event.getData();
  +if (ejbName != null) {
  +ContextEjb ejb = namingResources.findEjb(ejbName);
  +addEjb(ejb);
  +}
  +
   } else if (type.equals("addEnvironment")) {
  -
  -} else if (type.equals("addResourceParams")) {
  -
  +
  +String environmentName = (String) event.getData();
  +if (environmentName != null) {
  +ContextEnvironment env = 
  +namingResources.findEnvironment(environmentName);
  +addEnvironment(env);
  +}
  +
  +} else if ((type.equals("addResourceParams")) 
  +   || (type.equals("removeResourceParams"))) {
  +
  +String resourceParamsName = (String) event.getData();
  +if (resourceParamsName != null) {
  +ContextEjb ejb = namingResources.findEjb(resourceParamsName);
  +if (ejb != null) {
  +removeEjb(resourceParamsName);
  +addEjb(ejb);
  +}
  +ContextResource resource = 
  +namingResources.findResource(resourceParamsName);
  +if (resource != null) {
  +removeResource(resourceParamsName);
  +addResource(resource);
  +}
  +String resourceEnvRefValue = 
  +namingResources.findResourceEnvRef(resourceParamsName);
  +if (resourceEnvRefValue != null) {
  +removeResourceEnvRef(resourceParamsName);
  +addResourceEnvRef(resourceParamsName, resourceEnvRefValue);
  +}
  +ContextResourceLink resourceLink = 
  +namingResources.findResourceLink(resourceParamsName);
  +if (resourceLink != null) {
  +removeResourceLink(resourceParamsName);
  +addResourceLink(resourceLink);
  +}
  +}
  +
   } else if (type.equals("addLocalEjb")) {
  -
  +
  +String localEjbName = (String) event.getData();
  +if (localEjbName != null) {
  +ContextLocalEjb localEjb = 
  +namingResources.findLocalEjb(localEjbName);
  +addLocalEjb(localEjb);
  +}
  +
   } else if (type.equals("addResource")) {
  -
  +
  +String resourceName = (String) event.getData();
  +if (resourceName != null) {
  +ContextResource resource = 
  +namingResources.findResource(resourceName);
  +addResource(resource);
  +}
  +
   } else if (type.equals("addResourceLink")) {
  -
  +
  +String resourceLinkName = (String) event.getData();
  +if (resourceLinkName != null) {
  +ContextResourceLink resourceLink = 
  +namingResources.findResourceLink(resourceLinkName);
  +addResourceLink(resourceLink);
  +}
  +
   } else if (type.eq

Re: [VOTE] Tomcat 4.0.2 Release Plan

2001-11-28 Thread Remy Maucherat

> [EMAIL PROTECTED] wrote:
> > - backporting the 'trusted apps having access to catalina internals'
from
> > 4.1
>
> How exactly is the 'trusted apps having access to catalina internals'
implemented?

The parent CL is the Catalina CL (instead of being the shared CL).

> Recently some of that code in the WebappClassLoader was reverted after I
demonstrated
> that the Java SecurityManager and a catalina.policy could prevent access
to
> catalina internals.  I also posted a proposal last week recommending some
changes
> in where the servlet jar files were located to make it easier to write a
policy
> file and prevent inadvertant granting of AllPermission to servlets in
> $CATALINA_HOME/server/lib.  IMHO, if the SecurityManager is used, it is
the
> only thing that would be needed to control security of 'trusted apps'.
> At one point Craig and I discussed making use of the Java SecurityManager
the
> default way to start Tomcat 4.

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 5174] New: - entropy value computed but not used in org.apache.catalina.authenticator.AuthenticatorBase

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5174

entropy value computed but not used in 
org.apache.catalina.authenticator.AuthenticatorBase

   Summary: entropy value computed but not used in
org.apache.catalina.authenticator.AuthenticatorBase
   Product: Tomcat 4
   Version: 4.0.1 Final
  Platform: All
OS/Version: All
Status: NEW
  Severity: Minor
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


in method catalina.authenticator.AuthenticatorBase.getRandom()
the seed value is calculated but not then used.

method is probably missing the final this.random.setSeed(seed); call
after line 851.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Emulating JServ's session.topleveldomain with Catalina

2001-11-28 Thread Daniel Rall

Daniel Rall <[EMAIL PROTECTED]> writes:

> [This was originally sent to tomcat-user, but is probably better
> discussed on tomcat-dev.]
>
> Why does the Valve implementation at the bottom of this message never
> print out any session cookies?

To answer myself (as addressed by my recent patch), because the
session cookie is added via the sendHeaders() method of
HttpResponseBase AFTER the Pipeline finishes processing.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Disable Refresh Function in IE

2001-11-28 Thread Mika Goeckel

Tom,

there may be some application, where such behavior is expensive, i.e. hit
the 'acknowledge credit card charge' button twice.
The worker servlet would have the requests first, so it has to intercept the
second. As the out stream of the first is gone in the view of the browser,
you would need clever logic. I.e. rollback the transaction of the first and
execute the second as if nothing special happened.

M.
^X^S
- Original Message -
From: "Tomas Rokicki" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Wednesday, November 28, 2001 8:32 PM
Subject: RE: Disable Refresh Function in IE


> You can't really avoid refresh.
>
> Consider that people can double-click on a submit button or
> link, quite inadverdantly, and your server sees it as two
> submissions but you only get the second response.
>
> Other than the timing, there is very little to distinguish this
> >from hitting the refresh button.
>
> If the server refuses to serve refresh requests, well, you've
> just broken anyone with a slow finger on the mouse.
>
> (And yes, some people still double-click links intentionally
> because you double-click to launch on Windows and why should
> the Web be any different?  True these people are typically
> moms and pops, but everyone's got them, right?  Parents, that
> is?)
>
> -tom
>
> -Original Message-
> From: Denis Balazuc [mailto:[EMAIL PROTECTED]]
> Sent: Wednesday, November 28, 2001 11:28 AM
> To: Tomcat Developers List
> Subject: Re: Disable Refresh Function in IE
>
>
> No, there's no way to disable any of the browser's buttons such as
Refresh,
> Back or Forward
>
> The only way to prevent a refresh is to maintain some flag when you serve
> requests, but even this is hardly feasible.
> I'd love to hear about a clean solution on that topicWe need to avoid
> people from refreshing pages too
>
> - Original Message -
> From: "Bala Nemani" <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Sent: Wednesday, November 28, 2001 12:54 PM
> Subject: Disable Refresh Function in IE
>
>
> > Hi:
> >
> > Is there a way to disable REFRESH functionality. I.e. not just
> > hiding the Refresh button but disable the refresh functionality it self
> (F5
> > function key also).
> >
> > Thanks
> >
> >
> > --
> > To unsubscribe, e-mail:
> 
> > For additional commands, e-mail:
> 
> >
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: [TC4] How to know when tomcat is properly shut down?

2001-11-28 Thread Mika Goeckel

Hi,

on a unix system, you could do something like

if ps -efwww | grep "org.apache.catalina.startup.Bootstrap" | grep -vc
"grep" >/dev/null;
then echo "yes";
else echo "no";
fi

the second grep is because grep might find it's own command line otherwise.

hope that helps.

Cheers, Mika

- Original Message -
From: "Endre Stølsvik" <[EMAIL PROTECTED]>
To: "Tomcat developer list" <[EMAIL PROTECTED]>
Sent: Wednesday, November 28, 2001 6:53 PM
Subject: [TC4] How to know when tomcat is properly shut down?


> This did not get answered the first time, so I'll try again!! Better luck
> this time? Please??
>
> --
> Mvh,
> Endre
>
> -- Forwarded message --
> Date: Wed, 21 Nov 2001 09:10:54 +0100 (MET)
> From: Endre Stølsvik <[EMAIL PROTECTED]>
> Reply-To: Tomcat Developers List <[EMAIL PROTECTED]>
> To: Tomcat developer list <[EMAIL PROTECTED]>
> Subject: [TC4] How to know when tomcat is properly shut down? (fwd)
>
> Since nobody answered on tomcat-user, I'll just forward this one here
> (since I think it actually belongs here in the first place..)
>
> -- Forwarded message --
> Date: Tue, 20 Nov 2001 18:14:20 +0100 (MET)
> From: Endre Stølsvik <[EMAIL PROTECTED]>
> Reply-To: Tomcat Users List <[EMAIL PROTECTED]>
> To: Tomcat user list <[EMAIL PROTECTED]>
> Subject: [TC4] How to know when tomcat is properly shut down?
>
> The catalina.sh and related scripts all start the Bootstrap.java class and
> asks it to shut down Catalina.
>
> This script, if successful in connecting to the shutdown port of Catalina,
> returns immediately. This whether or not there is 8953289527 pending
> database commits or whatever that has to be done before things actually
> are properly shut down.
>
> This is highly undesirable, and I would love if it were possible to shut
> down catalina and then chill untill it actually has shut down.
>
> This is especially important when shutting down the entire server, as the
> database shutdown might be the next in line, in which case everything
> breaks..
>
> Of course, it would also be very nice if one could know if Catalina has
> properly come up. It could for example write a "boolean file" when the
> server has initialized all webapps, and then delete the same file right
> before the main method of Catalina exits on shutdown. Or one could use
> Bootstrap with argument -waitForUp or something..
> ---
>
> And yes, Henri's init.d scripts also just fake this, waiting in just 2
> seconds, which is too short time, and therefore the "restart" option of
> the init.d script is flawed. The shutdown part of it doesn't wait at all,
> so you might end up shutting the server physically down (read as: killing
> all the java threads w/o cleaning up) before tomcat has finished shutting
> down.
>
> Mvh,
> Endre
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: [VOTE] Tomcat 4.0.2 Release Plan

2001-11-28 Thread Ryan Lubke

Hi Andrew,

Take a look at the following URL:
http://jakarta.apache.org/site/getinvolved.html


On Wed, 2001-11-28 at 19:10, Andrew Bruno wrote:
> How can this kind of documentation be inclcuded?
> 
> http://www.vacodi.com/howto/tomcat/iisnt/
> 
> I am happy to do some extra work (fix some content, etc..), but what
> standard and process do I follow? if there is one?  How can it be
> submitted by me? or anyone else is welcome to grab it, and put in CVS,
> docs, etc

Basically you would create a documentation patch of some sort from the 
anon CVS tree which you could submit to the developer list.  A committer
monitoring the list would apply the patch to the CVS tree if
appropriate.

> 
> If it were included in the next release it would help a lot of people,
> and hopefully reduce some traffic on the tomcat-user mailing list.
> 
> Regards, Andrew
> 
> 
Hope this helps. 



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Disable Refresh Function in IE

2001-11-28 Thread Mika Goeckel

Hi,

the way to do that, is to create a rigid state model of your application and
use a centralized worker servlet (hide all other pages/jsps/servlets from
the user).
Struts gives the framwork for that.

Mika

- Original Message -
From: "Denis Balazuc" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Wednesday, November 28, 2001 8:27 PM
Subject: Re: Disable Refresh Function in IE


> No, there's no way to disable any of the browser's buttons such as
Refresh,
> Back or Forward
>
> The only way to prevent a refresh is to maintain some flag when you serve
> requests, but even this is hardly feasible.
> I'd love to hear about a clean solution on that topicWe need to avoid
> people from refreshing pages too
>
> - Original Message -
> From: "Bala Nemani" <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Sent: Wednesday, November 28, 2001 12:54 PM
> Subject: Disable Refresh Function in IE
>
>
> > Hi:
> >
> > Is there a way to disable REFRESH functionality. I.e. not just
> > hiding the Refresh button but disable the refresh functionality it self
> (F5
> > function key also).
> >
> > Thanks
> >
> >
> > --
> > To unsubscribe, e-mail:
> 
> > For additional commands, e-mail:
> 
> >
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: [VOTE] Tomcat 4.0.2 Release Plan

2001-11-28 Thread Andrew Bruno

How can this kind of documentation be inclcuded?

http://www.vacodi.com/howto/tomcat/iisnt/

I am happy to do some extra work (fix some content, etc..), but what
standard and process do I follow? if there is one?  How can it be
submitted by me? or anyone else is welcome to grab it, and put in CVS,
docs, etc

If it were included in the next release it would help a lot of people,
and hopefully reduce some traffic on the tomcat-user mailing list.

Regards, Andrew





> -Original Message-
> From: Endre Stølsvik [mailto:[EMAIL PROTECTED]]
> Sent: Thursday, 29 November 2001 5:06 AM
> To: Tomcat Developers List
> Subject: Re: [VOTE] Tomcat 4.0.2 Release Plan
> 
> 
> On Wed, 28 Nov 2001, GOMEZ Henri wrote:
> 
> | What about mod_webapp SNAPSHOT for this release ?
> 
> Yes, PLEASE do so. I hate this stuff. It's awful. I'm trying 
> to compile,
> to get this stuff to work, but I don't know if I'm getting the right
> stuff, just checking it out from the CVS and all..
> 
> A "release" of the mod_webapp would be nice, and hopefully 
> also a couple
> of builds towards that different API/EAPI stuff.. ("Yes, I'm using the
> build which is distributed with the 4.0.2 release")
> 
> ..
> 
> -- 
> Mvh,
> Endre
> 
> 
> --
> To unsubscribe, e-mail:   
> 
> For additional commands, e-mail: 
> 
> 
> 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 3784] - Long URLs cause ArrayIndexOutOfBoundsException

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=3784

Long URLs cause ArrayIndexOutOfBoundsException

[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]



--- Additional Comments From [EMAIL PROTECTED]  2001-11-28 15:45 ---
*** Bug 5171 has been marked as a duplicate of this bug. ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 5171] - ContextManager: Error reading request, ignored - java.lang.ArrayIndexOutOfBoundsException: 2048

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5171

ContextManager: Error reading request, ignored - 
java.lang.ArrayIndexOutOfBoundsException: 2048

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2001-11-28 15:45 ---


*** This bug has been marked as a duplicate of 3784 ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 5173] New: - IllegalStateException not thrown if response out has been closed

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5173

IllegalStateException not thrown if response out has been closed

   Summary: IllegalStateException not thrown if response out has
been closed
   Product: Tomcat 4
   Version: 4.0.1 Final
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


IllegalStateException not thrown if response out has been closed

The following simplified code finds problem.

in MainServlet.java
{

doProcess(request, response); //inside this method, it has closed response
context.getRequestDispacher("/test.jsp").forward(request, response); 
}

The above code should generate some exception.
Tomcat gave a blank page instead giving error.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




SSL

2001-11-28 Thread Natascha Petry Ligocki

Hi,

Does anyone have succesfully imported a certificate with TOMCAT?
I follow the documentation steps using J2SSE and OPENSSL, and tried
to import Verisign and Thawte trials. The server startup but when
I tried to access the page as https://127.0.0.1:8443 nothing comes
up and the page couldn´t retrieved.

I look up all over the net but I couldn´t find anything to help me.

Thanks.

Natascha.


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 5171] New: - ContextManager: Error reading request, ignored - java.lang.ArrayIndexOutOfBoundsException: 2048

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5171

ContextManager: Error reading request, ignored - 
java.lang.ArrayIndexOutOfBoundsException: 2048

   Summary: ContextManager: Error reading request, ignored -
java.lang.ArrayIndexOutOfBoundsException: 2048
   Product: Tomcat 3
   Version: 3.2 Final
  Platform: PC
OS/Version: Windows NT/2K
Status: NEW
  Severity: Blocker
  Priority: Other
 Component: Servlet
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I have a html table which displays  104 rows approximately each column of the 
HTML row has some form elements like check boxes, textfield and dropdowns.
When I am editing these rows and trying to save the edits, I am getting this 
exception.
 ContextManager: Error reading request, ignored - 
java.lang.ArrayIndexOutOfBoundsException: 2048

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




[PATCH] Proposed Fix for Bugzilla 5169

2001-11-28 Thread Ryan Lubke

Synopsis of 5169:

   JavaServer Pages Specification 1.2, Section JSP.8.4.2:

   The "jsp_precompile" parameter may have no value, or may
   have the values "true" or "false".  In all cases, the 
   request should not be delivered to the JSP page.

   With Tomcat, if the jsp_precompile parameter is false, the 
   request is delivered to the target JSP page.  This is a 
   violation of the spec.

The issue seems to lie in org/apache/jasper/servlet/JspServlet.java.

During the processing of the request parameters, if the jsp_precompile
value evaluated to false, the preCompile method would return false.
Because of this, the service method in the JspServletWrapper class
would not return as the precompile value passed was false.

The attached simple patch seems to resolve the issue running what tests
I have.

Comments welcome.

Thanks,

-rl



Index: JspServlet.java
===
RCS file: 
/home/cvspublic/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/servlet/JspServlet.java,v
retrieving revision 1.24
diff -u -r1.24 JspServlet.java
--- JspServlet.java 2001/11/28 17:26:08 1.24
+++ JspServlet.java 2001/11/28 21:40:18
@@ -422,7 +422,7 @@
 if (value.equals("true"))
 return (true); // ?jsp_precompile=true
 else if (value.equals("false"))
-return (false);// ?jsp_precompile=false
+return (true);// ?jsp_precompile=false
 else
 throw new ServletException("Cannot have request parameter " +
Constants.PRECOMPILE + " set to " +



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 


[PATCH] SSI support

2001-11-28 Thread Paul Speed

Hello,

I'm posting my SSI patches again since the CVS versions have changed
since I last posted them.  This latest version has Amy Roh's most
recent changes merged into it.  The description is the same as in the
quoted e-mail.  I'm going ahead and including all.zip which contains
the various patches in case the nice committer that gets to this 
doesn't feel like hitting the web link. :)  Here is the description 
of what all.zip contains (also from the web page linked below):

SsiInvokerServlet.diff
diff -u output for the org.apache.catalina.servlets.SsiInvokerServlet.
This patch should be independent of the others since it just fixes
some SSI directive parsing issues. 

new_classes.zip 
4 new .java files for the org.apache.catalina.util.ssi package. 
Note: I did not add apache headers to these files since I
 didn't think it was appropriate for a non-committer to do so. 

util_ssi.diff 
The diff -u output for many of the other files in the 
org.apache.catalina.util.ssi package. 

tester_web.zip 
New files for the tester/web directory. Includes files for the 
tester/web/golden directory as well... all relative to tester/web. 

tester.diff 
diff -u output for src/bin/tester.xml. It adds the appropriate 
directives for the tests added from tester_web.zip. 

My interest in seeing these changes committed is two-fold:
1) I'd like to know if there are any problems that may require
   my help to resolve.
2) I have some additional changes I'd like to propose at some
   point but I don't want to make my patch set any larger than
   it already is. :)  Specifically, I want to lock down the
   "exec" directive so that SSI can be safely/securely deployed by 
   default.

If someone looks at this stuff and finds something wrong, then
please let me know.  Thanks.
-Paul Speed

Paul Speed wrote:
> 
> Hello,
> 
> I realize Bip is away, but I thought I'd post these anyway before I
> forget about them.  Since I've had problems with multiple attachments
> I went ahead and stuck the files on my web site at:
> 
> http://www.progeeks.com/pspeed/tomcat/SSIPatches.html
> 
> Each file has a description of what it contains and where it should
> go.  If a committer chooses to apply them and has problems then let
> me know.
> 
> Here is the description of the changes from the above-linked page:
> 
> >
> > What I did...
> >
> > The changes to SsiInvokerServlet should be independent of the other
> > changes. Really, I just improved parsing support to handle escaped
> > characters, etc. and be more error-compatible with Apache.
> >
> > The other SSI commands were modified to be more compatible with
> > Apache SSI. Specifically, I've verified that the supported tags
> > should work the same as mod_include in Apache 1.3.22. At least they
> > support the same options. The tags were also enhanced to fit with the
> > new conditional tags.
> >
> > I also added the implementation of the conditional tags: "if",
> > "elif", "else", and "endif". This includes an expression parser.
> > It's been a while since I've written a parser and I tried to do it
> > with a slant on understandability. There's probably room for
> > improvement, but it works the same as Apache on all of the tests
> > I've tried... and it passed all of the new tester pages which
> > generate identical output to Apache 1.3.22.
> >
> > So after these patches, the only tags that are missing that
> > mod_include has are "printenv" and "perl" (which is conditionally
> > included anyway).  Also, the "encoding" parameter on "echo" is
> > silently ignored right now.
> >
> 
> Thanks,
> -Paul Speed
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 


all.zip
Description: Zip compressed data

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 


cvs commit: jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets DefaultServlet.java

2001-11-28 Thread remm

remm01/11/28 13:10:45

  Modified:catalina/src/share/org/apache/catalina/servlets
DefaultServlet.java
  Log:
  - Add support for upload resuming, which can be useful when uploading
large files over the internet.
  - Based on a patch submitted to the Slide project by Mike Gartrell 
  
  Revision  ChangesPath
  1.45  +165 -13   
jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
  
  Index: DefaultServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java,v
  retrieving revision 1.44
  retrieving revision 1.45
  diff -u -r1.44 -r1.45
  --- DefaultServlet.java   2001/11/16 22:53:01 1.44
  +++ DefaultServlet.java   2001/11/28 21:10:45 1.45
  @@ -1,7 +1,7 @@
   /*
  - * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java,v
 1.44 2001/11/16 22:53:01 patrickl Exp $
  - * $Revision: 1.44 $
  - * $Date: 2001/11/16 22:53:01 $
  + * $Header: 
/home/cvs/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java,v
 1.45 2001/11/28 21:10:45 remm Exp $
  + * $Revision: 1.45 $
  + * $Date: 2001/11/28 21:10:45 $
*
* 
*
  @@ -73,6 +73,7 @@
   import java.io.InputStream;
   import java.io.IOException;
   import java.io.PrintWriter;
  +import java.io.RandomAccessFile;
   import java.io.Reader;
   import java.io.InputStreamReader;
   import java.io.Writer;
  @@ -123,7 +124,7 @@
*
* @author Craig R. McClanahan
* @author Remy Maucherat
  - * @version $Revision: 1.44 $ $Date: 2001/11/16 22:53:01 $
  + * @version $Revision: 1.45 $ $Date: 2001/11/28 21:10:45 $
*/
   
   public class DefaultServlet
  @@ -234,6 +235,12 @@
'A', 'B', 'C', 'D', 'E', 'F'};
   
   
  +/**
  + * Size of file transfer buffer in bytes.
  + */
  +private static final int BUFFER_SIZE = 4096;
  +
  +
   // - Static Initializer
   
   
  @@ -582,12 +589,6 @@
   return;
   }
   
  -// Looking for a Content-Range header
  -if (req.getHeader("Content-Range") != null) {
  -// No content range header is supported
  -resp.sendError(HttpServletResponse.SC_NOT_IMPLEMENTED);
  -}
  -
   // Retrieve the resources
   DirContext resources = getResources();
   
  @@ -604,8 +605,31 @@
   }
   
   boolean result = true;
  +
  +// Temp. content file used to support partial PUT
  +File contentFile = null;
  +
  +// Input stream for temp. content file used to support partial PUT
  +FileInputStream contentFileInStream = null;
  +
  +ResourceInfo resourceInfo = new ResourceInfo(path, resources);
  +Range range = parseContentRange(req, resp);
  +
  +InputStream resourceInputStream = null;
  +
  +// Append data specified in ranges to existing content for this
  +// resource - create a temp. file on the local filesystem to
  +// perform this operation
  +// Assume just one range is specified for now
  +if (range != null) {
  +contentFile = executePartialPut(req, range, path);
  +resourceInputStream = new FileInputStream(contentFile);
  +} else {
  +resourceInputStream = req.getInputStream();
  +}
  +
   try {
  -Resource newResource = new Resource(req.getInputStream());
  +Resource newResource = new Resource(resourceInputStream);
   // FIXME: Add attributes
   if (exists) {
   resources.rebind(path, newResource);
  @@ -630,6 +654,73 @@
   
   
   /**
  + * Handle a partial PUT.  New content specified in request is appended to 
  + * existing content in oldRevisionContent (if present). This code does 
  + * not support simultaneous partial updates to the same resource.
  + */
  +protected File executePartialPut(HttpServletRequest req, Range range, 
  + String path) 
  +throws IOException {
  +
  +// Append data specified in ranges to existing content for this
  +// resource - create a temp. file on the local filesystem to
  +// perform this operation
  +File tempDir = (File) getServletContext().getAttribute
  +("javax.servlet.context.tempdir");
  +// Convert all '/' characters to '.' in resourcePath
  +String convertedResourcePath = path.replace('/', '.');
  +File contentFile = new File(tempDir, convertedResourcePath);
  +if (contentFile.createNewFile()) {
  +// Clean up contentFile when Tomcat is terminated
  +contentFile

RE: TC 3.3: For Servlets only

2001-11-28 Thread Ignacio J. Ortega

This calls for adding some kind of attribute noJsp="false" in
WebXmlReader interceptor to not add "*.jsp" to every context..

Saludos ,
Ignacio J. Ortega


> -Mensaje original-
> De: Bill Barker [mailto:[EMAIL PROTECTED]]
> Enviado el: jueves 22 de noviembre de 2001 21:42
> Para: Tomcat Developers List
> Asunto: Re: TC 3.3: For Servlets only
> 
> 
> Commenting out JspInterceptor effectively removes JSP 
> support.  Now you
> either need to define a "*.jsp" mapping in your web.xml, or hack
> WebXmlReader (line 67 of "Final") so that it doesn't add a 
> default "*.jsp"
> mapping.
> - Original Message -
> From: "Bojan Smojver" <[EMAIL PROTECTED]>
> To: "Tomcat Dev List" <[EMAIL PROTECTED]>
> Sent: Thursday, November 22, 2001 3:28 AM
> Subject: TC 3.3: For Servlets only
> 
> 
> > Two questions:
> >
> > - does anyone have experience with removing the JSP part 
> from TC (i.e.
> > make TC 3.3 a servlet container only)?
> > - would something like that actually break any licensing 
> agreements with
> > Sun?
> >
> > Bojan
> >
> > --
> > To unsubscribe, e-mail:
> 
> > For additional commands, e-mail:
> 
> >
> 
> 
> **
> 
> This message is intended only for the use of the person(s) 
> listed above 
> as the intended recipient(s), and may contain information that is 
> PRIVILEGED and CONFIDENTIAL.  If you are not an intended recipient, 
> you may not read, copy, or distribute this message or any 
> attachment.  
> If you received this communication in error, please notify us 
> immediately 
> by e-mail and then delete all copies of this message and any 
> attachments.
> 
> 
> In addition you should be aware that ordinary (unencrypted) 
> e-mail sent 
> through the Internet is not secure. Do not send confidential 
> or sensitive 
> information, such as social security numbers, account 
> numbers, personal 
> identification numbers and passwords, to us via ordinary 
> (unencrypted) 
> e-mail. 
> 
> --
> To unsubscribe, e-mail:   

For additional commands, e-mail:



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: [VOTE] New Committer: Jazmin Jonson

2001-11-28 Thread Patrick Luby

+1

Patrick

Amy Roh wrote:
> 
> As Bill Barker suggested, I would like to propose Jazmin Jonson as a new
> committer.
> 
> She has contributed a numerous patches to Tomcat4 admin application.
> 
> Votes please?
> 
> Amy Roh
> 
> --
> To unsubscribe, e-mail:   
> For additional commands, e-mail: 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Mod_webapp & Solaris 8

2001-11-28 Thread Aaron Bannert

On Wed, Nov 28, 2001 at 03:30:38PM -0500, Matt Goyer wrote:
> I've got both binutils and libtool installed.
> 
> How do I get it to use the GNU linker instead? Though 'ld -v' tells me
> ld -v 'GNU ld version 2.11.2 (with BFD 2.11.2)'

That's a good question. I'm not seeing any relevant flags or params
that one can pass to gcc, and I am seing the string '/usr/ccs/bin/ld'
showing up in the gcc binary, so I'm guessing it has to be configured
at compile-time. Did you try setting the LD environment variable?

The only surefire ways I know of making this work are:
- add libgcc.a to your linker line (ie the output of
  `gcc -print-libgcc-file-name`)
- recompile gcc to use the gnu linker

-aaron

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: Mod_webapp & Solaris 8

2001-11-28 Thread Matt Goyer

I've got both binutils and libtool installed.

How do I get it to use the GNU linker instead? Though 'ld -v' tells me
ld -v 'GNU ld version 2.11.2 (with BFD 2.11.2)'

Thanks,
Matt

-Original Message-
From: Aaron Bannert [mailto:[EMAIL PROTECTED]] 
Sent: Wednesday, November 28, 2001 1:56 PM
To: Tomcat Developers List
Subject: Re: Mod_webapp & Solaris 8


On Wed, Nov 28, 2001 at 10:08:28AM -0800, Justin Erenkrantz wrote:
> On Wed, Nov 28, 2001 at 12:31:13PM -0500, mgoyer wrote:
> > Httpd was built with gcc-3.0.1 the same version that I'm using for 
> > mod_webapp.
> 
> Then, just add -R/path/to/gcc-3.0.1/lib to your LDFLAGS for httpd.

There's a trick for getting the path, try `gcc -print-libgcc-file-name`.
Barring syntax errors, you could probably do something like LIBS="`gcc
-print-libgcc-file-name`". I don't suggest dynamically linking against
libgcc.

Another solution is to use the GNU linker (gld from binutils). gld knows
about libgcc and implicitly pulls symbols from it when needed.

BTW, if you upgrade to libtool-1.4.2 you'll get a nice little warning
about using the solaris linker with gcc.

-aaron

--
To unsubscribe, e-mail:

For additional commands, e-mail:



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: 3.3 classloading & resources

2001-11-28 Thread Keith Wannamaker

Hi Costin,
Yes, I verified that this does indeed do the trick.
Wonder if Sun is going to fix ResourceBundle to handle this?
Hope so!  At any rate, thanks for the tip.

Keith

| -Original Message-
| From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
| Sent: Monday, November 26, 2001 6:49 PM
| To: Tomcat Developers List
| Subject: Re: 3.3 classloading & resources
| 
| 
| The solution - for JDK1.2+ - is to use the 3 parameter getBundle, with
| Thread.currentThread().getContextClassLoader() as the third param.
| For JDK1.1 there's nothing you can do.
| 
| Let me know if it doesn't work - I tried this before and I had no
| problems.  The resources could be in WEB-INF/classes, a jar in
| WEB-INF/lib or any jar in the app.classloader.


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: [VOTE] New Committer: Jazmin Jonson

2001-11-28 Thread Bill Barker

+1
- Original Message -
From: "Amy Roh" <[EMAIL PROTECTED]>
To: "tomcat-dev" <[EMAIL PROTECTED]>
Sent: Wednesday, November 28, 2001 11:04 AM
Subject: [VOTE] New Committer: Jazmin Jonson


> As Bill Barker suggested, I would like to propose Jazmin Jonson as a new
> committer.
>
> She has contributed a numerous patches to Tomcat4 admin application.
>
> Votes please?
>
> Amy Roh
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>


**

This message is intended only for the use of the person(s) listed above 
as the intended recipient(s), and may contain information that is 
PRIVILEGED and CONFIDENTIAL.  If you are not an intended recipient, 
you may not read, copy, or distribute this message or any attachment.  
If you received this communication in error, please notify us immediately 
by e-mail and then delete all copies of this message and any attachments.


In addition you should be aware that ordinary (unencrypted) e-mail sent 
through the Internet is not secure. Do not send confidential or sensitive 
information, such as social security numbers, account numbers, personal 
identification numbers and passwords, to us via ordinary (unencrypted) 
e-mail. 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: Disable Refresh Function in IE

2001-11-28 Thread Tomas Rokicki

You can't really avoid refresh.

Consider that people can double-click on a submit button or
link, quite inadverdantly, and your server sees it as two
submissions but you only get the second response.

Other than the timing, there is very little to distinguish this
from hitting the refresh button.

If the server refuses to serve refresh requests, well, you've
just broken anyone with a slow finger on the mouse.

(And yes, some people still double-click links intentionally
because you double-click to launch on Windows and why should
the Web be any different?  True these people are typically
moms and pops, but everyone's got them, right?  Parents, that
is?)

-tom

-Original Message-
From: Denis Balazuc [mailto:[EMAIL PROTECTED]]
Sent: Wednesday, November 28, 2001 11:28 AM
To: Tomcat Developers List
Subject: Re: Disable Refresh Function in IE


No, there's no way to disable any of the browser's buttons such as Refresh,
Back or Forward

The only way to prevent a refresh is to maintain some flag when you serve
requests, but even this is hardly feasible.
I'd love to hear about a clean solution on that topicWe need to avoid
people from refreshing pages too

- Original Message -
From: "Bala Nemani" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Wednesday, November 28, 2001 12:54 PM
Subject: Disable Refresh Function in IE


> Hi:
>
> Is there a way to disable REFRESH functionality. I.e. not just
> hiding the Refresh button but disable the refresh functionality it self
(F5
> function key also).
>
> Thanks
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: [VOTE] New Committer: Jazmin Jonson

2001-11-28 Thread Remy Maucherat

> As Bill Barker suggested, I would like to propose Jazmin Jonson as a new
> committer.
> 
> She has contributed a numerous patches to Tomcat4 admin application.
> 
> Votes please?

+1.

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Disable Refresh Function in IE

2001-11-28 Thread Denis Balazuc

No, there's no way to disable any of the browser's buttons such as Refresh,
Back or Forward

The only way to prevent a refresh is to maintain some flag when you serve
requests, but even this is hardly feasible.
I'd love to hear about a clean solution on that topicWe need to avoid
people from refreshing pages too

- Original Message -
From: "Bala Nemani" <[EMAIL PROTECTED]>
To: <[EMAIL PROTECTED]>
Sent: Wednesday, November 28, 2001 12:54 PM
Subject: Disable Refresh Function in IE


> Hi:
>
> Is there a way to disable REFRESH functionality. I.e. not just
> hiding the Refresh button but disable the refresh functionality it self
(F5
> function key also).
>
> Thanks
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




[VOTE] New Committer: Jazmin Jonson

2001-11-28 Thread Amy Roh

As Bill Barker suggested, I would like to propose Jazmin Jonson as a new
committer.

She has contributed a numerous patches to Tomcat4 admin application.

Votes please?

Amy Roh


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Mod_webapp & Solaris 8

2001-11-28 Thread Aaron Bannert

On Wed, Nov 28, 2001 at 10:08:28AM -0800, Justin Erenkrantz wrote:
> On Wed, Nov 28, 2001 at 12:31:13PM -0500, mgoyer wrote:
> > Httpd was built with gcc-3.0.1 the same version that I'm using for
> > mod_webapp.
> 
> Then, just add -R/path/to/gcc-3.0.1/lib to your LDFLAGS for
> httpd.

There's a trick for getting the path, try `gcc -print-libgcc-file-name`.
Barring syntax errors, you could probably do something like
LIBS="`gcc -print-libgcc-file-name`". I don't suggest dynamically
linking against libgcc.

Another solution is to use the GNU linker (gld from binutils). gld knows
about libgcc and implicitly pulls symbols from it when needed.

BTW, if you upgrade to libtool-1.4.2 you'll get a nice little warning
about using the solaris linker with gcc.

-aaron

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Mod_webapp & Solaris 8

2001-11-28 Thread Justin Erenkrantz

On Wed, Nov 28, 2001 at 10:32:05AM -0800, Justin Erenkrantz wrote:
> You could try:
> 
> LIBS="-Lgcc" \
> LDFLAGS=-R/usr/local/lib/gcc-lib/sparc-sun-solaris2.8/3.0.1 \
> ./configure --enable-module=rewrite --enable-shared=rewrite

Ack, I meant -lgcc not -Lgcc.  Freezing cold sticky fingers.  -- justin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: [VOTE] Tomcat 4.0.2 Release Plan

2001-11-28 Thread Amy Roh

>
> [X] +1: I approve this plan, and I'll help
> [ ] +0: I approve this plan
> [ ] -0: I'm against this plan, but I won't veto it
> [ ] -1: I'm against this plan, and my reason is:

Amy



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Mod_webapp & Solaris 8

2001-11-28 Thread Justin Erenkrantz

On Wed, Nov 28, 2001 at 01:26:41PM -0500, Matt Goyer wrote:
> Tricky beast it is!
> 
> I installed gcc 3.0.1 using the sunfreeware package and it looks like
> it's sticking the lib files in 
> /usr/local/lib/gcc-lib/sparc-sun-solaris2.8/3.0.1 so:
> 
> To configure Apache I'm doing:
> 
> LDFLAGS=-R/usr/local/lib/gcc-lib/sparc-sun-solaris2.8/3.0.1 \
> ./configure --enable-module=rewrite --enable-shared=rewrite

You could try:

LIBS="-Lgcc" \
LDFLAGS=-R/usr/local/lib/gcc-lib/sparc-sun-solaris2.8/3.0.1 \
./configure --enable-module=rewrite --enable-shared=rewrite

You need to force httpd to bring in libgcc (but Solaris's ld may
be stubborn about bringing it in if it isn't used).  

You may also have better luck if you get mod_webapp to compile 
statically.  The problem here is that the run-time link path on 
httpd is different than the link path that mod_webapp requires.
By compiling it statically, that problem goes away.

httpd-2.0 handles this much better since it'd bring in 
libgcc.  =)  -- justin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: Mod_webapp & Solaris 8

2001-11-28 Thread Matt Goyer

Tricky beast it is!

I installed gcc 3.0.1 using the sunfreeware package and it looks like
it's sticking the lib files in 
/usr/local/lib/gcc-lib/sparc-sun-solaris2.8/3.0.1 so:

To configure Apache I'm doing:

LDFLAGS=-R/usr/local/lib/gcc-lib/sparc-sun-solaris2.8/3.0.1 \
./configure --enable-module=rewrite --enable-shared=rewrite

To configure mod_webapp I'm doing:

LDFLAGS=-R/usr/local/lib/gcc-lib/sparc-sun-solaris2.8/3.0.1 \ 
./configureLDFLAGS=-R/usr/local/lib/gcc-lib/sparc-sun-solaris2.8/3.0.1
./configure

And it's still the same error. Am I missing something?

Thanks,
Matt

-Original Message-
From: Justin Erenkrantz [mailto:[EMAIL PROTECTED]] 
Sent: Wednesday, November 28, 2001 1:08 PM
To: Tomcat Developers List
Subject: Re: Mod_webapp & Solaris 8


On Wed, Nov 28, 2001 at 12:31:13PM -0500, mgoyer wrote:
> Httpd was built with gcc-3.0.1 the same version that I'm using for 
> mod_webapp.

Then, just add -R/path/to/gcc-3.0.1/lib to your LDFLAGS for httpd.

(Using gcc-3.0.1 on Solaris is a really tricky beast because gcc doesn't
add the -R flags to the binaries.)  -- justin


--
To unsubscribe, e-mail:

For additional commands, e-mail:



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 5169] New: - If jsp_precompile is evalutated to be false, the request will be processed by the target JSP

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5169

If jsp_precompile is evalutated to be false, the request will be processed by the 
target JSP

   Summary: If jsp_precompile is evalutated to be false, the request
will be processed by the target JSP
   Product: Tomcat 4
   Version: 4.0.1 Final
  Platform: All
OS/Version: All
Status: NEW
  Severity: Major
  Priority: Other
 Component: Jasper
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


JavaServer Pages Specification 1.2, Section JSP.8.4.2:

The "jsp_precompile" parameter may have no value, or may
have the values "true" or "false".  In all cases, the 
request should not be delivered to the JSP page.

With Tomcat, if the jsp_precompile parameter is false, the 
request is delivered to the target JSP page.  This is a 
violation of the spec.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Mod_webapp & Solaris 8

2001-11-28 Thread Justin Erenkrantz

On Wed, Nov 28, 2001 at 12:31:13PM -0500, mgoyer wrote:
> Httpd was built with gcc-3.0.1 the same version that I'm using for
> mod_webapp.

Then, just add -R/path/to/gcc-3.0.1/lib to your LDFLAGS for
httpd.

(Using gcc-3.0.1 on Solaris is a really tricky beast because
gcc doesn't add the -R flags to the binaries.)  -- justin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: [VOTE] Tomcat 4.0.2 Release Plan

2001-11-28 Thread Endre Stølsvik

On Wed, 28 Nov 2001, GOMEZ Henri wrote:

| What about mod_webapp SNAPSHOT for this release ?

Yes, PLEASE do so. I hate this stuff. It's awful. I'm trying to compile,
to get this stuff to work, but I don't know if I'm getting the right
stuff, just checking it out from the CVS and all..

A "release" of the mod_webapp would be nice, and hopefully also a couple
of builds towards that different API/EAPI stuff.. ("Yes, I'm using the
build which is distributed with the 4.0.2 release")

..

-- 
Mvh,
Endre


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Disable Refresh Function in IE

2001-11-28 Thread Bala Nemani

Hi:

Is there a way to disable REFRESH functionality. I.e. not just
hiding the Refresh button but disable the refresh functionality it self (F5
function key also).

Thanks


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




[TC4] How to know when tomcat is properly shut down?

2001-11-28 Thread Endre Stølsvik

This did not get answered the first time, so I'll try again!! Better luck
this time? Please??

-- 
Mvh,
Endre

-- Forwarded message --
Date: Wed, 21 Nov 2001 09:10:54 +0100 (MET)
From: Endre Stølsvik <[EMAIL PROTECTED]>
Reply-To: Tomcat Developers List <[EMAIL PROTECTED]>
To: Tomcat developer list <[EMAIL PROTECTED]>
Subject: [TC4] How to know when tomcat is properly shut down? (fwd)

Since nobody answered on tomcat-user, I'll just forward this one here
(since I think it actually belongs here in the first place..)

-- Forwarded message --
Date: Tue, 20 Nov 2001 18:14:20 +0100 (MET)
From: Endre Stølsvik <[EMAIL PROTECTED]>
Reply-To: Tomcat Users List <[EMAIL PROTECTED]>
To: Tomcat user list <[EMAIL PROTECTED]>
Subject: [TC4] How to know when tomcat is properly shut down?

The catalina.sh and related scripts all start the Bootstrap.java class and
asks it to shut down Catalina.

This script, if successful in connecting to the shutdown port of Catalina,
returns immediately. This whether or not there is 8953289527 pending
database commits or whatever that has to be done before things actually
are properly shut down.

This is highly undesirable, and I would love if it were possible to shut
down catalina and then chill untill it actually has shut down.

This is especially important when shutting down the entire server, as the
database shutdown might be the next in line, in which case everything
breaks..

Of course, it would also be very nice if one could know if Catalina has
properly come up. It could for example write a "boolean file" when the
server has initialized all webapps, and then delete the same file right
before the main method of Catalina exits on shutdown. Or one could use
Bootstrap with argument -waitForUp or something..
---

And yes, Henri's init.d scripts also just fake this, waiting in just 2
seconds, which is too short time, and therefore the "restart" option of
the init.d script is flawed. The shutdown part of it doesn't wait at all,
so you might end up shutting the server physically down (read as: killing
all the java threads w/o cleaning up) before tomcat has finished shutting
down.

Mvh,
Endre


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




[tc4] Warp-connector reinitializing webapps

2001-11-28 Thread Endre Stølsvik

This won't ever be answered on the user list, so I hope for some replies
here..:

When I start apace after starting tomcat, the webapp I defined in
httpd.conf is getting initialized, even though it already got initialized
from the standalone connector..

This is part of my server.xml file:




  
  








  
  

  
  

  
  






This is maybe the way it's supposed to be (because it says somewhere that
each instance should be started as its own webapp), but then I wonder why
the WebappLoader logs to the two different loggers defined here. The one
that starts up automatically because of the standalone HttpConnector logs
the "startup sequnce" to the localhost_log file, while the one that starts
because of the warp connection being made by apache, logs to the
catalina_log file.

How is the warp thing working, does it in effect create an Engine for
itself, not caring of the one defined in server.xml?? Or..?

I don't get the connection thing between apache to work either, though.
Apache answers all the time that "The requested URL /[webapp] was not
found on this server. .. Apache 1.3.20", even if some connection to tomcat
apparently was made..

..All this stuff isn't _too_ well documented...


-- 
Mvh,
Endre


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/servlet JspServlet.java

2001-11-28 Thread remm

remm01/11/28 09:28:11

  Modified:jasper/src/share/org/apache/jasper/servlet Tag:
tomcat_40_branch JspServlet.java
  Log:
  - Fix typo.
Patch submitted by Ryan Lubke 
  
  Revision  ChangesPath
  No   revision
  
  
  No   revision
  
  
  1.21.2.3  +1 -1  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/servlet/JspServlet.java
  
  Index: JspServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/servlet/JspServlet.java,v
  retrieving revision 1.21.2.2
  retrieving revision 1.21.2.3
  diff -u -r1.21.2.2 -r1.21.2.3
  --- JspServlet.java   2001/11/26 22:59:21 1.21.2.2
  +++ JspServlet.java   2001/11/28 17:28:11 1.21.2.3
  @@ -424,7 +424,7 @@
   else if (value.equals("false"))
   return (false);// ?jsp_precompile=false
   else
  -throw new ServletException("Cannott have request parameter " +
  +throw new ServletException("Cannot have request parameter " +
  Constants.PRECOMPILE + " set to " +
  value);
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/servlet JspServlet.java

2001-11-28 Thread remm

remm01/11/28 09:26:08

  Modified:jasper/src/share/org/apache/jasper/servlet JspServlet.java
  Log:
  - Fix typo.
Patch submitted by Ryan Lubke 
  
  Revision  ChangesPath
  1.24  +1 -1  
jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/servlet/JspServlet.java
  
  Index: JspServlet.java
  ===
  RCS file: 
/home/cvs/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/servlet/JspServlet.java,v
  retrieving revision 1.23
  retrieving revision 1.24
  diff -u -r1.23 -r1.24
  --- JspServlet.java   2001/11/26 22:55:43 1.23
  +++ JspServlet.java   2001/11/28 17:26:08 1.24
  @@ -424,7 +424,7 @@
   else if (value.equals("false"))
   return (false);// ?jsp_precompile=false
   else
  -throw new ServletException("Cannott have request parameter " +
  +throw new ServletException("Cannot have request parameter " +
  Constants.PRECOMPILE + " set to " +
  value);
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




[PATCH] Tomcat 4.0 -- Spelling correction in JspServlet class

2001-11-28 Thread Ryan Lubke

Simple spelling correction in org.apache.jasper.servlet.JspServlet




Index: JspServlet.java
===
RCS file: 
/home/cvspublic/jakarta-tomcat-4.0/jasper/src/share/org/apache/jasper/servlet/JspServlet.java,v
retrieving revision 1.23
diff -u -r1.23 JspServlet.java
--- JspServlet.java 2001/11/26 22:55:43 1.23
+++ JspServlet.java 2001/11/28 17:20:56
@@ -424,7 +424,7 @@
 else if (value.equals("false"))
 return (false);// ?jsp_precompile=false
 else
-throw new ServletException("Cannott have request parameter " +
+throw new ServletException("Cannot have request parameter " +
Constants.PRECOMPILE + " set to " +
value);
 



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 


Re: Info on customizing jspc - jasper

2001-11-28 Thread Tom Drake

Alberto:

Maybe I'm missing something here but couldn't you simply
 intercept the response output stream and redirect it to a file?

Have you tried using a filter?

Alternatively, ou may be able to do this by 'including'
your jsp from a servlet or another jsp.

One last thought. Tag libraries have the ability to intercept 'body content'
that appears between the corresponding opening and closing tags.

BodyContent body = getBodyContent();
String bodyOfCaptureTag = body.getString();
// write bodyOfCaptureTag to file here...

You could create a simple BodyTagSupport taglib object, use this tag in
a new jsp that you create that looks something like this.



This is a little bizarre, but should even work with Tomcat 3.1 .

Tom
- Original Message -
From: "Alberto Romei" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Wednesday, November 28, 2001 2:34 AM
Subject: Re: Info on customizing jspc - jasper


| Hi, and many thanks for the replies.
| Using <%@page extends="my.jsp.page.class" %> allows me to change only the
| name of the superclass for my JSP, but i need to do more than this.
| I need to change all the fixed lines of the generated code.
| For example, i would like to change:
|
| public void _jspService(HttpServletRequest request,
HttpServletResponse
| response)
| in
| public void _jspService(MyParam p1, String  s, int n)
|
| or substituting
| JspFactory _jspxFactory = null;
| with
| String name = "X";
|
| and so on...
|
| The other solution proposed by Mike is good, but HttpServletResponse needs
a
| ServletOutputStream, and the generated servlet calls getPageContext()
which
| takes my request and response objects, so i guess my implementation will
not
| be so straightforward. Anyway, i think i'll try this way.
|
| If you have other ideas, please let me know
|
| Thanks
| Alberto
|
| - Original Message -
| From: "Bill Barker" <[EMAIL PROTECTED]>
| To: "Tomcat Developers List" <[EMAIL PROTECTED]>
| Sent: Tuesday, November 27, 2001 8:27 PM
| Subject: Re: Info on customizing jspc - jasper
|
|
| > This is off-topic for the dev list.  You'll probably get a better
response
| > from [EMAIL PROTECTED]
| >
| > What you want is <@page extends="my.jsp.page.class" %>
| > - Original Message -
| > From: "Alberto Romei" <[EMAIL PROTECTED]>
| > To: <[EMAIL PROTECTED]>
| > Sent: Tuesday, November 27, 2001 10:32 AM
| > Subject: Info on customizing jspc - jasper
| >
| >
| > > I wanted to use JspC to generate a java program (not exactly a
servlet)
| > > which writes its output to a file on the disk instead of the
| > > HttpServletResponse's JspWriter.
| > >
| > > In practice, i just need to customize the fixed parts of the generated
| > code
| > > like:
| > >
| > > public class Foo extends HttpJspBase {
| > >
| > > or
| > >
| > > public void _jspService(HttpServletRequest request,
| > HttpServletResponse
| > > response)
| > > throws java.io.IOException, ServletException {
| > >
| > > From what i've seen, i could simply substitute JspParseEventListener
in
| > the
| > > jasper jars, but in this way i would "throw away" the normal
processing
| of
| > > JSPs.
| > >
| > > So, what is the correct way to customize the JSP compilation ?
| > > Must i subclass org.apache.jasper.compiler.Compiler and call
| > > MyCompiler.something() instead of jspc.parseFiles() ? (that would be a
| lot
| > > of work... )
| > > If so, is there any kind of documentation on how to correctly write a
| > custom
| > > JSP compiler ? (possibly working with future versions of tomcat, too)
| > >
| > > Any suggestion is appreciated.
| > >
| > > Thanks
| > >
| > > Alberto
| > >
| > > P.S.
| > > I'm new to tomcat source, so please be patient.
| > >
| > >
| > >
| > > --
| > > To unsubscribe, e-mail:
| > 
| > > For additional commands, e-mail:
| > 
| > >
| >
| >
| > **
| >
| > This message is intended only for the use of the person(s) listed above
| > as the intended recipient(s), and may contain information that is
| > PRIVILEGED and CONFIDENTIAL.  If you are not an intended recipient,
| > you may not read, copy, or distribute this message or any attachment.
| > If you received this communication in error, please notify us
immediately
| > by e-mail and then delete all copies of this message and any
attachments.
| >
| >
| > In addition you should be aware that ordinary (unencrypted) e-mail sent
| > through the Internet is not secure. Do not send confidential or
sensitive
| > information, such as social security numbers, account numbers, personal
| > identification numbers and passwords, to us via ordinary (unencrypted)
| > e-mail.
| >
| > --
| > To unsubscribe, e-mail:
| 
| > For additional commands, e-mail:
| 
| >
|
|
|
| --
| To unsubscribe, e-mail:

| For additional commands, e-mail:

|
|
|


--
To unsubs

RE: Mod_webapp & Solaris 8

2001-11-28 Thread mgoyer

Httpd was built with gcc-3.0.1 the same version that I'm using for
mod_webapp.

-Original Message-
From: Justin Erenkrantz [mailto:[EMAIL PROTECTED]] 
Sent: Wednesday, November 28, 2001 11:34 AM
To: Tomcat Developers List
Subject: Re: Mod_webapp & Solaris 8


On Wed, Nov 28, 2001 at 11:15:07AM -0500, Matt Goyer wrote:
> Syntax error on line 206 of /usr/local/apache/conf/httpd.conf:
> Cannot load /usr/local/apache/libexec/mod_webapp.so into server:
> ld.so.1: /usr/local/apache/bin/httpd: fatal: relocation error: file
> /usr/local/apache/libexec/mod_webapp.so: symbol __lshrdi3: referenced 
> symbol not found

You need to compile Apache with the same compiler as you compiled 
mod_webapp.  So, if you are using gcc-3.0.1, make sure that httpd 
was built with gcc-3.0.1.  An executable built with gcc-3.0.1 knows 
where to find gcclib.  -- justin


--
To unsubscribe, e-mail:

For additional commands, e-mail:



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: [VOTE] Tomcat 4.0.2 Release Plan

2001-11-28 Thread Remy Maucherat

> >There are few things I would like to see fixed before releasing:
> >- the jvmroute ( I'll do a patch if nobody else does it )
>
> YES PLEASE +1, will give tomcat 4.0 access to load balancing
> feature of mod_jk ;)

Ok, I'm all for it, but one of you guys will have to implement it ;)

> >- backporting the 'trusted apps having access to catalina
> >internals' from
> >4.1
> >
> >I would be happier to see 4.0.2 released a bit later, I hope
> >we can freeze
> >j-t-c/mod_jk around 12/15, but we need few weeks for testing.
> >If 4.0.2 is
> >released on 12/16, it needs to use a branch ( same code as in 4.0.1 ).

The dates were for 4.0.2 beta 1. Since it is a bugfix release, the final was
supposed to go out only when we're happy with the bugs status.

> Yes, could we wait some time and fix one of the problem
> of users about the webconnector ?
>
> I'm still working on packaging mod_webapp, (yes yes)
> against the recent Apache 2.0.28 beta 

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: [VOTE] Tomcat 4.0.2 Release Plan

2001-11-28 Thread Remy Maucherat

> On Tue, 27 Nov 2001, Remy Maucherat wrote:
>
> > - A few more code merge will happen between now and the first beta
release
> >   (at least one to add JAVA_HOME support in the install script).
> > - The release notes will document all the fixes which occured since
4.0.1.
> > - The release notes will list the must-fix bugs. This generally includes
> > bugs
> >   whose severity in Bugzilla is 'blocker' (P1), 'critical' (P2)
> >   or 'major' (P3).
> > - Tomcat 4.0.2 won't have any regressions over 4.0.1.
> > - All betas for 4.0.2 should be considered release candidates if the
> > must-fix
> >   issues list is empty.
> > - Tomcat 4.0.2 beta 1 should be released between 12/02 and 12/16.
> > - This vote will run until 12/01.
> >
> > 
> > [ ] +1: I approve this plan, and I'll help
> > [X] +0: I approve this plan
> > [ ] -0: I'm against this plan, but I won't veto it
> > [ ] -1: I'm against this plan, and my reason is:
>
> There are few things I would like to see fixed before releasing:
> - the jvmroute ( I'll do a patch if nobody else does it )

Well, I'm not going to do it, since I can't really test it.

> - backporting the 'trusted apps having access to catalina internals' from
> 4.1

Really ?
Why's that ?

I was planning not to port that change.

> I would be happier to see 4.0.2 released a bit later, I hope we can freeze
> j-t-c/mod_jk around 12/15, but we need few weeks for testing. If 4.0.2 is
> released on 12/16, it needs to use a branch ( same code as in 4.0.1 ).

And since when do you care about 4.0 schedule ?
;-)

Remy


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 4829] - Automatic deployment of war files does not work properly

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=4829

Automatic deployment of war files does not work properly





--- Additional Comments From [EMAIL PROTECTED]  2001-11-28 09:10 ---
*** Bug 5105 has been marked as a duplicate of this bug. ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 5105] - Tomcat can not automatically reload web apps if a context is defined in server.xml

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5105

Tomcat can not automatically reload web apps if a context is defined in server.xml

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||DUPLICATE



--- Additional Comments From [EMAIL PROTECTED]  2001-11-28 09:10 ---
This bug really is a duplicate of 4829, which describes an issue that has been 
discussed ad nauseam.

If you're not happy you can submit a patch which would implement the bahavior 
you want :)

*** This bug has been marked as a duplicate of 4829 ***

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Mod_webapp & Solaris 8

2001-11-28 Thread Justin Erenkrantz

On Wed, Nov 28, 2001 at 11:15:07AM -0500, Matt Goyer wrote:
> Syntax error on line 206 of /usr/local/apache/conf/httpd.conf:
> Cannot load /usr/local/apache/libexec/mod_webapp.so into server:
> ld.so.1: /usr/local/apache/bin/httpd: fatal: relocation error: file
> /usr/local/apache/libexec/mod_webapp.so: symbol __lshrdi3: referenced
> symbol not found

You need to compile Apache with the same compiler as you compiled 
mod_webapp.  So, if you are using gcc-3.0.1, make sure that httpd 
was built with gcc-3.0.1.  An executable built with gcc-3.0.1 knows 
where to find gcclib.  -- justin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Strange Tomcat I/O behavior

2001-11-28 Thread Eric Rescorla

I'd finished adding portable SSL support to Tomcat and was
testing it when I ran into an interesting snag. Roughly,
the way things work is as follows (spread out over a number
of classes)

Socket s=accept();
PushbackInputStream is=new PushbackInputStream
   (s.getInputStream());
int x=is.read();

Sometimes (but not always) I'm getting stalled on the first
byte read. I know that there's data in the pipe because I
can see it on the wire with tcpdump or ssldump but it never
seems to get to my application.

Some interesting observations:
(1) This always happens on the first read of a given connection.
(2) Sometimes if you close the connection or kill tomcat 
whatever's wedged seems to unwedge and the read completes.
(3) This never seems to happen in PureTLS standalone, only 
in combination with Tomcat.

I'm about to start really digging into this (first by adding a dummy
module in place of PureTLS) but I wanted to know if anyone had seen
anything similar and had any guesses about what might be going on.

Thanks,
-Ekr















--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Mod_webapp & Solaris 8

2001-11-28 Thread Matt Goyer

I've been struggling with this for a week or two now..

I'm able to compile mod_webapp on Solaris 8 with GCC 3.0.1 using the
snapshots of mod_webapp and apr from CVS. However I have to modify my
apxs since three values don't get properly set by the apache makefile.

So I then try and load my compiled mod_webapp with Apache and get the
following error:

Syntax error on line 206 of /usr/local/apache/conf/httpd.conf:
Cannot load /usr/local/apache/libexec/mod_webapp.so into server:
ld.so.1: /usr/local/apache/bin/httpd: fatal: relocation error: file
/usr/local/apache/libexec/mod_webapp.so: symbol __lshrdi3: referenced
symbol not found

I then pulled apart libgcc.a (as recommend in a post here) and made
libgcc.so and located it in /usr/lib and when I do:

export LD_PRELOAD=/usr/lib/libgcc.so /usr/local/apache/bin/apachectl
configtest

I then get:

Syntax error on line 206 of /usr/local/apache/conf/httpd.conf:
Cannot load /usr/local/apache/libexec/mod_webapp.so into server:
ld.so.1: /usr/local/apache/bin/httpd: fatal: relocation error: file
/usr/local/apache/libexec/mod_webapp.so: symbol ap_table_get: referenced
symbol not found

What am I missing?

Can anyone get mod_webapp working on Solaris 8?? If some has.. If you
could post a quick install guide of what you did I'd appreciate that.

I posted here before and someone talked about setting LD_LIBRARY_PATH
and I tried that too to no avail.

Matt


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 5163] - typos in RUNNING.txt

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5163

typos in RUNNING.txt

[EMAIL PROTECTED] changed:

   What|Removed |Added

   Severity|Normal  |Minor
 OS/Version|Other   |All
   Priority|Other   |Low
   Platform|Other   |All

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 5166] New: - CATALINA_BASE config issues for RUNNING.txt

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5166

CATALINA_BASE config issues for RUNNING.txt

   Summary: CATALINA_BASE config issues for RUNNING.txt
   Product: Tomcat 4
   Version: Nightly Build
  Platform: All
OS/Version: All
Status: NEW
  Severity: Minor
  Priority: Other
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Short version:

 RUNNING.txt says you can use CATALINA_BASE and CATALINA_HOME,
 but this doesn't work with the distribution config:

 - The webapps/admin.xml and webapps/manager.xml docBase has
   ../server relative to $CATALINA_BASE, causing those two
   webapps to fail.
 - The shared directory is not found, causing the JspServlet
   to not be found

Long version:

In RUNNING.txt, step (4) explains how to use CATALINA_BASE and CATALINA_HOME.
Alas this doesn't work:

  # build Tomcat, no problem
  setenv MYSRC /home/mak/jakarta/jakarta-tomcat-4.0
  (cd $MYSRC; cvs update -d; ant clean; ant dist)
 
  # copy dist and run, no problem
  setenv MYBASE /home/mak/tomcat-instance1
  rm -fr $MYBASE
  cp -r $MYSRC/dist $MYBASE
  setenv CATALINA_HOME $MYBASE
  $CATALINA_HOME/bin/startup.sh

  # try $CATALINA_BASE, runs but produces errors in the log
  setenv MYBASE /home/mak/tomcat-instance2
  rm -fr $MYBASE
  mkdir $MYBASE
  cp -r $MYSRC/dist/{conf,webapps} $MYBASE
  mkdir $MYBASE/{logs,work}
  setenv CATALINA_HOME $MYSRC/dist
  setenv CATALINA_BASE $MYBASE
  $CATALINA_HOME/bin/startup.sh

This produces:

  Using CLASSPATH:
/home/mak/jakarta/jakarta-tomcat-4.0/dist/bin/bootstrap.jar:/usr/j2se/lib/tools.jar:/usr/local/java/jsse1.0.2/lib/jcert.jar:/usr/local/java/jsse1.0.2/lib/jnet.jar:/usr/local/java/jsse1.0.2/lib/jsse.jar
  Using CATALINA_BASE: /home/mak/tomcat-instance2
  Using CATALINA_HOME: /home/mak/jakarta/jakarta-tomcat-4.0/dist
  Using JAVA_HOME: /usr/j2se

then logs:

  StandardWrapper[/examples:jsp]: Marking servlet jsp as unavailable
  StandardContext[/examples]: Servlet /examples threw load() exception
  javax.servlet.ServletException: Wrapper cannot find servlet class
org.apache.jasper.servlet.JspServlet or a class it depends on

and later:

  StandardContext[/manager]: Error initializing resources: Document base
/home/mak/tomcat-instance2/webapps/../server/webapps/manager does not exist or
is not a readable directory

Analysis:

  The error from /manager (and a similar one from /admin) are due to 
  webapps/admin.xml and webapps/manager.xml having a docBase starting
  with "../server/", which is used relative to $CATALINA_BASE instead
  of $CATALINA_HOME. You can address this by making them absolute paths
  based on $CATALINA_HOME, or to copy/symlink the server/ directory
  into $CATALINA_BASE. The RUNNING.txt should mention this.

  The error about JspServlet is due to the shared/ directory.
  A workaround is to copy/symlink the $CATALINA_HOME/shared directory
  into $CATALINA_BASE. Assuming that $CATALINA_BASE is in fact the
  sensible place (I'd say so), RUNNING.txt should mention this.

Incidentally, I noticed in a `grep '"shared"'
catalina/src/share/org/apache/catalina/startup/*.java`
that sometimes it is looked up relative to getCatalinaHome, sometimes relative
to getCatalinaBase. Is this correct?

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




FW: [Cryptix-Users] OpenSSL and java keytool

2001-11-28 Thread GOMEZ Henri

>-Original Message-
>From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED]]
>Sent: Wednesday, November 28, 2001 11:51 AM
>To: GOMEZ Henri
>Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED];
>[EMAIL PROTECTED]
>Subject: RE: [Cryptix-Users] OpenSSL and java keytool
>
>
>
>I only did now. Guess my previous answer doesn't make sense.
>
>Perhaps you can check which CipherSuites your JSSE server supports?
>
>  SSLServerSocket s = ...
>  System.out.println("Enabled cipher suites:");
>  String[] c = s.getEnabledCipherSuites();
>  for (int i = 0; i < c.length; i++)
>   System.out.println("  " + c[i]);
>
>To enable all CipherSuites:
>  s.setEnabledCipherSuites(s.getSupportedCipherSuites());
>
>Maybe that helps?
>
>BTW, nice document, that howto. Maybe a small suggestion: I'd also add
>the KeyStore type as a parameter. This way, it would be possible to use
>other KeyStores then "JKS". And perhaps a storepass parameter as well.
>
>Stef
>
>
>
>Did you read the tomcat SSL howto ?
>
>We've discussed that there :
>
>http://jakarta.apache.org/tomcat/tomcat-3.3-doc/tomcat-ssl-howto.html
>
>Regards
>
>-
>Henri Gomez ___[_]
>EMAIL : [EMAIL PROTECTED](. .)
>PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
>PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6
>
>
>
>>-Original Message-
>>From: Manfred.Zerndl [mailto:[EMAIL PROTECTED]]
>>Sent: Wednesday, November 28, 2001 8:50 AM
>>To: [EMAIL PROTECTED]
>>Subject: [Cryptix-Users] OpenSSL and java keytool
>>
>>
>>Hi there,
>>
>>So far, I have been working under Linux (SuSE 7.0) with
>>OpenSSL 0.9.6. I
>>used OpenSSL for creating a self-signed server certificate for a https
>>server.
>>
>>Everything ist fine so far. Meanwhile we want to set up a
>>servlet engine
>>(Tomcat 3.2.3) which is also https-enabled.
>>Unfortunately, tomcat administrates its certificates with "keytool"
>>coming with the JDK 1.3.
>>
>>When I try to import my OpenSSL certificate into keytool, restart my
>>servlet engine, I get a browser error saying that the browser (e.g.
>>Netscape) and the server have no common encrypttion algorithms.
>>
>>Can anybody help me?
>>
>>Thanks
>>Manfred Zerndl
>>
>>---
>>
>>Manfred Zerndl
>>Bezirksfinanzdirektion München
>>Alexandrastr. 3, D-80538 München, GERMANY
>>[EMAIL PROTECTED]
>>
>>
>>
>>For BUGS:  provide Cryptix version, Java version,
>>platform, STACK TRACE and preferrably a small
>>stand-alone program demonstrating the problem!
>>
>>Subscribe/unsubscribe/change your options at:
>>http://lists.cryptix.org/mailman/listinfo/cryptix-users/
>>
>
>
>
>For BUGS:  provide Cryptix version, Java version,
>platform, STACK TRACE and preferrably a small
>stand-alone program demonstrating the problem!
>
>Subscribe/unsubscribe/change your options at:
>http://lists.cryptix.org/mailman/listinfo/cryptix-users/
>
>
>

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: [VOTE] Tomcat 4.0.2 Release Plan

2001-11-28 Thread GOMEZ Henri

>There are few things I would like to see fixed before releasing:
>- the jvmroute ( I'll do a patch if nobody else does it )

YES PLEASE +1, will give tomcat 4.0 access to load balancing
feature of mod_jk ;)

>- backporting the 'trusted apps having access to catalina 
>internals' from
>4.1
>
>I would be happier to see 4.0.2 released a bit later, I hope 
>we can freeze
>j-t-c/mod_jk around 12/15, but we need few weeks for testing. 
>If 4.0.2 is
>released on 12/16, it needs to use a branch ( same code as in 4.0.1 ).

Yes, could we wait some time and fix one of the problem
of users about the webconnector ?

I'm still working on packaging mod_webapp, (yes yes)
against the recent Apache 2.0.28 beta 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RPM new packaging proposal

2001-11-28 Thread GOMEZ Henri

Hi to all,

I want to propose a new packaging policy for Tomcat,
3.2/3.3/4.0 RPMs.

Up to now, the Tomcat RPM which are built from the source 
present in jakarta site and include the binary jars present
in the source tarball.

To respect the general RPM packaging method (Mandrake,
Redhat, Suse and others), and more generally packaging
policies from Debian group, I wish to remove the use 
of included jar and use the jar for the other required RPM.

In tomcat 3.2.x case.

* servletapi3-3.2.4 will provide servlet-2.2.jar in /usr/share/java

* tomcat3-3.2.4 will provide webserver.jar and jasper.jar

* xml parser will be grabbed from the one found on our system
  and following the jpackage project, I'll make use of jaxp_parser.jar
  which live in /usr/share/java and which is a symlink on a real 
  XML parser like, xerces-j (xerces.jar), crimson (crimson.jar), xml4j
  (xml4j.jar), all of this living in /usr/share/java.

servlet.jar and xml_parser.jar won't be copied from /usr/share/java
but will use symlink .

ln -s /usr/share/java/servlet-2.2.jar /var/tomcat/lib/servlet.jar
ln -s /usr/share/java/xml_parser.jar /var/tomcat/lib/xml_parser.jar

In Tomcat 3.3 case, it will be similar expect I'll add also xalan.jar
which is present in xalan-j RPM (2.1.0 today).

In Tomcat 4.0 case, we'll make use also of jmx, jndi and tyrex, which all
live in the respective RPM. Tomcat 4.0 will also make use of servletapi4,
which provide /usr/share/java/servlet-2.3.jar

JSSE is a special case, since it's not mandatory but may be installed in 
tomcat lib dirs if detected at install time (thanks to comment this
automatic
installation)

As such, all the needed RPM will be provided as source and binary (noarch)
in distrib directory so users will have everything necessary to use the RPM.

This refactory is part of a job conducted on jpackage, 
http://jpackage.sourceforge.net/, which is a project to provide a 
full RPM distribution of usual java applications and libraries.

All the major jakarta.apache.org and xml.apache.org projects are
available at jpackage, making the dependencies easier to handle.

Nota that jpackage make extensive use of xml, xml -> spec translator, 
ant (building) and rpm (for packaging). 

Thanks to give your opinion.

Regards
 
-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .) 
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 5163] New: - typos in RUNNING.txt

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5163

typos in RUNNING.txt

   Summary: typos in RUNNING.txt
   Product: Tomcat 4
   Version: Nightly Build
  Platform: Other
OS/Version: Other
Status: NEW
  Severity: Normal
  Priority: Other
 Component: Unknown
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


diff -u -r1.2 RUNNING.txt
--- RUNNING.txt 2001/08/27 20:22:37 1.2
+++ RUNNING.txt 2001/11/28 14:36:35
@@ -103,7 +103,7 @@
 
 (4) Advanced Configuration - Multiple Tomcat 4 Instances
 
-In many circumstances, it is desireable to have a single copy of a Tomcat 4
+In many circumstances, it is desirable to have a single copy of a Tomcat 4
 binary distribution shared among multiple users on the same server.  To make
 this possible, you must configure a CATALINA_BASE environment variable (in
 addition to CATALINA_HOME as described above) that points to a directory
@@ -123,7 +123,7 @@
 
 If you do not set CATALINA_BASE to an explicit value, it will be initialized
 to the same value as is set for CATALINA_HOME (which means that the same
-directory is used for all relative path resoluations).
+directory is used for all relative path resolutions).
 
 
 (5) Troubleshooting:
@@ -155,7 +155,7 @@
After you click apply, Windows will create shortcuts in the directory with
which you can use to start and stop the container.
 
-3) The 'localhost' machine isn't found.  This could happen if you're behing a
+3) The 'localhost' machine isn't found.  This could happen if you're behind a
proxy.  If that's the case, make sure the proxy configuration for your
browser knows that you shouldn't be going through the proxy to access the
"localhost" machine.

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Tomcat & JDeveloper.

2001-11-28 Thread Juan Carlos Fernández Galante

Can I debug a jsp with JDeveloper, using OJVM or other Protocol?



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 5160] New: - 'IllegalStateException'

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5160

'IllegalStateException'

   Summary: 'IllegalStateException'
   Product: Tomcat 3
   Version: 3.2.2 Final
  Platform: PC
OS/Version: Windows NT/2K
Status: UNCONFIRMED
  Severity: Major
  Priority: Other
 Component: Servlet
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


Hello,
Pls help me.
 I am using Tomcat 3.1 with Apache on Windows 2000 Professional & P III
machine and JDK 1.3.1 .

 When I include a JSP file in another JSP file the page does not come
properly (Like when I include a error page).

 It shows an 'IllegalStateException: Cannot forward as OutputStream or
Writer has already been obtained'.

 I have a file login.jsp which validates a user and on successful login
includes another JSP file depending upon the type of user.
The following error is reported : -

IllegalStateException: Cannot forward as OutputStream or Writer has already
been obtained

The same file i had been able to run on a WIN NT server machine with P III
machine and JDK 1.3.1 .
Please help me to solve this problem. Any help would be appreciated.

Chirag Mehta
MENTORIX TECHNOLOGIES
693 0202  xtn - 226

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Problems building webapp_module

2001-11-28 Thread Brian P Millett

Gonzalez, Federico wrote:

>I get the following error when trying to build webapp_module
>apxs:Error: no config variable LDFLAGS_SHLIB
>

This should be a FAQ item.

You have a miss configured apxs application.  Check to see if apxs is 
configured correctly.  Here is an example for apache 1.3.X with gcc (See 
the value for $CFG_LDFLAGS_SHLIB)

my $CFG_TARGET= q(httpd);# substituted via 
Makefile.tmpl
my $CFG_CC= q(gcc);# substituted via 
Makefile.tmpl
my $CFG_CFLAGS= q( -DEAPI -DSOLARIS2=280 -DUSE_EXPAT 
-I../lib/expat-lite -DNO_DL_NEEDED -O6 -mcpu=v8 -Wa,-xarch=v8plusa 
`../apaci`);# substituted via Makefile.tmpl
my $CFG_CFLAGS_SHLIB  = q(-fPIC -DSHARED_MODULE);  # substituted via 
Makefile.tmpl
my $CFG_LD_SHLIB  = q(gcc);  # substituted via Makefile.tmpl
my $CFG_LDFLAGS_SHLIB = q(-G); # substituted via Makefile.tmpl
my $CFG_LIBS_SHLIB= q(-fPIC);# substituted via Makefile.tmpl
my $CFG_PREFIX= q(/opt/apache);# substituted via 
APACI install
my $CFG_SBINDIR   = q(/opt/apache/bin);   # substituted via 
APACI install
my $CFG_INCLUDEDIR= q(/opt/apache/include);# substituted via 
APACI install
my $CFG_LIBEXECDIR= q(/opt/apache/libexec);# substituted via 
APACI install
my $CFG_SYSCONFDIR= q(/opt/apache/conf);# substituted via 
APACI install

-- 
Brian Millett
Enterprise Consulting Group   "Shifts in paradigms
(314) 205-9030   often cause nose bleeds."
[EMAIL PROTECTED]   Greg Glenn




--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 5105] - Tomcat can not automatically reload web apps if a context is defined in server.xml

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5105

Tomcat can not automatically reload web apps if a context is defined in server.xml





--- Additional Comments From [EMAIL PROTECTED]  2001-11-28 04:48 ---
On Step 3 I meant:
...saveOnRestart to "false"...
(I would like not to save my sessions by restart, just because some methods of 
my project are not serializable, and when I restart the webapp the users become 
their old session and an error)

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: [VOTE] Tomcat 4.0.2 Release Plan

2001-11-28 Thread costinm

On Tue, 27 Nov 2001, Remy Maucherat wrote:

> - A few more code merge will happen between now and the first beta release
>   (at least one to add JAVA_HOME support in the install script).
> - The release notes will document all the fixes which occured since 4.0.1.
> - The release notes will list the must-fix bugs. This generally includes
> bugs
>   whose severity in Bugzilla is 'blocker' (P1), 'critical' (P2)
>   or 'major' (P3).
> - Tomcat 4.0.2 won't have any regressions over 4.0.1.
> - All betas for 4.0.2 should be considered release candidates if the
> must-fix
>   issues list is empty.
> - Tomcat 4.0.2 beta 1 should be released between 12/02 and 12/16.
> - This vote will run until 12/01.
>
> 
> [ ] +1: I approve this plan, and I'll help
> [X] +0: I approve this plan
> [ ] -0: I'm against this plan, but I won't veto it
> [ ] -1: I'm against this plan, and my reason is:

There are few things I would like to see fixed before releasing:
- the jvmroute ( I'll do a patch if nobody else does it )
- backporting the 'trusted apps having access to catalina internals' from
4.1

I would be happier to see 4.0.2 released a bit later, I hope we can freeze
j-t-c/mod_jk around 12/15, but we need few weeks for testing. If 4.0.2 is
released on 12/16, it needs to use a branch ( same code as in 4.0.1 ).

Costin


--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




cvs commit: jakarta-tomcat/src/doc index.html

2001-11-28 Thread larryi

larryi  01/11/28 03:15:06

  Modified:src/doc  index.html
  Log:
  Update Tomcat reference from 3.2 to 3.3
  
  Reported by: James Bromberger
  
  Revision  ChangesPath
  1.9   +2 -2  jakarta-tomcat/src/doc/index.html
  
  Index: index.html
  ===
  RCS file: /home/cvs/jakarta-tomcat/src/doc/index.html,v
  retrieving revision 1.8
  retrieving revision 1.9
  diff -u -r1.8 -r1.9
  --- index.html2001/10/09 17:43:35 1.8
  +++ index.html2001/11/28 11:15:06 1.9
  @@ -1,7 +1,7 @@
   
   
 
  -
  +
   
   
   
  @@ -48,7 +48,7 @@
 with "Tomcat workers," and the worker.properties file.
   
   Tomcat and SSL - Using SSL with
  -  Tomcat 3.2, including configuring web connectors.
  +  Tomcat 3.3, including configuring web connectors.
   
 
   
  
  
  

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: [VOTE] Tomcat 4.0.2 Release Plan

2001-11-28 Thread GOMEZ Henri

What about mod_webapp SNAPSHOT for this release ?

Will you include the latest stuff from JTC CVS ?

-
Henri Gomez ___[_]
EMAIL : [EMAIL PROTECTED](. .) 
PGP KEY : 697ECEDD...oOOo..(_)..oOOo...
PGP Fingerprint : 9DF8 1EA8 ED53 2F39 DC9B 904A 364F 80E6 



>-Original Message-
>From: Remy Maucherat [mailto:[EMAIL PROTECTED]]
>Sent: Wednesday, November 28, 2001 7:26 AM
>To: [EMAIL PROTECTED]
>Subject: [VOTE] Tomcat 4.0.2 Release Plan
>
>
>Hi,
>
>I think it's the appropriate time to consider starting a new 
>release cycle
>for
>Tomcat 4.0. There has been a variety of significant bugs fixed 
>since 4.0.1
>(although there hasn't been any fixes for any showstopper bug).
>
>I don't plan to propose a formal release plan for this 
>release, as it is a
>bugfix-only release, and it will be released as soon as there 
>are no more
>must-fix issues remaining in the most current release candidate.
>
>- A few more code merge will happen between now and the first 
>beta release
>  (at least one to add JAVA_HOME support in the install script).
>- The release notes will document all the fixes which occured 
>since 4.0.1.
>- The release notes will list the must-fix bugs. This 
>generally includes
>bugs
>  whose severity in Bugzilla is 'blocker' (P1), 'critical' (P2)
>  or 'major' (P3).
>- Tomcat 4.0.2 won't have any regressions over 4.0.1.
>- All betas for 4.0.2 should be considered release candidates if the
>must-fix
>  issues list is empty.
>- Tomcat 4.0.2 beta 1 should be released between 12/02 and 12/16.
>- This vote will run until 12/01.
>
>
>[ ] +1: I approve this plan, and I'll help
>[ ] +0: I approve this plan
>[ ] -0: I'm against this plan, but I won't veto it
>[ ] -1: I'm against this plan, and my reason is:
>
>
>
>
>Remy
>
>
>--
>To unsubscribe, e-mail:   

For additional commands, e-mail: 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: Info on customizing jspc - jasper

2001-11-28 Thread Alberto Romei

Hi, and many thanks for the replies.
Using <%@page extends="my.jsp.page.class" %> allows me to change only the
name of the superclass for my JSP, but i need to do more than this.
I need to change all the fixed lines of the generated code.
For example, i would like to change:

public void _jspService(HttpServletRequest request, HttpServletResponse
response)
in
public void _jspService(MyParam p1, String  s, int n)

or substituting
JspFactory _jspxFactory = null;
with
String name = "X";

and so on...

The other solution proposed by Mike is good, but HttpServletResponse needs a
ServletOutputStream, and the generated servlet calls getPageContext() which
takes my request and response objects, so i guess my implementation will not
be so straightforward. Anyway, i think i'll try this way.

If you have other ideas, please let me know

Thanks
Alberto

- Original Message -
From: "Bill Barker" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Tuesday, November 27, 2001 8:27 PM
Subject: Re: Info on customizing jspc - jasper


> This is off-topic for the dev list.  You'll probably get a better response
> from [EMAIL PROTECTED]
>
> What you want is <@page extends="my.jsp.page.class" %>
> - Original Message -
> From: "Alberto Romei" <[EMAIL PROTECTED]>
> To: <[EMAIL PROTECTED]>
> Sent: Tuesday, November 27, 2001 10:32 AM
> Subject: Info on customizing jspc - jasper
>
>
> > I wanted to use JspC to generate a java program (not exactly a servlet)
> > which writes its output to a file on the disk instead of the
> > HttpServletResponse's JspWriter.
> >
> > In practice, i just need to customize the fixed parts of the generated
> code
> > like:
> >
> > public class Foo extends HttpJspBase {
> >
> > or
> >
> > public void _jspService(HttpServletRequest request,
> HttpServletResponse
> > response)
> > throws java.io.IOException, ServletException {
> >
> > From what i've seen, i could simply substitute JspParseEventListener in
> the
> > jasper jars, but in this way i would "throw away" the normal processing
of
> > JSPs.
> >
> > So, what is the correct way to customize the JSP compilation ?
> > Must i subclass org.apache.jasper.compiler.Compiler and call
> > MyCompiler.something() instead of jspc.parseFiles() ? (that would be a
lot
> > of work... )
> > If so, is there any kind of documentation on how to correctly write a
> custom
> > JSP compiler ? (possibly working with future versions of tomcat, too)
> >
> > Any suggestion is appreciated.
> >
> > Thanks
> >
> > Alberto
> >
> > P.S.
> > I'm new to tomcat source, so please be patient.
> >
> >
> >
> > --
> > To unsubscribe, e-mail:
> 
> > For additional commands, e-mail:
> 
> >
>
>
> **
>
> This message is intended only for the use of the person(s) listed above
> as the intended recipient(s), and may contain information that is
> PRIVILEGED and CONFIDENTIAL.  If you are not an intended recipient,
> you may not read, copy, or distribute this message or any attachment.
> If you received this communication in error, please notify us immediately
> by e-mail and then delete all copies of this message and any attachments.
>
>
> In addition you should be aware that ordinary (unencrypted) e-mail sent
> through the Internet is not secure. Do not send confidential or sensitive
> information, such as social security numbers, account numbers, personal
> identification numbers and passwords, to us via ordinary (unencrypted)
> e-mail.
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




DO NOT REPLY [Bug 5105] - Tomcat can not automatically reload web apps if a context is defined in server.xml

2001-11-28 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG 
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND 
INSERTED IN THE BUG DATABASE.

http://nagoya.apache.org/bugzilla/show_bug.cgi?id=5105

Tomcat can not automatically reload web apps if a context is defined in server.xml

[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|DUPLICATE   |



--- Additional Comments From [EMAIL PROTECTED]  2001-11-28 02:23 ---
PLEASE, Remy Maucherat, try the following steps:

- Create an "examples.war" file (with the examples webapp tree) and copy it in 
the /webapps directory. What a pitty, the last versions from tomcat do not 
include /webapps/*.war files!!! ;-).

- Delete all the files and direcories recursively from /webapps/examples and 
from /work/localhost/examples (directories "examples" included).

- In the server.xml file uncomment the Persistent Manager section from the 
Tomcat Examples Context just to "test Persistent Sessions" and set the 
parameter saveOnRestart to "true".

- Start tomcat and try to figure out what does tomcat do with the examples 
webapp => the examples webapp does not exist: examples.war was not entpacked 
into /webapps/examples!!
See your log file (localhost_examples_log.-mm-dd.txt):
2001-11-28 10:45:05 StandardContext[/examples]: Error initializing resources: 
Document base D:\Programme\JBuilder5\tomcat\webapps\examples does not exist or 
is not a readable directory

- And what happens when you type 
http://localhost:8080/examples/servlets/index.html in your browser?

- If you are using tomcat with apache, try to figure out what does tomcat do 
with the examples webapp when you type 
http://localhost/examples/servlets/index.html in your browser.

- And now follow the steps described by James Cai:
a) delete the webapps and work directories for the examples webapp, comment out 
the  config from examples and restart tomcat ==> examples.war will be 
entpacked into /webapps/examples!!. (The examples context is not valid -it was 
commented out-).
b) uncomment the  in server.xml and restart Tomcat again without 
deleting any files (trees webapps/examples and work/localhost/examples) 
previously ==> this time it DOES work only because the /webapps/examples tree 
was previously created in (a). (The examples context is now valid).

I THINK WE ARE NOT TRYING TO CONFUSE ANYBODY.
JUST FOLLOW THE STEPS...
WE ARE ONLY TRYING TO DESCRIBE A SITUATION WHERE TOMCAT DOES NOT
WORK PROPERLY!!!

--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




[PATCH][Catalina] Improved flexiblity of pipeline WRT session cookies

2001-11-28 Thread Daniel Rall

First, this patch fixes a problem with Catalina's sendHeaders()
implementation which prevents post-service() Valve code from having a
chance to cleanly set or modify the JSESSIONID cookie used to store
Catalina's session identifier.

Second, this removes some of the remnants of a cut and paste birth of
WarpResponse from jakarta-tomcat-4.0 (note that there is another copy
of this file in the jakarta-turbine-connectors repository).

This patch is against CVS HEAD of jakarta-tomcat-4.0 from the evening
of Wed, Nov 28.

On a parallel note, neither JServ (in JServServletManager) nor
Catalina (in two HttpProcessor impls and WarpRequestHandler) use the
equalsIgnoreCase that section 4.1 of RFC 2109 to me suggests use when
rooting through the cookies parsed from the request stream (when
initially seeking the session identifier).  Even though a constant is
used internally in Catalina, I would assume that Catalina would accept
cookies formatted as per the RFC (perhaps common usage suggests
otherwise?).


Index: HttpResponseBase.java
===
RCS file: 
/home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/HttpResponseBase.java,v
retrieving revision 1.40
diff -u -u -r1.40 HttpResponseBase.java
--- HttpResponseBase.java   2001/11/13 19:39:27 1.40
+++ HttpResponseBase.java   2001/11/28 09:15:20
@@ -614,25 +614,7 @@
 }
 
 // Add the session ID cookie if necessary
-HttpServletRequest hreq = (HttpServletRequest) request.getRequest();
-HttpSession session = hreq.getSession(false);
-
-if ((session != null) && session.isNew() && (getContext() != null)
-&& getContext().getCookies()) {
-Cookie cookie = new Cookie(Globals.SESSION_COOKIE_NAME,
-   session.getId());
-cookie.setMaxAge(-1);
-String contextPath = null;
-if (context != null)
-contextPath = context.getPath();
-if ((contextPath != null) && (contextPath.length() > 0))
-cookie.setPath(contextPath);
-else
-cookie.setPath("/");
-if (hreq.isSecure())
-cookie.setSecure(true);
-addCookie(cookie);
-}
+addAbsentSessionCookie((HttpServletRequest) request.getRequest());
 
 // Send all specified cookies (if any)
 synchronized (cookies) {
@@ -657,6 +639,63 @@
 
 // The response is now committed
 committed = true;
+
+}
+
+
+/**
+ * Adds the session ID cookie if a new session exists for
+ * hreq, the Context is configured to pass the
+ * session ID via cookies (the default), and the session cookie
+ * doesn't already exist in the request (could've been inserted by
+ * a meddling Valve during Pipeline execution).
+ *
+ * @param hreq The HttpServletRequest whose session to service.
+ */
+protected void addAbsentSessionCookie(HttpServletRequest hreq) {
+
+HttpSession session = hreq.getSession(false);
+
+if ((session != null) && session.isNew() && (getContext() != null)
+&& getContext().getCookies() && !containsSessionCookie()) {
+Cookie cookie = new Cookie(Globals.SESSION_COOKIE_NAME,
+   session.getId());
+cookie.setMaxAge(-1);
+String contextPath = null;
+if (context != null)
+contextPath = context.getPath();
+if ((contextPath != null) && (contextPath.length() > 0))
+cookie.setPath(contextPath);
+else
+cookie.setPath("/");
+if (hreq.isSecure())
+cookie.setSecure(true);
+addCookie(cookie);
+}
+
+}
+
+
+/**
+ * Returns whether this HttpResponse contains the session
+ * identifier cookie.  Though section 4.1 of RFC 2109 suggests
+ * that cookie name comparisons are case-insentive, a
+ * case-sensitive comparison is performed for consistancy with the
+ * rest of Catalina's implementation.
+ *
+ * @return Whether this response has a session identifier cookie
+ * set.
+ */
+protected boolean containsSessionCookie() {
+
+Cookie c;
+for (Iterator i = cookies.iterator(); i.hasNext(); ) {
+c = (Cookie) i.next();
+if (Globals.SESSION_COOKIE_NAME.equals(c.getName())) {
+return true;
+}
+}
+return false;
 
 }
 


Index: WarpResponse.java
===
RCS file: 
/home/cvspublic/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/connector/warp/WarpResponse.java,v
retrieving revision 1.7
diff -u -u -r1.7 WarpResponse.java
--- WarpResponse.java   2001/08/09 20:08:58 1.7
+++ WarpResponse.java   2001/11/28 09:15:00
@@ -201,25 +201,7 @@
 

Re: What Happen with of Tomcat 4.0.1 instalation?

2001-11-28 Thread Juan Carlos Fernández Galante

Thanks for your help.

- Original Message -
From: "Ferran Arís" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Wednesday, November 28, 2001 9:10 AM
Subject: RE: What Happen with of Tomcat 4.0.1 instalation?


> I think Carlos you will get a better help in Tomcat User Mail List rather
> than in the Tomcat Developer List (the one you are writing now), the
> problems discussed here are very different from the help you need. You can
> check this URL :
>
> http://jakarta.apache.org/site/mail2.html and look for Tomcat User List,
> then hit on subscribe.
>
>
>
> HINT : Check on the windows registry for this entries :
>
> HKEY_LOCAL_MACHINE\SOFTWARE\JavaSoft\Java Development Kit
> HKEY_LOCAL_MACHINE\SOFTWARE\JavaSoft\Java Runtime Environment
>
> and look inside if the JavaHome Value is pointing to the directory where
> your JDK is installed.
>
> and add to your environment "My Computer, Properties, Advanced, System
> Variables" a variable called JAVA_HOME and the path from the JVM you want
to
> use.
>
> Hope it helps ...
>
>
> -Mensaje original-
> De: Juan Carlos Fernández Galante
> [mailto:[EMAIL PROTECTED]]
> Enviado el: martes, 27 de noviembre de 2001 19:01
> Para: Tomcat Developers List
> Asunto: What Happen with of Tomcat 4.0.1 instalation?
>
>
> I am attempting to install Tomcat 4.0.1, on
>
> Windows 2000
> Apache 1.3
> jdk1.3.1 & jdk1.4 beta3
>
> but when I try to execute the jakarta-tomcat-4.0.1.exe file, the next
> message appear:
>
> Could´t find a JDK on this computer.
>
> Can you help me?
>
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>
>



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




RE: What Happen with of Tomcat 4.0.1 instalation?

2001-11-28 Thread Ferran Arís

I think Carlos you will get a better help in Tomcat User Mail List rather
than in the Tomcat Developer List (the one you are writing now), the
problems discussed here are very different from the help you need. You can
check this URL :

http://jakarta.apache.org/site/mail2.html and look for Tomcat User List,
then hit on subscribe.



HINT : Check on the windows registry for this entries :

HKEY_LOCAL_MACHINE\SOFTWARE\JavaSoft\Java Development Kit
HKEY_LOCAL_MACHINE\SOFTWARE\JavaSoft\Java Runtime Environment

and look inside if the JavaHome Value is pointing to the directory where
your JDK is installed.

and add to your environment "My Computer, Properties, Advanced, System
Variables" a variable called JAVA_HOME and the path from the JVM you want to
use.

Hope it helps ...


-Mensaje original-
De: Juan Carlos Fernández Galante
[mailto:[EMAIL PROTECTED]]
Enviado el: martes, 27 de noviembre de 2001 19:01
Para: Tomcat Developers List
Asunto: What Happen with of Tomcat 4.0.1 instalation?


I am attempting to install Tomcat 4.0.1, on

Windows 2000
Apache 1.3
jdk1.3.1 & jdk1.4 beta3

but when I try to execute the jakarta-tomcat-4.0.1.exe file, the next
message appear:

Could´t find a JDK on this computer.

Can you help me?



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 



--
To unsubscribe, e-mail:   
For additional commands, e-mail: 




Re: http protocol version question

2001-11-28 Thread Bill Barker

These types of questions are better addressed at
[EMAIL PROTECTED]

The short answer is that Tomcat 3.x currently supports only the 1.0
protocol.  Tomcat 4.x also supports the 1.1. protocol.
- Original Message -
From: "yuexiang" <[EMAIL PROTECTED]>
To: "Tomcat Developers List" <[EMAIL PROTECTED]>
Sent: Tuesday, November 27, 2001 11:18 PM
Subject: http protocol version question


> Hi,
>
> I am new as a tomcat user.
> Who can explain to me what is the relation between http protocol version
(1.0 /1.1)
> and the tomcat? It seems that the servlet already return http packet as
1.0 verion.
>
>
> Thanks
> yang
>
>
>  ^  ^
>  (oo)\___
>  (__)\   )\/\
>  ||w |
>  || ||
>
> Welcome http://192.168.213.203
>
>
>
>
> --
> To unsubscribe, e-mail:

> For additional commands, e-mail:

>


**

This message is intended only for the use of the person(s) listed above 
as the intended recipient(s), and may contain information that is 
PRIVILEGED and CONFIDENTIAL.  If you are not an intended recipient, 
you may not read, copy, or distribute this message or any attachment.  
If you received this communication in error, please notify us immediately 
by e-mail and then delete all copies of this message and any attachments.


In addition you should be aware that ordinary (unencrypted) e-mail sent 
through the Internet is not secure. Do not send confidential or sensitive 
information, such as social security numbers, account numbers, personal 
identification numbers and passwords, to us via ordinary (unencrypted) 
e-mail. 

--
To unsubscribe, e-mail:   
For additional commands, e-mail: