Change in vdsm[master]: monitoring: Introduce the eventloop module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the eventloop module
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the check module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the check module
..


Patch Set 22:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the check module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the check module
..


Patch Set 21:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 21
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

[edwardh]

Edward Haas has posted comments on this change.

Change subject: ifcfg: re-enable IPv6 before device configuration, or disable 
afterwards
..


Patch Set 9: Code-Review-1

(3 comments)

https://gerrit.ovirt.org/#/c/54555/9/lib/vdsm/network/configurators/__init__.py
File lib/vdsm/network/configurators/__init__.py:

Line 216: wait_for_device
I don't understand this one.
The caller creates a device and then asks to wait for a device to be created? 
What if it was already created?
If you want to make sure a device is created before proceeding (blocking on 
it), it needs to be done in the creation context.

I know there are races with links coming up, but not with their creation. Do we 
really need to be so pedantic?


https://gerrit.ovirt.org/#/c/54555/9/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:

Line 805:  args=(iface, cgroup))
Line 806: t.daemon = True
Line 807: t.start()
Line 808: else:
Line 809: if not iface.master and (iface.ipv4 or iface.ipv6):
Nice catch
Line 810: if iface.ipv4:
Line 811: expected_event = {'label': iface.name, 'family': 
'inet',
Line 812:   'scope': 'global'}
Line 813: elif iface.ipv6:


https://gerrit.ovirt.org/#/c/54555/9/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 1879: @permutations([[([4], [6])],
Line 1880:[([6], [4])],
Line 1881:[([4], [4, 6], [4])]])
Line 1882: @cleanupNet
Line 1883: def testStaticNetworkConfig(self, ip_reconfigurations):
I find it hard to read this test and if it will fail, it will be painful to 
understand which scenario failed.

Can you please split this test into multiple ones?
Each should check a specific scenario and have a name that fits it.
Line 1884: with dummyIf(1) as nics:
Line 1885: nic, = nics
Line 1886: IPv4 = dict(nic=nic, bootproto='none', ipaddr=IP_ADDRESS,
Line 1887: netmask=IP_MASK, gateway=IP_GATEWAY)


-- 
To view, visit https://gerrit.ovirt.org/54555
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the check module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the check module
..


Patch Set 20:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: Add fcoe hook

[pzhukov]

Pavel Zhukov has posted comments on this change.

Change subject: hooks: Add fcoe hook
..


Patch Set 2:

I removed persist code because I was thinking it's redundant (supervdsm will 
restore config every boot (setupNetworks call) based on persistent network 
configuration anyway). But I'm not sure...

-- 
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Pavel Zhukov 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: Add fcoe hook

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: Add fcoe hook
..


Patch Set 2:

I think that it would be better to copy the config before-network-setup

You should call persist if it is on oVirt node.

You should remove the file if the custom property is removed, or if the whole 
network is removed.

Thanks for the first draft!

-- 
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: common handling of exceptions

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: common handling of exceptions
..


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/54664/11/tests/virt_api_test.py
File tests/virt_api_test.py:

Line 17: #
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20: 
Line 21: from vdsm.virt import api
I think this should come after vdsm imports (more specific), or even last - 
this is the module under test.
Line 22: from vdsm import exception
Line 23: from vdsm import response
Line 24: 
Line 25: from testlib import VdsmTestCase as TestCaseBase


-- 
To view, visit https://gerrit.ovirt.org/54664
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the eventloop module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the eventloop module
..


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/54849/9/lib/vdsm/storage/eventloop.py
File lib/vdsm/storage/eventloop.py:

Line 188: 
Line 189: Any positional arguments after the callback will be passed to
Line 190: the callback when it is called.
Line 191: 
Line 192: Copied from Python 3.4 with without changes.
> OK, I'll leave only the notes about changes, and add a general note about t
Addresses in next patch for the entire file.
Line 193: """
Line 194: self._check_closed()
Line 195: return self._call_soon(callback, args)
Line 196: 


-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the check module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the check module
..


Patch Set 19:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 19
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: Add fcoe hook

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: Add fcoe hook
..


Patch Set 2:

* #1239122::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1239122::OK, public bug
* Check Product::#1239122::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hooks: Add fcoe hook

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: Add fcoe hook
..


Patch Set 1:

* #1239122::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1239122::OK, public bug
* Check Product::#1239122::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the check module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the check module
..


Patch Set 18:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the check module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the check module
..


Patch Set 17:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 17
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the check module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the check module
..


Patch Set 16:

* #1081962::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1081962::OK, public bug
* Check Product::#1081962::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 
ovirt-3.3 ovirt-3.2)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54757
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the eventloop module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: monitoring: Introduce the eventloop module
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add support for SCSI

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: add support for SCSI
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55024
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib049bc8669d3dc14a83c89c0d03f3410f242e1cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: make _update_usb_device_info more generic

[mpolednik]

Martin Polednik has uploaded a new change for review.

Change subject: hostdev: make _update_usb_device_info more generic
..

hostdev: make _update_usb_device_info more generic

This is change of naming rather than functionality. The same idea can
be (and must be) used for scsi devices.

Change-Id: I6a37a94dab06806b9f3b8baabce4cc4d9ed47c34
Signed-off-by: Martin Polednik 
---
M vdsm/virt/vmdevices/hostdevice.py
1 file changed, 4 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/23/55023/1

diff --git a/vdsm/virt/vmdevices/hostdevice.py 
b/vdsm/virt/vmdevices/hostdevice.py
index b18d003..e528487 100644
--- a/vdsm/virt/vmdevices/hostdevice.py
+++ b/vdsm/virt/vmdevices/hostdevice.py
@@ -56,7 +56,6 @@
 
 
 """
-
 if (CAPABILITY_TO_XML_ATTR[
 self._deviceParams['capability']] == 'pci' and
 utils.tobool(self.specParams.get('iommuPlaceholder', False))):
@@ -79,7 +78,7 @@
 return hostdev
 
 @classmethod
-def _update_usb_device_info(cls, vm, device_conf, x):
+def _update_unclear_device_info(cls, vm, device_conf, x):
 alias = x.getElementsByTagName('alias')[0].getAttribute('name')
 address = vmxml.device_address(x)
 
@@ -97,15 +96,15 @@
 dev['alias'] = alias
 
 # This has an unfortunate effect that we will not be able to look up
-# any new USB passthrough devices, because there is no easy
+# any new problematic devices, because there is no easy
 # way of reconstructing the udev name we use as unique id.
 
 @classmethod
 def update_device_info(cls, vm, device_conf):
 for x in vm.domain.get_device_elements('hostdev'):
 device_type = x.getAttribute('type')
-if device_type == 'usb':
-cls._update_usb_device_info(vm, device_conf, x)
+if device_type != 'pci':
+cls._update_unclear_device_info(vm, device_conf, x)
 continue
 alias = x.getElementsByTagName('alias')[0].getAttribute('name')
 address = vmxml.device_address(x)


-- 
To view, visit https://gerrit.ovirt.org/55023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6a37a94dab06806b9f3b8baabce4cc4d9ed47c34
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: expose generic scsi driver char device in device pa...

[mpolednik]

Martin Polednik has uploaded a new change for review.

Change subject: hostdev: expose generic scsi driver char device in device params
..

hostdev: expose generic scsi driver char device in device params

Preparation for upcoming scsi-passthrough patch series. This value can
be displayed by engine for better UX as it corresponds to generic scsi
driver device names (e.g. /dev/sg{num}). Main reason is that VDSM needs
to know the endpoint to properly set permissions.

Change-Id: I91e6793e946310b57e3004cbebc286cc6e00a724
Signed-off-by: Martin Polednik 
---
M lib/vdsm/hostdev.py
1 file changed, 6 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/22/55022/1

diff --git a/lib/vdsm/hostdev.py b/lib/vdsm/hostdev.py
index 48933b6..c9371eb 100644
--- a/lib/vdsm/hostdev.py
+++ b/lib/vdsm/hostdev.py
@@ -141,6 +141,12 @@
 address = physfn.find('address')
 params['physfn'] = pci_address_to_name(**address.attrib)
 
+try:
+params['endpoint'] = caps.find('char').text
+except AttributeError:
+# Is not scsi endpoint.
+pass
+
 iommu_group = caps.find('iommuGroup')
 if iommu_group is not None:
 params['iommu_group'] = iommu_group.attrib['number']


-- 
To view, visit https://gerrit.ovirt.org/55022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I91e6793e946310b57e3004cbebc286cc6e00a724
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: make _update_usb_device_info more generic

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: make _update_usb_device_info more generic
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a37a94dab06806b9f3b8baabce4cc4d9ed47c34
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: expose generic scsi driver char device in device pa...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: expose generic scsi driver char device in device params
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/55022
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91e6793e946310b57e3004cbebc286cc6e00a724
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add support for SCSI

[mpolednik]

Martin Polednik has uploaded a new change for review.

Change subject: hostdev: add support for SCSI
..

hostdev: add support for SCSI

SCSI devices inside sysfs device tree are different. Normally, we
require a single sysfs entry in listAllDevices to determine the
endpoint and address of the devices. SCSI requires two entries -
generic one to determine endpoint, and scsi entry to determine address
and it's host adapter.

Change-Id: Ib049bc8669d3dc14a83c89c0d03f3410f242e1cd
Signed-off-by: Martin Polednik 
---
M lib/vdsm/hostdev.py
M tests/hostdevTests.py
M vdsm/supervdsm_api/udev.py
M vdsm/virt/vmdevices/hostdevice.py
4 files changed, 69 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/24/55024/1

diff --git a/lib/vdsm/hostdev.py b/lib/vdsm/hostdev.py
index c9371eb..0904f61 100644
--- a/lib/vdsm/hostdev.py
+++ b/lib/vdsm/hostdev.py
@@ -29,6 +29,7 @@
 
 CAPABILITY_TO_XML_ATTR = {'pci': 'pci',
   'scsi': 'scsi',
+  'scsi_generic': 'scsi_generic',
   'usb_device': 'usb'}
 
 
@@ -50,6 +51,19 @@
 
 def name_to_pci_path(device_name):
 return device_name[4:].replace('_', '.').replace('.', ':', 2)
+
+
+def scsi_address_to_adapter(scsi_address):
+"""
+Read adapter info from scsi host address, and mutate the adress (removing
+'host' key) to conform to libvirt.
+"""
+adapter = 'scsi_host{}'.format(scsi_address['host'])
+scsi_address['unit'] = scsi_address['lun']
+del scsi_address['lun']
+del scsi_address['host']
+
+return {'name': adapter}
 
 
 def pci_address_to_name(domain, bus, slot, function):
@@ -225,6 +239,12 @@
 supervdsm.getProxy().appropriateUSBDevice(
 device_params['address']['bus'],
 device_params['address']['device'])
+elif capability == 'scsi_generic':
+supervdsm.getProxy().appropriateSCSIDevice(device_name,
+   device_params['endpoint'])
+# SCSI is uncool. We need the generic device for endpoint, but it's
+# parent (proper SCSI device) for it's address.
+device_params = get_device_params(device_params['parent'])
 
 return device_params
 
@@ -244,6 +264,8 @@
 supervdsm.getProxy().rmAppropriateUSBDevice(
 device_params['address']['bus'],
 device_params['address']['device'])
+elif capability == 'scsi_generic':
+supervdsm.getProxy().rmAppropriateSCSIDevice(device_params['endpoint'])
 
 
 def change_numvfs(device_name, numvfs):
diff --git a/tests/hostdevTests.py b/tests/hostdevTests.py
index 5af9cd5..2df05ef 100644
--- a/tests/hostdevTests.py
+++ b/tests/hostdevTests.py
@@ -114,6 +114,16 @@
 %s
 
 ''',
+'scsi_0_0_0_0':
+'''
+
+
+
+
+
+%s
+
+''',
 _SRIOV_VF:
 '''
 
@@ -402,7 +412,8 @@
 'smp': '8', 'maxVCpus': '160',
 'memSize': '1024', 'memGuaranteedSize': '512'}
 
-@permutations([[device] for device in _PCI_DEVICES + _USB_DEVICES])
+@permutations([[device] for device in _PCI_DEVICES + _USB_DEVICES +
+   [_SCSI_DEVICES[2]]])
 def testCreateHostDevice(self, device_name):
 dev_spec = {'type': 'hostdev', 'device': device_name}
 device = hostdevice.HostDevice(self.conf, self.log, **dev_spec)
diff --git a/vdsm/supervdsm_api/udev.py b/vdsm/supervdsm_api/udev.py
index 26b3a61..82ad49e 100644
--- a/vdsm/supervdsm_api/udev.py
+++ b/vdsm/supervdsm_api/udev.py
@@ -26,6 +26,7 @@
 from vdsm import commands
 from vdsm import cmdutils
 from vdsm import udevadm
+from vdsm import utils
 
 from vdsm.constants import EXT_CHOWN, \
 DISKIMAGE_USER, DISKIMAGE_GROUP, \
@@ -56,6 +57,32 @@
 
 
 @expose
+def appropriateSCSIDevice(device_name, endpoint):
+ruleFile = _UDEV_RULE_FILE_NAME % ('scsi', device_name)
+rule = 'RUN+="%s %s:%s %s"\n' % (
+EXT_CHOWN, QEMU_PROCESS_USER, QEMU_PROCESS_GROUP, endpoint)
+with open(ruleFile, "w") as rf:
+_log.debug("Creating rule %s: %r", ruleFile, rule)
+rf.write(rule)
+
+_udevTrigger(subsystem_matches=('scsi_generic',))
+
+
+@expose
+def rmAppropriateSCSIDevice(device_name, endpoint):
+rule_file = _UDEV_RULE_FILE_NAME % ('scsi', device_name)
+_log.debug("Removing rule %s", rule_file)
+utils.rmFile(rule_file)
+
+_log.debug('Changing ownership (to root:disk) of device %s', endpoint)
+cmd = [EXT_CHOWN, 'root:disk', endpoint]
+rc, out, err = commands.execCmd(cmd)
+if err:
+raise OSError(errno.EINVAL, 'Could not change ownership'
+  'out %s\nerr %s' % (out, err))
+
+
+@expose
 def appropriateMultipathDevice(guid, thiefId):
 ruleFile = _UDEV_RULE_FILE_NAME % (guid, thiefId)
 # WARNING: we cannot use USER, 

Change in vdsm[master]: monitoring: Introduce the check module

[nsoffer]

Nir Soffer has uploaded a new change for review.

Change subject: monitoring: Introduce the check module
..

monitoring: Introduce the check module

The check module is providing DirectioChecker that run in an event loop
thread. Using this we can run all the storage domain checkers in one
thread, protecting them from blocking when domain monitor thread is
blocked on unrelated tasks such as refreshing lvm cache or rescanning
storage connections.

This will be used to separate storage domain health checking form other
tasks performed by the storage domains monitor threads, avoiding false
negative check results.

When running as script, this module watch all multipath devices on a
host. This demo code will be removed when the tests are completed.

(Partial tests)

Change-Id: If22fe38b8b29116270f9012b75895506adc48852
Bug-Url: https://bugzilla.redhat.com/1081962
Signed-off-by: Nir Soffer 
---
M debian/vdsm-python.install
M lib/vdsm/storage/Makefile.am
A lib/vdsm/storage/check.py
M tests/Makefile.am
A tests/storage_check_test.py
M vdsm.spec.in
6 files changed, 345 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/57/54757/15

diff --git a/debian/vdsm-python.install b/debian/vdsm-python.install
index c1c5e78..1d8e37a 100644
--- a/debian/vdsm-python.install
+++ b/debian/vdsm-python.install
@@ -62,6 +62,7 @@
 ./usr/lib/python2.7/dist-packages/vdsm/sslcompat.py
 ./usr/lib/python2.7/dist-packages/vdsm/sslutils.py
 ./usr/lib/python2.7/dist-packages/vdsm/storage/__init__.py
+./usr/lib/python2.7/dist-packages/vdsm/storage/check.py
 ./usr/lib/python2.7/dist-packages/vdsm/storage/constants.py
 ./usr/lib/python2.7/dist-packages/vdsm/storage/eventloop.py
 ./usr/lib/python2.7/dist-packages/vdsm/storage/exception.py
diff --git a/lib/vdsm/storage/Makefile.am b/lib/vdsm/storage/Makefile.am
index 44d4507..255abd1 100644
--- a/lib/vdsm/storage/Makefile.am
+++ b/lib/vdsm/storage/Makefile.am
@@ -23,6 +23,7 @@
 
 dist_vdsmstorage_PYTHON = \
__init__.py \
+   check.py \
constants.py \
eventloop.py \
exception.py \
diff --git a/lib/vdsm/storage/check.py b/lib/vdsm/storage/check.py
new file mode 100644
index 000..e6274b8
--- /dev/null
+++ b/lib/vdsm/storage/check.py
@@ -0,0 +1,236 @@
+#
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+from __future__ import absolute_import
+
+import asyncore
+import logging
+import re
+
+import cpopen
+
+from vdsm.infra import filecontrol
+
+
+class DirectioChecker(object):
+"""
+Check path availability using direct I/O.
+
+On each check cycle, the complete callback is invoke with a CheckResult
+instance.
+"""
+
+log = logging.getLogger("storage.check")
+
+def __init__(self, loop, path, complete=None, interval=10.0):
+self._loop = loop
+self._path = path
+self._complete = complete
+self._interval = interval
+self._check_time = None
+self._timer = None
+self._proc = None
+self._reader = None
+self._reaper = None
+self._err = None
+
+def start(self):
+"""
+Start checker from any thread.
+"""
+self.log.info("Start watching %r", self._path)
+self._timer = self._loop.call_soon_threadsafe(self.check)
+
+def stop(self):
+"""
+Stop checker from any thread.
+"""
+self.log.info("Stop watching %r", self._path)
+self._timer.cancel()
+self._timer = None
+
+@property
+def running(self):
+return self._timer is not None
+
+def check(self):
+if not self.running:
+return
+cmd = ["dd", "if=%s" % self._path, "of=/dev/null", "bs=4096",
+   "count=1", "iflag=direct"]
+self.log.debug("START check %r cmd=%s", self._path, cmd)
+self._check_time = self._loop.time()
+self._proc = cpopen.CPopen(cmd, stdin=None, stdout=None,
+   stderr=cpopen.PIPE)
+self._reader = self._loop.create_dispatcher(Reader, self._proc.stderr,
+

Change in vdsm[master]: monitoring: Introduce the eventloop module

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: monitoring: Introduce the eventloop module
..


Patch Set 9:

(2 comments)

Francesco, we have 2 event loops in vdsm:
- yajsonrpc/betterAsyncore.py
- lib/vdsm/virt/vmchannels.py

Both do not provide the services I need for the next patch 
(https://gerrit.ovirt.org/54757) like running calls in the event loop thread 
and schedule calls.

This eventloop can replace the betterAsyncore one, and maybe also the 
vmchannels one (not sure how it scales, since asycore is using poll). When we 
use Python 3, we can replace all with the builtin event loop, which supports 
also epoll out of the box.

I'm not suggesting to touch the infra reactor since I don't have time to work 
on it now.

https://gerrit.ovirt.org/#/c/54849/9/lib/vdsm/storage/eventloop.py
File lib/vdsm/storage/eventloop.py:

Line 188: 
Line 189: Any positional arguments after the callback will be passed to
Line 190: the callback when it is called.
Line 191: 
Line 192: Copied from Python 3.4 with without changes.
> unneeded
OK, I'll leave only the notes about changes, and add a general note about the 
entire class.
Line 193: """
Line 194: self._check_closed()
Line 195: return self._call_soon(callback, args)
Line 196: 


Line 238: 
Line 239: Any positional arguments after the callback will be passed to
Line 240: the callback when it is called.
Line 241: 
Line 242: Copied from Python 3.4 with without changes.
> unneeded
OK
Line 243: """
Line 244: return self.call_at(self.time() + delay, callback, *args)
Line 245: 
Line 246: def call_at(self, when, callback, *args):


-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: events: introduction of schema

[automation]

gerrit-hooks has posted comments on this change.

Change subject: events: introduction of schema
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54754
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I43a9f1852b1459a2e905244049507704f0187201
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Mucha 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: json: removal of old schemas

[automation]

gerrit-hooks has posted comments on this change.

Change subject: json: removal of old schemas
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[automation]

gerrit-hooks has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 24:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: data verification

[automation]

gerrit-hooks has posted comments on this change.

Change subject: bridge: data verification
..


Patch Set 12:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: set correct permissions for hwrng device

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: virt: set correct permissions for hwrng device
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/54806/4/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 392: 
Line 393: def uses_source(self, source):
Line 394: return self._SOURCES[self.specParams['source']] == source
Line 395: 
Line 396: def set_endpoint_permissions(self):
> Do we have a default implementation of this for all devices, or this is an 
Actually this is on my todo list: we currently don't (except for host devices, 
where detach/reattach routine can be abused). We need something (device setup, 
device teardown?) in the future.
Line 397: supervdsm.getProxy().appropriateHwrngDevice(self.conf['vmId'])
Line 398: 
Line 399: def unset_endpoint_permissions(self):
Line 400: 
supervdsm.getProxy().rmAppropriateHwrngDevice(self.conf['vmId'])


-- 
To view, visit https://gerrit.ovirt.org/54806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: fix naming style

[automation]

gerrit-hooks has posted comments on this change.

Change subject: bridge: fix naming style
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54948
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I149b233303a7bddfc52a7d690e77ae91b8152f84
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: usage of yaml schema

[automation]

gerrit-hooks has posted comments on this change.

Change subject: bridge: usage of yaml schema
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: set correct permissions for hwrng device

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: set correct permissions for hwrng device
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/54806/4/vdsm/virt/vmdevices/core.py
File vdsm/virt/vmdevices/core.py:

Line 392: 
Line 393: def uses_source(self, source):
Line 394: return self._SOURCES[self.specParams['source']] == source
Line 395: 
Line 396: def set_endpoint_permissions(self):
Do we have a default implementation of this for all devices, or this is an 
interface that works only for hwrng?
Line 397: supervdsm.getProxy().appropriateHwrngDevice(self.conf['vmId'])
Line 398: 
Line 399: def unset_endpoint_permissions(self):
Line 400: 
supervdsm.getProxy().rmAppropriateHwrngDevice(self.conf['vmId'])


-- 
To view, visit https://gerrit.ovirt.org/54806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: json: removal of old schemas

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: json: removal of old schemas
..


Patch Set 7: Verified+1

Change verified by host deploying vdsm, configuring a data domain and running 
single vm.

-- 
To view, visit https://gerrit.ovirt.org/54548
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2d8a9d0837408ab727ecdeaa37d49efbca5bebdc
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: data verification

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: bridge: data verification
..


Patch Set 12: Verified+1

Change verified by host deploying vdsm, configuring a data domain and running 
single vm.

-- 
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: usage of yaml schema

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: bridge: usage of yaml schema
..


Patch Set 7: Verified+1

Change verified by host deploying vdsm, configuring a data domain and running 
single vm.

-- 
To view, visit https://gerrit.ovirt.org/54528
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia76d8245568514d20e446237bd667d87fb4ad3e8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 24: Verified+1

Change verified by host deploying vdsm, configuring a data domain and running 
single vm.

-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: bridge: fix naming style

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: bridge: fix naming style
..


Patch Set 2: Verified+1

Change verified by host deploying vdsm, configuring a data domain and running 
single vm.

-- 
To view, visit https://gerrit.ovirt.org/54948
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I149b233303a7bddfc52a7d690e77ae91b8152f84
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: set correct permissions for hwrng device

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: virt: set correct permissions for hwrng device
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/54806/4/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

Line 70: _udevTrigger
> we do this already for other subsystem, AFAIR it's as race-free as we could
Let's assume it is not race free. Each function still creates it's file and 
triggers for given subsystem. In this model, it doesn't matter as long, as the 
file is owned by something that allows QEMU access (that is guaranteed by the 
fact that this functions is called and blocks. We don't care about future 
triggers.

As for reverting the permissions, similar scenario occurs: the function will 
not be called before the VM is destroyed, and races between similar functions 
barely matter.

I don't know how this exact case could be made more resilient.


-- 
To view, visit https://gerrit.ovirt.org/54806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingDriveInfo() out of Vm

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..


Patch Set 13: Code-Review+1

Thanks, looks better now.

-- 
To view, visit https://gerrit.ovirt.org/53677
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6b372f86b82da7422727f3d084b9afc5505a289
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingDriveInfo() out of Vm

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/53677/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1723: devices = self._devices
Line 1724: vmdevices.network.Interface.update_device_info(
Line 1725: self, devices[hwclass.NIC])
Line 1726: vmdevices.storage.Drive.update_device_info(
Line 1727: self, devices[hwclass.DISK])
> Why don't you like them? Because they are class methods or for another reas
I don't like them because updating the conf/devices from xml should not be the 
responsibility of the Device class. Classes should be responsible for creating 
instances.

Also in this design the code for handling the xml is spread all over the place, 
instead of one module handling this task.
Line 1728: vmdevices.core.Sound.update_device_info(
Line 1729: self, devices[hwclass.SOUND])
Line 1730: vmdevices.core.Video.update_device_info(
Line 1731: self, devices[hwclass.VIDEO])


-- 
To view, visit https://gerrit.ovirt.org/53677
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6b372f86b82da7422727f3d084b9afc5505a289
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: set correct permissions for hwrng device

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: set correct permissions for hwrng device
..


Patch Set 4: Code-Review+1

(1 comment)

partial review: I just need to deep dive of udev handling and refresh my 
knowledge. Looks good so far, hence partial ACK.

https://gerrit.ovirt.org/#/c/54806/4/vdsm/supervdsm_api/udev.py
File vdsm/supervdsm_api/udev.py:

Line 70: _udevTrigger
we do this already for other subsystem, AFAIR it's as race-free as we could 
get, right?


-- 
To view, visit https://gerrit.ovirt.org/54806
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: don't depend on ovirt-vmconsole on fedora

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: don't depend on ovirt-vmconsole on fedora
..


Patch Set 2: -Verified

with the workaround described in the commit message, it should now work.

-- 
To view, visit https://gerrit.ovirt.org/54999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: contrib: schema converter

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: contrib: schema converter
..


Patch Set 23:

(5 comments)

https://gerrit.ovirt.org/#/c/52864/23/contrib/schema-converter
File contrib/schema-converter:

Line 26: json_schema_path - path where json schema is located
Line 27: 
Line 28: yaml_schema_path - path where yaml schema is written
Line 29: """
Line 30: from api import vdsmapi
> Should be at the end of the imports as ths is the most specific import.
I am not importing it from current package so I can use '.'.

Will keep the import ordering tidy.
Line 31: 
Line 32: import sys
Line 33: import yaml
Line 34: 


Line 29: """
Line 30: from api import vdsmapi
Line 31: 
Line 32: import sys
Line 33: import yaml
> This is not from standard library, so it should be after the collections im
Done
Line 34: 
Line 35: from collections import OrderedDict
Line 36: 
Line 37: 


https://gerrit.ovirt.org/#/c/52864/23/lib/api/Makefile.am
File lib/api/Makefile.am:

Line 31:$(NULL)
Line 32: 
Line 33: dist_vdsmpyrpc_PYTHON = \
Line 34:__init__.py \
Line 35:schemaapi.py\
> Can we rename this to schema.py?
We are in removal old schemas patch and we reuse vdsmapi module name.
Line 36:vdsmapi.py \
Line 37:$(NULL)
Line 38: 
Line 39: dist_vdsmrpc_DATA = \


https://gerrit.ovirt.org/#/c/52864/23/lib/api/process-schema.py
File lib/api/process-schema.py:

Line 36
Line 37
Line 38
Line 39
Line 40
> Instead of moving this code, rename the module to process_schema.py, or bet
Done


https://gerrit.ovirt.org/#/c/52864/23/vdsm.spec.in
File vdsm.spec.in:

Line 79: BuildRequires: python-pthreading
Line 80: BuildRequires: qemu-img
Line 81: BuildRequires: rpm-python
Line 82: BuildRequires: python-blivet
Line 83: BuildRequires: python-yaml
> What about python3-yaml?
I can only see:

BuildRequires: python3-nose
BuildRequires: python3-six

and there are no other module dependencies with python3. Do we really want to 
add it now?
Line 84: 
Line 85: %if "@PYTHON3@" != ""
Line 86: BuildRequires: python3-nose
Line 87: BuildRequires: python3-six


-- 
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 23
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Martin Sivák 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: don't depend on ovirt-vmconsole on fedora

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: don't depend on ovirt-vmconsole on fedora
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54999/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: spec: don't depend on ovirt-vmconsole on fedora
Line 8: 
Line 9: Resurrect the koji_build flag to avoid to depend
Line 10: on ovirt-vmconsole on fedora, where the package
> Please include here the hack needed ot get VMs running. Just in case someon
Done
Line 11: is not yet present.
Line 12: 
Line 13: Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee


-- 
To view, visit https://gerrit.ovirt.org/54999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: don't depend on ovirt-vmconsole on fedora

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: don't depend on ovirt-vmconsole on fedora
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: bump libvirt requirement

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: spec: bump libvirt requirement
..


Patch Set 3: Code-Review+2 Verified+1

CI is good enough for verification.

-- 
To view, visit https://gerrit.ovirt.org/54796
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7c231a33161d91470e98165311f408cf6fa41d38
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: don't depend on ovirt-vmconsole on fedora

[fromani]

Francesco Romani has posted comments on this change.

Change subject: spec: don't depend on ovirt-vmconsole on fedora
..


Patch Set 1: Verified-1

"works", but VMs will fail to run without the ovirt-vmconsole group, which is 
owned by the ovirt-vmconsole package

-- 
To view, visit https://gerrit.ovirt.org/54999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: don't depend on ovirt-vmconsole on fedora

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: spec: don't depend on ovirt-vmconsole on fedora
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/54999/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: spec: don't depend on ovirt-vmconsole on fedora
Line 8: 
Line 9: Resurrect the koji_build flag to avoid to depend
Line 10: on ovirt-vmconsole on fedora, where the package
Please include here the hack needed ot get VMs running. Just in case someone 
actually needs that.
Line 11: is not yet present.
Line 12: 
Line 13: Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee


-- 
To view, visit https://gerrit.ovirt.org/54999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: native ovs [1]

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: native ovs [1]
..


Patch Set 20: Code-Review-1

(6 comments)

This is a partial review.

My recomendation is to split this patch into small subjects: caps, stats, 
netswitch, validator... etc.

I'm also missing the configurator layer here, at least as a skeleton.. It will 
make it clear why kernel interface and ip needs to be separated from the ovs 
parts.

https://gerrit.ovirt.org/#/c/54890/20/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 240: hooks.after_network_setup(
Line 241: _build_setup_hook_dict(networks, bondings, options))
Line 242: 
Line 243: 
Line 244: def _setup_networks(networks, bondings, options):
It will be best to have an additional patch, before this one, with the 
netswitch layer.

It should split and check switch types, validate switch, call the correct 
switch setup...

api.py should do little: Overall rollback logic, init stuff that we need in 
general (?), canonicalize part and the connectivity check.

Regarding the rollback, it will be good to add a TODO here to complete the 
overall rollback.
Line 245: canonicalize_networks(networks)
Line 246: # TODO: Add canonicalize_bondings(bondings)
Line 247: 
Line 248: running_config = RunningConfig()


Line 250: separate_native_ovs_nets_bonds
this is an example of netswitch responsibility


https://gerrit.ovirt.org/#/c/54890/20/lib/vdsm/network/ovs_switch/caps.py
File lib/vdsm/network/ovs_switch/caps.py:

Line 88: supervdsm.getProxy
Calling getProxy() from within the ovs switch is bad.
We need a strategy on how to get caps as root, but as a minimum I would 
recomend creating a new verb under network.api: 'caps_network', register it 
(like we do with setupNetworks) and use it to complement the existing non-root 
caps.

netinfo should be responsible for the collection of ovs information.
caps can use netinfo and build a caps report, but that could even be a netinfo 
method if no special logic is required.


https://gerrit.ovirt.org/#/c/54890/20/lib/vdsm/network/ovs_switch/stats.py
File lib/vdsm/network/ovs_switch/stats.py:

Line 28: networks_stats
Seems to fit 'normalize' based on what it actually does.
But I think it needs to be used differently, not to get stats as input but to 
generate fresh stats by itself.

And what about placing this under ovs netinfo?


https://gerrit.ovirt.org/#/c/54890/20/vdsm/caps.py
File vdsm/caps.py:

Line 166: 
Line 167: # TODO: Version requests by engine to ease handling of 
compatibility.
Line 168: netinfo_data = netinfo_cache.get(compatibility=30600)
Line 169: caps.update(netinfo_data)
Line 170: caps = ovs_caps.caps(caps)
The design included a netinfo hierarchy, passing caps of the switches through 
it seems appropriate.
It deserves its own patch.
Line 171: 
Line 172: try:
Line 173: caps['hooks'] = hooks.installed()
Line 174: except:


https://gerrit.ovirt.org/#/c/54890/20/vdsm/supervdsmServer
File vdsm/supervdsmServer:

Line 380: except cmdutils.Error as e:
Line 381: raise OSError(errno.EINVAL, 'Could not trigger change '
Line 382:   'out %s\nerr %s' % (e.out, e.err))
Line 383: 
Line 384: @logDecorator
Are you using these new verbs because you cannot get those with a non-root? 
Doesn't ovs support non-root read only access?

supervdsm verbs are now registered through vdsm/supervdsm_api/network.py and 
not here.
Line 385: def ovs_get_stp(self, iface):
Line 386: return ovs_caps.get_stp(iface)
Line 387: 
Line 388: @logDecorator


-- 
To view, visit https://gerrit.ovirt.org/54890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf958554c0f71cfe652869bd75eb17aea5ca676
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: ifcfg: re-enable IPv6 before device configuration, or disable 
afterwards
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54555
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add support for hotplug

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: add support for hotplug
..


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/42661/10/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2140: self.saveState()
 : self._getUnderlyingHostDeviceInfo()
> Difficult question. As the call can be quite complex to execute compared to
I don't have strong feelings yet. I'm trying to think what is 1. safer 2. 
faster (in this order) if we move likes 2134-2141 out of the loop and if we do 
those operations in bulk.


-- 
To view, visit https://gerrit.ovirt.org/42661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2465360664ef9b659c52dc610a95d2c2f1555c54
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: don't implicitly reattach devices

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: don't implicitly reattach devices
..


Patch Set 2: Code-Review+2

(1 comment)

https://gerrit.ovirt.org/#/c/54936/2//COMMIT_MSG
Commit Message:

Line 21: We can also assume that, on properly maintained
   : hosts, the devices are reserved for assignment and are not meant to be
   : used by the host at all.
> No, that is part of 'what we do for users'. We may at some point just let t
ok, fully makes sense to me.


-- 
To view, visit https://gerrit.ovirt.org/54936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1136292cb7e9d13a8202b1f5162299d2155e8036
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev/sr-iov: don't reattach devices
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: don't implicitly reattach devices

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: hostdev: don't implicitly reattach devices
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1136292cb7e9d13a8202b1f5162299d2155e8036
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: hostdev/sr-iov: don't reattach devices
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: move persistent to lib

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: storage: move persistent to lib
..


storage: move persistent to lib

Moving vdsm/storage/persistentDict.py to
lib/vdsm/storage/persistent.py

Change-Id: I525423502e20aceca872dd26f5cb408e8e69d12d
Signed-off-by: Fred Rolland 
Reviewed-on: https://gerrit.ovirt.org/54582
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M debian/vdsm-python.install
M debian/vdsm.install
M lib/vdsm/storage/Makefile.am
R lib/vdsm/storage/persistent.py
M tests/persistentDictTests.py
M vdsm.spec.in
M vdsm/storage/Makefile.am
M vdsm/storage/blockSD.py
M vdsm/storage/fileSD.py
M vdsm/storage/sd.py
M vdsm/storage/spbackends.py
11 files changed, 13 insertions(+), 12 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Freddy Rolland: Verified



-- 
To view, visit https://gerrit.ovirt.org/54582
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I525423502e20aceca872dd26f5cb408e8e69d12d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: storage: move persistent to lib

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: move persistent to lib
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54582
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I525423502e20aceca872dd26f5cb408e8e69d12d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Fred Rolland 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: don't depend on ovirt-vmconsole on fedora

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: spec: don't depend on ovirt-vmconsole on fedora
..

spec: don't depend on ovirt-vmconsole on fedora

Resurrect the koji_build flag to avoid to depend
on ovirt-vmconsole on fedora, where the package
is not yet present.

Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee
Signed-off-by: Francesco Romani 
---
M configure.ac
M vdsm.spec.in
2 files changed, 18 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/99/54999/1

diff --git a/configure.ac b/configure.ac
index 2ad70a7..0165a67 100644
--- a/configure.ac
+++ b/configure.ac
@@ -84,6 +84,19 @@
   AC_SUBST([GLUSTER_MGMT], ['0']))
 
 AC_ARG_ENABLE(
+[koji_build],
+[AS_HELP_STRING(
+[--enable-koji-build],
+[build koji version @<:@default=no@:>@]
+)],
+,
+[enable_koji_build="no"]
+)
+AS_IF([test "${enable_koji_build}" = "yes"],
+  AC_SUBST([KOJI_BUILD], ['1']),
+  AC_SUBST([KOJI_BUILD], ['0']))
+
+AC_ARG_ENABLE(
 [libvirt-sanlock],
 [AS_HELP_STRING(
 [--disable-libvirt-sanlock],
diff --git a/vdsm.spec.in b/vdsm.spec.in
index ecc804f..0ce5e81 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -10,6 +10,9 @@
 %global snlk_user @SNLKUSER@
 %global cdrom_group @CDROMGROUP@
 
+# Build types
+%global koji_build @KOJI_BUILD@
+
 # Features
 %global with_gluster_mgmt @GLUSTER_MGMT@
 %global with_hooks @HOOKS@
@@ -130,7 +133,9 @@
 Requires: safelease >= 1.0-5
 %endif
 Requires: mom >= 0.4.5
+%if 0%{?koji_build} == 0
 Requires: ovirt-vmconsole >= 1.0.0-0
+%endif
 
 %if 0%{?rhel}
 Requires: libguestfs-tools-c >= 1:1.20.11-10


-- 
To view, visit https://gerrit.ovirt.org/54999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: spec: don't depend on ovirt-vmconsole on fedora

[automation]

gerrit-hooks has posted comments on this change.

Change subject: spec: don't depend on ovirt-vmconsole on fedora
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54999
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81d39abcc55e371ac3631b0d5394ebf174c86fee
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: Skipping networkTests if alien bonds presents in the system

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Skipping networkTests if alien bonds presents in the system
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53498
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5326305fac74a43ca7cab259133e7a8861fa9261
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ilia Meerovich 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Ilia Meerovich 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: containers: detect and report container support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: containers: detect and report container support
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53820
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id236a30a5c875994c037b8d00c7463bceaab143f
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: sudo: add permissions to run containers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sudo: add permissions to run containers
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54178
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7e37ba8f510cf96990645868fca481b08aea4ba6
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: containers: initial support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: containers: initial support
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53821
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09e4b0552613ee160760a5a9bb4b27e0ae1f5d2f
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hook: add imagerepo feed containers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hook: add imagerepo feed containers
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I94ae3b82150981c76a6079d5741aeca8faa1dd33
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: containers: make sure directory are ready

[automation]

gerrit-hooks has posted comments on this change.

Change subject: containers: make sure directory are ready
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54177
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I48daf34026ece93032f9b336893b938fbab95f25
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: vm: events: don't abort creation if event fails

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vm: events: don't abort creation if event fails
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54933
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1a06df003fce796519df26550910352120da17a8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: recovery: refactor entry points

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: recovery: refactor entry points
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53819
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib60642992c7b7a33079a487d0ef27071b8b5
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: WIP: vm: skip domDependentInit for containers

[automation]

gerrit-hooks has posted comments on this change.

Change subject: WIP: vm: skip domDependentInit for containers
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54179
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7360d75c4adcab655c2cd215c6b9d91f9d92a646
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: HACK: virt: override vm type from custom property

[automation]

gerrit-hooks has posted comments on this change.

Change subject: HACK: virt: override vm type from custom property
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54872
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I63b89f8791a9b0eb08100c62dcfa28d29b2321a6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: supervdsm: configure container networks

[automation]

gerrit-hooks has posted comments on this change.

Change subject: network: supervdsm: configure container networks
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54998
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: containers: always add emulator to XML

[automation]

gerrit-hooks has posted comments on this change.

Change subject: containers: always add emulator to XML
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54176
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie40c6a3e2cdbb72053db71056092d3b7684b994d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: network: supervdsm: configure container networks

[fromani]

Francesco Romani has uploaded a new change for review.

Change subject: network: supervdsm: configure container networks
..

network: supervdsm: configure container networks

extend setupNetworks() to configure container's network
once existing configuration succeed.

We don't want to disrupt VM management, so if the
container setup fail, we should only log this and go ahead.

Change-Id: I338ca2d3abb0b1447c5a18c97afb9e14314f4107
Signed-off-by: Francesco Romani 
---
M debian/vdsm.install
M lib/vdsm/convirtconnection.py
M vdsm.spec.in
M vdsm/API.py
M vdsm/supervdsm_api/Makefile.am
A vdsm/supervdsm_api/convirt.py
6 files changed, 52 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/98/54998/1

diff --git a/debian/vdsm.install b/debian/vdsm.install
index 0cb26ce..8e6d72c 100644
--- a/debian/vdsm.install
+++ b/debian/vdsm.install
@@ -121,6 +121,7 @@
 ./usr/share/vdsm/storage/volume.py
 ./usr/share/vdsm/sitecustomize.py
 ./usr/share/vdsm/supervdsm_api/__init__.py
+./usr/share/vdsm/supervdsm_api/convirt.py
 ./usr/share/vdsm/supervdsm_api/hwinfo.py
 ./usr/share/vdsm/supervdsm_api/mkimage.py
 ./usr/share/vdsm/supervdsm_api/ksm.py
diff --git a/lib/vdsm/convirtconnection.py b/lib/vdsm/convirtconnection.py
index f57afb2..a2ff2de 100644
--- a/lib/vdsm/convirtconnection.py
+++ b/lib/vdsm/convirtconnection.py
@@ -26,6 +26,7 @@
 import convirt  # TODO: fix naming
 import convirt.api  # TODO: fix naming
 from convirt.config import environ
+from convirt.config import network
 _container_runtimes = convirt.api.supported()
 environ.update(run_dir='/var/run/ovirt-containers')
 except ImportError:
@@ -62,6 +63,21 @@
 return convirt.recoveryAllDomains()
 
 
+def setup_networks(nets):
+if not _container_runtimes:
+raise NotAvailable()
+bridge = nets.get('bonding', None) or nets.get('nic', None)
+if bridge is None:
+raise RuntimeError('cannot configure without bridge data')  # FIXME
+# TODO ipv6
+# TODO: ipaddr -> subnet
+network.update(name=bridge,  # TODO: is this correct?
+   bridge=bridge,
+   subnet=nets['ipaddr'],
+   mask=nets['netmask'])
+convirt.api.configure()
+
+
 def open_connection(uri=None, username=None, passwd=None):
 """ by calling this method you are getting a new and unwrapped connection
 if you want to use wrapped and cached connection use the get() method
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 35a1a3b..f558d3c 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -907,6 +907,7 @@
 %{_libexecdir}/%{vdsm_name}/vdsmd_init_common.sh
 %{_libexecdir}/%{vdsm_name}/wait_for_ipv4s
 %{_datadir}/%{vdsm_name}/supervdsm_api/__init__.py*
+%{_datadir}/%{vdsm_name}/supervdsm_api/convirt.py*
 %{_datadir}/%{vdsm_name}/supervdsm_api/hwinfo.py*
 %{_datadir}/%{vdsm_name}/supervdsm_api/mkimage.py*
 %{_datadir}/%{vdsm_name}/supervdsm_api/ksm.py*
diff --git a/vdsm/API.py b/vdsm/API.py
index 077d875..aad96bc 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -1471,6 +1471,11 @@
 try:
 self._cif._netConfigDirty = True
 supervdsm.getProxy().setupNetworks(networks, bondings, options)
+try:
+supervdsm.getProxy().setup_container_networks(networks)
+except Exception as exc:
+self.log.warning(
+'cannot setup container networks: %s', str(exc))
 return {'status': doneCode}
 except ConfigNetworkError as e:
 self.log.error(e.message, exc_info=True)
diff --git a/vdsm/supervdsm_api/Makefile.am b/vdsm/supervdsm_api/Makefile.am
index e59c6b5..c070a71 100644
--- a/vdsm/supervdsm_api/Makefile.am
+++ b/vdsm/supervdsm_api/Makefile.am
@@ -22,6 +22,7 @@
 supervdsm_apidir = $(vdsmdir)/supervdsm_api
 dist_supervdsm_api_PYTHON = \
__init__.py \
+   convirt.py \
test.py \
hwinfo.py \
ksm.py \
diff --git a/vdsm/supervdsm_api/convirt.py b/vdsm/supervdsm_api/convirt.py
new file mode 100644
index 000..4cb35ed
--- /dev/null
+++ b/vdsm/supervdsm_api/convirt.py
@@ -0,0 +1,28 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301 USA
+#
+# Refer to the 

Change in vdsm[master]: virt: Move Vm._getUnderlyingDriveInfo() out of Vm

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..


Patch Set 13: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/53677
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6b372f86b82da7422727f3d084b9afc5505a289
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingDriveInfo() out of Vm

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..


Patch Set 11:

(3 comments)

https://gerrit.ovirt.org/#/c/53677/11/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 1723: devices = self._devices
Line 1724: vmdevices.network.Interface.update_device_info(
Line 1725: self, devices[hwclass.NIC])
Line 1726: vmdevices.storage.Drive.update_device_info(
Line 1727: self, devices[hwclass.DISK])
> I don't like these class methods, but it seems to be too late now after you
Why don't you like them? Because they are class methods or for another reason? 
We can make changes in followup patches.
Line 1728: vmdevices.core.Sound.update_device_info(
Line 1729: self, devices[hwclass.SOUND])
Line 1730: vmdevices.core.Video.update_device_info(
Line 1731: self, devices[hwclass.VIDEO])


https://gerrit.ovirt.org/#/c/53677/11/vdsm/virt/vmdevices/storage.py
File vdsm/virt/vmdevices/storage.py:

Line 443: dom = ET.fromstring(xml_string)
Line 444: return bool(dom.findall(self._xpath))
Line 445: 
Line 446: @classmethod
Line 447: def _getDriveIdentification(cls, dom):
> I don't see any use of the cls argument - why is this a classmethod?
Done
Line 448: sources = dom.getElementsByTagName('source')
Line 449: if sources:
Line 450: devPath = (sources[0].getAttribute('file') or
Line 451:sources[0].getAttribute('dev') or


Line 457: alias = 
dom.getElementsByTagName('alias')[0].getAttribute('name')
Line 458: return alias, devPath, name
Line 459: 
Line 460: @classmethod
Line 461: def update_device_info(cls, vm, device_conf):
> Same, I don't see any use of this class, so it should be a function in this
Each device type has its own update_device_info method, so it should be in the 
corresponding class. We can argue whether it should be classmethod or 
staticmethod, but conceptually it's not a separate function.
Line 462: # FIXME!  We need to gather as much info as possible from the 
libvirt.
Line 463: # In the future we can return this real data to management 
instead of
Line 464: # vm's conf
Line 465: for x in vm.domain.get_device_elements('disk'):


-- 
To view, visit https://gerrit.ovirt.org/53677
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6b372f86b82da7422727f3d084b9afc5505a289
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingDriveInfo() out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingDriveInfo() out of Vm
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53677
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6b372f86b82da7422727f3d084b9afc5505a289
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Move Vm._getUnderlyingVmDevicesInfo() content out of Vm
..


Patch Set 13:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/53679
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I81a0da783bc40f0f08dfdac2bbb955bc55d81b0e
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...

[osvoboda]

Ondřej Svoboda has posted comments on this change.

Change subject: ifcfg: re-enable IPv6 before device configuration, or disable 
afterwards
..


Patch Set 8:

This may be related to _wait_for_event in _ifup which expects an IPv6 
link-local address.

==
FAIL: testSetupNetworksMultiMTUsOverNic(False) 
(functional.networkTests.NetworkTest)
--
Traceback (most recent call last):
  File "/usr/share/vdsm/tests/testlib.py", line 73, in wrapper
return f(self, *args)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 213, in wrapper
func(*args, **kwargs)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 1253, in 
testSetupNetworksMultiMTUsOverNic
mtu=1400)
  File "/usr/share/vdsm/tests/functional/networkTests.py", line 1235, in 
_createVlanedNetOverNicAndCheck
self.assertEquals(status, SUCCESS, msg)
AssertionError: Unexpected exception
 >> begin captured logging << 
root: DEBUG: /usr/bin/taskset --cpu-list 0-0 /usr/sbin/tc qdisc show (cwd None)
root: DEBUG: SUCCESS:  = '';  = 0
root: INFO: Adding network test-network0({'vlan': 27, 'nic': 'dummy_i9fhY', 
'dhcpv6': False, 'mtu': 1500, 'bootproto': 'none', 'bridged': False, 
'defaultRoute': False})
root: DEBUG: /usr/bin/taskset --cpu-list 0-0 /usr/sbin/tc qdisc show (cwd None)
root: DEBUG: SUCCESS:  = '';  = 0
root: INFO: Adding network test-network0({'vlan': 27, 'nic': 'dummy_i9fhY', 
'dhcpv6': False, 'mtu': 1500, 'bootproto': 'none', 'bridged': False, 
'defaultRoute': False})
- >> end captured logging << -


MainProcess|Thread-654::ERROR::2016-03-21 
11:17:23,454::supervdsmServer::96::SuperVdsm.ServerCallback::(wrapper) Error in 
setupNetworks
Traceback (most recent call last):
  File "/usr/share/vdsm/supervdsmServer", line 94, in wrapper
res = func(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/vdsm/network/api.py", line 226, in 
setupNetworks
_setup_networks(networks, bondings, options)
  File "/usr/lib/python2.7/site-packages/vdsm/network/api.py", line 268, in 
_setup_networks
bondings, _netinfo)
  File "/usr/lib/python2.7/site-packages/vdsm/network/legacy_switch.py", line 
465, in add_missing_networks
_netinfo=_netinfo, **attrs)
  File "/usr/lib/python2.7/site-packages/vdsm/network/legacy_switch.py", line 
175, in wrapped
return func(network, configurator, **kwargs)
  File "/usr/lib/python2.7/site-packages/vdsm/network/legacy_switch.py", line 
245, in _add_network
net_ent_to_configure.configure(**options)
  File "/usr/lib/python2.7/site-packages/vdsm/network/models.py", line 142, in 
configure
self.configurator.configureVlan(self, **opts)
  File "/usr/lib/python2.7/site-packages/vdsm/network/configurators/ifcfg.py", 
line 113, in configureVlan
_ifup(vlan)
  File "/usr/lib/python2.7/site-packages/vdsm/network/configurators/ifcfg.py", 
line 820, in _ifup
_exec_ifup(iface, cgroup)
  File "/usr/lib64/python2.7/contextlib.py", line 24, in __exit__
self.gen.next()
  File "/usr/lib/python2.7/site-packages/vdsm/network/configurators/ifcfg.py", 
line 961, in _wait_for_event
mon.stop()
  File "/usr/lib/python2.7/site-packages/vdsm/netlink/monitor.py", line 164, in 
stop
raise MonitorError(E_NOT_RUNNING)
MonitorError: 1

-- 
To view, visit https://gerrit.ovirt.org/54555
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add support for hotplug

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: hostdev: add support for hotplug
..


Patch Set 10:

(3 comments)

https://gerrit.ovirt.org/#/c/42661/10/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2117: index
> what do you need this for?
leftovers! :( will remove


Line 2140: self.saveState()
 : self._getUnderlyingHostDeviceInfo()
> question: why after each iteration and not just once after the loop ended?
Difficult question. As the call can be quite complex to execute compared to 
others, this was idea of 'some' security. Would you prefer only a single call 
at the end?


Line 2143: list
> why explicit call to list()?
used set before, will fix!


-- 
To view, visit https://gerrit.ovirt.org/42661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2465360664ef9b659c52dc610a95d2c2f1555c54
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: don't implicitly reattach devices

[mpolednik]

Martin Polednik has posted comments on this change.

Change subject: hostdev: don't implicitly reattach devices
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/54936/2//COMMIT_MSG
Commit Message:

Line 21: We can also assume that, on properly maintained
   : hosts, the devices are reserved for assignment and are not meant to be
   : used by the host at all.
> hence, question: if we assume properly maintained host, shouldn't we skip s
No, that is part of 'what we do for users'. We may at some point just let the 
user define a group of devices that will be used and detach them on startup, 
but it's unclear whether there are any more benefits to that approach.

The idea behind this change is to do detach seamlessly, and only if the host is 
something like laptop used for testing allow user to reattach the device. Doing 
it automagically is dangerous.


-- 
To view, visit https://gerrit.ovirt.org/54936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1136292cb7e9d13a8202b1f5162299d2155e8036
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: expose parameters needed to support hotunplug

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: expose parameters needed to support hotunplug
..


Patch Set 2: Code-Review+1

(1 comment)

partial review. Looks OK, albeit a bit hard to parse. Partial ACK.
Please check the inline comments and let's try to make it easier to read.

https://gerrit.ovirt.org/#/c/54939/2/vdsm/virt/vmdevices/hostdevice.py
File vdsm/virt/vmdevices/hostdevice.py:

Line 65: return ('./devices/hostdev/source/address{}'.format(
   : ''.join(['[@{key}=\'{base}{value:{padding}}\']'.format(
   : key=key, value=int(value), **_padding(key)) for
   : key, value in self.hostAddress.items()])))
this is a bit too terse. Could you please unzip it to make easier to parse for 
humans?


-- 
To view, visit https://gerrit.ovirt.org/54939
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09e879051b1d47e48e9ae73c1f7d9bfbea8f1237
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: expose hotplug via vdsClient

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: expose hotplug via vdsClient
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54938
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46fb415c39d04b94428703ac19da505a2cf2800d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: add support for hotplug

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: add support for hotplug
..


Patch Set 10: Code-Review-1

(4 comments)

looks ok, but questions inside. Please check the inline comments. -1 for 
visibility.

https://gerrit.ovirt.org/#/c/42661/10/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2104: dev_objects.append((vmdevices.hostdevice.HostDevice(
 : self.conf, self.log, **dev_spec)))
 : try:
 : dev_objects[-1].detach()
 : except libvirt.libvirtError:
minor: I'd do:


  host_dev = vmdevices.hostdevice.HostDevice(
self.conf, self.log, **dev_spec)
  try:
host_dev.detach()
  except libvirt.libvirtError:
# handle it
  dev_objects.append(host_dev)


no big deal however. Your call


Line 2117: index
what do you need this for?


Line 2140: self.saveState()
 : self._getUnderlyingHostDeviceInfo()
question: why after each iteration and not just once after the loop ended?


Line 2143: list
why explicit call to list()?


-- 
To view, visit https://gerrit.ovirt.org/42661
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2465360664ef9b659c52dc610a95d2c2f1555c54
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Ido Barkan 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev/sr-iov: don't reattach devices

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev/sr-iov: don't reattach devices
..


Patch Set 2: Code-Review+1

if 54936 is ok, this follows suit.

-- 
To view, visit https://gerrit.ovirt.org/54937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I890e103e193776f269ab7d4f98c006f1b0bcb266
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: hostdev: don't implicitly reattach devices

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: don't implicitly reattach devices
..


Patch Set 2: Code-Review+1

(1 comment)

https://gerrit.ovirt.org/#/c/54936/2//COMMIT_MSG
Commit Message:

Line 21: We can also assume that, on properly maintained
   : hosts, the devices are reserved for assignment and are not meant to be
   : used by the host at all.
hence, question: if we assume properly maintained host, shouldn't we skip step 
#1 above as well?


-- 
To view, visit https://gerrit.ovirt.org/54936
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1136292cb7e9d13a8202b1f5162299d2155e8036
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: cpuarch: Move PAGE_SIZE_BYTES to cpuarch

[automation]

gerrit-hooks has posted comments on this change.

Change subject: cpuarch: Move PAGE_SIZE_BYTES to cpuarch
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3'])

-- 
To view, visit https://gerrit.ovirt.org/54990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id36da115083b94f5c4c24b2af066e70caf09a17b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: cpuarch: Move PAGE_SIZE_BYTES to cpuarch

[mpolednik]

Martin Polednik has uploaded a new change for review.

Change subject: cpuarch: Move PAGE_SIZE_BYTES to cpuarch
..

cpuarch: Move PAGE_SIZE_BYTES to cpuarch

This constant is mostly related to the CPU architecture.

Change-Id: Id36da115083b94f5c4c24b2af066e70caf09a17b
Signed-off-by: Martin Polednik 
---
M lib/vdsm/cpuarch.py
M lib/vdsm/health.py
M tests/momTests.py
M vdsm/API.py
M vdsm/caps.py
M vdsm/momIF.py
6 files changed, 12 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/54990/1

diff --git a/lib/vdsm/cpuarch.py b/lib/vdsm/cpuarch.py
index bbb1332..387e7e3 100644
--- a/lib/vdsm/cpuarch.py
+++ b/lib/vdsm/cpuarch.py
@@ -20,6 +20,7 @@
 
 from __future__ import absolute_import
 
+import os
 import platform
 
 from .config import config
@@ -31,6 +32,8 @@
 
 SUPPORTED_ARCHITECTURES = (X86_64, PPC64, PPC64LE)
 
+PAGE_SIZE_BYTES = os.sysconf('SC_PAGESIZE')
+
 
 class UnsupportedArchitecture(Exception):
 def __init__(self, target_arch):
diff --git a/lib/vdsm/health.py b/lib/vdsm/health.py
index 1b414a5..8e50a7f 100644
--- a/lib/vdsm/health.py
+++ b/lib/vdsm/health.py
@@ -26,6 +26,7 @@
 
 from . config import config
 from . import concurrent
+from . import cpuarch
 
 _monitor = None
 
@@ -114,7 +115,6 @@
 
 class ProcStat(object):
 
-_PAGE_SIZE = os.sysconf("SC_PAGESIZE")
 _TICKS_PER_SEC = os.sysconf("SC_CLK_TCK")
 _PATH = "/proc/self/stat"
 
@@ -125,7 +125,7 @@
 self.utime = int(fields[13], 10) / float(self._TICKS_PER_SEC)
 self.stime = int(fields[14], 10) / float(self._TICKS_PER_SEC)
 self.threads = int(fields[19], 10)
-self.rss = int(fields[23], 10) * self._PAGE_SIZE / 1024
+self.rss = int(fields[23], 10) * cpuarch.PAGE_SIZE_BYTES / 1024
 
 
 def saferepr(obj):
diff --git a/tests/momTests.py b/tests/momTests.py
index bf11a84..b5b512c 100644
--- a/tests/momTests.py
+++ b/tests/momTests.py
@@ -21,12 +21,13 @@
 import logging
 import threading
 from momIF import MomClient
-from caps import PAGE_SIZE_BYTES
 from vdsm.define import Mbytes
 from mom import unixrpc
 from six.moves import configparser
 import os.path
 import monkeypatch
+
+from vdsm import cpuarch
 
 MOM_CONF = "/dev/null"
 MOM_PORT = os.path.join(os.path.dirname(__file__), "test_mom_vdsm.sock")
@@ -160,7 +161,7 @@
 "ksmMergeAcrossNodes": True,
 "ksmState": False,
 "ksmPages": 5,
-"memShared": 100 * PAGE_SIZE_BYTES / Mbytes
+"memShared": 100 * cpuarch.PAGE_SIZE_BYTES / Mbytes
 }
 
 self.assertEqual(stats, expected)
diff --git a/vdsm/API.py b/vdsm/API.py
index 077d875..f905fb4 100644
--- a/vdsm/API.py
+++ b/vdsm/API.py
@@ -28,6 +28,7 @@
 from vdsm.network.errors import ConfigNetworkError
 
 from vdsm import commands
+from vdsm import cpuarch
 from vdsm import utils
 from clientIF import clientIF
 from vdsm import constants
@@ -53,7 +54,6 @@
 from vdsm.define import doneCode, errCode, Kbytes, Mbytes
 import caps
 from vdsm.config import config
-from caps import PAGE_SIZE_BYTES
 
 
 haClient = None  # Define here to work around pyflakes issue #13
@@ -1606,7 +1606,7 @@
 resident += int(statmfile.read().split()[1])
 except:
 pass
-resident *= PAGE_SIZE_BYTES
+resident *= cpuarch.PAGE_SIZE_BYTES
 meminfo = utils.readMemInfo()
 freeOrCached = (meminfo['MemFree'] +
 meminfo['Cached'] + meminfo['Buffers']) * Kbytes
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 539deb3..899b25e 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -46,8 +46,6 @@
 RNG_SOURCES = {'random': '/dev/random',
'hwrng': '/dev/hwrng'}
 
-PAGE_SIZE_BYTES = os.sysconf('SC_PAGESIZE')
-
 
 def _getFreshCapsXMLStr():
 return libvirtconnection.get().getCapabilities()
diff --git a/vdsm/momIF.py b/vdsm/momIF.py
index 0800af1..a5523ce 100644
--- a/vdsm/momIF.py
+++ b/vdsm/momIF.py
@@ -21,9 +21,10 @@
 import logging
 import socket
 from vdsm.config import config
-from caps import PAGE_SIZE_BYTES
 from vdsm.define import Mbytes
 
+from vdsm.cpuarch import PAGE_SIZE_BYTES
+
 try:
 import mom
 from mom import unixrpc


-- 
To view, visit https://gerrit.ovirt.org/54990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id36da115083b94f5c4c24b2af066e70caf09a17b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: decode XML string when parsing devices

[fromani]

Francesco Romani has submitted this change and it was merged.

Change subject: hostdev: decode XML string when parsing devices
..


hostdev: decode XML string when parsing devices

As there is no encoding of information and libvirt does not handle
encoding, our best bet is ascii. This patch therefore converts device
XMLs to ascii, ignoring the errors found.

Change-Id: Iaf9b9699790c83bb82a88a700c63d05604588d02
Bug-Url: https://bugzilla.redhat.com/1315435
Signed-off-by: Martin Polednik 
Reviewed-on: https://gerrit.ovirt.org/54802
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
Reviewed-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/54980
---
M tests/devices/data/Makefile.am
A tests/devices/data/computer.xml
M tests/hostdevTests.py
M tests/vmfakelib.py
M vdsm/hostdev.py
5 files changed, 32 insertions(+), 2 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, but someone else must approve
  Francesco Romani: Looks good to me, approved
  Martin Polednik: Verified



-- 
To view, visit https://gerrit.ovirt.org/54980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iaf9b9699790c83bb82a88a700c63d05604588d02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: decode XML string when parsing devices

[fromani]

Francesco Romani has posted comments on this change.

Change subject: hostdev: decode XML string when parsing devices
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf9b9699790c83bb82a88a700c63d05604588d02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: decode XML string when parsing devices

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: decode XML string when parsing devices
..


Patch Set 2:

* #1315435::Update tracker: OK
* Set MODIFIED::bug 1315435#1315435OK

-- 
To view, visit https://gerrit.ovirt.org/54980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf9b9699790c83bb82a88a700c63d05604588d02
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the eventloop module

[fromani]

Francesco Romani has posted comments on this change.

Change subject: monitoring: Introduce the eventloop module
..


Patch Set 9:

initial review:
at first glance seems fine, very nice to read, well done and well tested, with 
just few minor documentation glitches here and there (please see inline 
comments).

Given the fact you need a new eventloop, I think it is a good idea to be 
forward compatible with the API we will find in python 3.

I just have a couple of general concerns; being general, they also apply to 
this patch

1. I feel weird we need another eventloop. Can't we extract something from the 
existing codebase? How much work would that cost?
2. In general, I'm not a fan of ripping code from external modules and bundle 
on our codebase - this is essentially a backport/fork of python 3.x code.

To wrap up, *if* we need yet another event loop, I think this patch is very 
promising and a good change. But do we really need to maintain another event 
loop?

-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[ovirt-3.6]: hostdev: decode XML string when parsing devices

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hostdev: decode XML string when parsing devices
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54980
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf9b9699790c83bb82a88a700c63d05604588d02
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: IP address hosttail split tool

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: IP address hosttail split tool
..


Patch Set 6:

Edy, you'd better express your dislike in your git commit message, where it is 
more likely to be preserved.

-- 
To view, visit https://gerrit.ovirt.org/54312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: net: IP address hosttail split tool

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: IP address hosttail split tool
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/54312
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: move sourcerouting_test to tests/net where it belongs

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: tests: move sourcerouting_test to tests/net where it belongs
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/54923
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1caeaec31f4dfe2717a6cc3fded5fc937a909e25
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: move sourcerouting_test to tests/net where it belongs

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: move sourcerouting_test to tests/net where it belongs
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/54923
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1caeaec31f4dfe2717a6cc3fded5fc937a909e25
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: tests: move sourcerouting_test to tests/net where it belongs

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: tests: move sourcerouting_test to tests/net where it belongs
..


tests: move sourcerouting_test to tests/net where it belongs

Change-Id: I1caeaec31f4dfe2717a6cc3fded5fc937a909e25
Signed-off-by: Dan Kenigsberg 
Reviewed-on: https://gerrit.ovirt.org/54923
Continuous-Integration: Jenkins CI
Reviewed-by: Edward Haas 
Tested-by: Edward Haas 
---
M debian/vdsm-tests.install
M tests/Makefile.am
M tests/network/Makefile.am
R tests/network/ip_route_show_table_all.out
R tests/network/sourcerouting_test.py
M vdsm.spec.in
6 files changed, 7 insertions(+), 3 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified; Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/54923
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1caeaec31f4dfe2717a6cc3fded5fc937a909e25
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: monitoring: Introduce the eventloop module

[fromani]

Francesco Romani has posted comments on this change.

Change subject: monitoring: Introduce the eventloop module
..


Patch Set 9:

(2 comments)

https://gerrit.ovirt.org/#/c/54849/9/lib/vdsm/storage/eventloop.py
File lib/vdsm/storage/eventloop.py:

Line 192: with
unneeded


Line 242: with
unneeded


-- 
To view, visit https://gerrit.ovirt.org/54849
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: osinfo: refactor package_versions function

[fromani]

Francesco Romani has posted comments on this change.

Change subject: osinfo: refactor package_versions function
..


Patch Set 5: Code-Review+1

(1 comment)

looks fine

https://gerrit.ovirt.org/#/c/54546/5/lib/vdsm/osinfo.py
File lib/vdsm/osinfo.py:

Line 129: if osname == OSName.RHEVH or osname == OSName.OVIRT:
Line 130: version, release_name = 
_parse_node_version('/etc/default/version')
Line 131: elif osname == OSName.DEBIAN:
Line 132: version = linecache.getline('/etc/debian_version', 
1).strip('\n')
Line 133: release_name = ''  # Debian just has a version entry
this change is unneeded, but I don't mind this time. If you have to resubmit, 
please drop it.
Line 134: else:
Line 135: if osname == OSName.POWERKVM:
Line 136: release_path = '/etc/ibm_powerkvm-release'
Line 137: else:


-- 
To view, visit https://gerrit.ovirt.org/54546
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I36e9a605bea5ec6b823eaca4d7669c5060122fcd
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: grub2: expose via API

[automation]

gerrit-hooks has posted comments on this change.

Change subject: grub2: expose via API
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/49656
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61eec50cf0923e2874ff1e8b8d90fa4380b8fdb2
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Change in vdsm[master]: lib: grub2 module

[automation]

gerrit-hooks has posted comments on this change.

Change subject: lib: grub2 module
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found

-- 
To view, visit https://gerrit.ovirt.org/47946
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9e7e0b327882f64196a71fe20dcbd99017b80800
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches