Change in vdsm[master]: commit-template: Refine the example text
Allon Mureinik has posted comments on this change. Change subject: commit-template: Refine the example text .. Patch Set 1: Verified-1 (2 comments) https://gerrit.ovirt.org/#/c/55105/1/commit-template.txt File commit-template.txt: PS1, Line 3: module name, subsystem name, or feature name, "a module name, a subsystem name or a feature name," PS1, Line 11: neccesary typo. should be "necessary". -- To view, visit https://gerrit.ovirt.org/55105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16f0e6981447c7f467d4a22fb59b1ba7d736a389 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: schema converter
Nir Soffer has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 25:
(3 comments)
https://gerrit.ovirt.org/#/c/52864/25/tests/schemaValidationTest.py
File tests/schemaValidationTest.py:
Line 77
Line 78
Line 79
Line 80
Line 81
Why do we need to change this test?
Line 36: from nose.plugins.skip import SkipTest
Line 37:
Line 38:
Line 39: @contextmanager
Line 40: def schema_not_found():
Why do we need this?
Line 41: try:
Line 42: yield
Line 43: except schemaapi.SchemaNotFound:
Line 44: raise SkipTest('yaml schema not available')
Line 194: else:
Line 195: return None
Line 196:
Line 197:
Line 198: class JsonToYamlValidation(TestCaseBase):
To test the yaml schema, we don't need to find the schema.
The test should:
- Convert the json schema to yaml
- Read both json and yaml schema
- Normalized type names (e.g. str/string)
- Verify that both are the same
This is the only thing we need to replace the json schema with yaml.
Line 199:
Line 200: def swap_types(self, name):
Line 201: if name == 'str':
Line 202: return 'string'
--
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: contrib: schema converter
Nir Soffer has posted comments on this change.
Change subject: contrib: schema converter
..
Patch Set 25:
(4 comments)
https://gerrit.ovirt.org/#/c/52864/25/lib/api/schemaapi.py
File lib/api/schemaapi.py:
Line 48: raise SchemaNotFound("Unable to find API schema file in %s or %s",
Line 49: localpath, installedpath)
Line 50:
Line 51:
Line 52: class SchemaCache(object):
Can you rename this class in this patch? (should not break the next patches).
Line 53:
Line 54: def __init__(self, paths):
Line 55: self._schema = {}
Line 56: try:
Line 54: def __init__(self, paths):
Line 55: self._schema = {}
Line 56: try:
Line 57: for path in paths:
Line 58: with open(path) as f:
Why do we need to support multiple schema files?
Line 59: data = yaml.load(f)
Line 60: self._schema.update({key: value for (key, value)
Line 61: in data.items() if key !=
'types'})
Line 62:
Line 55: self._schema = {}
Line 56: try:
Line 57: for path in paths:
Line 58: with open(path) as f:
Line 59: data = yaml.load(f)
data is good name for blob of bytes. But this is a dict, or actually a schema
dict.
Line 60: self._schema.update({key: value for (key, value)
Line 61: in data.items() if key !=
'types'})
Line 62:
Line 63: self._schema['types'] = dict(
Line 61: in data.items() if key !=
'types'})
Line 62:
Line 63: self._schema['types'] = dict(
Line 64: self._schema.get('types', {}).items() +
Line 65: data.get('types').items())
This code is not clear and very inefficient.
- copy huge dict into a huge tuple (items())
- create a temporary dict from the tuple, filtering out 'types'
- update an schema dict with the temporary dict
- copy schema['types'] to tuple
- copy new schema['types'] to tuple
- create new dict from both tuples
How about:
self._methods = {}
self._types = {}
for path in paths:
with open(path):
schema = yaml.load(f)
types = schema.pop('types')
self._types.update(types)
self._methods.update(schema)
We never expose the underlying _schema, so there is no reason to keep the the
schema in single dict.
Line 66: except IOError:
Line 67: raise SchemaNotFound("Unable to find API schema file")
Line 68:
Line 69: def get_params(self, class_name, method_name):
--
To view, visit https://gerrit.ovirt.org/52864
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3921cebb7f550f63849f3bc5c80636b6e9495c92
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Darshan N
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Martin Sivák
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Oved Ourfali
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Sahina Bose
Gerrit-Reviewer: Vinzenz Feenstra
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: bridge: data verification
Nir Soffer has posted comments on this change.
Change subject: bridge: data verification
..
Patch Set 13:
(5 comments)
https://gerrit.ovirt.org/#/c/53919/13/tests/schemaapi_test.py
File tests/schemaapi_test.py:
Line 66: params = {"addr": "rack05-pdu01-lab4.tlv.redhat.com", "port":
54321,
Line 67: "agent": "apc_snmp", "username": "emesika",
Line 68: "password": "pass", "action": "off", "options":
"port=15"}
Line 69:
Line 70: _schema.schema().verify_params('Host', 'fenceNode', params)
What do you test here? I don't see any assert
Line 71:
Line 72: @MonkeyPatch(schemaapi, 'config',
Line 73: make_config([('devel', 'api_strict_mode', 'true')]))
Line 74: def test_ok_response(self):
Line 73: make_config([('devel', 'api_strict_mode', 'true')]))
Line 74: def test_ok_response(self):
Line 75: ret = {'power': 'on'}
Line 76:
Line 77: _schema.schema().verify_retval('Host', 'fenceNode', ret)
Same
Line 78:
Line 79: @MonkeyPatch(schemaapi, 'config',
Line 80: make_config([('devel', 'api_strict_mode', 'true')]))
Line 81: def test_unknown_response_type(self):
Line 78:
Line 79: @MonkeyPatch(schemaapi, 'config',
Line 80: make_config([('devel', 'api_strict_mode', 'true')]))
Line 81: def test_unknown_response_type(self):
Line 82: with self.assertRaises(JsonRpcError) as e:
Why does it raise JsonRpcError? what public error is returned to the client?
I would expect that this will raise something like UnknownKey or some other
SchemaVerificationError that explain the issue.
Line 83: ret = {'My caps': 'My capabilites'}
Line 84:
Line 85: _schema.schema().verify_retval('Host', 'getCapabilities',
ret)
Line 86:
Line 83: ret = {'My caps': 'My capabilites'}
Line 84:
Line 85: _schema.schema().verify_retval('Host', 'getCapabilities',
ret)
Line 86:
Line 87: self.assertIn('My caps', e.exception.message)
What does does it mean that we have this text in the message?
Line 88:
Line 89: @MonkeyPatch(schemaapi, 'config',
Line 90: make_config([('devel', 'api_strict_mode', 'true')]))
Line 91: def test_unknown_param(self):
Line 86:
Line 87: self.assertIn('My caps', e.exception.message)
Line 88:
Line 89: @MonkeyPatch(schemaapi, 'config',
Line 90: make_config([('devel', 'api_strict_mode', 'true')]))
This monkey patching is repeating too much, maybe move to to a helper function:
def api_strict_mode():
return MonkeyPatch(schemaapi, 'config', make_config([('devel',
'api_strict_mode', 'true')]))
Then use it like this:
@api_strict_mode()
Line 91: def test_unknown_param(self):
Line 92: params = {"storagepoolID":
"0002-0002-0002-0002-00f6",
Line 93: "onlyForce": True,
Line 94: "storagedomainID":
"773adfc7-10d4-4e60-b700-3272ee1871f9"}
--
To view, visit https://gerrit.ovirt.org/53919
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id24a5e078fa92e4129d37a47593c7a167e78712e
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitoring: Introduce the eventloop module
Nir Soffer has posted comments on this change. Change subject: monitoring: Introduce the eventloop module .. Patch Set 11: Verified+1 -- To view, visit https://gerrit.ovirt.org/54849 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I627f06f136792967f257b6ec439622432f2021be Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitoring: Introduce the check module
gerrit-hooks has posted comments on this change. Change subject: monitoring: Introduce the check module .. Patch Set 25: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug * Check Product::#1081962::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852 Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitoring: Introduce the check module
gerrit-hooks has posted comments on this change. Change subject: monitoring: Introduce the check module .. Patch Set 24: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug * Check Product::#1081962::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: monitoring: Introduce the check module
gerrit-hooks has posted comments on this change. Change subject: monitoring: Introduce the check module .. Patch Set 23: * #1081962::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1081962::OK, public bug * Check Product::#1081962::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54757 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If22fe38b8b29116270f9012b75895506adc48852 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Warn about callers of fileUtils.createdir()
Nir Soffer has submitted this change and it was merged. Change subject: fileUtils: Warn about callers of fileUtils.createdir() .. fileUtils: Warn about callers of fileUtils.createdir() To ensure we will check the callers of fileUtils.createdir() it emits now a warning when a directory exists. The warning is available only when python_warnings_enable option is enabled, so it does not effect users. Change-Id: I5c3e7e21367eb690d0c7a6c6f79c515b18a9fff0 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/37003 Continuous-Integration: Jenkins CI Reviewed-by: Adam Litke --- M vdsm/storage/fileUtils.py 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Adam Litke: Looks good to me, approved Nir Soffer: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/37003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c3e7e21367eb690d0c7a6c6f79c515b18a9fff0 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Warn about callers of fileUtils.createdir()
gerrit-hooks has posted comments on this change. Change subject: fileUtils: Warn about callers of fileUtils.createdir() .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/37003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c3e7e21367eb690d0c7a6c6f79c515b18a9fff0 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: HA: Make getHostLeaseStatus API public
Nir Soffer has posted comments on this change.
Change subject: HA: Make getHostLeaseStatus API public
..
Patch Set 6:
(2 comments)
https://gerrit.ovirt.org/#/c/29157/6/client/vdsClient.py
File client/vdsClient.py:
Line 1837:
Line 1838: def getHostLeaseStatus(self, args):
Line 1839: domains = {}
Line 1840: for pair in args:
Line 1841: sdUUID, hostId = pair.split('=', 1)
> Minor nit but wouldn't it make more sense to use : to separate the sdUUID a
Why? Is this more common in vdsClient?
I think I chose this since it is closer to common command line interface:
--option=value
Line 1842: domains[sdUUID] = int(hostId)
Line 1843: response = self.s.getHostLeaseStatus(domains)
Line 1844: if response['status']['code']:
Line 1845: print("Cannot get host storage liveliness")
https://gerrit.ovirt.org/#/c/29157/6/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:
Line 2300: #
Line 2301: # Since: 4.18
Line 2302: ##
Line 2303: {'map': 'HostLeaseStatusMap',
Line 2304: 'key': 'UUID', 'value': 'str'}
> So this API is limited to one query per domain? The internal API does not
No, host ids are unique per domain. Currently engine is using the same id on
all domains, but we want to support different host id for each domain. This is
the reason the internal api was designed like this.
This patch is about exposing the internal api, not changing it.
Line 2305:
Line 2306: ##
Line 2307: # @Host.getHostLeaseStatus:
Line 2308: #
--
To view, visit https://gerrit.ovirt.org/29157
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I415c1fee6256bf8d4e03ee542cc58e193162e9b8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Allon Mureinik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Daniel Erez
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot
Gerrit-Reviewer: Maor Lipchuk
Gerrit-Reviewer: Martin Peřina
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Saggi Mizrahi
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add readers contention rwlock test
Nir Soffer has posted comments on this change. Change subject: tests: Add readers contention rwlock test .. Patch Set 4: Verified+1 Rebase without a change. -- To view, visit https://gerrit.ovirt.org/51923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdaf5096d0898d97db6234538233dfa01217f9ed Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rwlock: Replace misc.RWLock
Nir Soffer has posted comments on this change. Change subject: rwlock: Replace misc.RWLock .. Patch Set 21: This change update the import after previous patch move rwlock to lib/vdsm/storage. -- To view, visit https://gerrit.ovirt.org/43423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ae6064e8e031339303e64606a70673807c4083a Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rwlock: Add simpler RWLock
Nir Soffer has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 25: This version move the new lock to lib/vdsm/storage, since this is a delicate storage only infrastructure. We will move it to lib/vdsm/common only if this is needed in other areas. The test was renamed to storage_rwlock_test.py to match the new location. There is no change in the code. -- To view, visit https://gerrit.ovirt.org/42908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rwlock: Add simpler RWLock
Nir Soffer has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 25: Verified+1 -- To view, visit https://gerrit.ovirt.org/42908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rwlock: Add simpler RWLock
gerrit-hooks has posted comments on this change. Change subject: rwlock: Add simpler RWLock .. Patch Set 25: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42908 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2466c137c89598772fb46347eb02195916883cac Gerrit-PatchSet: 25 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Dima Kuznetsov Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add readers contention rwlock test
gerrit-hooks has posted comments on this change. Change subject: tests: Add readers contention rwlock test .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/51923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdaf5096d0898d97db6234538233dfa01217f9ed Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: rwlock: Replace misc.RWLock
gerrit-hooks has posted comments on this change. Change subject: rwlock: Replace misc.RWLock .. Patch Set 21: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/43423 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9ae6064e8e031339303e64606a70673807c4083a Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Warn about callers of fileUtils.createdir()
Adam Litke has posted comments on this change. Change subject: fileUtils: Warn about callers of fileUtils.createdir() .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/37003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c3e7e21367eb690d0c7a6c6f79c515b18a9fff0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network tests: remove bonds after use
Edward Haas has posted comments on this change. Change subject: network tests: remove bonds after use .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1dc00ce35acf57726725956c5d2f83e20b2122c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...
Edward Haas has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 12: (4 comments) https://gerrit.ovirt.org/#/c/54555/12/lib/vdsm/network/configurators/__init__.py File lib/vdsm/network/configurators/__init__.py: PS12, Line 214: ipv6_supported We seem to need this only when enable=False. When the want to enable IPv6 and there is no support for it, we better explode. If we want to disable IPv6, it makes sense, but why ask to disable something that does not exist... isn't it the caller responsibility? PS12, Line 227: logging.warning Do we really need it? Won't we explode if something unexpected will happen? The test will surely fail. We did expect this to happen even with no relation to the waiting part, right? BTW: In what scenario we found it to be missing before? https://gerrit.ovirt.org/#/c/54555/12/tests/functional/networkTests.py File tests/functional/networkTests.py: PS12, Line 1888: @cleanupNet Just checking with you: If the test fail, do we see the correct backtrace? Usually @cleanupNet is ran on the test method and not the helper... If it works as expected then it looks good to me. PS12, Line 1889: _test_static_ip_configuration Thanks, now I understand what is actually tested. Are you sure this helper function is not ran by the test runner directly? Asking because it has the string 'test' in it. -- To view, visit https://gerrit.ovirt.org/54555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add readers contention rwlock test
Nir Soffer has posted comments on this change. Change subject: tests: Add readers contention rwlock test .. Patch Set 3: Ping? -- To view, visit https://gerrit.ovirt.org/51923 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibdaf5096d0898d97db6234538233dfa01217f9ed Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: pool: Remove refreshStoragePool verb
Nir Soffer has posted comments on this change. Change subject: pool: Remove refreshStoragePool verb .. Patch Set 5: Maor, Liron, please ack. -- To view, visit https://gerrit.ovirt.org/54901 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If63f5749121d481aa41e6be0b27711d431668265 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List
Nir Soffer has submitted this change and it was merged. Change subject: storage: Remove legacy get[Iso|Floppy]List .. storage: Remove legacy get[Iso|Floppy]List The legacy getIsoList and getFloppyList verbs are only used in DCs of compatibility version 3.3 (or older), while newer DCs use the getFileStats verb. Since these old DC levels are no longer supported by VDSM, these verbs can safely be removed. Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23 Signed-off-by: Allon Mureinik Reviewed-on: https://gerrit.ovirt.org/54900 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer --- M client/vdsClient.py M lib/api/vdsmapi-schema.json M lib/vdsm/rpc/Bridge.py M lib/vdsm/rpc/bindingxmlrpc.py M lib/vdsm/storage/exception.py M vdsm/API.py M vdsm/storage/hsm.py 7 files changed, 2 insertions(+), 132 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/54900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storage: Remove legacy get[Iso|Floppy]List
gerrit-hooks has posted comments on this change. Change subject: storage: Remove legacy get[Iso|Floppy]List .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54900 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6c9d563654a0a43994bc9e50ebff382726adb23 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Allon Mureinik Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Simone Tiraboschi Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Warn about callers of fileUtils.createdir()
Nir Soffer has posted comments on this change. Change subject: fileUtils: Warn about callers of fileUtils.createdir() .. Patch Set 6: Verified+1 -- To view, visit https://gerrit.ovirt.org/37003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c3e7e21367eb690d0c7a6c6f79c515b18a9fff0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Warn about callers of fileUtils.createdir()
gerrit-hooks has posted comments on this change. Change subject: fileUtils: Warn about callers of fileUtils.createdir() .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/37003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c3e7e21367eb690d0c7a6c6f79c515b18a9fff0 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Convert unhelpful warnings to debug messages
Nir Soffer has submitted this change and it was merged. Change subject: fileUtils: Convert unhelpful warnings to debug messages .. fileUtils: Convert unhelpful warnings to debug messages When a directory exists, fileUtils.createdir() logs a warning, although it has no context to tell if the existing directory is expected in the normal flow, or an unexpected error condition. This warning causes users to worry about non-existing issues and feel less confident about the product. It also makes developer life harder, since searching for warnings results in many unrelated messages. This patch changes the warning to debug message, which may be helpful for debugging. Code that wants to warn about existing directories should not call fileUtils.createdir() but the underlying os.makedirs() and handle the EEXIST error. Change-Id: I7800b860eb81334b63abefcca9a21a552331458f Bug-Url: https://bugzilla.redhat.com/1129587 Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/36764 Reviewed-by: Allon Mureinik Reviewed-by: Freddy Rolland Reviewed-by: Adam Litke Continuous-Integration: Jenkins CI --- M vdsm/storage/fileUtils.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Nir Soffer: Verified Adam Litke: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/36764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7800b860eb81334b63abefcca9a21a552331458f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Convert unhelpful warnings to debug messages
gerrit-hooks has posted comments on this change. Change subject: fileUtils: Convert unhelpful warnings to debug messages .. Patch Set 10: * update_tracker: OK * Set MODIFIED::bug 1129587#1129587IGNORE, not oVirt classification but -- To view, visit https://gerrit.ovirt.org/36764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7800b860eb81334b63abefcca9a21a552331458f Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Warn about callers of fileUtils.createdir()
Nir Soffer has posted comments on this change. Change subject: fileUtils: Warn about callers of fileUtils.createdir() .. Patch Set 5: Here is a log when warnings are enabled: Note that we get a warning for the code calling this function - this code should be inspected and probably fixed not to create unneeded directories. # xzgrep 'UserWarning: Using existing direcotory:' /var/log/vdsm/vdsm.log.1.xz MainThread::WARNING::2016-03-22 20:19:04,667::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/hsm.py:344: UserWarning: Using existing direcotory: /rhev/data-center/mnt jsonrpc.Executor/4::WARNING::2016-03-22 20:19:42,160::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/sp.py:1267: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/dom_md jsonrpc.Executor/4::WARNING::2016-03-22 20:19:42,160::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/sp.py:1268: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/images jsonrpc.Executor/4::WARNING::2016-03-22 20:19:42,172::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:691: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/images jsonrpc.Executor/4::WARNING::2016-03-22 20:19:42,172::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:695: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/dom_md Thread-45::WARNING::2016-03-22 20:19:42,208::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:691: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/images Thread-45::WARNING::2016-03-22 20:19:42,208::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:695: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/dom_md Thread-61::WARNING::2016-03-22 20:19:42,756::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:691: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/images Thread-61::WARNING::2016-03-22 20:19:42,757::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:695: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/dom_md jsonrpc.Executor/1::WARNING::2016-03-22 20:19:49,638::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/sp.py:1237: UserWarning: Using existing direcotory: /rhev/data-center/591475db-6fa9-455d-9c05-7f6e30fb06d5 jsonrpc.Executor/1::WARNING::2016-03-22 20:19:50,316::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/sp.py:1267: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/dom_md jsonrpc.Executor/1::WARNING::2016-03-22 20:19:50,316::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/sp.py:1268: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/images jsonrpc.Executor/1::WARNING::2016-03-22 20:19:50,321::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:691: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/images jsonrpc.Executor/1::WARNING::2016-03-22 20:19:50,322::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:695: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/dom_md 8a693e96-0e89-4a5d-a3b2-093e18988e43::WARNING::2016-03-22 20:20:03,444::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:691: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/images 8a693e96-0e89-4a5d-a3b2-093e18988e43::WARNING::2016-03-22 20:20:03,444::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:695: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/dom_md 8a693e96-0e89-4a5d-a3b2-093e18988e43::WARNING::2016-03-22 20:20:04,224::fileUtils::157::py.warnings::(createdir) /usr/share/vdsm/storage/blockSD.py:1215: UserWarning: Using existing direcotory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/master -- To view, visit https://gerrit.ovirt.org/37003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c3e7e21367eb690d0c7a6c6f79c515b18a9fff0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-
Change in vdsm[master]: commit-template: Refine the example text
Nir Soffer has posted comments on this change. Change subject: commit-template: Refine the example text .. Patch Set 1: Verified+1 Verified visually and using vim spell checker. Hopefully Adam and Allon can suggest improvments. -- To view, visit https://gerrit.ovirt.org/55105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16f0e6981447c7f467d4a22fb59b1ba7d736a389 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: commit-template: Refine the example text
Nir Soffer has uploaded a new change for review. Change subject: commit-template: Refine the example text .. commit-template: Refine the example text Improve the long description, making the template closer to how a commit message should look like. Change-Id: I16f0e6981447c7f467d4a22fb59b1ba7d736a389 Signed-off-by: Nir Soffer --- M commit-template.txt 1 file changed, 9 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/05/55105/1 diff --git a/commit-template.txt b/commit-template.txt index 8395df4..7e5858e 100644 --- a/commit-template.txt +++ b/commit-template.txt @@ -1,7 +1,13 @@ -: short summary under 50 chars +topic: Short summary under 50 chars (if possible) -Longer description using lines' length under 72 chars. +The topic should be module name, subsystem name, or feature name, +helping to understand what is this patch about. -With multiple paragraphs if necessary. +The rest of the commit message should include a longer description, +explaining why this patch is needed, why it is implemented in the +specific way, and the nature of the change. + +The description should use line length of 72 chars and multiple +paragraphs if neccesary. Bug-Url: https://bugzilla.redhat.com/?? -- To view, visit https://gerrit.ovirt.org/55105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I16f0e6981447c7f467d4a22fb59b1ba7d736a389 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: commit-template: Refine the example text
gerrit-hooks has posted comments on this change. Change subject: commit-template: Refine the example text .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55105 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16f0e6981447c7f467d4a22fb59b1ba7d736a389 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Make vdsm arch specific package
Nir Soffer has posted comments on this change. Change subject: spec: Make vdsm arch specific package .. Patch Set 2: This fails make rpm with this error: 18:51:17 Processing files: vdsm-debuginfo-4.17.999-811.git45b4f7b.fc23.x86_64 18:51:17 error: Empty %files file /home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/rpmbuild/BUILD/vdsm-4.17.999/debugfiles.list 18:51:17 18:51:17 18:51:17 RPM build errors: 18:51:17 Empty %files file /home/jenkins/workspace/vdsm_master_check-patch-fc23-x86_64/vdsm/rpmbuild/BUILD/vdsm-4.17.999/debugfiles.list 18:51:17 Makefile:1031: recipe for target 'rpm' failed Hopefully someone have a clue about this :-) -- To view, visit https://gerrit.ovirt.org/42490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecbc71ccded31e8b80b14dbb03fd738694ceb37c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs [1]
Edward Haas has posted comments on this change. Change subject: net: native ovs [1] .. Patch Set 22: (1 comment) https://gerrit.ovirt.org/#/c/54890/22/lib/vdsm/netinfo/ovs.py File lib/vdsm/netinfo/ovs.py: better place it under ovs: network.ovs.netinfo Line 1: # Line 2: # Copyright 2016 Hat, Inc. Line 3: # Line 4: # This program is free software; you can redistribute it and/or modify -- To view, visit https://gerrit.ovirt.org/54890 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaaf958554c0f71cfe652869bd75eb17aea5ca676 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: set correct permissions for hwrng device
Nir Soffer has posted comments on this change. Change subject: virt: set correct permissions for hwrng device .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/54806/4/vdsm/virt/vmdevices/core.py File vdsm/virt/vmdevices/core.py: Line 392: Line 393: def uses_source(self, source): Line 394: return self._SOURCES[self.specParams['source']] == source Line 395: Line 396: def set_endpoint_permissions(self): > I don't have hard feelings either (slightly like the simpler naming, but Ma How "endpoint" is related to sysfs entry? This is not about hate, but about names that are consistent with the rest of the project, and help to understand the code. If we use to call sysfs entries endpoints, this is a good name. If we don't use this term in vdsm, lets not add the only usage here. Line 397: supervdsm.getProxy().appropriateHwrngDevice(self.conf['vmId']) Line 398: Line 399: def unset_endpoint_permissions(self): Line 400: supervdsm.getProxy().rmAppropriateHwrngDevice(self.conf['vmId']) -- To view, visit https://gerrit.ovirt.org/54806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id958a291e5a15813309928ba3d8c67828273b6c6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Move vdsm package contents to vdsm-deamon
Jenkins CI has posted comments on this change. Change subject: spec: Move vdsm package contents to vdsm-deamon .. Patch Set 3: Continuous-Integration-1 Propagate review hook: Continuous Integration value inherited from patch 2 -- To view, visit https://gerrit.ovirt.org/42491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58b0b0e7461f9ac10a189dd8ca6715d02183ad21 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nelly Credi Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Run unit tests using travis-ci and docker
Nir Soffer has posted comments on this change. Change subject: tests: Run unit tests using travis-ci and docker .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/54856/5/contrib/Dockerfile File contrib/Dockerfile: Line 9: Line 10: CMD mkdir workspace && \ Line 11: cd workspace && \ Line 12: git clone http://gerrit.ovirt.org/p/vdsm.git && cd vdsm && \ Line 13: ./autogen.sh --system; make; make check-unit > It's a reference point... I run things on my branch and want to compare to I don't think it is useful to the project. -- To view, visit https://gerrit.ovirt.org/54856 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia6cd647acb4c740f890e9b602783915439317880 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Caro Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: cache: allow root-requiring changes in get()
Edward Haas has posted comments on this change. Change subject: netinfo: cache: allow root-requiring changes in get() .. Patch Set 2: Code-Review-1 I imagined it a bit different, let me know what you think: From getCapabilities(), after the regular caps.get(), call supervdsm.getProxy().supercaps_network() and complement the needed. supercaps_network() will build/use ovs_netinfo. This way, testing will be simple and we will not have calls between non-root to root from inside the modules. The other option, is to be consistent and use supervdsm for all network caps, but that will increase root usage which is bad. Dan is against it. -- To view, visit https://gerrit.ovirt.org/55073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84c6e8aa5a3820638a26aab6d112f0285b1fbd8c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Add create_block_volume
gerrit-hooks has posted comments on this change. Change subject: storagetests: Add create_block_volume .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4e1aafd87c4fee5b3f47a63ca7b055009cd006b8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Rename make_blocksd
gerrit-hooks has posted comments on this change. Change subject: storagetests: Rename make_blocksd .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Add create_block_volume
Nir Soffer has submitted this change and it was merged. Change subject: storagetests: Add create_block_volume .. storagetests: Add create_block_volume Add a utility function to create a fake block volume. We must make sure the LV is present in our FakeLVM instance with the proper lvtags. Volume metadata is allocated from the fake domain's metadata area. We must also create the directory for the image. Change-Id: I4e1aafd87c4fee5b3f47a63ca7b055009cd006b8 Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/54570 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-by: Freddy Rolland --- M tests/storagetestlib.py 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, approved Adam Litke: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54570 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4e1aafd87c4fee5b3f47a63ca7b055009cd006b8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Create metadata storage area for block domains
gerrit-hooks has posted comments on this change. Change subject: storagetests: Create metadata storage area for block domains .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie6e5306241fe730148d780e328afd8612cf8b8a3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Create metadata storage area for block domains
Nir Soffer has submitted this change and it was merged. Change subject: storagetests: Create metadata storage area for block domains .. storagetests: Create metadata storage area for block domains In order for our fake block storage domains to function with more real code we need to create the "backing storage" for the metadata LV. As written today, the code does not care if this is a file instead of a block device. Change-Id: Ie6e5306241fe730148d780e328afd8612cf8b8a3 Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/54568 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-by: Freddy Rolland --- M tests/storagefakelib.py M tests/storagetestlib.py 2 files changed, 3 insertions(+), 1 deletion(-) Approvals: Nir Soffer: Looks good to me, approved Adam Litke: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54568 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie6e5306241fe730148d780e328afd8612cf8b8a3 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: storagetests: Rename make_blocksd
Nir Soffer has submitted this change and it was merged. Change subject: storagetests: Rename make_blocksd .. storagetests: Rename make_blocksd Over time make_blocksd has evolved to work more like make_filesd_manifest. Now that it performs the same functionality as its file counterpart we should make the names similar as well. Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/54569 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-by: Freddy Rolland --- M tests/storagetestlib.py 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Adam Litke: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54569 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia740637551ae90519da029baf4e609bc97229a67 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add test_overwrite_blocksize test
gerrit-hooks has posted comments on this change. Change subject: tests: Add test_overwrite_blocksize test .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54669 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85fc8ad393aff49154d9d414bd6474a723b315f1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Add test_overwrite_blocksize test
Nir Soffer has submitted this change and it was merged. Change subject: tests: Add test_overwrite_blocksize test .. tests: Add test_overwrite_blocksize test The BlockStorageDomainManifest has special behavior with respect to its logBlkSize and phyBlkSize properties. These are set at object construction time from the passed metadata but are not updated when replaceMetadata is called (even if the new metadata specifies new sizes). This test verifies that values are not overridden by replaceMetadata but that non-default values can be provided during object construction. Change-Id: I85fc8ad393aff49154d9d414bd6474a723b315f1 Signed-off-by: Adam Litke Reviewed-on: https://gerrit.ovirt.org/54669 Continuous-Integration: Jenkins CI Reviewed-by: Nir Soffer Reviewed-by: Freddy Rolland --- M tests/domain_manifest_test.py 1 file changed, 16 insertions(+), 8 deletions(-) Approvals: Nir Soffer: Looks good to me, approved Adam Litke: Verified Jenkins CI: Passed CI tests Freddy Rolland: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/54669 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85fc8ad393aff49154d9d414bd6474a723b315f1 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Idan Shaby Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Vered Volansky Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Move vdsm package contents to vdsm-deamon
gerrit-hooks has posted comments on this change. Change subject: spec: Move vdsm package contents to vdsm-deamon .. Patch Set 3: * #1320281::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1320281::OK, public bug * Check Product::#1320281::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58b0b0e7461f9ac10a189dd8ca6715d02183ad21 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nelly Credi Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Do not require ceph-common on ppc64le
gerrit-hooks has posted comments on this change. Change subject: ceph: Do not require ceph-common on ppc64le .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sagi Shnaidman Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Do not require ceph-common on ppc64le
gerrit-hooks has posted comments on this change. Change subject: ceph: Do not require ceph-common on ppc64le .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42471 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76aa1267193ac4a7d6c7b8243dd6452341167f3c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Daniel Erez Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Sagi Shnaidman Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Move vdsm package contents to vdsm-deamon
gerrit-hooks has posted comments on this change. Change subject: spec: Move vdsm package contents to vdsm-deamon .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42491 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58b0b0e7461f9ac10a189dd8ca6715d02183ad21 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nelly Credi Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Make vdsm arch specific package
gerrit-hooks has posted comments on this change. Change subject: spec: Make vdsm arch specific package .. Patch Set 2: * #1320281::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1320281::OK, public bug * Check Product::#1320281::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/42490 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecbc71ccded31e8b80b14dbb03fd738694ceb37c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eyal Edri Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Convert unhelpful warnings to debug messages
Nir Soffer has posted comments on this change. Change subject: fileUtils: Convert unhelpful warnings to debug messages .. Patch Set 9: Here is vdsm startup log with the new debug message: # grep 'Using existing directory:' /var/log/vdsm/vdsm.log MainThread::DEBUG::2016-03-22 20:05:33,823::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt jsonrpc.Executor/7::DEBUG::2016-03-22 20:06:27,704::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/dom_md jsonrpc.Executor/7::DEBUG::2016-03-22 20:06:27,705::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/images jsonrpc.Executor/7::DEBUG::2016-03-22 20:06:27,716::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/images jsonrpc.Executor/7::DEBUG::2016-03-22 20:06:27,717::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/dom_md Thread-46::DEBUG::2016-03-22 20:06:27,747::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/images Thread-46::DEBUG::2016-03-22 20:06:27,747::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/dom_md Thread-62::DEBUG::2016-03-22 20:06:28,189::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/images Thread-62::DEBUG::2016-03-22 20:06:28,189::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/dom_md jsonrpc.Executor/5::DEBUG::2016-03-22 20:06:39,634::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/591475db-6fa9-455d-9c05-7f6e30fb06d5 jsonrpc.Executor/5::DEBUG::2016-03-22 20:06:40,314::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/dom_md jsonrpc.Executor/5::DEBUG::2016-03-22 20:06:40,314::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6c77adb1-74fc-4fa9-a0ac-3b5a4b789318/images jsonrpc.Executor/5::DEBUG::2016-03-22 20:06:40,320::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/images jsonrpc.Executor/5::DEBUG::2016-03-22 20:06:40,320::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/dom_md d1125338-9cbd-4656-8f6f-6ed675b05505::DEBUG::2016-03-22 20:06:48,495::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/images d1125338-9cbd-4656-8f6f-6ed675b05505::DEBUG::2016-03-22 20:06:48,495::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/dom_md d1125338-9cbd-4656-8f6f-6ed675b05505::DEBUG::2016-03-22 20:06:49,238::fileUtils::156::Storage.fileUtils::(createdir) Using existing directory: /rhev/data-center/mnt/blockSD/6acaac02-7e7d-4321-8ba2-70e07d96581d/master -- To view, visit https://gerrit.ovirt.org/36764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7800b860eb81334b63abefcca9a21a552331458f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Convert unhelpful warnings to debug messages
Nir Soffer has posted comments on this change. Change subject: fileUtils: Convert unhelpful warnings to debug messages .. Patch Set 9: Verified+1 -- To view, visit https://gerrit.ovirt.org/36764 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7800b860eb81334b63abefcca9a21a552331458f Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Liron Aravot Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Tal Nisan Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fileUtils: Warn about callers of fileUtils.createdir()
Nir Soffer has posted comments on this change. Change subject: fileUtils: Warn about callers of fileUtils.createdir() .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/37003 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c3e7e21367eb690d0c7a6c6f79c515b18a9fff0 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Ala Hino Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: cache: get() refactoring
Petr Horáček has posted comments on this change. Change subject: netinfo: cache: get() refactoring .. Patch Set 1: Take a look at https://gerrit.ovirt.org/#/c/54890/22/lib/vdsm/netinfo/cache.py -- To view, visit https://gerrit.ovirt.org/55079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic250262de9ab6ca274615432bfe230d2ed3ba3aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: common handling of exceptions
Nir Soffer has posted comments on this change. Change subject: virt: common handling of exceptions .. Patch Set 12: Code-Review-1 Francesco, can you check my comments on version 9? https://gerrit.ovirt.org/#/c/54664/9/tests/virt_api_test.py -- To view, visit https://gerrit.ovirt.org/54664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: cache: get() refactoring
Edward Haas has posted comments on this change. Change subject: netinfo: cache: get() refactoring .. Patch Set 1: Code-Review+1 Not sure why it was needed but I'm ok with the change. -- To view, visit https://gerrit.ovirt.org/55079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic250262de9ab6ca274615432bfe230d2ed3ba3aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: suppress
Edward Haas has posted comments on this change. Change subject: utils: suppress .. Patch Set 2: Code-Review+1 Note that vdsm/utils.py is a common cross vertical module, other maintainers may need to review it. You may need tp split the suppress addition from its usage, not sure what is expected in such cases. -- To view, visit https://gerrit.ovirt.org/55065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76d5b0658435e59701ac4d845827e86026085c07 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ovs: hook: fake bridgeless networks
Edward Haas has posted comments on this change. Change subject: ovs: hook: fake bridgeless networks .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/55066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8d076a1181adc6910be13a1f7560018d3eeaa07 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: shell_helper: ignore iproute2's @master notation to obtain d...
gerrit-hooks has posted comments on this change. Change subject: shell_helper: ignore iproute2's @master notation to obtain device names .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/47266 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idc8e950e02e5102f33afcb3b12493efadc2c66c1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: cache: get() refactoring
Petr Horáček has uploaded a new change for review. Change subject: netinfo: cache: get() refactoring .. netinfo: cache: get() refactoring Make get() more readable and ready for another compatibility changes. Change-Id: Ic250262de9ab6ca274615432bfe230d2ed3ba3aa Signed-off-by: Petr Horáček --- M lib/vdsm/netinfo/cache.py 1 file changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/79/55079/1 diff --git a/lib/vdsm/netinfo/cache.py b/lib/vdsm/netinfo/cache.py index df53808..ad6fa22 100644 --- a/lib/vdsm/netinfo/cache.py +++ b/lib/vdsm/netinfo/cache.py @@ -95,13 +95,12 @@ def get(vdsmnets=None, compatibility=None): -if compatibility is None: -return _get(vdsmnets) -elif compatibility < 30700: +_netinfo = _get(vdsmnets) +if compatibility < 30700: # REQUIRED_FOR engine < 3.7 -return _stringify_mtus(_get(vdsmnets)) +_netinfo = _stringify_mtus(_netinfo) -return _get(vdsmnets) +return _netinfo def _stringify_mtus(netinfo_data): -- To view, visit https://gerrit.ovirt.org/55079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic250262de9ab6ca274615432bfe230d2ed3ba3aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs [1]
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [1] .. Patch Set 22: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54890 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaaf958554c0f71cfe652869bd75eb17aea5ca676 Gerrit-PatchSet: 22 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: cache: allow root-requiring changes in get()
gerrit-hooks has posted comments on this change. Change subject: netinfo: cache: allow root-requiring changes in get() .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84c6e8aa5a3820638a26aab6d112f0285b1fbd8c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: cache: get() refactoring
gerrit-hooks has posted comments on this change. Change subject: netinfo: cache: get() refactoring .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55079 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic250262de9ab6ca274615432bfe230d2ed3ba3aa Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add fcoe hook
Pavel Zhukov has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 11: Verified+1 -- To view, visit https://gerrit.ovirt.org/55029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Pavel Zhukov Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network tests: remove bonds after use
gerrit-hooks has posted comments on this change. Change subject: network tests: remove bonds after use .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1dc00ce35acf57726725956c5d2f83e20b2122c Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...
gerrit-hooks has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 12: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network tests: remove bonds after use
gerrit-hooks has posted comments on this change. Change subject: network tests: remove bonds after use .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55078 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1dc00ce35acf57726725956c5d2f83e20b2122c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...
gerrit-hooks has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 11: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: network tests: remove bonds after use
Ondřej Svoboda has uploaded a new change for review.
Change subject: network tests: remove bonds after use
..
network tests: remove bonds after use
Change-Id: Ic1dc00ce35acf57726725956c5d2f83e20b2122c
Signed-off-by: Ondřej Svoboda
---
M tests/functional/networkTests.py
1 file changed, 10 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/55078/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 0d20c28..fa648c6 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -2847,6 +2847,16 @@
self.assertBondExists('bond0', nics1)
self.assertBondExists('bond1', nics0)
+# cleanup
+bondings = {
+'bond0': {'remove': True}
+'bond1': {'remove': True},
+}
+status, msg = self.setupNetworks({}, bondings, NOCHK)
+self.assertEqual(status, SUCCESS, msg)
+self.assertBondDoesntExist('bond0')
+self.assertBondDoesntExist('bond1')
+
@contextmanager
def setup_bonds_with_veth_pair(self, bond_options):
with veth_pair() as (n1, n2), veth_pair() as (n3, n4):
--
To view, visit https://gerrit.ovirt.org/55078
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic1dc00ce35acf57726725956c5d2f83e20b2122c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: common handling of exceptions
Piotr Kliczewski has posted comments on this change. Change subject: virt: common handling of exceptions .. Patch Set 12: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54664 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic186dc8fa062d8b3789c6057bba68fbbc23f311b Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Amit Aviram Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: expose hostdevReattach maintenance verb
Piotr Kliczewski has posted comments on this change.
Change subject: hostdev: expose hostdevReattach maintenance verb
..
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/54891/5/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:
Line 413: 'Host_getStorageDomains': {'ret': 'domlist'},
Line 414: 'Host_getStorageRepoStats': {'ret': Host_getStorageRepoStats_Ret},
Line 415: 'Host_hostdevListByCaps': {'ret': 'deviceList'},
Line 416: 'Host_hostdevChangeNumvfs': {},
Line 417: 'Host_hostdevReattach': {},
Empty dictionary has no value here. We can remove it.
Line 418: 'Host_startMonitoringDomain': {},
Line 419: 'Host_stopMonitoringDomain': {},
Line 420: 'Host_getVMList': {'call': Host_getVMList_Call, 'ret': 'vmList'},
Line 421: 'Host_getVMFullList': {'call': Host_getVMFullList_Call, 'ret':
'vmList'},
--
To view, visit https://gerrit.ovirt.org/54891
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebfb6a4e3854de8ea412417832a57fb896b78d1a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for hotunplug
Piotr Kliczewski has posted comments on this change. Change subject: hostdev: add support for hotunplug .. Patch Set 6: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/42747/6/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 7743: hostdevHotunplug Why do we need 2 times vmId? One is needed to construct VM object. Is the second vmId different form params parameter? Why not to reuse vmId passed during construction of VM object. -- To view, visit https://gerrit.ovirt.org/42747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If36f7da8f018615b76a1a8779ff15b890a823db8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for hotplug
Piotr Kliczewski has posted comments on this change. Change subject: hostdev: add support for hotplug .. Patch Set 12: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/42661/12/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 7697: hostdevHotplugParams We start types with capital letter so please follow the convention. Line 7711: hostdevHotplug Why do we need 2 times vmId? One is needed to construct VM object. Is the second vmId different form params parameter? Why not to reuse vmId passed during construction of VM object. https://gerrit.ovirt.org/#/c/42661/12/lib/vdsm/rpc/bindingxmlrpc.py File lib/vdsm/rpc/bindingxmlrpc.py: Line 465: params['vmId'] Here we see that we do not need two vmIds. -- To view, visit https://gerrit.ovirt.org/42661 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2465360664ef9b659c52dc610a95d2c2f1555c54 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hostdev: add support for hotunplug
Piotr Kliczewski has posted comments on this change. Change subject: hostdev: add support for hotunplug .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/42747/6/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 7729: hostdevHotunplugParams We have convention to start types with capital letter. -- To view, visit https://gerrit.ovirt.org/42747 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If36f7da8f018615b76a1a8779ff15b890a823db8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Ido Barkan Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Jenkins CI RO Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: vdsm requires vdsm-cli
gerrit-hooks has posted comments on this change. Change subject: spec: vdsm requires vdsm-cli .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6efd5cd9b0decc168cbc3fd08d5914ee1ec92ff5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: vdsm requires vdsm-cli
Dan Kenigsberg has submitted this change and it was merged. Change subject: spec: vdsm requires vdsm-cli .. spec: vdsm requires vdsm-cli vdsm is packaging the sos plugin, which in turn relies on vdsm-cli. Thus vdsm-cli should be a dependency of vdsm. Change-Id: I6efd5cd9b0decc168cbc3fd08d5914ee1ec92ff5 Signed-off-by: Fabian Deutsch Reviewed-on: https://gerrit.ovirt.org/54354 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg Reviewed-by: Yaniv Bronhaim Tested-by: Fabian Deutsch --- M vdsm.spec.in 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Fabian Deutsch: Verified Yaniv Bronhaim: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/54354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6efd5cd9b0decc168cbc3fd08d5914ee1ec92ff5 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: IP address hosttail split tool
Dan Kenigsberg has submitted this change and it was merged. Change subject: net: IP address hosttail split tool .. net: IP address hosttail split tool vdsm.common.network.address.hostail_split is provided to decode hostport and nfs mount path. Both use the following structure: host:tail, where 'tail' is either a port or a path. Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/54312 Continuous-Integration: Jenkins CI Reviewed-by: Freddy Rolland Reviewed-by: Francesco Romani Reviewed-by: Piotr Kliczewski Reviewed-by: Dan Kenigsberg --- M configure.ac M lib/vdsm/Makefile.am A lib/vdsm/common/Makefile.am A lib/vdsm/common/__init__.py A lib/vdsm/common/network/Makefile.am A lib/vdsm/common/network/__init__.py A lib/vdsm/common/network/address.py M tests/Makefile.am A tests/common/Makefile.am A tests/common/__init__.py A tests/common/network_test.py M vdsm.spec.in 12 files changed, 265 insertions(+), 1 deletion(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Looks good to me, but someone else must approve Freddy Rolland: Looks good to me, but someone else must approve Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/54312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: IP address hosttail split tool
gerrit-hooks has posted comments on this change. Change subject: net: IP address hosttail split tool .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/54312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: IP address hosttail split tool
Dan Kenigsberg has posted comments on this change. Change subject: net: IP address hosttail split tool .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/54312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vm: events: don't abort creation if event fails
Piotr Kliczewski has posted comments on this change. Change subject: vm: events: don't abort creation if event fails .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/54933/3/vdsm/virt/vm.py File vdsm/virt/vm.py: Line 345: Exception I understand that if connection is not there we fail to send. What is the error that we are getting here? We should be more specific what kind of failure we ignore. Maybe we need better exception handling in communication layer. -- To view, visit https://gerrit.ovirt.org/54933 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1a06df003fce796519df26550910352120da17a8 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Add a dependency to vdsm on vdsm-cli
Fabian Deutsch has abandoned this change. Change subject: spec: Add a dependency to vdsm on vdsm-cli .. Abandoned -- To view, visit https://gerrit.ovirt.org/54006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I9cf60a74128802d577485b674764d2ad45fcf1ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: vdsm requires vdsm-cli
Fabian Deutsch has posted comments on this change. Change subject: spec: vdsm requires vdsm-cli .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/54354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6efd5cd9b0decc168cbc3fd08d5914ee1ec92ff5 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: spec: Add a dependency to vdsm on vdsm-cli
gerrit-hooks has posted comments on this change. Change subject: spec: Add a dependency to vdsm on vdsm-cli .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/54006 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cf60a74128802d577485b674764d2ad45fcf1ae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Fabian Deutsch Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: IP address hosttail split tool
Piotr Kliczewski has posted comments on this change. Change subject: net: IP address hosttail split tool .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/54312 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib246c78987f9707674a1966df91120d4189b41fc Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Freddy Rolland Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add fcoe hook
gerrit-hooks has posted comments on this change. Change subject: hooks: Add fcoe hook .. Patch Set 11: * #1239122::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1239122::OK, public bug * Check Product::#1239122::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55029 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Pavel Zhukov Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Pavel Zhukov Gerrit-Reviewer: Yaniv Kaul Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: set system name for threads
Francesco Romani has uploaded a new change for review.
Change subject: lib: set system name for threads
..
lib: set system name for threads
To make the troubleshooting easier, we want
to set meaningful system names for our threads, so
we can use system tools (top, ps) to learn what Vdsm is doing.
The problem is that the system thread name must be at most
15 ASCII character long, while python's thread name could be
any legal string
A good shortening algorithm failed to emerge, so we
just truncate the possibly long python name and we use the truncated
name for system thread name.
Change-Id: I165f5ce9c86dad407d956a3b07e247431f2eed41
Bug-Url: https://bugzilla.redhat.com/1141422
Signed-off-by: Francesco Romani
---
M lib/vdsm/concurrent.py
M lib/vdsm/executor.py
2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/74/55074/1
diff --git a/lib/vdsm/concurrent.py b/lib/vdsm/concurrent.py
index 71eb341..1f9f215 100644
--- a/lib/vdsm/concurrent.py
+++ b/lib/vdsm/concurrent.py
@@ -22,6 +22,7 @@
import threading
from collections import namedtuple
+from . import pthread
from . import utils
@@ -174,6 +175,8 @@
@utils.traceback(on=logger)
def run():
+if name is not None:
+pthread.setname(name[:15])
return func(*args, **kwargs)
thread = threading.Thread(target=run, name=name)
diff --git a/lib/vdsm/executor.py b/lib/vdsm/executor.py
index 9c9c218..37a9a9e 100644
--- a/lib/vdsm/executor.py
+++ b/lib/vdsm/executor.py
@@ -171,7 +171,6 @@
self._thread.join()
def _run(self):
-pthread.setname(self.name[:15])
self._log.debug('Worker started')
try:
while True:
--
To view, visit https://gerrit.ovirt.org/55074
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I165f5ce9c86dad407d956a3b07e247431f2eed41
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lib: set system name for threads
gerrit-hooks has posted comments on this change. Change subject: lib: set system name for threads .. Patch Set 1: * #1141422::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1141422::OK, public bug * Check Product::#1141422::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55074 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I165f5ce9c86dad407d956a3b07e247431f2eed41 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: hooks: Add fcoe hook
Pavel Zhukov has posted comments on this change.
Change subject: hooks: Add fcoe hook
..
Patch Set 10:
(3 comments)
https://gerrit.ovirt.org/#/c/55029/10/vdsm.spec.in
File vdsm.spec.in:
Line 622: VDSM hook used for applying IPv6 configuration through custom network
Line 623: properties
Line 624:
Line 625: %package hook-fcoe
Line 626: Summary:Hook for enable fcoe support
> for -> to
fixed
Line 627: BuildArch: noarch
Line 628: Requires: %{name} = %{version}-%{release}
Line 629: Requires: fcoe-utils
Line 630:
Line 625: %package hook-fcoe
Line 626: Summary:Hook for enable fcoe support
Line 627: BuildArch: noarch
Line 628: Requires: %{name} = %{version}-%{release}
Line 629: Requires: fcoe-utils
> What about lldpad?
fcoe-utils depends on it
Line 630:
Line 631: %description hook-fcoe
Line 632: %{summary}
Line 633:
Line 627: BuildArch: noarch
Line 628: Requires: %{name} = %{version}-%{release}
Line 629: Requires: fcoe-utils
Line 630:
Line 631: %description hook-fcoe
> thin description...
fixed
Line 632: %{summary}
Line 633:
Line 634: %if 0%{?with_gluster_mgmt}
Line 635: %package gluster
--
To view, visit https://gerrit.ovirt.org/55029
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iad2faed7205ca08801132df072b469dbe781318c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pavel Zhukov
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Pavel Zhukov
Gerrit-Reviewer: Yaniv Kaul
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: allow root-requiring changes in network capabilties
Petr Horáček has uploaded a new change for review.
Change subject: caps: allow root-requiring changes in network capabilties
..
caps: allow root-requiring changes in network capabilties
Since some OVS parameters are available only to root, we have to
introduce a mechanism to complement already gathered network
capabilties with root-only ones.
This will be done by introduced network/api.py:caps_network().
Change-Id: I84c6e8aa5a3820638a26aab6d112f0285b1fbd8c
Signed-off-by: Petr Horáček
---
M lib/vdsm/network/api.py
M vdsm/caps.py
M vdsm/supervdsm_api/network.py
3 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/55073/1
diff --git a/lib/vdsm/network/api.py b/lib/vdsm/network/api.py
index 74557fa..f43e77b 100644
--- a/lib/vdsm/network/api.py
+++ b/lib/vdsm/network/api.py
@@ -50,6 +50,11 @@
_SYSFS_SRIOV_NUMVFS = '/sys/bus/pci/devices/{}/sriov_numvfs'
+def caps_network(caps):
+"""Complement existing non-root capabilties"""
+return {}
+
+
def _wait_for_udev_events():
# FIXME: This is an ugly hack that is meant to prevent VDSM to report VFs
# that are not yet named by udev or not report all of. This is a blocking
diff --git a/vdsm/caps.py b/vdsm/caps.py
index 539deb3..8393609 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -39,6 +39,7 @@
from vdsm import numa
from vdsm import osinfo
from vdsm import host
+from vdsm import supervdsm
from vdsm import utils
import storage.hba
from virt import vmdevices
@@ -166,6 +167,7 @@
# TODO: Version requests by engine to ease handling of compatibility.
netinfo_data = netinfo_cache.get(compatibility=30600)
caps.update(netinfo_data)
+caps.update(supervdsm.getProxy().caps_network(caps))
try:
caps['hooks'] = hooks.installed()
diff --git a/vdsm/supervdsm_api/network.py b/vdsm/supervdsm_api/network.py
index 1718b75..e08535b 100644
--- a/vdsm/supervdsm_api/network.py
+++ b/vdsm/supervdsm_api/network.py
@@ -21,7 +21,8 @@
from . import expose
from vdsm.tool.restore_nets import restore
-from vdsm.network.api import setSafeNetworkConfig, setupNetworks, change_numvfs
+from vdsm.network.api import (setSafeNetworkConfig, setupNetworks,
+ change_numvfs, caps_network)
from vdsm.tc import setPortMirroring, unsetPortMirroring
@@ -32,6 +33,7 @@
expose(setSafeNetworkConfig)
expose(setupNetworks)
+expose(caps_network)
expose(change_numvfs)
expose(setPortMirroring)
expose(unsetPortMirroring)
--
To view, visit https://gerrit.ovirt.org/55073
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I84c6e8aa5a3820638a26aab6d112f0285b1fbd8c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: allow root-requiring changes in network capabilties
gerrit-hooks has posted comments on this change. Change subject: caps: allow root-requiring changes in network capabilties .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55073 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I84c6e8aa5a3820638a26aab6d112f0285b1fbd8c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: net: native ovs [1]
gerrit-hooks has posted comments on this change. Change subject: net: native ovs [1] .. Patch Set 21: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54890 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaaf958554c0f71cfe652869bd75eb17aea5ca676 Gerrit-PatchSet: 21 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...
gerrit-hooks has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 10: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/54555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ifcfg: re-enable IPv6 before device configuration, or disabl...
Ondřej Svoboda has posted comments on this change. Change subject: ifcfg: re-enable IPv6 before device configuration, or disable afterwards .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/54555/9/tests/functional/networkTests.py File tests/functional/networkTests.py: Line 1879: @permutations([[([4], [6])], Line 1880:[([6], [4])], Line 1881:[([4], [4, 6], [4])]]) Line 1882: @cleanupNet Line 1883: def testStaticNetworkConfig(self, ip_reconfigurations): > Aha, maybe I understand now. Do you suggest to extract the inner function a I mean, to extract the inside of the outer function. Line 1884: with dummyIf(1) as nics: Line 1885: nic, = nics Line 1886: IPv4 = dict(nic=nic, bootproto='none', ipaddr=IP_ADDRESS, Line 1887: netmask=IP_MASK, gateway=IP_GATEWAY) -- To view, visit https://gerrit.ovirt.org/54555 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idddfb096e6ea384dbe6655c5c4178d4884a8db85 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: utils: suppress
gerrit-hooks has posted comments on this change. Change subject: utils: suppress .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55065 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I76d5b0658435e59701ac4d845827e86026085c07 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: ovs: hook: fake bridgeless networks
gerrit-hooks has posted comments on this change. Change subject: ovs: hook: fake bridgeless networks .. Patch Set 1: Verified-1 * #1234867::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1234867::OK, public bug * Check Product::#1234867::OK, Correct classification oVirt * Check TM::#1234867::OK, correct target milestone ovirt-3.6.5 * Check merged to previous::WARN, Still open on branches master -- To view, visit https://gerrit.ovirt.org/55071 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8d076a1181adc6910be13a1f7560018d3eeaa07 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.6 Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.6]: ovs: hook: fake bridgeless networks
Petr Horáček has uploaded a new change for review.
Change subject: ovs: hook: fake bridgeless networks
..
ovs: hook: fake bridgeless networks
Engine expects Display networks to be bridgeless. We can't create
bridgeless networks in OVS, but we can create them bridged and then lie
about them to engine.
Change-Id: Ia8d076a1181adc6910be13a1f7560018d3eeaa07
Signed-off-by: Petr Horáček
Bug-Url: https://bugzilla.redhat.com/1234867
---
M vdsm_hooks/ovs/ovs_after_get_caps.py
M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
2 files changed, 16 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/55071/1
diff --git a/vdsm_hooks/ovs/ovs_after_get_caps.py
b/vdsm_hooks/ovs/ovs_after_get_caps.py
index bbb8735..f74c6e7 100755
--- a/vdsm_hooks/ovs/ovs_after_get_caps.py
+++ b/vdsm_hooks/ovs/ovs_after_get_caps.py
@@ -97,7 +97,9 @@
net_info = _get_net_info(attrs, interface, dhcpv4ifaces, dhcpv6ifaces,
routes)
net_info['iface'] = network
-net_info['bridged'] = True
+# if Engine expects network to be bridgeless (for Display network
+# purposes), report it as bridgeless
+net_info['bridged'] = attrs.get('bridged')
net_info['ports'] = _get_ports(network, attrs)
net_info['stp'] = _get_stp(interface)
ovs_networks_caps[network] = net_info
@@ -109,15 +111,19 @@
dhcpv4ifaces, dhcpv6ifaces = netinfo._get_dhclient_ifaces()
routes = netinfo._get_routes()
for network, attrs in iter_ovs_nets(running_config.networks):
-interface = network if 'vlan' in attrs else BRIDGE_NAME
-net_info = _get_net_info(attrs, interface, dhcpv4ifaces, dhcpv6ifaces,
- routes)
-net_info['bridged'] = True
-net_info['ports'] = _get_ports(network, attrs)
-# TODO netinfo._bridge_options does not work here
-net_info['opts'] = {}
-net_info['stp'] = _get_stp(interface)
-ovs_bridges_caps[network] = net_info
+bridged = attrs.get('bridged')
+# if Engine expects network to be bridgeless (for Display network
+# purposes), do not report its bridge
+if bridged:
+interface = network if 'vlan' in attrs else BRIDGE_NAME
+net_info = _get_net_info(attrs, interface, dhcpv4ifaces,
+ dhcpv6ifaces, routes)
+net_info['bridged'] = True
+net_info['ports'] = _get_ports(network, attrs)
+# TODO netinfo._bridge_options does not work here
+net_info['opts'] = {}
+net_info['stp'] = _get_stp(interface)
+ovs_bridges_caps[network] = net_info
return ovs_bridges_caps
diff --git a/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
b/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
index 5f38773..88e365e 100644
--- a/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
+++ b/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
@@ -162,11 +162,8 @@
nic = attrs.get('nic')
bonding = attrs.get('bonding')
vlan = attrs.get('vlan')
-bridged = attrs.get('bridged', True)
stp = attrs.get('stp', False)
-if not bridged:
-raise Exception('OVS does not support bridgeless networks')
if bonding in running_config.bonds:
if not is_ovs_bond(running_config.bonds[bonding]):
raise Exception('%s is not OVS bonding' % bonding)
--
To view, visit https://gerrit.ovirt.org/55071
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8d076a1181adc6910be13a1f7560018d3eeaa07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Petr Horáček
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ovs: hook: fake bridgeless networks
Petr Horáček has uploaded a new change for review.
Change subject: ovs: hook: fake bridgeless networks
..
ovs: hook: fake bridgeless networks
Engine expects Display networks to be bridgeless. We can't create
bridgeless networks in OVS, but we can create them bridged and then lie
about them to engine.
Change-Id: Ia8d076a1181adc6910be13a1f7560018d3eeaa07
Signed-off-by: Petr Horáček
---
M vdsm_hooks/ovs/ovs_after_get_caps.py
M vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
2 files changed, 15 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/66/55066/1
diff --git a/vdsm_hooks/ovs/ovs_after_get_caps.py
b/vdsm_hooks/ovs/ovs_after_get_caps.py
index b7172f3..b5c38db 100755
--- a/vdsm_hooks/ovs/ovs_after_get_caps.py
+++ b/vdsm_hooks/ovs/ovs_after_get_caps.py
@@ -96,7 +96,9 @@
interface = network if 'vlan' in attrs else BRIDGE_NAME
net_info = _get_net_info(interface, routes)
net_info['iface'] = network
-net_info['bridged'] = True
+# if Engine expects network to be bridgeless (for Display network
+# purposes), report it as bridgeless
+net_info['bridged'] = attrs.get('bridged')
net_info['ports'] = _get_ports(network, attrs)
net_info['stp'] = _get_stp(interface)
ovs_networks_caps[network] = net_info
@@ -107,14 +109,18 @@
ovs_bridges_caps = {}
routes = netinfo_routes.get_routes()
for network, attrs in iter_ovs_nets(running_config.networks):
-interface = network if 'vlan' in attrs else BRIDGE_NAME
-net_info = _get_net_info(interface, routes)
-net_info['bridged'] = True
-net_info['ports'] = _get_ports(network, attrs)
-# TODO netinfo._bridge_options does not work here
-net_info['opts'] = {}
-net_info['stp'] = _get_stp(interface)
-ovs_bridges_caps[network] = net_info
+bridged = attrs.get('bridged')
+# if Engine expects network to be bridgeless (for Display network
+# purposes), do not report its bridge
+if bridged:
+interface = network if 'vlan' in attrs else BRIDGE_NAME
+net_info = _get_net_info(interface, routes)
+net_info['bridged'] = bridged
+net_info['ports'] = _get_ports(network, attrs)
+# TODO netinfo._bridge_options does not work here
+net_info['opts'] = {}
+net_info['stp'] = _get_stp(interface)
+ovs_bridges_caps[network] = net_info
return ovs_bridges_caps
diff --git a/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
b/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
index 8b995f3..e5458af 100644
--- a/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
+++ b/vdsm_hooks/ovs/ovs_before_network_setup_ovs.py
@@ -186,11 +186,8 @@
nic = attrs.get('nic')
bonding = attrs.get('bonding')
vlan = attrs.get('vlan')
-bridged = attrs.get('bridged', True)
stp = attrs.get('stp', False)
-if not bridged:
-raise Exception('OVS does not support bridgeless networks')
if bonding in running_config.bonds:
if not is_ovs_bond(running_config.bonds[bonding]):
raise Exception('%s is not OVS bonding' % bonding)
--
To view, visit https://gerrit.ovirt.org/55066
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia8d076a1181adc6910be13a1f7560018d3eeaa07
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ovs: hook: fake bridgeless networks
gerrit-hooks has posted comments on this change. Change subject: ovs: hook: fake bridgeless networks .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/55066 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia8d076a1181adc6910be13a1f7560018d3eeaa07 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
