Change in vdsm[master]: Revert "NetworkManager: configure to monitor ifcfg/connectio...
Dan Kenigsberg has posted comments on this change. Change subject: Revert "NetworkManager: configure to monitor ifcfg/connection files" .. Patch Set 1: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/59260/1/vdsm.spec.in File vdsm.spec.in: Line 205: Requires: python >= 2.7.5-18.el7_1.1 Line 206: Requires: policycoreutils-python Line 207: Requires: selinux-policy-targeted >= 3.13.1-16.el7 Line 208: Requires: systemd >= 219-11.el7 Line 209: Requires: initscripts >= 9.49.31-1 initscripts-9.49.30-1.el7_2.3 Line 210: %else Line 211: Requires: fence-agents-all Line 212: Requires: kernel >= 4.1.6 Line 213: # Subprocess and thread bug was found on python 2.7.2 -- To view, visit https://gerrit.ovirt.org/59260 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392a918112c3a7b5bfee6fccb2a51b038d5a543f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: py3: Require libselinux-python3
Edward Haas has uploaded a new change for review. Change subject: py3: Require libselinux-python3 .. py3: Require libselinux-python3 Change-Id: Ieea613d78b30eebb7b1f3786e7169e70aa1e9e03 Signed-off-by: Edward Haas --- M automation/check-merged.packages.fc23 M automation/check-patch.packages.fc23 M vdsm.spec.in 3 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/59425/1 diff --git a/automation/check-merged.packages.fc23 b/automation/check-merged.packages.fc23 index bf27e8a..fe315b9 100644 --- a/automation/check-merged.packages.fc23 +++ b/automation/check-merged.packages.fc23 @@ -4,6 +4,7 @@ lago lago-ovirt libguestfs-tools-c +libselinux-python3 libvirt-python3 m2crypto make diff --git a/automation/check-patch.packages.fc23 b/automation/check-patch.packages.fc23 index 1e45923..8490020 100644 --- a/automation/check-patch.packages.fc23 +++ b/automation/check-patch.packages.fc23 @@ -2,6 +2,7 @@ automake git libguestfs-tools-c +libselinux-python3 libvirt-python3 m2crypto make diff --git a/vdsm.spec.in b/vdsm.spec.in index bbaa9ec..bb82744 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -97,6 +97,7 @@ BuildRequires: python3-six BuildRequires: python3-netaddr BuildRequires: python3-yaml +BuildRequires: libselinux-python3 BuildRequires: libvirt-python3 %endif # rhel %endif # support python3 -- To view, visit https://gerrit.ovirt.org/59425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ieea613d78b30eebb7b1f3786e7169e70aa1e9e03 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: py3: Require libselinux-python3
gerrit-hooks has posted comments on this change. Change subject: py3: Require libselinux-python3 .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieea613d78b30eebb7b1f3786e7169e70aa1e9e03 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: py3: Require libselinux-python3
Irit Goihman has posted comments on this change. Change subject: py3: Require libselinux-python3 .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/59425/1//COMMIT_MSG Commit Message: PS1, Line 7: Require libselinux-python3 can you provide more details why this package is required? -- To view, visit https://gerrit.ovirt.org/59425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieea613d78b30eebb7b1f3786e7169e70aa1e9e03 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: don't count bond slave duplicates
gerrit-hooks has posted comments on this change. Change subject: ovs: don't count bond slave duplicates .. Patch Set 8: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I073b555799bd1f558078e993127f3dfbaad09204 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ovs: edit bond mode
gerrit-hooks has posted comments on this change. Change subject: ovs: edit bond mode .. Patch Set 11: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58437 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9009933445c8bf162b236a2f9081e796d5f9272f Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net tests: Support the ability to choose the tested switch
gerrit-hooks has posted comments on this change. Change subject: net tests: Support the ability to choose the tested switch .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e230633dfefcdc4a4b545eb2139ffe190c6f35 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: netswitch: split queries actions on netswitch level
gerrit-hooks has posted comments on this change. Change subject: netswitch: split queries actions on netswitch level .. Patch Set 12: * #1195208::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1195208::OK, public bug * Check Product::#1195208::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4164e09735dfbd6853b0ac296760895ee62c9449 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: py3: Require libselinux-python3
Edward Haas has posted comments on this change. Change subject: py3: Require libselinux-python3 .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/59425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieea613d78b30eebb7b1f3786e7169e70aa1e9e03 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: py3: Require libselinux-python3
gerrit-hooks has posted comments on this change. Change subject: py3: Require libselinux-python3 .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieea613d78b30eebb7b1f3786e7169e70aa1e9e03 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: py3: Require libselinux-python3
Irit Goihman has posted comments on this change. Change subject: py3: Require libselinux-python3 .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieea613d78b30eebb7b1f3786e7169e70aa1e9e03 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: netswitch: split queries actions on netswitch level
Edward Haas has posted comments on this change. Change subject: netswitch: split queries actions on netswitch level .. Patch Set 12: Verified+1 Partial: Unit Tests are passing. CI failed due to a missing py3 package (selinux). -- To view, visit https://gerrit.ovirt.org/58502 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4164e09735dfbd6853b0ac296760895ee62c9449 Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Petr Horáček Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: py3: Require libselinux-python3
Edward Haas has posted comments on this change. Change subject: py3: Require libselinux-python3 .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59425/1//COMMIT_MSG Commit Message: PS1, Line 7: Require libselinux-python3 > can you provide more details why this package is required? Done -- To view, visit https://gerrit.ovirt.org/59425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieea613d78b30eebb7b1f3786e7169e70aa1e9e03 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: adding support for version 4.1
Eli Mesika has posted comments on this change. Change subject: vdsm: adding support for version 4.1 .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59308/2/lib/vdsm/dsaversion.py.in File lib/vdsm/dsaversion.py.in: Line 39: 'clusterLevels': ['4.0', '4.1'], Line 40: } Line 41: Line 42: if cpuarch.real() == cpuarch.PPC64LE: Line 43: version_info['clusterLevels'] = ['4.0', '4.1'] > we don't really plan to stop the support in foreseeable future, so this can Not relevant to this patch IMO , might be done in a separate patch -- To view, visit https://gerrit.ovirt.org/59308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aaaf4d6ebf6c1e0fdcb37a158993a7b84c7f06d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: py3: Require libselinux-python3
Dan Kenigsberg has posted comments on this change. Change subject: py3: Require libselinux-python3 .. Patch Set 2: Code-Review+2 raising -- To view, visit https://gerrit.ovirt.org/59425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieea613d78b30eebb7b1f3786e7169e70aa1e9e03 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: py3: Require libselinux-python3
Dan Kenigsberg has submitted this change and it was merged. Change subject: py3: Require libselinux-python3 .. py3: Require libselinux-python3 The selinux package/module is not required in the spec and CI automation packages, therefore py3 unit tests are failing. Change-Id: Ieea613d78b30eebb7b1f3786e7169e70aa1e9e03 Signed-off-by: Edward Haas Reviewed-on: https://gerrit.ovirt.org/59425 Continuous-Integration: Jenkins CI Reviewed-by: Irit Goihman Reviewed-by: Dan Kenigsberg --- M automation/check-merged.packages.fc23 M automation/check-patch.packages.fc23 M vdsm.spec.in 3 files changed, 3 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Irit Goihman: Looks good to me, but someone else must approve Dan Kenigsberg: Looks good to me, approved Edward Haas: Verified -- To view, visit https://gerrit.ovirt.org/59425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieea613d78b30eebb7b1f3786e7169e70aa1e9e03 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: py3: Require libselinux-python3
gerrit-hooks has posted comments on this change. Change subject: py3: Require libselinux-python3 .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/59425 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieea613d78b30eebb7b1f3786e7169e70aa1e9e03 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: adding support for version 4.1
Nir Soffer has posted comments on this change. Change subject: vdsm: adding support for version 4.1 .. Patch Set 2: I asked Eli to update the minimal versions as well. If we are not sure yet about this maybe it is better split the change to add 4.1 support, and remove 3.x support. -- To view, visit https://gerrit.ovirt.org/59308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aaaf4d6ebf6c1e0fdcb37a158993a7b84c7f06d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: adding support for version 4.1
Nir Soffer has posted comments on this change. Change subject: vdsm: adding support for version 4.1 .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59308/2/lib/vdsm/dsaversion.py.in File lib/vdsm/dsaversion.py.in: Line 39: 'clusterLevels': ['4.0', '4.1'], Line 40: } Line 41: Line 42: if cpuarch.real() == cpuarch.PPC64LE: Line 43: version_info['clusterLevels'] = ['4.0', '4.1'] > Not relevant to this patch IMO , might be done in a separate patch This should be removed once ppc64le version is same as others. Lets split the removal of 3.x and special ppc64le part to another patch so we can merge quickly 4.1 addition. -- To view, visit https://gerrit.ovirt.org/59308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aaaf4d6ebf6c1e0fdcb37a158993a7b84c7f06d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net tests: Support the ability to choose the tested switch
gerrit-hooks has posted comments on this change. Change subject: net tests: Support the ability to choose the tested switch .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e230633dfefcdc4a4b545eb2139ffe190c6f35 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py
Eli Mesika has uploaded a new change for review.
Change subject: vdsm: adding handling for NGN in osinfo.py
..
vdsm: adding handling for NGN in osinfo.py
Current osinfo.py implementation lacks handling for NGN (New Generation
Node).
This patch adds another parameter in addition to the osname, release and
version named pretty_name, that is empty bu default and if
/etc/os-release file exists on the OS, will return the content of the
PRETTY_NAME value (if exists) from that file.
Change-Id: Ida119527b263302bf3f78e359bac12113718b744
Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1324447
Signed-off-by: emesika
---
M lib/api/vdsm-api.yml
M lib/vdsm/osinfo.py
2 files changed, 32 insertions(+), 9 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/59431/1
diff --git a/lib/api/vdsm-api.yml b/lib/api/vdsm-api.yml
index 475ccda..2814fc5 100644
--- a/lib/api/vdsm-api.yml
+++ b/lib/api/vdsm-api.yml
@@ -4650,6 +4650,10 @@
- description: The OS version (eg. 17 for Fedora 17)
name: version
type: string
+
+- description: The OS pretty name
+name: pretty_name
+type: string
type: object
WatchdogEventAction: &WatchdogEventAction
diff --git a/lib/vdsm/osinfo.py b/lib/vdsm/osinfo.py
index 8ad99a1..0910872 100644
--- a/lib/vdsm/osinfo.py
+++ b/lib/vdsm/osinfo.py
@@ -23,6 +23,7 @@
import glob
import linecache
import logging
+import shlex
import time
import os
@@ -106,18 +107,34 @@
return OSName.UNKNOWN
-def _parse_node_version(path):
+def _parse_release_file(path):
data = {}
-with open(path) as f:
-for line in f:
-try:
-key, value = [kv.strip() for kv in line.split('=', 1)]
-except ValueError:
-continue
+try:
+with open(path) as f:
+for line in shlex.split(f, comments=True):
+try:
+key, value = line.split('=', 1)
+except ValueError:
+continue
-data[key] = value
+data[key] = value
+except IOError:
+logging.exception('Fail to read release file')
+return data
+
+def _parse_node_version(path):
+data = _parse_release_file(path)
return data.get('VERSION', ''), data.get('RELEASE', '')
+
+
+def _get_pretty_name():
+pretty_name = ''
+if os.path.exists('/etc/os-release'):
+data = _parse_release_file('/etc/os-release')
+if data.get('PRETTY_NAME') is not None:
+pretty_name = data.get('PRETTY_NAME').strip('"')
+return pretty_name
@utils.memoized
@@ -131,6 +148,7 @@
version = release_name = ''
osname = _release_name()
+pretty_name = _get_pretty_name()
try:
if osname == OSName.RHEVH or osname == OSName.OVIRT:
version, release_name = _parse_node_version('/etc/default/version')
@@ -150,7 +168,8 @@
except:
logging.error('failed to find version/release', exc_info=True)
-return dict(release=release_name, version=version, name=osname)
+return dict(release=release_name, version=version,
+name=osname, pretty_name=pretty_name)
def selinux_status():
--
To view, visit https://gerrit.ovirt.org/59431
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ida119527b263302bf3f78e359bac12113718b744
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eli Mesika
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py
gerrit-hooks has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida119527b263302bf3f78e359bac12113718b744 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py
Eli Mesika has abandoned this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Abandoned Abandoned due to Dans comment , solution will have a different approach for NGN using the original osname, release and version and adding the PRETTY_NAME that will have the details about the NGN from the /etc/os-release file -- To view, visit https://gerrit.ovirt.org/57620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I17337643cd4e986c09b07137d80da3555161ee70 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py
gerrit-hooks has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 20: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/57620 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17337643cd4e986c09b07137d80da3555161ee70 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: Revert "NetworkManager: configure to monitor ifcfg/connectio...
Anonymous Coward #1001177 has posted comments on this change. Change subject: Revert "NetworkManager: configure to monitor ifcfg/connection files" .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.ovirt.org/59260 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392a918112c3a7b5bfee6fccb2a51b038d5a543f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Anonymous Coward #1001177 Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michael Burman Gerrit-Reviewer: Ondřej Svoboda Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm.conf: Add drop-in dir
Irit Goihman has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 13:
(22 comments)
https://gerrit.ovirt.org/#/c/58728/13/lib/vdsm/config.py.in
File lib/vdsm/config.py.in:
Line 25: import glob
Line 26:
Line 27:
Line 28: _SYSCONFDIR = '@sysconfdir@'
Line 29: _VDSMCONFDIR = 'vdsm/vdsm.conf.d/'
> This is not needed, the old version with a name argument was better, making
Done
Line 30: _DROPPIN_BASE = ("/usr/lib/", "/run/", _SYSCONFDIR)
Line 31:
Line 32: parameters = [
Line 33: # Section: [vars]
Line 26:
Line 27:
Line 28: _SYSCONFDIR = '@sysconfdir@'
Line 29: _VDSMCONFDIR = 'vdsm/vdsm.conf.d/'
Line 30: _DROPPIN_BASE = ("/usr/lib/", "/run/", _SYSCONFDIR)
> This is not one base, so it should be named _DROPIN_BASES
Done
Line 31:
Line 32: parameters = [
Line 33: # Section: [vars]
Line 34: ('vars', [
Line 506: print(twp.fill(comment))
Line 507: print(twp.fill("%s = %s" % (key, value)))
Line 508: print('')
Line 509:
Line 510:
> Modifying code in .in files is huge pain. Please move all the code this fil
for now we can't add imports in this file since config.py file is generated
during make install and all the imports fail. we need to add a change to
lib/vdsm/Makefile.am in a different patch and then make the change here.
Line 511: def load():
Line 512: cfg = configparser.ConfigParser()
Line 513: set_defaults(cfg)
Line 514: read_configs(cfg)
Line 507: print(twp.fill("%s = %s" % (key, value)))
Line 508: print('')
Line 509:
Line 510:
Line 511: def load():
> Better add name argument here
Done
Line 512: cfg = configparser.ConfigParser()
Line 513: set_defaults(cfg)
Line 514: read_configs(cfg)
Line 515: return cfg
Line 510:
Line 511: def load():
Line 512: cfg = configparser.ConfigParser()
Line 513: set_defaults(cfg)
Line 514: read_configs(cfg)
> And here:
Done
Line 515: return cfg
Line 516:
Line 517:
Line 518: def read_configs(cfg):
Line 514: read_configs(cfg)
Line 515: return cfg
Line 516:
Line 517:
Line 518: def read_configs(cfg):
> And here:
Done
Line 519: """This function is reading config files in a specific scheme
Line 520:
Line 521: The function reads - for one component - config files from several
Line 522: locations and in addition it is also reading configuration
snippets
Line 526: other packages which can then be put into the vendor drop-in dir,
Line 527: or users can overwrite the defaults, by placing a complete or
partial
Line 528: configuration file into /etc or a drop-in directory.
Line 529: """
Line 530: default_conf = os.path.join(_SYSCONFDIR, 'vdsm', 'vdsm.conf')
> Your suggestion would try to read: /etc/vdsm/vdsm.conf.d/vdsm.conf instead
Done
Line 531: cfg.read(default_conf)
Line 532:
Line 533: dropins = []
Line 534: for path in _DROPPIN_BASE:
Line 531: cfg.read(default_conf)
Line 532:
Line 533: dropins = []
Line 534: for path in _DROPPIN_BASE:
Line 535: pattern = os.path.join(path, _VDSMCONFDIR, '[0-9]*.conf')
> Do not assume any format of file names, we should read any conf file. Use:
I changed it back but don't we want to support only conf files that begin with
a number?
Line 536: dropins.extend(glob.glob(pattern))
Line 537:
Line 538: dropins.sort(key=os.path.basename)
Line 539: cfg.read(dropins)
https://gerrit.ovirt.org/#/c/58728/13/tests/config_test.py
File tests/config_test.py:
Line 24: from testlib import make_config, namedTemporaryDir, VdsmTestCase
Line 25: from vdsm import config
Line 26:
Line 27:
Line 28: ADMIN_PATH = 'etc/'
> We don't need these constants, they are used only in create_conf_dirs.
Done
Line 29: CONF_PATH = 'vdsm/vdsm.conf.d'
Line 30:
Line 31: RUNTIME_PATH = 'run/'
Line 32:
Line 25: from vdsm import config
Line 26:
Line 27:
Line 28: ADMIN_PATH = 'etc/'
Line 29: CONF_PATH = 'vdsm/vdsm.conf.d'
> We don't need this, use a helper to create dropin, it will be the only plac
Done
Line 30:
Line 31: RUNTIME_PATH = 'run/'
Line 32:
Line 33: VENDOR_PATH = 'usr/lib/'
Line 32:
Line 33: VENDOR_PATH = 'usr/lib/'
Line 34:
Line 35: SSL_TRUE = '[vars]\nssl = true\n'
Line 36: SSL_FALSE = '[vars]\nssl = false\n'
> We don't need these constants, you want to have specifc value for each drop
Done
Line 37:
Line 38:
Line 39: @contextmanager
Line 40: def create_conf_dirs():
Line 36: SSL_FALSE = '[vars]\nssl = false\n'
Line 37:
Line 38:
Line 39: @contextmanager
Line 40: def create_conf_dirs():
> Nice!
Done
Line 41: with namedTemporaryDir() as path:
Line 42: admin_path = os.path.join(path, ADMIN_PATH)
Line 43: vendor_path = os.path.join(path, VENDOR_PATH)
Line 44: runtime_path = os.path.join(path, RUNTIME_PATH)
Line 40: def create_conf_dirs():
Line 41: with namedTemporaryDir() as path:
Line 42:
Change in vdsm[master]: vdsm.conf: Add drop-in dir
gerrit-hooks has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 14: * #1279555::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279555::OK, public bug * Check Product::#1279555::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58728 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3849829aca50b30742e9c860d7c19296d6361015 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm.conf: Add drop-in dir
gerrit-hooks has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 15: * #1279555::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279555::OK, public bug * Check Product::#1279555::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58728 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3849829aca50b30742e9c860d7c19296d6361015 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tox: skip code style validation if required tox version isn'...
gerrit-hooks has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. .. Patch Set 7: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tox: skip code style validation if required tox version isn'...
Irit Goihman has posted comments on this change.
Change subject: tox: skip code style validation if required tox version isn't
installed.
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/59306/6//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-06-14 15:00:54 +0300
Line 4: Commit: Irit Goihman
Line 5: CommitDate: 2016-06-19 14:58:42 +0300
Line 6:
Line 7: tox: skip code style validation if required tox version isn't
> I know I suggested it :) but still - "fail make process if required tox ver
Done
Line 8: installed.
Line 9:
Line 10: Over RHEL 7.2 yum contains only tox-1.4.2 which doesn't fit to vdsm
Line 11: requirements.
https://gerrit.ovirt.org/#/c/59306/6/Makefile.am
File Makefile.am:
Line 81:
Line 82: .PHONY: gitignore
Line 83: gitignore:
Line 84:@echo "Checking that .in files are ignored..."
Line 85:@if test -f .gitignore; then \
> what if tox is not installed at all ?
Done
Line 86: for i in `git ls-files \*.in`; do \
Line 87:if ! grep -q -x $${i%%.in} .gitignore; then \
Line 88: echo "Missing $${i%%.in} in .gitignore"; exit 1; fi; \
Line 89: done; \
Line 84:@echo "Checking that .in files are ignored..."
Line 85:@if test -f .gitignore; then \
Line 86: for i in `git ls-files \*.in`; do \
Line 87:if ! grep -q -x $${i%%.in} .gitignore; then \
Line 88: echo "Missing $${i%%.in} in .gitignore"; exit 1; fi; \
> you can use TOX_VERSION in the print as well
Done
Line 89: done; \
Line 90:fi;
Line 91:
Line 92: .PHONY: abs_imports
--
To view, visit https://gerrit.ovirt.org/59306
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman
Gerrit-Reviewer: Edward Haas
Gerrit-Reviewer: Irit Goihman
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tox: skip code style validation if required tox version isn'...
gerrit-hooks has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tox: skip code style validation if required tox version isn'...
Nir Soffer has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/59306/6//COMMIT_MSG Commit Message: Line 5: CommitDate: 2016-06-18 21:47:19 +0300 Line 6: Line 7: tox: fail make process if tox version isn't right Line 8: Line 9: Over RHEL yum contains only tox-1.4.2 which doesn't fit to vdsm requirements. > maybe better to specify RHEL 7.2 When writing text (commit message, comments, docstrings) better use 72 characters. If you are using vim, you can set the textwidth automatically by adding these to your .vimrc: autocmd Filetype gitcommit textwidth=72 See this for more info: http://www.ovirt.org/develop/dev-process/working-with-gerrit/ Line 10: We require to install tox with pip currently. Line 11: This patch validates the version and fails make process if tox is older than 2.1.1 Line 12: Line 13: Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm.conf: Add drop-in dir
gerrit-hooks has posted comments on this change. Change subject: vdsm.conf: Add drop-in dir .. Patch Set 16: * #1279555::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1279555::OK, public bug * Check Product::#1279555::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58728 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3849829aca50b30742e9c860d7c19296d6361015 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tox: skip code style validation if required tox version isn'...
gerrit-hooks has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tox: skip code style validation if required tox version isn'...
Edward Haas has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. .. Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tox: skip code style validation if required tox version isn'...
Nir Soffer has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. .. Patch Set 9: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/59306/9/Makefile.am File Makefile.am: Line 81:done; Line 82: Line 83: .PHONY: pyflakes Line 84: pyflakes: Line 85:if [ -x "$(TOX)" ]; then \ -n was good enough - we detect TOX in configure, and if it is not installed, it will be empty string. Line 86:if [[ ! `tox --version | cut -d' ' -f1` < $(TOX_MIN_VERSION) ]]; \ Line 87:then \ Line 88:tox -- pyflakes ; \ Line 89:else \ Line 82: Line 83: .PHONY: pyflakes Line 84: pyflakes: Line 85:if [ -x "$(TOX)" ]; then \ Line 86:if [[ ! `tox --version | cut -d' ' -f1` < $(TOX_MIN_VERSION) ]]; \ Comparing version like that does not work - for example: if [[ 2.11.0 < 2.9.0 ]]; then echo broken; fi To compare versions, you need to parse version info components (e.g. "2.1.1" -> (2, 1, 1) , and compare the components. I think the best way to do this would be a small script to compare versions, something like: if not `require "2.1.1" ""`; then warn.. fi Line 87:then \ Line 88:tox -- pyflakes ; \ Line 89:else \ Line 90:echo "Warning: skipping check since tox is too old \ -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm.conf: Add drop-in dir
Nir Soffer has posted comments on this change.
Change subject: vdsm.conf: Add drop-in dir
..
Patch Set 13:
(1 comment)
https://gerrit.ovirt.org/#/c/58728/13/tests/config_test.py
File tests/config_test.py:
Line 64: create_conf(admin_path, 'vdsm', 'vdsm.conf', SSL_FALSE)
Line 65: cfg = config.load()
Line 66: self.assertFalse(cfg.getboolean('vars', 'ssl'))
Line 67:
Line 68: def test_confread_dirs_priority(self):
> Done - I didn't create 4 different tests since I want to check the priority
Checking the priority should be done in separate test. We should have a very
simple test to make sure we read all the files, and a more complex test to
ensure that the right config file overrides others.
Line 69: with create_conf_dirs() as (admin_path, vendor_path,
runtime_path):
Line 70: create_conf(
Line 71: admin_path,
Line 72: 'vdsm',
--
To view, visit https://gerrit.ovirt.org/58728
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3849829aca50b30742e9c860d7c19296d6361015
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Irit Goihman
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ppc64hwinfo: add tests for getHardwareInfoStructure
Dan Kenigsberg has submitted this change and it was merged. Change subject: ppc64hwinfo: add tests for getHardwareInfoStructure .. ppc64hwinfo: add tests for getHardwareInfoStructure Change-Id: I86853a7f475c371581dc51d2d6426daeb10082fe Signed-off-by: Martin Polednik Reviewed-on: https://gerrit.ovirt.org/57748 Reviewed-by: Francesco Romani Continuous-Integration: Jenkins CI --- M tests/hwinfo_test.py 1 file changed, 34 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/57748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86853a7f475c371581dc51d2d6426daeb10082fe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ppc64hwinfo: add tests for getHardwareInfoStructure
gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: add tests for getHardwareInfoStructure .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/57748 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86853a7f475c371581dc51d2d6426daeb10082fe Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ppc64hwinfo: refactor _getFromDeviceTree
Dan Kenigsberg has submitted this change and it was merged. Change subject: ppc64hwinfo: refactor _getFromDeviceTree .. ppc64hwinfo: refactor _getFromDeviceTree The function was not pep8 compliant and not really nice either. We improve the function by making it pep8 compliant, renaming it to _from_device_tree and overall nicer. Change-Id: Id065362e54bf004281b2f84593a8b0fd2f8e90b1 Signed-off-by: Martin Polednik Reviewed-on: https://gerrit.ovirt.org/57749 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M lib/vdsm/ppc64HardwareInfo.py M tests/hwinfo_test.py 2 files changed, 12 insertions(+), 14 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/57749 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id065362e54bf004281b2f84593a8b0fd2f8e90b1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ppc64hwinfo: refactor _getFromDeviceTree
gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: refactor _getFromDeviceTree .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/57749 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id065362e54bf004281b2f84593a8b0fd2f8e90b1 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ppc64hwinfo: extend cpuinfo to platform and machine
Dan Kenigsberg has submitted this change and it was merged. Change subject: ppc64hwinfo: extend cpuinfo to platform and machine .. ppc64hwinfo: extend cpuinfo to platform and machine Platform and machine keys in cpuinfo are ppc64 and ppc64le platform specific keys indicating the machine type and platform. We expose them in cpuinfo to enable other modules use them without having to parse /proc/cpuinfo themself. Change-Id: I9a18b6ba49c9d0a6199dad436defae39c20f0cc5 Signed-off-by: Martin Polednik Reviewed-on: https://gerrit.ovirt.org/57750 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M lib/vdsm/cpuinfo.py M tests/cpuinfo_test.py 2 files changed, 57 insertions(+), 2 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/57750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a18b6ba49c9d0a6199dad436defae39c20f0cc5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ppc64hwinfo: extend cpuinfo to platform and machine
gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: extend cpuinfo to platform and machine .. Patch Set 5: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/57750 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9a18b6ba49c9d0a6199dad436defae39c20f0cc5 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ppc64hwinfo: refactor getHardwareInfoStructure
Dan Kenigsberg has submitted this change and it was merged. Change subject: ppc64hwinfo: refactor getHardwareInfoStructure .. ppc64hwinfo: refactor getHardwareInfoStructure Since all information we need are now available via _from_device_tree or cpuinfo, we can drop custom cpuinfo parsing and simply format the values we get elsewhere. Change-Id: I0245925f5cf3a0a2d384fdff0f5701b312b336b1 Signed-off-by: Martin Polednik Reviewed-on: https://gerrit.ovirt.org/57751 Continuous-Integration: Jenkins CI Reviewed-by: Francesco Romani --- M lib/vdsm/cpuinfo.py M lib/vdsm/ppc64HardwareInfo.py M tests/hwinfo_test.py 3 files changed, 28 insertions(+), 52 deletions(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, approved Martin Polednik: Verified -- To view, visit https://gerrit.ovirt.org/57751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0245925f5cf3a0a2d384fdff0f5701b312b336b1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: ppc64hwinfo: refactor getHardwareInfoStructure
gerrit-hooks has posted comments on this change. Change subject: ppc64hwinfo: refactor getHardwareInfoStructure .. Patch Set 6: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/57751 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0245925f5cf3a0a2d384fdff0f5701b312b336b1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tox: skip code style validation if required tox version isn'...
Yaniv Bronhaim has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/59306/9/Makefile.am File Makefile.am: Line 87:then \ Line 88:tox -- pyflakes ; \ Line 89:else \ Line 90:echo "Warning: skipping check since tox is too old \ Line 91:please install tox $(TOX_MIN_VERSION) or later."; \ Nir, I don't agree that we should just warn. I prefer to remove the make check in koji and brew rather allowing people to build silently vdsm without pep8 and pyflakes check Line 92:fi \ Line 93:else \ Line 94:echo "Warning: tox is not installed, skipping check"; \ Line 95:fi -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: adding support for version 4.1
gerrit-hooks has posted comments on this change. Change subject: vdsm: adding support for version 4.1 .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aaaf4d6ebf6c1e0fdcb37a158993a7b84c7f06d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: adding support for version 4.1
Eli Mesika has posted comments on this change. Change subject: vdsm: adding support for version 4.1 .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/59308/2/lib/vdsm/dsaversion.py.in File lib/vdsm/dsaversion.py.in: Line 39: 'clusterLevels': ['4.0', '4.1'], Line 40: } Line 41: Line 42: if cpuarch.real() == cpuarch.PPC64LE: Line 43: version_info['clusterLevels'] = ['4.0', '4.1'] > This should be removed once ppc64le version is same as others. Done -- To view, visit https://gerrit.ovirt.org/59308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aaaf4d6ebf6c1e0fdcb37a158993a7b84c7f06d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: adding support for version 4.1
Eli Mesika has posted comments on this change. Change subject: vdsm: adding support for version 4.1 .. Patch Set 3: Verified+1 -- To view, visit https://gerrit.ovirt.org/59308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aaaf4d6ebf6c1e0fdcb37a158993a7b84c7f06d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tox: skip code style validation if required tox version isn'...
Nir Soffer has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/59306/9/Makefile.am File Makefile.am: Line 82: Line 83: .PHONY: pyflakes Line 84: pyflakes: Line 85:if [ -x "$(TOX)" ]; then \ Line 86:if [[ ! `tox --version | cut -d' ' -f1` < $(TOX_MIN_VERSION) ]]; \ > Comparing version like that does not work - for example: rpmdev-vercmp seems to do what we want. Line 87:then \ Line 88:tox -- pyflakes ; \ Line 89:else \ Line 90:echo "Warning: skipping check since tox is too old \ Line 87:then \ Line 88:tox -- pyflakes ; \ Line 89:else \ Line 90:echo "Warning: skipping check since tox is too old \ Line 91:please install tox $(TOX_MIN_VERSION) or later."; \ > Nir, I don't agree that we should just warn. I prefer to remove the make ch I'm fine with that, we will need to do this anyway since development tools are too old on downstream. Line 92:fi \ Line 93:else \ Line 94:echo "Warning: tox is not installed, skipping check"; \ Line 95:fi -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: adding support for version 4.1
Allon Mureinik has posted comments on this change. Change subject: vdsm: adding support for version 4.1 .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/59308/3/lib/vdsm/dsaversion.py.in File lib/vdsm/dsaversion.py.in: Line 35: 'version_name': version_name, Line 36: 'software_version': software_version, Line 37: 'software_revision': software_revision, Line 38: 'supportedENGINEs': ['3.5', '3.6', '4.0', '4.1'], Line 39: 'clusterLevels': ['3.5','3.6', '4.0', '4.1'], You are missing space before '3.6' and have a redundant space after it. Other than that, looks fine to me Line 40: } Line 41: Line 42: if cpuarch.real() == cpuarch.PPC64LE: -- To view, visit https://gerrit.ovirt.org/59308 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7aaaf4d6ebf6c1e0fdcb37a158993a7b84c7f06d Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eli Mesika Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Martin Polednik Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Oved Ourfali Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tox: skip code style validation if required tox version isn'...
Yaniv Bronhaim has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. .. Patch Set 9: (2 comments) https://gerrit.ovirt.org/#/c/59306/9/Makefile.am File Makefile.am: Line 81:done; Line 82: Line 83: .PHONY: pyflakes Line 84: pyflakes: Line 85:if [ -x "$(TOX)" ]; then \ > -n was good enough - we detect TOX in configure, and if it is not installed do we? oh, missed that. Line 86:if [[ ! `tox --version | cut -d' ' -f1` < $(TOX_MIN_VERSION) ]]; \ Line 87:then \ Line 88:tox -- pyflakes ; \ Line 89:else \ Line 87:then \ Line 88:tox -- pyflakes ; \ Line 89:else \ Line 90:echo "Warning: skipping check since tox is too old \ Line 91:please install tox $(TOX_MIN_VERSION) or later."; \ > I'm fine with that, we will need to do this anyway since development tools Irit, keep the exit here, and the evironment env flag to disable style check run, and in separate patch remove the make check from the spec with a comment that we miss many tools to run our uts in the build systems, such as tox. Nir might be able to elaborate more Line 92:fi \ Line 93:else \ Line 94:echo "Warning: tox is not installed, skipping check"; \ Line 95:fi -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py
Dan Kenigsberg has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida119527b263302bf3f78e359bac12113718b744 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tox: skip code style validation if required tox version isn'...
Yaniv Bronhaim has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/59306/9/Makefile.am File Makefile.am: Line 82: Line 83: .PHONY: pyflakes Line 84: pyflakes: Line 85:if [ -x "$(TOX)" ]; then \ Line 86:if [[ ! `tox --version | cut -d' ' -f1` < $(TOX_MIN_VERSION) ]]; \ > rpmdev-vercmp seems to do what we want. can you try to check if in configure.ac we can validate the version as well? probably autotools got a macro for that Line 87:then \ Line 88:tox -- pyflakes ; \ Line 89:else \ Line 90:echo "Warning: skipping check since tox is too old \ -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Setup ipv6autoconf with OVS switch
Edward Haas has uploaded a new change for review.
Change subject: net: Setup ipv6autoconf with OVS switch
..
net: Setup ipv6autoconf with OVS switch
When handling an OVS switch setup, set ipv6autoconf for its northbound
ifaces.
This is required at this stage for passing functional tests.
Change-Id: I2ab57857ff9f5c9ed582ae4aaacc3477f2fcd94d
Signed-off-by: Edward Haas
---
M lib/vdsm/network/ip/address.py
M lib/vdsm/network/netswitch.py
M lib/vdsm/sysctl.py
3 files changed, 60 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/44/59444/1
diff --git a/lib/vdsm/network/ip/address.py b/lib/vdsm/network/ip/address.py
index 50c910f..ad555ec 100644
--- a/lib/vdsm/network/ip/address.py
+++ b/lib/vdsm/network/ip/address.py
@@ -21,6 +21,7 @@
import socket
import struct
+from vdsm import sysctl
from vdsm.network import errors as ne
from vdsm.network.errors import ConfigNetworkError
@@ -153,3 +154,11 @@
def addrs_info(dev, ipaddrs=None, ipv4_gateway=None):
return addresses.getIpInfo(dev, ipaddrs, ipv4_gateway)
+
+
+def enable_ipv6_local_auto(dev):
+sysctl.enable_ipv6_local_auto(dev)
+
+
+def disable_ipv6_local_auto(dev):
+sysctl.disable_ipv6_local_auto(dev)
diff --git a/lib/vdsm/network/netswitch.py b/lib/vdsm/network/netswitch.py
index 817aa02..523dfa9 100644
--- a/lib/vdsm/network/netswitch.py
+++ b/lib/vdsm/network/netswitch.py
@@ -20,6 +20,7 @@
import six
+from vdsm.network.ip import address
from vdsm.network.libvirt import networks as libvirt_nets
from vdsm.network.netinfo.cache import (libvirtNets2vdsm, get as netinfo_get,
CachingNetInfo)
@@ -137,6 +138,7 @@
def _setup_ovs(networks, bondings, options, in_rollback):
with ovs_switch.transaction(in_rollback, networks, bondings):
ovs_switch.setup(networks, bondings)
+_setup_ipv6autoconf(networks)
connectivity.check(options)
@@ -163,3 +165,15 @@
@memoized
def _is_ovs_service_running():
return service_status('openvswitch', verbose=False) == 0
+
+
+def _setup_ipv6autoconf(networks):
+# TODO: Move func to IP or LINK level.
+# TODO: Implicitly disable ipv6 on SB iface/s and fake ifaces (br, bond).
+for net, attrs in six.iteritems(networks):
+if 'remove' in attrs:
+continue
+if attrs['ipv6autoconf']:
+address.enable_ipv6_local_auto(net)
+else:
+address.disable_ipv6_local_auto(net)
diff --git a/lib/vdsm/sysctl.py b/lib/vdsm/sysctl.py
index 7b717f1..fb0e0bf 100644
--- a/lib/vdsm/sysctl.py
+++ b/lib/vdsm/sysctl.py
@@ -40,6 +40,10 @@
set_rp_filter(dev, _RPFILTER_STRICT)
+def enable_ipv6(dev):
+disable_ipv6(dev, disable=False)
+
+
def disable_ipv6(dev, disable=True):
with open('/proc/sys/net/ipv6/conf/%s/disable_ipv6' % dev, 'w') as f:
f.write('1' if disable else '0')
@@ -67,3 +71,36 @@
return bool(not is_disabled and
is_autoconf and is_accept_ra and is_accept_redirects)
+
+
+def enable_ipv6_local_auto(dev):
+return _set_ipv6_local_auto(dev, True)
+
+
+def disable_ipv6_local_auto(dev):
+return _set_ipv6_local_auto(dev, False)
+
+
+def _set_ipv6_local_auto(dev, state):
+setstate = '1' if state else '0'
+try:
+if is_disabled_ipv6(dev):
+if state:
+enable_ipv6(dev)
+else:
+return True
+
+with open('/proc/sys/net/ipv6/conf/%s/autoconf' % dev, 'w') as f:
+f.write(setstate)
+with open('/proc/sys/net/ipv6/conf/%s/accept_ra' % dev, 'w') as f:
+f.write(setstate)
+with open('/proc/sys/net/ipv6/conf'
+ '/%s/accept_redirects' % dev, 'w') as f:
+f.write(setstate)
+except IOError as e:
+if e.errno == errno.ENOENT:
+return False
+else:
+raise
+
+return True
--
To view, visit https://gerrit.ovirt.org/59444
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2ab57857ff9f5c9ed582ae4aaacc3477f2fcd94d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net tests: Support the ability to choose the tested switch
gerrit-hooks has posted comments on this change. Change subject: net tests: Support the ability to choose the tested switch .. Patch Set 8: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e230633dfefcdc4a4b545eb2139ffe190c6f35 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Setup ipv6autoconf with OVS switch
gerrit-hooks has posted comments on this change. Change subject: net: Setup ipv6autoconf with OVS switch .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab57857ff9f5c9ed582ae4aaacc3477f2fcd94d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net tests: Support the ability to choose the tested switch
Edward Haas has posted comments on this change. Change subject: net tests: Support the ability to choose the tested switch .. Patch Set 8: Verified+1 Functional tests are passing with OVS chosen, please re-verify. -- To view, visit https://gerrit.ovirt.org/58970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e230633dfefcdc4a4b545eb2139ffe190c6f35 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Setup ipv6autoconf with OVS switch
Edward Haas has posted comments on this change. Change subject: net: Setup ipv6autoconf with OVS switch .. Patch Set 1: Verified+1 Passing functional tests with OVS switch. -- To view, visit https://gerrit.ovirt.org/59444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab57857ff9f5c9ed582ae4aaacc3477f2fcd94d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: vdsm: adding handling for NGN in osinfo.py
Yaniv Bronhaim has posted comments on this change. Change subject: vdsm: adding handling for NGN in osinfo.py .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/59431/1//COMMIT_MSG Commit Message: Line 9: Current osinfo.py implementation lacks handling for NGN (New Generation Line 10: Node). Line 11: Line 12: This patch adds another parameter in addition to the osname, release and Line 13: version named pretty_name, that is empty bu default and if s/bu/by Line 14: /etc/os-release file exists on the OS, will return the content of the Line 15: PRETTY_NAME value (if exists) from that file. Line 16: Line 17: Change-Id: Ida119527b263302bf3f78e359bac12113718b744 Line 11: Line 12: This patch adds another parameter in addition to the osname, release and Line 13: version named pretty_name, that is empty bu default and if Line 14: /etc/os-release file exists on the OS, will return the content of the Line 15: PRETTY_NAME value (if exists) from that file. so in ngn we don't return osname release and version at all?? Line 16: Line 17: Change-Id: Ida119527b263302bf3f78e359bac12113718b744 Line 18: Bug-Url : https://bugzilla.redhat.com/show_bug.cgi?id=1324447 -- To view, visit https://gerrit.ovirt.org/59431 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida119527b263302bf3f78e359bac12113718b744 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Eli Mesika Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Fabian Deutsch Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net tests: Support the ability to choose the tested switch
Dan Kenigsberg has posted comments on this change. Change subject: net tests: Support the ability to choose the tested switch .. Patch Set 8: (2 comments) https://gerrit.ovirt.org/#/c/58970/8//COMMIT_MSG Commit Message: Line 8: Line 9: Use VDSM_TESTER_SWITCH_TYPE env variable to specify which switch type Line 10: should be tested in the functional tests. Line 11: If it is not set, all switch types will run. Line 12: If 'ovs' (or 'legacy') is set, then 'legacy' (or 'ovs') are skipped. please refer to the ovs(?) bug forcing us to do this trick. Line 13: Line 14: Change-Id: I06e230633dfefcdc4a4b545eb2139ffe190c6f35 https://gerrit.ovirt.org/#/c/58970/8/tests/functional/networkTests.py File tests/functional/networkTests.py: PS8, Line 425: _skip_per_switch_type maybe _skip_nontested_switch()? or add the docstring """skip setupNetwork if it attempts to create a switchtype other than VDSM_TESTER_SWITCH_TYPE' -- To view, visit https://gerrit.ovirt.org/58970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e230633dfefcdc4a4b545eb2139ffe190c6f35 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: Add inplace virt-sparsify support
gerrit-hooks has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 2: * #734120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#734120::OK, public bug * Check Product::#734120::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/57347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Shmuel Melamud Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: Add inplace virt-sparsify support
gerrit-hooks has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 3: * #734120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#734120::OK, public bug * Check Product::#734120::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/57347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Shmuel Melamud Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: Create an external ifcfg bond in a context
Edward Haas has uploaded a new change for review.
Change subject: net test: Create an external ifcfg bond in a context
..
net test: Create an external ifcfg bond in a context
test_setupNetworks_on_external_vlaned_bond test has left the system
unclean when an exception occurs before the bond removal.
Change-Id: I7295a9a1eafeef9a2643dd8f3aa64b25797d3810
Signed-off-by: Edward Haas
---
M tests/functional/networkTests.py
1 file changed, 61 insertions(+), 40 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/48/59448/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 492f60e..031a0b8 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -2690,46 +2690,12 @@
@ValidateRunningAsRoot
def test_setupNetworks_on_external_vlaned_bond(self):
with dummyIf(2) as nics:
-with open(NET_CONF_PREF + nics[0], 'w') as f:
-f.write("""DEVICE=%s
-MASTER=%s
-SLAVE=yes
-ONBOOT=yes
-MTU=1500
-NM_CONTROLLED=no""" % (nics[0], BONDING_NAME))
-with open(NET_CONF_PREF + nics[1], 'w') as f:
-f.write("""DEVICE=%s
-MASTER=%s
-SLAVE=yes
-ONBOOT=yes
-MTU=1500
-NM_CONTROLLED=no""" % (nics[1], BONDING_NAME))
-with open(NET_CONF_PREF + BONDING_NAME, 'w') as f:
-f.write("""DEVICE=%s
-BONDING_OPTS='mode=802.3ad miimon=150'
-ONBOOT=yes
-BOOTPROTO=none
-DEFROUTE=yes
-NM_CONTROLLED=no
-HOTPLUG=no""" % BONDING_NAME)
-with open(NET_CONF_PREF + BONDING_NAME + '.' + VLAN_ID, 'w') as f:
-f.write("""DEVICE=%s.%s
-VLAN=yes
-ONBOOT=yes
-BOOTPROTO=static
-NM_CONTROLLED=no
-HOTPLUG=no""" % (BONDING_NAME, VLAN_ID))
-
-rc, _, err = execCmd([EXT_IFUP, BONDING_NAME])
-self.assertEqual(rc, SUCCESS, err)
-rc, _, err = execCmd([EXT_IFUP, BONDING_NAME + '.' + VLAN_ID])
-self.assertEqual(rc, SUCCESS, err)
-
-status, msg = self.setupNetworks(
-{NETWORK_NAME: {'bonding': BONDING_NAME, 'bridged': True,
-'vlan': VLAN_ID}}, {}, NOCHK)
-self.assertEqual(status, SUCCESS, msg)
-self.assertNetworkExists(NETWORK_NAME)
+with self._create_external_ifcfg_bond(BONDING_NAME, nics, VLAN_ID):
+status, msg = self.setupNetworks(
+{NETWORK_NAME: {'bonding': BONDING_NAME, 'bridged': True,
+'vlan': VLAN_ID}}, {}, NOCHK)
+self.assertEqual(status, SUCCESS, msg)
+self.assertNetworkExists(NETWORK_NAME)
self.vdsm_net.save_config()
self.vdsm_net.restoreNetConfig()
@@ -2998,6 +2964,61 @@
for nic in nics:
self.assertNotIn('ad_aggregator_id', nic_caps[nic])
+@contextmanager
+def _create_external_ifcfg_bond(self, bond_name, nics, vlan_id):
+IFCFG_SLAVE_TEMPLATE = """DEVICE=%s
+MASTER=%s
+SLAVE=yes
+ONBOOT=yes
+MTU=1500
+NM_CONTROLLED=no"""
+
+IFCFG_BOND_TEMPLATE = """DEVICE=%s
+BONDING_OPTS='mode=802.3ad miimon=150'
+ONBOOT=yes
+BOOTPROTO=none
+DEFROUTE=yes
+NM_CONTROLLED=no
+HOTPLUG=no"""
+
+IFCFG_VLAN_TEMPLATE = """DEVICE=%s.%s
+VLAN=yes
+ONBOOT=yes
+BOOTPROTO=static
+NM_CONTROLLED=no
+HOTPLUG=no"""
+
+with open(NET_CONF_PREF + nics[0], 'w') as f:
+f.write(IFCFG_SLAVE_TEMPLATE % (nics[0], bond_name))
+with open(NET_CONF_PREF + nics[1], 'w') as f:
+f.write(IFCFG_SLAVE_TEMPLATE % (nics[1], bond_name))
+with open(NET_CONF_PREF + bond_name, 'w') as f:
+f.write(IFCFG_BOND_TEMPLATE % bond_name)
+with open(NET_CONF_PREF + bond_name + '.' + vlan_id, 'w') as f:
+f.write(IFCFG_VLAN_TEMPLATE % (bond_name, vlan_id))
+
+rc, _, err = execCmd([EXT_IFUP, bond_name])
+self.assertEqual(rc, SUCCESS, err)
+rc, _, err = execCmd([EXT_IFUP, bond_name + '.' + vlan_id])
+self.assertEqual(rc, SUCCESS, err)
+
+try:
+yield
+finally:
+rc, _, err = execCmd([EXT_IFDOWN, bond_name + '.' + vlan_id])
+self.assertEqual(rc, SUCCESS, err)
+rc, _, err = execCmd([EXT_IFDOWN, bond_name])
+self.assertEqual(rc, SUCCESS, err)
+
+# The bond needs to be removed by force
+with open(BONDING_MASTERS, 'w') as bonds:
+bonds.write('-%s\n' % bond_name)
+
+os.remove(NET_CONF_PREF + nics[0])
+os.remove(NET_CONF_PREF + nics[1])
+os.remove(NET_CONF_PREF + bond_name)
+os.remove(NET_CONF_PREF + bond_name + '.' + vlan_id)
+
@memoized
def switch_to_test():
--
To view, visit https://gerrit.ovirt.org/59448
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7295a9a1eafeef9a2643dd8f3aa64b25797d3810
Gerrit-
Change in vdsm[master]: net test: Create an external bond in a context
Edward Haas has uploaded a new change for review.
Change subject: net test: Create an external bond in a context
..
net test: Create an external bond in a context
Change-Id: I401fcbb8047c215300309c991415d263979f8b9e
Signed-off-by: Edward Haas
---
M tests/functional/networkTests.py
1 file changed, 16 insertions(+), 10 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/47/59447/1
diff --git a/tests/functional/networkTests.py b/tests/functional/networkTests.py
index 9358fee..492f60e 100644
--- a/tests/functional/networkTests.py
+++ b/tests/functional/networkTests.py
@@ -2663,13 +2663,7 @@
@ValidateRunningAsRoot
def test_setupNetworks_on_external_bond(self):
with dummyIf(2) as nics:
-with open(BONDING_MASTERS, 'w') as bonds:
-bonds.write('+%s\n' % BONDING_NAME)
-try:
-with open(BONDING_SLAVES % BONDING_NAME, 'w') as f:
-for nic in nics:
-linkSet(nic, ['down'])
-f.write('+%s\n' % nic)
+with _create_external_bond(BONDING_NAME, nics):
status, msg = self.setupNetworks(
{NETWORK_NAME:
{'bonding': BONDING_NAME, 'bridged': False}},
@@ -2677,9 +2671,6 @@
self.assertEqual(status, SUCCESS, msg)
self.assertNetworkExists(NETWORK_NAME)
self.assertBondExists(BONDING_NAME, nics)
-finally:
-with open(BONDING_MASTERS, 'w') as bonds:
-bonds.write('-%s\n' % BONDING_NAME)
self.vdsm_net.save_config()
self.vdsm_net.restoreNetConfig()
@@ -3011,3 +3002,18 @@
@memoized
def switch_to_test():
return os.environ.get('VDSM_TESTER_SWITCH_TYPE')
+
+
+@contextmanager
+def _create_external_bond(name, slaves):
+with open(BONDING_MASTERS, 'w') as bonds:
+bonds.write('+%s\n' % name)
+try:
+with open(BONDING_SLAVES % BONDING_NAME, 'w') as f:
+for slave in slaves:
+linkSet(slave, ['down'])
+f.write('+%s\n' % slave)
+yield
+finally:
+with open(BONDING_MASTERS, 'w') as bonds:
+bonds.write('-%s\n' % name)
--
To view, visit https://gerrit.ovirt.org/59447
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I401fcbb8047c215300309c991415d263979f8b9e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: Create an external bond in a context
gerrit-hooks has posted comments on this change. Change subject: net test: Create an external bond in a context .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I401fcbb8047c215300309c991415d263979f8b9e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: Create an external ifcfg bond in a context
gerrit-hooks has posted comments on this change. Change subject: net test: Create an external ifcfg bond in a context .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7295a9a1eafeef9a2643dd8f3aa64b25797d3810 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: stomp: simplified client
Yaniv Bronhaim has posted comments on this change. Change subject: stomp: simplified client .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/59151 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: Add inplace virt-sparsify support
gerrit-hooks has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 4: * #734120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#734120::OK, public bug * Check Product::#734120::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/57347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Shmuel Melamud Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: Add inplace virt-sparsify support
gerrit-hooks has posted comments on this change. Change subject: storage: Add inplace virt-sparsify support .. Patch Set 5: * #734120::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#734120::OK, public bug * Check Product::#734120::OK, Correct classification oVirt * Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/57347 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ac2bb1fbd2acbe0fc47694d17313c6ccd01a227 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Shmuel Leib Melamud Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Maor Lipchuk Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Shmuel Melamud Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tox: skip code style validation if required tox version isn'...
Edward Haas has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. .. Patch Set 9: -Code-Review -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net tests: Support the ability to choose the tested switch
gerrit-hooks has posted comments on this change. Change subject: net tests: Support the ability to choose the tested switch .. Patch Set 9: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/58970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e230633dfefcdc4a4b545eb2139ffe190c6f35 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net tests: Support the ability to choose the tested switch
Edward Haas has posted comments on this change. Change subject: net tests: Support the ability to choose the tested switch .. Patch Set 9: Verified+1 (2 comments) Functional tests are passing with OVS chosen, please re-verify. https://gerrit.ovirt.org/#/c/58970/8//COMMIT_MSG Commit Message: Line 8: Line 9: Use VDSM_TESTER_SWITCH_TYPE env variable to specify which switch type Line 10: should be tested in the functional tests. Line 11: If it is not set, all switch types will run. Line 12: If 'ovs' (or 'legacy') is set, then 'legacy' (or 'ovs') are skipped. > please refer to the ovs(?) bug forcing us to do this trick. Done Line 13: Line 14: The option has been introduced to overcome the problem described by Line 15: https://bugzilla.redhat.com/show_bug.cgi?id=1346232 Line 16: https://gerrit.ovirt.org/#/c/58970/8/tests/functional/networkTests.py File tests/functional/networkTests.py: PS8, Line 425: _skip_per_switch_type > maybe _skip_nontested_switch()? Done -- To view, visit https://gerrit.ovirt.org/58970 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06e230633dfefcdc4a4b545eb2139ffe190c6f35 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net: Setup ipv6autoconf with OVS switch
gerrit-hooks has posted comments on this change. Change subject: net: Setup ipv6autoconf with OVS switch .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2ab57857ff9f5c9ed582ae4aaacc3477f2fcd94d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: Create an external ifcfg bond in a context
gerrit-hooks has posted comments on this change. Change subject: net test: Create an external ifcfg bond in a context .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7295a9a1eafeef9a2643dd8f3aa64b25797d3810 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: Create an external bond in a context
gerrit-hooks has posted comments on this change. Change subject: net test: Create an external bond in a context .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' and is a valid url. * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 'ovirt-4.0']) -- To view, visit https://gerrit.ovirt.org/59447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I401fcbb8047c215300309c991415d263979f8b9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: Create an external ifcfg bond in a context
Edward Haas has posted comments on this change. Change subject: net test: Create an external ifcfg bond in a context .. Patch Set 2: Verified+1 Functional tests are passing: VDSM_TESTER_SWITCH_TYPE=ovs ./run_tests.sh functional/networkTests.p VDSM_TESTER_SWITCH_TYPE=legacy ./run_tests.sh functional/networkTests.p -- To view, visit https://gerrit.ovirt.org/59448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7295a9a1eafeef9a2643dd8f3aa64b25797d3810 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: net test: Create an external bond in a context
Edward Haas has posted comments on this change. Change subject: net test: Create an external bond in a context .. Patch Set 2: Verified+1 Functional tests are passing: VDSM_TESTER_SWITCH_TYPE=ovs ./run_tests.sh functional/networkTests.p VDSM_TESTER_SWITCH_TYPE=legacy ./run_tests.sh functional/networkTests.p -- To view, visit https://gerrit.ovirt.org/59447 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I401fcbb8047c215300309c991415d263979f8b9e Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Edward Haas Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Petr Horáček Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: sdm: Support snapshot creation
Nir Soffer has posted comments on this change.
Change subject: sdm: Support snapshot creation
..
Patch Set 10:
(12 comments)
https://gerrit.ovirt.org/#/c/57057/10/tests/storage_volume_artifacts_test.py
File tests/storage_volume_artifacts_test.py:
Line 198:
Line 199: child_info = qemuimg.info(child_artifacts.volume_path)
Line 200: self.assertEqual(parent.vol_id, child_info['backingfile'])
Line 201:
Line 202: def test_create_snapshot_wrong_size(self):
Can you add a comment explaining whats wrong with the size here? Why do we
specify a size when creating a snapshot?
Line 203: with self.fake_env() as env:
Line 204: parent = self.create_base_volume(env, sc.RAW_FORMAT,
Line 205: img_id=self.img_id)
Line 206:
Line 451: # Therefore, we cannot use file size for this test.
Line 452: lv = env.lvm.getLV(env.sd_manifest.sdUUID, self.vol_id)
Line 453: self.assertEqual(actual_size, int(lv.size))
Line 454: vsize = qemuimg.info(artifacts.volume_path)['virtualsize']
Line 455: self.assertEqual(test_size, vsize)
I think we can separate this, it is not related to snapshots. Will make it
eaiser to understand this change in the future.
Line 456:
Line 457: def test_size_rounded_up(self):
Line 458: # If the underlying device is larger the size will be updated
Line 459: with fake_block_env() as env:
https://gerrit.ovirt.org/#/c/57057/10/vdsm/storage/sdm/volume_artifacts.py
File vdsm/storage/sdm/volume_artifacts.py:
Line 247
Line 248
Line 249
Line 250
Line 251
This is the best place to change the parent type to internal.
Line 379
Line 380
Line 381
Line 382
Line 383
Do we support creating a snapshot with initial size?
The size parameter must be the parent size, so it is not really a parameter. We
need to provide a simpler interface for creating a snapshot.
Line 384
Line 385
Line 386
Line 387
Line 388
This is relevant only to the first volume, even then it is more about consuming
the volume, not about creating a volume.
Line 395
Line 396
Line 397
Line 398
Line 399
This is the best place to change the parent type to internal.
Line 135: self.log.debug("initial_size %s not a multiple of the
block size",
Line 136:initial_size)
Line 137: raise se.InvalidParameterException("initial_size",
initial_size)
Line 138:
Line 139: def _clone_parent(self, parent, size):
Not sure why you call this clone - isn't it actually create_snapshot()?
Line 140: # This function must be called after the parent volume id has
been set
Line 141: # in the new volume's metadata so the garbage collector will
be able to
Line 142: # undo this change to the parent volume in the event of a
failure.
Line 143: parent_vol = self.sd_manifest.produceVolume(parent.img_id,
Line 144: parent.vol_id)
Line 145: parent_size_bytes = parent_vol.getSize() * sc.BLOCK_SIZE
Line 146: if parent_size_bytes != size:
Line 147: self.log.debug("New volume must have the same size as
parent")
Line 148: raise se.InvalidParameterException("size", size)
I would remove the size parameter when creating new volume. There is no reason
to specify it.
Why do we use create_volume for creating snapshot? We should have s separate
verb for this, requiring only the parameter that makes sense.
This will simplify both verbs, and in this class we can add a simpler method
for creating a snapshot.
Line 149:
Line 150: if not parent_vol.isLegal():
Line 151: raise
se.createIllegalVolumeSnapshotError(parent_vol.volUUID)
Line 152:
Line 147: self.log.debug("New volume must have the same size as
parent")
Line 148: raise se.InvalidParameterException("size", size)
Line 149:
Line 150: if not parent_vol.isLegal():
Line 151: raise
se.createIllegalVolumeSnapshotError(parent_vol.volUUID)
This is not related to volume initialization, should be done in the validation
part of creating an image.
Line 152:
Line 153: self.log.debug("Setting volType to internal for volume %s",
Line 154:parent.vol_id)
Line 155: parent_vol.setInternal()
Line 151: raise
se.createIllegalVolumeSnapshotError(parent_vol.volUUID)
Line 152:
Line 153: self.log.debug("Setting volType to internal for volume %s",
Line 154:parent.vol_id)
Line 155: parent_vol.setInternal()
This should be the last thing before we commit, here it is too early.
Line 156: parent_vol.prepare(rw=False)
Line 157: try:
Line 158: qemuimg.create(self.volume_path, backing=parent.vol_id,
Line 159:format=sc.fmt2str(sc.COW_
Change in vdsm[master]: tests: Fix blockSD file layout
Nir Soffer has posted comments on this change.
Change subject: tests: Fix blockSD file layout
..
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/57058/1/vdsm/storage/sdm/volume_artifacts.py
File vdsm/storage/sdm/volume_artifacts.py:
Line 385: def volume_path(self):
Line 386: #return lvm.lvPath(self.sd_manifest.sdUUID, self.vol_id)
Line 387: im = image.ImageManifest(self.sd_manifest.getRepoPath())
Line 388: image_dir = im.getImageDir(self.sd_manifest.sdUUID,
self.img_id)
Line 389: return os.path.join(image_dir, self.vol_id)
Why this is better? Is this what we use in the old code?
Line 390:
Line 391: def create(self, size, vol_format, disk_type, desc, parent=None,
Line 392:initial_size=None):
Line 393: prealloc = self.get_volume_preallocation(vol_format)
Line 462: blockVolume.TAG_PREFIX_IMAGE + self.img_id)
Line 463: lvm.createLV(self.sd_manifest.sdUUID, self.vol_id, lv_size,
Line 464: activate=True, initialTags=tags)
Line 465:
Line 466: def _create_image_path(self):
We should take this out of this class - this can be done by the job if we
created successfully the volume. Do we have any reason to do this here except
that it was done in old code?
Line 467: im = image.ImageManifest(self.sd_manifest.getRepoPath())
Line 468: image_dir = im.getImageDir(self.sd_manifest.sdUUID,
self.img_id)
Line 469: if not os.path.isdir(image_dir):
Line 470: self.log.info("Create placeholder %s for image's volumes",
--
To view, visit https://gerrit.ovirt.org/57058
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id68197ef3fb61d16c1130cec1d4d0f384d2e30b7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke
Gerrit-Reviewer: Adam Litke
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: tox: skip code style validation if required tox version isn'...
Nir Soffer has posted comments on this change. Change subject: tox: skip code style validation if required tox version isn't installed. .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/59306/9/Makefile.am File Makefile.am: Line 82: Line 83: .PHONY: pyflakes Line 84: pyflakes: Line 85:if [ -x "$(TOX)" ]; then \ Line 86:if [[ ! `tox --version | cut -d' ' -f1` < $(TOX_MIN_VERSION) ]]; \ > can you try to check if in configure.ac we can validate the version as well We may be able to do this in configure, but do you cannot fail configure since it will fail build on downstream. The best place to fail is here, when you try to use tox. Line 87:then \ Line 88:tox -- pyflakes ; \ Line 89:else \ Line 90:echo "Warning: skipping check since tox is too old \ -- To view, visit https://gerrit.ovirt.org/59306 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Irit Goihman Gerrit-Reviewer: Edward Haas Gerrit-Reviewer: Irit Goihman Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: logstat: Print statistics from vdsm log
Nir Soffer has submitted this change and it was merged. Change subject: logstat: Print statistics from vdsm log .. logstat: Print statistics from vdsm log This tool print the size of the log data generated by each log level, logger, and location (logger:module:lineno). Sample output (trimmed): Levels 23831913 DEBUG 5283179 WARNING 5097252 INFO 38955 ERROR Loggers 5927768 storage.check 5356340 jsonrpc.JsonRpcServer 5281867 SchemaCache 4941607 Storage.Misc.excCmd 4886896 Storage.TaskManager.Task ... Locations 5281867 SchemaCache:vdsmapi:143(_report_inconsistency) 5163660 jsonrpc.JsonRpcServer:__init__:548(_serveRequest) 4352610 Storage.TaskManager.Task:task:1193(prepare) 4338316 dispatcher:logUtils:52(wrapper) 3838591 Storage.Misc.excCmd:lvm:292(cmd) ... Change-Id: I462756fc5688918aad3c42a2cbb1c33ffaffe14b Signed-off-by: Nir Soffer Reviewed-on: https://gerrit.ovirt.org/59019 Reviewed-by: Francesco Romani Reviewed-by: Piotr Kliczewski Continuous-Integration: Jenkins CI --- A contrib/logstat M tox.sh 2 files changed, 102 insertions(+), 0 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Nir Soffer: Verified; Looks good to me, approved Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/59019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I462756fc5688918aad3c42a2cbb1c33ffaffe14b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: logstat: Print statistics from vdsm log
gerrit-hooks has posted comments on this change. Change subject: logstat: Print statistics from vdsm log .. Patch Set 4: * Update tracker: IGNORE, no Bug-Url found * Set MODIFIED::IGNORE, no Bug-Url found. -- To view, visit https://gerrit.ovirt.org/59019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I462756fc5688918aad3c42a2cbb1c33ffaffe14b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: logstat: Print statistics from vdsm log
Nir Soffer has posted comments on this change. Change subject: logstat: Print statistics from vdsm log .. Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/59019 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I462756fc5688918aad3c42a2cbb1c33ffaffe14b Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer Gerrit-Reviewer: Adam Litke Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: stomp: simplified client
Nir Soffer has posted comments on this change.
Change subject: stomp: simplified client
..
Patch Set 3:
(4 comments)
https://gerrit.ovirt.org/#/c/59151/3/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 579
Line 580
Line 581
Line 582
Line 583
In another patch, it would be nice to use here concurrent.thread.
Line 591
Line 592
Line 593
Line 594
Line 595
Why do we need lazy_start? you disable it for the simple client - do we needed
it elsewhere?
Line 575: there is a need to customize please use StandAloneRpcClient().
Line 576: """
Line 577: sslctx = None
Line 578: if ssl:
Line 579: # we need to make sure to use std ssl module
The comment is not clear - is this a todo or this explains what we do in the
next line?
Line 580: from vdsm.sslutils import SSLContext
Line 581: key_file, cert_file, ca_certs = certutils.get_cert_paths(
Line 582: config.get('vars', 'trust_store_path')
Line 583: )
Line 582: config.get('vars', 'trust_store_path')
Line 583: )
Line 584: sslctx = SSLContext(key_file=key_file, cert_file=cert_file,
Line 585: ca_certs=ca_certs)
Line 586: return StandAloneRpcClient(host, port, "jms.topic.vdsm_requests",
Can you explain this parameter? Why do we need each part?
Line 587:str(uuid4()), sslctx, lazy_start=False)
Line 588:
Line 589:
Line 590: def StandAloneRpcClient(host, port, request_queue, response_queue,
--
To view, visit https://gerrit.ovirt.org/59151
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b9b33474e60ab349885a7de18eeacc8f648011f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: utils: build cert paths in single place
Nir Soffer has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 6: Please address my comments from version 4: https://gerrit.ovirt.org/#/c/52354/4..6/lib/vdsm/certutils.py,unified -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: utils: build cert paths in single place
Nir Soffer has posted comments on this change. Change subject: utils: build cert paths in single place .. Patch Set 4: (1 comment) https://gerrit.ovirt.org/#/c/52354/4/lib/vdsm/tool/configurators/certificates.py File lib/vdsm/tool/configurators/certificates.py: Line 30 Line 31 Line 32 Line 33 Line 34 These constants are just fine, not sure why do you want to replace them. Can you explain what is the issue? -- To view, visit https://gerrit.ovirt.org/52354 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58dd3a5f7c1503fc38b6c6a204c036c06d09941b Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: rpc: Log RPC call summary on info level
Nir Soffer has posted comments on this change.
Change subject: rpc: Log RPC call summary on info level
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/59080/7/lib/vdsm/rpc/bindingxmlrpc.py
File lib/vdsm/rpc/bindingxmlrpc.py:
Line 1276: except:
Line 1277: f.__self__.cif.log.error("unexpected error",
exc_info=True)
Line 1278: return errCode['unexpected']
Line 1279: finally:
Line 1280: f.__self__.cif.log.info("RPC call %s finished in %.2f
seconds",
> I don't mind making the change but whether it's jsonrpc or xmlrpc is clear
OK, lets go with RPC.
Line 1281: f.__name__,
Line 1282: utils.monotonic_time() -
start_time)
Line 1283: wrapper.__name__ = f.__name__
Line 1284: wrapper.__doc__ = f.__doc__
--
To view, visit https://gerrit.ovirt.org/59080
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idde2f1ba7394f16770543f5ca13411e8c2339cc6
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: api: Move after_get_all_vm_stats hook from API to clientIF
Nir Soffer has posted comments on this change. Change subject: api: Move after_get_all_vm_stats hook from API to clientIF .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/59393/1/vdsm/API.py File vdsm/API.py: Line 1339 Line 1340 Line 1341 Line 1342 Line 1343 > We can perhaps have the cake *and* eat it. We cannot leave the patch in the current state. Either we call both hooks here or in cif. I'm not happy about moving stuff to cif, another one of the bad parts of vdsm. Before we add more functionality there, we should fix the design - find a better name for this meaningless cif, implement it properly (getInstance with parameters?!). -- To view, visit https://gerrit.ovirt.org/59393 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf9cdf57e7fc4e72733b195acdd84a10602df7ca Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: rpc: Log important info from VM stats
Nir Soffer has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 19: (1 comment) https://gerrit.ovirt.org/#/c/58465/19/lib/vdsm/throttledlog.py File lib/vdsm/throttledlog.py: Line 39: self._timeout = timeout Line 40: self._counter = 0 Line 41: self._last_time = 0 Line 42: Line 43: def should_log(self): > I like letting the class doing its single job without messing with logging This class single job is to log stuff periodically. Line 44: now = monotonic_time() Line 45: result = self._should_log(now) Line 46: self._counter = (self._counter + 1) % self._interval Line 47: self._last_time = now -- To view, visit https://gerrit.ovirt.org/58465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcbac615323b62fb9a27e5c0f5a4e98990076146 Gerrit-PatchSet: 19 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: rpc: Log important info from VM stats
Nir Soffer has posted comments on this change. Change subject: rpc: Log important info from VM stats .. Patch Set 20: (4 comments) Please separate the throttledlog and its test to another patch. This is trivial backport that does not touch anything and make the rest of the patch easier to review. https://gerrit.ovirt.org/#/c/58465/20/lib/vdsm/throttledlog.py File lib/vdsm/throttledlog.py: Line 39: self._timeout = timeout Line 40: self._counter = 0 Line 41: self._last_time = 0 Line 42: Line 43: def should_log(self): I think we should log here, but lets go with your way and find better names - how about step() or tick() - both are clear about having a side effect. Line 44: now = monotonic_time() Line 45: result = self._should_log(now) Line 46: self._counter = (self._counter + 1) % self._interval Line 47: self._last_time = now Line 43: def should_log(self): Line 44: now = monotonic_time() Line 45: result = self._should_log(now) Line 46: self._counter = (self._counter + 1) % self._interval Line 47: self._last_time = now last_time should update only if result is True. We miss a test faking utils.monotonic_time. Line 48: return result Line 49: Line 50: def _should_log(self, now): Line 51: return (self._counter == 0 or Line 46: self._counter = (self._counter + 1) % self._interval Line 47: self._last_time = now Line 48: return result Line 49: Line 50: def _should_log(self, now): _result()? Line 51: return (self._counter == 0 or Line 52: (now - self._last_time) >= self._timeout) Line 53: Line 54: Line 100: else: Line 101: if not periodic.should_log(): Line 102: return Line 103: Line 104: _logger.log(level, message, *args) It would be nice to provide the standard loging methods (debug, info...). Possible implementation is: debug = functools.partial(log, level=logging.DEBUG) ... -- To view, visit https://gerrit.ovirt.org/58465 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifcbac615323b62fb9a27e5c0f5a4e98990076146 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Milan Zamazal Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Francesco Romani Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Milan Zamazal Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Piotr Kliczewski Gerrit-Reviewer: gerrit-hooks Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: rpc: Log important info from VM stats
Nir Soffer has posted comments on this change.
Change subject: rpc: Log important info from VM stats
..
Patch Set 20:
(2 comments)
https://gerrit.ovirt.org/#/c/58465/20/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 442
Line 443
Line 444
Line 445
Line 446
This is a good pattern for other verbs:
- We control what we log using wrappers
- We control when we log using throtteldlog
Line 89: if self.irs:
Line 90: self._contEIOVmsCB = partial(clientIF.contEIOVms,
proxy(self))
Line 91:
self.irs.registerDomainStateChangeCallback(self._contEIOVmsCB)
Line 92: self.log = log
Line 93: throttledlog.throttle('getAllVmStats', 40)
Better move this to _configure_logging() helper, this method is already too big.
Line 94: self._recovery = True
Line 95: self.channelListener = Listener(self.log)
Line 96: self.mom = None
Line 97: self.bindings = {}
--
To view, visit https://gerrit.ovirt.org/58465
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifcbac615323b62fb9a27e5c0f5a4e98990076146
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: rpc: Log also error codes of RPC calls
Nir Soffer has posted comments on this change.
Change subject: rpc: Log also error codes of RPC calls
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/59234/4/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 514: response_log = "succeeded"
Line 515: else:
Line 516: response_log = "failed (error %s)" % (error.code,)
Line 517: else:
Line 518: response_log = "without response"
> To me, it looks like a good idea.
So lets do this in the previous patch that added the info logs.
Line 519: self.log.info("RPC call %s %s in %.2f seconds",
Line 520: req.method, response_log, monotonic_time() -
start_time)
Line 521:
Line 522: def _do_serveRequest(self, ctx, req):
--
To view, visit https://gerrit.ovirt.org/59234
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I776e667fcfd1a20a9ef5f6c638d6c3d950672314
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal
Gerrit-Reviewer: Francesco Romani
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: Piotr Kliczewski
Gerrit-Reviewer: gerrit-hooks
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org
Change in vdsm[master]: storage: Add inplace virt-sparsify support
Nir Soffer has posted comments on this change.
Change subject: storage: Add inplace virt-sparsify support
..
Patch Set 5:
(18 comments)
https://gerrit.ovirt.org/#/c/57347/5/client/vdsClient.py
File client/vdsClient.py:
Line 1386: if status['status']['code']:
Line 1387: return status['status']['code'],
status['status']['message']
Line 1388: return 0, status['uuid']
Line 1389:
Line 1390: def sparsifyImageInplace(self, args):
Not needed, this client is deprecated.
Line 1391: (imgUUID, spUUID, sdUUID, volUUID) = args
Line 1392: status = self.s.sparsifyImageInplace(imgUUID, spUUID,
sdUUID, volUUID)
Line 1393: if status['status']['code']:
Line 1394: return status['status']['code'],
status['status']['message']
https://gerrit.ovirt.org/#/c/57347/5/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line 7734: type: *UUID
Line 7735:
Line 7736: Image.sparsifyInplace:
Line 7737: added: '4.1'
Line 7738: description: Perform an in-place sparse (e.g. not creating a new
image) on
in-place sparsify
Line 7739: given volume, removing unused space from the volume.
Line 7740: params:
Line 7741: - description: The UUID of the Image
Line 7742: name: imageID
https://gerrit.ovirt.org/#/c/57347/5/lib/vdsm/rpc/Bridge.py
File lib/vdsm/rpc/Bridge.py:
Line 358: 'Image_download': {'ret': 'uuid'},
Line 359: 'Image_mergeSnapshots': {'ret': 'uuid'},
Line 360: 'Image_move': {'ret': 'uuid'},
Line 361: 'Image_reconcileVolumeChain': {'ret': 'volumes'},
Line 362: 'Image_sparsifyInplace': {},
Piotr, is this really required for verbs without a return value?
Line 363: 'Image_syncData': {'ret': 'uuid'},
Line 364: 'Image_upload': {'ret': 'uuid'},
Line 365: 'Image_prepare': {'ret': Image_prepare_Ret},
Line 366: 'ISCSIConnection_discoverSendTargets': {'ret': 'fullTargets'},
https://gerrit.ovirt.org/#/c/57347/5/lib/vdsm/rpc/bindingxmlrpc.py
File lib/vdsm/rpc/bindingxmlrpc.py:
Line 762: return image.sparsify(tmpVolUUID, dstSdUUID, dstImgUUID,
dstVolUUID)
Line 763:
Line 764: def imageSparsifyInplace(self, imgUUID, spUUID, sdUUID, volUUID):
Line 765: image = API.Image(imgUUID, spUUID, sdUUID)
Line 766: return image.sparsifyInplace(volUUID)
xmlrpc is deprecated, we don't add any feature here. New features are available
only using jsonrpc.
Line 767:
Line 768: def imageCloneStructure(self, spUUID, sdUUID, imgUUID, dstSdUUID):
Line 769: image = API.Image(imgUUID, spUUID, sdUUID)
Line 770: return image.cloneStructure(dstSdUUID)
https://gerrit.ovirt.org/#/c/57347/5/lib/vdsm/virtsparsify.py
File lib/vdsm/virtsparsify.py:
Line 19
Line 20
Line 21
Line 22
Line 23
This the place for "from stdlib imports"
Line 1: #
Line 2: # Copyright 2016 Red Hat, Inc.
This should be 2014-2016
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
Line 18: # Refer to the README and COPYING files for full details of the license
Line 19: #
Line 20:
Line 21: from __future__ import absolute_import
Line 22: from contextlib import contextmanager
contextmanager is an exception, you can keep this import as is, but put it
under the stdlib modules imports.
Line 23: import logging
Line 24: import signal
Line 25: from uuid import uuid4
Line 26:
Line 21: from __future__ import absolute_import
Line 22: from contextlib import contextmanager
Line 23: import logging
Line 24: import signal
Line 25: from uuid import uuid4
Don't import functions from modules. Import uuid and use uuid.uuid4()
Line 26:
Line 27: from . import cmdutils
Line 28: from . import commands
Line 29: from . import concurrent
Line 62: if rc != 0:
Line 63: raise cmdutils.Error(cmd, rc, out, err)
Line 64:
Line 65:
Line 66: def sparsifyInplace(imgUUID, sdUUID, spUUID, volUUID, irs):
New vdsm code should use lower_case style. sparsify_inplace looks right.
Use img_uuid, sd_uuid, ...
Line 67: """
Line 68: Sparsify the volume in place
Line 69: (without copying from an input disk to an output disk)
Line 70: """
Line 69: (without copying from an input disk to an output disk)
Line 70: """
Line 71: job = SparsifyJob(imgUUID, sdUUID, spUUID, volUUID, irs)
Line 72: job.start()
Line 73: jobs.add(job)
This should be the wrapper calling virt-sparsify - like the old code above.
Line 74:
Line 75:
Line 76: def delete_sparsify_job(job_id):
Line 77: return jobs.delete(job_id)
Line 73: jobs.add(job)
Line 74:
Line 75:
Line 76: def delete_sparsify_job(job_id):
Line 77: return jobs.delete(job_id)
We don't need to delete this job, it should be deleted automatically after the
job finish. You can use the sched
