Change in vdsm[master]: vm: Remove useless volume size monitoring

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: vm: Remove useless volume size monitoring
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59801
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1436c2968f3e408ce38a913c6ca3146a25a312d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt net: Support VM migration on OVS based networks

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: virt net: Support VM migration on OVS based networks
..


Patch Set 5: Code-Review-1

(10 comments)

https://gerrit.ovirt.org/#/c/59645/2//COMMIT_MSG
Commit Message:

PS2, Line 10: betweeni
between


PS2, Line 12: king
kind


https://gerrit.ovirt.org/#/c/59645/5//COMMIT_MSG
Commit Message:

PS5, Line 10: betweeni
between


PS5, Line 12: king
kind


https://gerrit.ovirt.org/#/c/59645/5/vdsm/virt/vm_migrate_hook.py
File vdsm/virt/vm_migrate_hook.py:

Line 27: from vdsm.config import config
Line 28: from vdsm.network import api as net_api
Line 29: 
Line 30: 
Line 31: _DEBUG_MODE = False
this is used only once. would not be better to use just kwarg?
Line 32: LOG_FILE = '/tmp/libvirthook_ovs_migrate.log'
Line 33: 
Line 34: 
Line 35: def main(domain, event, phase, *args, **kwargs):


Line 37: sys.exit(0)
Line 38: 
Line 39: with _logging(_DEBUG_MODE) as log:
Line 40: if log:
Line 41: print('Hook input args are: ', domain, event, phase, 
file=log)
what about args and kwargs? you use them, you should log them.
Line 42: 
Line 43: stdin = kwargs.get('stdin', sys.stdin)
Line 44: 
Line 45: tree = ET.parse(stdin)


PS5, Line 130: target_vm_info
i'd use targed_vm_info or target_vm_conf everywhere in the script


Line 133: return
Line 134: 
Line 135: graphics_listen = graphics.find('listen')
Line 136: 
Line 137: target_display_network = target_vm_info['displayNetwork']
so, just to be sure, we still use displayNetwork, even with displayIp?
Line 138: 
Line 139: if net_api.ovs_bridge(target_display_network):
Line 140: graphics_listen.set('type', 'address')
Line 141: graphics_listen.set('address', target_vm_info['displayIp'])


PS5, Line 155: ","
single quotes single quotes!!


PS5, Line 161: w
why not 'a'?


-- 
To view, visit https://gerrit.ovirt.org/59645
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7d32f9605f9ca99d1e07062108f2567806ac59c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm.conf: Add drop-in dir

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm.conf: Add drop-in dir
..


Patch Set 1: Code-Review-1

Please rebase on https://gerrit.ovirt.org/#/c/59802

Merging the current patch without the previous one may break libvirt and tool 
tests.

-- 
To view, visit https://gerrit.ovirt.org/59858
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3849829aca50b30742e9c860d7c19296d6361015
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg.py: Don't check -T support

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: qemuimg.py: Don't check -T support
..


Patch Set 3: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/55926
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4ac5f44b2788b76a49440330033dfc5faea0831
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg.py: Don't check compat support

[amureini]

Allon Mureinik has posted comments on this change.

Change subject: qemuimg.py: Don't check compat support
..


Patch Set 3: Verified+1

The CI failure, while consistent, doesn't seem relevant:

20:44:13 testGetDeviceByIP   
FAIL

-- 
To view, visit https://gerrit.ovirt.org/55925
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie141ac33f60b340b7f12832e4fb6b92ea6a68289
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm.conf: Add drop-in dir

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: vdsm.conf: Add drop-in dir
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59858
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3849829aca50b30742e9c860d7c19296d6361015
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg.py: Don't check -T support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg.py: Don't check -T support
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/55926
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4ac5f44b2788b76a49440330033dfc5faea0831
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg.py: Don't check compat support

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg.py: Don't check compat support
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/55925
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie141ac33f60b340b7f12832e4fb6b92ea6a68289
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3 tests: ported network/config_network_test.py to python3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: py3 tests: ported network/config_network_test.py to python3
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff4a2eceaddcd1982887f84f2a1f01d6579530c7
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: usage of single reactor in vdsm

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: migration: usage of single reactor in vdsm
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/59720/4//COMMIT_MSG
Commit Message:

Line 7: migration: usage of single reactor in vdsm
Line 8: 
Line 9: In most of the cases for each standalone client there is reactor but
Line 10: we want to share one in vdsm. There are already too many threads in 
vdsm
Line 11: so it is not desired to add more.
> Lets update to reflect the behavior in the current version  of the patch.
Done
Line 12: 
Line 13: 
Line 14: Backport-To: 4.0
Line 15: Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d


https://gerrit.ovirt.org/#/c/59720/4/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 464: def server(self):
Line 465: return self._server
Line 466: 
Line 467: def createClient(self, connected_socket, owns_reactor=False):
Line 468: return StompClient(connected_socket, self._reactor, 
owns_reactor)
> This should use kwargs call style - owns_reactor=owns_reactor.
Done
Line 469: 
Line 470: def process_requests(self):
Line 471: self._reactor.process_requests()
Line 472: 


-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm.spec: change 'make check' to 'make unittest'

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: vdsm.spec: change 'make check' to 'make unittest'
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/59417/3/Makefile.am
File Makefile.am:

Line 105
Line 106
Line 107
Line 108
Line 109
> This target should depend on unittests.
renaming the target doesn't prevent the recursive call for make check in 
subdirs. if i add unittest the tests will run twice


-- 
To view, visit https://gerrit.ovirt.org/59417
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3 tests: ported network/config_network_test.py to python3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: py3 tests: ported network/config_network_test.py to python3
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff4a2eceaddcd1982887f84f2a1f01d6579530c7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: removing txRate and rxRate from code

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: removing txRate and rxRate from code
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6466de88f0228ac3496b4642d34f5eb7b281afa
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Refactor verify_untrusted_volume

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Refactor verify_untrusted_volume
..


Patch Set 5:

* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
* Check Product::#1344289::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59409
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90c06286c5e0b85c3b190026882b937fdb38266e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Use --output json for 'check' and 'info'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Use --output json for 'check' and 'info'
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5db4fab6434246e7f1789ae8e438a0024b862f85
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Report qcow2 compat version

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Report qcow2 compat version
..


Patch Set 5:

* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
* Check Product::#1344289::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91ee8ee96bdc3a230463987f857fd7e88c629b6a
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: verify_untrusted_volume: Check compatibility version

[automation]

gerrit-hooks has posted comments on this change.

Change subject: verify_untrusted_volume: Check compatibility version
..


Patch Set 6:

* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
* Check Product::#1344289::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59411
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib2d5609340ba3bbe00f81d0cde727eb75c94ebec
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Introduce supports_compat helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: qemuimg: Introduce supports_compat helper
..


Patch Set 6:

* #1344289::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1344289::OK, public bug
* Check Product::#1344289::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59410
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I341b4559d5d10709fa93b722572cf7f0a8f953ff
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3 tests: ported imagetickets_test.py to python3

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: py3 tests: ported imagetickets_test.py to python3
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/59859/2/vdsm/storage/imagetickets.py
File vdsm/storage/imagetickets.py:

Line 26
Line 27
Line 28
Line 29
Line 30
> This module is not available yet on python3, so this module cannot work on 
I tried :) I will abandon this patch. this change is very small and can be done 
again


-- 
To view, visit https://gerrit.ovirt.org/59859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If13fb30966d98fa0381da25f0f2907899df12e96
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3 tests: ported network/conf_test.py to python3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: py3 tests: ported network/conf_test.py to python3
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59860
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iff4a2eceaddcd1982887f84f2a1f01d6579530c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3 tests: ported network/conf_test.py to python3

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: py3 tests: ported network/conf_test.py to python3
..

py3 tests: ported network/conf_test.py to python3

ported relevant code to python3 in order that
network/conf_test.py will be python3 compatible.

Change-Id: Iff4a2eceaddcd1982887f84f2a1f01d6579530c7
Signed-off-by: Irit Goihman 
---
M lib/vdsm/network/legacy_switch.py
M lib/vdsm/network/netinfo/cache.py
M tests/Makefile.am
3 files changed, 10 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/59860/1

diff --git a/lib/vdsm/network/legacy_switch.py 
b/lib/vdsm/network/legacy_switch.py
index c58450d..97d5f0d 100644
--- a/lib/vdsm/network/legacy_switch.py
+++ b/lib/vdsm/network/legacy_switch.py
@@ -438,7 +438,7 @@
 # special case as it is handled automatically by the os)
 def _bridge_only_config(conf):
 return dict(
-(k, v) for k, v in conf.iteritems()
+(k, v) for k, v in six.iteritems(conf)
 if k not in ('bonding', 'nic', 'mtu', 'vlan'))
 
 def _bridge_reconfigured(current_net_conf, required_net_conf):
@@ -457,7 +457,7 @@
 # We need to use the newest host info
 _netinfo.updateDevices()
 
-for network, attrs in networks.iteritems():
+for network, attrs in six.iteritems(networks):
 if 'remove' in attrs:
 continue
 
@@ -612,14 +612,14 @@
 
 
 def validate_network_setup(networks, bondings):
-for network, networkAttrs in networks.iteritems():
+for network, networkAttrs in six.iteritems(networks):
 if networkAttrs.get('remove', False):
 _validate_network_remove(networkAttrs)
 elif 'vlan' in networkAttrs:
 Vlan.validateTag(networkAttrs['vlan'])
 
 currentNicsSet = set(netinfo_nics.nics())
-for bonding, bondingAttrs in bondings.iteritems():
+for bonding, bondingAttrs in six.iteritems(bondings):
 Bond.validateName(bonding)
 if 'options' in bondingAttrs:
 Bond.validateOptions(bondingAttrs['options'])
diff --git a/lib/vdsm/network/netinfo/cache.py 
b/lib/vdsm/network/netinfo/cache.py
index 0a6bd6c..b4027a6 100644
--- a/lib/vdsm/network/netinfo/cache.py
+++ b/lib/vdsm/network/netinfo/cache.py
@@ -124,7 +124,7 @@
 ipAddrs = getIpAddrs()
 
 d = {}
-for net, netAttr in nets.iteritems():
+for net, netAttr in six.iteritems(nets):
 try:
 # Pass the iface if the net is _not_ bridged, the bridge otherwise
 d[net] = _getNetInfo(netAttr.get('iface', net), netAttr['bridged'],
@@ -230,7 +230,7 @@
 
 def _getBridgedNetworksAndVlansForIface(self, iface):
 """ Returns tuples of (bridge, vlan) connected to nic/bond """
-for network, netdict in self.networks.iteritems():
+for network, netdict in six.iteritems(self.networks):
 if netdict['bridged']:
 for interface in netdict['ports']:
 if iface == interface:
@@ -240,7 +240,7 @@
 
 def _getBridgelessNetworksAndVlansForIface(self, iface):
 """ Returns tuples of (network, vlan) connected to nic/bond """
-for network, netdict in self.networks.iteritems():
+for network, netdict in six.iteritems(self.networks):
 if not netdict['bridged']:
 if iface == netdict['iface']:
 yield (network, None)
@@ -254,14 +254,14 @@
 
 def getNetworkForIface(self, iface):
 """ Return the network attached to nic/bond """
-for network, netdict in self.networks.iteritems():
+for network, netdict in six.iteritems(self.networks):
 if ('ports' in netdict and iface in netdict['ports'] or
 'iface' in netdict and iface == netdict['iface']):
 return network
 
 def getBridgedNetworkForIface(self, iface):
 """ Return all bridged networks attached to nic/bond """
-for bridge, netdict in self.networks.iteritems():
+for bridge, netdict in six.iteritems(self.networks):
 if netdict['bridged'] and iface in netdict['ports']:
 return bridge
 
@@ -270,7 +270,7 @@
 return bondAttrs['slaves']
 
 def getBondingForNic(self, nic):
-bondings = [b for (b, attrs) in self.bondings.iteritems() if
+bondings = [b for (b, attrs) in six.iteritems(self.bondings) if
 nic in attrs['slaves']]
 if bondings:
 assert len(bondings) == 1, \
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 352f5be..0fcbcb4 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -190,7 +190,6 @@
monkeypatchTests.py \
mountTests.py \
network/conf_persistence_test.py \
-   network/conf_test.py \
network/config_network_test.py \
network/hook_ovs_test.py \
network/iproute2_test.py \


-- 
To 

Change in vdsm[master]: py3 tests: ported imagetickets_test.py to python3

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: py3 tests: ported imagetickets_test.py to python3
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/59859/2/vdsm/storage/imagetickets.py
File vdsm/storage/imagetickets.py:

Line 26
Line 27
Line 28
Line 29
Line 30
This module is not available yet on python3, so this module cannot work on 
python 3.

The tests pass since they monkeypatch the missing uhttp. So we can have this 
test in python3, but the actual coe will always fail with 
ImageDaemonUnsupported, not very useful.

Better to keep the tests blacklisted so we remember that this does not work yet.


-- 
To view, visit https://gerrit.ovirt.org/59859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If13fb30966d98fa0381da25f0f2907899df12e96
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3 tests: ported imagetickets_test.py to python3

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: py3 tests: ported imagetickets_test.py to python3
..


Patch Set 2:

(1 comment)

Looks good, actually too good to be true. I believe the actual code will fail 
in python 3 :-)

https://gerrit.ovirt.org/#/c/59859/2/tests/imagetickets_test.py
File tests/imagetickets_test.py:

Line 37
Line 38
Line 39
Line 40
Line 41
This works, but I think that in python3 response.read() returns bytes object, 
not string. So this test works now in python3, but the real code will probably 
fail.

Can you test what is returned in python3 and fix the test to return same types?


-- 
To view, visit https://gerrit.ovirt.org/59859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If13fb30966d98fa0381da25f0f2907899df12e96
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3 tests: ported imagetickets_test.py to python3

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: py3 tests: ported imagetickets_test.py to python3
..


Patch Set 2: Verified+1

test passes on jenkins

-- 
To view, visit https://gerrit.ovirt.org/59859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If13fb30966d98fa0381da25f0f2907899df12e96
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: removing txRate and rxRate from code

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: removing txRate and rxRate from code
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6466de88f0228ac3496b4642d34f5eb7b281afa
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: usage of single reactor in vdsm

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: migration: usage of single reactor in vdsm
..


Patch Set 4:

Needs to update commit message and fix argument call style, otherwise looks 
good.

-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: usage of single reactor in vdsm

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: migration: usage of single reactor in vdsm
..


Patch Set 4:

(2 comments)

https://gerrit.ovirt.org/#/c/59720/4//COMMIT_MSG
Commit Message:

Line 7: migration: usage of single reactor in vdsm
Line 8: 
Line 9: In most of the cases for each standalone client there is reactor but
Line 10: we want to share one in vdsm. There are already too many threads in 
vdsm
Line 11: so it is not desired to add more.
Lets update to reflect the behavior in the current version  of the patch.

I think it is important to explain that by default StompClient owns its client 
to simplify user code and prevent leaks. More sophisticated users creating a 
client from StompReactor, sharing the same reactor by many clients can use a 
flag to mark the reactor as shared.
Line 12: 
Line 13: 
Line 14: Backport-To: 4.0
Line 15: Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d


https://gerrit.ovirt.org/#/c/59720/4/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:

Line 464: def server(self):
Line 465: return self._server
Line 466: 
Line 467: def createClient(self, connected_socket, owns_reactor=False):
Line 468: return StompClient(connected_socket, self._reactor, 
owns_reactor)
This should use kwargs call style - owns_reactor=owns_reactor.
Line 469: 
Line 470: def process_requests(self):
Line 471: self._reactor.process_requests()
Line 472: 


-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3 tests: ported imagetickets_test.py to python3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: py3 tests: ported imagetickets_test.py to python3
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If13fb30966d98fa0381da25f0f2907899df12e96
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3 tests: ported imagetickets_test.py to python3

[igoihman]

Irit Goihman has uploaded a new change for review.

Change subject: py3 tests: ported imagetickets_test.py to python3
..

py3 tests: ported imagetickets_test.py to python3

ported relevant code to python3 in order that imagetickets_test.py
will be python3 compatible.

Change-Id: If13fb30966d98fa0381da25f0f2907899df12e96
Signed-off-by: Irit Goihman 
---
M tests/Makefile.am
M tests/imagetickets_test.py
M vdsm/storage/imagetickets.py
3 files changed, 6 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/59/59859/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 352f5be..16119bd 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -179,7 +179,6 @@
hooksTests.py \
hostdevTests.py \
hoststatsTests.py \
-   imagetickets_test.py \
iscsiTests.py \
lvmTests.py \
main.py \
diff --git a/tests/imagetickets_test.py b/tests/imagetickets_test.py
index 39a2800..f2ea111 100644
--- a/tests/imagetickets_test.py
+++ b/tests/imagetickets_test.py
@@ -18,15 +18,17 @@
 # Refer to the README and COPYING files for full details of the license
 #
 
-import httplib
 import json
 import socket
 import io
+
+from six.moves import http_client
 
 from monkeypatch import MonkeyPatch
 from testlib import VdsmTestCase
 from testlib import expandPermutations, permutations
 from testlib import recorded
+
 
 from vdsm.storage import exception as se
 from storage import imagetickets
@@ -158,7 +160,7 @@
 self.assertTrue(err_msg in e.value)
 
 @MonkeyPatch(imagetickets, 'uhttp', FakeUHTTP())
-@permutations([[httplib.HTTPException], [socket.error], [OSError]])
+@permutations([[http_client.HTTPException], [socket.error], [OSError]])
 def test_image_tickets_error(self, exc_type):
 ticket = create_ticket(uuid="uuid")
 
diff --git a/vdsm/storage/imagetickets.py b/vdsm/storage/imagetickets.py
index 281a0e9..476f249 100644
--- a/vdsm/storage/imagetickets.py
+++ b/vdsm/storage/imagetickets.py
@@ -19,12 +19,12 @@
 #
 
 import functools
-import httplib
 import json
 import logging
 import os
 
 from contextlib import closing
+from six.moves import http_client
 
 try:
 from ovirt_imageio_daemon import uhttp
@@ -74,7 +74,7 @@
 try:
 con.request(method, "/tickets/%s" % uuid, body=body)
 res = con.getresponse()
-except (httplib.HTTPException, EnvironmentError) as e:
+except (http_client.HTTPException, EnvironmentError) as e:
 raise se.ImageTicketsError("Error communicating with "
"ovirt-imageio-daemon: "
"{error}".format(error=e))


-- 
To view, visit https://gerrit.ovirt.org/59859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If13fb30966d98fa0381da25f0f2907899df12e96
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: py3 tests: ported imagetickets_test.py to python3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: py3 tests: ported imagetickets_test.py to python3
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59859
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If13fb30966d98fa0381da25f0f2907899df12e96
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: usage of single reactor in vdsm

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: migration: usage of single reactor in vdsm
..


Patch Set 4:

As Nir suggested let's do not add too many threads to vdsm there are already 
too many.

-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: usage of single reactor in vdsm

[automation]

gerrit-hooks has posted comments on this change.

Change subject: migration: usage of single reactor in vdsm
..


Patch Set 4:

* #1349461::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1349461::OK, public bug
* Check Product::#1349461::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: stomp: Close reactor only if client owns it

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: stomp: Close reactor only if client owns it
..


Patch Set 1:

I updated the original patch with suggested here approach. We do not need this 
patch anymore.

-- 
To view, visit https://gerrit.ovirt.org/59855
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a0d4225263d0fb1667041def9497168cf8f20bf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Use --output json for 'check' and 'info'

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: qemuimg: Use --output json for 'check' and 'info'
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/59649/3/tests/qemuimgTests.py
File tests/qemuimgTests.py:

Line 65: @expandPermutations
Line 66: class InfoTests(TestCaseBase):
Line 67: CLUSTER_SIZE = 65536
Line 68: 
Line 69: def _data(self):
> Renamed to _fake_info.  It's not output.  It's a data representation of the
Sounds good.
Line 70: return {
Line 71: "virtual-size": 1048576,
Line 72: "filename": "leaf.img",
Line 73: "cluster-size": self.CLUSTER_SIZE,


-- 
To view, visit https://gerrit.ovirt.org/59649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5db4fab6434246e7f1789ae8e438a0024b862f85
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Refactor verify_untrusted_volume

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Refactor verify_untrusted_volume
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/59409/1/lib/vdsm/storage/misc.py
File lib/vdsm/storage/misc.py:

Line 781: """Used to mark exported methods as deprecated"""
Line 782: return f
Line 783: 
Line 784: 
Line 785: def verify_untrusted_volume(path, meta_format):
> I'd like to get this simple feature done in less than 2 months.  I've alrea
I also like to get this quickly, but I don't want to add code to misc.py, we 
have enough crap there.

This was approved for hsm.py, why move it? If you don't find a better place, 
keep the code in hsm.py.

To test HSM methods, you can create a subclass, override __init__ to avoid the 
unwanted effects and set what must be set for your test, and call the method.

This will give us better test that cover the entire verb instead of only the 
trivial method that you moved to misc.py. Such test will not have to be 
modified when we change the implementation (e.g. move the verb to another 
module).

For example, look at vmTests.py:TestingVm.
Line 786: qemu_info = qemuimg.info(path)
Line 787: qemu_format = qemu_info["format"]
Line 788: 
Line 789: if meta_format != qemu_format:


-- 
To view, visit https://gerrit.ovirt.org/59409
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90c06286c5e0b85c3b190026882b937fdb38266e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt net: Change graphics type from network to address

[edwardh]

Edward Haas has posted comments on this change.

Change subject: virt net: Change graphics type from network to address
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/59336/8/vdsm/virt/vmdevices/graphics.py
File vdsm/virt/vmdevices/graphics.py:

PS8, Line 252: net
> why this rename?
So it will look pretty, otherwise it will fall into two lines, adding '('...
We also did used nets, so renaming network to net seems reasonable and 
consistent.


-- 
To view, visit https://gerrit.ovirt.org/59336
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0724627bd6c37ce11f943c8818fcd5b559fdf070
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm.conf: Add drop-in dir

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm.conf: Add drop-in dir
..


Patch Set 1:

* #1279555::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1279555::OK, public bug
* Check Product::#1279555::OK, Correct classification oVirt
* Check TM::#1279555::OK, correct target milestone ovirt-4.0.1
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/59858
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3849829aca50b30742e9c860d7c19296d6361015
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: vdsm.conf: Add drop-in dir

[igoihman]

Hello Piotr Kliczewski, Nir Soffer, Yaniv Bronhaim,

I'd like you to do a code review.  Please visit

https://gerrit.ovirt.org/59858

to review the following change.

Change subject: vdsm.conf: Add drop-in dir
..

vdsm.conf: Add drop-in dir

A drop-in dir allows the user to put partial configurations
into a drop-in directory.
This will allow to either set the configuration or override
already set configurations using the partical configuration files.

Change-Id: I3849829aca50b30742e9c860d7c19296d6361015
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1279555
Signed-off-by: Irit Goihman 
Reviewed-on: https://gerrit.ovirt.org/58728
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Nir Soffer 
Reviewed-by: Piotr Kliczewski 
---
M lib/vdsm/config.py.in
M tests/Makefile.am
A tests/config_test.py
M vdsm.spec.in
M vdsm/Makefile.am
5 files changed, 223 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/58/59858/1

diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index 6b5156d..fad2ab3 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -1,5 +1,5 @@
 #
-# Copyright 2011-2013 Red Hat, Inc.
+# Copyright 2011-2016 Red Hat, Inc.
 #
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -17,11 +17,35 @@
 #
 # Refer to the README and COPYING files for full details of the license
 #
+"""
+This module creates vdsm configuration from a default vdsm configuration file
+under /etc/vdsm/vdsm.conf. It reads conf files from drop-in dirs and updates
+the configuration according to the files.
+
+The semantics of the directories and the search order is as follows:
+
+- /etc/vdsm/vdsm.conf - for user configuration. We install this
+  file if missing, and never touch this file during upgrade.
+- /etc/vdsm/vdsm.conf.d/ - for admin drop-in conf files.
+- /usr/lib/vdsm/vdsm.conf.d/ - for vendor drop-in configuration files.
+- /var/run/vdsm/vdsm.conf.d/ - for admin temporary configuration.
+
+Files with a .conf suffix can be placed into any of the vdsm.conf.d drop-in
+directories.
+
+The priority of the configuration files is determined by the number prefix of
+each file.
+"""
 
 from __future__ import absolute_import
 import os
 from six.moves import configparser
 import textwrap
+import glob
+
+_SYSCONFDIR = '@sysconfdir@'
+_DROPPIN_BASES = ("/usr/lib/", "/run/", _SYSCONFDIR)
+
 
 parameters = [
 # Section: [vars]
@@ -501,9 +525,39 @@
 print(twp.fill("%s = %s" % (key, value)))
 print('')
 
-config = configparser.ConfigParser()
-set_defaults(config)
-config.read([os.path.join('@CONFDIR@', 'vdsm.conf')])
+
+def load(name):
+cfg = configparser.ConfigParser()
+set_defaults(cfg)
+read_configs(cfg, name)
+return cfg
+
+
+def read_configs(cfg, name):
+"""This function is reading config files in a specific scheme
+
+The function reads - for one component - config files from several
+locations and in addition it is also reading configuration snippets
+from drop-in directories.
+This scheme allows to store the vendor provided (default) configuration
+in a different directory, and override it using either defaults from
+other packages which can then be put into the vendor drop-in dir,
+or users can overwrite the defaults, by placing a complete or partial
+configuration file into /etc or a drop-in directory.
+"""
+default_conf = os.path.join(_SYSCONFDIR, name, name + '.conf')
+cfg.read(default_conf)
+
+dropins = []
+for path in _DROPPIN_BASES:
+pattern = os.path.join(path, name, name + '.conf.d', '*.conf')
+dropins.extend(glob.glob(pattern))
+
+dropins.sort(key=os.path.basename)
+cfg.read(dropins)
+
+
+config = load('vdsm')
 
 if __name__ == '__main__':
 print_config()
diff --git a/tests/Makefile.am b/tests/Makefile.am
index 59ff6e1..6dac859 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -50,6 +50,7 @@
cmdutilsTests.py \
commands_test.py \
concurrentTests.py \
+   config_test.py \
cpuinfo_test.py \
cpuProfileTests.py \
deviceTests.py \
diff --git a/tests/config_test.py b/tests/config_test.py
new file mode 100644
index 000..207afbc
--- /dev/null
+++ b/tests/config_test.py
@@ -0,0 +1,152 @@
+# Copyright 2016 Red Hat, Inc.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# 

Change in vdsm[master]: net tests: link_test must not depend on functional

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net tests: link_test must not depend on functional
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/59841/1/tests/network/link_test.py
File tests/network/link_test.py:

PS1, Line 33: _
Do we really need to make these 'private'?
It looks weird to me.


-- 
To view, visit https://gerrit.ovirt.org/59841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I183ff35ea44d042766bde069082310c7d168f084
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: test: Introduce mock module for testing

[edwardh]

Edward Haas has posted comments on this change.

Change subject: test: Introduce mock module for testing
..


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/59797/1//COMMIT_MSG
Commit Message:

PS1, Line 13: reverts
> Why do we want to revert?
We introduced the mock, then it was reverted and now we want to revert the 
revert.


https://gerrit.ovirt.org/#/c/59797/1/automation/check-patch.packages.fc23
File automation/check-patch.packages.fc23:

Line 14: python-coverage
Line 15: python-devel
Line 16: python-inotify
Line 17: python-ioprocess
Line 18: python-mock
> why don't we have it in check-merged.packages?
We should... Done
Line 19: python-netaddr
Line 20: python-nose
Line 21: python-pthreading
Line 22: python-six


-- 
To view, visit https://gerrit.ovirt.org/59797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72edd0a9388f11d905cfbd7d2fac5a95e1212cea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm.spec: change 'make check' to 'make unittest'

[edwardh]

Edward Haas has posted comments on this change.

Change subject: vdsm.spec: change 'make check' to 'make unittest'
..


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/59417/2//COMMIT_MSG
Commit Message:

Line 10: using tox.
Line 11: not all machines support tox and there are some issues
Line 12: running tox without network.
Line 13: separating style validation from tests enables creating an rpm
Line 14: without style.
> make check can be equal to make unittests, as it runs recursively check-loc
How about this:
check: check-style check-tests ...
check-style: pep8 pyflakes
check-tests: check-unit check-integration

I am also in favor of dropping the recursive built-in check and instead 
explicitly call the relevant sub-directory.

Having overlapping targets is also not recommend, I would prefer to see each 
with its own target and an aggregated target. The disadvantage is that the 
test-run is separated by types (unless we can build an args variable per 
target?).

If we can avoid flags, it will be cleaner IMO.
Line 15: 
Line 16: Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571


https://gerrit.ovirt.org/#/c/59417/3/Makefile.am
File Makefile.am:

PS3, Line 127: unittest
tests includes all kind of tests, not only unit tests.
How about naming the target as 'tests'?


-- 
To view, visit https://gerrit.ovirt.org/59417
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: use reactor per connection

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: migration: use reactor per connection
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/59720/3//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: migration: use reactor per connection
Line 8: 
Line 9: We need to make sure that reactor is not reused between incoming and
Line 10: outgoing connections.
> Here is an untested draft implementing my suggestion - please check.
I reviewed your suggestion and I think that it is not enough to fix the issue.

On one hand we want to simplify client code as much as possible but on the 
other hand we want to expose this detail to the user. Majority of the clients 
would have their on reactors. Only internal to vdsm clients could share the 
reactor. If I wanted to introduce "own_reactor" I would provide default as 
True. Having this option could confuse users.

I agree that closing reactor which is used by others is an error so to make it 
simile we make all the clients to own one.
Line 11: 
Line 12: 
Line 13: Backport-To: 4.0
Line 14: Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d


-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: stomp: Close reactor only if client owns it

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: stomp: Close reactor only if client owns it
..


Patch Set 1: Code-Review-1

This patch is problematic for jsonrpcvdscli where we create reactor each time. 
If we want to fix this we need to make sure that we fix everywhere not only in 
stompreactor module.

-- 
To view, visit https://gerrit.ovirt.org/59855
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a0d4225263d0fb1667041def9497168cf8f20bf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: use reactor per connection

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: migration: use reactor per connection
..


Patch Set 3: Code-Review-1

This change looks wrong, we don't need new reactor for each migration. The 
client should be fixed not to close a reactor it does not own.

-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: use reactor per connection

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: migration: use reactor per connection
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/59720/3//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: migration: use reactor per connection
Line 8: 
Line 9: We need to make sure that reactor is not reused between incoming and
Line 10: outgoing connections.
> Ok, so the issue using a shared reactor, or your own reactor. The client sh
Here is an untested draft implementing my suggestion - please check.
https://gerrit.ovirt.org/59855
Line 11: 
Line 12: 
Line 13: Backport-To: 4.0
Line 14: Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d


-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: stomp: Close reactor only if client owns it

[automation]

gerrit-hooks has posted comments on this change.

Change subject: stomp: Close reactor only if client owns it
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59855
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3a0d4225263d0fb1667041def9497168cf8f20bf
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Report qcow2 compat version

[alitke]

Adam Litke has posted comments on this change.

Change subject: qemuimg: Report qcow2 compat version
..


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/59408/4/tests/qemuimgTests.py
File tests/qemuimgTests.py:

Line 98: self.assertEqual(leaf_fmt, info['format'])
Line 99: self.assertEqual(size, info['virtualsize'])
Line 100: self.assertEqual(self.CLUSTER_SIZE, info['clustersize'])
Line 101: self.assertEqual(base_path, info['backingfile'])
Line 102: self.assertEqual(qemuimg._qcow2_compat(), info['compat'])
> _qcow2_compat is private, don't depend on it. I would mock the config inste
Done
Line 103: 
Line 104: def test_parse_error(self):
Line 105: def call(cmd, **kw):
Line 106: out = "image: leaf.img\ninvalid file format line"


-- 
To view, visit https://gerrit.ovirt.org/59408
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I91ee8ee96bdc3a230463987f857fd7e88c629b6a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: qemuimg: Use --output json for 'check' and 'info'

[alitke]

Adam Litke has posted comments on this change.

Change subject: qemuimg: Use --output json for 'check' and 'info'
..


Patch Set 3:

(4 comments)

https://gerrit.ovirt.org/#/c/59649/3/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:

Line 59: return "ecode=%s, stdout=%s, stderr=%s, message=%s" % (
Line 60: self.ecode, self.stdout, self.stderr, self.message)
Line 61: 
Line 62: 
Line 63: def parse_qemuimg_json(output):
> This looks like a private helper, lets rename it and move it to the bottom.
Done
Line 64: obj = json.loads(output)
Line 65: if not isinstance(obj, dict):
Line 66: raise ValueError("not a JSON object")
Line 67: return obj


https://gerrit.ovirt.org/#/c/59649/3/tests/qemuimgTests.py
File tests/qemuimgTests.py:

Line 38: return 0, json.dumps(data), []
Line 39: 
Line 40: 
Line 41: @expandPermutations
Line 42: class GeneralTests(TestCaseBase):
> I would not add tests for this code, this is a private helper without any i
ok.  Removed these tests.
Line 43: 
Line 44: def test_parse_qemuimg_json(self):
Line 45: output = '{"a": 1}'
Line 46: self.assertEqual({"a": 1}, qemuimg.parse_qemuimg_json(output))


Line 65: @expandPermutations
Line 66: class InfoTests(TestCaseBase):
Line 67: CLUSTER_SIZE = 65536
Line 68: 
Line 69: def _data(self):
> _data is little to generic, how about _fake_output?
Renamed to _fake_info.  It's not output.  It's a data representation of the 
info that will be returned.  Implemented this way so the tests can modify it 
simply.
Line 70: return {
Line 71: "virtual-size": 1048576,
Line 72: "filename": "leaf.img",
Line 73: "cluster-size": self.CLUSTER_SIZE,


Line 361: 
Line 362: 
Line 363: class CheckTests(TestCaseBase):
Line 364: 
Line 365: def _data(self):
> _data is little to generic, how about _fake_output?
same as above.
Line 366: return {
Line 367: "image-end-offset": 262144,
Line 368: "total-clusters": 16,
Line 369: "check-errors": 0,


-- 
To view, visit https://gerrit.ovirt.org/59649
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5db4fab6434246e7f1789ae8e438a0024b862f85
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: use reactor per connection

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: migration: use reactor per connection
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/59720/3//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: migration: use reactor per connection
Line 8: 
Line 9: We need to make sure that reactor is not reused between incoming and
Line 10: outgoing connections.
> when close on a client (outgoing connection) is called we close reactor as 
Ok, so the issue using a shared reactor, or your own reactor. The client should 
close the reactor only if it owns the reactor.

We should have a own_reactor in the client, set to True only when you create a 
standalone client without a reactor.

Closing the reactor that you don't own is an error.
Line 11: 
Line 12: 
Line 13: Backport-To: 4.0
Line 14: Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d


-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: use reactor per connection

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: migration: use reactor per connection
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/59720/3//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: migration: use reactor per connection
Line 8: 
Line 9: We need to make sure that reactor is not reused between incoming and
Line 10: outgoing connections.
> Why?
when close on a client (outgoing connection) is called we close reactor as 
well. This behavior would stop acceptor's reactor and for all the other clients.
Line 11: 
Line 12: 
Line 13: Backport-To: 4.0
Line 14: Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d


-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: use reactor per connection

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: migration: use reactor per connection
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/59720/3//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: migration: use reactor per connection
Line 8: 
Line 9: We need to make sure that reactor is not reused between incoming and
Line 10: outgoing connections.
Why?

I don't any reason why reactor should care about type of connections, but maybe 
we have a problem with the design.
Line 11: 
Line 12: 
Line 13: Backport-To: 4.0
Line 14: Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d


-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: use reactor per connection

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: migration: use reactor per connection
..


Patch Set 3:

I don't think CI have such a case. Would need to be done manually I suppose. 
And the leak verification - Francesco, Milan or Nir  could surely help

-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm.spec: change 'make check' to 'make unittest'

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm.spec: change 'make check' to 'make unittest'
..


Patch Set 3:

(5 comments)

https://gerrit.ovirt.org/#/c/59417/3//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2016-06-18 21:30:59 +0300
Line 4: Commit: Irit Goihman 
Line 5: CommitDate: 2016-06-27 16:52:11 +0300
Line 6: 
Line 7: vdsm.spec: change 'make check' to 'make unittest'
We are not replacing make check, but adding a new target that it depend on.
Line 8: 
Line 9: during vdsm rpm check 'make check' is running style validation
Line 10: using tox.
Line 11: not all machines support tox and there are some issues


https://gerrit.ovirt.org/#/c/59417/3/Makefile.am
File Makefile.am:

Line 105
Line 106
Line 107
Line 108
Line 109
This target should depend on unittests.

Since we don't need recursive checks, we can rename it to "check". Hopefully it 
will override autoconf recursive check.


Line 88:if [ -n "$(TOX)" ]; then \
Line 89:tox -- pyflakes; \
Line 90:else \
Line 91:echo "Warning: tox is not installed, skipping 
check"; \
Line 92:fi \
Not related to adding the new target.
Line 93:fi
Line 94: 
Line 95: .PHONY: pep8
Line 96: pep8:


Line 100:   if [ -n "$(TOX)" ]; then \
Line 101:   tox -- pep8; \
Line 102:   else \
Line 103:   echo "Warning: tox is not installed, skipping 
check"; \
Line 104:   fi \
Not related to adding the new target.
Line 105:   fi
Line 106: 
Line 107: .PHONY: python3
Line 108: python3: all


Line 125:   $(MAKE) -C tests/ check args='-a type=unit'
Line 126: 
Line 127: .PHONY: unittest
Line 128: unittest:
Line 129:   $(MAKE) -C tests/ check
Looks fine if we can override check in this makefile so it does not run 
recursive check on all directories.
Line 130: 
Line 131: all-local: \
Line 132:   vdsm.spec
Line 133: 


-- 
To view, visit https://gerrit.ovirt.org/59417
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: virt: Correct disconnectAction parameter extraction

[vfeenstr]

Vinzenz Feenstra has posted comments on this change.

Change subject: virt: Correct disconnectAction parameter extraction
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/59842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1695a56d3f7e68f8f9b8d2a929775edc4570985
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: test: Introduce mock module for testing

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: test: Introduce mock module for testing
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/59797/1/automation/check-patch.packages.fc23
File automation/check-patch.packages.fc23:

Line 14: python-coverage
Line 15: python-devel
Line 16: python-inotify
Line 17: python-ioprocess
Line 18: python-mock
why don't we have it in check-merged.packages?
Line 19: python-netaddr
Line 20: python-nose
Line 21: python-pthreading
Line 22: python-six


-- 
To view, visit https://gerrit.ovirt.org/59797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72edd0a9388f11d905cfbd7d2fac5a95e1212cea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm.spec: change 'make check' to 'make unittest'

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: vdsm.spec: change 'make check' to 'make unittest'
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/59417/2//COMMIT_MSG
Commit Message:

Line 10: variable that disables tox run.
Line 11: This option is useful for developers who encounter issues running tox
Line 12: on their environment and want to skip tox style validation.
Line 13: use it by the following:
Line 14: make check DISABLE_STYLE_VALIDATION=1
> make check can be equal to make unittests, as it runs recursively check-loc
make unitest is *not* equal to make check. It will run the unittests in tests/, 
nothing else.
Line 15: 
Line 16: Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571


-- 
To view, visit https://gerrit.ovirt.org/59417
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: virt: Correct disconnectAction parameter extraction

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Correct disconnectAction parameter extraction
..


Patch Set 1:

* #1349383::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1349383::OK, public bug
* Check Product::#1349383::OK, Correct classification oVirt
* Check TM::#1349383::OK, correct target milestone ovirt-4.0.1
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/59842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1695a56d3f7e68f8f9b8d2a929775edc4570985
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: virt: Correct disconnectAction parameter extraction

[vfeenstr]

Vinzenz Feenstra has uploaded a new change for review.

Change subject: virt: Correct disconnectAction parameter extraction
..

virt: Correct disconnectAction parameter extraction

The disconnectAction has previously never been passed to the
_setTicketForGraphicDev method. This patch fixes this oversight.

Backport-To: 4.0
Bug-Url: https://bugzilla.redhat.com/1349383
Change-Id: Ia1695a56d3f7e68f8f9b8d2a929775edc4570985
Signed-off-by: Vinzenz Feenstra 
Reviewed-on: https://gerrit.ovirt.org/59692
Reviewed-by: Milan Zamazal 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
(cherry picked from commit 7c6905edf642574de44261afbb979bc5fb3ef1a2)
---
M vdsm/virt/vm.py
1 file changed, 7 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/59842/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 0fe722e..b040902 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -2417,7 +2417,8 @@
 if graphics:
 result = self._setTicketForGraphicDev(
 graphics, params['password'], params['ttl'],
-params.get('existingConnAction'), params['params'])
+params.get('existingConnAction'),
+params.get('disconnectAction'), params['params'])
 if result['status']['code'] == 0:
 result['vmList'] = self.status()
 return result
@@ -3930,9 +3931,10 @@
 return response.error('ticketErr',
   'no graphics devices configured')
 return self._setTicketForGraphicDev(
-graphics, otp, seconds, connAct, params)
+graphics, otp, seconds, connAct, None, params)
 
-def _setTicketForGraphicDev(self, graphics, otp, seconds, connAct, params):
+def _setTicketForGraphicDev(self, graphics, otp, seconds, connAct,
+disconnectAction, params):
 graphics.setAttribute('passwd', otp.value)
 if int(seconds) > 0:
 validto = time.strftime('%Y-%m-%dT%H:%M:%S',
@@ -3943,9 +3945,8 @@
 hooks.before_vm_set_ticket(self._domain.xml, self.conf, params)
 try:
 self._dom.updateDeviceFlags(graphics.toxml(), 0)
-disconnectAction = params.get('disconnectAction',
-  ConsoleDisconnectAction.LOCK_SCREEN)
-self._consoleDisconnectAction = disconnectAction
+self._consoleDisconnectAction = disconnectAction or \
+ConsoleDisconnectAction.LOCK_SCREEN
 except virdomain.TimeoutError as tmo:
 res = response.error('ticketErr', unicode(tmo))
 else:


-- 
To view, visit https://gerrit.ovirt.org/59842
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia1695a56d3f7e68f8f9b8d2a929775edc4570985
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Vinzenz Feenstra 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: link_test must not depend on functional

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: link_test must not depend on functional
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I183ff35ea44d042766bde069082310c7d168f084
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: net tests: link_test must not depend on functional

[danken]

Dan Kenigsberg has uploaded a new change for review.

Change subject: net tests: link_test must not depend on functional
..

net tests: link_test must not depend on functional

Before this patch, link_test imported functional/networkTests just for
importing a throw-away IP address and CIDR.

Change-Id: I183ff35ea44d042766bde069082310c7d168f084
Signed-off-by: Dan Kenigsberg 
---
M tests/network/link_test.py
1 file changed, 7 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/59841/1

diff --git a/tests/network/link_test.py b/tests/network/link_test.py
index e17a01b..647aa5b 100644
--- a/tests/network/link_test.py
+++ b/tests/network/link_test.py
@@ -22,7 +22,6 @@
 from collections import deque
 import time
 
-from functional.networkTests import IP_ADDRESS, IP_CIDR
 from .nettestlib import Dummy
 from vdsm.network.netlink import monitor
 from vdsm.sysctl import is_disabled_ipv6
@@ -30,6 +29,9 @@
 
 from testValidation import ValidateRunningAsRoot
 from testlib import start_thread, VdsmTestCase as TestCaseBase
+
+_IP_ADDRESS = '192.0.2.1'
+_IP_CIDR = '24'
 
 
 class NetlinkEventMonitorTests(TestCaseBase):
@@ -85,7 +87,7 @@
  groups=('link', 'ipv4-route')) as mon_l_r:
 dummy = Dummy()
 dummy.create()
-dummy.set_ip(IP_ADDRESS, IP_CIDR)
+dummy.set_ip(_IP_ADDRESS, _IP_CIDR)
 dummy.up()
 dummy.remove()
 
@@ -147,11 +149,12 @@
  silent_timeout=True) as mon:
 dummy = Dummy()
 dummy_name = dummy.create()
-dummy.set_ip(IP_ADDRESS, IP_CIDR)
+dummy.set_ip(_IP_ADDRESS, _IP_CIDR)
 dummy.up()
 dummy.remove()
 
-expected_events = _expected_events(dummy_name, IP_ADDRESS, IP_CIDR)
+expected_events = _expected_events(
+dummy_name, _IP_ADDRESS, _IP_CIDR)
 _expected = list(expected_events)
 _caught = []
 


-- 
To view, visit https://gerrit.ovirt.org/59841
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I183ff35ea44d042766bde069082310c7d168f084
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Refactor verify_untrusted_volume

[alitke]

Adam Litke has posted comments on this change.

Change subject: Refactor verify_untrusted_volume
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/59409/1/lib/vdsm/storage/misc.py
File lib/vdsm/storage/misc.py:

Line 781: """Used to mark exported methods as deprecated"""
Line 782: return f
Line 783: 
Line 784: 
Line 785: def verify_untrusted_volume(path, meta_format):
> The best would be to move the entire verb out of hsm into a new module abou
I'd like to get this simple feature done in less than 2 months.  I've already 
expanded scope once (to start using json format).  Since the verb was already 
approved in hsm.py let's keep everything this way for now.  If you want to get 
rid of misc.py then let's see a separate patch set because there is already a 
lot of other stuff here.
Line 786: qemu_info = qemuimg.info(path)
Line 787: qemu_format = qemu_info["format"]
Line 788: 
Line 789: if meta_format != qemu_format:


-- 
To view, visit https://gerrit.ovirt.org/59409
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I90c06286c5e0b85c3b190026882b937fdb38266e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Amit Aviram 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: use reactor per connection

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: migration: use reactor per connection
..


Patch Set 3:

Michal so how do you want to have it verified? Any specific use case to be 
covered? Can it by done by env provisioned by CI?

-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm: removing txRate and rxRate from code

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm: removing txRate and rxRate from code
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59544
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id6466de88f0228ac3496b4642d34f5eb7b281afa
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: use reactor per connection

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: migration: use reactor per connection
..


Patch Set 3:

This is an urgent patch, if we don't manage to do that in time for 4.0.1 we 
should proceed with extra verification anyway, but let's try at least...

-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: use reactor per connection

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: migration: use reactor per connection
..


Patch Set 3: Verified-1

Can we doublecheck there is no resource leak, similar to how we chased leaks 
not so long ago. Nir added some helper code for that, right?

We should also check parallel migrations, that wasn't part of verification on 
Friday, unfortunately

-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 5: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Correct disconnectAction parameter extraction

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Correct disconnectAction parameter extraction
..


Patch Set 4:

* #1349383::Update tracker: OK
* Set MODIFIED::bug 1349383#1349383OK

-- 
To view, visit https://gerrit.ovirt.org/59692
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1695a56d3f7e68f8f9b8d2a929775edc4570985
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Fix README for scratchpad VDSM hook

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: Fix README for scratchpad VDSM hook
..


Fix README for scratchpad VDSM hook

The separator for multiple disks is ':', not ','

Change-Id: Id65c2d54e28066b6bce3b17d1b61df0a11bc5912
Signed-off-by: yk...@redhat.com
Reviewed-on: https://gerrit.ovirt.org/58582
Continuous-Integration: Jenkins CI
Reviewed-by: Eyal Edri 
Reviewed-by: Dan Kenigsberg 
---
M vdsm_hooks/scratchpad/README
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Eyal Edri: Looks good to me, but someone else must approve
  Yaniv Kaul: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/58582
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id65c2d54e28066b6bce3b17d1b61df0a11bc5912
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Kaul 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Correct disconnectAction parameter extraction

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: Correct disconnectAction parameter extraction
..


virt: Correct disconnectAction parameter extraction

The disconnectAction has previously never been passed to the
_setTicketForGraphicDev method. This patch fixes this oversight.

Backport-To: 4.0
Bug-Url: https://bugzilla.redhat.com/1349383
Change-Id: Ia1695a56d3f7e68f8f9b8d2a929775edc4570985
Signed-off-by: Vinzenz Feenstra 
Reviewed-on: https://gerrit.ovirt.org/59692
Reviewed-by: Milan Zamazal 
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani 
---
M vdsm/virt/vm.py
1 file changed, 7 insertions(+), 6 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Vinzenz Feenstra: Verified
  Francesco Romani: Looks good to me, approved
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/59692
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia1695a56d3f7e68f8f9b8d2a929775edc4570985
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Fix README for scratchpad VDSM hook

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Fix README for scratchpad VDSM hook
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/58582
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id65c2d54e28066b6bce3b17d1b61df0a11bc5912
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Kaul 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Fix README for scratchpad VDSM hook

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: Fix README for scratchpad VDSM hook
..


Patch Set 2: Code-Review+2

raising

-- 
To view, visit https://gerrit.ovirt.org/58582
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id65c2d54e28066b6bce3b17d1b61df0a11bc5912
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Kaul 
Gerrit-Reviewer: Anton Marchukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: command: Store stdout and stderr to a log file

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: command: Store stdout and stderr to a log file
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/59833/1/tests/commands_test.py
File tests/commands_test.py:

Line 98: errLog=errLog)
Line 99: self.assertEquals(rc, 0)
Line 100: checklog()
Line 101: 
Line 102: # Async: wait
Is this the rigt place fot the async tests? There are also test classes 
AsyncProcTests (in miscTests.py) and AsyncProcessOperationTests (in 
utilsTests.py). But I'm not sure if they are more appropriate for this.
Line 103: p = commands.execCmd(cmd(('bash', '-c', command)),
Line 104:  sync=False,
Line 105:  outLog=outLog,
Line 106:  errLog=errLog)


-- 
To view, visit https://gerrit.ovirt.org/59833
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a8b9afaa196729c8ab98f380a39833a9a0840cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: Remove useless volume size monitoring

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: Remove useless volume size monitoring
..


Patch Set 1: Code-Review+1

Not that I completely understand everything here, but I can't see any obvious 
error.

-- 
To view, visit https://gerrit.ovirt.org/59801
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1436c2968f3e408ce38a913c6ca3146a25a312d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: Fix README for scratchpad VDSM hook

[eedri]

Eyal Edri has posted comments on this change.

Change subject: Fix README for scratchpad VDSM hook
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/58582
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id65c2d54e28066b6bce3b17d1b61df0a11bc5912
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Kaul 
Gerrit-Reviewer: Anton Marchukov 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Eyal Edri 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

[automation]

gerrit-hooks has posted comments on this change.

Change subject: v2v: Log detailed output of virt-v2v
..


Patch Set 1:

* #1350465::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1350465::OK, public bug
* Check Product::#1350465::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59834
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: command: Store stdout and stderr to a log file

[automation]

gerrit-hooks has posted comments on this change.

Change subject: command: Store stdout and stderr to a log file
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59833
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5a8b9afaa196729c8ab98f380a39833a9a0840cd
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: v2v: Log detailed output of virt-v2v

[Tomas Golembiovsky]

Tomas Golembiovsky has uploaded a new change for review.

Change subject: v2v: Log detailed output of virt-v2v
..

v2v: Log detailed output of virt-v2v

The detailed log virt-v2v output is often necessary to debug conversion
failures. We provide '-v -x' arguments to virt-v2v to get the detailed
output and store the logs in the VDSM run directory.

Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Bug-Url: https://bugzilla.redhat.com/1350465
Signed-off-by: Tomáš Golembiovský 
---
M lib/vdsm/v2v.py
M tests/fake-virt-v2v
2 files changed, 63 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/59834/1

diff --git a/lib/vdsm/v2v.py b/lib/vdsm/v2v.py
index defbe14..0948741 100644
--- a/lib/vdsm/v2v.py
+++ b/lib/vdsm/v2v.py
@@ -384,6 +384,7 @@
 self._irs = irs
 self._prepared_volumes = []
 self._passwd_file = os.path.join(_V2V_DIR, "%s.tmp" % vmid)
+self._base_command = [_VIRT_V2V.cmd, '-v', '-x']
 
 def execute(self):
 raise NotImplementedError("Subclass must implement this")
@@ -394,7 +395,10 @@
deathSignal=signal.SIGTERM,
nice=NICENESS.HIGH,
ioclass=IOCLASS.IDLE,
-   env=self._environment())
+   env=self._environment(),
+   outLog=os.path.join(_V2V_DIR,
+   "%s.log" % self._vmid),
+   errToOutLog=True)
 
 def _get_disk_format(self):
 fmt = self._vminfo.get('format', 'raw').lower()
@@ -490,11 +494,11 @@
 self._password = password
 
 def _command(self):
-cmd = [_VIRT_V2V.cmd,
-   '-ic', self._uri,
-   '-o', 'vdsm',
-   '-of', self._get_disk_format(),
-   '-oa', self._vminfo.get('allocation', 'sparse').lower()]
+cmd = self._base_command
+cmd.extend(['-ic', self._uri,
+'-o', 'vdsm',
+'-of', self._get_disk_format(),
+'-oa', self._vminfo.get('allocation', 'sparse').lower()])
 cmd.extend(self._disk_parameters())
 cmd.extend(['--password-file',
 self._passwd_file,
@@ -521,19 +525,19 @@
 self._ova_path = ova_path
 
 def _command(self):
-cmd = [_VIRT_V2V.cmd,
-   '-i', 'ova', self._ova_path,
-   '-o', 'vdsm',
-   '-of', self._get_disk_format(),
-   '-oa', self._vminfo.get('allocation', 'sparse').lower(),
-   '--vdsm-vm-uuid',
-   self._vmid,
-   '--vdsm-ovf-output',
-   _V2V_DIR,
-   '--machine-readable',
-   '-os',
-   self._get_storage_domain_path(
-   self._prepared_volumes[0]['path'])]
+cmd = self._base_command
+cmd.extend(['-i', 'ova', self._ova_path,
+'-o', 'vdsm',
+'-of', self._get_disk_format(),
+'-oa', self._vminfo.get('allocation', 'sparse').lower(),
+'--vdsm-vm-uuid',
+self._vmid,
+'--vdsm-ovf-output',
+_V2V_DIR,
+'--machine-readable',
+'-os',
+self._get_storage_domain_path(
+self._prepared_volumes[0]['path'])])
 cmd.extend(self._disk_parameters())
 return cmd
 
@@ -559,11 +563,11 @@
 self._ssh_agent = SSHAgent()
 
 def _command(self):
-cmd = [_VIRT_V2V.cmd,
-   '-ic', self._uri,
-   '-o', 'vdsm',
-   '-of', self._get_disk_format(),
-   '-oa', self._vminfo.get('allocation', 'sparse').lower()]
+cmd = self._base_command
+cmd.extend(['-ic', self._uri,
+'-o', 'vdsm',
+'-of', self._get_disk_format(),
+'-oa', self._vminfo.get('allocation', 'sparse').lower()])
 cmd.extend(self._disk_parameters())
 cmd.extend(['--vdsm-vm-uuid',
 self._vmid,
@@ -782,7 +786,8 @@
  description)
 for chunk in self._iter_progress(stream):
 progress = self._parse_progress(chunk)
-yield DiskProgress(progress)
+if progress is not None:
+yield DiskProgress(progress)
 if progress == 100:
 break
 
@@ -807,8 +812,7 @@
 def _parse_progress(self, chunk):
 m = self.DISK_PROGRESS_RE.match(chunk)
 if m is None:
-raise OutputParserError('error parsing progress, chunk: %r'
-% chunk)
+return None
 try:
 return int(m.group(1))
 

Change in vdsm[master]: command: Store stdout and stderr to a log file

[Tomas Golembiovsky]

Tomas Golembiovsky has uploaded a new change for review.

Change subject: command: Store stdout and stderr to a log file
..

command: Store stdout and stderr to a log file

Method execCmd() can be used to execute arbitrary command and return
stdout and stderr either as a string, or provide wrapper streams to the
file descriptors in case of asynchronous execution.

This change adds the possibility to store the stdout and stderr to a log
file independently of the execution method used (synchronous or
asynchronous). Redirecting both stdout and stderr into a single file is
also possible for asynchronous processesing.

Change-Id: I5a8b9afaa196729c8ab98f380a39833a9a0840cd
Signed-off-by: Tomáš Golembiovský 
---
M lib/vdsm/commands.py
M tests/commands_test.py
2 files changed, 128 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/33/59833/1

diff --git a/lib/vdsm/commands.py b/lib/vdsm/commands.py
index bffec83..de96097 100644
--- a/lib/vdsm/commands.py
+++ b/lib/vdsm/commands.py
@@ -43,7 +43,8 @@
 def execCmd(command, sudo=False, cwd=None, data=None, raw=False,
 printable=None, env=None, sync=True, nice=None, ioclass=None,
 ioclassdata=None, setsid=False, execCmdLogger=logging.root,
-deathSignal=0, resetCpuAffinity=True):
+deathSignal=0, resetCpuAffinity=True, outLog=None, errLog=None,
+errToOutLog=False):
 """
 Executes an external command, optionally via sudo.
 
@@ -52,6 +53,14 @@
 a temporary thread, spawn a sync=False sub-process, and have the thread
 finish, the new subprocess would die immediately.
 """
+if errToOutLog and sync:
+# Using errToOutLog together with sync makes not much sense. Since we
+# do not get messages as they come, all we can do is write all the
+# stderr after all the stdout.
+if outLog is None:
+outLog = errLog
+else:
+errLog = outLog
 
 command = cmdutils.wrap_command(command, with_ioclass=ioclass,
 ioclassdata=ioclassdata, with_nice=nice,
@@ -70,7 +79,8 @@
 p = CPopen(command, close_fds=True, cwd=cwd, env=env,
deathSignal=deathSignal)
 if not sync:
-p = AsyncProc(p)
+p = AsyncProc(p, outLog=outLog, errLog=errLog,
+  errToOutLog=errToOutLog)
 if data is not None:
 p.stdin.write(data)
 p.stdin.flush()
@@ -85,6 +95,24 @@
 out = ""
 
 execCmdLogger.debug(cmdutils.retcode_log_line(p.returncode, err=err))
+
+# Dump stdout
+try:
+if outLog is not None:
+with open(outLog, 'w') as f:
+f.write(out)
+except IOError:
+execCmdLogger.exception(
+"Failed to dump stdout to log file '%s'" % outLog)
+
+# Dump stderr
+try:
+if errLog is not None:
+with open(errLog, 'w') as f:
+f.write(err)
+except IOError:
+execCmdLogger.exception(
+"Failed to dump stderr to log file '%s'" % errLog)
 
 if not raw:
 out = out.splitlines(False)
@@ -192,10 +220,15 @@
 
 return len(data)
 
-def __init__(self, popenToWrap):
+def __init__(self, popenToWrap, outLog=None, errLog=None,
+ errToOutLog=False):
 # this is an ugly hack to let this module load on Python 3, and fail
 # later when AsyncProc is used.
 from StringIO import StringIO
+
+if errToOutLog and outLog is None:
+outLog = errLog
+errLog = None
 
 self._streamLock = threading.Lock()
 self._proc = popenToWrap
@@ -227,6 +260,32 @@
 self.stdin = io.BufferedWriter(self._streamWrapper(self,
self._stdin, self._fdin), BUFFSIZE)
 
+if outLog is None:
+self._outLog = None
+else:
+try:
+self._outLog = open(outLog, 'w')
+except IOError:
+logging.exception(
+"Failed to open stdout log file '%s'" % outLog)
+self._outLog = None
+
+if errToOutLog:
+self._errLog = self._outLog
+elif errLog is not None:
+try:
+self._errLog = open(errLog, 'w')
+except IOError:
+logging.exception(
+"Failed to open stderr log file '%s'" % errLog)
+self._errLog = None
+else:
+self._errLog = None
+
+self._fdMapLog = {fdout: self._outLog,
+  fderr: self._errLog,
+  self._fdin: None}
+
 self._returncode = None
 
 self.blocking = False
@@ -249,6 +308,8 @@
 
 for fd, event in pollres:
 stream = self._fdMap[fd]
+log = 

Change in vdsm[master]: hostdev: move usb device code to separate class

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: move usb device code to separate class
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/57958
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I481a966776089f37971a27637e06d21eafabd05c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: cleanup udev files after PCI host devices

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: cleanup udev files after PCI host devices
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59042
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8af3f4d359768f7857e5f8b2fe6c5f89a5037a51
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: improve robustness of libvirt SCSI access

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: improve robustness of libvirt SCSI access
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58011
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0e9983fd309869ebd8a4aacd8bfe42158cd26e64
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: move pci device code to separate class

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: move pci device code to separate class
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/57956
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6bceb93c2434ff827406bbf4ee0af30f5726f6af
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Betak 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: use specific device classes in HostDevice

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: use specific device classes in HostDevice
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/57963
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2734b7ec789c0ce57b64d7699cbe967c774bb608
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hostdev: move scsi device code to separate class

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hostdev: move scsi device code to separate class
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/57960
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I784c158192433bba1ea4dd330f8a633024b9fec2
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vm: Introduce drive monitoring concept

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: vm: Introduce drive monitoring concept
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia082f8bef03735c63b66e6b6c574e527bf6cafb4
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: tox: fail make process if required tox version isn't installed.

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: tox: fail make process if required tox version isn't installed.
..


Patch Set 13:

(1 comment)

https://gerrit.ovirt.org/#/c/59306/13/build-aux/vercmp
File build-aux/vercmp:

Line 38: logging.debug("{} == {}".format(actual_version, 
required_version))
Line 39: sys.exit(1)
Line 40: else:
Line 41: logging.debug("{} > {}".format(actual_version, 
required_version))
Line 42: sys.exit(2)
> you're right but I need to return the value to shell script and the two pos
We can return a value here, and exit with this value in main.
Line 43: 
Line 44: 
Line 45: def parse_args():
Line 46: parser = argparse.ArgumentParser(description='compare actual 
version to '


-- 
To view, visit https://gerrit.ovirt.org/59306
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I665025dacdd5346a5e021ac98e864f7b6461917c
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: periodic: Avoid useless drive monitoring

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: periodic: Avoid useless drive monitoring
..


Patch Set 2: Code-Review+1

(1 comment)

Looks like a good idea to me.

https://gerrit.ovirt.org/#/c/59764/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS2, Line 1003: retruns
... returns ...


-- 
To view, visit https://gerrit.ovirt.org/59764
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I274acc2112cd9b55ac1867d850401be8911adf29
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: vdsm.spec: change 'make check' to 'make unittest'

[automation]

gerrit-hooks has posted comments on this change.

Change subject: vdsm.spec: change 'make check' to 'make unittest'
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59417
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: hooks: openstack hook should wait a while for nic activation

[automation]

gerrit-hooks has posted comments on this change.

Change subject: hooks: openstack hook should wait a while for nic activation
..


Patch Set 5:

* #1314371::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1314371::OK, public bug
* Check Product::#1314371::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/58917
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4f455789909f090a039863fdcfeb61b9db1042f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: test: Introduce mock module for testing

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: test: Introduce mock module for testing
..


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/59797/1//COMMIT_MSG
Commit Message:

PS1, Line 13: reverts
Why do we want to revert?


-- 
To view, visit https://gerrit.ovirt.org/59797
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72edd0a9388f11d905cfbd7d2fac5a95e1212cea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: client: use representation object

[Jenkins CI]

Jenkins CI has posted comments on this change.

Change subject: client: use representation object
..


Patch Set 2: Continuous-Integration+1

Propagate review hook: Continuous Integration value inherited from patch 1

-- 
To view, visit https://gerrit.ovirt.org/59827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3492c104e726867dd75488a475202789277e8914
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Correct disconnectAction parameter extraction

[fromani]

Francesco Romani has posted comments on this change.

Change subject: virt: Correct disconnectAction parameter extraction
..


Patch Set 3: Code-Review+2

raising score

-- 
To view, visit https://gerrit.ovirt.org/59692
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1695a56d3f7e68f8f9b8d2a929775edc4570985
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Vinzenz Feenstra 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: migration: use reactor per connection

[fromani]

Francesco Romani has posted comments on this change.

Change subject: migration: use reactor per connection
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/59720/3/vdsm/clientIF.py
File vdsm/clientIF.py:

PS3, Line 454: thread.start()
> Thread dies when client is closed either by calling close or by GC.
ok, thanks.


-- 
To view, visit https://gerrit.ovirt.org/59720
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I06e21151e3e9f9e7da9e178bb0199c07f269ae8d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Peřina 
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: client: use representation object

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: client: use representation object
..


Patch Set 2: Verified+1

Verified that together with https://gerrit.ovirt.org/#/c/59720/3 migrations 
work for me on master again.

-- 
To view, visit https://gerrit.ovirt.org/59827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3492c104e726867dd75488a475202789277e8914
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: client: use representation object

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: client: use representation object
..


Patch Set 2:

No, we haven't backported the changes yet. I will fix it while backporting.

-- 
To view, visit https://gerrit.ovirt.org/59827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3492c104e726867dd75488a475202789277e8914
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: client: use representation object

[mzamazal]

Milan Zamazal has posted comments on this change.

Change subject: client: use representation object
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3492c104e726867dd75488a475202789277e8914
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: client: use representation object

[oourfali]

Oved Ourfali has posted comments on this change.

Change subject: client: use representation object
..


Patch Set 2:

is it for 4.0 as well?

-- 
To view, visit https://gerrit.ovirt.org/59827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3492c104e726867dd75488a475202789277e8914
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: virt: Add info about the number of run tasks in executor wor...

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: virt: Add info about the number of run tasks in executor workers
..


Patch Set 6: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/59048
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id5175f6d7d004bec97f604036ceb3f1662277224
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: lvm: Use global_filter instead of filter

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: lvm: Use global_filter instead of filter
..


Patch Set 7:

I think I think it would be better to consume lvm from  
https://bugzilla.redhat.com/show_bug.cgi?id=1346172 instead

-- 
To view, visit https://gerrit.ovirt.org/58943
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87b97e9fc52c3d6d507c21af536658ab528c0ce8
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org

Change in vdsm[master]: client: use representation object

[automation]

gerrit-hooks has posted comments on this change.

Change subject: client: use representation object
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59827
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3492c104e726867dd75488a475202789277e8914
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/admin/lists/vdsm-patches@lists.fedorahosted.org