Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: edit bond detached from bridge but still attached to a vlan
..


Patch Set 15: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: edit bond detached from bridge but still attached to a vlan
..


Patch Set 15: Verified+1

Just renamed test class.

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: edit bond detached from bridge but still attached to a vlan
..


Patch Set 15:

* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::OK, public bug
* Check Product::#1372798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net test: shared nic between bond and network

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: shared nic between bond and network
..


Patch Set 4:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice4ead640d45d0717d2a30bd01398cbbfff3f88a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-3.6]: spec: Require ioprocess 0.15.2

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: spec: Require ioprocess 0.15.2
..


Patch Set 1: Verified+1

The package is available now, we can merge this.

-- 
To view, visit https://gerrit.ovirt.org/63038
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia1fba8f5bfb84e9ff60478e36a09f1690ca6989a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.6
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Remove volume run link after live merge

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Live Merge: Remove volume run link after live merge
..


Patch Set 10:

(1 comment)

https://gerrit.ovirt.org/#/c/59725/10/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:

Line 821: """
Line 822: volRunlink = os.path.join(constants.P_VDSM_STORAGE,
Line 823:   self.sdUUID, imgUUID, volUUID)
Line 824: try:
Line 825: self.log.info("Unlinking volme runtime link: %r", 
volRunLink)
> Which comment? I thought I addressed all comments
The comment about this log line.
Line 826: os.unlink(volRunLink)
Line 827: except OSError as e:
Line 828: if e.error != errno.ENOENT:
Line 829: raise


-- 
To view, visit https://gerrit.ovirt.org/59725
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Teardown volume on HSM after live merge

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Live Merge: Teardown volume on HSM after live merge
..


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/64301/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4764:self.drive.imageID, baseVolUUID,
Line 4765:topVolInfo['capacity'])
Line 4766: 
Line 4767: def teardown_top_volume(self):
Line 4768: # TODO move this method to storage public API
> This needs to happen before we can merge.  We can't have code like this in 
The plan is to backport this to 4.0, where it is ok to add these dependencies. 
Nobody is going to break vdsm to multiple processes in 4.0 :-)

In master I expect to see a patch adding a proper storage api soon.
Line 4769: sd_manifest = 
sdc.sdCache.produce_manifest(self.drive.domainID)
Line 4770: sd_manifest.teardownVolume(self.drive.imageID,
Line 4771:self.job['topVolume'])
Line 4772: 


Line 4787: # not part of the chain.  Now, we want to teardown the top 
volume. Note
Line 4788: # that if volume deactivation fails, we don't want to fail 
the megre
Line 4789: # whole operation as the VM is running without issues.  It 
is worth to
Line 4790: # note that if volume deactivation fails, chances are high 
that the
Line 4791: # environment is severely damaged.
I do want to the operation to fail, we cannot continue to use this environment.
Line 4792: self.teardown_top_volume()
Line 4793: 
Line 4794: def isSuccessful(self):
Line 4795: """


-- 
To view, visit https://gerrit.ovirt.org/64301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce VolumeManifest.datapath_session

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Introduce VolumeManifest.datapath_session
..


Patch Set 1: Code-Review-1

(8 comments)

https://gerrit.ovirt.org/#/c/64362/1//COMMIT_MSG
Commit Message:

Line 17: incrementation when exiting successfully which will also allow engine 
to
Line 18: determine if an operation was completed successfully.
Line 19: 
Line 20: All metadata updates must be performed to a single block with one write
Line 21: in order to ensure atomicity.
Maybe separate the new context manger and its tests from the usage of this 
infrastructure?
Line 22: 
Line 23: Change-Id: I30a3ac2971411778d24e007aac9fcb3009edb4c4


https://gerrit.ovirt.org/#/c/64362/1/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 231: source = dict(endpoint_type='div', sd_id=src_vol.sdUUID,
Line 232:   img_id=src_vol.imgUUID, 
vol_id=src_vol.volUUID)
Line 233: dest = dict(endpoint_type='div', sd_id=dst_vol.sdUUID,
Line 234: img_id=dst_vol.imgUUID, 
vol_id=dst_vol.volUUID)
Line 235: self.assertEqual(sc.LEGAL_VOL, src_vol.getLegality())
We don't need this assert, since we don't except any change in the source 
volume.
Line 236: self.assertEqual(sc.LEGAL_VOL, dst_vol.getLegality())
Line 237: fake_convert = FakeQemuConvertChecker(src_vol, dst_vol)
Line 238: with MonkeyPatchScope([(qemuimg, 'convert', 
fake_convert)]):
Line 239: job = storage.sdm.api.copy_data.Job(job_id, 0, 
source, dest)


Line 239: job = storage.sdm.api.copy_data.Job(job_id, 0, 
source, dest)
Line 240: job.run()
Line 241: wait_for_job(job)
Line 242: self.assertEqual(jobs.STATUS.DONE, job.status)
Line 243: self.assertEqual(sc.LEGAL_VOL, src_vol.getLegality())
Same.

If you want to check the source volume, maybe add another test?
Line 244: self.assertEqual(sc.LEGAL_VOL, dst_vol.getLegality())
Line 245: 
Line 246: # TODO: Missing tests:
Line 247: # Copy between 2 different domains


Line 240: job.run()
Line 241: wait_for_job(job)
Line 242: self.assertEqual(jobs.STATUS.DONE, job.status)
Line 243: self.assertEqual(sc.LEGAL_VOL, src_vol.getLegality())
Line 244: self.assertEqual(sc.LEGAL_VOL, dst_vol.getLegality())
It would be nice to test that volume remain illegal when the operation fails. 
Later we will verify also the generation.
Line 245: 
Line 246: # TODO: Missing tests:
Line 247: # Copy between 2 different domains
Line 248: # Abort before copy


Line 249: # Abort during copy
Line 250: 
Line 251: 
Line 252: class FakeQemuConvertChecker(object):
Line 253: def __init__(self, src_vol, dst_vol):
We can make this more useful by accepting the command to run. To simulate 
success, call with /bin/true, and to simulate failure, /bin/false.
Line 254: self.src_vol = src_vol
Line 255: self.dst_vol = dst_vol
Line 256: 
Line 257: def __call__(self, *args, **kwargs):


https://gerrit.ovirt.org/#/c/64362/1/tests/storage_volume_test.py
File tests/storage_volume_test.py:

Line 110: vol.setMetadata = CountedInstanceMethod(vol.setMetadata)
Line 111: self.assertEqual(sc.LEGAL_VOL, vol.getLegality())
Line 112: with vol.datapath_session():
Line 113: self.assertEqual(sc.ILLEGAL_VOL, vol.getLegality())
Line 114: self.assertEqual(1, vol.setMetadata.nr_calls)
I don't think this verification is needed, documenting how the method should be 
implemented is good enough.

Also we don't care if this method will perform several metadata calls. We care 
only about setting the volume to illegal when entering the context, and setting 
it back only if no exception was raised.
Line 115: self.assertEqual(sc.LEGAL_VOL, vol.getLegality())
Line 116: self.assertEqual(2, vol.setMetadata.nr_calls)
Line 117: 
Line 118: def test_datapath_session_fail_inside_context(self):


https://gerrit.ovirt.org/#/c/64362/1/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:

Line 139
Line 140
Line 141
Line 142
Line 143
I think a property would make this much simpler:

@property
def datapath_session(self):
return self._vol.datapath_session


https://gerrit.ovirt.org/#/c/64362/1/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 497: """
Line 498: pass
Line 499: 
Line 500: @contextmanager
Line 501: def datapath_session(self):
I'm not sure about the name.

How about:

- data_operation
- operation
- transaction

One word describing this concept would be best.

We allready using the concept of operation, (e.g. QemuOperaiton), so having to 
do operations on volumes inside a volume.operation context 

Change in vdsm[master]: Live Merge: Teardown volume on HSM after live merge

[alitke]

Adam Litke has posted comments on this change.

Change subject: Live Merge: Teardown volume on HSM after live merge
..


Patch Set 5:

(5 comments)

https://gerrit.ovirt.org/#/c/64301/5/vdsm/storage/sd.py
File vdsm/storage/sd.py:

PS5, Line 531: teared
torn


PS5, Line 532: teared
torn


https://gerrit.ovirt.org/#/c/64301/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

PS5, Line 4768: TODO
This needs to happen before we can merge.  We can't have code like this in virt.


PS5, Line 4786: nvolume
volume


PS5, Line 4788: megre
merge


-- 
To view, visit https://gerrit.ovirt.org/64301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Use detect_format workaround in copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Use detect_format workaround in copy_data
..


Patch Set 11:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Refactor workarounds.detect_format

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Refactor workarounds.detect_format
..


Patch Set 5:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64230
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Use detect_format workaround in copy_data

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: storage: Use detect_format workaround in copy_data
..


storage: Use detect_format workaround in copy_data

SDM.copy_data needs to apply the same workaround when interpreting
volume format information for VM configuration disks.  Resolve this TODO
and add a test for it.

Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/64231
Reviewed-by: Nir Soffer 
Continuous-Integration: Jenkins CI
---
M tests/storage_sdm_copy_data_test.py
M vdsm/storage/sdm/api/copy_data.py
2 files changed, 56 insertions(+), 11 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Refactor workarounds.detect_format

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: storage: Refactor workarounds.detect_format
..


storage: Refactor workarounds.detect_format

The function workarounds.detect_format accepts two volumes, checks for a
special case, then returns the qemuimg formats that should be used for
each volume.  To make this logic more sharable, change detect_format to
just detect if the problem exists and let the calling code decide which
format to use.  This will allow the sdm.copy_data code to use this
function cleanly.

Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899
Signed-off-by: Adam Litke 
Reviewed-on: https://gerrit.ovirt.org/64230
Reviewed-by: Nir Soffer 
Continuous-Integration: Nir Soffer 
---
M lib/vdsm/storage/workarounds.py
M tests/storage_workarounds_test.py
M vdsm/storage/image.py
3 files changed, 18 insertions(+), 23 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved; Passed CI tests

Objections:
  Jenkins CI: Failed CI tests



-- 
To view, visit https://gerrit.ovirt.org/64230
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Teardown volume on HSM after live merge

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Live Merge: Teardown volume on HSM after live merge
..


Patch Set 5:

* #1377849::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1377849::OK, public bug
* Check Product::#1377849::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Remove volume run link after live merge

[ahino]

Ala Hino has posted comments on this change.

Change subject: Live Merge: Remove volume run link after live merge
..


Patch Set 10:

(2 comments)

https://gerrit.ovirt.org/#/c/59725/10/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:

Line 821: """
Line 822: volRunlink = os.path.join(constants.P_VDSM_STORAGE,
Line 823:   self.sdUUID, imgUUID, volUUID)
Line 824: try:
Line 825: self.log.info("Unlinking volme runtime link: %r", 
volRunLink)
> ./vdsm/storage/blockSD.py:825: undefined name 'volRunLink'
Which comment? I thought I addressed all comments
Line 826: os.unlink(volRunLink)
Line 827: except OSError as e:
Line 828: if e.error != errno.ENOENT:
Line 829: raise


Line 822: volRunlink = os.path.join(constants.P_VDSM_STORAGE,
Line 823:   self.sdUUID, imgUUID, volUUID)
Line 824: try:
Line 825: self.log.info("Unlinking volme runtime link: %r", 
volRunLink)
Line 826: os.unlink(volRunLink)
> Same error here.
Done
Line 827: except OSError as e:
Line 828: if e.error != errno.ENOENT:
Line 829: raise
Line 830: self.log.debug("Volume run link %r does not exist", 
volRunlink)


-- 
To view, visit https://gerrit.ovirt.org/59725
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Remove volume run link after live merge

[automation]

gerrit-hooks has posted comments on this change.

Change subject: Live Merge: Remove volume run link after live merge
..


Patch Set 11:

* #1321018::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1321018::OK, public bug
* Check Product::#1321018::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/59725
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce VolumeManifest.datapath_session

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Introduce VolumeManifest.datapath_session
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64362
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30a3ac2971411778d24e007aac9fcb3009edb4c4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Introduce VolumeManifest.datapath_session

[alitke]

Adam Litke has uploaded a new change for review.

Change subject: storage: Introduce VolumeManifest.datapath_session
..

storage: Introduce VolumeManifest.datapath_session

When performing datapath operations on a volume (eg. copying data) we
mark the volume ILLEGAL before starting the operation and only mark the
volume LEGAL again once the operation is finished.  As long as this is
all done with the volume lease held the engine can poll the volume from
any host to determine if the operation is running (lease held) and can
detect an interrupted/failed operation (lease free and volume ILLEGAL).

Later this contextmanager will be expanded to support volume generation
incrementation when exiting successfully which will also allow engine to
determine if an operation was completed successfully.

All metadata updates must be performed to a single block with one write
in order to ensure atomicity.

Change-Id: I30a3ac2971411778d24e007aac9fcb3009edb4c4
Signed-off-by: Adam Litke 
---
M tests/storage_sdm_copy_data_test.py
M tests/storage_volume_test.py
M vdsm/storage/sdm/api/copy_data.py
M vdsm/storage/volume.py
4 files changed, 104 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/62/64362/1

diff --git a/tests/storage_sdm_copy_data_test.py 
b/tests/storage_sdm_copy_data_test.py
index c0ec533..93f55c6 100644
--- a/tests/storage_sdm_copy_data_test.py
+++ b/tests/storage_sdm_copy_data_test.py
@@ -221,7 +221,40 @@
 # Qemu pads the file to a 1k boundary with null bytes
 self.assertTrue(f.read().startswith(vm_conf_data))
 
+@permutations((('file',), ('block',)))
+def test_datapath_session(self, env_type):
+job_id = str(uuid.uuid4())
+fmt = sc.RAW_FORMAT
+with self.get_vols(env_type, fmt, fmt) as (src_chain, dst_chain):
+src_vol = src_chain[0]
+dst_vol = dst_chain[0]
+source = dict(endpoint_type='div', sd_id=src_vol.sdUUID,
+  img_id=src_vol.imgUUID, vol_id=src_vol.volUUID)
+dest = dict(endpoint_type='div', sd_id=dst_vol.sdUUID,
+img_id=dst_vol.imgUUID, vol_id=dst_vol.volUUID)
+self.assertEqual(sc.LEGAL_VOL, src_vol.getLegality())
+self.assertEqual(sc.LEGAL_VOL, dst_vol.getLegality())
+fake_convert = FakeQemuConvertChecker(src_vol, dst_vol)
+with MonkeyPatchScope([(qemuimg, 'convert', fake_convert)]):
+job = storage.sdm.api.copy_data.Job(job_id, 0, source, dest)
+job.run()
+wait_for_job(job)
+self.assertEqual(jobs.STATUS.DONE, job.status)
+self.assertEqual(sc.LEGAL_VOL, src_vol.getLegality())
+self.assertEqual(sc.LEGAL_VOL, dst_vol.getLegality())
+
 # TODO: Missing tests:
 # Copy between 2 different domains
 # Abort before copy
 # Abort during copy
+
+
+class FakeQemuConvertChecker(object):
+def __init__(self, src_vol, dst_vol):
+self.src_vol = src_vol
+self.dst_vol = dst_vol
+
+def __call__(self, *args, **kwargs):
+assert sc.LEGAL_VOL == self.src_vol.getLegality()
+assert sc.ILLEGAL_VOL == self.dst_vol.getLegality()
+return qemuimg.QemuImgOperation(['/bin/true'])
diff --git a/tests/storage_volume_test.py b/tests/storage_volume_test.py
index 79cae70..2231148 100644
--- a/tests/storage_volume_test.py
+++ b/tests/storage_volume_test.py
@@ -19,10 +19,12 @@
 #
 
 from __future__ import absolute_import
+import uuid
 
 from monkeypatch import MonkeyPatchScope
 from storagefakelib import FakeStorageDomainCache
 from storagetestlib import FakeSD
+from storagetestlib import fake_env
 from testlib import expandPermutations, permutations
 from testlib import recorded
 from testlib import VdsmTestCase
@@ -34,6 +36,7 @@
 from storage import volume
 
 HOST_ID = 1
+MB = 1048576
 
 
 class FakeSDManifest(object):
@@ -92,3 +95,45 @@
 self.assertEqual(expected[:1], manifest.__calls__)
 lock.release()
 self.assertEqual(expected, manifest.__calls__)
+
+
+@expandPermutations
+class VolumeManifestTest(VdsmTestCase):
+
+def test_datapath_session(self):
+img_id = str(uuid.uuid4())
+vol_id = str(uuid.uuid4())
+
+with fake_env('file') as env:
+env.make_volume(MB, img_id, vol_id)
+vol = env.sd_manifest.produceVolume(img_id, vol_id)
+vol.setMetadata = CountedInstanceMethod(vol.setMetadata)
+self.assertEqual(sc.LEGAL_VOL, vol.getLegality())
+with vol.datapath_session():
+self.assertEqual(sc.ILLEGAL_VOL, vol.getLegality())
+self.assertEqual(1, vol.setMetadata.nr_calls)
+self.assertEqual(sc.LEGAL_VOL, vol.getLegality())
+self.assertEqual(2, vol.setMetadata.nr_calls)
+
+def 

Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
..


Patch Set 6: -Verified

pending jsonrpc cli fix

-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: sos: change getConnectedStoragePoolsList result key
..


Patch Set 3: -Verified

pending jsonrpc cli fix

-- 
To view, visit https://gerrit.ovirt.org/63557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I369d1392701d7b0eac2ce73613ba633a9a60d059
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: after_vm_destroy.py: migrate to jsonrpcvdscli

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: after_vm_destroy.py: migrate to jsonrpcvdscli
..


Patch Set 6:

pending jsonrpc cli fix

-- 
To view, visit https://gerrit.ovirt.org/62383
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f3fa6479dde2c4a1298d0ae167d888d9f7e020a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 15: -Verified

please ignore the jsonrpc migration patches until we will have the fixed cli. 
The current version depends on an abandoned patch.

-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Flatten LockType constants

[alitke]

Adam Litke has posted comments on this change.

Change subject: resourceManager: Flatten LockType constants
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id78e07814f21a1dcf33efa2afe400eff041e3001
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Inline LockType.validate

[alitke]

Adam Litke has posted comments on this change.

Change subject: resourceManager: Inline LockType.validate
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63627
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8205fb724d52eeedcc86c0f53656b2502721e1d0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: resourceManager: Remove unused method

[alitke]

Adam Litke has posted comments on this change.

Change subject: resourceManager: Remove unused method
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63626
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4d50f2dc83e5f50c3bdc4b7401e06d4813c2b1e0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Freddy Rolland 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Use detect_format workaround in copy_data

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Use detect_format workaround in copy_data
..


Patch Set 10: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Refactor workarounds.detect_format

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Refactor workarounds.detect_format
..


Patch Set 4: Verified+1

Verified by the following steps:
- Create 1G thin disk on block sd
- Move disk to file sd
- Manually edit vdsm volume metadata to set SIZE=20
- Overwrite the volume file with "VM configuration"
- Move the disk back to the block sd

The operation succeeded and the following appeared in the log:
77fcb026-4c51-4984-adfd-fc54a9641c87::WARNING::2016-09-23 
17:39:57,139::workarounds::59::storage.workarounds::(invalid_vm_conf_disk) 
Incorrect volume format 'qcow2' has been detected for volume 
u'33bb30de-0f7e-4f49-864f-f1add3298790', using the actual format 'raw'.

-- 
To view, visit https://gerrit.ovirt.org/64230
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7b2be176c474f9049d067f0a0c169644ac39899
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/62324/15/lib/vdsm/tool/dump_volume_chains.py
File lib/vdsm/tool/dump_volume_chains.py:

Line 122
Line 123
Line 124
Line 125
Line 126
We found that this return the wrong data 2 weeks ago, and I don't see any 
change in jsonrpcvdscli, or in the bridge that fixed this - how can this work?


-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 15: Code-Review-1

We need working json rpc client that supports all verbs before we can migrated 
this to json rpc.

-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: change getConnectedStoragePoolsList result key

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: sos: change getConnectedStoragePoolsList result key
..


Patch Set 3: Code-Review-1

We need working json rpc client that supports all verbs before we can migrated 
this to json rpc.

-- 
To view, visit https://gerrit.ovirt.org/63557
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I369d1392701d7b0eac2ce73613ba633a9a60d059
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: More standard logging format

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: logging: More standard logging format
..


Patch Set 4:

Thanks Peter, I think this is an interesting idea.

For the common use case textual logs work fine. For some cases,
like consuming the logs by a program, the current log is pretty
bad.

For example, the repoplot tool:
- https://github.com/oVirt/vdsm/blob/master/contrib/repoplot
- https://bugzilla.redhat.com/1081962 (look for repoplot)

Having structured logs can help, but is not enough, the logs must
be designed to support such usage and treated like an api, and
we can do this using textual logs.

To make it easier to follow operations, we added logs when operation
starts and finish, for example (look for START and FINISH):

- https://github.com/oVirt/vdsm/blob/master/lib/vdsm/common/api.py
- https://github.com/oVirt/vdsm/blob/master/lib/vdsm/storage/check.py

I think we should discuss this later in the context of the entire
ovirt project.

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Peter Portante 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: dump_volume_chains: migrate to jsonrpcvdscli

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: dump_volume_chains: migrate to jsonrpcvdscli
..


Patch Set 15: Code-Review-1

Needs a rebase

-- 
To view, visit https://gerrit.ovirt.org/62324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f34824ba84498bedf9ddc7cb5b41e8cdce603a1
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Oved Ourfali 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: sos: collect 'nodectl info' output

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 2: -Verified

* #1372093::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372093::OK, public bug
* Check Product::#1372093::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::#1372093::OK, correct target milestone ovirt-4.0.5
* Check merged to previous::OK, change not open on any previous branch

-- 
To view, visit https://gerrit.ovirt.org/63775
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: utils: add is_kvm helper

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: virt: utils: add is_kvm helper
..


Patch Set 34: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967
Gerrit-PatchSet: 34
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: utils: add is_kvm helper

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: virt: utils: add is_kvm helper
..


virt: utils: add is_kvm helper

Proper container support needs some changes into oVirt Engine.
First of all, Engine should send a different vmType from the
default (hardcoded) 'kvm' to select the container runtime to be used.

Until the Engine patch is ready, we use this hack to get
the container runtime from a custom property.

Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967
Signed-off-by: Francesco Romani 
Reviewed-on: https://gerrit.ovirt.org/55647
Reviewed-by: Milan Zamazal 
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/virt/utils.py
M tests/vmUtilsTests.py
2 files changed, 27 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Verified
  Milan Zamazal: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: utils: add is_kvm helper

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: utils: add is_kvm helper
..


Patch Set 35:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/55647
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f9e1b8f9326e565ee7324d0b328100ca86c6967
Gerrit-PatchSet: 35
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: sos: collect 'nodectl info' output
..


sos: collect 'nodectl info' output

CEE needs a quick and reliable way to determine release information
from a customer's sosreport. nodectl is installed RHV-H by default
and the output of 'nodectl info' provides a nice summary of the
available images and their boot options as well as the current image/layer
in use. If the command doesn't exist it will be ignored by sos report.

Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1372093
Signed-off-by: Irit Goihman 
Reviewed-on: https://gerrit.ovirt.org/63765
Continuous-Integration: Jenkins CI
Reviewed-by: Yaniv Bronhaim 
Reviewed-by: Dan Kenigsberg 
---
M vdsm/sos/vdsm.py.in
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Yaniv Bronhaim: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Irit Goihman: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[automation]

gerrit-hooks has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 2:

* #1372093::Update tracker: OK
* Set MODIFIED::bug 1372093#1372093IGNORE, not all related patches are 
closed, check 63775

-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: sos: collect 'nodectl info' output

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: sos: collect 'nodectl info' output
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63765
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8360e3812d9a84a592099ba93c583aa6c68a3ed0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: add migrate and migrateStatus

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: add migrate and migrateStatus
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: add migrate and migrateStatus

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: jsonrpcvdscli: add migrate and migrateStatus
..


jsonrpcvdscli: add migrate and migrateStatus

Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17
Signed-off-by: Simone Tiraboschi 
Reviewed-on: https://gerrit.ovirt.org/64324
Reviewed-by: Piotr Kliczewski 
Continuous-Integration: Jenkins CI
Reviewed-by: Irit Goihman 
---
M lib/vdsm/jsonrpcvdscli.py
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, approved
  Simone Tiraboschi: Verified
  Jenkins CI: Passed CI tests
  Irit Goihman: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/64324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net tests: bond tests fails on CI with ctypes.AttributeError

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net tests: bond tests fails on CI with ctypes.AttributeError
..


Patch Set 1:

The commit message needs some beefing: admit that we have no idea what are 
these failures.

does all the tests here are susceptible to this error?

-- 
To view, visit https://gerrit.ovirt.org/64345
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c88dd66056cbb1f65f77e8b1a7cf1f03e4fb80a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: add migrate and migrateStatus

[igoihman]

Irit Goihman has posted comments on this change.

Change subject: jsonrpcvdscli: add migrate and migrateStatus
..


Patch Set 2: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: acceptor: stop to double close acceptor

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: acceptor: stop to double close acceptor
..


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/63685/1/lib/vdsm/protocoldetector.py
File lib/vdsm/protocoldetector.py:

Line 206
Line 207
Line 208
Line 209
Line 210
I think the fix is to not close the reactor - this class does not own the 
reactor, and should not close it.

We should close only the acceptor. The caller own the reactor and should close 
it, probably in prepareForShutdown.


-- 
To view, visit https://gerrit.ovirt.org/63685
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: logging: More standard logging format

[peter . portante]

Peter Portante has posted comments on this change.

Change subject: logging: More standard logging format
..


Patch Set 4:

Hope you don't mind a comment from an outsider...

These kinds of changes to make formatting of log output "pretty" tie the 
visualizations of logs to the log emitter, which can be less flexible than you 
might want in the future.

Have you considered keeping the format of how logs are emitted separate from 
how they are displayed so that they can iterate at their own rate and their 
concerns not be intertwined?

Perhaps a JSON format output and write a simple viewer that consumes that, or 
use an existing one?

-- 
To view, visit https://gerrit.ovirt.org/64113
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I640c3c83db3b5818a08b4984d5358b1e27bf0ef3
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Peter Portante 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Use detect_format workaround in copy_data

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Use detect_format workaround in copy_data
..


Patch Set 10: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Teardown volume on HSM after live merge

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Live Merge: Teardown volume on HSM after live merge
..


Patch Set 4: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/64301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Remove volume run link after live merge

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Live Merge: Remove volume run link after live merge
..


Patch Set 10: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/59725/10/vdsm/storage/blockSD.py
File vdsm/storage/blockSD.py:

Line 821: """
Line 822: volRunlink = os.path.join(constants.P_VDSM_STORAGE,
Line 823:   self.sdUUID, imgUUID, volUUID)
Line 824: try:
Line 825: self.log.info("Unlinking volme runtime link: %r", 
volRunLink)
./vdsm/storage/blockSD.py:825: undefined name 'volRunLink'

This is the result of using mixedCase names in Python. In Java this works since 
the compiler detect this errors, in Python using this style is a recipe for 
failure.

To avoid this, lets use only lowercase_with_underscores names for all local 
variables.

Unfortunately, for method names and arguments we should match the module style.

Also, you ignored one of my comment about the log above in previous version, 
please address it.
Line 826: os.unlink(volRunLink)
Line 827: except OSError as e:
Line 828: if e.error != errno.ENOENT:
Line 829: raise


Line 822: volRunlink = os.path.join(constants.P_VDSM_STORAGE,
Line 823:   self.sdUUID, imgUUID, volUUID)
Line 824: try:
Line 825: self.log.info("Unlinking volme runtime link: %r", 
volRunLink)
Line 826: os.unlink(volRunLink)
Same error here.
Line 827: except OSError as e:
Line 828: if e.error != errno.ENOENT:
Line 829: raise
Line 830: self.log.debug("Volume run link %r does not exist", 
volRunlink)


-- 
To view, visit https://gerrit.ovirt.org/59725
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib88bf92e702ac6c324b87c9459b01adf165eaca4
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Use detect_format workaround in copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Use detect_format workaround in copy_data
..


Patch Set 10:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Use detect_format workaround in copy_data

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Use detect_format workaround in copy_data
..


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/64231/9/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:

Line 102: self.vol_id = params.get('vol_id')
Line 103: self._host_id = host_id
Line 104: self._writable = writable
Line 105: self._vol = None
Line 106: self._qemu_format = None
We don't use this now.
Line 107: 
Line 108: @property
Line 109: def locks(self):
Line 110: img_ns = sd.getNamespace(sc.IMAGE_NAMESPACE, self.sd_id)


-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Use detect_format workaround in copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Use detect_format workaround in copy_data
..


Patch Set 9:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Teardown volume on HSM after live merge

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Live Merge: Teardown volume on HSM after live merge
..


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/64301/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4782: self.vm.enableDriveMonitor()
Line 4783: self.success = True
Line 4784: self.vm.log.info("Synchronization completed (job %s)",
Line 4785:  self.job['jobID'])
Line 4786: self.teardown_top_volume()
> After another thought, I think it is better not to fail merge in this case,
I don't think this is a good idea, if we cannot deactivate the lv, or remove 
the symlinks in /run/vdsm, the system is fucked up and we should fail hard and 
loud.

If you do not agree you should add a big comment here explaining why the clean 
must succeed when we cannot teardown the volume.
Line 4787: 
Line 4788: def isSuccessful(self):
Line 4789: """
Line 4790: Returns True if this phase completed successfully.


-- 
To view, visit https://gerrit.ovirt.org/64301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cleanup: Remove log messages when raising exceptions

[nsoffer]

Nir Soffer has submitted this change and it was merged.

Change subject: cleanup: Remove log messages when raising exceptions
..


cleanup: Remove log messages when raising exceptions

Change-Id: I2cc68734d8c405343d118cfc2d9e8da09445dd88
Signed-off-by: Ala Hino 
Reviewed-on: https://gerrit.ovirt.org/64342
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer 
---
M vdsm/storage/blockSD.py
1 file changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Ala Hino: Verified



-- 
To view, visit https://gerrit.ovirt.org/64342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2cc68734d8c405343d118cfc2d9e8da09445dd88
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cleanup: Remove log messages when raising exceptions

[automation]

gerrit-hooks has posted comments on this change.

Change subject: cleanup: Remove log messages when raising exceptions
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.

-- 
To view, visit https://gerrit.ovirt.org/64342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc68734d8c405343d118cfc2d9e8da09445dd88
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[michal . skrivanek]

Michal Skrivanek has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 6:

(6 comments)

https://gerrit.ovirt.org/#/c/62873/4/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 473: flags = (libvirt.VIR_MIGRATE_LIVE |
Line 474:  libvirt.VIR_MIGRATE_PEER2PEER |
Line 475:  (libvirt.VIR_MIGRATE_TUNNELLED if
Line 476:  self._tunneled else 0) |
Line 477:  (libvirt.VIR_MIGRATE_ABORT_ON_ERROR if
7.3 is coming out really soon, and will be adopted in 4.0.z already. Likely 
before this patch gets in
Line 478:  self._abortOnError else 0) |
Line 479:  (libvirt.VIR_MIGRATE_COMPRESSED if
Line 480:  self._compressed else 0) |
Line 481:  (libvirt.VIR_MIGRATE_AUTO_CONVERGE if


Line 803: self.stop()
Line 804: 
Line 805: 
Line 806: _Progress = collections.namedtuple('_Progress', [
Line 807: 'job_type', 'time_elapsed', 'data_total',
?
Line 808: 'data_processed', 'data_remaining',
Line 809: 'mem_total', 'mem_processed', 'mem_remaining',
Line 810: 'mem_bps', 'mem_constant', 'compression_bytes',
Line 811: 'dirty_rate', 'mem_iteration'


https://gerrit.ovirt.org/#/c/62873/6/vdsm/virt/migration.py
File vdsm/virt/migration.py:

Line 480:  self._compressed else 0) |
Line 481:  (libvirt.VIR_MIGRATE_AUTO_CONVERGE if
Line 482:  self._autoConverge else 0))
Line 483: if self._use_convergence_schedule:
Line 484: # TODO: Replace this whole block with simple flag 
setting once
we're going to do that very soon in 4.0.z, probably before this patch is merged
Line 485: # Vdsm depends on proper versions of QEMU and libvirt.
Line 486: try:
Line 487: flags |= libvirt.VIR_MIGRATE_POSTCOPY
Line 488: except AttributeError:


Line 490: pass
Line 491: # There is a QEMU bug causing post-copy migration 
fail when
Line 492: # (XBZRLE) compression is enabled.  So let's disable 
the
Line 493: # compression until we depend on a fixed QEMU version.
Line 494: # See https://bugzilla.redhat.com/1368422.
since the policy wouldn't include it we can leave it as a qemu issue only
Line 495: if flags & libvirt.VIR_MIGRATE_POSTCOPY:
Line 496: flags &= ~libvirt.VIR_MIGRATE_COMPRESSED
Line 497: self._vm._dom.migrateToURI3(duri, params, flags)
Line 498: else:


Line 787:downtime)
Line 788: self._vm._dom.migrateSetMaxDowntime(downtime, 0)
Line 789: elif action == CONVERGENCE_SCHEDULE_POST_COPY:
Line 790: self._vm.log.info('Switching to post-copy migration')
Line 791: if not hasattr(self._vm._dom, 'migrateStartPostCopy'):
again, no need for that soon, so please do not handle it in the patch
Line 792: self._vm.log.warn('Failed to switch to post-copy 
migration: '
Line 793:   'not supported')
Line 794: elif self._vm._dom.migrateStartPostCopy(0) < 0:
Line 795: # Do nothing for now; the next action will be invoked 
after a


Line 827: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_PROCESSED],
Line 828: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_REMAINING],
Line 829: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_BPS],
Line 830: stats[libvirt.VIR_DOMAIN_JOB_MEMORY_CONSTANT],
Line 831: stats.get(libvirt.VIR_DOMAIN_JOB_COMPRESSION_BYTES, 0),
why?
Line 832: # available since libvirt 1.3
Line 833: stats.get('memory_dirty_rate', -1),
Line 834: # available since libvirt 1.3
Line 835: stats.get('memory_iteration', -1),


-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Use detect_format workaround in copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Use detect_format workaround in copy_data
..


Patch Set 8:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Use detect_format workaround in copy_data

[alitke]

Adam Litke has posted comments on this change.

Change subject: storage: Use detect_format workaround in copy_data
..


Patch Set 6:

(5 comments)

https://gerrit.ovirt.org/#/c/64231/3/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 218: # Copy between 2 different domains
Line 219: # Abort before copy
Line 220: # Abort during copy
Line 221
Line 222
> After all this setup, we did not verify the copy, jus that it did not raise
Done


https://gerrit.ovirt.org/#/c/64231/6/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 24: 
Line 25: from fakelib import FakeScheduler
Line 26: from monkeypatch import MonkeyPatchScope
Line 27: from storagefakelib import FakeResourceManager
Line 28: from storagetestlib import fake_env, fake_file_env
> pyflakes thinks this is unused:
Done
Line 29: from storagetestlib import make_qemu_chain, write_qemu_chain, 
verify_qemu_chain
Line 30: from storagetestlib import qemu_pattern_write, qemu_pattern_verify
Line 31: from storagetestlib import ChainVerificationError
Line 32: from testlib import VdsmTestCase, expandPermutations, permutations


Line 201: src_vol = src_chain[0]
Line 202: dst_vol = dst_chain[0]
Line 203: src_path = src_vol.getVolumePath()
Line 204: qemuimg.create(src_path, vm_conf_size, qemuimg.FORMAT.RAW)
Line 205: qemu_pattern_write(src_path, qemuimg.FORMAT.RAW)
> We need to comment the part corrupting the qcow image, and separate it from
Done
Line 206: source = dict(endpoint_type='div', sd_id=src_vol.sdUUID,
Line 207:   img_id=src_vol.imgUUID, 
vol_id=src_vol.volUUID)
Line 208: dest = dict(endpoint_type='div', sd_id=dst_vol.sdUUID,
Line 209: img_id=dst_vol.imgUUID, 
vol_id=dst_vol.volUUID)


Line 211: job.run()
Line 212: wait_for_job(job)
Line 213: self.assertEqual(jobs.STATUS.DONE, job.status)
Line 214: dst_path = dst_vol.getVolumePath()
Line 215: qemu_pattern_verify(dst_path, qemuimg.FORMAT.RAW)
> Since we are dealing with raw format, I think we can test this in a simpler
Close, but qemu pads the destination file to a 1k boundary.  See if you like 
what I have done.
Line 216: 
Line 217: # TODO: Missing tests:
Line 218: # Copy between 2 different domains
Line 219: # Abort before copy


https://gerrit.ovirt.org/#/c/64231/3/vdsm/storage/sdm/api/copy_data.py
File vdsm/storage/sdm/api/copy_data.py:

Line 66: return
Line 67: 
Line 68: # Workaround for volumes containing VM configuration 
info that
Line 69: # were created with invalid vdsm metadata.
Line 70: if self._source.is_invalid_vm_conf_disk():
> is_xxx is typically a method, not property.
Done
Line 71: src_format = dst_format = qemuimg.FORMAT.RAW
Line 72: else:
Line 73: src_format = self._source.qemu_format
Line 74: dst_format = self._dest.qemu_format


-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cleanup: Remove log messages when raising exceptions

[ahino]

Ala Hino has posted comments on this change.

Change subject: cleanup: Remove log messages when raising exceptions
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc68734d8c405343d118cfc2d9e8da09445dd88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: enable glusterfs access through libgfapi interface

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: enable glusterfs access through libgfapi interface
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/44061/8/vdsm/clientIF.py
File vdsm/clientIF.py:

Line 321: if drive.get('diskType') == DISK_TYPE.NETWORK:
Line 322: volinfo = res['info']
Line 323: volPath = volinfo['path']
Line 324: drive['protocol'] = volinfo['protocol']
Line 325: # currently, single host is provided due to this 
bug:
> I think we should take in the support for additional hosts as an addon patc
I agree with Sahina, this patch should make it possible to use libgfapi with 
current support in libvirt.

When libvirt will support more than one host we will support multiple hosts.
Line 326: # https://bugzilla.redhat.com/1247521
Line 327: drive['hosts'] = [volinfo['hosts'][0]]
Line 328: else:
Line 329: volPath = res['path']


-- 
To view, visit https://gerrit.ovirt.org/44061
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Prasanna Kumar Kalever 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: enable glusterfs access through libgfapi interface

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: virt: enable glusterfs access through libgfapi interface
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/44061/8/vdsm/storage/glusterVolume.py
File vdsm/storage/glusterVolume.py:

Line 76:  for brick in volInfo[volname]['bricks']]
Line 77: 
Line 78: return {'path': glusterPath,
Line 79: 'protocol': 'gluster',
Line 80: 'volfileServer': volfileServer,
> yes volfileserver is one of the address of bricks. However volfileserver co
Yes, this sounds like a good solution.

Drive has a "hosts" and "protocol" attributes, and creating xml for network 
drive must use only these properties. See tests/vmStorageTests.py test_network.

If you think that the current support for network drives is not good enough for 
gluster, please suggest a way to add the missing info in a generic way that can 
work for any network drive.

I think Drive.volumeInfo is not used for anything now, and it will be removed 
soon.


-- 
To view, visit https://gerrit.ovirt.org/44061
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Prasanna Kumar Kalever 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Teardown volume on HSM after live merge

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: Live Merge: Teardown volume on HSM after live merge
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64301/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4769
Line 4770
Line 4771
Line 4772
Line 4773
> Actually, _syncVolumeChain is defined on the VM and the drive isn't held as
Right, but this operation should have been defined in the cleanup thread. A 
method should use the same abstraction level (e.g operations on self, or 
operations on self.vm etc.)


-- 
To view, visit https://gerrit.ovirt.org/64301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: enable glusterfs access through libgfapi interface

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: enable glusterfs access through libgfapi interface
..


Patch Set 10:

* #1022961::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1022961::OK, public bug
* Check Product::#1022961::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/44061
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Prasanna Kumar Kalever 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cleanup: Remove log messages when raising exceptions

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: cleanup: Remove log messages when raising exceptions
..


Patch Set 1:

Please verify

-- 
To view, visit https://gerrit.ovirt.org/64342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc68734d8c405343d118cfc2d9e8da09445dd88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cleanup: Remove log messages when raising exceptions

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: cleanup: Remove log messages when raising exceptions
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc68734d8c405343d118cfc2d9e8da09445dd88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Use detect_format workaround in copy_data

[nsoffer]

Nir Soffer has posted comments on this change.

Change subject: storage: Use detect_format workaround in copy_data
..


Patch Set 6:

(3 comments)

https://gerrit.ovirt.org/#/c/64231/6/tests/storage_sdm_copy_data_test.py
File tests/storage_sdm_copy_data_test.py:

Line 24: 
Line 25: from fakelib import FakeScheduler
Line 26: from monkeypatch import MonkeyPatchScope
Line 27: from storagefakelib import FakeResourceManager
Line 28: from storagetestlib import fake_env, fake_file_env
pyflakes thinks this is unused:
13:14:40 ./tests/storage_sdm_copy_data_test.py:28: 'fake_file_env' imported but 
unused
Line 29: from storagetestlib import make_qemu_chain, write_qemu_chain, 
verify_qemu_chain
Line 30: from storagetestlib import qemu_pattern_write, qemu_pattern_verify
Line 31: from storagetestlib import ChainVerificationError
Line 32: from testlib import VdsmTestCase, expandPermutations, permutations


Line 201: src_vol = src_chain[0]
Line 202: dst_vol = dst_chain[0]
Line 203: src_path = src_vol.getVolumePath()
Line 204: qemuimg.create(src_path, vm_conf_size, qemuimg.FORMAT.RAW)
Line 205: qemu_pattern_write(src_path, qemuimg.FORMAT.RAW)
We need to comment the part corrupting the qcow image, and separate it from the 
normal flow.
Line 206: source = dict(endpoint_type='div', sd_id=src_vol.sdUUID,
Line 207:   img_id=src_vol.imgUUID, 
vol_id=src_vol.volUUID)
Line 208: dest = dict(endpoint_type='div', sd_id=dst_vol.sdUUID,
Line 209: img_id=dst_vol.imgUUID, 
vol_id=dst_vol.volUUID)


Line 211: job.run()
Line 212: wait_for_job(job)
Line 213: self.assertEqual(jobs.STATUS.DONE, job.status)
Line 214: dst_path = dst_vol.getVolumePath()
Line 215: qemu_pattern_verify(dst_path, qemuimg.FORMAT.RAW)
Since we are dealing with raw format, I think we can test this in a simpler way:

create qcow2 chains normally

# Corrupt qcow image with raw vm conf data
vm_conf_data = "vm configuration data"
with open(src_path, 'w') as f:
f.write(vm_conf_data)

perform copy...

with open(dst_path) as f:
self.assertEqual(f.read(), vm_conf_data)
Line 216: 
Line 217: # TODO: Missing tests:
Line 218: # Copy between 2 different domains
Line 219: # Abort before copy


-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: Initial support for post-copy migration

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: Initial support for post-copy migration
..


Patch Set 7:

* #1354343::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1354343::OK, public bug
* Check Product::#1354343::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/62873
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4c9911f47331120a1b78326044a4949abf35d5fe
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Milan Zamazal 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: Tomas Jelinek 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Use detect_format workaround in copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Use detect_format workaround in copy_data
..


Patch Set 7:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: enable glusterfs access through libgfapi interface

[automation]

gerrit-hooks has posted comments on this change.

Change subject: virt: enable glusterfs access through libgfapi interface
..


Patch Set 9:

* #1022961::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1022961::OK, public bug
* Check Product::#1022961::OK, Correct classification oVirt
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/44061
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Prasanna Kumar Kalever 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: virt: enable glusterfs access through libgfapi interface

[sabose]

Sahina Bose has posted comments on this change.

Change subject: virt: enable glusterfs access through libgfapi interface
..


Patch Set 8:

(1 comment)

https://gerrit.ovirt.org/#/c/44061/8/vdsm/storage/glusterVolume.py
File vdsm/storage/glusterVolume.py:

Line 76:  for brick in volInfo[volname]['bricks']]
Line 77: 
Line 78: return {'path': glusterPath,
Line 79: 'protocol': 'gluster',
Line 80: 'volfileServer': volfileServer,
> Why do we need this?
yes volfileserver is one of the address of bricks. However volfileserver could 
be the user preferred server to access the volume. Especially in case that user 
has setup virtual IP, they may provide that as the volfileserver.
We can change to add volfileserver as the first element in hosts, as I see it 
is not used in prepareVolumePath - let me know if right approach


-- 
To view, visit https://gerrit.ovirt.org/44061
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54b81e87b959b0b49c0f06810f88410e7c75de1d
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Federico Simoncelli 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Prasanna Kumar Kalever 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Kaul 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: storage: Use detect_format workaround in copy_data

[automation]

gerrit-hooks has posted comments on this change.

Change subject: storage: Use detect_format workaround in copy_data
..


Patch Set 6:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64231
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iecfd3e0fd5923e9a79ab21e01c9b12def78c
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: add migrate and migrateStatus

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: add migrate and migrateStatus
..


Patch Set 2: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: gluster: set selinux labels while creating bricks

[fromani]

Francesco Romani has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 1: Code-Review+1

targeted 4.0.6, temporary holding merge until we finish 4.0.5

-- 
To view, visit https://gerrit.ovirt.org/64296
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: add migrate and migrateStatus

[automation]

gerrit-hooks has posted comments on this change.

Change subject: jsonrpcvdscli: add migrate and migrateStatus
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: add migrate and migrateStatus

[stirabos]

Simone Tiraboschi has posted comments on this change.

Change subject: jsonrpcvdscli: add migrate and migrateStatus
..


Patch Set 2: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: gluster: set selinux labels while creating bricks

[rnachimu]

Ramesh N has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/64296
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Ramesh N 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: tests: inspect.getargspec() is deprecated in py3
..


Patch Set 2: Verified+1

Verified by running build on my f23.

-- 
To view, visit https://gerrit.ovirt.org/64313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: add migrateStatus

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: jsonrpcvdscli: add migrateStatus
..


Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/64324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[ovirt-4.0]: gluster: set selinux labels while creating bricks

[sabose]

Sahina Bose has posted comments on this change.

Change subject: gluster: set selinux labels while creating bricks
..


Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64296
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ca5fec80831073643635875095b88c1c4c2132e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-4.0
Gerrit-Owner: Ramesh N 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sahina Bose 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net test: shared nic between bond and network

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net test: shared nic between bond and network
..


Patch Set 3: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/64206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice4ead640d45d0717d2a30bd01398cbbfff3f88a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: supervdsm: expose systemd utilities

[fromani]

Francesco Romani has posted comments on this change.

Change subject: supervdsm: expose systemd utilities
..


Patch Set 30: Verified+1

-- 
To view, visit https://gerrit.ovirt.org/56491
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38e9a346da784fc200a82d9e5d9fdf665e752987
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik 
Gerrit-Reviewer: Milan Zamazal 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: config: add tunables for container support

[fromani]

Francesco Romani has posted comments on this change.

Change subject: config: add tunables for container support
..


Patch Set 1: Verified+1

if tests pass, we are clear.

-- 
To view, visit https://gerrit.ovirt.org/64243
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30e4372fc88ebb7e68cc3b982af3c2eefacef7ce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

[edwardh]

Edward Haas has posted comments on this change.

Change subject: net: edit bond detached from bridge but still attached to a vlan
..


Patch Set 14: Code-Review+1

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net tests: bond tests fails on CI with ctypes.AttributeError

[phoracek]

Petr Horáček has uploaded a new change for review.

Change subject: net tests: bond tests fails on CI with ctypes.AttributeError
..

net tests: bond tests fails on CI with ctypes.AttributeError

Change-Id: I6c88dd66056cbb1f65f77e8b1a7cf1f03e4fb80a
---
M tests/network/link_bond_test.py
1 file changed, 9 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/45/64345/1

diff --git a/tests/network/link_bond_test.py b/tests/network/link_bond_test.py
index a610f63..7eb8b00 100644
--- a/tests/network/link_bond_test.py
+++ b/tests/network/link_bond_test.py
@@ -20,12 +20,15 @@
 
 from contextlib import contextmanager
 
+import ctypes
+
 from nose.plugins.attrib import attr
 from nose.plugins.skip import SkipTest
 
 from testlib import VdsmTestCase as TestCaseBase
 
 from .nettestlib import dummy_devices
+from testValidation import broken_on_ci
 
 from vdsm.network.link import iface
 from vdsm.network.link.bond import Bond
@@ -41,16 +44,19 @@
 @attr(type='integration')
 class LinkBondTests(TestCaseBase):
 
+@broken_on_ci(exception=ctypes.ArgumentError)
 def test_bond_without_slaves(self):
 with bond_device() as bond:
 self.assertFalse(iface.is_up(bond.master))
 
+@broken_on_ci(exception=ctypes.ArgumentError)
 def test_bond_with_slaves(self):
 with dummy_devices(2) as (nic1, nic2):
 with bond_device() as bond:
 bond.add_slaves((nic1, nic2))
 self.assertFalse(iface.is_up(bond.master))
 
+@broken_on_ci(exception=ctypes.ArgumentError)
 def test_bond_devices_are_up(self):
 with dummy_devices(2) as (nic1, nic2):
 with bond_device() as bond:
@@ -60,6 +66,7 @@
 self.assertTrue(iface.is_up(nic2))
 self.assertTrue(iface.is_up(bond.master))
 
+@broken_on_ci(exception=ctypes.ArgumentError)
 def test_bond_exists(self):
 with dummy_devices(2) as (nic1, nic2):
 with bond_device() as _bond:
@@ -77,6 +84,7 @@
 expected_bond_set = set([b1.master, b2.master, b3.master])
 self.assertLessEqual(expected_bond_set, actual_bond_set)
 
+@broken_on_ci(exception=ctypes.ArgumentError)
 def test_bond_create_failure_on_slave_add(self):
 with dummy_devices(2) as (nic1, nic2):
 with bond_device() as base_bond:
@@ -89,6 +97,7 @@
 broken_bond.add_slaves((nic1, nic2))
 self.assertFalse(Bond(bond_name).exists())
 
+@broken_on_ci(exception=ctypes.ArgumentError)
 def test_bond_edit_failure_on_slave_add(self):
 with dummy_devices(2) as (nic1, nic2):
 with bond_device() as base_bond, bond_device() as edit_bond:


-- 
To view, visit https://gerrit.ovirt.org/64345
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6c88dd66056cbb1f65f77e8b1a7cf1f03e4fb80a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net tests: bond tests fails on CI with ctypes.AttributeError

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net tests: bond tests fails on CI with ctypes.AttributeError
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64345
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6c88dd66056cbb1f65f77e8b1a7cf1f03e4fb80a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: Consume ifcfg files that have a non vdsm standard name
..


Patch Set 5:

* #1367378::Update tracker: OK
* Set MODIFIED::bug 1367378#1367378IGNORE, not all related patches are 
closed, check 64095

-- 
To view, visit https://gerrit.ovirt.org/63990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name

[danken]

Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Consume ifcfg files that have a non vdsm standard name
..


net: Consume ifcfg files that have a non vdsm standard name

VDSM assumes that the ifcfg files which represent network devices are
named in the following format: ifcfg-

If the host is set initially by Network Manager, the names of the files
do no correspond to the expected format.

This patch adjusts the ifcfg file name to the mentioned format and
erases any other ifcfg files that correspond to the same device.

This is not a NM friendly patch, it assumes that NM is not active while
setupNetworks is issued.

Change-Id: I0bf70ba936d5de1f17a90742644719216018f674
Bug-Url: https://bugzilla.redhat.com/1367378
Signed-off-by: Edward Haas 
Reviewed-on: https://gerrit.ovirt.org/63990
Continuous-Integration: Jenkins CI
Reviewed-by: Petr Horáček 
Reviewed-by: Dan Kenigsberg 
---
M lib/vdsm/network/configurators/ifcfg.py
M tests/network/func_net_basic_test.py
2 files changed, 70 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Petr Horáček: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/63990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: Consume ifcfg files that have a non vdsm standard name

[danken]

Dan Kenigsberg has posted comments on this change.

Change subject: net: Consume ifcfg files that have a non vdsm standard name
..


Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.ovirt.org/63990
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bf70ba936d5de1f17a90742644719216018f674
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michael Burman 
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: Live Merge: Teardown volume on HSM after live merge

[ahino]

Ala Hino has posted comments on this change.

Change subject: Live Merge: Teardown volume on HSM after live merge
..


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/64301/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 4769
Line 4770
Line 4771
Line 4772
Line 4773
> Another place where we should not pass an argument.
Actually, _syncVolumeChain is defined on the VM and the drive isn't held as a 
variable of the VM


-- 
To view, visit https://gerrit.ovirt.org/64301
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iec3b6adb50293d8c98f5d8726d668eb272d16549
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: Adam Litke 
Gerrit-Reviewer: Ala Hino 
Gerrit-Reviewer: Allon Mureinik 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: Yes
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: acceptor: stop to double close acceptor

[piotr . kliczewski]

Piotr Kliczewski has posted comments on this change.

Change subject: acceptor: stop to double close acceptor
..


Patch Set 1: Verified+1

Verified by running tests several times.

-- 
To view, visit https://gerrit.ovirt.org/63685
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9a14cfa84c34241dbb511c0348109073b6865087
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer 
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: tests: inspect.getargspec() is deprecated in py3

[automation]

gerrit-hooks has posted comments on this change.

Change subject: tests: inspect.getargspec() is deprecated in py3
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64313
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25a58ea32bf7548a8f27cc217392fd0958cc8b7d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Yaniv Bronhaim 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: v2v: support for block devices

[Tomas Golembiovsky]

Tomas Golembiovsky has posted comments on this change.

Change subject: v2v: support for block devices
..


Patch Set 1: Code-Review+1

Adding +1, but it leaves me thinking whether we should do something for the 
other types as well. Based on documentation there are three other disk types: 
dir, netowork and volume.

-- 
To view, visit https://gerrit.ovirt.org/64272
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5f7a85715764efded7b296e858b130a05fe10f2a
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi 
Gerrit-Reviewer: Francesco Romani 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Shahar Havivi 
Gerrit-Reviewer: Tomas Golembiovsky 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cleanup: Remove log messages when raising exceptions

[automation]

gerrit-hooks has posted comments on this change.

Change subject: cleanup: Remove log messages when raising exceptions
..


Patch Set 1:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2cc68734d8c405343d118cfc2d9e8da09445dd88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: cleanup: Remove log messages when raising exceptions

[ahino]

Ala Hino has uploaded a new change for review.

Change subject: cleanup: Remove log messages when raising exceptions
..

cleanup: Remove log messages when raising exceptions

Change-Id: I2cc68734d8c405343d118cfc2d9e8da09445dd88
Signed-off-by: Ala Hino 
---
M vdsm/storage/blockSD.py
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/42/64342/1

diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index 8ac7433..6ce6af7 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -1149,8 +1149,6 @@
 self.log.debug("path to image directory already exists: %s",
dst)
 else:
-self.log.error("Failed to create path to image directory: %s",
-   dst)
 raise
 return dst
 
@@ -1184,7 +1182,6 @@
 if e.errno == errno.EEXIST:
 self.log.debug("img run vol already exists: %s", dstVol)
 else:
-self.log.error("Failed to create img run vol: %s", dstVol)
 raise
 
 return imgRunDir


-- 
To view, visit https://gerrit.ovirt.org/64342
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2cc68734d8c405343d118cfc2d9e8da09445dd88
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino 
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: jsonrpcvdscli: add migrateStatus

[stirabos]

Simone Tiraboschi has posted comments on this change.

Change subject: jsonrpcvdscli: add migrateStatus
..


Patch Set 1: Code-Review-1

-- 
To view, visit https://gerrit.ovirt.org/64324
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia51377a89ec0ff55e430b4140848314b8cf7cb17
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi 
Gerrit-Reviewer: Irit Goihman 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski 
Gerrit-Reviewer: Sandro Bonazzola 
Gerrit-Reviewer: Simone Tiraboschi 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net test: shared nic between bond and network

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net test: shared nic between bond and network
..


Patch Set 3: Verified+1

Passed network/*_test.py OK.

-- 
To view, visit https://gerrit.ovirt.org/64206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice4ead640d45d0717d2a30bd01398cbbfff3f88a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

[phoracek]

Petr Horáček has posted comments on this change.

Change subject: net: edit bond detached from bridge but still attached to a vlan
..


Patch Set 14: Verified+1

Passed network/*_test.py OK.

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: edit bond detached from bridge but still attached to a vlan
..


Patch Set 14:

* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::OK, public bug
* Check Product::#1372798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net test: shared nic between bond and network

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: shared nic between bond and network
..


Patch Set 3:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice4ead640d45d0717d2a30bd01398cbbfff3f88a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net: edit bond detached from bridge but still attached to a ...

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net: edit bond detached from bridge but still attached to a vlan
..


Patch Set 13:

* #1372798::Update tracker: OK
* Check Bug-Url::OK
* Check Public Bug::#1372798::OK, public bug
* Check Product::#1372798::OK, Correct product Red Hat Enterprise 
Virtualization Manager
* Check TM::SKIP, not in a monitored branch (ovirt-3.6 ovirt-4.0)
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/63723
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I460cb08cf436b932e7d9592557a03d7b6fc36a0f
Gerrit-PatchSet: 13
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org

Change in vdsm[master]: net test: shared nic between bond and network

[automation]

gerrit-hooks has posted comments on this change.

Change subject: net test: shared nic between bond and network
..


Patch Set 2:

* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: ' 
and is a valid url.
* Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.6', 
'ovirt-4.0'])

-- 
To view, visit https://gerrit.ovirt.org/64206
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ice4ead640d45d0717d2a30bd01398cbbfff3f88a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček 
Gerrit-Reviewer: Dan Kenigsberg 
Gerrit-Reviewer: Edward Haas 
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček 
Gerrit-Reviewer: gerrit-hooks 
Gerrit-HasComments: No
___
vdsm-patches mailing list -- vdsm-patches@lists.fedorahosted.org
To unsubscribe send an email to vdsm-patches-le...@lists.fedorahosted.org