Change in vdsm[master]: [WIP]add simple balloon functional testcase
Adam Litke has posted comments on this change. Change subject: [WIP]add simple balloon functional testcase .. Patch Set 2: Code-Review+1 -- To view, visit http://gerrit.ovirt.org/12820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie8140fe1c754d9d4026c503a19420e6552a3f4fe Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: verbs for managing services
Adam Litke has posted comments on this change. Change subject: gluster: verbs for managing services .. Patch Set 24: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11094 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Rename balloon_min to min_guarantee in balloon information
Adam Litke has posted comments on this change. Change subject: Rename balloon_min to min_guarantee in balloon information .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/16774 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iecd4e234215d0d75a2f42da3303ca4d80053af26 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Enable balloon and use the MoM multiple policies feature
Adam Litke has posted comments on this change. Change subject: Enable balloon and use the MoM multiple policies feature .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/16728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3fa80990bdbcd88f8ec83f5c664047c75c2e7a73 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Implement python bindings
Adam Litke has abandoned this change. Change subject: [WIP] Implement python bindings .. Patch Set 8: Abandoned Bitrot -- To view, visit http://gerrit.ovirt.org/11755 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I3f22966348c4c459710d79e1d97f98e2280d7022 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...
Adam Litke has abandoned this change. Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged' field .. Patch Set 6: Abandoned Bitrot -- To view, visit http://gerrit.ovirt.org/11567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I4dfa57649e545dbdf490fec1bb7bf3012b509a40 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-jsonrpc depends on vdsm-yajsonrpc
Adam Litke has abandoned this change. Change subject: vdsm-jsonrpc depends on vdsm-yajsonrpc .. Patch Set 2: Abandoned Bitrot -- To view, visit http://gerrit.ovirt.org/12317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I8b368b7ed5f490a8e7d9a68cea2aebd01c0b26f1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: Fix the Hooks schema definition
Adam Litke has abandoned this change. Change subject: schema: Fix the Hooks schema definition .. Patch Set 9: Abandoned Bitrot -- To view, visit http://gerrit.ovirt.org/11568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I07168edf4ec71c4640d873e854da184abd4230e8 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Ensure package version data are always strings
Adam Litke has abandoned this change. Change subject: caps: Ensure package version data are always strings .. Patch Set 9: Abandoned Bitrot -- To view, visit http://gerrit.ovirt.org/11569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I506d2b5edacd85c5540a040ce0ff5fe40c12b352 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: address and deviceId are optional for VM devices
Adam Litke has abandoned this change. Change subject: api: address and deviceId are optional for VM devices .. Patch Set 1: Abandoned Bitrot -- To view, visit http://gerrit.ovirt.org/12316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I00fdfd984960e9b71d72e6b455e1aae4e3a7fe49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet
Adam Litke has posted comments on this change.
Change subject: gluster: new vdsm verb glusterHostUUIDGet
..
Patch Set 4: (1 inline comment)
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 156: #
Line 157: # Since: 4.10.3
Line 158: ##
Line 159: {'type': 'HostUUID',
Line 160: 'data': {'uuid': 'UUID'}}
Yes, in order to maintain accuracy of the schema.
Line 161:
Line 162: ##
Line 163: # @GlusterHost.uuid:
Line 164: #
--
To view, visit http://gerrit.ovirt.org/13785
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf48b4c9530c48b2c46234d98c8cb4244adf22fd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added verbs for read, update, add and remove hooks
Adam Litke has posted comments on this change.
Change subject: gluster: Added verbs for read, update, add and remove hooks
..
Patch Set 5: (2 inline comments)
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 149: # Since: 4.10.3
Line 150: ##
Line 151: {'type': 'HookContent',
Line 152: 'data': {'content': 'str', 'type': 'str', 'md5sum': 'str'}}
Line 153:
Why isn't 'type' an enum?
Line 154: ##
Line 155: # @GlusterHook.read:
Line 156: #
Line 157: # Provides the hook content
Line 193: ##
Line 194: {'command': {'class': 'GlusterHook', 'name': 'update'},
Line 195: 'data': {'glusterCmd': 'str', 'hookLevel': 'HookLevel', 'hookName':
'str', 'hookData': 'str', 'hookMd5Sum': 'str'},
Line 196: 'returns': 'boolean'}
Line 197:
'bool' not 'boolean'
Line 198: ##
Line 199: # @GlusterHook.add:
Line 200: #
Line 201: # Add a hook file
--
To view, visit http://gerrit.ovirt.org/14145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie123356209aa0f71176bd06b9c53e0e96211e716
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: verbs for managing services
Adam Litke has posted comments on this change.
Change subject: gluster: verbs for managing services
..
Patch Set 18: I would prefer that you didn't submit this
(1 inline comment)
One small change to make it correct. You can test your schema file for
validity with the following command:
./vdsm_api/process-schema.py vdsm/gluster/vdsmapi-gluster-schema.json out.html
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 243: # status information for list of services
Line 244: #
Line 245: # Since: 4.10.3
Line 246: ##
Line 247: {'command': {'class': 'GlusterService', 'name': 'get'},
name needs to be 'manage'
Line 248: 'data': {'serviceName': 'str', 'action': 'GlusterServiceAction',
'failOnError': 'bool'},
--
To view, visit http://gerrit.ovirt.org/11094
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a16bf566d17e186a66503391dfd04b2f2bb4bb4
Gerrit-PatchSet: 18
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: new vdsm verb glusterHostUUIDGet
Adam Litke has posted comments on this change.
Change subject: gluster: new vdsm verb glusterHostUUIDGet
..
Patch Set 4: (1 inline comment)
File vdsm/gluster/vdsmapi-gluster-schema.json
Line 156: #
Line 157: # Since: 4.10.3
Line 158: ##
Line 159: {'type': 'HostUUID',
Line 160: 'data': {'uuid': 'UUID'}}
Do you really intend for this type to be a dictionary with a single key/value?
{'uuid': '5c1843a2-8dad-4b28-ae74-764b37c97da9'}
Other vdsm verbs simply use the 'str' type.
Line 161:
Line 162: ##
Line 163: # @GlusterHost.uuid:
Line 164: #
--
To view, visit http://gerrit.ovirt.org/13785
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idf48b4c9530c48b2c46234d98c8cb4244adf22fd
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Aravinda VK avish...@redhat.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added gluster hooks support
Adam Litke has posted comments on this change. Change subject: gluster: Added gluster hooks support .. Patch Set 30: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3918aa035d90967f1297dc7fadcf14b6a9385c45 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmapi: vdsmapi support for gluster vdsm verbs
Adam Litke has posted comments on this change. Change subject: vdsmapi: vdsmapi support for gluster vdsm verbs .. Patch Set 3: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id10b51a41d103afcf81cb76c460f3b9821238317 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: move exportToSupervdsm at module level
Adam Litke has posted comments on this change. Change subject: gluster: move exportToSupervdsm at module level .. Patch Set 14: Looks good to me, but someone else must approve Looks ok to me. -- To view, visit http://gerrit.ovirt.org/13051 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5b8217899a637a10c7bc47a13e8afdddc1b0fefe Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Added gluster hooks support
Adam Litke has posted comments on this change. Change subject: gluster: Added gluster hooks support .. Patch Set 27: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3918aa035d90967f1297dc7fadcf14b6a9385c45 Gerrit-PatchSet: 27 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmapi: vdsmapi support for gluster vdsm verbs
Adam Litke has posted comments on this change. Change subject: vdsmapi: vdsmapi support for gluster vdsm verbs .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) No major objections. Would like to see a few cleanups in the find_schema() path. File vdsm_api/vdsmapi.py Line 137: if os.access(path, os.R_OK): Line 138: return path Line 139: else: Line 140: return None Line 141: Is there a way you could adapt the original function to support the gluster schema? Why are you not attempting to support finding the schema file in the local path? Maybe you should install the schema file in the same directory as the vdsm schema. Then you can modify find_schema to take a schema name (with the default being 'vdsmapi-schema'. Line 142: Line 143: _api_info = None Line 144: Line 145: -- To view, visit http://gerrit.ovirt.org/13921 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id10b51a41d103afcf81cb76c460f3b9821238317 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: make our udev rules take effect later than default Ubuntu lv...
Adam Litke has posted comments on this change. Change subject: make our udev rules take effect later than default Ubuntu lvm rules .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12816 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9711c8388ad260427a511ed00465cdeb80a5ca1c Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Alon Bar-Lev alo...@redhat.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ew...@kohlvanwijngaarden.nl Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: change vdsm to use multipolicy mom
Adam Litke has posted comments on this change. Change subject: change vdsm to use multipolicy mom .. Patch Set 4: I would prefer that you didn't submit this (1 inline comment) File vdsm/Makefile.am Line 127: limits.conf \ Line 128: logger.conf.in \ Line 129: mk_sysprep_floppy.in \ Line 130: mom.conf.in \ Line 131: mom_policies/mom.policy \ I would like to propose a different naming schema for the policy directory and the policy files. The directory should be named policy.d and the policy should be named 50_default.policy. This will make the naming conform to the standard way of handling configuration directories. the .d suffix implies that the directory can contain a set of partial configuration files (in our case policies). Since policies are parsed in alphabetical order, we prefix each one with a number so we can directly control their order. Line 132: sudoers.vdsm.in \ Line 133: vdsmd.8.in \ Line 134: vdsmd.init.in \ Line 135: vdsmd.service \ -- To view, visit http://gerrit.ovirt.org/11243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If06b7f5d5bb69767b0d97c1063c44ae2bd9cd799 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Mei Liu liu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dynamicly generate json-rpc client proxy methods according t...
Adam Litke has posted comments on this change. Change subject: dynamicly generate json-rpc client proxy methods according to schema .. Patch Set 11: I would prefer that you didn't submit this I think we should get the python bindings merged and then use those for testing. http://gerrit.ovirt.org/#/c/11755/ -- To view, visit http://gerrit.ovirt.org/11283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib081e26203638114d7d632489432a50eeea45dd4 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Shu Ming shum...@linux.vnet.ibm.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...
Adam Litke has posted comments on this change. Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged' field .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/11567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dfa57649e545dbdf490fec1bb7bf3012b509a40 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: Fix the Hooks schema definition
Adam Litke has posted comments on this change. Change subject: schema: Fix the Hooks schema definition .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/11568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07168edf4ec71c4640d873e854da184abd4230e8 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Ensure package version data are always strings
Adam Litke has posted comments on this change. Change subject: caps: Ensure package version data are always strings .. Patch Set 9: Verified -- To view, visit http://gerrit.ovirt.org/11569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I506d2b5edacd85c5540a040ce0ff5fe40c12b352 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: address and deviceId are optional for VM devices
Adam Litke has posted comments on this change. Change subject: api: address and deviceId are optional for VM devices .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00fdfd984960e9b71d72e6b455e1aae4e3a7fe49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-jsonrpc depends on vdsm-yajsonrpc
Adam Litke has posted comments on this change. Change subject: vdsm-jsonrpc depends on vdsm-yajsonrpc .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12317 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8b368b7ed5f490a8e7d9a68cea2aebd01c0b26f1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm-jsonrpc depends on vdsm-yajsonrpc
Adam Litke has uploaded a new change for review.
Change subject: vdsm-jsonrpc depends on vdsm-yajsonrpc
..
vdsm-jsonrpc depends on vdsm-yajsonrpc
Vdsm's jsonrpc server binding imports yajsonrpc but the spec file does not list
yajsonrpc as a dependency. Fix.
Change-Id: I8b368b7ed5f490a8e7d9a68cea2aebd01c0b26f1
Signed-off-by: Adam Litke a...@us.ibm.com
---
M vdsm.spec.in
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/17/12317/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index 38838ea..2b6144f 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -195,6 +195,7 @@
BuildArch: noarch
Requires: %{name}-python = %{version}-%{release}
+Requires: %{name}-yajsonrpc = %{version}-%{release}
Requires: %{name}-api = %{version}-%{release}
%if 0%{?rhel} == 6
Requires: python-ordereddict
--
To view, visit http://gerrit.ovirt.org/12317
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8b368b7ed5f490a8e7d9a68cea2aebd01c0b26f1
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: address and deviceId are optional for VM devices
Adam Litke has uploaded a new change for review.
Change subject: api: address and deviceId are optional for VM devices
..
api: address and deviceId are optional for VM devices
Signed-off-by: Adam Litke a...@us.ibm.com
Change-Id: I00fdfd984960e9b71d72e6b455e1aae4e3a7fe49
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 31 insertions(+), 31 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/16/12316/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index e2512ea..7e57475 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -1938,11 +1938,11 @@
# @propagateErrors: If enabled, disk I/O errors will be reported to vdsm for
#possible resolution (eg. allocating more space)
#
-# @address: Device hardware address
+# @address: #optional Device hardware address
#
# @alias:Alias used to identify this device in commands
#
-# @deviceId: A unique ID for this device
+# @deviceId: #optional A unique ID for this device
#
# @specParams: #optional Additional device parameters
#
@@ -1972,8 +1972,8 @@
'readonly': 'bool', '*bootOrder': 'uint', '*domainID': 'UUID',
'*poolID': 'UUID', '*imageID': 'UUID', '*volumeID': 'UUID',
'format': 'VmDiskDeviceFormat', 'propagateErrors': 'bool',
- 'address': 'VmDeviceAddress', 'alias': 'str',
- 'deviceId': 'UUID', '*specParams': 'VmDiskDeviceSpecParams',
+ '*address': 'VmDeviceAddress', 'alias': 'str',
+ '*deviceId': 'UUID', '*specParams': 'VmDiskDeviceSpecParams',
'apparentsize': 'uint', 'index': 'int', 'name': 'str',
'optional': 'bool', 'shared': 'bool', 'truesize': 'uint',
'volumeChain': ['VmDiskDeviceVolumeChainEntry'],
@@ -2046,11 +2046,11 @@
# @bootOrder: #optional If specified, this device is part of the boot
# sequence at the specified position
#
-# @address: Device hardware address
+# @address: #optional Device hardware address
#
# @alias: Alias used to identify this device in commands
#
-# @deviceId: A unique ID for this device
+# @deviceId: #optional A unique ID for this device
#
# @specParams:#optional Additional device parameters
#
@@ -2066,7 +2066,7 @@
'data': {'deviceType': 'VmDeviceType', 'device': 'VmInterfaceDeviceType',
'nicModel': 'VmInterfaceDeviceModel', 'macAddr': 'str',
'network': 'str', '*bootOrder': 'uint',
- 'address': 'VmDeviceAddress', 'alias': 'str', 'deviceId': 'UUID',
+ '*address': 'VmDeviceAddress', 'alias': 'str', '*deviceId': 'UUID',
'*specParams': 'VmInterfaceDeviceSpecParams', '*linkActive': 'bool',
'*portMirroring': ['str']}}
@@ -2111,11 +2111,11 @@
#
# @device: The type of video device exposed to the VM operating system
#
-# @address: Device hardware address
+# @address: #optional Device hardware address
#
# @alias: Alias used to identify this device in commands
#
-# @deviceId:A unique ID for this device
+# @deviceId:#optional A unique ID for this device
#
# @specParams: #optional Additional device parameters
#
@@ -2123,7 +2123,7 @@
##
{'type': 'VmVideoDevice',
'data': {'deviceType': 'VmDeviceType', 'device': 'VmVideoDeviceType',
- 'address': 'VmDeviceAddress', 'alias': 'str', 'deviceId': 'UUID',
+ '*address': 'VmDeviceAddress', 'alias': 'str', '*deviceId': 'UUID',
'*specParams': 'VmVideoDeviceSpecParams'}}
##
@@ -2166,11 +2166,11 @@
#
# @device: The type of sound hardware exposed to the VM operating system
#
-# @address: Device hardware address
+# @address: #optional Device hardware address
#
# @alias: Alias used to identify this device in commands
#
-# @deviceId:A unique ID for this device
+# @deviceId:#optional A unique ID for this device
#
# @specParams: #optional Additional device parameters
#
@@ -2178,7 +2178,7 @@
##
{'type': 'VmSoundDevice',
'data': {'deviceType': 'VmDeviceType', 'device': 'VmSoundDeviceType',
- 'address': 'VmDeviceAddress', 'alias': 'str', 'deviceId': 'UUID',
+ '*address': 'VmDeviceAddress', 'alias': 'str', '*deviceId': 'UUID',
'*specParams': 'VmSoundDeviceSpecParams'}}
##
@@ -2214,17 +2214,17 @@
#
# @device: The specific type of controller device
#
-# @address: Device hardware address
+# @address: #optional Device hardware address
#
# @alias: Alias used to identify this device in commands
#
-# @deviceId:A unique ID for this device
+# @deviceId:#optional A unique ID for this device
#
# Since: 4.10.0
##
{'type': 'VmControllerDevice',
'data': {'deviceType': 'VmDeviceType', 'device': 'VmControllerDeviceType',
- 'address': 'VmDeviceAddress', 'alias': 'str', 'deviceId': 'UUID'}}
+
Change in vdsm[master]: add verb for vdsm to tuneCpu params
Adam Litke has posted comments on this change. Change subject: add verb for vdsm to tuneCpu params .. Patch Set 8: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e02e09ef06ad6de45be75c3f2f913a3025750f Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Doron Fediuck dfedi...@redhat.com Gerrit-Reviewer: Laszlo Hornyak lhorn...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Ryan Harper ry...@us.ibm.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Skip tests that behave badly when run in parallel
Adam Litke has uploaded a new change for review.
Change subject: tests: Skip tests that behave badly when run in parallel
..
tests: Skip tests that behave badly when run in parallel
A particular test: resourceManagerTests.testStressTest works by spawning lots of
threads to test the resource manager. Unfortunately, when run in parallel with
other tests (as happens on Jenkins), it can cause spurious errors in comletely
unrelated tests by causing the user to exceed its thread limit. There is no
real way around this problem other than to skip this test when tests can be
running in parallel.
To achieve this, introduce a new nose plugin (similar to SlowTestsPlugin) that
can be activated by a command line parameter or environment variable. When
active, tests marked as @nonparalleltest will be skipped.
The environment variable NOSE_SKIP_NONPARALLEL_TESTS should be added to the
Jenkins unit test job.
Change-Id: Id74717584f0c4753cec58cb1b701e7095a735924
Signed-off-by: Adam Litke a...@us.ibm.com
---
M tests/resourceManagerTests.py
M tests/testValidation.py
M tests/testrunner.py
3 files changed, 46 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/73/12173/1
diff --git a/tests/resourceManagerTests.py b/tests/resourceManagerTests.py
index c873394..2a3ada0 100644
--- a/tests/resourceManagerTests.py
+++ b/tests/resourceManagerTests.py
@@ -27,7 +27,7 @@
import storage.resourceManager as resourceManager
from testrunner import VdsmTestCase as TestCaseBase
-from testValidation import slowtest
+from testValidation import slowtest, nonparalleltest
class NullResourceFactory(resourceManager.SimpleResourceFactory):
@@ -603,6 +603,7 @@
resources.pop().release() # exclusiveReq 3
@slowtest
+@nonparalleltest
def testStressTest(self):
This tests raises thousands of threads and tries to acquire the same
diff --git a/tests/testValidation.py b/tests/testValidation.py
index 5776851..2c8d736 100644
--- a/tests/testValidation.py
+++ b/tests/testValidation.py
@@ -51,6 +51,37 @@
SlowTestsPlugin.enabled = True
+class NonParallelTestsPlugin(Plugin):
+
+When running tests concurrently on the same system, this plugin can be used
+to skip tests that only work properly when run by themselves.
+
+name = 'nonparalleltests'
+enabled = False
+
+def add_options(self, parser, env=os.environ):
+env_opt = 'NOSE_SKIP_NONPARALLEL_TESTS'
+if env is None:
+default = False
+else:
+default = env.get(env_opt)
+
+parser.add_option('--without-nonparallel-tests',
+ action='store_true',
+ default=default,
+ dest='disable_nonparallel_tests',
+ help='Some tests must be run by themselves and ' +
+ 'can cause spurious errors when run in ' +
+ 'parallel. If running tests in parallel, ' +
+ 'use this option to skip these types of ' +
+ 'tests [%s]' % env_opt)
+
+def configure(self, options, conf):
+Plugin.configure(self, options, conf)
+if options.disable_nonparallel_tests:
+NonParallelTestsPlugin.enabled = True
+
+
def ValidateRunningAsRoot(f):
@wraps(f)
def wrapper(*args, **kwargs):
@@ -86,6 +117,17 @@
return wrap
+def nonparalleltest(f):
+@wraps(f)
+def wrapper(*args, **kwargs):
+if NonParallelTestsPlugin.enabled:
+raise SkipTest(Non-parallel tests have been disabled)
+
+return f(*args, **kwargs)
+
+return wrapper
+
+
def checkSudo(cmd):
p = subprocess.Popen(['sudo', '-l', '-n'] + cmd,
stdin=subprocess.PIPE, stdout=subprocess.PIPE,
diff --git a/tests/testrunner.py b/tests/testrunner.py
index dfe9885..d999551 100644
--- a/tests/testrunner.py
+++ b/tests/testrunner.py
@@ -36,7 +36,7 @@
pthreading.monkey_patch()
-from testValidation import SlowTestsPlugin
+from testValidation import SlowTestsPlugin, NonParallelTestsPlugin
import zombieReaper
zombieReaper.registerSignalHandler()
@@ -287,6 +287,7 @@
workingDir=testdir,
plugins=core.DefaultPluginManager())
conf.plugins.addPlugin(SlowTestsPlugin())
+conf.plugins.addPlugin(NonParallelTestsPlugin())
runner = VdsmTestRunner(stream=conf.stream,
verbosity=conf.verbosity,
--
To view, visit http://gerrit.ovirt.org/12173
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id74717584f0c4753cec58cb1b701e7095a735924
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
___
Change in vdsm[master]: tests: Skip tests that behave badly when run in parallel
Adam Litke has posted comments on this change. Change subject: tests: Skip tests that behave badly when run in parallel .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74717584f0c4753cec58cb1b701e7095a735924 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Skip stress tests that behave badly when run in paral...
Adam Litke has posted comments on this change. Change subject: tests: Skip stress tests that behave badly when run in parallel .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74717584f0c4753cec58cb1b701e7095a735924 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: fix Exception message error in apiTests module
Adam Litke has posted comments on this change. Change subject: fix Exception message error in apiTests module .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic51b141047dc0490e50a050fd667f63d30f121f2 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: add a json rpc funtional test which sets up a VM
Adam Litke has posted comments on this change.
Change subject: add a json rpc funtional test which sets up a VM
..
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
File tests/functional/jsonrpcTests.py
Line 1: #
Line 2: # Copyright 2012 Red Hat, Inc.
You wrote this file, right? The copyright should be to you and IBM and in 2013
Line 3: #
Line 4: # This program is free software; you can redistribute it and/or modify
Line 5: # it under the terms of the GNU General Public License as published by
Line 6: # the Free Software Foundation; either version 2 of the License, or
Line 109: kernelArgsDistro['rhel'] = kernelArgsDistro['fedora']
Line 110: if distro.lower() not in kernelArgsDistro:
Line 111: raise SkipTest(Don't know how to perform direct kernel
boot for
Line 112:%s % distro)
Line 113:
Can you also to an access test for the kernel and initrd? I've found that
tests like this fail because with selinux and svirt enabled, the qemu process
cannot access the kernel and initrd.
Line 114: template = {'vmId': '-abcd---',
Line 115: 'vmName': 'vdsmKernelBootVM',
Line 116: 'display': 'vnc',
Line 117: 'kvmEnable': 'true',
--
To view, visit http://gerrit.ovirt.org/11386
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I734614fdc9515e2883004aceafb36291ee44e59a
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blocksd: skip broken images in getAllVolumes
Adam Litke has posted comments on this change. Change subject: blocksd: skip broken images in getAllVolumes .. Patch Set 2: FYI: This may be a candidate for fixing https://bugzilla.redhat.com/show_bug.cgi?id=910013 -- To view, visit http://gerrit.ovirt.org/11859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9bbf7eecdb11873dd5fe9bef2afaa680aecbc32 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Organize schema symbols by type
Adam Litke has uploaded a new change for review.
Change subject: api: Organize schema symbols by type
..
api: Organize schema symbols by type
Currently the vdsmapi module returns the parsed schema as a large list of
symbols. Consumers of this list have all resorted to reorganizing the symbols
by type (commands, types, enums, maps, etc). Rather than forcing each user to
rewrite this code, just do it correctly at the source. This reduces code
duplication and makes at easier to add new symbol types (such as events and
errors).
Signed-off-by: Adam Litke a...@us.ibm.com
Change-Id: Ie20291689c402e3f49267181eeb96f2cedbe9690
---
M vdsm_api/vdsmapi.py
1 file changed, 122 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/12106/1
diff --git a/vdsm_api/vdsmapi.py b/vdsm_api/vdsmapi.py
index 889da71..f154e99 100644
--- a/vdsm_api/vdsmapi.py
+++ b/vdsm_api/vdsmapi.py
@@ -24,6 +24,9 @@
# Refer to the README and COPYING files for full details of the license
#
+import os
+from vdsm import constants
+
try:
from collections import OrderedDict
OrderedDict # make pyflakes happy
@@ -107,3 +110,122 @@
exprs.append(expr_eval)
return exprs
+
+
+def find_schema():
+
+Find the API schema file whether we are running from within the source dir
+or from an installed location
+
+localpath = os.path.dirname(__file__)
+installedpath = constants.P_VDSM
+for directory in localpath, installedpath:
+path = os.path.join(directory, 'vdsmapi-schema.json')
+if os.access(path, os.R_OK):
+return path
+raise Exception(Unable to find API schema file in %s or %s,
+localpath, installedpath)
+
+
+_api_info = None
+
+
+def _load_api_info(schema):
+
+Organize API information from the schema file into a useful structure:
+
+types: A dictionary of type symbols indexed by type name
+{
+ 'type': type name
+ 'data': dict containing this type's attributes in name/type pairs
+ 'union': an optional list of child types to which this type is castable
+}
+
+enums: A dictionary of enum symbols indexed by enum name
+{
+ 'enum': enum name,
+ 'data': a list of valid values
+}
+
+aliases: A dictionary of alias symbols indexed by alias name
+{
+ 'alias': alias name
+ 'data': aliased type
+}
+
+maps: A dictionary of mapping types indexed by name
+{
+ 'map': the name of the mapping type
+ 'key': the type for this map's keys
+ 'value': the type for this map's values
+}
+
+commands: A dictionary of command namespaces indexed by namespace name that
+contains dictionaries of command symbols indexed by command name
+{
+ 'command'
+ {
+ 'class': the namespace to which the command belongs
+ 'name': the command name
+ }
+ 'data': an optional ordered dictionary of parameters in name/type pairs
+ 'returns': the type of the return value, if any
+}
+
+unions: A dictionary that describes valid casts between related types.
+Each key is a source type that is castable and the value is a list of types
+to which the source type may be cast.
+
+global _api_info
+
+info_key = schema
+if schema is None:
+schema = find_schema()
+with open(schema) as f:
+symbols = parse_schema(f)
+
+info = {'types': {}, 'enums': {}, 'aliases': {}, 'maps': {},
+'commands': {}, 'unions': {}}
+
+for s in symbols:
+if 'alias' in s:
+info['aliases'][s['alias']] = s
+elif 'type' in s:
+info['types'][s['type']] = s
+elif 'enum' in s:
+info['enums'][s['enum']] = s
+elif 'map' in s:
+info['maps'][s['map']] = s
+elif 'command' in s:
+ns = s['command']['class']
+cmd = s['command']['name']
+if ns not in info['commands']:
+info['commands'][ns] = {cmd: s}
+else:
+info['commands'][ns][cmd] = s
+
+# Determine the valid casts
+def add_relation(mapping, typeA, typeB):
+if typeA in mapping:
+mapping[typeA].append(typeB)
+else:
+mapping[typeA] = [typeB, ]
+
+for t in info['types'].values():
+if 'union' not in t:
+continue
+for u in t['union']:
+add_relation(info['unions'], u, t['type'])
+add_relation(info['unions'], t['type'], u)
+
+_api_info = {info_key: info}
+
+
+def get_api(schema=None):
+
+Get organized information about the vdsm API. If schema is specified,
+read from a specific file. Otherwise try to find the schema automatically.
+
+if _api_info is None or schema not in _api_info:
+_load_api_info(schema)
+return _api_info[schema]
--
To view, visit http://gerrit.ovirt.org/12106
To
Change in vdsm[master]: api: Convert schemaTests to use vdsmapi.get_api
Adam Litke has uploaded a new change for review. Change subject: api: Convert schemaTests to use vdsmapi.get_api .. api: Convert schemaTests to use vdsmapi.get_api Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4 Signed-off-by: Adam Litke a...@us.ibm.com --- M tests/schemaTests.py 1 file changed, 1 insertion(+), 22 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/08/12108/1 diff --git a/tests/schemaTests.py b/tests/schemaTests.py index 9bf4b5b..ae82b9f 100644 --- a/tests/schemaTests.py +++ b/tests/schemaTests.py @@ -18,30 +18,9 @@ # from testrunner import VdsmTestCase as TestCaseBase -import os.path import vdsmapi -from vdsm import constants - - -def findSchema(): - -Find the API schema file whether we are running tests from the source dir -or from the tests install location - -scriptdir = os.path.dirname(__file__) -localpath = os.path.join(scriptdir, '../vdsm_api/vdsmapi-schema.json') -installedpath = os.path.join(constants.P_VDSM, 'vdsmapi-schema.json') -for f in localpath, installedpath: -if os.access(f, os.R_OK): -return f -raise Exception(Unable to find schema in %s or %s % (localpath, - installedpath)) class SchemaTest(TestCaseBase): -def setUp(self): -self.schema = findSchema() - def testSchemaParse(self): -with open(self.schema) as f: -vdsmapi.parse_schema(f) +self.assertTrue(isinstance(vdsmapi.get_api(), dict)) -- To view, visit http://gerrit.ovirt.org/12108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Move DynamicBridge to vdsmapi schema processing
Adam Litke has uploaded a new change for review.
Change subject: api: Move DynamicBridge to vdsmapi schema processing
..
api: Move DynamicBridge to vdsmapi schema processing
Signed-off-by: Adam Litke a...@us.ibm.com
Change-Id: I0bbcc2475a40749c959eade157f6030b2c2f5e71
---
M tests/apiTests.py
M vdsm/clientIF.py
M vdsm_api/Bridge.py
M vdsm_api/jsonrpc/__init__.py
4 files changed, 29 insertions(+), 59 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/07/12107/1
diff --git a/tests/apiTests.py b/tests/apiTests.py
index 7ad8a1f..5275391 100644
--- a/tests/apiTests.py
+++ b/tests/apiTests.py
@@ -27,7 +27,6 @@
from contextlib import closing
from testrunner import VdsmTestCase as TestCaseBase
-from vdsm import constants
import BindingJsonRpc
import jsonrpc
import apiData
@@ -110,21 +109,6 @@
sys.modules['API'] = _newAPI
-def findSchema():
-
-Find the API schema file whether we are running tests from the source dir
-or from the tests install location
-
-scriptdir = os.path.dirname(__file__)
-localpath = os.path.join(scriptdir, '../vdsm_api/vdsmapi-schema.json')
-installedpath = os.path.join(constants.P_VDSM, 'vdsmapi-schema.json')
-for f in localpath, installedpath:
-if os.access(f, os.R_OK):
-return f
-raise Exception(Unable to find schema in %s or %s,
-localpath, installedpath)
-
-
def setUpModule():
Set up the environment for all tests:
@@ -140,12 +124,11 @@
handler.setLevel(logging.INFO)
log.addHandler(handler)
-schema = findSchema()
createFakeAPI()
# Bridge imports the API module so we must set up the fake API first
import Bridge
-bridge = Bridge.DynamicBridge(schema)
+bridge = Bridge.DynamicBridge()
# Support parallel testing. Try hard to find an open port to use
port = getFreePort()
diff --git a/vdsm/clientIF.py b/vdsm/clientIF.py
index 841e962..ef9a19b 100644
--- a/vdsm/clientIF.py
+++ b/vdsm/clientIF.py
@@ -153,11 +153,10 @@
def _loadBindingJsonRpc(self):
from BindingJsonRpc import BindingJsonRpc
from Bridge import DynamicBridge
-schema = os.path.join(constants.P_VDSM, 'vdsmapi-schema.json')
ip = self._getServerIP(config.get('addresses', 'management_ip'))
port = config.getint('addresses', 'json_port')
conf = [('tcp', {ip: ip, port: port})]
-self.bindings['json'] = BindingJsonRpc(DynamicBridge(schema), conf)
+self.bindings['json'] = BindingJsonRpc(DynamicBridge(), conf)
def _prepareBindings(self):
self.bindings = {}
diff --git a/vdsm_api/Bridge.py b/vdsm_api/Bridge.py
index 8fade0f..cc3f227 100644
--- a/vdsm_api/Bridge.py
+++ b/vdsm_api/Bridge.py
@@ -29,8 +29,8 @@
class DynamicBridge(object):
-def __init__(self, schema):
-self._parseSchema(schema)
+def __init__(self):
+self.api = vdsmapi.get_api()
def dispatch(self, name, argobj):
methodName = name.replace('.', '_')
@@ -60,30 +60,13 @@
except KeyError:
raise VdsmError(5, Response is missing '%s' member % member)
-def _parseSchema(self, schema):
-self.commands = {}
-self.classes = {}
-self.types = {}
-with open(schema) as f:
-symbols = vdsmapi.parse_schema(f)
-for s in symbols:
-if 'command' in s:
-key = %s_%s % (s['command']['class'],
- s['command']['name'])
-self.commands[key] = s
-elif 'class' in s:
-cls = s['class']
-self.classes[cls] = s
-elif 'type' in s:
-t = s['type']
-self.types[t] = s
-
def __getattr__(self, attr):
-if attr in self.commands:
+try:
className, methodName = attr.split('_')
-return partial(self._dynamicMethod, className, methodName)
-else:
+self.api['commands'][className][methodName]
+except (KeyError, ValueError):
raise AttributeError(Attribute not found '%s' % attr)
+return partial(self._dynamicMethod, className, methodName)
def _convertClassName(self, name):
@@ -97,7 +80,7 @@
except KeyError:
return name
-def _getMethodArgs(self, className, cmd, argObj):
+def _getMethodArgs(self, className, methodName, argObj):
An internal API call currently looks like:
@@ -109,10 +92,11 @@
them from here. For any given method, the method_args are obtained by
chopping off the ctor_args from the beginning of argObj.
-className = self._convertClassName(className)
# Get the full argument list
-allArgs = self.commands[cmd].get('data', {}).keys()
+sym =
Change in vdsm[master]: api: Convert process_schema.py to use vdsmapi.get_api()
Adam Litke has uploaded a new change for review.
Change subject: api: Convert process_schema.py to use vdsmapi.get_api()
..
api: Convert process_schema.py to use vdsmapi.get_api()
Change-Id: Id4f6ec96f503b41fc1c976f515feb15a58a33747
Signed-off-by: Adam Litke a...@us.ibm.com
---
M vdsm_api/process-schema.py
1 file changed, 36 insertions(+), 38 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/09/12109/1
diff --git a/vdsm_api/process-schema.py b/vdsm_api/process-schema.py
index e8de198..c4bda0d 100755
--- a/vdsm_api/process-schema.py
+++ b/vdsm_api/process-schema.py
@@ -35,7 +35,7 @@
typeKinds = ('class', 'type', 'enum', 'map', 'union', 'alias')
-def read_symbol_comment(f, symbols):
+def read_symbol_comment(f, api):
In the VDSM API schema, each entity is preceeded by a comment that provides
additional human-readable information about the entity. The format of this
@@ -61,24 +61,21 @@
##
-def find_symbol(symbols, name):
+def find_symbol(api, name):
Find a symbol by name in the vdsmapi parsed symbol list.
-for s in symbols:
-if '.' in name:
-cls, member = name.split('.')
-if member == 'init' and s.get('init') == cls:
-return s
-if 'command' not in s:
-continue
-if s['command']['class'] == cls and \
-s['command']['name'] == member:
-return s
-else:
-for k in typeKinds:
-if s.get(k) == name:
-return s
+if '.' in name:
+# This is a command
+ns, method = name.split('.')
+try:
+return api['commands'][ns][method]
+except KeyError:
+pass
+else:
+for sType in ('types', 'enums', 'aliases', 'maps'):
+if name in api[sType]:
+return api[sType][name]
raise ValueError(symbol: %s not found % name)
# Parse one complete comment block. Blocks begin and end with '^##'.
@@ -96,8 +93,12 @@
m = re.search('^\@(.*):$', line)
name = m.group(1)
+# We skip namespace definitions since there is nothing to document
+if name in api['commands']:
+return
+
# Find the already processed symbol information
-symbol = find_symbol(symbols, name)
+symbol = find_symbol(api, name)
symbol.update({'name': name, 'info_data': {}, 'info_return': '',
'xxx': []})
@@ -157,7 +158,7 @@
return symbol
-def read_schema_doc(f, symbols):
+def read_schema_doc(f, api):
Read all of the documentation information from the schema and attach it to
the relavent symbol definitions we have already parsed.
@@ -165,9 +166,9 @@
while True:
line = f.readline()
if not line:
-return symbols
+return api
if line.strip() == '##':
-read_symbol_comment(f, symbols)
+read_symbol_comment(f, api)
continue
@@ -287,7 +288,7 @@
f.write('/pbr/\n')
-def create_doc(symbols, filename):
+def create_doc(api, filename):
f = open(filename, 'w')
header =
@@ -317,17 +318,16 @@
f.write(header)
-# Sort commands by their expanded names
-cmdKey = lambda k: k.get('command', {}).get('class', '') + '.' + \
-k.get('command', {}).get('name', '')
-commands = [s for s in sorted(symbols, key=cmdKey)
-if 'command' in s]
-# Types come after commands but they are not sorted
-types = [s for s in symbols if 'command' not in s]
-for s in commands:
-write_symbol(f, s)
-for s in types:
-write_symbol(f, s)
+# First, write out commands in sorted order
+for ns in sorted(api['commands'].iterkeys()):
+for cmd in sorted(api['commands'][ns].iterkeys()):
+write_symbol(f, api['commands'][ns][cmd])
+
+# Write out the data types
+for sType in ('aliases', 'types', 'maps', 'enums'):
+for name in sorted(api[sType].iterkeys()):
+write_symbol(f, api[sType][name])
+
f.write(footer)
@@ -358,15 +358,13 @@
schema = sys.argv[1]
output = sys.argv[2]
-symbols = None
-# First read in the progmatic schema definition
-with open(schema) as f:
-symbols = vdsmapi.parse_schema(f)
-verify_symbols(symbols)
+api = vdsmapi.get_api(schema)
+#verify_symbols(symbols)
# Now merge in the information from the comments
with open(schema) as f:
-symbols = read_schema_doc(f, symbols)
+symbols = read_schema_doc(f, api)
+
create_doc(symbols, output)
--
To view, visit http://gerrit.ovirt.org/12109
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType:
Change in vdsm[master]: gluster: add task support
Adam Litke has posted comments on this change.
Change subject: gluster: add task support
..
Patch Set 4: I would prefer that you didn't submit this
(1 inline comment)
Some TODO items regarding the schema.
File vdsm_api/glusterapi-schema.json
Line 37: # Start rebalance of given volume.
Line 38: #
Line 39: # @volumeName: Gluster volume name
Line 40: #
Line 41: ##
Try running this file through process-schema.py in vdsm_api. That will show
you the places where this schema file is not quite compatible with the expected
format. For example, you have no 'Since' tags. Also, you are missing the
return information for some of these commands.
Line 42: {'command': {'class': 'GlusterVolume', 'name': 'rebalanceStart'},
Line 43: 'data': {'volumeName': 'str'}}
Line 44:
Line 45: ##
--
To view, visit http://gerrit.ovirt.org/10200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I154df353bc6f23001d7bf61b8f5345abd2019cb6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Bala.FA barum...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Shireesh Anjal san...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Organize schema symbols by type
Adam Litke has posted comments on this change. Change subject: api: Organize schema symbols by type .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie20291689c402e3f49267181eeb96f2cedbe9690 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Remove some unneeded functions from vdsmapi.py
Adam Litke has posted comments on this change. Change subject: api: Remove some unneeded functions from vdsmapi.py .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/11865 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I25d534033f089bf9f36592bd2be0e98f2fde2dfe Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Separate api schema into its own package
Adam Litke has posted comments on this change. Change subject: api: Separate api schema into its own package .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/11864 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ae8d6e57c11bf89d6c695df7cf80b436495069e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert schemaTests to use vdsmapi.get_api
Adam Litke has posted comments on this change. Change subject: api: Convert schemaTests to use vdsmapi.get_api .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12108 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3e5716fcb9724621f4fb282746bf02958b1972d4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Convert process_schema.py to use vdsmapi.get_api()
Adam Litke has posted comments on this change. Change subject: api: Convert process_schema.py to use vdsmapi.get_api() .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12109 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4f6ec96f503b41fc1c976f515feb15a58a33747 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Avoid ResourceManagerTests failures when running para...
Adam Litke has posted comments on this change. Change subject: tests: Avoid ResourceManagerTests failures when running parallel tests .. Patch Set 2: (1 inline comment) File tests/resourceManagerTests.py Line 643: def tryThread(fn, *args): Line 644: t = threading.Thread(target=fn, args=args) Line 645: try: Line 646: t.start() Line 647: except: Done Line 648: stop.set() Line 649: while len(resources) 0: Line 650: res = resources.pop() Line 651: res.release() -- To view, visit http://gerrit.ovirt.org/12034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd18d683ea3b8f72d569a6151066179ef21d3d26 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Avoid ResourceManagerTests failures when running para...
Adam Litke has posted comments on this change. Change subject: tests: Avoid ResourceManagerTests failures when running parallel tests .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/12034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd18d683ea3b8f72d569a6151066179ef21d3d26 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Added a support for a guest hibernate command.
Adam Litke has posted comments on this change.
Change subject: Added a support for a guest hibernate command.
..
Patch Set 15: I would prefer that you didn't submit this
(1 inline comment)
File vdsm_api/vdsmapi-schema.json
Line 5158: # Since: 4.10.0
Line 5159: ##
Line 5160: {'union': 'HibernateTarget',
Line 5161: 'data': ['HibernationVolumeHandle', 'HibernateState']}
Line 5162:
This is invalid syntax for a union (but I think it may have been valid in an
earlier incarnation of the schema). Take a look at other unions in the schema
for a correct example:
##
# @NetInfoNetwork:
#
# A discriminated record to store information about a VDSM network.
#
# @bridged: If True, the union is a 'NetInfoBridgedNetwork'
#If False, the union is a 'NetInfoBridgelessNetwork'
#
# Since: 4.10.0
##
{'type': 'NetInfoNetwork',
'data': {'bridged': 'bool'},
'union': ['NetInfoBridgedNetwork', 'NetInfoBridgelessNetwork']}
Line 5163: ##
Line 5164: # @VM.hibernate:
Line 5165: #
Line 5166: # Save the live state of the VM to disk and stop it.
--
To view, visit http://gerrit.ovirt.org/1121
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ad6836e61e9d91ec6f46a599541f61ff12e9737
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Ayal Baron aba...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Gal Hammer gham...@redhat.com
Gerrit-Reviewer: Haim Ateya hat...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Peter V. Saveliev p...@redhat.com
Gerrit-Reviewer: ShaoHe Feng shao...@linux.vnet.ibm.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Zhou Zheng Sheng zhshz...@linux.vnet.ibm.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Make getFreePort work in a multithreaded environment
Adam Litke has uploaded a new change for review. Change subject: tests: Make getFreePort work in a multithreaded environment .. tests: Make getFreePort work in a multithreaded environment getFreePort does not currently work reliably if multiple copies are running concurrently. Since each copy starts at the same port, the chance of choosing the same port number at the same time is great. Switch to letting the OS find an available port. This should fix the intermittent failures of jsonRpcTests and apiTests. Change-Id: I6adcdde3fd0312ec532b261107af45dbc87f34f3 Signed-off-by: Adam Litke a...@us.ibm.com --- M tests/jsonRpcUtils.py 1 file changed, 4 insertions(+), 19 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/12028/1 diff --git a/tests/jsonRpcUtils.py b/tests/jsonRpcUtils.py index 020f64a..66968e8 100644 --- a/tests/jsonRpcUtils.py +++ b/tests/jsonRpcUtils.py @@ -23,29 +23,14 @@ pass -_PORT_RANGE = xrange(49152, 65535) - - -_distributedPorts = [] - - def getFreePort(): sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM) with closing(sock): -for port in _PORT_RANGE: -if port in _distributedPorts: -continue - -try: -sock.bind((0.0.0.0, port)) -except: -continue - -_distributedPorts.append(port) -return port -else: +try: +sock.bind((0.0.0.0, 0)) +except: raise Exception(Could not find a free port) - +return sock.getsockname()[1] @contextmanager def _tcpServerConstructor(messageHandler): -- To view, visit http://gerrit.ovirt.org/12028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6adcdde3fd0312ec532b261107af45dbc87f34f3 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Make getFreePort work in a multithreaded environment
Adam Litke has posted comments on this change. Change subject: tests: Make getFreePort work in a multithreaded environment .. Patch Set 2: Verified I can locally run 8 copies of the tests at the same time with this patch. -- To view, visit http://gerrit.ovirt.org/12028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6adcdde3fd0312ec532b261107af45dbc87f34f3 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Avoid ResourceManagerTests failures when running para...
Adam Litke has uploaded a new change for review. Change subject: tests: Avoid ResourceManagerTests failures when running parallel tests .. tests: Avoid ResourceManagerTests failures when running parallel tests In the Jenkins test environment, tests are run in parallel. ResourceManagerTests.testStressTest spawns lots of threads and can easily exceed the system limit when multiple copies are active. To prevent failures in this case, allow the test to fallback to single threaded mode when more threads cannot be created. This does mean that the test may be less rigorous when run in parallel but I don't see a better way to work around this false positive issue. The test will still be full strength when run alone. Change-Id: Ibd18d683ea3b8f72d569a6151066179ef21d3d26 Signed-off-by: Adam Litke a...@us.ibm.com --- M tests/resourceManagerTests.py 1 file changed, 17 insertions(+), 13 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/34/12034/1 diff --git a/tests/resourceManagerTests.py b/tests/resourceManagerTests.py index c873394..58de49e 100644 --- a/tests/resourceManagerTests.py +++ b/tests/resourceManagerTests.py @@ -637,6 +637,15 @@ res.release() threadLimit.release() +def tryThread(fn, *args): +t = threading.Thread(target=fn, args=args) +try: +t.start() +except: +fn(*args) +else: +threads.append(t) + manager = self.manager rnd = Random() @@ -645,9 +654,8 @@ threads = [] for i in range(nthreads): -threadLimit.acquire() -threads.append(threading.Thread(target=register)) -threads[-1].start() +threadLimit.acquire() +tryThread(register) while len(threads) 0: for t in threads[:]: @@ -657,18 +665,14 @@ while len(resources) 0: while len(resources) 1: threadLimit.acquire() -threads.append( -threading.Thread(target=releaseShared, - args=[requests.pop(), - resources.pop()])) -threads[-1].start() +req = requests.pop() +res = resources.pop() +tryThread(releaseShared, req, res) threadLimit.acquire() -threads.append( -threading.Thread(target=releaseUnknown, - args=[requests.pop(), - resources.pop()])) -threads[-1].start() +req = requests.pop() +res = resources.pop() +tryThread(releaseUnknown, req, res) def tearDown(self): manager = self.manager -- To view, visit http://gerrit.ovirt.org/12034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd18d683ea3b8f72d569a6151066179ef21d3d26 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Avoid ResourceManagerTests failures when running para...
Adam Litke has posted comments on this change. Change subject: tests: Avoid ResourceManagerTests failures when running parallel tests .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/12034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd18d683ea3b8f72d569a6151066179ef21d3d26 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: Avoid ResourceManagerTests failures when running para...
Adam Litke has posted comments on this change. Change subject: tests: Avoid ResourceManagerTests failures when running parallel tests .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/12034 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd18d683ea3b8f72d569a6151066179ef21d3d26 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blocksd: skip broken images in getAllVolumes
Adam Litke has posted comments on this change. Change subject: blocksd: skip broken images in getAllVolumes .. Patch Set 2: Looks good to me, but someone else must approve Yes please! We are actually seeing this in a production system and it's causing us a lot of grief. Once the damage has been done, we'd at least like to move on and not have the whole environment broken. -- To view, visit http://gerrit.ovirt.org/11859 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib9bbf7eecdb11873dd5fe9bef2afaa680aecbc32 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Ayal Baron aba...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Eduardo ewars...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Itamar Heim ih...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Separate api schema into its own package
Adam Litke has uploaded a new change for review.
Change subject: api: Separate api schema into its own package
..
api: Separate api schema into its own package
The vdsm schema definition is needed by the vdsm server but also by clients.
Split the shema into its own package so it can be installed by clients without
pulling in server-side dependencies.
Change-Id: I6ae8d6e57c11bf89d6c695df7cf80b436495069e
Signed-off-by: Adam Litke a...@us.ibm.com
---
M vdsm.spec.in
M vdsm_api/Makefile.am
2 files changed, 19 insertions(+), 4 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/64/11864/1
diff --git a/vdsm.spec.in b/vdsm.spec.in
index dcbfbb6..a0033e8 100644
--- a/vdsm.spec.in
+++ b/vdsm.spec.in
@@ -183,11 +183,20 @@
An XMLRPC interface for interacting with vdsmd. Primary control interface for
ovirt-engine and vdsClient.
+%package api
+Summary:VDSM API definition
+BuildArch: noarch
+
+%description api
+Provides the VDSM API schema and documentation.
+
%package jsonrpc
Summary:VDSM API Server
BuildArch: noarch
Requires: %{name}-python = %{version}-%{release}
+Requires: %{name}-yajsonrpc = %{version}-%{release}
+Requires: %{name}-api = %{version}-%{release}
%if 0%{?rhel} == 6
Requires: python-ordereddict
%endif
@@ -616,7 +625,7 @@
%files
%defattr(-, root, root, -)
-%doc COPYING README vdsm/vdsm.conf.sample vdsm_api/vdsm-api.html
+%doc COPYING README vdsm/vdsm.conf.sample
%if 0%{?rhel}
%{_initrddir}/vdsmd
%else
@@ -952,11 +961,14 @@
%defattr(-, root, root, -)
%{_datadir}/%{vdsm_name}/BindingXMLRPC.py*
+%files api
+%doc vdsm_api/vdsm-api.html
+%{_datadir}/%{vdsm_name}/vdsmapi-schema.json
+%{python_sitearch}/vdsmapi.py*
+
%files jsonrpc
%{_datadir}/%{vdsm_name}/BindingJsonRpc.py*
%{_datadir}/%{vdsm_name}/Bridge.py*
-%{_datadir}/%{vdsm_name}/vdsmapi.py*
-%{_datadir}/%{vdsm_name}/vdsmapi-schema.json
%files yajsonrpc
%{python_sitearch}/yajsonrpc/__init__.py*
diff --git a/vdsm_api/Makefile.am b/vdsm_api/Makefile.am
index 6d1548b..d022082 100644
--- a/vdsm_api/Makefile.am
+++ b/vdsm_api/Makefile.am
@@ -10,13 +10,16 @@
dist_vdsm_PYTHON = \
BindingJsonRpc.py \
Bridge.py \
- vdsmapi.py \
$(NULL)
dist_vdsm_DATA = \
vdsmapi-schema.json \
$(NULL)
+dist_pyexec_PYTHON = \
+ vdsmapi.py \
+ $(NULL)
+
nodist_noinst_DATA = \
vdsm-api.html \
$(NULL)
--
To view, visit http://gerrit.ovirt.org/11864
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6ae8d6e57c11bf89d6c695df7cf80b436495069e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: api: Remove some unneeded functions from vdsmapi.py
Adam Litke has uploaded a new change for review.
Change subject: api: Remove some unneeded functions from vdsmapi.py
..
api: Remove some unneeded functions from vdsmapi.py
Change-Id: I25d534033f089bf9f36592bd2be0e98f2fde2dfe
Signed-off-by: Adam Litke a...@us.ibm.com
---
M vdsm_api/vdsmapi.py
1 file changed, 0 insertions(+), 142 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/65/11865/1
diff --git a/vdsm_api/vdsmapi.py b/vdsm_api/vdsmapi.py
index c68daa1..889da71 100644
--- a/vdsm_api/vdsmapi.py
+++ b/vdsm_api/vdsmapi.py
@@ -97,10 +97,6 @@
expr += line
elif expr:
expr_eval = evaluate(expr)
-if 'enum' in expr_eval:
-add_enum(expr_eval['enum'])
-elif 'union' in expr_eval:
-add_enum('%sKind' % expr_eval['union'])
exprs.append(expr_eval)
expr = line
else:
@@ -108,144 +104,6 @@
if expr:
expr_eval = evaluate(expr)
-if 'enum' in expr_eval:
-add_enum(expr_eval['enum'])
-elif 'union' in expr_eval:
-add_enum('%sKind' % expr_eval['union'])
exprs.append(expr_eval)
return exprs
-
-
-def parse_args(typeinfo):
-for member in typeinfo:
-argname = member
-argentry = typeinfo[member]
-optional = False
-structured = False
-if member.startswith('*'):
-argname = member[1:]
-optional = True
-if isinstance(argentry, OrderedDict):
-structured = True
-yield (argname, argentry, optional, structured)
-
-
-def de_camel_case(name):
-new_name = ''
-for ch in name:
-if ch.isupper() and new_name:
-new_name += '_'
-if ch == '-':
-new_name += '_'
-else:
-new_name += ch.lower()
-return new_name
-
-
-def camel_case(name):
-new_name = ''
-first = True
-for ch in name:
-if ch in ['_', '-']:
-first = True
-elif first:
-new_name += ch.upper()
-first = False
-else:
-new_name += ch.lower()
-return new_name
-
-
-def c_var(name):
-return name.replace('-', '_').lstrip(*)
-
-
-def c_fun(name):
-return c_var(name).replace('.', '_')
-
-
-def c_list_type(name):
-return '%sList' % name
-
-
-def type_name(name):
-if type(name) == list:
-return c_list_type(name[0])
-return name
-
-
-enum_types = []
-
-
-def add_enum(name):
-global enum_types
-enum_types.append(name)
-
-
-def is_enum(name):
-global enum_types
-return (name in enum_types)
-
-
-def c_type(name):
-if name == 'str':
-return 'char *'
-elif name == 'int':
-return 'int64_t'
-elif name == 'bool':
-return 'bool'
-elif name == 'number':
-return 'double'
-elif type(name) == list:
-return '%s *' % c_list_type(name[0])
-elif is_enum(name):
-return name
-elif name is None or len(name) == 0:
-return 'void'
-elif name == name.upper():
-return '%sEvent *' % camel_case(name)
-else:
-return '%s *' % name
-
-
-def genindent(count):
-ret =
-for i in range(count):
-ret +=
-return ret
-
-
-indent_level = 0
-
-
-def push_indent(indent_amount=4):
-global indent_level
-indent_level += indent_amount
-
-
-def pop_indent(indent_amount=4):
-global indent_level
-indent_level -= indent_amount
-
-
-def cgen(code, **kwds):
-indent = genindent(indent_level)
-lines = code.split('\n')
-lines = map(lambda x: indent + x, lines)
-return '\n'.join(lines) % kwds + '\n'
-
-
-def mcgen(code, **kwds):
-return cgen('\n'.join(code.split('\n')[1:-1]), **kwds)
-
-
-def basename(filename):
-return filename.split(/)[-1]
-
-
-def guardname(filename):
-guard = basename(filename).rsplit(., 1)[0]
-for substr in [., , -]:
-guard = guard.replace(substr, _)
-return guard.upper() + '_H'
--
To view, visit http://gerrit.ovirt.org/11865
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I25d534033f089bf9f36592bd2be0e98f2fde2dfe
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Fix race in ProtonReactor and add better delivery s...
Adam Litke has posted comments on this change. Change subject: jsonrpc: Fix race in ProtonReactor and add better delivery semantics .. Patch Set 11: Looks good to me, but someone else must approve Thanks for the explanation Saggi. -- To view, visit http://gerrit.ovirt.org/10256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie53d6f4b8a119f8a9e366b717c22ba38bcc99e80 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Implement python bindings
Adam Litke has posted comments on this change.
Change subject: [WIP] Implement python bindings
..
Patch Set 2: (7 inline comments)
File vdsm_api/vdsmapi-schema.json
Line 2341: # @deviceType: The device type (always @balloon)
Line 2342: #
Line 2343: # @device: The the type of balloon device
Line 2344: #
Line 2345: # @address: #optional Device hardware address
yes.
Line 2346: #
Line 2347: # @alias: Alias used to identify this device in commands
Line 2348: #
Line 2349: # @specParams: #optional Additional device parameters
File vdsm_api/vdsm_client/generate.py
Line 119: def generate_file_top(f):
Line 120: f.write(pygen('''##
Line 121: # AUTOMATICALLY GENERATED, DO NOT MODIFY
Line 122: ##
Line 123: # Copyright (C) 2013 Adam Litke, IBM Corporation
It's a derived work so the copyright of the generator should apply to the
generated file. At least that seems the safest to me.
Line 124: #
Line 125: # This program is free software; you can redistribute it and/or modify
Line 126: # it under the terms of the GNU General Public License as published by
Line 127: # the Free Software Foundation; either version 2 of the License, or
Line 138: #
Line 139: # Refer to the README and COPYING files for full details of the
license
Line 140: ##
Line 141:
Line 142: from modelBase import encode, VdsmRequest, CommandNamespace, BaseType
Fair point.
Line 143: '''))
Line 144:
Line 145:
Line 146: def generate_file_bottom(f):
Line 158:
Line 159: for val in enum['data']:
Line 160: name = val.replace('-', '_').replace(' ', '_').upper()
Line 161: ret += mpygen('''
Line 162: %(name)s = '%(value)s'
For now. They need to have some representation and string seemed the most
appropriate to me as that's how vdsm represents it today.
Line 163: ''', name=name, value=val.lower())
Line 164: f.write(ret)
Line 165:
Line 166:
Line 350: if name in aliased_types:
Line 351: name = aliased_types[name]
Line 352: return name
Line 353:
Line 354:
sure.
Line 355:
###
Line 356: indent_level = 0
Line 357: namespaces = {}
Line 358: enum_types = []
Line 361: aliased_types = {}
Line 362: union_members = {}
Line 363:
Line 364:
Line 365: errors = [
Ok.
Line 366: {'code': 1, 'name': 'PROTOCOL_ERROR', 'message': ''},
Line 367: {'code': 2, 'name': 'CONNECTION_ERROR', 'message': ''},
Line 368: {'code': 3, 'name': 'OPERATION_CANCELLED', 'message': ''},
Line 369: {'code': 4, 'name': 'OPERATION_NOT_SUPPORTED', 'message': ''},
File vdsm.spec.in
Line 207: %package client-python
Line 208: Summary:VDSM client library for python
Line 209: BuildArch: noarch
Line 210: Requires: %{name}-yajsonrpc = %{version}-%{release}
Line 211: Requires: %{name}-jsonrpc = %{version}-%{release}
%{_datadir}/%{vdsm_name}/vdsmapi.py*
%{_datadir}/%{vdsm_name}/vdsmapi-schema.json
These could probably be split into a vdsm-api package. Though I wonder if we
are creating too many sub-packages here.
Line 212: Requires: %{name}-python = %{version}-%{release}
Line 213:
Line 214: %description client-python
Line 215: A module for accessing the vdsm API from python programs
--
To view, visit http://gerrit.ovirt.org/11755
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3f22966348c4c459710d79e1d97f98e2280d7022
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Make jsonrpc an independent package
Adam Litke has posted comments on this change. Change subject: jsonrpc: Make jsonrpc an independent package .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e5718d56e09e7f6ad36bc3b2f241c03bbaf08b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Fix race in ProtonReactor and add better delivery s...
Adam Litke has posted comments on this change. Change subject: jsonrpc: Fix race in ProtonReactor and add better delivery semantics .. Patch Set 11: (1 inline comment) Commit Message Line 3: AuthorDate: 2012-12-19 16:34:57 -0500 Line 4: Commit: Saggi Mizrahi smizr...@redhat.com Line 5: CommitDate: 2013-02-05 11:24:02 -0500 Line 6: Line 7: jsonrpc: Fix race in ProtonReactor and add better delivery semantics It would be nice if you could explain what the race actually is. Line 8: Line 9: Change-Id: Ie53d6f4b8a119f8a9e366b717c22ba38bcc99e80 -- To view, visit http://gerrit.ovirt.org/10256 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie53d6f4b8a119f8a9e366b717c22ba38bcc99e80 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Add multi-threading option to JsonRpcServer
Adam Litke has posted comments on this change. Change subject: jsonrpc: Add multi-threading option to JsonRpcServer .. Patch Set 11: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a37dfcf3cfde92c8552e6c6eef5016efe3fbd6d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Federate context and request-response objects
Adam Litke has posted comments on this change. Change subject: jsonrpc: Federate context and request-response objects .. Patch Set 11: Looks good to me, but someone else must approve Patch is unchanged and my review stands as-is. -- To view, visit http://gerrit.ovirt.org/10375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I091ca9acad5940418cbf3961a76a06cbfef976f0 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Federate context and request-response objects
Adam Litke has posted comments on this change. Change subject: jsonrpc: Federate context and request-response objects .. Patch Set 11: Verified -- To view, visit http://gerrit.ovirt.org/10375 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I091ca9acad5940418cbf3961a76a06cbfef976f0 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Add multi-threading option to JsonRpcServer
Adam Litke has posted comments on this change. Change subject: jsonrpc: Add multi-threading option to JsonRpcServer .. Patch Set 11: Verified -- To view, visit http://gerrit.ovirt.org/10374 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a37dfcf3cfde92c8552e6c6eef5016efe3fbd6d Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Change cxtr to connector to make the code a bit mor...
Adam Litke has posted comments on this change. Change subject: jsonrpc: Change cxtr to connector to make the code a bit more understandable .. Patch Set 10: Verified; Looks good to me, but someone else must approve Carrying my review forward. -- To view, visit http://gerrit.ovirt.org/10631 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39846bca542e84ee792a367789d39facd9e90c25 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Add support for multiple listeners
Adam Litke has posted comments on this change. Change subject: jsonrpc: Add support for multiple listeners .. Patch Set 5: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11400 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe1b392eab2c30df5720caca11a80f44c6135437 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Change start_listening to createListener
Adam Litke has posted comments on this change. Change subject: jsonrpc: Change start_listening to createListener .. Patch Set 5: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11401 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I846926002d86b5f195dd5ef06aa6039e2e2a0482 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Make reactor clients 1st class objects
Adam Litke has posted comments on this change. Change subject: jsonrpc: Make reactor clients 1st class objects .. Patch Set 5: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11402 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64e4dfeb4eece4a85a3c6d36324b1e00f366a1cd Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Use asyncore instead of custom solution
Adam Litke has posted comments on this change. Change subject: jsonrpc: Use asyncore instead of custom solution .. Patch Set 6: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11605 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e07a125eb905357f130d460accbc67c4b9a66ed Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Check for credit before popping a message from the ...
Adam Litke has posted comments on this change. Change subject: jsonrpc: Check for credit before popping a message from the queue .. Patch Set 3: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11622 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0ad34b3b1125143ac1e3f6185359d49ec74bd8ee Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Remove unecessary check
Adam Litke has posted comments on this change. Change subject: jsonrpc: Remove unecessary check .. Patch Set 3: Verified Please add a reason why the check is not needed to your commit message. -- To view, visit http://gerrit.ovirt.org/11623 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic1c04d3ba13b369c850370b9c5ffaf68da7328a7 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: (OCD) Add space at the end of the sample string
Adam Litke has posted comments on this change. Change subject: tests: (OCD) Add space at the end of the sample string .. Patch Set 3: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11624 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1caf6c6701215cd028caf6b8052176e2be36ce2e Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Use the AsyncoreClient implementation in tests too
Adam Litke has posted comments on this change. Change subject: jsonrpc: Use the AsyncoreClient implementation in tests too .. Patch Set 3: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11625 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6f98075c73000c1a1bea7228eb0590c0678ea900 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Make jsonrpc an independent package
Adam Litke has posted comments on this change. Change subject: jsonrpc: Make jsonrpc an independent package .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e5718d56e09e7f6ad36bc3b2f241c03bbaf08b Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: report IPv6 information
Adam Litke has posted comments on this change. Change subject: netinfo: report IPv6 information .. Patch Set 6: Looks good to me, but someone else must approve I don't see any problems with the schema changes. -- To view, visit http://gerrit.ovirt.org/9382 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf195eeeb06ee385099e0d9f149d467e897717b8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Hunt Xu mhun...@gmail.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Hunt Xu mhun...@gmail.com Gerrit-Reviewer: Livnat Peer lp...@redhat.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Ensure package version data are always strings
Adam Litke has posted comments on this change.
Change subject: caps: Ensure package version data are always strings
..
Patch Set 2: (2 inline comments)
File vdsm/caps.py
Line 319: ver, rel = '0', '0'
Line 320: try:
Line 321: t = file('/proc/sys/kernel/version').read().split()[2:]
Line 322: del t[4] # Delete timezone
Line 323: t = str(time.mktime(time.strptime(' '.join(t
Done
Line 324: except:
Line 325: logging.error('kernel build time not found',
exc_info=True)
Line 326: t = '0'
Line 327: return dict(version=ver, release=rel, buildtime=t)
Line 342: logging.debug(rpm package %s not found, pkg)
Line 343: else:
Line 344: pkgs[pkg] = {
Line 345: 'version': str(mi['version']),
Line 346: 'release': str(mi['release']),
I am not sure to be honest. The documentation for the rpm API doesn't state
the type of data returned. The one that actually tripped me up was for the
kernel above so I will limit this patch to that part only.
Line 347: 'buildtime': str(mi['buildtime']),
Line 348: }
Line 349: except:
Line 350: logging.error('', exc_info=True)
--
To view, visit http://gerrit.ovirt.org/11569
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I506d2b5edacd85c5540a040ce0ff5fe40c12b352
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...
Adam Litke has posted comments on this change. Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged' field .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dfa57649e545dbdf490fec1bb7bf3012b509a40 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] Implement python bindings
Adam Litke has uploaded a new change for review.
Change subject: [WIP] Implement python bindings
..
[WIP] Implement python bindings
This patch produces a native way for python programs to work with the vdsm
jsonrpc API without needing to understand the transports and the jsonrpc
protocol. The module defines a set of API objects that are auto-generated from
the schema which represent the types and commands from the vdsm API.
Features:
- Auto-generated from the schema
- Parameters and return values are type-checked
- Union support (see test cases for examples)
ToDo:
- Add support for errors as python exceptions
- Events
- More functional testing to vet the entire schema
Notes:
- Due to the current arrangement of the vdsm modules, you must manually add
/usr/share/vdsm to PYTHONPATH when importing vdsm_client from its installed
location.
Change-Id: I3f22966348c4c459710d79e1d97f98e2280d7022
Signed-off-by: Adam Litke a...@us.ibm.com
---
M Makefile.am
M configure.ac
A tests/PythonClientTests.py
M vdsm.spec.in
M vdsm_api/Makefile.am
A vdsm_api/vdsm_client/Makefile.am
A vdsm_api/vdsm_client/__init__.py
A vdsm_api/vdsm_client/generate.py
A vdsm_api/vdsm_client/modelBase.py
A vdsm_api/vdsm_client/test.py
M vdsm_api/vdsmapi-schema.json
11 files changed, 1,017 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/11755/1
diff --git a/Makefile.am b/Makefile.am
index 75f360f..f4a2b54 100644
--- a/Makefile.am
+++ b/Makefile.am
@@ -62,7 +62,7 @@
vdsm_reg \
$(NULL)
-PEP8_BLACKLIST = config.py,constants.py
+PEP8_BLACKLIST = config.py,constants.py,_generated.py
check-local:
find . -path './.git' -prune -type f -o \
diff --git a/configure.ac b/configure.ac
index 434d209..501ba72 100644
--- a/configure.ac
+++ b/configure.ac
@@ -81,6 +81,7 @@
AC_SUBST([vdsmtestsdir], ['${datarootdir}/vdsm/tests'])
AC_SUBST([vdsmapidir], ['${datarootdir}/vdsm_api'])
AC_SUBST([yajsonrpcdir], ['${pyexecdir}/yajsonrpc'])
+AC_SUBST([vdsmclientpydir], ['${pyexecdir}/vdsm_client'])
# VDSM registration default paths
AC_SUBST([vdsmregdir], ['${datarootdir}/vdsm-reg'])
@@ -192,6 +193,7 @@
tests/functional/Makefile
vds_bootstrap/Makefile
vdsm_api/Makefile
+ vdsm_api/vdsm_client/Makefile
vdsm_cli/Makefile
vdsm_hooks/directlun/Makefile
vdsm_hooks/faqemu/Makefile
diff --git a/tests/PythonClientTests.py b/tests/PythonClientTests.py
new file mode 100644
index 000..6b057e1
--- /dev/null
+++ b/tests/PythonClientTests.py
@@ -0,0 +1,137 @@
+#
+# Copyright 2013 Adam Litke, IBM Corporation
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 2 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA
+#
+# Refer to the README and COPYING files for full details of the license
+#
+
+import uuid
+from contextlib import closing
+from testrunner import VdsmTestCase as TestCaseBase
+from vdsm_client import *
+from jsonRpcUtils import \
+REACTOR_TYPE_PERMUTATIONS, \
+constructReactor, \
+constructServer
+
+class DataTypeTests(TestCaseBase):
+def testMissingConstructParam(self):
+with self.assertRaises(TypeError):
+VmInterfaceDevice()
+
+def testConstruct(self):
+addr = VmDeviceAddress(addressType=VmDeviceAddressType.DRIVE)
+deviceId = str(uuid.uuid4())
+dev = VmDiskDevice(deviceType=VmDeviceType.DISK,
+ device=VmDiskDeviceType.DISK,
+ readonly=False, format=VmDiskDeviceFormat.RAW,
+ propagateErrors=False, address=addr,
+ alias='disk0', deviceId=deviceId,
+ apparentsize=0, index=0, name='Test Disk',
+ optional=False, shared=False, truesize=0,
+ volumeChain=[])
+self.assertTrue('device' in dev._obj)
+
+
+def testObjectTypeChecking(self):
+ihba = IscsiHba(InitiatorName='test')
+with self.assertRaises(TypeError):
+# The second param should be a list of FcHba
+obj = HbaInventory([ihba], [ihba])
+
+
+def testSetAttribute(self):
+params = {'device': VmDiskDeviceType.DISK, 'domainID': '',
+ 'poolID': '', 'imageID': '', 'volumeID': ''}
+
Change in vdsm[master]: schema: Fix the Hooks schema definition
Adam Litke has posted comments on this change. Change subject: schema: Fix the Hooks schema definition .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/11568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07168edf4ec71c4640d873e854da184abd4230e8 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: Fix the Hooks schema definition
Adam Litke has posted comments on this change. Change subject: schema: Fix the Hooks schema definition .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/11568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07168edf4ec71c4640d873e854da184abd4230e8 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Ensure package version data are always strings
Adam Litke has posted comments on this change. Change subject: caps: Ensure package version data are always strings .. Patch Set 6: Verified -- To view, visit http://gerrit.ovirt.org/11569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I506d2b5edacd85c5540a040ce0ff5fe40c12b352 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...
Adam Litke has posted comments on this change. Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged' field .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/11567 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4dfa57649e545dbdf490fec1bb7bf3012b509a40 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Make jsonrpc an independent package
Adam Litke has posted comments on this change. Change subject: jsonrpc: Make jsonrpc an independent package .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I09e5718d56e09e7f6ad36bc3b2f241c03bbaf08b Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...
Adam Litke has posted comments on this change.
Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged'
field
..
Patch Set 1: (1 inline comment)
File vdsm/netinfo.py
Line 318:'netmask': getnetmask(bridge),
Line 319:'gateway': routes.get(bridge,
'0.0.0.0'),
Line 320:'mtu': getMtu(bridge),
Line 321:'cfg': getIfaceCfg(bridge),
Line 322:'bridged': True,
Not really, because the 'NetInfoNetwork' is a union that can reference either a
bridged or bridgeless network and there must be some concise way to identify
which type is contained by the 'NetInfoNetwork' instance. They way the schema
does that is by having an identifier field that is common to all structures
'NetInfoBridgedNetwork', 'NetInfoBridgelessNetwork') that can be in a union.
Does that make sense?
Line 323:})
Line 324: for bridge in bridges()])
Line 325:
Line 326: d['nics'] = dict([(nic, {'speed': speed(nic),
--
To view, visit http://gerrit.ovirt.org/11567
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4dfa57649e545dbdf490fec1bb7bf3012b509a40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: Update VmDefinition to match current behavior
Adam Litke has uploaded a new change for review.
Change subject: schema: Update VmDefinition to match current behavior
..
schema: Update VmDefinition to match current behavior
The schema for VmDefinition was incorrect in that it had some fields marked as
mandatory even though they may be omitted. Also, exitCode and exitMessage were
not included in the original definition.
Signed-off-by: Adam Litke a...@us.ibm.com
Change-Id: I82e3b4e2073245fa837eb0333dfe1c90c7e4cfe8
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 18 insertions(+), 12 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/12/11712/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index b4eb825..83e8476 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -2481,14 +2481,14 @@
#
# @clientIp: The IP address of the client connected to the display
#
-# @cpuType: The type of CPU being emulated
+# @cpuType: #optional The type of CPU being emulated
# special values 'hostPassthrough' and 'hostModel'
# are reserved for host-passthrough and host-mode cpu
# mode
#
-# @custom:A dictionary of custom, free-form properties
+# @custom:#optional A dictionary of custom, free-form
properties
#
-# @devices: An array of VM devices present
+# @devices: #optional An array of VM devices present
#
# @display: The type of display
#
@@ -2498,9 +2498,9 @@
#
# @displaySecurePort: The port in use for encrypted display data
#
-# @emulatedMachine: The specific machine specification being emulated
+# @emulatedMachine: #optional The machine specification being emulated
#
-# @keyboardLayout:The keyboard layout string (eg. 'en-us')
+# @keyboardLayout:#optional The keyboard layout string (eg. 'en-us')
#
# @kvmEnable: Indicates if KVM hardware acceleration is enabled
#
@@ -2510,7 +2510,7 @@
#
# @nice: The host scheduling priority
#
-# @pauseCode: Indicates the reason a VM has been paused
+# @pauseCode: #optional Indicates the reason a VM has been paused
#
# @pid: The process ID of the underlying qemu process
#
@@ -2533,20 +2533,26 @@
#
# @vmType:The type of VM
#
+# @exitCode: #optional The exit code f the VM process has ended
+#
+# @exitMessage: #optional Explains the reason that the VM process has
+# exited
+#
# Since: 4.10.0
##
{'type': 'VmDefinition',
- 'data': {'acpiEnable': 'bool', 'clientIp': 'str', 'cpuType': 'str',
- 'custom': 'StringMap', 'devices': ['VmDevice'],
+ 'data': {'acpiEnable': 'bool', 'clientIp': 'str', '*cpuType': 'str',
+ '*custom': 'StringMap', '*devices': ['VmDevice'],
'display': 'VmDisplayType', 'displayIp': 'str',
- 'displayPort': 'uint', 'displaySecurePort': 'uint',
- 'emulatedMachine': 'str', 'keyboardLayout': 'str',
+ 'displayPort': 'int', 'displaySecurePort': 'int',
+ '*emulatedMachine': 'str', '*keyboardLayout': 'str',
'kvmEnable': 'bool', 'memSize': 'uint',
- 'nicModel': 'str', 'nice': 'int', 'pauseCode': 'str',
+ 'nicModel': 'str', 'nice': 'int', '*pauseCode': 'str',
'pid': 'uint', 'smp': 'uint', '*smpCoresPerSocket': 'uint',
'*smpThreadsPerCore': 'uint', 'status': 'VmStatus',
'timeOffset': 'uint', 'transparentHugePages': 'bool',
- 'vmId': 'UUID', 'vmName': 'str', 'vmType': 'VmType'}}
+ 'vmId': 'UUID', 'vmName': 'str', 'vmType': 'VmType',
+ '*exitCode': 'int', '*exitMessage': 'str'}}
##
# @VmParameters:
--
To view, visit http://gerrit.ovirt.org/11712
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I82e3b4e2073245fa837eb0333dfe1c90c7e4cfe8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: Eliminate 'class' from StorageDomainInfo
Adam Litke has uploaded a new change for review.
Change subject: schema: Eliminate 'class' from StorageDomainInfo
..
schema: Eliminate 'class' from StorageDomainInfo
'class' is usually a reserved word and makes a bad name for a type field.
Change it to domainClass and add the required type fixup to the Bridge.
Change-Id: I7d13d4c6141e42c996b50a86d4b812c8c42f831f
Signed-off-by: Adam Litke a...@us.ibm.com
---
M vdsm_api/Bridge.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 12 insertions(+), 11 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/11711/1
diff --git a/vdsm_api/Bridge.py b/vdsm_api/Bridge.py
index 49b1558..8fade0f 100644
--- a/vdsm_api/Bridge.py
+++ b/vdsm_api/Bridge.py
@@ -371,4 +371,5 @@
'IscsiCredentials': partial(fieldClone, 'type', 'authType'),
'ConnectionRefArgs': partial(fieldClone, 'type', 'connType'),
'VolumeInfo': partial(fieldClone, 'type', 'allocType'),
+'StorageDomainInfo': partial(fieldClone, 'class', 'domainClass'),
}
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index b4eb825..a83a799 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -3543,31 +3543,31 @@
#
# Information about a Storage Domain.
#
-# @uuid:The Storage Domain UUID
+# @uuid: The Storage Domain UUID
#
-# @domainType: The type of backing storage used by this domain
+# @domainType: The type of backing storage used by this domain
#
-# @class: The Storage Domain class
+# @domainClass: The Storage Domain class
#
-# @name:The human-readable name for this Storage Domain
+# @name: The human-readable name for this Storage Domain
#
-# @role:The Storage Domain role
+# @role: The Storage Domain role
#
-# @pool:The Storage Pool associated with this Storage Domain
+# @pool: The Storage Pool associated with this Storage Domain
#
-# @version: The version of this Storage Domain
+# @version: The version of this Storage Domain
#
-# @lver:The lock version of the associated Storage Pool
+# @lver: The lock version of the associated Storage Pool
#
-# @spm_id: Contains the Host ID of the Storage Pool Manager
+# @spm_id: Contains the Host ID of the Storage Pool Manager
#
-# @master_ver: The version of the master Storage Domain
+# @master_ver: The version of the master Storage Domain
#
# Since: 4.10.0
##
{'type': 'StorageDomainInfo',
'data': {'uuid': 'UUID', 'domainType': 'StorageDomainType',
- 'class': 'StorageDomainImageClass', 'name': 'str',
+ 'domainClass': 'StorageDomainImageClass', 'name': 'str',
'role': 'StorageDomainRole', 'pool': ['UUID'], 'version': 'int',
'lver': 'int', 'spm_id': 'int', 'master_ver': 'int'}}
--
To view, visit http://gerrit.ovirt.org/11711
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7d13d4c6141e42c996b50a86d4b812c8c42f831f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Ensure package version data are always strings
Adam Litke has posted comments on this change. Change subject: caps: Ensure package version data are always strings .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11569 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I506d2b5edacd85c5540a040ce0ff5fe40c12b352 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: Eliminate 'class' from StorageDomainInfo
Adam Litke has posted comments on this change. Change subject: schema: Eliminate 'class' from StorageDomainInfo .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11711 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d13d4c6141e42c996b50a86d4b812c8c42f831f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: Update VmDefinition to match current behavior
Adam Litke has posted comments on this change. Change subject: schema: Update VmDefinition to match current behavior .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11712 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82e3b4e2073245fa837eb0333dfe1c90c7e4cfe8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...
Adam Litke has posted comments on this change.
Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged'
field
..
Patch Set 1: (1 inline comment)
File vdsm/netinfo.py
Line 318:'netmask': getnetmask(bridge),
Line 319:'gateway': routes.get(bridge,
'0.0.0.0'),
Line 320:'mtu': getMtu(bridge),
Line 321:'cfg': getIfaceCfg(bridge),
Line 322:'bridged': True,
I agree that it seems pretty obvious to a human reader that each of these is
bridged. But requiring that context in clients makes the API hard to use. I
just don't think it makes sense to fragment the types in order to save a single
field. Then clients would receive a NetInfoBridge in one case and a
NetInfoBridgeMinusBridged in another case.
Line 323:})
Line 324: for bridge in bridges()])
Line 325:
Line 326: d['nics'] = dict([(nic, {'speed': speed(nic),
--
To view, visit http://gerrit.ovirt.org/11567
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4dfa57649e545dbdf490fec1bb7bf3012b509a40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Adam Litke a...@us.ibm.com
Gerrit-Reviewer: Antoni Segura Puimedon asegu...@redhat.com
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Rearrange test classes for reusability
Adam Litke has posted comments on this change. Change subject: jsonrpc: Rearrange test classes for reusability .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/11122 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I78f9546c0bfb2348510340922ba95569b1827830 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: change vdsm to use multipolicy mom
Adam Litke has posted comments on this change. Change subject: change vdsm to use multipolicy mom .. Patch Set 1: I would prefer that you didn't submit this (1 inline comment) Mom doesn't yet have a 0.3.1 version so committing this patch will make it impossible to install vdsm. First we need to get mom updated with the new version. Commit Message Line 6: Line 7: change vdsm to use multipolicy mom Line 8: Line 9: To support multipolicy, all policies will be placed Line 10: in directory '/etc/vdsm/mom-policy-dir' instead of in a single file. Typically the directory name ends in '.d' so I would suggest renaming to 'mom-policy.d' Line 11: At startup mom will load all policy files under this directory. Line 12: Line 13: Change-Id: If06b7f5d5bb69767b0d97c1063c44ae2bd9cd799 -- To view, visit http://gerrit.ovirt.org/11243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If06b7f5d5bb69767b0d97c1063c44ae2bd9cd799 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvro...@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Mark Wu wu...@linux.vnet.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: caps: Ensure package version data are always strings
Adam Litke has uploaded a new change for review.
Change subject: caps: Ensure package version data are always strings
..
caps: Ensure package version data are always strings
According to the schema, package version information is always returned in
string form. Make sure this is the case.
Change-Id: I506d2b5edacd85c5540a040ce0ff5fe40c12b352
Signed-off-by: Adam Litke a...@us.ibm.com
---
M vdsm/caps.py
1 file changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/69/11569/1
diff --git a/vdsm/caps.py b/vdsm/caps.py
index a307200..d719672 100644
--- a/vdsm/caps.py
+++ b/vdsm/caps.py
@@ -320,7 +320,7 @@
try:
t = file('/proc/sys/kernel/version').read().split()[2:]
del t[4] # Delete timezone
-t = time.mktime(time.strptime(' '.join(t)))
+t = str(time.mktime(time.strptime(' '.join(t
except:
logging.error('kernel build time not found', exc_info=True)
t = '0'
@@ -342,9 +342,9 @@
logging.debug(rpm package %s not found, pkg)
else:
pkgs[pkg] = {
-'version': mi['version'],
-'release': mi['release'],
-'buildtime': mi['buildtime'],
+'version': str(mi['version']),
+'release': str(mi['release']),
+'buildtime': str(mi['buildtime']),
}
except:
logging.error('', exc_info=True)
@@ -359,7 +359,7 @@
for pkg in KEY_PACKAGES:
try:
deb_pkg = KEY_PACKAGES[pkg]
-ver = cache[deb_pkg].installed.version
+ver = str(cache[deb_pkg].installed.version)
# Debian just offers a version
pkgs[pkg] = dict(version=ver, release=, buildtime=)
except:
--
To view, visit http://gerrit.ovirt.org/11569
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I506d2b5edacd85c5540a040ce0ff5fe40c12b352
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: Fix the Hooks schema definition
Adam Litke has uploaded a new change for review.
Change subject: schema: Fix the Hooks schema definition
..
schema: Fix the Hooks schema definition
The schema does not correctly describe the format of the hook info as returned
in VdsmCapabilities. The correct format looks like the following:
{'after_vm_start': {'01_faqemu': {'md5': 'xxx-xxx'},
'02_another': {'md5': 'yyy-yyy'}},
'before_vm_start': {'01_faqemu': {'md5': 'xxx-xxx'},
'02_another': {'md5': 'yyy-yyy'}}}
This means we need to add a new map type to define the outermost dict as a map
of HookType - HookScriptInfoMap. HookScriptInfoMap remains a map of
Hook name - HookScriptInfo.
Change-Id: I07168edf4ec71c4640d873e854da184abd4230e8
Signed-off-by: Adam Litke a...@us.ibm.com
---
M vdsm_api/vdsmapi-schema.json
1 file changed, 90 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/68/11568/1
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index a863b19..944ed17 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -861,6 +861,95 @@
'key': 'str', 'value': 'HookScriptInfo'}
##
+# @HookType:
+#
+# An enumeration of hook types.
+#
+# @before_vm_start:Executed before starting a VM
+#
+# @after_vm_start: Executed after a VM has been started
+#
+# @before_vm_cont: Executed before resuming a paused VM
+#
+# @after_vm_cont: Executed after after resuming a paused VM
+#
+# @before_vm_pause:Executed before pausing a VM
+#
+# @after_vm_pause: Executed after a VM has been paused
+#
+# @before_vm_migrate_source: Executed on the source host prior to
+# beginning the migration
+#
+# @after_vm_migrate_source:Executed on the source host after the
+# migration has finished
+#
+# @before_vm_migrate_destination: Executed on the destination host prior to
+# beginning migration
+#
+# @after_vm_migrate_destination: Executed on the destination host after the
+# migration has finished
+#
+# @before_vm_hibernate:Executed before hibernating a VM
+#
+# @after_vm_hibernate: Executed after a VM has been hiberbated
+#
+# @before_vm_dehibernate: Executed before thawing a hibernated VM
+#
+# @after_vm_dehibernate: Executed after thawing a hibernated VM
+#
+# @before_vm_destroy: Executed before destroying a VM
+#
+# @after_vm_destroy: Executed after destroying a VM
+#
+# @before_vm_set_ticket: Executed before creating an access ticket
for
+# client access to a VM
+#
+# @after_vm_set_ticket:Executed after a ticket has been created to
+# grant client access to a VM
+#
+# @before_nic_hotplug: Executed before plugging a virtual NIC
+#
+# @after_nic_hotplug: Executed after plugging in a virtual NIC
+#
+# @before_nic_hotunplug: Executed before unplugging a virtual NIC
+#
+# @after_nic_hotunplug:Executed after a virtual NIC is unplugged
+#
+# @after_nic_hotplug_fail: Executed after a virtual NIC hotplug
+# operation has failed
+#
+# @after_nic_hotunplug_fail: Executed after a virtual NIC hot unplug
+# operation has failed
+#
+# @before_vdsm_start: Executed before vdsm starts up
+#
+# @after_vdsm_stop:Executed after vdsm has stopped
+#
+# Since: 4.10.3
+##
+{'enum': 'HookType',
+ 'data': ['before_vm_start', 'after_vm_start', 'before_vm_cont',
+ 'after_vm_cont', 'before_vm_pause', 'after_vm_pause',
+ 'before_vm_migrate_source', 'after_vm_migrate_source',
+ 'before_vm_migrate_destination', 'after_vm_migrate_destination',
+ 'before_vm_hibernate', 'after_vm_hibernate', 'before_vm_dehibernate',
+ 'after_vm_dehibernate', 'before_vm_destroy', 'after_vm_destroy',
+ 'before_vm_set_ticket', 'after_vm_set_ticket', 'before_nic_hotplug',
+ 'after_nic_hotplug', 'before_nic_hotunplug', 'after_nic_hotunplug',
+ 'after_nic_hotplug_fail', 'after_nic_hotunplug_fail',
+ 'before_vdsm_start', 'after_vdsm_stop']}
+
+##
+# @HookScriptTypesMap:
+#
+# A mapping of installed hook scripts indexed by hook type.
+#
+# Since: 4.10.0
+##
+{'map': 'HookScriptTypesMap',
+ 'key': 'HookType', 'value': 'HookScriptInfoMap'}
+
+##
# @SoftwarePackageInfoMap:
#
# A mapping of information indexed by software package name.
@@ -949,7 +1038,7 @@
'supportedProtocols': ['str'], 'clusterLevels': ['str'],
'networks': 'NetInfoNetworkMap', 'bridges': 'NetInfoBridgeMap',
Change in vdsm[master]: netinfo: Items in the 'bridges' dict are missing the 'bridge...
Adam Litke has uploaded a new change for review.
Change subject: netinfo: Items in the 'bridges' dict are missing the 'bridged'
field
..
netinfo: Items in the 'bridges' dict are missing the 'bridged' field
According to the schema, VdsmCapabilities contains a 'bridges' entry which is a
map of NetInfoBridge items. NetInfoBridge is supposed to contain the member
'bridged' which is the field that distinguishes a bridged network from a
bridgeless one. Add this field to the NetInfoBridge items in 'bridges' in order
to comply with the schema.
Signed-off-by: Adam Litke a...@us.ibm.com
Change-Id: I4dfa57649e545dbdf490fec1bb7bf3012b509a40
---
M vdsm/netinfo.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/67/11567/1
diff --git a/vdsm/netinfo.py b/vdsm/netinfo.py
index df6a19f..1528374 100644
--- a/vdsm/netinfo.py
+++ b/vdsm/netinfo.py
@@ -319,6 +319,7 @@
'gateway': routes.get(bridge, '0.0.0.0'),
'mtu': getMtu(bridge),
'cfg': getIfaceCfg(bridge),
+ 'bridged': True,
})
for bridge in bridges()])
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index b4eb825..a863b19 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -583,11 +583,13 @@
# @permhwaddr: #optional For bonded nics: the real MAC address which will be
# used if the card is freed from the bond.
#
+# @cfg: Raw device configuration parameters
+#
# Since: 4.10.0
##
{'type': 'NetInfoNic',
'data': {'speed': 'int', 'addr': 'str', 'netmask': 'str', 'hwaddr': 'str',
- 'mtu': 'uint', '*permhwaddr': 'str'}}
+ 'mtu': 'uint', '*permhwaddr': 'str', 'cfg': 'StringMap'}}
##
# @NetInfoBond:
--
To view, visit http://gerrit.ovirt.org/11567
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4dfa57649e545dbdf490fec1bb7bf3012b509a40
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: Strengthen schema verification
Adam Litke has uploaded a new change for review.
Change subject: schema: Strengthen schema verification
..
schema: Strengthen schema verification
Add additional checking to process-schema.py to detect the following errors:
- Symbol comment documents a field which is not defined in the symbol
- Symbol references an undefined type
Change-Id: Ia750e537fad9ad57d1163906b130033e896c36dd
Signed-off-by: Adam Litke a...@us.ibm.com
---
M vdsm_api/process-schema.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 46 insertions(+), 19 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/97/11397/1
diff --git a/vdsm_api/process-schema.py b/vdsm_api/process-schema.py
index 970637b..686e624 100755
--- a/vdsm_api/process-schema.py
+++ b/vdsm_api/process-schema.py
@@ -140,6 +140,9 @@
m = re.search('^\@(.*?):\s*(.*)', line)
if m:
name, desc = (m.group(1), m.group(2))
+if name not in strip_stars(symbol['data']):
+raise ValueError('%s' comment mentions '%s' which is \
+ not defined % (symbol['name'], name))
symbol[mode][name] = desc
# Track the name in case there is are multiple lines to append
last_arg = name
@@ -175,23 +178,24 @@
return .join(html_escape_table.get(c, c) for c in text)
+def strip_stars(items):
+
+A symbol prepended with '*' means the symbol is optional. Strip this
+when looking up the symbol documentation.
+
+ret = []
+for i in items:
+if i.startswith('*'):
+ret.append(i[1:])
+else:
+ret.append(i)
+return ret
+
+
def write_symbol(f, s):
Write an HTML reprentation of a symbol definition and documentation.
-def strip_stars(items):
-
-A symbol prepended with '*' means the symbol is optional. Strip this
-when looking up the symbol documentation.
-
-ret = []
-for i in items:
-if i.startswith('*'):
-ret.append(i[1:])
-else:
-ret.append(i)
-return ret
-
def filter_types(items):
When creating the type crosslink, if an entity is a list container we
@@ -327,6 +331,29 @@
f.write(footer)
+def verify_symbols(symbols):
+def filter_name(name):
+if isinstance(name, list):
+name = name[0]
+if name.startswith('*'):
+name = name[1:]
+return name
+
+names = ['str', 'bool', 'int', 'uint', 'float']
+names.extend([s['type'] for s in symbols if 'type' in s])
+names.extend([s['enum'] for s in symbols if 'enum' in s])
+names.extend([s['alias'] for s in symbols if 'alias' in s])
+names.extend([s['map'] for s in symbols if 'map' in s])
+
+# Make sure all type references are defined
+for s in symbols:
+if 'type' in s or 'command' in s:
+for k, v in s.get('data', {}).items():
+if filter_name(v) not in names:
+raise ValueError('%s': undefined type reference '%s' % (
+s['type'], v))
+
+
def main():
schema = sys.argv[1]
output = sys.argv[2]
@@ -335,6 +362,8 @@
# First read in the progmatic schema definition
with open(schema) as f:
symbols = vdsmapi.parse_schema(f)
+verify_symbols(symbols)
+
# Now merge in the information from the comments
with open(schema) as f:
symbols = read_schema_doc(f, symbols)
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 1baffe2..4b8 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -368,7 +368,7 @@
# Since: 4.10.0
##
{'enum': 'TaskState',
- 'data': ['unknown', 'running', 'finished', 'aborting', 'cleaning']}
+ 'data': ['unknown', 'init', 'running', 'finished', 'aborting', 'cleaning']}
##
# @TaskResult:
@@ -1550,13 +1550,13 @@
'storageDomains': 'StorageDomainVitalsMap',
'elapsedTime': 'uint', 'memUsed': 'uint',
'anonHugePages': 'uint', 'cpuLoad': 'float',
- 'diskStats': 'PathStatsMap', 'thpState': 'THPStates'},
+ 'diskStats': 'PathStatsMap', 'thpState': 'THPStates',
'memAvailable': 'int', 'memShared': 'int', 'memCommitted': 'int',
'swapTotal': 'int', 'swapFree': 'int','vmCount': 'int',
'vmActive': 'int', 'vmMigrating': 'int', 'dateTime': 'str',
'ksmState': 'bool', 'ksmPages': 'int', 'ksmCpu': 'float',
'netConfigDirty': 'bool', 'generationID': 'UUID',
- 'momStatus': 'MOMStatus'}
+ 'momStatus': 'MOMStatus'}}
##
# @Host.getStats:
@@ -2363,7 +2363,7 @@
#
# Since: 4.10.0
##
-{'enum': 'VmChannelDeviceType', 'data': ['unix', 'spicevmc']}
+{'enum': 'VmChannelDeviceType', 'data': ['unix',
Change in vdsm[master]: schema: bridges was added to VdsmCapabilities
Adam Litke has uploaded a new change for review.
Change subject: schema: bridges was added to VdsmCapabilities
..
schema: bridges was added to VdsmCapabilities
In 1fa30a, Dan added a new field 'bridges' to VdsmCapabilities but did not
update the schema to reflect it. At the moment we are not checking for
extraneous fields in our types so I just caught it now by chance.
Change-Id: Ib12a7d89c71e6946d12b1a4cb580be1458c280eb
Signed-off-by: Adam Litke a...@us.ibm.com
---
M vdsm/netinfo.py
M vdsm_api/vdsmapi-schema.json
2 files changed, 14 insertions(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/96/11396/1
diff --git a/vdsm/netinfo.py b/vdsm/netinfo.py
index c8496db..df6a19f 100644
--- a/vdsm/netinfo.py
+++ b/vdsm/netinfo.py
@@ -316,6 +316,7 @@
'stp': bridge_stp_state(bridge),
'addr': getaddr(bridge),
'netmask': getnetmask(bridge),
+ 'gateway': routes.get(bridge, '0.0.0.0'),
'mtu': getMtu(bridge),
'cfg': getIfaceCfg(bridge),
})
diff --git a/vdsm_api/vdsmapi-schema.json b/vdsm_api/vdsmapi-schema.json
index 9e92bd8..1baffe2 100644
--- a/vdsm_api/vdsmapi-schema.json
+++ b/vdsm_api/vdsmapi-schema.json
@@ -809,6 +809,16 @@
'key': 'str', 'value': 'NetInfoNetwork'}
##
+# @NetInfoBridgeMap:
+#
+# A mapping of NIC information indexed by device name.
+#
+# Since: 4.10.0
+##
+{'map': 'NetInfoBridgeMap',
+ 'key': 'str', 'value': 'NetInfoBridgedNetwork'}
+
+##
# @NetInfoNicMap:
#
# A mapping of NIC information indexed by device name.
@@ -891,6 +901,8 @@
#
# @networks:Information about configured VDSM networks
#
+# @bridges: Information about the network bridges on the host
+#
# @nics:Information about the network cards on the host
#
# @bondings:Information about configured bonding devices
@@ -933,7 +945,7 @@
'cpuFlags': 'str', 'version_name': 'str', 'software_version': 'str',
'software_revision': 'str', 'supportedENGINEs': ['str'],
'supportedProtocols': ['str'], 'clusterLevels': ['str'],
- 'networks': 'NetInfoNetworkMap',
+ 'networks': 'NetInfoNetworkMap', 'bridges': 'NetInfoBridgeMap',
'nics': 'NetInfoNicMap', 'bondings': 'NetInfoBondMap',
'vlans': 'NetInfoVlanMap', '*hooks': 'HookScriptInfoMap',
'operatingSystem': 'OsVersion', 'uuid': 'str',
--
To view, visit http://gerrit.ovirt.org/11396
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib12a7d89c71e6946d12b1a4cb580be1458c280eb
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: bridges was added to VdsmCapabilities
Adam Litke has posted comments on this change. Change subject: schema: bridges was added to VdsmCapabilities .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/11396 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib12a7d89c71e6946d12b1a4cb580be1458c280eb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Adam Litke a...@us.ibm.com Gerrit-Reviewer: Adam Litke a...@us.ibm.com Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Bridge: Fix the specification of the getAllTasks return valu...
Adam Litke has uploaded a new change for review.
Change subject: Bridge: Fix the specification of the getAllTasks return value
..
Bridge: Fix the specification of the getAllTasks return value
Change-Id: Ibf4dfacf9917a51a2d98433e5fa9a4bc5e1fe785
Signed-off-by: Adam Litke a...@us.ibm.com
---
M vdsm_api/Bridge.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/36/11336/1
diff --git a/vdsm_api/Bridge.py b/vdsm_api/Bridge.py
index 658ab36..49b1558 100644
--- a/vdsm_api/Bridge.py
+++ b/vdsm_api/Bridge.py
@@ -351,7 +351,7 @@
'Volume_getInfo': {'ret': 'info'},
'Volume_getPath': {'ret': 'path'},
'Volume_getSize': {'ret': Volume_getsize_Ret},
-'Host_getAllTasks': {'ret': 'TasksDetails'},
+'Host_getAllTasks': {'ret': 'tasks'},
}
--
To view, visit http://gerrit.ovirt.org/11336
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf4dfacf9917a51a2d98433e5fa9a4bc5e1fe785
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke a...@us.ibm.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
