Change in vdsm[master]: lvm: Make the isLVActive() method public.
Lee Yarwood has abandoned this change. Change subject: lvm: Make the isLVActive() method public. .. Abandoned -- To view, visit http://gerrit.ovirt.org/21386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Itamar Heim Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
Lee Yarwood has abandoned this change. Change subject: supervdsm: Enable multiprocessing module logging. .. Abandoned -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Gibson Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Introduce a maximum time limit a migration may take
Lee Yarwood has posted comments on this change.
Change subject: Introduce a maximum time limit a migration may take
..
Patch Set 1:
(1 comment)
After discussing this issue with Vinzenz and Tomas at length today I've
suggested that for now we base the overall timeout value on a simple
calculation using a percentage of the migration bandwidth.
In the longer term I really think we should move the logic for both calculating
this timeout and monitoring migration progression to the engine.
I've created the following RFEs requesting this :
[RFE] Allow migration configuration values to be set per VM from engine
https://bugzilla.redhat.com/show_bug.cgi?id=1034871
[RFE] Engine should apply a sensible overall timeout to the live migration of
guests.
https://bugzilla.redhat.com/show_bug.cgi?id=1034893
File lib/vdsm/config.py.in
Line 54: 'Maximum time the destination waits since migration is
stalled. '
Line 55: 'Please note, that this is not overall migration timeout. '
Line 56: 'Source waits twice as long (to avoid races).'),
Line 57:
Line 58: ('migration_max_time', '21600',
I've suggested that this value is based on the time taken to transfer the
memory of a guest given a certain percentage of migration bandwidth.
For example for a 4GB guest allowing for 50% of the default 32MiB/s migration
bandwidth we would set the timeout to 281.
Line 59: 'The maximum time in seconds a migration may take before
the '
Line 60: 'migration will be aborted.'),
Line 61:
Line 62: ('migration_listener_timeout', '30',
--
To view, visit http://gerrit.ovirt.org/21708
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifd2f76b9334fcb7d2db24c081cccae15e8fd0b0c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Lee Yarwood
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Tomáš Došek
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
Lee Yarwood has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 7: Code-Review-1 -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
Lee Yarwood has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 7: Verified-1 Unfortunately while attempting to verify this change it appears that lvchange --refresh is not having the desired effect on volumes that have been modified on other hosts. For example a common flow where we have seen issues as a result of this in the past is with the merging of snapshots. I've attempted a few of these while leaving one or more volumes active a HSM. While this change does correctly call lvchange --refresh against these before use on the HSM the underlying dm structure of the volume is not updated and thus the guest is unable to boot. Maybe this is just a lvm2 bug but it really needs more research before we verify this change. -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
Lee Yarwood has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 7: @Nir Isn't this avoided thanks to Eduardo's 'One shot prepare' patch [1]? I still need to verify this patch series against master and will check that it doesn't introduce any additional activation or refresh commands into the prepare flow. [1] http://gerrit.ovirt.org/#/c/4220/ -- To view, visit http://gerrit.ovirt.org/21387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.
Lee Yarwood has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 10: @Nir np, maybe I'm missing something regarding gerrit workflow but isn't it cleaner to rebase and push your own change? Introducing the dependency without the need to repush this change or my two other changes that depend on it ;) -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Allow multiple LVs to be refreshed at once.
Lee Yarwood has posted comments on this change. Change subject: lvm: Allow multiple LVs to be refreshed at once. .. Patch Set 7: (2 comments) > Are all callers updated by this patch? Yes. # git grep refreshLV vdsm/storage/blockVolume.py:lvm.refreshLVs(self.sdUUID, (self.volUUID,)) vdsm/storage/lvm.py:def refreshLVs(vgName, lvNames): Commit Message Line 8: Line 9: This change refactors the refreshLV method to allow multiple Line 10: volumes to be refreshed at once as possible with the activate Line 11: and deactive methods. Line 12: Done Line 13: Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d File vdsm/storage/blockVolume.py Line 94: raise se.VolumeDoesNotExist(self.volUUID) # Fix me Line 95: volume.Volume.validate(self) Line 96: Line 97: def refreshVolume(self): Line 98: lvm.refreshLVs(self.sdUUID, self.volUUID) Done Line 99: Line 100: @classmethod Line 101: def getVSize(cls, sdobj, imgUUID, volUUID, bs=BLOCK_SIZE): Line 102: """ Returns size in block units. -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
Lee Yarwood has posted comments on this change.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
Patch Set 3:
(1 comment)
File vdsm/storage/blockSD.py
Line 1068: If the image is based on a template image it will be
activated.
Line 1069: """
Line 1070: toRefresh = [vol for vol in volUUIDs if vol not in
SPECIAL_LVS and
Line 1071: lvm.isLVActive(self.sdUUID, vol)]
Line 1072: lvm.activateLVs(self.sdUUID, volUUIDs)
Nir, just to answer a question you asked before regarding passing all volumes
to the activateLVs method. I could create a toActivate list here and only pass
these but that duplicates the logic already in the activateLVs method. I don't
want to touch that method now so it's just easier to pass everything through
and let it filter them out.
Line 1073:
Line 1074: if toRefresh:
Line 1075: log.warning("The following volumes are already active
and will be"
Line 1076: " refreshed before use : %s", toRefresh)
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
Gerrit-Reviewer: Lee Yarwood
Gerrit-Reviewer: Nir Soffer
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
Lee Yarwood has uploaded a new change for review.
Change subject: blockSD: Ensure active volumes are refreshed before use.
..
blockSD: Ensure active volumes are refreshed before use.
At present we trust that active LVs represent the current state of a
given LV. This may not be the case if the LV has been modified
(extended, recreated etc) by another host while the LV is active on
the current host.
This change forces active non-special LVs to be refresh before use.
Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Signed-off-by: Lee Yarwood
---
M vdsm/storage/blockSD.py
1 file changed, 11 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/21387/1
diff --git a/vdsm/storage/blockSD.py b/vdsm/storage/blockSD.py
index d27f331..7d296b7 100644
--- a/vdsm/storage/blockSD.py
+++ b/vdsm/storage/blockSD.py
@@ -1059,14 +1059,23 @@
def activateVolumes(self, imgUUID, volUUIDs):
"""
-Activate all the volumes belonging to the image.
+Activate all the volumes belonging to the image. Refresh any active
+volumes that belong to the image as long as they are not special.
-imgUUID: the image to be deactivated.
+imgUUID: the image to be activated.
allVols: getAllVolumes result.
If the image is based on a template image it will be activated.
"""
+toRefresh = [ vol for vol in volUUIDs if vol not in SPECIAL_LVS and
+ lvm.isLVActive(self.sdUUID, vol)]
lvm.activateLVs(self.sdUUID, volUUIDs)
+
+if toRefresh:
+log.warning("The following volumes are already active and will be"
+" refreshed before use : %s", toRefresh)
+lvm.refreshLVs(self.sdUUID, toRefresh)
+
vgDir = os.path.join("/dev", self.sdUUID)
return self.createImageLinks(vgDir, imgUUID, volUUIDs)
--
To view, visit http://gerrit.ovirt.org/21387
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If3058cded234500e01939e50b2485afebd7087a3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Make the isActiveLV() method public.
Lee Yarwood has uploaded a new change for review. Change subject: lvm: Make the isActiveLV() method public. .. lvm: Make the isActiveLV() method public. This change makes the private isActiveLV() method public for use in the blockSD layer. Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec Signed-off-by: Lee Yarwood --- M vdsm/storage/lvm.py 1 file changed, 1 insertion(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/86/21386/1 diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py index 112f1c0..76184b8 100644 --- a/vdsm/storage/lvm.py +++ b/vdsm/storage/lvm.py @@ -1221,10 +1221,8 @@ return os.path.basename(os.readlink(lvp)) -def _isLVActive(vgName, lvName): +def isLVActive(vgName, lvName): """Active volumes have a mp link. - -This function should not be used out of this module. """ return os.path.exists(lvPath(vgName, lvName)) -- To view, visit http://gerrit.ovirt.org/21386 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I670fe3969b88819891c64ea3ac487b070618aaec Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: blockSD: Ensure active volumes are refreshed before use.
Lee Yarwood has posted comments on this change. Change subject: blockSD: Ensure active volumes are refreshed before use. .. Patch Set 6: Thanks for the reviews everyone and my apologies for the time taken to respond. Placing the additional refresh logic in lvm.py was indeed a mistake. I had intended to move it up into blockSD.py a while ago after talking to Ayal and Federico at the Forum. -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Allon Mureinik Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: lvm: Ensure active LVs are refreshed before use.
Lee Yarwood has posted comments on this change. Change subject: lvm: Ensure active LVs are refreshed before use. .. Patch Set 5: I've pushed the revert patch for review but plan on verifying this upstream before adding additional documentation, justification etc. -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ensure active LVs are refreshed before use.
Lee Yarwood has posted comments on this change. Change subject: Ensure active LVs are refreshed before use. .. Patch Set 4: Verified-1 Code-Review-1 Unfortunately lvchange doesn't allow both -a and --refresh switches in the same command thus this approach isn't valid. My apologies for missing this until now. With lvm2-2.02.98-9.el6.x86_64 I get the following... # lvchange --available y --refresh 615ba535-42b9-4307-9a9a-884d1218a1f1/8f3d7be3-df61-4340-8ab9-c07561ecac8a Only one of -a and --refresh permitted. Run `lvchange --help' for more information. I'll revert the patch to the previous implementation, profile and verify that the change doesn't degrade performance when starting, provisioning etc. -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ensure active LVs are refreshed before use.
Lee Yarwood has posted comments on this change. Change subject: Ensure active LVs are refreshed before use. .. Patch Set 4: (3 comments) Commit Message Line 3: AuthorDate: 2013-10-04 14:32:48 +0100 Line 4: Commit: Lee Yarwood Line 5: CommitDate: 2013-10-18 17:25:19 +0100 Line 6: Line 7: Ensure active LVs are refreshed before use. This change should only refresh active LVs, inactive LVs will be activated as normal without an additional refresh after this. However I'll add the lvm: tag to the message. Line 8: Line 9: At present active LVs are trusted to correctly represent the correct Line 10: state of a given LV. This may not be the case if the LV has been Line 11: modified by another host since the LV was activated. File vdsm/storage/lvm.py Line 1124: Line 1125: Line 1126: def activateLVs(vgName, lvNames): Line 1127: lvNames = _normalizeargs(lvNames) Line 1128: _setLVAvailability(vgName, lvNames, "y --refresh") Not quite, the issue is that we can't trust that the layout of dm devices that form the LV are correct *if* the LV is already active. I'll add a comment with this. Line 1129: Line 1130: Line 1131: def deactivateLVs(vgName, lvNames): Line 1132: lvNames = _normalizeargs(lvNames) Line 1124: Line 1125: Line 1126: def activateLVs(vgName, lvNames): Line 1127: lvNames = _normalizeargs(lvNames) Line 1128: _setLVAvailability(vgName, lvNames, "y --refresh") Same here, we can always file a RFE for this and update the call later. Line 1129: Line 1130: Line 1131: def deactivateLVs(vgName, lvNames): Line 1132: lvNames = _normalizeargs(lvNames) -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nir Soffer Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
Lee Yarwood has posted comments on this change. Change subject: supervdsm: Enable multiprocessing module logging. .. Patch Set 4: > I'm not sure what you mean "import only what needed". > What's being imported that's not needed? As we require multiprocessing to call get_logger() I've removed the subsequent imports from the module and edited the lines calling for them. Feel free to revert if this is not what you wanted here Yaniv. > So 17199 won't remove the necessity for this patch. +1 -- To view, visit http://gerrit.ovirt.org/19741 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: David Gibson Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ensure active LVs are refreshed before use.
Lee Yarwood has uploaded a new change for review. Change subject: Ensure active LVs are refreshed before use. .. Ensure active LVs are refreshed before use. At present active LVs are trusted to correctly represent the correct state of a given LV. This may not be the case if the LV has been modified by another host since the LV was activated Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Bug-Url: https://bugzilla.redhat.com/1009812 Signed-off-by: Lee Yarwood --- M vdsm/storage/lvm.py 1 file changed, 6 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/71/19871/1 diff --git a/vdsm/storage/lvm.py b/vdsm/storage/lvm.py index 0c2964e..6d2c487 100644 --- a/vdsm/storage/lvm.py +++ b/vdsm/storage/lvm.py @@ -1127,9 +1127,15 @@ lvNames = _normalizeargs(lvNames) toActivate = [lvName for lvName in lvNames if not _isLVActive(vgName, lvName)] +toRefresh = [lvname for lvname in lvNames if _isLVActive(vgName, lvName)] + if toActivate: _setLVAvailability(vgName, toActivate, "y") +if toRefresh: +for lv in toRefresh: +refreshLV(vgName, lv) + def deactivateLVs(vgName, lvNames): lvNames = _normalizeargs(lvNames) -- To view, visit http://gerrit.ovirt.org/19871 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1ecc64b8ca0133b030ba5bfa37f1a2c55067dd5d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: supervdsm: Enable multiprocessing module logging.
Lee Yarwood has uploaded a new change for review.
Change subject: supervdsm: Enable multiprocessing module logging.
..
supervdsm: Enable multiprocessing module logging.
The multiprocessing module includes error logging using Python's logging
module, but it is not enabled by default. This patch enables the
logging and sets it to propagate to the supervdsmServer's root logger,
so it now defaults to producing logging and can be configured easily
from /etc/vdsm/svdsm.logger.conf.
Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea
Signed-off-by: Lee Yarwood
Signed-off-by: David Gibson
---
M vdsm/supervdsmServer
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/41/19741/1
diff --git a/vdsm/supervdsmServer b/vdsm/supervdsmServer
index 40ec9df..006c35c 100755
--- a/vdsm/supervdsmServer
+++ b/vdsm/supervdsmServer
@@ -30,6 +30,7 @@
import signal
import logging
import logging.config
+import multiprocessing
LOG_CONF_PATH = "/etc/vdsm/svdsm.logger.conf"
@@ -356,6 +357,7 @@
def main(sockfile, pidfile=None):
log = logging.getLogger("SuperVdsm.Server")
+multiprocessing.get_logger().propagate = 1
def bind(func):
def wrapper(_SuperVdsm, *args, **kwargs):
--
To view, visit http://gerrit.ovirt.org/19741
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Idbbe0f1eb294e99de997f78b964a062fdddbb6ea
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add the ability to use bus and device IDs with the hostusb h...
Lee Yarwood has posted comments on this change. Change subject: Add the ability to use bus and device IDs with the hostusb hook. .. Patch Set 9: Verified+1 Marking as verified, mails also sent to vdsm-devel [1] and users [2]. I'll follow up later in the week to have the reviews finished. [1] https://lists.fedorahosted.org/pipermail/vdsm-devel/2013-September/002565.html [2] http://lists.ovirt.org/pipermail/users/2013-September/016224.html -- To view, visit http://gerrit.ovirt.org/17428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00b4b03993cd7290462b0e17457892b23dd41b31 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add the ability to use bus and device IDs with the hostusb h...
Lee Yarwood has posted comments on this change. Change subject: Add the ability to use bus and device IDs with the hostusb hook. .. Patch Set 8: -Verified Dan is correct, the options required for the hook to attach a host USB device by vendor and product IDs has changed from : 0x1234:0xbeef&0x:0xabaa To vendor=0x1234:product=0xbeef&vendor=0x:product=0xabaa I'll send a mail out about this later today. I also need to update the commit message and doc strings a little. -- To view, visit http://gerrit.ovirt.org/17428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00b4b03993cd7290462b0e17457892b23dd41b31 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add the ability to use bus and device IDs with the hostusb h...
Lee Yarwood has posted comments on this change. Change subject: Add the ability to use bus and device IDs with the hostusb hook. .. Patch Set 8: Verified+1 Marking as verified. Can I ask for another round of reviews now this builds correctly and passes the unit tests. Thanks in advance, Lee -- To view, visit http://gerrit.ovirt.org/17428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00b4b03993cd7290462b0e17457892b23dd41b31 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add the ability to use bus and device IDs with the hostusb h...
Lee Yarwood has posted comments on this change. Change subject: Add the ability to use bus and device IDs with the hostusb hook. .. Patch Set 5: Verified -- To view, visit http://gerrit.ovirt.org/17428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I00b4b03993cd7290462b0e17457892b23dd41b31 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Shahar Havivi Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add hostusbdirect hook to vdsm_hooks.
Lee Yarwood has posted comments on this change.
Change subject: Add hostusbdirect hook to vdsm_hooks.
..
Patch Set 1: (1 inline comment)
File vdsm_hooks/hostusbdirect/before_vm_start.py
Line 97:
Line 98: for usb in os.environ['usbhostdirect'].split('&'):
Line 99: bus, device = usb.split(':')
Line 100: chown(bus, device)
Line 101: devices.append({'bus': bus, 'device': device})
Urgh my mistake, why I didn't just call add_device(bus, device) is beyond me.
I'll push a new version later today with this and a few other typos changed.
Line 102:
Line 103: add_devices(domxml, devices)
Line 104: hooking.write_domxml(domxml)
Line 105: except:
--
To view, visit http://gerrit.ovirt.org/17428
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I00b4b03993cd7290462b0e17457892b23dd41b31
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
Gerrit-Reviewer: Dan Kenigsberg
Gerrit-Reviewer: Lee Yarwood
Gerrit-Reviewer: Shahar Havivi
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add hostusbdirect hook to vdsm_hooks.
Lee Yarwood has uploaded a new change for review. Change subject: Add hostusbdirect hook to vdsm_hooks. .. Add hostusbdirect hook to vdsm_hooks. This is a slight variation of the hostusb hook. This version uses the bus and device IDs to attach host USB device to the guest using the following libvirt XML : In the future this could be merged with the hostusb hook. Change-Id: I00b4b03993cd7290462b0e17457892b23dd41b31 Signed-off-by: Lee Yarwood --- M configure.ac M vdsm.spec.in M vdsm_hooks/Makefile.am A vdsm_hooks/hostusbdirect/Makefile.am A vdsm_hooks/hostusbdirect/README A vdsm_hooks/hostusbdirect/after_vm_destroy.py A vdsm_hooks/hostusbdirect/before_vm_migrate_source.py A vdsm_hooks/hostusbdirect/before_vm_start.py A vdsm_hooks/hostusbdirect/sudoers.vdsm_hook_hostusbdirect 9 files changed, 262 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/17428/1 diff --git a/configure.ac b/configure.ac index 0ccca95..39e31f0 100644 --- a/configure.ac +++ b/configure.ac @@ -225,6 +225,7 @@ vdsm_hooks/fileinject/Makefile vdsm_hooks/floppy/Makefile vdsm_hooks/hostusb/Makefile + vdsm_hooks/hostusbdirect/Makefile vdsm_hooks/hugepages/Makefile vdsm_hooks/isolatedprivatevlan/Makefile vdsm_hooks/macspoof/Makefile diff --git a/vdsm.spec.in b/vdsm.spec.in index 235d1db..c1b9431 100644 --- a/vdsm.spec.in +++ b/vdsm.spec.in @@ -389,6 +389,15 @@ Hook is getting vendor and product id of USB device disconnect it from host and attach it to VM +%package hook-hostusb-direct +Summary:Allow attaching USB device from host by bus and device ids. +BuildArch: noarch +Requires: usbutils + +%description hook-hostusb-direct +Hook is getting bus and device id of USB device +disconnect it from host and attach it to VM + %package hook-hugepages Summary:Huge pages enable user to handle VM with 2048KB page files. BuildArch: noarch diff --git a/vdsm_hooks/Makefile.am b/vdsm_hooks/Makefile.am index 8a8d594..fb4052b 100644 --- a/vdsm_hooks/Makefile.am +++ b/vdsm_hooks/Makefile.am @@ -30,6 +30,7 @@ fileinject \ floppy \ hostusb \ + hostusbdirect \ hugepages \ isolatedprivatevlan \ macspoof \ diff --git a/vdsm_hooks/hostusbdirect/Makefile.am b/vdsm_hooks/hostusbdirect/Makefile.am new file mode 100644 index 000..9d0cdbc --- /dev/null +++ b/vdsm_hooks/hostusbdirect/Makefile.am @@ -0,0 +1,52 @@ +# +# Copyright 2013 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +# +# Refer to the README and COPYING files for full details of the license +# + +EXTRA_DIST = \ + after_vm_destroy.py \ + before_vm_migrate_source.py \ + before_vm_start.py \ + sudoers.vdsm_hook_hostusbdirect + +install-data-hook: + chmod 440 $(DESTDIR)$(sysconfdir)/sudoers.d/50_vdsm_hook_hostusbdirect + +install-data-local: install-data-sudoers + $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_vm_start + $(INSTALL_SCRIPT) $(srcdir)/before_vm_start.py \ + $(DESTDIR)$(vdsmhooksdir)/before_vm_start/50_hostusbdirect + $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/after_vm_destroy + $(INSTALL_SCRIPT) $(srcdir)/after_vm_destroy.py \ + $(DESTDIR)$(vdsmhooksdir)/after_vm_destroy/50_hostusbdirect + $(MKDIR_P) $(DESTDIR)$(vdsmhooksdir)/before_vm_migrate_source + $(INSTALL_SCRIPT) $(srcdir)/before_vm_migrate_source.py \ + $(DESTDIR)$(vdsmhooksdir)/before_vm_migrate_source/50_hostusbdirect + +uninstall-local: uninstall-data-sudoers + $(RM) $(DESTDIR)$(vdsmhooksdir)/before_vm_start/50_hostusbdirect + $(RM) $(DESTDIR)$(vdsmhooksdir)/after_vm_destroy/50_hostusbdirect + $(RM) $(DESTDIR)$(vdsmhooksdir)/before_vm_migrate_source/50_hostusbdirect + +install-data-sudoers: + $(MKDIR_P) $(DESTDIR)$(sysconfdir)/sudoers.d + $(INSTALL_DATA) $(srcdir)/sudoers.vdsm_hook_hostusbdirect \ + $(DESTDIR)$(sysconfdir)/sudoers.d/50_vdsm_hook_hostusbdirect + +uninstall-data-sudoers: + $(RM) $(DESTDIR)$(sysconfdir)/sudoers.d/50_vdsm_hook_hostusbdirect diff --git a/vdsm_hooks/hostusbdirect/README b/vdsm_hooks/hostusbdirect/README new fil
Change in vdsm[master]: sos: collect permissions of /etc/vdsm/
Lee Yarwood has abandoned this change. Change subject: sos: collect permissions of /etc/vdsm/ .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/17287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ibaac81d83c6f8c92e16bf65fa2859ccb7e02f5f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Keith Robertson Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: humble devassy Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dumpStorageTable: Avoid an unnecessary traceback if vdsmd is...
Lee Yarwood has posted comments on this change. Change subject: dumpStorageTable: Avoid an unnecessary traceback if vdsmd is down. .. Patch Set 3: Verified -- To view, visit http://gerrit.ovirt.org/17278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d3c0758d9580bfaf164bb3f706d91d8b0ab7f33 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Pavel Zhukov Gerrit-Reviewer: Tomáš Došek Gerrit-Reviewer: humble devassy Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sos: collect permissions of /etc/vdsm/
Lee Yarwood has posted comments on this change. Change subject: sos: collect permissions of /etc/vdsm/ .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17287 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibaac81d83c6f8c92e16bf65fa2859ccb7e02f5f4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Keith Robertson Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: humble devassy ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: sos: collect permissions of /etc/vdsm/
Lee Yarwood has uploaded a new change for review.
Change subject: sos: collect permissions of /etc/vdsm/
..
sos: collect permissions of /etc/vdsm/
sos is not correctly preserving permissions of collected
files (BZ#888724). Until this is fixed we need to gather
the output of ls -lR against /etc/vdsm.
Change-Id: Ibaac81d83c6f8c92e16bf65fa2859ccb7e02f5f4
Bug-Url:https://bugzilla.redhat.com/show_bug.cgi?id=987931
Signed-off-by: Lee Yarwood
---
M vdsm/sos/vdsm.py.in
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/87/17287/1
diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index 63a028c..a62f305 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -81,6 +81,7 @@
self.addCopySpec("/proc/%s/cmdline" % pid)
self.addCopySpec("/proc/%s/status" % pid)
self.addCopySpec("/proc/%s/mountstats" % pid)
+self.collectExtOutput("/bin/ls -lR /etc/vdsm")
self.collectExtOutput("/bin/ls -l /var/log/core")
self.collectExtOutput(
"/bin/su vdsm -s /bin/sh -c '/usr/bin/tree -l @VDSMREPO@'")
--
To view, visit http://gerrit.ovirt.org/17287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibaac81d83c6f8c92e16bf65fa2859ccb7e02f5f4
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dumpStorageTable: Avoid an unnecessary traceback if vdsmd is...
Lee Yarwood has posted comments on this change. Change subject: dumpStorageTable: Avoid an unnecessary traceback if vdsmd is down. .. Patch Set 2: I would prefer that you didn't submit this Humble, please do not submit changes like this without the consent of the change owner... Pushing v2 of my own patch now. -- To view, visit http://gerrit.ovirt.org/17278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d3c0758d9580bfaf164bb3f706d91d8b0ab7f33 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Pavel Zhukov Gerrit-Reviewer: Tomáš Došek Gerrit-Reviewer: humble devassy Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dumpStorageTable: Avoid an unnecessary traceback if vdsmd is...
Lee Yarwood has posted comments on this change. Change subject: dumpStorageTable: Avoid an unnecessary traceback if vdsmd is down. .. Patch Set 1: Verified -- To view, visit http://gerrit.ovirt.org/17278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6d3c0758d9580bfaf164bb3f706d91d8b0ab7f33 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: dumpStorageTable: Avoid an unnecessary traceback if vdsmd is...
Lee Yarwood has uploaded a new change for review. Change subject: dumpStorageTable: Avoid an unnecessary traceback if vdsmd is down. .. dumpStorageTable: Avoid an unnecessary traceback if vdsmd is down. When vdsmd is down the first getConnectedStoragePoolsList call results in a 'Connection Refused' trace being shown. To avoid this trace being picked up by abrt and thus worrying users we should test the connection, catching any errors before continuing. Change-Id: I6d3c0758d9580bfaf164bb3f706d91d8b0ab7f33 Signed-off-by: Lee Yarwood --- M vdsm/dumpStorageTable.py.in 1 file changed, 9 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/78/17278/1 diff --git a/vdsm/dumpStorageTable.py.in b/vdsm/dumpStorageTable.py.in index f75e35f..2d5ef66 100644 --- a/vdsm/dumpStorageTable.py.in +++ b/vdsm/dumpStorageTable.py.in @@ -309,7 +309,15 @@ from vdsm import vdscli import sys -rc, msg = StorageTable(vdscli.connect()).show() +# Test the connection to avoid sending abrt a traceback if vdsmd is down. +try: +conn = vdscli.connect() +conn.getConnectedStoragePoolsList() +except: +print 'Unable to connect to vdsmd' +sys.exit(1) + +rc, msg = StorageTable(conn).show() if rc: print >>sys.stderr, msg sys.exit(rc) -- To view, visit http://gerrit.ovirt.org/17278 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6d3c0758d9580bfaf164bb3f706d91d8b0ab7f33 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: vmChannels: Do not use epoll unregister
Lee Yarwood has posted comments on this change. Change subject: vdsm: vmChannels: Do not use epoll unregister .. Patch Set 4: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/15393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iacb8dee05e179405d7946bef7329ca406223744a Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Gal Hammer Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: Vinzenz Feenstra Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: vmChannels: Do not use epoll unregister
Lee Yarwood has posted comments on this change.
Change subject: vdsm: vmChannels: Do not use epoll unregister
..
Patch Set 2: (1 inline comment)
File vdsm/vmChannels.py
Line 53: self.log.error("Received EPOLLHUP|EPOLLERR on fileno %d",
fileno)
Line 54: if fileno in self._channels:
Line 55: reconnect = True
Line 56: else:
Line 57: self.log.debug("Received EPOLLHUP|EPOLLERR on fd not
handled "
Agreed, something like :
''EPOLLHUP|EPOLLERR received but fd removed by epoll."
Line 58:"by this class anymore.")
Line 59: elif (event & select.EPOLLIN):
Line 60: obj = self._channels[fileno]
Line 61: obj['reconnects'] = 0
--
To view, visit http://gerrit.ovirt.org/15393
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iacb8dee05e179405d7946bef7329ca406223744a
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra
Gerrit-Reviewer: Gal Hammer
Gerrit-Reviewer: Lee Yarwood
Gerrit-Reviewer: Michal Skrivanek
Gerrit-Reviewer: Vinzenz Feenstra
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ensure teardownVolumePath is called with a valid dict.
Lee Yarwood has abandoned this change. Change subject: Ensure teardownVolumePath is called with a valid dict. .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/14811 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I259ee0edd02afe179057b54fc8d1e0843db5be8e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ensure teardownVolumePath is called with a valid dict.
Lee Yarwood has posted comments on this change.
Change subject: Ensure teardownVolumePath is called with a valid dict.
..
Patch Set 1: Fails; I would prefer that you didn't submit this
(1 inline comment)
File vdsm/vm.py
Line 1069: # clean them up
Line 1070: with self._volPrepareLock:
Line 1071: for drive in drives:
Line 1072: try:
Line 1073: self.cif.teardownVolumePath(drive.volumeChain[0])
Ah this is wrong, testing this downstream it actually results in
AttributeError: 'Drive' object has no attribute 'volumeChain'
As a result of which we then clean up the image correctly but I'm not entirely
sure how. I'll Verify this is the same upstream and then propose a new change.
Apologies for the noise!
Line 1074: except:
Line 1075: self.log.error("Drive teardown failure for %s",
Line 1076:drive, exc_info=True)
Line 1077:
--
To view, visit http://gerrit.ovirt.org/14811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I259ee0edd02afe179057b54fc8d1e0843db5be8e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
Gerrit-Reviewer: Lee Yarwood
Gerrit-Reviewer: oVirt Jenkins CI Server
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Ensure teardownVolumePath is called with a valid dict.
Lee Yarwood has uploaded a new change for review.
Change subject: Ensure teardownVolumePath is called with a valid dict.
..
Ensure teardownVolumePath is called with a valid dict.
If teardownVolumePath is not called with a valid dict of format
{'domainID':,'poolID':,'imageID':} we do not inturn call teardownImage
and do not deactivate the volume.
Change-Id: I259ee0edd02afe179057b54fc8d1e0843db5be8e
Bug-Url: https://bugzilla.redhat.com/962549
Signed-off-by: Lee Yarwood
---
M vdsm/storage/hsm.py
M vdsm/vm.py
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/11/14811/1
diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py
index 15b8331..d5d56a0 100644
--- a/vdsm/storage/hsm.py
+++ b/vdsm/storage/hsm.py
@@ -3152,7 +3152,7 @@
for vol in imgVolumes:
volInfo = {'domainID': sdUUID, 'imageID': imgUUID,
'volumeID': vol.volUUID, 'path': vol.getVolumePath(),
- 'vmVolInfo': vol.getVmVolumeInfo()}
+ 'vmVolInfo': vol.getVmVolumeInfo(), 'poolID': spUUID}
if config.getboolean('irs', 'use_volume_leases'):
leasePath, leaseOffset = dom.getVolumeLease(vol.imgUUID,
diff --git a/vdsm/vm.py b/vdsm/vm.py
index 2b76662..5802fc4 100644
--- a/vdsm/vm.py
+++ b/vdsm/vm.py
@@ -1070,7 +1070,7 @@
with self._volPrepareLock:
for drive in drives:
try:
-self.cif.teardownVolumePath(drive)
+self.cif.teardownVolumePath(drive.volumeChain[0])
except:
self.log.error("Drive teardown failure for %s",
drive, exc_info=True)
--
To view, visit http://gerrit.ovirt.org/14811
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I259ee0edd02afe179057b54fc8d1e0843db5be8e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsmd.init: disable libvirt connection keepalives
Lee Yarwood has posted comments on this change. Change subject: vdsmd.init: disable libvirt connection keepalives .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/14010 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I632d02f12481911c4ceb6477c42c3b66de47d0c9 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Greg Padgett Gerrit-Reviewer: Barak Azulay Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Greg Padgett Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Yaniv Bronhaim Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add additional exception handling within vmChannels.py
Lee Yarwood has posted comments on this change. Change subject: vdsm: Add additional exception handling within vmChannels.py .. Patch Set 1: This is an attempt to get the exception handling found in change 11977[1] merged ASAP. [1] http://gerrit.ovirt.org/#/c/11977/7 -- To view, visit http://gerrit.ovirt.org/13093 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie733ca7ccd2689f6041ee18bbe335f355a89ac55 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdsm: Add additional exception handling within vmChannels.py
Lee Yarwood has uploaded a new change for review.
Change subject: vdsm: Add additional exception handling within vmChannels.py
..
vdsm: Add additional exception handling within vmChannels.py
At present any exception thrown by _epoll.poll(1) is not caught. This patch adds
additional exception handling to catch and log any exceptions thrown by the
thread.
Change-Id: Ie733ca7ccd2689f6041ee18bbe335f355a89ac55
Signed-off-by: Lee Yarwood
---
M vdsm/vmChannels.py
1 file changed, 21 insertions(+), 8 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/93/13093/1
diff --git a/vdsm/vmChannels.py b/vdsm/vmChannels.py
index 1d20f1d..024ba4f 100644
--- a/vdsm/vmChannels.py
+++ b/vdsm/vmChannels.py
@@ -21,6 +21,7 @@
import threading
import time
import select
+import errno
class Listener(threading.Thread):
@@ -114,21 +115,33 @@
def _wait_for_events(self):
""" Wait for an epoll event and handle channels' timeout. """
-events = self._epoll.poll(1)
-for (fileno, event) in events:
-self._handle_event(fileno, event)
+try:
+events = self._epoll.poll(1)
+except IOError as err:
+# We don't want to log a quite common error
+if err.errno is not errno.EINTR:
+self.log.exception("IOError on epoll.poll(1)")
+except:
+self.log.exception("Exception on epoll.poll(1)")
else:
-self._update_channels()
-if (self._timeout is not None) and (self._timeout > 0):
-self._handle_timeouts()
-self._handle_unconnected()
+for (fileno, event) in events:
+self._handle_event(fileno, event)
+else:
+self._update_channels()
+if (self._timeout is not None) and (self._timeout > 0):
+self._handle_timeouts()
+self._handle_unconnected()
def run(self):
""" The listener thread's function. """
self.log.info("Starting VM channels listener thread.")
self._quit = False
while not self._quit:
-self._wait_for_events()
+try:
+self._wait_for_events()
+except:
+self.log.exception("Unhandled exception caught in vm channels "
+ "listener thread")
def stop(self):
Stop the listener execution. """
--
To view, visit http://gerrit.ovirt.org/13093
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie733ca7ccd2689f6041ee18bbe335f355a89ac55
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: image: do not delete the template on deleteImage
Lee Yarwood has posted comments on this change. Change subject: image: do not delete the template on deleteImage .. Patch Set 1: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/12105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06c7e6402b901fab6277cd768ce82591e8c21e51 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: upgrade: catch MetaDataKeyNotFoundError when preparing image...
Lee Yarwood has posted comments on this change. Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images .. Patch Set 3: I've also created the 3.2 change as requested by Federico. http://gerrit.ovirt.org/#/c/11485/ -- To view, visit http://gerrit.ovirt.org/11281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92f7a61bf6d1e24e84711486fd4f8ba67e2a0077 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.2]: upgrade: catch MetaDataKeyNotFoundError when preparing image...
Lee Yarwood has posted comments on this change. Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images .. Patch Set 1: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/11485 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92f7a61bf6d1e24e84711486fd4f8ba67e2a0077 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.2 Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: upgrade: catch MetaDataKeyNotFoundError when preparing image...
Lee Yarwood has posted comments on this change.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
..
Patch Set 3: Verified; Looks good to me, but someone else must approve
Verified, we now catch and continue past blanked out metadata.
Thread-786::INFO::2013-01-28 16:43:43,438::logUtils::37::dispatcher::(wrapper)
Run and protect:
upgradeStoragePool(spUUID='5f5b38da-69b2-11e2-8d4a-001a4a210859',
targetDomVersion='3')
[..]
Thread-786::DEBUG::2013-01-28
16:44:06,472::formatConverter::243::Storage.v3DomainConverter::(v3DomainConverter)
Converting image: f9ff166b-3559-4b30-adb4-56eea7c62425
[..]
Thread-786::ERROR::2013-01-28
16:44:06,786::formatConverter::283::Storage.v3DomainConverter::(v3DomainConverter)
It is not possible to prepare the image f9ff166b-3559-4b30-adb4-56eea7c62425,
the volume metadata looks damaged
Traceback (most recent call last):
File "/usr/share/vdsm/storage/imageRepository/formatConverter.py", line 268,
in v3DomainConverter
for vol in img.prepare(domain.sdUUID, imgUUID):
File "/usr/share/vdsm/storage/image.py", line 364, in prepare
chain = self.getChain(sdUUID, imgUUID, volUUID)
File "/usr/share/vdsm/storage/image.py", line 319, in getChain
if len(uuidlist) == 1 and srcVol.isShared():
File "/usr/share/vdsm/storage/volume.py", line 662, in isShared
return self.getVolType() == type2name(SHARED_VOL)
File "/usr/share/vdsm/storage/volume.py", line 623, in getVolType
self.voltype = self.getMetaParam(VOLTYPE)
File "/usr/share/vdsm/storage/volume.py", line 867, in getMetaParam
raise se.MetaDataKeyNotFoundError(str(meta) + ":" + str(key))
MetaDataKeyNotFoundError: Meta Data key not found error: ('{}:VOLTYPE',)
[..]
Thread-786::DEBUG::2013-01-28
16:44:07,121::formatConverter::291::Storage.v3DomainConverter::(v3DomainConverter)
Unable to teardown the image f9ff166b-3559-4b30-adb4-56eea7c62425, this error
is not critical since the volume might be in use
Traceback (most recent call last):
File "/usr/share/vdsm/storage/imageRepository/formatConverter.py", line 287,
in v3DomainConverter
img.teardown(domain.sdUUID, imgUUID)
File "/usr/share/vdsm/storage/image.py", line 379, in teardown
chain = self.getChain(sdUUID, imgUUID, volUUID)
File "/usr/share/vdsm/storage/image.py", line 319, in getChain
if len(uuidlist) == 1 and srcVol.isShared():
File "/usr/share/vdsm/storage/volume.py", line 662, in isShared
return self.getVolType() == type2name(SHARED_VOL)
File "/usr/share/vdsm/storage/volume.py", line 623, in getVolType
self.voltype = self.getMetaParam(VOLTYPE)
File "/usr/share/vdsm/storage/volume.py", line 867, in getMetaParam
raise se.MetaDataKeyNotFoundError(str(meta) + ":" + str(key))
MetaDataKeyNotFoundError: Meta Data key not found error: ('{}:VOLTYPE',)
[..]
Thread-786::DEBUG::2013-01-28
16:44:10,203::formatConverter::295::Storage.v3DomainConverter::(v3DomainConverter)
Finalizing the storage domain upgrade from version 2 to version 3 for domain
dd2e9e56-b962-402b-a316-710037de7a2c
--
To view, visit http://gerrit.ovirt.org/11281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I92f7a61bf6d1e24e84711486fd4f8ba67e2a0077
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Federico Simoncelli
Gerrit-Reviewer: Lee Yarwood
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.2]: upgrade: catch MetaDataKeyNotFoundError when preparing image...
Lee Yarwood has uploaded a new change for review.
Change subject: upgrade: catch MetaDataKeyNotFoundError when preparing images
..
upgrade: catch MetaDataKeyNotFoundError when preparing images
Ensure that we catch and continue past any MetaDataKeyNotFoundError
exception when preparing images that may contain partially removed
volumes. For example where the LV is still present but the metadata
block has been blanked out.
Change-Id: I92f7a61bf6d1e24e84711486fd4f8ba67e2a0077
Signed-off-by: Lee Yarwood
---
M vdsm/storage/imageRepository/formatConverter.py
1 file changed, 5 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/85/11485/1
diff --git a/vdsm/storage/imageRepository/formatConverter.py
b/vdsm/storage/imageRepository/formatConverter.py
index 3c8ac34..e7bf297 100644
--- a/vdsm/storage/imageRepository/formatConverter.py
+++ b/vdsm/storage/imageRepository/formatConverter.py
@@ -280,6 +280,11 @@
log.error("It is not possible to prepare the image %s, the "
"volume chain looks damaged", imgUUID, exc_info=True)
+except se.MetaDataKeyNotFoundError:
+log.error("It is not possible to prepare the image %s, the "
+ "volume metadata looks damaged", imgUUID,
+ exc_info=True)
+
finally:
try:
img.teardown(domain.sdUUID, imgUUID)
--
To view, visit http://gerrit.ovirt.org/11485
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92f7a61bf6d1e24e84711486fd4f8ba67e2a0077
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.2
Gerrit-Owner: Lee Yarwood
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] BZ#748386 - Replace dd with qemu-img convert within _i...
Lee Yarwood has abandoned this change. Change subject: [WIP] BZ#748386 - Replace dd with qemu-img convert within _interImagesCopy. .. Patch Set 1: Abandoned http://gerrit.ovirt.org/#/c/10979/ -- To view, visit http://gerrit.ovirt.org/10088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I50db161a068a7269082baa5474d9057785730c4e Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] BZ#748386 - qemuConvert test cases
Lee Yarwood has abandoned this change. Change subject: [WIP] BZ#748386 - qemuConvert test cases .. Patch Set 2: Abandoned http://gerrit.ovirt.org/#/c/10979/ -- To view, visit http://gerrit.ovirt.org/9290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1c9f302928c246f7ce195d169f8d5a533df1a344 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] BZ#748386 - Refactor and move volume.qemuConvert into ...
Lee Yarwood has abandoned this change. Change subject: [WIP] BZ#748386 - Refactor and move volume.qemuConvert into qemuImg. .. Patch Set 6: Abandoned http://gerrit.ovirt.org/#/c/10979/ -- To view, visit http://gerrit.ovirt.org/8728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I7adc41e8a9f5d4b9faa58a8cf5bec685b66e303e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: upgrade: Catch MetaDataKeyNotFoundError when preparing parti...
Lee Yarwood has uploaded a new change for review.
Change subject: upgrade: Catch MetaDataKeyNotFoundError when preparing
partially removed volumes.
..
upgrade: Catch MetaDataKeyNotFoundError when preparing partially removed
volumes.
Ensure that we catch and continue past any MetaDataKeyNotFoundError exception
when
preparing images that may contain partially removed volumes. For example where
the
LV is still present but the metadata block has been blanked out.
Change-Id: I92f7a61bf6d1e24e84711486fd4f8ba67e2a0077
Signed-off-by: Lee Yarwood
---
M vdsm/storage/imageRepository/formatConverter.py
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/81/11281/1
diff --git a/vdsm/storage/imageRepository/formatConverter.py
b/vdsm/storage/imageRepository/formatConverter.py
index b455059..1a9ec90 100644
--- a/vdsm/storage/imageRepository/formatConverter.py
+++ b/vdsm/storage/imageRepository/formatConverter.py
@@ -277,6 +277,10 @@
log.error("It is not possible to prepare the image %s, the "
"volume chain looks damaged", imgUUID, exc_info=True)
+except se.MetaDataKeyNotFoundError:
+log.error("It is not possible to prepare the image %s, the "
+ "volume metadata looks damaged", imgUUID,
exc_info=True)
+
finally:
try:
img.teardown(domain.sdUUID, imgUUID)
--
To view, visit http://gerrit.ovirt.org/11281
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I92f7a61bf6d1e24e84711486fd4f8ba67e2a0077
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: upgrade: force upgrade to v2 before upgrading to v3
Lee Yarwood has posted comments on this change. Change subject: upgrade: force upgrade to v2 before upgrading to v3 .. Patch Set 2: Verified -- To view, visit http://gerrit.ovirt.org/10792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bd424ad29e76d1368ff2959bb8fe45afc595cdb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: upgrade: force upgrade to v2 before upgrading to v3
Lee Yarwood has posted comments on this change. Change subject: upgrade: force upgrade to v2 before upgrading to v3 .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10792 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2bd424ad29e76d1368ff2959bb8fe45afc595cdb Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Haim Ateya Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#891300 Reload udev rules before calling udevadm trigger.
Lee Yarwood has abandoned this change. Change subject: BZ#891300 Reload udev rules before calling udevadm trigger. .. Patch Set 2: Abandoned replaced by http://gerrit.ovirt.org/#/c/10758/ -- To view, visit http://gerrit.ovirt.org/10656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ic32ee84b789c7bfaace9a7c96fa835c891b3342f Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Derrick Ornelas Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: udev: Race fix- load and trigger dev rule(#891300)
Lee Yarwood has posted comments on this change. Change subject: udev: Race fix- load and trigger dev rule(#891300) .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10758 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If3b2008a3d9df2dcaf54190721c2dd9764338627 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Vered Volansky Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use cp to copy sparse volumes when moving a vm
Lee Yarwood has posted comments on this change. Change subject: Use cp to copy sparse volumes when moving a vm .. Patch Set 5: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10543 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c4c693884a225c868c18bdcb4930c2c1042db2c Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dafna Ron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Eduardo Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Yeela Kaplan Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#891300 Reload udev rules before calling udevadm trigger.
Lee Yarwood has uploaded a new change for review. Change subject: BZ#891300 Reload udev rules before calling udevadm trigger. .. BZ#891300 Reload udev rules before calling udevadm trigger. Change-Id: Ic32ee84b789c7bfaace9a7c96fa835c891b3342f Signed-off-by: Lee Yarwood --- M vdsm/storage/hsm.py M vdsm/supervdsmServer.py 2 files changed, 9 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/56/10656/1 diff --git a/vdsm/storage/hsm.py b/vdsm/storage/hsm.py index efb2749..bc63645 100644 --- a/vdsm/storage/hsm.py +++ b/vdsm/storage/hsm.py @@ -2924,6 +2924,7 @@ Warning: Internal use only. """ supervdsm.getProxy().appropriateDevice(guid, thiefId) +supervdsm.getProxy().udevReloadRules() supervdsm.getProxy().udevTrigger(guid) @public diff --git a/vdsm/supervdsmServer.py b/vdsm/supervdsmServer.py index 5effd41..994d043 100755 --- a/vdsm/supervdsmServer.py +++ b/vdsm/supervdsmServer.py @@ -215,6 +215,14 @@ return configNetwork.setSafeNetworkConfig() @logDecorator +def udevReloadRules(self): +cmd = [EXT_UDEVADM, "control", "--reload-rules"] +rc, out, err = misc.execCmd(cmd, sudo=False) +if rc: +raise OSError(errno.EINVAL, "Could not reload udev rules \ + out %s\nerr %s" % (out, err)) + +@logDecorator def udevTrigger(self, guid): cmd = [EXT_UDEVADM, 'trigger', '--verbose', '--action', 'change', '--property-match=DM_NAME=%s' % guid] -- To view, visit http://gerrit.ovirt.org/10656 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic32ee84b789c7bfaace9a7c96fa835c891b3342f Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] BZ#748386 - Replace dd with qemu-img convert within _i...
Lee Yarwood has uploaded a new change for review.
Change subject: [WIP] BZ#748386 - Replace dd with qemu-img convert within
_interImagesCopy.
..
[WIP] BZ#748386 - Replace dd with qemu-img convert within _interImagesCopy.
_interImagesCopy previously used dd to copy volumes thus fully
allocating sparse file volumes. This change replaces dd with
the new qemuImg.convert method.
Change-Id: I50db161a068a7269082baa5474d9057785730c4e
Signed-off-by: Lee Yarwood
---
M vdsm/storage/image.py
1 file changed, 8 insertions(+), 13 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/10088/1
diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index afb1abf..8f4867a 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -580,19 +580,14 @@
try:
for srcVol in chains['srcChain']:
# Do the actual copy
-try:
-dstVol = destDom.produceVolume(imgUUID=imgUUID,
volUUID=srcVol.volUUID)
-srcSize = srcVol.getVolumeSize(bs=1)
-misc.ddWatchCopy(srcVol.getVolumePath(),
dstVol.getVolumePath(), vars.task.aborting, size=srcSize)
-except se.ActionStopped:
-raise
-except se.StorageException:
-self.log.error("Unexpected error", exc_info=True)
-raise
-except Exception:
-self.log.error("Copy image error: image=%s, src domain=%s,
dst domain=%s", imgUUID, srcSdUUID,
-destDom.sdUUID, exc_info=True)
-raise se.CopyImageError()
+dstVol = destDom.produceVolume(imgUUID=imgUUID,
volUUID=srcVol.volUUID)
+qemuImg.convert(srcVol, srcVol.getFormat(), dstVol,
dstVol.getFormat())
+
+except qemuImg.QImgError(e):
+self.log.error("%s", str(e))
+raise
+except Exception, e:
+raise se.CopyImageError("Error copying src image=%s to dst
image=%s: msg=%s" % (srcImgUUID, dstImgUUID, str(e)))
finally:
# teardown volumes
self.__cleanupMove(srcLeafVol, dstLeafVol)
--
To view, visit http://gerrit.ovirt.org/10088
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I50db161a068a7269082baa5474d9057785730c4e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add sanlock debug info to sosreport.
Lee Yarwood has abandoned this change. Change subject: Add sanlock debug info to sosreport. .. Patch Set 3: Abandoned Already addressed within sos. -- To view, visit http://gerrit.ovirt.org/9589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Ieb02a8b87d24b503ddf6238c09d28e93242d3f56 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add sanlock debug info to sosreport.
Lee Yarwood has posted comments on this change. Change subject: Add sanlock debug info to sosreport. .. Patch Set 3: Fails; I would prefer that you didn't submit this Apologies Federico! I missed this BZ while testing downstream. Abandoning the change now... Lee -- To view, visit http://gerrit.ovirt.org/9589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ieb02a8b87d24b503ddf6238c09d28e93242d3f56 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Add sanlock debug info to sosreport.
Lee Yarwood has uploaded a new change for review.
Change subject: Add sanlock debug info to sosreport.
..
Add sanlock debug info to sosreport.
Collect log_dump and status output from sanlock.
Change-Id: Ieb02a8b87d24b503ddf6238c09d28e93242d3f56
Signed-off-by: Lee Yarwood
---
M vdsm/sos/vdsm.py.in
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/9589/1
diff --git a/vdsm/sos/vdsm.py.in b/vdsm/sos/vdsm.py.in
index 5f09f8d..04ad7fc 100644
--- a/vdsm/sos/vdsm.py.in
+++ b/vdsm/sos/vdsm.py.in
@@ -90,6 +90,8 @@
self.collectExtOutput("/usr/bin/iostat")
self.collectExtOutput("/sbin/iscsiadm -m node")
self.collectExtOutput("/sbin/iscsiadm -m session")
+self.collectExtOutput("/sbin/sanlock client log_dump")
+self.collectExtOutput("/sbin/sanlock client status -D")
sslopt = ['', '-s '][config.getboolean('vars', 'ssl')]
vdsclient = "/usr/bin/vdsClient " + sslopt + "0 "
self.collectExtOutput(vdsclient + "getVdsCapabilities")
--
To view, visit http://gerrit.ovirt.org/9589
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieb02a8b87d24b503ddf6238c09d28e93242d3f56
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Lee Yarwood
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] BZ#748386 - qemuConvert test cases
Lee Yarwood has posted comments on this change. Change subject: [WIP] BZ#748386 - qemuConvert test cases .. Patch Set 1: This is very much a WIP at present but I wanted to at least start pushing to gerrit for viability. I will will up with a thread to vdsm-devel regarding the best way to write tests against volumes shortly. -- To view, visit http://gerrit.ovirt.org/9290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c9f302928c246f7ce195d169f8d5a533df1a344 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] BZ#748386 - qemuConvert test cases
Lee Yarwood has uploaded a new change for review. Change subject: [WIP] BZ#748386 - qemuConvert test cases .. [WIP] BZ#748386 - qemuConvert test cases Adds some simple qemu-img tests against volume.qemuConvert() to ensure volumes remain the correct format after being converted. Change-Id: I1c9f302928c246f7ce195d169f8d5a533df1a344 Signed-off-by: Lee Yarwood --- A tests/qemuImgTests.py A vdsm/storage/fakeVolume.py 2 files changed, 214 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/9290/1 diff --git a/tests/qemuImgTests.py b/tests/qemuImgTests.py new file mode 100644 index 000..e1cc70c --- /dev/null +++ b/tests/qemuImgTests.py @@ -0,0 +1,148 @@ +# +# Copyright 2012 Red Hat, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 2 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA +# +# Refer to the README and COPYING files for full details of the license +# + +from testrunner import VdsmTestCase as TestCase + +import tempfile +import uuid +import os + + +from storage.threadLocal import vars +from storage.fakeVolume import FakeFileVolume +import storage.task as task +import storage.volume as volume +import storage.misc as misc + +EXT_QEMUIMG = '/bin/qemu-img' +EXT_DD = '/bin/dd' +VOL_SIZE = "10M" +VOL_ALLOC = "20" + +class FileVolumes(): + +def __init__(self): +self.dir = tempfile.mkdtemp() +self.sduuid = str(uuid.uuid4()) +self.imguuid = str(uuid.uuid4()) +self.repo = self.dir + "/" + self.sduuid + "/images/" + self.imguuid +os.makedirs(self.repo) + +def genPathUUID(self): +u = str(uuid.uuid4()) +p = self.repo + "/" + u +return p, u + + +def createCOW(self): +path, voluuid = self.genPathUUID() +misc.execCmd([EXT_QEMUIMG, "create", "-f", "qcow2", path, VOL_SIZE],sync=False) +return FakeFileVolume(repoPath=self.dir, sdUUID=self.sduuid, imgUUID=self.imguuid, volUUID=voluuid, + volFormat=volume.COW_FORMAT, volPath=path) + +def createRAW(self): +path, voluuid = self.genPathUUID() +misc.execCmd([EXT_QEMUIMG, "create", "-f", "raw", path, VOL_SIZE],sync=False) +return FakeFileVolume(repoPath=self.dir, sdUUID=self.sduuid, imgUUID=self.imguuid, volUUID=voluuid, + volFormat=volume.RAW_FORMAT, volPath=path) + +def createCOWPrealloc(self): +v = self.createCOW() +misc.execCmd([EXT_DD, "if=/dev/zero", "of=%s" % v.getVolumePath(), "bs=512"]) +return v + + +def createCOWChild(self,parent): +path, voluuid = self.genPathUUID() +misc.execCmd([EXT_QEMUIMG, "create", "-f", "qcow2", "-o", "backing_file=%s/%s,backing_fmt=raw" % +(self.repo,parent.volUUID), self.repo + "/" + voluuid, VOL_SIZE],sync=False) +fake = FakeFileVolume(repoPath=self.dir, sdUUID=self.sduuid, imgUUID=self.imguuid, volUUID=voluuid, +volFormat=volume.COW_FORMAT, volPath=path) +# Hack to avoid a call to sdc.produce() later when we try to find the parent. +fake.setParent(parent.volUUID) +fake.setParentVolume(parent) +return fake + +def cleanUp(self): +os.rmdir(self.dir) + + +class qemuImgRebaseTestCase(TestCase): +""" + +""" + +class qemuImgCreateTestCase(TestCase): +""" + +""" + +class qemuImgConvertTestCase(TestCase): + + +def runQemuConvert(self, src, dst): + +vars.task = task.Task(id=None, name='qemuImgTests') +try: +(rc, out, err) = volume.qemuConvert(src, dst, vars.task.aborting) +self.assertFalse(rc) +except Exception: + self.fail() + + +def testFileQemuConvert(self): +# create the repo +t = FileVolumes() + +# RAW to RAW +src = t.createRAW() +dst = t.createRAW() +self.runQemuConvert(src, dst) + +# QCOW2 to RAW +#src = t.createCOW() +#dst = t.createRAW() +#self.runQemuConvert(src, dst) + +# RAW to QCOW2 +#src = t.createRAW() +#dst = t.createCOW() +#self.runQemuConvert(src, dst) + +# RAW<-QCOW2 to RAW<-QCOW2 +parent = t.createRAW() +src = t.createCOWChild(parent) +dst = t.createCOW()
Change in vdsm[master]: [WIP] BZ#748386 - refactor qemuConvert to only use qemu-img ...
Lee Yarwood has uploaded a new change for review.
Change subject: [WIP] BZ#748386 - refactor qemuConvert to only use qemu-img
convert.
..
[WIP] BZ#748386 - refactor qemuConvert to only use qemu-img convert.
This change refactors the qemuConvert method, dropping the use of dd with RAW
volumes in favour of qemu-img
convert thus preserving sparseness. The change also introduces the use of the
backing_file and backing_fmt
options when converting COW volumes.
Change-Id: I7adc41e8a9f5d4b9faa58a8cf5bec685b66e303e
Signed-off-by: Lee Yarwood
---
M vdsm/storage/image.py
M vdsm/storage/volume.py
2 files changed, 25 insertions(+), 38 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/28/8728/1
diff --git a/vdsm/storage/image.py b/vdsm/storage/image.py
index e86d94c..69ab6b6 100644
--- a/vdsm/storage/image.py
+++ b/vdsm/storage/image.py
@@ -788,19 +788,9 @@
try:
# Start the actual copy image procedure
-srcVol.prepare(rw=False)
+srcVol.prepare(rw=True, chainrw=True, setrw=True)
dstVol.prepare(rw=True, setrw=True)
-
-try:
-(rc, out, err) = volume.qemuConvert(volParams['path'],
dstPath,
-volParams['volFormat'], dstVolFormat,
vars.task.aborting,
-size=srcVol.getVolumeSize(bs=1),
dstvolType=dstVol.getType())
-if rc:
-raise se.StorageException("rc: %s, err: %s" % (rc,
err))
-except se.ActionStopped, e:
-raise e
-except se.StorageException, e:
-raise se.CopyImageError(str(e))
+(rc, out, err) = volume.qemuConvert(srcVol, dstVol, self.idle,
vars.task.aborting)
# Mark volume as SHARED
if volType == volume.SHARED_VOL:
@@ -997,12 +987,12 @@
# Step 2: Convert successor to new volume
# qemu-img convert -f qcow2 successor -O raw newUUID
-(rc, out, err) = volume.qemuConvert(srcVolParams['path'],
newVol.getVolumePath(),
-srcVolParams['volFormat'], volParams['volFormat'],
vars.task.aborting,
-size=volParams['apparentsize'], dstvolType=newVol.getType())
-if rc:
-self.log.error("qemu-img convert failed: rc=%s, out=%s, err=%s",
-rc, out, err)
+try:
+(rc, out, err) = volume.qemuConvert(srcVol, newVol, self.idle,
vars.task.aborting)
+except se.ActionStopped:
+raise
+except se.StorageException:
+self.log.error("Unexpected error", exc_info=True)
raise se.MergeSnapshotsError(newUUID)
newVol.teardown(sdUUID=newVol.sdUUID, volUUID=newVol.volUUID)
diff --git a/vdsm/storage/volume.py b/vdsm/storage/volume.py
index b9eb356..875b59a 100644
--- a/vdsm/storage/volume.py
+++ b/vdsm/storage/volume.py
@@ -960,28 +960,25 @@
log.debug('(qemuRebase): REBASE %s DONE' % (src))
return (rc, out, err)
+def qemuConvert(src, dst, idle, stop):
+"""
+Copy the src image into the new dst.
+"""
+cmd = constants.CMD_LOWPRIO + [constants.EXT_QEMUIMG, "convert", "-t",
"none",
+"-f", fmt2str(src.getFormat()), "-O",
fmt2str(dst.getFormat())]
-def qemuConvert(src, dst, src_fmt, dst_fmt, stop, size, dstvolType):
-"""
-Convert the 'src' image (or chain of images) into a new single 'dst'
-"""
-src_fmt = fmt2str(src_fmt)
-dst_fmt = fmt2str(dst_fmt)
-log.debug('(qemuConvert): COPY %s (%s) to %s (%s) START' %
- (src, src_fmt, dst, dst_fmt))
+# backing_file only used when src has a parent and both volumes are COW.
+if src.getParentVolume() and src.getFormat() == COW_FORMAT and
dst.getFormat() == COW_FORMAT :
+cmd += ["-o", "backing_file=%s,backing_fmt=%s" %
(src.getParentVolume().getVolumePath(),
+
fmt2str(src.getParentVolume().getFormat()))]
-if (src_fmt == "raw" and dst_fmt == "raw" and
-dstvolType == PREALLOCATED_VOL):
-(rc, out, err) = misc.ddWatchCopy(
- src=src, dst=dst,
- stop=stop, size=size,
- recoveryCallback=baseAsyncTasksRollback)
-else:
-cmd = constants.CMD_LOWPRIO + [constants.EXT_QEMUIMG, "convert",
- "-t", "none", "-f", src_fmt, src,
- "-O", dst_fmt, dst]
-(rc, out, err) = misc.watchCmd(cmd, stop=stop,
+cmd += [src.getVolumePath(), dst.getVolumePath()]
+
+(rc, out, err) = misc.watchCmd(cmd, stop=stop, idle=idle, sudo=False,
recoveryCallback=baseAsyncTasksRollback)
-log.debug('(qemuConvert): COPY %s to %s DONE'
Change in vdsm[master]: BZ#839312 - Use cp to copy sparse files to ensure they remai...
Lee Yarwood has abandoned this change. Change subject: BZ#839312 - Use cp to copy sparse files to ensure they remain sparse. .. Patch Set 1: Abandoned Abandoning the change and submitting a fresh, rebased and highly revised change shortly. -- To view, visit http://gerrit.ovirt.org/6160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: Iff138110bd0990cd7d41481b933fb6776a3fcdaf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nigel Jones Gerrit-Reviewer: Shu Ming Gerrit-Reviewer: Yeela Kaplan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Report host hyperthreads as real cores
Lee Yarwood has posted comments on this change. Change subject: Report host hyperthreads as real cores .. Patch Set 2: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/7097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I950c1ce84933204b2d33844c3b3d9485667581af Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Dan Kenigsberg Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Gal Hammer Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Michal Skrivanek Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#839312 - Use cp to copy sparse files to ensure they remai...
Lee Yarwood has posted comments on this change. Change subject: BZ#839312 - Use cp to copy sparse files to ensure they remain sparse. .. Patch Set 1: (1 inline comment) File vdsm/storage/image.py Line 584: if isinstance(dstVol, fileVolume.FileVolume) and dstVol.getType() == volume.SPARSE_VOL: Yes that's a valid case, for example if the export domain is block (only possible with older downstream versions) and the data is file based. AFAIK cp will provide a block by block copy of the LV into a file. I hadn't thought of using qemu-img at the time of writing this patch but a number of people have since highlighted it to me. I'll rewrite this change to use qemu-img instead, removing this horrid check and verify against the above use case. Thanks, Lee -- To view, visit http://gerrit.ovirt.org/6160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff138110bd0990cd7d41481b933fb6776a3fcdaf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Igor Lvovsky Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nigel Jones Gerrit-Reviewer: Yeela Kaplan ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#839312 - Use cp to copy sparse files to ensure they remai...
Lee Yarwood has posted comments on this change. Change subject: BZ#839312 - Use cp to copy sparse files to ensure they remain sparse. .. Patch Set 1: (1 inline comment) WIP attempt to correct BZ#839312 upstream. Comments welcome as always. File vdsm/storage/image.py Line 584: if isinstance(dstVol, fileVolume.FileVolume) and dstVol.getType() == volume.SPARSE_VOL: Aside from not being pep8 compliant this feels like a horrid hack to me, does anyone have any better ideas? -- To view, visit http://gerrit.ovirt.org/6160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iff138110bd0990cd7d41481b933fb6776a3fcdaf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Nigel Jones ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#839312 - Use cp to copy sparse files to ensure they remai...
Lee Yarwood has uploaded a new change for review. Change subject: BZ#839312 - Use cp to copy sparse files to ensure they remain sparse. .. BZ#839312 - Use cp to copy sparse files to ensure they remain sparse. Previously all volumes were copied with dd, with sparse files this would result in the destination volume being fully allocated and thus no longer sparse. Change-Id: Iff138110bd0990cd7d41481b933fb6776a3fcdaf Signed-off-by: Lee Yarwood --- M vdsm/storage/image.py M vdsm/storage/misc.py 2 files changed, 27 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/60/6160/1 -- To view, visit http://gerrit.ovirt.org/6160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iff138110bd0990cd7d41481b933fb6776a3fcdaf Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use more descriptive exceptions for blocksize errors.
Lee Yarwood has abandoned this change. Change subject: Use more descriptive exceptions for blocksize errors. .. Patch Set 1: Abandoned -- To view, visit http://gerrit.ovirt.org/3688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I1bdb9aa24a5efa5c919ace632dfaba8d96fc3c73 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#824729 - Use doubler param in _loadCorrectedTimeout
Lee Yarwood has posted comments on this change. Change subject: BZ#824729 - Use doubler param in _loadCorrectedTimeout .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4728 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I83678b27411e3d582fb36858d79aba9dc4c15ac6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nigel Jones Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Correct spmprotect.sh to log the sdUUID to spm-lock.log.
Lee Yarwood has posted comments on this change. Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. .. Patch Set 1: Ayal, do you mean a generic test for spmprotect.sh or just in the context of this change (that only changes the logging...)? If it's the former I can follow up in an additional commit with something. Thanks, Lee -- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Saggi Mizrahi Gerrit-Reviewer: Shu Ming ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Correct spmprotect.sh to log the sdUUID to spm-lock.log.
Lee Yarwood has posted comments on this change. Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. .. Patch Set 1: Looks good to me, but someone else must approve Apologies I've been out for a while. Bumping this again, hopefully there are no objections? -- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#809012 - Calculate metadata offset from logical block siz...
Lee Yarwood has posted comments on this change. Change subject: BZ#809012 - Calculate metadata offset from logical block size .. Patch Set 1: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0dd89a5d2a2f24e55e777529d5e667517d7c0983 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nigel Jones Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Correct spmprotect.sh to log the sdUUID to spm-lock.log.
Lee Yarwood has posted comments on this change. Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. .. Patch Set 1: I'd be happy to leave this correction to the original authors if you'd like to keep git blame clean Dan. -- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Correct spmprotect.sh to log the sdUUID to spm-lock.log.
Lee Yarwood has uploaded a new change for review. Change subject: Correct spmprotect.sh to log the sdUUID to spm-lock.log. .. Correct spmprotect.sh to log the sdUUID to spm-lock.log. saferelease.acquire() actually calls spmprotect.sh with the sdUUID and not the spUUID. Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Signed-off-by: Lee Yarwood --- M vdsm/storage/protect/spmprotect.sh 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/21/3821/1 -- To view, visit http://gerrit.ovirt.org/3821 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I39a5499e8db28b0a54a186099877804601543b80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use more descriptive exceptions for blocksize errors.
Lee Yarwood has posted comments on this change. Change subject: Use more descriptive exceptions for blocksize errors. .. Patch Set 1: Looks good to me, but someone else must approve Required by ovirt-engine change http://gerrit.ovirt.org/3696. -- To view, visit http://gerrit.ovirt.org/3688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1bdb9aa24a5efa5c919ace632dfaba8d96fc3c73 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Use more descriptive exceptions for blocksize errors.
Lee Yarwood has uploaded a new change for review. Change subject: Use more descriptive exceptions for blocksize errors. .. Use more descriptive exceptions for blocksize errors. DeviceLogicalBlockSizeError - 518 DevicePhysicalBlockSizeError - 519 Change-Id: I1bdb9aa24a5efa5c919ace632dfaba8d96fc3c73 Signed-off-by: Lee Yarwood --- M AUTHORS M vdsm/storage/lvm.py M vdsm/storage/storage_exception.py 3 files changed, 13 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/3688/1 -- To view, visit http://gerrit.ovirt.org/3688 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I1bdb9aa24a5efa5c919ace632dfaba8d96fc3c73 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#809012 - Remove physical block size limitations
Lee Yarwood has posted comments on this change. Change subject: BZ#809012 - Remove physical block size limitations .. Patch Set 9: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82630ff2964f875a2e135dad550eafca451af42d Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood Gerrit-Reviewer: Peter V. Saveliev Gerrit-Reviewer: Saggi Mizrahi ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#809012 - Remove physical block size limitations.
Lee Yarwood has posted comments on this change. Change subject: BZ#809012 - Remove physical block size limitations. .. Patch Set 8: Looks good to me, but someone else must approve It looks like we are in agreement about this patch now. I've got another vdsm and engine patch queued to add more descriptive exceptions but I'll also look into the blockSD.create() check Ayal has suggested. -- To view, visit http://gerrit.ovirt.org/3284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82630ff2964f875a2e135dad550eafca451af42d Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#809012 - Remove physical block size limitations.
Lee Yarwood has posted comments on this change. Change subject: BZ#809012 - Remove physical block size limitations. .. Patch Set 7: No score (2 inline comments) File vdsm/constants.py.in Line 39: SUPPORTED_BLOCKSIZE = (512,) Correct, sorry I thought I had removed this, the actual check isn't required as we already check each PV above with : 803 _checkpvsblksize(pvs) File vdsm/storage/multipath.py Line 152: return (logical, physical) I'm not sure I follow Ayal, the function would only print an error message if the logical block size was different to the physical block size. I wouldn't call it validation. IIRC we are reviewing the blocksizes _before_ calling blockSD.create() anyway. -- To view, visit http://gerrit.ovirt.org/3284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82630ff2964f875a2e135dad550eafca451af42d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#809012 - Remove physical block size limitations.
Lee Yarwood has posted comments on this change. Change subject: BZ#809012 - Remove physical block size limitations. .. Patch Set 7: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/3284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82630ff2964f875a2e135dad550eafca451af42d Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#809012 - Remove physical block size limitations.
Lee Yarwood has posted comments on this change. Change subject: BZ#809012 - Remove physical block size limitations. .. Patch Set 6: (1 inline comment) File vdsm/storage/lvm.py Line 896: pvBlkSize = _getpvblksize(pv) Rushing to push this before leaving the office I missed this whitespace, does the team use any commit hooks to run things through pylint etc? -- To view, visit http://gerrit.ovirt.org/3284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82630ff2964f875a2e135dad550eafca451af42d Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#809012 - Remove physical block size limitations.
Lee Yarwood has posted comments on this change. Change subject: BZ#809012 - Remove physical block size limitations. .. Patch Set 4: (1 inline comment) File vdsm/storage/lvm.py Line 907: if (logPvBlkSize, phyPvBlkSize) != vgBlkSize: > if logPvBlckSize < phyBlkSize: 901 already checks this, we only accept phyBlkSize >= logPvBlkSize as you previously suggested. > if logPvBlkSize != vgBlkSize: I think you mean if logPvBlkSize != vgBlkSize[0]: but I understand what your getting at, we only care about the logical size with this check as well. -- To view, visit http://gerrit.ovirt.org/3284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82630ff2964f875a2e135dad550eafca451af42d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#809012 - Remove physical block size limitations.
Lee Yarwood has posted comments on this change. Change subject: BZ#809012 - Remove physical block size limitations. .. Patch Set 2: (2 inline comments) File vdsm/storage/lvm.py Line 896: pvBlkSize = _getpvblksize(pv) Dan I don't understand, do you want us to call _getpvblksize() three times in the same method? Line 897: logPvBlkSize, phyPvBlkSize = pvBlkSize I'll add this back in and throw the generic DeviceBlockSizeError for now. -- To view, visit http://gerrit.ovirt.org/3284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I82630ff2964f875a2e135dad550eafca451af42d Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Ayal Baron Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Federico Simoncelli Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: BZ#809012 - Remove physical block size limitations.
Lee Yarwood has uploaded a new change for review. Change subject: BZ#809012 - Remove physical block size limitations. .. BZ#809012 - Remove physical block size limitations. Corrects limitations set against the logical and physical block size of a device. Also hints at adding finer grain exceptions for errors related to the block size of a device. Change-Id: I82630ff2964f875a2e135dad550eafca451af42d --- M vdsm/constants.py.in M vdsm/storage/lvm.py M vdsm/storage/multipath.py 3 files changed, 9 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/84/3284/1 -- To view, visit http://gerrit.ovirt.org/3284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I82630ff2964f875a2e135dad550eafca451af42d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improves logging when attempting to run hooks for a vm.
Lee Yarwood has abandoned this change. Change subject: Improves logging when attempting to run hooks for a vm. .. Patch Set 2: Abandoned As agreed with Dan hooks are already logged by execCmd and thus is not required. -- To view, visit http://gerrit.ovirt.org/243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: abandon Gerrit-Change-Id: I9f3f15dda5560ef515c6753293c9f1ec2ed874e4 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood Gerrit-Reviewer: Dan Kenigsberg Gerrit-Reviewer: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Improves logging when attempting to run hooks for a vm.
Lee Yarwood has uploaded a new change for review. Change subject: Improves logging when attempting to run hooks for a vm. .. Improves logging when attempting to run hooks for a vm. Change-Id: I9f3f15dda5560ef515c6753293c9f1ec2ed874e4 --- M vdsm/hooks.py 1 file changed, 5 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/243/1 -- To view, visit http://gerrit.ovirt.org/243 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9f3f15dda5560ef515c6753293c9f1ec2ed874e4 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Lee Yarwood ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://fedorahosted.org/mailman/listinfo/vdsm-patches
