Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Michal Skrivanek has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Verified in deep together with 38805 but *NEVER* in isolation. See comments in 38805 for documentation of verification steps and log excerpts. -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 5:
Additional Verification (on Isolation): VDSM Master with Engine Master:
JSONRPC:
Thread-77::DEBUG::2015-03-18
11:05:13,139::__init__::469::jsonrpc.JsonRpcServer::(_serveRequest) Calling
'Host.getVMFullList' in bridge with {u'vmList':
[u'995a5f50-9f77-479d-9f05-acc00965dd3e']}
JsonRpcServer::DEBUG::2015-03-18
11:05:13,139::__init__::506::jsonrpc.JsonRpcServer::(serve_requests) Waiting
for request
Thread-77::DEBUG::2015-03-18
11:05:13,140::__init__::500::jsonrpc.JsonRpcServer::(_serveRequest) Return
'Host.getVMFullList' in bridge with [{u'acpiEnable': u'true',
u'emulatedMachine': u'rhel6.5.0', 'pid': '18719', u'memGuaranteedSize': 8192,
u'spiceSslCipherSuite': u'DEFAULT', 'displaySecurePort': u'5900',
u'timeOffset': u'0', u'cpuType': u'SandyBridge', u'smp': u'2', 'pauseCode':
'NOERR', u'smartcardEnable': u'false', u'custom':
{u'device_b0a9483f-8106-4a62-9deb-94d701194647device_9a8c7e80-cd0b-4454-8974-5aebc6151e5e':
u'VmDevice {vmId=995a5f50-9f77-479d-9f05-acc00965dd3e,
deviceId=9a8c7e80-cd0b-4454-8974-5aebc6151e5e, device=ide, type=CONTROLLER,
bootOrder=0, specParams={}, address={slot=0x01, bus=0x00, domain=0x,
type=pci, function=0x1}, managed=false, plugged=true, readOnly=false,
deviceAlias=ide0, customProperties={}, snapshotId=null, logicalName=null}',
u'device_b0a9483f-8106-4a62-9deb-94d701194647': u'VmDevice
{vmId=995a5f50-9f77-479d-9f05-acc00965dd3e, deviceId!
=b0a9483f-8106-4a62-9deb-94d701194647, device=virtio-serial, type=CONTROLLER,
bootOrder=0, specParams={}, address={slot=0x04, bus=0x00, domain=0x,
type=pci, function=0x0}, managed=false, plugged=true, readOnly=false,
deviceAlias=virtio-serial0, customProperties={}, snapshotId=null,
logicalName=null}',
u'device_b0a9483f-8106-4a62-9deb-94d701194647device_9a8c7e80-cd0b-4454-8974-5aebc6151e5edevice_7c593783-8146-407b-8e57-20d768bc2179device_1f301e5b-db4c-4528-a381-4b62532c6d19device_473d465a-0617-431f-939a-9d94d537d932':
u'VmDevice {vmId=995a5f50-9f77-479d-9f05-acc00965dd3e,
deviceId=473d465a-0617-431f-939a-9d94d537d932, device=spicevmc, type=CHANNEL,
bootOrder=0, specParams={}, address={bus=0, controller=0, type=virtio-serial,
port=3}, managed=false, plugged=true, readOnly=false, deviceAlias=channel2,
customProperties={}, snapshotId=null, logicalName=null}',
u'device_b0a9483f-8106-4a62-9deb-94d701194647device_9a8c7e80-cd0b-4454-8974-5aebc6151e5edevice_7c593783-8146-407b-8e!
57-20d768bc2179device_1f301e5b-db4c-4528-a381-4b62532c6d19': u'VmDevice
{vmId=995a5f50-9f77-479d-9f05-acc00965dd3e,
deviceId=1f301e5b-db4c-4528-a381-4b62532c6d19, device=unix, type=CHANNEL,
bootOrder=0, specParams={}, address={bus=0, controller=0, type=virtio-serial,
port=2}, managed=false, plugged=true, readOnly=false, deviceAlias=channel1,
customProperties={}, snapshotId=null, logicalName=null}',
u'device_b0a9483f-8106-4a62-9deb-94d701194647device_9a8c7e80-cd0b-4454-8974-5aebc6151e5edevice_7c593783-8146-407b-8e57-20d768bc2179':
u'VmDevice {vmId=995a5f50-9f77-479d-9f05-acc00965dd3e,
deviceId=7c593783-8146-407b-8e57-20d768bc2179, device=unix, type=CHANNEL,
bootOrder=0, specParams={}, address={bus=0, controller=0, type=virtio-serial,
port=1}, managed=false, plugged=true, readOnly=false, deviceAlias=channel0,
customProperties={}, snapshotId=null, logicalName=null}'}, u'vmType': u'kvm',
u'memSize': 8192, u'smpCoresPerSocket': u'1', u'vmName': u'F20_R7', u'nice':
u'0', 'status': 'Up', u'bootMenuEnable': u'false', u'vmId':
u'995a5f50-9f77-479d-9f05!
-acc00965dd3e', 'displayIp': '192.168.1.39', 'displayPort': '-1',
'guestDiskMapping': {}, 'clientIp': '', 'nicModel': 'rtl8139,pv',
u'keyboardLayout': u'en-us', u'kvmEnable': u'true', u'transparentHugePages':
u'true', u'displayNetwork': u'ovirtmgmt', u'devices': [{'target': 8388608,
u'specParams': {u'model': u'virtio'}, 'alias': u'balloon0', 'deviceType':
u'balloon', u'deviceId': u'0a9631ed-7e89-47d5-80a8-9241285788ae', u'address':
{u'slot': u'0x06', u'bus': u'0x00', u'domain': u'0x', u'type': u'pci',
u'function': u'0x0'}, u'device': u'memballoon', u'type': u'balloon'},
{u'specParams': {}, 'alias': u'virtio-serial0', 'deviceType': u'controller',
u'deviceId': u'b0a9483f-8106-4a62-9deb-94d701194647', u'address': {u'slot':
u'0x04', u'bus': u'0x00', u'domain': u'0x', u'type': u'pci', u'function':
u'0x0'}, u'device': u'virtio-serial', u'type': u'controller'}, {u'specParams':
{u'vram': u'32768', u'heads': u'1'}, 'alias': u'video0', 'deviceType':
u'video', u'deviceId': u'6!
c698a9d-b68a-4886-8c27-50844e4e04ad', u'address': {u'slot': u'0x02', u'bus':
u'0x00', u'domain': u'0x', u'type': u'pci', u'function': u'0x0'},
u'device': u'qxl', u'type': u'video'}, {'device': 'spice', 'specParams':
{'displayNetwork': u'ovirtmgmt', 'keyMap': u'en-us', 'displayIp':
Change in vdsm[master]: API: onlyUUID should affect only short status
Dan Kenigsberg has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
automat...@ovirt.org has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 7: * Update tracker::#1196327::OK * Set MODIFIED::bug 1196327#1196327IGNORE, not all related patches are closed, check 38805 -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Dan Kenigsberg has submitted this change and it was merged. Change subject: API: onlyUUID should affect only short status .. API: onlyUUID should affect only short status this patch makes the 'onlyUUID' parameter take effect only if 'fullStatus' equals False (short status was asked). depending on 'fullStatus' boolean parameter, the getVMList API can return either full or short VM status. Due to a bug originally introduced before 3.5.0, short status was incorrectly produced as list(UUIDs), but it is meant to be a list(dict(vmId:UUID, status:vmStatus), ) The 'onlyUUID' parameter was added to preserve backward compatibility with early Engines 3.5.x, but it is meant to fix short status (fullStatus=False), and should not always affect output. Instead, the current code always produces short and broken status if 'onlyUUID' equals True, with the side effect that also fullStatus is affected. Bug-Url: https://bugzilla.redhat.com/1196327 Related-To: https://bugzilla.redhat.com/1196735 Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Signed-off-by: Francesco Romani from...@redhat.com Reviewed-on: https://gerrit.ovirt.org/38679 Reviewed-by: Dan Kenigsberg dan...@redhat.com --- M vdsm/API.py M vdsm/rpc/Bridge.py M vdsm/rpc/vdsmapi-schema.json 3 files changed, 8 insertions(+), 5 deletions(-) Approvals: Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
automat...@ovirt.org has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 6: * Update tracker::#1196327::OK * Check Bug-Url::OK * Check Public Bug::#1196327::OK, public bug * Check Product::#1196327::OK, Correct product oVirt * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 6: Verified+1 version 6 changes the bug url(s) (and apparently drops all the score in the process) with no code changes. Copying my score. -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 6: Build Failed http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16821/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16993/ : FAILURE -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 7: Build Failed http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el6-x86_64_merged/752/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc21-x86_64_merged/348/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master_unit-tests_merged/4733/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc21-x86_64_merged/725/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el6-x86_64_merged/353/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master_create-rpms-el7-x86_64_merged/754/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-el7-x86_64_merged/352/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master-libgfapi_create-rpms-fc20-x86_64_merged/342/ : ABORTED http://jenkins.ovirt.org/job/vdsm_master_create-rpms-fc20-x86_64_merged/758/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Piotr Kliczewski has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16769/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16941/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Adam Litke has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/4/vdsm/API.py
File vdsm/API.py:
Line 1385: vmSet = set(vmList)
Line 1386: vmlist = [v.status(fullStatus)
Line 1387: for v in self._cif.vmContainer.values()
Line 1388: if not vmSet or v.id in vmSet]
Line 1389: if not fullStatus and onlyUUID:
onlyUUID was born with an intention to change only the fullStatus=False beh
Documentation updated locally, change not yet uploaded.
Commit message will be fixed to reflect that MOM change fixes the issue, not
this patch.
Line 1390: # BZ 1196735: api backward compatibility issue
Line 1391: # REQUIRED_FOR: engine-3.5.0 only
Line 1392: vmlist = [v['vmId'] for v in vmlist]
Line 1393: return {'status': doneCode, 'vmList': vmlist}
--
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Martin Sivák has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 4: Code-Review-1 Here are my comments to the way this is fixed. I learned three things after I discussed this with Dan and Francesco: 1) MOM is the only direct consumer of API.py 2) The issue is only in engine's usage of JSONRPC and does not hit XMLRPC 3) The engine only consumes API.py through the Bridge Taking those three points into account we should fix the issue (change the default behaviour) in the Bridge implementation. That way MOM will still see what it expects, no compatibility issues will appear and the bug will be just as gone. So Piotrs comment about changing the default in the 3rd revision is right (engine in 3.5), but at the wrong place. We should change the default for JSONRPC and keep API intact to stay MOM compatible. -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: I split the onlyUUID default switch patch in https://gerrit.ovirt.org/#/c/38805 , we can continue discussion over here. -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 4: Given the last concerns about MOM compatibility (being a proper Fedora Package, may break some 3.3/3.4 setups) assuming we do want to follow onlyUUID with fullStatus=False only, so we want this patch in: I did a careful review of all the possible flows, and it seems that - in XMLRPC, we always set explicitely onlyUUID=False, so no room for breakage - in JSONRPC, we have Host_getVMList_Call (short status!), on which - if onlyUUID is provided from the outside, we use it (Engine = 3.5.1) - if onlyUUID is NOT given (Engine 3.5.0), we default as True, and doing so we preserve the backward compatibility - in JSONRPC, in Host_getVMFullList_Call (full status), we use onlyUUID=False explicitely, so no issue hee So, if the above analysis is correct, it seems we always pass the correct value to onlyUUID and, moreover, we never relies on its default values. Then, it seems legit to switch the default values to the one which also preserves MOM backward compatibility (onlyUUID=False), because - in API.py, we need to be backward compatible with MOM, which calls getVMList both with FullStatus=True and without any arguments. Please review the above and tell me what is wrong. If everything's right, we may able to just switch default, drop the MOM patch(es) and fix the remaining issues with just this patch. -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
automat...@ovirt.org has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: * Update tracker::#1196735::OK * Check Bug-Url::OK * Check Public Bug::#1196735::OK, public bug * Check Product::#1196735::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Martin Sivák has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Code-Review+1 Yep I like this approach much better. -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Dan Kenigsberg has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Piotr Kliczewski has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 2: -Code-Review -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Piotr Kliczewski has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/4/vdsm/API.py
File vdsm/API.py:
Line 1385: vmSet = set(vmList)
Line 1386: vmlist = [v.status(fullStatus)
Line 1387: for v in self._cif.vmContainer.values()
Line 1388: if not vmSet or v.id in vmSet]
Line 1389: if not fullStatus and onlyUUID:
Once mom change is in do we really need this change?
Line 1390: # BZ 1196735: api backward compatibility issue
Line 1391: # REQUIRED_FOR: engine-3.5.0 only
Line 1392: vmlist = [v['vmId'] for v in vmlist]
Line 1393: return {'status': doneCode, 'vmList': vmlist}
--
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Piotr Kliczewski has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/3/vdsm/API.py
File vdsm/API.py:
Line 1388: if not vmSet or v.id in vmSet]
Line 1389: if not fullStatus and onlyUUID:
Line 1390: # BZ 1196735: api backward compatibility issue
Line 1391: # REQUIRED_FOR: engine-3.5.0 only
Line 1392: # REQUIRED_FOR: mom-0.4.3
why do we need this line? We should drop this functionality when engine-3.5
I think that if we update the spec and mom we do not need this patch at all.
Line 1393: vmlist = [v['vmId'] for v in vmlist]
Line 1394: return {'status': doneCode, 'vmList': vmlist}
Line 1395:
Line 1396: def getExternalVMs(self, uri, username, password):
--
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Piotr Kliczewski has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 3: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/38679/3/vdsm/API.py File vdsm/API.py: Line 1378: Line 1379: return dict(status=doneCode) Line 1380: Line 1381: # VM-related functions Line 1382: def getVMList(self, fullStatus=False, vmList=(), onlyUUID=False): Defaulting onlyUUID to False is bad idea for engines 3.5.0 which are not able to tell you what you want. This is way I decided to set it to True by default and modified all the places where we can make a choice. Line 1383: return a list of known VMs with full (or partial) config each Line 1384: # To improve complexity, convert 'vms' to set(vms) Line 1385: vmSet = set(vmList) Line 1386: vmlist = [v.status(fullStatus) https://gerrit.ovirt.org/#/c/38679/3/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 352: The VM object has no getInfo method. We use the method from 'Global' and Line 353: pass arguments to get verbose information for only this one VM. Line 354: Line 355: vmId = api._UUID Line 356: return API.Global().getVMList(True, [vmId], False) strictly speaking, we don't *need* this change. Defaults should lead to cor After adding check for fullStatus we indeed do not need this change. Line 357: Line 358: Line 359: def VM_getInfo_Ret(ret): Line 360: -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
automat...@ovirt.org has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 4: * Update tracker::#1196735::OK * Check Bug-Url::OK * Check Public Bug::#1196735::OK, public bug * Check Product::#1196735::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
automat...@ovirt.org has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 3: * Update tracker::#1196735::OK * Check Bug-Url::OK * Check Public Bug::#1196735::OK, public bug * Check Product::#1196735::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
automat...@ovirt.org has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 2: * Update tracker::#1196735::OK * Check Bug-Url::OK * Check Public Bug::#1196735::OK, public bug * Check Product::#1196735::OK, Correct product Red Hat Enterprise Virtualization Manager * Check TR::SKIP, not in a monitored branch (ovirt-3.5 ovirt-3.4 ovirt-3.3 ovirt-3.2) * Check merged to previous::IGNORE, Not in stable branch (['ovirt-3.5', 'ovirt-3.4', 'ovirt-3.3']) -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38679/3/vdsm/API.py File vdsm/API.py: Line 1378: Line 1379: return dict(status=doneCode) Line 1380: Line 1381: # VM-related functions Line 1382: def getVMList(self, fullStatus=False, vmList=(), onlyUUID=False): That I was afraid of. That was what I was afraid of.* Line 1383: return a list of known VMs with full (or partial) config each Line 1384: # To improve complexity, convert 'vms' to set(vms) Line 1385: vmSet = set(vmList) Line 1386: vmlist = [v.status(fullStatus) -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38679/2/vdsm/API.py File vdsm/API.py: Line 1378: Line 1379: return dict(status=doneCode) Line 1380: Line 1381: # VM-related functions Line 1382: def getVMList(self, fullStatus=False, vmList=(), onlyUUID=True): we learned the hard and painful way how VDSM proper uses this API, and where and how it could break. Now let's see how MOM uses it. mom $ git grep getVMList mom/HypervisorInterfaces/vdsmInterface.py:56:response = self.vdsm_api.getVMList(True, [uuid]) mom/HypervisorInterfaces/vdsmInterface.py:65:response = self.vdsm_api.getVMList(True, [uuid]) mom/HypervisorInterfaces/vdsmInterface.py:75:response = self.vdsm_api.getVMList() so, we have one call with all the default values. And so we must make sure the default values are correct also for MOM case. Which means we'll most likely need to switch the default value for 'onlyUUID'. Line 1383: return a list of known VMs with full (or partial) config each Line 1384: # To improve complexity, convert 'vms' to set(vms) Line 1385: vmSet = set(vmList) Line 1386: vmlist = [v.status(fullStatus) -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 2: Code-Review-1 preliminary verification failed. MOM also calls getVMList() without arguments. The current defaults are: fullStatus=False, vmList=(), onlyUUID=True so MOM will get the 3.5.0 short status, which is no good. We need to - switch the default for onlyUUID - make sure that at Binding level (XMLRPC, JSONRPC) code passes always the right combination of parameters to keep Engine happy (and not break _again_ something else). -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Dan Kenigsberg has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 3:
(3 comments)
https://gerrit.ovirt.org/#/c/38679/3//COMMIT_MSG
Commit Message:
Line 33: wit
which
https://gerrit.ovirt.org/#/c/38679/3/vdsm/API.py
File vdsm/API.py:
Line 1388: if not vmSet or v.id in vmSet]
Line 1389: if not fullStatus and onlyUUID:
Line 1390: # BZ 1196735: api backward compatibility issue
Line 1391: # REQUIRED_FOR: engine-3.5.0 only
Line 1392: # REQUIRED_FOR: mom-0.4.3
why do we need this line? We should drop this functionality when engine-3.5.0
is gone, but no change is expected in mom.
We should just require (in spec) a mom version that passes onlyUUID=False
Line 1393: vmlist = [v['vmId'] for v in vmlist]
Line 1394: return {'status': doneCode, 'vmList': vmlist}
Line 1395:
Line 1396: def getExternalVMs(self, uri, username, password):
https://gerrit.ovirt.org/#/c/38679/3/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:
Line 352: The VM object has no getInfo method. We use the method from
'Global' and
Line 353: pass arguments to get verbose information for only this one VM.
Line 354:
Line 355: vmId = api._UUID
Line 356: return API.Global().getVMList(True, [vmId], False)
strictly speaking, we don't *need* this change. Defaults should lead to cor
I share your weariness. +1 for explicitness.
Line 357:
Line 358:
Line 359: def VM_getInfo_Ret(ret):
Line 360:
--
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38679/3/vdsm/rpc/Bridge.py File vdsm/rpc/Bridge.py: Line 352: The VM object has no getInfo method. We use the method from 'Global' and Line 353: pass arguments to get verbose information for only this one VM. Line 354: Line 355: vmId = api._UUID Line 356: return API.Global().getVMList(True, [vmId], False) strictly speaking, we don't *need* this change. Defaults should lead to correct behaviour. But given the story behind this bug, I'd rather have it. Reviewers please share your thoughts. Line 357: Line 358: Line 359: def VM_getInfo_Ret(ret): Line 360: -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 3: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16636/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16807/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/38679/3//COMMIT_MSG
Commit Message:
Line 33: wit
which
damn, missed in v4. Will fix.
https://gerrit.ovirt.org/#/c/38679/3/vdsm/API.py
File vdsm/API.py:
Line 1388: if not vmSet or v.id in vmSet]
Line 1389: if not fullStatus and onlyUUID:
Line 1390: # BZ 1196735: api backward compatibility issue
Line 1391: # REQUIRED_FOR: engine-3.5.0 only
Line 1392: # REQUIRED_FOR: mom-0.4.3
I think that if we update the spec and mom we do not need this patch at all
Agreed. Will keep up to date and address comments, but I'm prepared to abandon
it anytime.
Line 1393: vmlist = [v['vmId'] for v in vmlist]
Line 1394: return {'status': doneCode, 'vmList': vmlist}
Line 1395:
Line 1396: def getExternalVMs(self, uri, username, password):
--
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 3: (1 comment) https://gerrit.ovirt.org/#/c/38679/3/vdsm/API.py File vdsm/API.py: Line 1378: Line 1379: return dict(status=doneCode) Line 1380: Line 1381: # VM-related functions Line 1382: def getVMList(self, fullStatus=False, vmList=(), onlyUUID=False): Defaulting onlyUUID to False is bad idea for engines 3.5.0 which are not ab That I was afraid of. Then we are in a dead end because MOM wants to call getVMList() without arguments, to get the list of UUIDs. But it expects the fixed format (onlyUUID=False). Line 1383: return a list of known VMs with full (or partial) config each Line 1384: # To improve complexity, convert 'vms' to set(vms) Line 1385: vmSet = set(vmList) Line 1386: vmlist = [v.status(fullStatus) -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/4/vdsm/API.py
File vdsm/API.py:
Line 1385: vmSet = set(vmList)
Line 1386: vmlist = [v.status(fullStatus)
Line 1387: for v in self._cif.vmContainer.values()
Line 1388: if not vmSet or v.id in vmSet]
Line 1389: if not fullStatus and onlyUUID:
Once mom change is in do we really need this change?
Strictly speaking, I think we don't.
It makes things a little nicer and safer IMHO, but can wait for calmer times.
I'm just keeping it up to date, not pushing for it.
Line 1390: # BZ 1196735: api backward compatibility issue
Line 1391: # REQUIRED_FOR: engine-3.5.0 only
Line 1392: vmlist = [v['vmId'] for v in vmlist]
Line 1393: return {'status': doneCode, 'vmList': vmlist}
--
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Dan Kenigsberg has posted comments on this change.
Change subject: API: onlyUUID should affect only short status
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38679/4/vdsm/API.py
File vdsm/API.py:
Line 1385: vmSet = set(vmList)
Line 1386: vmlist = [v.status(fullStatus)
Line 1387: for v in self._cif.vmContainer.values()
Line 1388: if not vmSet or v.id in vmSet]
Line 1389: if not fullStatus and onlyUUID:
Strictly speaking, I think we don't.
onlyUUID was born with an intention to change only the fullStatus=False
behaviour. I did not intend it to override the ancient fullStatus=True.
Therefore, I prefer to include this change, and DOCUMENT it in the schema.
However, now that we know that this change does not solve the woes of mom, the
commit message should be changed.
Line 1390: # BZ 1196735: api backward compatibility issue
Line 1391: # REQUIRED_FOR: engine-3.5.0 only
Line 1392: vmlist = [v['vmId'] for v in vmlist]
Line 1393: return {'status': doneCode, 'vmList': vmlist}
--
To view, visit https://gerrit.ovirt.org/38679
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Barak Azulay bazu...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Martin Sivák msi...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 4: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16642/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16813/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Francesco Romani has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 2: version 2 improves the commit message and adds bug url, with no code changes. -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 1: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16631/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16802/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
oVirt Jenkins CI Server has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 2: Build Successful http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16632/ : SUCCESS http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/16803/ : SUCCESS -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
