[MediaWiki-CodeReview] [MediaWiki r113327]: New comment added
Nikerabbit posted a comment on MediaWiki.r113327. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113327#c31959 Commit summary for MediaWiki.r113327: follow up r113323 Nikerabbit's comment: The last two links are not https? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113327]: New comment added
Peachey88 posted a comment on MediaWiki.r113327. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113327#c31960 Commit summary for MediaWiki.r113327: follow up r113323 Peachey88's comment: They don't appear to support SSL on their site. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113347]: New comment added
Nikerabbit posted a comment on MediaWiki.r113347. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113347#c31961 Commit summary for MediaWiki.r113347: [ToolserverI18N] clean up - protocol relative urls where possible - whitespace clean up Nikerabbit's comment: Most editors don't pick up protocol-less links from plain text, and if they do they default to http anyway, so I don't really see the point. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113327]: Revision status changed
Nikerabbit changed the status of MediaWiki.r113327 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113327 Old status: deferred New status: ok Commit summary for MediaWiki.r113327: follow up r113323 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111724]: New comment added, and revision status changed
Santhosh.thottingal changed the status of MediaWiki.r111724 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111724#c31962 Old Status: fixme New Status: new Commit summary for MediaWiki.r111724: Qunit Testcases for mediawiki.language. For now, just one test for convertGrammar. More tests coming. Santhosh.thottingal's comment: Yes, That is required for all other language tests too. We will require loading each lang.js one after another, do testing for that language. But language.js loading being done based on contentlanguage by ResourceLoader, how can we achieve this? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113350]: Revision status changed
Krinkle changed the status of MediaWiki.r113350 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113350 Old status: new New status: ok Commit summary for MediaWiki.r113350: Add the test to qunit/index.html White space fixes, just use local grammartest instead of mw.language.grammartest. Ping r111724 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111724]: New comment added
Krinkle posted a comment on MediaWiki.r111724. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111724#c31963 Commit summary for MediaWiki.r111724: Qunit Testcases for mediawiki.language. For now, just one test for convertGrammar. More tests coming. Krinkle's comment: Good question :) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113339]: Revision status changed
MaxSem changed the status of MediaWiki.r113339 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113339 Old status: new New status: ok Commit summary for MediaWiki.r113339: (bug 34929) Show the correct diff when a section edit is rejected by the spam filter. Use EditPage::showDiff() so that the same kind of diff is shown as when you click the show changes button. I considered changing the source text to be the original section text, but if you do that, the line numbers are wrong and section=new doesn't show you the headline which may have matched the spam filter. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111724]: New comment added
Krinkle posted a comment on MediaWiki.r111724.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111724#c31964
Commit summary for MediaWiki.r111724:
Qunit Testcases for mediawiki.language. For now, just one test for
convertGrammar. More tests coming.
Krinkle's comment:
Maybe {{REVISIONUSER}} knowns.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113292]: Revision status changed
MaxSem changed the status of MediaWiki.r113292 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113292 Old status: new New status: ok Commit summary for MediaWiki.r113292: Follow-up r113277: release-notes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Announcing a new extension - SideBarMenu,
The SideBarMenu simplifies creating multilevel menues. http://www.mediawiki.org/wiki/Extension:SideBarMenu This is my first development project including mediawiki and has been by request of a large oil company in Norway; Statoil. Any feedback of any kind, is appreciated. -Kim ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113347]: New comment added
Krinkle posted a comment on MediaWiki.r113347. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113347#c31965 Commit summary for MediaWiki.r113347: [ToolserverI18N] clean up - protocol relative urls where possible - whitespace clean up Krinkle's comment: The important urls fixed in this commit aren't plain text. They are * images from upload.wikimedia.org * links to the Toolserver Intuition dashboard (when using [https://toolserver.org/~platonides/catdown/catdown.php a tool over https], the Set langauge link used to be hardcoded to http, that's fixed now) * the returnTo query passed by tools was hardcoded to http as well. the comment fixes are just normalization of the headers I use in my tools, not specific to TsInt ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113349]: New comment added, and revision status changed
Krinkle changed the status of MediaWiki.r113349 to fixme and commented it.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113349#c31966
Old Status: new
New Status: fixme
Commit summary for MediaWiki.r113349:
* Minor whitespace fix in mediawiki.language.js
* Use mw.language.getData in all language js files instead of directling
accessing from mw.language.data based on the fixes in r112991
Krinkle's comment:
pre
- var grammarForms = mw.language.data[ 'hu' ].get( 'grammarForms' );
+ var grammarForms =mw.language.getData( 'hu', 'grammarForms' );
- var grammarForms = mw.language.data[ 'ru' ].get( 'grammarForms' );
+ var grammarForms = mw.language.getData( 'ru', 'grammarForms' );
/pre
minor whitespace and indention nag.
pre
Index: branches/jsgrammar/resources/mediawiki.language/languages/bs.js
— — @@ -20,8 +20,9 @@
mediaWiki.language.convertGrammar = function( word, form ) {
- var grammarForms = mw.language.data[ 'bs' ].get( 'grammarForms' );
+ var grammarForms = mw.language.getData( 'bs', 'grammarForms' );
if ( grammarForms grammarForms[form] ) {
+ if ( grammarForms grammarForms[form] ) {
return grammarForms[form][word] ;
}
switch ( form ) {
/pre
Duplicated if-statement, throwing exception codeSyntaxError: Unexpected end
of input/code (marking fixme).
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113349]: Revision status changed
Santhosh.thottingal changed the status of MediaWiki.r113349 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113349 Old status: fixme New status: new Commit summary for MediaWiki.r113349: * Minor whitespace fix in mediawiki.language.js * Use mw.language.getData in all language js files instead of directling accessing from mw.language.data based on the fixes in r112991 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113347]: Revision status changed
MaxSem changed the status of MediaWiki.r113347 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113347 Old status: new New status: ok Commit summary for MediaWiki.r113347: [ToolserverI18N] clean up - protocol relative urls where possible - whitespace clean up ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] PDF Download
Hi all. I just wanted to confirm that Santosh's description of the current limitations of the PDF rendering engine are accurate. Regarding the GSOC project: As the principal developer of the current PDF rendering I'd also be happy to share insights on PDF rendering. Let me know if I can do anything to help. Best Regards, Volker Am 04.03.2012 07:30, schrieb Sumana Harihareswara: On 03/03/2012 10:25 PM, Santhosh Thottingal wrote: Here i have a question that at this moment is there any developer of developer group is working on this issue? if yes then i want to join with him. I had discussed this with Pediapress developers in the past. I started a project many months back to develop a general purpose PDF rendering library for complex scripts and I had announced it here: http://lists.wikimedia.org/pipermail/wikimediaindia-l/2011-February/002198.html And I have an online version based on the code in development http://silpa.org.in/Render. It can create PDFs from Bengali wiki pages and possibly most of the scripts that we support. The text rendering engine used is Pango. This is my petproject and 2-3 people joined me, but recently it is inactive in development since we are not getting free time. The library require lot of work to reach a reasonably usable state. Then it require good amount of effort to integrate with collection extension. The project is hosted at https://savannah.nongnu.org/projects/pypdflib and available in Debian. Thanks Santhosh Santhosh, it looks like Nasir might be interested in working on this as a Google Summer of Code project: ... Is [it] possible to apply GSoC for this issue. If this is the case, Santhosh, would you be interested in possibly mentoring Nasir? -- Volker Haas Senior Developer brainbot technologies ag Boppstraße 64 55118 Mainz Phone: +49 (0)6131 2116394 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113354]: Revision status changed
Krinkle changed the status of MediaWiki.r113354 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113354 Old status: new New status: ok Commit summary for MediaWiki.r113354: Remove duplicated line added in r113349 by mistake. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113355]: Revision status changed
Krinkle changed the status of MediaWiki.r113355 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113355 Old status: new New status: ok Commit summary for MediaWiki.r113355: Whitespace fixes. Ping r113349 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113349]: Revision status changed
Krinkle changed the status of MediaWiki.r113349 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113349 Old status: new New status: resolved Commit summary for MediaWiki.r113349: * Minor whitespace fix in mediawiki.language.js * Use mw.language.getData in all language js files instead of directling accessing from mw.language.data based on the fixes in r112991 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113357]: Revision status changed
Krinkle changed the status of MediaWiki.r113357 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113357 Old status: new New status: ok Commit summary for MediaWiki.r113357: r113303: Register extension for translatewiki.net. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113359]: New comment added
Peachey88 posted a comment on MediaWiki.r113359. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113359#c31967 Commit summary for MediaWiki.r113359: Added to blogs on en planet and updated one in fr per requests on meta Peachey88's comment: I thought ^demon had already moved planets over to Git? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113359]: New comment added
IAlex posted a comment on MediaWiki.r113359. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113359#c31968 Commit summary for MediaWiki.r113359: Added to blogs on en planet and updated one in fr per requests on meta IAlex's comment: At least on meta it's still stated that they are in SVN: [[meta:Planet Wikimedia#Requests for inclusion]]. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113362]: Revision status changed
Reedy changed the status of MediaWiki.r113362 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113362 Old status: new New status: ok Commit summary for MediaWiki.r113362: svn:eol-style native ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113362]: New comment added
Reedy posted a comment on MediaWiki.r113362. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113362#c31969 Commit summary for MediaWiki.r113362: svn:eol-style native Reedy's comment: I'm getting... pre U /home/reedy/mediawiki/trunk/extensions/SideBarMenu/test/MenuParserTest.php U /home/reedy/mediawiki/trunk/extensions/SideBarMenu/test/MenuItemTest.php U /home/reedy/mediawiki/trunk/extensions/SideBarMenu/LICENSE UU /home/reedy/mediawiki/trunk/extensions/SideBarMenu/SideBarMenu.i18n.php UU /home/reedy/mediawiki/trunk/extensions/SideBarMenu/SideBarMenu.php U /home/reedy/mediawiki/trunk/extensions/SideBarMenu/.gitignore U /home/reedy/mediawiki/trunk/extensions/SideBarMenu/SideBarMenu.hooks.php U /home/reedy/mediawiki/trunk/extensions/SideBarMenu/includes/MenuParser.php U /home/reedy/mediawiki/trunk/extensions/SideBarMenu/includes/MenuItem.php svn: Unrecognised line ending style reedy@ubuntu64-web-esxi:~$ svn up ~/mediawiki/ --ignore-externals svn: Unrecognised line ending style /pre Fine on windows though.. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113362]: New comment added
Reedy posted a comment on MediaWiki.r113362. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113362#c31970 Commit summary for MediaWiki.r113362: svn:eol-style native Reedy's comment: Meh, must just be SVN being stupid. Removing the extension and then svn updating again fixed it ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Git, Gerrit and the coming migration
On 2012-03-07, at 6:01 AM, Chad wrote: My main worry is that we are not spending enough time on getting all engineers (both internal and in the community) up to speed with the coming migration to Git and Gerrit and that we are going to blame the tools (Gerrit and/or Git) instead of the complex interaction between three changes. We are making three fundamental changes in one-shot: 1) Migrating from a centralized source control system to a decentralized system (SVN - Git) 2) Introducing a new dedicated code-review tool (Gerrit) 3) Introducing a gated-trunk model These are big changes. They're drastic changes. They require a rethinking of a great many things that we do from both technical and non-technical perspectives. Unfortunately, I don't see how we could've done #1 without #2. CodeReview is not designed (and was never designed) to work with a DVCS. The workflow's just not there, and it would've basically required rewriting huge parts of it. Rather than reinvent the wheel (again), we went with Gerrit. Arguably, we could've gone a straight push and skipped item #3. But given the continual code review backlog, and the desire to keep trunk stable (and hopefully deploy much more often), the decision to gate trunk was made pretty early on in the discussions. I understand that we want to do all 3 of those changes, my point was merely to make it very in explicit what we are changing and that the biggest change, IMHO, is the introduction of 3). It seems that most of the discussion is focusing on the tools (that's also how this thread started) while I think the discussion should focus on mastering the new workflow and what we can do to make sure that we have the right tutorials training available to make this migration as gentle as possible. I am confident that we will master the new tools, but a new workflow requires new habits and that might take more time to develop. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Git, Gerrit and the coming migration
Le 06/03/12 20:20, Diederik van Liere a écrit : My main worry is that we are not spending enough time on getting all engineers (both internal and in the community) up to speed with the coming migration to Git and Gerrit There are plenty of guides around that should cover most beginner question. I will be happy to answer questions in #mediawiki. -- git magic: An introduction to git, available in several languages. http://www-cs-students.stanford.edu/~blynn/gitmagic/ Follow Scott Chacon git evangelist: -- Pro git Everyone should read that free book. It comes with visual explanations which make the theory very easy to understand. If you had only one chapter to read, read the Git Branching one. http://progit.org/book/ I had the opportunity to read his Git Internals book. At $12 it is well worth it: http://peepcode.com/products/git-internals-pdf -- GitHub: Create a public repository there and play with it. It is a great exercise to have fun with a remote. Try forking a project such as the Wikipedia mobile application. Github has a lot of actually helpfull and well written help. http://help.github.com/ -- CHEAT CODES!!! Search for git cheat sheets. Print several of them and stick them near your screen. Use them as a references. Finally, the day of someone doing integration, still by Scott Chacon: http://schacon.github.com/git/everyday.html#Integrator -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Git, Gerrit and the coming migration
Diederik van Liere wrote: We are making three fundamental changes in one-shot: They are not that much of change. It is like if you changed from using a paper map and an old car to a nice SUV with a GPS. It is still a lot of metal on 4 wheels with one purpose: move some fresh meat from A to B. The model is the same. Only the tool changes. (you can quote me on this when we finally take the decision to migrate to JavaScript or Python) 1) Migrating from a centralized source control system to a decentralized system (SVN - Git) Decentralization itself is just a buzz word for the twitter guys. In the end, it does not change that much since most people have a reference repository. I guess most developers will use the WMF repository as a reference, or at the very least, all patches will eventually end up in the WMF repository. We could imagine having the WMF feature team to use their own repository then submit a nice giant patch once in a while. 2) Introducing a new dedicated code-review tool (Gerrit) That one is a habit change. It is a bit disturbing for the first week, just like any new web interface. We will eventually get used to it. I am sure people will easily adapt to the GUI and we will be there to assist. 3) Introducing a gated-trunk model We have been using a gated-trunk model for as long as I can remember. Here how it goes with subversion/CodeReview: ===[ SVN PROCESS ] - someone submit its patch proposal in subversion trunk - patch is reviewed then either it: - gets rejected : revision is reverted and marked as such - is accepted : revision marked 'ok' - it needs enhancement : marked 'fixme' repeat :-) From time to time, all patches marked 'ok' are allowed to pass the gate and land in a wmf branch. Then we deploy them. == We will use the exact same model with git/gerrit: ===[ GIT PROCESS ] - someone submit their patch proposal in Gerrit - patch is reviewed then either it: - gets rejected: marked abandoned in Gerrit - is accepted : patch is merged in WMF reference repository by Gerrit - it needs enhancement : comment asking submitter to enhance it. From time to time, all patches merged in the master branch are allowed to pass the gate and land in a wmf branch. Then we deploy them. As a summary: commit to trunk -- submit to Gerrit revision marked 'ok' -- change merged trunk to WMF branch -- master into WMF Note: it works the same with Bugzilla, people send their patches as attachments to a bug report. It reviewed there and eventually patch is applied by a gate keeper. -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Git, Gerrit and the coming migration
Le 08/03/12 14:52, Antoine Musso a écrit : There are plenty of guides around that should cover most beginner question. And I forgot git ready which as lot of tip from beginner to pro :-] http://gitready.com/ ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] MathJax scalable math rendering update for 1.19
Le 07/03/12 22:05, Brion Vibber a écrit : Here's a sample page on a test wiki, copied from en.wikipedia: http://leuksman.com/mw/index.php/Alpha_compositing It even works in lynx by showing the latex source code. I just hope that Jidanni knows LaTeX :-] I specially like the zoom when you one click on a math expression. Makes it really easier to read. Well done Brion! -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Announcing a new extension - SideBarMenu,
2012/3/8 Kim Eik k...@heldig.org The SideBarMenu simplifies creating multilevel menues. http://www.mediawiki.org/wiki/Extension:SideBarMenu This is my first development project including mediawiki and has been by request of a large oil company in Norway; Statoil. Any feedback of any kind, is appreciated. Very good! Thanks! Wikisource needs lots of gadgets/tools, youe extension could be inspiring and very useful when there's any need to add lots of tools-links into SideBarMenu. We found to that sidebar menu is much more comfortable if it is fixed so that it doesn't scroll any more when scrolling long texts in edit mode. Alex brollo ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Git, Gerrit and the coming migration
On 03/08/2012 05:45 AM, Diederik van Liere wrote: I understand that we want to do all 3 of those changes, my point was merely to make it very in explicit what we are changing and that the biggest change, IMHO, is the introduction of 3). It seems that most of the discussion is focusing on the tools (that's also how this thread started) while I think the discussion should focus on mastering the new workflow and what we can do to make sure that we have the right tutorials training available to make this migration as gentle as possible. I am confident that we will master the new tools, but a new workflow requires new habits and that might take more time to develop. I agree 100%. Antoine, you mentioned that you're happy to answer questions in #mediawiki, and you pointed to some learning resources. That's a good start. Who is willing to compose and teach a few interactive tutorials, between now and March 21st, on how to use the new tools (including the points Diederik brought up about more advanced git topics like squash, bisect, cherry-pick, and rebase)? Antoine, are you volunteering? Chad wrote, of the arrows to next/previous diff: I'd figured that out a little while ago. I guess it seemed a little more obvious to me. Perhaps we should start a How do I...? or FAQ page for Gerrit, so we can start collecting these common questions in a single place. Who is willing to do this? https://www.mediawiki.org/wiki/Git would be a reasonable home for it. If we don't do things like this, then the migration will be more painful and frustrating for lots of developers. Let's set ourselves up for success. -- Sumana Harihareswara Volunteer Development Coordinator Wikimedia Foundation ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [Wikimedia r1375]: New comment added, and revision status changed
Jpostlethwaite changed the status of Wikimedia.r1375 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1375#c31971 Old Status: ok New Status: fixme Commit summary for Wikimedia.r1375: Converting most queries to follow drupal convention and use token substitution. I left questionable query construction in _civicrm_recurring_globalcollect_update_record() untouched. Jpostlethwaite's comment: This line is broken: pre $failure_retry_date = failure_retry_date( $date ); /pre I will look into fixing it. That method does not exist. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1349]: New comment added, and revision status changed
Jpostlethwaite changed the status of Wikimedia.r1349 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1349#c31972 Old Status: resolved New Status: fixme Commit summary for Wikimedia.r1349: Added ability to send emails and log contributions. See r1212. Jpostlethwaite's comment: Emails are not being sent. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1375]: New comment added, and revision status changed
Jpostlethwaite changed the status of Wikimedia.r1375 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1375#c31973 Old Status: fixme New Status: new Commit summary for Wikimedia.r1375: Converting most queries to follow drupal convention and use token substitution. I left questionable query construction in _civicrm_recurring_globalcollect_update_record() untouched. Jpostlethwaite's comment: This is fixed in r1446. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113369]: Revision status changed
SPQRobin changed the status of MediaWiki.r113369 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113369 Old status: new New status: ok Commit summary for MediaWiki.r113369: Fix all trailing whitespace ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113370]: New comment added, and revision status changed
Amire80 changed the status of MediaWiki.r113370 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113370#c31974 Old Status: new New Status: fixme Commit summary for MediaWiki.r113370: bug 34090 - make different titles for masking appear if it's been hidden or oversighted. Add links to the user pages for the red lines on the overlays, fix a bug where the item wasn't being added in the right spot, moved the make a user link to the utils class since it was being used in several places Amire80's comment: Please document the i18n messages under the qqq language. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1349]: New comment added
Jpostlethwaite posted a comment on Wikimedia.r1349. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1349#c31975 Commit summary for Wikimedia.r1349: Added ability to send emails and log contributions. See r1212. Jpostlethwaite's comment: The hook does not exist. Called from: Line 488 pre module_invoke_all( 'civicrm_recurring_globalcollect', $contribution ); Array ( [0] = civicrm_recurring_globalcollect [1] = Array ( [is_error] = 0 [version] = 3 [count] = 1 [id] = 467 [values] = Array ( [467] = Array ( [id] = 467 [contact_id] = 2 [contribution_type_id] = 5 [contribution_page_id] = [payment_instrument_id] = 1 [receive_date] = 20120308085353 [non_deductible_amount] = [total_amount] = 10.00 [fee_amount] = [net_amount] = [trxn_id] = RECURRING GLOBALCOLLECT GLOBALCOLLECT RECURRING - 123 - 3 [invoice_id] = [currency] = USD [cancel_date] = [cancel_reason] = [receipt_date] = [thankyou_date] = [source] = [amount_level] = [contribution_recur_id] = 1 [honor_contact_id] = [is_test] = [is_pay_later] = [contribution_status_id] = [honor_type_id] = [address_id] = [check_number] = null [campaign_id] = ) ) ) ) /pre From: module_invoke_all() pre args: [1] module: [thank_you] --- hook: [civicrm_recurring_globalcollect] --- function: [thank_you_civicrm_recurring_globalcollect] /pre ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [pywikipedia r9971]: New comment added
Valhallasw posted a comment on pywikipedia.r9971. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9971#c31976 Commit summary for pywikipedia.r9971: Starting the survey for old Python versions. See http://thread.gmane.org/gmane.comp.python.pywikipediabot.general/12473 Valhallasw's comment: Why not just add suppresssurvey = False in config.py? (Or even suppressurvey = (sys.version = 2.7.2)) Which simplifies the code in wikipedia.py to if sys.version '2.7.2' and not config.suppresssurvey: (or if not config.suppresssurvey) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] GUI for Git
Hi all, in prepartion for the big bang I am reading pages like https://www.mediawiki.org/wiki/Git/Workflow but I miss a recommondation for a good Git GUI, especially for Win 7. Has anyone tested TortoiseGit? Is it a good choice for developers who use TortoiseSVN since years? Does it support git-review too? Thanks for your help. Raimond. signature.asc Description: OpenPGP digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r112115]: New comment added
^demon posted a comment on MediaWiki.r112115. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112115#c31977 Commit summary for MediaWiki.r112115: bug 34090 - no code changes, just fixing/adding keyword svn properties ^demon's comment: Other than using these in the API versions, I highly highly discourage them. They tend to create needless merge conflicts and don't work at all in git. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113367]: New comment added
^demon posted a comment on MediaWiki.r113367. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113367#c31978 Commit summary for MediaWiki.r113367: Bug 27246 - Downloading trunk version of ExtensionDistributor gives error Only attempt to include ExtensionFunctions.php if it exists in this extension source tree AND it's used! ^demon's comment: It makes me sad that we're still dealing with this vestigial file :( ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] GUI for Git
I've been testing some GUIs for Mac. So far the git-review support is usually what eliminates an app from consideration. No luck yet... -Greg Sent from my iPhone. Apologies for any typos. A more detailed response may be sent later. On Mar 8, 2012, at 12:09 PM, Raimond Spekking raimond.spekk...@gmail.com wrote: Hi all, in prepartion for the big bang I am reading pages like https://www.mediawiki.org/wiki/Git/Workflow but I miss a recommondation for a good Git GUI, especially for Win 7. Has anyone tested TortoiseGit? Is it a good choice for developers who use TortoiseSVN since years? Does it support git-review too? Thanks for your help. Raimond. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] GUI for Git
Op 8 mrt. 2012 om 18:09 heeft Raimond Spekking raimond.spekk...@gmail.com het volgende geschreven: Hi all, in prepartion for the big bang I am reading pages like https://www.mediawiki.org/wiki/Git/Workflow but I miss a recommondation for a good Git GUI, especially for Win 7. Has anyone tested TortoiseGit? Is it a good choice for developers who use TortoiseSVN since years? I'm using TortoiseGIT for visual diffing and committing, as well as for looking into the commit logs. Works well enough for me. I push using command line (often a batch script). Does it support git-review too? That I have not looked into. I push using command line. -- Siebrand Mazeland M: +31 6 50 69 1239 Skype: siebrand ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113273]: Revision status changed
Catrope changed the status of MediaWiki.r113273 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113273 Old status: new New status: ok Commit summary for MediaWiki.r113273: bug 34090 - add javascript level hiding on request oversight IF autohidden is returned in the json response ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] GUI for Git
Am 08.03.2012 18:26, schrieb Siebrand Mazeland: Op 8 mrt. 2012 om 18:09 heeft Raimond Spekking raimond.spekk...@gmail.com het volgende geschreven: in prepartion for the big bang I am reading pages like https://www.mediawiki.org/wiki/Git/Workflow but I miss a recommondation for a good Git GUI, especially for Win 7. Has anyone tested TortoiseGit? Is it a good choice for developers who use TortoiseSVN since years? https://www.mediawiki.org/wiki/Git_Graphical_User_Interfaces signature.asc Description: OpenPGP digital signature ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113287]: New comment added, and revision status changed
Catrope changed the status of MediaWiki.r113287 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113287#c31979 Old Status: fixme New Status: ok Commit summary for MediaWiki.r113287: bug 34090 - usernames and formatted timestamps into red lines for hidden/oversighted both on page load and dynamic hide/oversight (uses the data-blah custom attribute trick with jquery) Catrope's comment: Marking todo for message documentation and lack of i18n for the fake username. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113311]: New comment added, and revision status changed
Catrope changed the status of MediaWiki.r113311 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113311#c31980 Old Status: new New Status: ok Commit summary for MediaWiki.r113311: bug 34090 - fixing the username bugs - apparently using the data- stuff with jquery makes .data() not work right, so went back to own custom attributes and pushing them into the javascript method when populating the name/timestamp Catrope's comment: Hmm, what broke here? data-foo is supposed to Just Work, I'd be interested to hear what kinds of issues you ran into. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113317]: Revision status changed
Catrope changed the status of MediaWiki.r113317 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113317 Old status: new New status: ok Commit summary for MediaWiki.r113317: bug 34090 - js and css voodoo to make the element with the red lines appear above the gray mask ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113370]: Revision status changed
Catrope changed the status of MediaWiki.r113370 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113370 Old status: fixme New status: resolved Commit summary for MediaWiki.r113370: bug 34090 - make different titles for masking appear if it's been hidden or oversighted. Add links to the user pages for the red lines on the overlays, fix a bug where the item wasn't being added in the right spot, moved the make a user link to the utils class since it was being used in several places ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113371]: Revision status changed
Catrope changed the status of MediaWiki.r113371 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113371 Old status: new New status: ok Commit summary for MediaWiki.r113371: bug 34090 - fixes for oversighter view for hide/oversight panels ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] GUI for Git
I have tried the TortoiseGIT but i did not like it that much. now i am using SmartGit for my other git projects because some of the features is very useful for me. Here is the download link http://www.syntevo.com/smartgit/index.html thanks nasir On Fri, Mar 9, 2012 at 12:14 AM, Thomas Gries m...@tgries.de wrote: Am 08.03.2012 18:26, schrieb Siebrand Mazeland: Op 8 mrt. 2012 om 18:09 heeft Raimond Spekking raimond.spekk...@gmail.com het volgende geschreven: in prepartion for the big bang I am reading pages like https://www.mediawiki.org/wiki/Git/Workflow but I miss a recommondation for a good Git GUI, especially for Win 7. Has anyone tested TortoiseGit? Is it a good choice for developers who use TortoiseSVN since years? https://www.mediawiki.org/wiki/Git_Graphical_User_Interfaces ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- *Nasir Khan Saikat http://profiles.google.com/nasir8891* ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113311]: New comment added
Elizabeth M Smith posted a comment on MediaWiki.r113311.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113311#c31981
Commit summary for MediaWiki.r113311:
bug 34090 - fixing the username bugs - apparently using the data- stuff with
jquery makes .data() not work right, so went back to own custom attributes and
pushing them into the javascript method when populating the name/timestamp
Elizabeth M Smith's comment:
data-foo works - kind of
If the attribute is present in the html it is properly added to data and I can
get it out and change it as expected (that was pretty cool)
however, when I then tried to add data('user-hide') to elements that did not
have it present at html load time, I could not
Not sure if this is spec or if it's a jquery bug (seriously think it's a
jquery bug)
If I added the attr with an empty value into the html at load time, it worked
fine... But there are four possible data attributes per feedback row so that
would mean putting 4 empty data-blah attributes on every row displayed so I
could change the users/timestamps as necessary - the overhead in that is insane
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113311]: New comment added
Catrope posted a comment on MediaWiki.r113311. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113311#c31982 Commit summary for MediaWiki.r113311: bug 34090 - fixing the username bugs - apparently using the data- stuff with jquery makes .data() not work right, so went back to own custom attributes and pushing them into the javascript method when populating the name/timestamp Catrope's comment: That's weird, setting yet-unheard-of data is supposed to work even in the presence of other data- attributes. Maybe it's a bug in the specific version of jQuery we're using or something. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] GUI for Git
On Thu, 08 Mar 2012 09:09:54 -0800, Raimond Spekking raimond.spekk...@gmail.com wrote: Hi all, in prepartion for the big bang I am reading pages like https://www.mediawiki.org/wiki/Git/Workflow but I miss a recommondation for a good Git GUI, especially for Win 7. Has anyone tested TortoiseGit? Is it a good choice for developers who use TortoiseSVN since years? Does it support git-review too? Thanks for your help. Raimond. I've heard comments that TortoiseGit was sub-standard. It didn't even have support for the index. I put together this awhile ago: https://www.mediawiki.org/wiki/Git_Graphical_User_Interfaces For Windows I suggest trying to use Git Extensions. The UI seamed to be very fully featured. It also came bundled with an installer for git/mysgit, bash, and some putty pieces. So it even gives you access to a unix-like command line. For OS X, I haven't been using a GUI (besides `git gui`) so I can't say for sure what is the best. But Source Tree is looking a little more promising than GitX. Unfortunately for git-review, I don't think there is a single GUI that supports it. -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113311]: New comment added
Elizabeth M Smith posted a comment on MediaWiki.r113311. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113311#c31983 Commit summary for MediaWiki.r113311: bug 34090 - fixing the username bugs - apparently using the data- stuff with jquery makes .data() not work right, so went back to own custom attributes and pushing them into the javascript method when populating the name/timestamp Elizabeth M Smith's comment: I highly suspect it's a JQuery bug, but for now the workaround functions fine (That's weird seems to be the singular reaction to everyone I show that bug to ;) ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113287]: New comment added
Nikerabbit posted a comment on MediaWiki.r113287. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113287#c31984 Commit summary for MediaWiki.r113287: bug 34090 - usernames and formatted timestamps into red lines for hidden/oversighted both on page load and dynamic hide/oversight (uses the data-blah custom attribute trick with jquery) Nikerabbit's comment: /me protests. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r105380]: New comment added, and revision status changed
MaxSem changed the status of MediaWiki.r105380 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/105380#c31985 Old Status: ok New Status: fixme Commit summary for MediaWiki.r105380: * (bug 32617) Fix for edit summary on section 0 containing a bogus section heading Based on patch posted by Dan Collins: https://bugzilla.wikimedia.org/attachment.cgi?id=9552 with a tweak to avoid breaking a similar case in other sections. Follows up on function extraction test cases added in r105379. MaxSem's comment: Causes bug 35051. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113378]: Revision status changed
MaxSem changed the status of MediaWiki.r113378 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113378 Old status: new New status: ok Commit summary for MediaWiki.r113378: remove ROBOTS meta tag ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113374]: New comment added
MaxSem posted a comment on MediaWiki.r113374. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113374#c31986 Commit summary for MediaWiki.r113374: render zero rated landing page MaxSem's comment: Shouldn't it be somewhere like Special:ZeroRated instead? ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Announcing a new extension - SideBarMenu,
By fixed do you mean the css style position: fixed; ? On Thu, Mar 8, 2012 at 5:08 PM, Alex Brollo alex.bro...@gmail.com wrote: 2012/3/8 Kim Eik k...@heldig.org The SideBarMenu simplifies creating multilevel menues. http://www.mediawiki.org/wiki/Extension:SideBarMenu This is my first development project including mediawiki and has been by request of a large oil company in Norway; Statoil. Any feedback of any kind, is appreciated. Very good! Thanks! Wikisource needs lots of gadgets/tools, youe extension could be inspiring and very useful when there's any need to add lots of tools-links into SideBarMenu. We found to that sidebar menu is much more comfortable if it is fixed so that it doesn't scroll any more when scrolling long texts in edit mode. Alex brollo ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113374]: New comment added
Preilly posted a comment on MediaWiki.r113374. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113374#c31987 Commit summary for MediaWiki.r113374: render zero rated landing page Preilly's comment: This is now fixed in: r113379. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113363]: Revision status changed
Preilly changed the status of MediaWiki.r113363 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113363 Old status: new New status: ok Commit summary for MediaWiki.r113363: render search box correctly on blackberry 9300 it seems there is an issue with absolute positioning within padded elements on blackberry 9300 in that the logo jumps to the right underneath the search box this fixes this by putting the padding on the parent element ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Git, Gerrit and the coming migration
Le 08/03/12 17:35, Sumana Harihareswara a écrit : I'd figured that out a little while ago. I guess it seemed a little more obvious to me. Perhaps we should start a How do I...? or FAQ page for Gerrit, so we can start collecting these common questions in a single place. Who is willing to do this? https://www.mediawiki.org/wiki/Git would be a reasonable home for it. I have already added one question in [[Gerrit]] about rebasing change. https://www.mediawiki.org/wiki/Gerrit Probably a lot more to add there :-] -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r99942]: New comment added, and revision status changed
MaxSem changed the status of MediaWiki.r99942 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99942#c31988 Old Status: ok New Status: fixme Commit summary for MediaWiki.r99942: * Do magic word parsing after parameter replacement in MediaWiki:Enotif_body and MediaWiki:Enotif_subject * Fix link to Special:EmailUser in case $wgEnotifUseRealName was true and the user defined a real name, link was pointing to Special:EmailUser/Real_Name instead of Special:EmailUser/User_Name * Simplified the code of EmailNotification::composeCommonMailtext() MaxSem's comment: Looks like it causes bug 35019: Edit summary shouldn't be parsed as wikitext into html in e-mail notifications ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113374]: Revision status changed
MaxSem changed the status of MediaWiki.r113374 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113374 Old status: new New status: resolved Commit summary for MediaWiki.r113374: render zero rated landing page ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113379]: Revision status changed
MaxSem changed the status of MediaWiki.r113379 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113379 Old status: new New status: ok Commit summary for MediaWiki.r113379: render zero rated landing page ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r112479]: New comment added
SPQRobin posted a comment on MediaWiki.r112479.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/112479#c31989
Commit summary for MediaWiki.r112479:
Combine getLanguageNames and getTranslatedLanguageNames into one function which
is much easier and more logical to use. Does not contain any actual changes yet
in what the function does.
* Reduces the overly long code in r107002, and reduces code for {{#language:}}
* Fixes the language list in Special:Translate which contained languages that
gave invalid code when selecting
SPQRobin's comment:
Thought I added @since..
Done in r113385. Are there other indentation issues?
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r83786]: New comment added, and revision status changed
MaxSem changed the status of MediaWiki.r83786 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83786#c31990 Old Status: ok New Status: fixme Commit summary for MediaWiki.r83786: Divert a river through the Augean Stables that is SpecialBlockip.php. * Move to SpecialBlock.php, and rename class appropriately * Complete refactor * Use HTMLForm in block form. This changes most of the ids and field names on the form, but allows proper validation, nicer formatting, clears up several fixmes, and is generally Better(TM). * Spin various parts out into static functions, several of which properly belong in the backend (but Block.php is a worse mess still) * Invert some of the block options so that every checkbox makes the block more severe (so check to disable email is fine, but check to allow usertalk edit (default true) is inverted to check to disable usertalk edit (default false). * revert r40359 (move doMassUserBlock() to core). No one seems to be using this function, which has nothing to do with the frontend UI in SpecialBlock (it might perhaps belong in Block.php); it is pretty bespoke for CheckUser, doesn't seem to have very much utility elsewhere. MaxSem's comment: Causes bug 32827: Block log for IP ranges not shown on Special:Block. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r103751]: New comment added, and revision status changed
MaxSem changed the status of MediaWiki.r103751 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/103751#c31991 Old Status: ok New Status: fixme Commit summary for MediaWiki.r103751: In the spirit of r103745, guard against invalid user names in SpecialContributions and SpecialDeletedContributions by checking for invalidity early, then passing User objects around. Loosely based on Søren Løvborg's patch on bug 26854 MaxSem's comment: Fixmed per [[#c31764]]. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113359]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113359 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113359 Old status: new New status: ok Commit summary for MediaWiki.r113359: Added to blogs on en planet and updated one in fr per requests on meta ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] GUI for Git
I am just starting to use a git GUI on my Mac and don't have much experience with different clients, but there is a good overview/review on stackoverflow: http://stackoverflow.com/questions/455698/best-visual-client-for-git-on-mac-os-x Favorites seem to be - Tower (for most beautiful UI) http://www.git-tower.com/ - SourceTree (for supporting multiple repositories) http://www.sourcetreeapp.com/ Best, Christoph Am 08.03.2012 um 19:25 schrieb Daniel Friesen: On Thu, 08 Mar 2012 09:09:54 -0800, Raimond Spekking raimond.spekk...@gmail.com wrote: Hi all, in prepartion for the big bang I am reading pages like https://www.mediawiki.org/wiki/Git/Workflow but I miss a recommondation for a good Git GUI, especially for Win 7. Has anyone tested TortoiseGit? Is it a good choice for developers who use TortoiseSVN since years? Does it support git-review too? Thanks for your help. Raimond. I've heard comments that TortoiseGit was sub-standard. It didn't even have support for the index. I put together this awhile ago: https://www.mediawiki.org/wiki/Git_Graphical_User_Interfaces For Windows I suggest trying to use Git Extensions. The UI seamed to be very fully featured. It also came bundled with an installer for git/mysgit, bash, and some putty pieces. So it even gives you access to a unix-like command line. For OS X, I haven't been using a GUI (besides `git gui`) so I can't say for sure what is the best. But Source Tree is looking a little more promising than GitX. Unfortunately for git-review, I don't think there is a single GUI that supports it. -- ~Daniel Friesen (Dantman, Nadir-Seen-Fire) [http://daniel.friesen.name] ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l -- Christoph Kepper PediaPress GmbH Boppstraße 64 55118 Mainz Phone: +49 (0)6131 3271809 ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] GUI for Git
Unfortunately for git-review, I don't think there is a single GUI that supports it. There's actually no requirement for using git-review. It simply makes things easier. If you set up the remote, and make sure to include the commit-msg hook, you can use anything you want. I haven't started using git-review at all. I'm still using the aliases/remotes I originally made for the puppet repo. - Ryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Git, Gerrit and the coming migration
On 07/03/12 01:13, Chad wrote: Learning a new tool and new workflow is jarring, but I think it's a feeling that will pass slightly as time goes on. That's part of the reason we pushed the decision about Phabricator out by a few months-- it allows us to get some hands-on experience with Gerrit. By that point I hope we'll be moving past the initial Git learning curve, and I think it'll allow us to make a better decision about code review tools without being clouded by git-isms (some of which will remain regardless of the tool in question). Sadly you only get one first impression, and Gerrit doesn't do a good job at that :( I don't see the point of not starting with the best tool from the beginning. Migrations are painful, and with permanent consequences, so the less the better. We may err on deciding which one is best, or not know about a better alternative until after migrating, but refusing to consider them? Imagine you were going to learn horseback riding, and were given a lame horse. - Hey! You have given me an injured horse. - First learn to gallop with it, then we can consider if it's worth changing it. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] GUI for Git
On 08/03/12 20:50, Christoph Kepper wrote: I am just starting to use a git GUI on my Mac and don't have much experience with different clients, but there is a good overview/review on stackoverflow: http://stackoverflow.com/questions/455698/best-visual-client-for-git-on-mac-os-x Favorites seem to be - Tower (for most beautiful UI) http://www.git-tower.com/ - SourceTree (for supporting multiple repositories) http://www.sourcetreeapp.com/ Best, Christoph Don't fall just for fancy GUIs if you pretend to use it with phase3. Some of them have an horrible performance (= are unusable) with big repos. ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Git, Gerrit and the coming migration
On Thu, Mar 8, 2012 at 3:08 PM, Platonides platoni...@gmail.com wrote: On 07/03/12 01:13, Chad wrote: Learning a new tool and new workflow is jarring, but I think it's a feeling that will pass slightly as time goes on. That's part of the reason we pushed the decision about Phabricator out by a few months-- it allows us to get some hands-on experience with Gerrit. By that point I hope we'll be moving past the initial Git learning curve, and I think it'll allow us to make a better decision about code review tools without being clouded by git-isms (some of which will remain regardless of the tool in question). Sadly you only get one first impression, and Gerrit doesn't do a good job at that :( I don't see the point of not starting with the best tool from the beginning. Migrations are painful, and with permanent consequences, so the less the better. We may err on deciding which one is best, or not know about a better alternative until after migrating, but refusing to consider them? Imagine you were going to learn horseback riding, and were given a lame horse. - Hey! You have given me an injured horse. - First learn to gallop with it, then we can consider if it's worth changing it. I'd hardly call Gerrit a lame horse, more like a horse with funny spots on it and an extra tail. Also: what's this mythical best tool? I've not seen it suggested before. -Chad ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113390]: New comment added
Raymond posted a comment on MediaWiki.r113390. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113390#c31992 Commit summary for MediaWiki.r113390: bug 34090 - adding translation for automatic hider user Raymond's comment: 'articlefeedbackv5-default-user' = 'Article Feedback V5', I do not know this extension very well so maybe I misread something. If 'Article Feedback V5' is a username please consider addind to $wgReservedUsernames, see [[Manual:$wgReservedUsernames]]. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r81500]: New comment added
Helder.wiki posted a comment on MediaWiki.r81500.
URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81500#c31993
Commit summary for MediaWiki.r81500:
Making a start with $.jsMessage. A more flexible way for messages. Supports
grouping them and making the replacing of previous messages into option (the
current jsMsg() function always replaces older messages. Time has shown that
there is need for the ability to show older messages as well and grouping to
avoid different scripts from erasing or clearing eachother's output (current
Commons and a few other wikis have created similar functions to enable keeping
previous messages)
* See also bug 26888. Not resolving the bug yet, this plugins needs a little
more testing and should then be called from within mw.util.jsMessage with some
wiki specific things.
Examples:
// Show a simple message in the default group
$.jsMessage( {
message: 'Hello',
target: 'mw-js-message'
} );
// Add a new message this time stating the defaults
$.jsMessage( {
message: 'World',
group: 'default',
replace: false,
target: 'mw-js-message'
} );
// Post a new message, replacing the previous ones
$.jsMessage( {
message: 'New',
group: 'default',
replace: true,
target: 'mw-js-message'
} );
// Add a messages in a new group (groups separated by a line)
$.jsMessage( {
message: 'A new group',
group: 'something',
target: 'mw-js-message'
} );
// Clear the default group
// See code comments for more info
$.jsMessage( {
message: '',
replace: true,
target: 'mw-js-message'
} );
// Clear the 'something'-group
// Since this leaves no visible groups, the main box will hide (slideUp) right
after
$.jsMessage( {
message: '',
group: 'something',
replace: true,
target: 'mw-js-message'
} );
If testing goes well, mw.util.jsMsg(message, className, replace) will call
$.jsMessage( { message: message, group: className, replace: replace, target:
$.jsMessage(ge' );
So it's more a backend plugin, not used directly by core modules.
But this way extensions or third party sites can easily re-use this plugin
and/or create multiple message boxes
on one page, by calling $.jsMessageNew and giving an id and location for it on
the page.
Helder.wiki's comment:
I think the default parent shoudn't be the body, because it breaks the
appearence of the skin. Compare
jsMsg('Lorem ipsum...'); // ok =)
with
$.messageBox({
message:'Lorem ipsum...', // Blergh! =(
});
Maybe the default target should be the 'mw-js-message' (which is/was used by
the jsMsg from wikibits.js). E.g.: the result of
$.messageBox({
message:'Lorem ipsum...',
target: 'mw-js-message'
});
looks a lot better than without specifying the target.
___
MediaWiki-CodeReview mailing list
mediawiki-coderev...@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[Wikitech-l] Weird API behavior when getting img thumb url
Hey, I'm seeing some weird behavior and can't figure out what's going on. I have some code making a request to the API to obtain the thumb url of an image: http://dpaste.org/nuOfX/ This code is used here, and right now the first two images are full size and the third is a thumb: http://education.wmflabs.org/wiki/Special:CampusAmbassadors No idea why it's working for some and not for others. Stranger yet, I cannot reproduce this issue locally, running the same code. This is with trunk and with instant commons on. Cheers -- Jeroen De Dauw http://www.bn2vs.com Don't panic. Don't be evil. -- ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] GUI for Git
Le 08/03/12 20:54, Ryan Lane a écrit : I haven't started using git-review at all. I'm still using the aliases/remotes I originally made for the puppet repo. You are soo old school! :- -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Weird API behavior when getting img thumb url
On Thu, Mar 8, 2012 at 12:39 PM, Jeroen De Dauw jeroended...@gmail.com wrote:
Hey,
I'm seeing some weird behavior and can't figure out what's going on.
I have some code making a request to the API to obtain the thumb url of an
image: http://dpaste.org/nuOfX/
This code is used here, and right now the first two images are full size
and the third is a thumb:
http://education.wmflabs.org/wiki/Special:CampusAmbassadors
No idea why it's working for some and not for others. Stranger yet, I
cannot reproduce this issue locally, running the same code. This is with
trunk and with instant commons on.
I don't know why this happens, but you really don't need internal API
requests to get thumbnail URLs. This is much simpler:
$file = wfFindFile( 'Foobar.jpg' );
$thumb = $file-transform( array( 'width' = 200 ) );
if ( $mto !$mto-isError() ) { $url = $mto-getURL(); } else { /*
Handle error */ }
Roan
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] GUI for Git
Le 08/03/12 19:25, Daniel Friesen a écrit : For OS X, I haven't been using a GUI (besides `git gui`) so I can't say for sure what is the best. But Source Tree is looking a little more promising than GitX. GitX has been forked over and over. The original one is at https://github.com/pieter/gitx , if you look at the network https://github.com/pieter/gitx/network the laullon fork seems to be the most maintained one. Screenshots etc are at http://gitx.laullon.com/ -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Weird API behavior when getting img thumb url
On Thu, Mar 8, 2012 at 3:51 PM, Roan Kattouw roan.katt...@gmail.com wrote:
I don't know why this happens, but you really don't need internal API
requests to get thumbnail URLs. This is much simpler:
$file = wfFindFile( 'Foobar.jpg' );
$thumb = $file-transform( array( 'width' = 200 ) );
if ( $mto !$mto-isError() ) { $url = $mto-getURL(); } else { /*
Handle error */ }
s/$thumb/$mto/?
-Chad
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Git, Gerrit and the coming migration
I'd hardly call Gerrit a lame horse, more like a horse with funny spots on it and an extra tail. Also: what's this mythical best tool? I've not seen it suggested before. +1 There are alternative solutions, but none of them are viable without development work. Gerrit is viable right now, in its current state. Its downside is that its interface is slightly painful. Every tool we use is going to have something we dislike about it interface-wise. Let's work with the OpenStack team and improve it. - Ryan ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Weird API behavior when getting img thumb url
On Thu, Mar 8, 2012 at 12:58 PM, Chad innocentkil...@gmail.com wrote:
On Thu, Mar 8, 2012 at 3:51 PM, Roan Kattouw roan.katt...@gmail.com wrote:
I don't know why this happens, but you really don't need internal API
requests to get thumbnail URLs. This is much simpler:
$file = wfFindFile( 'Foobar.jpg' );
$thumb = $file-transform( array( 'width' = 200 ) );
if ( $mto !$mto-isError() ) { $url = $mto-getURL(); } else { /*
Handle error */ }
s/$thumb/$mto/?
Yeah, I changed my mind about the variable name halfway through. When
I say $mto I mean $thumb (or vice versa).
Roan
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
Re: [Wikitech-l] Weird API behavior when getting img thumb url
Hey,
$file = wfFindFile( 'Foobar.jpg' );
$thumb = $file-transform( array( 'width' = 200 ) );
if ( $mto !$mto-isError() ) { $url = $mto-getURL(); } else { /*
Handle error */ }
I tried your code, and now all my images are FOOBAR. It does not work!
More seriously though: I updated my code to use this indeed better way to
get the thumb ( http://dpaste.org/XIr5W/ ), but the problem appears to be
completely unaffected :/
Cheers
--
Jeroen De Dauw
http://www.bn2vs.com
Don't panic. Don't be evil.
--
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[Wikitech-l] git aliases
Hello, Some people have been asking me which aliases I have been using. I have dumped them on the new [[Git_aliases]]. The most useful is the lg alias I have found on stackoverflow, it will show an ASCII graph along oneline commits. See the page for complete alias and screenshots :-] [[Git_aliases]] https://www.mediawiki.org/wiki/Git/aliases -- Antoine hashar Musso ___ Wikitech-l mailing list Wikitech-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113098]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113098 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113098 Old status: new New status: ok Commit summary for MediaWiki.r113098: Lightened the background color of diff context lines as per Erwin Dokter's suggestion. Now using the standard Vector gray background color (#f3f3f3) which is as light as you can go without most monitors rendering it as white. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113398]: Revision status changed
Awjrichards changed the status of MediaWiki.r113398 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113398 Old status: new New status: deferred Commit summary for MediaWiki.r113398: Localisation updates for core and extension messages from translatewiki.net ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113103]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113103 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113103 Old status: new New status: ok Commit summary for MediaWiki.r113103: Normalise method returns, and returned value usage Documentation fixes ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113225]: New comment added
Nikerabbit posted a comment on MediaWiki.r113225. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113225#c31994 Commit summary for MediaWiki.r113225: Clear the associated metadata when a translatable page is deleted. Move the associated metadata when a translatable page is moved. Nikerabbit's comment: If somebody would happen to have 00 or similar as the reason, this would remove it. Not a big issue though. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113405]: New comment added, and revision status changed
Ryan lane changed the status of MediaWiki.r113405 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113405#c31995 Old Status: new New Status: fixme Commit summary for MediaWiki.r113405: I'm fed up of new labs users having problems on initial login because their key was in the wrong format. When the key doesn't look to be in the right format: a) Try to automatically convert it in the server. Much easier than explaining where to find the option in the menu. b) Reject it in other case, so at least they know upfront that, and don't have to discover it the hard way when trying to login after discarding the other possible reasons. Ryan lane's comment: This is a great change, but let's switch this to use openssh's ssh-keygen. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r99942]: New comment added, and revision status changed
IAlex changed the status of MediaWiki.r99942 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/99942#c31996 Old Status: fixme New Status: new Commit summary for MediaWiki.r99942: * Do magic word parsing after parameter replacement in MediaWiki:Enotif_body and MediaWiki:Enotif_subject * Fix link to Special:EmailUser in case $wgEnotifUseRealName was true and the user defined a real name, link was pointing to Special:EmailUser/Real_Name instead of Special:EmailUser/User_Name * Simplified the code of EmailNotification::composeCommonMailtext() IAlex's comment: Fixed in r113407. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113407]: Revision status changed
MaxSem changed the status of MediaWiki.r113407 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113407 Old status: new New status: ok Commit summary for MediaWiki.r113407: * (bug 35019) Fix for rr99942: edit summaries are no longer transformed in notification e-mails ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r111647]: New comment added
George Orwell III posted a comment on MediaWiki.r111647. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111647#c31997 Commit summary for MediaWiki.r111647: (Bug 31417) Content-holding div needs an ID. Since the introduction of the class mw-content-ltr/rtl, it has been used to get the page text which is very bad because there are two class names and it is not always on the same place (if at all). This ID will always hold the bodytext (excluding categories, ArticleFeedback, ...). George Orwell III's comment: A lot of people on en.wikisource were wondering how to use the ms-content-ltr container to replace an interim container scheme used for dynamic layouts of transcluded content once it went through the ProofReading process. This additional ID generated skin-wide would greatly help cut down on the amount of local .js currently needed (not to mention help stop abusing #contentSub where the interim container is being dynamically moved to). Any chance this revision slated for 1.20wmf with the new ID attribute generation could be hurried along? Patching the current wikisource deployed version sooner rather than later sure could go a long way in undoing our dynamic layout mess moving forward. TIA - GOIII ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113406]: Revision status changed
Catrope changed the status of MediaWiki.r113406 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113406 Old status: new New status: ok Commit summary for MediaWiki.r113406: MFT r112732 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
Re: [Wikitech-l] Weird API behavior when getting img thumb url
On Thu, Mar 8, 2012 at 1:24 PM, Jeroen De Dauw jeroended...@gmail.comwrote:
Hey,
$file = wfFindFile( 'Foobar.jpg' );
$thumb = $file-transform( array( 'width' = 200 ) );
if ( $mto !$mto-isError() ) { $url = $mto-getURL(); } else { /*
Handle error */ }
I tried your code, and now all my images are FOOBAR. It does not work!
;)
More seriously though: I updated my code to use this indeed better way to
get the thumb ( http://dpaste.org/XIr5W/ ), but the problem appears to be
completely unaffected :/
I'm not sure why the width parameter doesn't seem to be taking effect in
the transform but rather than creating your own img element you may
wish to use $thumb-toHtml() just for consistency.
Hmm... it looks like there's a bug in thumbnailing with InstantCommons here.
at http://education.wmflabs.org/wiki/File:Kitten%27s_paw.jpg the thumbnail
in the version dialog is also actually pulling in a full-size image.
Checking a direct api hit to Commons:
https://commons.wikimedia.org/w/api.php?action=querytitles=File:Kitten%27s_paw.jpgprop=imageinfoiiurlwidth=200iiprop=url
note there's a separate 'url' (the original size url) and 'thumburl'
(scaled url). Don't see an obvious reason for breakage though... seems ok
in my local trunk instances too.
-- brion
___
Wikitech-l mailing list
Wikitech-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
[MediaWiki-CodeReview] [MediaWiki r113412]: New comment added
Aaron Schulz posted a comment on MediaWiki.r113412. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113412#c31998 Commit summary for MediaWiki.r113412: [FileBackend] Made doOperations() Status handling align with documentation as well as what FileRepo is essentially expecting when using the 'force' option (it assumes fatals are for total batch failures, not just partial ones). The relevant documentation was also improved. Aaron Schulz's comment: Should fix bug 35054. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [Wikimedia r1447]: Revision status changed
Pgehres (WMF) changed the status of Wikimedia.r1447 to ok URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1447 Old status: new New status: ok Commit summary for Wikimedia.r1447: Try more than once to get a response from paypal... And I cannot believe we weren't doing this already. ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
[MediaWiki-CodeReview] [MediaWiki r113143]: Revision status changed
Aaron Schulz changed the status of MediaWiki.r113143 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/113143 Old status: new New status: ok Commit summary for MediaWiki.r113143: get rid of deperacted method usage ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-codereview
