Re: d3d11 patch
On Fri, Oct 11, 2013 at 7:20 PM, Max . asnl...@hotmail.com wrote: Hi, I would like to know when the first patchs for d3d11 will be introduce into wine ? Beginning of 2014 ? middle 2014 ? End 2014 ? Thanks, WIR
Re: xmllite: Use BOOL type where appropriate
On Thu, Oct 10, 2013 at 12:40 PM, Nikolay Sivov bungleh...@gmail.com wrote: On 10/10/2013 00:36, Frédéric Delanoy wrote: --- dlls/xmllite/reader.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/dlls/xmllite/reader.c b/dlls/xmllite/reader.c index 0a4423c..a216951 100644 --- a/dlls/xmllite/reader.c +++ b/dlls/xmllite/reader.c @@ -726,7 +726,7 @@ static void readerinput_grow(xmlreaderinput *readerinput, int length) } } -static inline int readerinput_is_utf8(xmlreaderinput *readerinput) +static inline BOOL readerinput_is_utf8(xmlreaderinput *readerinput) I don't actually see what this will achieve, but I see such patches are accepted. Is it a new style rule? Basically cleanup/clarity. Using boolean values when expressing logical expressions results does make sense (and it makes the intent clearer) IMHO. The fact that it translates to integer values is just a C implementation/design detail. Why using an integer type when one only needs one of two truth values like TRUE/FALSE? -- Frédéric Delanoy
Re: msvcrt: add support for _chsize_s (try #2)
On Sun, Oct 6, 2013 at 12:45 AM, morphiend morphi...@gmail.com wrote: This patch adds the _chsize_s() to the mscvrt and corresponding mscvr*s. This was tested on Ubuntu 12.10 using IDA 6.4 as a test application. Without the implementation of _chsize_s(), certain binaries caused an internal crash of IDA. This patch fixed that crash. You need to use your real name when sending patches. -- Frédéric Delanoy
Re: ntdll/tests: Add tests for job objects. (try 2)
On Fri, Sep 6, 2013 at 5:41 AM, Andrew Cook aris...@gmail.com wrote: --- dlls/ntdll/tests/Makefile.in | 1 + dlls/ntdll/tests/job.c | 151 +++ include/winnt.h | 5 ++ 3 files changed, 157 insertions(+) create mode 100644 dlls/ntdll/tests/job.c +if(pNtIsProcessInJob) +todo_wine todo_wine ok(pNtIsProcessInJob(pi[0].hProcess, JobObject) == STATUS_PROCESS_NOT_IN_JOB, +NtIsProcessInJob: expected STATUS_PROCESS_NOT_IN_JOB, got %x\n, ret); Is that double todo_wine intended? It seems weird... -- Frédéric Delanoy
Re: [docs 2/2] winedev: Don't recommend a preprocessor check to comment out code
On Mon, Sep 2, 2013 at 10:34 PM, André Hentschel n...@dawncrow.de wrote: --- en/winedev-coding.sgml | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) There's a typo in -block of code. +block of code and it makes sure the code get's maintained. get's = gets -- Frédéric Delanoy
Re: [website] Added templates/zh-cn/cvs.template translation
On Sat, Aug 17, 2013 at 5:31 PM, Ken Sharp kennyb...@o2.co.uk wrote: On 17/08/13 09:02, Frédéric Delanoy wrote: Hwang YunSong (황윤성) Looks like UTF-8 works fine, so you could always use your real Chinese name. Of course Ken but then you miss the point of transliteration ;) -- Frédéric Delanoy
Re: [website] Added templates/zh-cn/cvs.template translation
On Sat, Aug 17, 2013 at 5:57 AM, xulixin xulixin1...@gmail.com wrote: Should I change my name's spelling to Lixin Xu, or LiXin Xu, or other format? Not sure, most people (at least non-Chinese) use firstname lastname convention, but I guess you should use the same convention as other Chinese-speaking committers. Here's a list I extracted from AUTHORS file that *look* Chinese to me (don't know if they're really Chinese, or Korean, or from another Asian country): Chae Jong Bin Cheer Xiao Chia-I Wu Hwang YunSong (황윤성) Jau-Horng Chen Jay Yang Qian Hong Qingchuan Wang Qingdoa Daoo Shi Quan He Wei-Lun Chao Weisheng Li Xiang Li XueFeng Chang Yong Chi Yuxi Zhang Zhangrong Huang Zhan Jianyu Hope this helps, Frédéric Delanoy
RFC: winedev guide multimedia chapter patch
Hi guys, I've been updating the wine multimedia paths of the wine dev guide, but I'm not really familiar with that area of Wine, so could you please have a look at the attached patch to check if it seems correct? I checked the code a bit but I'm not sure how outdated the guide is. For easier testing, just clone http://source.winehq.org/git/docs.git, apply the patch and run ./configure, then 'make winedev-guide.html' in the en/ subdirectory. Thanks, Frédéric Delanoy From 4f20de43d0803702d6364a5d2adbe37f7cad2a3e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Delanoy?= frederic.dela...@gmail.com Date: Wed, 7 Aug 2013 17:50:58 +0200 Subject: [docs] winedev: Update wine multimedia DLLs paths Reply-To: wine-devel wine-devel@winehq.org --- en/winedev-multimedia.sgml | 137 + 1 file changed, 77 insertions(+), 60 deletions(-) diff --git a/en/winedev-multimedia.sgml b/en/winedev-multimedia.sgml index a38d7a2..1225b14 100644 --- a/en/winedev-multimedia.sgml +++ b/en/winedev-multimedia.sgml @@ -7,12 +7,30 @@ /para para - The implementation can be found in the - filenamedlls/winmm//filename directory (and in many of its - subdirectories), but also in filenamedlls/msacm//filename - (for the audio compression/decompression manager) and - filenamedlls/msvideo//filename (for the video - compression/decompression manager). + The implementation can be found in a number of directories: + itemizedlist +listitem + para +filename class=directorydlls/winmm//filename, filename +class=directorydlls/mmsystem.dll16//filename and filename +class=directorydlls/msacm32.drv//filename + /para +/listitem +listitem + para +filename class=directorydlls/msacm32//filename and filename +class=directorydlls/msacm.dll16//filename (for the audio compression/decompression +manager) + /para +/listitem +listitem + para +filename class=directorydlls/msvfw32//filename and filename +class=directorydlls/msvideo.dll16//filename (for the video +compression/decompression manager). + /para +/listitem + /itemizedlist /para sect1 id=mm-overview @@ -21,8 +39,8 @@ para The multimedia stuff is split into 3 layers. The low level (device drivers), mid level (MCI commands) and high level abstraction layers. -The low level layer has also some helper DLLs (like the MSACM/MSACM32 -and MSVIDEO/MSVFW32 pairs). +The low level layer has also some helper DLLs (like the msacm32/msacm.dll16 +and msvfw32/msvideo.dll16 pairs). /para para @@ -163,10 +181,10 @@ Kernel space |Client applications | | v v v | | v v v v | | +---+---+-+-+ | | | waveInXXX | | mciXXX | *playSound* | - | | | waveOutXXX| | | mmioXXX | WinMM.dll + | | | waveOutXXX| | | mmioXXX | winmm.dll | | | midiInXXX | | | timeXXX | 32-bit | | | midiOutXXX| | | driverXXX | - | | | midiStreamXXX | | | | MMSystem.dll + | | | midiStreamXXX | | | | mmsystem.dll16 | | | mixerXXX | | | | 16-bit | | | auxXXX+---+ +---+ mmThread| | | | | joyXXX| Call back | mmTask | | @@ -177,7 +195,7 @@ Kernel space |Client applications +-+ | | +-++--+ |HW driver|---|*.drv|| mci*.drv | +-+ | | +--+ +---+ - | || msacm.drv || mciwave | + | || msacm32.drv || mciwave | | |+--+ +---+ | | | midimap.drv || mcimidi | | | +-++---+ @@ -238,7 +256,7 @@ Kernel space |Client applications /para para - There are two specific low level drivers (msacm.drv for wave input/output, +There are two specific low level drivers (msacm32.drv for wave input/output, midimap.drv for MIDI output only). These drivers (also present in Windows): itemizedlist @@ -303,21 +321,21 @@ Kernel space |Client applications /sect2 sect2 - titleWave mapper (msacm.drv)/title +titleWave mapper (msacm32.drv, mmsystem.dll16)/title para The Wave mapper device allows to load on-demand audio
Re: [website] Added templates/zh-cn/cvs.template translation
On Fri, Aug 16, 2013 at 8:13 AM, xulixin xulixin1...@gmail.com wrote: From 860262aed3d58f42012e6dd5264eb29bd29deffb Mon Sep 17 00:00:00 2001 From: xulixin xulixin1...@gmail.com Date: Fri, 16 Aug 2013 13:56:36 +0800 Subject: add templates/zh-cn/cvs.template --- templates/zh-cn/cvs.template | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/templates/zh-cn/cvs.template b/templates/zh-cn/cvs.template index ba10a25..a9bc5d1 100644 --- a/templates/zh-cn/cvs.template +++ b/templates/zh-cn/cvs.template @@ -13,9 +13,9 @@ h1 id=sourcetree通过 Web 方式浏览源码树/h1 -pThe source code of the entire Wine tree is (a href=http://lxr.linux.no/;LXR/a-based) - cross-referenced and available for browsing, including a search engine. - This cross-references source is based on the snapshot-releases and is made available at:/p +pWine tree的源码 (a href=http://lxr.linux.no/;LXR/a-based) + 是相互参照且可供浏览的，包括一个搜索引擎。 + 这交叉参考的源码是基于snapshot-releases版本，可从下面网站获得：/p ul lia href=http://source.winehq.org/;source.winehq.org/a/li /ul Hi, the real name is required when sending patches. Also, lxr.linux.no isn't used anymore, so the original file would need to be updated beforehand. -- Frédéric Delanoy
Re: [website] Added templates/zh-cn/cvs.template translation
On Fri, Aug 16, 2013 at 12:28 PM, GOUJON Alexandre ale.gou...@gmail.com wrote:
On 08/16/2013 11:59 AM, Frédéric Delanoy wrote:
Also, lxr.linux.no isn't used anymore, so the original file would need
to be updated beforehand.
Do you mean http://source.winehq.org/{source,ident,search,find} is not
accurate anymore ?
I mean
http://source.winehq.org/git/website.git/blob/HEAD:/templates/en/cvs.template
is outdated, at least wrt the lxr.linux.no, as I said.
--
Frédéric Delanoy
Re: [website] Added templates/zh-cn/cvs.template translation
On Fri, Aug 16, 2013 at 3:21 PM, Frédéric Delanoy
frederic.dela...@gmail.com wrote:
On Fri, Aug 16, 2013 at 12:28 PM, GOUJON Alexandre ale.gou...@gmail.com
wrote:
On 08/16/2013 11:59 AM, Frédéric Delanoy wrote:
Also, lxr.linux.no isn't used anymore, so the original file would need
to be updated beforehand.
Do you mean http://source.winehq.org/{source,ident,search,find} is not
accurate anymore ?
I mean
http://source.winehq.org/git/website.git/blob/HEAD:/templates/en/cvs.template
is outdated, at least wrt the lxr.linux.no, as I said.
Well my bad, I misread the blob contents.
Still sending patch e.g. to update the git link.
Maybe this page could removed altogether, though, since we aren't
using cvs for a long time now.
--
Frédéric Delanoy
Re: [website] Update git URL
On Fri, Aug 16, 2013 at 3:59 PM, Michael Stefaniuc mstef...@redhat.com wrote: On 08/16/2013 03:32 PM, Frédéric Delanoy wrote: --- templates/en/cvs.template | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/templates/en/cvs.template b/templates/en/cvs.template index 202cf60..300b9e4 100644 --- a/templates/en/cvs.template +++ b/templates/en/cvs.template @@ -3,9 +3,9 @@ h1 class=titleThe Wine CVS Tree/h1 Schouldn't the title change too? And nowadays people know what git is and that's kinda the default SCM that people expect. That's a historic page, redirecting to git. It could probably go, but I guess that would break some links from other websites. -- Frédéric Delanoy
Re: PLEASE add bug links!
On Fri, Aug 16, 2013 at 2:46 PM, Ken Sharp kennyb...@o2.co.uk wrote: There's little point in my continually asking users to add bug links to the AppDB if maintainers and/or administrators don't bother themselves. It takes longer to create a bug report than it does to link it to the database. It really isn't that hard. I've added hundreds over the past few weeks and this is not the first time I have said it, nor am I the first one to do so. It's even on the Wiki. http://wiki.winehq.org/Bugs You'll probably want to add a subject on the forum, since it's decoupled from wine-users, and most users are on the forum now. -- Frédéric Delanoy
Re: [website] Added templates/zh-cn/cvs.template translation
On Fri, Aug 16, 2013 at 6:31 PM, Hin-Tak Leung ht...@users.sourceforge.net wrote: snipped I believe he did give his real name. Xu is a common surname in China (Not sure about Xin, probably also a less common one!). Most Chinese names consist of 3 syllables, a single-syllable surname and a double-syllable first name. Double-syllable surname are less common, but single-syllable first names are also quite popular in recent years; So you expect most Chinese names to be in 3 syllables, fewer in just two, and an even smaller number in 4. Xu Li-Xin (surname Xu, first name Li-Xin) is a conceivable real name. It is probably also conceivable that it should be interpreted as firstname Xu-Li surname Xin. Yes, with a population of 1.3 x 10^11, and using mostly 3 syllables, collisions are extremely common in China, after romantisation from Mandarin pronunciations. Well the fact that the name was given without any spaces made me think it wasn't a real name. I didn't know Chinese enough to fill the blanks ;) -- Frédéric Delanoy
Re: Sort the AUTHORS file by their last names.
On Fri, Aug 16, 2013 at 6:51 PM, Tae Wong seotaewon...@gmail.com wrote: Older revisions sort them by last name instead of text line. Your file contains all of the names sorted on last name. The current revision contains all names sorted in first name, not last name. The old revisions were updated manually. The current revision is updated automatically from git committer information (e.g. 'user.name' config variable , and most people happen to set it to firstname family_name -- Frédéric Delanoy
Re: msvcrt: strncpy doesn't compliant C standard (try 2)
On Tue, Aug 6, 2013 at 10:44 PM, Álvaro Nieto alvaro.ni...@gmail.com wrote: Remove strlen and implement some tests You should probably add tests for when the source string is not null-terminated. Frédéric Delanoy
Re: [PATCH] typo fixes (https://github.com/vlajos/misspell_fixer)
On Mon, Aug 5, 2013 at 9:41 PM, Veres Lajos vla...@gmail.com wrote: Signed-off-by: Veres Lajos vla...@gmail.com --- dlls/comctl32/tests/trackbar.c |2 +- documentation/ChangeLog.ALPHA | 80 documentation/ChangeLog.BETA | 44 +++--- documentation/ChangeLog.OLD| 24 ++-- tools/winebuild/utils.c|2 +- 5 files changed, 76 insertions(+), 76 deletions(-) The documentation/ChangeLog.* files have been removed so the patch won't apply. Frédéric Delanoy
Re: Request to add wow64 keyword to bugzilla
On Wed, Aug 7, 2013 at 4:30 PM, Ken Sharp kennyb...@o2.co.uk wrote: +1 from me. On 07/08/13 15:03, Rosanne DiMesio wrote: As to keyword usage, some of those bugs were tagged with the win64 keyword, some weren't. I know there is also a win32 keyword, and perhaps that is meant to be used for the kinds of bugs I am looking for, but if so, that is not at all clear from the keyword definition, and it is not how people are using the keywords. There's no win32 keyword? There's no win32 keyword ; only win16 and win64 There wouldn't be any use anyway since it would be the default Frédéric Delanoy
Re: help [Abount Sql2005 and WMI]
On Sun, Aug 4, 2013 at 10:39 AM, Jing Li slvm.f...@gmail.com wrote: Hi, all: I have met a problem when installing sql2005, and it seems related to some WMI problems. As WMI has just been implemented in wine-1.6 ( right? ), I want to know in what degree it has been implemented.By the way is there anyone succeed in install of it? Thanks. Appreciate your kind help. Please ask support questions on wine-users mailing list, or on the forum. This is a development list.
Re: [docs] wineusr: Assorted formatting tagging fixes (try 2)
On Fri, Aug 2, 2013 at 2:25 PM, Alexandre Julliard julli...@winehq.org wrote: Frédéric Delanoy frederic.dela...@gmail.com writes: @@ -710,17 +714,18 @@ Path=c:\windows;c:\windows\system;e:\;e:\test;f:\ choose between several edition modes: itemizedlist listitem - para - Emacs: the same keybindings as under - emacs are available. For example, Ctrl-A - will bring the cursor to the beginning - of the edition line. See your emacs - manual for the details of the commands. - /para +para + literalEmacs/literal: the same keybindings as under + commandemacs/command are available. For example, + keycombokeycapCtrl/keycapkeycapA/keycap/keycombo + will bring the cursor to the beginning + of the edition line. See your commandemacs/command + manual for the details of the commands. +/para Please avoid messing up the indentation. That's just replacing the Tabs by spaces in the affected lines. The affected lines were using a mix of tabs and spaces g It's indented two spaces from the parent listitem tag as it was before (at least when tabs are displayed as 4 chars) Should I keep those tabs? Frédéric
Re: [docs] sgml is not a valid output format
On Tue, Jul 23, 2013 at 5:26 PM, Frédéric Delanoy frederic.dela...@gmail.com wrote: --- Make.rules.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Make.rules.in b/Make.rules.in index fda8e81..d326247 100644 --- a/Make.rules.in +++ b/Make.rules.in @@ -100,7 +100,7 @@ dummy: # Manual Dependencies -ALLFORMATS = html pdf sgml ps txt +ALLFORMATS = html pdf ps txt Please discard this patch ; it seems to be used in the translated guides to generate sgml from english version+po file
Re: [docs] winelib: Use proper entity escaping for '','' and ''
On Fri, Jul 19, 2013 at 5:50 PM, Julian Rüger j...@gmx.net wrote: Hi Frédéric, - $(CC) $(CC_OPTS) -DRC_INVOKED -E -x c $ | $(WRC) -N $(WRCFLAGS) $(WINELIB_FLAGS) -o $@ + $(CC) $(CC_OPTS) -DRC_INVOKED -E -x c $lt; | $(WRC) -N $(WRCFLAGS) $(WINELIB_FLAGS) -o $@ looks like you forgot the . Best, Julian Good catch, thanks. Sending updated version. Frédéric
Re: winedev: Add doc for winedbg symbol_picker option
On Thu, Jul 18, 2013 at 12:48 AM, Frédéric Delanoy frederic.dela...@gmail.com wrote: --- en/winedev-debugger.sgml | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) Please discard this. It has been committed a long time ago. Sorry (again) for the noise. Frédéric
Re: loader: Indicate wine can run 64-bit apps in manpage
On Tue, Jul 16, 2013 at 4:57 PM, Frédéric Delanoy frederic.dela...@gmail.com wrote: --- loader/wine.man.in | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) Please ignore this patch: I accidentally resent it. Sorry about the noise. Frédéric
Re: riched20: ITextDocument stubs for ITextServices
On Sun, Jul 14, 2013 at 3:50 AM, Tiger Soldier tigerso...@gmail.com wrote: This patch implements a standalone stub of ITextDocument. The stub is currently used in txtsrv.c and will replace the stub in richole.c You have to use your real name when submitting patches to wine-patches. Frédéric
Re: [docs 2/3] winedev: Use hyphen in bitness
On Sun, Jul 14, 2013 at 7:41 PM, André Hentschel n...@dawncrow.de wrote: --- en/winedev-architecture.sgml | 56 ++-- en/winedev-debugger.sgml | 10 en/winedev-kernel.sgml | 24 +-- en/winedev-multimedia.sgml | 36 ++-- 4 files changed, 63 insertions(+), 63 deletions(-) - (an int is 16 bit in 16-bit and 32 bits in 32-bit, pointers + (an int is 16-bit in 16-bit and 32-bits in 32-bit, pointers This part sounds a bit weird... also, one is in plural with the other is in singular form. Probably would benefit from a sentence reorganization. Frédéric
Re: po: Tweak the French 'broadcast' and 'unicast' translations.
On Sat, Jul 13, 2013 at 12:36 AM, Francois Gouget fgou...@free.fr wrote: On Fri, 12 Jul 2013, Frédéric Delanoy wrote: [...] The grand dictionnaire terminologique (http://gdt.oqlf.gouv.qc.ca/Resultat.aspx) gives The thing is this dictionary is not actually French... it's Québécois. One of the differences is that Québécois is a lot more strict about not using English words, ever. Well it's not only this dictionary which tells that. I've seen it used in other dictionaries and networking books too. [...] BTW to broadcast = diffuser And also 'télédiffuser', 'émettre', 'transmettre', 'annoncer', 'téléviser', 'émission', etc. I may agree with unicast but the diffusion and multidiffusion seem OK to me It's the opposite for me. At least I can recognise that 'monodiffusion' being a made up word it must have something to do with networking. But just plain 'diffusion' can be used in so many contexts.. Well the context of networking is pretty clear here: networking (netstat/ipconfig/...), certainly not television... Frédéric
Re: po: Fix the French DEL, ERASE, RD and RMDIR usage messages.
On Fri, Jul 12, 2013 at 12:34 PM, Francois Gouget fgou...@free.fr wrote: msgid DEL filename deletes a file or set of files.\n -msgstr DEL fichiers efface un fichier ou un groupe de fichiers.\n +msgstr DEL fichier efface un fichier ou un groupe de fichiers.\n fichiers indicate it can be any number of files, replacing by the singular form doesn't (one may think only one file is deletable per command) If you absolutely want the same singular ou plural form, the English msgid it what should be changed instead IMO Same remark for your ERASE diff hunk. Regards, Frédéric
Re: po: Some Franch translation tweaks.
On Fri, Jul 12, 2013 at 1:16 PM, Francois Gouget fgou...@free.fr wrote: --- po/fr.po | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) There's a typo in the commit message (you probably spotted it already). msgstr PAUSE affiche un message à l'écran demandant à l'utilisateur d'appuyer sur -une touche.\n +une\n +touche.\n This is probably not needed msgid Drive Mapping -msgstr Assignation de lecteur +msgstr Dossier cible Are you sure about this one? Maybe the original should be changed as well in this case... Frédéric
Re: po: Tweak the French 'broadcast' and 'unicast' translations.
On Fri, Jul 12, 2013 at 4:33 PM, Francois Gouget fgou...@free.fr wrote: --- Surprisingly enough (for me) the existing translations match the term used in Microsoft's Terminology file: broadcast address - adresse de diffusion broadcast - diffusion multicast - multidiffusion unicast - monodiffusion https://www.microsoft.com/Language/en-US/Terminology.aspx But I still don't think they're good translations. I find 'diffusion' way too general and vague. Reading it I would certainly not make the link with broadcast, even in the domain of networking. Similarly I don't think 'monodiffusion' would be readily understood. So I'm more enclined to follow Wikipedia which uses the untranslated terms as the title of their French articles: Well they're just untranslated... you said it The grand dictionnaire terminologique (http://gdt.oqlf.gouv.qc.ca/Resultat.aspx) gives broadcast - diffusion (générale) multicast - multidiffusion / diffusion groupée (beurk) monocast - envoi individuel http://glossaire.traduc.org/ (used for manpages/howtos) gives broadcast - diffusion multicast - multidiffusion unicast - unicast BTW to broadcast = diffuser I may agree with unicast but the diffusion and multidiffusion seem OK to me
Re: po: Tweak the French 'broadcast' and 'unicast' translations.
On Fri, Jul 12, 2013 at 10:29 PM, GOUJON Alexandre ale.gou...@gmail.com wrote: This is particularly true among programmers/network admins.. (who use a lot of technical and english terms) but casual users also tend to reject the always-translate-into-french idea. Quoting an article that made me laugh so hard I bookmarked it : Arrivé sur le World Wide Web, je me connecte à un proxy quand Mac OS X m'informe par l'intermédiaire d'une pop-up qu'une opération de phishing pourrait bien être en cours. Dans le même temps, j'ai l'impression que ma zone de swap sature : une nouvelle fois, je vais devoir dumper la base de données sur laquelle je travaille [..] puis rebooter ma machine. snip becomes Arrivé sur la Toile d'araignée mondiale, je me connecte à un serveur mandataire quand mon système d'exploitation exclusif m'informe par l'intermédiaire d'une fenêtre intruse qu'une opération de filoutage pourrait bien être en cours. Dans le même temps, j'ai le sentiment que ma zone de permutation sature : une nouvelle fois, je vais devoir clicher la base de données sur laquelle je travaille [..] puis réamorcer ma machine. [If you don't laugh, you should at least be smiling now] Well that's an extreme case, but often people use English (a.k.a. franglais) when not necessary to be seen as cool, e.g. meeting has a perfectly usable French translation, réunion. The above looks more like automatic google translation. Frédéric
Re: Should we translate the prompt
On Mon, Jul 8, 2013 at 12:16 PM, Francois Gouget fgou...@free.fr wrote: On Sun, 7 Jul 2013, Jactry Zeng wrote: [...] msgid %1? (Yes|No)\n [...] When I discuss this with Qian Hong, he give a better idea. We may can just make the origin text more apropos, just like: msgid %1? (Y)es|(N)o\n I think this would look odd in English and that the original string is better. Note the shortcuts/hotkeys are dependent on the Yes key and No key, so they should be kept consistent e.g. in French #: cmd.rc:318 xcopy.rc:40 msgctxt Yes key msgid Y msgstr O #: cmd.rc:319 xcopy.rc:41 msgctxt No key msgid N msgstr N #: cmd.rc:354 msgid (Yes|No) msgstr (Oui|Non) Similar for File, Directory, etc. #: xcopy.rc:43 msgctxt File key msgid F msgstr F #: xcopy.rc:44 msgctxt Directory key msgid D msgstr R Frédéric
Re: Wine release 1.6-rc4
On Sat, Jun 29, 2013 at 10:30 AM, Neumann, A. D. info.adneum...@googlemail.com wrote: Hello, I changed my email address. Please send this information to: info.adneum...@t-online.de Thank you! D. Neumann You have to update your email address on the wine-announce mailing list (http://www.winehq.org/mailman/listinfo/wine-announce) This list is for wine development only. F. Delanoy
Re: [docs] winedev: Update backtrace and relay examples
On Tue, Jul 2, 2013 at 11:39 PM, André Hentschel n...@dawncrow.de wrote: --- en/winedev-debugger.sgml | 269 ++- 1 file changed, 222 insertions(+), 47 deletions(-) diff --git a/en/winedev-debugger.sgml b/en/winedev-debugger.sgml index b877063..31046c0 100644 --- a/en/winedev-debugger.sgml +++ b/en/winedev-debugger.sgml @@ -280,31 +280,208 @@ winedbg hl.exe -windowed These usually show up like this: /para screen -|Unexpected Windows program segfault - opcode = 8b -|Segmentation fault in Windows program 1b7:c41. -|Loading symbols from ELF file /root/wine/wine... -|more Loading symbols from ... -|In 16 bit mode. ... Maybe you can leave the 16 bit stuff there and have the 32 bit as an addition, not a replacement? Frédéric
Re: [patch] full translation update for 16 rc4
On Sun, Jun 30, 2013 at 6:08 AM, 中川祥 matyapir...@gmail.com wrote: Hi, please resubmit this patch with your full name transliterated in English.
Re: [website] Added Portuguese translation for call for translators
2013/6/19 Lucas Zawacki lfzawa...@gmail.com: From: Lucas Zawacki lfzawa...@gmail.com --- news/pt/2013061601.xml |9 + 1 file changed, 9 insertions(+) create mode 100644 news/pt/2013061601.xml diff --git a/news/pt/2013061601.xml b/news/pt/2013061601.xml new file mode 100644 index 000..86bf5a8 --- /dev/null +++ b/news/pt/2013061601.xml @@ -0,0 +1,9 @@ +news +date16 de Junho de 2013/date +titleProcura-se tradutores!/title +body Just wondering: does it make sense to translate a call for translators? I mean, if a volunteer can't understand the English from the call, (s)he wouldn't be able to translate correctly anyway. Frédéric
Re: [Wine] Call for Translators
On Sun, Jun 16, 2013 at 2:02 PM, Martin Gregorie mar...@gregorie.org wrote: On Sun, 2013-06-16 at 08:52 +0200, Francois Gouget wrote: On Sun, 16 Jun 2013, Yaron Shahrabani wrote: Hey Francois, sorry for trolling but I guess this is the time to revisit our stand regarding web translation platform (because I suspect it might be the cause for the lack of participation). What do you guys think? Do you mean the stance on making sure every contribution is properly attributed to its author? I don't think that's negotiable. As a native English speaker I'm not really affected by WINE's language support. My main gripe with WINE is the evident lack of regression testing. Martin Please don't hijack threads. Feel free to open a new thread on this subject on wine-devel. Frédéric
Re: Using of mac driver completely breaks tablets support?
On Wed, Jun 12, 2013 at 6:35 PM, Ken Thomases k...@codeweavers.com wrote: Hi, On Jun 12, 2013, at 10:47 AM, Andrey Upadyshev wrote: How can I switch back to x11 driver? In the registry, set the following: [HKEY_CURRENT_USER\Software\Wine\Drivers] Graphics=x11 Some of the basics of how to do that (although not this specific thing) are documented at http://wiki.winehq.org/UsefulRegistryKeys. Regards, Ken You should probably document this setting on the wiki and/or in the FAQ. Frédéric
Re: testbot and NT4
On Mon, Jun 3, 2013 at 12:47 AM, André Hentschel n...@dawncrow.de wrote: On 02.06.2013 23:58, Ann and Jason Edmeades wrote: Hiya, Its been a while since I did some cmd work and noticed there were some new bugs so am doing some fiddling. The real pain for me was always keeping the tests passing on nt4, so I noted with relief/surprise that the testbot doesnt have an NT4 VM anymore. Is it correct that there is no longer a requirement for tests to pass on NT4 for submission (if it's required, I really need a nt4 testbot!) If not, is there any objection to removing the numerous hacks in the test suite so they run on NT4? I haven't heard about NT4 been taking out of the requirement. I guess the NT4 machines are offline due to the transition to the new testbot (newtestbot.winehq.org). Hopefully the machines are working again on one of the testbots soon, let's wait a bit. With the upcoming code freeze i'd say we need them. maybe someone else can tell more. IIRC Alexandre stated some time ago (on IRC?) that the NT 4 support would/could be removed once the new testbot infrastructure is in place. Just my 2 ¢ Frédéric
Re: po: Added Croatian translation.
On Thu, May 23, 2013 at 3:45 PM, Joško Nikolić josko.nikol...@gmail.com wrote: --- configure | 1 + po/LINGUAS | 1 + po/hr.po | 13923 +++ 3 files changed, 13925 insertions(+) create mode 100644 po/hr.po As mentioned on IRC, you should remove the #| msgid foo lines, and modify 'configure.ac' instead of 'configure', which is autogenerated. Frédéric
Re: [wine-devel] Troubles configuring and building wine-1.5.30 on Debian wheezy
On Tue, May 21, 2013 at 10:10 AM, Alan W. Irwin ir...@beluga.phys.uvic.cawrote: Hugh McMaster's reply was already a help, but I need more comments please. Maybe http://wiki.winehq.org/WineOn64bit could help? Frédéric
Re: [2/6] uuid: add transact.h and txdtc.h
On Wed, May 1, 2013 at 11:19 PM, Daniel Jeliński djelins...@gmail.comwrote: #include msdasc.h +#include transact.h +#include txdtc.h A patch only adding new headers for inclusion is likely not acceptable. You should merge it with another patch making use of it. Frédéric
Re: [AppDB] version: Only display comments section in case version has maintainers
On Mon, Apr 29, 2013 at 1:49 AM, Rosanne DiMesio dime...@earthlink.netwrote: On Sun, 28 Apr 2013 18:47:25 -0400 Christopher Cope cco...@utk.edu wrote: I understand the premise, but I disagree. A lot of apps that I use don't have maintainers. However, the comments are typically helpful. I believe this should be approached differently. So volunteer to be a maintainer. Say a program had a volunteer working on it, and there were some comments explaining how to make it work (e.g. winetricks, ...), or work better So now, if the maintainer leaves, all the comments will be lost/invisible? That seems a bit harsh: you probably can't expect users to follow workarounds scattered across associated bugs, can you? Furthermore, there's already a comment telling sthg along the lines of this program wasn't tested with a recent wine version. Isn't that sufficient already? Frédéric
Re: [AppDB] version: Only display comments section in case version has maintainers
On Thu, May 2, 2013 at 2:43 PM, Rosanne DiMesio dime...@earthlink.netwrote: On Thu, 2 May 2013 11:35:28 +0200 Frédéric Delanoy frederic.dela...@gmail.com wrote: Furthermore, there's already a comment telling sthg along the lines of this program wasn't tested with a recent wine version. Isn't that sufficient already? How exactly is that going to prevent spam in comments? This won't prevent it, but I'm not sure hiding/disabling comments won't do more harm than good. In other words, my objection was just that we shouldn't throw the baby out with the bathwater. IMHO comments/instructions on the appdb entries are more important than the occasional spam. If the problem is so important, would it be feasible to add sthg like a captcha to at least avoid automated spam? Frédéric
Re: [AppDB] version: Only display comments section in case version has maintainers
On Thu, May 2, 2013 at 7:23 PM, Rosanne DiMesio dime...@earthlink.netwrote: On Thu, 2 May 2013 17:57:16 +0200 Frédéric Delanoy frederic.dela...@gmail.com wrote: This won't prevent it, but I'm not sure hiding/disabling comments won't do more harm than good. My opinion, based on close to 5 years experience as an active AppDB admin and maintainer, is it will inconvenience a few people, but overall do far more good than harm, for reasons that go beyond simple spam control. The number of unmaintained apps with an active community of commenters is small; in most unmaintained apps, questions posted just sit there unanswered. Users seeking help would be much better off posting on the forum. Of course, but we don't want people to ask the same questions over and over again on the forum. I thought the whole point of the appdb entry was to centralize information on running apps with wine (comments being common to all versions of the software tested)... Since Andre's patch (thank you, Andre) merely disables comments for unmaintained apps, any user who really thinks it's vital that the comments appear in a particular entry can make that happen themselves simply by volunteering to be a maintainer. If it's not important enough to someone to put forth the trivial effort required to do that, then it's not important to them, period. Maintaining/testing app entries may not be so trivial for everyone, and you can't expect everyone wanting to know how to run an app to become a maintainer... Maybe merely disabling *new* (vs all) comments for unmaintained apps would also do the job??? Frédéric
Re: Clang static analyzer results / wine-1.5.28-66-g6899279
On Wed, Apr 24, 2013 at 7:40 AM, Austin English austinengl...@gmail.comwrote: On Fri, Apr 19, 2013 at 1:52 AM, Michael Stefaniuc mstef...@redhat.com wrote: On 04/19/2013 12:43 AM, Austin English wrote: With wine-1.5.20 and clang 3.2, the test suite is in the same state on my Fedora 18 machine as gcc-4.7.2 llvm version: git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@179768 91177308-0d34-0410-b5e6-96231b3b80d8 clang version: git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@179771 91177308-0d34-0410-b5e6-96231b3b80d8 ./configure --disable-tests was used to reduce noise Static analyse of the tests is important as well. Over the years I found bad tests that didn't test what they were supposed to test. And even cases where the Wine code was bad due to that as it passed the tests. bye michael That was suggested by Jacek, see http://www.winehq.org/pipermail/wine-devel/2012-January/094059.html Sure, but Michael has a good point here IMHO. Although, one can sort/filter by file, or if it's really that annoying, a quick script removing tr elements containing /tests should be easy enough. Frédéric
Re: [0/4] Improve wineconsole and kernel32
On Wed, Apr 24, 2013 at 9:15 AM, Hugh McMaster hugh.mcmas...@masterindexing.com wrote: This series of four patches will improve various three functions in kernel32: * GetConsoleFontSize * GetCurrentConsoleFont * GetLargestConsoleWindowSize This is achieved by moving logical calculations to wineconsole itself. kernel32.dll only receives the final values. The first and second patches should be applied to source before compiling Wine. If this is not done, the compiler will exit with errors. (The first is a patch for server/protocol.def and requires tools/make_requests to be run). After each patch, Wine should be able to compile correctly (e.g. for regression testing) If not, you should split your patches differently IMO. Frédéric
Re: [1/13] wineconsole and kernel32: set GetLargestConsoleWindowSize based on screen resolution
On Mon, Apr 8, 2013 at 2:53 PM, Hugh McMaster hugh.mcmas...@masterindexing.com wrote: This patch creates winecon_private.h in 'include/wineconsole'. The header is now a shared header. Note that the source code is the same as that in programs/wineconsole/winecon_private.h. (This latter file will be removed later.) Tested on Linux Mint 14 and Mac OS X 10.8 (Mountain Lion). --- include/wineconsole/winecon_private.h | 103 + 1 file changed, 103 insertions(+) create mode 100644 include/wineconsole/winecon_private.h Please don't send 13 patches with the same name. Also, for long patch series, you should describe the whole purpose of the series in the first patch [1/N] (or even better in a [0/N] patch) Finally,even if one change per patch is the rule, don't overdo it... Frédéric
Re: d3dx9 [patch 1/3]: Avoid two useless computations
On Fri, Apr 5, 2013 at 9:41 AM, Rico Schüller kgbric...@web.de wrote: On 05.04.2013 09:13, Nozomi Kodama wrote: s = 0.75f; -if ( order 2 ) -s += 5.0f / 16.0f; -if ( order 4 ) -s -= 3.0f / 32.0f; +if (order 2) +s = 1.0625f; +if (order 4) +s = 0.96875f; s /= D3DX_PI; Doesn't the compiler do that already? Most likely,since those are literal constants. Besides, 5.0f / 16.0f is more readable than a pre-computed result. So I don't think this patch is really useful. Frédéric
Re: Use accented letters in their names.
On 3/4/13, Frédéric Delanoy frederic.dela...@gmail.com wrote: On Fri, Mar 1, 2013 at 5:01 PM, Tae Wong seotaewon...@gmail.com wrote: The authors file is outdated and you want this updated with the missing authors. Andrej Znidarsic should have Slovenian accented letters for his last name. On 2/4/13, Tae Wong seotaewon...@gmail.com wrote: You will want to use accented letters in their authors names. Caolan McNamara Ferenc Wagner Marko Nikolic Every once and a while the GNOME Live website is down with an error on Netscape called “The operation timed out when attempting to contact .” - This paragraph should have a website name. You want to be unbanned in Amaterasu Translations and the DOS ain’t dead forums. Feel free to send a patch to wine-patches fixing those issues. On Wed, Mar 6, 2013 at 3:02 PM, Tae Wong seotaewon...@gmail.com wrote: You’ve sent a patch to wine-patches but never got them fixed! I didn't send a patch, but you did (well, sort of, this wasn't really a patch, but a mere email) See http://wiki.winehq.org/SubmittingPatches for instructions (http://source.winehq.org/patches/ helps you see what is the status of your patch, in this case 94687) Note however that this authors list is likely autogenerated from git.(John Doo email address) email addresses, so it's up to the patch submitter to correctly spell his/her own name to begin with. Rewriting the history to fix this seems overkill to me. Hence, if you fix the AUTHORS file, your changes might be overwritten the next time the file is generated. Frédéric
Re: Use accented letters in their names.
On Fri, Mar 1, 2013 at 5:01 PM, Tae Wong seotaewon...@gmail.com wrote: The authors file is outdated and you want this updated with the missing authors. Andrej Znidarsic should have Slovenian accented letters for his last name. On 2/4/13, Tae Wong seotaewon...@gmail.com wrote: You will want to use accented letters in their authors names. Caolan McNamara Ferenc Wagner Marko Nikolic Every once and a while the GNOME Live website is down with an error on Netscape called “The operation timed out when attempting to contact .” - This paragraph should have a website name. You want to be unbanned in Amaterasu Translations and the DOS ain’t dead forums. Feel free to send a patch to wine-patches fixing those issues. Frédéric
Re: Raise the minimum version of FreeBSD to 8.0.
On Sun, Mar 3, 2013 at 12:22 AM, Gerald Pfeifer ger...@pfeifer.com wrote: We've had this as a requirement in the FreeBSD ports for quite a while (and the Wiki describes some background). Gerald --- - FreeBSD 7.0 or later + FreeBSD 8.0 or later ... FreeBSD info: - Wine will generally not work properly on versions before FreeBSD 7.0. + Wine will generally not work properly on versions before FreeBSD 8.0. You should also change the version in the various README.xx translations (in 'documentation' directory). Frédéric
Re: [PATCH] netstat: Clarify labels in UDP statistics.
On Tue, Feb 12, 2013 at 7:56 PM, Lauri Kenttä lauri.ken...@gmail.com wrote: On 2013-02-09 23:15, Frédéric Delanoy wrote: Invalid Datagrams is too vague. It could mean datagrams sent or received. I think it's pretty obvious. Nobody should send invalid datagrams anyway, especially not using any actual datagram functions, so it would be ridiculous to have a counter for it. Yet it's what Windows uses, and is more specific, so I don't really think this should modified On 2013-02-09 23:15, Frédéric Delanoy wrote: If you want to disambiguate/explain, use message contexts as explained in http://wiki.winehq.org/Translating This isn't (only) a translation ambiguity issue, this is about the original texts, especially No Ports. Or are you trying to suggest that I add #msgctxt#udp_received_stats# to that Invalid Datagrams? I meant if you find a msgstr ambiguous(which is not really a problem for the No ports IMHO), you can use msgctxt so that other translators benefit as well. Frédéric
Re: [PATCH] netstat: Clarify labels in UDP statistics.
On Sat, Feb 9, 2013 at 1:03 PM, Lauri Kenttä lauri.ken...@gmail.com wrote: Change labels in UDP statistics so that they better reflect the actual meanings as described in MSDN [1]. [1] http://msdn.microsoft.com/en-us/library/windows/desktop/aa366929%28v=vs.85%29.aspx --- - IDS_UDP_NO_PORTS,No Ports - IDS_UDP_RECV_ERRORS, Receive Errors + IDS_UDP_NO_PORTS,Invalid Port Errors + IDS_UDP_RECV_ERRORS, Invalid Datagrams IDS_UDP_DGRAMS_SENT, Datagrams Sent Invalid Datagrams is too vague. It could mean datagrams sent or received. If you want to disambiguate/explain, use message contexts as explained in http://wiki.winehq.org/Translating Frédéric
Re: [1/2] netstat: Implement the TCP stats output
On Sun, Jan 20, 2013 at 8:09 PM, André Hentschel n...@dawncrow.de wrote: --- + IDS_TCP_SEGM_RECV, Segments Recieved Typo here: should be Received (same issue on the 2nd patch) Frédéric
Re: [website] Wine 1.5.21 freigegeben
On Fri, Jan 4, 2013 at 10:33 PM, André Hentschel n...@dawncrow.de wrote: --- news/de/2012122101.xml~ | 17 + Not sure checking in your editor backup file is a good idea ;) Frédéric
Re: Re: netstat: Initial implementation (try 2)
On Wed, Jan 2, 2013 at 5:06 PM, André Hentschel n...@dawncrow.de wrote: Original-Nachricht Betreff: Re: netstat: Initial implementation (try 2) Datum: Sat, 29 Dec 2012 15:39:54 +0100 Von: André Hentschel n...@dawncrow.de An: Wine Devel wine-devel@winehq.org Am 28.12.2012 23:10, schrieb Frédéric Delanoy: On Thu, Dec 27, 2012 at 7:03 PM, André Hentschel n...@dawncrow.de wrote: +#define IDS_TCP_TIME_WAIT 11 +#define IDS_TCP_DELETE_TCB 12 ... + IDS_TCP_CLOSED, CLOSED + IDS_TCP_LISTENING, LISTENING + IDS_TCP_SYN_SENT,SYN_SENT + IDS_TCP_SYN_RCVD,SYN_RCVD + IDS_TCP_ESTABLISHED, ESTABLISHED + IDS_TCP_FIN_WAIT1, FIN_WAIT1 + IDS_TCP_FIN_WAIT2, FIN_WAIT2 + IDS_TCP_CLOSE_WAIT, CLOSE_WAIT + IDS_TCP_CLOSING, CLOSING + IDS_TCP_LAST_ACK,LAST_ACK + IDS_TCP_TIME_WAIT, TIME_WAIT + IDS_TCP_DELETE_TCB, DELETE_TCB Are these really supposed to be translated? If not they probably should be hardcoded in a C file. Frédéric In german Windows they are, not sure about the french one. see also http://www.winehq.org/pipermail/wine-devel/2012-December/098259.html It seems to be a specificity in the German version: it's not translated in the French version (tested on different windows versions). And apparently neither in other languages, if one can trust the various http://en.wikipedia.org/wiki/Netstat page translations, and the various localized screenshots of netstat using your favorite web search engine. Also, IMHO, it makes little to no sense to translate stuff like CLOSE_WAIT or FIN_WAIT1 with are part of a standard specification... so 'hardcoding them would not cause much harm, if at all. Frédéric
Re: wine-1.5.20 reversion compared to 1.5.19 and previous; MinGW/gcc 4.7.0 segfaults under wineconsole
On Mon, Dec 24, 2012 at 8:58 AM, Alan W. Irwin ir...@beluga.phys.uvic.ca wrote: On 2012-12-23 21:25-0600 Austin English wrote: On Dec 23, 2012 7:22 PM, Alan W. Irwin ir...@beluga.phys.uvic.ca wrote: The subject line pretty much says it all. Running MinGW/gcc under wineconsole for any simple test programme should demonstrate the issue for wine-1.5.20 which is not present in wine-1.5.19 and a fairly large selection of 1.5.x and MinGW versions I have tried over the last year or so. I would be happy to supply more details if there is any difficulty replicating this reversion. Alan Please run a regression test and file a bug at http://bugs.winehq.org. No thank you. Why would anyone help you if you fail to do your homework? Your bug description is rather vague and you can't expect people to start randomly testing apps until they (supposedly) find the bug you're talking about. Please provide a minimal simple test program If you want it fixed, failing to cooperate here won't help you much. Instead, create your test program, specify download links, and describe a minimal procedure to reproduce your bug (and add the appropriate keywords: download, patch, testcase, ...) http://wiki.winehq.org/BugReports and http://bugs.winehq.org/describekeywords.cgi can help here. For regressions, especially a rather recent one like you seem to suggest, there are more likely to be fixed quickly, especially if you perform the regression test yourself (reasons: you're in the best position to do it yourself; it can take some time developpers won't necessarily have: if they ran regression tests all day, when would they code???) See http://wiki.winehq.org/RegressionTesting The last time I wrote a wine bug report (with a test case and a patch to fix the problem no less), Which bug? wine developers seemed content with the fact that that bug had been reported. They did not actually fix the problem until I made a special personal appeal to one of them more than a year later. So eventually there was a happy ending there, but the impression I got from that experience is that Wine bug reports for even the most obvious issues like that one are pretty much a waste of everyone's time unless and until a Wine developer takes responsibility. Of course, in that case the bug reporting system is worthwhile since it can make a permanent record of all the events leading to a solution. If the bug was trivial to fix, why did you not send it yourself to wine-patches? There are a lot of bugs, and not many people who can fix those, so you can't expect *your* bug to be fixed in minutes. If you want to increase your chance for the bug to be fixed, you could wait less than a year, and e.g. restest if the bug still persists every couple of months (or better, after every wine release) and tell so on the bug report. No amount of complaining on this list will likely help... In this case, I would like a Wine developer to take responsibility as well for what I think is an obvious issue with 1.5.20 by verifying the issue, and then taking any further development steps they want to take concerning this issue. Or perhaps there will be an even more obvious symptom of the problem with 1.5.20 that will lead to a solution quicker than if someone follows the MinGW segfault symptom that I have found. In other words, I am willing to help out Wine by reporting the issue informally here, and let Wine developers make their best judgement of what to do about the issue, but that is about it. Again, the bugzilla system is there to report bug, not this mailing list. Do you really expect someone to read your mail and create a bug from it??? Sorry I have to be ruthless about this, but I do not want to get involved in wine development or go through a bunch of Wine bug-reporting hoops since I need to reserve my development efforts for my own free software projects. If you don't want to be cooperative, why should we help you??? Creating a good bug report is not really being involved in wine development IMO. Mere users without any programming experience do it regularly. Alan Frédéric
Re: wine-1.5.20 reversion compared to 1.5.19 and previous; MinGW/gcc 4.7.0 segfaults under wineconsole
On Fri, Dec 28, 2012 at 11:54 AM, Alan W. Irwin ir...@beluga.phys.uvic.ca wrote: On 2012-12-28 10:44+0100 Frédéric Delanoy wrote: On Mon, Dec 24, 2012 at 8:58 AM, Alan W. Irwin ir...@beluga.phys.uvic.ca wrote: On 2012-12-23 21:25-0600 Austin English wrote: On Dec 23, 2012 7:22 PM, Alan W. Irwin ir...@beluga.phys.uvic.ca wrote: The subject line pretty much says it all. Running MinGW/gcc under wineconsole for any simple test programme should demonstrate the issue for wine-1.5.20 which is not present in wine-1.5.19 and a fairly large selection of 1.5.x and MinGW versions I have tried over the last year or so. I would be happy to supply more details if there is any difficulty replicating this reversion. Alan Please run a regression test and file a bug at http://bugs.winehq.org. No thank you. Why would anyone help you if you fail to do your homework? The shoe is on the other foot. I am trying to help Wine developers assuming they have an interest in fixing obvious problems in their code no matter how informally such problems are pointed out. This bug should be easy to replicate. Try to compile any C programme (e.g., a Hello, world programme) with MinGW-4.7.0 under wine-1.5.20 and that compiler segfaults. Do the same under wine-1.5.19, and there is no such problem. That's all that should be required to not only replicate the bug but also demonstrate the reversion. Meanwhile, I am happy to stick with 1.5.19 until some Wine developer takes responsibility for getting this regression fixed. I think that creating a bug would have taken less time than writing your emails, and be more helpful on the long run (this thread will be archived like others, and be mostly forgotten, unlike bugs in bugzilla) If anybody tries such a test, and doesn't see the issue, then as I said before I am willing to supply more details. By the way, informal bug reports reported on mailing lists have been quite helpful to me in the past for my own software projects. I also have seen a number of projects spend an inordinate amount of time with bug triage rather than actually fixing the code. Wine is a big project. What applies to a small/medium project doesn't necessarily apply here. If everybody started reporting bugs in emails, that would quickly become unmanageable. So I welcome informal bug reports for my own projects especially when an issue is easy to replicate. It appears you do not personally welcome such informal reports, but hopefully other wine developers are not so inflexible for obvious problems like this one is. It's not so much that I don't welcome informal reports (they can be helpful of course), but I didn't like the tone of your inital reply. It sounded to me like: Have someone fix my bug quickly, but I don't want to waste time reporting it correcty [go through a bunch of Wine bug-reporting hoops]... so do all the work yourself. That isn't a nice way to ask for support IMHO, especially for other people volunteering their time on Wine, and who may also have other projects of their own. Also, you didn't probably pay a cent for your wine version, so don't expect people to prioritize the issues you encounter above all others, which may be equally important. Other users have issues with wine but they don't generally complain as loudly as you did. Alan Frédéric
Re: Need help to install Xlib/xfree86 devlopnemt packeg in ubuntu 10 LTS
On Thu, Dec 20, 2012 at 6:25 AM, Hamid Lohar hmdlo...@gmail.com wrote: I am installing it from source file (wine 1.5.x.tar.bz2) by running wine install i get error x support not found, wine can not fount x, please instal xlib/xfree86 devlopment files. That is the error. You need to install your X development files (that depends on your distribution, e.g. libx11-dev) for compiling wine. Most likely, you shouldn't do that, and instead use prepackaged (binary) versions of wine = http://www.winehq.org/download/ Again, you should ask such questions on wine-users or the wine forum (http://forum.winehq.org/) Frédéric
Re: [PATCH 1/3] [cmd] Convert the set /a tests to validate better
On Fri, Dec 14, 2012 at 4:50 PM, Ann and Jason Edmeades u...@edmeades.me.uk wrote: Hiya, Thanks for the comments I don't really like hardcoding a variable name in a function... I don't mind not having the variable hardcoded in the function, but I dont like the solution(s), and after all they are only test routines! Being test routines doesn't mean they don't have to be clean. Harcoding variable names is almost alway a bad thing(TM) One extremely useful benefit of naming the variable and checking the expected contents rather than just echoing them, is that you can extract the chunk of the test script into a standalone testcase and run/debug that on whatever o/s without needing to go through the test infrastructure - whereas getting output from the command script and not knowing whether it is right or wrong until you go off and compare it to some hard coded list of values is much harder to work with. I don't really understand your point here. You're echoing the variable name anyway, so if the 'set foo' displays it as well; I don't see the advantage of your method An interim option might be something like 'checkcontents var value var value' type routine - would that be better? Seems convoluted. Why just no go KISS? 2. The check for the presence of the first parameter is unneeded since you always call with at least one param (you control all calls) Its just an example of defensive coding, for which I make no excuse :-) Well, unneeded here, and to quote you: after all they are only test routines ;-) Also, the shift solution keeps your defensive check at all times (even if 3 arguments). 3. When only 1 variable is used, no need to add a '1' suffix as in 'foo1' or 'WINE_foo1': the '1' doesn't help/add useful information No, but it doesnt hurt either and gives consistency with the other tests In other non-for /a test, there's never a WINE_foo1 anywhere. Using foo, bar and baz when you have at most 3 arguments seems standard practice to me. Using an enumeration suffix for only 1! variable is not reasonable IMHO (imagine a mathematical fun(x1), people might wonder why there's no x2, x3, ...) If the patch doesnt go in as-is, I'll recode the check routine using what I describe above and if it does, I'll just patch the routine... If its a generic routine as described above it can then be reused elsewhere in the tests potentially as well Thanks for the review! Jason You're welcome. Frédéric NB: replies on wine-devel should be only the bottom
Re: [PATCH 1/3] [cmd] Convert the set /a tests to validate better
On Thu, Dec 13, 2012 at 10:59 PM, Ann and Jason Edmeades ja...@edmeades.me.uk wrote: The tests previously set a variable which was not checked until the subsequent test completed (as env vars are expanded as the line is read, meaning a sequence of set /a var=x echo %var% echos the contents before the set is executed). In addition when multiple variables are involved in the calculation, only the first one was being checked, and this is changed to check all variables involved in the calculation. + +REM Check the variables are set to the expected value and clear their contents +:check_vars +if not %1== ( + if %1==%WINE_var1% ( +echo WINE_var1 correctly %1 + ) else ( +echo ERROR: WINE_var1 incorrectly %WINE_var1% [%1] + ) +) +if not %2== ( + if %2==%WINE_var2% ( +echo WINE_var2 correctly %2 + ) else ( +echo ERROR: WINE_var2 incorrectly %WINE_var2% [%2] + ) +) +if not %3== ( + if %3==%WINE_var3% ( +echo WINE_var3 correctly %1 + ) else ( +echo ERROR: WINE_var3 incorrectly %WINE_var3% [%3] + ) +) A couple comments: 1. I don't really like hardcoding a variable name in a function... Why not using something like: set /a var=1 +2 call :compute var set /a foo=8, bar=foo+1 call :compute foo bar goto :end :compute set %1 set %1= // to clear the contents if not %2 == ( set %2 set %2= // clearing here as well ) goto :eof :end which prints the variable(s) name and value, without hardcoding? var=3 foo=8 bar=9 2. The check for the presence of the first parameter is unneeded since you always call with at least one param (you control all calls) 3. When only 1 variable is used, no need to add a '1' suffix as in 'foo1' or 'WINE_foo1': the '1' doesn't help/add useful information 4. Ideally, for clarity, one would use delayed expansion instead, such as setlocal EnableDelayedExpansion set /a var=1 +2 echo !var! endlocal but this isn't implemented yet, so adding a preliminary comment like REM FIXME Simplify tests when EnableDelayedExpansion is supported would be good IMO 5. You could even simplify the above function (making it more generic, instead of testing for up to 3 arguments) by using SHIFT and an additional label, like :compute :comploop if not %1 == ( set %1 set %1= shift ) else ( goto :eof ) goto :comploop goto :eof Or even better (if NT4 allows): :compute for %%i in (%*) do ( set %%i set %%i= ) goto :eof Frédéric
Re: [PATCH 1/3] [cmd] Convert the set /a tests to validate better
On Fri, Dec 14, 2012 at 2:59 AM, Frédéric Delanoy frederic.dela...@gmail.com wrote: On Thu, Dec 13, 2012 at 10:59 PM, Ann and Jason Edmeades ja...@edmeades.me.uk wrote: The tests previously set a variable which was not checked until the subsequent test completed (as env vars are expanded as the line is read, meaning a sequence of set /a var=x echo %var% echos the contents before the set is executed). In addition when multiple variables are involved in the calculation, only the first one was being checked, and this is changed to check all variables involved in the calculation. + +REM Check the variables are set to the expected value and clear their contents +:check_vars +if not %1== ( + if %1==%WINE_var1% ( +echo WINE_var1 correctly %1 + ) else ( +echo ERROR: WINE_var1 incorrectly %WINE_var1% [%1] + ) +) +if not %2== ( + if %2==%WINE_var2% ( +echo WINE_var2 correctly %2 + ) else ( +echo ERROR: WINE_var2 incorrectly %WINE_var2% [%2] + ) +) +if not %3== ( + if %3==%WINE_var3% ( +echo WINE_var3 correctly %1 + ) else ( +echo ERROR: WINE_var3 incorrectly %WINE_var3% [%3] + ) +) A couple comments: 1. I don't really like hardcoding a variable name in a function... Why not using something like: set /a var=1 +2 call :compute var set /a foo=8, bar=foo+1 call :compute foo bar goto :end :compute Note compute is probably a bad name, display might be better to describe the purpose of the routine. Frédéric
Re: Need help to install Xlib/xfree86 devlopnemt packeg in ubuntu 10 LTS
On Thu, Dec 6, 2012 at 3:32 PM, Hamid Lohar hmdlo...@gmail.com wrote: Dear sir, I am installing wine 1.3 from source file but i getting fail to install beacose of Xlib/xfree86 devlopnemt packeg so i neet that packege please help me. You don't provide enough information about your issue: what's the error message? distrib? These questions should be asked on wine-users/forum anyway (also the only supported versions are latest 1.4.x and 1.5.x).
Re: [PATCH 1/4] kernel32: Support UTF-7 in MultiByteToWideChar.
On Tue, Dec 4, 2012 at 5:30 AM, Alex Henrie alexhenri...@gmail.com wrote: 2012/12/2 Dmitry Timoshkov dmi...@baikal.ru: Also you probably need to add support for composition/ surrogates like other implementations do. MSDN states: Starting with Windows Vista, this function fully conforms with the Unicode 4.1 specification for UTF-8 and UTF-16. The function used on earlier operating systems encodes or decodes lone surrogate halves or mismatched surrogate pairs. Code written in earlier versions of Windows that rely on this behavior to encode random non-text binary data might run into problems. However, code that uses this function on valid UTF-8 strings will behave the same way as on earlier Windows operating systems. http://msdn.microsoft.com/en-us/library/windows/desktop/dd319072%28v=vs.85%29.aspx My implementation is modeled after Windows XP (Wine's default target Windows version), which encodes and decodes arbitrary character sequences without normalization. I saw that my submission has already been marked rejected--was this why? -Alex The above MSDN comment indicates pre-Vista versions are buggy, so it's probably not a good idea to match that behaviour. But to know the reason your patch was reject, you should ask the maintainer (Alexandre Julliard) Frédéric
Re: [PATCH 1/5] [WineHelp]: added basic infrastructure for a new wineconsole mode: line
On Mon, Dec 3, 2012 at 10:12 PM, Eric Pouech eric.pou...@orange.fr wrote: diff --git a/programs/wineconsole/line.c b/programs/wineconsole/line.c new file mode 100644 index 000..4b7fd29 --- /dev/null +++ b/programs/wineconsole/line.c @@ -0,0 +1,334 @@ +/* + * a GUI application for displaying a console + * Line back end + * + * Copyright 2002 Eric Pouech Guess that should be 2012 ;) Frédéric
Re: wined3d: Add some 'fall through' comments (coverity)
On Thu, Nov 29, 2012 at 10:24 PM, Henri Verbeet hverb...@gmail.com wrote: On 29 November 2012 17:04, Frédéric Delanoy frederic.dela...@gmail.com wrote: case WINED3D_TOP_BUMPENVMAP_LUMINANCE: lum_map |= 1 stage; +/* fall through */ case WINED3D_TOP_BUMPENVMAP: bump_map |= 1 stage; +/* fall through */ case WINED3D_TOP_BLEND_TEXTURE_ALPHA: case WINED3D_TOP_BLEND_TEXTURE_ALPHA_PM: tex_map |= 1 stage; I'm not opposed to these if they make it easier to find real bugs inside the noise with Coverity, but I would also note that it should be pretty obvious to anyone actually touching this code that the fall through is intentional. Indeed this case is pretty obvious, but it's not always the case in other files, and IMHO the reader should know quickly what was the intent of the programmer, hence the explicit fall through comment. I'm currently running through the remaining missing break coverity warning, so we can differentiate between real bugs and implicit constructs. Frédéric
Re: [1/2] ole32: Add helper for string table memory freeing
On Mon, Nov 26, 2012 at 8:54 AM, Nikolay Sivov bungleh...@gmail.com wrote:
On 11/26/2012 01:01, Frédéric Delanoy wrote:
---
dlls/ole32/filemoniker.c | 44
++--
1 file changed, 18 insertions(+), 26 deletions(-)
diff --git a/dlls/ole32/filemoniker.c b/dlls/ole32/filemoniker.c
index b3a5cc2..688f6b8 100644
--- a/dlls/ole32/filemoniker.c
+++ b/dlls/ole32/filemoniker.c
@@ -657,6 +657,16 @@ FileMonikerImpl_Reduce(IMoniker* iface, IBindCtx*
pbc, DWORD dwReduceHowFar,
return MK_S_REDUCED_TO_SELF;
}
+static void
+FileMonikerImpl_FreeStringTable(LPOLESTR* stringTable)
+{
+int i;
+
+for (i=0; stringTable[i]!=NULL; i++)
+CoTaskMemFree(stringTable[i]);
+CoTaskMemFree(stringTable);
+}
+
Could you please adjust a naming for that to something like
free_stringtable() cause it doesn't really access file moniker in this
helper.
OK
Also stringTable[i]!=NULL could be shortened to stringTable[i].
I know but it's mostly a matter of style. I prefer the '!= NULL'
notation when accessing it array-style, and any sane compiler would
optimize it anyway.
CoTaskMemFree(str1);
CoTaskMemFree(str2);
@@ -1004,17 +1010,9 @@ FileMonikerImpl_CommonPrefixWith(IMoniker*
iface,IMoniker* pmkOther,IMoniker** p
{
for(i=0;isameIdx;i++)
strcatW(commonPath,stringTable1[i]);
-
-for(i=0;inb1;i++)
-CoTaskMemFree(stringTable1[i]);
-
-CoTaskMemFree(stringTable1);
-
-for(i=0;inb2;i++)
-CoTaskMemFree(stringTable2[i]);
-
-CoTaskMemFree(stringTable2);
-
+
+FileMonikerImpl_FreeStringTable(stringTable1);
+FileMonikerImpl_FreeStringTable(stringTable2);
You sure it's an equivalent change? I mean regarding index boundaries above.
It's equivalent.
Also while you're at it FileMonikerImpl_DecomposePath() needs to be
properly fixed - it returns HRESULT, not it. And surrounding code relies on
FAILED() mask to get this index boundary from return value, this is really
broken.
Yes, but that probably warrants a patch of its own, to keep this one
as self-contained/atomic as possible.
I'll look into that
Frédéric
Explicit fall-through in switch statements?
For every wine version, static checkers (like coverity) detect cases where a switch case automatically falls-through to the next case. Shouldn't be there a rule that such cases are always marked with a fall-through comment? With the possible exception of case with no statement? like 'case FOO: case BAR: do_something();...'? This would probably help IMHO, especially when people refactor old code. Frédéric
Re: cmd: Fix possible NULL pointer access in heap_strdupW
On Sat, Nov 17, 2012 at 10:52 PM, André Hentschel n...@dawncrow.de wrote: we already do that (ieframe,vbscript,wininet,.. are good examples), but not consistent all over the place --- programs/cmd/wcmd.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/programs/cmd/wcmd.h b/programs/cmd/wcmd.h index 3cc4c0b..303d260 100644 --- a/programs/cmd/wcmd.h +++ b/programs/cmd/wcmd.h @@ -142,7 +142,8 @@ static inline WCHAR *heap_strdupW(const WCHAR *str) size = (strlenW(str)+1)*sizeof(WCHAR); ret = heap_alloc(size); -memcpy(ret, str, size); +if(ret) +memcpy(ret, str, size); } return ret; -- 1.8.0 heap_alloc is cmd was made infallible, so this isn't necessary (c6d24089dbc284f0fef5e1ce37b75ac04c6ebd94) Frédéric
Re: [PATCH] regedit: fixed a fclose(stdin) issue (Coverity)
On Sat, Nov 17, 2012 at 9:28 PM, Marcus Meissner meiss...@suse.de wrote:
Hi,
If we have multiple filenames on the commandline, and the second one is -,
we would fclose(stdin) as realname is not NULL.
(And also double free realname.)
So set it back to NULL after free and in the stdin case.
Ciao, Marcus
---
programs/regedit/regedit.c |1 +
1 Datei geändert, 1 Zeile hinzugefügt(+)
diff --git a/programs/regedit/regedit.c b/programs/regedit/regedit.c
index acff701..b6f74ee 100644
--- a/programs/regedit/regedit.c
+++ b/programs/regedit/regedit.c
@@ -143,6 +143,7 @@ static BOOL PerformRegAction(REGEDIT_ACTION action, LPSTR
s)
if (strcmp(filename, -) == 0)
{
reg_file = stdin;
+realname = NULL;
}
else
{
realname is set to NULL at the start of every iteration, so this is not useful.
Frédéric
Re: [PATCH 2/4] [cmd] Prevent external env vars causing tests to fail
On Mon, Nov 19, 2012 at 10:03 PM, Ann and Jason Edmeades
ja...@edmeades.me.uk wrote:
Existance of external environment variables should not cause
make test to fail, but it can cause extra lines in some of the
set commands if the test does not first clear them out.
[Fixes bug 32087]
diff --git a/programs/cmd/tests/test_builtins.cmd
b/programs/cmd/tests/test_builtins.cmd
index a1a3c4a..3efcd2a 100644
--- a/programs/cmd/tests/test_builtins.cmd
+++ b/programs/cmd/tests/test_builtins.cmd
@@ -239,6 +239,9 @@ set FOO=
echo Testing 'set'
call :setError 0
+rem Remove any FOO* BA* environment variables from shell before proceeding
+for /f delims== %%i in ('set ba') do set %%i=
+for /f delims== %%i in ('set foo') do set %%i=
set FOOBAR 2 nul nul
echo %ErrorLevel%
set FOOBAR = baz
IMHO it might be better to use variable names like WINE_xxx for tests
involving enumerations to avoid needlessly altering the environment.
(not that BAR, FOO or FOOBAR are likely to be already used environment
variables)
Frédéric
Re: ole32: Fix outstanding memory leak (coverity)
On Sat, Nov 10, 2012 at 3:57 PM, André Hentschel n...@dawncrow.de wrote:
---
dlls/ole32/storage32.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/dlls/ole32/storage32.c b/dlls/ole32/storage32.c
index 8498eaf..4099df6 100644
--- a/dlls/ole32/storage32.c
+++ b/dlls/ole32/storage32.c
@@ -9067,17 +9067,16 @@ static HRESULT OLECONVERT_GetOLE10ProgID(LPSTORAGE
pStorage, char *strProgID, DW
else
{
STATSTG stat;
-LPOLESTR wstrProgID;
+LPOLESTR wstrProgID = NULL;
/* Get the OleType from the registry */
REFCLSID clsid = (stat.clsid);
IStorage_Stat(pStorage, stat, STATFLAG_NONAME);
hRes = ProgIDFromCLSID(clsid, wstrProgID);
if(hRes == S_OK)
-{
*dwSize = WideCharToMultiByte(CP_ACP, 0, wstrProgID, -1,
strProgID, *dwSize, NULL, FALSE);
+if(wstrProgID)
CoTaskMemFree(wstrProgID);
-}
CoTaskMemFree is no-op when given NULL argument so if(wstrProgID) is
not necessary (since you initialize it to NULL)
Frédéric
Re: crypt32: Avoid double free in CRYPT_LoadSIP on error path (coverity))
On Mon, Oct 29, 2012 at 10:37 AM, Nikolay Sivov bungleh...@gmail.com wrote: On 10/29/2012 11:33, Frédéric Delanoy wrote: FreeLibrary(temp) can be called twice on error. CID 714004 --- error: FreeLibrary(lib); -FreeLibrary(temp); +if (temp != NULL) FreeLibrary(temp); SetLastError(TRUST_E_SUBJECT_FORM_UNKNOWN); return FALSE; } This is useless, FreeLibrary() checks for NULL. Right, although it uses SetLastError( ERROR_INVALID_HANDLE) when it encounters NULLs But the return value of FreeLibrary isn't checked, so it probably doesn't matter much. Frédéric
Re: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono
On Sun, Jun 3, 2012 at 7:02 PM, Dan Kegel daniel.r.ke...@gmail.com wrote: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh now also installs mono. It should be probably be called wine-install-addons.sh now, maybe I'll rename it that soon. If you have a better idea for the name, let me know. Wouldn't it be better (and more acceptable for people disliking/wanting to avoid mono) to - keep install-gecko.sh as is - create install-mono.sh - create wine-install-addons.sh calling the former ? Frédéric
Re: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh also installs mono
On Mon, Jun 4, 2012 at 8:35 AM, Dan Kegel d...@kegel.com wrote: On Sun, Jun 3, 2012 at 11:20 PM, Frédéric Delanoy frederic.dela...@gmail.com wrote: On Sun, Jun 3, 2012 at 7:02 PM, Dan Kegel daniel.r.ke...@gmail.com wrote: http://winetricks.googlecode.com/svn/trunk/src/install-gecko.sh now also installs mono. ... Wouldn't it be better (and more acceptable for people disliking/wanting to avoid mono) to - keep install-gecko.sh as is - create install-mono.sh - create wine-install-addons.sh calling the former ? The point of this script is to make life easier for me and for the average user. It's not to make life easier for people who don't like mono, mostly because I doubt there are many of them. My comment was not only meant for mono-haters, but it can also be useful IMHO to split e.g. to limit download size.when one doesn't even need mono, and it maybe clearer as well (addons is pretty generic). Frédéric
Re: Testing regedit
On Thu, May 24, 2012 at 8:47 AM, Daniel Jelinski djelins...@gmail.com wrote: 2012/5/24 Austin English austinengl...@gmail.com: On Wed, May 23, 2012 at 12:24 PM, Daniel Jelinski djelins...@gmail.com wrote: Hello, I just noticed that wine's regedit has a few interesting bugs that appear when running with native comctl32. Can I/should I file them in the bugzilla? Regards, Daniel What sort of bugs? In general, any bugs found with native dlls are suspect.. -- -Austin One found with both native and builtin comctl32 - if you right-click a key and select New, the new one is created under the node that was last selected, not under the one that was right-clicked. This is different form windows regedit and can be confusing. Is there a bug opened for that issue? If not, could you submit one so it is tracked and (hopefully) eventually fixed? Frédéric
Re: msi: Tweak msiexec's usage message.
On Fri, May 4, 2012 at 3:21 PM, Francois Gouget fgou...@free.fr wrote:
On Fri, 4 May 2012, Julian Rüger wrote:
Hi Francois and wine-devel,
while we're at it, shouldn't these
Advertise a product:\n
\t/j[u|m] package [/t transform] [/g languageid]\n
Apply a patch:\n
\t/p patch_package [property]\n
\t/p patch_package /a package [property]\n
also be put in curly brackets?
Like this:
\t/j[u|m] {package} [/t transform] ...
\t/p {patch_package} [property]\n
...
My understanding is that for msiexec the curly brackets are only used to
enclose cases where there is two or more alternatives: {a|b|c}. With
{required parameter} being an exception to the rule, maybe because it in
fact represents a list.
It would be nice if all of Wine's tools used the same conventions for
the usage messages.
The msiexec conventions look sane to me: [ ] for optional and { } for
mandatory parameters (*only* when a choice/list is involved). It's
also what's used in other wine commands /? results (e.g. 'start',
'ipconfig', 'regedit', etc.).
Frédéric
Re: po: English (neutral / Great Britain) spelling fixes.
On Thu, May 3, 2012 at 7:07 AM, Nicolas Le Cam niko.le...@gmail.com wrote: Le 3 mai 2012 02:45, Francois Gouget fgou...@free.fr a écrit : @@ -9429,9 +9429,9 @@ msgstr start [options] document_filename\n \n Options:\n -/M[inimized] Start the program minimized.\n -/MAX[imized] Start the program maximized.\n -/R[estored] Start the program normally (neither minimized nor maximized).\n +/M[inimized] Start the program minimised.\n +/MAX[imized] Start the program maximised.\n +/R[estored] Start the program normally (neither minimised nor maximised).\n /W[ait] Wait for started program to finish, then exit with its exit code.\n /Unix Use a Unix filename and start the file like windows explorer.\n Hi Francois, Shouldn't the end of words between brackets be translated too ? IMO they shouldn't be translated, since they indicate the long version of options. Frédéric
Re: New forum software
On Tue, Apr 17, 2012 at 03:30, Vitaliy Margolen wine-de...@kievinfo.com wrote: Can I ask when we'll have the new forum software installed? It's been discussed ages ago and we still using the same old crappy version. IIRC there were some issues with the forum = mailing list interactions. BTW, a new wiki version would also be nice, e.g. something that allows you to preview changes (diff only, *not* full page) before publication. MoinMoin doesn't allow that, even in recent versions. Frédéric
Re: [PATCH] cmd/tests: If we rewind to the beginning of the line, don't increment line number.
On Mon, Mar 26, 2012 at 10:13, Christian Costa titan.co...@gmail.com wrote: If some particular cases, a bias is introduced in the line number which make error message mismatch the content of the .exp file. This patch fixes that. --- programs/cmd/tests/batch.c | 4 I guess this should be marked as a prerequisite to/included in your new attrib patches list Frédéric
Re: Web based translation tool
On Mon, Mar 26, 2012 at 16:23, Michal Čihař mic...@cihar.com wrote: With some sort of merging of commits things get more complex. It turned out such feature seems to be important for more projects, so I will end up implementing some way of merging of commits for 1.0. Details can be found at https://github.com/nijel/weblate/issues/16 I don't know how your tool/system exactly works, so my comment may be a bit naive/wrong, but instead of merging commits, couldn't there be instead (or as a complement) some kind of session/transaction system where a user translates a number of msgids, then sort of commits its changes to close the session/transaction, which would trigger the git commit creation? That would (help) limiting the # of git commits created IMO, at the cost of some additional complexity Frédéric
Re: [website] Spanish translation for release 1.5.0
On Sat, Mar 24, 2012 at 12:13, Eduardo García eduardo.gar...@gmx.com wrote: You should send diff using git (e.g. with 'git format-patch -k 1) i.e. sthg like http://source.winehq.org/patches/data/84646
Re: What happened to my patch? -- msvcrt/file.c: file mode T (temporary file) (try 4)
On Fri, Mar 16, 2012 at 18:43, Robert van Herk mijnspambo...@hotmail.com wrote: Hi all, I never heard from my patch again. Has it fallen into a void? Probably got deferred during the code freeze. Resubmit. BTW http://source.winehq.org/patches/ is used to see the status of patches Frédéric
Re: What happened to my patch? -- msvcrt/file.c: file mode T (temporary file) (try 4)
On Sat, Mar 17, 2012 at 13:43, Frédéric Delanoy frederic.dela...@gmail.com wrote: On Fri, Mar 16, 2012 at 18:43, Robert van Herk mijnspambo...@hotmail.com wrote: Hi all, I never heard from my patch again. Has it fallen into a void? Probably got deferred during the code freeze. Resubmit. BTW http://source.winehq.org/patches/ is used to see the status of patches Also there won't be any patch committed next week (maintainer holidays)
Re: po: Update Polish translation.
On Fri, Mar 16, 2012 at 20:15, Łukasz Wojniłowicz lukasz.wojnilow...@gmail.com wrote: --- po/pl.po | 70 - 1 files changed, 32 insertions(+), 38 deletions(-) #: cryptui.rc:296 -#, fuzzy #| msgid Cryptographic Message Syntax Standard/PKCS #7 Messages (.p7b) Those #| lines must be removed as well (previous msgid) Frédéric
Re: po: Update Polish translation.
On Sat, Mar 17, 2012 at 19:27, Łukasz Wojniłowicz lukasz.wojnilow...@gmail.com wrote: Dnia sobota, 17 marca 2012 15:29:25 piszesz: On Fri, Mar 16, 2012 at 20:15, Łukasz Wojniłowicz lukasz.wojnilow...@gmail.com wrote: --- po/pl.po | 70 - 1 files changed, 32 insertions(+), 38 deletions(-) #: cryptui.rc:296 -#, fuzzy #| msgid Cryptographic Message Syntax Standard/PKCS #7 Messages (.p7b) Those #| lines must be removed as well (previous msgid) Frédéric I edited it through lokalize (computer aided translation application) and it didn't remove it. Is it vital for this patch to be accepted? AJ doesn't want those, and I agree (no need for former msgid when the entry is updated: that's just noise) I guess it should appear as comment in localize (not tested), or else you can use an editor/sed to remove those. Frédéric
Re: po: Update Korean translation
On Wed, Mar 14, 2012 at 13:31, Hwang YunSong(황윤성) hys...@dreamwiz.comwrote: fuzzy sections translated Please remove the #| msgid comment lines (previous msgid) and resubmit.
Re: po: Spanish translation update (this patch supersedes previous patches fixing fuzzies)
On Wed, Mar 14, 2012 at 22:57, Eduardo García eduardo.gar...@gmx.com wrote: This patch fixes fuzzies and remove obsolete comments. With regards. Eduardo You may also remove the #| msgid ... lines: these only indicate the former msgid, so you can see the difference quickly. Also, add (try N) suffix when you submit a new version of a patch (that's a bit more concise than your this patch... fuzzies) Frédéric
Re: po: Update Korean translation
On Wed, Mar 14, 2012 at 13:31, Hwang YunSong(황윤성) hys...@dreamwiz.comwrote: fuzzy sections translated You may also remove the #| msgid ... lines: these only indicate the former msgid, so you can see the difference quickly. Frédéric
Re: [PATCH] po: Remove bad characters (C2 A0) from french translations.
On Mon, Mar 12, 2012 at 20:32, Christian Costa titan.co...@gmail.com wrote: Le 12/03/2012 21:02, Nikolay Sivov a écrit : On 3/12/2012 21:52, Christian Costa wrote: They are displayed as a single space in a text editor but visible with an hex editor. I guess this is a non-breakable space. I don't know. Anyway it produces garbage for what the string is used for so the patch still applies. Use a sane editor. Non-break space were explicitly added, as required by French typography. Frédéric
Re: [PATCH] po: Remove bad characters (C2 A0) from french translations.
On Tue, Mar 13, 2012 at 00:42, Christian Costa titan.co...@gmail.com wrote: BTW, is there an editor that shows them ? gvim doesn't. Emacs does. Non-breakable space are only present in french translations. Between a name and a ':'. Also after/before '«' and '», as well as before double punctuation (;:?!). This is not nicer to me. I wondering if that would not be better to remove them all... It shouldn't be removed just because someone's editor doesn't show them. The said editor should be fixed instead, and not ignoring the typography rule. Frédéric
Re: [PATCH] po: Remove bad characters (C2 A0) from french translations.
On Tue, Mar 13, 2012 at 11:52, Christian Costa titan.co...@gmail.com wrote: Never heard of this rule for french or never paid attention but I'm fine with it if this is so. Actually there should sometimes also be thin non-breakable spaces in po, but those are very badly supported, so are not used here. Some links for your info: http://fr.wikipedia.org/wiki/Espace_typographique http://fr.wikipedia.org/wiki/Espace_insécable (and other wikipedia pages) provide some information This string exists in native devenum and thus is subject to translation so I just have to find why regedit displays it badly when editing the registry. Wine traces functions also but I would it is more normal. Hmm... odd indeed Frédéric
Re: use assert etc. in Wine dlls? What is better?
On Tue, Mar 13, 2012 at 15:05, joerg-cyril.hoe...@t-systems.com wrote: Hi, Maarten's wine-pulse contains several instances of assert() ... What is current opinion on this topic? IMO asserts are for (fatal) errors that should never happen, that puts a program into an inconsistent state. Consider them as basic invariants of a program, indicative of some serious bug, so better report them as early as possible, to prevent seeing weird issues later where the source of the problem can be very hard to detect/debug. ERRs are for (possibly non-recoverable, but not necessarily) errors, with a lower importance, i.e. they don't indicate a serious logic flaw in the core of the code. Just my 2 ¢. Frédéric
Re: Translating the Wiki to Portuguese
On Thu, Mar 8, 2012 at 18:32, Lucas Zawacki lfzawa...@gmail.com wrote: Hello guys, I'd like to help translate some chunks of the Wine wiki to Portuguese. What is the accepted method of translating the wiki pages? What pages do you recognize as being more important to be translated first? If any portuguese speakers want to help let's get in touch to organize ourselves and split the work. Note you may want to update the main website pages (http://source.winehq.org/git/website.git/) first (e.g. the home page download page).
Re: [PATCH 2/9] d3drm: Fix identation.
On Fri, Mar 9, 2012 at 11:55, Christian Costa titan.co...@gmail.com wrote: --- dlls/d3drm/meshbuilder.c | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/dlls/d3drm/meshbuilder.c b/dlls/d3drm/meshbuilder.c index 39df1c6..9ca7cea 100644 That patch has probably little chance of getting committed. Formatting-only patches are generally discarded right away. Frédéric
Re: Translating the Wiki to Portuguese
2012/3/9 Frédéric Delanoy frederic.dela...@gmail.com: On Thu, Mar 8, 2012 at 18:32, Lucas Zawacki lfzawa...@gmail.com wrote: Hello guys, I'd like to help translate some chunks of the Wine wiki to Portuguese. What is the accepted method of translating the wiki pages? What pages do you recognize as being more important to be translated first? If any portuguese speakers want to help let's get in touch to organize ourselves and split the work. Note you may want to update the main website pages (http://source.winehq.org/git/website.git/) first (e.g. the home page download page). More information on http://wiki.winehq.org/TranslateWineHQ
Re: Two questions on the Portuguese translation
BTW, when is the final release of 1.4 coming? Thanks. Likely today. This shouldn't prevent you from sending translation patches, though. They'll be eventually incorporated in a future 1.4.1 release (and 1.5.x) Frédéric
Re: msvcrt/file.c: file mode T (temporary file) (try 3)
On Mon, Feb 27, 2012 at 11:23, Robert van Herk mijnspambo...@hotmail.com wrote: So what actually prevents you from properly implementing this? Especially that Wine already supports temporary files. Search for MSVCRT__O_TEMPORARY Vitaliy. I wrote a new version that maps 'D' - MSVCRT__O_TEMPORARY, and 'T' - MSVCRT__O_SHORT_LIVED | MSVCRT__O_TEMPORARY I deliberately included MSVCRT__O_TEMPORARY in 'T': on Windows, when a file is opened in 'T' mode, a subsequent call to GetFileAttributes(tempfile) show that the FILE_ATTRIBUTE_TEMPORARY flag is set, so this seemed like to most sensible thing to do. I updated the conformance test such that it checks that the file is actually deleted after fclose. Kind regards, Robert van Herk You may already be aware of this, but you can request a testbot account to check your patches before submission to wine-patches. See http://testbot.winehq.org/ Frédéric
Re: doc: Update Italian README
2012/2/28 Luca Bennati luc...@gmail.com: I tried converting README.it to UTF8, instead of the current Extended ASCII, which works really bad on my system. However, it does not seems like Git caught this change: could this be done manually? I applied the patch manually and it seems the conversion went fine. Maybe there were some accentuated letters already. (hint: 'iconv' can be useful for those kind of conversions, or a save with your favorite editor) BTW, -6. ESEGUIRE I PROGRAMMI +6. RUNNING PROGRAMS seems wrong... Frédéric
