[OpenJDK 2D-Dev] [10] RFR JDK-8190332: PngReader throws NegativeArraySizeException/OOM error when IHDR width is very large

Hello All, Please review the following fix in JDK10 : Bug : https://bugs.openjdk.java.net/browse/JDK-8190332 Webrev : http://cr.openjdk.java.net/~jdv/8190332/webrev.00/ Issue : Two types of issues are fixed under the same solution, so HYPERLINK "https://bugs.openjdk.java.net/brows

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190332: PngReader throws NegativeArraySizeException/OOM error when IHDR width is very large

. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8190332/webrev.01/ Thanks, Jay From: Phil Race Sent: Tuesday, November 14, 2017 12:06 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190332: PngReader throws NegativeArraySizeException

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190332: PngReader throws NegativeArraySizeException/OOM error when IHDR width is very large

: Wednesday, November 15, 2017 6:22 PM To: Jayathirth D V; Philip Race; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK-8190332: PngReader throws NegativeArraySizeException/OOM error when IHDR width is very large Hello Jay Good day to you. Overall, the code change looks good. Few minor changes to

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190332: PngReader throws NegativeArraySizeException/OOM error when IHDR width is very large

ail/2d-dev/2016-April/006677.html ). If Phil/Others can also give clarification on this, if needed I will make this minor correction. Regards, Jay -Original Message- From: Prahalad Kumar Narayanan Sent: Thursday, November 16, 2017 2:11 PM To: Jayathirth D V; Philip Race; 2d-dev S

[OpenJDK 2D-Dev] [10] RFR JDK-8191431: Reading multiple PNG images with unique IDAT chunk positions will cause IIOException

Hello All, Please review the following fix in JDK10 : Bug : https://bugs.openjdk.java.net/browse/JDK-8191431 Webrev : http://cr.openjdk.java.net/~jdv/8191431/webrev.00/ Issue : When we try to read multiple PNG images with different IDAT chunk positions using the same PNGImageReader

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8191431: Reading multiple PNG images with unique IDAT chunk positions will cause IIOException

Hi Prahalad, Thanks for the review. I have updated the test case. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8191431/webrev.01/ Thanks, Jay -Original Message- From: Prahalad Kumar Narayanan Sent: Monday, November 20, 2017 5:25 PM To: Jayathirth D V; 2d-dev

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8191431: Reading multiple PNG images with unique IDAT chunk positions will cause IIOException

Message- From: Prahalad Kumar Narayanan Sent: Tuesday, November 21, 2017 8:13 AM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK-8191431: Reading multiple PNG images with unique IDAT chunk positions will cause IIOException Hello Jay Good day to you. I looked into the modified

[OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

Hello All, Please review the following fix in JDK10 : Bug : https://bugs.openjdk.java.net/browse/JDK-8176795 Webrev : http://cr.openjdk.java.net/~jdv/8176795/webrev.00/ Issue : When we draw translucent color over an opaque color in Unix from JDK 8 we get different color after compos

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

Hello All, Gentle reminder for review. Thanks, Jay From: Jayathirth D V Sent: Thursday, December 07, 2017 8:47 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender. Hello All, Please

[OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws NullPointerException when PLTE section is missing

Hello All, Please review the following fix in JDK10 : Bug : https://bugs.openjdk.java.net/browse/JDK-8190997 Webrev : http://cr.openjdk.java.net/~jdv/8190997/webrev.00/ Issue : When we try to read PNG image with color type as PNG_COLOR_PALETTE in IHDR header but missing the required

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws NullPointerException when PLTE section is missing

: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws NullPointerException when PLTE section is missing Hello Jay I looked into the changes. The logic to check the presence of PLTE chunk is correct. Few minor changes . The if condition to check

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws NullPointerException when PLTE section is missing

inal Message- From: Sergey Bylokhov Sent: Wednesday, December 13, 2017 9:35 PM To: Jayathirth D V; Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws NullPointerException when PLTE section is missing It looks fine, but I wonder

[OpenJDK 2D-Dev] RFR JDK-8191174: PngReader throws IllegalArgumentException because ScanlineStride calculation logic is not proper

Hello All, Please review the following fix in JDK : Bug : https://bugs.openjdk.java.net/browse/JDK-8191174 Webrev : http://cr.openjdk.java.net/~jdv/8191174/webrev.00/ Issue : When we try to read PNG image with large width we throw undocumented IllegalArgumentException with message "

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

garding the test case change you have mentioned please guide me. Regards, Jay -Original Message- From: Prahalad Kumar Narayanan Sent: Thursday, December 14, 2017 5:19 PM To: Philip Race; Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws NullPointerException when PLTE section is missing

Hi Sergey, Could you please provide your inputs and review the fix. Thanks, Jay -Original Message- From: Jayathirth D V Sent: Thursday, December 14, 2017 9:47 AM To: Sergey Bylokhov; Prahalad Kumar Narayanan; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws NullPointerException when PLTE section is missing

12:59 AM To: Jayathirth D V Cc: Sergey Bylokhov; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [10] RFR JDK-8190997: PNGImageReader throws NullPointerException when PLTE section is missing I concur but you might consider these changes to some verbiage: * PNGImageReader: L741PNG specification

Re: [OpenJDK 2D-Dev] RFR JDK-8191174: PngReader throws IllegalArgumentException because ScanlineStride calculation logic is not proper

, Jay -Original Message- From: Prahalad Kumar Narayanan Sent: Tuesday, December 19, 2017 3:08 PM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] RFR JDK-8191174: PngReader throws IllegalArgumentException because ScanlineStride calculation logic is not proper Hello Jay Good day to yo

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-5064835] TextMeasurer/deleteChar function fails when deleting more than one characters

Hi Prahalad, Please find my inputs: Since we are making changes to deleteChar() code and specification I think we should make similar changes to insertChar() to make them behave in same way. I observed Jane Wang comment in JBS and tested inserting multiple character using TextMeasurer.insertCh

[OpenJDK 2D-Dev] [11] RFR JDK-8191073: JpegImageReader throws IndexOutOfBoundsException when trying to read image data from tables-only image

Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-8191073 Webrev : http://cr.openjdk.java.net/~jdv/8191073/webrev.00/ Issue: When we try to read image data from JPEG input stream having tables-only information JPEGImageReader throws

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191073: JpegImageReader throws IndexOutOfBoundsException when trying to read image data from tables-only image

rev.01/ Thanks, Jay From: Brian Burkhalter Sent: Saturday, January 06, 2018 4:43 AM To: Jayathirth D V Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191073: JpegImageReader throws IndexOutOfBoundsException when trying to read image data from tables-only image Hi Jay, On

Re: [OpenJDK 2D-Dev] RFR JDK-8191174: PngReader throws IllegalArgumentException because ScanlineStride calculation logic is not proper

ergey Bylokhov Sent: Saturday, January 06, 2018 2:45 PM To: Prahalad Kumar Narayanan; Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] RFR JDK-8191174: PngReader throws IllegalArgumentException because ScanlineStride calculation logic is not proper Probably we can use Math.multiplyExact()? The cu

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-5064835] TextMeasurer/deleteChar function fails when deleting more than one characters

- start != fChars.length + 1) { & if (end - start != fChars.length-1) {-> if (end - start != fChars.length - 1) { Thanks, Jay -Original Message- From: Prahalad Kumar Narayanan Sent: Monday, January 08, 2018 12:12 PM To: Sergey Bylokhov; Jayathirth D V; 2d-d

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191073: JpegImageReader throws IndexOutOfBoundsException when trying to read image data from tables-only image

, 2018 2:30 AM To: Jayathirth D V Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191073: JpegImageReader throws IndexOutOfBoundsException when trying to read image data from tables-only image Hi Jay, Sorry but I have a few picky comments. 377 // If imagePositions list

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8194489] Incorrect size computation at BandedSampleModel.createDataBuffer

Hi Prahalad, Change looks good to me. Thanks, Jay From: Brian Burkhalter Sent: Wednesday, January 10, 2018 6:52 AM To: Prahalad Kumar Narayanan Cc: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8194489] Incorrect size computation at BandedSampleModel.createDataBuffer Hi Pra

Re: [OpenJDK 2D-Dev] RFR JDK-8191174: PngReader throws IllegalArgumentException because ScanlineStride calculation logic is not proper

ge- From: Sergey Bylokhov Sent: Saturday, January 13, 2018 9:00 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] RFR JDK-8191174: PngReader throws IllegalArgumentException because ScanlineStride calculation logic is not proper Hi, Jay. Can you please confirm that it is not pos

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

will be removed. Please review the updated webrev: http://cr.openjdk.java.net/~jdv/8176795/webrev.01/ Thanks, Jay -Original Message- From: Prahalad Kumar Narayanan Sent: Tuesday, January 16, 2018 8:27 AM To: Jayathirth D V; Philip Race; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [10] RFR JDK

[OpenJDK 2D-Dev] [11] RFR JDK-8195131: Dead code removal for changes present in JDK-8176795

Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-8195131 Webrev : http://cr.openjdk.java.net/~jdv/8195131/webrev.00/ Issue: After changes present in https://bugs.openjdk.java.net/browse/JDK-8176795 the Non-Premultiplied alpha colo

[OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-8191023 Webrev : http://cr.openjdk.java.net/~jdv/8191023/webrev.00/ Note : Submitter has raised 3 bugs JDK-8191023 , JDK-8191076 , JDK-8191109 with similar issue but in 3 different P

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

inal Message- From: Prahalad Kumar Narayanan Sent: Tuesday, January 23, 2018 8:24 AM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size Hello Jay I looked into the bug and the fix. The

Re: [OpenJDK 2D-Dev] [11] RFR JDK-8191023: PngReader throws NegativeArraySizeException when keyword length exceeds chunk size

Hi Sergey & Prahalad, Thanks for your inputs. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8191023/webrev.02/ Regards, Jay -Original Message- From: Prahalad Kumar Narayanan Sent: Thursday, January 25, 2018 3:23 PM To: Sergey Bylokhov; Jayathirth D V; 2d

Re: [OpenJDK 2D-Dev] [10] RFR JDK-8176795: Wrong color drawn when painting translucent colors on volatile images using XRender.

Hi Clemens, Forked repo for all the latest client changes is : http://hg.openjdk.java.net/jdk/client Thanks, Jay -Original Message- From: Clemens Eisserer [mailto:linuxhi...@gmail.com] Sent: Tuesday, February 20, 2018 7:04 PM To: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [10] RFR JDK-81767

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-8198613] Test cases result in failure or timeout when run with OpenGL backend

Hi Prahalad, I ran all the test cases after change in my Windows 7 intel i5 machine. All the test cases pass, also it looks like we have changes in 3 manual test cases. 1) java/awt/image/VolatileImage/CustomCompositeTest.java didn't fail in my machine, may be some specific configuration leads t

[OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not supported in BMPImageReader

Hello All, Please review the following solution in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-7031957 Webrev : http://cr.openjdk.java.net/~jdv/7031957/webrev.00/ Issue: If we try to read any BMP image of DIB header type BITMAPV2INFOHEADER/ BITMAPV3INFOHEADER, we get IOEx

Re: [OpenJDK 2D-Dev] [11] RFR [JDK-6686236] GIF native IIOMetadata assumes characterCellWidth/Height as 2bytes

Hi Prahalad, Verified the code changes with test case. Change looks fine. Thanks, Jay -Original Message- From: Phil Race Sent: Friday, March 16, 2018 9:21 PM To: Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR [JDK-6686236] GIF native IIOMetadata assumes charact

Re: [OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not supported in BMPImageReader

DER & BITMAPV3INFOHEADER also. Please let us know your inputs. Thanks, Jay From: Phil Race Sent: Monday, March 19, 2018 11:07 PM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not suppo

Re: [OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not supported in BMPImageReader

Message- From: Prahalad Kumar Narayanan Sent: Wednesday, March 21, 2018 2:33 PM To: Philip Race; Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-7031957: DIB header of type BITMAPV2INFOHEADER & BITMAPV3INFOHEADER is not supported in BMPImageReader Hello Jay Good day

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values

Hi Prahalad, Change looks fine. Test case works properly before and after the code change. Since we are touching getNumThumbnailsSupported() function and it is only overridden in JPEGImageWriter we can add override annotation for the same. Thanks, Jay -Original Message- From: Prahalad

Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 when passing null values

can take that in separate bug. Thanks, Jay -Original Message- From: Philip Race Sent: Tuesday, March 27, 2018 2:39 AM To: Jayathirth D V Cc: Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR: [JDK-4954348]: JPGWriter.getNumThumbnailsSupported does not return -1 whe

[OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

Hello All, Please review the following solution in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-6788458 Webrev : http://cr.openjdk.java.net/~jdv/6788458/webrev.00/ Issue: When we try to read non-indexed RGB PNG image having transparent pixel information in tRNS chunk, Imag

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

Read16BitPNGWithTRNSChunk.java to reflect this small change. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/6788458/webrev.01/ Thanks, Jay From: Jayathirth D V Sent: Tuesday, March 27, 2018 6:51 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

Jay From: Jayathirth D V Sent: Wednesday, March 28, 2018 8:28 AM To: 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images Hello All, I just realized that the test case Read16BitPNGWithTRNSChunk.java is cre

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

i Sent: Wednesday, March 28, 2018 11:52 AM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images Hi Jay, I have some points as below: 1. I suggest to rename considerTransparentPixel

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

riate value. The initialization of tRNS_colorType change can be considered as newly added check. Thanks, Jay From: Krishna Addepalli Sent: Monday, April 02, 2018 9:56 AM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while re

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

ough them and update accordingly later. Thanks, Jay From: Krishna Addepalli Sent: Monday, April 02, 2018 11:40 AM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images Hmmm, thanks for

Re: [OpenJDK 2D-Dev] [11] JDK-8200526 Test sun/java2d/marlin/ClipShapeTest.java times out

Hi Laurent,   I ran the updated test case in my Windows 7 machine and it passes without any time out. +1.   Please update copyright year content to “2017, 2018” before pushing, no need for another webrev.   Thanks, Jay   From: Laurent Bourgès [mailto:bourges.laur...@gmail.com] Sent: We

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

an Sent: Monday, April 02, 2018 12:03 PM To: Krishna Addepalli; Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images Hello Jay Good day to you. I looked into the latest code changes. Please find my review obs

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

rev.06/ Thanks, Jay -Original Message- From: Prahalad Kumar Narayanan Sent: Friday, April 06, 2018 1:42 PM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images Hello Jay Good day to y

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

or review: http://cr.openjdk.java.net/~jdv/6788458/webrev.07/ Thanks, Jay -Original Message- From: Prahalad Kumar Narayanan Sent: Monday, April 09, 2018 2:23 PM To: Jayathirth D V; 2d-dev Subject: RE: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading n

[OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-6574555 Webrev : http://cr.openjdk.java.net/~jdv/6574555/webrev.00/ Issue: PNGImageWriter. write_bKGD() function sets incorrect R, G, B value when IHDR colortype and bKGD colortype i

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images

: Phil Race Sent: Wednesday, April 11, 2018 10:23 PM To: Jayathirth D V; Prahalad Kumar Narayanan; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [11] RFR JDK-6788458: PNGImageReader ignores tRNS chunk while reading non-indexed RGB images http://cr.openjdk.java.net/~jdv/6788458/webrev.07/src/java.desktop

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

Hi Phil, Thanks for your inputs. I have modified the test case to use ByteArrayOutput/InputStream. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/6574555/webrev.01/ Regards, Jay From: Phil Race Sent: Wednesday, April 11, 2018 10:40 PM To: Jayathirth D V

Re: [OpenJDK 2D-Dev] [11] RFR JDK-6574555: PNGImageWriter incorrectly sets bKGD chunk

Hi Prahalad, Thanks for the review. I have updated the test case to dispose the image reader. Please find updated webrev: http://cr.openjdk.java.net/~jdv/6574555/webrev.02/ Regards, Jay From: Prahalad Kumar Narayanan Sent: Tuesday, April 17, 2018 11:50 AM To: Jayathirth D V

[OpenJDK 2D-Dev] [11] RFR JDK-5109146: PNGMetadata Background color initialization from standard metadata is incomplete

Hello All, Please review the following fix in JDK11 : Bug : https://bugs.openjdk.java.net/browse/JDK-5109146 Webrev : http://cr.openjdk.java.net/~jdv/5109146/webrev.00/ Issue: PNGMetadata.mergeStandardTree() function doesn't set proper bKGD colortype. Solution: When bKGD R, G, B

Re: [OpenJDK 2D-Dev] [11] RFR JDK-5109146: PNGMetadata Background color initialization from standard metadata is incomplete

Hello All, Since changes related to JDK-6574555 is pushed. Please find new webrev which captures test case changes over JDK-6574555. http://cr.openjdk.java.net/~jdv/5109146/webrev.01/ Thanks, Jay From: Jayathirth D V Sent: Tuesday, April 17, 2018 3:34 PM To: 2d-dev Subject

Re: [OpenJDK 2D-Dev] [11] Review Request: 8202301 Add tests related to JDK-8196572 to the ProblemList

+1 -Original Message- From: Sergey Bylokhov Sent: Thursday, April 26, 2018 11:02 AM To: 2d-dev Subject: [OpenJDK 2D-Dev] [11] Review Request: 8202301 Add tests related to JDK-8196572 to the ProblemList Hello. Please review small update for jdk11. Bug: https://bugs.openjdk.java.net/brow

Re: [OpenJDK 2D-Dev] [11] RFR JDK-5109146: PNGMetadata Background color initialization from standard metadata is incomplete

ifyStandardRGBValuesFromBKGDChunk() in succession, since each in turn calls writeAndReadMetaData() and the writer is disposed. On the other hand, if querying for the reader/writer for once is enough, then you can initialize the image reader/writer in the static block itself, and then run t

Re: [OpenJDK 2D-Dev] [11] Review Request: 8203027 Open source tests for "java.awt.geom"

Hi Sergey, +1. In NotConvexPieTest.java please add space between words for "String failText" before pushing. No need for another webrev. Thanks, Jay -Original Message- From: Phil Race Sent: Thursday, May 17, 2018 3:46 AM To: Sergey Bylokhov; 2d-dev; Jayathirth D v Subjec

Re: [OpenJDK 2D-Dev] RFR: 8204391: Colors with alpha are painted incorrectly on Linux

Hi Phil, Thanks for fixing the regression introduced by https://bugs.openjdk.java.net/browse/JDK-8176795 . I went through the changes present in http://cr.openjdk.java.net/~prr/8204931/ and it looks fine. I have added detail review summary in the bug itself. We can also ask Clemens to take a lo

Re: [OpenJDK 2D-Dev] RFR: 8208466: Fix potential memory leak in harfbuzz shaping

Hi Phil, Changes are fine. Thanks, Jay -Original Message- From: Philip Race Sent: Saturday, July 28, 2018 11:38 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] RFR: 8208466: Fix potential memory leak in harfbuzz shaping bug: https://bugs.openjdk.java.net/browse/JDK-8208466 webrev: http://cr.o

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212040: Compilation error due to wrong usage of NSPrintJobDispositionValue in mac10.12

Hi Prasanta,   Changes are fine.   Thanks, Jay   From: Prasanta Sadhukhan Sent: Thursday, October 11, 2018 1:40 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [12] RFR JDK-8212040: Compilation error due to wrong usage of NSPrintJobDispositionValue in mac10.12   Hi All, Please review a build is

[OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file

Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8212116 Webrev: http://cr.openjdk.java.net/~jdv/8212116/webrev.00/ Issue : When we try to read PNG image with no text in tEXt chunk we throw IIOException. Root cause : While fix

[OpenJDK 2D-Dev] [12] RFR JDK-8213130: Update ProblemList after verification of jtreg tests in Win 7

Hello All, Please review the following fix in JDK 12: Bug : https://bugs.openjdk.java.net/browse/JDK-8213130 Webrev : http://cr.openjdk.java.net/~jdv/8213130/webrev.00/ These are the test failures/errors which happen when they are run individually. All the failures/erros are happenin

Re: [OpenJDK 2D-Dev] [8u] RFR: 8212914: Test javax/imageio/plugins/bmp/BMP8BPPLoadTest.java fails

Hi Fairoz, @requires tag usage in jtreg : https://openjdk.java.net/jtreg/tag-spec.html#requires_names I think jtreg tag doesn’t support mentioning input file. Also I don’t know why it was mentioned as "@requires BMP8BPPLoadTest.PNG" when input file in code was "new File("BMP8BPPLoadTest.bmp")"

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8213138: Update ProblemList.txt for mac

Changes are fine.   Regards, Jay   From: Prasanta Sadhukhan Sent: Tuesday, October 30, 2018 3:28 PM To: awt-...@openjdk.java.net; swing-...@openjdk.java.net; 2d-dev Subject: [12] RFR JDK-8213138: Update ProblemList.txt for mac   Hi All, Please review an updation of ProblemList for mac jtr

[OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

Hello All, Please review the following fix in JDK12 : Bug : https://bugs.openjdk.java.net/browse/JDK-8176556 Webrev : http://cr.openjdk.java.net/~jdv/8176556/webrev.00/ Issue : When we run java/awt/dnd/ImageTransferTest/ImageTransferTest.java if fails to get ImageWriter(Service prov

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

Hello All, Forgot to update ProblemList. Please find updated webrev with ProblemList change also : http://cr.openjdk.java.net/~jdv/8176556/webrev.01/ Thanks, Jay From: Jayathirth D V Sent: Wednesday, November 07, 2018 3:42 PM To: 2d-dev; awt-...@openjdk.java.net Subject

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

Hello All, I am replying to the last mail in this thread. >From the test case we can see that it is not strict about pixel data which was >transferred during DnD. It is just making sure we are able to do DnD for all >native image formats. In test case ImageTransferer. areImagesIdentical(

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8176556: java/awt/dnd/ImageTransferTest/ImageTransferTest.java fails for JFIF

n or throw something like UnsupportedOperationException we can do it in separate bug. Please let me know I will raise separate bug for the same. Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Friday, November 09, 2018 12:41 AM To: Jayathirth D V; Philip Race; Bria

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException

Hello All, Gentle reminder for review. Thanks, Jay From: Jayathirth Rao Sent: Tuesday, October 23, 2018 7:09 PM To: 2d-dev@openjdk.java.net Subject: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException Hello All, Please review

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file

Hello All, Gentle reminder for review. Thanks, Jay From: Jayathirth D V Sent: Tuesday, October 16, 2018 6:37 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [12] RFR JDK-8212116: IIOException "tEXt chunk length is not proper" on opening png file Hello All, Please

[OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8211795 Webrev: http://cr.openjdk.java.net/~jdv/8211795/webrev.00/ Issue : When we read PNG image having tRNS chunk and it needs bitDepth adjustment then we throw ArrayIndexOutOfBo

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

2018 4:07 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458 Hi, Jay. Can you please provide some more detail about this bug. > Root cause : In JDK-6788458 we are adding extra alpha channel fo

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException

chunkCRC will not be used anywhere in the logic. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8211422/webrev.01/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Wednesday, November 14, 2018 4:31 AM To: Jayathirth D V; 2d-dev@openjdk.java.net Subject: Re

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException

Thanks Sergey for the approval. Need one more review. Please review the webrev : http://cr.openjdk.java.net/~jdv/8211422/webrev.01/ Regards, Jay -Original Message- From: Sergey Bylokhov Sent: Thursday, November 15, 2018 10:58 PM To: Jayathirth D V; 2d-dev@openjdk.java.net Subject: Re

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

I have made change to use inputBands data for creation and use of scale array. Ran complete imageio jtreg and JCK tests there are no failures. Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8211795/webrev.01/ Thanks, Jay -Original Message- From: Jayathirth D V Sen

[OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond

Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8212875 Webrev : http://cr.openjdk.java.net/~jdv/8212875/webrev.00/ TIFF Technical Note #2 link is broken at many places in our code. I tried finding replacement for broken link, unfo

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211795: ArrayIndexOutOfBoundsException in PNGImageReader after JDK-6788458

Thanks Sergey for the review. I need one more review. Please review the latest webrev: http://cr.openjdk.java.net/~jdv/8211795/webrev.01/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Saturday, November 17, 2018 3:35 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D

Re: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG with corrupt CRC for IEND chunk throws IIOException

Image viewer) also work this way and they are not worried about CRC for IEND chunk. Thanks, Jay -Original Message- From: Krishna Addepalli Sent: Tuesday, November 20, 2018 2:32 PM To: Jayathirth D V; 2d-dev@openjdk.java.net Subject: RE: [OpenJDK 2D-Dev] [12] RFR JDK-8211422: Reading PNG

Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond

review: http://cr.openjdk.java.net/~jdv/8212875/webrev.01/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Thursday, November 22, 2018 6:21 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond Hi

Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp: links for tiff/TTN2.draft.txt do not respond

Hi Sergey, Please find updated webrev for review: http://cr.openjdk.java.net/~jdv/8212875/webrev.02/ Thanks, Jay -Original Message- From: Sergey Bylokhov Sent: Tuesday, November 27, 2018 1:29 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8212875: ftp

[OpenJDK 2D-Dev] [12] RFR JDK-8213050: simpleTagLabel before is not getting generated properly

Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8213050 Webrev : http://cr.openjdk.java.net/~jdv/8213050/webrev.00/ Issue : Markup corrector tidy is throwing issues in files bmp_metadata.html, wbmp_metadata.html & tiff_metadata.htm

[OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in ImageInputStream.java & ImageOutputStream.java

Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8214817 Webrev : http://cr.openjdk.java.net/~jdv/8214817/webrev.00/ Thanks, Jay

[OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214876: Add "intermittent" key for imageio/stream/StreamCloserLeak/run_test.sh

Hello All, Please review the following fix in JDK12: Bug : https://bugs.openjdk.java.net/browse/JDK-8214876 Webrev : http://cr.openjdk.java.net/~jdv/8214876/webrev.00/ I have not added JBS bug id under @bug since it is a trivial test change. Thanks, Jay

Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in ImageInputStream.java & ImageOutputStream.java

Hi Alexey, Thanks for the review. I will add space before pushing the change. Regards, Jay -Original Message- From: Alexey Ivanov Sent: Thursday, December 06, 2018 12:45 AM To: Jayathirth D V; 2d-dev Subject: Re: [OpenJDK 2D-Dev] [12] RFR(XS) JDK-8214817: Bad links in

Re: [OpenJDK 2D-Dev] RFR: 8225007: java/awt/print/PrinterJob/LandscapeStackOverflow.java may hang

Hi, I was also looking into this test case under https://bugs.openjdk.java.net/browse/JDK-8224969 I will close it as duplicate of this bug. I saw that in case of Ubuntu and Mac we are throwing "java.awt.print.PrinterException: No print service found. " but I in case of Windows test just timeso

Re: [OpenJDK 2D-Dev] [13] RFR JDK-8224824:ProblemList java/awt/Color/AlphaColorTest failure in linux_x64

Changes are fine. Thanks, Jay -Original Message- From: Prasanta Sadhukhan Sent: Monday, May 27, 2019 3:03 PM To: 2d-dev Subject: [OpenJDK 2D-Dev] [13] RFR JDK-8224824:ProblemList java/awt/Color/AlphaColorTest failure in linux_x64 Hi All, AlphaColorTest is failing in mach5 linux headfu

Re: [OpenJDK 2D-Dev] [14] Review Request: 8235547 Video memory leak in the OGL pipeline on macOS

+1. Thanks, Jay > On 10-Dec-2019, at 12:48 AM, Philip Race wrote: > > OK, +1 > > -phil. > > On 12/9/19, 11:15 AM, Sergey Bylokhov wrote: >> On 12/9/19 10:23 am, Phil Race wrote: >>> How did this get found ? Is it a regression caused by some other bug fix ? >> >> I had run the test for the ol

Re: [OpenJDK 2D-Dev] [14] Review Request: 8235520 [macosx] Delete NSView based direct rendering mechanism

Changes are fine. Thanks, Jay > On 07-Dec-2019, at 5:53 AM, Sergey Bylokhov > wrote: > > Hello. > Please review the fix for JDK 14. > > Bug: https://bugs.openjdk.java.net/browse/JDK-8235520 > Fix: http://cr.openjdk.java.net/~serb/8235520/webrev.00 > > This is a part of the effort to clean up

Re: [OpenJDK 2D-Dev] [15] Review Request: 5085520 Inconsistency in spec for RenderingHints.entrySet()

Change looks fine. Thanks, Jay > On 22-Jan-2020, at 10:49 PM, Phil Race wrote: > > Looks fine. You could have added that the Set is unmodifiable but it is not > critical. > > -phil. > > On 1/20/20 9:02 PM, Sergey Bylokhov wrote: >> Hello. >> Please review the fix for JDK 15. >> >> Bug: http

Re: [OpenJDK 2D-Dev] RFR: 8238942: Rendering artifacts with LCD text and fractional metrics

Change looks good to me. And we have good amount of time to notice any pixel accuracy issues. Thanks, Jay > On 12-Feb-2020, at 9:45 AM, Philip Race wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8238942 > webrev: http://cr.openjdk.java.net/~prr/8238942/ > > As discussed in the bug, w

Re: [OpenJDK 2D-Dev] [14] RFR JDK-8235147: Release HDC from passiveDCList sooner

Hi Alexey, Change looks good to me. I think this change should be in awt-dev, so I have added the same for future reference. Thanks, Jay > On 24-Feb-2020, at 7:15 PM, Alexey Ivanov wrote: > > I'm still waiting for a second reviewer. > > Anyone? > Thank you in advance! > > > On 17/02/2020 1

Re: [OpenJDK 2D-Dev] RFR: 8219578 No associated icon for the leaf node of Jtree

Change looks good to me. Thanks, Jay -Original Message- From: Philip Race Sent: Thursday, March 5, 2020 7:26 AM To: Sergey Bylokhov Cc: awt-...@openjdk.java.net; 2d-dev <2d-dev@openjdk.java.net>; swing-...@openjdk.java.net Subject: Re: RFR: 8219578 No associated icon for the leaf no

[OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

Hello All, Please review the following fix for JDK 15: Bug : https://bugs.openjdk.java.net/browse/JDK-6532025 Webrev : http://cr.openjdk.java.net/~jdv/6532025/webrev.00/ Root cause : When w

Re: [OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

Mar-2020, at 10:20 PM, Brian Burkhalter > wrote: > > Hello Jay, > > The source fix looks OK to me. I get the same exception as in the bug > description when I run the test against my unpatched local JDK 15 build. > > Thanks, > > Brian > >>

Re: [OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

t; >> On Mar 5, 2020, at 9:18 AM, Jayathirth D v > <mailto:jayathirth@oracle.com>> wrote: >> >> Hello Brian, >> >> Thanks for the review. GIF stream in regression test case would match >> warn.gif stream behaviour that’s why it going into GIFImageRe

Re: [OpenJDK 2D-Dev] [15] RFR JDK-6532025: GIF reader throws misleading exception with truncated images

} catch (IIOException e) { > 52 // do nothing we expect IIOException but we should not > 53 // throw IndexOutOfBoundsException > 54 System.out.println(e.toString()); > 55 System.out.println("Caught IIOException ignore i

Re: [OpenJDK 2D-Dev] RFR: 8223935: PIT: java/awt/font/WindowsIndicFonts.java fails on windows10

Looks good to me. Thanks, Jay > On 17-Mar-2020, at 10:04 PM, Philip Race wrote: > > Bug: https://bugs.openjdk.java.net/browse/JDK-8223935 > Webrev: http://cr.openjdk.java.net/~prr/8223935/ > > WindowsIndicFonts has been failing randomly depending on > whether a test system has the Indic fonts

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

Hi Phil, Please share webrev link, you have added JBS link for webrev. I went to path where you usually share webrev's and found http://cr.openjdk.java.net/~prr/8242004/ Thanks, Jay > On 10-Apr-2020, at 12:49 AM, Philip Race wrote: > > Any takers

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

//cr.openjdk.java.net/%7Eprr/8242004/> > > -phil. > > > On 4/9/20, 7:00 PM, Jayathirth D v wrote: >> >> Hi Phil, >> >> Please share webrev link, you have added JBS link for webrev. >> I went to path where you usually share webrev's and found &

Re: [OpenJDK 2D-Dev] RFR: 8242004: TextLayout throws Exception with a non-invertible transform

be null but I don't think you'll get more > than a line .. > > -phil. > > On 4/10/20, 12:57 AM, Philip Race wrote: >> >> >> >> On 4/9/20, 10:26 PM, Jayathirth D v wrote: >>> >>> Hi Phil, >>> >>> I went thr

<    1   2   3   4   5   >