Re: [PR] Cleanup deprecated query options [pinot]

2024-05-01 Thread via GitHub
Jackie-Jiang commented on code in PR #13040: URL: https://github.com/apache/pinot/pull/13040#discussion_r1586682821 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java: ## @@ -85,24 +84,22 @@ public BrokerResponse

Re: [PR] [SPARK-48067][SQL] Fix variant default columns [spark]

2024-05-01 Thread via GitHub
dtenedor commented on code in PR #46312: URL: https://github.com/apache/spark/pull/46312#discussion_r1586664236 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala: ## @@ -84,9 +84,16 @@ object ResolveDefaultColumns extends

Re: [PR] [MBUILDCACHE-86] bugfix / enhancements restoration of outputs on disk [maven-build-cache-extension]

2024-05-01 Thread via GitHub
nobesio commented on PR #104: URL: https://github.com/apache/maven-build-cache-extension/pull/104#issuecomment-2088939166 Thank you, @kbuntrock! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

2024-05-01 Thread via GitHub
github-actions[bot] commented on PR #27718: URL: https://github.com/apache/superset/pull/27718#issuecomment-2088939075 @Antonio-RiveroMartnez Ephemeral environment spinning up at http://34.223.248.234:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and

Re: [I] Query history page is not usable in 3.1.2 and 4.0.0, caused by bug in sql_parse.py [superset]

2024-05-01 Thread via GitHub
gthomas-strike commented on issue #28145: URL: https://github.com/apache/superset/issues/28145#issuecomment-2088938047 We are encountering the same issue with a deployment using the latest `0.12.9` helm chart version -- This is an automated message from the Apache Git Service. To respond

Re: [PR] [HUDI-6296] Add Scala 2.13 support for Spark 3.5 integration [hudi]

2024-05-01 Thread via GitHub
hudi-bot commented on PR #11130: URL: https://github.com/apache/hudi/pull/11130#issuecomment-2088936037 ## CI report: * edf2bf30a2ddbd48db9452f34b1ac716bd2ebe18 UNKNOWN * b1598f5861c2b90da91ad33dc360533728ef7163 UNKNOWN * fdcb64e5115b8e02ccae14d3bdc9539d8ac67beb Azure:

Re: [PR] Enhancement: Sketch value aggregator performance [pinot]

2024-05-01 Thread via GitHub
Jackie-Jiang merged PR #13020: URL: https://github.com/apache/pinot/pull/13020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] Check all recipients against allowed domains [incubator-ponymail-foal]

2024-05-01 Thread via GitHub
raboof opened a new pull request, #258: URL: https://github.com/apache/incubator-ponymail-foal/pull/258 Follow-up on https://github.com/apache/incubator-ponymail-foal/pull/250 (draft because needs testing) -- This is an automated message from the Apache Git Service. To respond to

Re: [I] Finalize SIGMOD 2024 paper ~(if accepted)~ [datafusion]

2024-05-01 Thread via GitHub
alamb commented on issue #8373: URL: https://github.com/apache/datafusion/issues/8373#issuecomment-2088935249 I think it is finally accepted  ``` -- Forwarded message - From: Tim Pollitt Date: Wed, May 1, 2024 at 2:44 PM Subject: ACM Proceedings

Re: [PR] [SPARK-48067][SQL] Fix variant default columns [spark]

2024-05-01 Thread via GitHub
dtenedor commented on PR #46312: URL: https://github.com/apache/spark/pull/46312#issuecomment-2088934443 ``` previously we could not set a variant default column like create table t( v6 variant default parse_json('{\"k\": \"v\"}') ) ``` @richardc-db this

[I] Tracking Upgrade to Datafusion 37 [datafusion-python]

2024-05-01 Thread via GitHub
Michael-J-Ward opened a new issue, #663: URL: https://github.com/apache/datafusion-python/issues/663 I sketched out some of the upgrade in #662 and wanted to share what I encountered. Some major changes in between datafusion 36 and 37. ##

Re: [I] Unable to Run tests of CometShuffleEncryptionSuite [datafusion-comet]

2024-05-01 Thread via GitHub
viirya commented on issue #367: URL: https://github.com/apache/datafusion-comet/issues/367#issuecomment-2088932628 Have you tried to run it in command line? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] feat: Only allow supported and tested cast operations to be converted to native [datafusion-comet]

2024-05-01 Thread via GitHub
andygrove commented on code in PR #362: URL: https://github.com/apache/datafusion-comet/pull/362#discussion_r158786 ## spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala: ## @@ -1042,10 +1042,10 @@ object CometSparkSessionExtensions extends Logging {

Re: [PR] fixTestUninvertingReader [solr]

2024-05-01 Thread via GitHub
dsmiley merged PR #2422: URL: https://github.com/apache/solr/pull/2422 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [SPARK-48067][SQL] Fix variant default columns [spark]

2024-05-01 Thread via GitHub
dtenedor commented on code in PR #46312: URL: https://github.com/apache/spark/pull/46312#discussion_r1586662927 ## sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/ResolveDefaultColumnsUtil.scala: ## @@ -84,9 +84,16 @@ object ResolveDefaultColumns extends

Re: [PR] [SPARK-47578][CORE] Spark Core: Migrate logWarning with variables to structured logging framework [spark]

2024-05-01 Thread via GitHub
gengliangwang commented on code in PR #46309: URL: https://github.com/apache/spark/pull/46309#discussion_r1586662318 ## core/src/main/scala/org/apache/spark/deploy/master/Master.scala: ## @@ -1294,7 +1293,7 @@ private[deploy] class Master( if (worker.state !=

Re: [I] DataFusion `38.0.0` Release [datafusion]

2024-05-01 Thread via GitHub
alamb commented on issue #10217: URL: https://github.com/apache/datafusion/issues/10217#issuecomment-2088930080 Here is a PR witha proposed API https://github.com/apache/datafusion/pull/10330 that would close https://github.com/apache/datafusion/issues/10181 -- This is an

Re: [I] Error "entered unreachable code: NamedStructField should be rewritten in OperatorToFunction" after upgrade to 37 [datafusion]

2024-05-01 Thread via GitHub
alamb commented on issue #10181: URL: https://github.com/apache/datafusion/issues/10181#issuecomment-2088929490 Here is a PR with a proposed new API: https://github.com/apache/datafusion/pull/10330 -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] Add APIs to create `PhysicalExpressions` from `Expr`s: `SessionContext::create_physical_expr()` and `SessionState::create_physical_expr()` [datafusion]

2024-05-01 Thread via GitHub
alamb commented on code in PR #10330: URL: https://github.com/apache/datafusion/pull/10330#discussion_r1586649331 ## datafusion-examples/examples/expr_api.rs: ## @@ -92,7 +90,8 @@ fn evaluate_demo() -> Result<()> { let expr = col("a").lt(lit(5)).or(col("a").eq(lit(8)));

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586661597 ## bin/install_dependencies.ps1: ## @@ -34,6 +36,11 @@ if (Test-Path($ChocolateyProfile)) { } refreshenv +Write-Output " * Seting up MSYS *** " Review

Re: [PR] SOLR-17265: Fix randomized PRS testing [solr]

2024-05-01 Thread via GitHub
dsmiley commented on code in PR #2436: URL: https://github.com/apache/solr/pull/2436#discussion_r1586652988 ## solr/test-framework/src/java/org/apache/solr/cloud/SolrCloudTestCase.java: ## @@ -83,7 +83,7 @@ public class SolrCloudTestCase extends SolrTestCaseJ4 { private

[I] Lucene.Net.Util.SystemConsole throws not supported exception in .NET MAUI app running on android/iOS [lucenenet]

2024-05-01 Thread via GitHub
JayOfemi opened a new issue, #936: URL: https://github.com/apache/lucenenet/issues/936 ### Is there an existing issue for this? - [X] I have searched the existing issues ### Describe the bug I am simply trying to create a StandardQueryParser. I get the below exception

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-05-01 Thread Colomban Wendling via Github-comments
Closed #1340. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#event-12673653995 You are receiving this because you are subscribed to this thread. Message ID:

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-05-01 Thread Colomban Wendling via Github-comments
Yeah I agree, better stick with libsoup then, although relying on an existing component was an interesting idea. -- Reply to this email directly or view it on GitHub: https://github.com/geany/geany-plugins/pull/1340#issuecomment-2088925494 You are receiving this because you are subscribed to

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586658315 ## bin/install_dependencies.ps1: ## @@ -34,6 +36,11 @@ if (Test-Path($ChocolateyProfile)) { } refreshenv +Write-Output " * Seting up MSYS *** " Review

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586657681 ## bin/shell.ps1: ## @@ -33,6 +33,7 @@ $env:PATH += ";${elxInstallPath}\bin" $env:PATH += ";${vcpkgBase}\bin" $env:PATH += ";C:\Program Files (x86)\WiX Toolset

Re: [I] [C++] Unable to read date64 or date32 in specific format from CSV [arrow]

2024-05-01 Thread via GitHub
davlee1972 commented on issue #28303: URL: https://github.com/apache/arrow/issues/28303#issuecomment-2088922037 This is still an issue.. It also extends to time32[s].. **CSV conversion error to time32[s]: invalid value '7:55:00'** Right now the timestamp_parser will only

Re: [PR] refactor(plugins): BigNumber Time Comparison with existing time_offset API [superset]

2024-05-01 Thread via GitHub
Antonio-RiveroMartnez commented on PR #27718: URL: https://github.com/apache/superset/pull/27718#issuecomment-2088922177 /testenv up FEATURE_CHART_PLUGINS_EXPERIMENTAL=true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

2024-05-01 Thread via GitHub
phet commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586649678 ## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java: ## @@ -244,9 +250,10 @@ public void createTopologySpec() { }

Re: [I] pony mail search result url does not work as link [incubator-ponymail-foal]

2024-05-01 Thread via GitHub
sebbASF closed issue #255: pony mail search result url does not work as link URL: https://github.com/apache/incubator-ponymail-foal/issues/255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

2024-05-01 Thread via GitHub
phet commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586649678 ## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java: ## @@ -244,9 +250,10 @@ public void createTopologySpec() { }

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

2024-05-01 Thread via GitHub
phet commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586640513 ## gobblin-service/src/test/java/org/apache/gobblin/service/modules/orchestration/OrchestratorTest.java: ## @@ -114,6 +119,8 @@ public void setup() throws Exception {

Re: [PR] feat: Implement Spark-compatible CAST from string to timestamp types [datafusion-comet]

2024-05-01 Thread via GitHub
andygrove commented on code in PR #335: URL: https://github.com/apache/datafusion-comet/pull/335#discussion_r1586652474 ## spark/src/test/scala/org/apache/comet/CometCastSuite.scala: ## @@ -528,14 +528,29 @@ class CometCastSuite extends CometTestBase with

[PR] SOLR-17265: Fix randomized PRS testing [solr]

2024-05-01 Thread via GitHub
HoustonPutman opened a new pull request, #2436: URL: https://github.com/apache/solr/pull/2436 https://issues.apache.org/jira/browse/SOLR-17265 This fixes the test errors introduced by https://github.com/apache/solr/pull/2230 I'm not really certain what the previous logic was

Re: [PR] Pass original message down through conversion for storage write api [beam]

2024-05-01 Thread via GitHub
johnjcasey commented on PR #31106: URL: https://github.com/apache/beam/pull/31106#issuecomment-2088916288 @Abacn @ahmedabu98 could you take a look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] docs: add sizing explanation to bloom filter docs in parquet [arrow-rs]

2024-05-01 Thread via GitHub
hiltontj opened a new pull request, #5705: URL: https://github.com/apache/arrow-rs/pull/5705 Added documentation detailing the sizing of bloom filters in the parquet crate. # Which issue does this PR close? There is currently no issue for this change. #

[PR] Fix TestHnswBitVectorsFormat.testIndexAndSearchBitVectors flakiness [lucene]

2024-05-01 Thread via GitHub
benwtrent opened a new pull request, #1: URL: https://github.com/apache/lucene/pull/1 The flaky test failure is due to score tie-breaking by doc id. To avoid requiring document id order from being consistent (thus reducing randomness in the test), this commit ensures all bit

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-05-01 Thread via GitHub
robertwb merged PR #31092: URL: https://github.com/apache/beam/pull/31092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
big-r81 commented on code in PR #32: URL: https://github.com/apache/couchdb-glazier/pull/32#discussion_r1586646945 ## bin/shell.ps1: ## @@ -33,6 +33,7 @@ $env:PATH += ";${elxInstallPath}\bin" $env:PATH += ";${vcpkgBase}\bin" $env:PATH += ";C:\Program Files (x86)\WiX Toolset

Re: [PR] doc: Clean up supported JDKs in README [datafusion-comet]

2024-05-01 Thread via GitHub
andygrove merged PR #366: URL: https://github.com/apache/datafusion-comet/pull/366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [SPARK-48074][Core] Improve the readability of JSON loggings [spark]

2024-05-01 Thread via GitHub
gengliangwang commented on PR #46322: URL: https://github.com/apache/spark/pull/46322#issuecomment-2088917364 cc @panbingkun @dtenedor as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Use a System wide property to enable PRS [solr]

2024-05-01 Thread via GitHub
HoustonPutman commented on PR #2230: URL: https://github.com/apache/solr/pull/2230#issuecomment-2088918365 Ok created a PR to fix this, I'm not sure what the logic here was supposed to be, but I've changed PRS to be a much more normal per-test-class randomized option. -- This is an

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-05-01 Thread via GitHub
shunping commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1586642831 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-05-01 Thread via GitHub
shunping commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1586642831 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [PR] initial commit [activemq-artemis]

2024-05-01 Thread via GitHub
jbertram closed pull request #4910: initial commit URL: https://github.com/apache/activemq-artemis/pull/4910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] doc: Fix target typo in development.md [datafusion-comet]

2024-05-01 Thread via GitHub
andygrove merged PR #364: URL: https://github.com/apache/datafusion-comet/pull/364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[Github-comments] Re: [geany/geany] Use GtkFileChooserNative for opening files on Windows and macOS (PR #3861)

2024-05-01 Thread Jiří Techet via Github-comments
> To me it seems fine to use those dialogs since it seems to work well and if > it goes the same for "Save As" and maybe "Open Folder". Making it > configurable is a good idea, I don't mind about the default. Good to hear. I'll try to prepare the patches (after finishing the boring task of

Re: [PR] Flink: Backport #10200 to v1.19 and v1.17 [iceberg]

2024-05-01 Thread via GitHub
pvary commented on PR #10259: URL: https://github.com/apache/iceberg/pull/10259#issuecomment-2088912008 Thanks for the review @stevenzwu! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Flink: Backport #10200 to v1.19 and v1.17 [iceberg]

2024-05-01 Thread via GitHub
pvary merged PR #10259: URL: https://github.com/apache/iceberg/pull/10259 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] docs: Add a plugin overview page to the contributors guide [datafusion-comet]

2024-05-01 Thread via GitHub
parthchandra commented on code in PR #345: URL: https://github.com/apache/datafusion-comet/pull/345#discussion_r1586638726 ## docs/source/contributor-guide/plugin_overview.md: ## @@ -0,0 +1,50 @@ + + +# Comet Plugin Overview + +The entry point to Comet is the

Re: [PR] fedora:40: build quiche with both openssl and boringssl [trafficserver-ci]

2024-05-01 Thread via GitHub
bneradt merged PR #342: URL: https://github.com/apache/trafficserver-ci/pull/342 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Bump serde from 1.0.199 to 1.0.200 in /lang/rust [avro]

2024-05-01 Thread via GitHub
martin-g merged PR #2886: URL: https://github.com/apache/avro/pull/2886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@avro.apache.org

[PR] fedora:40: build quiche with both openssl and boringssl [trafficserver-ci]

2024-05-01 Thread via GitHub
bneradt opened a new pull request, #342: URL: https://github.com/apache/trafficserver-ci/pull/342 Pull in the updated tools/build_h3_tools.sh work from ATS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of maven-compat [maven-plugin-tools]

2024-05-01 Thread via GitHub
slawekjaranowski commented on code in PR #280: URL: https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1586636233 ## maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java: ## @@ -69,25 +69,33 @@ public class

[PR] Add MSYS2 to be able to build QuickJS [couchdb-glazier]

2024-05-01 Thread via GitHub
nickva opened a new pull request, #32: URL: https://github.com/apache/couchdb-glazier/pull/32 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [GOBBLIN-2056] initialize topology specs directly without waitging for listener call… [gobblin]

2024-05-01 Thread via GitHub
arjun4084346 commented on code in PR #3937: URL: https://github.com/apache/gobblin/pull/3937#discussion_r1586634905 ## gobblin-service/src/main/java/org/apache/gobblin/service/modules/utils/FlowCompilationValidationHelper.java: ## @@ -73,12 +74,12 @@ public class

Re: [PR] [SPARK-48016][SQL][3.5] Fix a bug in try_divide function when with decimals [spark]

2024-05-01 Thread via GitHub
gengliangwang commented on PR #46323: URL: https://github.com/apache/spark/pull/46323#issuecomment-2088905069 @dongjoon-hyun Thanks for pointing out the mistaken changes! It is now reverted in https://github.com/apache/spark/pull/46323/commits/0a43e3ab982dcb21bfaf9594db0233a354f12869 --

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-01 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1586632167 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1169,8 +1129,7 @@ private Map beginningOrEndOffset(Collection

[PR] [SPARK-48016][SQL][3.5] Fix a bug in try_divide function when with decimals [spark]

2024-05-01 Thread via GitHub
gengliangwang opened a new pull request, #46323: URL: https://github.com/apache/spark/pull/46323 ### What changes were proposed in this pull request? Currently, the following query will throw DIVIDE_BY_ZERO error instead of returning null ``` SELECT

Re: [PR] Enforce strict host tag check [cloudstack]

2024-05-01 Thread via GitHub
blueorangutan commented on PR #9017: URL: https://github.com/apache/cloudstack/pull/9017#issuecomment-2088903484 @vishesh92 a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests -- This is an automated message from the Apache Git Service. To

Re: [PR] [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of maven-compat [maven-plugin-tools]

2024-05-01 Thread via GitHub
slawekjaranowski commented on code in PR #280: URL: https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1586630365 ## maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java: ## @@ -69,25 +69,33 @@ public class

Re: [PR] Bump ejs, @vue/cli and @vue/cli-service in /ui [cloudstack]

2024-05-01 Thread via GitHub
dependabot[bot] commented on PR #9024: URL: https://github.com/apache/cloudstack/pull/9024#issuecomment-2088901609 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve

Re: [PR] Bump ejs, @vue/cli and @vue/cli-service in /ui [cloudstack]

2024-05-01 Thread via GitHub
rohityadavcloud closed pull request #9024: Bump ejs, @vue/cli and @vue/cli-service in /ui URL: https://github.com/apache/cloudstack/pull/9024 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] [3.2.x] Upgrade to latest Camel & Quarkus releases [camel-quarkus]

2024-05-01 Thread via GitHub
jamesnetherton merged PR #6058: URL: https://github.com/apache/camel-quarkus/pull/6058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Enforce strict host tag check [cloudstack]

2024-05-01 Thread via GitHub
vishesh92 commented on PR #9017: URL: https://github.com/apache/cloudstack/pull/9017#issuecomment-2088901115 @blueorangutan test -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] GH-41470: [C++] Reuse deduplication logic for direct registration [arrow]

2024-05-01 Thread via GitHub
vibhatha commented on PR #41466: URL: https://github.com/apache/arrow/pull/41466#issuecomment-2088901863 @lidavidm this seems to be from the recent maven build update? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-01 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1586626516 ## clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java: ## @@ -987,6 +987,7 @@ public void testResetUsingAutoResetPolicy(GroupProtocol

Re: [PR] Remove superfluous usage of System.out.println [camel-quarkus]

2024-05-01 Thread via GitHub
jamesnetherton merged PR #6060: URL: https://github.com/apache/camel-quarkus/pull/6060 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add cli-connector support for Camel JBang runtime=quarkus [camel-quarkus]

2024-05-01 Thread via GitHub
jamesnetherton merged PR #6059: URL: https://github.com/apache/camel-quarkus/pull/6059 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] [SPARK-48072][SQL][TESTS] Improve SQLQuerySuite test output [spark]

2024-05-01 Thread via GitHub
dongjoon-hyun commented on code in PR #46318: URL: https://github.com/apache/spark/pull/46318#discussion_r1586626193 ## sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala: ## @@ -4750,12 +4750,13 @@ class SQLQuerySuite extends QueryTest with SharedSparkSession

Re: [I] Setup regular meetups for Comet development [datafusion-comet]

2024-05-01 Thread via GitHub
parthchandra commented on issue #217: URL: https://github.com/apache/datafusion-comet/issues/217#issuecomment-2088897629 For those who might be reading this in future: Meetups links: https://docs.google.com/document/d/1NBpkIAuU7O9h8Br5CbFksDhX-L9TyO9wmGLPMe0Plc8/edit?usp=sharing

Re: [I] Setup regular meetups for Comet development [datafusion-comet]

2024-05-01 Thread via GitHub
parthchandra closed issue #217: Setup regular meetups for Comet development URL: https://github.com/apache/datafusion-comet/issues/217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] feat: Add a test for supported types of SortMergeJoin in DataFusion [datafusion-comet]

2024-05-01 Thread via GitHub
comphead commented on code in PR #365: URL: https://github.com/apache/datafusion-comet/pull/365#discussion_r1586622441 ## common/src/main/scala/org/apache/comet/CometConf.scala: ## @@ -383,6 +383,13 @@ object CometConf { .booleanConf .createWithDefault(false) + val

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-01 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1586622390 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumer.java: ## @@ -1273,6 +1228,22 @@ private void close(Duration timeout, boolean

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-01 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1586620323 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEvent.java: ## @@ -16,9 +16,118 @@ */ package

Re: [PR] Enforce strict host tag check [cloudstack]

2024-05-01 Thread via GitHub
blueorangutan commented on PR #9017: URL: https://github.com/apache/cloudstack/pull/9017#issuecomment-2088894554 Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9507 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] feat: Implement Spark-compatible CAST from string to integral types [datafusion-comet]

2024-05-01 Thread via GitHub
parthchandra commented on code in PR #307: URL: https://github.com/apache/datafusion-comet/pull/307#discussion_r1586606093 ## core/src/execution/datafusion/expressions/cast.rs: ## @@ -142,6 +233,202 @@ impl Cast { } } +/// Equivalent to

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-01 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1586620323 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CompletableEvent.java: ## @@ -16,9 +16,118 @@ */ package

[Github-comments] Re: [geany/geany-plugins] updatechecker: Port to GIO and small other fixes (PR #1340)

2024-05-01 Thread Jiří Techet via Github-comments
Regarding macOS, the way gio behaves I expect it will never work so better to use libsoup (2 or 3, both are provided by gtk-osx). I can try again if I manage to get tls work with libsoup - to be honest, I didn't try too hard last time because I don't use neither of the plugins. -- Reply to

[I] Unable to Run tests of CometShuffleEncryptionSuite [datafusion-comet]

2024-05-01 Thread via GitHub
ganeshkumar269 opened a new issue, #367: URL: https://github.com/apache/datafusion-comet/issues/367 ### Describe the bug when ever I execute the test class CometShuffleEncryptionSuite, the tests fails/crashes with no meaningful error message, though I get this warning message

Re: [I] [Enhancement] Do some code optimization.[EventMeshCommon] (eventmesh)

2024-05-01 Thread via GitHub
github-actions[bot] commented on issue #4763: URL: https://github.com/apache/eventmesh/issues/4763#issuecomment-2088892526 It has been 90 days since the last activity on this issue. Apache EventMesh values the voices of the community. Please don't hesitate to share your latest insights on

Re: [PR] FnAPI proto changes for ordered list state. [beam]

2024-05-01 Thread via GitHub
robertwb commented on code in PR #31092: URL: https://github.com/apache/beam/pull/31092#discussion_r1586618153 ## model/fn-execution/src/main/proto/org/apache/beam/model/fn_execution/v1/beam_fn_api.proto: ## @@ -1063,6 +1087,10 @@ message StateAppendRequest { // Represents a

Re: [I] Add ability to disable a running DAG only after after it's in a finished state [airflow]

2024-05-01 Thread via GitHub
eladkal commented on issue #22006: URL: https://github.com/apache/airflow/issues/22006#issuecomment-209489 @jscheffl The way I imagine it is that the drain status is temporary (for the duration of the drain). once drain is finished it should be switched to pause. So at any given time

Re: [I] Support for snowflake catalog in apache iceberg [iceberg-python]

2024-05-01 Thread via GitHub
prabodh1194 commented on issue #685: URL: https://github.com/apache/iceberg-python/issues/685#issuecomment-207256 raised PR here -- https://github.com/apache/iceberg-python/pull/687 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[PR] define snowflake catalog [iceberg-python]

2024-05-01 Thread via GitHub
prabodh1194 opened a new pull request, #687: URL: https://github.com/apache/iceberg-python/pull/687 - defined reading Iceberg tables using the snowflake catalog. - snowflake catalog is pretty much read only, so adding primarily read only ops. - refer snowflake iceberg sdk read guide:

Re: [PR] [SPARK-48016][SQL] Fix a bug in try_divide function when with decimals [spark]

2024-05-01 Thread via GitHub
gengliangwang commented on PR #46286: URL: https://github.com/apache/spark/pull/46286#issuecomment-205469 @dongjoon-hyun Thanks a lot. I will create a backport for 3.5. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-48068][PYTHON] `mypy` should have `--python-executable` parameter [spark]

2024-05-01 Thread via GitHub
viirya commented on PR #46314: URL: https://github.com/apache/spark/pull/46314#issuecomment-204973 Looks good to me. Thanks @dongjoon-hyun -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[PR] Add GlobalClockRuleConfigurationRepositoryTupleSwapperIT [shardingsphere]

2024-05-01 Thread via GitHub
terrymanu opened a new pull request, #31094: URL: https://github.com/apache/shardingsphere/pull/31094 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SPARK-46009][SQL][FOLLOWUP] Remove unused PERCENTILE_CONT and PERCENTILE_DISC in g4 [spark]

2024-05-01 Thread via GitHub
dongjoon-hyun closed pull request #46272: [SPARK-46009][SQL][FOLLOWUP] Remove unused PERCENTILE_CONT and PERCENTILE_DISC in g4 URL: https://github.com/apache/spark/pull/46272 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] [SPARK-46009][SQL][FOLLOWUP] Remove unused PERCENTILE_CONT and PERCENTILE_DISC in g4 [spark]

2024-05-01 Thread via GitHub
dongjoon-hyun commented on PR #46272: URL: https://github.com/apache/spark/pull/46272#issuecomment-204219 Thank you, @beliefer . Merged to master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] Only validate if a simple element parse succeeds [daffodil]

2024-05-01 Thread via GitHub
stevedlawrence merged PR #1228: URL: https://github.com/apache/daffodil/pull/1228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] Add password enabled during ISO register and update [cloudstack]

2024-05-01 Thread via GitHub
blueorangutan commented on PR #8992: URL: https://github.com/apache/cloudstack/pull/8992#issuecomment-203891 UI build: :heavy_check_mark: Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8992 (QA-JID-332) -- This is an automated message from the Apache Git Service. To respond

Re: [PR] chore: add a utils method to getColumnReader with SQLConf [datafusion-comet]

2024-05-01 Thread via GitHub
viirya commented on PR #360: URL: https://github.com/apache/datafusion-comet/pull/360#issuecomment-203549 Hmm, I think @parthchandra meant that by adding SQLConf, `common` will depend on Spark. Does it conflict with the direction to make `common` not Spark dependent? -- This is an

Re: [PR] [YAML] Increase re-use of providers with implicitly overlapping transforms. [beam]

2024-05-01 Thread via GitHub
robertwb merged PR #30793: URL: https://github.com/apache/beam/pull/30793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] KAFKA-15974: Enforce that event processing respects user-provided timeout [kafka]

2024-05-01 Thread via GitHub
kirktrue commented on code in PR #15640: URL: https://github.com/apache/kafka/pull/15640#discussion_r1586607598 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/CommitEvent.java: ## @@ -30,12 +29,7 @@ public abstract class CommitEvent extends

Re: [I] Explore adding table ids tags to some metrics [accumulo]

2024-05-01 Thread via GitHub
dlmarion commented on issue #4511: URL: https://github.com/apache/accumulo/issues/4511#issuecomment-201202 Yeah, I get that total cardinality is an issue for most of the TSDBs, but I think limitations are different for each. My point was that we should not take the numbers from

Re: [PR] Fix ISM-expecting tests by explicilty requisting random access. [beam]

2024-05-01 Thread via GitHub
robertwb merged PR #31149: URL: https://github.com/apache/beam/pull/31149 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] explain plan disables some cases in ScanExecRule [datafusion-comet]

2024-05-01 Thread via GitHub
viirya commented on issue #322: URL: https://github.com/apache/datafusion-comet/issues/322#issuecomment-200855 Closed it now. Thanks @jc4x4 for reminding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [I] heap use after free in QUICStreamAdapter::stream via HQTransaction::get_transaction_id [trafficserver]

2024-05-01 Thread via GitHub
bneradt closed issue #11170: heap use after free in QUICStreamAdapter::stream via HQTransaction::get_transaction_id URL: https://github.com/apache/trafficserver/issues/11170 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] heap use after free in QUICStreamAdapter::stream via HQTransaction::get_transaction_id [trafficserver]

2024-05-01 Thread via GitHub
bneradt commented on issue #11170: URL: https://github.com/apache/trafficserver/issues/11170#issuecomment-200781 I have not seen this recently. I believe it is indeed likely that #1196 has fixed this. Closing. -- This is an automated message from the Apache Git Service. To respond

  1   2   3   4   5   6   7   8   9   10   >