Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-22 Thread Chris Harrelson
LGTM3 On Wed, Feb 21, 2024 at 9:01 PM Domenic Denicola wrote: > LGTM2 > > On Thu, Feb 22, 2024 at 5:20 AM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> LGTM1 >> >> Thanks for diving into the samples. Sounds like the breakage risk here is >> indeed low. >> >> On Wed, Feb 21, 2024

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-21 Thread Domenic Denicola
LGTM2 On Thu, Feb 22, 2024 at 5:20 AM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > LGTM1 > > Thanks for diving into the samples. Sounds like the breakage risk here is > indeed low. > > On Wed, Feb 21, 2024 at 8:15 PM Brad Triebwasser > wrote: > >> Sure, I checked 10 unique origins

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-21 Thread Yoav Weiss (@Shopify)
LGTM1 Thanks for diving into the samples. Sounds like the breakage risk here is indeed low. On Wed, Feb 21, 2024 at 8:15 PM Brad Triebwasser wrote: > Sure, I checked 10 unique origins (skipping duplicate pu707ev.com > subdomains which make up half of the sampled domains) listed in >

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-21 Thread Brad Triebwasser
Sure, I checked 10 unique origins (skipping duplicate pu707ev.com subdomains which make up half of the sampled domains) listed in https://chromestatus.com/metrics/feature/timeline/popularity/4448. 4 of them reference: https://cdn.jsdelivr.net/gh/cffgnu/qhdd/asset/responsive.min.js. I won't post

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-20 Thread Yoav Weiss (@Shopify)
On Tuesday, February 20, 2024 at 8:32:33 PM UTC+1 Brad Triebwasser wrote: [Premature Send. Full message below] We are tracking UMA for when the permission name "window-placement" is parsed (e.g all calls to navigator.permissions.query({name: 'window-placement'}) increment the counter. That

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-20 Thread Yoav Weiss (@Shopify)
On Tue, Feb 20, 2024 at 4:56 PM Vladimir Levin wrote: > > > On Mon, Feb 19, 2024 at 12:10 PM Yoav Weiss (@Shopify) < > yoavwe...@chromium.org> wrote: > >> >> >> On Fri, Feb 16, 2024 at 8:19 PM Brad Triebwasser >> wrote: >> >>> Usage for the legacy permission and permission policy are ~0.006 >>>

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-20 Thread Brad Triebwasser
[Premature Send. Full message below] We are tracking UMA for when the permission name "window-placement" is parsed (e.g all calls to navigator.permissions.query({name: 'window-placement'}) increment the counter. That function will throw an exception *"The provided value 'window-placement' is not

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-20 Thread Brad Triebwasser
Certainly. We are tracking UMA both for when the permission name "window-placement" is parsed (e.g all calls to navigator.permissions.query({name: 'window-placement'}) increment the counter. That function will throw an exception *"The provided value 'window-placement' is not a valid enum value

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-20 Thread Vladimir Levin
On Mon, Feb 19, 2024 at 12:10 PM Yoav Weiss (@Shopify) < yoavwe...@chromium.org> wrote: > > > On Fri, Feb 16, 2024 at 8:19 PM Brad Triebwasser > wrote: > >> Usage for the legacy permission and permission policy are ~0.006 >> and

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-19 Thread Yoav Weiss (@Shopify)
On Fri, Feb 16, 2024 at 8:19 PM Brad Triebwasser wrote: > Usage for the legacy permission and permission policy are ~0.006 > and > ~0.015 > Can you detail what

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-16 Thread Brad Triebwasser
Usage for the legacy permission and permission policy are ~0.006 and ~0.015 (% page loads) while the new variants are ~1.166

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-15 Thread Yoav Weiss (@Shopify)
200 origins sounds like a lot. Do you know what %age of page views those origins would represent? On Wed, Feb 14, 2024 at 11:32 PM Brad Triebwasser wrote: > *tl;dr:* We expect at most 200 origins could break, and only ~30 of those > may be legitimately using the API. > > We do track UMA/UKM for

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-14 Thread Brad Triebwasser
*tl;dr:* We expect at most 200 origins could break, and only ~30 of those may be legitimately using the API. We do track UMA/UKM for the primary API entrypoint function ( GetScreenDetails ) which we expect nearly all

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-12 Thread Mike Taylor
Agree that the risk feels low... one thing to perhaps check for (if you have UKM or use counters) is to see if there is any legit usage on sites of `navigator.permissions.query()` that isn't catching errors, since that will throw a TypeError and can break a page. On 2/12/24 9:16 AM, Rick

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-12 Thread Rick Byers
Presumably the risk of legitimate breakage here is bounded by the use of the Window Management API, right? Are there any UseCounters for the various Window Management operations? I couldn't find any at a quick glance. I imagine legitimate usage is dominated by a few sites with an obvious need (do

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-07 Thread Brad Triebwasser
+blink-dev@chromium.org / Reply All Thanks for your feedback, Mike! Recipes inline: > > On Tue, Feb 6, 2024 at 9:36 PM Mike Taylor wrote: > >> Hi Brad, >> On 2/6/24 3:49 PM, Brad Triebwasser wrote: >> >> Contact emails >> >> btri...@chromium.org >> >> Explainer >> >> >>

Re: [blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-06 Thread Mike Taylor
Hi Brad, On 2/6/24 3:49 PM, Brad Triebwasser wrote: Contact emails btri...@chromium.org Explainer https://github.com/w3c/window-management/blob/main/EXPLAINER_spec_and_permission_rename.md

[blink-dev] Intent to Ship: Remove "window-placement" alias for permission and permission policy "window-management"

2024-02-06 Thread Brad Triebwasser
Contact emails btri...@chromium.org Explainer https://github.com/w3c/window-management/blob/main/EXPLAINER_spec_and_permission_rename.md Specification https://w3c.github.io/window-management/#api-permission-api-integration Summary Removes the legacy "window-placement" alias for permission