Re: RFR: 8295010: Reduce if required in EC limbs operations [v4]

2022-10-13 Thread Xue-Lei Andrew Fan
> Hi, > > May I have this update reviewed? With this update, the result will be > reduced if required in EC limbs operations in the JDK implementation. > > In the current implementation, the EC limbs addition and subtraction result > is not reduced before the value is returned. This behavior

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-13 Thread Vladimir Ivanov
On Thu, 13 Oct 2022 07:47:20 GMT, Andrew Haley wrote: > The problem is that this bug is very insidious: the user probably doesn't > know that there's anything wrong, and almost certainly has no idea that it's > anything to do with JNI. I'm still trying to grasp why the current problem is somet

Re: RFR: 8295262: Build binutils out of source tree [v2]

2022-10-13 Thread Aleksey Shipilev
On Thu, 13 Oct 2022 08:41:35 GMT, Ludovic Henry wrote: >> Currently, when passing --with-binutils-src, binutils is built in the source >> tree. That leads to conflicting targets when compiling for different >> architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target) >> from

Re: RFR: 8295262: Build binutils out of source tree [v2]

2022-10-13 Thread Erik Joelsson
On Thu, 13 Oct 2022 08:41:35 GMT, Ludovic Henry wrote: >> Currently, when passing --with-binutils-src, binutils is built in the source >> tree. That leads to conflicting targets when compiling for different >> architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target) >> from

Re: RFR: 8295262: Build binutils out of source tree [v2]

2022-10-13 Thread Aleksey Shipilev
On Thu, 13 Oct 2022 08:41:35 GMT, Ludovic Henry wrote: >> Currently, when passing --with-binutils-src, binutils is built in the source >> tree. That leads to conflicting targets when compiling for different >> architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target) >> from

Re: RFR: 8294314: Minimize disabled warnings in hotspot [v9]

2022-10-13 Thread Aleksey Shipilev
On Wed, 12 Oct 2022 11:07:36 GMT, Aleksey Shipilev wrote: > > @shipilev In a "tenth time's the charm" spirit, here's what I do think is > > actually a PR that can be integrated. > > Cool! I'll try to schedule the overnight build-matrix run to see if anything > is broken. I was able to build t

Re: RFR: 8294314: Minimize disabled warnings in hotspot [v21]

2022-10-13 Thread Aleksey Shipilev
On Wed, 12 Oct 2022 11:04:14 GMT, Magnus Ihse Bursie wrote: >> After [JDK-8294281](https://bugs.openjdk.org/browse/JDK-8294281), it is now >> possible to disable warnings for individual files instead for whole >> libraries. I used this opportunity to go through all disabled warnings in >> hots

Re: RFR: 8295262: Build binutils out of source tree [v2]

2022-10-13 Thread Ludovic Henry
On Thu, 13 Oct 2022 07:56:09 GMT, Aleksey Shipilev wrote: >> Ludovic Henry has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains three additional >> c

Re: RFR: 8295262: Build binutils out of source tree [v2]

2022-10-13 Thread Ludovic Henry
> Currently, when passing --with-binutils-src, binutils is built in the source > tree. That leads to conflicting targets when compiling for different > architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target) > from the same jdk source tree. > > The simplest solution is to b

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-13 Thread Andrew Haley
On Wed, 12 Oct 2022 17:00:15 GMT, Andrew Haley wrote: >> A bug in GCC causes shared libraries linked with -ffast-math to disable >> denormal arithmetic. This breaks Java's floating-point semantics. >> >> The bug is https://gcc.gnu.org/bugzilla/show_bug.cgi?id=55522 >> >> One solution is to sav

Re: RFR: 8295262: Build binutils out of source tree

2022-10-13 Thread Aleksey Shipilev
On Thu, 13 Oct 2022 07:43:33 GMT, Ludovic Henry wrote: > Currently, when passing --with-binutils-src, binutils is built in the source > tree. That leads to conflicting targets when compiling for different > architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target) > from the

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-13 Thread Andrew Haley
On Wed, 12 Oct 2022 20:26:34 GMT, Jorn Vernee wrote: > Following that logic: from our perspective `dlopen` violates its ABI in > certain cases. Preserving the control bits across calls to `dlopen` seems > like a pragmatic solution. I'm not sure how important it is to have an opt-in > for the c

Re: RFR: 8295159: DSO created with -ffast-math breaks Java floating-point arithmetic [v7]

2022-10-13 Thread Andrew Haley
On Wed, 12 Oct 2022 20:35:09 GMT, Maurizio Cimadamore wrote: > Isn't it an illustration of a more general problem we have with native code > where it can mess with FP environment at any time? Yes. > We already have similar problems with MXCSR register and provide verification > logic (part o

RFR: 8295262: Build binutils out of source tree

2022-10-13 Thread Ludovic Henry
Currently, when passing --with-binutils-src, binutils is built in the source tree. That leads to conflicting targets when compiling for different architectures (ex: amd64 on the host, and riscv64 or aarch64 for the target) from the same jdk source tree. The simplest solution is to build binutil

Re: RFR: 8293422: DWARF emitted by Clang cannot be parsed [v4]

2022-10-13 Thread Christian Hagedorn
On Wed, 12 Oct 2022 14:28:02 GMT, Magnus Ihse Bursie wrote: > If is is a big change or not depends on how it affects builds on macos. I > assume that clang functionality that was published in 2017 is already > incorporated in the minimum supported version of Xcode on mac. (This needs to > be v