On Thu, 11 Jul 2024 16:19:49 GMT, Chen Liang wrote:
> Please review this build-only change that fixes the link to the SVG sealed
> graph by the `@sealedGraph` javadoc taglet. This affects JDK 23 ea
> documentation (as shown in #20122) and thus is backported.
Marked as reviewed by prappo
On Fri, 7 Jun 2024 19:01:45 GMT, Sonia Zaldana Calles
wrote:
> Hi all,
>
> This PR addresses [8333685](https://bugs.openjdk.org/browse/JDK-8333685).
>
> I have added the following enhancements:
> - Removed uses of `fgrep` and `egrep` with `grep -F` and `grep -E`
> respectively.
> -
On Mon, 20 May 2024 20:17:10 GMT, Jonathan Gibbons wrote:
> Please review a small fix to address a crash when handling HTML5 entities in
> a Markdown doc comment.
>
> The path for the `entities.txt` (originally `entities.properties`) was not
> correctly imported when importing the latest
On Thu, 16 May 2024 14:53:17 GMT, Chen Liang wrote:
> My rationale for a potential preview is that we changed
> `-Xlint:dangling-doc-comments` as `///` is now dangling doc comment. Is this
> considered a Java programming language change? There were some community
> comments objecting the use
On Wed, 15 May 2024 21:04:36 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Thu, 16 May 2024 13:05:39 GMT, Chen Liang wrote:
> A meta question about the JEP: Why don't Javadoc features (like snippets and
> markdown comments) don't go through preview, while Compiler features mostly
> do? Is there any bar for previews?
Jon could probably reply more substantially,
On Wed, 15 May 2024 21:04:36 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Tue, 7 May 2024 17:31:29 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Mon, 8 Apr 2024 21:12:42 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons wrote:
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible
On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons wrote:
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible
On Wed, 27 Mar 2024 22:04:30 GMT, Jonathan Gibbons wrote:
> Please review the updates to support a proposed new
> `-Xlint:dangling-doc-comments` option.
>
> The work can be thought of as in 3 parts:
>
> 1. An update to the `javac` internal class `DeferredLintHandler` so that it
> is possible
On Mon, 4 Mar 2024 14:40:06 GMT, Pavel Rappo wrote:
> I have a test case to report. The following results in no `@param`
> information being rendered, which I think is a bug:
>
> ```
> /// Hello, _Markdown_ world!
> ///
> ///
> /// @param hello
>
On Fri, 1 Mar 2024 21:49:29 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Fri, 16 Feb 2024 07:42:47 GMT, Hannes Wallnöfer wrote:
>> Jonathan Gibbons has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Support for Table Of Contents in Markdown headings
>> - fix typo
>
>
On Thu, 15 Feb 2024 19:39:07 GMT, Pavel Rappo wrote:
>> whitespace is handled separately, on line 280 (`readIndent`) and285 (`:
>> (indent <= 3) ? peekLineKind()`)
>
> Correct, but I believe the ordered list marker should be like this:
>
> ORDERED_LIST_ITEM
On Thu, 15 Feb 2024 19:20:23 GMT, Jonathan Gibbons wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
>> line 1401:
>>
>>> 1399: */
>>> 1400: enum LineKind {
>>> 1401: BLANK(Pattern.compile("[ \t]*")),
>>
>> `BLANK` is a pseudo kind,
On Thu, 15 Feb 2024 00:30:25 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Mon, 12 Feb 2024 23:52:35 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Fri, 9 Feb 2024 22:17:43 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Mon, 12 Feb 2024 16:29:19 GMT, Jonathan Gibbons wrote:
> I guess it depends how much we want to import the code as-is, without knowing
> any lint-warts.
I think it would be nice not to have to modify code beyond superficial edits:
addition of headers, renaming of packages, and converting
On Thu, 8 Feb 2024 18:52:54 GMT, Jonathan Gibbons wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/markup/RawHtml.java
>> line 145:
>>
>>> 143: }
>>> 144:
>>> 145: Pattern tag = Pattern.compile("<(?[A-Za-z0-9]+)(\\s|>)");
>>
>> I'm not sure I grok
On Tue, 30 Jan 2024 23:47:00 GMT, Jonathan Gibbons wrote:
>> src/jdk.internal.md/share/classes/jdk/internal/markdown/MarkdownTransformer.java
>> line 771:
>>
>>> 769: copyTo(getStartPos(link));
>>> 770: // push temporary value for {@code trees} while
>>>
On Thu, 1 Feb 2024 00:19:42 GMT, Jonathan Gibbons wrote:
>> I'll add a test case.
>
> Done
Thank you. I double-checked: if that `replace` is removed,
jdk/javadoc/doclet/testMarkdown/TestMarkdown.java fails.
-
PR Review Comment:
On Wed, 31 Jan 2024 22:15:23 GMT, Jonathan Gibbons wrote:
>> I guess I don't see this as being as big a deal as you seem to think it is.
>> What is it that you are so concerned about?
>>
>> I also think it is a potential feature to document and use reference links
>> with `code:` URLs, using
On Tue, 30 Jan 2024 23:15:32 GMT, Jonathan Gibbons wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DocTreeMaker.java
>> line 790:
>>
>>> 788:
>>> 789: // end of paragraph is newline, followed by a blank line or
>>> the beginning of the next block
>>> 790:
On Thu, 8 Feb 2024 15:38:26 GMT, Pavel Rappo wrote:
>> test/langtools/jdk/javadoc/tool/sampleapi/lib/sampleapi/generator/ModuleGenerator.java
>> line 49:
>>
>>> 47: import sampleapi.util.PoorDocCommentTable;
>
On Thu, 8 Feb 2024 21:46:34 GMT, Jonathan Gibbons wrote:
>> I believe this is substantially covered in line 226-227. See the third call
>> to `test` in the following group of lines:
>>
>>
>> for (String src : sources) {
>> test(src);
>>
On Tue, 23 Jan 2024 13:02:46 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upst
On Wed, 15 Nov 2023 00:37:06 GMT, Jonathan Gibbons wrote:
>> test/langtools/jdk/javadoc/tool/testTransformer/TestTransformer.java line 96:
>>
>>> 94: var sl =
>>> ServiceLoader.load(DocTrees.DocCommentTreeTransformer.class);
>>> 95: return StreamSupport.stream(sl.spliterator(),
On Thu, 8 Feb 2024 15:35:58 GMT, Pavel Rappo wrote:
>> Please update the DocComment printout in that commented out test: the actual
>> content is different. It would be nice if the test were passing at least at
>> the moment of its initial commit.
>>
>
On Mon, 29 Jan 2024 23:50:25 GMT, Jonathan Gibbons wrote:
>> Probably, yes.
>
> New class comment added.
I can see it and it reads nicely; thanks!
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1484586216
On Tue, 30 Jan 2024 00:47:33 GMT, Jonathan Gibbons wrote:
> > Musing on this more.
> > Can/should we, without introducing probably unwelcome `Kind.MD` to
> > `javax.tools.JavaFileObject.Kind`, teach javac to recognise `package.md`
> > similarly to how it recognises legacy `package.html`? If we
On Mon, 29 Jan 2024 23:34:24 GMT, Jonathan Gibbons wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/DocCommentParser.java
>> line 215:
>>
>>> 213: case '\n', '\r' -> {
>>> 214: return newString(bp, p);
>>> 215: }
>>
>>
On Wed, 7 Feb 2024 18:14:24 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Tue, 30 Jan 2024 21:37:10 GMT, Jonathan Gibbons wrote:
>> src/jdk.compiler/share/classes/com/sun/tools/javac/parser/JavaTokenizer.java
>> line 1065:
>>
>>> 1063:
>>> 1064: if (accept('/')) { // (Spec. 3.7)
>>> 1065: if (accept('/')) { // Markdown
On Thu, 11 Jan 2024 15:07:33 GMT, Pavel Rappo wrote:
>> test/langtools/tools/javac/classfiles/attributes/deprecated/DeprecatedTest.java
>> line 26:
>>
>>> 24: /*
>>> 25: * @test
>>> 26: * @bug 8042261 8298405
>>
>> This
On Wed, 8 Nov 2023 17:17:46 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains 28 commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into
>&
On Wed, 7 Feb 2024 18:14:24 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Fri, 19 Jan 2024 18:37:48 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Fri, 19 Jan 2024 18:37:48 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Fri, 19 Jan 2024 18:37:48 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Tue, 23 Jan 2024 12:22:19 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge with upstream/master
>> - Merge with upst
On Fri, 19 Jan 2024 18:37:48 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Fri, 19 Jan 2024 18:37:48 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Fri, 19 Jan 2024 18:37:48 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Fri, 12 Jan 2024 17:47:06 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Mon, 8 Jan 2024 21:26:50 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Mon, 8 Jan 2024 21:26:50 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Mon, 8 Jan 2024 21:26:50 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Mon, 8 Jan 2024 21:26:50 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Wed, 15 Nov 2023 18:48:59 GMT, Jonathan Gibbons wrote:
>> Hmm. teeny-tiny "yes", dominated by a big "BUT".
>>
>> There is no easy simple direct support for Markdown in user-defined taglets,
>> since there is no way to know the syntactic form of user-defined tags. We
>> might be able to
On Wed, 8 Nov 2023 16:24:20 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Wed, 15 Nov 2023 00:21:10 GMT, Jonathan Gibbons wrote:
> the output with the break iterator is now the same as the default simple
> iterator
I can confirm that. Thanks.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/16388#discussion_r1448993923
On Thu, 11 Jan 2024 12:29:01 GMT, Magnus Ihse Bursie wrote:
> @pavelrappo
>
> > I've run the updated script on JDK. The script found 8 missorted sealed and
> > 20 missorted default. The script also found 3 false positive default:[...]
> > None of those findings are addressed in this PR.
>
>
On Wed, 8 Nov 2023 15:57:14 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contain
On Wed, 3 Jan 2024 12:09:42 GMT, Pavel Rappo wrote:
> Please review this PR to update `blessed-modifier.order.sh` for the
> `default`, `sealed`, `non-sealed`, and `strictfp` modifiers.
>
> In a [discussion][] preceding this PR, it was agreed that the script should
> better re
On Wed, 15 Nov 2023 18:58:43 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Thu, 4 Jan 2024 07:15:32 GMT, Martin Buchholz wrote:
> Thanks ... now I see ...
FWIW, @jddarcy thinks we can still improve `Modifier.toString(int)`. See this
comment and its parent thread:
https://github.com/openjdk/jdk/pull/17239#discussion_r1441050656
-
PR Review Comment:
On Wed, 3 Jan 2024 17:16:37 GMT, Martin Buchholz wrote:
> it also needs a corresponding update
> https://download.java.net/java/early_access/jdk23/docs/api/java.base/java/lang/reflect/Modifier.html#toString(int)
>From the preceding discussion, it follows that it cannot be done:
Please review this PR to update `blessed-modifier.order.sh` for the `default`,
`sealed`, `non-sealed`, and `strictfp` modifiers.
In a [discussion][] preceding this PR, it was agreed that the script should
better refer to relevant JLS sections rather than to
On Tue, 28 Nov 2023 14:32:14 GMT, Pavel Rappo wrote:
> Please review this PR to support _JEP 463 Implicitly Declared Classes and
> Instance Main Method (Second Preview)_ in JavaDoc.
>
> [JEP 463](https://openjdk.org/jeps/463) is the next iteration of [JEP
> 445](https://openj
Please review this PR to support _JEP 463 Implicitly Declared Classes and
Instance Main Method (Second Preview)_ in JavaDoc.
[JEP 463](https://openjdk.org/jeps/463) is the next iteration of [JEP
445](https://openjdk.org/jeps/445), which introduced the ability to have a
source file as a
On Wed, 8 Nov 2023 22:17:21 GMT, Jonathan Gibbons wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comments in `JavaTokenizer`
>> * new module
On Wed, 8 Nov 2023 17:25:36 GMT, Pavel Rappo wrote:
>> Please review a patch to add support for Markdown syntax in documentation
>> comments, as described in the associated JEP.
>>
>> Notable features:
>>
>> * support for `///` documentation comment
On Thu, 26 Oct 2023 23:29:00 GMT, Jonathan Gibbons wrote:
> Please review a patch to add support for Markdown syntax in documentation
> comments, as described in the associated JEP.
>
> Notable features:
>
> * support for `///` documentation comments in `JavaTokenizer`
> * new module
On Tue, 22 Aug 2023 11:09:39 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
This pull request has now been integrated.
Changeset: a4e97aa4
Author: Pavel Rappo
URL:
https://git.openjdk.org/jdk/commit/a4e97aa4ebe6fcfc3ed9e45ed81df1d55e52d621
Stats: 4 lines in 1 f
On Tue, 22 Aug 2023 12:19:42 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
This pull request has now been integrated.
Changeset: 0901d75e
Author: Pavel Rappo
URL:
https://git.openjdk.org/jdk/commit/0901d75e074322c5a8d55e3c72c4cba4291fb00c
Stats: 6 lines in 3 fi
On Tue, 22 Aug 2023 14:55:18 GMT, Pavel Rappo wrote:
>> Please review this trivial PR.
>
> Pavel Rappo has updated the pull request with a new target base due to a
> merge or a rebase. The pull request now contains two commits:
>
> - Merge branch 'master' into 831475
> Please review this trivial PR.
Pavel Rappo has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains two commits:
- Merge branch 'master' into 8314753
- Initial commit
-
Changes: https://git.openjdk.org/jdk/pull/15385/fi
On Tue, 22 Aug 2023 08:42:32 GMT, Pavel Rappo wrote:
> Please review this simple PR.
This pull request has now been integrated.
Changeset: f39fc0aa
Author: Pavel Rappo
URL:
https://git.openjdk.org/jdk/commit/f39fc0aa2de19332fa51af605ece0660891d8c7a
Stats: 124 lines in 28 fi
On Tue, 22 Aug 2023 12:23:18 GMT, Mark Reinhold wrote:
> I wouldn’t update the copyright year as you have in some of these files.
I was taught to do it every time when I change a file. Would you like me to
revert those changes to copyright years in this case?
-
PR Comment:
Please review this trivial PR.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/15387/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15387=00
Issue: https://bugs.openjdk.org/browse/JDK-8314762
Stats: 6 lines in 3 files changed: 0 ins; 0 del; 6
On Tue, 22 Aug 2023 11:09:39 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
CC'ing client-libs-dev because @beaninfo and @Note and jmx-dev because of
@since.unbundled, which might've been used for JMX before 2007.
-
PR Comment: https://git.openjdk.org/jdk/pull/15
On Tue, 22 Aug 2023 11:09:39 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
CC'ing core-libs-dev whose members might also have some recollection on tags in
question.
-
PR Comment: https://git.openjdk.org/jdk/pull/15385#issuecomment-1687995105
On Tue, 22 Aug 2023 11:09:39 GMT, Pavel Rappo wrote:
> Please review this trivial PR.
CC'ing client-libs-dev because `@beaninfo` and `@Note` and jmx-dev because of
`@since.unbundled`, which might've been used for JMX before 2007.
-
PR Comment: https://git.openjdk.org/jdk/p
Please review this trivial PR.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/15385/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15385=00
Issue: https://bugs.openjdk.org/browse/JDK-8314753
Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0
Please review this simple PR.
-
Commit messages:
- Initial commit
Changes: https://git.openjdk.org/jdk/pull/15382/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=15382=00
Issue: https://bugs.openjdk.org/browse/JDK-8314738
Stats: 124 lines in 28 files changed: 0 ins; 116
On Mon, 26 Jun 2023 14:07:03 GMT, Pavel Rappo wrote:
> Please review this cleanup PR to normalize names of identifiers which are
> Java variables/fields or tokens in text files. Those names either contain a
> pronoun that is very rarely used in code, or seem like they contain such a
On Mon, 26 Jun 2023 18:44:42 GMT, Pavel Rappo wrote:
>> make/data/charsetmapping/charsets line 149:
>>
>>> 147: package sun.nio.cs
>>> 148: typesbcs
>>> 149: histname ISO8859_2
>>
>> Should this column be re-aligned with the lo
On Mon, 26 Jun 2023 18:31:06 GMT, Jens Lidestrom wrote:
>> Please review this cleanup PR to normalize names of identifiers which are
>> Java variables/fields or tokens in text files. Those names either contain a
>> pronoun that is very rarely used in code, or seem like they contain such a
>>
On Mon, 26 Jun 2023 18:21:07 GMT, Roger Riggs wrote:
>> Please review this cleanup PR to normalize names of identifiers which are
>> Java variables/fields or tokens in text files. Those names either contain a
>> pronoun that is very rarely used in code, or seem like they contain such a
>>
Please review this cleanup PR to normalize names of identifiers which are Java
variables/fields or tokens in text files. Those names either contain a pronoun
that is very rarely used in code, or seem like they contain such a pronoun,
which, in fact, they don't. Either way, the goal is to
It appears that the error is coming from make/SourceRevision.gmk
> On 26 Jun 2023, at 13:55, Alan Snyder wrote:
>
> It would be very unlikely for CCC to fail to correctly clone the directory.
>
> It would be helpful to know what the build tool is complaining about with
> that message.
>
>>
On Thu, 2 Mar 2023 12:03:44 GMT, Pavel Rappo wrote:
> Please review this superficial documentation cleanup that was triggered by
> unrelated analysis of doc comments in JDK API.
>
> The only effect that this multi-area PR has on the JDK API Documentation
> (i.e. the ob
to occur in infrequently updated third-party code (e.g.
> javax.xml), which I assume we shouldn't touch unless necessary.
> * I will update copyright years after (and if) the fix had been approved, as
> required.
Pavel Rappo has updated the pull request with a new target base due to a
On Fri, 3 Mar 2023 08:15:49 GMT, Alexey Ivanov wrote:
>> Please review this superficial documentation cleanup that was triggered by
>> unrelated analysis of doc comments in JDK API.
>>
>> The only effect that this multi-area PR has on the JDK API Documentation
>> (i.e. the observable effect
On Thu, 2 Mar 2023 16:23:17 GMT, Alexey Ivanov wrote:
>> Please review this superficial documentation cleanup that was triggered by
>> unrelated analysis of doc comments in JDK API.
>>
>> The only effect that this multi-area PR has on the JDK API Documentation
>> (i.e. the observable effect
Please review this superficial documentation cleanup that was triggered by
unrelated analysis of doc comments in JDK API.
The only effect that this multi-area PR has on the JDK API Documentation (i.e.
the observable effect on the generated HTML pages) can be summarized as follows:
diff
On Thu, 8 Dec 2022 16:22:30 GMT, Jonathan Gibbons wrote:
>> make/jdk/src/classes/build/tools/taglet/SealedGraph.java line 207:
>>
>>> 205: private static String relativeLink(TypeElement rootNode,
>>> TypeElement node) {
>>> 206: var backNavigator =
>>>
On Thu, 8 Dec 2022 09:19:54 GMT, Per Minborg wrote:
> This PR proposes adding hyperlinks to the sealed graphic layout making
> navigation much simpler via the image.
Given that this feature is welcome, I would suggest changing the priority of
the respective JBS issue to P3, withdrawing this
91 matches
Mail list logo
