Re: [PATCH v2] bloat-o-meter: line wrapped at 75 columns instead of 80

2024-03-14 Thread Bernhard Reutner-Fischer
On Mon, 11 Mar 2024 18:39:33 +0800 Kang-Che Sung wrote: > I was curious. Is there a reason for BusyBox's bloat-o-meter script not to > keep in sync with the version that comes in the Linux kernel source? > > I occasionally use the bloat-o-meter from the Linux kernel to compare even > BusyBox

Re: [PATCH] awk: fix segfault when compiled by clang

2024-03-02 Thread Bernhard Reutner-Fischer
On Fri, 19 Jan 2024 15:41:17 + Ron Yorston wrote: > A 32-bit build of BusyBox using clang segfaulted in the test > "awk assign while assign". Specifically, on line 7 of the test > input where the adjustment of the L.v pointer when the Fields > array was reallocated > > L.v += Fields

Re: [V2 PATCH] crond: log5 fix typo, replace log level '4' with '5'

2024-03-02 Thread Bernhard Reutner-Fischer
On Thu, 1 Feb 2024 03:17:09 + Jones Syue 薛懷宗 wrote: > Found previous patch accidentally adds 'x' permission to file 'crond.c', > attached v2 patch would not change permissions of file 'crond.c', > thank you :) Applied, thanks! ___ busybox mailing

Re: fix large PID overflow their column in top command

2024-02-21 Thread Bernhard Reutner-Fischer
arches. Many thanks in advance and cheers, Bernhard > > Br-Matthew > > > From: Bernhard Reutner-Fischer > Sent: Thursday, February 15, 2024 9:46 PM > To: Matthew Chae > Cc: rep.dot@gmail.com ; David Laight > ; 'Denys Vlasenko' ; > busybox@

Re: fix large PID overflow their column in top command

2024-02-15 Thread Bernhard Reutner-Fischer
y reusing it elsewhere, as a follow-up. thanks > Can you review these and give me your thoughts? > Just let me know if you think that the code size needs to be reduced. > > Br-Matthew > ____ > From: Bernhard Reutner-Fischer > Sent: Tuesday, February

Re: fix large PID overflow their column in top command

2024-02-13 Thread Bernhard Reutner-Fischer
On Mon, 5 Feb 2024 09:56:20 + Matthew Chae wrote: > Hi David, > > I'm sending an improved patch based on your comments. > > Not only does it not care about the PID_MAX value, > it searches all the contents to be output to recognize the required column > width > and dynamically allocates

Re: [RFC PATCH] ip link: support for the CAN netlink

2023-05-06 Thread Bernhard Reutner-Fischer
On 30 April 2023 11:52:26 CEST, Dario Binacchi wrote: >Hi Nikolaus, > >On Thu, Apr 27, 2023 at 11:28 AM Nikolaus Voss wrote: >> >> Hi Dario, >> >> I posted a more minimalistic approach > >This is the reason why I added the CONFIG_IPLINK_CAN option. >Anyway, I think we both agree that busybox

Re: Busybox hwclock implement set/get RTC params

2023-05-06 Thread Bernhard Reutner-Fischer
On 4 May 2023 13:59:41 CEST, Primoz Fiser wrote: >2) If we invest time implementing hwlock set/get RTC params, would you >be willing to accept it? We would like to avoid developing a solution >that won't be accepted into busybox upstream. I think it makes sense, yes. > >3) At this stage,

Re: [PATCH v2] udhcp: add option to set CoS priority

2023-04-12 Thread Bernhard Reutner-Fischer
On Tue, 11 Apr 2023 22:58:00 +0200 Clément Péron wrote: > Hi Pacien, > > On Tue, 11 Apr 2023 at 00:54, pacien wrote: > > > > I worked on my own version of this, before seeing that this one was > > already posted to the list. Sorry for the collision. > > > > Message-Id:

Re: [PATCH] build system: clean more files on make clean

2023-04-12 Thread Bernhard Reutner-Fischer
Hi Tomas! Applied, thanks! On Sun, 09 Apr 2023 10:19:29 +0200 (CEST) "Tomas Paukrt" wrote: > From 57bf559403d89133197d33a2a181815d1f057b2b Mon Sep 17 00:00:00 2001 > From: Tomas Paukrt > Date: Sun, 9 Apr 2023 09:06:43 +0200 > Subject: [PATCH] build system: clean more files on make clean > >

Re: [PATCH] fixdep: avoid underflow when end of entry doesn't coincide with EOF

2023-02-23 Thread Bernhard Reutner-Fischer
Hi Arsen! On Tue, 21 Feb 2023 20:20:31 +0100 Arsen Arsenović wrote: > Bug: https://bugs.gentoo.org/893776 > Closes: https://bugs.busybox.net/show_bug.cgi?id=15326 > Signed-off-by: Arsen Arsenović > --- > Hi, > > This is a fix for the recently reported scandep-related build failure. > The

Re: [PATCH v1] miscutils/seedrng.c: fix include error on glibc < 2.25

2023-02-17 Thread Bernhard Reutner-Fischer
On 17 February 2023 19:39:08 CET, Thomas Devoogdt wrote: >From: Thomas Devoogdt > >getrandom() was introduced in version 3.17 of the Linux kernel. > Support was added to glibc in version 2.25. Yeah maybe. I'd strongly advise against that. YMMV. Just disable it then TBH? thanks,

Re: [PATCH][RFC] udhcp: add option to set CoS priority

2023-01-13 Thread Bernhard Reutner-Fischer
On Fri, 13 Jan 2023 10:55:26 +0100 Clément Péron wrote: > Hi, > > > On Fri, 13 Jan 2023 at 10:48, Clément Péron wrote: > > > > Some ISP, like the French ISP Orange uses DHCP messages with > > a CoS Priority of 6 otherwise they are not processed. > > > > Add an option to allow setting this

Re: busybox init returns fails with error code -1 (0x00007f00)

2022-10-26 Thread Bernhard Reutner-Fischer
> written. Using an emulator like qemu > -cdrom ../my.iso -m 512m or the > qemu-system-i386 variant that you target And yes, that's a bit exaggerated. In former times you could have plenty space left on a box with 2MB RAM even when running Linux. But, alas, nowadays the kernel alone occupies

Re: busybox init returns fails with error code -1 (0x00007f00)

2022-10-26 Thread Bernhard Reutner-Fischer
On 26 October 2022 03:02:47 CEST, Jeff Pohlmeyer wrote: >On Tue, Oct 25, 2022 at 3:57 PM samuel ammonius wrote: >> >> I have a simple ISO filesystem set up with busybox and grub. >> These are the commands I use in GRUB2 to start the system: >> >> grub> set root=(cd) >> grub> linux /boot/bzImage

Re: busybox init returns fails with error code -1 (0x00007f00)

2022-10-26 Thread Bernhard Reutner-Fischer
On 25 October 2022 22:55:44 CEST, samuel ammonius wrote: >(Also, Google supports filtering the results using "site:busybox.net >". You could just link to Google search instead of paying for >cse.google.com in this search bar ) That is using an API key i generated

Re: Why is busybox grep matching ^SOL after NUL?

2022-10-18 Thread Bernhard Reutner-Fischer
On Tue, 18 Oct 2022 05:45:02 -0500 Rob Landley wrote: > $ echo -e 'one\0two' | busybox grep -l ^t > (standard input) /* BB_AUDIT GNU defects - always acts as -a. */ $ man grep | grep -A5 "^\s*-z," -z, --null-data Treat input and output data as sequences of lines,

Re: [PATCH] memset 0 in obscure is optimized away by compiler

2022-10-01 Thread Bernhard Reutner-Fischer
On Sat, 1 Oct 2022 21:48:39 +0200 Bernhard Reutner-Fischer wrote: > On Wed, 16 Apr 2014 20:25:39 -0400 > > > That's exactly the situation here. The lifetime of the object being > > cleared by memset ends sufficiently close to the memset that the > > compiler is

Re: [PATCH] memset 0 in obscure is optimized away by compiler

2022-10-01 Thread Bernhard Reutner-Fischer
On Wed, 16 Apr 2014 20:25:39 -0400 > That's exactly the situation here. The lifetime of the object being > cleared by memset ends sufficiently close to the memset that the > compiler is able to achieve the same observable effects that would be > seen in the abstract machine without actually

Re: [PATCH v4] shell: exchange Dijkstra $(( )) evaluator..

2022-09-06 Thread Bernhard Reutner-Fischer
Hi Steffen, On Wed, 31 Aug 2022 01:43:26 +0200 Steffen Nurpmeso wrote: > The former implementation was not correct regarding whiteouts in > ?: conditional branches. The new one also parses a bit better, in > effect on equal level than bash with its recursive descendent parser. Please provide

Re: [PATCH v6 0/2] less: fully implement -R

2022-06-05 Thread Bernhard Reutner-Fischer
On 3 June 2022 21:17:54 CEST, FriendlyNeighborhoodShane wrote: >It's been almost 2 months since the original patch was submitted and a >few weeks since this final version was. But it hasn't received any kind of >a reply/feedback from the maintainers yet (and this seems to be the case >with quite

Re: [PATCH] su: support numeric UIDs with a -n flag

2022-05-14 Thread Bernhard Reutner-Fischer
On 10 May 2022 16:06:35 CEST, Michael Tokarev wrote: >10.05.2022 16:53, Michael Tokarev wrote: >.. >> Do you really want su there? Maybe setpriv will better suit your needs? > >Grrr, and setpriv in busybox does not support user/group settings at all... ;) Then adding support for setting user and

Re: [PATCH] su: support numeric UIDs with a -n flag

2022-05-12 Thread Bernhard Reutner-Fischer
On 10 May 2022 17:12:31 CEST, Laurent Bercot wrote: > For non-interactive applications of su with numeric uids, may I suggest >https://skarnet.org/software/s6/s6-applyuidgid.html ? Or simply write your own trivial "execas". Maybe something like

Re: [PATCH v2] seedrng: limit poolsize to 256 bytes and document flock() and fsync() usage

2022-05-02 Thread Bernhard Reutner-Fischer
On 2 May 2022 16:34:25 CEST, Michael Conrad wrote: >On 5/2/22 09:54, Bernhard Reutner-Fischer wrote: >> But why is the seeding being run only at S20, way after udev? > >It needs to be at least late enough for the persistent storage to be mounted, >which probably isn't t

Re: [PATCH v2] seedrng: limit poolsize to 256 bytes and document flock() and fsync() usage

2022-05-02 Thread Bernhard Reutner-Fischer
On Sun, 1 May 2022 18:35:00 +0200 Emmanuel Deloget wrote: > > There is also the case (that on my systems at least) udev > > initialisation reads from /dev/[u]random well before the S20 > > script loads any saved entropy. > > I've not tried to find out what the value is used for. > > I find at

Re: [PATCH v9] seedrng: import SeedRNG utility for kernel RNG seed files

2022-04-29 Thread Bernhard Reutner-Fischer
On Fri, 29 Apr 2022 18:35:54 +0200 Denys Vlasenko wrote: > Even partial removal of these complicated error paths > cuts down the size by ~10% It's one of those situations where all you would really want is spend 100b in the kernel to "credit" seed. Be it via /sys or the first bit of the write

Re: [PATCH] seedrng: code-golf even smaller

2022-04-24 Thread Bernhard Reutner-Fischer
On Thu, 21 Apr 2022 12:37:32 +0200 "Jason A. Donenfeld" wrote: > Since we're passing 0 as the timeout, we don't need safe_poll. Remove > cleanup at end of program, since OS does that, which lets us simplify > control flow. Factor repeated function calls into ternary loop. Applied, thanks!

Re: [PATCH] seedrng: prune header includes

2022-04-24 Thread Bernhard Reutner-Fischer
On Thu, 21 Apr 2022 14:34:29 +0200 "Jason A. Donenfeld" wrote: > I'm not a huge fan of this, but Bernhard seems to prefer it: since > libbb.h contains most the headers we use, we can remove them from > seedrng.c. Supposedly this helps with compile times, but I couldn't > actually detect a

[RFC,PATCH 1/1] new applet: stdbuf(1)

2022-04-20 Thread Bernhard Reutner-Fischer
/libstdbuf.so for uClibc libstdbuf.o is around 400b Signed-off-by: Bernhard Reutner-Fischer --- .gitignore| 1 + Makefile.custom | 26 + Makefile.flags| 2 + coreutils/libstdbuf.c | 125 ++ coreutils/stdbuf.c| 115

[RFC,PATCH 0/1] new applet: stdbuf(1)

2022-04-20 Thread Bernhard Reutner-Fischer
. Thoughts? Bernhard Reutner-Fischer (1): new applet: stdbuf(1) .gitignore| 1 + Makefile.custom | 26 + Makefile.flags| 2 + coreutils/libstdbuf.c | 125 ++ coreutils/stdbuf.c| 115

Re: [PATCH] vi: fix backspace over tab in commands

2022-04-20 Thread Bernhard Reutner-Fischer
On Wed, 20 Apr 2022 09:23:30 +0100 Ron Yorston wrote: > Colon and search commands are entered on the status line. Since > the cursor position wasn't being tracked backspacing over a tab > resulted in a mismatch between the actual and apparent content > of the command. Applied, thanks!

Re: [PATCH v9] seedrng: import SeedRNG utility for kernel RNG seed files

2022-04-20 Thread Bernhard Reutner-Fischer
Hi Jason! On Tue, 19 Apr 2022 12:50:05 +0200 "Jason A. Donenfeld" wrote: > The RNG can't actually be seeded from a shell script, due to the > reliance on ioctls and the fact that entropy written into the > unprivileged /dev/urandom device is not immediately mixed in, making > subsequent seed

Re: [PATCH v8] seedrng: import SeedRNG utility for kernel RNG seed files

2022-04-19 Thread Bernhard Reutner-Fischer
On Tue, 19 Apr 2022 12:24:05 +0200 "Jason A. Donenfeld" wrote: > On Tue, Apr 19, 2022 at 11:33 AM Bernhard Reutner-Fischer > wrote: > > I was not refering to the startup scripts but to the possibility that > > we read data from the path /dev/random, close the fd and

Re: [PATCH v8] seedrng: import SeedRNG utility for kernel RNG seed files

2022-04-19 Thread Bernhard Reutner-Fischer
On Tue, 19 Apr 2022 08:48:50 + David Laight wrote: > > So to go back to the underlying issue. > > In v8 we cannot guarantee that we really got a seed from > > the kernel, let alone trustworthy. It could have been data from about > > any file, including /dev/zero or other unhelpful, no-random

Re: [PATCH v8] seedrng: import SeedRNG utility for kernel RNG seed files

2022-04-19 Thread Bernhard Reutner-Fischer
On Tue, 12 Apr 2022 21:07:36 +0200 "Jason A. Donenfeld" wrote: > Hi Bernhard, > > On Tue, Apr 12, 2022 at 8:37 PM Bernhard Reutner-Fischer > wrote: > > > > Hi Jason! > > I'm a bit surprised that even if i give -n the seed is moved to > > se

Re: [PATCH v8] seedrng: import SeedRNG utility for kernel RNG seed files

2022-04-14 Thread Bernhard Reutner-Fischer
-- (add/remove: 0/1 grow/shrink: 1/1 up/down: 280/-542) Total: -262 bytes $ size */seedrng.o* textdata bss dec hex filename 1900 0 01900 76c util-linux/seedrng.o.v8 1658 0 01658 67a util-linux/seed

Re: [PATCH v2] seedrng: import SeedRNG utility for kernel RNG seed files

2022-04-10 Thread Bernhard Reutner-Fischer
> > For example, in read_new_seed() we probably don't need the errno=EIO, > > for the user it should be sufficient to > > bb_simple_error_msg("unable to read new seed"); i suppose? > > Not a huge fan of that, but okay, sure. bb_simple_perror_msg should > suppress errno=0 "Success" messages

Re: [PATCH v2] seedrng: import SeedRNG utility for kernel RNG seed files

2022-04-10 Thread Bernhard Reutner-Fischer
On Sun, 10 Apr 2022 17:39:50 +0200 "Jason A. Donenfeld" wrote: > Hi Bernhard, > > On Sun, Apr 10, 2022 at 5:29 PM Bernhard Reutner-Fischer > wrote: > > > > Also seed_dir et al are only used in main so i'd move them there and > > > > not have th

Re: [PATCH v2] seedrng: import SeedRNG utility for kernel RNG seed files

2022-04-10 Thread Bernhard Reutner-Fischer
On Sun, 10 Apr 2022 15:56:17 +0200 "Jason A. Donenfeld" wrote: > Hi Bernhard, > > On Sun, Apr 10, 2022 at 3:40 PM Bernhard Reutner-Fischer > wrote: > > Also seed_dir et al are only used in main so i'd move them there and > > not have them static. D

Re: [PATCH v2] seedrng: import SeedRNG utility for kernel RNG seed files

2022-04-10 Thread Bernhard Reutner-Fischer
On Sun, 10 Apr 2022 14:43:16 +0200 "Jason A. Donenfeld" wrote: > > mkdir: bb_make_directory > > This one wasn't so useful: I don't actually want _recursive_ directory > creation, I don't think. Probably. But it doesn't harm either. And if it saves size it's preferable. Also seed_dir et al

Re: [PATCH v2] seedrng: import SeedRNG utility for kernel RNG seed files

2022-04-10 Thread Bernhard Reutner-Fischer
Hi! On 5 April 2022 01:23:38 CEST, "Jason A. Donenfeld" wrote: >This commit imports it into Busybox and wires up the basic config. The >utility itself is tiny, and unlike the example code from the SeedRNG >project, we can re-use libbb's existing hash functions, rather than >having to ship a

Re: arping: alarm() vs ualarm()

2022-04-10 Thread Bernhard Reutner-Fischer
On 7 April 2022 13:38:48 CEST, matthias.hottgenr...@icloud.com wrote: >Hello all together, > >I’m using the busybox arping version to scan a larger number of systems. Lots >of these systems don’t answer to the arping request. >Due to the implementation of arping, the timeout has to be at least

Re: Question about isolating and re-using code from busybox

2022-03-04 Thread Bernhard Reutner-Fischer
On 4 March 2022 07:48:58 CET, Emmanuel Deloget wrote: >Hello Tim, > >it seems to me that it should not be that complicated, as the tar >handling code is mostly encapsulated into a library of its own. > >See https://git.busybox.net/busybox/tree/archival/libarchive for >futher reference. I think

return type demotion remarks

2021-11-27 Thread Bernhard Reutner-Fischer
Hi! I'm attaching a color log of some spots that may benefit of using narrower return types; See "could return". It certainly misses still quite some cases as it currently works only per function and thus does not see return values flowing from calls in the function. Taking call's known return

Re: [PATCH] Fix const pointer assignment trick on clang 9+

2021-10-17 Thread Bernhard Reutner-Fischer
On 9 October 2021 21:47:40 CEST, Norbert Lange wrote: >The problem sounds lot like what std::launder [1] is supposed to >solve, there is a builtin `__builtin_launder` for this very purpose Launder is a c++ thing. Does LLVM make it available in C too? thanks,

[PATCH 0/1] Silence analyzer warning in chrt

2021-10-10 Thread Bernhard Reutner-Fischer
e of uninitialized value ‘priority’ here | 193 | sched_get_priority_min(policy), sched_get_priority_max(policy) | | ~~ | 194 | ); | | ~ | Bernhard Reutner-Fischer (1): ch

[PATCH 1/1] chrt: silence analyzer warning

2021-10-10 Thread Bernhard Reutner-Fischer
) Total: -3 bytes textdata bss dec hex filename 97215742351840 978232 eed38 busybox_old 97215442351840 978229 eed35 busybox_unstripped Signed-off-by: Bernhard Reutner-Fischer --- util-linux/chrt.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v2] find: implement -amin, -atime, -cmin, and -ctime

2021-10-01 Thread Bernhard Reutner-Fischer
On 29 September 2021 13:49:39 CEST, Ismael Luceno wrote: bloat-o-meter if all are on versus baseline? Just curious. thanks, ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH] vi: fix regex search compilation error

2021-07-13 Thread Bernhard Reutner-Fischer
On Tue, 13 Jul 2021 21:42:05 +0100 Ron Yorston wrote: > Bernhard Reutner-Fischer wrote: > >If i'm not mistaken, the s++ is fully redundant here although it seems > >that my gcc-11 does not optimize it like if we manually spell it out > >like in the attached? > >

Re: [PATCH] vi: fix regex search compilation error

2021-07-13 Thread Bernhard Reutner-Fischer
On Tue, 13 Jul 2021 at 18:24, Bernhard Reutner-Fischer wrote: > > On Tue, 13 Jul 2021 16:35:43 +0100 > Ron Yorston wrote: > > > Building with FEATURE_VI_REGEX_SEARCH enabled fails. > btw.. If i'm not mistaken, the s++ is fully redundant here although it seems that my gcc

Re: [PATCH] vi: fix regex search compilation error

2021-07-13 Thread Bernhard Reutner-Fischer
On Tue, 13 Jul 2021 16:35:43 +0100 Ron Yorston wrote: > Building with FEATURE_VI_REGEX_SEARCH enabled fails. Applied. thanks, > > Signed-off-by: Ron Yorston > --- > editors/vi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/editors/vi.c b/editors/vi.c > index

Re: [git commit] taskset: implement -a

2021-06-20 Thread Bernhard Reutner-Fischer
On 19 June 2021 17:42:35 CEST, Denys Vlasenko wrote: >commit: >https://git.busybox.net/busybox/commit/?id=25128176c46b169cdec2c18b5730c36a940f6eb0 >branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master > >function old new >delta

Re: [PATCH] build system: new configuration interface (nconfig)

2021-04-18 Thread Bernhard Reutner-Fischer
On Sun, 18 Apr 2021 21:43:06 +0200 Xabier Oneca -- xOneca wrote: > Hi Bernhard, > > > The usual way to update out kconfig was to pull the upstream version > > from the kernel, refresh our patch (if we had one) and commit > > both. We usually picked the current stable kernel version and

Re: [PATCH] build system: new configuration interface (nconfig)

2021-04-18 Thread Bernhard Reutner-Fischer
Hi Xabier, On Sun, 18 Apr 2021 19:20:22 +0200 Xabier Oneca -- xOneca wrote: > This patch adds a more modern-looking interface using ncurses. The > implementation does not depend on lxdialog, which is currently distributed > with > Busybox. > > The code is borrowed from the Linux kernel

Re: [PATCH] vi: add expandtab option

2021-04-18 Thread Bernhard Reutner-Fischer
On Fri, 16 Apr 2021 15:50:49 +0100 Ron Yorston wrote: > Peter0x44 wrote: > >> I've haven't signed off on them because I'd like to get a signoff from > >> Peter on the first > >I'm a little confused on what I'm being asked here - should I just > >submit the patch again, with my git user.name

Re: [PATCH v2 3/3] touch: add --time=what option

2021-04-12 Thread Bernhard Reutner-Fischer
On Tue, 13 Apr 2021 00:27:50 +0200 Xabier Oneca -- xOneca wrote: > This option is the long version of -a and -m. > > function old new delta > touch_main 484 539 +55 > .rodata

Re: Cross compiling from x86_64 to SPARC

2021-02-07 Thread Bernhard Reutner-Fischer
On Mon, 01 Feb 2021 10:47:34 +0200 Baruch Siach wrote: > Hi Rich, > > On Mon, Feb 01 2021, Rich Fromm wrote: > > I have an old ReadyNAS NV+ v1 from Netgear that's having some hardware > > issues, and I'm trying to retrieve the data off of the disk array. I can > > boot into a tech support mode,

Re: Cross compiling from x86_64 to SPARC

2021-02-07 Thread Bernhard Reutner-Fischer
On Mon, 1 Feb 2021 00:22:52 -0800 Rich Fromm wrote: > Sorry if this is a FAQ. I manually clicked month by month through 5 years > of mailing list archives (is there a functional way to search?), and only We have a shorthand of google search "site:busybox.net" here:

Re: change for PATCH : Do not add -lresolv on non-Linux systems

2021-02-07 Thread Bernhard Reutner-Fischer
On Sun, 7 Feb 2021 06:23:37 + Yuping Luo wrote: > Hello, > > The patch[1] define osname in Linux is "Linux", while it's "GNU/Linux" > maybe the following change is necessary to avoid build break. I've applied Martins patch, please try current git. thanks, pgpukaUltBhHm.pgp

Re: [PATCH v3] Makefile.flags: fix the OS detection for libresolv

2021-02-07 Thread Bernhard Reutner-Fischer
On Fri, 22 Jan 2021 22:24:05 +0100 Martin Kaiser wrote: > From: Martin Kaiser > > 054493350 ("Do not add -lresolv on non-Linux systems") adds a condition > to link with libresolv only on linux systems. > > This patch uses the output of $CC -dumpmachine to detect the target platform > for

Re: Question on udhcpc script

2021-02-06 Thread Bernhard Reutner-Fischer
On Sat, 6 Feb 2021 at 14:18, Bernhard Reutner-Fischer wrote: > > On Sat, 6 Feb 2021 11:43:31 + > Walter Harms wrote: > > > aeh, yes ... > > > > important question: did someone fix (and tested) this issue ? > > > On 1 February 2021 11:33:25 CET, Walte

Re: Question on udhcpc script

2021-02-06 Thread Bernhard Reutner-Fischer
On Sat, 6 Feb 2021 11:43:31 + Walter Harms wrote: > aeh, yes ... > > important question: did someone fix (and tested) this issue ? > On 1 February 2021 11:33:25 CET, Walter Harms wrote: > >hello, > >indeed that looks wrong: > >it would be easy to invert but i have no setup to test. >

Re: Question on udhcpc script

2021-02-06 Thread Bernhard Reutner-Fischer
On 1 February 2021 11:33:25 CET, Walter Harms wrote: >hello, >indeed that looks wrong: >it would be easy to invert but i have no setup to test. >can you do that ? > >just change: > if [ -z "$(ip -6 route list | grep default)" ]; then >into >if ! [ -z "$(ip -6 route list | grep default)" ]; then

Re: FreeBSD patches

2021-01-03 Thread Bernhard Reutner-Fischer
On 3 January 2021 22:42:43 CET, Eli Schwartz wrote: >On 1/3/21 4:27 PM, Alex Samorukov wrote: >> Hi, thank you. I was manually moving patches from my BSD port to >git and looks like did some errors. Now will follow Denys advise and send >them one by one. >>> Please git

Re: FreeBSD patches

2021-01-03 Thread Bernhard Reutner-Fischer
On 3 January 2021 15:51:41 CET, Alex Samorukov wrote: >Hi, thank you. I was manually moving patches from my BSD port to git >and >looks like did some errors. Now will follow Denys advise and send them >one by one. Please git send-email against current master for posterity. External links cannot

Re: [PATCH] chrt: support for musl C library

2020-10-15 Thread Bernhard Reutner-Fischer
On Fri, 11 Sep 2020 17:45:38 +0200 Christian Eggers wrote: > musl "implements" several sched_xxx() functions by returning ENOSYS. As > an alternative, either pthread_(g|s)etschedparam() or direct syscalls > can be used. I don't like using the syscalls directly in the way you propose below.

Re: Placement of load_policy in /usr/sbin

2020-10-15 Thread Bernhard Reutner-Fischer
On Wed, 14 Oct 2020 21:12:28 +0200 Xabier Oneca -- xOneca wrote: > Hi, > > > Busybox seems to place its implementation of SELinux's load_policy in > > /usr/sbin by default. Other (albeit external) utilities, such as semodule, > > expect to find load_policy in /sbin by default. Would it be

Re: Searching the lists

2020-07-12 Thread Bernhard Reutner-Fischer
On Sun, 12 Jul 2020 13:48:02 +0200 Xabier Oneca -- xOneca wrote: > Hi Baruch, > > > How do I search the lists? When I go to https://www.busybox.net/lists.html > > it just says to search the lists, but doesn't say how to do this? > > Using Google, you can search for "something >

Re: Add httpd directory list support & conspy fix

2020-07-06 Thread Bernhard Reutner-Fischer
On Mon, 6 Jul 2020 00:12:41 +0300 Sergey Ponomarev wrote: > This is an old topic where Pascal proposed a patch that allows to run a > script to list the directory with httpd > http://hg.slitaz.org/wok/raw-file/3dc7c4a7f5ef/busybox/stuff/busybox-1.18-httpd.u > > > > > Denys said: > > This

Re: [PATCH] domain_codec: optimize call to dname_enc

2020-06-10 Thread Bernhard Reutner-Fischer
On Thu, 11 Jun 2020 13:12:53 -0500 Martin Lewis wrote: > Hi, > Yes, looks good :) PS: i was at first a bit thrown off by the function name to talk about DNAME RR (as opposed to CNAME RR resp. domain_name) but in the context of dhcp as opposed to dns it makes more sense i suppose. I'd expand the

Re: [git commit] Makefile.flags: restrict Wno-constant-logical-operand and Wno-string-plus-int options for clang

2020-06-10 Thread Bernhard Reutner-Fischer
On 10 June 2020 14:33:19 CEST, Denys Vlasenko wrote: >commit: >https://git.busybox.net/busybox/commit/?id=505eeae402a84dc5208986c5ad611f5e485cbe34 >branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master > >these options were added in b4ef2e3467d8e980ccf13c9dd342459c013b455f >commit

Re: Non-responsive maintainer?

2020-06-06 Thread Bernhard Reutner-Fischer
On Sat, 6 Jun 2020 18:40:37 +0200 Wolf wrote: > On 2020-06-05 12:10:54 +0200, Bernhard Reutner-Fischer wrote: > > [..] > > > > So: Please involve yourself more closely in the project, like you > > would foster any other opensource community project. > >

Re: Question: ip route and rto_min

2020-06-05 Thread Bernhard Reutner-Fischer
On Fri, 5 Jun 2020 19:38:51 +0100 Tiago Marques wrote: > Hi all, > > I wanted to set rto_min for a specific route. I've been looking in the > config file for an option to enable this option and use it in the "ip > route" command but to no avail. Can any one give me some pointers? Is it > not

Re: [Bug 12981] awk: seems to try to falsely expand strings

2020-06-05 Thread Bernhard Reutner-Fischer
On Fri, 05 Jun 2020 19:50:07 + bugzi...@busybox.net wrote: > https://bugs.busybox.net/show_bug.cgi?id=12981 > > --- Comment #3 from Steffen Nurpmeso --- > The nawk bug is already fixed, heh. Luckily i saved away the script, another > version did not reveal the crash there. The final

Re: Non-responsive maintainer?

2020-06-05 Thread Bernhard Reutner-Fischer
On Fri, 5 Jun 2020 at 05:41, Jody Bruchon wrote: > > Understood. Be well. > > On June 4, 2020 9:45:39 PM EDT, Eli Schwartz wrote: > >On 6/4/20 9:01 PM, Jody Bruchon wrote: > >> If things hang for too long, I'd be willing to fork the project and > >> maintain it so it can keep on chugging. I'm

Re: git smart http for busybox repo

2020-05-16 Thread Bernhard Reutner-Fischer
On Sat, 16 May 2020 at 00:11, Peter Korsgaard wrote: > Hmm, did something change afterwards? I just got a report about issues > accessing the Buildroot repo over https, and it indeed doesn't seem to > work: Famous last minute change. Fixed. Sorry for that!

Re: git smart http for busybox repo

2020-05-13 Thread Bernhard Reutner-Fischer
On Mon, 13 Apr 2020 at 16:43, Yannik Sembritzki wrote: > > Hi, > > currently, the busybox git server is only providing "dumb http" > functionality. > This is, for example, demonstrated when trying to make shallow clone: > > $ git clone --depth=1 https://git.busybox.net/busybox/ > Cloning into

Re: git smart http for busybox repo

2020-04-22 Thread Bernhard Reutner-Fischer
On 21 April 2020 14:14:50 CEST, Yannik Sembritzki wrote: >I'm glad my message ended the unncessary github discussion. > >However, I'd still like to know who is in charge of maintaining >git.busybox.net, so I can forward this suggestion to the right person. We are doing this as time permits. I

Re: busybox mount does not use fstab mount options for root partition

2020-03-03 Thread Bernhard Reutner-Fischer
On Tue, 3 Mar 2020 17:06:35 +0100 (CET) Andreas Hilse wrote: > Root partition is mounted read-only by the kernel (command line: > root=/dev/sda1) and then remounted read-write via busybox init inittab entry > "::sysinit:/bin/mount -o remount,rw" (due to > Could this be a bug or is there

Re: [PATCH] - Adds TAR_SEC_CAPABILITY feature to tar

2020-01-08 Thread Bernhard Reutner-Fischer
On 7 January 2020 01:25:17 CET, Cole Dishington wrote: >Package: busybox > >Version: v131.1 >Severity: wishlist > > >This patch adds the ability for tar to extract security capabilities, >stored in pax headers. I have tested this on Linux Ubuntu x86_64 and it >works. I have tested it against GNU

Re: [PATCH 2/8] mdev: increase netlink buffer sizes

2019-12-18 Thread Bernhard Reutner-Fischer
On 17 December 2019 17:06:46 CET, "Jan Klötzke" wrote: >On Tue, Dec 17, 2019 at 12:01:09AM +, Laurent Bercot wrote: >> >> > The socket receive buffer turned out to be too small for real world >> > systems. Use the same size as udevd to be on the safe side. As this >is >> > just a limit and

Re: mdev -d can (silently) die with "read: no buffer space available"

2019-12-15 Thread Bernhard Reutner-Fischer
rors properly which might return undef. For clarity i would rephrase it like in the attached, again fwiw. Both untested, but you get the idea.. cheers, >From 9d53a0aeccbbf4b47f9f39e588485cc6c273b407 Mon Sep 17 00:00:00 2001 From: Bernhard Reutner-Fischer Date: Sun, 15 Dec 2019 08:38:54 +0100 Subject: [P

Re: [PATCH 1/2] iproute: codeshrink netlink message length check

2019-11-13 Thread Bernhard Reutner-Fischer
On 12 November 2019 12:04:24 CET, Natanael Copa wrote: >reduce size by de-duplicate netlink message length check > >function old new >delta >check_nlmsg_len- 22 >+22 >print_route

Re: [git commit] taskset: add support for taking/printing CPU list (-c option)

2019-11-08 Thread Bernhard Reutner-Fischer
On 1 November 2019 15:44:49 CET, Denys Vlasenko wrote: >commit: >https://git.busybox.net/busybox/commit/?id=162ac7f45ed0ffdb2fdb2fc1871557523fd22d98 >branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master > >function old new >delta

Re: [PATCH] Remove stime() function calls

2019-11-08 Thread Bernhard Reutner-Fischer
On 8 November 2019 23:26:48 CET, Alistair Francis wrote: >On Wed, 2019-11-06 at 09:17 +0100, walter harms wrote: >> Your are right but so far i understand >> the idea here is to have a replacement when >> a programm demands stime(). > >Thanks! Do I need to do anything else or is this going to be

Re: [PATCH] brctl: Added support for showmacs command

2019-09-20 Thread Bernhard Reutner-Fischer
On Mon, 16 Sep 2019 18:08:41 +0200 Martin Lewis wrote: > Hi, > > The attached implementation is roughly the same found in brctl from > bridge-utils. > It does the same actions, and specifically reads it’s entries from > /sys/class/net//brforward. > The relevant kernel function is

Re: [PATCH] brctl: Added support for showmacs command

2019-09-15 Thread Bernhard Reutner-Fischer
On 15 September 2019 18:04:49 CEST, Martin Lewis wrote: >Signed-off-by: Martin Lewis >--- >networking/brctl.c | 119 >- > 1 file changed, 100 insertions(+), 19 deletions(-) > >diff --git a/networking/brctl.c b/networking/brctl.c >index

Re: [PATCH] init: add option to select a default init script

2019-08-13 Thread Bernhard Reutner-Fischer
On 10 August 2019 14:38:42 CEST, David Demelier wrote: >On Fri, 2019-07-05 at 14:25 +0200, David Demelier wrote: >> --- >> init/init.c | 10 +- >> 1 file changed, 9 insertions(+), 1 deletion(-) >> >> diff --git a/init/init.c b/init/init.c >> index 0f3c5fa4d..a875caf84 100644 >> ---

Re: [git commit] do not duplicate CONFIG_PID_FILE_PATH and ".pid" strings

2019-03-18 Thread Bernhard Reutner-Fischer
On 17 March 2019 19:48:39 CET, Denys Vlasenko wrote: >commit: >https://git.busybox.net/busybox/commit/?id=5059653882dbd86e3bbf48389f9f81b0fac8cd0a >branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master > > text data bss dec hex filename > 981737

Re: bb_daemonize_or_rexec(DAEMON_CLOSE_EXTRA_FDS) does not close extra fds

2019-03-15 Thread Bernhard Reutner-Fischer
On Thu, 14 Mar 2019 17:01:16 +0100 Bernd Petrovitsch wrote: > > Thoughts? > > https://stackoverflow.com/questions/1315382/closing-all-open-files-in-a-process > has something: > - Use https://man.openbsd.org/closefrom.2 - which doesn't exist on > Linux. > - use getdtablesize() > - use

Re: [git commit] dhcp service example: cater for servers hot giving subnet and/or router

2019-02-05 Thread Bernhard Reutner-Fischer
On 5 February 2019 17:48:24 CET, Denys Vlasenko wrote: >commit: >https://git.busybox.net/busybox/commit/?id=2feaba1d8dc2893d9f1064673e500312eaa70777 >branch: https://git.busybox.net/busybox/commit/?id=refs/heads/master > >Signed-off-by: Denys Vlasenko >--- >

Re: [git commit] bc: new applet, throws warning

2018-12-07 Thread Bernhard Reutner-Fischer
On 6 December 2018 22:38:45 CET, Gavin Howard wrote: >On Thu, Dec 6, 2018 at 2:30 PM Michael Conrad >wrote: >> >> On 12/6/2018 11:48 AM, Gavin Howard wrote: >> >> > you are going to have to make the bc not give good error messages >and/or not check for errors as thoroughly (a massive chunk of

Re: [git commit] bc: new applet, throws warning

2018-12-06 Thread Bernhard Reutner-Fischer
Hi, Are you sure this is a good idea? I was under the impression that it would be much more sane to write bc from scratch given the extraordinary size of the proposed implementation. Thanks, On 5 December 2018 15:40:38 CET, Denys Vlasenko wrote: >commit:

Re: [PATCH] Add a 'busybox --list name' option to display script content Re: License concerns when embedding script in busybox binary

2018-11-11 Thread Bernhard Reutner-Fischer
On Fri, 09 Nov 2018 18:10:33 + Ron Yorston wrote: > Add an option to allow the content of embedded scripts to be > displayed. > > It's disabled by default. When enabled: I'd enable it unconditionally when embedded scripts are enabled. And i would much prefer to name the option --show.

Re: printf can't handle the '+' char in front of an integer

2018-10-31 Thread Bernhard Reutner-Fischer
On Wed, 31 Oct 2018 at 00:36, Denys Vlasenko wrote: > > On Fri, Oct 19, 2018 at 3:43 PM Bernhard Reutner-Fischer > wrote: > > On Fri, 19 Oct 2018 at 15:30, Bernhard Reutner-Fischer > > wrote: > > > On Fri, 19 Oct 2018 at 11:03, Cristian Ionescu-Idbohrn > &g

Re: printf can't handle the '+' char in front of an integer

2018-10-19 Thread Bernhard Reutner-Fischer
On Fri, 19 Oct 2018 at 15:30, Bernhard Reutner-Fischer wrote: > > On Fri, 19 Oct 2018 at 11:03, Cristian Ionescu-Idbohrn > wrote: > > > > The documentation on this page: > > > > > > http://pubs.opengroup.org/onlinepubs/9699919799/utilities/print

Re: printf can't handle the '+' char in front of an integer

2018-10-19 Thread Bernhard Reutner-Fischer
On Fri, 19 Oct 2018 at 11:03, Cristian Ionescu-Idbohrn wrote: > > The documentation on this page: > > http://pubs.opengroup.org/onlinepubs/9699919799/utilities/printf.html > > (search for 'ISO/IEC 646:1991') shows this example: > > printf "%d\n" 3 +3 -3 \'3 \"+3 "'-3" > > busybox

Re: Using netns in a busybox environment

2018-10-18 Thread Bernhard Reutner-Fischer
On Thu, 18 Oct 2018 at 14:00, Igor Soares Nunes wrote: > > Hi all, > > > I wonder if it is possible to use "ip netns" to create network namespaces > with "ip" busybox. There currently is no support for netns in busybox' ip. I suggest you use the big ip if you need netns. thanks,

Re: mdev.conf setting example for running with linux kernel's IMA/EVM

2018-10-18 Thread Bernhard Reutner-Fischer
On Thu, 18 Oct 2018 at 09:47, Bernhard Reutner-Fischer wrote: > > On Wed, 17 Oct 2018 at 11:02, 趙翊廷 wrote: > > > 2. in /etc/mdev.confg we need to add a symbol link something like > > /dev/block/3:0 > > hd[a-z]* 0:6 660 *ln -sf /dev/$MDEV /dev/block/$(ls -l /de

Re: mdev.conf setting example for running with linux kernel's IMA/EVM

2018-10-18 Thread Bernhard Reutner-Fischer
On Wed, 17 Oct 2018 at 11:02, 趙翊廷 wrote: > 2. in /etc/mdev.confg we need to add a symbol link something like > /dev/block/3:0 > hd[a-z]* 0:6 660 *ln -sf /dev/$MDEV /dev/block/$(ls -l /dev/$MDEV|awk > '{print $5}'|tr -d ','):$(ls -l /dev/$MDEV|awk '{print $6}') > sd[a-z]* 0:6 660 *ln

  1   2   3   4   5   >