[PATCH] D33644: Add default values for function parameter chunks

klimek added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:2411-2412 + if (DefValue.at(0) != '=') { +// If we don't have = in front of value +return " = " + DefValue; + } Can you expand in the comment on when each of these happens?

[PATCH] D34512: Add preliminary Cross Translation Unit support library

klimek added a comment. Specifically, ping Richard for new top-level lib in clang. https://reviews.llvm.org/D34512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34512: Add preliminary Cross Translation Unit support library

klimek added a comment. In https://reviews.llvm.org/D34512#800626, @whisperity wrote: > In https://reviews.llvm.org/D34512#800502, @xazax.hun wrote: > > > In https://reviews.llvm.org/D34512#800499, @klimek wrote: > > > > > In https://reviews.llvm.org/D34512#800490, @xazax.hun wrote: > > > > > >

[PATCH] D34512: Add preliminary Cross Translation Unit support library

klimek added a reviewer: rsmith. klimek added a comment. +Richard as top-level code owner for new libs. For bikeshedding the name: I'd have liked libIndex, but that's already taken. CrossTU doesn't seem too bad to me, too, though. https://reviews.llvm.org/D34512

[PATCH] D34512: [libTooling] Add preliminary Cross Translation Unit support for libTooling

klimek added a comment. In https://reviews.llvm.org/D34512#800490, @xazax.hun wrote: > It looks like Richard approved libTooling as a dependency for clang on the > mailing list (http://lists.llvm.org/pipermail/cfe-dev/2017-July/054536.html). > If it is ok to have this code in libTooling (for

[PATCH] D34696: [refactor] Move clang-rename to Clang

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rL LLVM https://reviews.llvm.org/D34696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG, thx for bearing with me, this looks great. (and sorry if I didn't send this earlier, just noticed I forgot to hit submit :( ) Comment at:

[PATCH] D34696: [refactor] Move the core of clang-rename to lib/Tooling/Refactoring

klimek added a comment. In https://reviews.llvm.org/D34696#795020, @arphaman wrote: > In https://reviews.llvm.org/D34696#793613, @klimek wrote: > > > The main thing I'm concerned about is having the main code in core, but > > having all tests in tools-extra. I think if we go that route we

[PATCH] D34755: [clangd] Added a test, checking that gcc install is searched via VFS.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D34755 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34696: [refactor] Move the core of clang-rename to lib/Tooling/Refactoring

klimek added a comment. The main thing I'm concerned about is having the main code in core, but having all tests in tools-extra. I think if we go that route we should also move clang-rename and its tests to core. Thoughts? Repository: rL LLVM https://reviews.llvm.org/D34696

[PATCH] D33644: Add default values for function parameter chunks

klimek added a comment. In https://reviews.llvm.org/D33644#793601, @yvvan wrote: > In https://reviews.llvm.org/D33644#793594, @klimek wrote: > > > In https://reviews.llvm.org/D33644#793577, @yvvan wrote: > > > > > In https://reviews.llvm.org/D33644#793573, @klimek wrote: > > > > > > > In

[PATCH] D33644: Add default values for function parameter chunks

klimek added a comment. In https://reviews.llvm.org/D33644#793577, @yvvan wrote: > In https://reviews.llvm.org/D33644#793573, @klimek wrote: > > > In https://reviews.llvm.org/D33644#783903, @yvvan wrote: > > > > > Do not evaluate numbers. > > > Check for != "=" is needed not to mess with

[PATCH] D34687: [Tooling] CompilationDatabase should be able to strip position arguments when `-fsyntax-only` is used

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Repository: rL LLVM https://reviews.llvm.org/D34687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30691: [analyzer] Support for naive cross translational unit analysis

klimek added a reviewer: rsmith. klimek added a comment. Richard (added as reviewer) usually owns decisions around clang itself. Writing an email to cfe-dev with the numbers and wait for whether others have concerns would probably also be good. https://reviews.llvm.org/D30691

[PATCH] D34512: [libTooling] Add preliminary Cross Translation Unit support for libTooling

klimek added inline comments. Comment at: include/clang/Tooling/CrossTranslationUnit.h:53-58 + /// \p CrossTUDir directory, called \p IndexName. In case the declaration is + /// found in the index the corresponding AST file will be loaded and the + /// definition of the

[PATCH] D34512: [libTooling] Add preliminary Cross Translation Unit support for libTooling

klimek added reviewers: dexonsmith, akyrtzi, benlangmuir, arphaman. klimek added a comment. Adding folks interested in the indexing discussion. Comment at: include/clang/Tooling/CrossTranslationUnit.h:53-58 + /// \p CrossTUDir directory, called \p IndexName. In case the

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

klimek added a comment. In https://reviews.llvm.org/D34304#788080, @saugustine wrote: > In https://reviews.llvm.org/D34304#787699, @klimek wrote: > > > I mean, arguments need to be adjusted before converting to ArgStringList > > and calling newInvocation? I'm not sure I fully understand the

[PATCH] D34512: [libTooling] Add preliminary Cross Translation Unit support for libTooling

klimek added a comment. General direction looks good. I think in addition to integration tests through the static analyzer, we should still have unit tests. Comment at: include/clang/Tooling/CrossTranslationUnit.h:47 + + const FunctionDecl *getCTUDefinition(const

[PATCH] D34329: [GSoC] Clang AST diffing

klimek added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:57 +/// Within a tree, this identifies a node by its preorder offset. +using NodeId = int; + johannes wrote: > arphaman wrote: > > I think that it's better to make make `NodeId` a

[PATCH] D34469: Use vfs::FileSystem in ASTUnit when creating CompilerInvocation.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D34469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34470: [clangd] Allow to override resource dir in ClangdServer.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D34470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

klimek added a comment. I mean, arguments need to be adjusted before converting to ArgStringList and calling newInvocation? I'm not sure I fully understand the problem, can you elaborate? https://reviews.llvm.org/D34304 ___ cfe-commits mailing

[PATCH] D33823: [clang-format] Support sorting using declarations

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D33823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34287: Moved code hanlding precompiled preamble out of the ASTUnit.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D34287 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34329: [GSoC] Clang AST diffing

klimek added a comment. Reviewing this mainly from the API view, and leaving the technical details to others :) Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:124 + +class ASTDiff { + TreeRoot , Generally, can we put the public interface first in the

[PATCH] D34287: Moved code hanlding precompiled preamble out of the ASTUnit.

klimek added inline comments. Comment at: include/clang/Frontend/PrecompiledPreamble.h:124 +/// CanReusePreamble + AddImplicitPreamble to make use of it. +class PrecompiledPreamble { +public: ilya-biryukov wrote: > klimek wrote: > > If a user doesn't care about

[PATCH] D34287: Moved code hanlding precompiled preamble out of the ASTUnit.

klimek added inline comments. Comment at: lib/Frontend/ASTUnit.cpp:131-136 +/// \brief Get a source buffer for \p MainFilePath, handling all file-to-file +/// and file-to-buffer remappings inside \p Invocation. +static PossiblyOwnedBuffer +getBufferForFileHandlingRemapping(const

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

klimek added a comment. In https://reviews.llvm.org/D34263#784168, @akyrtzi wrote: > In https://reviews.llvm.org/D34263#783694, @klimek wrote: > > > how many patches for single file mode are coming down the road, though? I'm > > somewhat concerned about the overall complexity it'll add to

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. oh, and lg from my side https://reviews.llvm.org/D34263 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

klimek added a comment. In https://reviews.llvm.org/D34304#784496, @saugustine wrote: > In https://reviews.llvm.org/D34304#783675, @klimek wrote: > > > I think a better way might be to generally leave dependency options alone, > > add a default argument adapter to filter out all deps related

[PATCH] D34329: [GSoC] Clang AST diffing

klimek added inline comments. Comment at: include/clang/Tooling/ASTDiff/ASTDiff.h:123 + +void runDiff(ASTContext , ASTContext ); + This is the main exposed interface? Generally, if all we want to do is printing, I wouldn't put that into a library in Tooling,

[PATCH] D33644: Add default values for function parameter chunks

klimek added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:2453 std::string PlaceholderStr = FormatFunctionParameter(Policy, Param); +if (Param->hasDefaultArg() && PlaceholderStr.find("=") == std::string::npos) { +std::string DefaultValue =

[PATCH] D33823: [clang-format] Support sorting using declarations

klimek added inline comments. Comment at: lib/Format/UsingDeclarationsSorter.cpp:41-42 + +bool computeUsingDeclarationLabel(const FormatToken *UsingTok, + std::string *Label) { + assert(UsingTok && UsingTok->is(tok::kw_using) && "Expecting a

[PATCH] D34287: Moved code hanlding precompiled preamble out of the ASTUnit.

klimek added inline comments. Comment at: include/clang/Frontend/PrecompiledPreamble.h:42-43 +/// destructors. +/// An assertion will fire if two PCHTempFiles are created with the same name, +/// so it's not intended to be used outside preamble-handling. +class TempPCHFile {

[PATCH] D34263: [preprocessor] When preprocessor option 'SingleFileParseMode' is enabled, parse all directive blocks if the condition uses undefined macros

klimek added a comment. Generally this patch lg from my side - how many patches for single file mode are coming down the road, though? I'm somewhat concerned about the overall complexity it'll add to clang. When I saw your first patch my reaction was "wow, this works with this little change -

[PATCH] D34304: Allow CompilerInvocations to generate .d files.

klimek added a comment. I think a better way might be to generally leave dependency options alone, add a default argument adapter to filter out all deps related flags, and allow users to add their own argument adapters that don't do that. https://reviews.llvm.org/D34304

[PATCH] D33644: Add default values for function parameter chunks

klimek added inline comments. Comment at: lib/Sema/SemaCodeComplete.cpp:2453 std::string PlaceholderStr = FormatFunctionParameter(Policy, Param); +if (Param->hasDefaultArg() && PlaceholderStr.find("=") == std::string::npos) { +std::string DefaultValue =

[PATCH] D33644: Add default values for function parameter chunks

klimek added a comment. Ok, now I get it - can you please add tests? This is usually tested by adding a c-index-test based test. Comment at: lib/Sema/SemaCodeComplete.cpp:2411-2417 + const SourceLocation StartLoc = SrcRange.getBegin(); + const SourceLocation EndLoc =

[PATCH] D33644: Add default values for function parameter chunks

klimek added a comment. Can you give a bit more background what this is trying to do? https://reviews.llvm.org/D33644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32480: clang-format: Add CompactNamespaces option

klimek added a comment. Generally LG from my side. Comment at: unittests/Format/FormatTest.cpp:1363-1381 + EXPECT_EQ("namespace {\n" + "namespace {\n" +"}} // namespace

[PATCH] D32480: clang-format: Add CompactNamespaces option

klimek added a comment. In https://reviews.llvm.org/D32480#773807, @Typz wrote: > So how do I proceed? > > 1. Keep the CompactNamespace option, and make "compacted" namespaces always > add at most one level of indentation > 2. Or assume that this can only ever usefully work with the behavior of

[PATCH] D33714: clang-format: [JS] improve calculateBraceType heuristic

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. Apart from fixme LG. Comment at: lib/Format/UnwrappedLineParser.cpp:397 // blocks (for example while parsing lambdas). + // TODO(martinprobst): Some of

[PATCH] D32480: clang-format: Add CompactNamespaces option

klimek added a comment. I'm less concerned about everything suddenly re-indenting when you change code - if you use any kind of namespace indentation, that's what will happen now and then (and is why many style guides do not indent in namespaces). For what it's worth, I'd 1. vote for only

[PATCH] D33047: [ClangD] Refactor clangd into separate components

klimek added inline comments. Comment at: clangd/ClangdLSPServer.h:23 + +class ClangdLSPServer { + class LSPDiagnosticsConsumer; ilya-biryukov wrote: > klimek wrote: > > I'd have expected something that's called LSP server to work on the LSP > > protocol level

[PATCH] D33047: [ClangD] Refactor clangd into separate components

klimek added inline comments. Comment at: clangd/ClangdLSPServer.h:23 + +class ClangdLSPServer { + class LSPDiagnosticsConsumer; I'd have expected something that's called LSP server to work on the LSP protocol level (that is, have a server(iostream) equivalent

[PATCH] D32909: [Tooling] Remove redundant check, NFCi

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D32909 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D32351: [Tooling][libclang] Remove unused CompilationDatabase::MappedSources

klimek added a comment. Is there a specific reason to take this out? It seems generally useful to allow compilation-db implementors to provide sources. https://reviews.llvm.org/D32351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

klimek added a comment. In https://reviews.llvm.org/D31992#725912, @malaperle-ericsson wrote: > In https://reviews.llvm.org/D31992#725866, @krasimir wrote: > > > Seems that we're starting to hit some YAML/JSON mismatches, or is it that > > your YAML string support is lacking? > > > I don't

[PATCH] D31992: [clangd] Escape only necessary characters in JSON output

klimek added inline comments. Comment at: clangd/Protocol.cpp:26-50 + for (llvm::StringRef::iterator i = Input.begin(), e = Input.end(); i != e; ++i) { +if (*i == '\\') + EscapedInput += ""; +else if (*i == '"') + EscapedInput += "\\\""; +// bell +

[PATCH] D30777: Added `applyAtomicChanges` function.

klimek added inline comments. Comment at: include/clang/Tooling/Refactoring/AtomicChange.h:129 +struct ApplyChangesSpec { + // If true, cleans up redundant/erroneous around changed code with + // clang-format's cleanup functionality, e.g. redundant commas around deleted

[PATCH] D30735: Add missing implementation for AtomicChange::replace(...)

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D30735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30650: [clang-tidy] misc-use-after-move: Fix failing assertion

klimek added a comment. In https://reviews.llvm.org/D30650#693165, @Eugene.Zelenko wrote: > I think we should refactor this check as part of Static Analyzer, since it's > path-sensitive. Are you saying it should be path sensitive? Because currently it's not, right?

[PATCH] D27810: FileManager: mark virtual file entries as valid entries

klimek added a comment. Is the diff view on phab broken, or am I missing something? I only see a single line of diff now, and don't see a way to change the diff. https://reviews.llvm.org/D27810 ___ cfe-commits mailing list

[PATCH] D30636: [analyzer] Fix crash when building CFG with variable of incomplete type

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D30636 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30532: Add examples to clang-format configuration

klimek added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:218 + +#define A \ +int ; \ Do we really align these 3 spaces out? Comment at: docs/ClangFormatStyleOptions.rst:447 + SomeClass::Constructor() +

[PATCH] D27054: Introducing clang::tooling::AtomicChange for refactoring tools.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D27054 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

klimek added a comment. Also, do we want to not call ReplaceFile in Path.inc on Win if it potentially leaves temp files lying around? Reading the code, it looks like we currently actually believe it may fail, and retry with MoveFileEx afterwards... https://reviews.llvm.org/D30385

[PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

klimek added a comment. Can we open the files with FILE_SHARE_DELETE instead? https://reviews.llvm.org/D30385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30385: clang-format: Don't leave behind temp files in -i mode on Windows, PR26125, reloaded

klimek added inline comments. Comment at: include/clang/Rewrite/Core/Rewriter.h:188-197 + /// prewrite(FID) is called after all changes to FID have been written to a + /// temporary file, but before that temporary file is moved into FID's + /// location. Windows's

[PATCH] D30210: [include-fixer] Add usage count to find-all-symbols.

klimek added inline comments. Comment at: include-fixer/find-all-symbols/FindAllSymbols.cpp:251 + } else { +assert(false && "Must match a NamedDecl!"); + } You can use llvm_unreachable instead. Or do you actually want to fall through in release mode?

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

klimek added inline comments. Comment at: test/Format/check-coding-style-mozilla.cpp:7-9 +/* This Source Code Form is subject to the terms of the Mozilla Public + * License, v. 2.0. If a copy of the MPL was not distributed with this + * file, You can obtain one at

[PATCH] D29943: [clang-format] Align block comment decorations

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29943: [clang-format] Align block comment decorations

klimek added inline comments. Comment at: lib/Format/BreakableToken.cpp:397 +// +// Don't try aligning if there are less lines, since some patterns like +// fewer lines Comment at: lib/Format/BreakableToken.cpp:402 +

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg Comment at: clangd/ASTManager.cpp:138-139 + // Currently we discard all pending requests and just enqueue the latest one. + while (!RequestQueue.empty()) +

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

klimek added inline comments. Comment at: clangd/ASTManager.h:67 + /// Setting Done to true will make the worker thread terminate. + std::atomic Done; +}; bkramer wrote: > klimek wrote: > > arphaman wrote: > > > It looks like `Done` is always accessed in a

[PATCH] D29886: [clangd] Wire up ASTUnit and publish diagnostics with it.

klimek added inline comments. Comment at: clangd/ASTManager.cpp:69 + // our one-element queue is empty. + if (!RequestIsPending && !Done) +ClangRequestCV.wait(Lock); arphaman wrote: > This is just a suggestion based on personal opinion:

[PATCH] D27810: Normalize all filenames before searching FileManager caches

klimek added inline comments. Comment at: lib/Basic/FileManager.cpp:167-168 DirNameStr = DirName.str() + '.'; +llvm::sys::path::native(DirNameStr); +DirName = DirNameStr; + } else { I'd add a canonicalizePath function that: -> on unix just returns

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg. I'd probably still call it consumeComments or something, as we require a flush afterwards for the unconsumed comments, but I don't feel too strongly about that.

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

klimek added inline comments. Comment at: lib/Format/UnwrappedLineParser.h:121-123 + // Comments specifies the sequence of comment tokens to analyze. They get + // either pushed to the current line or added to the comments before the next + // token. krasimir

[PATCH] D29699: [clang-tidy] Add -extra-arg and -extra-arg-before to clang-tidy-diff.py

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

klimek added inline comments. Comment at: lib/Format/UnwrappedLineParser.h:121-123 + // Comments specifies the sequence of comment tokens to analyze. They get + // either pushed to the current line or added to the comments before the next + // token. krasimir

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

klimek added inline comments. Comment at: lib/Format/UnwrappedLineParser.h:121-123 + // Comments specifies the sequence of comment tokens to analyze. They get + // either pushed to the current line or added to the comments before the next + // token. Given

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

klimek added inline comments. Comment at: lib/Format/UnwrappedLineParser.cpp:2207-2208 +const FormatToken *NextTok) { + // Decides which comment tokens should be added to the current line and which + // should be added as comments before the next token. + //

[PATCH] D29626: [clang-format] Break before a sequence of line comments aligned with the next line.

klimek added a comment. I think this looks pretty good. More comments would help :) Also, organize is spelled with a 'z' in American. https://reviews.llvm.org/D29626 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D29221: clang-format-vsix: "format on save" feature

klimek added a reviewer: hans. klimek added a comment. +hans +1 to "format only current document but save all" not making much sense :) Comment at: tools/clang-format-vs/ClangFormat/TypeConverterUtils.cs:7 +{ +public sealed class TypeConverterUtils +{

[PATCH] D29622: Add a batch query and replace tool based on AST matchers.

klimek added inline comments. Comment at: clang-query/QueryReplace.cpp:50 + +void QueryReplaceTool::addOperation(clang::query::QueryReplaceSpec ) { + ast_matchers::dynamic::Diagnostics Diag; Shouldn't that also just return the error? Comment

[PATCH] D29451: Add a prototype for clangd v0.1

klimek added inline comments. Comment at: clangd/JSONRPCDispatcher.h:25-32 + virtual ~Handler() = default; + + /// Called when the server receives a method call. This is supposed to return + /// a result on Outs. + virtual void handleMethod(llvm::yaml::MappingNode *Params,

[PATCH] D29451: Add a prototype for clangd v0.1

klimek accepted this revision. klimek added a comment. LG. Couple of questions. Comment at: clangd/ClangDMain.cpp:65 +// Now read the JSON. +std::vector JSON; +JSON.resize(Len); Adi wrote: > Avoid unnecessary JSON.resize(Len) & potential

[PATCH] D29322: [clang-format] Fix regression merging comments across newlines.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg minus adding the FIXME to the place where we need the change. Comment at: lib/Format/UnwrappedLineParser.cpp:2127-2129 +// Additional fine-grained breaking of line

[PATCH] D29300: [clang-format] Refactor WhitespaceManager and friends

klimek added a comment. Generally looks like the right direction, minus that I'm not sure yet what the plan for things broken in BreakableToken are. Comment at: lib/Format/TokenAnnotator.cpp:1843 +Current->MatchingParen->opensBlockOrBlockTypeList(Style)) +

[PATCH] D29271: Revert r293455, which breaks v8 with a spurious error. Testcase added.

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. lg https://reviews.llvm.org/D29271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28764 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

klimek added inline comments. Comment at: lib/Format/BreakableToken.cpp:747 +Split SplitBefore, WhitespaceManager ) { + // If this is the first line of a token, we need to inform Whitespace Manager + // about it: either adapt the whitespace range preceding it, or mark it

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

klimek added inline comments. Comment at: lib/Format/BreakableToken.cpp:279-280 + return Content.size() >= 2 && + Content != "clang-format on" && + Content != "clang-format off" && + !Content.endswith("\\") && Can we now use delimitsRegion here?

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

klimek added inline comments. Comment at: lib/Format/BreakableToken.h:42-48 +/// There is a pair of operations that are used to compress a long whitespace +/// range with a single space if that will bring the line lenght under the +/// column limit: +/// -

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

klimek added a comment. This is starting to be pretty awesome. The one thing that would help me review the gist of the implementation a bit more is if that had a bit more comments. Perhaps go over the math in the code and put some comments in why we're doing what at various steps.

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

klimek added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1158-1159 +CommentPragmasRegex.match(Current.TokenText.substr(2)) || +Current.TokenText.substr(2).ltrim().startswith("clang-format on") || +

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

klimek added inline comments. Comment at: lib/Format/BreakableToken.h:55-56 +/// been reformatted, and +/// - replaceWhitespaceBefore, for executing the reflow using a whitespace +/// manager. +/// Shouldn't that be called insertBreakBefore for consistency

[PATCH] D28764: [clang-format] Implement comment reflowing (v3)

klimek added inline comments. Comment at: lib/Format/BreakableToken.h:40 +/// of the content after a split has been used for breaking, and +/// - insertBreak, for executing the split using a whitespace manager. +/// Do we want to describe how replaceWhitespace

[PATCH] D28548: Improve include fixer's ranking by taking the paths into account.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291664: Improve include fixer's ranking by taking the paths into account. (authored by klimek). Changed prior to commit: https://reviews.llvm.org/D28548?vs=83930=83937#toc Repository: rL LLVM

[PATCH] D28548: Improve include fixer's ranking by taking the paths into account.

klimek created this revision. klimek added a reviewer: bkramer. klimek added a subscriber: cfe-commits. Instead of just using popularity, we also take into account how similar the path of the current file is to the path of the header. Our first approach is to get popularity into a reasonably

[PATCH] D28260: Add an argumentsAre matcher

klimek added a reviewer: bkramer. klimek added a comment. +benjamin https://reviews.llvm.org/D28260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28465: clang-format: [JS] ASI after imports

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27971: Make FormatStyle.GetStyleOfFile test work on MSVC

klimek added inline comments. Comment at: lib/Format/Format.cpp:1920-1922 + std::error_code EC = FS->makeAbsolute(Path); + assert(!EC); + (void)EC; amaiorano wrote: > klimek wrote: > > I think if makeAbsolute doesn't work, we will probably want to err out

[PATCH] D27971: Make FormatStyle.GetStyleOfFile test work on MSVC

klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land. Apart from the error handling LG. Thanks! Comment at: lib/Format/Format.cpp:1920-1922 + std::error_code EC = FS->makeAbsolute(Path); + assert(!EC); + (void)EC;

[PATCH] D27971: Make FormatStyle.GetStyleOfFile test work on MSVC

klimek added a comment. Why isn't the right solution to make getStyle() use vfs::FileSystem? Generally, everything in clang-format (well, in clang) should use vfs::FileSystem for file access. https://reviews.llvm.org/D27971 ___ cfe-commits

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

klimek added a comment. In https://reviews.llvm.org/D27440#626477, @amaiorano wrote: > In https://reviews.llvm.org/D27440#626415, @ioeric wrote: > > > `llvm::ErrorOr` carries `std::error_code`. If you want richer information > > (e.g. error_code + error message), `llvm::Expcted` and

[PATCH] D27440: clang-format-vsix: fail when clang-format outputs to stderr

klimek added a reviewer: ioeric. klimek added a comment. +eric, who has some experience llvm::Error'ing our interfaces :) llvm::ErrorOr seems like the right approach here? https://reviews.llvm.org/D27440 ___ cfe-commits mailing list

[PATCH] D27754: [clang-format] Implement comment reflowing (again).

klimek added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:1174-1175 LineIndex != EndIndex; ++LineIndex) { -if (!DryRun) - Token->replaceWhitespaceBefore(LineIndex, Whitespaces); +Token->replaceWhitespaceBefore(LineIndex,

[PATCH] D27754: [clang-format] Implement comment reflowing (again).

klimek added inline comments. Comment at: lib/Format/BreakableToken.cpp:471 + WhitespaceManager ) { + if (Tok.is(TT_LineComment)) { +// If this is the first line of a token, inform Whitespace Manager about it.

<    1   2   3   4   5   6   >