[PATCH] D34475: [AArch64] Add support for __builtin_ms_va_list on aarch64

mstorsjo updated this revision to Diff 106701. mstorsjo added a comment. Updated for the new version of https://reviews.llvm.org/D34474. https://reviews.llvm.org/D34475 Files: include/clang-c/Index.h include/clang/Basic/Builtins.def include/clang/Basic/BuiltinsX86.def include/clang/Basi

[PATCH] D35465: [clang] Remove redundant check-prefix=CHECK from tests. NFC.

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. Looks ok to me, at least for the one file that I wrote. https://reviews.llvm.org/D35465 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D34475: [AArch64] Add support for __builtin_ms_va_list on aarch64

mstorsjo added a comment. Reid, with https://reviews.llvm.org/D34474 approved, does this look like what you had in mind? https://reviews.llvm.org/D34475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D34475: [AArch64] Add support for __builtin_ms_va_list on aarch64

This revision was automatically updated to reflect the committed changes. Closed by commit rL308218: [AArch64] Add support for __builtin_ms_va_list on aarch64 (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D34475?vs=106701&id=106941#toc Repository: rL LLVM https:/

[PATCH] D35529: [COFF, ARM64] Make +reserve-x18 the default

mstorsjo added a comment. Wouldn't it make more sense to set this by default within LLVM, where it's already enabled by default for darwin? Currently there's this code there: AArch64Subtarget::AArch64Subtarget(const Triple &TT, const std::string &CPU, cons

[PATCH] D35546: [AArch64] Produce correct defaultlib directives for windows in MSVC style

mstorsjo created this revision. Herald added subscribers: kristof.beyls, rengolin, aemerson. https://reviews.llvm.org/D35546 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/pragma-comment.c Index: test/CodeGen/pragma-comment.c =

[PATCH] D35546: [AArch64] Produce correct defaultlib directives for windows in MSVC style

This revision was automatically updated to reflect the committed changes. Closed by commit rL308584: [AArch64] Produce correct defaultlib directives for windows in MSVC style (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D35546?vs=107058&id=107443#toc Repository:

[PATCH] D35862: [clang] Add ARM64 support to armintr.h for MSVC compatibility

mstorsjo added a comment. The Microsoft version of `intrin.h` includes a header named `arm64intr.h` (IIRC), I think it'd be better for compatibility if we also provided a file with the same name instead of reusing this one. https://reviews.llvm.org/D35862 ___

[PATCH] D35934: [Headers] Add a test for arm64intr.h

mstorsjo created this revision. Herald added subscribers: kristof.beyls, aemerson. This tests the ARM64 specific constants added in SVN r309081, similar to the one added in r277928 for armintr.h. https://reviews.llvm.org/D35934 Files: test/Headers/ms-intrin.cpp Index: test/Headers/ms-intri

[PATCH] D35934: [Headers] Add a test for arm64intr.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL309314: [Headers] Add a test for arm64intr.h (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D35934?vs=108438&id=108515#toc Repository: rL LLVM https://reviews.llvm.org/D35

[PATCH] D41906: [libunwind][PPC64] Added vector registers.

mstorsjo added a comment. No objections from me on this. There were a few stray cosmetic changes that perhaps could be split out, but it's not big enough that I'd object to it. So if @compnerd doesn't mind, I'll commit this. Repository: rL LLVM https://reviews.llvm.org/D41906 ___

[PATCH] D41906: [libunwind][PPC64] Added vector registers.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322596: [PPC64] Added vector registers. (authored by mstorsjo, committed by ). Repository: rL LLVM https://reviews.llvm.org/D41906 Files: libunwind/trunk/include/__libunwind_config.h libunwind/tru

[PATCH] D42555: [libunwind] Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs

mstorsjo created this revision. mstorsjo added reviewers: compnerd, smeenai, phosek. Herald added subscribers: kristof.beyls, aemerson. Otherwise, a shared library build with SJLJ APIs enabled would end up with duplicate symbols. This didn't occur for the apple && arm case due to specifically ch

[PATCH] D42555: [libunwind] Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs

This revision was automatically updated to reflect the committed changes. Closed by commit rL323499: Don't enable _LIBUNWIND_BUILD_ZERO_COST_APIS if building the SJLJ APIs (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.ll

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

mstorsjo created this revision. mstorsjo added reviewers: rnk, majnemer, compnerd, smeenai. This fixes building Qt as shared libraries with clang in MinGW mode; previously subclasses of the QObjectData class (in other DLLs than the base DLL) failed to find the typeinfo symbols (that neither were

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

mstorsjo updated this revision to Diff 131783. mstorsjo added a comment. Remove a few accidentally leftover parts of the new testcase. https://reviews.llvm.org/D42641 Files: lib/CodeGen/CGVTables.cpp test/CodeGenCXX/dllimport-missing-key.cpp test/CodeGenCXX/dllimport-rtti.cpp test/CodeG

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

mstorsjo added inline comments. Comment at: lib/CodeGen/CGVTables.cpp:887-888 + if (CGM.getTriple().isWindowsGNUEnvironment() && RD->hasAttr()) +return true; + majnemer wrote: > Maybe a comment like "VTables of classes declared as dllimport are always >

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

mstorsjo updated this revision to Diff 132045. mstorsjo added a comment. Adjusted the fix by moving the change into ShouldUseExternalRTTIDescriptor - this causes less changes to other tests. @majnemer - do you think this is better or worse than having the fix in isVTableExternal? https://revie

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

mstorsjo added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2766 +// Don't import the RTTI but emit it locally +if (CGM.getTriple().isWindowsGNUEnvironment() && IsDLLImport) + return false; compnerd wrote: > Can't this be simplified to

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

mstorsjo added inline comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:2766 +// Don't import the RTTI but emit it locally +if (CGM.getTriple().isWindowsGNUEnvironment() && IsDLLImport) + return false; mstorsjo wrote: > compnerd wrote: > > Can't th

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL324059: [MinGW] Emit typeinfo locally for dllimported classes without key functions (authored by mstorsjo, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://revie

[PATCH] D42641: [MinGW] Emit typeinfo locally for dllimported classes without key functions

mstorsjo added a subscriber: hans. mstorsjo added a comment. @hans I'd like to have this in 6.0 as well, to allow building Qt for windows as DLLs. Repository: rL LLVM https://reviews.llvm.org/D42641 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D116088: [compiler-rt] Implement ARM atomic operations for architectures without SMP support

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. I think this looks reasonable. I haven't tried it, but I guess we should proceed with it instead of holding it back, as there's nobody else reviewing it. Repository: rG LLVM Github Mono

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo added a comment. In D111081#3212890 , @mgorny wrote: > Well, I dunno how MinGW works, so can't judge that part. Furthermore, I'm > thoroughly confused why this works on top of existing (non-Gentoo?) test > tree. Could you explain it a bit more?

[PATCH] D106674: Runtime for Interop directive

mstorsjo added inline comments. Comment at: openmp/runtime/src/dllexports:553 +omp_get_interop_ptr 761 +omp_get_interop_str 762 jdoerfert wrote: > Those values are taken by now, you need new values that are not ta

[PATCH] D106674: Runtime for Interop directive

mstorsjo added inline comments. Comment at: openmp/runtime/src/dllexports:553 +omp_get_interop_ptr 761 +omp_get_interop_str 762 mstorsjo wrote: > jdoerfert wrote: > > Those values are taken by now, you need new va

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo marked an inline comment as done. mstorsjo added a comment. Any further comments on this one, or is tolerable in this form? I'd prefer to not move the unescaping to shared code for now (as the exact definition of what it should do is a bit open). Repository: rG LLVM Github Monorepo

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo added a comment. In D100756#2717331 , @amccarth wrote: > There's a lot going on here, but I don't see anything wrong. Thanks for the > completeness of the tests and the comments, as that helps a lot in > understanding what's going on here. Th

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf8de9aaef2f4: [llvm-rc] Add a GNU windres-like frontend to llvm-rc (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D1007

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added subscribers: smeenai, mstorsjo. mstorsjo added a comment. In D101479#2733303 , @thakis wrote: > How does this interact with `/MT` / `/MD`? Does this link the static or the > dynamic libc++? If the former, does that do the right thing for D

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2733434 , @thakis wrote: > In D101479#2733354 , @mstorsjo > wrote: > >> Not sure if we want the desicion between static and shared libc++ be coupled >> with `/MT` and `/MD`,

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2740895 , @phosek wrote: > On other platforms the decision whether to use static or shared is controlled > by `-static-libstdc++`, does CL have a similar flag or shall we support > `-static-libstdc++` in MSVC driver

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2741223 , @phosek wrote: > In D101479#2741202 , @mstorsjo > wrote: > >> In D101479#2740895 , @phosek wrote: >> >>> On other platforms

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2748189 , @amccarth wrote: > In D101479#2733354 , @mstorsjo > wrote: > >> Not sure if we want the desicion between static and shared libc++ be coupled >> with `/MT` and `/MD`

[PATCH] D101479: [Driver] Support libc++ in MSVC

mstorsjo added a comment. In D101479#2750765 , @amccarth wrote: > Ah, thanks for explaining that! In the VC++ stack, `/MD` and `/MT` make the > DLL/static choice for the CRT, the C++ standard library, and the compiler > runtime.[1] It never occurred t

[PATCH] D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker

mstorsjo added a reviewer: MaskRay. mstorsjo added a comment. Adding more potential reviewers. For context, see https://github.com/llvm/llvm-project/blob/llvmorg-14-init/clang/lib/Driver/Driver.cpp#L335-L353 where the original option is filtered out. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D116485: [clang][MinGW] Explicitly ignore `-fPIC` & friends

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, thanks. The fact that GCC used to emit a non-fatal warning for this option, but no longer does, probably is the key deciding factor here. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker

mstorsjo added a comment. In D114064#3216147 , @Ericson2314 wrote: > Not sure what the exact division of labor is between the GNU and MinGW > backends, but assuming there is no way to share this between them the patch > looks good. Yeah. Also at this

[PATCH] D100810: [llvm] Use `GNUInstallDirs` to support custom installation dirs

mstorsjo added inline comments. Comment at: llvm/CMakeLists.txt:75 set(LLVM_ENABLE_PROJECTS "" CACHE STRING - "Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS}), or \"all\".") + "Semicolon-separated list of projects to build (${LLVM_KNOWN_PROJECTS})

[PATCH] D114064: [clang] [MinGW] Pass --no-demangle through to the mingw linker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa8877c5ccc0e: [clang] [MinGW] Pass --no-demangle through to the mingw linker (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116503: [clang] Add arguments for silencing unused argument warnings for some but not all arguments

mstorsjo created this revision. mstorsjo added reviewers: aaron.ballman, sepavloff, phosek, MaskRay. Herald added a subscriber: dang. mstorsjo requested review of this revision. Herald added a project: clang. When passing a set of flags to configure defaults for a specific target (similar to the c

[PATCH] D116020: [clang][#52782] Bail on incomplete parameter type in stdcall name mangling

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, the change seems sensible to me. But I’d prefer if you could hold off pushing it for another couple days, as others who might want to comment might not be following during the holida

[PATCH] D116503: [clang] Add arguments for silencing unused argument warnings for some but not all arguments

mstorsjo added a comment. In D116503#3221083 , @MaskRay wrote: > A more searchable subject (mentioning the new option in the subject is useful > for archaeology) may be `Add > --start-no-unused-arguments/--end-no-unused-arguments to silence some unused

[PATCH] D116503: [clang] Add arguments for silencing unused argument warnings for some but not all arguments

mstorsjo updated this revision to Diff 397476. mstorsjo added a comment. Regenerated ClangCommandLineReference.rst (with the relevant changes), removed NoXarchOption. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116503/new/ https://reviews.llvm.o

[PATCH] D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings

mstorsjo updated this revision to Diff 397719. mstorsjo marked 2 inline comments as done. mstorsjo added a comment. Add testcases for using the new option with clang-cl, use `--target=` everywhere. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1165

[PATCH] D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings

mstorsjo added a comment. In D116503#3223094 , @MaskRay wrote: > But make sure to wait a bit to see what others think. Do you think it's ok to go ahead and land this change now, or should I wait a bit more? (I'd like to have it landed with enough margin

[PATCH] D116503: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence some unused argument warnings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG50ec1306d060: [clang] Add --start-no-unused-arguments/--end-no-unused-arguments to silence… (authored by mstorsjo). Repository: rG LLVM Github Mo

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

mstorsjo added a comment. The relanded version in rG41fbdfa4d5601cccbcdc0ded8ef35190d502f7f3 seems to be breaking some builds with PCH for me, failing asserts like this: clang: ../tools/clang/include/clang/Basic/SourceLocat

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

mstorsjo added a comment. Ok, now I managed to make a standalone reproducer: https://martin.st/temp/pch-preproc.hxx and https://martin.st/temp/main-preproc.cpp $ bin/clang -target x86_64-w64-mingw32 -w -x c++-header -c pch-preproc.hxx -o pch-preproc.hxx.pch -std=c++17 -O3 $ bin/clang -targ

[PATCH] D116919: [AST] Add RParen loc for decltype AutoTypeloc.

mstorsjo added a comment. In D116919#3247887 , @hokein wrote: > Thanks, everyone! > > I manage to figure out the cause, the crash was caused by an arbitrary > RPareLoc -- we missed to set the RPareLoc in > `TreeTransform::TransformAutoType`. I reland th

[PATCH] D115045: [Clang] Ignore CLANG_DEFAULT_LINKER for custom-linker toolchains

mstorsjo added a comment. In D115045#3175648 , @phosek wrote: > Rather, we shouldn't consider `-DCLANG_DEFAULT_LINKER=lld` as a valid value. > Instead AMDGPU bot should use `-DCLANG_DEFAULT_LINKER=ld.lld`. I think this would be a kinda disruptive change

[PATCH] D113254: [clang] Fix a misadjusted path style comparison in a unittest

mstorsjo added a comment. Yeah I guess I should have just committed this as trivial. Anyway, it doesn't seem to have had any notable impact on anything - luckily. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113254/new/ https://reviews.llvm.org/D

[PATCH] D113254: [clang] Fix a misadjusted path style comparison in a unittest

This revision was automatically updated to reflect the committed changes. Closed by commit rG120d44d1a00b: [clang] Fix a misadjusted path style comparison in a unittest (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113254/new/

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

mstorsjo added a comment. In D115441#3187009 , @rnk wrote: > I seem to recall assuming that Windows `long double` was 64-bits in many, > many places. Unfortunately, I have no idea where that could've happened. Nothing comes to mind for me about that - i

[PATCH] D115441: [X86][MS] Add 80bit long double support for Windows

mstorsjo added a comment. In D115441#3188172 , @pengfei wrote: >> In GCC on Windows (and clang in mingw mode), long double is always 80 bit on >> x86. (On i386, sizeof(long double) == 12, while on x86_64 it's 16.) > > How about the alignment? I can see o

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

mstorsjo added a comment. Btw, while this change does explain _what_ it does, it doesn't actually say the exact reason _why_. Cleanliness? Sure, that's nice... Or is it a case where e.g. some translations produce different error messages? Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

mstorsjo added a comment. In D98278#2637866 , @zero9178 wrote: > In D98278#2637826 , @mstorsjo wrote: > >> Btw, while this change does explain _what_ it does, it doesn't actually say >> the exact reason _why_. Clea

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

mstorsjo added a comment. In D98278#2637866 , @zero9178 wrote: > In D98278#2637826 , @mstorsjo wrote: > >> Btw, while this change does explain _what_ it does, it doesn't actually say >> the exact reason _why_. Clea

[PATCH] D98278: [test] Add ability to get error messages from CMake for errc substitution

mstorsjo added a comment. In D98278#2639481 , @zero9178 wrote: > Changes in this patch are based on this one https://reviews.llvm.org/D97472. > In the discussion there it was deemed not a good solution to use case > insensitive comparison as that would m

[PATCH] D99330: [clang-tidy] [test] Tweak a regex pattern to accommodate for quirks in MSYS based grep

mstorsjo created this revision. mstorsjo added a reviewer: rnk. Herald added a subscriber: xazax.hun. mstorsjo requested review of this revision. Herald added a project: clang-tools-extra. Currently on Windows, 'not' is a regular win32 executable, which parses command line parameters according to

[PATCH] D94355: [Passes] Add relative lookup table converter pass

mstorsjo added a comment. It looks like this is breaking the Windows/ARM(64) target - it doesn't produce the right relative relocations for symbol differences. It can be reproduced with a testcase like this: $ cat test.s .text func1: ret func2: ret

[PATCH] D94355: [Passes] Add relative lookup table converter pass

mstorsjo added a comment. In D94355#2657881 , @mstorsjo wrote: > It looks like this is breaking the Windows/ARM(64) target - it doesn't > produce the right relative relocations for symbol differences. It can be > reproduced with a testcase like this: > >

[PATCH] D99973: [Windows] Add test coverage for line endings when rewriting includes

mstorsjo added a comment. Not very familiar with the feature, but from the linked discussion it looks sensible to me, so +1, I can give a formal stamp a bit later if nobody else does. Comment at: clang/test/Frontend/rewrite-includes-macros.cpp:15 +} \ No newline at end of fil

[PATCH] D100374: [clang] [AArch64] Fix Windows va_arg handling for larger structs

mstorsjo created this revision. mstorsjo added reviewers: rnk, efriedma, TomTan, maxim-kuvyrkov. Herald added subscribers: danielkiss, pengfei, kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. Aggregate types over 16 bytes are passed by reference. Contrary

[PATCH] D40660: Enable auto-linking on Windows

mstorsjo edited subscribers, added: libcxx-commits, mstorsjo; removed: llvm-commits, cfe-commits. mstorsjo added a comment. I see that @smeenai brought up the inconsistency between `_DLL` and `_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS` already back when this was reviewed. I'm running into problems

[PATCH] D100374: [clang] [AArch64] Fix Windows va_arg handling for larger structs

mstorsjo added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:6106 uint64_t Members = 0; IsIndirect = !isHomogeneousAggregate(Ty, Base, Members); } rnk wrote: > rnk wrote: > > Do we need to worry about H[VF]As passed to variadic functi

[PATCH] D94355: [Passes] Add relative lookup table converter pass

mstorsjo added a comment. In D94355#2665532 , @gulfem wrote: >> Would you be ok with reverting this change until I can sort that out, or can >> we disable the pass for those targets until then? > > I will disable the pass for those targets for now. > When

[PATCH] D100374: [clang] [AArch64] Fix Windows va_arg handling for larger structs

This revision was automatically updated to reflect the committed changes. Closed by commit rG3637c5c8ec3d: [clang] [AArch64] Fix Windows va_arg handling for larger structs (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100374/n

[PATCH] D100467: [clang] [AArch64] Fix handling of HFAs passed to Windows variadic functions

mstorsjo created this revision. mstorsjo added reviewers: rnk, efriedma, TomTan, maxim-kuvyrkov. Herald added subscribers: danielkiss, kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. The documentation says that for variadic functions, all composites are tr

[PATCH] D100468: [clang] [test] Share patterns in CodeGen/ms_abi_aarch64.c between cases. NFC.

mstorsjo created this revision. mstorsjo added reviewers: rnk, efriedma, TomTan, maxim-kuvyrkov. Herald added subscribers: danielkiss, kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D100468

[PATCH] D99330: [clang-tidy] [test] Tweak a regex pattern to accommodate for quirks in MSYS based grep

mstorsjo abandoned this revision. mstorsjo added a comment. Not needed, handled by D99938 for now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99330/new/ https://reviews.llvm.org/D99330 _

[PATCH] D100468: [clang] [test] Share patterns in CodeGen/ms_abi_aarch64.c between cases. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rGee570e215353: [clang] [test] Share patterns in CodeGen/ms_abi_aarch64.c between cases. NFC. (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D100467: [clang] [AArch64] Fix handling of HFAs passed to Windows variadic functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e0f2e89ff95: [clang] [AArch64] Fix handling of HFAs passed to Windows variadic functions (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D100467?vs=337412&id=337866#toc Repos

[PATCH] D100755: [llvm-rc] [3/4] Run clang to preprocess input files

mstorsjo updated this revision to Diff 338969. mstorsjo added a comment. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. - Added a testcase under clang/test/Preprocessor - Changed the option to -no-preprocess - Removed the env var for disabling preprocessing - Made it

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo updated this revision to Diff 338978. mstorsjo added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebased on top of the updated preceding patch. Adjusted the logic for picking th e default triple, to preserve the exact spelling of the default triple, i

[PATCH] D100755: [llvm-rc] [3/4] Run clang to preprocess input files

mstorsjo added inline comments. Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:94 + +ErrorOr findClang(const char *Argv0) { + StringRef Parent = llvm::sys::path::parent_path(Argv0); aganea wrote: > Since you're not using the `std::error_code` below in the call site,

[PATCH] D100755: [llvm-rc] [3/4] Run clang to preprocess input files

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG64bc44f5ddfb: [llvm-rc] Run clang to preprocess input files (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.org/D100755?vs=3

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: clang/test/Driver/woa-crypto.c:2 +// RUN: %clang -target arm-windows-msvc -### -S %s -O0 -o /dev/null 2>&1 | FileCheck %s

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo updated this revision to Diff 339158. mstorsjo added a comment. Rebased, updated with fixes making the full preprocessing test pass on windows, including fixes for the default arch when running on arches that aren't normally supported as windows targets. Repository: rG LLVM Github M

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

mstorsjo added a comment. In D100937#2704530 , @simon_tatham wrote: > Yes, it looks easy enough to add something in > `llvm/unittests/ADT/TripleTest.cpp` to directly test `getARMCPUForArch`. > > I'd mildly prefer to do that //as well// as having the tes

[PATCH] D100937: [ARM][Driver][Windows] Allow command-line upgrade to Armv8.

mstorsjo accepted this revision. mstorsjo added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100937/new/ https://reviews.llvm.org/D100937 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo added inline comments. Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:259 -} // anonymous namespace +static bool consume_back_lower(StringRef &S, const char *str) { + if (!S.endswith_lower(str)) aganea wrote: > `s/str/Str/` Thanks, will fix. ===

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo updated this revision to Diff 339263. mstorsjo added a comment. Updated the capitalization of one variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100756/new/ https://reviews.llvm.org/D100756 Files: clang/test/CMakeLists.txt cla

[PATCH] D100756: [llvm-rc] [4/4] Add a GNU windres-like frontend to llvm-rc

mstorsjo marked an inline comment as done. mstorsjo added inline comments. Comment at: llvm/tools/llvm-rc/llvm-rc.cpp:300 + +std::string unescape(StringRef S) { + std::string Out; aganea wrote: > mstorsjo wrote: > > aganea wrote: > > > I would also need this fun

[PATCH] D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm

mstorsjo created this revision. mstorsjo added reviewers: rnk, compnerd, smeenai. Herald added a subscriber: kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D94364 Files: clang/lib/Basic/Ta

[PATCH] D94364: [clang] Allow specifying the aapcs and aapcs-vfp for windows on arm

mstorsjo added a comment. In D94364#2490743 , @compnerd wrote: > Can you please add some more context around the motivation for this change? > It seems ... unnecessary as everything is already AAPCS/AAPCS-VFP. Yeah it's a redundant attribute, but I don'

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo added a comment. The change looks ok to me, but I think it'd be good to have a testcase for finding these paths (IIRC there are a bunch of simulated sysroots under clang/test/Driver). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

mstorsjo added a subscriber: rnk. mstorsjo added a comment. This looks ok to me I guess. Technically in this case, this is pretty much equivalent to `#ifdef _WIN32`, i.e. any form when running on windows, where the process considers itself windows (cygwin doesn't define `_WIN32`), but I guess k

[PATCH] D111707: [clang] [Windows] Mark PIC as implicitly enabled for aarch64, just like for x86_64

mstorsjo created this revision. mstorsjo added reviewers: MaskRay, rnk. Herald added a subscriber: kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. This doesn't practically affect the code generation. Repository: rG LLVM Github Monorepo https://reviews

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95/new/ https://reviews.llvm.org/D95 ___ cfe-commits mailing list cfe-commi

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo added a comment. Looks ok to me - WDYT @mgorny? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D111707: [clang] [Windows] Mark PIC as implicitly enabled for aarch64, just like for x86_64

mstorsjo added inline comments. Comment at: clang/test/Driver/pic.c:322 // RUN: | FileCheck %s --check-prefix=CHECK-PIC2 +// RUN: %clang -c %s -target aarch64-windows-msvc -### 2>&1 \ +// RUN: | FileCheck %s --check-prefix=CHECK-PIC2 MaskRay wrote: > perhaps

[PATCH] D111707: [clang] [Windows] Mark PIC as implicitly enabled for aarch64, just like for x86_64

mstorsjo added a comment. In D111707#3062361 , @MaskRay wrote: > I was thinking of when testing "windows" x "pic", whether the test should > reside in "windows" or "pic". > If in "windows", we can decrease the number of RUN lines and use one RUN line >

[PATCH] D111707: [clang] [Windows] Mark PIC as implicitly enabled for aarch64, just like for x86_64

This revision was automatically updated to reflect the committed changes. Closed by commit rGb541845ea082: [clang] [Windows] Mark PIC as implicitly enabled for aarch64, just like for… (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D111195: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9b9a7f42870: [clang][Tooling] Use Windows command lines on all Windows, except Cygwin (authored by jeremyd2019, committed by mstorsjo). Repository:

[PATCH] D111457: [clang][test] Add lit helper for windows paths

mstorsjo added a comment. Wouldn't this one also be solved pretty much the same, but differently, by changing `if (llvm::sys::path::is_absolute(RemappedFile)) {` into `is_absolute_gnu`? Since we're remapping debug paths, it's plausible that the target path can be a different style (when cross c

[PATCH] D111579: [clang] Fix DIFile directory root on Windows

mstorsjo added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:439 +if (llvm::sys::path::root_path(DirBuf) == DirBuf) { + // Don't strip the common prefix if it is only the root ("/" or "C:\") // since that would make LLVM diagnostic locations confu

[PATCH] D111952: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

mstorsjo created this revision. mstorsjo added reviewers: phosek, MaskRay. Herald added subscribers: pengfei, kristof.beyls. mstorsjo requested review of this revision. Herald added a project: clang. For x86, most contempory mingw toolchains use i686 as 32 bit x86 arch target. As long as the targ

[PATCH] D111952: [clang] [MinGW] Guess the right ix86 arch name spelling as sysroot

mstorsjo added a comment. I guess a downside of this solution, is that if an `i686` sysroot exists next to the clang binary, it becomes practically impossible to test codegen differences when you run it with various `-target iX86-w64-mingw32` options, as they'd all be corrected back to `i686`.

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

mstorsjo added a comment. I've bisected a crash in generated code down to this commit. The code that crashes is clean when run in ubsan. The misbehaviour happens across 4 tested architectures (i686, x86_64, armv7, aarch64). The misbehaviour occurs in this preprocessed source, https://martin.st

<    7   8   9   10   11   12   13   >