[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny updated this revision to Diff 180114. mgorny edited the summary of this revision. mgorny added a comment. Herald added subscribers: atanasyan, sdardis. Updated to use clang's libdir logic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. @ruiu, what if one of the systems changes defaults (e.g. due to Hardening) and starts defaulting to noexecstack? In that case we'd want `-z execstack' to actually emit PT_GNU_STACK, and I don't think we really are able to 100% detect the default in clang. I'd really see

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. Actually, I've just researched a bit and default stack permissions depend on arch in glibc, so assuming it's RWX by default is wrong. Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554

[PATCH] D56607: [clang] [NetBSD] Enable additional sanitizer types

mgorny created this revision. mgorny added a reviewer: krytarowski. Repository: rC Clang https://reviews.llvm.org/D56607 Files: lib/Driver/ToolChains/NetBSD.cpp Index: lib/Driver/ToolChains/NetBSD.cpp === ---

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny updated this revision to Diff 181268. mgorny added a comment. Implemented checking the triple against target registry. Also made `--version` output the detected target. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215 Files:

[PATCH] D56607: [clang] [NetBSD] Enable additional sanitizer types

mgorny updated this revision to Diff 181356. mgorny added a comment. Herald added a subscriber: cryptoad. Updated the tests to account for most of the known sanitizer types. Notes/TODO: 1. I wasn't able to get a sane match for `-fsanitize=undefined`, so I just check if it enables anything. 2.

[PATCH] D56607: [clang] [NetBSD] Enable additional sanitizer types

This revision was automatically updated to reflect the committed changes. Closed by commit rL351002: [NetBSD] Enable additional sanitizer types (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56647: [WIP] [ELF] Implement --copy-dt-needed-entries

mgorny created this revision. mgorny added reviewers: ruiu, krytarowski. Herald added subscribers: llvm-commits, jfb, arichardson, emaste. Herald added a reviewer: espindola. This is my proof-of-concept on making `--copy-dt-needed-entries` work. Apparently, i've been able to hack on it hard

[PATCH] D56650: [lld] [ELF] Support inferring target triple from filename

mgorny created this revision. mgorny added reviewers: ruiu, joerg, krytarowski, arichardson. Herald added subscribers: llvm-commits, emaste. Herald added a reviewer: espindola. Support inferring the target triple from linker filename (e.g. ${triple}-ld.lld), and customizing the linker behavior

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny added inline comments. Comment at: ELF/Driver.cpp:770 + // Start with a default initial triple + Config->TargetTriple = llvm::Triple(getDefaultTargetTriple()); + krytarowski wrote: > krytarowski wrote: > > arichardson wrote: > > > arichardson wrote: > >

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny updated this revision to Diff 181484. mgorny marked 7 inline comments as done. mgorny set the repository for this revision to rLLD LLVM Linker. mgorny added a comment. Herald added a subscriber: fedor.sergeev. Split target logic into D56650 , switched to

[PATCH] D47819: [compiler-rt] [test] Disable sunrpc tests when rpc/xdr.h is missing

mgorny added a comment. Ping. I'd really like to merge this before the branch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47819/new/ https://reviews.llvm.org/D47819 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:5698 +#if SANITIZER_NETBSD + if (fp->_bf._base) +COMMON_INTERCEPTOR_INITIALIZE_RANGE(fp->_bf._base, krytarowski wrote:

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny updated this revision to Diff 179641. mgorny marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D56158: [sanitizer_common] Implement funopen*() interceptors for NetBSD

mgorny updated this revision to Diff 179728. mgorny added a comment. Renamed stuff as requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56158/new/ https://reviews.llvm.org/D56158 Files: lib/sanitizer_common/sanitizer_common_interceptors.inc

[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

mgorny created this revision. mgorny added reviewers: krytarowski, vitalybuka. Herald added subscribers: Sanitizers, llvm-commits, dberris, kubamracek. Add two new test cases that test the following stdio.h functions: - clearerr() - feof() - ferror() - fileno() - fgetc() - getc() - ungetc()

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny added reviewers: eugenis, kcc. mgorny added a comment. We've been discussing this, and I think we're doing this the wrong way. Could you help me a little understand this? In particular, what is the purpose of unpoisoning file? Is it in order to account for stdio functions being

[PATCH] D56062: [compiler-rt] [test] Detect glibc-2.27+ and XFAIL appropriate tests

This revision was automatically updated to reflect the committed changes. Closed by commit rCRT350717: [test] Detect glibc-2.27+ and XFAIL appropriate tests (authored by mgorny, committed by ). Changed prior to commit: https://reviews.llvm.org/D56062?vs=179456=180824#toc Repository: rCRT

[PATCH] D56062: [compiler-rt] [test] Detect glibc-2.27+ and XFAIL appropriate tests

mgorny added a comment. Ping. Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56062/new/ https://reviews.llvm.org/D56062 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D47817: [compiler-rt] [sanitizer_common] Remove support for tirpc/rpc/xdr.h

mgorny added a comment. Ping again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D47817/new/ https://reviews.llvm.org/D47817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

mgorny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56109/new/ https://reviews.llvm.org/D56109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny updated this revision to Diff 180886. mgorny added a comment. Adjusted to make paths sysroot-relative. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56215/new/ https://reviews.llvm.org/D56215 Files: ELF/Config.h ELF/Driver.cpp ELF/Driver.h Index: ELF/Driver.h

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

mgorny marked 4 inline comments as done. mgorny added a comment. The tests were submitted earlier as D56153 . I'll implement the remaining suggestions. Repository: rCRT Compiler Runtime CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56157/new/

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

mgorny updated this revision to Diff 179842. mgorny added a comment. Updated to use `COMMON_INTERCEPTOR_FILE_OPEN` with `nullptr` argument. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56157/new/ https://reviews.llvm.org/D56157 Files:

[PATCH] D56157: [sanitizer_common] Implement popen, popenve, pclose interceptors

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lib/esan/esan_interceptors.cpp:90 } while (false) +#define COMMON_INTERCEPTOR_PIPE_OPEN(ctx, file) \ + do {

[PATCH] D56215: [lld] [ELF] Include default search paths for NetBSD driver

mgorny added a comment. We've discussed this a bit and given other changes we need to do, and I see pretty much three options here: 1. We hardcode stuff under `defined(__NetBSD__)` which kinda solves the problem, except lld won't be very cross-friendly. 2. We try to do conditionals based on

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny added a comment. Apparently the first change changing the completion results is: commit a408f8d27bfd5bab55c39ef2a6fff6850be4a351 Author: Ilya Biryukov Date: Tue Apr 24 15:48:53 2018 [CodeComplete] Fix completion at the end of keywords Summary: Make

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny added a comment. ...and unless I'm mistaken, this commit is responsible for both changes (that is, I need to apply all of this patch to make tests pass at its point). https://reviews.llvm.org/D50171 ___ cfe-commits mailing list

[PATCH] D50171: [python] [tests] Update test_code_completion

mgorny added a comment. @ilya-biryukov, gentle ping. I'd like to patch this for 7.0.0 in Gentoo. Do you think my patch would be good enough, or do you expect to submit something else soonish? https://reviews.llvm.org/D50171 ___ cfe-commits

[PATCH] D55828: [clang] [Driver] Disable -faddrsig by default on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rC349647: [Driver] Disable -faddrsig by default on NetBSD (authored by mgorny, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55828/new/

[PATCH] D55830: [clang] [Basic] Correct description of SanitizerSet.empty()

This revision was automatically updated to reflect the committed changes. Closed by commit rL349648: [Basic] Correct description of SanitizerSet.empty() (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

mgorny created this revision. mgorny added reviewers: krytarowski, dberris, george.karpenkov. Herald added subscribers: Sanitizers, llvm-commits. Add a code to properly test for presence of LLVMTestingSupport library when performing a stand-alone build, and skip tests requiring it when it is not

[PATCH] D55811: [compiler-rt] [sanitizer_common] Fix sha2 interceptors not to use vars in array len

This revision was automatically updated to reflect the committed changes. Closed by commit rL349645: [sanitizer_common] Fix sha2 interceptors not to use vars in array len (authored by mgorny, committed by ). Herald added a subscriber: delcypher. Changed prior to commit:

[PATCH] D55832: [clang] [Driver] Add .hasAnySanitizer() to SanitizerArgs

This revision was automatically updated to reflect the committed changes. Closed by commit rL349649: [Driver] Add .hasAnySanitizer() to SanitizerArgs (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D55654: [clang] [Driver] [NetBSD] Add -D_REENTRANT when using sanitizers

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rL349650: [Driver] [NetBSD] Add -D_REENTRANT when using sanitizers (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. In D56554#1369606 , @mgorny wrote: > In D56554#1369592 , @ruiu wrote: > > > No, I'm suggesting you add execstack, noexecstack and nognustack as a > > tri-state -z flag. Does this sound

[PATCH] D56932: [Driver] [NetBSD] Pass default library search paths to linker

mgorny added a comment. Gentle ping. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56932/new/ https://reviews.llvm.org/D56932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny updated this revision to Diff 183729. mgorny added a comment. Ok, here's my proposition of using trinary enum. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 Files: ELF/Config.h ELF/Driver.cpp ELF/Writer.cpp docs/ld.lld.1

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

mgorny created this revision. mgorny added reviewers: krytarowski, joerg, phosek, dlj. Herald added a subscriber: dberris. Append appropriate -rpath when using shared compiler-rt runtimes, e.g. '-fsanitize=address -shared-libasan'. There's already a similar logic in CommonArgs.cpp but it uses

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

mgorny added a comment. Given that this path changes with every clang release, so you're effectively making a hard dependency on the clang version used to build the program, I dare say some systems may either decide not to support shared runtimes at all or use `ld.so.conf` or equivalent that

[PATCH] D60046: [python, tests] Disable Clang Python tests on Solaris/SPARC

mgorny requested changes to this revision. mgorny added a comment. This revision now requires changes to proceed. Just add it to the regex above. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60046/new/ https://reviews.llvm.org/D60046

[PATCH] D60046: [python, tests] Disable Clang Python tests on SPARC

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Thanks, looks good. Do you have commit access or do you need me to commit it for you? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60046/new/

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

mgorny added inline comments. Comment at: clang/lib/DirectoryWatcher/DirectoryWatcher-linux.inc.h:135 +if (!statusOpt.hasValue()) + K = DirectoryWatcher::EventKind::Removed; + } akyrtzi wrote: > mgorny wrote: > > akyrtzi wrote: > > > mgorny

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

mgorny created this revision. mgorny added reviewers: krytarowski, joerg, chandlerc, eugenis. Herald added a reviewer: EricWF. Herald added a project: clang. Support locating the libc++ header files relatively to the clang executable, in addition to the default system path. This is meant to

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

mgorny added inline comments. Comment at: clang/lib/DirectoryWatcher/DirectoryWatcher-linux.inc.h:135 +if (!statusOpt.hasValue()) + K = DirectoryWatcher::EventKind::Removed; + } akyrtzi wrote: > mgorny wrote: > > akyrtzi wrote: > > > mgorny

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:430 +// system install from src +getDriver().SysRoot + "/usr/include/c++", + }; krytarowski wrote: > mgorny wrote: > > krytarowski

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: clang/lib/Driver/ToolChains/NetBSD.cpp:430 +// system install from src +getDriver().SysRoot + "/usr/include/c++", + }; krytarowski wrote: > I propose to go for: > >

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

mgorny updated this revision to Diff 188083. mgorny added a comment. Shamelessly increased overhead by checking one more path as requested by Kamil. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58592/new/ https://reviews.llvm.org/D58592 Files: clang/lib/Driver/ToolChains/NetBSD.cpp

[PATCH] D35169: Refactor DragonFly BSD toolchain driver.

mgorny added inline comments. Herald added subscribers: jdoerfert, krytarowski. Comment at: lib/Driver/ToolChains/DragonFly.cpp:118 } - CmdArgs.push_back(Args.MakeArgString(getToolChain().GetFilePath("crti.o"))); -if (Args.hasArg(options::OPT_shared) ||

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

mgorny added a comment. Also, don't forget that `inotify()` is not 100% reliable on Linux, and it can miss events under high loads. So technically you should probably include periodic directory scans if you are going to rely on this actually reporting every file added.

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

mgorny added inline comments. Comment at: clang/lib/DirectoryWatcher/DirectoryWatcher-linux.inc.h:135 +if (!statusOpt.hasValue()) + K = DirectoryWatcher::EventKind::Removed; + } akyrtzi wrote: > mgorny wrote: > > jkorous wrote: > > > mgorny

[PATCH] D58592: [clang] [ToolChains/NetBSD] Support relative libc++ header path

This revision was automatically updated to reflect the committed changes. Closed by commit rL355282: [clang] [ToolChains/NetBSD] Support relative libc++ header path (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D58418: [clang][DirectoryWatcher] Upstream DirectoryWatcher

mgorny added inline comments. Comment at: clang/lib/DirectoryWatcher/DirectoryWatcher-linux.inc.h:196 + while (true) { +if (close(inotifyFD) == -1 && errno == EINTR) + continue; There's some fancy function for this in LLVM. `RetryAfterSignal`, I think.

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny marked 5 inline comments as done. mgorny added inline comments. Comment at: ELF/Config.h:191 bool ZGlobal; + GnuStackKind ZGnustack; bool ZHazardplt; ruiu wrote: > Members are (roughly) sorted alphabetically, so move this below the last > boolean

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny updated this revision to Diff 190681. mgorny marked 2 inline comments as done. mgorny added a comment. Herald added a project: LLVM. Implemented @ruiu's suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 Files:

[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

mgorny added a comment. (apparently because the `CMAKE_MODULE_PATH` logic relies on going backwards to find `cmake/modules` and does not account that the modules will actually be in the same directory) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57063/new/

[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

mgorny added a comment. @phosek, I'm sorry to say but this is apparently breaking stand-alone clang builds: FAILED: lib/Basic/VCSVersion.inc cd /var/tmp/portage/sys-devel/clang-/work/x/y/clang--abi_x86_64.amd64/lib/Basic && /usr/bin/cmake -DNAMES="LLVM;CLANG" -DLLVM_SOURCE_DIR=

[PATCH] D57063: [CMake] Unify scripts for generating VCS headers

mgorny added a comment. Submitted a fix as D57996 . Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57063/new/ https://reviews.llvm.org/D57063 ___ cfe-commits mailing list

[PATCH] D57404: build: remove use of llvm-config

mgorny added a comment. Will overriding `LLVM_BUILD_MAIN_SRC_DIR` work? Gentoo relies on being able to provide sources in another directory since all builds are done in isolated temporary directories. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57404/new/

[PATCH] D57404: build: remove use of llvm-config

mgorny added a comment. I don't think that's going to work on top of unconfigured sources. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57404/new/ https://reviews.llvm.org/D57404 ___ cfe-commits mailing list

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D57303: [ToolChains] [NetBSD] Append -rpath for shared compiler-rt runtimes

This revision was automatically updated to reflect the committed changes. Closed by commit rL352610: [clang] [Driver] [NetBSD] Append -rpath for shared compiler-rt runtimes (authored by mgorny, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. Besides our verbose purists? Not that I'm aware of. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

mgorny added a comment. I think the main concern is that if we link `ld -> ld.lld`, gcc will no longer work out of the box. So we would have to repeat all the logic in gcc and in any other compiler that calls `ld` directly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56650/new/

[PATCH] D56650: [lld] [ELF] Support customizing behavior on target triple

mgorny added a comment. In D56650#1377494 , @ruiu wrote: > But that's only adding missing `-L` and perhaps a few more, no? That doesn't > seem too hard to do in gcc. Probably not, provided nobody will block it. I'm not the one opposed to it. > I don't

[PATCH] D57404: build: remove use of llvm-config

mgorny added a comment. Herald added a project: clang. Could you please update this to match the LLD version? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57404/new/ https://reviews.llvm.org/D57404 ___ cfe-commits

[PATCH] D57521: [CMake] External compiler-rt-configure requires LLVMTestingSupport when including tests

mgorny added a comment. Ideally we wouldn't introduce such a complex dependency for 2 test cases. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57521/new/ https://reviews.llvm.org/D57521 ___ cfe-commits mailing list

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. In D56554#1369592 , @ruiu wrote: > No, I'm suggesting you add execstack, noexecstack and nognustack as a > tri-state -z flag. Does this sound good? Do you mean that of those three options, the last one specified should take

[PATCH] D56554: [ELF] Add '-z nognustack' opt to suppress emitting PT_GNU_STACK

mgorny added a comment. Just to be clear, are you suggesting that I add `-z gnustack` as well? Repository: rLLD LLVM Linker CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56554/new/ https://reviews.llvm.org/D56554 ___ cfe-commits mailing

[PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

mgorny created this revision. mgorny added reviewers: krytarowski, joerg, hans, rsmith. Add a test for tracking PR41027 (8.0 regression breaking assembly code relying on __builtin_constant_p() to identify compile-time constants). Mark it as expected to fail everywhere.

[PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

mgorny added a comment. In D60728#1468486 , @hans wrote: > What's the value in checking in this xfail'ed test without an actual fix for > the problem? 1. It may help whoever tries to address it in the future, to have a known-good reproducer. 2. If

[PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

mgorny updated this revision to Diff 195518. mgorny added a comment. Updated per request. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60728/new/ https://reviews.llvm.org/D60728 Files: clang/test/Sema/pr41027.c Index: clang/test/Sema/pr41027.c

[PATCH] D59744: Fix i386 ABI "__m64" type bug

mgorny added a comment. In D59744#1529182 , @krytarowski wrote: > In D59744#1527412 , @wxiao3 wrote: > > > Consider other Systems (e.g Darwin, PS4 and FreeBSD) don't want to spend > > any effort dealing with the

[PATCH] D60728: [clang] [test] Add a (xfailing) test for PR41027

This revision was automatically updated to reflect the committed changes. Closed by commit rL362587: [clang] [test] Add a (xfailing) test for PR41027 (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D62005: [libunwind] [test] Fix inferring source paths

mgorny marked 2 inline comments as done. mgorny added inline comments. Comment at: libunwind/test/libunwind/test/config.py:27 +self.libcxx_src_root = (self.get_lit_conf('libcxx_src_root') +or os.path.join(self.libunwind_src_root, '../libcxx'))

[PATCH] D62005: [libunwind] [test] Fix inferring source paths

This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rL361931: [libunwind] [test] Fix inferring source paths (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits.

[PATCH] D59744: Fix i386 ABI "__m64" type bug

mgorny added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:1005 bool IsMCUABI; + bool IsLinuxABI; unsigned DefaultNumRegisterParameters; Maybe replace the two booleans with something alike `IsPassInMMXRegABI`? And while at it, include NetBSD

[PATCH] D62005: [libunwind] [test] Fix inferring source paths

mgorny added a comment. Ping. Could somebody review this, please? It's blocking NetBSD buildbot for quite some time already. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62005/new/ https://reviews.llvm.org/D62005

[PATCH] D63062: [clang-format] Added New Style Rule: BitFieldDeclsOnSeparateLines

mgorny requested changes to this revision. mgorny added inline comments. This revision now requires changes to proceed. Comment at: docs/ClangFormatStyleOptions.rst:195 +**BitFieldDeclsOnSeparateLines** (``bool``) + If ``true``, Align Bitfield Declarations on seperate lines. +

[PATCH] D62005: [libunwind] [test] Fix inferring source paths

mgorny added a comment. Ping. Repository: rUNW libunwind CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62005/new/ https://reviews.llvm.org/D62005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D62005: [libunwind] [test] Fix inferring source paths

mgorny created this revision. mgorny added reviewers: jroelofs, krytarowski. Herald added subscribers: libcxx-commits, ldionne, christof. Fix two issues that caused libcxx source path not to be inferred correctly when not specified explicitly: 1. get_lit_conf() uses default value only if the lit

[PATCH] D55616: Emit ASM input in a constant context

mgorny added a comment. Herald added a project: clang. This change apparently introduced a regression: https://bugs.llvm.org/show_bug.cgi?id=41027 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55616/new/ https://reviews.llvm.org/D55616

[PATCH] D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss

mgorny added a comment. In D64666#1613057 , @ziangwan wrote: > The warning is actually correct here. This implicit integral to float > conversion loses precision. Is it the intended behavior of the code? If so, > we can simply add an explicit type cast

[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

mgorny added subscribers: krytarowski, EricWF, mclow.lists, howard.hinnant, mgorny. mgorny added a comment. This change seems to have broken libc++ tests when run with trunk clang:

[PATCH] D67452: [clang] [unittest] Import LLVMTestingSupport if necessary

This revision was automatically updated to reflect the committed changes. Closed by commit rL371733: [clang] [unittest] Import LLVMTestingSupport if necessary (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit:

[PATCH] D67452: [clang] [unittest] Import LLVMTestingSupport if necessary

mgorny added a comment. Thanks. Could you also ack the backport in https://bugs.llvm.org/show_bug.cgi?id=43281? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67452/new/ https://reviews.llvm.org/D67452 ___ cfe-commits mailing list

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny added a comment. In D67585#1670422 , @beanz wrote: > In D67585#1670420 , @mgorny wrote: > > > Sure but I want to build-test practically everything else. I wouldn't mind > > if this didn't basically kill my

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny added a comment. Sure but I want to build-test practically everything else. I wouldn't mind if this didn't basically kill my test system by resource exhaustion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67585/new/ https://reviews.llvm.org/D67585

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny added a comment. Also note that I'm leaving it enabled by default, so only people explicitly opting out would not be testing it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67585/new/ https://reviews.llvm.org/D67585 ___

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny created this revision. mgorny added reviewers: tstellar, sylvestre.ledru, smeenai, beanz. Similarly to how LLVM dylib can be disabled via LLVM_BUILD_LLVM_DYLIB, introduce CLANG_BUILD_CLANG_DYLIB to make it possible to disable building clang's dylib. This is useful for pure testing

[PATCH] D67585: [clang] [cmake] Make building dylib optional

mgorny added a comment. But in that case, we should aim for consistency, i.e. remove the matching option from LLVM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67585/new/ https://reviews.llvm.org/D67585 ___ cfe-commits mailing list

[PATCH] D67719: [clang] [Basic] Enable __has_feature(leak_sanitizer)

mgorny created this revision. mgorny added reviewers: krytarowski, eugenis, leonardchan, vitalybuka, phosek. Add a 'leak_sanitizer' feature akin to existing '*_sanitizer' features to let programmers switch code paths accounting for leak sanitizers being enabled. https://reviews.llvm.org/D67719

[PATCH] D67452: [clang] [unittest] Import LLVMTestingSupport if necessary

mgorny created this revision. mgorny added reviewers: sammccall, gribozavr, compnerd. Herald added subscribers: kadircet, ilya-biryukov. Add LLVMTestingSupport directory from LLVM_MAIN_SRC_DIR when building clang stand-alone and LLVMTestingSupport library is not present. This is needed to fix

[PATCH] D66176: Fix Driver/modules.cpp test to work when build directory name contains '.s'

mgorny added a comment. Ping. This is a really silly issue, and one that could be fixed trivially, so it'd be really nice to actually fix it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66176/new/ https://reviews.llvm.org/D66176

[PATCH] D67719: [clang] [Basic] Enable __has_feature(leak_sanitizer)

mgorny updated this revision to Diff 221155. mgorny added a comment. Test added. Thanks for the suggestion! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67719/new/ https://reviews.llvm.org/D67719 Files: clang/include/clang/Basic/Features.def

[PATCH] D68423: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools

This revision was automatically updated to reflect the committed changes. Closed by commit rL373694: [clang-tools-extra] [cmake] Use add_clang_tool() to install tools (authored by mgorny, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to

[PATCH] D70958: [compiler-rt] [test] Disable ASLR on ASAN/MSAN/TSAN tests on NetBSD

mgorny created this revision. mgorny added reviewers: krytarowski, eugenis, kcc, dvyukov. Herald added subscribers: llvm-commits, dberris. Herald added a project: LLVM. Use a new %run wrapper for ASAN/MSAN/TSAN tests that calls paxctl in order to disable ASLR on the test executables. This makes

[PATCH] D71419: [clang] [test] Disable the test exhausting stack on NetBSD

This revision was automatically updated to reflect the committed changes. Closed by commit rG4c6c1d0f4371: [clang] [test] Disable the test exhausting stack on NetBSD (authored by mgorny). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D71613: [cmake] Use 'llvm-config --components' to determine components

mgorny created this revision. mgorny added reviewers: dberris, justinkb. Herald added projects: LLVM, Sanitizers. Herald added subscribers: llvm-commits, Sanitizers. Use 'llvm-config --components' to determine available components rather than relying on '--libs' to fail for non-available. This

[PATCH] D55891: [compiler-rt] [xray] [tests] Detect and handle missing LLVMTestingSupport gracefully

mgorny added a comment. I've tried fixing llvm-config but that's non-trivial. If I fix it to correctly recognize which components are included in dylib, and return other libraries directly, it just uncovers other problems. Please see if D71613 fixes your

<    1   2   3   4   5   6   7   8   9   >