[chromium-dev] Re: GYP and cross-compiling

On Wed, Oct 7, 2009 at 7:46 PM, Thomas Van Lenten wrote: > It seems like another approach would be to use the target types to indicate > if the library or executable is for the host or native (ie-add types for > host vs. target), then you could use target_conditions to have different > flags. > TV

[chromium-dev] Re: How expensive is setting a crash key for breakpad?

That sounds like a great idea!! Note that there are some limits on crash keys, here's the relevant quote from breakpad.h: """ // User defined key and value string storage. Generally this is used // to configure Breakpad's internal operation, such as whether the // crash_sender should prompt the u

[chromium-dev] How does ResourceHandleInternal::start get called

Hi, I am trying to figure out how does ResourceHandleInternal::start() get called. I put breakpoint in debugger, and I think it is driven by a Timeout: see '#220x071e2b7a in webkit_glue::WebKitClientImpl::DoTimeout at webkitclient_impl.h:97' in the stack track. How can I find out where

[chromium-dev] How expensive is setting a crash key for breakpad?

In fixing a Mac bug, I recently added a layer to intercept -[NSApplication sendAction:to:from:] and make sure a certain message wasn't forwarded if the target was known to be freed. Since this is sort of a core function for event dispatch, now we're seeing crashdumps with my new method on the sta

[chromium-dev] Re: GYP and cross-compiling

It seems like another approach would be to use the target types to indicate if the library or executable is for the host or native (ie-add types for host vs. target), then you could use target_conditions to have different flags. TVL On Wed, Oct 7, 2009 at 10:06 PM, Antoine Labour wrote: > If yo

[chromium-dev] buildbot failure in Chromium on Chromium Builder (dbg), revision 28369

Automatically closing tree for "compile" on "Chromium Builder (dbg)" http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Builder%20%28dbg%29/builds/11678 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20Builder%20%28dbg%29 --=> Automatically closing tree fo

[chromium-dev] GYP and cross-compiling

If you don't care about gyp or cross-compiling, you can skip this message. I've been experimenting with adding host support for cross-compiling into gyp. By this, I mean being able to use the cross-compiler to build Chrome, but still using the host compiler for build tools. "Regular" Chrome, with v

[chromium-dev] buildbot failure in Chromium on Mac10.5 Tests, revision 28352

Automatically closing tree for "unit_tests" on "Mac10.5 Tests" http://build.chromium.org/buildbot/waterfall/builders/Mac10.5%20Tests/builds/6250 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Mac10.5%20Tests --=> Automatically closing tree for "unit_tests" on "Mac10.5 Tests" <=

[chromium-dev] gclient sync getting stuck

I'm trying to run gclient sync, and it seems to get stuck on updating webkit: dhcp-172-31-134-235:Chromium nickbaum$ gclient sync running 'svn update /Users/Shared/Chromium/src-internal' in '/Users/Shared/Chromium' At revision 3449. running 'svn update /Users/Shared/Chromium/src

[chromium-dev] Re: detecting tabs using a lot of CPU?

Umm... shouldn't we be looking into why the tab is taking so much CPU? :) For example, back in April I saw a similar thing happen on Facebook and with WinDbg found that WebKit was simply running in an infinite loop. The WebKit team jumped on this and submitted a fix just 2 days after I reported i

[chromium-dev] buildbot failure in Chromium on Linux Builder (ChromeOS), revision 28326

Automatically closing tree for "compile" on "Linux Builder (ChromeOS)" http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromeOS%29/builds/4193 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux%20Builder%20%28ChromeOS%29 --=> Automatically closing tr

[chromium-dev] Re: Chrome Layout Tests Task Force status updates 10/6

The thing about the media layout tests is ~2 weeks ago all of them were failing. We've flipped switched to get them running and even after disabling a bunch due to flakiness we're still ahead -- just need to keep up the fixes. Andrew On Wed, Oct 7, 2009 at 9:36 AM, Peter Kasting wrote: > BTW, I

[chromium-dev] Re: Local State / Preferences distinction

On Wed, Oct 7, 2009 at 1:26 PM, Tony Chang wrote: > The quasi-defunct profile system that uses the enable-udd-profiles > still has a separate Local State file and safe browsing databases > because it used different user data directory (udd). > > This change seems orthogonal to the profile system

[chromium-dev] Re: Local State / Preferences distinction

The quasi-defunct profile system that uses the enable-udd-profiles still has a separate Local State file and safe browsing databases because it used different user data directory (udd). This change seems orthogonal to the profile system as it is currently implemented. We can resplit the Preferen

[chromium-dev] Re: Local State / Preferences distinction

On Wed, Oct 7, 2009 at 12:52 PM, Tony Chang wrote: > Actually, the original distinction was stuff that could be shared > across computers and stuff that couldn't be shared (i.e., local > state).  I think originally this was for the difference between stuff > that a mounted home directory would sy

[chromium-dev] The Great Webkit Comparison Table

On quirksmode, sponsored by Google, apparently: http://www.quirksmode.org/blog/archives/2009/10/there_is_no_web.html -- Erik Corry, Software Engineer Google Denmark ApS. CVR nr. 28 86 69 84 c/o Philip & Partners, 7 Vognmagergade, P.O. Box 2227, DK-1018 Copenhagen K, Denmark. --~--~-~-

[chromium-dev] Re: Local State / Preferences distinction

Actually, the original distinction was stuff that could be shared across computers and stuff that couldn't be shared (i.e., local state). I think originally this was for the difference between stuff that a mounted home directory would sync and stuff that wouldn't sync. In practice, I think it's

[chromium-dev] Re: [mac] Chromium Helper + ffmpeg binary location == no video

Albert J. Wong wrote: > What is @loader_path relative off of? @loader_path is the directory that contains whatever is being loaded. While loading the main executable, @loader_path is equivalent to @executable_path. If your three dylibs refer to one another and are always in the same directory,

[chromium-dev] Re: [mac] Chromium Helper + ffmpeg binary location == no video

http://developer.apple.com/mac/library/documentation/Darwin/Reference/ManPages/man1/dyld.1.html sorta "relative to the thing loading this" TVL On Wed, Oct 7, 2009 at 3:52 PM, Albert J. Wong (王重傑) wrote: > What is @loader_path relative off of? > > > On Wed, Oct 7, 2009 at 12:35 PM, Mark Mentovai

[chromium-dev] Re: [mac] Chromium Helper + ffmpeg binary location == no video

What is @loader_path relative off of? On Wed, Oct 7, 2009 at 12:35 PM, Mark Mentovai wrote: > My preference would be to place them inside Chromium > Framework.framework, then. If you need to, you can put them inside > Chromium Helper.app/Contents/MacOS instead, but I'm trying really hard > to m

[chromium-dev] Re: detecting tabs using a lot of CPU?

On Wed, Oct 7, 2009 at 12:35 PM, Charles Reis wrote: > Only power users, which is why I think such a button only belongs in an > extension.  (Sorry if that part wasn't clear.) > Basically, I tend to have lots of tabs open, but I'm only using a small set > at any time.  That means I often find mys

[chromium-dev] Local State / Preferences distinction

I was looking at , which is a bug Tony filed to merge the Local State and Preferences files. Both files hold user preferences, but the idea is that Local State holds prefs that are common to all user profiles, and Preferences is unique to each user (thus it is in the Default

[chromium-dev] Re: detecting tabs using a lot of CPU?

Pawel, I was responding to the idea of suspending a tab. I agree that exposing this information to extensions wouldn't be too hard and could be quite useful. On Wed, Oct 7, 2009 at 12:37 PM, Charles Reis wrote: > > > On Wed, Oct 7, 2009 at 12:25 PM, Jeremy Orlow wrote: > >> On Wed, Oct 7, 2009

[chromium-dev] Re: SVN Stable Tree Path for 3.0.195.25

(adding people more familiar with the release process...) On Wed, Oct 7, 2009 at 20:16, Amit Kishnani wrote: > > Hey Elliot, > > thanks for quick turnaround. > > the trunk (svn) : http://src.chromium.org/svn/trunk/src/chrome/VERSION is > > MAJOR=4 > MINOR=0 > BUILD=222 > PATCH=1 > > but I am loo

[chromium-dev] Re: detecting tabs using a lot of CPU?

On Wed, Oct 7, 2009 at 12:25 PM, Jeremy Orlow wrote: > On Wed, Oct 7, 2009 at 11:45 AM, Charles Reis wrote: > >> >> >> On Wed, Oct 7, 2009 at 11:13 AM, Andrew Scherkus >> wrote: >> >>> It'd be nice to have a non-distracting visual indicator, but to play the >>> devil's advocate... >>> What abou

[chromium-dev] Re: [mac] Chromium Helper + ffmpeg binary location == no video

My preference would be to place them inside Chromium Framework.framework, then. If you need to, you can put them inside Chromium Helper.app/Contents/MacOS instead, but I'm trying really hard to minimize the amount of "stuff" inside the app and the helper app. You can get the framework as a bundl

[chromium-dev] Re: detecting tabs using a lot of CPU?

On Wed, Oct 7, 2009 at 21:25, Jeremy Orlow wrote: > I could't imagine many users understanding a feature like this much less > finding it particularly useful. > That's right, an average user would be only confused. Just exposing this info (cpu-hungriness) to extensions seems interesting. > Wha

[chromium-dev] Re: [mac] Chromium Helper + ffmpeg binary location == no video

On Wed, Oct 7, 2009 at 12:17 PM, Mark Mentovai wrote: > > Which processes need to load these libraries? > Render process. > Are these libraries loaded at launch time or by dlopen? > dlopen() > > Mark > > > > --~--~-~--~~~---~--~~ Chromium Developers mailing

[chromium-dev] Re: detecting tabs using a lot of CPU?

On Wed, Oct 7, 2009 at 11:45 AM, Charles Reis wrote: > > > On Wed, Oct 7, 2009 at 11:13 AM, Andrew Scherkus wrote: > >> It'd be nice to have a non-distracting visual indicator, but to play the >> devil's advocate... >> What about intentionally CPU intensive sites that use , , >> WebGL? >> >> What

[chromium-dev] Re: [mac] Chromium Helper + ffmpeg binary location == no video

Which processes need to load these libraries? Are these libraries loaded at launch time or by dlopen? Mark --~--~-~--~~~---~--~~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://grou

[chromium-dev] Re: Why SOCK_SEQPACKET?

On Fri, Oct 2, 2009 at 2:40 PM, Adam Langley wrote: > > On Fri, Oct 2, 2009 at 2:37 PM, Ben Laurie wrote: >> Why will it certainly not work? From what (little) I understand, >> SOCK_SEQPACKET adds record boundaries to SOCK_STREAM ... presumably >> one could simulate that over SOCK_STREAM? > > Th

[chromium-dev] buildbot failure in Chromium on XP Tests (dbg)(1), revision 28278

Automatically closing tree for "unit_tests" on "XP Tests (dbg)(1)" http://build.chromium.org/buildbot/waterfall/builders/XP%20Tests%20%28dbg%29%281%29/builds/13361 http://build.chromium.org/buildbot/waterfall/waterfall?builder=XP%20Tests%20%28dbg%29%281%29 --=> Automatically closing tree for "u

[chromium-dev] Re: [mac] Chromium Helper + ffmpeg binary location == no video

Mark is probably the one to best answer a suggestion here. I'm assuming they also need to be handled in a version fashion with the app, yes? TVL On Wed, Oct 7, 2009 at 2:36 PM, Andrew Scherkus wrote: > On Wed, Oct 7, 2009 at 11:34 AM, Albert J. Wong (王重傑) > wrote: > >> We just noticed that the

[chromium-dev] Re: detecting tabs using a lot of CPU?

On Wed, Oct 7, 2009 at 11:13 AM, Andrew Scherkus wrote: > It'd be nice to have a non-distracting visual indicator, but to play the > devil's advocate... > What about intentionally CPU intensive sites that use , , > WebGL? > > What about scenarios where it's a plugin that's gone haywire? > > Could

[chromium-dev] Re: [mac] Chromium Helper + ffmpeg binary location == no video

On Wed, Oct 7, 2009 at 11:36 AM, Andrew Scherkus wrote: > On Wed, Oct 7, 2009 at 11:34 AM, Albert J. Wong (王重傑) > wrote: > >> We just noticed that the Chromium Helper.app cannot locate the ffmpeg >> binaries (libav*.dylib) in Mac Chromium. This leads to the video feature >> being disabled. :( >>

[chromium-dev] [mac] Chromium Helper + ffmpeg binary location == no video

We just noticed that the Chromium Helper.app cannot locate the ffmpeg binaries (libav*.dylib) in Mac Chromium. This leads to the video feature being disabled. :( Where should the ffmpeg binaries go? Should they be put alongside the binary in the Chromium Helper.app/Contents/MacOS? If we do this,

[chromium-dev] Re: [mac] Chromium Helper + ffmpeg binary location == no video

On Wed, Oct 7, 2009 at 11:34 AM, Albert J. Wong (王重傑) wrote: > We just noticed that the Chromium Helper.app cannot locate the ffmpeg > binaries (libav*.dylib) in Mac Chromium. This leads to the video feature > being disabled. :( > Where should the ffmpeg binaries go? Should they be put alongside

[chromium-dev] Re: SVN Stable Tree Path for 3.0.195.25

Hey Elliot, thanks for quick turnaround. the trunk (svn) : http://src.chromium.org/svn/trunk/src/chrome/VERSION is MAJOR=4 MINOR=0 BUILD=222 PATCH=1 but I am looking for "stable channel" - 3.0.195.125 release instead of "dev channel", please let me know if there is svn repository link with t

[chromium-dev] Re: detecting tabs using a lot of CPU?

It'd be nice to have a non-distracting visual indicator, but to play the devil's advocate... What about intentionally CPU intensive sites that use , , WebGL? What about scenarios where it's a plugin that's gone haywire? Could this be accomplished by an extension that displays a little CPU graph?

[chromium-dev] Re: detecting tabs using a lot of CPU?

I'm not convinced that we should bother users with this kind of stuff. If an advanced user want to see what's consuming resources, they can open the task manager. If we want this for debugging, perhaps it should live behind a flag. It would be cool if some kind combo of dev tools + extensions could

[chromium-dev] Re: Kiosk Mode for Chrome

Most kiosk applications I have developed never leave their designated pages anyway. There are no 'offsite' links or anything. Thus the content is fully controlled. Downloads would not have to be disabled for me. The only 2 key options I would personally want for a kiosk mode, are fullscreen (not m

[chromium-dev] Re: SVN Stable Tree Path for 3.0.195.25

The latest source is in trunk, not a specific release branch. -- Elliot On Tue, Oct 6, 2009 at 12:34 PM, Amit Kishnani wrote: > > Hey Guys, > > what is difference between these releases "3.0.190.2" & "3.0.195.25" > > i can get to "SVN" source tree to "read access" for code tree > "3.0.190.2" us

[chromium-dev] SVN Stable Tree Path for 3.0.195.25

Hey Guys, what is difference between these releases "3.0.190.2" & "3.0.195.25" i can get to "SVN" source tree to "read access" for code tree "3.0.190.2" using the following svn repository url http://src.chromium.org/svn/releases/3.0.190.2/src/ i want to make sure i am getting the latest stable

[chromium-dev] Re: detecting tabs using a lot of CPU?

We had also discussed putting icons indicating audio into tabs. That sounds crowded with icons, though: imaginably a game could have facicon, Unicode symbols, CPU load, audio, and the "x" displayed. I worry there just aren't enough pixels to display all the relevant information. On Wed, Oct 7,

[chromium-dev] Re: detecting tabs using a lot of CPU?

You could replace the favicon with a spinning clock or something. It might also be interesting to provide indicators for high memory usage (or perhaps if the recent memory growth is high), or IPC issues. Then again, many users might prefer not to have their tabs attracting attention needlessly.

[chromium-dev] Re: detecting tabs using a lot of CPU?

It's better to be non-animated. Remember,ichrome is using too much CPU already. Second; the user is doing something, he doesn't want to be distracted with information unrelated to his current task. If the user finds himself waiting on his current tab, his eyes will probably see a tab being slightl

[chromium-dev] Re: detecting tabs using a lot of CPU?

http://tinderbox.mozilla.org/1afi003r.gif On Wed, Oct 7, 2009 at 10:10 AM, Glen Murphy wrote: > > Something like yes! Maybe not a dialog, as I use things that peg my > CPU (games) somewhat frequently. > > One idea we toyed with was marking such tabs as 'on fire' (icon or > color), so at least th

[chromium-dev] Re: detecting tabs using a lot of CPU?

+1 to "glowing hot" idea! :DG< On Wed, Oct 7, 2009 at 10:10 AM, Glen Murphy wrote: > > Something like yes! Maybe not a dialog, as I use things that peg my > CPU (games) somewhat frequently. > > One idea we toyed with was marking such tabs as 'on fire' (icon or > color), so at least there was a

[chromium-dev] Re: UI across multiple platforms

Also, it would be great if you found someone willing to implement the modification on other platforms if you're not going to do it yourself. This helps to get feedback early from other platforms (where the modification might not make sense) and it makes sure the bug doesn't sit there without an o

[chromium-dev] Re: detecting tabs using a lot of CPU?

Something like yes! Maybe not a dialog, as I use things that peg my CPU (games) somewhat frequently. One idea we toyed with was marking such tabs as 'on fire' (icon or color), so at least there was a visual indication. I think this would be a good starting point before anything more obtrusive lik

[chromium-dev] Re: detecting tabs using a lot of CPU?

maybe instead of a dialog, we can have some kind of a non-modal badness indicator?-darin On Wed, Oct 7, 2009 at 9:59 AM, Paweł Hajdan Jr. wrote: > Just a while before one of my tabs (GMail) started using a lot of CPU time > (67% while I was compiling in the background). The browser and the system

[chromium-dev] Re: UI across multiple platforms

That sounds like the best plan to me. This way there can be separate owners. -Ben On Wed, Oct 7, 2009 at 10:04 AM, Aaron Boodman wrote: > FWIW, on extensions, what we have been finding works is to file > separate bugs for each platform's UI implementation. It is just too > much code to track wi

[chromium-dev] Re: UI across multiple platforms

FWIW, on extensions, what we have been finding works is to file separate bugs for each platform's UI implementation. It is just too much code to track with one bug. You end up with these mega bugs that never close. We label each bug OS- - a On Wed, Oct 7, 2009 at 10:01 AM, Ben Goodger (Google)

[chromium-dev] Re: detecting tabs using a lot of CPU?

Yes, please! However, I would get that dialog about 1000 times a day: http://crbug.com/22948 Linus On Wed, Oct 7, 2009 at 9:59 AM, Paweł Hajdan Jr. wrote: > Just a while before one of my tabs (GMail) started using a lot of CPU time > (67% while I was compiling in the background). The browser an

[chromium-dev] UI across multiple platforms

Because we have different frontend codebases on different platforms, it's important that we strive to maintain feature parity between them. For this reason whenever we implement a modification to the UI in substance (e.g. add a feature, change a behavior) we should make sure to file a bug for the

[chromium-dev] detecting tabs using a lot of CPU?

Just a while before one of my tabs (GMail) started using a lot of CPU time (67% while I was compiling in the background). The browser and the system were responsive at all times, but processing power was wasted. We have a warning dialog for hanged renderers offering to kill them. What do you think

[chromium-dev] Re: Scalability

On Wed, Oct 7, 2009 at 10:00 AM, Craig Schlenter wrote: > On Tue, Oct 6, 2009 at 11:09 PM, Jacob Mandelson wrote: >> On Tue, Oct 06, 2009 at 09:19:49PM +0200, Craig Schlenter wrote: >>> On Tue, Oct 6, 2009 at 8:14 PM, Craig Schlenter >>> wrote: >>> > On Tue, Oct 6, 2009 at 7:51 PM, Jacob Mandel

[chromium-dev] Re: Paper about DRAM error rates

I think it would be a very interesting experiment, because it would firewall the SQLite code from Chrome memory stompers (which IMHO are a much more likely danger than DRAM errors). -scott On Wed, Oct 7, 2009 at 9:31 AM, Peter Kasting wrote: > On Tue, Oct 6, 2009 at 6:49 PM, John Abd-El-Malek

[chromium-dev] Re: Chrome Layout Tests Task Force status updates 10/6

BTW, I'm really sad that during my two days of sheriffing I added like 100 new lines to the test expectations file -- basically something new failed once every couple of minutes. There's still tons of flakiness. I tried to send mail about some of the bigger buckets but it was all over the place :(

[chromium-dev] Re: Paper about DRAM error rates

On Tue, Oct 6, 2009 at 6:49 PM, John Abd-El-Malek wrote: > It's about getting rid of nasty problems like the browser process crashing > every startup because of a corrupt database and decreasing browser process > crashes in general. I am pretty sure that the sqlite wrapper and sanity checking w

[chromium-dev] Re: How to deal with flaky unit tests

On Tue, Oct 6, 2009 at 10:52 PM, Darin Fisher wrote: > If a test sometimes crashes or hangs, it'll still be disabled, right? Yes. But if it's a ui_tests that crashes chrome.exe (and not ui_tests.exe), we can still mark it as flaky. Nicolas > -darin > > On Tue, Oct 6, 2009 at 5:02 PM, Nicola

[chromium-dev] [Mac] Tab animation "improvements" under heavy stress

I've spent some time banging my head against this issue on Mac where when we open a ton of tabs at the same time (15+, eg, mashing down cmd-t or opening all bookmarks as tabs) it "looks janky" because the tabs animate independently. As a result, we end up with the surfacing tabs stuck at various p

[chromium-dev] Re: buildbot failure in Chromium on Linux Perf, revision 0

A fix just got in this morning that will hopefully fix recent buildbot spamming habits. It'll still send emails to chromium-dev@ but only when it's actually closing the tree. There was a mismatch between the rules used to close the tree and the rules used to send an email. I'll let you guess which

[chromium-dev] Re: Has anyone built successfully on Win7 64bit? I am getting bash.exe errors

For the record, I build on win7 (both x86 and x64) on vs2008 without problem here. M-A On Tue, Oct 6, 2009 at 9:21 PM, vha14 wrote: > > Still having the same issue after following John's suggestions. Being > forced to use a separate cygwin's bash.exe. > > On Oct 2, 12:16 am, Abubakar wrote: >>

[chromium-dev] Re: Google Blogoscoped author tries out Chrome app shortcuts

For reference, here now is the .reg file that will also work with previously associated files all solved now! Windows Registry Editor Version 5.00 [-HKEY_LOCAL_MACHINE\Software\Classes\.myextension] [-HKEY_CURRENT_USER\Software\Classes\.myextension] [-HKEY_CU

[chromium-dev] Re: Scalability

On Tue, Oct 6, 2009 at 11:09 PM, Jacob Mandelson wrote: > On Tue, Oct 06, 2009 at 09:19:49PM +0200, Craig Schlenter wrote: >> On Tue, Oct 6, 2009 at 8:14 PM, Craig Schlenter >> wrote: >> > On Tue, Oct 6, 2009 at 7:51 PM, Jacob Mandelson >> > wrote: >> >> On Tue, Oct 06, 2009 at 07:39:14PM +020