On Thu, 20 Jun 2024 08:29:39 GMT, Julian Waters wrote:
> In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a
> memmove decay bug by rewriting a sizeof on an array to an explicit size of
> 256, but this is a bit of a band aid fix. It's come to my attention that in
> C++,
The no-arg constructor BasicSliderUI() was added under
[JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
constructor should be deprecated for removal in future release
-
Commit messages:
- -8334580: Deprecate no-arg constructor BasicSliderUI() for removal
On Thu, 20 Jun 2024 20:04:47 GMT, Phil Race wrote:
>> The only problem with the flag is that the data flow is not as clear.
>>
>> I'm not insisting, it worked before and it will work in the future.
>
> The way it was "before" is that we always returned the value of "doIt". Why
> not restore
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the
On Tue, 18 Jun 2024 17:57:29 GMT, Magnus Ihse Bursie wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains seven
>>
On Tue, 18 Jun 2024 13:15:00 GMT, Abhishek Kumar wrote:
>>> Hmm. So .. new public API ? Is this absolutely necessary ?
>> I don't see why an app would need to call this directly.
>>
>> `setMnemonicHidden` can be changed to a `protected` member as you pointed
>> out it may not be required by an
On Thu, 20 Jun 2024 08:29:39 GMT, Julian Waters wrote:
> In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a
> memmove decay bug by rewriting a sizeof on an array to an explicit size of
> 256, but this is a bit of a band aid fix. It's come to my attention that in
> C++,
On Mon, 17 Jun 2024 07:29:45 GMT, Tejesh R wrote:
>> DetailsView removes JTable TAB, SHIFT-TAB, ENTER and SHIFT-ENTER
>> functionalities to disable navigation within JTable of FilePane in
>> DetailsView. This is causing the issue mentioned in the bug where on
>> invoking DetailsView the
On Tue, 18 Jun 2024 22:01:26 GMT, Alisen Chung wrote:
> How do I test this fix?
There isn't a specific test because it is code that is used internally in
somewhat random cases.
A number of automated tests will use it (and they do all pass)
and just running a UI app will sometimes exercise this
On Thu, 20 Jun 2024 10:39:48 GMT, Alexey Ivanov wrote:
>> Yes, it could have been done that way and my intiial fix in JBS is that only
>> but I wanted to reinstate the flag as it is before
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) which was working
>> till now..
>
> The
On Thu, 20 Jun 2024 11:10:59 GMT, Renjith Kannath Pariyangad
wrote:
>> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPrinterJob.java line 225:
>>
>>> 223: if (isRangeSet) {
>>> 224: attributes.add(new PageRanges(from+1, to+1));
>>> 225:
On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> This fix will resolve page range not printing proper pages if the rage begin
> from 2 or above on Mac machines.
> I have verified the manual range related tests like PageRanges.java,
> ClippedImages.java
On Tue, 18 Jun 2024 06:21:12 GMT, Tejesh R wrote:
>> Yes, modifying the shared `ActionMap` is causing this issue though. As far
>> as I have seen the copy first solution is mentioned in this bug
>> https://bugs.openjdk.org/browse/JDK-8166352 as customer submitted workaround.
>
> I did thought
On Wed, 19 Jun 2024 08:38:33 GMT, Abhishek Kumar wrote:
> Test failed intermittently on Ubuntu 20.04, Ubuntu 22.04 system. Added a
> delay to stable the test and multiple run in CI is Ok. Link is added in JBS.
This pull request has now been integrated.
Changeset: 9ef86da5
Author:Abhishek
On Wed, 15 May 2024 03:38:29 GMT, Nizar Benalla wrote:
>> If you're currently reviewing this PR, thank you!
>> Most fixes here are according to the reports by the since checker tool in
>> #18934 and are pretty simple.
>>
>> To make reviewing easier
>> - `BasicSliderUI` has the constructor
On Tue, 18 Jun 2024 17:09:08 GMT, Alexey Ivanov wrote:
> > > How do we remove this constructor? Can it be removed right away? Should
> > > it be deprecated for several releases before it's removed?
> >
> >
> > Just delete it in all versions of 17+?
>
> Now it is part of Java 17 and 21. It
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the
On Tue, 18 Jun 2024 21:48:54 GMT, Alisen Chung wrote:
> why was this attribute added, and why is it being removed now? is the bug in
> SunPageSelection?
I am not sure why this attribute added, but noticed for other OS's this
workflow will be taken care by _RasterPrinterJob_ . With this
On Thu, 20 Jun 2024 03:39:47 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 694:
>>
>>> 692: ::GlobalUnlock(setup.hDevMode);
>>> 693: }
>>> 694: doIt = JNI_TRUE;
>>
>> Another option would be to return
On Thu, 20 Jun 2024 05:12:28 GMT, Prasanta Sadhukhan
wrote:
>> On cancelling PageDialog, same PageFormat object should be returned which
>> stopped working after
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
>> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so
On Fri, 14 Jun 2024 20:21:16 GMT, Phil Race wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> condition update
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java
> line 780:
>
>>
On Tue, 18 Jun 2024 16:28:50 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> condition update
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthRootPaneUI.java
> line 115:
>
>>
> In GTK LAF, the menu mnemonics are always displayed which is different from
> the native behavior. In native application **(tested with gedit for normal
> buttons and tested with libreoffice for menu**), the menu mnemonics toggle on
> press of `ALT` key. Menu mnemonics are hidden initially
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the
On Fri, 17 Feb 2023 14:35:45 GMT, Laurent Bourgès wrote:
> Or use #define KBD_BUF_LEN 256 And use it explicitely in array init &
> memmove... as plain old C.
Turns out C++ has an even more elegant solution for this: Passing an array by
reference https://github.com/openjdk/jdk/pull/19798/files
In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a memmove
decay bug by rewriting a sizeof on an array to an explicit size of 256, but
this is a bit of a band aid fix. It's come to my attention that in C++, one can
pass an array by reference, which causes sizeof to work
On Wed, 19 Jun 2024 19:35:54 GMT, Alexey Ivanov wrote:
> Would it be clearer if setDelay(50) was called in the constructor of
> bug6492108?
I am ok with the current placing of setDelay(50).
-
PR Review Comment: https://git.openjdk.org/jdk/pull/19788#discussion_r1647193228
29 matches
Mail list logo
