On Thu, 20 Jun 2024 08:29:39 GMT, Julian Waters wrote:
> In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a
> memmove decay bug by rewriting a sizeof on an array to an explicit size of
> 256, but this is a bit of a band aid fix. It's come to my attention that in
> C++, one
On Mon, 10 Jun 2024 11:29:10 GMT, BlakeTNC wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed allModifiersMask datatype
>
> PS, There is an Apple Developer forum post here:
> (https://forums.developer.appl
On Thu, 20 Jun 2024 08:29:39 GMT, Julian Waters wrote:
> In [JDK-8302671](https://bugs.openjdk.org/browse/JDK-8302671) I fixed a
> memmove decay bug by rewriting a sizeof on an array to an explicit size of
> 256, but this is a bit of a band aid fix. It's come to my attention that in
> C++, one
On Fri, 18 Aug 2023 01:14:16 GMT, Harshitha Onkar wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed allModifiersMask datatype
>
> Issue reproducible with native app. Bug reported to Apple -
> CGEventSourc
On Thu, 6 Jun 2024 19:38:46 GMT, BlakeTNC wrote:
>> Harshitha Onkar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> changed allModifiersMask datatype
>
> Hello, I am the developer that originally reported this bug to the Adoptium
> team
On Wed, 2 Aug 2023 21:46:32 GMT, Harshitha Onkar wrote:
>> **Problem:**
>>
>> On macOS, Robot erroneously produces lowercase letter when mouse is moved
>> (manually) in unison with Robot's keyEvents. This issue was originally
>> logged by a developer of an on-screen accessibility keyboard - T
On Fri, 14 Jun 2024 03:49:13 GMT, Alisen Chung wrote:
> Add a check and storage for a custom DefaultMenuBar in Desktop.java and adds
> key event handling for a custom DefaultMenuBar in KeyboardManager.java.
> Also adds a manual test for checking that key event handling is correct for
> DefaultM
On Fri, 21 Jun 2024 07:55:24 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit for normal
>> buttons and tested with libreoffice for menu**), the menu mnemonics toggle
>>
On Sun, 12 May 2024 00:37:26 GMT, Nizar Benalla wrote:
> Simple code cleanup.
> If you're reviewing this, thanks.
This pull request has now been integrated.
Changeset: 1ff5acda
Author:Nizar Benalla
Committer: Phil Race
URL:
https://git.openjdk.org/jdk/commit/1ff5acdafff1ccd3e64c70e
On Tue, 18 Jun 2024 20:31:58 GMT, Phil Race wrote:
> Migrate font code from jdk.internal.misc.Unsafe to using FFM.
> This reduces the coupling between the java.desktop module and the internals
> of the java.base module.
>
> The code being changed here is not particularly performance sensitive,
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Fri, 21 Jun 2024 14:46:33 GMT, Renjith Kannath Pariyangad
wrote:
> I don't think there is any issue with native code, with this change I have
> brought MAC same as other OS.
Hm… It works correctly now. But if a page range is used,
`SunPageSelection.RANGE` is added to attributes. Now it's n
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Fri, 21 Jun 2024 18:44:58 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java
>> line 153:
>>
>>> 151: /**
>>> 152: * Constructs a {@code BasicSliderUI}.
>>> 153: * @deprecated This constructor will be removed in future release
On Fri, 21 Jun 2024 18:33:37 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add forRemoval
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line
> 153:
>
>> 1
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has upda
On Fri, 21 Jun 2024 18:08:45 GMT, Phil Race wrote:
> But it means that if we deprecated the consructor with args we'd probably
> want to look at those too. It seems like the ripple effect isn't worth it.
It would clean up the code… Yes, we would need to modify all the subclasses too.
> And wha
On Thu, 20 Jun 2024 20:03:20 GMT, Phil Race wrote:
>> All I wanted is to bring up the inconsistency so that a few people would
>> take a look at it while reviewing this change.
>
> It does look odd. Focus would need transferring in both cases I'd expect.
> It goes back to the very beginning of
On Fri, 21 Jun 2024 03:17:38 GMT, Prasanta Sadhukhan
wrote:
>> The way it was "before" is that we always returned the value of "doIt". Why
>> not restore that for consistency ?
>
> I believe that's what this PR is doing, it returns value of "doIt" at end,
> isn't it?
> The way it was "before"
On Fri, 21 Jun 2024 15:51:29 GMT, Prasanta Sadhukhan
wrote:
>> On cancelling PageDialog, same PageFormat object should be returned which
>> stopped working after
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
>> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so tha
On Fri, 21 Jun 2024 15:13:27 GMT, Iris Clark wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java
>> line 153:
>>
>>> 151: /**
>>> 152: * Constructs a {@code BasicSliderUI}.
>>> 153: * @deprecated This constructor will be removed in future release
>>
On Fri, 21 Jun 2024 15:59:26 GMT, Prasanta Sadhukhan
wrote:
> Now that I looked at the code more thoroughly, the no-arg constructor makes
> more sense actually.
>
> https://github.com/openjdk/jdk/blob/c41293a70834a79c79e859ebcdb8869884ac87dc/src/java.desktop/share/classes/javax/swing/plaf/basi
On Wed, 19 Jun 2024 05:34:55 GMT, Prasanta Sadhukhan
wrote:
> On cancelling PageDialog, same PageFormat object should be returned which
> stopped working after
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so that co
On Fri, 21 Jun 2024 15:51:29 GMT, Prasanta Sadhukhan
wrote:
>> On cancelling PageDialog, same PageFormat object should be returned which
>> stopped working after
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
>> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so tha
On Fri, 7 Jun 2024 20:34:23 GMT, Alisen Chung wrote:
>> Add a check for previous focused window on modal unblocking. If the owner of
>> a closing dialog was the last focused window, then the owner of the dialog
>> should regain focus.
>
> Alisen Chung has updated the pull request incrementally
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has upda
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has upda
> On cancelling PageDialog, same PageFormat object should be returned which
> stopped working after
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160).
> Fix is made to reinstate "doIt" flag removed in JDK-8307160 so that correct
> value is returned from PageDialog.show action..
> An a
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has upda
On Fri, 21 Jun 2024 14:51:39 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add forRemoval
>
> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line
> 153:
>
>> 1
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has upda
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has upda
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has upda
On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> This fix will resolve page range not printing proper pages if the rage begin
> from 2 or above on Mac machines.
> I have verified the manual range related tests like PageRanges.java,
> ClippedImages.java
On Fri, 21 Jun 2024 12:21:38 GMT, Prasanta Sadhukhan
wrote:
> Build works ok however I see in some places like
> [this](https://github.com/openjdk/jdk/blob/08ace27da1d9cd215c77471eabf41417ff6282d2/src/java.desktop/share/classes/java/awt/Graphics.java#L1169)
> @SuppressWarnings("removal") is us
On Fri, 21 Jun 2024 12:12:22 GMT, Kevin Rushforth wrote:
> This looks good. I presume you've done a test build to ensure that there are
> no "removal" warnings elsewhere in the JDK? (I suspect there aren't, since I
> doubt any test program would be using this mistakenly added constructor)
Buil
On Fri, 21 Jun 2024 11:14:52 GMT, Alexey Ivanov wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java
>> line 154:
>>
>>> 152: * Constructs a {@code BasicSliderUI}.
>>> 153: */
>>> 154: @Deprecated(since = "23")
>>
>> You need to add `forRemoval = tru
On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan
wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> Prasanta Sadhukhan has upda
> The no-arg constructor BasicSliderUI() was added under
> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
> constructor should be deprecated for removal in future release
Prasanta Sadhukhan has updated the pull request incrementally with one
additional commit since
On Thu, 20 Jun 2024 18:40:29 GMT, Alexey Ivanov wrote:
> Do you refer to
> [`test/jdk/java/awt/print/PrinterJob/PageRanges.java`](https://github.com/openjdk/jdk/blob/master/test/jdk/java/awt/print/PrinterJob/PageRanges.java)
> and
> [`test/jdk/java/awt/print/PrinterJob/ImagePrinting/ClippedIma
On Fri, 21 Jun 2024 11:10:56 GMT, Kevin Rushforth wrote:
>> The no-arg constructor BasicSliderUI() was added under
>> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
>> constructor should be deprecated for removal in future release
>
> src/java.desktop/share/classes/
On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> This fix will resolve page range not printing proper pages if the rage begin
> from 2 or above on Mac machines.
> I have verified the manual range related tests like PageRanges.java,
> ClippedImages.java
On Fri, 21 Jun 2024 03:31:50 GMT, Prasanta Sadhukhan
wrote:
> The no-arg constructor BasicSliderUI() was added under
> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This
> constructor should be deprecated for removal in future release
Changes requested by kcr (Author)
On Fri, 14 Jun 2024 16:00:10 GMT, Tejesh R wrote:
> DetailsView removes JTable TAB, SHIFT-TAB, ENTER and SHIFT-ENTER
> functionalities to disable navigation within JTable of FilePane in
> DetailsView. This is causing the issue mentioned in the bug where on invoking
> DetailsView the functional
> In GTK LAF, the menu mnemonics are always displayed which is different from
> the native behavior. In native application **(tested with gedit for normal
> buttons and tested with libreoffice for menu**), the menu mnemonics toggle on
> press of `ALT` key. Menu mnemonics are hidden initially and
On Thu, 20 Jun 2024 20:55:11 GMT, Phil Race wrote:
>> Infact `isMnemonicHidden` can also be changed to a `protected` member of the
>> class. I will check and update.
>
> protected members of public classes are part of the API
> Go look at javadoc - or generate javadoc for this change and see for
50 matches
Mail list logo
