Re: [cmake-developers] Generator expressions for install destination

On 09/23/2015 05:18 PM, Robert Goulet wrote: > Here is the patch to support genex for install(DIRECTORY) command > DESTINATION option. Thanks. Applied with minor tweaks: install: Allow generator expressions in DIRECTORY DESTINATION http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=bd189cc2

Re: [cmake-developers] Generator expressions for install destination

Thanks Brad! Sent from mobile, please excuse typos. > On Sep 24, 2015, at 10:24 AM, Brad King wrote: > >> On 09/23/2015 05:18 PM, Robert Goulet wrote: >> Here is the patch to support genex for install(DIRECTORY) command >> DESTINATION option. > > Thanks. Applied with

Re: [cmake-developers] Generator expressions for install destination

:36 PM To: cmake-developers@cmake.org Subject: Re: [cmake-developers] Generator expressions for install destination Robert Goulet wrote: > Yeah I guess it could look something like this (attachment). Yes, something like that (modulo the long line). > However I > just realized that if I d

Re: [cmake-developers] Generator expressions for install destination

On 09/23/2015 01:47 PM, Robert Goulet wrote: > Updated patch for install(FILES) DESTINATION genex support. Test added as > well. Thanks. I applied it without the test: install: Allow generator expressions in FILES DESTINATION http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=17aa6fd3 and

Re: [cmake-developers] Generator expressions for install destination

m>; cmake-developers@cmake.org Subject: Re: [cmake-developers] Generator expressions for install destination On 09/23/2015 10:11 AM, Robert Goulet wrote: > if I made that patch clean with tests, would you accept it for 3.4? Likely yes. I was only suggesting the delay to avoid regressing Steve's r

Re: [cmake-developers] Generator expressions for install destination

, September 23, 2015 3:03 PM To: Robert Goulet <robert.gou...@autodesk.com>; cmake-developers@cmake.org Subject: Re: [cmake-developers] Generator expressions for install destination On 09/23/2015 01:47 PM, Robert Goulet wrote: > Updated patch for install(FILES) DESTINATION genex support. T

Re: [cmake-developers] Generator expressions for install destination

On 09/23/2015 03:19 PM, Robert Goulet wrote: > I have a similar change that applies the exact same code logic > to install(DIRECTORY), but I haven't wrote the test yet. Should > I still write a test for it before I send it to you? Yes, please. Base the commit on 69ab5f55. You should be able to

Re: [cmake-developers] Generator expressions for install destination

ct: Re: [cmake-developers] Generator expressions for install destination On 09/23/2015 03:19 PM, Robert Goulet wrote: > I have a similar change that applies the exact same code logic to > install(DIRECTORY), but I haven't wrote the test yet. Should I still > write a test for it before I send

Re: [cmake-developers] Generator expressions for install destination

Brad King wrote: > On 09/22/2015 09:58 AM, Robert Goulet wrote: >> Patch attached for adding makefile to install generators. >> This refactoring is required for install(FILES) genex support, >> and most likely other install() signatures in the future. > > Thanks. I applied that and merged to

Re: [cmake-developers] Generator expressions for install destination

On 09/22/2015 09:58 AM, Robert Goulet wrote: > Patch attached for adding makefile to install generators. > This refactoring is required for install(FILES) genex support, > and most likely other install() signatures in the future. Thanks. I applied that and merged to 'next' for testing:

Re: [cmake-developers] Generator expressions for install destination

Thanks, once this is accepted in master I will send you my updated install(FILES) with genex support. I removed the GetDestination() signature since I agree it's not needed and might be confusing. -Original Message- From: Brad King [mailto:brad.k...@kitware.com] Sent: Tuesday,

Re: [cmake-developers] Generator expressions for install destination

On 09/22/2015 04:35 PM, Robert Goulet wrote: > Ok so that brings the question, how is 3.4 schedule looking? The feature freeze will be Oct 1 shortly after which post-3.4 development will open. Steve will then start his post-3.4 refactoring topic merges and then we can come back to this feature.

Re: [cmake-developers] Generator expressions for install destination

On 09/22/2015 04:00 PM, Stephen Kelly wrote: > This is going in the wrong direction. > (Merge topic 'generators-use-cmLocalGenerator', 2015-08-24) > http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9135e370 [snip] > The patch from Robert should not undo that effort, so the branch > should be

Re: [cmake-developers] Generator expressions for install destination

] On Behalf Of Stephen Kelly Sent: Tuesday, September 22, 2015 4:00 PM To: cmake-developers@cmake.org Subject: Re: [cmake-developers] Generator expressions for install destination Brad King wrote: > On 09/22/2015 09:58 AM, Robert Goulet wrote: >> Patch attached for adding makefile t

Re: [cmake-developers] Generator expressions for install destination

22, 2015 4:53 PM To: cmake-developers@cmake.org Subject: Re: [cmake-developers] Generator expressions for install destination Robert Goulet wrote: > Ok then perhaps the refactoring can wait but we'd still like to get > install(FILES) destination genex support in 3.4 if possible, and

Re: [cmake-developers] Generator expressions for install destination

Brad King wrote: > On 09/22/2015 04:00 PM, Stephen Kelly wrote: >> This is going in the wrong direction. >> (Merge topic 'generators-use-cmLocalGenerator', 2015-08-24) >> http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=9135e370 > [snip] >> The patch from Robert should not undo that effort,

Re: [cmake-developers] Generator expressions for install destination

: Brad King [mailto:brad.k...@kitware.com] Sent: Tuesday, September 22, 2015 4:27 PM To: Robert Goulet <robert.gou...@autodesk.com> Cc: cmake-developers@cmake.org Subject: Re: [cmake-developers] Generator expressions for install destination On 09/22/2015 04:00 PM, Stephen Kelly

Re: [cmake-developers] Generator expressions for install destination

Robert Goulet wrote: > Ok then perhaps the refactoring can wait but we'd still like to get > install(FILES) destination genex support in 3.4 if possible, and genex > evaluation requires the cmMakefile. How should we proceed then? cmLocalGenerator has a GetMakefile method (currently). Don't you

Re: [cmake-developers] Generator expressions for install destination

Robert Goulet wrote: > Yeah I guess it could look something like this (attachment). Yes, something like that (modulo the long line). > However I > just realized that if I don't also get install(DIRECTORY) in 3.4 then this > is not worth rushing it, since as you mention I would also need to

Re: [cmake-developers] Generator expressions for install destination

> This and its related changes are also refactoring that should go in its own > commit. Ok let's begin with this. Patch attached for adding makefile to install generators. This refactoring is required for install(FILES) genex support, and most likely other install() signatures in the future.

Re: [cmake-developers] Generator expressions for install destination

On 09/18/2015 03:49 PM, Robert Goulet wrote: > Here's a version that is more conservative. It doesn't change > the install(EXPORT) behavior. > install(TARGET) already supported genex Right. I'd forgotten about these changes: install: Allow generator expressions in TARGETS DESTINATION (#14317)

Re: [cmake-developers] Generator expressions for install destination

Here's a version that is more conservative. It doesn't change the install(EXPORT) behavior. install(TARGET) already supported genex, so basically this patch adds install(FILES) destination genex. Perhaps we should update the Help to only mention install(FILES) destination instead of all

Re: [cmake-developers] Generator expressions for install destination

On 09/09/2015 12:21 PM, Robert Goulet wrote: > Here’s the patch to add generator expressions to the install > command DESTINATION option. Thanks for the update. >>This should not be needed if things are factored correctly. >>Everything in that block already passes "config" through as a

[cmake-developers] Generator expressions for install destination

Hi, Here's the patch to add generator expressions to the install command DESTINATION option. Let me know if that's good to go. >@@ -216,6 +216,7 @@ void >cmScriptGenerator::GenerateScriptActionsPerConfig(std::ostream& os, > i != this->ConfigurationTypes->end(); ++i) > { >