Re: [PR] Bump minimum Airflow version in providers to Airflow 2.6.0 [airflow]

2023-12-06 Thread via GitHub
potiuk commented on PR #36017: URL: https://github.com/apache/airflow/pull/36017#issuecomment-1842367620 > rebased after #36061 lets see if CI passes Close enough - you need to also remove `2.5.0` from the list : https://github.com/apache/airflow/blob/main/dev/README_RELEASE_P

Re: [PR] fix(datasets): persist dataset extra dict to dataset event [airflow]

2023-12-06 Thread via GitHub
error418 commented on PR #36075: URL: https://github.com/apache/airflow/pull/36075#issuecomment-1842371559 @uranusjr I also thought the implementation was intended this way. I removed the merge with the latest commit to this PR for the review. In case the discussion comes to the resul

[PR] Use UTC explicitly in timetable tests [airflow]

2023-12-06 Thread via GitHub
uranusjr opened a new pull request, #36082: URL: https://github.com/apache/airflow/pull/36082 See discussion https://github.com/apache/airflow/pull/35887#pullrequestreview-1766821317 These tests logically depend on the fact that the test suite is run in UTC. While that is true and ex

Re: [I] When setup airflow database backend (postgressql), webserver is close. [airflow]

2023-12-06 Thread via GitHub
tharhtetsan commented on issue #35938: URL: https://github.com/apache/airflow/issues/35938#issuecomment-1842413732 Hello @potiuk Thank you for your continue support. When I test `Airflow-2.73 `with PostgresSQL docker locally, it work smoothly. but when I set `sql_alchemy_conn` for Azure P

Re: [PR] Fix for EksCreateClusterOperator deferrable mode [airflow]

2023-12-06 Thread via GitHub
Taragolis commented on code in PR #36079: URL: https://github.com/apache/airflow/pull/36079#discussion_r1416911328 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -253,6 +253,7 @@ def __init__( self.fargate_selectors = fargate_selectors or [{"namespace": DEFAUL

Re: [PR] GCP Secrets Backend Impersonation [airflow]

2023-12-06 Thread via GitHub
nathadfield commented on PR #36072: URL: https://github.com/apache/airflow/pull/36072#issuecomment-1842420638 > Chance for a unit test? @potiuk I guess I initially thought that the tests were covered as part of the `_get_target_principal_and_delegates` function and I wasn't really sur

Re: [PR] Revert "Add a public interface for custom weight_rule implementation (#35210)" [airflow]

2023-12-06 Thread via GitHub
ephraimbuddy merged PR #36066: URL: https://github.com/apache/airflow/pull/36066 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@air

Re: [PR] Fix for EksCreateClusterOperator deferrable mode [airflow]

2023-12-06 Thread via GitHub
Taragolis commented on code in PR #36079: URL: https://github.com/apache/airflow/pull/36079#discussion_r1416922185 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -400,9 +400,9 @@ def execute_failed(self, context: Context, event: dict[str, Any] | None = None) i

(airflow) branch main updated: Add support for tabs (and other UX components) to docs (#36041)

2023-12-06 Thread uranusjr
This is an automated email from the ASF dual-hosted git repository. uranusjr pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new 58e264c83f Add support for tabs (and other UX com

Re: [PR] Add support for tabs (and other UX components) to docs [airflow]

2023-12-06 Thread via GitHub
uranusjr commented on code in PR #36041: URL: https://github.com/apache/airflow/pull/36041#discussion_r1416928795 ## airflow/example_dags/example_python_operator.py: ## @@ -28,55 +28,59 @@ import pendulum -from airflow.decorators import task from airflow.models.dag import

Re: [I] Support tabs in docs [airflow]

2023-12-06 Thread via GitHub
uranusjr closed issue #29267: Support tabs in docs URL: https://github.com/apache/airflow/issues/29267 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: c

Re: [PR] Add support for tabs (and other UX components) to docs [airflow]

2023-12-06 Thread via GitHub
uranusjr merged PR #36041: URL: https://github.com/apache/airflow/pull/36041 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow

Re: [I] When setup airflow database backend (postgressql), webserver is close. [airflow]

2023-12-06 Thread via GitHub
potiuk commented on issue #35938: URL: https://github.com/apache/airflow/issues/35938#issuecomment-1842443894 No idea. Your DB requirements depend solely on your setup. As explained in the https://airflow.apache.org/docs/apache-airflow/stable/installation/index.html#notes-about-minimum-req

[PR] openlineage: add ClassVar to Airflow facets. [airflow]

2023-12-06 Thread via GitHub
JDarDagran opened a new pull request, #36084: URL: https://github.com/apache/airflow/pull/36084 Recent OpenLineage release introduced a change that breaks mypy in main. This PR fixes it. -- This is an automated message from the Apache Git Service. To respond to the message

Re: [I] When setup airflow database backend (postgressql), webserver is close. [airflow]

2023-12-06 Thread via GitHub
potiuk commented on issue #35938: URL: https://github.com/apache/airflow/issues/35938#issuecomment-1842448676 And especially - where your error is about the Azure/Managed databases, then likely those database have their own limitations or expectations, and thorough reading of their documeen

Re: [PR] Bump minimum Airflow version in providers to Airflow 2.6.0 [airflow]

2023-12-06 Thread via GitHub
eladkal commented on PR #36017: URL: https://github.com/apache/airflow/pull/36017#issuecomment-1842452408 > Close enough - you need to also remove 2.5.0 from the list Thanks! I new i forgot something -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [PR] Allow storage options to be passed [airflow]

2023-12-06 Thread via GitHub
uranusjr commented on code in PR #35820: URL: https://github.com/apache/airflow/pull/35820#discussion_r1416951641 ## airflow/io/__init__.py: ## @@ -32,21 +32,25 @@ if TYPE_CHECKING: from fsspec import AbstractFileSystem +from airflow.io.typedef import Properties Rev

Re: [PR] Allow storage options to be passed [airflow]

2023-12-06 Thread via GitHub
uranusjr commented on code in PR #35820: URL: https://github.com/apache/airflow/pull/35820#discussion_r1416952712 ## airflow/io/__init__.py: ## @@ -32,21 +32,25 @@ if TYPE_CHECKING: from fsspec import AbstractFileSystem +from airflow.io.typedef import Properties + +

Re: [I] DagRun marked as success without executing task [airflow]

2023-12-06 Thread via GitHub
potiuk commented on issue #17977: URL: https://github.com/apache/airflow/issues/17977#issuecomment-1842469420 > I still got same issue on airflow v2.4.3, Is there any updates regarding this? Well. It was also reported for 2.1.3. The issue was closed because no activity from the user

Re: [PR] Sync v2-8-stable with v2-8-test to release 2.8.0 [airflow]

2023-12-06 Thread via GitHub
ephraimbuddy commented on PR #36065: URL: https://github.com/apache/airflow/pull/36065#issuecomment-1842490013 > > We must wait for #36029 or merge #36066 to remove the feature before cutting the RC. I was sick the last few days, and I don't know if I will have the energy to finish #36029 t

(airflow) branch v2-8-test updated (e71373af69 -> 9176c28a50)

2023-12-06 Thread ephraimanierobi
This is an automated email from the ASF dual-hosted git repository. ephraimanierobi pushed a change to branch v2-8-test in repository https://gitbox.apache.org/repos/asf/airflow.git omit e71373af69 Update RELEASE_NOTES.rst add 7d1211de0f Fix gantt chart queued duration when queued_dttm

Re: [PR] Sync v2-8-stable with v2-8-test to release 2.8.0 [airflow]

2023-12-06 Thread via GitHub
ephraimbuddy commented on code in PR #36065: URL: https://github.com/apache/airflow/pull/36065#discussion_r1416974970 ## RELEASE_NOTES.rst: ## @@ -41,6 +41,8 @@ Significant Changes New Features - AIP-58: Add Airflow ObjectStore (AFS) (`AIP-58

Re: [PR] Use DbApiHook.run for DbApiHook.get_records and DbApiHook.get_first [airflow]

2023-12-06 Thread via GitHub
shlomiken commented on PR #26944: URL: https://github.com/apache/airflow/pull/26944#issuecomment-1842494020 @potiuk - looks like this PR breaks get_first and get_records return type for snowflake for example , so instead of tuple we get a Dict. this also breaks SqlSensor this code

Re: [PR] Allow storage options to be passed [airflow]

2023-12-06 Thread via GitHub
uranusjr commented on code in PR #35820: URL: https://github.com/apache/airflow/pull/35820#discussion_r1416991356 ## airflow/io/store/__init__.py: ## @@ -134,6 +146,6 @@ def attach( if store := _STORE_CACHE.get(alias): return store -_STORE_CACHE[alias

Re: [PR] openlineage: add ClassVar to Airflow facets. [airflow]

2023-12-06 Thread via GitHub
JDarDagran commented on PR #36084: URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842509172 I'm not sure why mypy fails now - it looks the opposite to what happens in main. -- This is an automated message from the Apache Git Service. To respond to the message, please log

[PR] Add retry mechanism and dataframe support for WeaviateIngestOperator [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 opened a new pull request, #36085: URL: https://github.com/apache/airflow/pull/36085 The PR add the retry mechanism while ingesting data into Weaviate, this is needed to ensure the data that we intend to ingest is not affected by the possible network or ratelimiting issue. We a

Re: [PR] Add helper function for CRUD operations on weaviate's schema and class objects [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 commented on code in PR #35919: URL: https://github.com/apache/airflow/pull/35919#discussion_r1417022573 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -119,38 +125,204 @@ def test_connection(self) -> tuple[bool, str]: self.log.error("Error test

Re: [PR] Add retry mechanism and dataframe support for WeaviateIngestOperator [airflow]

2023-12-06 Thread via GitHub
uranusjr commented on code in PR #36085: URL: https://github.com/apache/airflow/pull/36085#discussion_r1417027820 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -135,22 +139,40 @@ def create_schema(self, schema_json: dict[str, Any]) -> None: client = self.conn

Re: [PR] Add retry mechanism and dataframe support for WeaviateIngestOperator [airflow]

2023-12-06 Thread via GitHub
uranusjr commented on code in PR #36085: URL: https://github.com/apache/airflow/pull/36085#discussion_r1417028234 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -135,22 +139,40 @@ def create_schema(self, schema_json: dict[str, Any]) -> None: client = self.conn

Re: [PR] Add retry mechanism and dataframe support for WeaviateIngestOperator [airflow]

2023-12-06 Thread via GitHub
uranusjr commented on code in PR #36085: URL: https://github.com/apache/airflow/pull/36085#discussion_r1417031209 ## docs/apache-airflow-providers-weaviate/operators/weaviate.rst: ## @@ -28,7 +28,7 @@ into the database. Using the Operator ^^ -The WeaviateInge

Re: [PR] Add retry mechanism and dataframe support for WeaviateIngestOperator [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 commented on code in PR #36085: URL: https://github.com/apache/airflow/pull/36085#discussion_r1417034666 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -135,22 +139,40 @@ def create_schema(self, schema_json: dict[str, Any]) -> None: client = self.c

Re: [I] Add an on_skipped_callback [airflow]

2023-12-06 Thread via GitHub
aritra24 commented on issue #35936: URL: https://github.com/apache/airflow/issues/35936#issuecomment-1842563787 @RNHTTR I could take this up. Could you assign it to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

Re: [PR] Add helper function for CRUD operations on weaviate's schema and class objects [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 commented on code in PR #35919: URL: https://github.com/apache/airflow/pull/35919#discussion_r1417042460 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -119,38 +125,204 @@ def test_connection(self) -> tuple[bool, str]: self.log.error("Error test

Re: [PR] Add retry mechanism and dataframe support for WeaviateIngestOperator [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 commented on code in PR #36085: URL: https://github.com/apache/airflow/pull/36085#discussion_r1417047431 ## docs/apache-airflow-providers-weaviate/operators/weaviate.rst: ## @@ -28,7 +28,7 @@ into the database. Using the Operator ^^ -The Weaviate

Re: [PR] Add retry mechanism and dataframe support for WeaviateIngestOperator [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 commented on code in PR #36085: URL: https://github.com/apache/airflow/pull/36085#discussion_r1417047431 ## docs/apache-airflow-providers-weaviate/operators/weaviate.rst: ## @@ -28,7 +28,7 @@ into the database. Using the Operator ^^ -The Weaviate

Re: [I] Leak in Kubernetes Executor Running Tasks Slot Count [airflow]

2023-12-06 Thread via GitHub
c-thiel commented on issue #35675: URL: https://github.com/apache/airflow/issues/35675#issuecomment-1842586190 We had the same problem and only noticed it from Airflow 2.7.3, but it was there before. Maybe this helps for debugging: On the left of the red line we had Airflow 2.6.X

Re: [I] Leak in Kubernetes Executor Running Tasks Slot Count [airflow]

2023-12-06 Thread via GitHub
dirrao commented on issue #35675: URL: https://github.com/apache/airflow/issues/35675#issuecomment-1842591230 @c-thiel Yes. This workaround works and we are following the same. I have identified the leaks and am going to open the MR soon. -- This is an automated message from the Apach

Re: [PR] Bump up openai version to >=1.0 & use get_conn [airflow]

2023-12-06 Thread via GitHub
pankajkoti merged PR #36014: URL: https://github.com/apache/airflow/pull/36014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airfl

(airflow) branch main updated: Bump up openai version to >=1.0 & use get_conn (#36014)

2023-12-06 Thread pankajkoti
This is an automated email from the ASF dual-hosted git repository. pankajkoti pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new d2514b408c Bump up openai version to >=1.0 & us

[PR] Follow BaseHook connection fields method signature in providers hooks [airflow]

2023-12-06 Thread via GitHub
Taragolis opened a new pull request, #36086: URL: https://github.com/apache/airflow/pull/36086 In Airflow 2.3 (or even 2.2) BaseHook add methods `get_ui_field_behaviour` and `get_ui_field_behaviour` as classmethod, however most of the hooks define it as staticmethod

Re: [PR] Follow BaseHook connection fields method signature in providers hooks [airflow]

2023-12-06 Thread via GitHub
Taragolis commented on PR #36086: URL: https://github.com/apache/airflow/pull/36086#issuecomment-1842615240 We also have [DiscoverableHook](https://github.com/apache/airflow/blob/2bcd450e84426fd678b3fa2e4a15757af234e98a/airflow/hooks/base.py#L110) Protocol, which we do not use anywhere in A

Re: [I] Requests/limits in custom-values.yaml ignored [airflow]

2023-12-06 Thread via GitHub
dabukster commented on issue #35497: URL: https://github.com/apache/airflow/issues/35497#issuecomment-1842616559 I just added the dbMigrations section as the k8s cluster complained about it. Thus, just remove it. But I assume it is due to the configuration of our k8s cluster, as I just use

Re: [PR] Add retry mechanism and dataframe support for WeaviateIngestOperator [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 commented on code in PR #36085: URL: https://github.com/apache/airflow/pull/36085#discussion_r1417082359 ## docs/apache-airflow-providers-weaviate/operators/weaviate.rst: ## @@ -28,7 +28,7 @@ into the database. Using the Operator ^^ -The Weaviate

Re: [PR] openlineage: add ClassVar to Airflow facets. [airflow]

2023-12-06 Thread via GitHub
Taragolis commented on code in PR #36084: URL: https://github.com/apache/airflow/pull/36084#discussion_r1417097596 ## airflow/providers/openlineage/plugins/facets.py: ## @@ -28,7 +30,7 @@ class AirflowMappedTaskRunFacet(BaseFacet): mapIndex: int operatorClass: str -

Re: [PR] Add retry mechanism and dataframe support for WeaviateIngestOperator [airflow]

2023-12-06 Thread via GitHub
pankajkoti commented on code in PR #36085: URL: https://github.com/apache/airflow/pull/36085#discussion_r1417131009 ## airflow/providers/weaviate/operators/weaviate.py: ## @@ -40,9 +44,11 @@ class WeaviateIngestOperator(BaseOperator): :param conn_id: The Weaviate connecti

Re: [PR] openlineage: add ClassVar to Airflow facets. [airflow]

2023-12-06 Thread via GitHub
potiuk commented on PR #36084: URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842698048 > I'm not sure why mypy fails now - it looks the opposite to what happens in main. How to check what versions of packages are installed in the CI env? If PR does not change dep

Re: [PR] openlineage: add ClassVar to Airflow facets. [airflow]

2023-12-06 Thread via GitHub
potiuk commented on PR #36084: URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842699757 @JDarDagran https://github.com/apache/airflow/tree/constraints-main -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] openlineage: add ClassVar to Airflow facets. [airflow]

2023-12-06 Thread via GitHub
JDarDagran commented on PR #36084: URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842704615 Okay, how about we remove annotations in provider now as suggested by @Taragolis? Not sure if we ever want to add them back once contraints for `openlineage-python` are updated wi

Re: [PR] openlineage: add ClassVar to Airflow facets. [airflow]

2023-12-06 Thread via GitHub
potiuk commented on PR #36084: URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842714520 Longer explanation: > I'm not sure why mypy fails now - it looks the opposite to what happens in main. Yes. This is entirely expected that your PR will have 'regular' constr

Re: [PR] Add retry mechanism and dataframe support for WeaviateIngestOperator [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 commented on code in PR #36085: URL: https://github.com/apache/airflow/pull/36085#discussion_r1417162074 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -135,22 +139,40 @@ def create_schema(self, schema_json: dict[str, Any]) -> None: client = self.c

Re: [PR] Add retry mechanism and dataframe support for WeaviateIngestOperator [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 commented on code in PR #36085: URL: https://github.com/apache/airflow/pull/36085#discussion_r1417162923 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -135,22 +139,40 @@ def create_schema(self, schema_json: dict[str, Any]) -> None: client = self.c

Re: [PR] Add retry mechanism and dataframe support for WeaviateIngestOperator [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 commented on code in PR #36085: URL: https://github.com/apache/airflow/pull/36085#discussion_r1417165337 ## airflow/providers/weaviate/operators/weaviate.py: ## @@ -40,9 +44,11 @@ class WeaviateIngestOperator(BaseOperator): :param conn_id: The Weaviate connec

Re: [PR] Add helper function for CRUD operations on weaviate's schema and class objects [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 commented on code in PR #35919: URL: https://github.com/apache/airflow/pull/35919#discussion_r1417166343 ## airflow/providers/weaviate/operators/weaviate.py: ## @@ -51,21 +54,25 @@ def __init__( self, conn_id: str, class_name: str, -

Re: [PR] openlineage: add ClassVar to Airflow facets. [airflow]

2023-12-06 Thread via GitHub
JDarDagran commented on PR #36084: URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842726791 @potiuk thanks for your thorough explanation. After all it seems like I should bump the dependency version as the change in `openlineage-python` is correct, we just want to have al

Re: [PR] Add helper function for CRUD operations on weaviate's schema and class objects [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 commented on code in PR #35919: URL: https://github.com/apache/airflow/pull/35919#discussion_r1417168072 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -17,16 +17,22 @@ from __future__ import annotations +import json import warnings from functools imp

Re: [PR] Add retry mechanism and dataframe support for WeaviateIngestOperator [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 commented on code in PR #36085: URL: https://github.com/apache/airflow/pull/36085#discussion_r1417256443 ## airflow/providers/weaviate/operators/weaviate.py: ## @@ -51,21 +57,38 @@ def __init__( self, conn_id: str, class_name: str, -

Re: [PR] Add retry mechanism and dataframe support for WeaviateIngestOperator [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 commented on code in PR #36085: URL: https://github.com/apache/airflow/pull/36085#discussion_r1417258114 ## airflow/providers/weaviate/operators/weaviate.py: ## @@ -51,21 +57,38 @@ def __init__( self, conn_id: str, class_name: str, -

Re: [PR] openlineage: add ClassVar to Airflow facets. [airflow]

2023-12-06 Thread via GitHub
potiuk commented on code in PR #36084: URL: https://github.com/apache/airflow/pull/36084#discussion_r1417273791 ## airflow/providers/openlineage/plugins/facets.py: ## @@ -28,7 +30,9 @@ class AirflowMappedTaskRunFacet(BaseFacet): mapIndex: int operatorClass: str -

Re: [PR] openlineage: add ClassVar to Airflow facets. [airflow]

2023-12-06 Thread via GitHub
potiuk commented on code in PR #36084: URL: https://github.com/apache/airflow/pull/36084#discussion_r1417273983 ## airflow/providers/openlineage/plugins/facets.py: ## @@ -63,7 +67,9 @@ class UnknownOperatorInstance(RedactMixin): properties: dict[str, object] type: str

Re: [I] Delete DagRun event is not registered in audit log [airflow]

2023-12-06 Thread via GitHub
vchiapaikeo commented on issue #36057: URL: https://github.com/apache/airflow/issues/36057#issuecomment-1842854183 Happy to take a look at this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Add helper function for CRUD operations on weaviate's schema and class objects [airflow]

2023-12-06 Thread via GitHub
utkarsharma2 commented on code in PR #35919: URL: https://github.com/apache/airflow/pull/35919#discussion_r1417288759 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -112,22 +117,170 @@ def test_connection(self) -> tuple[bool, str]: self.log.error("Error test

Re: [I] Add an on_skipped_callback [airflow]

2023-12-06 Thread via GitHub
RNHTTR commented on issue #35936: URL: https://github.com/apache/airflow/issues/35936#issuecomment-1842868125 Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Use DbApiHook.run for DbApiHook.get_records and DbApiHook.get_first [airflow]

2023-12-06 Thread via GitHub
potiuk commented on PR #26944: URL: https://github.com/apache/airflow/pull/26944#issuecomment-1842870944 Use latest version of both Airflow and Snowflake provider. There were several fixes implemented after that one. Just make sure to upgrade everything to latest versions as they con

Re: [PR] Use DbApiHook.run for DbApiHook.get_records and DbApiHook.get_first [airflow]

2023-12-06 Thread via GitHub
potiuk commented on PR #26944: URL: https://github.com/apache/airflow/pull/26944#issuecomment-1842873116 And make sure to fix any deprecation warnings you see and look at the release notes - of Snowflake provider. There were a few breaking changes that you might want to fix (some of the thi

Re: [PR] openlineage: add ClassVar to Airflow facets. [airflow]

2023-12-06 Thread via GitHub
potiuk commented on PR #36084: URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842875683 BTw. @Taragolis in slack mentioned that just removing the annotation might work ... so maybe ? -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

2023-12-06 Thread via GitHub
KesharwaniArpita commented on PR #897: URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1842877259 > Well. You do realize you need to run pre-commit and apply the change though :) ? I did. I run the `pre-commit run --all-files` as mentioned in the [file](https://gith

Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

2023-12-06 Thread via GitHub
potiuk commented on PR #897: URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1842909424 `I did. I run the pre-commit run --all-files as mentioned in the [file](https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#id3). Is there anything else I need to do?

Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

2023-12-06 Thread via GitHub
potiuk commented on PR #897: URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1842910897 ![image](https://github.com/apache/airflow-site/assets/595491/530d3c23-08c1-4055-b037-d2f21b2bfd45) -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Account for change in UTC offset when calculating next schedule [airflow]

2023-12-06 Thread via GitHub
timkpaine commented on PR #35887: URL: https://github.com/apache/airflow/pull/35887#issuecomment-1842911920 > Does this need a significant fragment? I’m assuming it does not since there’s no backward incompatibility. Doesn't make a difference to me but this does change how certain thi

Re: [PR] Added table of content in CONTRIBUTE.md and enhanced the documentation. [airflow-site]

2023-12-06 Thread via GitHub
potiuk commented on PR #897: URL: https://github.com/apache/airflow-site/pull/897#issuecomment-1842913022 I think this output of the CI explains everything. I would have to literally copy what it says if you want instructions :) It's there precisely to instruct people what to do --

Re: [PR] openlineage: add ClassVar to Airflow facets. [airflow]

2023-12-06 Thread via GitHub
JDarDagran commented on PR #36084: URL: https://github.com/apache/airflow/pull/36084#issuecomment-1842915896 @potiuk @Taragolis yeah, in the end we all agreed on removing the annotation. Went for it -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [I] Airflow scheduler stopped working [airflow]

2023-12-06 Thread via GitHub
timkpaine commented on issue #35272: URL: https://github.com/apache/airflow/issues/35272#issuecomment-1842915975 Should hopefully be resolved in #35887 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] Add object methods in weaviate hook [airflow]

2023-12-06 Thread via GitHub
pankajkoti commented on code in PR #35934: URL: https://github.com/apache/airflow/pull/35934#discussion_r1417346501 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -200,3 +209,147 @@ def query_without_vector( .do() ) return results + +de

Re: [PR] Add object methods in weaviate hook [airflow]

2023-12-06 Thread via GitHub
ephraimbuddy commented on code in PR #35934: URL: https://github.com/apache/airflow/pull/35934#discussion_r1417387857 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -200,3 +209,147 @@ def query_without_vector( .do() ) return results + +

Re: [PR] Add object methods in weaviate hook [airflow]

2023-12-06 Thread via GitHub
ephraimbuddy commented on code in PR #35934: URL: https://github.com/apache/airflow/pull/35934#discussion_r1417391758 ## airflow/providers/weaviate/hooks/weaviate.py: ## @@ -200,3 +209,147 @@ def query_without_vector( .do() ) return results + +

Re: [I] If yarn is not preinstalled, local build fails. [airflow-site]

2023-12-06 Thread via GitHub
pierrejeambrun closed issue #901: If yarn is not preinstalled, local build fails. URL: https://github.com/apache/airflow-site/issues/901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] If yarn is not preinstalled, local build fails. [airflow-site]

2023-12-06 Thread via GitHub
pierrejeambrun commented on issue #901: URL: https://github.com/apache/airflow-site/issues/901#issuecomment-184296 thanks, closing as solved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] openlineage: add ClassVar to Airflow facets. [airflow]

2023-12-06 Thread via GitHub
mobuchowski merged PR #36084: URL: https://github.com/apache/airflow/pull/36084 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airf

(airflow) branch main updated: Remove ClassVar annotations. (#36084)

2023-12-06 Thread mobuchowski
This is an automated email from the ASF dual-hosted git repository. mobuchowski pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/main by this push: new fba682b1a5 Remove ClassVar annotations. (#3608

[I] Deferrable operator tasks don't call on_kill when fail or restarted [airflow]

2023-12-06 Thread via GitHub
nirben82 opened a new issue, #36090: URL: https://github.com/apache/airflow/issues/36090 ### Apache Airflow version Other Airflow 2 version (please specify below) ### What happened When marking a task that is using a deferrable operators as failed or cleared, on_kill met

Re: [I] Deferrable operator tasks don't call on_kill when fail or restarted [airflow]

2023-12-06 Thread via GitHub
boring-cyborg[bot] commented on issue #36090: URL: https://github.com/apache/airflow/issues/36090#issuecomment-1843012336 Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for ap

Re: [PR] Add Architecture Decision Record for common.sql introduction [airflow]

2023-12-06 Thread via GitHub
Taragolis commented on PR #36015: URL: https://github.com/apache/airflow/pull/36015#issuecomment-1843014243 I have some questions, I don't have any suggestions yet, but after some discussion we might have the right answer and add to this document, or upcoming updates. 1. Any idea how

Re: [PR] Fix for EksCreateClusterOperator deferrable mode [airflow]

2023-12-06 Thread via GitHub
vincbeck commented on code in PR #36079: URL: https://github.com/apache/airflow/pull/36079#discussion_r1417449599 ## airflow/providers/amazon/aws/operators/eks.py: ## @@ -253,6 +253,7 @@ def __init__( self.fargate_selectors = fargate_selectors or [{"namespace": DEFAULT

[I] Issue with Unreachable Page Due to Page Address Error [airflow-site]

2023-12-06 Thread via GitHub
thisistorr opened a new issue, #903: URL: https://github.com/apache/airflow-site/issues/903 Hello, This is Torr. I am writing to report an issue I encountered while attempting to access the linked website. Unfortunately, I received a "The page you were looking for couldn't be found"

[PR] Fix AWS system tests [airflow]

2023-12-06 Thread via GitHub
vincbeck opened a new pull request, #36091: URL: https://github.com/apache/airflow/pull/36091 There are currently [3 system tests](https://aws-mwaa.github.io/#/open-source/system-tests/dashboard.html) failing for the same reason: each system test creates security groups needed for `Redshif

[PR] Update SFTP Site Address (#903) [airflow-site]

2023-12-06 Thread via GitHub
thisistorr opened a new pull request, #904: URL: https://github.com/apache/airflow-site/pull/904 I changed the existing SFTP site address, as it was inaccessible, to a new address. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

(airflow) branch constraints-main updated: Updating constraints. Github run id:7115745249

2023-12-06 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a commit to branch constraints-main in repository https://gitbox.apache.org/repos/asf/airflow.git The following commit(s) were added to refs/heads/constraints-main by this push: new cb22a966ce Updating con

Re: [PR] Use DbApiHook.run for DbApiHook.get_records and DbApiHook.get_first [airflow]

2023-12-06 Thread via GitHub
shlomiken commented on PR #26944: URL: https://github.com/apache/airflow/pull/26944#issuecomment-1843099193 @potiuk - thanks , i kinda figure that out after trying to play with different versions of common-sql and provider. what surprised me is that we used to get a tuple, then after upgr

Re: [PR] Displaying "actual" try number in TaskInstance view [airflow]

2023-12-06 Thread via GitHub
bbovenzi commented on PR #34635: URL: https://github.com/apache/airflow/pull/34635#issuecomment-1843201889 > > How do you feel about the approach in general? It feels kinda hacky to me, but it technically works so > > @bbovenzi approved so I guess it's OK :) Yeah, if this gives

Re: [PR] Account for change in UTC offset when calculating next schedule [airflow]

2023-12-06 Thread via GitHub
dstandish commented on PR #35887: URL: https://github.com/apache/airflow/pull/35887#issuecomment-1843281803 There's a bugfix newsfragment type I think. Isn't this a bugfix? Doesn't every bugfix imply some kind of behavior change? I guess what's the big change here in behavior? Previousl

[PR] list pods performance optimization [airflow]

2023-12-06 Thread via GitHub
dirrao opened a new pull request, #36092: URL: https://github.com/apache/airflow/pull/36092 What happened _list_pods function uses kube list_namespaced_pod and list_pod_for_all_namespaces kube functions. Right now, these Kube functions will get the entire pod spec though we are inter

Re: [PR] Account for change in UTC offset when calculating next schedule [airflow]

2023-12-06 Thread via GitHub
timkpaine commented on PR #35887: URL: https://github.com/apache/airflow/pull/35887#issuecomment-184335 It changes when things will get scheduled, see my code above. So the same schedule will run at different times after upgrade -- This is an automated message from the Apache Git Serv

Re: [PR] fix(datasets): persist dataset extra dict to dataset event [airflow]

2023-12-06 Thread via GitHub
blag commented on PR #36075: URL: https://github.com/apache/airflow/pull/36075#issuecomment-184200 Please refer to the PR implementing this, and the discussion about an `extra` parameter [here](https://github.com/apache/airflow/pull/25419#pullrequestreview-1061066994). IIRC, the

Re: [I] Delete DagRun event is not registered in audit log [airflow]

2023-12-06 Thread via GitHub
vchiapaikeo commented on issue #36057: URL: https://github.com/apache/airflow/issues/36057#issuecomment-1843345898 Sooo it looks like this is actually being logged already in the audit log. However, it simply doesn't have an associated dag_id - https://github.com/apache/airflow/assets

Re: [PR] Implement task duration page in react. [airflow]

2023-12-06 Thread via GitHub
tirkarthi commented on PR #35863: URL: https://github.com/apache/airflow/pull/35863#issuecomment-1843348683 > Let's have x-axis labels still Done. I had instance as x-axis which leads to formatting as [object object] in the UI. I rely on execution date as using dataIntervalEnd lea

Re: [PR] Implement task duration page in react. [airflow]

2023-12-06 Thread via GitHub
tirkarthi commented on PR #35863: URL: https://github.com/apache/airflow/pull/35863#issuecomment-1843351355 > I also think we could bring in some Task details to this page. Basic stuff like the operator that comes from /dags/{dag_id}/tasks/{task_id} in the rest API I can pick it up as

Re: [PR] Fix AWS system tests [airflow]

2023-12-06 Thread via GitHub
syedahsn commented on code in PR #36091: URL: https://github.com/apache/airflow/pull/36091#discussion_r1417742343 ## airflow/providers/amazon/aws/operators/redshift_cluster.py: ## @@ -103,8 +103,37 @@ class RedshiftCreateClusterOperator(BaseOperator): "cluster_identifie

Re: [I] Deferrable operator tasks do not call `on_kill` method when fail or restarted [airflow]

2023-12-06 Thread via GitHub
tirkarthi commented on issue #36090: URL: https://github.com/apache/airflow/issues/36090#issuecomment-1843374660 Related : https://github.com/apache/airflow/issues/19929 . It seems this was reported earlier but got closed as stale issue. -- This is an automated message from the Apache Git

Re: [I] Dataset extra fields are not persisted [airflow]

2023-12-06 Thread via GitHub
blag commented on issue #35297: URL: https://github.com/apache/airflow/issues/35297#issuecomment-1843376925 Respectfully, I believe this issue is invalid. Datasets and dataset events are separate and distinct things, as are their respective `extra` fields, and copying `DatasetModel.extra` i

Re: [PR] fix(datasets): persist dataset extra dict to dataset event [airflow]

2023-12-06 Thread via GitHub
blag commented on PR #36075: URL: https://github.com/apache/airflow/pull/36075#issuecomment-1843390310 The docs are not optimally worded and definitely conflate datasets and dataset events, possibly leading to this confusion. See [here](https://airflow.apache.org/docs/apache-airflow/stable/

  1   2   >