svn commit: r24542 - /release/incubator/pulsar/KEYS

2018-01-29 Thread hrsakai
Author: hrsakai Date: Tue Jan 30 07:21:49 2018 New Revision: 24542 Log: Added gpg key for hrsakai Modified: release/incubator/pulsar/KEYS Modified: release/incubator/pulsar/KEYS == --- release/incubator/pulsar/KEYS

svn commit: r24541 - /dev/incubator/pulsar/KEYS

2018-01-29 Thread hrsakai
Author: hrsakai Date: Tue Jan 30 07:15:32 2018 New Revision: 24541 Log: Added gpg key for hrsakai Modified: dev/incubator/pulsar/KEYS Modified: dev/incubator/pulsar/KEYS == --- dev/incubator/pulsar/KEYS (original)

[GitHub] jai1 commented on a change in pull request #1123: Configure a max producer/consumer queue size enforced across partitions

2018-01-29 Thread GitBox
jai1 commented on a change in pull request #1123: Configure a max producer/consumer queue size enforced across partitions URL: https://github.com/apache/incubator-pulsar/pull/1123#discussion_r164650547 ## File path: pulsar-client-cpp/lib/ProducerConfiguration.cc ## @@

[GitHub] hrsakai opened a new pull request #1146: Fix url option on client tool

2018-01-29 Thread GitBox
hrsakai opened a new pull request #1146: Fix url option on client tool URL: https://github.com/apache/incubator-pulsar/pull/1146 ### Motivation We can't use `pulsar-client` command without specifing `serviceUrl`,`brokerServiceUrl`, or `webServiceUrl`. ``` $ cat

[incubator-pulsar] branch master updated: Fix race condition in testRedeliveryOnBlockedDistpatcher (#1144)

2018-01-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 059149c Fix race condition in

[GitHub] merlimat closed issue #814: Intermittent test failure DispatcherBlockConsumerTest.testRedeliveryOnBlockedDistpatcher

2018-01-29 Thread GitBox
merlimat closed issue #814: Intermittent test failure DispatcherBlockConsumerTest.testRedeliveryOnBlockedDistpatcher URL: https://github.com/apache/incubator-pulsar/issues/814 This is an automated message from the Apache

[GitHub] merlimat commented on issue #1145: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice

2018-01-29 Thread GitBox
merlimat commented on issue #1145: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice URL: https://github.com/apache/incubator-pulsar/issues/1145#issuecomment-361471241 This reproduces locally after running ~900 times.

[GitHub] merlimat opened a new issue #1145: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice

2018-01-29 Thread GitBox
merlimat opened a new issue #1145: Intermittent test failure in PersistentTopicTest.testClosingReplicationProducerTwice URL: https://github.com/apache/incubator-pulsar/issues/1145 As seen in

[GitHub] merlimat opened a new pull request #1144: Fix race condition in testRedeliveryOnBlockedDistpatcher

2018-01-29 Thread GitBox
merlimat opened a new pull request #1144: Fix race condition in testRedeliveryOnBlockedDistpatcher URL: https://github.com/apache/incubator-pulsar/pull/1144 ### Motivation The test is using `receiveAsync()` over multiple consumer objects and adding the message ids on an

[GitHub] merlimat commented on a change in pull request #1135: Added infinite time retention configuration option

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1135: Added infinite time retention configuration option URL: https://github.com/apache/incubator-pulsar/pull/1135#discussion_r164624867 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java

[GitHub] merlimat commented on issue #1097: Validate expected types in Python code wrapper

2018-01-29 Thread GitBox
merlimat commented on issue #1097: Validate expected types in Python code wrapper URL: https://github.com/apache/incubator-pulsar/pull/1097#issuecomment-361454629 retest this please This is an automated message from the

[GitHub] merlimat closed pull request #1139: Add timeouts to setup & teardown for ReplicatorTest

2018-01-29 Thread GitBox
merlimat closed pull request #1139: Add timeouts to setup & teardown for ReplicatorTest URL: https://github.com/apache/incubator-pulsar/pull/1139 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[incubator-pulsar] branch master updated: Add timeouts to setup & teardown for ReplicatorTest (#1139)

2018-01-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new 8a2b2f0 Add timeouts to setup &

[GitHub] rdhabalia commented on a change in pull request #1135: Added infinite time retention configuration option

2018-01-29 Thread GitBox
rdhabalia commented on a change in pull request #1135: Added infinite time retention configuration option URL: https://github.com/apache/incubator-pulsar/pull/1135#discussion_r164621919 ## File path: pulsar-client-tools/src/main/java/org/apache/pulsar/admin/cli/CmdNamespaces.java

[GitHub] rdhabalia commented on issue #1002: Making Pulsar Proxy more secure

2018-01-29 Thread GitBox
rdhabalia commented on issue #1002: Making Pulsar Proxy more secure URL: https://github.com/apache/incubator-pulsar/pull/1002#issuecomment-361450629 retest this please This is an automated message from the Apache Git Service.

[GitHub] rdhabalia commented on issue #1002: Making Pulsar Proxy more secure

2018-01-29 Thread GitBox
rdhabalia commented on issue #1002: Making Pulsar Proxy more secure URL: https://github.com/apache/incubator-pulsar/pull/1002#issuecomment-361450629 retest this please This is an automated message from the Apache Git Service.

[GitHub] rdhabalia commented on a change in pull request #1002: Making Pulsar Proxy more secure

2018-01-29 Thread GitBox
rdhabalia commented on a change in pull request #1002: Making Pulsar Proxy more secure URL: https://github.com/apache/incubator-pulsar/pull/1002#discussion_r164619782 ## File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/LookupProxyHandler.java ## @@

[GitHub] rdhabalia commented on a change in pull request #1002: Making Pulsar Proxy more secure

2018-01-29 Thread GitBox
rdhabalia commented on a change in pull request #1002: Making Pulsar Proxy more secure URL: https://github.com/apache/incubator-pulsar/pull/1002#discussion_r164620502 ## File path: pulsar-broker-common/src/main/java/org/apache/pulsar/broker/authorization/AuthorizationManager.java

[GitHub] merlimat commented on issue #1003: Intermittent test failure DispatcherBlockConsumerTest.testConsumerBlockingWithUnAckedMessagesAtDispatcher

2018-01-29 Thread GitBox
merlimat commented on issue #1003: Intermittent test failure DispatcherBlockConsumerTest.testConsumerBlockingWithUnAckedMessagesAtDispatcher URL: https://github.com/apache/incubator-pulsar/issues/1003#issuecomment-361438295 Still happening:

[GitHub] merlimat closed issue #1082: Intermittent test failures in DispatcherBlockConsumerTest.testConsumerBlockingWithUnAckedMessagesAtDispatcher

2018-01-29 Thread GitBox
merlimat closed issue #1082: Intermittent test failures in DispatcherBlockConsumerTest.testConsumerBlockingWithUnAckedMessagesAtDispatcher URL: https://github.com/apache/incubator-pulsar/issues/1082 This is an automated

[GitHub] nkurihar commented on issue #1133: Property name in documentation is incorrect

2018-01-29 Thread GitBox
nkurihar commented on issue #1133: Property name in documentation is incorrect URL: https://github.com/apache/incubator-pulsar/pull/1133#issuecomment-361429583 LGTM ? This is an automated message from the Apache Git Service.

[GitHub] merlimat commented on issue #1115: In Kafka consumer wrapper, group multiple messages when the app polls

2018-01-29 Thread GitBox
merlimat commented on issue #1115: In Kafka consumer wrapper, group multiple messages when the app polls URL: https://github.com/apache/incubator-pulsar/pull/1115#issuecomment-361425686 retest this please This is an

[GitHub] merlimat commented on issue #154: Retention 0mb and BacklogQuota 0mb

2018-01-29 Thread GitBox
merlimat commented on issue #154: Retention 0mb and BacklogQuota 0mb URL: https://github.com/apache/incubator-pulsar/issues/154#issuecomment-361416957 Added 2nd PR for docs changes: https://github.com/apache/incubator-pulsar/pull/1141

[GitHub] merlimat opened a new pull request #1141: Some clarifications on Retention documentation

2018-01-29 Thread GitBox
merlimat opened a new pull request #1141: Some clarifications on Retention documentation URL: https://github.com/apache/incubator-pulsar/pull/1141 ### Motivation Tried to simplify here a couple of statements on Retention and added references to infinite retention time as defined in

[GitHub] jai1 commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-29 Thread GitBox
jai1 commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164591461 ## File path: pulsar-client-cpp/lib/ProducerImpl.cc ## @@ -50,7 +50,9 @@

[GitHub] lucperkins opened a new pull request #1140: Remove master/slave terminology from Pulsar (WIP)

2018-01-29 Thread GitBox
lucperkins opened a new pull request #1140: Remove master/slave terminology from Pulsar (WIP) URL: https://github.com/apache/incubator-pulsar/pull/1140 ### Motivation There is a broad consensus in our industry that "master/slave" terminology is damaging, unnecessary, and frequently

[GitHub] jai1 commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-29 Thread GitBox
jai1 commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164589275 ## File path: pulsar-client-cpp/lib/ConsumerConfigurationImpl.h ## @@ -31,13 +31,18 @@ struct

[GitHub] jai1 commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-29 Thread GitBox
jai1 commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164588488 ## File path: pulsar-client-cpp/lib/ConsumerConfiguration.cc ## @@ -74,4 +74,30 @@ void

[GitHub] jai1 commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-29 Thread GitBox
jai1 commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164587853 ## File path: pulsar-client-cpp/include/pulsar/ConsumerCryptoFailureAction.h ## @@ -0,0 +1,41 @@

[GitHub] merlimat opened a new pull request #1139: Add timeouts to setup & teardown for ReplicatorTest

2018-01-29 Thread GitBox
merlimat opened a new pull request #1139: Add timeouts to setup & teardown for ReplicatorTest URL: https://github.com/apache/incubator-pulsar/pull/1139 ### Motivation All the tests in `ReplicatorTest` already do have timeouts, though the build keeps getting stuck on this class. The

[GitHub] merlimat opened a new issue #1138: Test Timeouts in ReplicatorTest

2018-01-29 Thread GitBox
merlimat opened a new issue #1138: Test Timeouts in ReplicatorTest URL: https://github.com/apache/incubator-pulsar/issues/1138 I have been seeing a lot of CI builds timing out after 100 minutes, all were blocked on the `ReplicatorTest`. For example:

[GitHub] merlimat commented on issue #1126: Intermittent test failure in testSkipCorruptDataLedger

2018-01-29 Thread GitBox
merlimat commented on issue #1126: Intermittent test failure in testSkipCorruptDataLedger URL: https://github.com/apache/incubator-pulsar/issues/1126#issuecomment-361408690 @rdhabalia I have seen this test failing several times in the last few days. Can you take a look when you have the

[GitHub] jai1 commented on issue #1002: Making Pulsar Proxy more secure

2018-01-29 Thread GitBox
jai1 commented on issue #1002: Making Pulsar Proxy more secure URL: https://github.com/apache/incubator-pulsar/pull/1002#issuecomment-361408368 retest this please This is an automated message from the Apache Git Service. To

[GitHub] merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164583151 ## File path: pom.xml ## @@ -180,7 +200,7 @@ flexible messaging model and an intuitive client

[GitHub] mgodave commented on issue #1112: Broker schema registry (1/3)

2018-01-29 Thread GitBox
mgodave commented on issue #1112: Broker schema registry (1/3) URL: https://github.com/apache/incubator-pulsar/pull/1112#issuecomment-361399155 Replaced with https://github.com/apache/incubator-pulsar/pull/1137 This is an

[GitHub] mgodave opened a new pull request #1137: Schema registry

2018-01-29 Thread GitBox
mgodave opened a new pull request #1137: Schema registry URL: https://github.com/apache/incubator-pulsar/pull/1137 ### Motivation Allow users of the system to store the structure and format of the data in a topic PIP:

[GitHub] mgodave closed pull request #1112: Broker schema registry (1/3)

2018-01-29 Thread GitBox
mgodave closed pull request #1112: Broker schema registry (1/3) URL: https://github.com/apache/incubator-pulsar/pull/1112 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker

2018-01-29 Thread GitBox
ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164565853 ## File path: pom.xml ## @@ -741,7 +761,7 @@ flexible messaging model and an intuitive client

[GitHub] ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker

2018-01-29 Thread GitBox
ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164565510 ## File path: pom.xml ## @@ -180,7 +200,7 @@ flexible messaging model and an intuitive client

[GitHub] merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164565191 ## File path: pom.xml ## @@ -741,7 +761,7 @@ flexible messaging model and an intuitive client

[GitHub] merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164564840 ## File path: pom.xml ## @@ -180,7 +200,7 @@ flexible messaging model and an intuitive client

[GitHub] ivankelly opened a new pull request #1136: Read compacted consumer flag

2018-01-29 Thread GitBox
ivankelly opened a new pull request #1136: Read compacted consumer flag URL: https://github.com/apache/incubator-pulsar/pull/1136 When enabled, a consumer will read messages from a compacted topic ledger if available. When disabled, the consumer will read from the message backlog as

[GitHub] merlimat commented on issue #1133: Property name in documentation is incorrect

2018-01-29 Thread GitBox
merlimat commented on issue #1133: Property name in documentation is incorrect URL: https://github.com/apache/incubator-pulsar/pull/1133#issuecomment-361380688 > @merlimat we should probably get someone who speaks japanese to look at that one Yep, sure. @yush1ga @nkurihar @massakam

[GitHub] ivankelly commented on issue #1042: Update maven compiler plugin to newest version

2018-01-29 Thread GitBox
ivankelly commented on issue #1042: Update maven compiler plugin to newest version URL: https://github.com/apache/incubator-pulsar/pull/1042#issuecomment-361374120 retest this please This is an automated message from the

[GitHub] ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker

2018-01-29 Thread GitBox
ivankelly commented on a change in pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164548657 ## File path: pulsar-broker/pom.xml ## @@ -119,6 +119,34 @@ test +

[GitHub] merlimat closed pull request #1044: Compact algo

2018-01-29 Thread GitBox
merlimat closed pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a

[GitHub] merlimat commented on issue #154: Retention 0mb and BacklogQuota 0mb

2018-01-29 Thread GitBox
merlimat commented on issue #154: Retention 0mb and BacklogQuota 0mb URL: https://github.com/apache/incubator-pulsar/issues/154#issuecomment-361367391 Sorry @sschepens, I missed this issue back in the days. I just created #1135 and I'll create another PR to clarify in the documentation

[GitHub] ivankelly commented on issue #1044: Compact algo

2018-01-29 Thread GitBox
ivankelly commented on issue #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#issuecomment-361366560 @merlimat CI is green now. I can push some more changes if this gets merged. This is an

[GitHub] ivankelly commented on issue #1133: Property name in documentation is incorrect

2018-01-29 Thread GitBox
ivankelly commented on issue #1133: Property name in documentation is incorrect URL: https://github.com/apache/incubator-pulsar/pull/1133#issuecomment-361366061 @merlimat we should probably get someone who speaks japanese to look at that one

[GitHub] merlimat opened a new pull request #1135: Added infinite time retention configuration option

2018-01-29 Thread GitBox
merlimat opened a new pull request #1135: Added infinite time retention configuration option URL: https://github.com/apache/incubator-pulsar/pull/1135 ### Motivation Currently, there is no direct way to configure an "infinite" retention time on data published on Pulsar topics,

[GitHub] merlimat commented on issue #1122: Use Optional for returning least loaded broker

2018-01-29 Thread GitBox
merlimat commented on issue #1122: Use Optional for returning least loaded broker URL: https://github.com/apache/incubator-pulsar/pull/1122#issuecomment-361353480 retest this please This is an automated message from the

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164523814 ## File path: pulsar-client-cpp/lib/MessageCrypto.h ## @@ -0,0 +1,95 @@ +/** + * Licensed to the

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164524553 ## File path: pulsar-client-cpp/lib/ProducerImpl.cc ## @@ -262,12 +295,21 @@ void

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164522672 ## File path: pulsar-client-cpp/include/pulsar/CryptoKeyReader.h ## @@ -0,0 +1,51 @@ +/** + *

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164524311 ## File path: pulsar-client-cpp/lib/ProducerImpl.cc ## @@ -262,12 +295,21 @@ void

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164524955 ## File path: pulsar-client-cpp/run-unit-tests.sh ## @@ -23,7 +23,9 @@ rm -rf ./pulsar-dist

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164523212 ## File path: pulsar-client-cpp/lib/BatchMessageContainer.cc ## @@ -93,6 +93,10 @@ void

[GitHub] merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1129: Added end to end encryption in C++ client URL: https://github.com/apache/incubator-pulsar/pull/1129#discussion_r164523753 ## File path: pulsar-client-cpp/lib/MessageCrypto.h ## @@ -0,0 +1,95 @@ +/** + * Licensed to the

[GitHub] merlimat commented on issue #1044: Compact algo

2018-01-29 Thread GitBox
merlimat commented on issue #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#issuecomment-360880464 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] merlimat commented on a change in pull request #1124: Support Pulsar proxy from C++/Python client library

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1124: Support Pulsar proxy from C++/Python client library URL: https://github.com/apache/incubator-pulsar/pull/1124#discussion_r164510154 ## File path: pulsar-client-cpp/lib/Url.cc ## @@ -88,6 +88,12 @@ const std::string&

[GitHub] merlimat commented on a change in pull request #1124: Support Pulsar proxy from C++/Python client library

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1124: Support Pulsar proxy from C++/Python client library URL: https://github.com/apache/incubator-pulsar/pull/1124#discussion_r164509672 ## File path: pulsar-client-cpp/lib/ConnectionPool.cc ## @@ -33,36 +33,37 @@

[GitHub] jai1 commented on issue #1125: Added missing C++ enum values

2018-01-29 Thread GitBox
jai1 commented on issue #1125: Added missing C++ enum values URL: https://github.com/apache/incubator-pulsar/pull/1125#issuecomment-361327943 retest this please This is an automated message from the Apache Git Service. To

[GitHub] merlimat commented on a change in pull request #1044: Compact algo

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1044: Compact algo URL: https://github.com/apache/incubator-pulsar/pull/1044#discussion_r164508229 ## File path: pulsar-broker/src/main/java/org/apache/pulsar/compaction/TwoPhaseCompactor.java ## @@ -0,0 +1,282 @@ +/** + *

[GitHub] jai1 commented on a change in pull request #1124: Support Pulsar proxy from C++/Python client library

2018-01-29 Thread GitBox
jai1 commented on a change in pull request #1124: Support Pulsar proxy from C++/Python client library URL: https://github.com/apache/incubator-pulsar/pull/1124#discussion_r164505677 ## File path: pulsar-client-cpp/lib/Url.h ## @@ -41,6 +41,8 @@ class Url { const

[GitHub] merlimat commented on issue #1047: Add StatefulSet option for BookKeeper on Google Kubernetes Engine

2018-01-29 Thread GitBox
merlimat commented on issue #1047: Add StatefulSet option for BookKeeper on Google Kubernetes Engine URL: https://github.com/apache/incubator-pulsar/pull/1047#issuecomment-361325066 retest this please This is an automated

[incubator-pulsar] branch master updated: Comment in config breaks docker scripts (#1131)

2018-01-29 Thread mmerli
This is an automated email from the ASF dual-hosted git repository. mmerli pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/incubator-pulsar.git The following commit(s) were added to refs/heads/master by this push: new b3fe055 Comment in config breaks

[GitHub] merlimat closed pull request #1131: Comment in config breaks docker scripts

2018-01-29 Thread GitBox
merlimat closed pull request #1131: Comment in config breaks docker scripts URL: https://github.com/apache/incubator-pulsar/pull/1131 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] merlimat commented on issue #1134: [WIP] Docker compose files for pulsar

2018-01-29 Thread GitBox
merlimat commented on issue #1134: [WIP] Docker compose files for pulsar URL: https://github.com/apache/incubator-pulsar/pull/1134#issuecomment-361319778 Even though this is not technically a "prod" deployment, should we have it under the `deployment` folder?

[GitHub] merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker

2018-01-29 Thread GitBox
merlimat commented on a change in pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132#discussion_r164501056 ## File path: pulsar-broker/pom.xml ## @@ -119,6 +119,34 @@ test + Review

[GitHub] ivankelly commented on issue #1134: [WIP] Docker compose files for pulsar

2018-01-29 Thread GitBox
ivankelly commented on issue #1134: [WIP] Docker compose files for pulsar URL: https://github.com/apache/incubator-pulsar/pull/1134#issuecomment-361294703 Currently only works with docker images generated with #1131 and #1132 applied.

[GitHub] ivankelly opened a new pull request #1134: Docker compose files for pulsar

2018-01-29 Thread GitBox
ivankelly opened a new pull request #1134: Docker compose files for pulsar URL: https://github.com/apache/incubator-pulsar/pull/1134 These files set up two clusters, US and EU, all on the local machine. Each cluster has 2 pulsar brokers, 3 bookies, and a 2 zookeeper nodes, one in

[GitHub] ivankelly opened a new pull request #1133: Property name in documentation is incorrect

2018-01-29 Thread GitBox
ivankelly opened a new pull request #1133: Property name in documentation is incorrect URL: https://github.com/apache/incubator-pulsar/pull/1133 The setup guides specify that test-prop is the property name, but then all later examples use test as the property name. This is obviously

[GitHub] ivankelly opened a new pull request #1132: Explicitly set zookeeper version in broker

2018-01-29 Thread GitBox
ivankelly opened a new pull request #1132: Explicitly set zookeeper version in broker URL: https://github.com/apache/incubator-pulsar/pull/1132 The broker "shades" zookeeper via the aspectj stuff, but the version it shades is the one pulled in with bookkeeper-server, not the version

[GitHub] ivankelly opened a new pull request #1131: Comment in config breaks docker scripts

2018-01-29 Thread GitBox
ivankelly opened a new pull request #1131: Comment in config breaks docker scripts URL: https://github.com/apache/incubator-pulsar/pull/1131 docker/scripts/apply-config-from-env.py only accepts # comments, not double slash.

[GitHub] jai1 commented on issue #1002: Making Pulsar Proxy more secure

2018-01-29 Thread GitBox
jai1 commented on issue #1002: Making Pulsar Proxy more secure URL: https://github.com/apache/incubator-pulsar/pull/1002#issuecomment-361228242 retest this please This is an automated message from the Apache Git Service. To