Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-05 Thread robert burrell donkin
On 5 May 2004, at 13:56, David Graham wrote: --- Simon Kitching <[EMAIL PROTECTED]> wrote: So the only question is: should it be BeanUtils that copies the class and does a release (with Digester depending on the new BeanUtils release), or should the copied class be added to Digester, with Digest

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-05 Thread David Graham
--- Simon Kitching <[EMAIL PROTECTED]> wrote: > On Wed, 2004-05-05 at 11:57, Craig McClanahan wrote: > > I like copying the class without a package rename as a medium-term > step > > while we deprecate and create a new public method that returns a > > standard collection class instead of a [coll

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-04 Thread Simon Kitching
On Wed, 2004-05-05 at 11:57, Craig McClanahan wrote: > I like copying the class without a package rename as a medium-term step > while we deprecate and create a new public method that returns a > standard collection class instead of a [collections] class. The chances > of a bad change on the [c

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-04 Thread Craig McClanahan
Stephen Colebourne wrote: This slipped past me... I have already examined the source and test compatability of collections 3.0 and 2.1: http://www.mail-archive.com/[EMAIL PROTECTED]/msg37636.html Binary compatability is much more difficult to test for. As there is no automated tool, some binary i

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-04 Thread Craig McClanahan
Stephen Colebourne wrote: From: "David Graham" <[EMAIL PROTECTED]> What happens if someone is using both digester and collections? Which ArrayStack class would be used when they're in the same package in different jars? Hoping that the class doesn't change seems rather optimistic and error pr

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-04 Thread Stephen Colebourne
This slipped past me... I have already examined the source and test compatability of collections 3.0 and 2.1: http://www.mail-archive.com/[EMAIL PROTECTED]/msg37636.html Binary compatability is much more difficult to test for. As there is no automated tool, some binary incompatabilities did occur

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-04 Thread Stephen Colebourne
From: "David Graham" <[EMAIL PROTECTED]> > What happens if someone is using both digester and collections? Which > ArrayStack class would be used when they're in the same package in > different jars? Hoping that the class doesn't change seems rather > optimistic and error prone. Its a judgement

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-04 Thread David Graham
--- Stephen Colebourne <[EMAIL PROTECTED]> wrote: > From: "robert burrell donkin" <[EMAIL PROTECTED]> > > maybe we could sidestep this issue by including the two collections > > classes (ArrayStack and Buffer) that beanutils depends upon (either > > directly or indirectly) within the beanutils rel

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-04 Thread Stephen Colebourne
From: "robert burrell donkin" <[EMAIL PROTECTED]> > maybe we could sidestep this issue by including the two collections > classes (ArrayStack and Buffer) that beanutils depends upon (either > directly or indirectly) within the beanutils release and removing the > collections dependency. since the v

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-04 Thread David Graham
--- robert burrell donkin <[EMAIL PROTECTED]> wrote: > On 4 May 2004, at 22:34, David Graham wrote: > > --- robert burrell donkin <[EMAIL PROTECTED]> > wrote: > > > > >> we screwed up :( > >> > >> a reference (in a public API) to the collection packaged version was > >> introduced and not picke

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-04 Thread Simon Kitching
On Wed, 2004-05-05 at 09:09, robert burrell donkin wrote: > On 24 Apr 2004, at 04:19, Craig R. McClanahan wrote: > > > > > From what I can see on TOMCAT-DEV, the Tomcat developers think that > > there are backwards incompatibilities for Tomcat users (beyond any > > issues that might affect Tom

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-04 Thread robert burrell donkin
On 4 May 2004, at 22:34, David Graham wrote: --- robert burrell donkin <[EMAIL PROTECTED]> wrote: we screwed up :( a reference (in a public API) to the collection packaged version was introduced and not picked up before it had been released. Can we deprecate the offending API, provide standard J

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-04 Thread David Graham
--- robert burrell donkin <[EMAIL PROTECTED]> wrote: > > On 4 May 2004, at 22:23, David Graham wrote: > > > > > --- robert burrell donkin <[EMAIL PROTECTED]> > wrote: > >> On 24 Apr 2004, at 04:19, Craig R. McClanahan wrote: > >> > >> > >> > >>> From what I can see on TOMCAT-DEV, the Tomcat dev

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-04 Thread robert burrell donkin
On 4 May 2004, at 22:23, David Graham wrote: --- robert burrell donkin <[EMAIL PROTECTED]> wrote: On 24 Apr 2004, at 04:19, Craig R. McClanahan wrote: From what I can see on TOMCAT-DEV, the Tomcat developers think that there are backwards incompatibilities for Tomcat users (beyond any issues th

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-04 Thread David Graham
--- robert burrell donkin <[EMAIL PROTECTED]> wrote: > On 24 Apr 2004, at 04:19, Craig R. McClanahan wrote: > > > > > From what I can see on TOMCAT-DEV, the Tomcat developers think that > > there are backwards incompatibilities for Tomcat users (beyond any > > issues that might affect Tomcat

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-04 Thread robert burrell donkin
On 24 Apr 2004, at 04:19, Craig R. McClanahan wrote: From what I can see on TOMCAT-DEV, the Tomcat developers think that there are backwards incompatibilities for Tomcat users (beyond any issues that might affect Tomcat itself). Based on that, I've certainly been one of those casting aspersi

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-05-01 Thread Craig R. McClanahan
Stephen Colebourne wrote: From: "Simon Kitching" <[EMAIL PROTECTED]> While compiling the release notes, and checking for API incompatibilities between releases, it occurred to me that there is a backward compatibility issue. Am I right in thinking that when subclassing a class with "protected"

Re: [digester] local ArrayStack implementation not backwardscompatible?

2004-04-19 Thread Stephen Colebourne
From: "Simon Kitching" <[EMAIL PROTECTED]> > While compiling the release notes, and checking for API > incompatibilities between releases, it occurred to me that there is a > backward compatibility issue. Am I right in thinking that when > subclassing a class with "protected" members, if the parent