Re: [all][POLL] what files to fixcrlf for windows distributions

2005-12-04 Thread Niall Pemberton
- Original Message - From: Stephen Colebourne [EMAIL PROTECTED] Sent: Sunday, December 04, 2005 12:56 AM I was the one who initially raised this issue. The reason I raised it is that most _users_ run Windows. And the default text editor on Windows is Notepad which doesn't handle LF.

Re: [all][POLL] what files to fixcrlf for windows distributions

2005-12-03 Thread Phil Steitz
I don't think it is feasible to patch the maven dist plugin or the hand-rolled ant scripts to inspect .svn/props for each file and then change line endings accordingly. I also verified that distros created on Windows are in fact shipping CRLF line endings on all files that have eol=native in

Re: [all][POLL] what files to fixcrlf for windows distributions

2005-12-03 Thread Martin Cooper
On 12/3/05, Phil Steitz [EMAIL PROTECTED] wrote: I don't think it is feasible to patch the maven dist plugin or the hand-rolled ant scripts to inspect .svn/props for each file and then change line endings accordingly. I also verified that distros created on Windows are in fact shipping CRLF

Re: [all][POLL] what files to fixcrlf for windows distributions

2005-12-03 Thread Phil Steitz
Thanks, Martin. I stand corrected then and will shut up about this. To close this out, I guess we are agreeing that we have no standard for line endings and will make no attempt to make them consistent. I did not know the Windows cvs client was also converting the files, so thought this was a

Re: [all][POLL] what files to fixcrlf for windows distributions

2005-12-03 Thread Henri Yandell
Has everyone been following the bit on http://www.apache.org/dev/version-control.html? -- Committers will need to properly configure their svn client. One particular issue is OS-specific line-endings for text files. When you add a new text file, especially when

Re: [all][POLL] what files to fixcrlf for windows distributions

2005-12-03 Thread Stephen Colebourne
Phil Steitz wrote: Thanks, Martin. I stand corrected then and will shut up about this. To close this out, I guess we are agreeing that we have no standard for line endings and will make no attempt to make them consistent. I did not know the Windows cvs client was also converting the files, so

Re: [all][POLL] what files to fixcrlf for windows distributions

2005-12-03 Thread Martin van den Bemt
Hi Stephen, Just add something like this in the maven.xml (the test is pretty useless probably..): j:if test=${os != 'Linux'} ant:fixcrlf srcdir=. includes=${abatchfile} eol=dos/ /j:if And of course you should add xmlns:ant=jelly:ant to have the ant namespace available.. Don't

Re: [all][POLL] what files to fixcrlf for windows distributions

2005-12-03 Thread Phil Steitz
On 12/3/05, Martin van den Bemt [EMAIL PROTECTED] wrote: Hi Stephen, Just add something like this in the maven.xml (the test is pretty useless probably..): j:if test=${os != 'Linux'} ant:fixcrlf srcdir=. includes=${abatchfile} eol=dos/ /j:if And of course you should add

Re: [all][POLL] what files to fixcrlf for windows distributions

2005-11-28 Thread sebb
On 27/11/05, Phil Steitz [EMAIL PROTECTED] wrote: snip I am working on a patch to the maven dist plugin that makes the crlf filter property configurable. Arnaud pointed out in another thread that there should probably a similar filter applied to make sure lf line endings are used in

Re: [all][POLL] what files to fixcrlf for windows distributions

2005-11-27 Thread sebb
On 27/11/05, Phil Steitz [EMAIL PROTECTED] wrote: On 11/15/05, Stephen Colebourne [EMAIL PROTECTED] wrote: Mario Ivankovits wrote: [X] .txt [ ] .java [ ] .properties [ ] .xml [ ] .css [ ] .mf My preference is for all ASCII files not in the src/java or src/text folders

Re: [all][POLL] what files to fixcrlf for windows distributions

2005-11-27 Thread Martin van den Bemt
Mario Ivankovits wrote: Hi! It turns out that it is required to fix the crlf (EOL) thing when building distributions for windows distributions. A windows distribution is a distribution packed as zip file. Required by who and what is broken ? And I don't agree that zips are windows

Re: [all][POLL] what files to fixcrlf for windows distributions

2005-11-27 Thread Phil Steitz
snip I am working on a patch to the maven dist plugin that makes the crlf filter property configurable. Arnaud pointed out in another thread that there should probably a similar filter applied to make sure lf line endings are used in the tar.gz distros. My inclination is to apply this

Re: [all][POLL] what files to fixcrlf for windows distributions

2005-11-26 Thread Phil Steitz
On 11/15/05, Stephen Colebourne [EMAIL PROTECTED] wrote: Mario Ivankovits wrote: [X] .txt [ ] .java [ ] .properties [ ] .xml [ ] .css [ ] .mf My preference is for all ASCII files not in the src/java or src/text folders to be converted. Note that I doubt [collections] or [io] do

Re: [all][POLL] what files to fixcrlf for windows distributions

2005-11-15 Thread Dion Gillard
As someone who uses Windows on a daily basis, I've never had a pproblem with the LF line endings and hence would only filter *.txt in a binary distribution. On 11/15/05, Mario Ivankovits [EMAIL PROTECTED] wrote: Hi! It turns out that it is required to fix the crlf (EOL) thing when building

RE: [all][POLL] what files to fixcrlf for windows distributions

2005-11-15 Thread Arnaud HERITIER
: mardi 15 novembre 2005 10:02 À : Jakarta Commons Developers List Objet : Re: [all][POLL] what files to fixcrlf for windows distributions As someone who uses Windows on a daily basis, I've never had a pproblem with the LF line endings and hence would only filter *.txt in a binary

Re: [all][POLL] what files to fixcrlf for windows distributions

2005-11-15 Thread Stephen Colebourne
Mario Ivankovits wrote: [X] .txt [ ] .java [X] .properties [X] .xml [X] .css [X] .mf My preference is for all ASCII files not in the src/java or src/text folders to be converted. Note that I doubt [collections] or [io] do this fully yet. Stephen