On Sat, 20 Nov 2021 03:26:51 GMT, Alexey Semenyuk wrote:
> 8277429: Conflicting jpackage static library name
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6485
On Fri, 19 Nov 2021 05:07:23 GMT, Vicente Romero wrote:
>> Please review this PR which aims to optimize the implementation of the
>> `toString` method we provide for records. A benchmark comparing the
>> implementation we are providing for records with lombok found out that
>> lombok is much f
8277429: Conflicting jpackage static library name
-
Commit messages:
- 8277429: Conflicting jpackage static library name
Changes: https://git.openjdk.java.net/jdk/pull/6485/files
Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=6485&range=00
Issue: https://bugs.openjdk.java.
On Fri, 19 Nov 2021 22:50:49 GMT, David Holmes wrote:
>> Regarding **jcmd** updates, I'm thinking maybe this would be better handled
>> separately. There is the potential to update to `GC.finalizer_info`
>> discussed previously. Looking at the **jcmd** tool docs, it seems like
>> `GC.run_final
On Fri, 5 Nov 2021 13:52:49 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to keep track of the last modified timesta
> The commit here is a potential fix for the issue noted in
> https://bugs.openjdk.java.net/browse/JDK-8258117.
>
> The change here repurposes an existing internal interface `ModuleInfoEntry`
> to keep track of the last modified timestamp of a `module-info.class`
> descriptor.
>
> This commit
On Wed, 17 Nov 2021 18:48:14 GMT, Volker Simonis wrote:
> In JDK 9, function objects implemented as anonymous inner classes in
> java.util.regex.Pattern have been replaced by lambda functions (see
> [JDK-8151481](https://bugs.openjdk.java.net/browse/JDK-8151481)). This led to
> a significant p
On Fri, 19 Nov 2021 20:13:06 GMT, Stuart Marks wrote:
>> Stuart Marks has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove Finalizer.Holder class.
>
> Regarding **jcmd** updates, I'm thinking maybe this would be better handled
> separ
On Fri, 19 Nov 2021 20:57:46 GMT, Daniel D. Daugherty
wrote:
> This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0.
>
> So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this
> [BACKOUT] has
> passed the macosx-aarch64 test task that was failing before.
This pull
On Fri, 19 Nov 2021 22:33:40 GMT, Alexey Semenyuk wrote:
>> This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0.
>>
>> So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this
>> [BACKOUT] has
>> passed the macosx-aarch64 test task that was failing before.
>
> Marked
On Fri, 19 Nov 2021 20:57:46 GMT, Daniel D. Daugherty
wrote:
> This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0.
>
> So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this
> [BACKOUT] has
> passed the macosx-aarch64 test task that was failing before.
Marked as
On Fri, 19 Nov 2021 20:57:46 GMT, Daniel D. Daugherty
wrote:
> This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0.
>
> So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this
> [BACKOUT] has
> passed the macosx-aarch64 test task that was failing before.
Marked as
> Both jar and jmod utilise java.io file operations whose methods define no
> ordering of the return file lists, and in fact rely on OS query file
> ordering, which can differ by underlying OS architecture.
> This PR adds sort processing to the creation of such jar's and jmod's to
> enable a det
On Fri, 19 Nov 2021 21:33:43 GMT, Mandy Chung wrote:
>> @magicus I've added updates to the jar and jmod man pages, as "Notes" about
>> ordering, does that sound reasonable?
>
>> I've added updates to the jar and jmod man pages, as "Notes" about
>> ordering, does that sound reasonable?
>
> The
On Fri, 19 Nov 2021 21:22:28 GMT, Andrew Leonard wrote:
> I've added updates to the jar and jmod man pages, as "Notes" about ordering,
> does that sound reasonable?
The true source of the man pages are still kept in our closed repository. The
copy in the jdk repo is generated from our closed
On Fri, 19 Nov 2021 20:57:46 GMT, Daniel D. Daugherty
wrote:
> This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0.
>
> So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this
> [BACKOUT] has
> passed the macosx-aarch64 test task that was failing before.
My Mach5 T
On Thu, 18 Nov 2021 11:42:48 GMT, Magnus Ihse Bursie wrote:
>>> Just to verify, this test jar had 16000 files in a single directory? Since
>>> having 100 files in 160 directories would not have the same impact, right?
>>
>> @magicus so the first test I did was 16,000 files in multiple directori
On Fri, 19 Nov 2021 20:25:56 GMT, Lance Andersen wrote:
> The changes look good.
>
> Could you please add a comment overviewing each test. Thank you
Done
-
PR: https://git.openjdk.java.net/jdk/pull/6395
> Both jar and jmod utilise java.io file operations whose methods define no
> ordering of the return file lists, and in fact rely on OS query file
> ordering, which can differ by underlying OS architecture.
> This PR adds sort processing to the creation of such jar's and jmod's to
> enable a det
On Fri, 19 Nov 2021 20:57:46 GMT, Daniel D. Daugherty
wrote:
> This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0.
>
> So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this
> [BACKOUT] has
> passed the macosx-aarch64 test task that was failing before.
My Mach5 T
On Fri, 19 Nov 2021 20:47:40 GMT, Roger Riggs wrote:
>> The `jdk.internal.ValueBased` annotation was incorrectly applied to
>> subclasses of java.util.AbstractMap.
>> [ValueBased](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/doc-files/ValueBased.html)
>> requires that
This reverts commit 936f7ff49ed86adb74bb1ff10d93cb3d7f7d70a0.
So far we've had 3 failed Tier2 job sets in a row. My Mach5 Tier2 of this
[BACKOUT] has
passed the macosx-aarch64 test task that was failing before.
-
Commit messages:
- Revert "8276150: Quarantined jpackage apps are la
On Wed, 17 Nov 2021 10:34:52 GMT, Sergey Bylokhov wrote:
>>> Yes it would be nice to clarify that a null is accepted by setComment. When
>>> null is specified, the comment length is written as 0
>>
>> @mrserb Are you taking the spec clarification or should we just created
>> another issue in J
> The `jdk.internal.ValueBased` annotation was incorrectly applied to
> subclasses of java.util.AbstractMap.
> [ValueBased](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/doc-files/ValueBased.html)
> requires that supertypes have no instance fields; AbstractMap has instanc
On Fri, 19 Nov 2021 19:08:48 GMT, Lance Andersen wrote:
>>> My thought is to remove it from this PR, since we've already determined the
>>> change has little impact.
>> We can raise a new issue if we feel it's needed.
>>
>> This is fine with me.
>
> I am Ok with separating this out as well but
On Fri, 19 Nov 2021 17:11:24 GMT, Mandy Chung wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276764: Enable deterministic file content ordering for Jar and Jmod
>>
>> Signed-off-by: Andrew Leonard
>
> tes
On Fri, 19 Nov 2021 20:15:54 GMT, Andrew Leonard wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort processi
On Fri, 19 Nov 2021 00:14:18 GMT, Stuart Marks wrote:
>> Pretty much what it says. The new option controls a static member in
>> InstanceKlass that's consulted to determine whether the finalization
>> machinery is activated for instances when a class is loaded. A new native
>> method is added
> Both jar and jmod utilise java.io file operations whose methods define no
> ordering of the return file lists, and in fact rely on OS query file
> ordering, which can differ by underlying OS architecture.
> This PR adds sort processing to the creation of such jar's and jmod's to
> enable a det
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Fri, 19 Nov 2021 00:14:18 GMT, Stuart Marks wrote:
>> Pretty much what it says. The new option controls a static member in
>> InstanceKlass that's consulted to determine whether the finalization
>> machinery is activated for instances when a class is loaded. A new native
>> method is added
On Fri, 19 Nov 2021 18:38:25 GMT, Lance Andersen wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276764: Enable deterministic file content ordering for Jar and Jmod
>>
>> Signed-off-by: Andrew Leonard
>
>
On Fri, 19 Nov 2021 17:27:45 GMT, Mandy Chung wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276764: Enable deterministic file content ordering for Jar and Jmod
>>
>> Signed-off-by: Andrew Leonard
>
> The
On Fri, 19 Nov 2021 18:55:40 GMT, Mandy Chung wrote:
>> The benchmark should use JMH. @cl4es, what are your thoughts here?
>
>> My thought is to remove it from this PR, since we've already determined the
>> change has little impact.
> We can raise a new issue if we feel it's needed.
>
> This i
On Fri, 19 Nov 2021 10:10:33 GMT, Andrew Leonard wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort processi
On Fri, 19 Nov 2021 18:15:46 GMT, Brent Christian wrote:
>> src/java.base/share/classes/java/lang/Object.java line 481:
>>
>>> 479: * system resources or to perform other cleanup.
>>> 480: *
>>> 481: * When running in a Java virtual machine in which finalization
>>> has been
>>
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Fri, 19 Nov 2021 18:33:31 GMT, Lance Andersen wrote:
>> My thought is to remove it from this PR, since we've already determined the
>> change has little impact.
>> We can raise a new issue if we feel it's needed.
>
> The benchmark should use JMH. @cl4es, what are your thoughts here?
> My th
On Mon, 8 Nov 2021 18:59:06 GMT, Сергей Цыпанов wrote:
>> This is a follow-up for https://github.com/openjdk/jdk/pull/4507, looks like
>> there are some cases that were not covered.
>>
>> Also this is related to https://github.com/openjdk/jdk/pull/3615
>
> Сергей Цыпанов has updated the pull re
On Sun, 17 Oct 2021 21:06:44 GMT, Andrey Turbanov wrote:
> Non-static classes hold a link to their parent classes, which can be avoided.
This pull request has now been integrated.
Changeset: e47cc81b
Author:Andrey Turbanov
Committer: Roger Riggs
URL:
https://git.openjdk.java.net/jd
On Thu, 7 Oct 2021 18:00:33 GMT, Andrey Turbanov wrote:
> Pass cause exception as constructor parameter is shorter and easier to read.
This pull request has now been integrated.
Changeset: f609b8fd
Author:Andrey Turbanov
Committer: Roger Riggs
URL:
https://git.openjdk.java.net/jdk/
On Sun, 26 Sep 2021 15:10:52 GMT, Andrey Turbanov wrote:
> In couple of classes, result part of arrays of Pattern.split is compared with
> `null`. Pattern.split (and hence String.split) never returns `null` in array
> elements. Such comparisons are redundant.
This pull request has now been int
On Fri, 17 Sep 2021 08:56:47 GMT, Andrey Turbanov wrote:
> String.contains was introduced in Java 5.
> Some code in java.base still uses old approach with `String.indexOf` to check
> if String contains specified substring.
> I propose to migrate such usages. Makes code shorter and easier to read
On Thu, 18 Nov 2021 23:43:20 GMT, Joe Wang wrote:
>> Add setProperty/getProperty methods to the XPath API so that properties can
>> be supported in the future.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update as commente
On Fri, 19 Nov 2021 10:10:33 GMT, Andrew Leonard wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort processi
On Fri, 19 Nov 2021 18:30:37 GMT, Andrew Leonard wrote:
>> @LanceAndersen what's your opinion? I'm not totally sure of it's usefulness?
>
> My thought is to remove it from this PR, since we've already determined the
> change has little impact.
> We can raise a new issue if we feel it's needed.
On Fri, 19 Nov 2021 18:13:47 GMT, Andrew Leonard wrote:
>> test/jdk/tools/jar/CreateJarBenchmark.java line 56:
>>
>>> 54: import jdk.test.lib.util.FileUtils;
>>> 55:
>>> 56: public class CreateJarBenchmark {
>>
>> This is a benchmark which should not be run as regression testing. I
>> wonde
On Fri, 19 Nov 2021 18:30:17 GMT, Lance Andersen wrote:
> The changes look OK.
>
> Have you run the JCK tests in addition to the Mach5 tests for the areas being
> changed to make sure we did not trip over a conformance test?
Sorry wrong PR window please ignore this comment
-
PR:
On Fri, 19 Nov 2021 10:10:33 GMT, Andrew Leonard wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort processi
On Fri, 5 Nov 2021 13:52:49 GMT, Jaikiran Pai wrote:
>> The commit here is a potential fix for the issue noted in
>> https://bugs.openjdk.java.net/browse/JDK-8258117.
>>
>> The change here repurposes an existing internal interface `ModuleInfoEntry`
>> to keep track of the last modified timesta
On Fri, 19 Nov 2021 15:50:47 GMT, Roger Riggs wrote:
> The `jdk.internal.ValueBased` annotation was incorrectly applied to
> subclasses of java.util.AbstractMap.
> [ValueBased](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/doc-files/ValueBased.html)
> requires that supe
Add a new --source-date (epoch milliseconds) option to jar and jmod
to allow specification of time to use for created/updated jar/jmod entries.
This then allows the ability to make the content deterministic.
Signed-off-by: Andrew Leonard
-
Commit messages:
- 8276766: Enable jar
On Fri, 19 Nov 2021 18:06:39 GMT, Mandy Chung wrote:
>> Here are the code changes for the "Deprecate finalizers in the standard Java
>> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
>> review.
>>
>> This change makes the indicated deprecations, and updates the API spe
On Fri, 19 Nov 2021 17:24:15 GMT, Mandy Chung wrote:
>> Andrew Leonard has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8276764: Enable deterministic file content ordering for Jar and Jmod
>>
>> Signed-off-by: Andrew Leonard
>
> tes
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Fri, 19 Nov 2021 15:50:47 GMT, Roger Riggs wrote:
> The `jdk.internal.ValueBased` annotation was incorrectly applied to
> subclasses of java.util.AbstractMap.
> [ValueBased](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/doc-files/ValueBased.html)
> requires that supe
The `jdk.internal.ValueBased` annotation was incorrectly applied to subclasses
of java.util.AbstractMap.
[ValueBased](https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/lang/doc-files/ValueBased.html)
requires that supertypes have no instance fields; AbstractMap has instance
field
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Thu, 18 Nov 2021 23:43:20 GMT, Joe Wang wrote:
>> Add setProperty/getProperty methods to the XPath API so that properties can
>> be supported in the future.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update as commente
On Fri, 19 Nov 2021 10:10:33 GMT, Andrew Leonard wrote:
>> Both jar and jmod utilise java.io file operations whose methods define no
>> ordering of the return file lists, and in fact rely on OS query file
>> ordering, which can differ by underlying OS architecture.
>> This PR adds sort processi
On Thu, 18 Nov 2021 23:43:20 GMT, Joe Wang wrote:
>> Add setProperty/getProperty methods to the XPath API so that properties can
>> be supported in the future.
>
> Joe Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update as commente
On Sun, 14 Nov 2021 16:45:07 GMT, Ichiroh Takiguchi
wrote:
>> Good suggestions. Filed a JBS issue:
>> https://bugs.openjdk.java.net/browse/JDK-8276970
>
> Hello @naotoj .
> For PrintStream.getCharset(), following changes may be required.
>
> +++ src/java.base/share/classes/java/io/OutputStream
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Thu, 18 Nov 2021 21:51:30 GMT, Brent Christian wrote:
> Here are the code changes for the "Deprecate finalizers in the standard Java
> API" portion of JEP 421 ("Deprecate Finalization for Removal") for code
> review.
>
> This change makes the indicated deprecations, and updates the API spec
On Mon, 8 Nov 2021 18:59:06 GMT, Сергей Цыпанов wrote:
>> This is a follow-up for https://github.com/openjdk/jdk/pull/4507, looks like
>> there are some cases that were not covered.
>>
>> Also this is related to https://github.com/openjdk/jdk/pull/3615
>
> Сергей Цыпанов has updated the pull re
On Fri, 15 Oct 2021 18:51:44 GMT, Andrey Turbanov wrote:
> Non-static classes hold a link to their parent classes, which can be avoided.
LGTM
-
Marked as reviewed by rriggs (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/5971
On Thu, 18 Nov 2021 11:42:48 GMT, Magnus Ihse Bursie wrote:
>>> Just to verify, this test jar had 16000 files in a single directory? Since
>>> having 100 files in 160 directories would not have the same impact, right?
>>
>> @magicus so the first test I did was 16,000 files in multiple directori
On Mon, 15 Nov 2021 19:56:28 GMT, Andy Herrick wrote:
> JDK-8276150: Quarantined jpackage apps are labeled as "damaged"
This pull request has now been integrated.
Changeset: 936f7ff4
Author:Andy Herrick
URL:
https://git.openjdk.java.net/jdk/commit/936f7ff49ed86adb74bb1ff10d93cb3d7f7
On Fri, 15 Oct 2021 18:51:44 GMT, Andrey Turbanov wrote:
> Non-static classes hold a link to their parent classes, which can be avoided.
I usually don't review changes in this area of core-libs but these are simple
enough and look reasonable.
-
Marked as reviewed by dfuchs (Review
I have been experimenting with
https://bugs.openjdk.java.net/browse/JDK-8224794 and have reached a
stage with my changes where I would like some inputs before I move ahead
or raise a PR for review.
As noted in that JBS issue, the idea is to open the underlying file
using FILE_SHARE_DELETE whe
On Fri, 19 Nov 2021 05:12:25 GMT, Vicente Romero wrote:
> It seems like the execution is way faster for these number of slots.
I suggested this experiment to split up the concatenations more aggressively to
diagnose if we're having an issue here where the performance of the method
handle produ
On Wed, 17 Nov 2021 19:48:25 GMT, kabutz wrote:
>> BigInteger currently uses three different algorithms for multiply. The
>> simple quadratic algorithm, then the slightly better Karatsuba if we exceed
>> a bit count and then Toom Cook 3 once we go into the several thousands of
>> bits. Since T
> Both jar and jmod utilise java.io file operations whose methods define no
> ordering of the return file lists, and in fact rely on OS query file
> ordering, which can differ by underlying OS architecture.
> This PR adds sort processing to the creation of such jar's and jmod's to
> enable a det
On Wed, 17 Nov 2021 21:29:00 GMT, Lance Andersen wrote:
>> I agree, I always use {}, I was being consistent with the rest of the
>> expand() method, but I will add {} as I prefer that too, better to set a
>> good example!
>
> Feel free to clean those up as well :-)
all fixed
-
PR
On Thu, 18 Nov 2021 09:32:04 GMT, Andrew Leonard wrote:
>> test/jdk/tools/jar/ContentOrder.java line 79:
>>
>>> 77: @Test
>>> 78: public void test1() throws IOException {
>>> 79: mkdir("testjar/Ctest1 testjar/Btest2/subdir1 testjar/Atest3");
>>
>> I suggest to make `mkdir` and `
On Thu, 18 Nov 2021 23:49:46 GMT, Mandy Chung wrote:
>> Andrew Leonard has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - 8276764: Enable deterministic file content ordering for Jar and Jmod
>>
>>Signed-off-by: Andrew Leonard
>>
> Both jar and jmod utilise java.io file operations whose methods define no
> ordering of the return file lists, and in fact rely on OS query file
> ordering, which can differ by underlying OS architecture.
> This PR adds sort processing to the creation of such jar's and jmod's to
> enable a det
78 matches
Mail list logo
