Re: RFR: JDK-8227641: java-options values with spaces are processed incorrectly

On 8/9/2019 9:25 AM, Roger Riggs wrote: Hi Alexander, I'm not sure we want to get into the business of telling people how use use shell quoting. It does vary from shell to shell and on Windows vs. Linux. I'd pick one simple example that works on Windows as well as Linux. I would have

Re: RFR: JDK-8227641: java-options values with spaces are processed incorrectly

I don't think we should put these examples in help text of --java-options, and that we we should just close this bug as "not a bug". The necessity of escaping option values with spaces and embedded quotes applies to many other jpackage options as well. The examples here don't really require

RFR: JDK-8224788: jpackage fails on OS X when using --runtime-image

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). JDK-8224788: jpackage fails on OS X when using --runtime-image [1] https://bugs.openjdk.java.net/browse/JDK-8224788 [2]

Re: RFR: JDK-8229252 : Add descriptions to Windows jtreg tests

this is fine. /Andy On 8/7/2019 12:47 PM, Alexey Semenyuk wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Add comments to Windows jtreg tests to help SQE setup their testing. [1]

RFR: JDK-8228744: file associations broken on linux.

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8228744 [2] http://cr.openjdk.java.net/~herrick/8228744/ /Andy

Re: jpackage: packaging a real application

Thanks for the heads up on linux file associations.  I have filed JDK-8228744 and make sure it is fixed. As to the customization of the msi scripts, it is generally the intention of the implementation that all resources would be fetched by calling fetchResource() in AbstractBundler.java.  I

Re: RFR (XXS): 8228722: jpackage RPM tests fail on some versions of rpmbuild

looks good. /Andy On 7/29/2019 10:43 AM, Dmitry Chuyko wrote: Hello, Please review a tiny fix of a test bug that appears in some environments. While extending jpackage platforms support in JDK-8222778 I used "-E" rpmbuild shortcut for arch detection. It seems to be missing in some versions

Re: RFR: JDK-8227684 : jpackage must handle win32 mangled names in jli.dll

ted changes, /Andy On 7/25/2019 8:22 AM, Kevin Rushforth wrote: It looks fine. -- Kevin On 7/25/2019 6:20 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://

RFR: JDK-8227312: Remove pkg bundle from DMG image.

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8227312 [2] http://cr.openjdk.java.net/~herrick/8227312/webrev.01/ /Andy

RFR: JDK-8227684 : jpackage must handle win32 mangled names in jli.dll

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8227684 [2] http://cr.openjdk.java.net/~herrick/8227684/webrev.01/ Submitted by: Robert Lichtenberger

Re: JDK-8228402: chdir() and write() errors are not handled in jpackage

terminates app abnormally. Do we really should terminate execution if write() fails in this case? Can we ignore error? It might be better to handle it gracefully and then return from main() with error if we cannot ignore error. Thanks, Alexander On 7/23/2019 2:07 PM, Andy Herrick wrote: Ple

JDK-8228402: chdir() and write() errors are not handled in jpackage

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8228402 [2] http://cr.openjdk.java.net/~herrick/8228402/ /Andy

RFR: JDK-8226542: DMG tests failing with java.io.IOException: Exec failed with code 1 command

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226542 [2] http://cr.openjdk.java.net/~herrick/8226542/ /Andy

RFR: JDK-8224627: Creating installer with --runtime-image on OS X fails

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8224627 [2] http://cr.openjdk.java.net/~herrick/8224627/webrev.01/ /Andy

Re: RFR: JDK-8220807: excessive verbose output when running with --win-per-user-install

. Is this by intention? - Alexey On 7/12/2019 10:31 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8220807 [2] http

Re: jpackage: spaces in --java-options

I can reproduce this problem and have created JDK-8227641 to address it. /Andy On 7/12/2019 3:53 AM, Serban Iordache wrote: Currently, there is no easy way to pass system properties containing spaces to the Java runtime. For example, if we

RFR: JDK-8220807: excessive verbose output when running with --win-per-user-install

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8220807 [2] http://cr.openjdk.java.net/~herrick/8220807/ /Andy

RFR: JDK-8227058: Regressions related to no longer setting user.dir

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8227058 [2] http://cr.openjdk.java.net/~herrick/8227058/ /Andy

Re: JPackage application image file system layout

will require further discussion. /Andy I would be willing to invest time in a patch for  b) or c) but only if someone with authority (Andy Herrick?) tells me, this makes sense. Best regards, Robert Lichtenberger

Re: OS X jpackage and java.class.path

can you share the command options used launching jpackage ? I think I would understand better if I saw the complete command. /Andy On 7/1/2019 3:02 PM, Michael Hall wrote: I think I may out mentioned this before but maybe I didn’t fix the problems it was causing me because I just ran into

Re: RFR: JDK-8226751: "Exception: ..." for missing file

be read:     if (!Files.isReadable(Paths.of(name))) The rest looks fine. -- Kevin On 6/29/2019 6:27 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https

RFR: JDK-8226891: rename and re-layout jpackage tests.

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226891 [2] http://cr.openjdk.java.net/~herrick/8226891/

RFR: JDK-8226751: "Exception: ..." for missing file

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226751 [2] http://cr.openjdk.java.net/~herrick/8226751/

Re: RFR: JDK-8224486: Arguments from jpackager cfg file not processed correctly

and Package.cpp. - Old loop is kept to avoid possible regression in case if we want to add values from OrderedMap which does not have duplicates flag set to true. Thanks, Alexander On 6/26/2019 7:21 AM, Andy Herrick wrote: then I'm fine with original fix. /Andy On 6/25/2019 6:08 PM, Alexander

RFR: JDK-8226904: current working directory wrong running jpackage app

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226904 [2] http://cr.openjdk.java.net/~herrick/8226904/webrev.01/ /Andy

Re: JPackage EA build 8 ( jdk-14-jpackage+1-8 )

On 6/27/2019 4:07 PM, Scott Palmer wrote: I also just noticed that "--icon" is not allowed with "--package-type msi"  when creating the msi using --app-image.  It should be, unless there is some other way to set the icon to show in "Add or Remove programs"? The --icon option needs to be

Re: RFR: JDK-8226599 use code coverage results to remove dead code

final test layout and names. I have filed JDK-8226891 to handle further name and layout changes /Andy On 6/26/2019 9:28 PM, Alexander Matveev wrote: Hi Andy, Why only some tests are renamed? Otherwise looks fine. Thanks, Alexander On 6/26/2019 4:09 PM, Andy Herrick wrote: Please review the jp

RFR: JDK-8226599 use code coverage results to remove dead code

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8226599 [2] http://cr.openjdk.java.net/~herrick/8226599/webrev.03 /Andy

Re: JPackage EA build 8 ( jdk-14-jpackage+1-8 )

We need to investigate this further, I have created issue: JDK-8221333 to track this issue. Thank you for you feedback. /Andy On 6/25/2019 9:17 AM, Rachel Greenham wrote: I've been getting the new jpackage working with our project build. Generally everything's fine. One probable minor bug

Re: JPackage EA build 8 ( jdk-14-jpackage+1-8 )

package:”, but this seems like a good suggestion to add one. Would "mac-dmg-image" or "mac-dmg-background" be an appropriate option name for such an option ? /Andy Regards, Scott On Jun 24, 2019, at 2:31 PM, Andy Herrick wrote: The next EA build of JPackage i

Re: RFR: JDK-8224486: Arguments from jpackager cfg file not processed correctly

then I'm fine with original fix. /Andy On 6/25/2019 6:08 PM, Alexander Matveev wrote: Hi Alexey, I cannot use index to get items from map. At least I did not figure it out how to do this. We need to use iterator when getting values from map. Thanks, Alexander On 6/25/2019 4:52 AM, Alexey

Re: RFR: JDK-8224486: Arguments from jpackager cfg file not processed correctly

I'm fine with this either way. The ini file will have GetAllowDuplicates() true, but any OrderedMap that doesn't will have count of 1. /Andy On 6/25/2019 7:52 AM, Alexey Semenyuk wrote: In

JPackage EA build 8 ( jdk-14-jpackage+1-8 )

whitespace only file modification. JDK-8223321: jpackage ToolProvider is not thread-safe JDK-8226532: cleanup is not called when jpackage command fails. JDK-8224597: create automated tests for platform create-app-image options please send feedback to core-libs-dev@openjdk.java.net /Andy Herrick

RFR: JDK-8226532: cleanup is not called when jpackage command fails.

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). Trivial fix to clean up the temp directory created by jpackage. [1] https://bugs.openjdk.java.net/browse/JDK-8226532 [2]

Re: RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

On 6/20/2019 1:44 PM, Kevin Rushforth wrote: Looks good. I presume you will update the HelpResources.properties for other languages before you push? yes - they are updated - I just left them out of the file list. /Andy -- Kevin On 6/20/2019 9:54 AM, Andy Herrick wrote: On 6/19/2019 1

Re: RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

On 6/19/2019 1:34 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). JDK-8225428: CLI change to remove "mode", rename to "package", and build only on

Re: RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

e. Thanks, Alexander On 6/19/2019 10:34 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). JDK-8225428: CLI change to remove "mode", rename to "package", and bui

Re: RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

ot;}; --- Should it be "--app-image"? yes - there is no need for a change here, either will work (since checking code uses String.contains()) but will revert in the next revision. /Andy - Alexey On 6/19/2019 1:34 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at

RFR: JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). JDK-8225428: CLI change to remove "mode", rename to "package", and build only one target [1] https://bugs.openjdk.java.net/browse/JDK-8225428 [2]

Re: RFR: JDK-8226193: BundleNameTest and BundleIdentifierTest fails if run without network connection

looks good. /Andy On 6/14/2019 6:42 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by disabling loading external DTD files. [1]

Re: RFR: JDK-8221333: Replace Inno Setup with custom MSI wrapper for .exe bundler

On 6/14/19, 3:45 PM, Andy Herrick wrote: I imported this patch , and after some merging problems, built jpackager. a simple exe installer built with: $JDK_HOME/bin/jpackage create-installer \ --installer-type exe \ --input ../input-jars \ --output output \ --name test-exe \ --vendor

Re: RFR: JDK-8221333: Replace Inno Setup with custom MSI wrapper for .exe bundler

I imported this patch , and after some merging problems, built jpackager. a simple exe installer built with: $JDK_HOME/bin/jpackage create-installer \ --installer-type exe \ --input ../input-jars \ --output output \ --name test-exe \ --vendor "Oracle Test" \ --description "Test exe installer"

Re: RFR: JDK-8225569: jpackage app-image layout

this one before push. /Andy -- Kevin On 6/14/2019 7:17 AM, Andy Herrick wrote: Please review the revised jpackage fix [3] for issue [1] revised to use Path.of() in JPackagePath test helper and to centralize code that creates output dirs and/or makes sure they are empty and writable. [3

Re: RFR: JDK-8225569: jpackage app-image layout

, Andy Herrick wrote: Sorry - subject was missing, this is for: JDK-8225569: jpackage app-image layout /Andy On 6/13/2019 12:59 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage

Re: RFR: JDK-8225569: jpackage app-image layout

Otherwise looks good. Thanks, Alexander On 6/13/2019 11:00 AM, Alexey Semenyuk wrote: Looks good. Q: any good reason we are not using Paths.get(a, b, c) instead of a + File.separator + b + File.separator + c to build paths? - Alexey On 6/13/2019 1:21 PM, Andy Herrick wrote: Sorry

Re: RFR: JDK-8225569: jpackage app-image layout

helper) is among the worst of the offenders. I will make a pass at cleaning that up and any other such places this change set is touching. /Andy - Alexey On 6/13/2019 1:21 PM, Andy Herrick wrote: Sorry - subject was missing, this is for: JDK-8225569: jpackage app-image layout /Andy

RFR: JDK-8225569: jpackage app-image layout

Sorry - subject was missing, this is for: JDK-8225569: jpackage app-image layout /Andy On 6/13/2019 12:59 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https

RFR:

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8225569 [2] http://cr.openjdk.java.net/~herrick/8225569/webrev.01/

Re: jpackage DMG creation trouble

I think the question here was what is in the dmg image. The dmg could be an image of the pkg, or an image of the application. Jeff says "I get both the app image *and *a pkg installer inside said dmg." We need to look into that. /Andy On 6/12/2019 9:04 AM, Kevin Rushforth wrote: Or if you

Re: RFR: JDK-8224597: create automated tests for platform create-app-image options

looks good. /Andy On 6/10/2019 10:24 PM, Alexander Matveev wrote: http://cr.openjdk.java.net/~almatvee/8224597/webrev.03/ - Tests are updated to use DOM+XPath. Thanks, Alexander On 6/10/2019 5:41 PM, Alexey Semenyuk wrote: I agree that SAX/StAX are faster and more memory efficient compared

Re: RFR: JDK-8225023: JPackageCreateAppImageBundleNameTest fails

looks good. /Andy On 6/10/2019 9:11 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed by using correct id for MAC_CF_BUNDLE_NAME, otherwise it was not set from

Re: RFR: JDK-8224597: create automated tests for platform create-app-image options

looks good to me. /Andy On 6/6/2019 5:37 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Added tests for --win-console, --mac-bundle-identifier and

Re: RFR: JDK-8224130: create additional automated tests for create-app-image

ead of new BufferedWriter(new FileWriter...)). -Alexey On 6/5/2019 8:07 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-822413

Re: RFR: JDK-8223333: Use try-with-resources where feasible

, lines 81-93 can be replaced with a single statement, something like: --- java.nio.file.Files.copy(   new ByteArrayInputStream(baos.toByteArray()),   output.toPath(),   StandardCopyOption.REPLACE_EXISTING); --- - Alexey On 6/5/2019 7:54 PM, Andy Herrick wrote: Please review

Re: RFR: JDK-8223333: Use try-with-resources where feasible

, Rémi - Mail original - De: "Andy Herrick" À: "core-libs-dev" Envoyé: Jeudi 6 Juin 2019 01:54:05 Objet: RFR: JDK-822: Use try-with-resources where feasible Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sa

RFR: JDK-8224130: create additional automated tests for create-app-image

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8224130 [2] http://cr.openjdk.java.net/~herrick/8224130/ /Andy

RFR: JDK-8224130: create additional automated tests for create-app-image

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8224130 [2] http://cr.openjdk.java.net/~herrick/8224130/ /Andy

RFR: JDK-8223212: Code cleanup found during jpackage review

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8223212 [2] http://cr.openjdk.java.net/~herrick/8223212/ /Andy

RFR: JDK-8223586: remove jpackage dead code and other cleanup

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8223586 [2] http://cr.openjdk.java.net/~herrick/8223586/ /Andy

RFR: JDK-8224748: --add-launcher option --add-modules

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8224748 [2] http://cr.openjdk.java.net/~herrick/8224748/ /Andy

RFR: JDK-8223953: Fix CLASSPATH parsing for sub-directorys containing spaces

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8223953 [2] http://cr.openjdk.java.net/~herrick/8223953/ /Andy

RFR: JDK-8223241: jpackage cleanup from code review

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8223241 [2] http://cr.openjdk.java.net/~herrick/8223241/ /Andy

RFR: JDK-8223334: Additional cleanup in jpackage tool

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8223334 [2] http://cr.openjdk.java.net/~herrick/8223334/ /Andy

RFR: JDK-8223333: Use try-with-resources where feasible

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-822 [2] http://cr.openjdk.java.net/~herrick/822/ /Andy

RFR: JDK-8222901: different behavior when --name option not used

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222901 [2] http://cr.openjdk.java.net/~herrick/8222901 /Andy

RFR: JDK-8223080: Build team code review requests.

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8223080 [2] http://cr.openjdk.java.net/~herrick/8223080/ /Andy

Re: Problems with jpackage

Can you send me the exact steps you use to show this problem ? /Andy On 6/2/2019 7:24 PM, Antônio Diego wrote:  Hello, I noticed that the generated runtime image by the jpackage don't contains the modules specified with the --module-path nor the --add-modules arguments.  Also, I noticed

Re: Problem with jpackage/Windows and using a different runtime

Klaus: I sent you this reply a few weeks back, and didn't get any further reply ... /Andy On 5/16/2019 10:59 AM, Andy Herrick wrote: Klaus: My apologies for not getting back to you sooner. I have tried the (nearly) the exact steps you give and can run the resultant app on windows. My

Re: jpackage multiple --add-exports

I've been trying your example (or something I have created that is close to it) and thought I was seeing multiple --add-exports are passed to the VM in my case. But on closer look I think when I have 3 "--java-options --add-exports=..." jpackager options, I get the three expected lines in

Re: Problem with jpackage/Windows and using a different runtime

Klaus: My apologies for not getting back to you sooner. I have tried the (nearly) the exact steps you give and can run the resultant app on windows. My best guess is that it is caused by a problem we have when there are spaces in the path given to --runtime-image. (similar to

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

On 5/10/2019 3:39 PM, Roger Riggs wrote: Hi Andy, Thanks for logging the issues. CLIHelp:  - 58, 65, 72, 80: Indentation of pLaunchOptions does not line up. I don't see what you mean here.  Looks lined up to me The lines with pLaunchOptions have tabs instead of spaces. jcheck has some

Re: Inno setup 6 broke javapacker/jpackage

Although we plan to remove dependency on Inno Setup in the future, if that is not done soon after initial integration we can fix this in WinExeBundler.java by handling this case.  I will add line item to one of the post integration fix CR's to do this. Thanks. /Andy On 5/9/2019 12:19 PM,

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

he mac app builder do the checking. All above added to JDK-8223586 <https://bugs.openjdk.java.net/browse/JDK-8223586> /Andy Regards, Roger On 04/29/2019 05:58 PM, Andy Herrick wrote: jpackage reviewers: We hope to move JEP 343 to "Proposed to Target" next week, so we would like expedite the review process as much as possible.

Re: RFR: JDK-8223318: jpackage --mac-bundle-name option doesn't work

Semyon: This webrev also includes your fix for 8223038 (http://cr.openjdk.java.net/~ssadetsky/8223038/). Both fixes look good, but should wait till after JEP is targeted. /Andy On 5/3/2019 3:08 PM, semyon.sadet...@oracle.com wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8223318

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

looks good. /Andy On 5/3/2019 2:08 PM, Kevin Rushforth wrote: Here is the webrev to document the threading limitation: https://bugs.openjdk.java.net/browse/JDK-8223321 http://cr.openjdk.java.net/~kcr/8223321/webrev.00/ Once reviewed, Andy can include this in the next version of the webrev

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

know if these were previously reviewed there, but I am not sure what the changes in NativeCompilation.gmk have to do with jpackage. -phil. On 4/24/19, 5:47 PM, Andy Herrick wrote: On 4/24/2019 8:44 PM, Andy Herrick wrote: Please review  changes for [1] which is the implementation bug fo

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

JDK-8223264 has been filed to address this. /Andy On 5/2/2019 2:25 PM, Phil Race wrote: Although our build system doesn't complain, my local Linux gcc generates several warnings which prevent jpackage from building. The attached patch makes

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

was only used for the Mac App Store deployment. Since it is not supported anymore this option is not used anywhere and need to be removed. Also the jdk.jpackage.internal. MacAppStoreBundler class and related resources are the dead code. --Semyon On 4/24/19 5:44 PM, Andy Herrick wrote: Please

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

I filed JDK-8223241 to address each of these issues, and included import statement wildcard usage as suggested (removing it from JDK-8223189 ) /Andy On 5/1/2019 7:17 PM, Kevin Rushforth

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

I have filed JDK-8223189 to address these. /Andy On 4/30/2019 7:02 PM, Kevin Rushforth wrote: I have a couple nit-picky comments: 1. The change to src/jdk.jlink/share/classes/module-info.java is unrelated to jpackage and should be

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

I filed task JDK-8223187 to look into (1) and CR JDK-8223188 to address (2). /Andy On 4/30/2019 6:53 PM, Phil Race wrote: A couple of questions / observations :- 1) setlocale

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

ewing this code. /Andy On 4/24/2019 8:44 PM, Andy Herrick wrote: Please review  changes for [1] which is the implementation bug for JEP-343. The webrev at [2] is the total cumulative webrev of changes for the jpackage tool, currently in the JDK-8200758-branch branch of the open sandbox reposit

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

On 4/29/2019 12:21 PM, Erik Joelsson wrote: There is a new set of macros that should be used to check things like target OS. The new macro is called like this: ifeq ($(call isTargetOs, windows macosx linux), false) Lib-jdk.jpackage.gmk and Launcher-jdk.jpackage.gmk: Same thing with

Re: RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

On 4/24/2019 8:44 PM, Andy Herrick wrote: Please review  changes for [1] which is the implementation bug for JEP-343. The webrev at [2] is the total cumulative webrev of changes for the jpackage tool, currently in the JDK-8200758-branch branch of the open sandbox repository. The webrev

RFR: JDK-8212780: JEP 343: Packaging Tool Implementation

Please review  changes for [1] which is the implementation bug for JEP-343. The webrev at [2] is the total cumulative webrev of changes for the jpackage tool, currently in the JDK-8200758-branch branch of the open sandbox repository. The webrev at [3] shows the changes from EA-05 to EA-06.

jpackage EA 6 Build 49 (2019/4/19)

. please send feedback to core-libs-dev@openjdk.java.net /Andy Herrick

RFR: JDK-8219683,,Modify App Image layout on Mac

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8219683 [2] http://cr.openjdk.java.net/~herrick/8219683/ /Andy

Re: RFR: JDK-8222676: create-installer with --app-image fails on mac

looks good to me - will test it tomorrow with my test cases. /Andy On 4/18/2019 8:05 PM, Alexander Matveev wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). - Fixed issue when app image is

Re: RFR: JDK-8222733: Modify jpackage option --add-launcher syntax

On 4/18/2019 5:21 PM, Phil Race wrote:  173 \  This Option can be used Multiple times.\n\ Why the capitalisation ? no reason - will revise /Andy -phil. On 4/18/19 2:17 PM, Alexander Matveev wrote: Hi Andy, Looks good. Thanks, Alexander On 4/18/2019 12:49 PM, Andy Herrick

RFR: JDK-8222733: Modify jpackage option --add-launcher syntax

Please review the jpackage fix for bugs [1] and [2] at [3]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222733 [2] https://bugs.openjdk.java.net/browse/JDK-8222731 [3]

Re: RFR: JDK-8219683: Investigate App Image layout on Mac

On 4/17/2019 6:33 PM, Andy Herrick wrote: On 4/17/2019 6:18 PM, semyon.sadet...@oracle.com wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8219683 webrev: http://cr.openjdk.java.net/~ssadetsky/8219683/webrev.00/ The fix moves Java runtime form Contents/PlugIns/Java.runtime

Re: RFR: JDK-8219683: Investigate App Image layout on Mac

On 4/17/2019 6:18 PM, semyon.sadet...@oracle.com wrote: bug: https://bugs.openjdk.java.net/browse/JDK-8219683 webrev: http://cr.openjdk.java.net/~ssadetsky/8219683/webrev.00/ The fix moves Java runtime form Contents/PlugIns/Java.runtime to Contents/Java.runtime. --Semyon Is there any

RFR: 8222486: Reorder sample usage in jpackage help output

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222486 [2] http://cr.openjdk.java.net/~herrick/8222486/ /Andy

RFR: JDK-8222439: New jpackage test fails on mac, linux

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222439 [2] http://cr.openjdk.java.net/~herrick/8222406/

RFR: JDK-8222406: Multiple arguments for the same option - aggragation broken.

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8222406 [2] http://cr.openjdk.java.net/~herrick/8222406/ /Andy

Re: RFE: JDK-8217895: jpackage --identifier purpose

On 4/11/2019 6:06 PM, semyon.sadet...@oracle.com wrote: On 4/11/19 12:05 PM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK

RFE: JDK-8217895: jpackage --identifier purpose

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] https://bugs.openjdk.java.net/browse/JDK-8217895 [2] http://cr.openjdk.java.net/~herrick/8217895/ /Andy

Re: RFR: JDK-8221749: Error messages

On 4/8/2019 6:05 PM, Andy Herrick wrote: On 4/8/2019 5:41 PM, Alexander Matveev wrote: Hi Andy, Looks good. Also, many messages (including added in this review) in MainResources.properties do have "." at the end and some don't. I think we should cleanup it and add ".&

Re: RFR: JDK-8221749: Error messages

e not full sentences, but most are.  Those that are should end in a period. I will address that in the next clean-up change. /ANdy Thanks, Alexander On 4/8/2019 4:41 AM, Andy Herrick wrote: Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open

RFR: JDK-8221749: Error messages

Please review the jpackage fix for bug [1] at [2]. This is a fix for the JDK-8200758-branch branch of the open sandbox repository (jpackage). [1] http://cr.openjdk.java.net/~herrick/8221749/ [2] https://bugs.openjdk.java.net/browse/JDK-8221749/ /Andy

<    2   3   4   5   6   7   8   9   >