Hi Bob,
Sorry I took a look but can't really review it in detail as I don't know
any of the cgroup details. Not sure who may ... perhaps Misha (cc'd).
On 15/03/2019 12:15 am, Bob Vandette wrote:
Ping ...
Please review these three fixes for Linux Docker/cgroup container support.
WEBREV:
Hi Ivan,
On 15/03/2019 5:49 am, Ivan Gerasimov wrote:
Hello!
The default implementation of Process.waitFor(long, TimeUnit) does not
check if the process has exited after the last portion of the timeout
has expired.
Please clarify. There is always a race between detecting a timeout and
the
Hi Ivan,
This is an "ancient" bug that you are fixing. I don't think it is valid.
On 15/03/2019 3:29 am, Ivan Gerasimov wrote:
Hello!
Not all the man pages agree that chmod, access and statvfs64 can be
interrupted, but at least on some platforms they are allowed to fail
with EINTR:
Looks good.
Thanks Kim!
David
-
On 14/03/2019 9:02 am, Kim Barrett wrote:
On Mar 13, 2019, at 4:29 PM, Kim Barrett wrote:
On Mar 13, 2019, at 4:07 PM, Kim Barrett wrote:
Please review this change to the JNI specification. The specified
behavior of Weak Global References, and in
Hi Lance,
On 13/03/2019 3:30 am, Lance Andersen wrote:
Hi all,
Please review this addition to the ProblemList.txt as this tests times out
from time to time
$ hg diff test/jdk/ProblemList.txt
diff -r 687e10fefa11 test/jdk/ProblemList.txt
--- a/test/jdk/ProblemList.txt Mon Mar 11 13:37:56
On 7/03/2019 12:48 am, Scott Palmer wrote:
I don’t mean any offence, but I have to say, I strongly disagree with nearly
everything you’ve written below. To me, the idea of making a stream of integers
for a simple loop counter is hackish, confusing, verbose, and basically abusing
the stream
On 4/03/2019 9:30 pm, Andrew Leonard wrote:
Hi,
This bug raised a missmatch between the Java and JNI definition for a
native method, where Java specifies "boolean" and the JNI jint. Which is
right, should they match?
https://bugs.openjdk.java.net/browse/JDK-8217735
Old javah generates
rstand than replicating that structure
in 3 files.
And of course, add a comment.
To make the source more readable, the cast could be factored
into a macro in the same file with the comment about why it is
needed.
Roger
On 02/21/2019 11:07 PM, David Holmes wrote:
On 22/02/2019 4:55 am,
JavaMain returns THREAD_FUNC_RETURN changes may contain some quite
artificial macro parts in java.c:
http://cr.openjdk.java.net/~dchuyko/8215009/webrev.02/
-Dmitry
On 12/19/18 9:27 AM, David Holmes wrote:
On 19/12/2018 1:56 am, Dmitry Chuyko wrote:
On 12/18/18 3:39 AM, David Holmes wrote
Hi Igor,
On 21/02/2019 3:19 pm, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev//8219139/webrev.00/index.html
40 lines changed: 17 ins; 2 del; 21 mod;
Hi all,
could you please review this small patch which moves tests from test/jdk/vm?
I find some of these tests - the runtime
On 11/02/2019 2:20 pm, Martin Buchholz wrote:
On Sun, Feb 10, 2019 at 7:41 PM David Holmes <mailto:david.hol...@oracle.com>> wrote:
> Still in limbo:
> 8203662: remove increment of modCount from ArrayList and Vector
replaceAll()
>
https://cr.openjd
Hi Martin,
On 9/02/2019 9:42 am, Martin Buchholz wrote:
https://cr.openjdk.java.net/~martin/webrevs/jdk/jsr166-integration/overview.html
8195057: java/util/concurrent/CountDownLatch/Basic.java failed w/ Xcomp
Hi Goetz,
Just one follow up for now:
* Add package visible "void setMessage (String msg)" to Throwable.
Yes, just use package accessibility to deal with this, no need to jump
through hoops (or the VM :) ).
Thanks,
David
On 8/02/2019 9:51 pm, Lindenmaier, Goetz wrote:
Hi David,
Hi
On 8/02/2019 11:59 am, Ivan Gerasimov wrote:
Hi David!
On 2/7/19 5:16 PM, David Holmes wrote:
Hi Ivan,
On 8/02/2019 11:02 am, Ivan Gerasimov wrote:
Hello!
The specification states:
"""
If the length of the specified CharSequence is less than or equal to
zero, then
Hi Ivan,
On 8/02/2019 11:02 am, Ivan Gerasimov wrote:
Hello!
The specification states:
"""
If the length of the specified CharSequence is less than or equal to
zero, then an empty buffer of capacity 16 is returned.
"""
However, the current implementation throws either
In 8/02/2019 10:05 am, David Holmes wrote:
Hi Volker,
Aaarggh!! Sorry Volker and Goetz. No idea where that came from.
David
-
You know I'm not going to be a big fan of this :), but as long as we
don't pay for it if we don't want it, then that's okay. (I'm still
trying to gauge
Hi Volker,
You know I'm not going to be a big fan of this :), but as long as we
don't pay for it if we don't want it, then that's okay. (I'm still
trying to gauge that)
I have a little test for this that I ran through your patch:
public class NPE {
static class B {
C b() { return
discussion offlist.
Best regards,
Jie
[1]
https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-January/057852.html
On 2019/1/31 上午10:09, David Holmes wrote:
Hi Jie, Roger,
I think this has now consumed far too many cycles for everyone,
dealing with a test that is checking for a leak
FAILED: loader not detected weakly
reachable");
}
+ Reference.reachabilityFence(loader);
+ Reference.reachabilityFence(loaderRef);
System.err.println(
"TEST PASSED: loader detected weakly reachable");
Thanks, Roger
On 01/11/2019 07:25 PM, Jie Fu wrote:
Thanks Davi
No attachment received.
David
On 30/01/2019 8:02 am, Andrey Turbanov wrote:
Could you please re-generate your patch? The reason I'm asking is that the
current patch contains extra line breaks.
Hm. There wasn't any extra line breaks in sent email. Regenerated
patch attached.
Andre Turbanov
On 29/01/2019 10:16 pm, Pavel Rappo wrote:
On 29 Jan 2019, at 08:50, David Holmes wrote:
Hi Pavel,
I don't think this kind of trivial change needs the OCA to be signed.
"A Participant may post messages to a list, submit simple patches, and make other
kinds of small contributions."
Hi Pavel,
On 29/01/2019 11:54 am, Pavel Rappo wrote:
On 28 Jan 2019, at 22:23, Andrey Turbanov wrote:
Thanks to review. Patch updated. I'm not really sure what to do next.
I should find someone who can create issue and commit my patch to
repository, right?
Have you signed the OCA [1]? The
On 27/01/2019 3:08 am, Martin Buchholz wrote:
It's a pet peeve that the name GetStringUTFChars is deeply misleading -
there are many "UTF"s, and this encoding is meant for use with the JVM
only. The documentation should make it clearer that this is NOT the UTF-8
you might expect.
It does!
representing the string in
modified UTF-8 encoding.
---
David
-
I have fixed my code, so its not an issue for me any more, but it seems like an
unnecessary tarpit awaiting the unwary.
Just my 2c.
Alan
On Jan 24, 2019, at 10:04 PM, David Holmes wrote:
On 25/01/2019 4:39 am, Alan Snyder
don't know if it is correct to say "all lambda classes" as I don't
know the full translation strategy for lambda expressions, but yes some
lambda generated classes are VM anonymous classes.
David
Thanks
Yumin
On Fri, Jan 25, 2019 at 7:18 PM David Holmes <mailto:david.hol...@oracl
On 25/01/2019 6:52 pm, yumin qi wrote:
Hi,
I have a question of anonymous class. We know the anonymous class with a
host_klass, and the flag is set when the InstanceKlass is created after the
class parsed. In case of a regular java class file, the flag will be set
correctly but for the
On 25/01/2019 4:39 am, Alan Snyder wrote:
Thank you. That post does explain what is happening, but leaves open the
question of whether GetStringUTFChars should be changed.
What is the value of the current implementation of GetStringUTFChars versus one
that returns true UTF-8?
Well that's
Mach 5 tier 1 - 3 tests passed on Linux/OS X/Windows x64 and Solaris
sparcv9.
David
On 22/01/2019 2:01 pm, David Holmes wrote:
Hi Patrick,
I'm putting this through our test system (again) and will report back
when its complete.
I also updated the bug report with the patch and assigned
:07 PM
*To:* Alan Bateman ; Patrick Zhang
; David Holmes
*Cc:* core-libs-dev
*Subject:* Re: 8215976: OpenJDK fails to build with GCC when the
#include inside zip.cpp comes from a non-sysroot path
Hi,
I can sponsor this. Let me know when the jdk-submit is complete.
Thanks, Roger
On 01/16
Hi Robert,
I've cc'd core-libs-dev as this is now about signed-jars and the launcher.
David
On 22/01/2019 4:48 am, Robert Marcano wrote:
On 1/21/19 8:25 AM, Robert Marcano wrote:
On 1/21/19 5:19 AM, Volker Simonis wrote:
-- Moved to hotspot-dev --
Hi Robert,
You can use
On 17/01/2019 5:23 pm, Thomas Stüfe wrote:
On Thu, Jan 17, 2019 at 1:23 AM David Holmes <mailto:david.hol...@oracle.com>> wrote:
On 17/01/2019 12:59 am, Alan Bateman wrote:
>
> Thanks for forwarding as this is a topic that will require a lot of
> discus
On 17/01/2019 12:59 am, Alan Bateman wrote:
Thanks for forwarding as this is a topic that will require a lot of
discussion and agreement from several areas due to potential impact on
long term maintenance and the potential for some of these native methods
to go away.
Gunter - can you
+1
Thanks,
David
On 16/01/2019 1:03 am, Roger Riggs wrote:
Hi Goetz,
Looks fine.
Removing unnecessary special case code is great!
Thanks, Roger
On 01/15/2019 07:49 AM, Lindenmaier, Goetz wrote:
Hi,
As AIX does not know $ORIGIN the path to libjli must be in LIBPATH.
libjli though has
inside
zip.cpp comes from a non-sysroot path
Hi Patrick,
Please re-post the entire proposed patch based on the JDK 13 repo.
BTW, there is already a "#ifndef _MSC_VER" at line 36.
Thanks, Roger
On 01/14/2019 09:02 AM, Magnus Ihse Bursie wrote:
On 2019-01-02 0
Hi John,
On 15/01/2019 11:47 am, John Rose wrote:
On Jan 11, 2019, at 4:53 PM, David Holmes <mailto:david.hol...@oracle.com>> wrote:
I think there is a problem knowing when "access check" means just
access check and when it means "access check plus the special hack f
On 12/01/2019 10:13 am, Mandy Chung wrote:
On 1/11/19 3:03 PM, David Holmes wrote:
On 12/01/2019 8:47 am, Mandy Chung wrote:
On 1/11/19 2:38 PM, David Holmes wrote:
There seem to be a number of spec issues around this. Shouldn't
findStaticSetter say something about what happens when the field
On 11/01/2019 11:11 pm, Remi Forax wrote:
- Mail original -
De: "David Holmes"
À: "Adam Farley8" , "core-libs-dev"
Envoyé: Vendredi 11 Janvier 2019 14:02:06
Objet: Re: RFR: JDK-8216558: Lookup.unreflectSetter(Field) fails to throw
IllegalAc
On 12/01/2019 8:47 am, Mandy Chung wrote:
On 1/11/19 2:38 PM, David Holmes wrote:
There seem to be a number of spec issues around this. Shouldn't
findStaticSetter say something about what happens when the field is
final? Same for findSetter? This issue seems to be much bigger than
just
oader being weakly
reachable...");
--
Could you please review it and give me some advice?
Thanks.
Best regards,
Jie
On 2019/1/11 下午12:16, David Holmes wrote:
I see three choices for you here :)
1. Don't
There seem to be a number of spec issues around this. Shouldn't
findStaticSetter say something about what happens when the field is
final? Same for findSetter? This issue seems to be much bigger than just
a simple bug fix.
A CSR request will need to be filed.
David
-
On 12/01/2019 5:07
On 11/01/2019 10:46 pm, Adam Farley8 wrote:
Hi All,
I posit that you shouldn't be able to change the contents of a a final
field.
Nice in theory, but not true in practice.
However, if you use Field.setAccessible(true) before calling
Lookup.unreflectSetter(Field), then you can get a
Looks good Joe!
Thanks,
David
On 11/01/2019 4:13 pm, Joe Darcy wrote:
Hello,
Please review the changes to fix:
JDK-8213299:
runtime/appcds/jigsaw/classpathtests/EmptyClassInBootClassPath.java
failed with java.lang.NoSuchMethodException
rds,
Jie
On 2019/1/11 下午12:16, David Holmes wrote:
I see three choices for you here :)
1. Don't try to run all tests under Xcomp but just stick to the "core"
sets of tests already tested by others.
2. Fix the given test as outlined. (I tested it on linux-x64 and it
fixed the pr
failing with Xcomp
Date: Fri, 11 Jan 2019 11:16:22 +0800
From: Jie Fu
To: David Holmes , core-libs-dev@openjdk.java.net
Hi,
Please review this patch for JDK-8216528:
-
diff -r 02e648ae46c3
test/jdk/java/rmi/transport/runtimeT
On 11/01/2019 12:13 pm, David Holmes wrote:
Hi Jie,
On 11/01/2019 11:58 am, Jie Fu wrote:
Hi David,
Thanks and apologies.
No apology needed :)
This issue was discovered by a broad -Xcomp testing with jtreg on
Loongson CPUs (MIPS compatible processors).
It was intended to test our MIPS
Hi Jie,
On 11/01/2019 11:58 am, Jie Fu wrote:
Hi David,
Thanks and apologies.
No apology needed :)
This issue was discovered by a broad -Xcomp testing with jtreg on
Loongson CPUs (MIPS compatible processors).
It was intended to test our MIPS port of OpenJDK.
We've found and fixed quite a
Hi Jie,
On 11/01/2019 12:44 am, Jie Fu wrote:
Hi all,
My name is Jie Fu, a JVM developer at Loongson working on the MIPS port
of OpenJDK.
I hope this is the right place to discuss the issue.
test/jdk/java/rmi/transport/runtimeThreadInheritanceLeak/RuntimeThreadInheritanceLeak.java
failed
I've filed:
https://bugs.openjdk.java.net/browse/JDK-8216324
for the JVM TI bug.
David
-
On 8/01/2019 11:38 am, David Holmes wrote:
On 7/01/2019 11:35 pm, Michael Rasmussen wrote:
On 7/01/2019 8:46 pm, Michael Rasmussen wrote:
Hi,
We recently discovered something similar, although
On 7/01/2019 11:35 pm, Michael Rasmussen wrote:
On 7/01/2019 8:46 pm, Michael Rasmussen wrote:
Hi,
We recently discovered something similar, although with the native counterparts
of getDeclaredMethods: the JVM-TI function GetClassMethods and the JDI method
ReferenceType.methods().
The
On 7/01/2019 8:46 pm, Michael Rasmussen wrote:
Hi,
We recently discovered something similar, although with the native counterparts
of getDeclaredMethods: the JVM-TI function GetClassMethods and the JDI method
ReferenceType.methods().
The documentation for which states "Only directly declared
Hi Roger,
On 4/01/2019 12:22 am, Roger Riggs wrote:
Hi,
With a link to the explanation added to the issue, I think it can be
closed as not-an-issue.
Do you think the Class.getDeclared* method specs should be updated to
reflect (pardon the pun) that synthetic methods/constructors will be
anyone wants to participate and has some time, your thoughts would
be of the great value!
Thanks,
Sergei
On Tue, 11 Dec 2018 at 08:20, David Holmes <mailto:david.hol...@oracle.com>> wrote:
On 11/12/2018 4:27 pm, Sergei Ustimenko wrote:
> Hi David,
>
> Thanks
Of
Patrick Zhang
Sent: Thursday, December 6, 2018 4:28 PM
To: core-libs-dev@openjdk.java.net; David Holmes
Cc: Florian Weimer
Subject: RE: OpenJDK fails to build with GCC when the #include inside
zip.cpp comes from a non-sysroot path
To All,
Who could help sponsor this simple patch (may require a wide
On 19/12/2018 1:56 am, Dmitry Chuyko wrote:
On 12/18/18 3:39 AM, David Holmes wrote:
On 11/12/2018 9:30 pm, Dmitry Chuyko wrote:
On 12/11/18 4:03 AM, David Holmes wrote:
Hi Dmitry,
On 11/12/2018 12:16 am, Dmitry Chuyko wrote:
Hello,
Please review a small fix in java_md_solinux.c
Looks good.
Thanks for fixing this Daniel!
David
On 19/12/2018 12:57 am, Daniel Fuchs wrote:
Hi,
Please find below a fix for:
8213402: [Testbug]
java/lang/System/LoggerFinder/internal/PlatformLoggerBridgeTest creates
an invalid nest relationship
On 11/12/2018 9:30 pm, Dmitry Chuyko wrote:
On 12/11/18 4:03 AM, David Holmes wrote:
Hi Dmitry,
On 11/12/2018 12:16 am, Dmitry Chuyko wrote:
Hello,
Please review a small fix in java_md_solinux.c: continuation is not
truly compatible with pthread_create start_routine's signature but we
of the same thing - the JDK - and will always use
the same (platform default) calling convention.
David
dl
On 12/16/18 4:57 PM, David Holmes wrote:
Hi Magnus,
Thanks for explaining how addition of JNIEXPORT may have started this
problem.
One follow up:
This will also need a CSR request due
an error if
JNICALL is removed tomorrow. This may be acceptable but that is what the
CSR request establishes.
Thanks,
David
On 13/12/2018 8:37 pm, Magnus Ihse Bursie wrote:
On 2018-12-12 13:17, David Holmes wrote:
Okay I went away and did some homework ...
Let me back up a bit and see if
On 13/12/2018 3:27 am, mark.reinh...@oracle.com wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8215301
Webrev: https://cr.openjdk.java.net/~mr/rev/8215301/
The `make generate-summary` target produces a handy tabular summary
of all of the modules in a JDK build into
to add JNICALL where missing
instead, then we may not have been having this conversation.
This will also need a CSR request due to the change in linking behaviour.
Cheers,
David
-
On 12/12/2018 9:03 pm, Magnus Ihse Bursie wrote:
On 2018-12-11 23:47, David Holmes wrote:
On 12/12/2018 12:34 am
On 12/12/2018 5:44 pm, Volker Simonis wrote:
On Tue, Dec 11, 2018 at 11:47 PM David Holmes wrote:
On 12/12/2018 12:34 am, Magnus Ihse Bursie wrote:
On 2018-12-11 00:23, David Holmes wrote:
Hi Magnus,
On 10/12/2018 11:19 pm, Magnus Ihse Bursie wrote:
I propose that we introduce a new
On 12/12/2018 12:34 am, Magnus Ihse Bursie wrote:
On 2018-12-11 00:23, David Holmes wrote:
Hi Magnus,
On 10/12/2018 11:19 pm, Magnus Ihse Bursie wrote:
I propose that we introduce a new define, available to all JDK native
files (Hotspot included), called JDK_EXPORT. The behavior
On 12/12/2018 7:52 am, mark.reinh...@oracle.com wrote:
2018/12/11 7:03:57 -0800, adam.far...@uk.ibm.com:
I've spotted 12 instances of swear words in OpenJDK source comments, and
it seems appropriate to remove them.
Bug: https://bugs.openjdk.java.net/browse/JDK-8215217
(webrev:
No issue with fixing F-bomb (though one comes from upstream sources I
think) and the Pitch typo, but seriously "damn" is not a swear word.
I have to suspect you ran a corporate word checker over the sources.
David
-
damn
/dam/
verb
past participle: damned
1.
(in Christian belief)
: the type array can be empty, or creating it can throw an
exception, but otherwise the entries cannot be null.
Cheers,
David
Regards,
Sergei
On Tue, 11 Dec 2018 at 02:34, David Holmes <mailto:david.hol...@oracle.com>> wrote:
Hi Sergey,
I've had a look and I don't think t
with anything if needed.
Thanks and regards,
Sergei
On Sat, 8 Dec 2018 at 12:03, David Holmes <mailto:david.hol...@oracle.com>> wrote:
Hi Sergey,
Just FYI we're in the process of moving away from using anonymous
classes for lambda's to using an extended Lookup.defineClass
Hi Dmitry,
On 11/12/2018 12:16 am, Dmitry Chuyko wrote:
Hello,
Please review a small fix in java_md_solinux.c: continuation is not
truly compatible with pthread_create start_routine's signature but we
control what actually happens. So it makes sense to add intermediate
void* cast to silence
Hi Magnus,
On 10/12/2018 11:19 pm, Magnus Ihse Bursie wrote:
I propose that we introduce a new define, available to all JDK native
files (Hotspot included), called JDK_EXPORT. The behavior of this symbol
will be very similar (as of now, in fact identical) to JNIEXPORT;
however, the semantics
Hi Sergey,
Just FYI we're in the process of moving away from using anonymous
classes for lambda's to using an extended Lookup.defineClass API - see:
https://bugs.openjdk.java.net/browse/JDK-8171335
this is being done under Project Valhalla, with current work in the
nestmates branch.
We
Hi Joe,
core-libs changes look good.
Thanks,
David
On 7/12/2018 12:31 pm, Joseph D. Darcy wrote:
Hello,
With the start of JDK 13 around the corner, please review the core libs
portions of:
JDK-8205626: Start of release updates for JDK 13
Hi Sergey,
Hotspot test changes should be reviewed on hotspot-dev not core-libs-dev.
Thanks,
David
On 6/12/2018 6:47 am, Sergey wrote:
Hi,
As stated in the bug description [1] there are few
places in the tests where bash syntax is being used.
First one is (as per ticket):
-
On 5/12/2018 8:54 pm, Alan Bateman wrote:
On 05/12/2018 10:44, David Holmes wrote:
so IMHO for this issue the "specification" should simply be:
Update the allowed values of the jdk.lang.Process.launchMechanism
property on Linux to accept the value "posix_spawn&q
Hi Thomas,
Pardon the top-posting but ...
The launchMechanism property was introduced by the following issue:
https://bugs.openjdk.java.net/browse/JDK-5049299
at the time there was no CSR process and it went through our internal
CCC process. The "specification" was as follows:
---
Hi Claes,
Meta-comment: are these Names candidates for the forthcoming
compile-time evaluation of constants? Just wondering if these
optimizations (and even the archiving itself) will be moot in the future?
Thanks,
David
On 4/12/2018 2:02 am, Claes Redestad wrote:
Hi,
initializing
heers,
David
#ifdef _MSC_VER // Windows
#define gmtime_r(t, s) gmtime(t)
#endif
Regards
Patrick
-Original Message-
From: Florian Weimer
Sent: Thursday, November 29, 2018 8:02 PM
To: David Holmes
Cc: Patrick Zhang ; jdk-...@openjdk.java.net;
core-libs-dev@openjdk.java.net
Subject: Re: O
This is probably best discussed on net-dev rather than core-libs-dev.
Cheers,
David
On 1/12/2018 2:27 am, Volker Simonis wrote:
On Fri, Nov 30, 2018 at 12:20 PM Steve Groeger wrote:
Hi Goetz,
I disabled IPv6 on my xLinux box and the MulticastSocket tests pass, as
they detected that IPv6 is
11/29/2018 4:26 PM, David Holmes wrote:
Hi Roger,
On 30/11/2018 5:54 am, Roger Riggs wrote:
Hi Thomas,
We'll also need a retroactive CSR for JDK 12 to change its status in
JDK 12 to be documented.
With my CSR Group member hat on ... not sure what you mean by
"documented" here?
Hi Roger,
On 30/11/2018 5:54 am, Roger Riggs wrote:
Hi Thomas,
We'll also need a retroactive CSR for JDK 12 to change its status in JDK
12 to be documented.
With my CSR Group member hat on ... not sure what you mean by
"documented" here? The property already exists and should already have
> I think this good. Thanks.
>
> -Chris.
>
>> On 28 Nov 2018, at 20:32, David Holmes mailto:david.hol...@oracle.com>> wrote:
>>
>> Hi Hamlin,
>>
>> On 28/11/2018 10:52 pm, Hamlin Li wrote:
>>> Hi
Looks good! Thanks for jumping on this.
David
On 29/11/2018 12:18 pm, Stuart Marks wrote:
Hi all,
https://bugs.openjdk.java.net/browse/JDK-8214460
Please review this small fix to correct broken macOS build caused by the
fix for JDK-8214014. Patch appended below.
Thanks,
s'marks
# HG
sing major disruption to the
CI testing! :(
Thanks,
David
Thank you
-Hamlin
On 2018/11/28 8:08 PM, David Holmes wrote:
Hi Hamlin,
On 28/11/2018 9:15 pm, Hamlin Li wrote:
Hi David,
Thank a lot for double checking the usage of testlibrary.
I have updated the patch,
http://cr.openjdk.java.net/~m
/lib
as there are dozens of tests that refer to
@library /lib/testlibrary/
either directly or via a relative path. Do they all need to be changed
?? Or none?
David
PS. I'm finished for the night.
Thank you
-Hamlin
On 2018/11/28 6:24 PM, David Holmes wrote:
Hi Hamlin,
I see a lot more
Hi Hamlin,
I see a lot more tests that look like they may be affected:
./jdk/com/sun/tools/attach/TempDirTest.java: * @run build
jdk.testlibrary.* Application RunnerUtil
./jdk/com/sun/tools/attach/PermissionTest.java: * @run build
jdk.testlibrary.* Application
Hi Markus,
Thanks for the explanation of the problem.
Reviewed.
Thanks,
David
On 23/11/2018 1:01 am, Markus Gronlund wrote:
Greetings,
Please review the following small fix.
Bug: https://bugs.openjdk.java.net/browse/JDK-8214161
Webrev: http://cr.openjdk.java.net/~mgronlun/8214161/webrev01/
On 21/11/2018 6:14 pm, Thomas Stüfe wrote:
Ping.. no-one has any thoughts on this?
I can see it being useful for test harnesses/frameworks.
It's not something I've ever looked at so have no first hand knowledge.
I wonder how the semantics of Windows Jobs compare to *NIX process
groups? Do
Hi Nick,
I'll leave it for core-libs and build folk to review this, but just for
some background ... This is a bit of a recurring issue. We have the all
encompassing:
https://bugs.openjdk.java.net/browse/JDK-8165620
"Entire JDK should be built with -D_FILE_OFFSET_BITS=64"
then we had the
On 20/11/2018 6:39 am, Kim Barrett wrote:
On Nov 19, 2018, at 7:56 AM, David Holmes wrote:
On 19/11/2018 5:04 pm, Kim Barrett wrote:
On Nov 19, 2018, at 1:31 AM, David Holmes wrote:
Hi Kim,
On 16/11/2018 12:31 pm, Kim Barrett wrote:
This doesn't strike me as a JEP that actually integrates
On 19/11/2018 5:04 pm, Kim Barrett wrote:
On Nov 19, 2018, at 1:31 AM, David Holmes wrote:
Hi Kim,
On 16/11/2018 12:31 pm, Kim Barrett wrote:
On Oct 3, 2018, at 3:13 PM, Kim Barrett wrote:
I've submitted a JEP for
(1) enabling the use of C++14 Language Features when building the JDK,
(2
Hi Kim,
On 16/11/2018 12:31 pm, Kim Barrett wrote:
On Oct 3, 2018, at 3:13 PM, Kim Barrett wrote:
I've submitted a JEP for
(1) enabling the use of C++14 Language Features when building the JDK,
(2) define a process for deciding and documenting which new features
can be used or are forbidden
On Nov 8, 2018, at 4:03 AM, David Holmes <mailto:david.hol...@oracle.com>> wrote:
Is it that case that the code the uses the ASM library, like the JFR
code and jlink code, and the tests, doesn't actually _have to_ change
to specifying Opcodes.ASM7 unless they plan on using ASM7 feature
Okay. Worth a try.
Thanks Amy.
David
On 9/11/2018 1:18 PM, Amy Lu wrote:
java/nio/channels/SocketChannel/AsyncCloseChannel.java
Please review this trivial fix to make this test run in othervm to bring
Mach 5 back to green.
bug: https://bugs.openjdk.java.net/browse/JDK-8213576
This test
Hi Vicente,
On 9/11/2018 2:39 AM, Vicente Romero wrote:
Hi David, Igor
On 11/7/18 10:03 PM, David Holmes wrote:
Hi Vicente,
All of the javadoc comment reformatting makes it nearly impossible to
see the actual substantive changes :(
ASM 7 also supports the Nestmate attributes and I
Hi Vicente,
All of the javadoc comment reformatting makes it nearly impossible to
see the actual substantive changes :(
ASM 7 also supports the Nestmate attributes and I was trying to see
how/where that appeared but its somewhat obscure. Oh well.
Is it that case that the code the uses the
Hi Roger,
Thanks for expanding on the issue. Hopefully in the future this can be
handled in a more direct way.
Thanks,
David
On 7/11/2018 8:13 AM, Roger Riggs wrote:
Hi David,
On 11/06/2018 04:52 PM, David Holmes wrote:
Hi Roger,
On 7/11/2018 2:17 AM, Roger Riggs wrote:
While working
Hi Roger,
On 7/11/2018 2:17 AM, Roger Riggs wrote:
While working to reduce startup time initializing properties, a pair of
improvements are proposed.
8185496: Improve performance of system properties initialization in
initPhase1 [1]
8213424: VersionProps duplicate initialization [2]
1) The
Hi Dean,
On 1/11/2018 10:13 AM, dean.l...@oracle.com wrote:
On 10/31/18 4:06 PM, David Holmes wrote:
Hi Dean,
Looking only at the hotspot changes. The removal of the DoPrivileged
and related privileged_stack code seems okay. I have a few related
comments:
src/hotspot/share/classfile
Hi Dean,
Looking only at the hotspot changes. The removal of the DoPrivileged and
related privileged_stack code seems okay. I have a few related comments:
src/hotspot/share/classfile/systemDictionary.hpp
You added the java_security_AccessController class after
Hi Alexander,
Not really a core-libs question, but in any case the simple answer for
the Oracle JDK is No. We can not provide the PDB files to you.
David
On 18/10/2018 1:08 AM, Alexander Miloslavskiy wrote:
Hello,
I'm trying to debug a native crash that regularly happens for one of our
Hi Mandy,
I took a look through all of this and it seems okay - though it was a
little surprising how far the name change needed to spread.
Thanks,
David
On 17/10/2018 2:08 AM, Mandy Chung wrote:
Webrev:
http://cr.openjdk.java.net/~mchung/jdk12/webrevs/8207146/webrev.00/
Unsafe::getObject
Hi Prakhar,
It's a bit late for Joe so allow me ...
On 9/10/2018 2:59 PM, Prakhar Makhija wrote:
Thanks Joseph, I'll check Skara.
I found one reference of "hgForest.sh"
I presume it is for cloning / pulling the jdk src projects, perhaps the hg
trees you are mentioning
A leftover from when
701 - 800 of 2723 matches
Mail list logo
