On Thu, 20 Jun 2024 21:53:25 GMT, Justin Lu wrote:
> > It requires append(int), but the Appendable has no such method.
>
> If via `Appendable` we don't have access to `append(int)`, can we simply
> `append(String.valueOf(int))`. And similarly for `append(char[], int, int)`,
> can we `append(St
On Thu, 20 Jun 2024 20:30:36 GMT, Steven Loomis wrote:
> CLDR is aware of this change but hasn't added it yet. We're mid cycle so it
> won't be much more than metadata this round due to timing.
> https://unicode-org.atlassian.net/issues/CLDR-17751 if you want to track.
Out of curiosity, what's
Hi all,
This pull request contains a backport of commit
[de8ee977](https://github.com/openjdk/jdk/commit/de8ee97718d7e12b541b310cf5b67f3e10e91ad9)
from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.
The commit being backported was authored by SendaoYan on 20 Jun 2024 and was
review
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Tue, 18 Jun 2024 07:41:35 GMT, SendaoYan wrote:
>> Hi all,
>> Testcase
>> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java`
>> run fails with root user privileged. I think it's necessary to skip this
>> testcase when user is root.
>> Why run the jtreg test by root
On Tue, 18 Jun 2024 17:57:29 GMT, Magnus Ihse Bursie wrote:
>> Magnus Ihse Bursie has updated the pull request with a new target base due
>> to a merge or a rebase. The incremental webrev excludes the unrelated
>> changes brought in by the merge/rebase. The pull request contains seven
>> addit
On Wed, 19 Jun 2024 02:05:28 GMT, lingjun-cg wrote:
> It requires append(int), but the Appendable has no such method.
If via `Appendable` we don't have access to `append(int)`, can we simply
`append(String.valueOf(int))`.
And similarly for `append(char[], int, int)`, can we
`append(String.valu
On Thu, 20 Jun 2024 19:47:56 GMT, Naoto Sato wrote:
>> I see your point. CLDR takes precedence over ISO4217 regarding currencies
>> here?
>
> That is more consistent IMO
CLDR is aware of this change but hasn't added it yet. We're mid cycle so it
won't be much more than metadata this round due
Please review this patch, which is a backport of the fix in #19615 to JDK 23.
This is not a clean patch, because the old patch was done on JDK-8333479
(#19585) which was absent in JDK 23; however, the conflicts were small, and the
only real changes were that `methodTypeDesc` and `classDesc` from
On Thu, 20 Jun 2024 19:51:51 GMT, Naoto Sato wrote:
> The point I wanted to make is that the text file only contains the "list one"
> part of the ISO 4217.
Renamed the file name to "ISO4217-list-one.txt"
-
PR Comment: https://git.openjdk.org/jdk/pull/19813#issuecomment-2181478826
> Please review this PR which incorporates the ISO 4217 Amendment 177 Update.
>
> Specifically, the introduction of the new currency, Zimbabwe Gold.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
reflect review: change txt name
--
844: JMX attaching of Subject does not work when security manager not
allowed
-
Commit messages:
- Backport bcf4bb4882e06d8c52f6eb4e9c4e027ba0622c5f
Changes: https://git.openjdk.org/jdk/pull/19810/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19810&range=00
Issue:
On Thu, 20 Jun 2024 19:01:29 GMT, Justin Lu wrote:
> > It's not about this update, but it may be better to rename the
> > `tablea1.txt` data file to `list-one.txt` or something along the line. The
> > name `tablea1` is obsolete, and it is now called "List one: Currency, fund
> > and precious m
On Thu, 20 Jun 2024 19:01:26 GMT, Justin Lu wrote:
>> src/java.base/share/classes/sun/util/resources/CurrencyNames.properties line
>> 516:
>>
>>> 514: zmk=Zambian Kwacha
>>> 515: zwd=Zimbabwean Dollar (1980-2008)
>>> 516: zwg=Zimbabwe Gold
>>
>> It's interesting to see the difference `Zimbabwe
> This PR adds a new JDK tool, called `jnativescan`, that can be used to find
> code that accesses native functionality. Currently this includes `native`
> method declarations, and methods marked with `@Restricted`.
>
> The tool accepts a list of class path and module path entries through
> `--
On Tue, 18 Jun 2024 10:00:33 GMT, lingjun-cg wrote:
>> ### Performance regression of DecimalFormat.format
>> From the output of perf, we can see the hottest regions contain atomic
>> instructions. But when run with JDK 11, there is no such problem. The
>> reason is the removed biased locking.
On Thu, 20 Jun 2024 12:11:25 GMT, Jorn Vernee wrote:
>> This PR adds a new JDK tool, called `jnativescan`, that can be used to find
>> code that accesses native functionality. Currently this includes `native`
>> method declarations, and methods marked with `@Restricted`.
>>
>> The tool accepts
> This PR adds a new JDK tool, called `jnativescan`, that can be used to find
> code that accesses native functionality. Currently this includes `native`
> method declarations, and methods marked with `@Restricted`.
>
> The tool accepts a list of class path and module path entries through
> `--
On Thu, 6 Jun 2024 12:46:36 GMT, jengebr wrote:
>> Improve `java/util/concurrent/CopyOnWriteArrayList` by eliminating needless
>> cloning of Object[0] instances. This cloning is intended to prevent callers
>> from changing array contents, but many `CopyOnWriteArrayList`s are allocated
>> to si
> Improve `java/util/concurrent/CopyOnWriteArrayList` by eliminating needless
> cloning of Object[0] instances. This cloning is intended to prevent callers
> from changing array contents, but many `CopyOnWriteArrayList`s are allocated
> to size zero, or are otherwise maintained empty, so cloning
On Thu, 20 Jun 2024 18:21:41 GMT, Naoto Sato wrote:
>> Justin Lu has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> reflect review comments
>
> src/java.base/share/classes/sun/util/resources/CurrencyNames.properties line
> 516:
>
>> 514:
> Please review this PR which incorporates the ISO 4217 Amendment 177 Update.
>
> Specifically, the introduction of the new currency, Zimbabwe Gold.
Justin Lu has updated the pull request incrementally with one additional commit
since the last revision:
reflect review comments
-
On Thu, 20 Jun 2024 18:36:22 GMT, Naoto Sato wrote:
> It's not about this update, but it may be better to rename the `tablea1.txt`
> data file to `list-one.txt` or something along the line. The name `tablea1`
> is obsolete, and it is now called "List one: Currency, fund and precious
> metal co
On Tue, 18 Jun 2024 10:00:33 GMT, lingjun-cg wrote:
>> ### Performance regression of DecimalFormat.format
>> From the output of perf, we can see the hottest regions contain atomic
>> instructions. But when run with JDK 11, there is no such problem. The
>> reason is the removed biased locking.
On Thu, 20 Jun 2024 16:13:04 GMT, Alan Bateman wrote:
> Another thing is that using joptsimple gives up a bit of control, e.g. the
> help output shows the parameter for --class-path as `` where the java
> launcher and other tools will show "path" or "class path". Same thing with
> `--release`
Updated all the tests that depend on external infrastructure services as
manual. These tests may fail with external reasons, for instance - change in CA
test portal, certificate status updates, or network issues.
-
Commit messages:
- Update comments
- comment explaining why these
On Thu, 20 Jun 2024 18:01:39 GMT, Justin Lu wrote:
> Please review this PR which incorporates the ISO 4217 Amendment 177 Update.
>
> Specifically, the introduction of the new currency, Zimbabwe Gold.
It's not about this update, but it may be better to rename the `tablea1.txt`
data file to `lis
On Thu, 20 Jun 2024 18:01:39 GMT, Justin Lu wrote:
> Please review this PR which incorporates the ISO 4217 Amendment 177 Update.
>
> Specifically, the introduction of the new currency, Zimbabwe Gold.
src/java.base/share/classes/sun/util/resources/CurrencyNames.properties line
516:
> 514: zmk=
On Sat, 15 Jun 2024 09:56:53 GMT, SendaoYan wrote:
> Hi all,
> Testcase
> `test/jdk/java/util/ResourceBundle/Control/MissingResourceCauseTestRun.java`
> run fails with root user privileged. I think it's necessary to skip this
> testcase when user is root.
> Why run the jtreg test by root user?
Please review this PR which incorporates the ISO 4217 Amendment 177 Update.
Specifically, the introduction of the new currency, Zimbabwe Gold.
-
Commit messages:
- init
Changes: https://git.openjdk.org/jdk/pull/19813/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=19813&ra
On Fri, 5 Apr 2024 00:00:58 GMT, Evemose wrote:
> **Subject**
> Addition of Predicate-based `indexOf` and `lastIndexOf` methods to
> `java.util.List`
>
> **Motivation**
> The motivation behind this proposal is to enhance the functionality of the
> `List` interface by providing a more flexible
On Thu, 20 Jun 2024 17:40:25 GMT, Alan Bateman wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update man page header to be consisten with the others
>
> src/jdk.jdeps/share/classes/com/sun/tools/jnativescan/JNative
On Thu, 20 Jun 2024 12:11:25 GMT, Jorn Vernee wrote:
>> This PR adds a new JDK tool, called `jnativescan`, that can be used to find
>> code that accesses native functionality. Currently this includes `native`
>> method declarations, and methods marked with `@Restricted`.
>>
>> The tool accepts
On Thu, 20 Jun 2024 12:06:43 GMT, Severin Gehwolf wrote:
>> Please review this enhancement to the container detection code which allows
>> it to figure out whether the JVM is actually running inside a container
>> (`podman`, `docker`, `crio`), or with some other means that enforces
>> memory/c
On Wed, 19 Jun 2024 21:13:33 GMT, Maurizio Cimadamore
wrote:
>> What do you suggest? Just a note in the error message that exploded
>> modules/class paths are not supported?
>
> Something like that yes
An altermative is to use ResolvedModule::reference to get a ModuleReference,
then use its o
On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote:
> The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for
> string comparison, which should be avoided.
This pull request has now been integrated.
Changeset: 265a0f55
Author:Naoto Sato
URL:
https://git.openjdk.org
On Tue, 18 Jun 2024 18:23:12 GMT, Naoto Sato wrote:
> The test library `jdk.test.lib.Platform` uses no-arg `toLowerCase()` for
> string comparison, which should be avoided.
Thank you for the reviews!
-
PR Comment: https://git.openjdk.org/jdk/pull/19775#issuecomment-2181150302
On Tue, 18 Jun 2024 16:35:10 GMT, Jorn Vernee wrote:
>> Jorn Vernee has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update man page header to be consisten with the others
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/platform/JD
On Mon, 10 Jun 2024 12:29:32 GMT, Pavel Rappo wrote:
> Please review this fix for an intermittent test failure.
>
> On some configurations, the default `expect` timeout of 10 seconds is
> insufficient. It is increased to 20; it's hard to imagine a configuration for
> which that new value would
On Thu, 20 Jun 2024 09:56:45 GMT, Pavel Rappo wrote:
>> Please review this fix for an intermittent test failure.
>>
>> On some configurations, the default `expect` timeout of 10 seconds is
>> insufficient. It is increased to 20; it's hard to imagine a configuration
>> for which that new value
On Thu, 20 Jun 2024 12:11:25 GMT, Jorn Vernee wrote:
>> This PR adds a new JDK tool, called `jnativescan`, that can be used to find
>> code that accesses native functionality. Currently this includes `native`
>> method declarations, and methods marked with `@Restricted`.
>>
>> The tool accepts
On Thu, 20 Jun 2024 12:11:25 GMT, Jorn Vernee wrote:
>> This PR adds a new JDK tool, called `jnativescan`, that can be used to find
>> code that accesses native functionality. Currently this includes `native`
>> method declarations, and methods marked with `@Restricted`.
>>
>> The tool accepts
On Thu, 20 Jun 2024 11:38:26 GMT, Jorn Vernee wrote:
>> src/jdk.jdeps/share/man/jnativescan.1 line 121:
>>
>>> 119: .TP
>>> 120: \f[V]--release\f[R] \f[I]version\f[R]
>>> 121: Used to specify the Java SE release that specifies the set of
>>> restricted
>>
>> In principle, the release could als
On Tue, 4 Jun 2024 07:13:15 GMT, Vanitha B P wrote:
> Created jtreg test case for
> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>
> The JpackageTest created tests that the child process started from the app
> launched by jpackage launcher is not automatically terminated w
On Thu, 20 Jun 2024 10:54:49 GMT, Emanuel Peter wrote:
>> I'm not opposed to accepting this patch as-is, but I think we should do so
>> with an eye towards reverting if we figure out a way to improve the
>> `putChar` intrinsic so that it doesn't block merge store optimization. What
>> do you t
On Thu, 20 Jun 2024 12:51:22 GMT, Evemose wrote:
> wouldn't it be better to create one uniform tool
See my reply here:
https://github.com/openjdk/jdk/pull/19774#issuecomment-2179078565
-
PR Comment: https://git.openjdk.org/jdk/pull/19774#issuecomment-2180653743
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
On Thu, 20 Jun 2024 12:11:25 GMT, Jorn Vernee wrote:
>> This PR adds a new JDK tool, called `jnativescan`, that can be used to find
>> code that accesses native functionality. Currently this includes `native`
>> method declarations, and methods marked with `@Restricted`.
>>
>> The tool accepts
> This PR adds a new JDK tool, called `jnativescan`, that can be used to find
> code that accesses native functionality. Currently this includes `native`
> method declarations, and methods marked with `@Restricted`.
>
> The tool accepts a list of class path and module path entries through
> `--
On Tue, 16 Apr 2024 18:25:52 GMT, Thomas Stuefe wrote:
>> Severin Gehwolf has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains ten additional
>> comm
> Please review this enhancement to the container detection code which allows
> it to figure out whether the JVM is actually running inside a container
> (`podman`, `docker`, `crio`), or with some other means that enforces
> memory/cpu limits by means of the cgroup filesystem. If neither of thos
> This PR adds a new JDK tool, called `jnativescan`, that can be used to find
> code that accesses native functionality. Currently this includes `native`
> method declarations, and methods marked with `@Restricted`.
>
> The tool accepts a list of class path and module path entries through
> `--
On Wed, 19 Jun 2024 21:35:07 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - review comments
>> - add man page
>
> src/jdk.jdeps/share/man/jnativescan.1 line 166:
>
>> 164: .fi
>> 165:
> Please review this enhancement to the container detection code which allows
> it to figure out whether the JVM is actually running inside a container
> (`podman`, `docker`, `crio`), or with some other means that enforces
> memory/cpu limits by means of the cgroup filesystem. If neither of thos
On Thu, 20 Jun 2024 08:34:45 GMT, Severin Gehwolf wrote:
>> Please review this PR which adds test support for systemd slices so that
>> bugs like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
>> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
>> c
On Thu, 20 Jun 2024 11:42:04 GMT, Jorn Vernee wrote:
>> src/jdk.jdeps/share/man/jnativescan.1 line 127:
>>
>>> 125: This option should be set to the version of the runtime under which the
>>> 126: application is eventually intended to be run.
>>> 127: If this flag is omitted, the version of \f[V
On Wed, 19 Jun 2024 21:30:49 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - review comments
>> - add man page
>
> src/jdk.jdeps/share/man/jnativescan.1 line 121:
>
>> 119: .TP
>> 120:
On Thu, 20 Jun 2024 10:09:46 GMT, Claes Redestad wrote:
>> @wenshao I'm glad we figured it out a bit, and I hope you learned a thing or
>> two :)
>>
>>> It would be even better if Unsafe.putChar could be used for MergeStore in
>>> the future.
>>
>> The `_putCharStringU` intrinsic uses
>> `Li
On Thu, 13 Jun 2024 07:36:34 GMT, Emanuel Peter wrote:
>> Thanks to @eme64 's patience and help, I found a way to use MergeStore
>> without doing boundary checking.
>>
>> It would be even better if Unsafe.putChar could be used for MergeStore in
>> the future.
>>
>> ## 1. JavaCode
>>
>> class
On Mon, 17 Jun 2024 05:53:45 GMT, Shaojin Wen wrote:
>> After PR https://github.com/openjdk/jdk/pull/16245, C2 optimizes stores into
>> primitive arrays by combining values into larger stores.
>>
>> This PR rewrites the code of appendNull and append(boolean) methods so that
>> these two meth
> Please review this fix for an intermittent test failure.
>
> On some configurations, the default `expect` timeout of 10 seconds is
> insufficient. It is increased to 20; it's hard to imagine a configuration for
> which that new value would still be insufficient, but we'll see.
>
> Aside from
On Wed, 19 Jun 2024 15:15:43 GMT, Magnus Ihse Bursie wrote:
>> This patch contains a set of changes to improve static builds. They will
>> pave the way for implementing a full static-only java launcher. The changes
>> here will:
>>
>> 1) Make sure non-exported symbols are made local in the sta
> Please review this PR which adds test support for systemd slices so that bugs
> like [JDK-8217338](https://bugs.openjdk.org/browse/JDK-8217338) can be
> verified. The added test, `SystemdMemoryAwarenessTest` currently passes on
> cgroups v1 and fails on cgroups v2 due to the way how
> [JDK-82
65 matches
Mail list logo
