On Tue, 23 Apr 2024 12:59:18 GMT, Adam Sotona wrote:
> ClassFile API `StackMapGenerator` attaches print or hex dump of the method to
> an error message.
> However there is no such attachment when the stack maps generation is turned
> off.
>
> This patch moves class print/
by `StackMapGenerator` and `StackCounter` to provide the same level of
> details in case of an error.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
applied suggested changes
On Wed, 24 Apr 2024 22:48:30 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> applied suggested changes
>
> src/java.base/share/classes/jdk/internal/classfile/impl
On Wed, 24 Apr 2024 22:43:21 GMT, Paul Sandoz wrote:
> This looks good, but for completeness it will need a CSR.
CSR created, thanks.
-
PR Comment: https://git.openjdk.org/jdk/pull/18913#issuecomment-2076498451
On Wed, 24 Apr 2024 21:52:11 GMT, Paul Sandoz wrote:
> Rather than duplicating some checks I wonder if it is possible to add a
> private method `entryByIndex(int index, int expectedTag)` that the existing
> `entryByIndex` defers to. If the `expectedTag` is non-negative then it checks
> `tag`
ClassFile API `StackMapGenerator` attaches print or hex dump of the method to
an error message.
However there is no such attachment when the stack maps generation is turned
off.
This patch moves class print/dump to `impl.Util::dumpMethod`, so it is shared
by `StackMapGenerator` and
This patch adds missing `@throws` javadoc annotations to
`java.lang.classfile.BufWriter`.
Please review.
Thank you,
Adam
-
Commit messages:
- 8322847: java.lang.classfile.BufWriter should specify @throws for its
writeXXX methods
Changes:
ClassFile API dives into the nested constant pool entries without type
restrictions, while parsing a class file. Validation of the entry is performed
post-parsing. Specifically corrupted constant pool entry may cause infinite
loop during parsing and throws SOE.
This patch resolves the issue by
come.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 13 commits:
- Merge branch 'master' into JDK-8294960-invoke
# Conflicts:
#
src/j
On Wed, 17 Apr 2024 20:46:26 GMT, Joe Darcy wrote:
> 8330458: Add missing @since tag to ClassFile.JAVA_23_VERSION
Marked as reviewed by asotona (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18828#pullrequestreview-2007907265
On Wed, 17 Apr 2024 08:46:59 GMT, Adam Sotona wrote:
> Current implementation of `LambdaMetafactory` does not allow to use lambdas
> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>
> This patch includes lambda implementation in a hidden class under
ch also fixes `j/l/i/defineHiddenClass/BasicTest::testLambda` to
> correctly cover this test case.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/java
On Wed, 17 Apr 2024 15:39:11 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> applied suggested changes
>
> test/jdk/java/lang/invoke/defineHiddenClass/src/Lambda.
ch also fixes `j/l/i/defineHiddenClass/BasicTest::testLambda` to
> correctly cover this test case.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with two additional
commits since the last revision:
- typo in comm
On Wed, 17 Apr 2024 15:21:32 GMT, Adam Sotona wrote:
>> java.base java.lang.invoke package heavily uses ASM to generate lambdas and
>> method handles.
>>
>> This patch converts ASM calls to Classfile API.
>>
>> This PR is continuation of https://github.c
come.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 12 additional commits since the
last
On Tue, 16 Apr 2024 22:49:28 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 10 addi
ch also fixes `j/l/i/defineHiddenClass/BasicTest::testLambda` to
> correctly cover this test case.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
applied suggested changes
--
On Wed, 17 Apr 2024 09:14:31 GMT, Chen Liang wrote:
>> Current implementation of `LambdaMetafactory` does not allow to use lambdas
>> in hidden classes. Invocation throws `NoClassDefFoundError` instead.
>>
>> This patch includes lambda implementation in a hidden class under the
>> special
On Wed, 17 Apr 2024 05:43:12 GMT, Joe Darcy wrote:
>> Get JDK 24 underway.
>
> Joe Darcy has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Correct release date as observed in review feedback.
> - Improve javadoc of class file update.
Current implementation of `LambdaMetafactory` does not allow to use lambdas in
hidden classes. Invocation throws `NoClassDefFoundError` instead.
This patch includes lambda implementation in a hidden class under the special
handling of `useImplMethodHandle`.
The patch also fixes
On Tue, 2 Apr 2024 09:37:52 GMT, Adam Sotona wrote:
> `IllegalArgumentException` thrown by some static factory methods of the
> following `java.lang.classfile.instruction` interfaces are not documented:
>
> - `ArrayLoadInstruction`
> - `ArrayStoreInstruction`
> -
ind and some methods
> have low practical use.
>
> This patch revisits the `CodeBuilder` API methods and introduces some changes.
>
> For more details, please, visit the [CSR
> ](https://bugs.openjdk.org/browse/JDK-8323067)
>
> Please review.
>
> Thank you,
> A
On Tue, 9 Apr 2024 13:39:47 GMT, Adam Sotona wrote:
> Class-File API `ClassPrinter` prints many useful info about bootstrap methods
> and invoke dynamic instructions, however bootstrap methods arguments are
> missing.
> This patch fixes bootstrap methods and invoke dynamic
On Tue, 9 Apr 2024 14:21:59 GMT, Brian Goetz wrote:
>> Class-File API `ClassPrinter` prints many useful info about bootstrap
>> methods and invoke dynamic instructions, however bootstrap methods arguments
>> are missing.
>> This patch fixes bootstrap methods and invoke dynamic instructions
On Wed, 3 Apr 2024 08:48:43 GMT, Adam Sotona wrote:
> Some of the Class-File API options were not mentioned in the package summary
> and one exception mentioned `ClassFile.DeadLabelsOption` javadoc was wrong.
> This patch fixes the javadoc.
>
> Please review.
>
> Thank y
On Tue, 9 Apr 2024 14:22:37 GMT, Brian Goetz wrote:
>> Some of the Class-File API options were not mentioned in the package summary
>> and one exception mentioned `ClassFile.DeadLabelsOption` javadoc was wrong.
>> This patch fixes the javadoc.
>>
>> Please review.
>>
>> Thank you,
>> Adam
>
>
` to `NONE`
>
> Chen Liang has updated the pull request with a new target base due to a merge
> or a rebase. The pull request now contains 13 commits:
>
> - Merge branch 'master' of https://github.com/openjdk/jdk into
> fix/typearg-model
> - Missed renaming in tests, thanks to
On Wed, 20 Mar 2024 02:10:35 GMT, Nizar Benalla wrote:
>> # Issue
>> - [JDK-8326836](https://bugs.openjdk.org/browse/JDK-8326836): changes were
>> made to the method signatures but this modification isn't reflected in the @
>> since tags. The @ since tags need to be updated.
>>
>> I changed
Class-File API `ClassPrinter` prints many useful info about bootstrap methods
and invoke dynamic instructions, however bootstrap methods arguments are
missing.
This patch fixes bootstrap methods and invoke dynamic instructions printing.
`ClassPrinterTest` is extended to print bootstrap method
On Thu, 8 Feb 2024 13:18:41 GMT, Adam Sotona wrote:
> ClassFile API provides two sets of instructions implementations (bound and
> unbound).
> Unbound implementation of `IncrementInstruction::constant` returns invalid
> value.
> This bug discovered a hole in the ClassFile AP
On Wed, 3 Apr 2024 08:15:52 GMT, Adam Sotona wrote:
> `Opcode.IFNONNULL.primaryTypeKind()` wrongly returned `IntType` instead of
> the right `ReferenceType`.
> Primary type kinds of `BRANCH` opcodes have yet no functional effect in the
> Class-File API.
> This simple patch
>
> `NewPrimitiveArrayInstruction::of` factory method also does not perform the
> check for invalid argument.
>
> This patch adds all the missing `@throws` Javadoc tags and fixes
> `NewPrimitiveArrayInstruction::of` factory method to perform the argument
> check.
>
>
On Tue, 27 Feb 2024 08:45:12 GMT, Adam Sotona wrote:
> Task providing Class-File API transition to Second Preview.
This pull request has now been integrated.
Changeset: 19a99d02
Author: Adam Sotona
URL:
https://git.openjdk.org/jdk/commit/19a99d023e32fa9f4d26b76bd36993719e1df
come.
>
> Please review.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 10 additional commits since the
last
>
> `NewPrimitiveArrayInstruction::of` factory method also does not perform the
> check for invalid argument.
>
> This patch adds all the missing `@throws` Javadoc tags and fixes
> `NewPrimitiveArrayInstruction::of` factory method to perform the argument
> check.
>
>
On Wed, 3 Apr 2024 11:42:04 GMT, ExE Boss wrote:
> The following factory methods are also missing `@throws
> IllegalArgumentException`:
>
> * `ConstantInstruction::ofIntrinsic`
> * `ConstantInstruction::ofArgument`
> * `ConstantInstruction::ofLoad`
Great catch, I'll add them, thank you!
>
> `NewPrimitiveArrayInstruction::of` factory method also does not perform the
> check for invalid argument.
>
> This patch adds all the missing `@throws` Javadoc tags and fixes
> `NewPrimitiveArrayInstruction::of` factory method to perform the argument
> check.
>
>
Some of the Class-File API options were not mentioned in the package summary
and one exception mentioned `ClassFile.DeadLabelsOption` javadoc was wrong.
This patch fixes the javadoc.
Please review.
Thank you,
Adam
-
Commit messages:
- 8325371: Missing ClassFile.Option in package
`Opcode.IFNONNULL.primaryTypeKind()` wrongly returned `IntType` instead of the
right `ReferenceType`.
Primary type kinds of `BRANCH` opcodes have yet no functional effect in the
Class-File API.
This simple patch fixes the typo.
Please review.
Thank you,
Adam
-
Commit messages:
-
`IllegalArgumentException` thrown by some static factory methods of the
following `java.lang.classfile.instruction` interfaces are not documented:
- `ArrayLoadInstruction`
- `ArrayStoreInstruction`
- `BranchInstruction`
- `ConvertInstruction`
- `DiscontinuedInstruction`
- `FieldInstruction`
-
On Fri, 22 Mar 2024 02:17:58 GMT, David Holmes wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 26 commits:
>>
>> - Merge remote-tracking branch 'openjdk/master' into
>>
.
>
> Also new `VerifierSelfTest::testParserVerifier` has been added.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
added references to jvms
-
Changes:
- all: ht
On Thu, 21 Mar 2024 14:40:37 GMT, Adam Sotona wrote:
>> ClassFile API `jdk.internal.classfile.verifier.VerifierImpl` performed only
>> bytecode-level class verification.
>> This patch adds `jdk.internal.classfile.verifier.ParserVerifier` with
>> additional class checks
.
>
> Also new `VerifierSelfTest::testParserVerifier` has been added.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 26 commits:
- Merge remote-tracking branch 'openjd
ClassFile API `jdk.internal.classfile.verifier.VerifierImpl` performed only
bytecode-level class verification.
This patch adds `jdk.internal.classfile.verifier.ParserVerifier` with
additional class checks inspired by
`hotspot/share/classfile/classFileParser.cpp`.
Also new
On Wed, 6 Mar 2024 15:31:40 GMT, Chen Liang wrote:
> Looking at 8326836 #18030, we might need `@since` tags on the new API methods.
Thanks for pointing it out, I've added them.
-
PR Comment: https://git.openjdk.org/jdk/pull/17282#issuecomment-1981230434
ind and some methods
> have low practical use.
>
> This patch revisits the `CodeBuilder` API methods and introduces some changes.
>
> For more details, please, visit the [CSR
> ](https://bugs.openjdk.org/browse/JDK-8323067)
>
> Please review.
>
> Thank you,
> A
ind and some methods
> have low practical use.
>
> This patch revisits the `CodeBuilder` API methods and introduces some changes.
>
> For more details, please, visit the [CSR
> ](https://bugs.openjdk.org/browse/JDK-8323067)
>
> Please review.
>
> Thank you,
> A
ind and some methods
> have low practical use.
>
> This patch revisits the `CodeBuilder` API methods and introduces some changes.
>
> For more details, please, visit the [CSR
> ](https://bugs.openjdk.org/browse/JDK-8323067)
>
> Please review.
>
> Thank you,
> A
On Fri, 15 Dec 2023 12:54:27 GMT, Adam Sotona wrote:
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any com
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any comments and suggestions are welcome.
>
> Please review.
&
On Mon, 8 Jan 2024 13:38:16 GMT, Adam Sotona wrote:
> ClassFile API performance related improvements have been separated from
> #17121 into this PR.
>
> These improvements are important to minimize performance regression of
> 8294961: Convert java.base/java.lang.reflect.ProxyG
On Mon, 4 Mar 2024 10:08:27 GMT, Claes Redestad wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update
>> src/java.base/share/classes/jdk/internal/classfile/impl/StackMapDecod
oxy classes #17121
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains 24 additional
On Mon, 15 Jan 2024 12:01:37 GMT, Adam Sotona wrote:
>> ClassFile API performance related improvements have been separated from
>> #17121 into this PR.
>>
>> These improvements are important to minimize performance regression of
>> 8294961: Convert java.base/ja
Task providing Class-File API transition to Second Preview.
-
Commit messages:
- 8326744: Class-File API transition to Second Preview
Changes: https://git.openjdk.org/jdk/pull/18021/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18021=00
Issue:
On Thu, 22 Feb 2024 05:38:19 GMT, Chen Liang wrote:
>> API changes as discussed on the mailing list:
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-November/000419.html
>>
>> Additional questions:
>> 1. Whether to rename `WildcardIndicator.DEFAULT` to `NONE`
>
> Chen Liang has
ngTransformation`. Second pass has been
> added to discover bugs in unbound-to-unbound instruction conversions.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Update tes
ClassFile API provides two sets of instructions implementations (bound and
unbound).
Unbound implementation of `IncrementInstruction::constant` returns invalid
value.
This bug discovered a hole in the ClassFile API test coverage.
This patch provides very simple fix of `IncrementInstruction`
On Mon, 5 Feb 2024 17:23:54 GMT, Paul Sandoz wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed CodeBuilder::newObject methods
>
> src/java.base/share/classes/java/lang/class
ind and some methods
> have low practical use.
>
> This patch revisits the `CodeBuilder` API methods and introduces some changes.
>
> For more details, please, visit the [CSR
> ](https://bugs.openjdk.org/browse/JDK-8323067)
>
> Please review.
>
> Thank you,
> A
`java.lang.classfile.CodeBuilder` contains more than 230 API methods.
Existing ClassFile API use cases proved the concept one big CodeBuilder is
comfortable. However there are some redundancies, glitches in the naming
conventions, some frequently used methods are hard to find and some methods
On Sun, 17 Dec 2023 23:11:10 GMT, Chen Liang wrote:
>> Summaries:
>> 1. A few recommendations about updating the constant API is made at
>> https://mail.openjdk.org/pipermail/classfile-api-dev/2023-March/000233.html
>> and I may update this patch shall the API changes be integrated before
>>
oxy classes #17121
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/java.base/share/classes/jdk/internal/classfile/impl/StackMapDecoder.java
Co-authored-by: Andrey
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any comments and suggestions are welcome.
>
> Please review.
&
On Tue, 9 Jan 2024 13:30:58 GMT, Adam Sotona wrote:
>> ClassFile API performance related improvements have been separated from
>> #17121 into this PR.
>>
>> These improvements are important to minimize performance regression of
>> 8294961: Convert java.base/ja
oxy classes #17121
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with three additional
commits since the last revision:
- updated copyright year
- reverted custom method slots counting in StackCounter
- improved and extended Generat
oxy classes #17121
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Update
src/java.base/share/classes/jdk/internal/classfile/impl/StackCounter.java
Co-authored-by: liach <78
On Mon, 8 Jan 2024 14:43:58 GMT, Chen Liang wrote:
> You need to update the slot counting from `DirectCodeBuilder` and
> `StackMapDecoder` to fully avoid creating any MethodTypeDesc.
It would be good to avoid all bottlenecks, however not all of them have equal
effect.
This patch avoids MTD
On Mon, 8 Jan 2024 14:19:12 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> applied suggested changes
>
> src/java.base/share/classes/jdk/internal/classfile/
oxy classes #17121
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
applied suggested changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17306/files
- new:
oxy classes #17121
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
improved StackMapDescoder::initFrameLocals performance
-
Changes:
- all: https://git.openjdk.org/jd
On Mon, 8 Jan 2024 14:20:17 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> applied suggested changes
>
> src/java.base/share/classes/jdk/internal/classfile/
oxy classes #17121
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
applied suggested changes
-
Changes:
- all: https://git.openjdk.org/jdk/pull/17306/files
- new:
On Sun, 7 Jan 2024 18:24:02 GMT, Chen Liang wrote:
> Also `StackMapDecoder::initFrameFromLocals(ClassEntry, ...)` can benefit from
> 2 changes:
>
> 1. Iterate MTD by index instead of creating copies
I'll add this fix to the performance improvements PR, thanks!
> 2. Pass ClassEntry from
On Fri, 5 Jan 2024 23:55:53 GMT, Mandy Chung wrote:
> > Profiling of the benchmarks revealed several slowdowns:
> > ```
> > * many expensive conversions from `Class` to `ClassDesc` to
> > `ClassEntry`, or even more expensive `MethodTypeDesc`
> >
> > * building proxy class from scratch from
On Fri, 5 Jan 2024 21:03:28 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackCounter fix
>
> src/java.base/share/classes/java/lang/reflect/ProxyGene
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any comments and suggestions are welcome.
>
> Please review.
&
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any comments and suggestions are welcome.
>
> Please review.
&
On Fri, 5 Jan 2024 21:23:02 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackCounter fix
>
> src/java.base/share/classes/java/lang/reflect/ProxyGene
On Fri, 5 Jan 2024 20:50:16 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackCounter fix
>
> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java li
On Fri, 5 Jan 2024 20:45:22 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackCounter fix
>
> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java li
On Sun, 7 Jan 2024 18:16:05 GMT, Chen Liang wrote:
>> Original code has been significant in profiler.
>>
>>
>> MethodTypeDesc desc = MethodTypeDesc.of(toClassDesc(returnType),
>>
>> Arrays.stream(parameterTypes).map(ProxyGenerator::toClassDesc).toArray(ClassDesc[]::new));
On Fri, 5 Jan 2024 20:43:00 GMT, Mandy Chung wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackCounter fix
>
> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.j
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any comments and suggestions are welcome.
>
> Please review.
&
ClassFile API performance related improvements have been separated from #17121
into this PR.
These improvements are important to minimize performance regression of
8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the
Classfile API to generate proxy classes #17121
Please
On Wed, 3 Jan 2024 12:36:26 GMT, Adam Sotona wrote:
>> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy
>> classes.
>>
>> This patch converts it to use Classfile API.
>>
>> It is continuation of https://github.com/openjdk/jdk/pull/10991
On Sun, 7 Jan 2024 18:18:32 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> StackCounter fix
>
> src/java.base/share/classes/jdk/internal/classfile/impl/StackCount
On Fri, 5 Jan 2024 23:06:30 GMT, Chen Liang wrote:
>> Discovered while writing a test for #16513 that
>> `ClassSignature.superclassSignature()` does not return a `ClassTypeSig`, yet
>> [JVM
>> Spec](https://docs.oracle.com/javase/specs/jvms/se21/html/jvms-4.html#jvms-4.7.9.1-4100)
>>
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any comments and suggestions are welcome.
>
> Please review.
&
On Sun, 24 Dec 2023 03:14:44 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor StackCounter fix
>
> src/java.base/share/classes/java/lang/reflect/ProxyGene
On Sun, 24 Dec 2023 04:07:07 GMT, Chen Liang wrote:
>> This code is part of the **ClassFile API**’s internals, and so it doesn’t
>> have access to `ProxyGenerator`’s cached `MethodTypeDesc`s, only the
>> underlying `Utf8Entry`, so it’d need to be parsed.
>
> I see that now Class return type
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes.
>
> This patch converts it to use Classfile API.
>
> It is continuation of https://github.com/openjdk/jdk/pull/10991
>
> Any comments and suggestions are welcome.
>
> Please review.
&
On Thu, 7 Dec 2023 07:53:58 GMT, Adam Sotona wrote:
>> ClassFile API throws `IndexOutOfBoundsException` when classfile structure is
>> corrupted so the parser attempts to read beyond the classfile bounds.
>> General contract is that only `IllegalArgumentException`
On Tue, 21 Nov 2023 13:59:23 GMT, Adam Sotona wrote:
> ClassFile API throws `IndexOutOfBoundsException` when classfile structure is
> corrupted so the parser attempts to read beyond the classfile bounds.
> General contract is that only `IllegalArgumentException` or its subclasses is
&
On Tue, 2 Jan 2024 07:03:55 GMT, Jaikiran Pai wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'master' into JDK-8320360-bounds
>>
>&
his patch wraps `IndexOutOfBoundsExceptions` thrown from all
> `ClassReaderImpl.buffer` manipulations into an
> `IllegalArgumentException("Reading beyond classfile bounds", iOOBECause)`.
> Relevant tests are added.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona ha
On Tue, 2 Jan 2024 12:41:08 GMT, Adam Sotona wrote:
>> src/java.base/share/classes/jdk/internal/classfile/impl/ClassReaderImpl.java
>> line 283:
>>
>>> 281: public void copyBytesTo(BufWriter buf, int p, int len) {
>>> 282: try {
>>> 2
On Tue, 2 Jan 2024 07:05:22 GMT, Jaikiran Pai wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains three commits:
>>
>> - Merge branch 'master' into JDK-8320360-bounds
>>
>&
201 - 300 of 1034 matches
Mail list logo
