On Thu, 25 Jul 2024 08:40:44 GMT, Vanitha B P wrote:
>> tools/jpackage/windows/WinChildProcessTest.java was failing intermittently,
>> fixed the issue and changes are tested.
>
> Vanitha B P has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Wed, 24 Jul 2024 12:20:05 GMT, Vanitha B P wrote:
> tools/jpackage/windows/WinChildProcessTest.java was failing intermittently,
> fixed the issue and changes are tested.
Looks good. I will approve once comments from Alexey are resolved.
-
PR Comment:
On Tue, 9 Jul 2024 16:12:58 GMT, Vanitha B P wrote:
>> Created jtreg test case for
>> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>>
>> The JpackageTest created tests that the child process started from the app
>> launched by jpackage launcher is not automatically
On Wed, 3 Jul 2024 04:11:40 GMT, Vanitha B P wrote:
>> Created jtreg test case for
>> [JDK-8325203](https://bugs.openjdk.org/browse/JDK-8325203) issue.
>>
>> The JpackageTest created tests that the child process started from the app
>> launched by jpackage launcher is not automatically
On Tue, 4 Jun 2024 12:37:03 GMT, Alexey Semenyuk wrote:
> > I assume WiX5 will just work if installed instead of WiX4?
>
> Correct.
>
> > Do you think it will make sense to introduce Wix5 ToolsetType in case if we
> > need to do something different between 4 and 5?
>
> They claim WiX5 is
On Wed, 5 Jun 2024 14:53:09 GMT, Alexey Semenyuk wrote:
>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources.properties
>> line 44:
>>
>>> 42: resource.installdirnotemptydlg-wix-file=Not empty install directory
>>> dialog WiX project file
>>> 43:
On Tue, 4 Jun 2024 01:29:15 GMT, Alexey Semenyuk wrote:
> > Is there plan to add support for WiX 5?
>
> This patch supports WiX5 as well. There is not much difference between WiX4
> and WiX5 from jpackage perspective. I'll update the description
I assume WiX5 will just work if installed
On Mon, 3 Jun 2024 20:29:47 GMT, Alexey Semenyuk wrote:
> 8333452: Make logging in jdk.jpackage.internal.OverridableResource class
> configurable
OverridableResource uses Log.verbose, which will log if -verbose is specified.
What do you mean by "OverridableResource class unconditionally
On Fri, 31 May 2024 14:05:07 GMT, Alexey Semenyuk wrote:
> Fix MainClassTest class to use HelloApp.AppOutputVerifier class to run app
> launcher instead of raw Executor. This makes MainClassTest test run app
> launchers with retries. This change addresses the primary issue.
>
> Fix
On Fri, 31 May 2024 21:36:56 GMT, Nir Lisker wrote:
> I see, but it doesn't say where to put license files, which are usually in
> the root. Do you know where these belong?
No idea.
-
PR Comment: https://git.openjdk.org/jdk/pull/19377#issuecomment-2143025767
On Fri, 31 May 2024 20:43:45 GMT, Nir Lisker wrote:
> > > For your example. This almost seems like an Apple bug if you can add a
> > > directory to the Contents directory but not a file?
> >
> >
> > Not sure if it is an Apple bug.
>
> Can this be reported to Apple somehow?
I do not think
On Fri, 24 May 2024 01:08:03 GMT, Alexander Matveev
wrote:
> This issue is reproducible with and without `--mac-sign`. jpackage will
> "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by
> using pseudo-identity "_-_". This is why jpack
On Thu, 30 May 2024 14:21:51 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8332110: jpackage tries to sign added files without the --mac-sign option
>> [v
On Thu, 30 May 2024 20:10:05 GMT, Alexey Semenyuk wrote:
> - Get rid of DottedVersion#greedy field.
> - Add support to save the unrecognizable remainder of the version string
> (required to handle Wix4 version string).
> - Implement DottedVersion#equals().
> - add
On Thu, 30 May 2024 20:26:02 GMT, Alexey Semenyuk wrote:
> Change jpackage tests output from:
>
>
> [19:16:29.586] Create: SimplePackageTest.test
> [19:16:29.587] [ RUN ] SimplePackageTest.test
> [19:16:29.663] TRACE: Bundler rpm supported
> [19:16:29.674] TRACE: Actions: [[initialize],
On Thu, 30 May 2024 22:54:12 GMT, Alexander Matveev
wrote:
>> This issue is reproducible with and without `--mac-sign`. jpackage will
>> "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by
>> using pseudo-identity "_-_". This is
he application bundle and caused the failure. Ensure content
> supplied via the "--app-content" parameter does not break the integrity of
> the application bundle, or add it in the post-processing step.
> Error: "codesign" failed with following output:
> Test.app:
On Thu, 30 May 2024 20:26:02 GMT, Alexey Semenyuk wrote:
> Change jpackage tests output from:
>
>
> [19:16:29.586] Create: SimplePackageTest.test
> [19:16:29.587] [ RUN ] SimplePackageTest.test
> [19:16:29.663] TRACE: Bundler rpm supported
> [19:16:29.674] TRACE: Actions: [[initialize],
On Tue, 28 May 2024 20:13:24 GMT, Alexey Semenyuk wrote:
> Add missing "--add-opens jdk.jpackage/jdk.jpackage.internal=ALL-UNNAMED" to
> the test descriptor
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review:
On Fri, 24 May 2024 01:08:03 GMT, Alexander Matveev
wrote:
> This issue is reproducible with and without `--mac-sign`. jpackage will
> "_ad-hoc_" sign application bundle when `--mac-sign` is not specified by
> using pseudo-identity "_-_". This is why jpack
?
Yes, you already suggested it. See https://bugs.openjdk.org/browse/JDK-8318063
and it was closed as won’t fix because such verification is redundant.
Thanks,
Alexander
From: Michael Hall
Date: Friday, May 24, 2024 at 1:47 AM
To: Alexander Matveev
Cc: core-libs-dev
Subject: Re: RFR: 8332110
This issue is reproducible with and without `--mac-sign`. jpackage will
"_ad-hoc_" sign application bundle when `--mac-sign` is not specified by using
pseudo-identity "_-_". This is why jpackage tries to sign added files and this
is expected behavior by jpackage. "codesign" fails since added
On Tue, 30 Apr 2024 23:58:49 GMT, Alexey Semenyuk wrote:
> Rerun pandoc on updated source man page file
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/19028#pullrequestreview-2032839569
On Thu, 18 Apr 2024 19:56:43 GMT, Alexey Semenyuk wrote:
> Pass a path with resolved symlinks to `dpkg -S` command. If it fails, try the
> original path if they differ.
>
> Testing on Ubuntu 24.04 passed. Successfully created a .deb package from
> SwingSet2.jar with the not-empty list of
: Tuesday, March 5, 2024 at 8:50 AM
To: Michael Hall
Cc: Alexander Matveev , core-libs-dev@openjdk.org
Subject: Re: [External] : Re: jpackage requests permission via a dialog
I’m wondering whether some developers might prefer to arrange the DMG layout by
hand.
That would require jpackage to use
is right with “the
configuration of the DMG appearance actually means configuring the .DS_Store
file in the DMG”.
Thanks,
Alexander
From: Michael Hall
Date: Monday, March 4, 2024 at 7:44 PM
To: Alan Snyder
Cc: Alexander Matveev , core-libs-dev@openjdk.org
Subject: [External] : Re: jpackage requests
Hi Alan,
See below.
From: core-libs-dev on behalf of Alan Snyder
Date: Sunday, March 3, 2024 at 7:09 PM
To: core-libs-dev@openjdk.org
Subject: jpackage requests permission via a dialog
I tried using jpackage on macOS to create a DMG (which I have not done before)
and was surprised when a
On Thu, 8 Feb 2024 20:57:51 GMT, Alexey Semenyuk wrote:
> Tested with the use case from the CR.
>
> The idea of the fix is to prevent grandchildren processes from being
> automatically attached to the job killing all processes attached to it when
> the job object is destroyed.
>
> Filed a
On Wed, 17 Jan 2024 18:33:27 GMT, Alexey Semenyuk wrote:
> Clean backport
Looks good. I verified that it is a clean backport.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk22/pull/88#pullrequestreview-1828180526
On Thu, 11 Jan 2024 18:19:15 GMT, Alexey Semenyuk wrote:
> Change the full path of a unit file passed to `systemctl enable` command to
> the unit file name. This prevents the command from creating a symlink in
> `/etc/systemd/system/` directory
Marked as reviewed by almatvee (Reviewer).
On Thu, 11 Jan 2024 18:19:15 GMT, Alexey Semenyuk wrote:
> Change the full path of a unit file passed to `systemctl enable` command to
> the unit file name. This prevents the command from creating a symlink in
> `/etc/systemd/system/` directory
Fix looks good. I will approve once "Integration
On Wed, 13 Dec 2023 22:12:48 GMT, Alisen Chung wrote:
> Translation drop for JDK22 RDP1
jpackage part looks fine.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/17096#pullrequestreview-1780705685
On Mon, 4 Dec 2023 20:08:15 GMT, Alexey Semenyuk wrote:
> 8294699: Launcher causes lingering busy cursor
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16958#pullrequestreview-1763517307
On Thu, 30 Nov 2023 14:14:56 GMT, Alexey Semenyuk wrote:
> Add tests to make sure jpackage emits meaningful error messages when used
> with invalid app images.
>
> Added `JPackageCommand.nullableOutputBundle()` function that returns an empty
> `Optional` instance if it fails to deduce a path
On Tue, 28 Nov 2023 02:24:20 GMT, Alexander Matveev
wrote:
> Looks like the test timed out due to slow/loaded host. Failure log similar to
> [JDK-8296489](https://bugs.openjdk.org/browse/JDK-8296489) and
> [JDK-8298735](https://bugs.openjdk.org/browse/JDK-8298735). Fixed by
> inc
On Tue, 28 Nov 2023 08:51:17 GMT, Alan Bateman wrote:
> Update the jtreg test group configuration in the jdk test tree so that the
> jpackage tests run in tier3 rather than tier2.
>
> At this time, the jpackage tests run in jdk:tier2, more specifically
> jdk:tier2_part2 as part of the
Looks like the test timed out due to slow/loaded host. Failure log similar to
[JDK-8296489](https://bugs.openjdk.org/browse/JDK-8296489) and
[JDK-8298735](https://bugs.openjdk.org/browse/JDK-8298735). Fixed by increasing
test timeout.
-
Commit messages:
- 8320681: [macos] Test
On Thu, 23 Nov 2023 16:36:28 GMT, Alexey Semenyuk wrote:
> Fix uninstallation scripts in Linux installers to take action on desktop
> files only if these desktop files are not owned by another package. This
> prevents `xdg-mime uninstall`, `xdg-desktop-menu uninstall` commands from
>
On Fri, 24 Nov 2023 16:33:13 GMT, Alexey Semenyuk wrote:
> 8320706: RuntimePackageTest.testUsrInstallDir test fails on Linux
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16810#pullrequestreview-1751469146
On Fri, 24 Nov 2023 22:31:18 GMT, Alexey Semenyuk wrote:
>> 8320249: tools/jpackage/share/AddLauncherTest.java#id1 fails intermittently
>> on Windows in verifyDescription
>
> Alexey Semenyuk has updated the pull request incrementally with one
> additional commit since the last revision:
>
>
On Tue, 7 Nov 2023 03:20:45 GMT, Alexey Semenyuk wrote:
> Remove `-Xmx512m` from the jtreg `@run` command as @AlanBateman suggested
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/16535#pullrequestreview-1716751895
On Mon, 30 Oct 2023 19:43:32 GMT, Alexander Matveev
wrote:
> - Added LinkOption.NOFOLLOW_LINKS when copying pre-define runtime image.
> - Added test to cover this change.
> - Cleanup RuntimeImageTest.java by removing unused imports and removed
> incubator from jpackage module name
- Added LinkOption.NOFOLLOW_LINKS when copying pre-define runtime image.
- Added test to cover this change.
- Cleanup RuntimeImageTest.java by removing unused imports and removed
incubator from jpackage module name.
-
Commit messages:
- 8310933: Copying from runtime image to
On Fri, 6 Oct 2023 22:15:00 GMT, Alexander Matveev wrote:
> - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity`
> CLI options to jpackage to provide signing identity directly to `codesign`
> and `productbuild` tools as per CSR
> [JDK-8316631](https://bugs
On Fri, 20 Oct 2023 04:23:22 GMT, Alexander Matveev
wrote:
>> - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity`
>> CLI options to jpackage to provide signing identity directly to `codesign`
>> and `productbuild` tools as per CSR
>
On Fri, 20 Oct 2023 04:23:22 GMT, Alexander Matveev
wrote:
>> - Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity`
>> CLI options to jpackage to provide signing identity directly to `codesign`
>> and `productbuild` tools as per CSR
>
handling not to allow invalid combinations of signing options.
> - Updated signing tests to test new changes.
Alexander Matveev has updated the pull request incrementally with one
additional commit since the last revision:
8311877: [macos] Add CLI options to provide signing identity directly to
handling not to allow invalid combinations of signing options.
> - Updated signing tests to test new changes.
Alexander Matveev has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The
On Tue, 17 Oct 2023 07:04:03 GMT, yaqsun wrote:
>> on some RHEL Linux 8.X and Fedora 27 machines , we run into errors in test
>> tools/jpackage/linux/LinuxResourceTest.java.
>> It's the same problem as https://bugs.openjdk.org/browse/JDK-8314121.
>> But after 8314121,
- Added `--mac-app-image-sign-identity` and `--mac-installer-sign-identity` CLI
options to jpackage to provide signing identity directly to `codesign` and
`productbuild` tools as per CSR
[JDK-8316631](https://bugs.openjdk.org/browse/JDK-8316631).
- If `codesign` or `productbuild` fails, then
On Thu, 28 Sep 2023 23:38:51 GMT, Alexey Semenyuk wrote:
> - Don't run osx specific checks on Linux and Windows
> - Rework checks output from
>
> [17:31:52.845] TRACE: assertTrue(): Unexptected value in app image file for
>
> [17:31:52.860] TRACE: assertTrue(): Unexptected value in app
On Thu, 28 Sep 2023 20:58:30 GMT, Alexey Semenyuk wrote:
> Don't use JDK image from `$JAVA_HOME` as a value of `--runtime-image`
> jpackage cli option. Use jlink to create a runtime in test work dir if the
> default runtime is not specified and pass the location of jlink output.
Looks good.
On Tue, 26 Sep 2023 12:20:55 GMT, Matthias Baesken wrote:
>> AIX currently does not have the jdk.jpackage system module. We have to take
>> this into account for these jpackage tests.
>
> Matthias Baesken has updated the pull request incrementally with one
> additional commit since the last
On Tue, 19 Sep 2023 20:15:20 GMT, Alexey Semenyuk wrote:
> Strip
>
> /*
> * @test
> * @modules jdk.jpackage
> * @compile --patch-module jdk.jpackage=${test.src} --add-reads
> jdk.jpackage=ALL-UNNAMED --add-exports
> jdk.jpackage/jdk.jpackage.internal=ALL-UNNAMED AppImageFileTest.java
> *
On Fri, 15 Sep 2023 13:32:39 GMT, Alexey Semenyuk wrote:
>> On Windows, restart app launcher in a way that when the parent app launcher
>> process terminates, the child app launcher process is automatically
>> terminated.
>
> Alexey Semenyuk has updated the pull request incrementally with two
On Fri, 15 Sep 2023 15:40:25 GMT, Alexey Semenyuk wrote:
> Run jpackage jtreg tests on Windows sequentially. Asynch execution of
> `msiexec.exe` that unpacks msi files doesn't work well.
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review:
Hi Michael,
On Aug 22, 2023, at 11:33 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Aug 22, 2023, at 9:40 PM, Alan Snyder
mailto:javali...@cbfiddle.com>> wrote:
On Aug 22, 2023, at 4:42 PM, Alexander Matveev
mailto:alexander.matv...@oracle.com>> wrote:
Hi Alan
Hi Alan,
On Aug 22, 2023, at 7:40 PM, Alan Snyder
mailto:javali...@cbfiddle.com>> wrote:
On Aug 22, 2023, at 4:42 PM, Alexander Matveev
mailto:alexander.matv...@oracle.com>> wrote:
Hi Alan,
On Aug 22, 2023, at 3:35 PM, Alan Snyder
mailto:javali...@cbfiddle.com>> wr
On Tue, 22 Aug 2023 21:59:50 GMT, Alexander Matveev
wrote:
> - Added support for certificates with UNICODE characters.
> - Added new approach to find certificate using "security" and "openssl"
> commands. Just "security" does not works, since it can t
Alexander
>
>> On Aug 22, 2023, at 3:15 PM, Alexander Matveev wrote:
>>
>> - Added support for certificates with UNICODE characters.
>> - Added new approach to find certificate using "security" and "openssl"
>> commands. Just "secu
- Added support for certificates with UNICODE characters.
- Added new approach to find certificate using "security" and "openssl"
commands. Just "security" does not works, since it can truncate certificates
name. "security" is used to dump certificate in PEM format and then "openssl"
to get
On Thu, 10 Aug 2023 22:58:18 GMT, Alexander Matveev
wrote:
> - This is regression from
> [JDK-8298488](https://bugs.openjdk.org/browse/JDK-8298488).
> - Since JDK-8298488 unsigned app bundles are ad-hoc signed and `codesign`
> will report that app bundle is signed and thus our
Hi Michael,
On Aug 10, 2023, at 10:48 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
I assume done with jpackage by indicating something like —mac-sign only? If
wrong feel free to correct.
No, it is always done if —mac-sign is NOT specified and we doing ad-hoc signing
on app bundle
Hi Michael,
On Aug 10, 2023, at 6:11 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Aug 10, 2023, at 6:35 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Aug 10, 2023, at 6:21 PM, Alexander Matveev
mailto:almat...@openjdk.org>> wrote:
- Fixed tests by
- This is regression from
[JDK-8298488](https://bugs.openjdk.org/browse/JDK-8298488).
- Since JDK-8298488 unsigned app bundles are ad-hoc signed and `codesign` will
report that app bundle is signed and thus our tests failed.
- Fixed tests by checking that all app bundles are signed and by
On Wed, 26 Jul 2023 18:42:47 GMT, Alexey Semenyuk wrote:
> 8311104: dangling-gsl warning in libwixhelper.cpp
Looks good.
-
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/15044#pullrequestreview-1548666131
On Wed, 26 Jul 2023 18:42:47 GMT, Alexey Semenyuk wrote:
> 8311104: dangling-gsl warning in libwixhelper.cpp
src/jdk.jpackage/windows/native/libwixhelper/libwixhelper.cpp line 75:
> 73: void findInstalledProducts(const Guid& upgradeCode,
> 74:
On Sat, 22 Jul 2023 21:41:06 GMT, Vladimir Petko wrote:
>> Use the same approach as Logger::defaultLogger() to ensure that the
>> appender is not destroyed before shared object destructor function is
>> executed.
>>
>> The alternative is to delete dcon() function, but we might run into a
>>
On Fri, 21 Jul 2023 10:55:13 GMT, Vladimir Petko wrote:
> Use the same approach as Logger::defaultLogger() to ensure that the appender
> is not destroyed before shared object destructor function is executed.
>
> The alternative is to delete dcon() function, but we might run into a
> similiar
On Thu, 20 Jul 2023 02:04:53 GMT, Alexey Semenyuk wrote:
>> [JDK-8309032](https://bugs.openjdk.org/browse/JDK-8309032),
>> [JDK-8306488](https://bugs.openjdk.org/browse/JDK-8306488)
>
> @sashamatveev would you like to review the change before I sponsor it?
@alexeysemenyukoracle Looks good.
On Tue, 11 Jul 2023 23:47:30 GMT, airsquared wrote:
> [JDK-8309032](https://bugs.openjdk.org/browse/JDK-8309032),
> [JDK-8306488](https://bugs.openjdk.org/browse/JDK-8306488)
Marked as reviewed by almatvee (Reviewer).
-
PR Review:
On Mon, 15 May 2023 22:51:52 GMT, Roger Riggs wrote:
>> Refactor the Platform class in jdk.jpackage to use the internal
>> OperatingSystem, Architecture, and Version classes.
>> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace
>> comparisons in the Platform class.
>> The
On Mon, 15 May 2023 20:10:38 GMT, Roger Riggs wrote:
>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/CLIHelp.java line 51:
>>
>>> 49: Log.info(I18N.getString("MSG_Help_no_args"));
>>> 50: } else {
>>> 51: OperatingSystem platform =
On Fri, 5 May 2023 14:12:21 GMT, Roger Riggs wrote:
>> Refactor the Platform class in jdk.jpackage to use the internal
>> OperatingSystem, Architecture, and Version classes.
>> The OperatingSystem.isXXX() and Architecture.isYYY() methods replace
>> comparisons in the Platform class.
>> The
On Mon, 10 Apr 2023 21:16:19 GMT, Alexey Semenyuk wrote:
> When `--main-jar` is specified and the name of the main class is picked from
> the jar's manifest, set `app.jarfile` property in launcher cfg file instead
> of `app.mainclass` and `app.classpath` properties to make app launcher run
>
On Mon, 13 Mar 2023 16:50:51 GMT, Alexander Matveev
wrote:
> This is similar to many other issues we had with `hdiutil` failures. Fixed in
> similar way by repeating `hdiutil` command. Cannot confirm that it will
> resolve this issue, but similar issues got resolved by repeatin
This is similar to many other issues we had with `hdiutil` failures. Fixed in
similar way by repeating `hdiutil` command. Cannot confirm that it will resolve
this issue, but similar issues got resolved by repeating command. Also,
switched writing output from `hdiutil` to file. It is known issue
On Thu, 16 Mar 2023 09:08:08 GMT, Matthias Baesken wrote:
>> The test fails on Alpine Linux 3.17, when checking the environment variable
>> LD_LIBRARY_PATH; looks like the actual env variable is much longer than the
>> test expects. It turned out that at least on Linux (probably also on other
On Tue, 7 Mar 2023 00:56:02 GMT, Alexander Matveev wrote:
> - Fixed by increasing test timeout. Fix verified on host which reproduced
> issue.
This pull request has now been integrated.
Changeset: 0a4d54f7
Author:Alexander Matveev
URL:
https://git.openjdk.org/jdk/
- Fixed by increasing test timeout. Fix verified on host which reproduced issue.
-
Commit messages:
- 8299779: Test tools/jpackage/share/jdk/jpackage/tests/MainClassTest.java
timed out
Changes: https://git.openjdk.org/jdk/pull/12896/files
Webrev:
On Mon, 9 Jan 2023 22:53:18 GMT, Alexey Semenyuk wrote:
> Increase failed test timeouts.
> Simple tests got an x1.5 increase and parametrized tests got an x2 increase
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11914
On Thu, 5 Jan 2023 20:10:45 GMT, Alexey Semenyuk wrote:
> 8299278: tools/jpackage/share/AddLauncherTest.java#id1 failed
> AddLauncherTest.bug8230933
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11868
On Fri, 16 Dec 2022 03:38:54 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert old translation. Fix lang codes
jpackage changes looks good.
On Fri, 16 Dec 2022 00:24:26 GMT, Damon Nguyen wrote:
>> src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/WinResources_ja.properties
>> line 37:
>>
>>> 35:
>>>
On Fri, 16 Dec 2022 00:15:51 GMT, Damon Nguyen wrote:
>> src/jdk.jpackage/share/classes/jdk/jpackage/internal/resources/MainResources_de.properties
>> line 82:
>>
>>> 80:
>>> 81: error.foreign-app-image=Fehler: .jpackage.xml-Datei fehlt in
>>> app-image-Verzeichnis ({0})
>>> 82:
On Thu, 15 Dec 2022 23:01:35 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert double quote as well
On Thu, 15 Dec 2022 20:43:42 GMT, Damon Nguyen wrote:
>> Open l10n drop
>> All tests passed
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Fix https and changed URL back
On Mon, 12 Dec 2022 21:23:50 GMT, Alexander Matveev
wrote:
> This issue is similar to JDK-8277493. Looks like macOS 13 cannot execute
> unsigned code and code should be at least ad hoc signed. Same as for macOS
> aarch64. Fixed by enabling ad hoc signing for macOS platform for
This issue is similar to JDK-8277493. Looks like macOS 13 cannot execute
unsigned code and code should be at least ad hoc signed. Same as for macOS
aarch64. Fixed by enabling ad hoc signing for macOS platform for both x64 and
aarch64.
-
Commit messages:
- 8298488: [macos13]
On Mon, 5 Dec 2022 22:14:50 GMT, Alexey Semenyuk wrote:
> - throw an exception if icon swap fails with the corresponding l10n message;
> - add retries to the jpackage test routine that extracts an icon from a
> launcher
Marked as reviewed by almatvee (Reviewer).
-
PR:
On Mon, 5 Dec 2022 22:20:19 GMT, Alexey Semenyuk wrote:
> Simply increase timeout limit to make test pass on slower/loaded hosts
Marked as reviewed by almatvee (Reviewer).
-
PR: https://git.openjdk.org/jdk/pull/11522
On Wed, 9 Nov 2022 20:02:05 GMT, Alexander Matveev wrote:
> Additional DMG content will be arranged in raws with 3 items per raw. DMG
> windows will be resized to show one or two raws without any scrolling
> required. To see any additional content after two raws (7 or more it
Additional DMG content will be arranged in raws with 3 items per raw. DMG
windows will be resized to show one or two raws without any scrolling required.
To see any additional content after two raws (7 or more items) user will need
to use vertical scroll bar. See JBS for screen shots.
On Fri, 4 Nov 2022 23:26:00 GMT, Alexander Matveev wrote:
> Changed names of symbolic links for drag and drop location in DMG image. See
> attached images in JBS.
> "/Applications" -> "Applications" for app DMG image.
> "/Library/Java/JavaVirtualMachin
On Fri, 4 Nov 2022 23:44:15 GMT, Alexey Semenyuk wrote:
>> Alexander Matveev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8296154: [macos] Change /Applications to Applications in DMG image [v2]
>
> src/j
ime DMG
> image.
>
> Automated test was not added, since DMGsetup.scpt is not getting executed in
> headless environment and thus symbolic links are not created during automated
> testing.
Alexander Matveev has updated the pull request incrementally with one
additional commit since th
Changed names of symbolic links for drag and drop location in DMG image. See
attached images in JBS.
"/Applications" -> "Applications" for app DMG image.
"/Library/Java/JavaVirtualMachines" -> "JavaVirtualMachines" for runtime DMG
image.
Automated test was not added, since DMGsetup.scpt is not
Hi Michael.
If you mean http://mikehall.pairserver.com/DMG_windows.dmg, then I cannot open
this link. It says file not found.
Thanks,
Alexander
On Oct 31, 2022, at 4:21 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Oct 31, 2022, at 5:56 PM, Alexander Matveev
mailto:alexande
Hi Michael,
On Oct 31, 2022, at 2:40 PM, Michael Hall
mailto:mik3h...@gmail.com>> wrote:
On Oct 31, 2022, at 4:17 PM, Alexander Matveev
mailto:alexander.matv...@oracle.com>> wrote:
Hi Michael,
Hello Alexander,
If I understood correctly you asking for several things
Hi Michael,
If I understood correctly you asking for several things:
1) Change “/Applications” to “Applications”. I agree and we should fix it if
possible. Did you file a bug for it? If not I can file.
2) Resize DMG window to show additional content which was added via
--mac-dmg-content, so
1 - 100 of 141 matches
Mail list logo
